1. 26 Oct, 2009 19 commits
    • eric@webkit.org's avatar
      2009-10-26 Kelly Norton <knorton@google.com> · bf3b5969
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Adds DOMTimer support to InspectorTimelineAgent.
              https://bugs.webkit.org/show_bug.cgi?id=30467
      
              * inspector/InspectorTimelineAgent.cpp: Added timer support and fixed some method names.
              (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
              (WebCore::InspectorTimelineAgent::didLayout):
              (WebCore::InspectorTimelineAgent::didRecalculateStyle):
              (WebCore::InspectorTimelineAgent::didPaint):
              (WebCore::InspectorTimelineAgent::didWriteHTML):
              (WebCore::InspectorTimelineAgent::didInstallTimer): Added.
              (WebCore::InspectorTimelineAgent::didRemoveTimer): Added.
              (WebCore::InspectorTimelineAgent::willFireTimer): Added.
              (WebCore::InspectorTimelineAgent::didFireTimer): Added.
              (WebCore::InspectorTimelineAgent::addItemToTimeline): Added.
              (WebCore::InspectorTimelineAgent::didCompleteCurrentTimelineItem): Renamed.
              * inspector/InspectorTimelineAgent.h:
              (WebCore::):
              * inspector/TimelineItemFactory.cpp: Add methods for timer-related ScriptObjects.
              (WebCore::TimelineItemFactory::createGenericTimerTimelineItem):
              (WebCore::TimelineItemFactory::createTimerInstallTimelineItem):
              * inspector/TimelineItemFactory.h:
              * page/DOMTimer.cpp: Added instrumentation points.
              (WebCore::DOMTimer::install):
              (WebCore::DOMTimer::removeById):
              (WebCore::DOMTimer::fired):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf3b5969
    • simon.fraser@apple.com's avatar
      2009-10-26 Simon Fraser <simon.fraser@apple.com> · 8110a530
      simon.fraser@apple.com authored
              Reviewed by Sam Weinig.
      
              <rdar://problem/6988966> Hardware layers do not show up in page snapshots
      
              * WebView/WebHTMLViewPrivate.h:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _compositingLayersHostingView]):
              Add a private method that returns the NSView used to host compositing layers.
      
              * platform/graphics/mac/Canvas3DLayer.h:
              * platform/graphics/mac/Canvas3DLayer.mm:
              (-[Canvas3DLayer copyImageSnapshotWithColorSpace:]):
              Add a method that gets called when snapshotting Canvas3DLayers for page snapshots,
              that allows the layer to return a CGImageRef of its contents.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8110a530
    • ossy@webkit.org's avatar
      [Qt] Update outdated expected files which expected wrong color values. · 940afb7e
      ossy@webkit.org authored
      Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-10-26
      Reviewed by Ariya Hidayat.
      
      * platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
      * platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
      * platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
      * platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
      * platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
      * platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50066 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      940afb7e
    • eric@webkit.org's avatar
      2009-10-26 Yury Semikhatsky <yurys@chromium.org> · 32ed8b46
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Pass "console" as object group when evaluating selection.
      
              https://bugs.webkit.org/show_bug.cgi?id=30738
      
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50065 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32ed8b46
    • eric@webkit.org's avatar
      2009-10-26 Keishi Hattori <casey.hattori@gmail.com> · 3cf653ff
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Fix for Console not showing repeat count when repeatedly logging an Event
              https://bugs.webkit.org/show_bug.cgi?id=30324
      
              * inspector/console-tests-expected.txt:
      2009-10-26  Keishi Hattori  <casey.hattori@gmail.com>
      
              Reviewed by Pavel Feldman.
      
              Fix for Console not showing repeat count when repeatedly logging an Event
              https://bugs.webkit.org/show_bug.cgi?id=30324
      
              * inspector/ConsoleMessage.cpp:
              (WebCore::ConsoleMessage::addToConsole):
              (WebCore::ConsoleMessage::updateRepeatCountInConsole): Added.
              * inspector/ConsoleMessage.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::addConsoleMessage): Calls updateRepeatCountInConsole if it is a repeating message.
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::addConsoleMessage): Renamed WebCore::InspectorFrontend::addMessageToConsole
              (WebCore::InspectorFrontend::updateConsoleMessageRepeatCount): Added. Called when repeatCount is incremented.
              * inspector/InspectorFrontend.h:
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype.addMessage): Removed calls to msg.isEqual.
              (WebInspector.ConsoleView.prototype.updateMessageRepeatCount): Added.
              (WebInspector.ConsoleView.prototype._incrementErrorWarningCount): Added. Updates the error/warning count.
              (WebInspector.ConsoleView.prototype.clearMessages):
              (WebInspector.ConsoleMessage):
              (WebInspector.ConsoleMessage.prototype.toMessageElement): Use ConsoleMessage._updateRepeatCount
              (WebInspector.ConsoleMessage.prototype._updateRepeatCount):
              * inspector/front-end/inspector.js:
              (WebInspector.addConsoleMessage): Renamed WebInspector.addMessageToConsole.
              (WebInspector.updateConsoleMessageRepeatCount): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3cf653ff
    • eric.carlson@apple.com's avatar
      2009-10-26 Eric Carlson <eric.carlson@apple.com> · 137b4da5
      eric.carlson@apple.com authored
              Reviewed by Eric Seidel.
      
              Remove HTML5 media element 'load' event
              https://bugs.webkit.org/show_bug.cgi?id=30464
              
              Part 1, change layout tests to not use the event.
      
              * media/audio-constructor-autobuffer-expected.txt:
              * media/audio-constructor-autobuffer.html:
              * media/audio-constructor-expected.txt:
              * media/audio-constructor-src-expected.txt:
              * media/audio-constructor-src.html:
              * media/audio-constructor.html:
              * media/audio-controls-rendering.html:
              * media/audio-data-url-expected.txt:
              * media/audio-data-url.html:
              * media/audio-mpeg-supported-expected.txt:
              * media/audio-mpeg-supported.html:
              * media/media-load-event-expected.txt:
              * media/media-load-event.html:
              * media/progress-event-expected.txt:
              * media/progress-event-total-expected.txt:
              * media/progress-event-total.html:
              * media/progress-event.html:
              * media/remove-from-document-expected.txt:
              * media/remove-from-document-no-load-expected.txt:
              * media/remove-from-document-no-load.html:
              * media/remove-from-document.html:
              * media/restore-from-page-cache-expected.txt:
              * media/restore-from-page-cache.html:
              * media/video-append-source-expected.txt:
              * media/video-append-source.html:
              * media/video-buffered-expected.txt:
              * media/video-buffered.html:
              * media/video-canvas-source-expected.txt:
              * media/video-canvas-source.html:
              * media/video-controls-expected.txt:
              * media/video-controls-transformed-expected.txt:
              * media/video-controls-transformed.html:
              * media/video-controls-zoomed-expected.txt:
              * media/video-controls-zoomed.html:
              * media/video-controls.html:
              * media/video-currentTime-expected.txt:
              * media/video-currentTime-set-expected.txt:
              * media/video-currentTime-set.html:
              * media/video-currentTime-set2-expected.txt:
              * media/video-currentTime-set2.html:
              * media/video-currentTime.html:
              * media/video-dom-src-expected.txt:
              * media/video-dom-src.html:
              * media/video-error-abort-expected.txt:
              * media/video-error-abort.html:
              * media/video-error-does-not-exist.html:
              * media/video-muted-expected.txt:
              * media/video-muted.html:
              * media/video-no-autoplay-expected.txt:
              * media/video-no-autoplay.html:
              * media/video-seek-past-end-paused-expected.txt:
              * media/video-seek-past-end-paused.html:
              * media/video-seek-past-end-playing-expected.txt:
              * media/video-seek-past-end-playing.html:
              * media/video-seekable-expected.txt:
              * media/video-seekable.html:
              * media/video-seeking-expected.txt:
              * media/video-seeking.html:
              * media/video-src-change-expected.txt:
              * media/video-src-change.html:
              * media/video-volume-expected.txt:
              * media/video-volume.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      137b4da5
    • cfleizach@apple.com's avatar
      crash with AX on when an image map contains an anchor tag · 415cfd7a
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30739
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      Tests: accessibility/crashing-a-tag-in-map.html
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::addChildren):
      
      LayoutTests: 
      
      * accessibility/crashing-a-tag-in-map-expected.txt: Added.
      * accessibility/crashing-a-tag-in-map.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      415cfd7a
    • kov@webkit.org's avatar
      2009-10-26 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 9d815fa1
      kov@webkit.org authored
              Unreviewed. Update documentation control files for 1.1.16.
      
              * docs/webkitgtk-docs.sgml:
              * docs/webkitgtk-sections.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50061 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d815fa1
    • kov@webkit.org's avatar
      Reviewed by Xan Lopez. · 96b5f19b
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=30759
      [GTK] Should use WebKitNetworkResponse, and expose it
      
      WebKitDownload now uses our WebKitNetworkResponse instead of using
      ResourceResponse directly. By exposing the response, like we do
      with the request, we give our users the ability to look at the
      response headers, status code, and so on, through the SoupMessage
      object.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50060 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96b5f19b
    • xan@webkit.org's avatar
      2009-10-26 Xan Lopez <xlopez@igalia.com> · 17381bdc
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Update for 1.1.16 release.
      
              * configure.ac:
      
      WebKit/gtk:
      
      2009-10-26  Xan Lopez  <xlopez@igalia.com>
      
              Reviewed by Gustavo Noronha.
      
              Update for 1.1.16 release.
      
              * NEWS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50059 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17381bdc
    • eric@webkit.org's avatar
      2009-10-26 Benjamin Poulain <benjamin.poulain@nokia.com> · fb528d62
      eric@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              [Qt] Reintroduce QWebElementCollection
      
              Revert the patch that has replaced QWebElementCollection
              with QList<QWebElement>. Update the tests accordingly.
      
              Remove the constness of the return type of QWebElement operator[].
      
              https://bugs.webkit.org/show_bug.cgi?id=30767
      
              * Api/qwebelement.cpp:
              (QWebElement::findAll):
              (QWebElementCollectionPrivate::QWebElementCollectionPrivate):
              (QWebElementCollectionPrivate::create):
              (QWebElementCollection::QWebElementCollection):
              (QWebElementCollection::operator=):
              (QWebElementCollection::~QWebElementCollection):
              (QWebElementCollection::operator+):
              (QWebElementCollection::append):
              (QWebElementCollection::count):
              (QWebElementCollection::at):
              (QWebElementCollection::toList):
              * Api/qwebelement.h:
              (const_iterator::begin):
              (const_iterator::end):
              (const_iterator::operator[]):
              * Api/qwebframe.cpp:
              (QWebFrame::findAllElements):
              * Api/qwebframe.h:
              * QtLauncher/main.cpp:
              (MainWindow::selectElements):
              * tests/qwebelement/tst_qwebelement.cpp:
              (tst_QWebElement::simpleCollection):
              (tst_QWebElement::iteration):
              (tst_QWebElement::emptyCollection):
              (tst_QWebElement::appendCollection):
              (tst_QWebElement::nullSelect):
              (tst_QWebElement::hasSetFocus):
              (tst_QWebElement::render):
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::inputMethods):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb528d62
    • benm@google.com's avatar
      Adds feature ENABLE guards to V8 bindings. · 84b693f5
      benm@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30697
      
      Patch by Steve Block <steveblock@google.com> on 2009-10-26
      Reviewed by Eric Seidel.
      
      This adds guards for the following features to the V8 bindings,
      to allow builds with V8 to succeed when these features are not enabled.
      - DATABASE
      - WORKERS
      - SHARED_WORKERS
      - SVG
      - XPATH
      - XSLT
      - INSPECTOR
      
      This is a build fix only, no new tests required.
      
      * bindings/v8/DOMObjectsInclude.h: Modified.
      * bindings/v8/DerivedSourcesAllInOne.cpp: Modified.
      * bindings/v8/V8Index.cpp: Modified.
      * bindings/v8/V8Index.h: Modified.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84b693f5
    • ossy@webkit.org's avatar
      Rubber-stamped by Tor Arne Vestbø. · 0627c419
      ossy@webkit.org authored
      Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
      http/tests/cookies/simple-cookies-max-age.html moved to flakey tests group.
      http/tests/xmlhttprequest/workers/close.html added to flakey tests group.
      
      * platform/qt/Skipped: 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0627c419
    • ossy@webkit.org's avatar
      Unreviewed trivial fix for r49854. · 17aff386
      ossy@webkit.org authored
      Patch by Csaba Osztrogonác <ossy@webkit.org> on 2009-10-26
      * platform/qt/Skipped: Missing html extension added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17aff386
    • eric@webkit.org's avatar
      2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com> · 2dd4734e
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              https://bugs.webkit.org/show_bug.cgi?id=25679
              [Gtk] Improve accessibility of focusable lists
      
              Fixes the issues with the Atk states exposed for ListBoxOption
      
              * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
              (setAtkStateSetFromCoreObject):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dd4734e
    • eric@webkit.org's avatar
      2009-10-26 Joanmarie Diggs <joanmarie.diggs@gmail.com> · 9e4b9729
      eric@webkit.org authored
              Reviewed by Xan Lopez.
      
              https://bugs.webkit.org/show_bug.cgi?id=27085
              [Gtk] Incorrect rendering of list
      
              Adds a way for platforms to indicate that a particular object
              should not be ignored.
      
              * accessibility/AccessibilityObject.h:
              * accessibility/chromium/AccessibilityObjectChromium.cpp:
              * accessibility/gtk/AccessibilityObjectAtk.cpp:
              * accessibility/mac/AccessibilityObjectMac.mm:
              * accessibility/qt/AccessibilityObjectQt.cpp:
              * accessibility/win/AccessibilityObjectWin.cpp:
              * accessibility/wx/AccessibilityObjectWx.cpp:
              (AccessibilityObject::accessibilityPlatformIncludesObject):
              * accessibility/AccessibilityRenderObject.cpp:
              (AccessibilityRenderObject::accessibilityIsIgnored):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e4b9729
    • eric@webkit.org's avatar
      2009-10-26 Steve Block <steveblock@google.com> · b461c379
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Adds ability to disable ReadWriteLock on platforms (eg Android) that use pthreads but do not support pthread_rwlock.
              https://bugs.webkit.org/show_bug.cgi?id=30713
      
              * wtf/Platform.h: Modified. Defines HAVE_PTHREAD_RWLOCK for all platforms currently using pthreads.
              * wtf/Threading.h: Modified. Use pthread_rwlock_t only when HAVE_PTHREAD_RWLOCK is defined.
              * wtf/ThreadingPthreads.cpp: Modified. Build ReadWriteLock methods only when HAVE_PTHREAD_RWLOCK is defined.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b461c379
    • eric@webkit.org's avatar
      2009-10-26 Kinuko Yasuda <kinuko@google.com> · 4738c682
      eric@webkit.org authored
              Reviewed by Jan Alonzo.
      
              Bug 30619: [Linux] Menu key doesn't work
              https://bugs.webkit.org/show_bug.cgi?id=30619
      
              Test: manual-tests/keyboard-menukey-event.html
              No new layout tests: testing this will require changes in the test
              controller in a platform-specific way.
      
              * platform/chromium/KeyCodeConversionGtk.cpp:
              (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
              GDK_Menu to return VKEY_APPS instead of VKEY_MENU.
              * platform/gtk/KeyEventGtk.cpp:
              (WebCore::windowsKeyCodeForKeyEvent): changed switch-case code for
              GDK_Menu to return V_APPS instead of VK_MENU.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4738c682
    • jmalonzo@webkit.org's avatar
      2009-10-26 Jan Michael Alonzo <jmalonzo@webkit.org> · 42dab9ba
      jmalonzo@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [Gtk] Reenable mod_rewrite in Fedora's httpd.conf
              https://bugs.webkit.org/show_bug.cgi?id=30741
      
              * http/conf/fedora-httpd.conf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42dab9ba
  2. 25 Oct, 2009 10 commits
  3. 24 Oct, 2009 11 commits
    • timothy@apple.com's avatar
      WebInspector: Fixed issue with IME inside console · b149bc94
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30660
      
      Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-24
      Reviewed by Timothy Hatcher.
      
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView.prototype._promptKeyDown):
      * inspector/front-end/DatabaseQueryView.js:
      (WebInspector.DatabaseQueryView.prototype._promptKeyDown):
      * inspector/front-end/inspector.js:
      (WebInspector.loaded):
      (WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp.
      (WebInspector.startEditing.element.handleKeyEvent):
      (WebInspector.startEditing):
      * inspector/front-end/utilities.js:
      (isEnterKey): Added. Check if in IME.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b149bc94
    • bweinstein@apple.com's avatar
      Fixes <https://bugs.webkit.org/show_bug.cgi?id=30752>. · c9bfaf07
      bweinstein@apple.com authored
      Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX.
              
      Reviewed by Timothy Hatcher.
      
      Have the scope bars select one scope by default, but if the multiple selection key
      is pressed, allow for multiple selection.
      
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView):
      (WebInspector.ConsoleView.prototype._updateFilter):
      (WebInspector.ConsoleView.prototype.filter):
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel):
      (WebInspector.ResourcesPanel.prototype.filter):
      (WebInspector.ResourcesPanel.prototype._updateFilter):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9bfaf07
    • weinig@apple.com's avatar
      WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751 · 6f70676f
      weinig@apple.com authored
      HTMLOptionsCollection should not inherit from HTMLCollection
      
      Reviewed by Dan Bernstein.
      
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      Added JSHTMLCollectionFunctions.h
      
      * bindings/js/JSHTMLAllCollectionCustom.cpp:
      (WebCore::callHTMLAllCollection):
      (WebCore::JSHTMLAllCollection::nameGetter):
      (WebCore::JSHTMLAllCollection::item):
      (WebCore::JSHTMLAllCollection::namedItem):
      * bindings/js/JSHTMLCollectionCustom.cpp:
      (WebCore::callHTMLCollection):
      (WebCore::JSHTMLCollection::nameGetter):
      (WebCore::JSHTMLCollection::item):
      (WebCore::JSHTMLCollection::namedItem):
      * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
      (WebCore::callHTMLCollection):
      (WebCore::JSHTMLOptionsCollection::getCallData):
      (WebCore::JSHTMLOptionsCollection::canGetItemsForName):
      (WebCore::JSHTMLOptionsCollection::nameGetter):
      (WebCore::JSHTMLOptionsCollection::indexSetter):
      (WebCore::JSHTMLOptionsCollection::item):
      (WebCore::JSHTMLOptionsCollection::namedItem):
      Refactor to use generic implementation of HTMLCollection bindings functions
      from JSHTMLCollectionFunctions.h
      
      * bindings/js/JSHTMLCollectionFunctions.h: Added.
      (WebCore::getCollectionNamedItems):
      (WebCore::getCollectionItems):
      (WebCore::callHTMLCollectionGeneric):
      Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
      JSHTMLOptionsCollection can all use.
      
      * bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h
      for toJS on document.all.
      
      * bindings/objc/DOMHTML.mm:
      * bindings/objc/DOMUtility.mm:
      (JSC::createDOMWrapper):
      Remove special cases for HTMLOptionsCollection.
      
      * bindings/scripts/CodeGeneratorJS.pm:
      * html/HTMLAllCollection.idl:
      * html/HTMLCollection.idl:
      * html/HTMLOptionsCollection.idl:
      
      LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
      HTMLOptionsCollection should not inherit from HTMLCollection
      
      Reviewed by Dan Bernstein.
      
      * fast/dom/wrapper-classes-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f70676f
    • timothy@apple.com's avatar
      Make the scope bars in the Web Inspector match other scope bars in Mac OS X. · e5458b88
      timothy@apple.com authored
      Also cleans up the CSS to use classes instead of ID selectors.
      
      https://bugs.webkit.org/show_bug.cgi?id=28186
      
      Reviewed by Dan Bernstein.
      
      * inspector/front-end/ResourcesPanel.js: Add the scope-bar class.
      * inspector/front-end/inspector.css: Lots of changes to make it look right.
      * inspector/front-end/inspector.html: Add the scope-bar class.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5458b88
    • timothy@apple.com's avatar
      Fix selecting Resources in the Web Inspector's Resources panel. · 0fd7ad7d
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30743
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added.
      (WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call
      isCategoryVisible on the ResourcesPanel.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fd7ad7d
    • timothy@apple.com's avatar
      Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting · 36cbe8c7
      timothy@apple.com authored
      All will deselect the other filters.
      
      https://bugs.webkit.org/show_bug.cgi?id=30744
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.createFilterElement): Better syntax.
      (WebInspector.ResourcesPanel):
      (WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop,
      and the child variable instead of target in the loop. Other clean up.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36cbe8c7
    • timothy@apple.com's avatar
      Make resizing the Web Inspector's Elements panel sidebar work again. · fe8ddd65
      timothy@apple.com authored
      Also makes Resources panel use the sidebar code in Panel.
      
      https://bugs.webkit.org/show_bug.cgi?id=30742
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/Panel.js:
      (WebInspector.Panel): Don't create the sidebar with an argument.
      (WebInspector.Panel.prototype.show): Call updateSidebarWidth.
      (WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent.
      (WebInspector.Panel.prototype.handleSidebarKeyEvent): Added.
      (WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar.
      (WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth.
      (WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth.
      (WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth.
      (WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
      * inspector/front-end/ProfilesPanel.js:
      (WebInspector.ProfilesPanel): Call createSidebar.
      (WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth.
      (WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth
      (WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto.
      (WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added.
      (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added.
      * inspector/front-end/StoragePanel.js:
      (WebInspector.StoragePanel): Call createSidebar.
      (WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel): Call createSidebar.
      (WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe8ddd65
    • timothy@apple.com's avatar
      Call updateSelection() in a few places so hovering in the Web Inspector's · 16a4516c
      timothy@apple.com authored
      Elements panel always has the correct row selection height.
      
      https://bugs.webkit.org/show_bug.cgi?id=30735
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/ElementsTreeOutline.js:
      (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
      (WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.
      * inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16a4516c
    • eric@webkit.org's avatar
      2009-10-24 Timothy Hatcher <timothy@apple.com> · dd961820
      eric@webkit.org authored
              Remove the re-root tree feature from the Web Inspector's
              Elements panel. This feature wasn't super useful and gets
              in the way of double-click to edit.
      
              https://bugs.webkit.org/show_bug.cgi?id=30736
      
              Reviewed by Pavel Feldman.
      
              * inspector/front-end/ElementsTreeOutline.js:
              (WebInspector.ElementsTreeElement.prototype.ondblclick):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd961820
    • eric@webkit.org's avatar
      2009-10-24 Anton Muhin <antonm@chromium.org> · a50961a5
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Implements ReturnsNew hint for V8 bindings generation code.
              https://bugs.webkit.org/show_bug.cgi?id=30745
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/V8DOMWrapper.h:
              (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a50961a5
    • mitz@apple.com's avatar
      Missing images at 350.org due to wrong URLs · 776ffb9b
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30748
      
      Reviewed by Sam Weinig.
      
      WebCore: 
      
      Test: fast/dom/HTMLImageElement/parse-src.html
      
      * dom/Element.cpp:
      (WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL().
      This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI()
      and SVGImageLoader::sourceURI() do.
      
      LayoutTests: 
      
      * fast/dom/HTMLImageElement/parse-src-expected.txt: Added.
      * fast/dom/HTMLImageElement/parse-src.html: Added.
      * fast/dom/HTMLImageElement/script-tests: Added.
      * fast/dom/HTMLImageElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Document/script-tests/TEMPLATE.html.
      * fast/dom/HTMLImageElement/script-tests/parse-src.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      776ffb9b