1. 25 Sep, 2012 1 commit
  2. 24 Sep, 2012 39 commits
    • fpizlo@apple.com's avatar
      SerializedScriptValue isn't aware of indexed storage, but should be · 904bab81
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97515
      <rdar://problem/12361874>
      
      Reviewed by Sam Weinig.
      
      Source/JavaScriptCore: 
      
      Export a method that WebCore now uses.
      
      * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
      * runtime/JSObject.h:
      (JSObject):
      
      Source/WebCore: 
      
      New test: fast/js/post-message-numeric-property.html
      
      * bindings/js/SerializedScriptValue.cpp:
      (WebCore::CloneDeserializer::putProperty):
      
      LayoutTests: 
      
      * fast/js/post-message-numeric-property-expected.txt: Added.
      * fast/js/post-message-numeric-property.html: Added.
      * fast/js/script-tests/post-message-numeric-property.js: Added.
      (window.onmessage):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      904bab81
    • barraclough@apple.com's avatar
      Remove JSObject::unwrappedGlobalObject(), JSObject::unwrappedObject() · 51bdc905
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97519
      
      Reviewed by Geoff Garen.
      
      ../JavaScriptCore: 
      
      unwrappedGlobalObject() was only needed because globalObject() doesn't always return a helpful result -
      specifically for WebCore's window shell the structure's globalObject is set to null. We can fix this by
      simply keeping the structure up to date as the window navigates, obviating the need for this function.
      
      The only other use of unwrappedObject() came from globalFuncEval(), and this can be trivially removed
      by flipping the way we perform this globalObject check (which we may also be able to remove!) - instead
      of getting the globalObject from the provided this value & comparing to the expected globalObject, we
      can get the this value from the expected globalObject, and compare to that provided.
      
      * runtime/JSGlobalObject.cpp:
          - Call globalObject() instead of unwrappedGlobalObject().
      * runtime/JSGlobalObjectFunctions.cpp:
      (JSC::globalFuncEval):
          - Changed to compare this object values, instead of globalObjects -
            this means we only need to be able to map globalObject -> this,
            and not vice versa.
      * runtime/JSObject.cpp:
      (JSC::JSObject::allowsAccessFrom):
      (JSC::JSObject::createInheritorID):
          - Call globalObject() instead of unwrappedGlobalObject().
      * runtime/JSObject.h:
      (JSObject):
          - Removed unwrappedGlobalObject(), unwrappedObject().
      
      ../WebCore: 
      
      JSDOMWindowShell::setWindow should update the structure's globalObject.
      
      * bindings/js/JSDOMWindowShell.h:
      (WebCore::JSDOMWindowShell::setWindow):
          - Update the JSDOMWindowShell's structure's globalObject when the
            window changes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51bdc905
    • yosin@chromium.org's avatar
      [Forms] We should remove DateTimeEditElement::valueAsDouble() · 72ec804c
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97327
      
      Reviewed by Kent Tamura.
      
      This patch removes unused function DateTimeEditElement::valueAsDouble()
      and related functions in DateTimeFieldElement.
      
      This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
      ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
      
      No new tests. This patch doesn't change behavior.
      
      * html/shadow/DateTimeEditElement.cpp: Removed valueAsDouble() implementation.
      * html/shadow/DateTimeEditElement.h: Removed valueAsDouble() declaration.
      (DateTimeEditElement):
      * html/shadow/DateTimeFieldElement.cpp: Removed valueAsDouble() implementation.
      * html/shadow/DateTimeFieldElement.h: Removed unitInMillisecond() and valueAsDouble() declarations.
      (DateTimeFieldElement):
      * html/shadow/DateTimeFieldElements.cpp: Removed unitInMillisecond() implementations.
      * html/shadow/DateTimeFieldElements.h:
      (DateTimeAMPMFieldElement): Removed unitInMillisecond() declaration.
      (DateTimeHourFieldElement): ditto.
      (DateTimeMillisecondFieldElement): ditto.
      (DateTimeMinuteFieldElement): ditto.
      (DateTimeSecondFieldElement): ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72ec804c
    • weinig@apple.com's avatar
      WKProcessGroup can't load injected bundle with file URL · ab11a23b
      weinig@apple.com authored
      <rdar://problem/12322774>
      https://bugs.webkit.org/show_bug.cgi?id=97520
      
      Reviewed by Anders Carlsson.
      
      * UIProcess/API/mac/WKProcessGroup.mm:
      (-[WKProcessGroup initWithInjectedBundleURL:]):
      Fix typo. We need to pass the string as path, not as a URL.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab11a23b
    • mark.lam@apple.com's avatar
      Deleting the classic interpreter and cleaning up some build options. · 74a9e837
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96969.
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::dump):
      (JSC::CodeBlock::finalizeUnconditionally):
      (JSC::CodeBlock::stronglyVisitStrongReferences):
      (JSC):
      * bytecode/Instruction.h:
      (JSC::Instruction::Instruction):
      * interpreter/AbstractPC.cpp:
      (JSC::AbstractPC::AbstractPC):
      * interpreter/AbstractPC.h:
      (AbstractPC):
      * interpreter/CallFrame.h:
      (ExecState):
      * interpreter/Interpreter.cpp:
      (JSC):
      (JSC::Interpreter::Interpreter):
      (JSC::Interpreter::~Interpreter):
      (JSC::Interpreter::initialize):
      (JSC::Interpreter::isOpcode):
      (JSC::Interpreter::unwindCallFrame):
      (JSC::getLineNumberForCallFrame):
      (JSC::getCallerInfo):
      (JSC::getSourceURLFromCallFrame):
      (JSC::Interpreter::execute):
      (JSC::Interpreter::executeCall):
      (JSC::Interpreter::executeConstruct):
      (JSC::Interpreter::retrieveArgumentsFromVMCode):
      (JSC::Interpreter::retrieveCallerFromVMCode):
      (JSC::Interpreter::retrieveLastCaller):
      * interpreter/Interpreter.h:
      (JSC::Interpreter::getOpcodeID):
      (Interpreter):
      * jit/ExecutableAllocatorFixedVMPool.cpp:
      (JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
      * offlineasm/asm.rb:
      * offlineasm/offsets.rb:
      * runtime/Executable.cpp:
      (JSC::EvalExecutable::compileInternal):
      (JSC::ProgramExecutable::compileInternal):
      (JSC::FunctionExecutable::compileForCallInternal):
      (JSC::FunctionExecutable::compileForConstructInternal):
      * runtime/Executable.h:
      (JSC::NativeExecutable::create):
      (NativeExecutable):
      (JSC::NativeExecutable::finishCreation):
      * runtime/JSGlobalData.cpp:
      (JSC):
      (JSC::JSGlobalData::JSGlobalData):
      (JSC::JSGlobalData::getHostFunction):
      * runtime/JSGlobalData.h:
      (JSGlobalData):
      (JSC::JSGlobalData::canUseJIT):
      (JSC::JSGlobalData::canUseRegExpJIT):
      * runtime/Options.cpp:
      (JSC::Options::initialize):
      
      Source/WebKit/blackberry: 
      
      * WebCoreSupport/AboutDataEnableFeatures.in:
      
      Source/WTF: 
      
      * wtf/OSAllocatorPosix.cpp:
      (WTF::OSAllocator::reserveAndCommit):
      * wtf/Platform.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74a9e837
    • antti@apple.com's avatar
      Don't use StyleSheetList internally. · 8a2e6f0f
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97504
      
      Reviewed by Ryosuke Niwa.
      
      StyleSheetList is a DOM type and should not be used internally. Use plain Vector instead and construct StyleSheetList on DOM access only.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::StyleResolver):
      (WebCore::StyleResolver::addStylesheetsFromSeamlessParents):
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * css/StyleSheetList.cpp:
      (WebCore::StyleSheetList::StyleSheetList):
      (WebCore::StyleSheetList::styleSheets):
      (WebCore):
      (WebCore::StyleSheetList::detachFromDocument):
              
          Use live stylesheet vector of the documents stylesheet collection as long as we are attached to a document. 
          When detached copy the stylesheet vector to a member field and use that instead.
      
      (WebCore::StyleSheetList::length):
      (WebCore::StyleSheetList::item):
      (WebCore::StyleSheetList::getNamedItem):
      * css/StyleSheetList.h:
              
          Removed StyleSheetVector typedef as Vector<RefPtr<StyleSheet> > is less opaque and not much longer.
          
      (WebCore):
      (WebCore::StyleSheetList::create):
      (StyleSheetList):
      (WebCore::StyleSheetList::document):
      * dom/Document.cpp:
      (WebCore::Document::~Document):
      (WebCore::Document::setCompatibilityMode):
      (WebCore::Document::styleSheets):
      * dom/Document.h:
      (Document):
      * dom/DocumentStyleSheetCollection.cpp:
      (WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
      (WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
      * dom/DocumentStyleSheetCollection.h:
      (WebCore::DocumentStyleSheetCollec
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a2e6f0f
    • weinig@apple.com's avatar
      Use NSUserDefaults rather than an environment variable to control whether to... · c14ecd30
      weinig@apple.com authored
      Use NSUserDefaults rather than an environment variable to control whether to use an XPC Service for the WebProcess
      https://bugs.webkit.org/show_bug.cgi?id=97514
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit2: 
      
      * GNUmakefile.list.am:
      * PlatformEfl.cmake:
      * Target.pri:
      Add new files.
      
      * UIProcess/Launcher/ProcessLauncher.h:
      * UIProcess/WebProcessProxy.cpp:
      (WebKit::WebProcessProxy::connect):
      Move platform specific launch options to a new function, platformConnect.
      
      * UIProcess/WebProcessProxy.h:
      * UIProcess/efl/WebProcessProxyEfl.cpp: Added.
      Move Efl specific launch options here.
       
      (WebKit::WebProcessProxy::platformConnect):
      * UIProcess/gtk/WebProcessProxyGtk.cpp: Added.
      Add stub.
      
      (WebKit::WebProcessProxy::platformConnect):
      * UIProcess/mac/WebProcessProxyMac.mm:
      (WebKit::WebProcessProxy::platformConnect):
      Move Mac specific launch option setting here, and switch from
      using an environment variable to NSUserDefaults.
      
      * UIProcess/qt/WebProcessProxyQt.cpp: Added.
      (WebKit::WebProcessProxy::platformConnect):
      Add stub.
      
      * UIProcess/win/WebProcessProxyWin.cpp:
      (WebKit::WebProcessProxy::platformConnect):
      Add stub.
      
      Tools: 
      
      * Scripts/webkitdirs.pm:
      (argumentsForRunAndDebugMacWebKitApp):
      Push "-WebKit2UseXPCServiceForWebProcess YES" as arguments when --use-web-process-xpc-service
      is provided to set the user default. Move adding of @ARGV to after custom additions as calling
      shouldUseXPCServiceForWebProcess() can change @ARGV.
      
      (runMacWebKitApp):
      (execMacWebKitAppForDebugging):
      Stop setting the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c14ecd30
    • commit-queue@webkit.org's avatar
      Source/WebCore: [GTK][EFL] Remove cairo prefix from include statements · f1807bd7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97509
      
      Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-09-24
      Reviewed by Gyuyoung Kim.
      
      Make the build system consistent by always assuming that directory
      that includes the cairo headers is included in the include path.
      
      No new tests as there is no new functionality.
      
      * platform/cairo/WidgetBackingStoreCairo.cpp:
      * platform/gtk/GtkWidgetBackingStoreX11.cpp:
      * plugins/gtk/PluginViewGtk.cpp:
      
      Source/WebKit2: [GTK][EFL] Remove cairo prefix from include statements
      https://bugs.webkit.org/show_bug.cgi?id=97509
      
      Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-09-24
      Reviewed by Gyuyoung Kim.
      
      Make the build system consistent by always assuming that directory
      that includes the cairo headers is included in the include path.
      
      * UIProcess/cairo/BackingStoreCairo.cpp:
      * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1807bd7
    • commit-queue@webkit.org's avatar
      [GTK][EFL] Make sure cairo is built with fontconfig support · 52ac6216
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97513
      
      Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-09-24
      Reviewed by Martin Robinson.
      
      The GTK and EFL port of WebKit requires a version of cairo that is built with fontconfig support.
      
      * efl/jhbuild.modules:
      * gtk/jhbuild.modules:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52ac6216
    • yosin@chromium.org's avatar
      Document::adoptNode for multiple fields time input UI should not crash · c58582b1
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97428
      
      Reviewed by Dimitri Glazkov.
      
      Source/WebCore:
      
      This patch changes Document::removeFocusedNodeOfSubtree() to check
      focused node in shadow DOM tree for avoiding Document::m_focusedNode
      not to have dangling pointer to field owner in DateTimeFieldElement.
      
      Test:
       - fast/dom/shadow/shadow-removechild-and-blur-event.html: test for removeChild dispatches blur event.
       - fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: test for adoptNode not to crash.
       - fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur.html: removeChild of input type "time" dispatches blur event, existing test.
      
      * dom/Document.cpp:
      (WebCore::Document::removeFocusedNodeOfSubtree): Changed to check
      focused node in shadow DOM tree in addition to descendant node.
      
      LayoutTests:
      
      This patch adds a test for checking removeChild() of shadow host
      dispatches blur event if focused node in shadow tree, a test for
      checking adoptNode() doesn't causes crash and dispatches blur event
      during document.adoptNode() and updates expectation for focus/blur event test.
      
      * fast/dom/shadow/shadow-removechild-and-blur-event-expectation.txt: Added.
      * fast/dom/shadow/shadow-removechild-and-blur-event.html: Added for checking removeChild of shadow host dispatchs blur event when focused node in shadow tree.
      * fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode-expected.txt: Added.
      * fast/forms/time-multiple-fields/time-multiple-fields-crash-after-adoptnode.html: Added.
      * fast/forms/time-multiple-fields/time-multiple-fields-state-change-on-focus-or-blur-expected.txt: Updated to expectation to have output from blur event handler.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c58582b1
    • commit-queue@webkit.org's avatar
      [CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to... · 143a7ff5
      commit-queue@webkit.org authored
      [CMake] Change hardcoded 'lib' and 'bin' in CMakeLists.txt to 'LIB_INSTALL_DIR' and 'EXEC_INSTALL_DIR'.
      https://bugs.webkit.org/show_bug.cgi?id=97419
      
      Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-09-24
      Reviewed by Gyuyoung Kim.
      
      Use the value of LIB_INSTALL_DIR and EXEC_INSTALL_DIR instead of
      hardcoding 'lib' and 'bin' for CMAKE_{ARCHIVE,LIBRARY,RUNTIME}_OUTPUT_DIRECTORY.
      
      * CMakeLists.txt:
      Use ${LIB_INSTALL_DIR} instead of hardcoding "lib".
      Use ${EXEC_INSTALL_DIR} instead of hardcoding "bin".
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      143a7ff5
    • commit-queue@webkit.org's avatar
      [Blackberry] Add a software rendering path for media player · 419fe17b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97443
      
      Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2012-09-24
      Reviewed by Yong Li.
      
      This patch adds a software rendering path for media player. When accelerated rendering
      is not supported by the media engine for the current media, the rendering will fallback
      to this software path.
      
      PR #212386
      Reviewed internally by Max Feil.
      
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::MediaPlayerPrivate::paint):
      (WebCore::MediaPlayerPrivate::updateStates):
      (WebCore::MediaPlayerPrivate::supportsAcceleratedRendering):
      (WebCore):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
      (MediaPlayerPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      419fe17b
    • benjamin@webkit.org's avatar
      We should not expect percent-escaped hostname for invalid URLs · b1aca801
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97415
      
      Reviewed by Adam Barth.
      
      The URL layout tests encode some Chromium specific behavior.
      Chromium does a partial canonicalization of invalid URLs. Neither Safari, nor Firefox nor Opera
      do that.
      
      This patch fix the tests and expectations for the IP tests.
      
      * fast/url/invalid-urls-utf8-expected.txt:
      * fast/url/invalid-urls-utf8.html:
      Move the "empty authority" check from both IP tests to the invalid URLs test. An empty authority
      for a standard URL causes an invalid URL, it should be kept as is.
      
      * fast/url/ipv4-expected.txt:
      * fast/url/ipv6-expected.txt:
      * fast/url/script-tests/ipv4.js:
      * fast/url/script-tests/ipv6.js: Extend a comment to clarify the rule.
      Invalid URLs should not be escaped.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129445 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1aca801
    • benjamin@webkit.org's avatar
      Fix Geolocation error reporting in the test support · 68ae0cd8
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97386
      
      Source/WebCore: 
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
      Reviewed by Sam Weinig.
      
      GeolocationController currently expose GeolocationError which can be either
      PermissionDenied or PositionUnavailable.
      
      In practice, only PositionUnavailable is supported and tested, only Chrome
      somewhat expose PermissionDenied.
      The correct way to deny the permission is through Geolocation::setIsAllowed().
      
      This patch does some of the initial cleanup toward that goal, reducing how
      far GeolocationError is spread.
      
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      Mac does not use GeolocationClientMock, it should not be compiled in WebCore.
      
      * platform/mock/GeolocationClientMock.cpp:
      (WebCore::GeolocationClientMock::GeolocationClientMock):
      (WebCore::GeolocationClientMock::setPosition):
      (WebCore::GeolocationClientMock::setPositionUnavailableError):
      This method replace setError(). It is limited to PositionUnavailable errors.
      
      (WebCore::GeolocationClientMock::reset):
      (WebCore::GeolocationClientMock::controllerTimerFired):
      (WebCore):
      (WebCore::GeolocationClientMock::clearError):
      * platform/mock/GeolocationClientMock.h:
      (WebCore):
      (GeolocationClientMock):
      
      Source/WebKit/blackberry: 
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
      Reviewed by Sam Weinig.
      
      * WebKitSupport/DumpRenderTreeSupport.cpp:
      (DumpRenderTreeSupport::setMockGeolocationPositionUnavailableError):
      * WebKitSupport/DumpRenderTreeSupport.h:
      (DumpRenderTreeSupport):
      
      Source/WebKit/chromium: 
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
      Reviewed by Sam Weinig.
      
      * public/WebGeolocationClientMock.h:
      (WebGeolocationClientMock):
      * src/WebGeolocationClientMock.cpp:
      (WebKit::WebGeolocationClientMock::setMockGeolocationPositionUnavailableError):
      
      Source/WebKit/gtk: 
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
      Reviewed by Sam Weinig.
      
      * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
      (DumpRenderTreeSupportGtk::setMockGeolocationPositionUnavailableError):
      * WebCoreSupport/DumpRenderTreeSupportGtk.h:
      (DumpRenderTreeSupportGtk):
      
      Source/WebKit/mac: 
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
      Reviewed by Sam Weinig.
      
      * WebView/WebView.mm:
      (-[WebView _geolocationDidFailWithMessage:]):
      * WebView/WebViewPrivate.h:
      
      Source/WebKit/qt: 
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
      Reviewed by Sam Weinig.
      
      * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
      (DumpRenderTreeSupportQt::setMockGeolocationPositionUnavailableError):
      * WebCoreSupport/DumpRenderTreeSupportQt.h:
      
      Tools: 
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
      Reviewed by Sam Weinig.
      The TestRunner was exposing internal implementation details of
      the Geolocation object through setMockGeolocationError().
      
      In practice, only the error code PositionUnavailable is supported
      or even implemented.
      
      Exposing setMockGeolocationError() does not make sense for WebKit2 as
      passing generic errors from the UIProcess is a bad idea. This is the
      opportunity to clean TestRunner and prepare and interface suitable for WebKit2.
      
      * DumpRenderTree/TestRunner.cpp:
      (setMockGeolocationPositionUnavailableErrorCallback):
      (TestRunner::staticFunctions):
      * DumpRenderTree/TestRunner.h:
      (TestRunner):
      * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
      (TestRunner::setMockGeolocationPositionUnavailableError):
      * DumpRenderTree/chromium/DRTTestRunner.cpp:
      (DRTTestRunner::DRTTestRunner):
      (DRTTestRunner::setMockGeolocationPositionUnavailableError):
      * DumpRenderTree/chromium/DRTTestRunner.h:
      (DRTTestRunner):
      * DumpRenderTree/efl/TestRunnerEfl.cpp:
      (TestRunner::setMockGeolocationPositionUnavailableError):
      * DumpRenderTree/gtk/TestRunnerGtk.cpp:
      (TestRunner::setMockGeolocationPositionUnavailableError):
      * DumpRenderTree/mac/MockGeolocationProvider.h:
      * DumpRenderTree/mac/MockGeolocationProvider.mm:
      (-[MockGeolocationProvider dealloc]):
      (-[MockGeolocationProvider resetError]):
      (-[MockGeolocationProvider setPosition:]):
      (-[MockGeolocationProvider setPositionUnavailableErrorWithMessage:]):
      (-[MockGeolocationProvider lastPosition]):
      (-[MockGeolocationProvider timerFired]):
      * DumpRenderTree/mac/TestRunnerMac.mm:
      (TestRunner::setMockGeolocationPositionUnavailableError):
      * DumpRenderTree/qt/TestRunnerQt.cpp:
      (TestRunner::setMockGeolocationPositionUnavailableError):
      * DumpRenderTree/qt/TestRunnerQt.h:
      (TestRunner):
      * DumpRenderTree/win/TestRunnerWin.cpp:
      (TestRunner::setMockGeolocationPositionUnavailableError):
      * DumpRenderTree/wx/TestRunnerWx.cpp:
      (TestRunner::setMockGeolocationPositionUnavailableError):
      
      LayoutTests: 
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-24
      Reviewed by Sam Weinig.
      
      Update the tests to use setMockGeolocationPositionUnavailableError() instead
      of setMockGeolocationError().
      
      Only PositionError.POSITION_UNAVAILABLE was supported, so this not change
      anything for the test coverage.
      
      * fast/dom/Geolocation/error-clear-watch.html:
      * fast/dom/Geolocation/error-expected.txt:
      * fast/dom/Geolocation/maximum-age-expected.txt:
      * fast/dom/Geolocation/reentrant-error-expected.txt:
      * fast/dom/Geolocation/script-tests/error.js:
      * fast/dom/Geolocation/script-tests/maximum-age.js:
      (checkError):
      (testNonZeroMaximumAge):
      * fast/dom/Geolocation/script-tests/permission-denied-already-error.js:
      * fast/dom/Geolocation/script-tests/reentrant-error.js:
      * fast/dom/Geolocation/script-tests/watch.js:
      (checkError):
      * fast/dom/Geolocation/watch-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129444 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      68ae0cd8
    • tkent@chromium.org's avatar
      [Chromium] Implement ValidationMessageClient for Chromium · fb4ea60f
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97167
      
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      * page/ValidationMessageClient.h:
      Add forward declaration for WTF::String.
      
      Source/WebKit/chromium:
      
      Introduce ValidationMessageClientImpl. However actual popup
      implementation should be done in WebViewClient.
      
      * WebKit.gyp: Add ValidationMessageClientImpl.{cpp,h}.
      * public/WebViewClient.h:
      (WebKit::WebViewClient::showValidationMessage): Added.
      (WebKit::WebViewClient::hideValidationMessage): Added.
      * src/ValidationMessageClientImpl.cpp: Added.
      (WebKit::ValidationMessageClientImpl::ValidationMessageClientImpl):
      (WebKit::ValidationMessageClientImpl::create):
      (WebKit::ValidationMessageClientImpl::~ValidationMessageClientImpl):
      Make sure that a popup is closed.
      (WebKit::ValidationMessageClientImpl::showValidationMessage):
      Implementataion of ValidationMessageClient::showValidationMessage.
      minimumSecondToShowValidationMessage and secondPerCharacter are same as
      the corresponding values in the current Shadow DOM implementation.
      (WebKit::ValidationMessageClientImpl::hideValidationMessage):
      Implementataion of ValidationMessageClient::hideValidationMessage.
      (WebKit::ValidationMessageClientImpl::isValidationMessageVisible):
      Implementataion of ValidationMessageClient::isValidationMessageVisible.
      (WebKit::ValidationMessageClientImpl::hideCurrentValidationMessage):
      This is a callback function for the timer.
      * src/ValidationMessageClientImpl.h: Added.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::WebViewImpl):
       - Initialize m_validationMessage.
       - Add a comment for PageClients.
      * src/WebViewImpl.h:
      Add m_validationMessage.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb4ea60f
    • mihaip@chromium.org's avatar
      [Chromium] Remove WebRuntimeFeatures::{enablePushState,isPushStateEnabled} · f04f2b63
      mihaip@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97506
      
      Reviewed by Adam Barth.
      
      These methods have been no-ops since r127674. All Chromium code that
      called them was removed with http://crrev.com/155205.
      
      * public/WebRuntimeFeatures.h:
      (WebRuntimeFeatures):
      * src/WebRuntimeFeatures.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129442 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f04f2b63
    • yosin@chromium.org's avatar
      [Forms] DateTimeEditElement should return string value for ease of... · 3ff16b01
      yosin@chromium.org authored
      [Forms] DateTimeEditElement should return string value for ease of implementing other date/time input types.
      https://bugs.webkit.org/show_bug.cgi?id=97303
      
      Reviewed by Kent Tamura.
      
      This patch introduces a function DateTimeEditElement::value() for
      setting internal text value of TimeInputType with new function
      EditControlOwner::formatDateTimeFieldsState() to utilize this protocl
      in other date time input types.
      
      We used DateTimeEditElement::valueAsDouble() and and BaseDateAndTimeInputType::serialize()
      to make string value then setting internal text value of multiple
      fields time input UI. Although, this steps doesn't work well for
      other date/time input types.
      
      This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
      ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
      
      No new tests. This patch doesn't change behavior.
      
      * html/DateTimeFieldsState.cpp:
      (WebCore::DateTimeFieldsState::hour23): Added to convert 1 to 12 hour value to 0 to 23 hour.
      * html/DateTimeFieldsState.h:
      (DateTimeFieldsState): Added declaration of hour23().
      * html/TimeInputType.cpp:
      (WebCore::TimeInputType::DateTimeEditControlOwnerImpl::editControlValueChanged): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().
      (WebCore::TimeInputType::DateTimeEditControlOwnerImpl::formatDateTimeFieldsState): Added to format time.
      (WebCore::TimeInputType::restoreFormControlState): Changed to use DateTimeEditElement::value() instead of DateTimeEditElement::valueAsDouble().
      * html/TimeInputType.h:
      (DateTimeEditControlOwnerImpl): Added a declaration of formatDateTimeFieldsState().
      * html/shadow/DateTimeEditElement.cpp:
      (WebCore::DateTimeEditElement::value): Added.
      * html/shadow/DateTimeEditElement.h:
      (EditControlOwner): Added a declaration of formatDateTimeFieldsState().
      (DateTimeEditElement): Added a declaration of value().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129441 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ff16b01
    • fpizlo@apple.com's avatar
      Nested try/finally should not confuse the finally unpopper in... · 84c256c3
      fpizlo@apple.com authored
      Nested try/finally should not confuse the finally unpopper in BytecodeGenerator::emitComplexJumpScopes
      https://bugs.webkit.org/show_bug.cgi?id=97508
      <rdar://problem/12361132>
      
      Reviewed by Sam Weinig.
      
      Source/JavaScriptCore: 
      
      We're reusing some vector for multiple iterations of a loop, but we were forgetting to clear its
      contents from one iteration to the next. Hence if you did multiple iterations of finally unpopping
      (like in a nested try/finally and a jump out of both of them) then you'd get a corrupted try
      context stack afterwards.
      
      * bytecompiler/BytecodeGenerator.cpp:
      (JSC::BytecodeGenerator::emitComplexJumpScopes):
      
      LayoutTests: 
      
      * fast/js/jsc-test-list:
      * fast/js/script-tests/try-try-return-finally-finally.js: Added.
      (foo):
      * fast/js/try-try-return-finally-finally-expected.txt: Added.
      * fast/js/try-try-return-finally-finally.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129440 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84c256c3
    • dino@apple.com's avatar
      [WebGL] Intel Mac needs built-in function emulation · 60e82368
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=96140
      
      Reviewed by Sam Weinig.
      
      Temporarily turn on built-in function emulation for Intel GPUs
      on OS X. This is a work-around for a driver bug, and
      will be removed once the driver is updated:
      https://bugs.webkit.org/show_bug.cgi?id=97503
      
      This can be tested using the Khronos WebGL conformance
      suite, in particular:
      
      conformance/glsl/functions/glsl-function-dot.html
      conformance/glsl/functions/glsl-function-length.html
      conformance/glsl/functions/glsl-function-normalize.html
      conformance/glsl/functions/glsl-function-reflect.html
      
      Note that the faceforward built-in will still cause
      problems on Intel GPUs, but this would require an unnecessary
      change in the ANGLE project (remember, we're going to
      remove this code once the driver is fixed).
      
      * platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
      (WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):
          Temporarily add "Intel" to the list of GPUs we do translation
          for in the shader compiler.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129439 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60e82368
    • commit-queue@webkit.org's avatar
      There is a mistake in InspectorProfilerAgent::enable(bool skipRecompile) · 77a038f7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97450
      
      Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-24
      Reviewed by Yury Semikhatsky.
      
      The "InspectorProfilerAgent::enable()" should invokes "PageScriptDebugServer" in
      no-worker thread.
      
      No new test case.
      
      * inspector/InspectorProfilerAgent.cpp:
      (WebCore::PageProfilerAgent::recompileScript):
      (PageProfilerAgent):
      (WebCore::WorkerProfilerAgent::recompileScript):
      (WorkerProfilerAgent):
      (WebCore::InspectorProfilerAgent::disable):
      (WebCore::InspectorProfilerAgent::enable):
      * inspector/InspectorProfilerAgent.h:
      (InspectorProfilerAgent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129438 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77a038f7
    • commit-queue@webkit.org's avatar
      [EFL][WK2] TestRunner needs touch events support. · f7d366a9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96465
      
      Patch by Nikhil Bansal <n.bansal@samsung.com> on 2012-09-24
      Reviewed by Kenneth Rohde Christiansen.
      
      Tools:
      
      Simulate touch events in WebkitTestRunner for touch related
      layout tests. This patch uses ewk_view_feed_touch_event() to
      generate touch events.
      
      * WebKitTestRunner/EventSenderProxy.h:
      (EventSenderProxy):
      * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
      (WTR):
      (WTR::setEvasModifiers):
      (WTR::EventSenderProxy::EventSenderProxy):
      (WTR::EventSenderProxy::~EventSenderProxy):
      (WTR::EventSenderProxy::sendTouchEvent):
      (WTR::EventSenderProxy::addTouchPoint):
      (WTR::EventSenderProxy::updateTouchPoint):
      (WTR::EventSenderProxy::setTouchModifier):
      (WTR::EventSenderProxy::touchStart):
      (WTR::EventSenderProxy::touchMove):
      (WTR::EventSenderProxy::touchEnd):
      (WTR::EventSenderProxy::touchCancel):
      (WTR::EventSenderProxy::clearTouchPoints):
      (WTR::EventSenderProxy::releaseTouchPoint):
      (WTR::EventSenderProxy::cancelTouchPoint):
      
      LayoutTests:
      
      Touch events support added in WebKitTestRunner for layout tests.
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129437 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7d366a9
    • fpizlo@apple.com's avatar
      ValueToInt32 bool case does bad things to registers · 7539f5a7
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97505
      <rdar://problem/12356331>
      
      Reviewed by Mark Hahnenberg.
      
      Source/JavaScriptCore: 
      
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::compileValueToInt32):
      
      LayoutTests: 
      
      * fast/js/dfg-bool-to-int32-reuse-expected.txt: Added.
      * fast/js/dfg-bool-to-int32-reuse.html: Added.
      * fast/js/jsc-test-list:
      * fast/js/script-tests/dfg-bool-to-int32-reuse.js: Added.
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129435 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7539f5a7
    • mark.lam@apple.com's avatar
      Add cloopDo instruction for debugging the llint C++ backend. · 9cc5df7d
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97502.
      
      Reviewed by Geoffrey Garen.
      
      * offlineasm/cloop.rb:
      * offlineasm/instructions.rb:
      * offlineasm/parser.rb:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129434 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cc5df7d
    • paroga@webkit.org's avatar
      Remove String::operator+=() · e65252dc
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=96172
      
      Reviewed by Benjamin Poulain.
      
      Source/WebCore:
      
      Replace the last usage with String::append() in Gtk.
      
      * platform/gtk/GtkInputMethodFilter.cpp:
      (WebCore::GtkInputMethodFilter::handleCommit):
      
      Source/WTF:
      
      * wtf/Platform.h:
      * wtf/text/WTFString.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e65252dc
    • fpizlo@apple.com's avatar
      JSArray::putByIndex asserts with readonly property on prototype · 44e841ff
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97435
      <rdar://problem/12357084>
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      Boy, there were some problems:
              
      - putDirectIndex() should know that it can set the index quickly even if it's a hole and we're
        in SlowPut mode, since that's the whole point of PutDirect.
              
      - We should have a fast path for putByIndex().
              
      - The LiteralParser should not use push(), since that may throw if we're having a bad time.
      
      * interpreter/Interpreter.cpp:
      (JSC::eval):
      * runtime/JSObject.h:
      (JSC::JSObject::putByIndexInline):
      (JSObject):
      (JSC::JSObject::putDirectIndex):
      * runtime/LiteralParser.cpp:
      (JSC::::parse):
      
      LayoutTests: 
      
      * fast/js/concat-while-having-a-bad-time.html: Added.
      * fast/js/concat-while-having-a-bad-time-expected.txt: Added.
      * fast/js/jsc-test-list:
      * fast/js/script-tests/concat-while-having-a-bad-time.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129432 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44e841ff
    • roger_fong@apple.com's avatar
    • commit-queue@webkit.org's avatar
      [WK2] TestRunner does not support overridePreference with value "0" · 69fd8c41
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97457
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-24
      Reviewed by Alexey Proskuryakov.
      
      Tools:
      
      testRunner.overridePreference() was marked as taking a boolean
      in argument in testRunner.idl even though the test cases are
      passing strings to it. The current code works if the test
      case wants to enable a setting and therefore passes "1" string.
      However, if the test wants to disable a setting and passes "0"
      string, the current code also evaluates this to true causing
      certain test cases to fail.
      
      The argument to testRunner.overridePreference() is now of string
      type and a function has been added to convert the string passed
      by the test to a boolean value.
      
      * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
      * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
      (WTR::toBool):
      (WTR):
      (WTR::TestRunner::overridePreference):
      * WebKitTestRunner/InjectedBundle/TestRunner.h:
      (TestRunner):
      
      LayoutTests:
      
      Unskip fast/regions/css-regions-disabled.html test case for
      WebKit2 now that WebKitTestRunner actually supports overriding
      a boolean preference with "0" value (to disable it).
      
      * platform/efl-wk2/TestExpectations:
      * platform/gtk-wk2/TestExpectations:
      * platform/mac-wk2/Skipped:
      * platform/qt-5.0-wk2/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129430 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69fd8c41
    • pilgrim@chromium.org's avatar
      [Chromium][Mac] Remove loadFont from PlatformSupport · 32f73c9f
      pilgrim@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97360
      
      Reviewed by Adam Barth.
      
      Part of a refactoring series. See tracking bug 82948.
      
      Source/WebCore:
      
      * platform/chromium/PlatformSupport.h:
      (PlatformSupport):
      * platform/graphics/chromium/CrossProcessFontLoading.mm:
      
      Source/WebKit/chromium:
      
      * src/PlatformSupport.cpp:
      (WebCore):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129429 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32f73c9f
    • mark.lam@apple.com's avatar
      Added a missing "if VALUE_PROFILER" around an access to ArrayProfile record. · a39652e1
      mark.lam@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97496.
      
      Reviewed by Filip Pizlo.
      
      * llint/LowLevelInterpreter32_64.asm:
      * llint/LowLevelInterpreter64.asm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129428 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a39652e1
    • tony@chromium.org's avatar
      Replace 2 uses of updateLogicalHeight with computeLogicalHeight · c3853eca
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97486
      
      Reviewed by Ojan Vafai.
      
      More work for bug 96804.  This is just a refactoring.
      
      No new tests, behavior should be the same as before.
      
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::computeLogicalHeight):
      * rendering/RenderFlowThread.h:
      * rendering/RenderMultiColumnFlowThread.cpp:
      (WebCore::RenderMultiColumnFlowThread::computeLogicalHeight):
      (WebCore):
      * rendering/RenderMultiColumnFlowThread.h:
      (RenderMultiColumnFlowThread):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129427 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3853eca
    • ggaren@apple.com's avatar
      Inlined activation tear-off in the DFG · cd57a712
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97487
      
      Reviewed by Filip Pizlo.
      
      * dfg/DFGOperations.cpp:
      * dfg/DFGOperations.h: Activation tear-off is always inlined now, so I
      removed its out-of-line implementation.
      
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile): Inlined the variable copy and update
      of JSVariableObject::m_registers. This usually turns into < 10 instructions,
      which is close to pure win as compared to the operation function call.
      
      * runtime/JSActivation.h:
      (JSActivation):
      (JSC::JSActivation::registersOffset):
      (JSC::JSActivation::tearOff):
      (JSC::JSActivation::isTornOff):
      (JSC):
      (JSC::JSActivation::storageOffset):
      (JSC::JSActivation::storage): Tiny bit of refactoring so the JIT can
      share the pointer math helper functions we use internally.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129426 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd57a712
    • roger_fong@apple.com's avatar
      Unreviewed. Mark... · f923ed76
      roger_fong@apple.com authored
      Unreviewed. Mark http/tests/security/inactive-document-with-empty-security-origin.html while Geoff Garen
      investigates in https://bugs.webkit.org/show_bug.cgi?id=95530 in order to get the bots green.
      
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f923ed76
    • kbr@google.com's avatar
      [V8] ArrayBuffer code should not pass a negative length to... · a188079a
      kbr@google.com authored
      [V8] ArrayBuffer code should not pass a negative length to SetIndexedPropertiesToExternalArrayData()
      https://bugs.webkit.org/show_bug.cgi?id=96703
      
      Reviewed by Adam Barth.
      
      Check length arguments that may be passed to SetIndexedPropertiesToExternalArrayData.
      
      No tests because it is not guaranteed that buffers this large can actually be allocated.
      
      * bindings/v8/custom/V8ArrayBufferViewCustom.h:
      (WebCore::wrapArrayBufferView):
      (WebCore::constructWebGLArrayWithArrayBufferArgument):
      (WebCore::constructWebGLArray):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129424 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a188079a
    • antti@apple.com's avatar
      Split stylesheet related code out from Document · e5a88a78
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97353
      
      Reviewed by Andreas Kling.
      
      Document is big and unwieldy. The code related to tracking active stylesheets can be factored out.
              
      The patch moves stylesheet upkeep, collection and invalidation code from Document to a separate
      DocumentStyleSheetCollection class. There are no functional changes.
              
      The usesLinkRules stylesheet feature bit and the related code is removed as no one was using it.
      
      * WebCore.xcodeproj/project.pbxproj:
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOneSelector):
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::StyleResolver):
      (WebCore::StyleResolver::Features::Features):
      (WebCore::StyleResolver::Features::add):
      (WebCore::StyleResolver::Features::clear):
      (WebCore::StyleResolver::collectMatchingRulesForList):
      * css/StyleResolver.h:
      (WebCore::StyleResolver::usesBeforeAfterRules):
      (Features):
      * dom/Document.cpp:
      (WebCore::Document::Document):
      (WebCore::Document::~Document):
      (WebCore::Document::setCompatibilityMode):
      (WebCore::Document::recalcStyle):
      (WebCore):
      (WebCore::Document::createStyleResolver):
      (WebCore::Document::seamlessParentUpdatedStylesheets):
      (WebCore::Document::didRemoveAllPendingStylesheet):
      (WebCore::Document::processHttpEquiv):
      (WebCore::Document::styleSheets):
      (WebCore::Document::preferredStylesheetSet):
      (WebCore::Document::selectedStylesheetSet):
      (WebCore::Document::setSelectedStylesheetSet):
      (WebCore::Document::styleResolverChanged):
      (WebCore::Document::reportMemoryUsage):
      (WebCore::Document::haveStylesheetsLoaded):
      * dom/Document.h:
      (WebCore):
      (Document):
      (WebCore::Document::styleSheetCollection):
      (WebCore::Document::hasNodesWithPlaceholderStyle):
      (WebCore::Document::setNeedsNotifyRemoveAllPendingStylesheet):
      (WebCore::Document::inStyleRecalc):
      * dom/DocumentStyleSheetCollection.cpp: Added.
      (WebCore):
      (WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::pageUserSheet):
      (WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
      (WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
      (WebCore::DocumentStyleSheetCollection::pageGroupUserSheets):
      (WebCore::DocumentStyleSheetCollection::clearPageGroupUserSheets):
      (WebCore::DocumentStyleSheetCollection::updatePageGroupUserSheets):
      (WebCore::DocumentStyleSheetCollection::addUserSheet):
      (WebCore::DocumentStyleSheetCollection::removePendingSheet):
      (WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
      (WebCore::DocumentStyleSheetCollection::removeStyleSheetCandidateNode):
      (WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
      (WebCore::DocumentStyleSheetCollection::testAddedStyleSheetRequiresStyleRecalc):
      (WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
      (WebCore::styleSheetsUseRemUnits):
      (WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
      (WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
      (WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
      (WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
      * dom/DocumentStyleSheetCollection.h: Added.
      (WebCore):
      (DocumentStyleSheetCollection):
      (WebCore::DocumentStyleSheetCollection::authorStyleSheets):
      (WebCore::DocumentStyleSheetCollection::documentUserSheets):
      (WebCore::DocumentStyleSheetCollection::needsUpdateActiveStylesheetsOnStyleRecalc):
      (WebCore::DocumentStyleSheetCollection::preferredStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::selectedStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::setPreferredStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::setSelectedStylesheetSetName):
      (WebCore::DocumentStyleSheetCollection::addPendingSheet):
      (WebCore::DocumentStyleSheetCollection::hasPendingSheets):
      (WebCore::DocumentStyleSheetCollection::usesSiblingRules):
      (WebCore::DocumentStyleSheetCollection::setUsesSiblingRulesOverride):
      (WebCore::DocumentStyleSheetCollection::usesFirstLineRules):
      (WebCore::DocumentStyleSheetCollection::usesFirstLetterRules):
      (WebCore::DocumentStyleSheetCollection::setUsesFirstLetterRules):
      (WebCore::DocumentStyleSheetCollection::usesBeforeAfterRules):
      (WebCore::DocumentStyleSheetCollection::setUsesBeforeAfterRulesOverride):
      (WebCore::DocumentStyleSheetCollection::usesRemUnits):
      (WebCore::DocumentStyleSheetCollection::setUsesRemUnit):
      * dom/Element.cpp:
      (WebCore::Element::recalcStyle):
      * dom/ProcessingInstruction.cpp:
      (WebCore::ProcessingInstruction::~ProcessingInstruction):
      (WebCore::ProcessingInstruction::checkStyleSheet):
      (WebCore::ProcessingInstruction::sheetLoaded):
      (WebCore::ProcessingInstruction::insertedInto):
      (WebCore::ProcessingInstruction::removedFrom):
      * dom/StyleElement.cpp:
      (WebCore::StyleElement::insertedIntoDocument):
      (WebCore::StyleElement::removedFromDocument):
      (WebCore::StyleElement::clearDocumentData):
      (WebCore::StyleElement::createSheet):
      (WebCore::StyleElement::sheetLoaded):
      (WebCore::StyleElement::startLoadingDynamicSheet):
      * html/HTMLLinkElement.cpp:
      (WebCore::HTMLLinkElement::~HTMLLinkElement):
      (WebCore::HTMLLinkElement::insertedInto):
      (WebCore::HTMLLinkElement::removedFrom):
      (WebCore::HTMLLinkElement::addPendingSheet):
      (WebCore::HTMLLinkElement::removePendingSheet):
      * html/HTMLQuoteElement.cpp:
      (WebCore::HTMLQuoteElement::insertedInto):
      * html/HTMLViewSourceDocument.cpp:
      (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
      * mathml/MathMLMathElement.cpp:
      (WebCore::MathMLMathElement::insertedInto):
      * page/Page.cpp:
      (WebCore::Page::userStyleSheetLocationChanged):
      * page/PageGroup.cpp:
      (WebCore::PageGroup::resetUserStyleCacheInAllFrames):
      * rendering/RenderBR.cpp:
      (WebCore::RenderBR::lineHeight):
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::styleDidChange):
      (WebCore::RenderBlock::splitBlocks):
      (WebCore::RenderBlock::addChildIgnoringAnonymousColumnBlocks):
      (WebCore::RenderBlock::lineHeight):
      (WebCore::RenderBlock::updateFirstLetter):
      * rendering/RenderInline.cpp:
      (WebCore::RenderInline::styleDidChange):
      (WebCore::RenderInline::updateAlwaysCreateLineBoxes):
      (WebCore::RenderInline::addChildIgnoringContinuation):
      (WebCore::RenderInline::splitInlines):
      (WebCore::RenderInline::lineHeight):
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::uncachedFirstLineStyle):
      (WebCore::RenderObject::firstLineStyleSlowCase):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::firstLineStyle):
      * rendering/RenderObjectChildList.cpp:
      (WebCore::RenderObjectChildList::updateBeforeAfterContent):
      * rendering/RenderTableRow.cpp:
      (WebCore::RenderTableRow::updateBeforeAndAfterContent):
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::verticalPositionForBox):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5a88a78
    • roger_fong@apple.com's avatar
      Unreviewed. http/tests/security/sandboxed-iframe-form-top.html fails on Windows. · 76f40e59
      roger_fong@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97485
      
      This test actually "passes" but is producing wrong output in whichever test proceeds it, thus causing that test to fail.
      
      * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129421 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76f40e59
    • commit-queue@webkit.org's avatar
      [BlackBerry] Reverting implementation for 407 error pages · 6c65e821
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97455
      
      Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-24
      Reviewed by Rob Buis.
      
      Source/WebCore:
      
      Revert "[BlackBerry] Reverting implementation for 407 error pages"
      This reverts commit fda0a1b6.
      
      This revert also reverts commit 0cffe019
      due to dependency issues.
      
      * PlatformBlackBerry.cmake:
      * platform/blackberry/AuthenticationChallengeManager.cpp: Removed.
      * platform/blackberry/AuthenticationChallengeManager.h:
      * platform/blackberry/PageClientBlackBerry.h:
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
      (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
      (WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
      (WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
      (WebCore::MediaPlayerPrivate::notifyChallengeResult):
      * platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
      (MediaPlayerPrivate):
      * platform/network/blackberry/NetworkJob.cpp:
      (WebCore::NetworkJob::NetworkJob):
      (WebCore::NetworkJob::handleNotifyStatusReceived):
      (WebCore::NetworkJob::notifyAuthReceived):
      (WebCore::NetworkJob::handleNotifyClose):
      (WebCore::NetworkJob::sendRequestWithCredentials):
      (WebCore::NetworkJob::notifyChallengeResult):
      * platform/network/blackberry/NetworkJob.h:
      (NetworkJob):
      
      Source/WebKit/blackberry:
      
      Revert "[BlackBerry] Really fix bug 95488 that user can get the
      authentication challenge dialog while the other tab has focus."
      https://bugs.webkit.org/show_bug.cgi?id=97348
      
      This reverts commit 0cffe019.
      
      * Api/BlackBerryGlobal.cpp:
      (BlackBerry::WebKit::globalInitialize):
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
      (BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
      (BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
      (BlackBerry::WebKit::WebPage::setVisible):
      * Api/WebPage_p.h:
      (WebPagePrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c65e821
    • crogers@google.com's avatar
      [REGRESSION] Layout Test webaudio/biquad-getFrequencyResponse.html is failing · b36882e6
      crogers@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97439
      
      Reviewed by Kenneth Russell.
      
      Fixes uninitialized member variable.
      
      This should fix flaky failing test: webaudio/biquad-getFrequencyResponse.html
      
      * Modules/webaudio/BiquadProcessor.cpp:
      (WebCore::BiquadProcessor::BiquadProcessor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129418 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b36882e6
    • dpranke@chromium.org's avatar
      Narrow Chromium TestExpectations for some hidpi failures to be Linux-only. · a04486d8
      dpranke@chromium.org authored
      crbug.com/150682
      
      Unreviewed, expectations change.
      
      Also remove a no-longer-failing Mac expectation for
      compositing/overflow/overflow-scaled-descendant-overlapping.html
      
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a04486d8
    • tony@chromium.org's avatar
      flex-grow should be 1 when omitted from flex shorthand · f72f3535
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97480
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      We were using 0, based on an outdated version of the spec.
      
      Tests: css3/flexbox/flex-property-parsing.html
             css3/flexbox/flex-algorithm.html: New test case.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseFlex):
      
      LayoutTests:
      
      Update tests due to default CSS value changes.
      
      * css3/flexbox/flex-algorithm-expected.txt:
      * css3/flexbox/flex-algorithm.html: Add test case using -webkit-flex: auto.
      * css3/flexbox/flex-property-parsing-expected.txt:
      * css3/flexbox/flex-property-parsing.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@129414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f72f3535