1. 17 May, 2013 40 commits
    • ch.dumez@sisa.samsung.com's avatar
      Get rid of [ConstructorParameters] extended attributes · be4640db
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116308
      
      Reviewed by Kentaro Hara.
      
      Get rid of WebKit-specific [ConstructorParameters] IDL extended attribute. Instead,
      [CustomConstructor] arguments are now explicitly specified, similarly to [Constructor]
      arguments and the constructor object's "length" property is now automatically
      computed for custom constructors as well.
      
      This is less error-prone as the value is not hardcoded, more consistent with
      [Constructor] extended attribute and gives more information about the custom constructor
      in the IDL file. We also get rid of a WebKit-specific IDL attribute which is always
      nice.
      
      No new tests, already covered by fast/js/constructor-length.html.
      
      * Modules/mediastream/MediaStream.idl:
      * Modules/webaudio/AudioContext.idl:
      * Modules/websockets/WebSocket.idl:
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateConstructorHelperMethods):
      * bindings/scripts/IDLAttributes.txt:
      * bindings/scripts/IDLParser.pm:
      (applyTypedefs):
      (parseAttributeRest):
      (copyExtendedAttributes):
      (parseExtendedAttributeRest):
      (applyExtendedAttributeList):
      * bindings/scripts/test/JS/JSFloat64Array.cpp:
      (WebCore::JSFloat64ArrayConstructor::finishCreation):
      * bindings/scripts/test/TestTypedArray.idl:
      * dom/MutationObserver.idl:
      * fileapi/Blob.idl:
      * html/DOMFormData.idl:
      * html/canvas/ArrayBuffer.idl:
      * html/canvas/DataView.idl:
      * page/WebKitPoint.idl:
      * workers/SharedWorker.idl:
      * workers/Worker.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150292 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be4640db
    • ap@apple.com's avatar
      Text input is largely broken when there are subframes loading · e042b63d
      ap@apple.com authored
              http://bugs.webkit.org/show_bug.cgi?id=59121
              <rdar://problem/9320468>
      
              Reviewed by Darin Adler.
      
              * UIProcess/PageClient.h:
              * UIProcess/API/mac/PageClientImpl.h:
              * UIProcess/API/mac/PageClientImpl.mm:
              (WebKit::PageClientImpl::updateSecureInputState): Separated secure input state
              updating into a separate function. Removed updateTextInputState, we don't need
              to go through PageClient to implement its behavior at all.
              (WebKit::PageClientImpl::dismissDictionaryLookupPanel): Added a FIXME.
      
              * UIProcess/API/mac/WKView.mm:
              * UIProcess/API/mac/WKViewInternal.h:
              Removed _updateTextInputStateIncludingSecureInputState.
      
              * UIProcess/WebPageProxy.h: Added m_temporarilyClosedComposition, which helps
              to figure out that WebCore decided to close a composition. The issue is that WebCore
              would first send an EditorState with hasComposition set to false, and with
              shouldIgnoreCompositionSelectionChange set to true, at which time we forget the
              previous m_editorState, but can't make any decisions based on this transient state.
              We should find a way to simplify this (maybe not send these updates with
              shouldIgnoreCompositionSelectionChange at all?)
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::WebPageProxy): Initialize m_temporarilyClosedComposition.
              (WebKit::WebPageProxy::didCommitLoadForFrame): Removed the code to kill a composition
              when any frame commits a load, which made no sense (along with surrounding code,
              which will unfortunately survive longer).
              (WebKit::WebPageProxy::editorStateChanged): Implemented state updating here,
              we don't need to go to WKView.mm to implement this logic. Figure out when WebCore
              discards a composition, and notify input methods about this.
              (WebKit::WebPageProxy::resetStateAfterProcessExited): Reset m_temporarilyClosedComposition.
              Added some FIXMEs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e042b63d
    • rniwa@webkit.org's avatar
      Mac rebaselines; also remove some entries. · 12a72937
      rniwa@webkit.org authored
      Seriously, I've had it enough. Why are people adding these entires never to rebaseline them later?
      
      * platform/mac/TestExpectations:
      * platform/mac/fast/css-generated-content/table-row-group-to-inline-expected.txt:
      * platform/mac/fast/dom/HTMLImageElement/image-alt-text-expected.png:
      * platform/mac/fast/dom/HTMLImageElement/image-alt-text-expected.txt:
      * platform/mac/fast/encoding/utf-16-big-endian-expected.png:
      * platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
      * platform/mac/fast/encoding/utf-16-little-endian-expected.png:
      * platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
      * platform/mac/fast/forms/input-value-expected.png:
      * platform/mac/fast/forms/input-value-expected.txt:
      * platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.png:
      * platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
      * platform/mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
      * platform/mac/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150290 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12a72937
    • commit-queue@webkit.org's avatar
      [WK2] Add support for selectTrailingWhitespaceEnabled setting · 4f07557a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=112426
      
      Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-05-17
      Reviewed by Ryosuke Niwa.
      
      * Shared/WebPreferencesStore.h:
      (WebKit): Add macro for selectTrailingWhitespaceEnabled.
      * UIProcess/API/C/WKPreferences.cpp:
      (WKPreferencesSetSelectTrailingWhitespaceEnabled):
      (WKPreferencesGetSelectTrailingWhitespaceEnabled): Implement methods
      using the new setting.
      * UIProcess/API/C/WKPreferencesPrivate.h: Add new methods headers.
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::isSelectTrailingWhitespaceEnabled): Implement
      method delegating in WebPage.
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences): Set
      selectTrailingWhitespaceEnabled setting.
      (WebKit::WebPage::setSmartInsertDeleteEnabled): Set
      selectTrailingWhitespaceEnabled as they are mutually exclusive.
      (WebKit):
      (WebKit::WebPage::isSelectTrailingWhitespaceEnabled): Implement method
      using settings.
      (WebKit::WebPage::setSelectTrailingWhitespaceEnabled): Implement method
      using settings and set smartInsertDeleteEnabled as they are mutually
      exclusive.
      * WebProcess/WebPage/WebPage.h:
      (WebPage): Add new methods headers.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f07557a
    • beidson@apple.com's avatar
      Fix crash introduced by http://trac.webkit.org/changeset/150282 · fddbd26d
      beidson@apple.com authored
      Followup to https://bugs.webkit.org/show_bug.cgi?id=116253
      
      Reviewed by Andreas Kling.
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::focusedFrameChanged): Frame might be null.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150288 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fddbd26d
    • commit-queue@webkit.org's avatar
      Remove chrome-channels command from the webkit-patch · 0ac5956f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116303
      
      Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-17
      Reviewed by Ryosuke Niwa.
      
      * Scripts/webkitpy/common/config/urls.py: Removed omahaproxy url.
      * Scripts/webkitpy/common/net/omahaproxy.py: Removed.
      * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Removed.
      * Scripts/webkitpy/tool/commands/__init__.py: Removed chromechannels import.
      * Scripts/webkitpy/tool/commands/chromechannels.py: Removed.
      * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150287 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ac5956f
    • ddkilzer@apple.com's avatar
      filter-build-webkit: Don't filter out the location of the missing symbol when linking fails · 11e2b638
      ddkilzer@apple.com authored
      Part 3 of 3: <http://webkit.org/b/116247>
      
      Reviewed by Benjamin Poulain.
      
      * Scripts/filter-build-webkit: Change while() loop to for() loop
      to track $previousLine, then pass $previousLine into
      shouldIgnoreLine().
      (shouldIgnoreLine): Add $previousLine argument. Do not skip a
      line that begins with four spaces if the previous line is a
      linker error message.
      * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
      - Add "Ignored: " to test descriptions to document expected
        behavior.
      - Add comment blocks for various groups of tests.
      - Expand "Build settings" tests since we're changing the code in
        shouldIgnoreLine() that ignores those lines.
      - Add tests for undefined symbols error message.
      (description): Add.  Extract from global code.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150286 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11e2b638
    • ddkilzer@apple.com's avatar
      Add tests for shouldIgnoreLine() in filter-build-webkit · 1f7e5af4
      ddkilzer@apple.com authored
      Part 2 of 3: <http://webkit.org/b/116247>
      
      Reviewed by Benjamin Poulain.
      
      * Scripts/filter-build-webkit:
      (shouldIgnoreLine): Add.  Extract code from global scope into
      subroutine to make it testable.
      * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: Add.
      Tests shouldIgnoreLine() using output from a real build
      transcript.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f7e5af4
    • rniwa@webkit.org's avatar
      Rename "WebKit Queues" to explicitly call out for EWS and CQ on build.webkit.org · 920b7b82
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116341
      
      Reviewed by Brady Eidson.
      
      * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150284 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      920b7b82
    • ch.dumez@sisa.samsung.com's avatar
      Get rid of [CustomGetter] for global named constructors · 175406ce
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116116
      
      Reviewed by Geoffrey Garen.
      
      Improve the JSC bindings generator so that global named constructors no longer
      require a [CustomGetter] IDL extended attribute. As a consequence, attributes
      on the global window object can now be automatically generated for interfaces
      that have a [NamedConstructor], namely HTMLOptionElement.
      
      The HTMLAudioElement global constructors are still manually defined because it
      requires custom code at the moment to check if the media player is available.
      
      No new tests, no behavior change.
      
      * bindings/js/JSDOMWindowCustom.cpp:
      * bindings/scripts/CodeGeneratorJS.pm:
      * bindings/scripts/preprocess-idls.pl:
      * bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
      * bindings/scripts/test/JS/JSTestNamedConstructor.h:
      * html/HTMLOptionElement.idl:
      * page/DOMWindow.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150283 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      175406ce
    • beidson@apple.com's avatar
      Replace WebFrameLoaderClient static_casts with a function that might return null. · cd6e7e21
      beidson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116253
      
      The general approach here is:
      1 - Introduce a toWebFrameLoaderClient() function to convert FrameLoaderClients, and that may return null.
      2 - Adopt toWebFrameLoaderClient() everywhere we used to do a direct static_cast<WebFrameLoaderClient*>
      3 - In functions that already support a "return 0" scenario, a failed cast results in a return 0.
      4 - In other functions that assume no failure to get the WebFrameLoaderClient, add an ASSERT.
      
      Reviewed by Alexey Proskuryakov.
      
      Add the utility function to cast:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      (WebKit::toWebFrameLoaderClient):
      
      Adopt it everywhere:
      * WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
      (WebKit::GeolocationPermissionRequestManager::startRequestForGeolocation):
      
      * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
      (WebKit::InjectedBundleNodeHandle::documentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlFrameElementContentFrame):
      (WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
      
      * WebProcess/InjectedBundle/InjectedBundle.cpp:
      (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
      
      * WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
      (WebKit::InjectedBundleDOMWindowExtension::frame):
      
      * WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:
      (WebKit::InjectedBundleHitTestResult::frame):
      (WebKit::InjectedBundleHitTestResult::targetFrame):
      
      * WebProcess/Network/WebResourceLoadScheduler.cpp:
      (WebKit::WebResourceLoadScheduler::scheduleLoad):
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::webPage):
      (WebKit::PluginView::performFrameLoadURLRequest):
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::focusedNodeChanged):
      (WebKit::WebChromeClient::focusedFrameChanged):
      (WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
      (WebKit::WebChromeClient::runJavaScriptAlert):
      (WebKit::WebChromeClient::runJavaScriptConfirm):
      (WebKit::WebChromeClient::runJavaScriptPrompt):
      (WebKit::WebChromeClient::print):
      (WebKit::WebChromeClient::exceededDatabaseQuota):
      (WebKit::WebChromeClient::runOpenPanel):
      
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::textFieldDidBeginEditing):
      (WebKit::WebEditorClient::textFieldDidEndEditing):
      (WebKit::WebEditorClient::textDidChangeInTextField):
      (WebKit::WebEditorClient::textDidChangeInTextArea):
      (WebKit::WebEditorClient::doTextFieldCommandFromEvent):
      (WebKit::WebEditorClient::textWillBeDeletedInTextField):
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchWillSendSubmitEvent):
      (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
      
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::contentsAsString):
      (WebKit::WebFrame::parentFrame):
      (WebKit::WebFrame::childFrames):
      (WebKit::WebFrame::frameForContext):
      (WebKit::WebFrameFilter::shouldIncludeSubframe):
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::mainFrameHasCustomRepresentation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150282 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd6e7e21
    • bfulgham@apple.com's avatar
      [Windows] Don't use pdevenv when building with VS2010. · c024a59a
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116338.
      
      Reviewed by Adam Roben.
      
      * Scripts/webkitdirs.pm:
      (setupCygwinEnv): Check if we are using VS2005, and only use
      the 'pdevenv' hack if we are. Otherwise, just build with
      our standard project since it uses VS2010+'s native
      parallel building features.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150281 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c024a59a
    • commit-queue@webkit.org's avatar
      Web Inspector: SyntaxError evaluating "1+1; //@ sourceURL=test" in console · 199bbd43
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116292
      
      Source/WebCore:
      
      Add a newline after the expression so a single line comment doesn't
      erroneously comment out the closing brace of the with block.
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-05-17
      Reviewed by Timothy Hatcher.
      
      Test: inspector/console/console-eval-comment.html
      
      * inspector/InjectedScriptSource.js:
      
      LayoutTests:
      
      Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-05-17
      Reviewed by Timothy Hatcher.
      
      * inspector/console/console-eval-comment-expected.txt: Added.
      * inspector/console/console-eval-comment.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150280 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      199bbd43
    • hyatt@apple.com's avatar
      · d75d0d62
      hyatt@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150279 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d75d0d62
    • hyatt@apple.com's avatar
      fast/flexbox/auto-height-with-flex.html failing only on release builds. · 771cc12c
      hyatt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116240
      
      Reviewed by Darin Adler.
      
      Fix the mainAxisContentExtent method so no overflow occurs, since it
      doesn't work right on release builds.
      
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::mainAxisContentExtent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      771cc12c
    • weinig@apple.com's avatar
      Expose new load-with-userData API to Objective-C · 601818cf
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116335
      
      Reviewed by Anders Carlsson.
      
      - Adds loadRequest:userData:, loadFileURL:restrictToFilesWithin:userData:, loadHTMLString:baseURL:userData:
        loadData:MIMEType:textEncodingName:baseURL:, and loadData:MIMEType:textEncodingName:baseURL:userData.
      - Adds a WKObjCTypeWrapperRef (which is a ObjCObjectGraph under the covers) to allow the userData to be unwrapped
        in the injected bundles willLoadURLRequest and willLoadDataRequest C-SPI callbacks.
      
      * Shared/API/c/WKBase.h:
      * Shared/API/c/WKSharedAPICast.h:
      * Shared/API/c/mac/WKBaseMac.h: Added.
      * Shared/API/c/mac/WKObjCTypeWrapperRef.h: Added.
      * Shared/API/c/mac/WKObjCTypeWrapperRef.mm: Added.
      (WKObjCTypeWrapperGetTypeID):
      (WKObjCTypeWrapperCreate):
      (WKObjCTypeWrapperGetObject):
      * UIProcess/API/mac/WKBrowsingContextController.h:
      * UIProcess/API/mac/WKBrowsingContextController.mm:
      (+[WKBrowsingContextController registerSchemeForCustomProtocol:]):
      (+[WKBrowsingContextController unregisterSchemeForCustomProtocol:]):
      (-[WKBrowsingContextController loadRequest:]):
      (-[WKBrowsingContextController loadRequest:userData:]):
      (-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:]):
      (-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]):
      (-[WKBrowsingContextController loadHTMLString:baseURL:]):
      (-[WKBrowsingContextController loadHTMLString:baseURL:userData:]):
      (-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:]):
      (-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
      * WebKit2.xcodeproj/project.pbxproj:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150277 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      601818cf
    • ch.dumez@sisa.samsung.com's avatar
      Add [EnabledAtRuntime] extended attribute support for global constructors · c1020034
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116147
      
      Reviewed by Geoffrey Garen.
      
      Add [EnabledAtRuntime] extended attribute support for global constructors.
      This patch adds [EnabledAtRuntime] extended attribute to SharedWorker and
      WebSocket IDL interfaces so that their global constructors on the global
      Window object can now be automatically generated.
      
      The behavior on JavaScript side is unchanged. We simply leverage
      RuntimeEnabledFeatures class and the new [EnabledAtRuntime] IDL extended
      attribute to generate the code for global constructors getters instead
      of using custom code.
      
      No new tests, no behavior change for layout tests.
      
      * GNUmakefile.list.am:
      * Modules/websockets/WebSocket.cpp: Enable WebSockets at runtime by default.
      * Modules/websockets/WebSocket.idl:
      * Target.pri:
      * UseJSC.cmake:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSBindingsAllInOne.cpp:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore):
      * bindings/js/JSDOMWindowWebSocketCustom.cpp: Removed.
      * bindings/scripts/CodeGeneratorJS.pm:
      (ToMethodName):
      (GetRuntimeEnableFunctionName):
      (GenerateImplementation):
      * bindings/scripts/IDLAttributes.txt:
      * page/DOMWindow.idl:
      * workers/SharedWorker.idl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1020034
    • kov@webkit.org's avatar
      Unreviewed. Skip webgl and transforms/3d tests again, until we find out why they do · 868f0865
      kov@webkit.org authored
      not run in the release bot.
      
      Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-17
      
      * platform/gtk/TestExpectations:
      
      Tools
      
      * Tools/DumpRenderTree/gtk/DumpRenderTree.cpp: Disable accelerated compositing until we figure
      out why it does not work properly in the 64 bits release bot.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      868f0865
    • commit-queue@webkit.org's avatar
      [BlackBerry] REGRESSION(r150060): Crash in LayerWebKitThread::updateTextureContents · f9faedf9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116305
      
      Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-17
      Reviewed by Rob Buis.
      
      PR 340537.
      Internally reviewed by Arvid Nilsson.
      
      Use updateLayoutAndStyleIfNeededRecursive() instead of
      layoutIfNeeded() since we are about to draw in
      rootLayerCommitTimerFired().
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::rootLayerCommitTimerFired):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150274 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9faedf9
    • andersca@apple.com's avatar
      Accessing null function pointers is bad. · 0cacc314
      andersca@apple.com authored
      * WebCoreSupport/WebFrameLoaderClient.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cacc314
    • ddkilzer@apple.com's avatar
      Make filter-build-webkit testable using LoadAsModule · 551f27d1
      ddkilzer@apple.com authored
      Part 1 of 3: <http://webkit.org/b/116247>
      
      Reviewed by Benjamin Poulain.
      
      * Scripts/filter-build-webkit: Change global variables that are
      used in subroutines from 'my' to 'our' to make it possible to
      evaluate the script in a package context in LoadAsModule.pm.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      551f27d1
    • weinig@apple.com's avatar
      Add WKPageLoadData and WKPageLoadDataWithUserData SPI to support loading arbitrary data blobs · ab631f5a
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116325
      
      Reviewed by Simon Fraser.
      
      * UIProcess/API/C/WKPage.cpp:
      (WKPageLoadData):
      (WKPageLoadDataWithUserData):
      Add new SPI.
      
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::loadData):
      * UIProcess/WebPageProxy.h:
      Pipe through to the WebProcess.
      
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::loadDataImpl):
      (WebKit::WebPage::loadData):
      (WebKit::WebPage::loadHTMLString):
      (WebKit::WebPage::loadAlternateHTMLString):
      (WebKit::WebPage::loadPlainTextString):
      (WebKit::WebPage::loadWebArchiveData):
      Rename existing loadData function to loadDataImpl (I hate it) to avoid overload conflict
      from IPC magic.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab631f5a
    • timothy@apple.com's avatar
      Fix Release builds. · c7e1b22d
      timothy@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7e1b22d
    • andersca@apple.com's avatar
      Make kit(Frame*) more robust · baba5723
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116324
      
      Reviewed by Darin Adler.
      
      Check that the frame loader's client isn't the EmptyFrameLoaderClient (or a subclass thereof)
      before casting to WebFrameLoaderClient.
      
      * WebView/WebFrame.mm:
      (kit):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      baba5723
    • darin@apple.com's avatar
      [EFL] Move EFL port off legacy clipboard · 598684a1
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116181
      
      Reviewed by Anders Carlsson.
      
      * dom/Clipboard.h: Switched EFL away from "legacy" mode for Clipboard.
      
      * page/efl/EventHandlerEfl.cpp:
      (WebCore::EventHandler::createDraggingClipboard): Changed to call Clipboard member function.
      
      * platform/efl/ClipboardEfl.cpp: Deleted most of the functions.
      (WebCore::Editor::newGeneralClipboard): Changed to call Clipboard member function.
      (WebCore::Clipboard::createDragImage): Moved from ClipboardEfl to Clipboard.
      (WebCore::Clipboard::declareAndWriteDragImage): Moved from ClipboardEfl to Clipboard.
      (WebCore::Clipboard::items): Ditto.
      
      * platform/efl/PasteboardEfl.cpp: A lot of copyright notices for a file that
      has no code in it other than notImplemented lines! I didn't add a new one.
      (WebCore::Pasteboard::createForCopyAndPaste): Added.
      (WebCore::Pasteboard::createPrivate): Added.
      (WebCore::Pasteboard::createForDragAndDrop): Added.
      (WebCore::Pasteboard::hasData): Added.
      (WebCore::Pasteboard::readString): Added.
      (WebCore::Pasteboard::writeString): Added.
      (WebCore::Pasteboard::types): Added.
      (WebCore::Pasteboard::readFilenames): Added.
      (WebCore::Pasteboard::setDragImage): Added.
      (WebCore::Pasteboard::writePasteboard): Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150268 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      598684a1
    • ch.dumez@sisa.samsung.com's avatar
      [EFL][WK2] Fix sub menu initialization in ewk_context_menu_item · 76311ebf
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116321
      
      Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-05-17
      Reviewed by Christophe Dumez.
      
      During sub menu creation, after initializing m_parentMenu, parentMenu
      pointer became null which may cause segfaults. This patch fixes it by
      using m_parentMenu.
      
      * UIProcess/API/efl/ewk_context_menu_item.cpp:
      (EwkContextMenuItem::EwkContextMenuItem):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76311ebf
    • andersca@apple.com's avatar
      Move the policy function to WebFramePolicyListener · 58107658
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116323
      
      Reviewed by Darin Adler.
      
      There's no need for the WebFrameLoaaderClient to hold on to the policy function,
      so move it to WebFramePolicyListener. This gets rid of another WebFrameLoaderClient cast.
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::setUpPolicyListener):
      Pass the policy function when creating the WebFramePolicyListener object.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150266 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58107658
    • andersca@apple.com's avatar
      WebFramePolicyListener should keep its Frame in a RefPtr · 1264df67
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116322
      
      Reviewed by Darin Adler.
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (-[WebFramePolicyListener initWithWebCoreFrame:]):
      No need to ref the frame, the RefPtr does that for us.
      
      (-[WebFramePolicyListener invalidate]):
      Just set the frame to null.
      
      (-[WebFramePolicyListener dealloc]):
      Remove call to deref, that's done automatically now.
      
      (-[WebFramePolicyListener finalize]):
      Remove this method. (We could have kept it just for the assertion but I didn't think that was necessary).
      
      (-[WebFramePolicyListener receivedPolicyDecision:):
      Use release() to transfer ownership.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1264df67
    • commit-queue@webkit.org's avatar
      Bad spacing inside MathML formulas when text-indent is specified · a481ce9c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106600
      
      Patch by Frédéric Wang <fred.wang@free.fr> on 2013-05-17
      Reviewed by Martin Robinson.
      
      Source/WebCore:
      
      When MathML is used in a HTML page that modifies the CSS text-indent,
      large gaps appear inside the mathematical expressions. Resetting it to
      0 on the math root (as Gecko does) fixes the issue.
      
      Tests: mathml/presentation/text-indent.html
             mathml/presentation/text-indent-expected.html
      
      * css/mathml.css:
      (math): reset text-indent to its default value.
      
      LayoutTests:
      
      New test to verify that the text-indent property is reset to 0 on
      the MathML root.
      
      * mathml/presentation/text-indent-expected.html: Added.
      * mathml/presentation/text-indent.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a481ce9c
    • commit-queue@webkit.org's avatar
      Fix code that expects Page::chrome() to return a pointer · 680ddff5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116313
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-17
      Reviewed by Darin Adler.
      
      Page::chrome() returns a reference after r150214.
      
      * platform/network/blackberry/NetworkManager.cpp:
      (WebCore::NetworkManager::startJob):
      * platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
      (WebCore::SocketStreamHandle::SocketStreamHandle):
      * testing/Internals.cpp:
      (WebCore::Internals::resetToConsistentState):
      (WebCore::Internals::setEnableMockPagePopup):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      680ddff5
    • commit-queue@webkit.org's avatar
      [BlackBerry] ImageBlackBerry: add missing BlendMode parameter · 5e46690f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116316
      
      Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-17
      Reviewed by Carlos Garcia Campos.
      
      When the new BitmapImage::draw() method was added in r147110 it
      didn't include the BlendMode parameter, which has been there since
      r137011.
      
      * platform/graphics/blackberry/ImageBlackBerry.cpp:
      (WebCore::BitmapImage::draw):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e46690f
    • andersca@apple.com's avatar
      Reduce number of WebFrameLoaderClient static casts in WebKit · ed2df53f
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116320
      
      Reviewed by Antti Koivisto.
      
      We already have a function to return a WebFrame from a WebCore::Frame, use it.
      
      * DOM/WebDOMOperations.mm:
      (WebFrameFilter::shouldIncludeSubframe):
      * WebView/WebDataSource.mm:
      (-[WebDataSource webFrame]):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ed2df53f
    • jer.noble@apple.com's avatar
      Some media/track tests fail or assert on Mac · 3218481e
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=97132
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Rationalize the font and padding behavior of cues and cue boxes; ::cue pseudo elements cannot have padding
      values applied via CSS (due to padding not being included in the whitelist of applicable CSS properties).
      Also, the font values were being applied to the box at one level and the cue at another, leading to incorrect
      layout in the snapToLines case. Padding has been removed from the cue, and the font settings are now applied
      to the box exclusively.
      
      Additionally, a few drive-by changes were made in TextTrackCue to the return values of displayTreeInternal() &
      element(), which previously returned a PassRefPtr<> instead of a plain pointer.
      
      * css/mediaControls.css:
      (video::-webkit-media-text-track-container): Move the font size to the display selector.
      (video::cue): Remove the display:inline and padding:2px declarations.
      (video::-webkit-media-text-track-display): Remove the -webkit-line-content now that the ::cue has no padding.
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCue::TextTrackCue): The background box is now a span, rather than a forced-inline div.
      (WebCore::TextTrackCue::displayTreeInternal): Return a plain pointer.
      (WebCore::TextTrackCue::getDisplayTree): Ditto.
      (WebCore::TextTrackCue::setFontSize): Set the font on the box, not the cue.
      * html/track/TextTrackCue.h:
      (WebCore::TextTrackCue::element): Return a plain pointer.
      * html/track/TextTrackCueGeneric.cpp:
      (WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): The cue element is now a span, not a div.
      * page/CaptionUserPreferencesMac.mm:
      (WebCore::CaptionUserPreferencesMac::captionsWindowCSS): Whitespace.
      (WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Do not set padding on the cue.
      
      LayoutTests:
      
      * media/track/captions-webvtt/captions-snap-to-lines-not-set.vtt:
      * media/track/track-cue-rendering-horizontal.html:
      * media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
      * media/track/track-cue-rendering-snap-to-lines-not-set.html:
      * media/track/track-cue-rendering-vertical.html:
      * platform/mac/TestExpectations:
      * platform/mac/media/track/track-cue-rendering-horizontal-expected.png:
      * platform/mac/media/track/track-cue-rendering-horizontal-expected.txt:
      * platform/mac/media/track/track-cue-rendering-vertical-expected.png:
      * platform/mac/media/track/track-cue-rendering-vertical-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3218481e
    • akling@apple.com's avatar
      Changes in text-only properties shouldn't cause repaints unless there is actually text. · 2c42276b
      akling@apple.com authored
      <http://webkit.org/b/116250>
      
      Reviewed by Antti Koivisto.
      
      Add a new StyleDifferenceRepaintIfText value to the repertoire of RenderStyle::diff().
      This result means that the renderer only needs to repaint if one of its immediate children contains text.
      
      This lets us avoid repainting the same pixels when hovering over constructs like:
      
          <style>
              a { text-decoration: none; }
              a:hover { text-decoration: underline; }
          </style>
          <a href="http://is.gd/andersca">
              <img src="cool-hat.jpg">
          </a>
      
      Since the change in text-decoration has no effect on the rendering of the <img> element,
      we'll now be smart enough to avoid repainting it.
      
      * rendering/style/RenderStyleConstants.h:
      * rendering/style/RenderStyle.cpp:
      (WebCore::RenderStyle::diff):
      
          Move checking of text-only properties until the very end, and return StyleDifferenceRepaintIfText
          in case a difference is found, giving precedence to StyleDifferenceRepaint.
      
      * rendering/RenderObject.h:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::hasImmediateNonWhitespaceTextChild):
      
          Helper to check if a RenderObject has at least one RenderText child containing more than just
          collapsible whitespace.
      
      (WebCore::RenderObject::shouldRepaintForStyleDifference):
      
          Helper to check if a StyleDifference is either ...Repaint or ...RepaintIfText and the renderer
          has an immediate text child.
      
      (WebCore::RenderObject::styleWillChange):
      (WebCore::RenderObject::setStyle):
      
          Don't repaint for StyleDifferenceRepaintIfText unless hasImmediateNonWhitespaceTextChild().
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::styleDidChange):
      * rendering/svg/SVGResourcesCache.cpp:
      (WebCore::SVGResourcesCache::clientStyleChanged):
      
          Tweak for new StyleDifference enum value.
      
      * rendering/RenderText.h:
      * rendering/RenderText.cpp:
      (WebCore::RenderText::isAllCollapsibleWhitespace):
      
          Made this const.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2c42276b
    • commit-queue@webkit.org's avatar
      Improve -webkit-text-underline-position memory usage. · cb5953c8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116108
      
      Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-05-17
      Reviewed by Benjamin Poulain.
      
      Remove m_maxLogicalTop private variable from RootInlineBox to reduce
      the overall memory used to render RootInlineBoxes (eight bytes per RootInlineBox
      instance in a 64-bit machine). RootInline::maxLogicalTop() now computes
      the maxLogicalTop value everytime it is called. In a typical page
      computeMaxLogicalTop is called less than 10 times for each
      InlineTextBox that uses -webkit-text-underline-position. That is a small
      price users of -webkit-text-underline-position will pay so that
      everybody can benefit from the memory reduction in RootInlineBox.
      
      No new tests, no change in behavior.
      
      * rendering/InlineFlowBox.cpp:
      (WebCore::InlineFlowBox::computeMaxLogicalTop): Make it const.
      * rendering/InlineFlowBox.h:
      * rendering/RootInlineBox.cpp:
      (WebCore::RootInlineBox::RootInlineBox): Remove m_maxLogicalTop.
      (WebCore::RootInlineBox::alignBoxesInBlockDirection): Remove
      computeMaxLogicalTop call and obsolete comment.
      (WebCore):
      (WebCore::RootInlineBox::maxLogicalTop): Compute maxLogicalTop before
      returning its value.
      * rendering/RootInlineBox.h:
      (RootInlineBox):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb5953c8
    • mifenton@rim.com's avatar
      [BlackBerry] Remove stale comment for select mouse handling. · e1461e40
      mifenton@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=116309
      
      Reviewed by Rob Buis.
      
      PR 135935.
      
      Remove a FIXME that has been invalidated by a change
      to our touch -> mouse model.
      
      Internally Rubberstamped by Genevieve Mak.
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1461e40
    • kov@webkit.org's avatar
      Unreviewed build fix. Remove assertion that doesn't make sense anymore since the · d4d07655
      kov@webkit.org authored
      page does not give us access to the Chrome pointer directly anymore.
      
      Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-17
      
      * webkit/webkitwebview.cpp:
      (WebKit::kit):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4d07655
    • alexis@webkit.org's avatar
      Make sure to call release() on our smart pointers when we should. · a9dd2520
      alexis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116307
      
      Reviewed by Andreas Kling.
      
      Call release() when we should call it. There is probably more occurence
      of this problem on the codebase but this is a first bunch of fixes.
      
      No new tests : existing ones should cover.
      
      * css/CSSComputedStyleDeclaration.cpp:
      (WebCore::valueForNinePieceImage):
      (WebCore::getBorderRadiusShorthandValue):
      (WebCore::CSSComputedStyleDeclaration::valueForFilter):
      (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      (WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForSidesShorthand):
      (WebCore::CSSComputedStyleDeclaration::getCSSPropertyValuesForGridShorthand):
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseBorderImage):
      * html/HTMLBodyElement.cpp:
      (WebCore::HTMLBodyElement::collectStyleForPresentationAttribute):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9dd2520
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Support sub menu in ewk context menus · f31ea9b9
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114729
      
      Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2013-05-17
      Reviewed by Christophe Dumez.
      
      Added submenu support in EwkContextMenu and an API function to receive
      Ewk_Context_Menu from submenu context menu item. A test case was added
      for new API function.
      EwkContextMenu is now an EwkObject allowing multiple instances of submenu
      to be used in different submenu type context menu items.
      
      * UIProcess/API/efl/ewk_context_menu_item.cpp:
      (EwkContextMenuItem::EwkContextMenuItem):
      (ewk_context_menu_item_new):
      (ewk_context_menu_item_parent_menu_get):
      (ewk_context_menu_item_submenu_get):
      * UIProcess/API/efl/ewk_context_menu_item.h:
      * UIProcess/API/efl/ewk_context_menu_item_private.h:
      (EwkContextMenuItem::create):
      (EwkContextMenuItem::parentMenu):
      (EwkContextMenuItem::subMenu):
      (EwkContextMenuItem):
      * UIProcess/API/efl/ewk_context_menu_private.h:
      (EwkContextMenu::ewkView):
      (EwkContextMenu):
      * UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:
      (showContextMenu):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f31ea9b9
    • paroga@webkit.org's avatar
      [CMake] Remove invalid include paths · 21c8781c
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=116213
      
      Reviewed by Gyuyoung Kim.
      
      Since "${JAVASCRIPTCORE_DIR}/wtf" does not exist, it is safe
      to remove them from the list of include directories.
      
      Source/JavaScriptCore:
      
      * PlatformEfl.cmake: Removed.
      * PlatformGTK.cmake: Removed.
      
      Source/WTF:
      
      * wtf/PlatformEfl.cmake:
      * wtf/PlatformGTK.cmake:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21c8781c