- 05 Sep, 2013 40 commits
-
-
hyatt@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120789 Reviewed by Beth Dakin. * rendering/RenderListItem.cpp: (WebCore::RenderListItem::RenderListItem): (WebCore::RenderListItem::willBeDestroyed): (WebCore::RenderListItem::willBeRemovedFromTree): (WebCore::RenderListItem::layout): (WebCore::RenderListItem::addOverflowFromChildren): (WebCore::RenderListItem::computePreferredLogicalWidths): (WebCore::RenderListItem::paint): * rendering/RenderListItem.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120787 Reviewed by Beth Dakin. Make sure nobody can create a RenderBlock directly. Make sure RenderBlockFlows get made when a display:block/inline-block/compact/run-in is seen. * html/HTMLDetailsElement.cpp: (WebCore::HTMLDetailsElement::createRenderer): * html/HTMLSummaryElement.cpp: (WebCore::HTMLSummaryElement::createRenderer): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::createAnonymous): * rendering/RenderBlock.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::createObject): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155141 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120715 Reviewed by Tim Horton. In WebKitTestRunner, snapshots obtained via windowSnapshotImage() were sometimes blank if a previous test triggered compositing mode, and the current test or reference did not require compositing. This happened because the UI process didn't wait for the web process to complete its compositing mode switch before snapshotting. Fix by calling WKPageForceRepaint() before we take the snapshot; this is async, so we have to spin the runloop for a while. Remove the Qt/EFL code that does the same thing. * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback): (WTR::TestInvocation::dumpResults): * WebKitTestRunner/TestInvocation.h: * WebKitTestRunner/cairo/TestInvocationCairo.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): * WebKitTestRunner/qt/TestInvocationQt.cpp: (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
hyatt@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120777 Reviewed by Simon Fraser. This patch adds a new RenderBlockFlow class. The idea is to get all of the line/float/margin code out of RenderBlock and into the subclass, and then we can make RenderBlock an abstract base. This will save memory for all of the classes that derive from RenderBlock but have their own layout systems (e.g., flexbox, grid, table), and it will let us tighten up types to make it more clear when we're talking about block layout code vs. a more generic block-level object that can have any kind of layout. The only real change here is that isBlockFlow() has been renamed to isRenderBlockFlow() and is now checking if the object is a RenderBlockFlow. All of the block subclasses have been patched to be a RenderBlock or RenderBlockFlow. * CMakeLists.txt: * GNUmakefile.list.am: * Target.pri: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.xcodeproj/project.pbxproj: * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored): (WebCore::AccessibilityRenderObject::determineAccessibilityRole): * dom/Position.cpp: (WebCore::Position::isCandidate): (WebCore::Position::getInlineBoxAndOffset): (WebCore::Position::primaryDirection): * dom/PositionIterator.cpp: (WebCore::PositionIterator::isCandidate): * editing/ApplyStyleCommand.cpp: (WebCore::ApplyStyleCommand::applyInlineStyleToPushDown): * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded): * editing/Editor.cpp: (WebCore::Editor::baseWritingDirectionForSelectionStart): * editing/FrameSelection.cpp: (WebCore::caretRenderer): * editing/TextIterator.cpp: (WebCore::TextIterator::shouldRepresentNodeOffsetZero): * editing/TypingCommand.cpp: (WebCore::TypingCommand::makeEditableRootEmpty): * editing/htmlediting.cpp: (WebCore::isBlockFlowElement): * html/shadow/SliderThumbElement.cpp: (WebCore::RenderSliderThumb::RenderSliderThumb): * html/shadow/SliderThumbElement.h: * rendering/LayoutState.cpp: (WebCore::LayoutState::LayoutState): * rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock): (WebCore::RenderBlock::collapseMargins): (WebCore::RenderBlock::selectionGaps): (WebCore::RenderBlock::firstLineBoxBaseline): (WebCore::RenderBlock::lastLineBoxBaseline): (WebCore::RenderBlock::firstLineBlock): (WebCore::findFirstLetterBlock): (WebCore::shouldCheckLines): (WebCore::RenderBlock::adjustForBorderFit): * rendering/RenderBlock.h: * rendering/RenderBlockFlow.cpp: Added. (WebCore::RenderBlockFlow::RenderBlockFlow): (WebCore::RenderBlockFlow::~RenderBlockFlow): * rendering/RenderBlockFlow.h: Added. (WebCore::toRenderBlockFlow): * rendering/RenderBox.cpp: (WebCore::RenderBox::computeRectForRepaint): (WebCore::RenderBox::positionForPoint): * rendering/RenderBoxModelObject.h: (WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion): * rendering/RenderDeprecatedFlexibleBox.cpp: (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp): (WebCore::RenderDeprecatedFlexibleBox::clearLineClamp): * rendering/RenderDetailsMarker.cpp: (WebCore::RenderDetailsMarker::RenderDetailsMarker): * rendering/RenderDetailsMarker.h: * rendering/RenderFieldset.cpp: (WebCore::RenderFieldset::RenderFieldset): * rendering/RenderFieldset.h: * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::RenderFileUploadControl): * rendering/RenderFileUploadControl.h: * rendering/RenderFlowThread.cpp: (WebCore::RenderFlowThread::RenderFlowThread): * rendering/RenderFlowThread.h: * rendering/RenderFullScreen.cpp: * rendering/RenderInline.cpp: (WebCore::RenderInline::computeRectForRepaint): * rendering/RenderLineBoxList.cpp: (WebCore::RenderLineBoxList::dirtyLinesFromChangedChild): * rendering/RenderMeter.cpp: (WebCore::RenderMeter::RenderMeter): * rendering/RenderMeter.h: * rendering/RenderMultiColumnBlock.cpp: (WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock): * rendering/RenderMultiColumnBlock.h: * rendering/RenderObject.cpp: (WebCore::RenderObject::computeRectForRepaint): (WebCore::RenderObject::styleWillChange): (WebCore::firstLineStyleForCachedUncachedType): * rendering/RenderObject.h: (WebCore::RenderObject::isBR): (WebCore::RenderObject::isRenderBlockFlow): * rendering/RenderObjectChildList.cpp: (WebCore::RenderObjectChildList::insertChildNode): * rendering/RenderProgress.cpp: (WebCore::RenderProgress::RenderProgress): * rendering/RenderProgress.h: * rendering/RenderRegion.cpp: (WebCore::RenderRegion::RenderRegion): * rendering/RenderRegion.h: * rendering/RenderRuby.cpp: (WebCore::RenderRubyAsBlock::RenderRubyAsBlock): * rendering/RenderRuby.h: * rendering/RenderRubyBase.cpp: (WebCore::RenderRubyBase::RenderRubyBase): * rendering/RenderRubyBase.h: * rendering/RenderRubyRun.cpp: (WebCore::RenderRubyRun::RenderRubyRun): * rendering/RenderRubyRun.h: * rendering/RenderRubyText.cpp: (WebCore::RenderRubyText::RenderRubyText): * rendering/RenderRubyText.h: * rendering/RenderTableCaption.cpp: (WebCore::RenderTableCaption::RenderTableCaption): * rendering/RenderTableCaption.h: * rendering/RenderTableCell.cpp: (WebCore::RenderTableCell::RenderTableCell): * rendering/RenderTableCell.h: * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::RenderTextControl): * rendering/RenderTextControl.h: * rendering/RenderTextControlSingleLine.h: (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): * rendering/RenderTextTrackCue.cpp: (WebCore::RenderTextTrackCue::RenderTextTrackCue): * rendering/RenderTextTrackCue.h: * rendering/RenderView.cpp: (WebCore::RenderView::RenderView): * rendering/RenderView.h: * rendering/svg/RenderSVGBlock.cpp: (WebCore::RenderSVGBlock::RenderSVGBlock): * rendering/svg/RenderSVGBlock.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155139 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
timothy_horton@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120771 Reviewed by Anders Carlsson. * platform/graphics/cg/PDFDocumentImage.cpp: (WebCore::PDFDocumentImage::createPDFDocument): Use the (removed in r155069) PLATFORM(MAC) way of making a CGDataProvider from a SharedBuffer everywhere; this is what iOS was expecting to use (where I accidentally changed behavior), and it should also work for Windows, the only other USE(CG) platform. Since we only createPDFDocument() after all data has been received, I'm not restoring the comment about the SharedBuffer being secretly written to behind its back. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dino@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120716 <rdar://problem/14914499> Reviewed by Antoine Quint. As decided in: http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2013-September/040680.html Source/WebCore: * bindings/js/JSHTMLCanvasElementCustom.cpp: (WebCore::JSHTMLCanvasElement::probablySupportsContext): * html/HTMLCanvasElement.cpp: (WebCore::HTMLCanvasElement::probablySupportsContext): * html/HTMLCanvasElement.h: * html/HTMLCanvasElement.idl: LayoutTests: * fast/canvas/webgl/canvas-supports-context-expected.txt: * fast/canvas/webgl/canvas-supports-context.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155137 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
joepeck@webkit.org authored
Unreviewed build fix. * bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::evaluateBreakpointAction): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120782 Reviewed by Andreas Kling. Source/ThirdParty: Set CLANG_CXX_LANGUAGE_STANDARD to gnu++0x. * gtest/xcode/Config/General.xcconfig: Source/WebCore: Pass -std=gnu++11 when preprocessing wtf/Platform.h. * DerivedSources.make: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155135 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
joepeck@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120576 Reviewed by Timothy Hatcher. Give the CodeMirror editor for JavaScript Breakpoint Actions JS Runtime completions (like window, document, etc.). The logic was inside of JavaScriptLogViewController but was already entirely independent. Factor it out into its own class and plug it into CodeMirrorCompletionController as a "CompletionsProvider". Because the class hooks into a global event to reset some state, make it a singleton, so new instances are not leaked. * UserInterface/Main.html: * UserInterface/Main.js: (WebInspector.loaded): * UserInterface/RuntimeManager.js: Added. (WebInspector.RuntimeManager): (WebInspector.RuntimeManager.prototype.evalCallback): (WebInspector.RuntimeManager.prototype.evaluateInInspectedWindow): Move eval in window to new RuntimeManager. A slightly cleaner place to this since it is used both by the console and JS completions provider. * UserInterface/CodeMirrorCompletionController.js: (WebInspector.CodeMirrorCompletionController): (WebInspector.CodeMirrorCompletionController.prototype.setExtendedCompletionProvider): (WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition): Allow a completions provider plugin to completions controller. If one is available, this supercedes the delegate extend completions path. * UserInterface/BreakpointActionView.js: * UserInterface/ConsolePrompt.js: (WebInspector.ConsolePrompt): Use the new JS completions provider to get runtime JS completions. NOTE: ConsolePrompt still needs the delegate path for SQL completions. * UserInterface/JavaScriptLogViewController.js: (WebInspector.JavaScriptLogViewController): (WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted): * UserInterface/JavaScriptRuntimeCompletionProvider.js: Added. (WebInspector.JavaScriptRuntimeCompletionProvider): (get WebInspector.JavaScriptRuntimeCompletionProvider.prototype.): (get WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded): Move the JS completions code to a new class. No changes needed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155134 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
joepeck@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120576 Reviewed by Timothy Hatcher. * UserInterface/Breakpoint.js: (WebInspector.Breakpoint): (WebInspector.Breakpoint.prototype.get actions): (WebInspector.Breakpoint.prototype.get options): (WebInspector.Breakpoint.prototype.get info): (WebInspector.Breakpoint.prototype._serializableActions): Saving, restoring, and serialization. (WebInspector.Breakpoint.prototype.createAction): (WebInspector.Breakpoint.prototype.recreateAction): (WebInspector.Breakpoint.prototype.removeAction): (WebInspector.Breakpoint.prototype.breakpointActionDidChange): Modifying _actions ivar. (WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement): (WebInspector.Breakpoint.prototype._popoverActionsCreateAddActionButton): (WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked): (WebInspector.Breakpoint.prototype._popoverActionsInsertBreakpointActionView): (WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView): (WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView): (WebInspector.Breakpoint.prototype.breakpointActionViewResized): Popover UI containing breakpoint action views and converting to and from having no actions. (WebInspector.Breakpoint.prototype.willDismissPopover): Cleanup some ivars when the popover dismisses. * UserInterface/Breakpoint.css: (.popover .edit-breakpoint-popover-content.wide): Wider setting when there are actions in the popover. (.popover .edit-breakpoint-popover-content > table > tr > th): Keep the title labels at the top of their section. * UserInterface/BreakpointAction.js: (WebInspector.BreakpointAction): (WebInspector.BreakpointAction.prototype.get breakpoint): (WebInspector.BreakpointAction.prototype.get type): (WebInspector.BreakpointAction.prototype.get data): (WebInspector.BreakpointAction.prototype.set data): (WebInspector.BreakpointAction.prototype.get info): Very basic BreakpointAction class. Notifies Breakpoint on data changes. Type changes are not allowed, instead just create a new BreakpointAction. * UserInterface/BreakpointActionView.css: Added. (.breakpoint-action-block-header): (.breakpoint-action-remove-button): (.breakpoint-action-remove-button:active): (.breakpoint-action-append-button): (.breakpoint-action-block-body): (.breakpoint-action-block-body > input): (.breakpoint-action-eval-editor): (.breakpoint-action-eval-editor > .CodeMirror): (.breakpoint-action-eval-editor > .CodeMirror-scroll): * UserInterface/BreakpointActionView.js: Added. (WebInspector.BreakpointActionView): (WebInspector.BreakpointActionView.displayStringForType): (WebInspector.BreakpointActionView.prototype.get action): (WebInspector.BreakpointActionView.prototype.get element): (WebInspector.BreakpointActionView.prototype._pickerChanged): (WebInspector.BreakpointActionView.prototype._appendActionButtonClicked): (WebInspector.BreakpointActionView.prototype._removeActionButtonClicked): (WebInspector.BreakpointActionView.prototype._updateBody.switch.break): (WebInspector.BreakpointActionView.prototype._logInputChanged): (WebInspector.BreakpointActionView.prototype._codeMirrorBlurred): (WebInspector.BreakpointActionView.prototype._codeMirrorViewportChanged): UI and form controls for individual breakpoint actions. The view wraps a single BreakpointAction, and for any actions that could affect other views the delegate is notified. * UserInterface/DebuggerManager.js: (WebInspector.DebuggerManager): (WebInspector.DebuggerManager.prototype._debuggerBreakpointActionType): When sending to the backend, make sure to send protocol enums. * UserInterface/Popover.js: (WebInspector.Popover.prototype.update): Update the popover when content changes. * UserInterface/Images/BreakpointActionAdd.svg: Added. * UserInterface/Images/BreakpointActionRemove.svg: Added. * UserInterface/InspectorBackendCommands.js: * UserInterface/Main.html: * Localizations/en.lproj/localizedStrings.js: Misc. New strings, images, includes. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155133 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
joepeck@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120576 Reviewed by Timothy Hatcher. Source/WebCore: Tests: inspector-protocol/debugger/setBreakpoint-actions.html inspector-protocol/debugger/setBreakpoint-options-exception.html * inspector/ScriptBreakpoint.h: (WebCore::ScriptBreakpointAction::ScriptBreakpointAction): (WebCore::ScriptBreakpoint::ScriptBreakpoint): Struct for a breakpoint action. Type and string of data. * bindings/js/ScriptDebugServer.h: * bindings/js/ScriptDebugServer.cpp: (WebCore::ScriptDebugServer::hasBreakpoint): (WebCore::ScriptDebugServer::evaluateBreakpointAction): (WebCore::ScriptDebugServer::evaluateBreakpointActions): (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded): (WebCore::ScriptDebugServer::pauseIfNeeded): When a breakpoint is triggered evaluate each of its breakpoint actions in order. If there are exceptions, log them. * inspector/Inspector.json: * inspector/InspectorDebuggerAgent.cpp: (WebCore::buildObjectForBreakpointCookie): (WebCore::InspectorDebuggerAgent::didParseSource): Save and restore breakpoint actions where needed. (WebCore::breakpointActionTypeForString): (WebCore::breakpointActionsFromProtocol): (WebCore::InspectorDebuggerAgent::setBreakpointByUrl): (WebCore::InspectorDebuggerAgent::setBreakpoint): Parse optional breakpoint actions from the protocol into ScriptBreakpointAction objects. LayoutTests: * inspector-protocol/debugger/resources/breakpoint.js: * inspector-protocol/debugger/setBreakpoint-actions-expected.txt: Added. * inspector-protocol/debugger/setBreakpoint-actions.html: Added. * inspector-protocol/debugger/setBreakpoint-options-exception-expected.txt: Added. * inspector-protocol/debugger/setBreakpoint-options-exception.html: Added. * inspector-protocol/resources/console-helper.js: Added. (ConsoleHelper.simplifiedConsoleMessage): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
simon.fraser@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120780 Reviewed by Tim Horton. When a repaint happened on a layer with a filter, and which paints into its compositing ancestor, we'd repaint the wrong layer (and assert). Fix by ensuring that RenderLayer::enclosingFilterLayer() takes paintsIntoCompositedAncestor() into account, by adding a function that we share between three callers who check isComposited() && !paintsIntoCompositedAncestor(). I didn't use a function on RenderLayer, because I wanted it to be inline but to not #include RenderLayerBacking in RenderLayer.h. Test: compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html * dom/Node.cpp: Drive-by removal of #include "RenderLayer.h" * rendering/RenderLayer.cpp: (WebCore::compositedWithOwnBackingStore): (WebCore::RenderLayer::enclosingCompositingLayerForRepaint): (WebCore::RenderLayer::enclosingFilterRepaintLayer): (WebCore::RenderLayer::clippingRootForPainting): LayoutTests: Fix repaint issue on "paints into ancestor" filtered layers https://bugs.webkit.org/show_bug.cgi?id=120780 <rdar://problem/14884148> Reviewed by Tim Horton. Ref test for opacity change on a filtered layer which paints into its compositing ancestor. * compositing/filters/opacity-change-on-filtered-paints-into-ancestor-expected.html: Added. * compositing/filters/opacity-change-on-filtered-paints-into-ancestor.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155131 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
consistent about using debug-build support libraries. Now that <rdar://problem/9898937> is resolved, we should be linking to debug AVFoundationCF as well. * page/CaptionUserPreferencesMediaAF.cpp: Link to AVFoundationCF_debug when building with the DEBUG_ALL target. * platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Ditto. * platform/graphics/avfoundation/cf/AVFoundationCFSoftLinking.h: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120699 Adding tests expectations to the current GTK's trackmenu implementation. Also adding a in-band-track test expectation as failure since we don't support in-band tracks yet. Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2013-09-05 Reviewed by Gustavo Noronha Silva. * platform/gtk/TestExpectations: * platform/gtk/media/video-controls-captions-trackmenu-expected.txt: Added. * platform/gtk/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added. * platform/gtk/media/video-controls-captions-trackmenu-localized-expected.txt: Added. * platform/gtk/media/video-controls-captions-trackmenu-sorted-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155128 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
roger_fong@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120712. <rdar://problem/14883216>. Reviewed by Brent Fulgham. * platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155127 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
* wtf/text/StringBuffer.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155126 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
berto@igalia.com authored
https://bugs.webkit.org/show_bug.cgi?id=120762 Reviewed by Gustavo Noronha Silva. The code to disable AC under Wayland is not run if we're using WebKitTestRunner, so it would be better to move it to WebKitWebViewBase. However it's not really necessary to do that, instead it's much simpler to disable accelerated compositing in all cases unless we know we can support it. * UIProcess/API/gtk/WebKitWebViewBase.cpp: (webkitWebViewBaseUpdatePreferences): * UIProcess/API/gtk/WebKitWebViewGroup.cpp: (webkitWebViewGroupAttachSettingsToPageGroup): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155125 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120766 Reviewed by Filip Pizlo. * BuildSlaveSupport/build.webkit.org-config/master.cfg: (RunJavaScriptCoreTests.commandComplete): (RunJavaScriptCoreTests.getText2): * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: (RunJavaScriptCoreTestsTest): Added. (RunJavaScriptCoreTestsTest.assertResults): (RunJavaScriptCoreTestsTest.test_no_regressions_old_output): (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output): (RunJavaScriptCoreTestsTest.test_mozilla_failure_new_output): (RunJavaScriptCoreTestsTest.test_fast_js_failure_new_output): (RunJavaScriptCoreTestsTest.test_fast_js_crash_new_output): (RunJavaScriptCoreTestsTest.test_mozilla_and_fast_js_failure_new_output): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bfulgham@apple.com authored
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters: Don't build 64-bit assembly in 32-bit build. Also correct 'filters' file so that files appear in categories that match their on-disk locations. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155123 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120723 Rubber stamped by Oliver Hunt. Convert more tests. * fast/js/dfg-branch-logical-not-peephole-around-osr-exit-expected.txt: * fast/js/dfg-branch-not-fail-expected.txt: * fast/js/dfg-byte-array-put-expected.txt: * fast/js/dfg-call-function-hit-watchpoint-expected.txt: * fast/js/dfg-call-method-hit-watchpoint-expected.txt: * fast/js/dfg-captured-var-get-local-expected.txt: * fast/js/dfg-cfa-merge-with-dead-use-at-tail-expected.txt: * fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement-expected.txt: * fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-expected.txt: * fast/js/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof-expected.txt: * fast/js/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local-expected.txt: * fast/js/dfg-cfg-simplify-redundant-dead-get-local-expected.txt: * fast/js/dfg-check-function-change-structure-expected.txt: * fast/js/jsc-test-list: * fast/js/script-tests/dfg-branch-logical-not-peephole-around-osr-exit.js: * fast/js/script-tests/dfg-branch-not-fail.js: * fast/js/script-tests/dfg-byte-array-put.js: * fast/js/script-tests/dfg-call-function-hit-watchpoint.js: * fast/js/script-tests/dfg-call-method-hit-watchpoint.js: * fast/js/script-tests/dfg-captured-var-get-local.js: * fast/js/script-tests/dfg-cfa-merge-with-dead-use-at-tail.js: * fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null-and-decrement.js: * fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-branch-not-null.js: * fast/js/script-tests/dfg-cfg-simplify-eliminate-set-local-type-check-then-typeof.js: * fast/js/script-tests/dfg-cfg-simplify-phantom-get-local-on-same-block-set-local.js: * fast/js/script-tests/dfg-cfg-simplify-redundant-dead-get-local.js: * fast/js/script-tests/dfg-check-function-change-structure.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155122 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120718 Reviewed by Andreas Kling. Source/WebCore: Change FormStreamFields::currentData to an OwnPtr. * platform/network/cf/FormDataStreamCFNet.cpp: (WebCore::closeCurrentStream): (WebCore::advanceCurrentStream): (WebCore::formCreate): Source/WTF: Change Vector::releaseBuffer() to return an OwnPtr. I intentionally chose to use an OwnPtr over a PassOwnPtr since we're trying to move away from PassOwnPtr objects. Fix fallout from this change by adopting OwnPtr/PassOwnPtr in StringBuffer and the two StringImpl constructors that adopt the passed in pointer. * wtf/Vector.h: * wtf/text/StringBuffer.h: * wtf/text/StringImpl.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155121 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
akling@apple.com authored
<https://webkit.org/b/120758> This didn't work so well on Qt bots. Will have to take bigger steps here instead of iterating. * history/CachedFrame.h: (WebCore::CachedFrame::create): * history/CachedPage.cpp: (WebCore::CachedPage::create): * history/CachedPage.h: * history/HistoryItem.h: * loader/FrameLoader.cpp: (WebCore::FrameLoader::commitProvisionalLoad): (WebCore::FrameLoader::transitionToCommitted): * loader/FrameLoader.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155120 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
andersca@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120720 Reviewed by Andreas Kling. Change AnimationList::operator[] to return an Animation& and fix up related code to also take references. * css/CSSComputedStyleDeclaration.cpp: * css/DeprecatedStyleBuilder.cpp: * page/animation/CompositeAnimation.cpp: * page/animation/KeyframeAnimation.cpp: * platform/animation/Animation.h: * platform/animation/AnimationList.cpp: * platform/animation/AnimationList.h: * rendering/RenderLayerBacking.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155119 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120759 Reviewed by Filip Pizlo. * Scripts/run-fast-jsc: Remove bashisms to make bash, dash and Darwin's /bin/sh happy. * Scripts/run-javascriptcore-tests: Enable run-fast-jsc tests everywhere, except Windows. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155118 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
Mozilla tests appears to run for a longer time. I think we want to continue to allow a few tests here and there to be longer-running, rather than excluding them. I seem to recall that those tests catch good bugs. * Scripts/run-javascriptcore-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155117 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=120770 Reviewed by Andreas Kling. There is no need to call this during recursive attach as siblings are going to be attached normally anyway. Move call sites to attach roots only. * style/StyleResolveTree.cpp: (WebCore::Style::createTextRenderersForSiblingsAfterAttachIfNeeded): Factor to take reference and do the inital tests itself. (WebCore::Style::createTextRendererIfNeeded): (WebCore::Style::updateTextRendererAfterContentChange): (WebCore::Style::attachChildren): Also tightened the condition where previously attached children may be encountered. (WebCore::Style::attachRenderTree): (WebCore::Style::resolveLocal): (WebCore::Style::updateTextStyle): (WebCore::Style::reattachRenderTree): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155116 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mikhail.pozdnyakov@intel.com authored
https://bugs.webkit.org/show_bug.cgi?id=120767 Reviewed by Anders Carlsson. The String(RefPtr<StringImpl>) constructor should be removed for the following reasons: - It almost does not have clients, so it is unneeded. - RefPtr should never be passed by value * wtf/text/StringBuilder.cpp: (WTF::StringBuilder::shrinkToFit): * wtf/text/WTFString.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120760 Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-09-05 Reviewed by Antti Koivisto. I have also removed text-align:justify from the tests because its not relevant to the tested functionality and it makes creating the expected results very difficult because of the way fragmented text is rendered when it's aligned justified. * fast/regions/overflow-in-uniform-regions-dynamic-expected.html: Added. * fast/regions/overflow-in-uniform-regions-dynamic.html: * fast/regions/overflow-in-variable-width-regions-expected.html: Added. * fast/regions/overflow-in-variable-width-regions.html: * fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.html: Added. * fast/regions/overflow-moving-below-floats-in-variable-width-regions.html: * fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.html: Added. * fast/regions/overflow-not-moving-below-floats-in-variable-width-regions.html: * fast/regions/overflow-rtl-in-variable-width-regions-expected.html: Added. * fast/regions/overflow-rtl-in-variable-width-regions.html: * fast/regions/overflow-size-change-in-variable-width-regions-expected.html: Added. * fast/regions/overflow-size-change-in-variable-width-regions.html: * platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed. * platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed. * platform/efl/fast/regions/overflow-in-variable-width-regions-expected.png: Removed. * platform/efl/fast/regions/overflow-in-variable-width-regions-expected.txt: Removed. * platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed. * platform/efl/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed. * platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed. * platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Removed. * platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed. * platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed. * platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed. * platform/gtk/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed. * platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.png: Removed. * platform/gtk/fast/regions/overflow-in-variable-width-regions-expected.txt: Removed. * platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed. * platform/gtk/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed. * platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed. * platform/gtk/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Removed. * platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed. * platform/gtk/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed. * platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed. * platform/mac/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed. * platform/mac/fast/regions/overflow-in-variable-width-regions-expected.png: Removed. * platform/mac/fast/regions/overflow-in-variable-width-regions-expected.txt: Removed. * platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed. * platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed. * platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed. * platform/mac/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Removed. * platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed. * platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed. * platform/qt-wk2/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed. * platform/qt-wk2/fast/regions/overflow-in-variable-width-regions-expected.png: Removed. * platform/qt-wk2/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed. * platform/qt-wk2/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed. * platform/qt-wk2/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed. * platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed. * platform/qt/fast/regions/overflow-in-uniform-regions-dynamic-expected.txt: Removed. * platform/qt/fast/regions/overflow-in-variable-width-regions-expected.png: Removed. * platform/qt/fast/regions/overflow-in-variable-width-regions-expected.txt: Removed. * platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Removed. * platform/qt/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt: Removed. * platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed. * platform/qt/fast/regions/overflow-rtl-in-variable-width-regions-expected.txt: Removed. * platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed. * platform/qt/fast/regions/overflow-size-change-in-variable-width-regions-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155114 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=118905 Patch by Enrique Ocaña González <eocanha@igalia.com> on 2013-09-05 Reviewed by Philippe Normand. Checked that the custom cursor image and its pixbuf is valid and create a null cursor otherwise. * platform/gtk/CursorGtk.cpp: (WebCore::createCustomCursor): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=119739 Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-09-05 Reviewed by Philippe Normand. WebAudio Specification suggests to use 'double' datatypes for minDecibels, maxDecibels and smoothingTimeConstant in AnalyserNode.idl and currentTime in AudioContext.idl. Current WebKit implementation has declared these attributes as 'float' type. Spec: https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AudioContext-section https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html#AnalyserNode No new tests, covered by existing tests. * Modules/webaudio/AnalyserNode.cpp: (WebCore::AnalyserNode::setMinDecibels): (WebCore::AnalyserNode::setMaxDecibels): (WebCore::AnalyserNode::setSmoothingTimeConstant): * Modules/webaudio/AnalyserNode.h: (WebCore::AnalyserNode::minDecibels): (WebCore::AnalyserNode::maxDecibels): (WebCore::AnalyserNode::smoothingTimeConstant): * Modules/webaudio/AnalyserNode.idl: * Modules/webaudio/AudioContext.idl: * Modules/webaudio/RealtimeAnalyser.h: (WebCore::RealtimeAnalyser::setMinDecibels): (WebCore::RealtimeAnalyser::minDecibels): (WebCore::RealtimeAnalyser::setMaxDecibels): (WebCore::RealtimeAnalyser::maxDecibels): (WebCore::RealtimeAnalyser::setSmoothingTimeConstant): (WebCore::RealtimeAnalyser::smoothingTimeConstant): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120665 Patch by Brendan Long <b.long@cablelabs.com> on 2013-09-05 Reviewed by Philippe Normand. * platform/efl/TestExpectations: Skip new media/track/in-band tests. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zarvai@inf.u-szeged.hu authored
* platform/qt-wk1/TestExpectations: Unskipping after 155104. * platform/qt/TestExpectations: Unskipping after r155061. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155110 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mihnea@adobe.com authored
https://bugs.webkit.org/show_bug.cgi?id=120397 Reviewed by Darin Adler. As regions will become anonymous blocks nested inside elements with the flow-from property, a first step would be to change the calls to node() with calls to generatingNode(). In the case of regions, generatingNode() will always return an Element* and not a Node*. Therefore, to get rid of toElement() casts, i created a specific method RenderRegion::generatingElement that will return the generating node as Element. No new tests as no functional change was introduced. Original patch by Catalin Badea. * css/ElementRuleCollector.cpp: (WebCore::ElementRuleCollector::collectMatchingRulesForRegion): * dom/WebKitNamedFlow.cpp: (WebCore::WebKitNamedFlow::getRegionsByContent): (WebCore::WebKitNamedFlow::getRegions): * rendering/RenderRegion.cpp: (WebCore::RenderRegion::regionOversetState): (WebCore::RenderRegion::setRegionOversetState): (WebCore::RenderRegion::checkRegionStyle): * rendering/RenderRegion.h: (WebCore::RenderRegion::generatingElement): * rendering/RenderTreeAsText.cpp: (WebCore::writeRenderRegionList): For pseudo-elements as regions, i want to print {pseudo} instead of {div} marker for the parent. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155109 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120532 Reviewed by Darin Adler. * CMakeLists.txt: * PlatformEfl.cmake: * PlatformGTK.cmake: * WebCore.vcxproj/WebCore.vcxproj: * WebCore.vcxproj/WebCore.vcxproj.filters: * platform/network/SynchronousLoaderClient.cpp: * platform/network/cf/SynchronousLoaderClientCFNet.cpp: Added. (WebCore::SynchronousLoaderClient::didReceiveAuthenticationChallenge): (WebCore::SynchronousLoaderClient::platformBadResponseError): * platform/network/soup/SynchronousLoaderClientSoup.cpp: Added. (WebCore::SynchronousLoaderClient::didReceiveAuthenticationChallenge): (WebCore::SynchronousLoaderClient::platformBadResponseError): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
jinwoo7.song@samsung.com authored
<https://webkit.org/b/120761> Reviewed by Gyuyoung Kim. Fix warning by removing unused parameter. * accessibility/atk/WebKitAccessibleInterfaceText.cpp: (sentenceAtPositionForAtkBoundary): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ljaehun.lim@samsung.com authored
Source/WTF/wtf/Vector.h:1210:48: error: ‘>>’ should be ‘> >’ within a nested template argument list * wtf/Vector.h: Add missing space. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=105408 Reviewed by Dean Jackson. Source/WebCore: Adding an early return if from or to clip-path values are 'none'. According to the specification we shall just interpolate between two basic shapes. http://dev.w3.org/csswg/css-shapes/#basic-shape-interpolation * page/animation/CSSPropertyAnimation.cpp: (WebCore::blendFunc): LayoutTests: Test that animation from none to a basic shape on -webkit-clip-path doesn't crash. * css3/masking/clip-path-animation-expected.txt: * css3/masking/clip-path-animation.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155105 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=120683 Patch by Andre Moreira Magalhaes <andre.magalhaes@collabora.co.uk> on 2013-09-05 Reviewed by Philippe Normand. Do not set pipeline state to NULL on MediaPlayerPrivateGStreamer::loadingFailed() otherwise the bus is flushed and we never get a GST_MESSAGE_ERROR when failing to load uris. Also restore previous behaviour (before r154988) of not invoking loadingFailed() for all failed manual state change attempts. * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::changePipelineState): Do not call loadingFailed() if state change fails as all manual state changes are now done with changePipelineState(). (WebCore::MediaPlayerPrivateGStreamer::play): (WebCore::MediaPlayerPrivateGStreamer::pause): (WebCore::MediaPlayerPrivateGStreamer::seek): (WebCore::MediaPlayerPrivateGStreamer::handleMessage): Restore previous behaviour (before changeset r154988) when calling changePipelineState(). (WebCore::MediaPlayerPrivateGStreamer::updateStates): Do nothing if changing to READY on EOS (same behaviour as setting to NULL as it was before changeset r154988). (WebCore::MediaPlayerPrivateGStreamer::loadingFailed): Do not set pipeline state to NULL so we properly get GST_MESSAGE_ERROR on loading failures. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155104 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
fpizlo@apple.com authored
can't support it because if non-bourne shells. This fixes part #2 of the Linux bot breakage. * Scripts/run-javascriptcore-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
berto@igalia.com authored
https://bugs.webkit.org/show_bug.cgi?id=120703 Reviewed by Carlos Garcia Campos. Fix member initialization so it matches their declaration [-Wreorder]. * html/shadow/MediaControlsGtk.cpp: (WebCore::MediaControlsGtk::MediaControlsGtk): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155102 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-