1. 23 Jan, 2012 1 commit
  2. 21 Jan, 2012 1 commit
  3. 08 Dec, 2011 1 commit
    • pierre.rossi@gmail.com's avatar
      Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision. · 573e9472
      pierre.rossi@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=73916
      
      Source/WebCore:
      
      This was needed for Qt since the mobile theme, which can be picked
      up at runtime, delegates the rendering of list boxes.
      
      Reviewed by Kent Tamura.
      
      No new tests, there's no functional change.
      
      * html/HTMLSelectElement.cpp:
      (WebCore::HTMLSelectElement::usesMenuList):
      * html/HTMLSelectElement.h:
      * platform/PopupMenuClient.h:
      (WebCore::PopupMenuClient::listBoxSelectItem):
      (WebCore::PopupMenuClient::multiple):
      * platform/qt/RenderThemeQtMobile.h:
      (WebCore::RenderThemeQtMobile::delegatesMenuListRendering):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::multiple):
      * rendering/RenderMenuList.h:
      * rendering/RenderTheme.h:
      (WebCore::RenderTheme::delegatesMenuListRendering):
      
      Source/WebKit/chromium:
      
      Reviewed by Kent Tamura.
      
      * src/ExternalPopupMenu.cpp:
      (WebKit::ExternalPopupMenu::didAcceptIndices):
      (WebKit::ExternalPopupMenu::getPopupMenuInfo):
      
      Source/WebKit/qt:
      
      Reviewed by Kent Tamura.
      
      * WebCoreSupport/PopupMenuQt.cpp:
      (SelectData::multiple):
      (WebCore::PopupMenuQt::selectItem):
      
      Tools:
      
      Reviewed by Kent Tamura.
      
      * qmake/mkspecs/features/features.prf:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@102419 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      573e9472
  4. 07 Nov, 2011 1 commit
    • eae@chromium.org's avatar
      Revert platform and scrolling to ints · 92a579fe
      eae@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71585
      
      Reviewed by Eric Seidel.
      
      Replace all uses of LayoutUnit and related types with ints in platform
      and scrolling code.
      
      Source/WebCore:
      
      No new tests.
      
      * page/FrameView.cpp:
      * page/FrameView.h:
      * platform/PopupMenuClient.h:
      * platform/ScrollAnimatorNone.cpp:
      * platform/ScrollAnimatorNone.h:
      * platform/ScrollView.cpp:
      * platform/ScrollView.h:
      * platform/ScrollableArea.h:
      * rendering/RenderLayer.cpp:
      * rendering/RenderLayer.h:
      * rendering/RenderListBox.cpp:
      * rendering/RenderListBox.h:
      * rendering/RenderMenuList.cpp:
      * rendering/RenderMenuList.h:
      * rendering/RenderTextControlSingleLine.cpp:
      * rendering/RenderTextControlSingleLine.h:
      
      Source/WebKit/chromium:
      
      * tests/ScrollAnimatorNoneTest.cpp:
      (MockScrollableArea::visibleHeight):
      (MockScrollableArea::visibleWidth):
      
      Source/WebKit2:
      
      * WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
      (WebKit::BuiltInPDFView::invalidateScrollbarRect):
      (WebKit::BuiltInPDFView::visibleHeight):
      (WebKit::BuiltInPDFView::visibleWidth):
      * WebProcess/Plugins/PDF/BuiltInPDFView.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92a579fe
  5. 01 Nov, 2011 1 commit
    • eae@chromium.org's avatar
      Switch PopupMenuClient to layout abstraction · d8d1f3b6
      eae@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=71308
      
      Reviewed by Darin Adler.
      
      Switch PopupMenuClient and rendering classes implementing it to layout
      type abstraction.
      
      No new tests.
      
      * platform/PopupMenuClient.h:
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::listIndexAtOffset):
      (WebCore::RenderListBox::panScroll):
      (WebCore::RenderListBox::scrollToward):
      (WebCore::RenderListBox::scrollSize):
      (WebCore::RenderListBox::scrollPosition):
      (WebCore::RenderListBox::setScrollOffset):
      (WebCore::RenderListBox::verticalScrollbarWidth):
      Revert scroll positions and scroll offsets to ints to align with device
      pixels.
      
      * rendering/RenderListBox.h:
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::showPopup):
      (WebCore::RenderMenuList::clientPaddingLeft):
      (WebCore::RenderMenuList::clientPaddingRight):
      * rendering/RenderMenuList.h:
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::hitInnerTextElement):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::clientPaddingLeft):
      (WebCore::RenderTextControlSingleLine::clientPaddingRight):
      * rendering/RenderTextControlSingleLine.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@99016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8d1f3b6
  6. 11 Oct, 2011 2 commits
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r97202, r97207, and r97215. · 27e694b0
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/97202
      http://trac.webkit.org/changeset/97207
      http://trac.webkit.org/changeset/97215
      https://bugs.webkit.org/show_bug.cgi?id=69894
      
      Broke builds (Requested by rniwa on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-11
      
      Source/WebCore:
      
      * platform/PopupMenuClient.h:
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::showPopup):
      * rendering/RenderMenuList.h:
      * rendering/RenderObject.h:
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::showPopup):
      * rendering/RenderTextControlSingleLine.h:
      * testing/Internals.cpp:
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/chromium:
      
      * src/AutofillPopupMenuClient.cpp:
      * src/AutofillPopupMenuClient.h:
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::applyAutofillSuggestions):
      * tests/PopupMenuTest.cpp:
      
      LayoutTests:
      
      * fast/dom/popup-menu-client-test-expected.txt: Removed.
      * fast/dom/popup-menu-client-test.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@97220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27e694b0
    • fsamuel@chromium.org's avatar
      Towards making PopupMenuClient more testable · aa54be8f
      fsamuel@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=69631
      
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Added some functions to window.internals to allow testing of parts of PopupMenuClient.
      
      Test: fast/dom/popup-menu-client-test.html
      
      * platform/PopupMenuClient.h:
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::showPopup):
      (WebCore::RenderMenuList::boundingBoxRect):
      * rendering/RenderMenuList.h:
      (WebCore::RenderMenuList::RenderMenuList::isPopupMenuClient):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::isPopupMenuClient):
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::showPopup):
      (WebCore::RenderTextControlSingleLine::boundingBoxRect):
      * rendering/RenderTextControlSingleLine.h:
      (WebCore::RenderTextControlSingleLine::isPopupMenuClient):
      * testing/Internals.cpp:
      (WebCore::Internals::toPopupMenuClient):
      (WebCore::Internals::popupClientPaddingLeft):
      (WebCore::Internals::popupClientPaddingRight):
      (WebCore::Internals::popupClientBoundingBoxRect):
      * testing/Internals.h:
      * testing/Internals.idl:
      
      Source/WebKit/chromium:
      
      * src/AutofillPopupMenuClient.cpp:
      (WebKit::AutofillPopupMenuClient::boundingBoxRect):
      * src/AutofillPopupMenuClient.h:
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::applyAutofillSuggestions):
      
      LayoutTests:
      
      * fast/dom/popup-menu-client-test-expected.txt: Added.
      * fast/dom/popup-menu-client-test.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@97202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa54be8f
  7. 12 Aug, 2011 1 commit
    • leviw@chromium.org's avatar
      Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units · 6eb4400c
      leviw@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66149
      
      Reviewed by Eric Seidel.
      
      Changing RenderMenuList, RenderListBox, and RenderFieldSet to the LayoutUnit
      abstraction from ints.
      
      No tests as no change in functionality.
      
      * rendering/RenderFieldset.cpp:
      (WebCore::RenderFieldset::layoutSpecialExcludedChild):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::numVisibleItems):
      (WebCore::RenderListBox::listHeight):
      (WebCore::RenderListBox::baselinePosition):
      (WebCore::RenderListBox::itemBoundingBoxRect):
      (WebCore::itemOffsetForAlignment):
      (WebCore::RenderListBox::panScroll):
      (WebCore::RenderListBox::scrollToward):
      (WebCore::RenderListBox::autoscroll):
      (WebCore::RenderListBox::scrollSize):
      (WebCore::RenderListBox::scrollPosition):
      (WebCore::RenderListBox::setScrollOffset):
      (WebCore::RenderListBox::itemHeight):
      (WebCore::RenderListBox::verticalScrollbarWidth):
      (WebCore::RenderListBox::scrollWidth):
      (WebCore::RenderListBox::scrollHeight):
      (WebCore::RenderListBox::scrollLeft):
      (WebCore::RenderListBox::setScrollLeft):
      (WebCore::RenderListBox::scrollTop):
      (WebCore::RenderListBox::setScrollTop):
      (WebCore::RenderListBox::controlClipRect):
      (WebCore::RenderListBox::invalidateScrollbarRect):
      (WebCore::RenderListBox::convertFromScrollbarToContainingView):
      (WebCore::RenderListBox::convertFromContainingViewToScrollbar):
      (WebCore::RenderListBox::contentsSize):
      (WebCore::RenderListBox::currentMousePosition):
      * rendering/RenderListBox.h:
      (WebCore::RenderListBox::scrollCornerRect):
      (WebCore::RenderListBox::invalidateScrollCornerRect):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::controlClipRect):
      (WebCore::RenderMenuList::showPopup):
      * rendering/RenderMenuList.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@92998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6eb4400c
  8. 18 Jul, 2011 2 commits
    • jhoneycutt@apple.com's avatar
      Focus and selection events are not fired when a <select>'s selection · a461af4e
      jhoneycutt@apple.com authored
      changes
      https://bugs.webkit.org/show_bug.cgi?id=64504
      <rdar://problem/9319881>
      
      Reviewed by Alice Liu.
      
      Source/WebCore:
      
      Test: platform/win/accessibility/option-element-selection-and-focus-events.html
      
      * accessibility/chromium/AXObjectCacheChromium.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      Add new notification type to the section of unhandled notifications.
      
      * accessibility/AXObjectCache.h:
      Declare a new notification, AXMenuListItemSelected.
      
      * accessibility/AccessibilityMenuList.cpp:
      (WebCore::AccessibilityMenuList::didUpdateActiveOption):
      Tell our child popup that the active option changed, and post a
      notification that our value changed.
      
      * accessibility/AccessibilityMenuList.h:
      Declare didUpdateActiveOption().
      
      * accessibility/AccessibilityMenuListPopup.cpp:
      (WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
      Get the child <option> element that is selected, and fire focus and
      selection events for it.
      
      * accessibility/AccessibilityMenuListPopup.h:
      Declare didUpdateActiveOption().
      
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      Map AXMenuListItemSelected -> EVENT_OBJECT_SELECTION.
      
      * dom/SelectElement.cpp:
      (WebCore::SelectElement::setSelectedIndex):
      Pass the newly-selected index.
      
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::RenderMenuList):
      Update the initialization list for the renamed m_lastActiveIndex.
      (WebCore::RenderMenuList::setTextFromOption):
      A new selection has been made in the popup; call
      didUpdateActiveOption().
      (WebCore::RenderMenuList::didSetSelectedIndex):
      Call didUpdateActiveOption(), passing the index of the newly-selected
      <option>.
      (WebCore::RenderMenuList::didUpdateActiveOption):
      If accessibility is disabled, or if the active option has not changed,
      return early. Check whether the option index is in the range of list
      items, and assert that the item at that index is an <option> element.
      Tell the AccessibilityMenuList for this element that we updated the
      active option.
      
      * rendering/RenderMenuList.h:
      Updated the declaration of didSetSelectedIndex() to take the selected
      index. Declared didUpdateActiveOption(). Renamed m_lastSelectedIndex to
      m_lastActiveIndex.
      
      Tools:
      
      * DumpRenderTree/AccessibilityController.h:
      Added m_notificationsEventHook for addNotificationListener().
      m_allEventsHook will now be used for setLogAccessibilityEvents().
      
      * DumpRenderTree/win/AccessibilityControllerWin.cpp:
      (AccessibilityController::AccessibilityController):
      Initialize m_notificationsEventHook.
      (AccessibilityController::~AccessibilityController):
      Turn off logging of all accessibility events. If
      m_notificationsEventHook is non-null, unhook it.
      (logEventProc):
      Add handling of EVENT_OBJECT_SELECTION.
      (AccessibilityController::setLogAccessibilityEvents):
      If the state of logging is not changing, return early. If we're turning
      off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
      hook for all events.
      (AccessibilityController::addNotificationListener):
      Use m_notificationsEventHook rather than m_allEventsHook.
      
      LayoutTests:
      
      * platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
      * platform/win/accessibility/option-element-selection-and-focus-events.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a461af4e
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r91132 and r91135. · b09331a7
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/91132
      http://trac.webkit.org/changeset/91135
      https://bugs.webkit.org/show_bug.cgi?id=64681
      
      Broke GTK and Chromium debug bots (Requested by rniwa on
      #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-07-18
      
      Source/WebCore:
      
      * accessibility/AXObjectCache.h:
      * accessibility/AccessibilityMenuList.cpp:
      * accessibility/AccessibilityMenuList.h:
      * accessibility/AccessibilityMenuListPopup.cpp:
      * accessibility/AccessibilityMenuListPopup.h:
      * accessibility/chromium/AXObjectCacheChromium.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      * dom/SelectElement.cpp:
      (WebCore::SelectElement::setSelectedIndex):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::RenderMenuList):
      (WebCore::RenderMenuList::setTextFromOption):
      (WebCore::RenderMenuList::didSetSelectedIndex):
      * rendering/RenderMenuList.h:
      
      Tools:
      
      * DumpRenderTree/AccessibilityController.h:
      * DumpRenderTree/win/AccessibilityControllerWin.cpp:
      (AccessibilityController::AccessibilityController):
      (AccessibilityController::~AccessibilityController):
      (logEventProc):
      (AccessibilityController::setLogAccessibilityEvents):
      (AccessibilityController::addNotificationListener):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91174 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b09331a7
  9. 15 Jul, 2011 1 commit
    • jhoneycutt@apple.com's avatar
      Focus and selection events are not fired when a <select>'s selection · c092ed79
      jhoneycutt@apple.com authored
      changes
      https://bugs.webkit.org/show_bug.cgi?id=64504
      <rdar://problem/9319881>
      
      Reviewed by Alice Liu.
      
      Source/WebCore:
      
      Test: platform/win/accessibility/option-element-selection-and-focus-events.html
      
      * accessibility/chromium/AXObjectCacheChromium.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      Add new notification type to the section of unhandled notifications.
      
      * accessibility/AXObjectCache.h:
      Declare a new notification, AXMenuListItemSelected.
      
      * accessibility/AccessibilityMenuList.cpp:
      (WebCore::AccessibilityMenuList::didUpdateActiveOption):
      Tell our child popup that the active option changed, and post a
      notification that our value changed.
      
      * accessibility/AccessibilityMenuList.h:
      Declare didUpdateActiveOption().
      
      * accessibility/AccessibilityMenuListPopup.cpp:
      (WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
      Get the child <option> element that is selected, and fire focus and
      selection events for it.
      
      * accessibility/AccessibilityMenuListPopup.h:
      Declare didUpdateActiveOption().
      
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      Map AXMenuListItemSelected -> EVENT_OBJECT_SELECTION.
      
      * dom/SelectElement.cpp:
      (WebCore::SelectElement::setSelectedIndex):
      Pass the newly-selected index.
      
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::RenderMenuList):
      Update the initialization list for the renamed m_lastActiveIndex.
      (WebCore::RenderMenuList::setTextFromOption):
      A new selection has been made in the popup; call
      didUpdateActiveOption().
      (WebCore::RenderMenuList::didSetSelectedIndex):
      Call didUpdateActiveOption(), passing the index of the newly-selected
      <option>.
      (WebCore::RenderMenuList::didUpdateActiveOption):
      If accessibility is disabled, or if the active option has not changed,
      return early. Check whether the option index is in the range of list
      items, and assert that the item at that index is an <option> element.
      Tell the AccessibilityMenuList for this element that we updated the
      active option.
      
      * rendering/RenderMenuList.h:
      Updated the declaration of didSetSelectedIndex() to take the selected
      index. Declared didUpdateActiveOption(). Renamed m_lastSelectedIndex to
      m_lastActiveIndex.
      
      Tools:
      
      * DumpRenderTree/AccessibilityController.h:
      Added m_notificationsEventHook for addNotificationListener().
      m_allEventsHook will now be used for setLogAccessibilityEvents().
      
      * DumpRenderTree/win/AccessibilityControllerWin.cpp:
      (AccessibilityController::AccessibilityController):
      Initialize m_notificationsEventHook.
      (AccessibilityController::~AccessibilityController):
      Turn off logging of all accessibility events. If
      m_notificationsEventHook is non-null, unhook it.
      (logEventProc):
      Add handling of EVENT_OBJECT_SELECTION.
      (AccessibilityController::setLogAccessibilityEvents):
      If the state of logging is not changing, return early. If we're turning
      off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
      hook for all events.
      (AccessibilityController::addNotificationListener):
      Use m_notificationsEventHook rather than m_allEventsHook.
      
      LayoutTests:
      
      * platform/win/accessibility/option-element-selection-and-focus-events-expected.txt: Added.
      * platform/win/accessibility/option-element-selection-and-focus-events.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@91132 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c092ed79
  10. 15 Jun, 2011 1 commit
    • tony@chromium.org's avatar
      2011-06-15 Tony Chang <tony@chromium.org> · 331e29c8
      tony@chromium.org authored
              Reviewed by Ojan Vafai.
      
              Rename RenderFlexibleBox to RenderDeprecatedFlexibleBox
              https://bugs.webkit.org/show_bug.cgi?id=62670
      
              * CMakeLists.txt:
              * GNUmakefile.list.am:
              * WebCore.gypi:
              * WebCore.order:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * html/shadow/MediaControlElements.cpp:
              (WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
              (WebCore::RenderMediaControlTimeDisplay::layout):
              * html/shadow/SliderThumbElement.cpp:
              (WebCore::RenderSliderContainer::RenderSliderContainer):
              (WebCore::RenderSliderContainer::layout):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::createAnonymousBlock):
              * rendering/RenderBox.cpp:
              * rendering/RenderButton.cpp:
              (WebCore::RenderButton::RenderButton):
              (WebCore::RenderButton::addChild):
              (WebCore::RenderButton::removeChild):
              * rendering/RenderButton.h:
              * rendering/RenderDeprecatedFlexibleBox.cpp:
              (WebCore::FlexBoxIterator::FlexBoxIterator):
              (WebCore::FlexBoxIterator::reset):
              (WebCore::FlexBoxIterator::first):
              (WebCore::FlexBoxIterator::next):
              (WebCore::RenderDeprecatedFlexibleBox::RenderDeprecatedFlexibleBox):
              (WebCore::RenderDeprecatedFlexibleBox::~RenderDeprecatedFlexibleBox):
              (WebCore::marginWidthForChild):
              (WebCore::RenderDeprecatedFlexibleBox::calcHorizontalPrefWidths):
              (WebCore::RenderDeprecatedFlexibleBox::calcVerticalPrefWidths):
              (WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
              (WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
              (WebCore::gatherFlexChildrenInfo):
              (WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
              (WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
              (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
              (WebCore::RenderDeprecatedFlexibleBox::placeChild):
              (WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):
              (WebCore::RenderDeprecatedFlexibleBox::renderName):
              * rendering/RenderDeprecatedFlexibleBox.h:
              (WebCore::RenderDeprecatedFlexibleBox::avoidsFloats):
              (WebCore::RenderDeprecatedFlexibleBox::isFlexibleBox):
              (WebCore::RenderDeprecatedFlexibleBox::isFlexingChildren):
              (WebCore::RenderDeprecatedFlexibleBox::isStretchingChildren):
              (WebCore::RenderDeprecatedFlexibleBox::hasMultipleLines):
              (WebCore::RenderDeprecatedFlexibleBox::isVertical):
              (WebCore::RenderDeprecatedFlexibleBox::isHorizontal):
              * rendering/RenderDetails.h: Removed the header since it wasn't actually
                    needed.  Looks like a copy/paste error from RenderButton.h.
              * rendering/RenderFullScreen.cpp:
              (RenderFullScreen::RenderFullScreen):
              (RenderFullScreen::destroy):
              * rendering/RenderFullScreen.h:
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::RenderMenuList):
              (WebCore::RenderMenuList::createInnerBlock):
              (WebCore::RenderMenuList::removeChild):
              * rendering/RenderMenuList.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::createObject):
              * rendering/RenderingAllInOne.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      331e29c8
  11. 26 May, 2011 1 commit
    • leviw@chromium.org's avatar
      2011-05-25 Levi Weintraub <leviw@chromium.org> · 2b63cbaf
      leviw@chromium.org authored
              Reviewed by Eric Seidel.
      
              Switch controlClipRect to use IntPoint
              https://bugs.webkit.org/show_bug.cgi?id=60806
      
              Switching controlClipRect to take an IntPoint representing the
              offset to be added instead of a pair of ints.
      
              No new tests as this is just refactoring.
      
              * WebCore.xcodeproj/project.pbxproj:
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::nodeAtPoint):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::pushContentsClip):
              * rendering/RenderBox.h:
              (WebCore::RenderBox::controlClipRect):
              * rendering/RenderButton.cpp:
              (WebCore::RenderButton::controlClipRect):
              * rendering/RenderButton.h:
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::paintItemBackground):
              (WebCore::RenderListBox::controlClipRect):
              * rendering/RenderListBox.h:
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::controlClipRect):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::controlClipRect):
              * rendering/RenderTextControlSingleLine.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@87443 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b63cbaf
  12. 28 Jan, 2011 1 commit
    • mitz@apple.com's avatar
      Source/WebCore: <rdar://problem/4761512> <select> can't display right-to-left (rtl) languages · 07c9c84c
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=19785
      
      Reviewed by Sam Weinig.
      
      Changed <select> pop-up menus on Mac OS X Snow Leopard and later to have their items aligned in the
      direction corresponding to the writing direction of the <select> element, with the checkmarks
      on the "start" side, and use the <option>'s writing direction rather than "natural". Made the
      pop-up button match the menu by adding a Chrome boolean function, selectItemAlignmentFollowsMenuWritingDirection(),
      which returns true for this pop-up behavior.
      
      * loader/EmptyClients.h:
      (WebCore::EmptyChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
      * manual-tests/pop-up-alignment-and-direction.html: Added.
      * page/Chrome.cpp:
      (WebCore::Chrome::selectItemAlignmentFollowsMenuWritingDirection): Added. Calls through to the
      client.
      * page/Chrome.h:
      * page/ChromeClient.h:
      * platform/PopupMenuStyle.h:
      (WebCore::PopupMenuStyle::PopupMenuStyle): Added hasTextDirectionOverride parameter and member
      variable initialization.
      (WebCore::PopupMenuStyle::hasTextDirectionOverride): Added this accessor.
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenuMac::populate): Set the pop-up's layout direction and items' text alignment
      to match the menu's writing direction. Set items' writing direction and direction override
      according to their styles.
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::RenderMenuList): Removed unncesaary initialization of a smart pointer.
      (WebCore::RenderMenuList::adjustInnerStyle): If the alignment of items in the menu follows the
      menu's writing direction, use that alignment for the button as well. Also in this mode, use the
      item's writing direction and override setting.
      (WebCore::RenderMenuList::setTextFromOption): Store the option element's style.
      (WebCore::RenderMenuList::itemStyle): Pass the text direction override value.
      (WebCore::RenderMenuList::menuStyle): Ditto. Also use the button's direction, not the inner text's.
      * rendering/RenderMenuList.h:
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::menuStyle): Pass the text direction override value.
      
      Source/WebKit/chromium: <select> can't display right-to-left (rtl) languages
      https://bugs.webkit.org/show_bug.cgi?id=19785
      
      Reviewed by Sam Weinig.
      
      * src/AutoFillPopupMenuClient.cpp:
      (WebKit::AutoFillPopupMenuClient::initialize): Pass hasTextDirectionOverride to the PopupMenuStyle
      constructor.
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::selectItemAlignmentFollowsMenuWritingDirection): Added.
      * src/ChromeClientImpl.h:
      * tests/PopupMenuTest.cpp:
      (WebKit::TestPopupMenuClient::itemStyle): Pass hasTextDirectionOverride to the PopupMenuStyle
      constructor.
      
      Source/WebKit/efl: <select> can't display right-to-left (rtl) languages
      https://bugs.webkit.org/show_bug.cgi?id=19785
      
      Reviewed by Sam Weinig.
      
      * WebCoreSupport/ChromeClientEfl.cpp:
      (WebCore::ChromeClientEfl::selectItemAlignmentFollowsMenuWritingDirection): Added.
      * WebCoreSupport/ChromeClientEfl.h:
      
      Source/WebKit/gtk: <select> can't display right-to-left (rtl) languages
      https://bugs.webkit.org/show_bug.cgi?id=19785
      
      Reviewed by Sam Weinig.
      
      * WebCoreSupport/ChromeClientGtk.cpp:
      (WebKit::ChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
      * WebCoreSupport/ChromeClientGtk.h:
      
      Source/WebKit/haiku: <select> can't display right-to-left (rtl) languages
      https://bugs.webkit.org/show_bug.cgi?id=19785
      
      Reviewed by Sam Weinig.
      
      * WebCoreSupport/ChromeClientHaiku.cpp:
      (WebCore::ChromeClientHaiku::selectItemAlignmentFollowsMenuWritingDirection): Added.
      * WebCoreSupport/ChromeClientHaiku.h:
      
      Source/WebKit/mac: <select> can't display right-to-left (rtl) languages
      https://bugs.webkit.org/show_bug.cgi?id=19785
      
      Reviewed by Sam Weinig.
      
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
      (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added. Returns true.
      
      Source/WebKit/qt: <select> can't display right-to-left (rtl) languages
      https://bugs.webkit.org/show_bug.cgi?id=19785
      
      Reviewed by Sam Weinig.
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::selectItemAlignmentFollowsMenuWritingDirection): Added.
      * WebCoreSupport/ChromeClientQt.h:
      
      Source/WebKit/win: <select> can't display right-to-left (rtl) languages
      https://bugs.webkit.org/show_bug.cgi?id=19785
      
      Reviewed by Sam Weinig.
      
      * WebCoreSupport/WebChromeClient.cpp:
      (WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
      * WebCoreSupport/WebChromeClient.h:
      
      Source/WebKit/wince: <select> can't display right-to-left (rtl) languages
      https://bugs.webkit.org/show_bug.cgi?id=19785
      
      Reviewed by Sam Weinig.
      
      * WebCoreSupport/ChromeClientWinCE.cpp:
      (WebKit::ChromeClientWinCE::selectItemAlignmentFollowsMenuWritingDirection): Added.
      * WebCoreSupport/ChromeClientWinCE.h:
      
      Source/WebKit/wx: <select> can't display right-to-left (rtl) languages
      https://bugs.webkit.org/show_bug.cgi?id=19785
      
      Reviewed by Sam Weinig.
      
      * WebKitSupport/ChromeClientWx.cpp:
      (WebCore::ChromeClientWx::selectItemAlignmentFollowsMenuWritingDirection): Added.
      * WebKitSupport/ChromeClientWx.h:
      
      Source/WebKit2: <select> can't display right-to-left (rtl) languages
      https://bugs.webkit.org/show_bug.cgi?id=19785
      
      Reviewed by Sam Weinig.
      
      * Shared/WebPopupItem.cpp:
      (WebKit::WebPopupItem::WebPopupItem): Added initializers for m_textDirection and m_hasTextDirectionOverride.
      (WebKit::WebPopupItem::encode): Encode the item's writing direction and direction override values.
      (WebKit::WebPopupItem::decode): Decode the item's writing direction and direction override values.
      * Shared/WebPopupItem.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::showPopupMenu): Added a parameter for the menu's text direction.
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in: Ditto.
      * UIProcess/WebPopupMenuProxy.h:
      * UIProcess/mac/WebPopupMenuProxyMac.h:
      * UIProcess/mac/WebPopupMenuProxyMac.mm:
      (WebKit::WebPopupMenuProxyMac::populate): Added a parameter for the menu's text direction.
      Set items' text alignment to match the menu's writing direction. Set items' writing direction
      and direction override according to their styles.
      (WebKit::WebPopupMenuProxyMac::showPopupMenu): Set the pop-up's layout direction.
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural): Changed to return false.
      (WebKit::WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection): Added.
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      * WebProcess/WebCoreSupport/WebPopupMenu.cpp:
      (WebKit::WebPopupMenu::populateItems): Initialize items' writing direction and direction override
      values.
      (WebKit::WebPopupMenu::show): Pass the menu's writing direction.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07c9c84c
  13. 21 Jan, 2011 1 commit
    • weinig@apple.com's avatar
      Part 2 of "Cleanup Scrollbar/ScrollbarClient relationship" · d7d77c3e
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=52779
      
      Reviewed by Anders Carlsson.
      
      Rename ScrollbarClient -> ScrollableArea.
      
      Source/WebCore: 
      
      - Also replaces Scrollbar::setClient with Scrollbar::disconnectFromScrollableArea
        since that was its only use case.
      
      * CMakeLists.txt:
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityScrollbar.cpp:
      (WebCore::AccessibilityScrollbar::setValue):
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::SelectorChecker::checkScrollbarPseudoClass):
      * page/FrameView.h:
      * platform/PopupMenuClient.h:
      * platform/ScrollAnimator.cpp:
      (WebCore::ScrollAnimator::create):
      (WebCore::ScrollAnimator::ScrollAnimator):
      (WebCore::ScrollAnimator::scroll):
      (WebCore::ScrollAnimator::notityPositionChanged):
      * platform/ScrollAnimator.h:
      * platform/ScrollAnimatorWin.cpp:
      (WebCore::ScrollAnimator::create):
      (WebCore::ScrollAnimatorWin::ScrollAnimatorWin):
      (WebCore::ScrollAnimatorWin::scroll):
      * platform/ScrollAnimatorWin.h:
      * platform/ScrollView.cpp:
      (WebCore::ScrollView::scroll):
      (WebCore::ScrollView::updateScrollbars):
      (WebCore::ScrollView::wheelEvent):
      * platform/ScrollView.h:
      * platform/ScrollableArea.cpp: Copied from WebCore/platform/ScrollbarClient.cpp.
      (WebCore::ScrollableArea::ScrollableArea):
      (WebCore::ScrollableArea::~ScrollableArea):
      (WebCore::ScrollableArea::scroll):
      (WebCore::ScrollableArea::scrollToOffsetWithoutAnimation):
      (WebCore::ScrollableArea::scrollToXOffsetWithoutAnimation):
      (WebCore::ScrollableArea::scrollToYOffsetWithoutAnimation):
      (WebCore::ScrollableArea::setScrollOffsetFromAnimation):
      * platform/ScrollableArea.h: Copied from WebCore/platform/ScrollbarClient.h.
      * platform/Scrollbar.cpp:
      (WebCore::Scrollbar::createNativeScrollbar):
      (WebCore::Scrollbar::Scrollbar):
      (WebCore::Scrollbar::offsetDidChange):
      (WebCore::Scrollbar::autoscrollPressedPart):
      (WebCore::Scrollbar::moveThumb):
      (WebCore::Scrollbar::mouseMoved):
      (WebCore::Scrollbar::isWindowActive):
      (WebCore::Scrollbar::invalidateRect):
      (WebCore::Scrollbar::convertToContainingView):
      (WebCore::Scrollbar::convertFromContainingView):
      * platform/Scrollbar.h:
      (WebCore::Scrollbar::disconnectFromScrollableArea):
      (WebCore::Scrollbar::scrollableArea):
      * platform/ScrollbarClient.cpp: Removed.
      * platform/ScrollbarClient.h: Removed.
      * platform/ScrollbarThemeComposite.cpp:
      * platform/chromium/FramelessScrollView.h:
      * platform/chromium/ScrollbarThemeChromium.cpp:
      (WebCore::ScrollbarThemeChromium::paintTickmarks):
      * platform/efl/ScrollbarEfl.cpp:
      (Scrollbar::createNativeScrollbar):
      (ScrollbarEfl::ScrollbarEfl):
      (scrollbarEflEdjeMessage):
      * platform/efl/ScrollbarEfl.h:
      * platform/gtk/MainFrameScrollbarGtk.cpp:
      (MainFrameScrollbarGtk::create):
      (MainFrameScrollbarGtk::MainFrameScrollbarGtk):
      (MainFrameScrollbarGtk::gtkValueChanged):
      * platform/gtk/MainFrameScrollbarGtk.h:
      * platform/mac/ScrollAnimatorMac.h:
      * platform/mac/ScrollAnimatorMac.mm:
      (WebCore::ScrollAnimator::create):
      (WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
      (WebCore::ScrollAnimatorMac::scroll):
      * platform/mac/ScrollbarThemeMac.mm:
      (WebCore::ScrollbarThemeMac::paint):
      * platform/qt/ScrollbarQt.cpp:
      (WebCore::Scrollbar::contextMenu):
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenuWin::scrollToRevealSelection):
      (WebCore::PopupMenuWin::wndProc):
      * platform/win/PopupMenuWin.h:
      * platform/win/ScrollbarThemeSafari.cpp:
      (WebCore::ScrollbarThemeSafari::paintTrackBackground):
      (WebCore::ScrollbarThemeSafari::paintButton):
      (WebCore::ScrollbarThemeSafari::paintThumb):
      * platform/wx/ScrollbarThemeWx.cpp:
      (WebCore::ScrollbarThemeWx::paint):
      * rendering/RenderDataGrid.h:
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::scrollToOffset):
      (WebCore::RenderLayer::destroyScrollbar):
      (WebCore::RenderLayer::scroll):
      * rendering/RenderLayer.h:
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
      (WebCore::RenderListBox::scroll):
      (WebCore::RenderListBox::logicalScroll):
      (WebCore::RenderListBox::setScrollTop):
      (WebCore::RenderListBox::destroyScrollbar):
      * rendering/RenderListBox.h:
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::createScrollbar):
      * rendering/RenderMenuList.h:
      * rendering/RenderScrollbar.cpp:
      (WebCore::RenderScrollbar::createCustomScrollbar):
      (WebCore::RenderScrollbar::RenderScrollbar):
      * rendering/RenderScrollbar.h:
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::createScrollbar):
      * rendering/RenderTextControlSingleLine.h:
      
      Source/WebKit/chromium: 
      
      * src/AutoFillPopupMenuClient.cpp:
      (WebKit::AutoFillPopupMenuClient::createScrollbar):
      * src/AutoFillPopupMenuClient.h:
      * src/WebScrollbarImpl.cpp:
      (WebKit::WebScrollbarImpl::WebScrollbarImpl):
      (WebKit::WebScrollbarImpl::scroll):
      (WebKit::WebScrollbarImpl::onMouseWheel):
      (WebKit::WebScrollbarImpl::onKeyDown):
      * src/WebScrollbarImpl.h:
      * tests/PopupMenuTest.cpp:
      (WebKit::TestPopupMenuClient::createScrollbar):
      
      Source/WebKit/qt: 
      
      * Api/qwebframe.cpp:
      (QWebFrame::setScrollBarValue):
      
      Source/WebKit/win: 
      
      * WebScrollBar.cpp:
      (WebScrollBar::scroll):
      * WebScrollBar.h:
      
      Source/WebKit2: 
      
      * UIProcess/win/WebPopupMenuProxyWin.cpp:
      (WebKit::WebPopupMenuProxyWin::onMouseWheel):
      (WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):
      * UIProcess/win/WebPopupMenuProxyWin.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76378 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7d77c3e
  14. 08 Jan, 2011 1 commit
  15. 12 Nov, 2010 1 commit
    • commit-queue@webkit.org's avatar
      2010-11-12 Ilya Sherman <isherman@chromium.org> · 3585c505
      commit-queue@webkit.org authored
              Reviewed by Eric Seidel.
      
              Remove some trailing whitespace
              https://bugs.webkit.org/show_bug.cgi?id=49433
      
              * platform/PopupMenuClient.h:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupContainer::show):
              (WebCore::PopupListBox::paintRow):
              (WebCore::PopupListBox::scrollToRevealRow):
              * platform/chromium/PopupMenuChromium.h:
              * platform/chromium/SearchPopupMenuChromium.cpp:
              * rendering/RenderMenuList.h:
              (WebCore::RenderMenuList::toRenderMenuList):
              * rendering/RenderTextControlSingleLine.h:
              (WebCore::toRenderTextControlSingleLine):
      2010-11-12  Ilya Sherman  <isherman@chromium.org>
      
              Reviewed by Eric Seidel.
      
              Remove some trailing whitespace
              https://bugs.webkit.org/show_bug.cgi?id=49433
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::createPopupMenu):
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::scrollRootLayerRect):
              (WebKit::WebViewImpl::invalidateRootLayerRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@71900 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3585c505
  16. 24 Sep, 2010 1 commit
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=46482, rename the various prefWidth functions to use · 75dad74e
      hyatt@apple.com authored
      preferredLogicalWidth.
      
      Reviewed by Simon Fraser.
      
      * rendering/AutoTableLayout.cpp:
      (WebCore::AutoTableLayout::recalcColumn):
      (WebCore::AutoTableLayout::computePreferredLogicalWidths):
      (WebCore::AutoTableLayout::calcEffectiveWidth):
      * rendering/AutoTableLayout.h:
      * rendering/FixedTableLayout.cpp:
      (WebCore::FixedTableLayout::calcWidthArray):
      (WebCore::FixedTableLayout::computePreferredLogicalWidths):
      * rendering/FixedTableLayout.h:
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::layoutBlockChildren):
      (WebCore::RenderBlock::layoutPositionedObjects):
      (WebCore::RenderBlock::getClearDelta):
      (WebCore::RenderBlock::computePreferredLogicalWidths):
      (WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
      (WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
      * rendering/RenderBlock.h:
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::dirtyLineBoxesForRenderer):
      (WebCore::RenderBlock::layoutInlineChildren):
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::RenderBox):
      (WebCore::RenderBox::minPreferredLogicalWidth):
      (WebCore::RenderBox::maxPreferredLogicalWidth):
      (WebCore::RenderBox::computeLogicalWidth):
      (WebCore::RenderBox::computeLogicalWidthUsing):
      (WebCore::RenderBox::computePositionedLogicalWidth):
      (WebCore::RenderBox::computePositionedLogicalWidthUsing):
      * rendering/RenderBox.h:
      (WebCore::RenderBox::computePreferredLogicalWidths):
      * rendering/RenderCounter.cpp:
      (WebCore::RenderCounter::computePreferredLogicalWidths):
      * rendering/RenderCounter.h:
      * rendering/RenderDataGrid.cpp:
      (WebCore::RenderDataGrid::computePreferredLogicalWidths):
      * rendering/RenderDataGrid.h:
      * rendering/RenderFieldset.cpp:
      (WebCore::RenderFieldset::computePreferredLogicalWidths):
      * rendering/RenderFieldset.h:
      * rendering/RenderFileUploadControl.cpp:
      (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
      * rendering/RenderFileUploadControl.h:
      * rendering/RenderFlexibleBox.cpp:
      (WebCore::RenderFlexibleBox::calcHorizontalPrefWidths):
      (WebCore::RenderFlexibleBox::calcVerticalPrefWidths):
      (WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
      (WebCore::RenderFlexibleBox::allowedChildFlex):
      * rendering/RenderFlexibleBox.h:
      * rendering/RenderFrameBase.cpp:
      (WebCore::RenderFrameBase::layoutWithFlattening):
      * rendering/RenderHTMLCanvas.cpp:
      (WebCore::RenderHTMLCanvas::canvasSizeChanged):
      * rendering/RenderImage.cpp:
      (WebCore::RenderImage::imageChanged):
      * rendering/RenderListBox.cpp:
      (WebCore::RenderListBox::computePreferredLogicalWidths):
      * rendering/RenderListBox.h:
      * rendering/RenderListItem.cpp:
      (WebCore::RenderListItem::updateMarkerLocation):
      (WebCore::RenderListItem::computePreferredLogicalWidths):
      * rendering/RenderListItem.h:
      * rendering/RenderListMarker.cpp:
      (WebCore::RenderListMarker::layout):
      (WebCore::RenderListMarker::computePreferredLogicalWidths):
      (WebCore::RenderListMarker::updateMargins):
      * rendering/RenderListMarker.h:
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::computePreferredLogicalWidths):
      * rendering/RenderMenuList.h:
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::RenderObject):
      (WebCore::RenderObject::setPreferredLogicalWidthsDirty):
      (WebCore::RenderObject::invalidateContainerPreferredLogicalWidths):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::preferredLogicalWidthsDirty):
      (WebCore::RenderObject::setNeedsLayoutAndPrefWidthsRecalc):
      (WebCore::RenderObject::minPreferredLogicalWidth):
      (WebCore::RenderObject::maxPreferredLogicalWidth):
      * rendering/RenderReplaced.cpp:
      (WebCore::RenderReplaced::computePreferredLogicalWidths):
      * rendering/RenderReplaced.h:
      * rendering/RenderReplica.cpp:
      (WebCore::RenderReplica::computePreferredLogicalWidths):
      * rendering/RenderReplica.h:
      * rendering/RenderSVGRoot.cpp:
      (WebCore::RenderSVGRoot::computePreferredLogicalWidths):
      * rendering/RenderSVGRoot.h:
      * rendering/RenderScrollbarPart.cpp:
      (WebCore::RenderScrollbarPart::computePreferredLogicalWidths):
      * rendering/RenderScrollbarPart.h:
      * rendering/RenderSlider.cpp:
      (WebCore::RenderSlider::computePreferredLogicalWidths):
      * rendering/RenderSlider.h:
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::computeLogicalWidth):
      (WebCore::RenderTable::computePreferredLogicalWidths):
      * rendering/RenderTable.h:
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::computePreferredLogicalWidths):
      * rendering/RenderTableCell.h:
      * rendering/RenderTableCol.cpp:
      (WebCore::RenderTableCol::computePreferredLogicalWidths):
      * rendering/RenderTableCol.h:
      * rendering/RenderText.cpp:
      (WebCore::RenderText::trimmedPrefWidths):
      (WebCore::RenderText::minPreferredLogicalWidth):
      (WebCore::RenderText::maxPreferredLogicalWidth):
      (WebCore::RenderText::computePreferredLogicalWidths):
      (WebCore::RenderText::width):
      * rendering/RenderText.h:
      * rendering/RenderTextControl.cpp:
      (WebCore::RenderTextControl::computePreferredLogicalWidths):
      * rendering/RenderTextControl.h:
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::preferredContentWidth):
      (WebCore::RenderTextControlSingleLine::preferredDecorationWidthRight):
      * rendering/RenderVideo.cpp:
      (WebCore::RenderVideo::updateIntrinsicSize):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::RenderView):
      (WebCore::RenderView::computePreferredLogicalWidths):
      (WebCore::RenderView::layout):
      * rendering/RenderView.h:
      * rendering/TableLayout.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@68276 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75dad74e
  17. 02 Aug, 2010 2 commits
    • luiz@webkit.org's avatar
      2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> · 260550a6
      luiz@webkit.org authored
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes PopupMenu and SearchPopupMenu have been made pure virtual.
      
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::~PopupMenu):
              * platform/SearchPopupMenu.h:
              (WebCore::SearchPopupMenu::~SearchPopupMenu):
      
              Classes RenderMenuList and RenderTexyControlSingleLine have been changed to use
              the new pure virtual PopupMenu and SearchPopupMenu.
      
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::adjustInnerStyle):
              (WebCore::RenderMenuList::showPopup):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
              (WebCore::RenderTextControlSingleLine::addSearchResult):
              (WebCore::RenderTextControlSingleLine::showPopup):
              (WebCore::RenderTextControlSingleLine::hidePopup):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              (WebCore::RenderTextControlSingleLine::valueChanged):
              * rendering/RenderTextControlSingleLine.h:
      
              Chrome and ChromeClient were made responsible for providing instances of classes
              PopupMenu and SearchPopupMenu to its users.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyPopupMenu::show):
              (WebCore::EmptyPopupMenu::hide):
              (WebCore::EmptyPopupMenu::updateFromElement):
              (WebCore::EmptyPopupMenu::disconnectClient):
              (WebCore::EmptySearchPopupMenu::popupMenu):
              (WebCore::EmptySearchPopupMenu::saveRecentSearches):
              (WebCore::EmptySearchPopupMenu::loadRecentSearches):
              (WebCore::EmptySearchPopupMenu::enabled):
              (WebCore::EmptyChromeClient::selectItemWritingDirectionIsNatural):
              (WebCore::EmptyChromeClient::createPopupMenu):
              (WebCore::EmptyChromeClient::createSearchPopupMenu):
              * page/Chrome.cpp:
              (WebCore::Chrome::selectItemWritingDirectionIsNatural):
              (WebCore::Chrome::createPopupMenu):
              (WebCore::Chrome::createSearchPopupMenu):
              * page/Chrome.h:
              * page/ChromeClient.h:
      
              Original contents of files PopupMenu.h and SearchPopupMenu.h have been splited
              in several files, two for each platform (PopupMenuXXX.h and SearchPopupMenuXXX.h).
              Each of new the files contain the concrete classes that inherit form PopupMenu or
              SearchPopupMenu and are specific for the corresponding platform.
      
              brew:
      
              * platform/brew/PopupMenuBrew.cpp:
              (WebCore::PopupMenuBrew::PopupMenuBrew):
              (WebCore::PopupMenuBrew::~PopupMenuBrew):
              (WebCore::PopupMenuBrew::disconnectClient):
              (WebCore::PopupMenuBrew::show):
              (WebCore::PopupMenuBrew::hide):
              (WebCore::PopupMenuBrew::updateFromElement):
              * platform/brew/PopupMenuBrew.h: Added.
              (WebCore::PopupMenuBrew::client):
              * platform/brew/SearchPopupMenuBrew.cpp:
              (WebCore::SearchPopupMenuBrew::saveRecentSearches):
              (WebCore::SearchPopupMenuBrew::loadRecentSearches):
              (WebCore::SearchPopupMenuBrew::SearchPopupMenuBrew):
              (WebCore::SearchPopupMenuBrew::enabled):
              (WebCore::SearchPopupMenuBrew::popupMenu):
              * platform/brew/SearchPopupMenuBrew.h: Added.
      
              chromium:
      
              * WebCore.gypi:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupMenuChromium::PopupMenuChromium):
              (WebCore::PopupMenuChromium::~PopupMenuChromium):
              (WebCore::PopupMenuChromium::show):
              (WebCore::PopupMenuChromium::hide):
              (WebCore::PopupMenuChromium::updateFromElement):
              (WebCore::PopupMenuChromium::disconnectClient):
              * platform/chromium/PopupMenuChromium.h:
              (WebCore::PopupMenuChromium::client):
              * platform/chromium/SearchPopupMenuChromium.cpp:
              (WebCore::SearchPopupMenuChromium::SearchPopupMenuChromium):
              (WebCore::SearchPopupMenuChromium::popupMenu):
              (WebCore::SearchPopupMenuChromium::enabled):
              (WebCore::SearchPopupMenuChromium::saveRecentSearches):
              (WebCore::SearchPopupMenuChromium::loadRecentSearches):
              * platform/chromium/SearchPopupMenuChromium.h: Added.
      
              efl:
      
              * platform/efl/PopupMenuEfl.cpp:
              (WebCore::PopupMenuEfl::PopupMenuEfl):
              (WebCore::PopupMenuEfl::~PopupMenuEfl):
              (WebCore::PopupMenuEfl::show):
              (WebCore::PopupMenuEfl::hide):
              (WebCore::PopupMenuEfl::updateFromElement):
              (WebCore::PopupMenuEfl::disconnectClient):
              * platform/efl/PopupMenuEfl.h: Added.
              (WebCore::PopupMenuEfl::client):
              * platform/efl/SearchPopupMenuEfl.cpp:
              (WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
              (WebCore::SearchPopupMenuEfl::popupMenu):
              (WebCore::SearchPopupMenuEfl::saveRecentSearches):
              (WebCore::SearchPopupMenuEfl::loadRecentSearches):
              (WebCore::SearchPopupMenuEfl::enabled):
              * platform/efl/SearchPopupMenuEfl.h: Added.
      
              gtk:
      
              * GNUmakefile.am:
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenuGtk::PopupMenuGtk):
              (WebCore::PopupMenuGtk::~PopupMenuGtk):
              (WebCore::PopupMenuGtk::show):
              (WebCore::PopupMenuGtk::hide):
              (WebCore::PopupMenuGtk::updateFromElement):
              (WebCore::PopupMenuGtk::disconnectClient):
              (WebCore::PopupMenuGtk::menuItemActivated):
              (WebCore::PopupMenuGtk::menuUnmapped):
              (WebCore::PopupMenuGtk::menuPositionFunction):
              (WebCore::PopupMenuGtk::menuRemoveItem):
              * platform/gtk/PopupMenuGtk.h: Added.
              (WebCore::PopupMenuGtk::client):
              * platform/gtk/SearchPopupMenuGtk.cpp:
              (WebCore::SearchPopupMenuGtk::SearchPopupMenuGtk):
              (WebCore::SearchPopupMenuGtk::popupMenu):
              (WebCore::SearchPopupMenuGtk::saveRecentSearches):
              (WebCore::SearchPopupMenuGtk::loadRecentSearches):
              (WebCore::SearchPopupMenuGtk::enabled):
              * platform/gtk/SearchPopupMenuGtk.h: Added.
      
              haiku:
      
              * platform/haiku/PopupMenuHaiku.cpp:
              (WebCore::HaikuPopup::HaikuPopup):
              (WebCore::HaikuPopup::~HaikuPopup):
              (WebCore::PopupMenuHaiku::PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::~PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::show):
              (WebCore::PopupMenuHaiku::hide):
              (WebCore::PopupMenuHaiku::updateFromElement):
              * platform/haiku/PopupMenuHaiku.h: Added.
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::client):
              * platform/haiku/SearchPopupMenuHaiku.cpp:
              (WebCore::SearchPopupMenuHaiku::SearchPopupMenuHaiku):
              (WebCore::SearchPopupMenuHaiku::saveRecentSearches):
              (WebCore::SearchPopupMenuHaiku::loadRecentSearches):
              (WebCore::SearchPopupMenuHaiku::enabled):
              (WebCore::SearchPopupMenuHaiku::popupMenu):
              * platform/haiku/SearchPopupMenuHaiku.h: Added.
      
              mac:
      
              * WebCore.exp.in:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/mac/PopupMenuMac.h: Added.
              (WebCore::PopupMenuMac::disconnectClient):
              (WebCore::PopupMenuMac::client):
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenuMac::PopupMenuMac):
              (WebCore::PopupMenuMac::~PopupMenuMac):
              (WebCore::PopupMenuMac::clear):
              (WebCore::PopupMenuMac::populate):
              (WebCore::PopupMenuMac::show):
              (WebCore::PopupMenuMac::hide):
              (WebCore::PopupMenuMac::updateFromElement):
              (WebCore::PopupMenuMac::itemWritingDirectionIsNatural):
              * platform/mac/SearchPopupMenuMac.h: Added.
              * platform/mac/SearchPopupMenuMac.mm:
              (WebCore::SearchPopupMenuMac::SearchPopupMenuMac):
              (WebCore::SearchPopupMenuMac::popupMenu):
              (WebCore::SearchPopupMenuMac::enabled):
              (WebCore::SearchPopupMenuMac::saveRecentSearches):
              (WebCore::SearchPopupMenuMac::loadRecentSearches):
      
              qt:
      
              * WebCore.pro:
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenuQt::PopupMenuQt):
              (WebCore::PopupMenuQt::~PopupMenuQt):
              (WebCore::PopupMenuQt::disconnectClient):
              (WebCore::PopupMenuQt::show):
              (WebCore::PopupMenuQt::hide):
              (WebCore::PopupMenuQt::updateFromElement):
              * platform/qt/PopupMenuQt.h: Added.
              * platform/qt/QtAbstractWebPopup.h:
              * platform/qt/SearchPopupMenuQt.cpp:
              (WebCore::SearchPopupMenuQt::SearchPopupMenuQt):
              (WebCore::SearchPopupMenuQt::popupMenu):
              (WebCore::SearchPopupMenuQt::saveRecentSearches):
              (WebCore::SearchPopupMenuQt::loadRecentSearches):
              (WebCore::SearchPopupMenuQt::enabled):
              * platform/qt/SearchPopupMenuQt.h: Added.
      
              win:
      
              * WebCore.vcproj/WebCore.vcproj:
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenuWin::PopupMenuWin):
              (WebCore::PopupMenuWin::~PopupMenuWin):
              (WebCore::PopupMenuWin::disconnectClient):
              (WebCore::PopupMenuWin::popupClassName):
              (WebCore::PopupMenuWin::show):
              (WebCore::PopupMenuWin::hide):
              (WebCore::PopupMenuWin::calculatePositionAndSize):
              (WebCore::PopupMenuWin::setFocusedIndex):
              (WebCore::PopupMenuWin::visibleItems):
              (WebCore::PopupMenuWin::listIndexAtPoint):
              (WebCore::PopupMenuWin::focusedIndex):
              (WebCore::PopupMenuWin::focusFirst):
              (WebCore::PopupMenuWin::focusLast):
              (WebCore::PopupMenuWin::down):
              (WebCore::PopupMenuWin::up):
              (WebCore::PopupMenuWin::invalidateItem):
              (WebCore::PopupMenuWin::clientRect):
              (WebCore::PopupMenuWin::incrementWheelDelta):
              (WebCore::PopupMenuWin::reduceWheelDelta):
              (WebCore::PopupMenuWin::scrollToRevealSelection):
              (WebCore::PopupMenuWin::updateFromElement):
              (WebCore::PopupMenuWin::paint):
              (WebCore::PopupMenuWin::valueChanged):
              (WebCore::PopupMenuWin::invalidateScrollbarRect):
              (WebCore::PopupMenuWin::registerClass):
              (WebCore::PopupMenuWin::PopupMenuWndProc):
              (WebCore::PopupMenuWin::wndProc):
              * platform/win/PopupMenuWin.h: Added.
              (WebCore::PopupMenuWin::client):
              (WebCore::PopupMenuWin::scrollbar):
              (WebCore::PopupMenuWin::itemHeight):
              (WebCore::PopupMenuWin::windowRect):
              (WebCore::PopupMenuWin::popupHandle):
              (WebCore::PopupMenuWin::setWasClicked):
              (WebCore::PopupMenuWin::wasClicked):
              (WebCore::PopupMenuWin::setScrollOffset):
              (WebCore::PopupMenuWin::scrollOffset):
              (WebCore::PopupMenuWin::wheelDelta):
              (WebCore::PopupMenuWin::scrollbarCapturingMouse):
              (WebCore::PopupMenuWin::setScrollbarCapturingMouse):
              * platform/win/SearchPopupMenuWin.cpp:
              (WebCore::SearchPopupMenuWin::SearchPopupMenuWin):
              (WebCore::SearchPopupMenuWin::popupMenu):
              (WebCore::SearchPopupMenuWin::enabled):
              (WebCore::SearchPopupMenuWin::saveRecentSearches):
              (WebCore::SearchPopupMenuWin::loadRecentSearches):
              * platform/win/SearchPopupMenuWin.h: Added.
      
              wx:
      
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenuWx::PopupMenuWx):
              (WebCore::PopupMenuWx::~PopupMenuWx):
              (WebCore::PopupMenuWx::disconnectClient):
              (WebCore::PopupMenuWx::show):
              (WebCore::PopupMenuWx::OnMenuItemSelected):
              (WebCore::PopupMenuWx::hide):
              (WebCore::PopupMenuWx::updateFromElement):
              * platform/wx/PopupMenuWx.h: Added.
              (WebCore::PopupMenuWx::client):
              * platform/wx/SearchPopupMenuWx.cpp:
              (WebCore::SearchPopupMenuWx::SearchPopupMenuWx):
              (WebCore::SearchPopupMenuWx::saveRecentSearches):
              (WebCore::SearchPopupMenuWx::loadRecentSearches):
              (WebCore::SearchPopupMenuWx::enabled):
              (WebCore::SearchPopupMenuWx::popupMenu):
              * platform/wx/SearchPopupMenuWx.h: Added.
      
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClientImpl::createPopupMenu):
              (WebKit::ChromeClientImpl::createSearchPopupMenu):
              * src/ChromeClientImpl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              (WebCore::ChromeClientEfl::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientEfl::createPopupMenu):
              (WebCore::ChromeClientEfl::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientEfl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClient::createPopupMenu):
              (WebKit::ChromeClient::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientGtk.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              (WebCore::ChromeClientHaiku::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientHaiku::createPopupMenu):
              (WebCore::ChromeClientHaiku::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientHaiku.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientQt::createPopupMenu):
              (WebCore::ChromeClientQt::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientQt.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
              * WebCoreSupport/WebChromeClient.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientWx::createPopupMenu):
              (WebCore::ChromeClientWx::createSearchPopupMenu):
              * WebKitSupport/ChromeClientWx.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes WebPopupMenu and WebSearchPopupMenu inherit from PopupMenu and
              SearchPopupMenu respectively. At this point they are just empty implementations.
      
              * WebProcess/WebCoreSupport/WebPopupMenu.cpp: Added.
              (WebKit::WebPopupMenu::WebPopupMenu):
              (WebKit::WebPopupMenu::~WebPopupMenu):
              (WebKit::WebPopupMenu::disconnectClient):
              (WebKit::WebPopupMenu::show):
              (WebKit::WebPopupMenu::hide):
              (WebKit::WebPopupMenu::updateFromElement):
              * WebProcess/WebCoreSupport/WebPopupMenu.h: Added.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Added.
              (WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
              (WebKit::WebSearchPopupMenu::popupMenu):
              (WebKit::WebSearchPopupMenu::saveRecentSearches):
              (WebKit::WebSearchPopupMenu::loadRecentSearches):
              (WebKit::WebSearchPopupMenu::enabled):
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Added.
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::WebChromeClient::createPopupMenu):
              (WebKit::WebChromeClient::createSearchPopupMenu):
              * WebProcess/WebCoreSupport/WebChromeClient.h:
      
              build issues:
      
              * WebKit2.xcodeproj/project.pbxproj:
              * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      260550a6
    • jorlow@chromium.org's avatar
      2010-08-02 Jeremy Orlow <jorlow@chromium.org> · 4409cc88
      jorlow@chromium.org authored
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * loader/EmptyClients.h:
              * page/Chrome.cpp:
              * page/Chrome.h:
              * page/ChromeClient.h:
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::create):
              (WebCore::PopupMenu::disconnectClient):
              (WebCore::PopupMenu::client):
              (WebCore::PopupMenu::scrollbar):
              (WebCore::PopupMenu::itemHeight):
              (WebCore::PopupMenu::windowRect):
              (WebCore::PopupMenu::popupHandle):
              (WebCore::PopupMenu::setWasClicked):
              (WebCore::PopupMenu::wasClicked):
              (WebCore::PopupMenu::setScrollOffset):
              (WebCore::PopupMenu::scrollOffset):
              (WebCore::PopupMenu::wheelDelta):
              (WebCore::PopupMenu::scrollbarCapturingMouse):
              (WebCore::PopupMenu::setScrollbarCapturingMouse):
              (WebCore::PopupMenu::isActive):
              (WebCore::PopupMenu::scrollbarCornerPresent):
              * platform/SearchPopupMenu.h:
              (WebCore::SearchPopupMenu::create):
              * platform/brew/PopupMenuBrew.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/brew/PopupMenuBrew.h: Removed.
              * platform/brew/SearchPopupMenuBrew.cpp:
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              * platform/brew/SearchPopupMenuBrew.h: Removed.
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/chromium/PopupMenuChromium.h:
              * platform/chromium/SearchPopupMenuChromium.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/chromium/SearchPopupMenuChromium.h: Removed.
              * platform/efl/PopupMenuEfl.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/efl/PopupMenuEfl.h: Removed.
              * platform/efl/SearchPopupMenuEfl.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/efl/SearchPopupMenuEfl.h: Removed.
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              (WebCore::PopupMenu::menuItemActivated):
              (WebCore::PopupMenu::menuUnmapped):
              (WebCore::PopupMenu::menuPositionFunction):
              (WebCore::PopupMenu::menuRemoveItem):
              * platform/gtk/PopupMenuGtk.h: Removed.
              * platform/gtk/SearchPopupMenuGtk.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/gtk/SearchPopupMenuGtk.h: Removed.
              * platform/haiku/PopupMenuHaiku.cpp:
              (WebCore::PopupMenuHaiku::PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::~PopupMenuHaiku):
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/haiku/PopupMenuHaiku.h: Removed.
              * platform/haiku/SearchPopupMenuHaiku.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/haiku/SearchPopupMenuHaiku.h: Removed.
              * platform/mac/PopupMenuMac.h: Removed.
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::clear):
              (WebCore::PopupMenu::populate):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/mac/SearchPopupMenuMac.h: Removed.
              * platform/mac/SearchPopupMenuMac.mm:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/qt/PopupMenuQt.h: Removed.
              * platform/qt/QtAbstractWebPopup.h:
              * platform/qt/SearchPopupMenuQt.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/qt/SearchPopupMenuQt.h: Removed.
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::popupClassName):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::calculatePositionAndSize):
              (WebCore::PopupMenu::setFocusedIndex):
              (WebCore::PopupMenu::visibleItems):
              (WebCore::PopupMenu::listIndexAtPoint):
              (WebCore::PopupMenu::focusedIndex):
              (WebCore::PopupMenu::focusFirst):
              (WebCore::PopupMenu::focusLast):
              (WebCore::PopupMenu::down):
              (WebCore::PopupMenu::up):
              (WebCore::PopupMenu::invalidateItem):
              (WebCore::PopupMenu::clientRect):
              (WebCore::PopupMenu::incrementWheelDelta):
              (WebCore::PopupMenu::reduceWheelDelta):
              (WebCore::PopupMenu::scrollToRevealSelection):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              (WebCore::PopupMenu::paint):
              (WebCore::PopupMenu::valueChanged):
              (WebCore::PopupMenu::invalidateScrollbarRect):
              (WebCore::PopupMenu::registerClass):
              (WebCore::PopupMenu::PopupMenuWndProc):
              (WebCore::PopupMenu::wndProc):
              * platform/win/PopupMenuWin.h: Removed.
              * platform/win/SearchPopupMenuWin.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/win/SearchPopupMenuWin.h: Removed.
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::OnMenuItemSelected):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/wx/PopupMenuWx.h: Removed.
              * platform/wx/SearchPopupMenuWx.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/wx/SearchPopupMenuWx.h: Removed.
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::adjustInnerStyle):
              (WebCore::RenderMenuList::showPopup):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
              (WebCore::RenderTextControlSingleLine::addSearchResult):
              (WebCore::RenderTextControlSingleLine::showPopup):
              (WebCore::RenderTextControlSingleLine::hidePopup):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              (WebCore::RenderTextControlSingleLine::valueChanged):
              * rendering/RenderTextControlSingleLine.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * src/ChromeClientImpl.cpp:
              * src/ChromeClientImpl.h:
              * tests/PopupMenuTest.cpp:
              (WebKit::SelectPopupMenuTest::SetUp):
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              * WebCoreSupport/ChromeClientEfl.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              * WebCoreSupport/ChromeClientGtk.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              * WebCoreSupport/ChromeClientHaiku.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/ChromeClientQt.cpp:
              * WebCoreSupport/ChromeClientQt.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebCoreSupport/WebChromeClient.cpp:
              * WebCoreSupport/WebChromeClient.h:
              * WebView.cpp:
              (WebView::mouseWheel):
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebKitSupport/ChromeClientWx.cpp:
              * WebKitSupport/ChromeClientWx.h:
      2010-08-02  Jeremy Orlow  <jorlow@chromium.org>
      
              Speculative revert of 64425 due to Chromium instability
              https://bugs.webkit.org/show_bug.cgi?id=43347
      
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              * WebProcess/WebCoreSupport/WebChromeClient.h:
              * WebProcess/WebCoreSupport/WebPopupMenu.cpp: Removed.
              * WebProcess/WebCoreSupport/WebPopupMenu.h: Removed.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Removed.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Removed.
              * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4409cc88
  18. 31 Jul, 2010 3 commits
    • luiz@webkit.org's avatar
      2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> · 46462155
      luiz@webkit.org authored
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes PopupMenu and SearchPopupMenu have been made pure virtual.
      
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::~PopupMenu):
              * platform/SearchPopupMenu.h:
              (WebCore::SearchPopupMenu::~SearchPopupMenu):
      
              Classes RenderMenuList and RenderTexyControlSingleLine have been changed to use
              the new pure virtual PopupMenu and SearchPopupMenu.
      
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::adjustInnerStyle):
              (WebCore::RenderMenuList::showPopup):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
              (WebCore::RenderTextControlSingleLine::addSearchResult):
              (WebCore::RenderTextControlSingleLine::showPopup):
              (WebCore::RenderTextControlSingleLine::hidePopup):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              (WebCore::RenderTextControlSingleLine::valueChanged):
              * rendering/RenderTextControlSingleLine.h:
      
              Chrome and ChromeClient were made responsible for providing instances of classes
              PopupMenu and SearchPopupMenu to its users.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyPopupMenu::show):
              (WebCore::EmptyPopupMenu::hide):
              (WebCore::EmptyPopupMenu::updateFromElement):
              (WebCore::EmptyPopupMenu::disconnectClient):
              (WebCore::EmptySearchPopupMenu::popupMenu):
              (WebCore::EmptySearchPopupMenu::saveRecentSearches):
              (WebCore::EmptySearchPopupMenu::loadRecentSearches):
              (WebCore::EmptySearchPopupMenu::enabled):
              (WebCore::EmptyChromeClient::selectItemWritingDirectionIsNatural):
              (WebCore::EmptyChromeClient::createPopupMenu):
              (WebCore::EmptyChromeClient::createSearchPopupMenu):
              * page/Chrome.cpp:
              (WebCore::Chrome::selectItemWritingDirectionIsNatural):
              (WebCore::Chrome::createPopupMenu):
              (WebCore::Chrome::createSearchPopupMenu):
              * page/Chrome.h:
              * page/ChromeClient.h:
      
              Original contents of files PopupMenu.h and SearchPopupMenu.h have been splited
              in several files, two for each platform (PopupMenuXXX.h and SearchPopupMenuXXX.h).
              Each of new the files contain the concrete classes that inherit form PopupMenu or
              SearchPopupMenu and are specific for the corresponding platform.
      
              brew:
      
              * platform/brew/PopupMenuBrew.cpp:
              (WebCore::PopupMenuBrew::PopupMenuBrew):
              (WebCore::PopupMenuBrew::~PopupMenuBrew):
              (WebCore::PopupMenuBrew::disconnectClient):
              (WebCore::PopupMenuBrew::show):
              (WebCore::PopupMenuBrew::hide):
              (WebCore::PopupMenuBrew::updateFromElement):
              * platform/brew/PopupMenuBrew.h: Added.
              (WebCore::PopupMenuBrew::client):
              * platform/brew/SearchPopupMenuBrew.cpp:
              (WebCore::SearchPopupMenuBrew::saveRecentSearches):
              (WebCore::SearchPopupMenuBrew::loadRecentSearches):
              (WebCore::SearchPopupMenuBrew::SearchPopupMenuBrew):
              (WebCore::SearchPopupMenuBrew::enabled):
              (WebCore::SearchPopupMenuBrew::popupMenu):
              * platform/brew/SearchPopupMenuBrew.h: Added.
      
              chromium:
      
              * WebCore.gypi:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupMenuChromium::PopupMenuChromium):
              (WebCore::PopupMenuChromium::~PopupMenuChromium):
              (WebCore::PopupMenuChromium::show):
              (WebCore::PopupMenuChromium::hide):
              (WebCore::PopupMenuChromium::updateFromElement):
              (WebCore::PopupMenuChromium::disconnectClient):
              * platform/chromium/PopupMenuChromium.h:
              (WebCore::PopupMenuChromium::client):
              * platform/chromium/SearchPopupMenuChromium.cpp:
              (WebCore::SearchPopupMenuChromium::SearchPopupMenuChromium):
              (WebCore::SearchPopupMenuChromium::popupMenu):
              (WebCore::SearchPopupMenuChromium::enabled):
              (WebCore::SearchPopupMenuChromium::saveRecentSearches):
              (WebCore::SearchPopupMenuChromium::loadRecentSearches):
              * platform/chromium/SearchPopupMenuChromium.h: Added.
      
              efl:
      
              * platform/efl/PopupMenuEfl.cpp:
              (WebCore::PopupMenuEfl::PopupMenuEfl):
              (WebCore::PopupMenuEfl::~PopupMenuEfl):
              (WebCore::PopupMenuEfl::show):
              (WebCore::PopupMenuEfl::hide):
              (WebCore::PopupMenuEfl::updateFromElement):
              (WebCore::PopupMenuEfl::disconnectClient):
              * platform/efl/PopupMenuEfl.h: Added.
              (WebCore::PopupMenuEfl::client):
              * platform/efl/SearchPopupMenuEfl.cpp:
              (WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
              (WebCore::SearchPopupMenuEfl::popupMenu):
              (WebCore::SearchPopupMenuEfl::saveRecentSearches):
              (WebCore::SearchPopupMenuEfl::loadRecentSearches):
              (WebCore::SearchPopupMenuEfl::enabled):
              * platform/efl/SearchPopupMenuEfl.h: Added.
      
              gtk:
      
              * GNUmakefile.am:
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenuGtk::PopupMenuGtk):
              (WebCore::PopupMenuGtk::~PopupMenuGtk):
              (WebCore::PopupMenuGtk::show):
              (WebCore::PopupMenuGtk::hide):
              (WebCore::PopupMenuGtk::updateFromElement):
              (WebCore::PopupMenuGtk::disconnectClient):
              (WebCore::PopupMenuGtk::menuItemActivated):
              (WebCore::PopupMenuGtk::menuUnmapped):
              (WebCore::PopupMenuGtk::menuPositionFunction):
              (WebCore::PopupMenuGtk::menuRemoveItem):
              * platform/gtk/PopupMenuGtk.h: Added.
              (WebCore::PopupMenuGtk::client):
              * platform/gtk/SearchPopupMenuGtk.cpp:
              (WebCore::SearchPopupMenuGtk::SearchPopupMenuGtk):
              (WebCore::SearchPopupMenuGtk::popupMenu):
              (WebCore::SearchPopupMenuGtk::saveRecentSearches):
              (WebCore::SearchPopupMenuGtk::loadRecentSearches):
              (WebCore::SearchPopupMenuGtk::enabled):
              * platform/gtk/SearchPopupMenuGtk.h: Added.
      
              haiku:
      
              * platform/haiku/PopupMenuHaiku.cpp:
              (WebCore::HaikuPopup::HaikuPopup):
              (WebCore::HaikuPopup::~HaikuPopup):
              (WebCore::PopupMenuHaiku::PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::~PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::show):
              (WebCore::PopupMenuHaiku::hide):
              (WebCore::PopupMenuHaiku::updateFromElement):
              * platform/haiku/PopupMenuHaiku.h: Added.
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::client):
              * platform/haiku/SearchPopupMenuHaiku.cpp:
              (WebCore::SearchPopupMenuHaiku::SearchPopupMenuHaiku):
              (WebCore::SearchPopupMenuHaiku::saveRecentSearches):
              (WebCore::SearchPopupMenuHaiku::loadRecentSearches):
              (WebCore::SearchPopupMenuHaiku::enabled):
              (WebCore::SearchPopupMenuHaiku::popupMenu):
              * platform/haiku/SearchPopupMenuHaiku.h: Added.
      
              mac:
      
              * WebCore.exp.in:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/mac/PopupMenuMac.h: Added.
              (WebCore::PopupMenuMac::disconnectClient):
              (WebCore::PopupMenuMac::client):
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenuMac::PopupMenuMac):
              (WebCore::PopupMenuMac::~PopupMenuMac):
              (WebCore::PopupMenuMac::clear):
              (WebCore::PopupMenuMac::populate):
              (WebCore::PopupMenuMac::show):
              (WebCore::PopupMenuMac::hide):
              (WebCore::PopupMenuMac::updateFromElement):
              (WebCore::PopupMenuMac::itemWritingDirectionIsNatural):
              * platform/mac/SearchPopupMenuMac.h: Added.
              * platform/mac/SearchPopupMenuMac.mm:
              (WebCore::SearchPopupMenuMac::SearchPopupMenuMac):
              (WebCore::SearchPopupMenuMac::popupMenu):
              (WebCore::SearchPopupMenuMac::enabled):
              (WebCore::SearchPopupMenuMac::saveRecentSearches):
              (WebCore::SearchPopupMenuMac::loadRecentSearches):
      
              qt:
      
              * WebCore.pro:
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenuQt::PopupMenuQt):
              (WebCore::PopupMenuQt::~PopupMenuQt):
              (WebCore::PopupMenuQt::disconnectClient):
              (WebCore::PopupMenuQt::show):
              (WebCore::PopupMenuQt::hide):
              (WebCore::PopupMenuQt::updateFromElement):
              * platform/qt/PopupMenuQt.h: Added.
              * platform/qt/QtAbstractWebPopup.h:
              * platform/qt/SearchPopupMenuQt.cpp:
              (WebCore::SearchPopupMenuQt::SearchPopupMenuQt):
              (WebCore::SearchPopupMenuQt::popupMenu):
              (WebCore::SearchPopupMenuQt::saveRecentSearches):
              (WebCore::SearchPopupMenuQt::loadRecentSearches):
              (WebCore::SearchPopupMenuQt::enabled):
              * platform/qt/SearchPopupMenuQt.h: Added.
      
              win:
      
              * WebCore.vcproj/WebCore.vcproj:
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenuWin::PopupMenuWin):
              (WebCore::PopupMenuWin::~PopupMenuWin):
              (WebCore::PopupMenuWin::disconnectClient):
              (WebCore::PopupMenuWin::popupClassName):
              (WebCore::PopupMenuWin::show):
              (WebCore::PopupMenuWin::hide):
              (WebCore::PopupMenuWin::calculatePositionAndSize):
              (WebCore::PopupMenuWin::setFocusedIndex):
              (WebCore::PopupMenuWin::visibleItems):
              (WebCore::PopupMenuWin::listIndexAtPoint):
              (WebCore::PopupMenuWin::focusedIndex):
              (WebCore::PopupMenuWin::focusFirst):
              (WebCore::PopupMenuWin::focusLast):
              (WebCore::PopupMenuWin::down):
              (WebCore::PopupMenuWin::up):
              (WebCore::PopupMenuWin::invalidateItem):
              (WebCore::PopupMenuWin::clientRect):
              (WebCore::PopupMenuWin::incrementWheelDelta):
              (WebCore::PopupMenuWin::reduceWheelDelta):
              (WebCore::PopupMenuWin::scrollToRevealSelection):
              (WebCore::PopupMenuWin::updateFromElement):
              (WebCore::PopupMenuWin::paint):
              (WebCore::PopupMenuWin::valueChanged):
              (WebCore::PopupMenuWin::invalidateScrollbarRect):
              (WebCore::PopupMenuWin::registerClass):
              (WebCore::PopupMenuWin::PopupMenuWndProc):
              (WebCore::PopupMenuWin::wndProc):
              * platform/win/PopupMenuWin.h: Added.
              (WebCore::PopupMenuWin::client):
              (WebCore::PopupMenuWin::scrollbar):
              (WebCore::PopupMenuWin::itemHeight):
              (WebCore::PopupMenuWin::windowRect):
              (WebCore::PopupMenuWin::popupHandle):
              (WebCore::PopupMenuWin::setWasClicked):
              (WebCore::PopupMenuWin::wasClicked):
              (WebCore::PopupMenuWin::setScrollOffset):
              (WebCore::PopupMenuWin::scrollOffset):
              (WebCore::PopupMenuWin::wheelDelta):
              (WebCore::PopupMenuWin::scrollbarCapturingMouse):
              (WebCore::PopupMenuWin::setScrollbarCapturingMouse):
              * platform/win/SearchPopupMenuWin.cpp:
              (WebCore::SearchPopupMenuWin::SearchPopupMenuWin):
              (WebCore::SearchPopupMenuWin::popupMenu):
              (WebCore::SearchPopupMenuWin::enabled):
              (WebCore::SearchPopupMenuWin::saveRecentSearches):
              (WebCore::SearchPopupMenuWin::loadRecentSearches):
              * platform/win/SearchPopupMenuWin.h: Added.
      
              wx:
      
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenuWx::PopupMenuWx):
              (WebCore::PopupMenuWx::~PopupMenuWx):
              (WebCore::PopupMenuWx::disconnectClient):
              (WebCore::PopupMenuWx::show):
              (WebCore::PopupMenuWx::OnMenuItemSelected):
              (WebCore::PopupMenuWx::hide):
              (WebCore::PopupMenuWx::updateFromElement):
              * platform/wx/PopupMenuWx.h: Added.
              (WebCore::PopupMenuWx::client):
              * platform/wx/SearchPopupMenuWx.cpp:
              (WebCore::SearchPopupMenuWx::SearchPopupMenuWx):
              (WebCore::SearchPopupMenuWx::saveRecentSearches):
              (WebCore::SearchPopupMenuWx::loadRecentSearches):
              (WebCore::SearchPopupMenuWx::enabled):
              (WebCore::SearchPopupMenuWx::popupMenu):
              * platform/wx/SearchPopupMenuWx.h: Added.
      
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClientImpl::createPopupMenu):
              (WebKit::ChromeClientImpl::createSearchPopupMenu):
              * src/ChromeClientImpl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              (WebCore::ChromeClientEfl::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientEfl::createPopupMenu):
              (WebCore::ChromeClientEfl::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientEfl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClient::createPopupMenu):
              (WebKit::ChromeClient::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientGtk.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              (WebCore::ChromeClientHaiku::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientHaiku::createPopupMenu):
              (WebCore::ChromeClientHaiku::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientHaiku.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientQt::createPopupMenu):
              (WebCore::ChromeClientQt::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientQt.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
              * WebCoreSupport/WebChromeClient.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientWx::createPopupMenu):
              (WebCore::ChromeClientWx::createSearchPopupMenu):
              * WebKitSupport/ChromeClientWx.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes WebPopupMenu and WebSearchPopupMenu inherit from PopupMenu and
              SearchPopupMenu respectively. At this point they are just empty implementations.
      
              * WebProcess/WebCoreSupport/WebPopupMenu.cpp: Added.
              (WebKit::WebPopupMenu::WebPopupMenu):
              (WebKit::WebPopupMenu::~WebPopupMenu):
              (WebKit::WebPopupMenu::disconnectClient):
              (WebKit::WebPopupMenu::show):
              (WebKit::WebPopupMenu::hide):
              (WebKit::WebPopupMenu::updateFromElement):
              * WebProcess/WebCoreSupport/WebPopupMenu.h: Added.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Added.
              (WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
              (WebKit::WebSearchPopupMenu::popupMenu):
              (WebKit::WebSearchPopupMenu::saveRecentSearches):
              (WebKit::WebSearchPopupMenu::loadRecentSearches):
              (WebKit::WebSearchPopupMenu::enabled):
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Added.
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::WebChromeClient::createPopupMenu):
              (WebKit::WebChromeClient::createSearchPopupMenu):
              * WebProcess/WebCoreSupport/WebChromeClient.h:
      
              build issues:
      
              * WebKit2.xcodeproj/project.pbxproj:
              * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46462155
    • commit-queue@webkit.org's avatar
      2010-07-31 Sheriff Bot <webkit.review.bot@gmail.com> · 5b1ae2ea
      commit-queue@webkit.org authored
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * loader/EmptyClients.h:
              * page/Chrome.cpp:
              * page/Chrome.h:
              * page/ChromeClient.h:
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::create):
              (WebCore::PopupMenu::disconnectClient):
              (WebCore::PopupMenu::client):
              (WebCore::PopupMenu::scrollbar):
              (WebCore::PopupMenu::itemHeight):
              (WebCore::PopupMenu::windowRect):
              (WebCore::PopupMenu::popupHandle):
              (WebCore::PopupMenu::setWasClicked):
              (WebCore::PopupMenu::wasClicked):
              (WebCore::PopupMenu::setScrollOffset):
              (WebCore::PopupMenu::scrollOffset):
              (WebCore::PopupMenu::wheelDelta):
              (WebCore::PopupMenu::scrollbarCapturingMouse):
              (WebCore::PopupMenu::setScrollbarCapturingMouse):
              (WebCore::PopupMenu::isActive):
              (WebCore::PopupMenu::scrollbarCornerPresent):
              * platform/SearchPopupMenu.h:
              (WebCore::SearchPopupMenu::create):
              * platform/brew/PopupMenuBrew.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/brew/PopupMenuBrew.h: Removed.
              * platform/brew/SearchPopupMenuBrew.cpp:
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              * platform/brew/SearchPopupMenuBrew.h: Removed.
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/chromium/PopupMenuChromium.h:
              * platform/chromium/SearchPopupMenuChromium.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/chromium/SearchPopupMenuChromium.h: Removed.
              * platform/efl/PopupMenuEfl.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/efl/PopupMenuEfl.h: Removed.
              * platform/efl/SearchPopupMenuEfl.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/efl/SearchPopupMenuEfl.h: Removed.
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              (WebCore::PopupMenu::menuItemActivated):
              (WebCore::PopupMenu::menuUnmapped):
              (WebCore::PopupMenu::menuPositionFunction):
              (WebCore::PopupMenu::menuRemoveItem):
              * platform/gtk/PopupMenuGtk.h: Removed.
              * platform/gtk/SearchPopupMenuGtk.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/gtk/SearchPopupMenuGtk.h: Removed.
              * platform/haiku/PopupMenuHaiku.cpp:
              (WebCore::PopupMenuHaiku::PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::~PopupMenuHaiku):
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/haiku/PopupMenuHaiku.h: Removed.
              * platform/haiku/SearchPopupMenuHaiku.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/haiku/SearchPopupMenuHaiku.h: Removed.
              * platform/mac/PopupMenuMac.h: Removed.
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::clear):
              (WebCore::PopupMenu::populate):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/mac/SearchPopupMenuMac.h: Removed.
              * platform/mac/SearchPopupMenuMac.mm:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/qt/PopupMenuQt.h: Removed.
              * platform/qt/QtAbstractWebPopup.h:
              * platform/qt/SearchPopupMenuQt.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/qt/SearchPopupMenuQt.h: Removed.
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::popupClassName):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::calculatePositionAndSize):
              (WebCore::PopupMenu::setFocusedIndex):
              (WebCore::PopupMenu::visibleItems):
              (WebCore::PopupMenu::listIndexAtPoint):
              (WebCore::PopupMenu::focusedIndex):
              (WebCore::PopupMenu::focusFirst):
              (WebCore::PopupMenu::focusLast):
              (WebCore::PopupMenu::down):
              (WebCore::PopupMenu::up):
              (WebCore::PopupMenu::invalidateItem):
              (WebCore::PopupMenu::clientRect):
              (WebCore::PopupMenu::incrementWheelDelta):
              (WebCore::PopupMenu::reduceWheelDelta):
              (WebCore::PopupMenu::scrollToRevealSelection):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              (WebCore::PopupMenu::paint):
              (WebCore::PopupMenu::valueChanged):
              (WebCore::PopupMenu::invalidateScrollbarRect):
              (WebCore::PopupMenu::registerClass):
              (WebCore::PopupMenu::PopupMenuWndProc):
              (WebCore::PopupMenu::wndProc):
              * platform/win/PopupMenuWin.h: Removed.
              * platform/win/SearchPopupMenuWin.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::enabled):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              * platform/win/SearchPopupMenuWin.h: Removed.
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenu::PopupMenu):
              (WebCore::PopupMenu::~PopupMenu):
              (WebCore::PopupMenu::show):
              (WebCore::PopupMenu::OnMenuItemSelected):
              (WebCore::PopupMenu::hide):
              (WebCore::PopupMenu::updateFromElement):
              (WebCore::PopupMenu::itemWritingDirectionIsNatural):
              * platform/wx/PopupMenuWx.h: Removed.
              * platform/wx/SearchPopupMenuWx.cpp:
              (WebCore::SearchPopupMenu::SearchPopupMenu):
              (WebCore::SearchPopupMenu::saveRecentSearches):
              (WebCore::SearchPopupMenu::loadRecentSearches):
              (WebCore::SearchPopupMenu::enabled):
              * platform/wx/SearchPopupMenuWx.h: Removed.
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::adjustInnerStyle):
              (WebCore::RenderMenuList::showPopup):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
              (WebCore::RenderTextControlSingleLine::addSearchResult):
              (WebCore::RenderTextControlSingleLine::showPopup):
              (WebCore::RenderTextControlSingleLine::hidePopup):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              (WebCore::RenderTextControlSingleLine::valueChanged):
              * rendering/RenderTextControlSingleLine.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * src/ChromeClientImpl.cpp:
              * src/ChromeClientImpl.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              * WebCoreSupport/ChromeClientEfl.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              * WebCoreSupport/ChromeClientGtk.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              * WebCoreSupport/ChromeClientHaiku.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/ChromeClientQt.cpp:
              * WebCoreSupport/ChromeClientQt.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebCoreSupport/WebChromeClient.cpp:
              * WebCoreSupport/WebChromeClient.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebKitSupport/ChromeClientWx.cpp:
              * WebKitSupport/ChromeClientWx.h:
      2010-07-31  Sheriff Bot  <webkit.review.bot@gmail.com>
      
              Unreviewed, rolling out r64422.
              http://trac.webkit.org/changeset/64422
              https://bugs.webkit.org/show_bug.cgi?id=43304
      
              Build fixes are needed for Snow Leopard and Windows.
              (Requested by lca on #webkit).
      
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              * WebProcess/WebCoreSupport/WebChromeClient.h:
              * WebProcess/WebCoreSupport/WebPopupMenu.cpp: Removed.
              * WebProcess/WebCoreSupport/WebPopupMenu.h: Removed.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Removed.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Removed.
              * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64423 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b1ae2ea
    • luiz@webkit.org's avatar
      2010-07-27 Luiz Agostini <luiz.agostini@openbossa.org> · 3f46b6e6
      luiz@webkit.org authored
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes PopupMenu and SearchPopupMenu have been made pure virtual.
      
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::~PopupMenu):
              * platform/SearchPopupMenu.h:
              (WebCore::SearchPopupMenu::~SearchPopupMenu):
      
              Classes RenderMenuList and RenderTexyControlSingleLine have been changed to use
              the new pure virtual PopupMenu and SearchPopupMenu.
      
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::adjustInnerStyle):
              (WebCore::RenderMenuList::showPopup):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::~RenderTextControlSingleLine):
              (WebCore::RenderTextControlSingleLine::addSearchResult):
              (WebCore::RenderTextControlSingleLine::showPopup):
              (WebCore::RenderTextControlSingleLine::hidePopup):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              (WebCore::RenderTextControlSingleLine::valueChanged):
              * rendering/RenderTextControlSingleLine.h:
      
              Chrome and ChromeClient were made responsible for providing instances of classes
              PopupMenu and SearchPopupMenu to its users.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyPopupMenu::show):
              (WebCore::EmptyPopupMenu::hide):
              (WebCore::EmptyPopupMenu::updateFromElement):
              (WebCore::EmptyPopupMenu::disconnectClient):
              (WebCore::EmptySearchPopupMenu::popupMenu):
              (WebCore::EmptySearchPopupMenu::saveRecentSearches):
              (WebCore::EmptySearchPopupMenu::loadRecentSearches):
              (WebCore::EmptySearchPopupMenu::enabled):
              (WebCore::EmptyChromeClient::selectItemWritingDirectionIsNatural):
              (WebCore::EmptyChromeClient::createPopupMenu):
              (WebCore::EmptyChromeClient::createSearchPopupMenu):
              * page/Chrome.cpp:
              (WebCore::Chrome::selectItemWritingDirectionIsNatural):
              (WebCore::Chrome::createPopupMenu):
              (WebCore::Chrome::createSearchPopupMenu):
              * page/Chrome.h:
              * page/ChromeClient.h:
      
              Original contents of files PopupMenu.h and SearchPopupMenu.h have been splited
              in several files, two for each platform (PopupMenuXXX.h and SearchPopupMenuXXX.h).
              Each of new the files contain the concrete classes that inherit form PopupMenu or
              SearchPopupMenu and are specific for the corresponding platform.
      
              brew:
      
              * platform/brew/PopupMenuBrew.cpp:
              (WebCore::PopupMenuBrew::PopupMenuBrew):
              (WebCore::PopupMenuBrew::~PopupMenuBrew):
              (WebCore::PopupMenuBrew::disconnectClient):
              (WebCore::PopupMenuBrew::show):
              (WebCore::PopupMenuBrew::hide):
              (WebCore::PopupMenuBrew::updateFromElement):
              * platform/brew/PopupMenuBrew.h: Added.
              (WebCore::PopupMenuBrew::client):
              * platform/brew/SearchPopupMenuBrew.cpp:
              (WebCore::SearchPopupMenuBrew::saveRecentSearches):
              (WebCore::SearchPopupMenuBrew::loadRecentSearches):
              (WebCore::SearchPopupMenuBrew::SearchPopupMenuBrew):
              (WebCore::SearchPopupMenuBrew::enabled):
              (WebCore::SearchPopupMenuBrew::popupMenu):
              * platform/brew/SearchPopupMenuBrew.h: Added.
      
              chromium:
      
              * WebCore.gypi:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupMenuChromium::PopupMenuChromium):
              (WebCore::PopupMenuChromium::~PopupMenuChromium):
              (WebCore::PopupMenuChromium::show):
              (WebCore::PopupMenuChromium::hide):
              (WebCore::PopupMenuChromium::updateFromElement):
              (WebCore::PopupMenuChromium::disconnectClient):
              * platform/chromium/PopupMenuChromium.h:
              (WebCore::PopupMenuChromium::client):
              * platform/chromium/SearchPopupMenuChromium.cpp:
              (WebCore::SearchPopupMenuChromium::SearchPopupMenuChromium):
              (WebCore::SearchPopupMenuChromium::popupMenu):
              (WebCore::SearchPopupMenuChromium::enabled):
              (WebCore::SearchPopupMenuChromium::saveRecentSearches):
              (WebCore::SearchPopupMenuChromium::loadRecentSearches):
              * platform/chromium/SearchPopupMenuChromium.h: Added.
      
              efl:
      
              * platform/efl/PopupMenuEfl.cpp:
              (WebCore::PopupMenuEfl::PopupMenuEfl):
              (WebCore::PopupMenuEfl::~PopupMenuEfl):
              (WebCore::PopupMenuEfl::show):
              (WebCore::PopupMenuEfl::hide):
              (WebCore::PopupMenuEfl::updateFromElement):
              (WebCore::PopupMenuEfl::disconnectClient):
              * platform/efl/PopupMenuEfl.h: Added.
              (WebCore::PopupMenuEfl::client):
              * platform/efl/SearchPopupMenuEfl.cpp:
              (WebCore::SearchPopupMenuEfl::SearchPopupMenuEfl):
              (WebCore::SearchPopupMenuEfl::popupMenu):
              (WebCore::SearchPopupMenuEfl::saveRecentSearches):
              (WebCore::SearchPopupMenuEfl::loadRecentSearches):
              (WebCore::SearchPopupMenuEfl::enabled):
              * platform/efl/SearchPopupMenuEfl.h: Added.
      
              gtk:
      
              * GNUmakefile.am:
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenuGtk::PopupMenuGtk):
              (WebCore::PopupMenuGtk::~PopupMenuGtk):
              (WebCore::PopupMenuGtk::show):
              (WebCore::PopupMenuGtk::hide):
              (WebCore::PopupMenuGtk::updateFromElement):
              (WebCore::PopupMenuGtk::disconnectClient):
              (WebCore::PopupMenuGtk::menuItemActivated):
              (WebCore::PopupMenuGtk::menuUnmapped):
              (WebCore::PopupMenuGtk::menuPositionFunction):
              (WebCore::PopupMenuGtk::menuRemoveItem):
              * platform/gtk/PopupMenuGtk.h: Added.
              (WebCore::PopupMenuGtk::client):
              * platform/gtk/SearchPopupMenuGtk.cpp:
              (WebCore::SearchPopupMenuGtk::SearchPopupMenuGtk):
              (WebCore::SearchPopupMenuGtk::popupMenu):
              (WebCore::SearchPopupMenuGtk::saveRecentSearches):
              (WebCore::SearchPopupMenuGtk::loadRecentSearches):
              (WebCore::SearchPopupMenuGtk::enabled):
              * platform/gtk/SearchPopupMenuGtk.h: Added.
      
              haiku:
      
              * platform/haiku/PopupMenuHaiku.cpp:
              (WebCore::HaikuPopup::HaikuPopup):
              (WebCore::HaikuPopup::~HaikuPopup):
              (WebCore::PopupMenuHaiku::PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::~PopupMenuHaiku):
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::show):
              (WebCore::PopupMenuHaiku::hide):
              (WebCore::PopupMenuHaiku::updateFromElement):
              * platform/haiku/PopupMenuHaiku.h: Added.
              (WebCore::PopupMenuHaiku::disconnectClient):
              (WebCore::PopupMenuHaiku::client):
              * platform/haiku/SearchPopupMenuHaiku.cpp:
              (WebCore::SearchPopupMenuHaiku::SearchPopupMenuHaiku):
              (WebCore::SearchPopupMenuHaiku::saveRecentSearches):
              (WebCore::SearchPopupMenuHaiku::loadRecentSearches):
              (WebCore::SearchPopupMenuHaiku::enabled):
              (WebCore::SearchPopupMenuHaiku::popupMenu):
              * platform/haiku/SearchPopupMenuHaiku.h: Added.
      
              mac:
      
              * WebCore.exp.in:
              * WebCore.xcodeproj/project.pbxproj:
              * platform/mac/PopupMenuMac.h: Added.
              (WebCore::PopupMenuMac::disconnectClient):
              (WebCore::PopupMenuMac::client):
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenuMac::PopupMenuMac):
              (WebCore::PopupMenuMac::~PopupMenuMac):
              (WebCore::PopupMenuMac::clear):
              (WebCore::PopupMenuMac::populate):
              (WebCore::PopupMenuMac::show):
              (WebCore::PopupMenuMac::hide):
              (WebCore::PopupMenuMac::updateFromElement):
              (WebCore::PopupMenuMac::itemWritingDirectionIsNatural):
              * platform/mac/SearchPopupMenuMac.h: Added.
              * platform/mac/SearchPopupMenuMac.mm:
              (WebCore::SearchPopupMenuMac::SearchPopupMenuMac):
              (WebCore::SearchPopupMenuMac::popupMenu):
              (WebCore::SearchPopupMenuMac::enabled):
              (WebCore::SearchPopupMenuMac::saveRecentSearches):
              (WebCore::SearchPopupMenuMac::loadRecentSearches):
      
              qt:
      
              * WebCore.pro:
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenuQt::PopupMenuQt):
              (WebCore::PopupMenuQt::~PopupMenuQt):
              (WebCore::PopupMenuQt::disconnectClient):
              (WebCore::PopupMenuQt::show):
              (WebCore::PopupMenuQt::hide):
              (WebCore::PopupMenuQt::updateFromElement):
              * platform/qt/PopupMenuQt.h: Added.
              * platform/qt/QtAbstractWebPopup.h:
              * platform/qt/SearchPopupMenuQt.cpp:
              (WebCore::SearchPopupMenuQt::SearchPopupMenuQt):
              (WebCore::SearchPopupMenuQt::popupMenu):
              (WebCore::SearchPopupMenuQt::saveRecentSearches):
              (WebCore::SearchPopupMenuQt::loadRecentSearches):
              (WebCore::SearchPopupMenuQt::enabled):
              * platform/qt/SearchPopupMenuQt.h: Added.
      
              win:
      
              * WebCore.vcproj/WebCore.vcproj:
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenuWin::PopupMenuWin):
              (WebCore::PopupMenuWin::~PopupMenuWin):
              (WebCore::PopupMenuWin::disconnectClient):
              (WebCore::PopupMenuWin::popupClassName):
              (WebCore::PopupMenuWin::show):
              (WebCore::PopupMenuWin::hide):
              (WebCore::PopupMenuWin::calculatePositionAndSize):
              (WebCore::PopupMenuWin::setFocusedIndex):
              (WebCore::PopupMenuWin::visibleItems):
              (WebCore::PopupMenuWin::listIndexAtPoint):
              (WebCore::PopupMenuWin::focusedIndex):
              (WebCore::PopupMenuWin::focusFirst):
              (WebCore::PopupMenuWin::focusLast):
              (WebCore::PopupMenuWin::down):
              (WebCore::PopupMenuWin::up):
              (WebCore::PopupMenuWin::invalidateItem):
              (WebCore::PopupMenuWin::clientRect):
              (WebCore::PopupMenuWin::incrementWheelDelta):
              (WebCore::PopupMenuWin::reduceWheelDelta):
              (WebCore::PopupMenuWin::scrollToRevealSelection):
              (WebCore::PopupMenuWin::updateFromElement):
              (WebCore::PopupMenuWin::paint):
              (WebCore::PopupMenuWin::valueChanged):
              (WebCore::PopupMenuWin::invalidateScrollbarRect):
              (WebCore::PopupMenuWin::registerClass):
              (WebCore::PopupMenuWin::PopupMenuWndProc):
              (WebCore::PopupMenuWin::wndProc):
              * platform/win/PopupMenuWin.h: Added.
              (WebCore::PopupMenuWin::client):
              (WebCore::PopupMenuWin::scrollbar):
              (WebCore::PopupMenuWin::itemHeight):
              (WebCore::PopupMenuWin::windowRect):
              (WebCore::PopupMenuWin::popupHandle):
              (WebCore::PopupMenuWin::setWasClicked):
              (WebCore::PopupMenuWin::wasClicked):
              (WebCore::PopupMenuWin::setScrollOffset):
              (WebCore::PopupMenuWin::scrollOffset):
              (WebCore::PopupMenuWin::wheelDelta):
              (WebCore::PopupMenuWin::scrollbarCapturingMouse):
              (WebCore::PopupMenuWin::setScrollbarCapturingMouse):
              * platform/win/SearchPopupMenuWin.cpp:
              (WebCore::SearchPopupMenuWin::SearchPopupMenuWin):
              (WebCore::SearchPopupMenuWin::popupMenu):
              (WebCore::SearchPopupMenuWin::enabled):
              (WebCore::SearchPopupMenuWin::saveRecentSearches):
              (WebCore::SearchPopupMenuWin::loadRecentSearches):
              * platform/win/SearchPopupMenuWin.h: Added.
      
              wx:
      
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenuWx::PopupMenuWx):
              (WebCore::PopupMenuWx::~PopupMenuWx):
              (WebCore::PopupMenuWx::disconnectClient):
              (WebCore::PopupMenuWx::show):
              (WebCore::PopupMenuWx::OnMenuItemSelected):
              (WebCore::PopupMenuWx::hide):
              (WebCore::PopupMenuWx::updateFromElement):
              * platform/wx/PopupMenuWx.h: Added.
              (WebCore::PopupMenuWx::client):
              * platform/wx/SearchPopupMenuWx.cpp:
              (WebCore::SearchPopupMenuWx::SearchPopupMenuWx):
              (WebCore::SearchPopupMenuWx::saveRecentSearches):
              (WebCore::SearchPopupMenuWx::loadRecentSearches):
              (WebCore::SearchPopupMenuWx::enabled):
              (WebCore::SearchPopupMenuWx::popupMenu):
              * platform/wx/SearchPopupMenuWx.h: Added.
      
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * src/ChromeClientImpl.cpp:
              (WebKit::ChromeClientImpl::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClientImpl::createPopupMenu):
              (WebKit::ChromeClientImpl::createSearchPopupMenu):
              * src/ChromeClientImpl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientEfl.cpp:
              (WebCore::ChromeClientEfl::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientEfl::createPopupMenu):
              (WebCore::ChromeClientEfl::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientEfl.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientGtk.cpp:
              (WebKit::ChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::ChromeClient::createPopupMenu):
              (WebKit::ChromeClient::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientGtk.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientHaiku.cpp:
              (WebCore::ChromeClientHaiku::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientHaiku::createPopupMenu):
              (WebCore::ChromeClientHaiku::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientHaiku.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.h:
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientQt::createPopupMenu):
              (WebCore::ChromeClientQt::createSearchPopupMenu):
              * WebCoreSupport/ChromeClientQt.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebCoreSupport/WebChromeClient.cpp:
              (WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebChromeClient::createPopupMenu):
              (WebChromeClient::createSearchPopupMenu):
              * WebCoreSupport/WebChromeClient.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebKitSupport/ChromeClientWx.cpp:
              (WebCore::ChromeClientWx::selectItemWritingDirectionIsNatural):
              (WebCore::ChromeClientWx::createPopupMenu):
              (WebCore::ChromeClientWx::createSearchPopupMenu):
              * WebKitSupport/ChromeClientWx.h:
      2010-07-27  Luiz Agostini  <luiz.agostini@openbossa.org>
      
              Reviewed by Darin Fisher.
      
              PopupMenu refactoring in preparation to WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=42592
      
              Classes WebPopupMenu and WebSearchPopupMenu inherit from PopupMenu and
              SearchPopupMenu respectively. At this point they are just empty implementations.
      
              * WebProcess/WebCoreSupport/WebPopupMenu.cpp: Added.
              (WebKit::WebPopupMenu::WebPopupMenu):
              (WebKit::WebPopupMenu::~WebPopupMenu):
              (WebKit::WebPopupMenu::disconnectClient):
              (WebKit::WebPopupMenu::show):
              (WebKit::WebPopupMenu::hide):
              (WebKit::WebPopupMenu::updateFromElement):
              * WebProcess/WebCoreSupport/WebPopupMenu.h: Added.
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp: Added.
              (WebKit::WebSearchPopupMenu::WebSearchPopupMenu):
              (WebKit::WebSearchPopupMenu::popupMenu):
              (WebKit::WebSearchPopupMenu::saveRecentSearches):
              (WebKit::WebSearchPopupMenu::loadRecentSearches):
              (WebKit::WebSearchPopupMenu::enabled):
              * WebProcess/WebCoreSupport/WebSearchPopupMenu.h: Added.
      
              As ChromeClient was made responsible for providing PopupMenu and SearchPopupMenu
              instances, concrete classes that inherit from ChromeClient needed to be changed to
              implement the new methods.
      
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
              (WebKit::WebChromeClient::createPopupMenu):
              (WebKit::WebChromeClient::createSearchPopupMenu):
              * WebProcess/WebCoreSupport/WebChromeClient.h:
      
              build issues:
      
              * WebKit2.xcodeproj/project.pbxproj:
              * win/WebKit2.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64422 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f46b6e6
  19. 27 Jul, 2010 1 commit
    • jhawkins@chromium.org's avatar
      2010-07-27 James Hawkins <jhawkins@chromium.org> · 03b5093f
      jhawkins@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Add the ability to show right-aligned icons in the AutoFill popup.
              https://bugs.webkit.org/show_bug.cgi?id=43076
      
              * public/WebView.h:
              * src/AutoFillPopupMenuClient.cpp:
              (WebKit::AutoFillPopupMenuClient::getIcon):
              (WebKit::AutoFillPopupMenuClient::removeSuggestionAtIndex):
              (WebKit::AutoFillPopupMenuClient::itemIcon):
              (WebKit::AutoFillPopupMenuClient::initialize):
              (WebKit::AutoFillPopupMenuClient::setSuggestions):
              * src/AutoFillPopupMenuClient.h:
              * src/WebViewImpl.cpp:
              (WebKit::WebViewImpl::applyAutoFillSuggestions):
              (WebKit::WebViewImpl::applyAutocompleteSuggestions):
              * src/WebViewImpl.h:
      2010-07-27  James Hawkins  <jhawkins@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Add itemIcon() method to the PopupMenuClient, used by Chrome AutoFill
              to display right-aligned credit card icons in the suggestions popup.
              https://bugs.webkit.org/show_bug.cgi?id=43076
      
              No new tests as this is only used by the Chromium WebKit API.
      
              * platform/PopupMenuClient.h:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupListBox::paintRow):
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::itemIcon):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::itemIcon):
              * rendering/RenderTextControlSingleLine.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@64173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03b5093f
  20. 13 Jul, 2010 1 commit
    • jcivelli@chromium.org's avatar
      2010-07-12 Jay Civelli <jcivelli@chromium.org> · d80e51c4
      jcivelli@chromium.org authored
              Reviewed by Kent Tamura.
      
              Adding right aligned text called labels to PopupMenus.
              https://bugs.webkit.org/show_bug.cgi?id=41964
      
              * platform/PopupMenuClient.h:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupListBox::paintRow):
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::itemLabel):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::itemLabel):
              * rendering/RenderTextControlSingleLine.h:
      2010-07-12  Jay Civelli  <jcivelli@chromium.org>
      
              Reviewed by Kent Tamura.
      
              Making the autofill popup use labels to show the label
              associated with an item.
              https://bugs.webkit.org/show_bug.cgi?id=41964
      
              * src/AutoFillPopupMenuClient.cpp:
              (WebKit::AutoFillPopupMenuClient::getSuggestion):
              (WebKit::AutoFillPopupMenuClient::getLabel):
              (WebKit::AutoFillPopupMenuClient::itemLabel):
              (WebKit::AutoFillPopupMenuClient::setSuggestions):
              (WebKit::AutoFillPopupMenuClient::convertListIndexToInternalIndex):
              * src/AutoFillPopupMenuClient.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@63179 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d80e51c4
  21. 01 Jun, 2010 1 commit
    • jhawkins@chromium.org's avatar
      2010-05-24 James Hawkins <jhawkins@chromium.org> · 66950fbe
      jhawkins@chromium.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Implement new PopupMenuClient methods selectionChanged()
              and selectionCleared().  Expose placeHolder methods and isAutoFilled()
              in WebInputElement.
      
              https://bugs.webkit.org/show_bug.cgi?id=39639
      
              * public/WebInputElement.h:
              * public/WebViewClient.h:
              (WebKit::WebViewClient::didSelectAutoFillSuggestion):
              (WebKit::WebViewClient::didClearAutoFillSelection):
              * src/AutoFillPopupMenuClient.cpp:
              (WebKit::AutoFillPopupMenuClient::selectionChanged):
              (WebKit::AutoFillPopupMenuClient::selectionCleared):
              (WebKit::AutoFillPopupMenuClient::popupDidHide):
              * src/AutoFillPopupMenuClient.h:
              * src/SuggestionsPopupMenuClient.h:
              (WebKit::SuggestionsPopupMenuClient::selectionChanged):
              (WebKit::SuggestionsPopupMenuClient::selectionCleared):
              * src/WebInputElement.cpp:
              (WebKit::WebInputElement::setPlaceholder):
              (WebKit::WebInputElement::placeholder):
              (WebKit::WebInputElement::isAutofilled):
      2010-05-24  James Hawkins  <jhawkins@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Added ability for PopupMenuClient to signal when
              * selection changed, and
              * selection cleared.
      
              https://bugs.webkit.org/show_bug.cgi?id=39639
      
              No new tests because this functionality is intentionally hidden from
              everything other than renderer.
      
              * platform/PopupMenuClient.h:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupListBox::selectIndex):
              (WebCore::PopupListBox::clearSelection):
              * rendering/RenderMenuList.h:
              (WebCore::RenderMenuList::RenderMenuList::selectionChanged):
              (WebCore::RenderMenuList::RenderMenuList::selectionCleared):
              * rendering/RenderTextControlSingleLine.h:
              (WebCore::RenderTextControlSingleLine::selectionChanged):
              (WebCore::RenderTextControlSingleLine::selectionCleared):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@60514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66950fbe
  22. 20 May, 2010 1 commit
    • mitz@apple.com's avatar
      <rdar://problem/8007953> Textarea using custom font appears blank · 55bf8727
      mitz@apple.com authored
      Reviewed by Dave Hyatt.
      
      WebCore: 
      
      Test: fast/css/font-face-in-shadow-DOM.html
      
      When a remote font is loaded, CSSFontSelector forces a style recalc, which replaces all
      RenderSyles that have FontFallbackLists referencing the placeholder font with fresh
      RenderStyles. However, it does not descend into shadow DOM trees, so those may end up with
      styles that still reference the placeholder font.
      
      The fix is to add RenderObject::requiresForcedStyleRecalcPropagation() and have it return
      true from renderers that maintain shadow DOM trees or otherwise keep their own RenderStyles.
      
      * dom/Element.cpp:
      (WebCore::Element::recalcStyle): Check if forced style recalc needs to propagated.
      * rendering/RenderButton.h:
      (WebCore::RenderButton::requiresForcedStyleRecalcPropagation):
      * rendering/RenderDataGrid.h:
      (WebCore::RenderDataGrid::requiresForcedStyleRecalcPropagation):
      * rendering/RenderFileUploadControl.h:
      (WebCore::RenderFileUploadControl::requiresForcedStyleRecalcPropagation):
      * rendering/RenderListItem.h:
      (WebCore::RenderListItem::requiresForcedStyleRecalcPropagation):
      * rendering/RenderMedia.h:
      (WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):
      * rendering/RenderMenuList.h:
      (WebCore::RenderMenuList::RenderMenuList::requiresForcedStyleRecalcPropagation):
      * rendering/RenderObject.h:
      (WebCore::RenderObject::requiresForcedStyleRecalcPropagation):
      * rendering/RenderProgress.h:
      (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
      * rendering/RenderSlider.h:
      (WebCore::RenderSlider::requiresForcedStyleRecalcPropagation):
      * rendering/RenderTextControl.h:
      (WebCore::RenderTextControl::requiresForcedStyleRecalcPropagation):
      
      LayoutTests: 
      
      * fast/css/font-face-in-shadow-DOM.html: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.png: Added.
      * platform/mac/fast/css/font-face-in-shadow-DOM-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@59876 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55bf8727
  23. 19 Mar, 2010 1 commit
    • eric@webkit.org's avatar
      2010-03-19 Luiz Agostini <luiz.agostini@openbossa.org> · 9e798b34
      eric@webkit.org authored
              Reviewed by Antti Koivisto.
      
              Multiselect Popup - PopupMenuClient extension
              https://bugs.webkit.org/show_bug.cgi?id=36178
      
              PopupMenuClient class is the interface used by combobox popup implementations.
              It needs to be extended to handle <select multiple> needs.
      
              A new interface named ListPopupMenuClient that inherits from PopupMenuClient was created.
              The use of this new class instead of adding methods to PopupMenuClient avoids changes
              in other non related implementations of PopupMenuClient.
      
              RenderMenuList has changed to inherit ListPopupMenuClient instead of PopupMenuClient
              and to have the new methods implemented.
      
              * platform/PopupMenuClient.h:
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::listBoxSelectItem):
              (WebCore::RenderMenuList::multiple):
              * rendering/RenderMenuList.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@56285 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e798b34
  24. 02 Mar, 2010 1 commit
    • cfleizach@apple.com's avatar
      aria-label isn't respected on option elements · 7a5d26ff
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=35400
      
      Reviewed by Beth Dakin.
      
      WebCore: 
      
      When aria-label is used on an <option> element, it can take three forms.
      An option in a multi-select list, a popup button and the menu that is displayed 
      from the popup button. This patches the three requisite locations so that if
      aria-label is used, the correct accessibility text is returned.
      
      Test: platform/mac/accessibility/option-with-arialabel.html
      
      * accessibility/AccessibilityListBoxOption.cpp:
      (WebCore::AccessibilityListBoxOption::stringValue):
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::getAttribute):
      * accessibility/AccessibilityObject.h:
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::getAttribute):
      (WebCore::AccessibilityRenderObject::stringValue):
      * platform/PopupMenuClient.h:
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenu::populate):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemAccessibilityText):
      * rendering/RenderMenuList.h:
      * rendering/RenderTextControlSingleLine.h:
      (WebCore::RenderTextControlSingleLine::itemAccessibilityText):
      
      WebKit/chromium: 
      
      * src/SuggestionsPopupMenuClient.h:
      (WebKit::SuggestionsPopupMenuClient::itemAccessibilityText):
      
      LayoutTests: 
      
      * platform/mac/accessibility/option-with-arialabel-expected.txt: Added.
      * platform/mac/accessibility/option-with-arialabel.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55425 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a5d26ff
  25. 22 Jan, 2010 1 commit
    • pkasting@chromium.org's avatar
      Not reviewed, backout. · 43ee8107
      pkasting@chromium.org authored
      Back out r52673, which caused several regressions.
      https://bugs.webkit.org/show_bug.cgi?id=32533
      
      WebCore: 
      
      * platform/PopupMenuClient.h:
      * platform/chromium/PopupMenuChromium.cpp:
      (WebCore::PopupContainer::hidePopup):
      (WebCore::PopupListBox::handleKeyEvent):
      (WebCore::PopupListBox::abandon):
      (WebCore::PopupListBox::acceptIndex):
      (WebCore::PopupListBox::selectIndex):
      (WebCore::PopupListBox::clearSelection):
      (WebCore::PopupListBox::hidePopup):
      * platform/gtk/PopupMenuGtk.cpp:
      (WebCore::PopupMenu::menuUnmapped):
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenu::show):
      * platform/qt/QtAbstractWebPopup.cpp:
      (WebCore::QtAbstractWebPopup::popupDidHide):
      * platform/qt/QtAbstractWebPopup.h:
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenu::hide):
      * platform/wx/PopupMenuWx.cpp:
      (WebCore::PopupMenu::OnMenuItemSelected):
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::popupDidHide):
      * rendering/RenderMenuList.h:
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::popupDidHide):
      * rendering/RenderTextControlSingleLine.h:
      
      WebKit/chromium: 
      
      * src/AutocompletePopupMenuClient.cpp:
      (WebKit::AutocompletePopupMenuClient::initialize):
      (WebKit::AutocompletePopupMenuClient::popupDidHide):
      (WebKit::AutocompletePopupMenuClient::setTextFromItem):
      * src/AutocompletePopupMenuClient.h:
      
      WebKit/qt: 
      
      * WebCoreSupport/QtFallbackWebPopup.cpp:
      (WebCore::QtFallbackWebPopupCombo::hidePopup):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@53716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43ee8107
  26. 04 Jan, 2010 1 commit
    • jhoneycutt@apple.com's avatar
      MSAA: <select> elements should broadcast value change events · cd3d45c6
      jhoneycutt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=33088
      
      <rdar://problem/7332364>
      
      Reviewed by Darin Adler.
      
      WebCore:
      
      * accessibility/AXObjectCache.cpp:
      (WebCore::AXObjectCache::postNotification):
      If the post type is async, follow the old code path; otherwise, call
      postPlatformNotification().
      
      * accessibility/AXObjectCache.h:
      (WebCore::AXObjectCache::):
      Added a new accessibility notification, AXMenuListValueChanged. Added
      a new parameter to postNotification() to specify whether the post should
      be synchronous or asynchronous.
      
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::postPlatformNotification):
      If the WebCore notification is AXMenuListValueChanged, broadcast an
      EVENT_OBJECT_VALUECHANGE event.
      
      * dom/SelectElement.cpp:
      (WebCore::SelectElement::setSelectedIndex):
      When the selected index of a RenderMenuList is changed, call
      RenderMenuList::didSetSelectedIndex().
      
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::RenderMenuLis...
      cd3d45c6
  27. 30 Dec, 2009 1 commit
    • eric@webkit.org's avatar
      2009-12-30 Zelidrag Hornung <zelidrag@chromium.org> · feec43af
      eric@webkit.org authored
              Reviewed by Dimitri Glazkov.
      
              Autocomplete in Chromium now offers suggestions within the input element as a user
              a) types text that produces some autocomplete suggestions, and
              b) scrolls through suggested values in the menu
              The suggested value is rendered but not exposed through JS unti the
              user makes the final selection.
      
              No new tests since this new functionality (autocomplete suggestions)
              is intentionally hidden from everything else than renderer.
      
              * src/AutocompletePopupMenuClient.cpp:
              (WebKit::AutocompletePopupMenuClient::initialize):
              (WebKit::AutocompletePopupMenuClient::setInitialAutocompleteValue):
              (WebKit::AutocompletePopupMenuClient::selectionChanged):
              (WebKit::AutocompletePopupMenuClient::popupDidHide):
              (WebKit::AutocompletePopupMenuClient::setTextFromItem):
              (WebKit::AutocompletePopupMenuClient::resetLastFieldValue):
              * src/AutocompletePopupMenuClient.h:
      
      2009-12-30  Zelidrag Hornung  <zelidrag@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Added ability for PopupMenuClient to signal when
              a) selection changed, and
              b) weather suggested value should be accepted when popup menu closes
      
              No new tests since this new functionality (autocomplete suggestions)
              is intentionally hidden from everything else than renderer.
      
              * platform/PopupMenuClient.h:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupContainer::hidePopup):
              (WebCore::PopupListBox::handleKeyEvent):
              (WebCore::PopupListBox::abandon):
              (WebCore::PopupListBox::acceptIndex):
              (WebCore::PopupListBox::selectIndex):
              (WebCore::PopupListBox::clearSelection):
              (WebCore::PopupListBox::hidePopup):
              * platform/gtk/PopupMenuGtk.cpp:
              (WebCore::PopupMenu::menuUnmapped):
              * platform/mac/PopupMenuMac.mm:
              (WebCore::PopupMenu::show):
              * platform/qt/QtFallbackWebPopup.cpp:
              (WebCore::QtFallbackWebPopup::hidePopup):
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenu::hide):
              * platform/wx/PopupMenuWx.cpp:
              (WebCore::PopupMenu::OnMenuItemSelected):
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::popupDidHide):
              * rendering/RenderMenuList.h:
              (WebCore::RenderMenuList::selectionChanged):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::popupDidHide):
              * rendering/RenderTextControlSingleLine.h:
              (WebCore::RenderTextControlSingleLine::selectionChanged):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52673 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      feec43af
  28. 14 Sep, 2009 1 commit
    • andersca@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=29138 · f3f30068
      andersca@apple.com authored
      Simplify popup menu handling.
      
      Reviewed by Adam Roben.
      
      * platform/PopupMenuClient.h:
      Rename hidePopup to popupDidHide.
              
      * platform/chromium/PopupMenuChromium.cpp:
      (WebCore::PopupListBox::handleKeyEvent):        
      (WebCore::PopupListBox::abandon):
      (WebCore::PopupListBox::acceptIndex):
      Call popupDidHide instead of hidePopup.
              
      * platform/gtk/PopupMenuGtk.cpp:
      (WebCore::PopupMenu::menuUnmapped):
      Ditto.
              
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenu::show):
      Ditto.
              
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenu::hide):
      Call popupDidHide.
              
      (WebCore::PopupWndProc):
      Call PopupMenu::hide.
              
      * platform/wx/PopupMenuWx.cpp:
      (WebCore::PopupMenu::OnMenuItemSelected):
      Call popupDidHide.
              
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::hidePopup):
      (WebCore::RenderMenuList::popupDidHide):
      * rendering/RenderMenuList.h:
      Set the "popup is visible" flag in popupDidHide.
              
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::hidePopup):
      (WebCore::RenderTextControlSingleLine::popupDidHide):
      * rendering/RenderTextControlSingleLine.h:
      Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3f30068
  29. 05 Aug, 2009 1 commit
    • darin@apple.com's avatar
      2009-08-05 Darin Adler <darin@apple.com> · b6cb2561
      darin@apple.com authored
              Reviewed by David Levin.
      
              Use checked casts for render tree
              https://bugs.webkit.org/show_bug.cgi?id=23522
      
              Last patch. Makes all the casts of RenderObject use checked
              casts instead of using static_cast directly.
      
              * accessibility/AccessibilityListBox.cpp:
              (WebCore::AccessibilityListBox::visibleChildren):
              (WebCore::AccessibilityListBox::doAccessibilityHitTest):
              * accessibility/AccessibilityListBoxOption.cpp:
              (WebCore::AccessibilityListBoxOption::elementRect):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::textUnderElement):
              (WebCore::AccessibilityRenderObject::stringValue):
              (WebCore::AccessibilityRenderObject::titleUIElement):
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
              * accessibility/AccessibilitySlider.cpp:
              (WebCore::AccessibilitySliderThumb::elementRect):
              * dom/InputElement.cpp:
              (WebCore::InputElement::updatePlaceholderVisibility):
              * dom/SelectElement.cpp:
              (WebCore::SelectElement::scrollToSelection):
              (WebCore::SelectElement::recalcStyle):
              (WebCore::SelectElement::setRecalcListItems):
              (WebCore::SelectElement::menuListDefaultEventHandler):
              (WebCore::SelectElement::listBoxDefaultEventHandler):
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
              * html/HTMLAppletElement.cpp:
              (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
              * html/HTMLCanvasElement.cpp:
              (WebCore::HTMLCanvasElement::reset):
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::updateWidget):
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::attach):
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::defaultEventHandler):
              * html/HTMLIFrameElement.cpp:
              (WebCore::HTMLIFrameElement::attach):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::defaultEventHandler):
              (WebCore::HTMLInputElement::addSearchResult):
              (WebCore::HTMLInputElement::onSearch):
              * html/HTMLLIElement.cpp:
              (WebCore::HTMLLIElement::parseMappedAttribute):
              (WebCore::HTMLLIElement::attach):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::setReadyState):
              (WebCore::HTMLMediaElement::mediaPlayerDurationChanged):
              (WebCore::HTMLMediaElement::mediaPlayerSizeChanged):
              (WebCore::HTMLMediaElement::mediaPlayerRenderingCanBeAccelerated):
              (WebCore::HTMLMediaElement::mediaPlayerGraphicsLayer):
              (WebCore::HTMLMediaElement::defaultEventHandler):
              (WebCore::HTMLMediaElement::finishParsingChildren):
              * html/HTMLOListElement.cpp:
              (WebCore::HTMLOListElement::parseMappedAttribute):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::updateWidget):
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::defaultEventHandler):
              * page/DragController.cpp:
              (WebCore::DragController::concludeEditDrag):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::capsLockStateMayHaveChanged):
              * page/Frame.cpp:
              (WebCore::Frame::ownerRenderer):
              * page/FrameView.cpp:
              (WebCore::FrameView::detachCustomScrollbars):
              * page/wince/FrameWince.cpp:
              (WebCore::computePageRectsForFrame):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally):
              * rendering/MediaControlElements.cpp:
              (WebCore::MediaControlTimelineElement::defaultEventHandler):
              * rendering/RenderBlockLineLayout.cpp:
              (WebCore::RenderBlock::findNextLineBreak):
              * rendering/RenderCounter.cpp:
              (WebCore::planCounter):
              * rendering/RenderFrameSet.cpp:
              (WebCore::RenderFrameSet::computeEdgeInfo):
              (WebCore::RenderFrameSet::setIsResizing):
              * rendering/RenderLayerBacking.cpp:
              (WebCore::RenderLayerBacking::contentsBox):
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::updateBacking):
              (WebCore::RenderLayerCompositor::requiresCompositingForVideo):
              * rendering/RenderListItem.cpp:
              (WebCore::previousListItem):
              (WebCore::RenderListItem::explicitValueChanged):
              * rendering/RenderObject.cpp:
              (WebCore::updateListMarkerNumbers):
              * rendering/RenderObjectChildList.cpp:
              (WebCore::updateListMarkerNumbers):
              (WebCore::invalidateCountersInContainer):
              * rendering/RenderScrollbarTheme.cpp:
              (WebCore::RenderScrollbarTheme::minimumThumbLength):
              (WebCore::RenderScrollbarTheme::backButtonRect):
              (WebCore::RenderScrollbarTheme::forwardButtonRect):
              (WebCore::RenderScrollbarTheme::trackRect):
              (WebCore::RenderScrollbarTheme::constrainTrackRectToTrackPieces):
              (WebCore::RenderScrollbarTheme::paintScrollbarBackground):
              (WebCore::RenderScrollbarTheme::paintTrackBackground):
              (WebCore::RenderScrollbarTheme::paintTrackPiece):
              (WebCore::RenderScrollbarTheme::paintButton):
              (WebCore::RenderScrollbarTheme::paintThumb):
              * rendering/RenderSlider.cpp:
              (WebCore::SliderThumbElement::defaultEventHandler):
              * rendering/RenderThemeChromiumMac.mm:
              (WebCore::RenderThemeChromiumMac::paintSliderThumb):
              (WebCore::RenderThemeChromiumMac::paintMediaSliderTrack):
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::determineSliderThumbState):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::paintSliderThumb):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintSliderThumb):
              * rendering/RenderThemeWin.cpp:
              (WebCore::RenderThemeWin::determineSliderThumbState):
              * rendering/SVGCharacterLayoutInfo.cpp:
              (WebCore::SVGCharacterLayoutInfo::addLayoutInformation):
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::findSVGRootObject):
              * rendering/TextControlInnerElements.cpp:
              (WebCore::RenderTextControlInnerBlock::nodeAtPoint):
              (WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
              * svg/SVGImageElement.cpp:
              (WebCore::SVGImageElement::attach):
              * svg/SVGMarkerElement.cpp:
              (WebCore::SVGMarkerElement::canvasResource):
              * svg/SVGTextContentElement.cpp:
              (WebCore::rootInlineBoxForTextContentElement):
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::defaultEventHandler):
              Use checked casts.
      
              * rendering/RenderApplet.h:
              * rendering/RenderCounter.h:
              * rendering/RenderFieldset.h:
              * rendering/RenderFileUploadControl.h:
              * rendering/RenderFrame.h:
              * rendering/RenderFrameSet.h:
              * rendering/RenderHTMLCanvas.h:
              * rendering/RenderListBox.h:
              * rendering/RenderListItem.h:
              * rendering/RenderListMarker.h:
              * rendering/RenderMedia.h:
              * rendering/RenderMenuList.h:
              * rendering/RenderPart.h:
              * rendering/RenderPartObject.h:
              * rendering/RenderPath.h:
              * rendering/RenderSVGContainer.h:
              * rendering/RenderSVGRoot.h:
              * rendering/RenderSVGTextPath.h:
              * rendering/RenderSVGViewportContainer.h:
              * rendering/RenderScrollbar.h:
              * rendering/RenderSlider.h:
              * rendering/RenderTextControlMultiLine.h:
              * rendering/RenderTextControlSingleLine.h:
              * rendering/RenderVideo.h:
              Added a checked cast. Also made most members protected or private.
      
              * rendering/RenderBlock.h:
              * rendering/RenderInline.h:
              * rendering/RenderReplaced.h:
              * rendering/RenderSVGBlock.h:
              * rendering/RenderSVGImage.h:
              * rendering/RenderSVGInlineText.h:
              * rendering/RenderSVGText.h:
              * rendering/RenderTextControl.h:
              Made most members protected or private.
      
              * rendering/RenderInline.cpp:
              * rendering/RenderSVGContainer.cpp:
              * rendering/RenderSVGHiddenContainer.cpp:
              * rendering/RenderSVGImage.cpp:
              * rendering/RenderSVGRoot.cpp:
              Removed unneeded destructor.
      
              * rendering/RenderSVGHiddenContainer.h:
              Removed unneeded virtual function overrides that did the same as
              the default and base class.
      
              * rendering/RenderSVGViewportContainer.cpp:
              (WebCore::RenderSVGViewportContainer::paint): Updated to use m_viewport
              directly instead of using a function call.
              (WebCore::RenderSVGViewportContainer::applyViewportClip): Ditto.
              (WebCore::RenderSVGViewportContainer::viewportTransform): Ditto.
              (WebCore::RenderSVGViewportContainer::localToParentTransform): Ditto.
              (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Ditto.
      
              * rendering/RenderScrollbar.cpp:
              (WebCore::pseudoForScrollbarPart): Changed switch statement to use cases for
              all values instead of using a default case.
      
              * rendering/RenderTreeAsText.cpp:
              (WebCore::operator<<): Removed dependency on casting to types that don't
              have any public members we need to get at. Instead, use function names to
              identify the type rather than doing so much overloading. Changed to use
              checked casts.
              (WebCore::write): Ditto.
      
              * rendering/SVGRenderSupport.cpp:
              (WebCore::renderSubtreeToImage): Changed to use a checked cast and also
              added a comment about the fact that the code does not do sufficient type
              checking before doing the cast.
      
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::writeRenderSVGTextBox): Renamed this from operator<<.
              (WebCore::writeSVGInlineTextBoxes): Renamed this from writeSVGInlineText.
              (WebCore::writeSVGText): Renamed this from write.
              (WebCore::writeSVGInlineText): Ditto.
              (WebCore::writeSVGImage): Ditto.
              * rendering/SVGRenderTreeAsText.h: Updated for name changes. Removed
              unneeded default arguments.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6cb2561
  30. 30 Jul, 2009 1 commit
    • mrowe@apple.com's avatar
      Bug 27828: Title attribute is not respected on option elements · 576af270
      mrowe@apple.com authored
      Fix <https://bugs.webkit.org/show_bug.cgi?id=27828> for Mac.
      
      Reviewed by Adele Peterson and Jon Honeycutt.
      
      No tests added as it is not clear how to test a tool tip from DumpRenderTree.
      
      * platform/PopupMenuClient.h: Add a method for retrieving the tool tip of an item.
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenu::populate): Set the tool tip of the menu item to that of the represented item.
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::itemToolTip): Expose the title attribute of the element as the tool tip.
      * rendering/RenderMenuList.h:
      * rendering/RenderTextControlSingleLine.h:
      (WebCore::RenderTextControlSingleLine::itemToolTip): Return an empty string, indicating no tool tip, for
      the popup menu in RenderTextControlSingleLine.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      576af270
  31. 23 May, 2009 1 commit
    • zimmermann@webkit.org's avatar
      Reviewed by Darin Adler. · de5f1ac8
      zimmermann@webkit.org authored
      Fixes: https://bugs.webkit.org/show_bug.cgi?id=23808
      
      After a long journey, add the last missing ABC to share form control element support with HTMLSelectElement.
      RenderListBox/RenderMenuList operates on SelectElement instead of HTMLSelectElement now, querying selected index etc.
      This makes it possible to use these render objects for ie. WML, as it's done before for input & option elements.
      
      WMLSelectElement will be created soon, in a follow-up patch, adding more methods to SelectElement, sharing code between
      HTMLSelectElement/WMLSelectElement.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44100 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de5f1ac8
  32. 04 Feb, 2009 1 commit
    • weinig@apple.com's avatar
      2009-02-04 Sam Weinig <sam@webkit.org> · 1a57c82c
      weinig@apple.com authored
              Reviewed by David Hyatt.
      
              Rename RenderStyle::Diff to StyleDifference and move it to
              RenderStyleConstants.h.
      
              * rendering/RenderBR.cpp:
              (WebCore::RenderBR::styleDidChange):
              * rendering/RenderBR.h:
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::styleWillChange):
              (WebCore::RenderBlock::styleDidChange):
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::styleWillChange):
              (WebCore::RenderBox::styleDidChange):
              * rendering/RenderBox.h:
              * rendering/RenderButton.cpp:
              (WebCore::RenderButton::styleWillChange):
              (WebCore::RenderButton::styleDidChange):
              * rendering/RenderButton.h:
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::styleDidChange):
              * rendering/RenderFieldset.h:
              * rendering/RenderFileUploadControl.cpp:
              (WebCore::RenderFileUploadControl::styleDidChange):
              * rendering/RenderFileUploadControl.h:
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::styleDidChange):
              * rendering/RenderInline.h:
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::styleChanged):
              * rendering/RenderLayer.h:
              * rendering/RenderLayerCompositor.cpp:
              (WebCore::RenderLayerCompositor::updateLayerCompositingState):
              (WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
              * rendering/RenderLayerCompositor.h:
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::styleDidChange):
              * rendering/RenderListBox.h:
              * rendering/RenderListItem.cpp:
              (WebCore::RenderListItem::styleDidChange):
              * rendering/RenderListItem.h:
              * rendering/RenderListMarker.cpp:
              (WebCore::RenderListMarker::styleWillChange):
              (WebCore::RenderListMarker::styleDidChange):
              * rendering/RenderListMarker.h:
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::styleDidChange):
              * rendering/RenderMenuList.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::setStyle):
              (WebCore::RenderObject::styleWillChange):
              (WebCore::RenderObject::styleDidChange):
              * rendering/RenderObject.h:
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::styleDidChange):
              * rendering/RenderReplaced.h:
              * rendering/RenderSVGGradientStop.cpp:
              (WebCore::RenderSVGGradientStop::styleDidChange):
              * rendering/RenderSVGGradientStop.h:
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::styleDidChange):
              * rendering/RenderSVGInlineText.h:
              * rendering/RenderScrollbarPart.cpp:
              (WebCore::RenderScrollbarPart::styleWillChange):
              (WebCore::RenderScrollbarPart::styleDidChange):
              * rendering/RenderScrollbarPart.h:
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::styleDidChange):
              * rendering/RenderSlider.h:
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::styleDidChange):
              * rendering/RenderTable.h:
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::styleWillChange):
              (WebCore::RenderTableCell::styleDidChange):
              * rendering/RenderTableCell.h:
              * rendering/RenderTableRow.cpp:
              (WebCore::RenderTableRow::styleWillChange):
              * rendering/RenderTableRow.h:
              * rendering/RenderText.cpp:
              (WebCore::RenderText::styleDidChange):
              * rendering/RenderText.h:
              (WebCore::RenderText::styleWillChange):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::styleDidChange):
              * rendering/RenderTextControl.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::styleDidChange):
              * rendering/RenderTextControlSingleLine.h:
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::styleDidChange):
              * rendering/RenderWidget.h:
              * rendering/style/RenderStyle.cpp:
              (WebCore::RenderStyle::diff):
              (WebCore::RenderStyle::setClip):
              * rendering/style/RenderStyle.h:
              * rendering/style/RenderStyleConstants.h:
              (WebCore::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a57c82c
  33. 25 Jan, 2009 1 commit
    • darin@apple.com's avatar
      WebCore: · 36744d67
      darin@apple.com authored
      2009-01-25  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Bug 23522: use checked casts for render tree
              https://bugs.webkit.org/show_bug.cgi?id=23522
      
              Step one: RenderText.
      
              Also change set of RenderFlow* to be a ListHashSet as the comment in the
              header indicated.
      
              * dom/CharacterData.cpp:
              (WebCore::CharacterData::setData): Use toRenderText.
              (WebCore::CharacterData::appendData): Ditto.
              (WebCore::CharacterData::insertData): Ditto.
              (WebCore::CharacterData::deleteData): Ditto.
              (WebCore::CharacterData::replaceData): Ditto.
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::getUpperLeftCorner): Ditto.
              (WebCore::ContainerNode::getLowerRightCorner): Ditto.
              * dom/Position.cpp:
              (WebCore::nextRenderedEditable): Ditto.
              (WebCore::previousRenderedEditable): Ditto.
              (WebCore::Position::renderedOffset): Ditto. Also use function members
              instead of data members of InlineTextBox.
              (WebCore::Position::upstream): Ditto.
              (WebCore::Position::downstream): Ditto.
              (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight): Ditto.
              (WebCore::Position::inRenderedText): Ditto.
              (WebCore::Position::isRenderedCharacter): Ditto.
              (WebCore::searchAheadForBetterMatch): Ditto.
              (WebCore::Position::getInlineBoxAndOffset): Ditto.
      
              * dom/Range.cpp: Added include of VisiblePosition.h now that it's no longer
              included in RenderObject.h.
      
              * dom/Text.cpp:
              (WebCore::Text::splitText): Use toRenderText.
              (WebCore::Text::recalcStyle): Ditto.
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::deleteInsignificantText): Ditto.
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::debugRenderer): Ditto.
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::handleTextNode): Ditto.
              (WebCore::TextIterator::handleTextBox): Ditto.
              (WebCore::TextIterator::emitText): Ditto.
              (WebCore::SimplifiedBackwardsTextIterator::handleTextNode): Ditto.
      
              * editing/VisiblePosition.cpp: Added include of FloatQuad.h now that it's
              no longer included in RenderObject.h.
              * inspector/InspectorController.cpp: Ditto.
              * page/Frame.cpp: Ditto.
              * rendering/RenderBox.cpp: Ditto.
              * rendering/RenderInline.cpp: Ditto.
              * rendering/RenderPath.cpp: Ditto.
              * rendering/RenderSVGContainer.cpp: Ditto.
              * rendering/RenderSVGImage.cpp: Ditto.
              * rendering/RenderSVGInlineText.cpp: Ditto.
              * rendering/RenderSVGTSpan.cpp: Ditto.
              * rendering/RenderSVGText.cpp: Ditto.
              * rendering/RenderSVGTextPath.cpp: Ditto.
              * rendering/RenderTableCell.cpp: Ditto.
              * rendering/RenderView.cpp: Ditto.
      
              * editing/visible_units.cpp:
              (WebCore::startPositionForLine): Use function members instead of data
              members of InlineTextBox.
              (WebCore::endPositionForLine): Ditto.
              (WebCore::startOfParagraph): Use toRenderText.
              (WebCore::endOfParagraph): Ditto.
      
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored): Use toRenderText.
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally): Ditto.
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::deleteLine): Ditto.
              (WebCore::InlineTextBox::extractLine): Ditto.
              (WebCore::InlineTextBox::attachLine): Ditto.
              (WebCore::InlineTextBox::placeEllipsisBox): Ditto.
              (WebCore::InlineTextBox::paintDecoration): Ditto.
              (WebCore::InlineTextBox::paintCompositionUnderline): Ditto.
              (WebCore::InlineTextBox::offsetForPosition): Ditto.
              (WebCore::InlineTextBox::positionForOffset): Ditto.
      
              * rendering/InlineTextBox.h: Made most members private. Use toRenderText.
      
              * rendering/RenderArena.cpp:
              (WebCore::RenderArena::allocate): Use static_cast instead of C-style cast.
              (WebCore::RenderArena::free): Ditto.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::addContinuationWithOutline): Use ListHashSet<RenderFlow*>
              instead of RenderFlowSequencedSet.
              (WebCore::RenderBlock::paintContinuationOutlines): Ditto.
              (WebCore::stripTrailingSpace): Ditto.
              (WebCore::RenderBlock::calcInlinePrefWidths): Ditto.
              (WebCore::RenderBlock::updateFirstLetter): Ditto.
      
              * rendering/RenderContainer.cpp:
              (WebCore::RenderContainer::addChild): Use toRenderText.
      
              * rendering/RenderFlow.cpp:
              (WebCore::RenderFlow::dirtyLinesFromChangedChild): Use ListHashSet<RenderFlow*>
              instead of RenderFlowSequencedSet.
              (WebCore::RenderFlow::paintLines): Ditto.
      
              * rendering/RenderMenuList.cpp: Removed some unneeded includes.
      
              * rendering/RenderMenuList.h: Added now-needed forward declaration of RenderText.
              Made more members private.
      
              * rendering/RenderObject.cpp: Updated includes.
              (WebCore::RenderObject::isEditable): Use toRenderText.
              (WebCore::RenderObject::positionForPoint): Made non-inline so we wouldn't have to
              include VisiblePosition.h in the header just for this.
      
              * rendering/RenderObject.h: Removed unneeded includes and forward declarations.
              Changed special vertical position values to be constants rather than an enum.
              Eliminated RenderFlowSequencedSet, and changed clients to use ListHashSet<RenderFlow*>.
      
              * rendering/RenderText.cpp:
              (WebCore::RenderText::findNextInlineTextBox): Use function members instead of
              data members of InlineTextBox.
              (WebCore::RenderText::positionForCoordinates): Ditto.
              (WebCore::isInlineFlowOrEmptyText): Use toRenderText.
              (WebCore::RenderText::previousCharacter): Use function members instead of
              data members of InlineTextBox.
              (WebCore::RenderText::position): Ditto.
              (WebCore::RenderText::caretMinOffset): Ditto.
              (WebCore::RenderText::caretMaxOffset): Ditto.
              (WebCore::RenderText::caretMaxRenderedOffset): Ditto.
      
              * rendering/RenderText.h: Added definition of toRenderText.
      
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::textWithHardLineBreaks): Use toRenderText.
              * rendering/RenderTreeAsText.cpp:
              (WebCore::operator<<): Use toRenderText and toRenderBox.
              (WebCore::writeTextRun): Ditto.
              (WebCore::write): Ditto.
      
              * rendering/bidi.cpp:
              (WebCore::InlineIterator::increment): Use toRenderText.
              (WebCore::InlineIterator::current): Ditto.
              (WebCore::checkMidpoints): Ditto.
              (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.
              (WebCore::RenderBlock::layoutInlineChildren): Ditto.
              (WebCore::RenderBlock::determineStartPosition): Ditto.
              (WebCore::shouldSkipWhitespaceAfterStartObject): Ditto.
              (WebCore::RenderBlock::findNextLineBreak): Ditto.
      
      WebKit/mac:
      
      2009-01-25  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              Bug 23522: use checked casts for render tree
              https://bugs.webkit.org/show_bug.cgi?id=23522
      
              Step one: RenderText.
      
              * WebView/WebRenderNode.mm:
              (copyRenderNode): Use toRenderText.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36744d67
  34. 13 Oct, 2008 1 commit
    • hyatt@apple.com's avatar
      2008-10-13 David Hyatt <hyatt@apple.com> · c3ed34a9
      hyatt@apple.com authored
              Make dropdown lists on Windows work with CSS custom scrollbars.
      
              Reviewed by Adele
      
              * platform/PopupMenu.h:
              (WebCore::PopupMenu::scrollbarCornerPresent):
              * platform/PopupMenuClient.h:
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenu::show):
              * rendering/RenderMenuList.cpp:
              (WebCore::RenderMenuList::createScrollbar):
              * rendering/RenderMenuList.h:
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::createScrollbar):
              * rendering/RenderTextControl.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@37571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3ed34a9
  35. 09 Oct, 2008 1 commit