1. 26 Aug, 2013 40 commits
    • weinig@apple.com's avatar
      Add support for Promises · bd760697
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120260
      
      Reviewed by Darin Adler.
      
      Source/JavaScriptCore: 
      
      Add an initial implementation of Promises - http://dom.spec.whatwg.org/#promises.
      - Despite Promises being defined in the DOM, the implementation is being put in JSC
        in preparation for the Promises eventually being defined in ECMAScript.
      
      * CMakeLists.txt:
      * DerivedSources.make:
      * DerivedSources.pri:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * Target.pri:
      Add new files.
      
      * jsc.cpp:
      Update jsc's GlobalObjectMethodTable to stub out the new QueueTaskToEventLoop callback. This mean's
      you can't quite use Promises with with the command line tool yet.
          
      * interpreter/CallFrame.h:
      (JSC::ExecState::promisePrototypeTable):
      (JSC::ExecState::promiseConstructorTable):
      (JSC::ExecState::promiseResolverPrototypeTable):
      * runtime/VM.cpp:
      (JSC::VM::VM):
      (JSC::VM::~VM):
      * runtime/VM.h:
      Add supporting code for the new static lookup tables.
      
      * runtime/CommonIdentifiers.h:
      Add 3 new identifiers, "Promise", "PromiseResolver", and "then".
      
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::reset):
      (JSC::JSGlobalObject::visitChildren):
      Add supporting code Promise and PromiseResolver's constructors and structures.
      
      * runtime/JSGlobalObject.h:
      (JSC::TaskContext::~TaskContext):
      Add a new callback to the GlobalObjectMethodTable to post a task on the embedder's runloop.
      
      (JSC::JSGlobalObject::promisePrototype):
      (JSC::JSGlobalObject::promiseResolverPrototype):
      (JSC::JSGlobalObject::promiseStructure):
      (JSC::JSGlobalObject::promiseResolverStructure):
      (JSC::JSGlobalObject::promiseCallbackStructure):
      (JSC::JSGlobalObject::promiseWrapperCallbackStructure):
      Add supporting code Promise and PromiseResolver's constructors and structures.
      
      * runtime/JSPromise.cpp: Added.
      * runtime/JSPromise.h: Added.
      * runtime/JSPromiseCallback.cpp: Added.
      * runtime/JSPromiseCallback.h: Added.
      * runtime/JSPromiseConstructor.cpp: Added.
      * runtime/JSPromiseConstructor.h: Added.
      * runtime/JSPromisePrototype.cpp: Added.
      * runtime/JSPromisePrototype.h: Added.
      * runtime/JSPromiseResolver.cpp: Added.
      * runtime/JSPromiseResolver.h: Added.
      * runtime/JSPromiseResolverConstructor.cpp: Added.
      * runtime/JSPromiseResolverConstructor.h: Added.
      * runtime/JSPromiseResolverPrototype.cpp: Added.
      * runtime/JSPromiseResolverPrototype.h: Added.
      Add Promise implementation.
      
      Source/WebCore: 
      
      Add an initial implementation of Promises - http://dom.spec.whatwg.org/#promises.
      - Despite Promises being defined in the DOM, the implementation is being put in JSC
        in preparation for the Promises eventually being defined in ECMAScript.
      
      Tests: fast/js/Promise-already-fulfilled.html
             fast/js/Promise-already-rejected.html
             fast/js/Promise-already-resolved.html
             fast/js/Promise-catch-in-workers.html
             fast/js/Promise-catch.html
             fast/js/Promise-chain.html
             fast/js/Promise-exception.html
             fast/js/Promise-fulfill-in-workers.html
             fast/js/Promise-fulfill.html
             fast/js/Promise-init-in-workers.html
             fast/js/Promise-init.html
             fast/js/Promise-reject-in-workers.html
             fast/js/Promise-reject.html
             fast/js/Promise-resolve-chain.html
             fast/js/Promise-resolve-in-workers.html
             fast/js/Promise-resolve-with-then-exception.html
             fast/js/Promise-resolve-with-then-fulfill.html
             fast/js/Promise-resolve-with-then-reject.html
             fast/js/Promise-resolve.html
             fast/js/Promise-simple-fulfill-inside-callback.html
             fast/js/Promise-simple-fulfill.html
             fast/js/Promise-simple-in-workers.html
             fast/js/Promise-simple.html
             fast/js/Promise-static-fulfill.html
             fast/js/Promise-static-reject.html
             fast/js/Promise-static-resolve.html
             fast/js/Promise-then-in-workers.html
             fast/js/Promise-then-without-callbacks-in-workers.html
             fast/js/Promise-then-without-callbacks.html
             fast/js/Promise-then.html
             fast/js/Promise-types.html
             fast/js/Promise.html
      
      * GNUmakefile.list.am:
      * Target.pri:
      * UseJSC.cmake:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/js/JSBindingsAllInOne.cpp:
      Add new files.
      
      * bindings/js/JSDOMGlobalObjectTask.cpp: Added.
      (WebCore::JSGlobalObjectCallback::create):
      (WebCore::JSGlobalObjectCallback::~JSGlobalObjectCallback):
      (WebCore::JSGlobalObjectCallback::call):
      (WebCore::JSGlobalObjectCallback::JSGlobalObjectCallback):
      (WebCore::JSGlobalObjectTask::JSGlobalObjectTask):
      (WebCore::JSGlobalObjectTask::~JSGlobalObjectTask):
      (WebCore::JSGlobalObjectTask::performTask):
      * bindings/js/JSDOMGlobalObjectTask.h: Added.
      (WebCore::JSGlobalObjectTask::create):
      Add a new task type to be used with the GlobalObjectMethodTable's new QueueTaskToEventLoop callback.
      
      * bindings/js/JSDOMWindowBase.cpp:
      (WebCore::JSDOMWindowBase::queueTaskToEventLoop):
      * bindings/js/JSDOMWindowBase.h:
      Implement the GlobalObjectMethodTable callback, QueueTaskToEventLoop. 
      
      * bindings/js/JSMainThreadExecState.h:
      All using JSMainThreadExecState as a simple RAII object.
      
      * bindings/js/JSWorkerGlobalScopeBase.cpp:
      (WebCore::JSWorkerGlobalScopeBase::JSWorkerGlobalScopeBase):
      (WebCore::JSWorkerGlobalScopeBase::allowsAccessFrom):
      (WebCore::JSWorkerGlobalScopeBase::supportsProfiling):
      (WebCore::JSWorkerGlobalScopeBase::supportsRichSourceInfo):
      (WebCore::JSWorkerGlobalScopeBase::shouldInterruptScript):
      (WebCore::JSWorkerGlobalScopeBase::javaScriptExperimentsEnabled):
      (WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):
      * bindings/js/JSWorkerGlobalScopeBase.h:
      Add a GlobalObjectMethodTable and implement QueueTaskToEventLoop. Forward the other callbacks
      to JSGlobalObject so they retain their existing behavior.
      
      LayoutTests: 
      
      Add tests adapted from the Mozilla and Blink projects.
      
      * fast/js/Promise-already-fulfilled-expected.txt: Added.
      * fast/js/Promise-already-fulfilled.html: Added.
      * fast/js/Promise-already-rejected-expected.txt: Added.
      * fast/js/Promise-already-rejected.html: Added.
      * fast/js/Promise-already-resolved-expected.txt: Added.
      * fast/js/Promise-already-resolved.html: Added.
      * fast/js/Promise-catch-expected.txt: Added.
      * fast/js/Promise-catch-in-workers-expected.txt: Added.
      * fast/js/Promise-catch-in-workers.html: Added.
      * fast/js/Promise-catch.html: Added.
      * fast/js/Promise-chain-expected.txt: Added.
      * fast/js/Promise-chain.html: Added.
      * fast/js/Promise-exception-expected.txt: Added.
      * fast/js/Promise-exception.html: Added.
      * fast/js/Promise-expected.txt: Added.
      * fast/js/Promise-fulfill-expected.txt: Added.
      * fast/js/Promise-fulfill-in-workers-expected.txt: Added.
      * fast/js/Promise-fulfill-in-workers.html: Added.
      * fast/js/Promise-fulfill.html: Added.
      * fast/js/Promise-init-expected.txt: Added.
      * fast/js/Promise-init-in-workers-expected.txt: Added.
      * fast/js/Promise-init-in-workers.html: Added.
      * fast/js/Promise-init.html: Added.
      * fast/js/Promise-reject-expected.txt: Added.
      * fast/js/Promise-reject-in-workers-expected.txt: Added.
      * fast/js/Promise-reject-in-workers.html: Added.
      * fast/js/Promise-reject.html: Added.
      * fast/js/Promise-resolve-chain-expected.txt: Added.
      * fast/js/Promise-resolve-chain.html: Added.
      * fast/js/Promise-resolve-expected.txt: Added.
      * fast/js/Promise-resolve-in-workers-expected.txt: Added.
      * fast/js/Promise-resolve-in-workers.html: Added.
      * fast/js/Promise-resolve-with-then-exception-expected.txt: Added.
      * fast/js/Promise-resolve-with-then-exception.html: Added.
      * fast/js/Promise-resolve-with-then-fulfill-expected.txt: Added.
      * fast/js/Promise-resolve-with-then-fulfill.html: Added.
      * fast/js/Promise-resolve-with-then-reject-expected.txt: Added.
      * fast/js/Promise-resolve-with-then-reject.html: Added.
      * fast/js/Promise-resolve.html: Added.
      * fast/js/Promise-simple-expected.txt: Added.
      * fast/js/Promise-simple-fulfill-expected.txt: Added.
      * fast/js/Promise-simple-fulfill-inside-callback-expected.txt: Added.
      * fast/js/Promise-simple-fulfill-inside-callback.html: Added.
      * fast/js/Promise-simple-fulfill.html: Added.
      * fast/js/Promise-simple-in-workers-expected.txt: Added.
      * fast/js/Promise-simple-in-workers.html: Added.
      * fast/js/Promise-simple.html: Added.
      * fast/js/Promise-static-fulfill-expected.txt: Added.
      * fast/js/Promise-static-fulfill.html: Added.
      * fast/js/Promise-static-reject-expected.txt: Added.
      * fast/js/Promise-static-reject.html: Added.
      * fast/js/Promise-static-resolve-expected.txt: Added.
      * fast/js/Promise-static-resolve.html: Added.
      * fast/js/Promise-then-expected.txt: Added.
      * fast/js/Promise-then-in-workers-expected.txt: Added.
      * fast/js/Promise-then-in-workers.html: Added.
      * fast/js/Promise-then-without-callbacks-expected.txt: Added.
      * fast/js/Promise-then-without-callbacks-in-workers-expected.txt: Added.
      * fast/js/Promise-then-without-callbacks-in-workers.html: Added.
      * fast/js/Promise-then-without-callbacks.html: Added.
      * fast/js/Promise-then.html: Added.
      * fast/js/Promise-types-expected.txt: Added.
      * fast/js/Promise-types.html: Added.
      * fast/js/Promise.html: Added.
      * fast/js/resources/Promise-catch-in-workers.js: Added.
      * fast/js/resources/Promise-fulfill-in-workers.js: Added.
      * fast/js/resources/Promise-init-in-workers.js: Added.
      * fast/js/resources/Promise-reject-in-workers.js: Added.
      * fast/js/resources/Promise-resolve-in-workers.js: Added.
      * fast/js/resources/Promise-simple-in-workers.js: Added.
      * fast/js/resources/Promise-then-in-workers.js: Added.
      * fast/js/resources/Promise-then-without-callbacks-in-workers.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd760697
    • rwlbuis@webkit.org's avatar
      Computed style of fill/stroke properties incorrect on references · 50fbb5b1
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114761
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      The computed style of the fill and stroke properties did not include
      the url() function. Added the url() string to output.
      
      Updated existing tests to cover the issue.
      
      * css/CSSPrimitiveValue.cpp: Cleanup.
      (WebCore::CSSPrimitiveValue::customCssText):
      * svg/SVGPaint.cpp: Added "url("
      (WebCore::SVGPaint::customCssText):
      
      LayoutTests:
      
      Add tests to verify that url function is included for references.
      
      * svg/css/script-tests/svg-attribute-parser-mode.js:
      * svg/css/svg-attribute-parser-mode-expected.txt:
      * transitions/svg-transitions-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50fbb5b1
    • roger_fong@apple.com's avatar
      <https://bugs.webkit.org/show_bug.cgi?id=119829> Add IAccessibleText and... · cdc57e72
      roger_fong@apple.com authored
      <https://bugs.webkit.org/show_bug.cgi?id=119829> Add IAccessibleText and IAccessibleEditableText interfaces and implementation to AppleWin port.
      
      Reviewed by Chris Fleizach.
      
      * AccessibleBase.cpp:
      (AccessibleBase::createInstance): Create an AccessibleText instance when necessary.
      (AccessibleBase::QueryService):
      * AccessibleBase.h:
      * AccessibleTextImpl.cpp: Added.
      (AccessibleText::AccessibleText):
      (AccessibleText::addSelection):
      (AccessibleText::get_attributes): Not Implemented
      (AccessibleText::get_caretOffset):
      (AccessibleText::get_characterExtents):
      (AccessibleText::get_nSelections):
      (AccessibleText::get_offsetAtPoint):
      (AccessibleText::get_selection):
      (AccessibleText::get_text):
      (AccessibleText::get_textBeforeOffset): Not Implemented
      (AccessibleText::get_textAfterOffset): Not Implemented
      (AccessibleText::get_textAtOffset): Not Implemented
      (AccessibleText::removeSelection):
      (AccessibleText::setCaretOffset):
      (AccessibleText::setSelection):
      (AccessibleText::get_nCharacters):
      (AccessibleText::scrollSubstringTo):
      (AccessibleText::scrollSubstringToPoint):
      (AccessibleText::get_newText): Not Implemented
      (AccessibleText::get_oldText): Not Implemented
      (AccessibleText::get_attributeRange): Not Implemented
      (AccessibleText::copyText):
      (AccessibleText::deleteText):
      (AccessibleText::insertText):
      (AccessibleText::cutText):
      (AccessibleText::pasteText):
      (AccessibleText::replaceText):
      (AccessibleText::setAttributes): Not Implemented
      (AccessibleText::QueryInterface):
      (AccessibleText::Release):
      (AccessibleText::convertSpecialOffset):
      (AccessibleText::initialCheck):
      * AccessibleTextImpl.h: Added.
      (AccessibleText::~AccessibleText):
      (AccessibleText::AddRef):
      * WebKit.vcxproj/Interfaces/Interfaces.vcxproj:
      * WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters:
      * WebKit.vcxproj/WebKit/WebKit.vcxproj:
      * WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj:
      * WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdc57e72
    • zandobersek@gmail.com's avatar
      Plenty of -Wcast-align warnings in KeywordLookup.h · fbef8ed9
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120316
      
      Reviewed by Darin Adler.
      
      * KeywordLookupGenerator.py: Use reinterpret_cast instead of a C-style cast when casting
      the character pointers to types of larger size. This avoids spewing lots of warnings
      in the KeywordLookup.h header when compiling with the -Wcast-align option.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fbef8ed9
    • zandobersek@gmail.com's avatar
      Undefine __STDC_LIMIT_MACROS and __STDC_CONSTANT_MACROS before redefining them · f3534a56
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120313
      
      Reviewed by Darin Adler.
      
      * wtf/LLVMHeaders.h: Undefine the two macros before they are defined again.
      This way we avoid the compilation-time warnings about the macros being invalidly redefined.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3534a56
    • zandobersek@gmail.com's avatar
      Prettify generated build guards in HTMLElementFactory.cpp · 289f739f
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120310
      
      Reviewed by Darin Adler.
      
      Build guards should wrap the constructor definitions without empty lines between
      the guards and the constructor code. Similarly, build guards for addTag calls
      shouldn't put an empty line after the build guard closure.
      
      * dom/make_names.pl:
      (printConstructorInterior):
      (printConstructors):
      (printFunctionInits):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      289f739f
    • robert@webkit.org's avatar
      Avoid painting every non-edge collapsed border twice over · db937eab
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119759
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Every collapsed border that isn't on the edge of a table gets painted at least twice, once by each
      adjacent cell. The joins are painted four times. This is unnecessary and results in tables with semi-transparent
      borders getting rendered incorrectly - each border adjoing two cells is painted twice and ends up darker than it should be.
      
      Fixing the overpainting at joins is another day's work. This patch ensures each collapsed border inside a table is only
      painted once. It does this by only allowing cells at the top and left edge of the table to paint their top and left collapsed borders.
      All the others can only paint their right and bottom collapsed border. This works because the borders are painted from bottom right to top left.
      
      Tests: fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl.html
             fast/table/border-collapsing/collapsed-borders-adjoining-sections.html
      
      * rendering/RenderTableCell.cpp:
      (WebCore::RenderTableCell::paintCollapsedBorders):
      
      LayoutTests:
      
      * fast/table/border-collapsing/collapsed-borders-adjoining-sections-expected.html: Added.
      * fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.png: Added.
      * fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt: Added.
          The painting here, though still wrong, is a progression on the behaviour prior to bug 11759 where
          the left border was painted twice. The painting can be resolved completely when we no longer paint
          twice at the border joins.
      * fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl.html: Added.
      * fast/table/border-collapsing/collapsed-borders-adjoining-sections.html: Added.
      * fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.png: Added.
      * fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt: Added.
      * fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db937eab
    • akling@apple.com's avatar
      Unreviewed build fix. · ccc2ab74
      akling@apple.com authored
      Source/WebCore:
      
      * page/Page.cpp:
      (WebCore::Page::setNeedsRecalcStyleInAllFrames):
      
      Source/WebKit/mac:
      
      * WebView/WebFrame.mm:
      (+[WebFrame _createMainFrameWithPage:frameName:frameView:]):
      
      Source/WebKit2:
      
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::createWithCoreMainFrame):
      (WebKit::WebFrame::createSubframe):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccc2ab74
    • bfulgham@apple.com's avatar
      Unreviewed buid fix. · cedcea8d
      bfulgham@apple.com authored
      * page/Page.cpp: 
      (WebCore::Page::setNeedsRecalcStyleInAllFrames): Remove extra '{' character.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cedcea8d
    • psolanki@apple.com's avatar
      PageGroup::groupSettings() should return a reference · 95fe3e51
      psolanki@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120319
      
      Reviewed by Andreas Kling.
      
      PageGroup::m_groupSettings is never NULL so we can just return a reference from groupSettings().
      
      Source/WebCore:
      
      * Modules/indexeddb/IDBFactory.cpp:
      * page/PageGroup.h:
      (WebCore::PageGroup::groupSettings):
      * storage/StorageNamespaceImpl.cpp:
      (WebCore::StorageNamespaceImpl::localStorageNamespace):
      * workers/DefaultSharedWorkerRepository.cpp:
      (WebCore::SharedWorkerProxy::groupSettings):
      * workers/WorkerMessagingProxy.cpp:
      (WebCore::WorkerMessagingProxy::startWorkerGlobalScope):
      
      Source/WebKit/blackberry:
      
      * Api/WebPage.cpp:
      (BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
      
      Source/WebKit/gtk:
      
      * webkit/webkitwebdatabase.cpp:
      (webkit_set_web_database_directory_path):
      
      Source/WebKit2:
      
      * WebProcess/Storage/StorageNamespaceImpl.cpp:
      (WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95fe3e51
    • akling@apple.com's avatar
      WebCore: Let Page create the main Frame. · 8e830e40
      akling@apple.com authored
      <https://webkit.org/b/119964>
      
      Source/WebCore:
      
      Reviewed by Anders Carlsson.
      
      Previously, Frame::create() would call Page::setMainFrame() when constructing the
      main Frame for a Page. Up until that point, Page had a null mainFrame().
      
      To guarantee that Page::mainFrame() is never null, we re-order things so that
      Page is responsible for creating its own main Frame. We do this at the earliest
      possible point; in the Page constructor initializer list.
      
      Constructing a Frame requires a FrameLoaderClient*, so I've added such a field to
      the PageClients struct.
      
      When creating a WebKit-layer frame, we now wrap the already-instantiated
      Page::mainFrame() instead of creating a new Frame.
      
      * loader/EmptyClients.cpp:
      (WebCore::fillWithEmptyClients):
      
          Add an EmptyFrameLoaderClient to the PageClients constructed here.
      
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::overlayPage):
      * svg/graphics/SVGImage.cpp:
      (WebCore::SVGImage::dataChanged):
      
          Updated to wrap Page::mainFrame() in a FrameView instead of creating their
          own Frame manually.
      
      * page/Frame.cpp:
      (WebCore::Frame::create):
      * page/Page.h:
      
          Remove Page::setMainFrame() and the only call site.
      
      * page/Page.cpp:
      (WebCore::Page::Page):
      
          Construct Page::m_mainFrame in the initializer list.
      
      (WebCore::Page::PageClients::PageClients):
      
          Add "FrameLoaderClient* loaderClientForMainFrame" to PageClients.
      
      (WebCore::Page::setNeedsRecalcStyleInAllFrames):
      
          Null-check the Frame::document() before calling through on it. This would
          otherwise crash when changing font-related Settings before calling init() on
          the Frame (like InspectorOverlay does.)
      
      Source/WebKit/gtk:
      
      Tweak WebKit1/GTK for changes in WebCore.
      
      Patch by Zan Dobersek <zdobersek@igalia.com>
      Reviewed by Gustavo Noronha Silva.
      
      * WebCoreSupport/FrameLoaderClientGtk.h:
      (WebKit::FrameLoaderClient::setWebFrame):
      * webkit/webkitwebframe.cpp:
      (webkit_web_frame_new):
      * webkit/webkitwebview.cpp:
      (webkit_web_view_init):
      
      Source/WebKit/mac:
      
      Reviewed by Anders Carlsson.
      
      * WebCoreSupport/WebFrameLoaderClient.h:
      (WebFrameLoaderClient::setWebFrame):
      
          Make it possible to construct a WebFrameLoaderClient with a null WebFrame*.
          A WebFrame* is later hooked up with a call to setWebFrame().
      
      * WebView/WebFrame.mm:
      (+[WebFrame _createMainFrameWithPage:frameName:frameView:]):
      
          Customized this method to wrap the Page::mainFrame() instead of creating a
          new Frame.
      
      * WebView/WebView.mm:
      (-[WebView _commonInitializationWithFrameName:groupName:]):
      
          Add a WebFrameLoaderClient to the PageClients passed to Page().
      
      Source/WebKit2:
      
      Reviewed by Anders Carlsson.
      
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::WebFrameLoaderClient):
      
          This starts out with a null WebFrame* pointer now.
      
      (WebKit::WebFrameLoaderClient::setWebFrame):
      
          WebFrame hooks itself up through this as soon as it's constructed.
      
      (WebKit::WebFrameLoaderClient::frameLoaderDestroyed):
      
          Tweak an out-of-date comment. The ref() we're balancing out comes from
          WebFrame::create().
      
      * WebProcess/WebPage/WebFrame.cpp:
      (WebKit::WebFrame::createWithCoreMainFrame):
      
          Rewrote createMainFrame() as createWithCoreMainFrame(). The new method wraps
          an existing WebCore::Frame instead of creating a new one.
      
      (WebKit::WebFrame::createSubframe):
      
          Merged WebFrame::init() into here since the logic isn't shared with main
          Frame creation anymore.
      
      (WebKit::WebFrame::create):
      (WebKit::WebFrame::WebFrame):
      
          Call WebFrameLoaderClient::setWebFrame(this).
      
      * WebProcess/WebPage/WebFrame.h:
      
          WebFrame::m_frameLoaderClient is now an OwnPtr rather than an inline member.
          This way it can be created before the WebFrame.
      
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::WebPage):
      
          Set up a WebFrameLoaderClient and pass it to the Page constructor along with
          the other PageClients.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e830e40
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed build fix. · 613d91e0
      bfulgham@apple.com authored
      * rendering/RenderMediaControls.cpp: Remove references to QuickTime controls
      that are no longer part of WKSI.
      (wkHitTestMediaUIPart): 
      (wkMeasureMediaUIPart):
      (wkDrawMediaUIPart):
      (wkDrawMediaSliderTrack):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      613d91e0
    • commit-queue@webkit.org's avatar
      <https://webkit.org/b/106133> document.body.scrollTop &... · 1cff1882
      commit-queue@webkit.org authored
      <https://webkit.org/b/106133> document.body.scrollTop & document.documentElement.scrollTop differ cross-browser
      
      Patch by Gurpreet Kaur <gur.trio@gmail.com> on 2013-08-26
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Webkit always uses document.body.scrollTop whether quirks or
      standard mode. Similiar behaviour is for document.body.scrollLeft.
      As per the specification webkit should return document.body.scrollTop
      for quirks mode and document.documentElement.scrollTop for standard mode.
      Same for document.body.scrollLeft and document.documentElement.scrollLeft.
      
      Tests: fast/dom/Element/scrollLeft-Quirks.html
             fast/dom/Element/scrollLeft.html
             fast/dom/Element/scrollTop-Quirks.html
             fast/dom/Element/scrollTop.html
      
      * dom/Element.cpp:
      (WebCore::Element::scrollLeft):
      (WebCore::Element::scrollTop):
      If the element does not have any associated CSS layout box or the element
      is the root element and the Document is in quirks mode return zero.
      Else If the element is the root element return the value of scrollY
      for scrollTop and scrollX for scrollLeft.
      * html/HTMLBodyElement.cpp:
      (WebCore::HTMLBodyElement::scrollLeft):
      (WebCore::HTMLBodyElement::scrollTop):
      If the element is the HTML body element, the Document is in quirks mode,
      return the value of scrollY for scrollTop and scrollX for scrollLeft.
      
      LayoutTests:
      
      * fast/dom/Element/scrollLeft-Quirks-expected.txt: Added.
      * fast/dom/Element/scrollLeft-Quirks.html: Added.
      * fast/dom/Element/scrollLeft-expected.txt: Added.
      * fast/dom/Element/scrollLeft.html: Added.
      * fast/dom/Element/scrollTop-Quirks-expected.txt: Added.
      * fast/dom/Element/scrollTop-Quirks.html: Added.
      * fast/dom/Element/scrollTop-expected.txt: Added.
      * fast/dom/Element/scrollTop.html: Added.
      Added new tests for verifying our behavior for document.body.scrollTop/scrollLeft and
      document.documentElement.scrollTop/scrollLeft for both Quirks as well as Standard mode.
      
      * fast/css/zoom-body-scroll-expected.txt:
      * fast/css/zoom-body-scroll.html:
      * fast/events/mouse-cursor.html:
      * http/tests/navigation/anchor-frames-expected.txt:
      * http/tests/navigation/anchor-frames-gbk-expected.txt:
      * http/tests/navigation/resources/frame-with-anchor-gbk.html:
      * http/tests/navigation/resources/frame-with-anchor-same-origin.html:
      * http/tests/navigation/resources/frame-with-anchor.html:
      * platform/mac-wk2/tiled-drawing/resources/scroll-and-load-page.html:
      * platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html:
      * platform/win/fast/css/zoom-body-scroll-expected.txt:
      Rebaselining existing tests as per the new behavior. The test cases are changed to use
      quirks mode because it uses document.body.scrollTop/scrollLeft and as per the new code
      document.body.scrollTop/scrollLeft will return correct value if document is in quirk mode
      Also test cases have been modified so that it tests what it used to.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cff1882
    • antti@apple.com's avatar
      REGRESSION (r154581): Some plugin tests failing in debug bots · 3fad2303
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120315
      
      Reviewed by Darin Adler.
              
      We are hitting the new no-event-dispatch-while-iterating assertion.
      
      Detaching deletes a plugin which modifies DOM while it dies.
      
      * dom/Document.cpp:
      (WebCore::Document::createRenderTree):
      (WebCore::Document::detach):
              
          Don't iterate at all. Document never has more than one Element child anyway.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fad2303
    • barraclough@apple.com's avatar
      RegExpMatchesArray should not call [[put]] · 49a919a4
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120317
      
      Reviewed by Oliver Hunt.
      
      This will call accessors on the JSObject/JSArray prototypes - so adding an accessor or read-only
      property called index or input to either of these prototypes will result in broken behavior.
      
      Source/JavaScriptCore: 
      
      * runtime/RegExpMatchesArray.cpp:
      (JSC::RegExpMatchesArray::reifyAllProperties):
          - put -> putDirect
      
      LayoutTests: 
      
      * fast/regex/lastIndex-expected.txt:
      * fast/regex/script-tests/lastIndex.js:
          - Added test
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      49a919a4
    • oliver@apple.com's avatar
      Building is so overrated. · 89147735
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89147735
    • oliver@apple.com's avatar
      Disable compression under MSVC for now · 1ac5b651
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ac5b651
    • bfulgham@apple.com's avatar
      [Windows] Updates to WKSI to get external builders working. · 84c36802
      bfulgham@apple.com authored
      * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
      * win/lib32/WebKitSystemInterface.lib:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84c36802
    • ddkilzer@apple.com's avatar
      BUILD FIX (r154580): RenderObject::document() returns a reference · 7389ed76
      ddkilzer@apple.com authored
      See: <https://webkit.org/b/120272>
      
      * accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
      (-[WebAccessibilityObjectWrapper _accessibilityParentForSubview:]):
      (AXAttributeStringSetHeadingLevel):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7389ed76
    • bfulgham@apple.com's avatar
      [Windows] Build fix after r154541. · 3e63670f
      bfulgham@apple.com authored
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Remove reference
      to deleted Element::pseudoElement(PseudoID), and add exports for new
      beforePseudoElement() and afterPseudoElement().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e63670f
    • bfulgham@apple.com's avatar
      [Windows] Build fix after r154578. Return Vector<String>() instead · 3667a55f
      bfulgham@apple.com authored
      of ListHashSet<String>().
      
      * platform/win/PasteboardWin.cpp:
      (WebCore::Pasteboard::types):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3667a55f
    • bfulgham@apple.com's avatar
      [Windows] Build fix after r154580. · 878424ce
      bfulgham@apple.com authored
      * rendering/RenderThemeWin.cpp: Mirror changes made for other ports now that
      Frame is known to always be valid when in a render tree. This allows us to
      get rid of some unneeded null checks.
      (WebCore::RenderThemeWin::getThemeData):
      (WebCore::RenderThemeWin::paintMenuList):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      878424ce
    • bfulgham@apple.com's avatar
      [Windows] Build fix after r154554. · 38bedef1
      bfulgham@apple.com authored
      * page/AutoscrollController.cpp: Correct various places where pointers are now
      references.
      (WebCore::AutoscrollController::stopAutoscrollTimer):
      (WebCore::AutoscrollController::startPanScrolling):
      (WebCore::AutoscrollController::autoscrollTimerFired):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38bedef1
    • carlosgc@webkit.org's avatar
      [GTK] Add WebKit2 API for isolated worlds · 85db5152
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=103377
      
      Reviewed by Anders Carlsson.
      
      * GNUmakefile.list.am: Add new files to compilation.
      * UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
      * UIProcess/API/gtk/tests/TestWebExtensions.cpp:
      (testWebExtensionWindowObjectCleared):
      (scriptDialogCallback):
      (runJavaScriptInIsolatedWorldFinishedCallback):
      (testWebExtensionIsolatedWorld):
      (beforeAll):
      * UIProcess/API/gtk/tests/WebExtensionTest.cpp:
      (echoCallback):
      (windowObjectCleared):
      (getWebPage):
      (methodCallCallback):
      * WebProcess/InjectedBundle/API/gtk/WebKitFrame.cpp:
      (webkit_frame_get_javascript_context_for_script_world): New public
      method to tget the JavaScript execution context for a given script
      world.
      * WebProcess/InjectedBundle/API/gtk/WebKitFrame.h:
      * WebProcess/InjectedBundle/API/gtk/WebKitScriptWorld.cpp: Added.
      (scriptWorlds): Global WebKitScriptWorld map.
      (_WebKitScriptWorldPrivate::~_WebKitScriptWorldPrivate):
      (webkitScriptWorldGet): Get the WebKitScriptWorld wrapping the
      given injected bundle script world.
      (webkitScriptWorldGetInjectedBundleScriptWorld): Get the injected
      bundle script world wrapped by the given WebKitScriptWorld.
      (webkitScriptWorldWindowObjectCleared): Emit
      WebKitScriptWorld::window-object-cleared signal.
      (webkitScriptWorldCreate): Create a new WebKitScriptWorld wrapping
      the given injected bundle script world.
      (createDefaultScriptWorld): Create the default WebKitScriptWorld
      wrapping the normal world.
      (webkit_script_world_get_default): Return the default WebKitScriptWorld.
      (webkit_script_world_new): Create a new isolated WebKitScriptWorld.
      * WebProcess/InjectedBundle/API/gtk/WebKitScriptWorld.h: Added.
      * WebProcess/InjectedBundle/API/gtk/WebKitScriptWorldPrivate.h: Added.
      * WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
      (didClearWindowObjectForFrame): Call webkitScriptWorldWindowObjectCleared().
      (webkitWebPageCreate): Add implementation for callback
      didClearWindowObjectForFrame in injected bundle loader client.
      * WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:
      Include WebKitScriptWorld.h.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      85db5152
    • carlosgc@webkit.org's avatar
      [WebKit2] Offsets for WKBundlePageLoaderClient in APIClientTraits are wrong · c163f96b
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120268
      
      Reviewed by Anders Carlsson.
      
      * Shared/APIClientTraits.cpp: Use always the first member of every
      version as the offset of the version.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c163f96b
    • zandobersek@gmail.com's avatar
      [GTK] Include most of the WebKit2 unit tests into the build and testing · 993d7cd5
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120307
      
      Reviewed by Philippe Normand.
      
      There are still various unit test source files that are not being included into
      the build. This patch includes most of these, only leaving out tests that do not
      compile or test features that are not supported by the GTK port.
      
      * Scripts/run-gtk-tests: Skip four newly-added tests that are failing or timing out.
      (TestRunner):
      * TestWebKitAPI/GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      993d7cd5
    • carlosgc@webkit.org's avatar
      [GTK] Allow to run tests without Xvfb in run-gtk-tests · e5803653
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120298
      
      Reviewed by Philippe Normand.
      
      Add --no-xvfb command line option to run tests in the current
      display.
      
      * Scripts/run-gtk-tests:
      (TestRunner._run_xvfb): Return early if option --no-xvfb has been
      passed.
      (TestRunner._setup_testing_environment): Use helper function
      _run_xvfb to start Xvfb if needed.
      (TestRunner._tear_down_testing_environment): Check Xvfb is
      actually running before trying to terminate it.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5803653
    • kov@webkit.org's avatar
      [GTK L10N] Updated Brazilian Portuguese translation for WebKitGTK+ · 7283da3a
      kov@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120193
      
      Patch by Enrico Nicoletto <liverig@gmail.com> on 2013-08-26
      Reviewed by Gustavo Noronha Silva.
      
      * pt_BR.po: Updated.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7283da3a
    • zarvai@inf.u-szeged.hu's avatar
      Adding Gabor Abraham to contributors.json. · f6e9e95f
      zarvai@inf.u-szeged.hu authored
      Reviewed by Csaba Osztrogonác.
      
      * Scripts/webkitpy/common/config/contributors.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6e9e95f
    • akling@apple.com's avatar
      Move DocumentTiming inside ENABLE(WEB_TIMING) guards. · 6e652df9
      akling@apple.com authored
      <https://webkit.org/b/120281>
      
      Reviewed by Anders Carlsson.
      
      Looks like this struct is only used by other ENABLE(WEB_TIMING) code, so don't bother
      filling it in if we're not building like that.
      
      * dom/Document.cpp:
      (WebCore::Document::setReadyState):
      (WebCore::Document::finishedParsing):
      * dom/Document.h:
      * dom/DocumentTiming.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e652df9
    • gyuyoung.kim@samsung.com's avatar
      Unreviewed, EFL gardening. EFL WK1 DRT doesn't support exif-orientation tests · c1a2b0f0
      gyuyoung.kim@samsung.com authored
      * platform/efl-wk1/TestExpectations: Add fast/images/exif-orientation-composited.html as failure.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1a2b0f0
    • carlosgc@webkit.org's avatar
      [GTK] Add support for passing test directories to run-gtk-tests · 71b7492d
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120296
      
      Reviewed by Philippe Normand.
      
      * Scripts/run-gtk-tests:
      (TestRunner._get_tests_from_dir): Helper function to return all
      unit tests found in a given directory.
      (TestRunner._get_tests): Check the given tests passed in the
      command line, so that if a directory is found the tests contained
      in the directory are added to the list of tests to run.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71b7492d
    • carlosgc@webkit.org's avatar
      [GTK] Improve the stop/reload button implementation in MiniBrowser · 92012cf4
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120292
      
      Reviewed by Philippe Normand.
      
      - Use an instance member of BrowserWindow for the button widget
        instead of a global variable.
      - Use notify::is-loading to monitor the WebView load instead of
        the estimated-load-progress property.
      - Use webkit_web_view_is_loading() to check whether the view
        is loading to change the button icon instead of a string
        comparison of the gtk stock icon id.
      - Use the right casts to fix compile warning.
      
      * MiniBrowser/gtk/BrowserWindow.c:
      (reloadOrStopCallback):
      (webViewLoadProgressChanged):
      (webViewIsLoadingChanged):
      (browser_window_init):
      (browserWindowConstructed):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92012cf4
    • commit-queue@webkit.org's avatar
      [Qt] Remove the fix in QWebPage::javaScriptConsoleMessage introduced by (r61433) · 40f338cb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119791
      
      Source/WebKit/qt:
      
      Patch by Arunprasad Rajkumar <arurajku@cisco.com> on 2013-08-26
      Reviewed by Jocelyn Turcotte.
      
      * WidgetApi/qwebpage.cpp:
      (QWebPage::javaScriptConsoleMessage): Removed hack specific to DRT, introduced by
      (r61433).
      
      Tools:
      
      Patch by Arunprasad Rajkumar <arurajku@cisco.com> on 2013-08-26
      Reviewed by Jocelyn Turcotte.
      
      Load empty url to send onunload event to currently running page. onunload event is
      mandatory for LayoutTests/plugins/open-and-close-window-with-plugin.html and
      LayoutTests/plugins/geturlnotify-during-document-teardown.html.
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebPage::~WebPage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40f338cb
    • carlosgc@webkit.org's avatar
      [GTK] Silence MiniBrowser compile warnings due to recent GTK+ deprecations · 65016125
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120290
      
      Reviewed by Philippe Normand.
      
      * MiniBrowser/gtk/GNUmakefile.am: Add
      -DGDK_VERSION_MIN_REQUIRED=GDK_VERSION_3_6 compile option.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65016125
    • carlosgc@webkit.org's avatar
      [GTK] Add missing initializer for pluginLoadPolicy in WKPageLoaderClient · e2aab3ca
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120289
      
      Reviewed by Philippe Normand.
      
      * UIProcess/API/gtk/WebKitLoaderClient.cpp:
      (attachLoaderClientToView): Add initializer for pluginLoadPolicy
      and rename the comment of the previous one as
      pluginLoadPolicy_deprecatedForUseWithV2.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2aab3ca
    • zandobersek@gmail.com's avatar
      [GTK] Add WillLoad test files to the TestWebKitAPI/TestWebKit2 program · c3953e52
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120288
      
      Reviewed by Carlos Garcia Campos.
      
      * TestWebKitAPI/GNUmakefile.am: Add the WillLoad.cpp build target that should be compiled
      into the TestWebKit2 program. The InjectedBundle counterpart file is added to the build as well.
      These unit tests are at the moment failing in debug configurations, so it would be nice to
      have the GTK builds report these failures as well.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c3953e52
    • carlosgc@webkit.org's avatar
      [GTK] webkitCredentialGetCredential returns a temporary in g_return_val_if_fail · 72fd2e7b
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120287
      
      Reviewed by Philippe Normand.
      
      * UIProcess/API/gtk/WebKitCredential.cpp:
      (webkitCredentialGetCredential): Use ASSERT() instead of
      g_return_val_if_fail() since this is a private function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72fd2e7b
    • carlosgc@webkit.org's avatar
      [GTK] Fix compile warning in WebKitDOMCustom · 8e03e247
      carlosgc@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120286
      
      Reviewed by Philippe Normand.
      
      * bindings/gobject/WebKitDOMCustom.cpp:
      (webkit_dom_html_element_get_item_type): Add return 0.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e03e247
    • ryuan.choi@samsung.com's avatar
      [EFL] EWebLauncher is executed as full screen with device pixel ratio · e9a0cde5
      ryuan.choi@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120282
      
      Reviewed by Gyuyoung Kim.
      
      * EWebLauncher/main.c:
      Use double instead of float for device_pixel_ratio which is passed to ECORE_GETOPT_VALUE_DOUBLE.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e9a0cde5