1. 12 Nov, 2007 30 commits
  2. 11 Nov, 2007 10 commits
    • aroben@apple.com's avatar
      Fix <rdar://5578982> ASSERT in... · 390aaf4f
      aroben@apple.com authored
              Fix <rdar://5578982> ASSERT in HashTable::checkTableConsistencyExceptSize beneath WebNotificationCenter
      
              The bug was due to a mismatch between HashMap::remove and
              HashTable::checkTableConsistency. HashMap::remove can delete the value
              stored in the HashTable (by derefing it), which is not normally
              allowed by HashTable. It's OK in this case because the value is about
              to be removed from the table, but HashTable wasn't aware of this.
      
              HashMap::remove now performs the consistency check itself before
              derefing the value.
      
              Darin noticed that the same bug would occur in HashSet, so I've fixed
              it there as well.
      
              Reviewed by Darin.
      
              * wtf/HashMap.h:
              (WTF::HashMap::remove): Perform the HashTable consistency check
              manually before calling deref.
              * wtf/HashSet.h:
              (WTF::HashSet::remove): Ditto.
              * wtf/HashTable.h: Made checkTableConsistency public so that HashMap
              and HashSet can call it.
              (WTF::HashTable::removeAndInvalidateWithoutEntryConsistencyCheck):
              Added.
              (WTF::HashTable::removeAndInvalidate): Added.
              (WTF::HashTable::remove):
              (WTF::HashTable::removeWithoutEntryConsistencyCheck): Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      390aaf4f
    • mrowe@apple.com's avatar
      Roll out r27708 as it breaks the Mac PowerPC build. · c05214d7
      mrowe@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c05214d7
    • mrowe@apple.com's avatar
      2007-11-11 Mike Hommey <mh+webkit@glandium.org> · 383057a9
      mrowe@apple.com authored
              Reviewed by Maciej.
      
              Fix http://bugs.webkit.org/show_bug.cgi?id=14521
              Bug 14521: JavaScriptCore fails to build on Linux/PPC gcc 4.1.2
      
              * wtf/TCSpinLock.h:
              (TCMalloc_SpinLock::Unlock): Change constraint from o to m.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      383057a9
    • mrowe@apple.com's avatar
      2007-11-11 Justin Haygood <jhaygood@reaktix.com> · 6f520711
      mrowe@apple.com authored
              Reviewed by Adam Roben.
      
              http://bugs.webkit.org/show_bug.cgi?id=15939
              Adds a currentThread API for use by SQLiteDatabase, etc.
      
              * platform/Threading.h:
              * platform/ThreadingNone.cpp:
              (WebCore::currentThread):
              * platform/gtk/ThreadingGtk.cpp:
              (WebCore::identifierByGthreadHandle):
              (WebCore::):
              * platform/pthreads/ThreadingPthreads.cpp:
              (WebCore::identifierByPthreadHandle):
              (WebCore::currentThread):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f520711
    • mitz@apple.com's avatar
      WebCore: · cb71b59e
      mitz@apple.com authored
              Reviewed by Adam Roben.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=15942
                REGRESSION: Selecting "Edit Html" tab in Blogger causes crash (Assertion failed: isRange())
      
              Test: editing/selection/cleared-by-relayout.html
      
              * editing/Selection.cpp:
              (WebCore::Selection::toRange): Check if the selection has been cleared
              by updating layout.
      
      LayoutTests:
      
              Reviewed by Adam Roben.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=15942
                REGRESSION: Selecting "Edit Html" tab in Blogger causes crash (Assertion failed: isRange())
      
              * editing/selection/cleared-by-relayout-expected.txt: Added.
              * editing/selection/cleared-by-relayout.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cb71b59e
    • darin@apple.com's avatar
      Reviewed by Mark Rowe. · 4dfc68a2
      darin@apple.com authored
              - fix line numbers that were off since my recent patch
      
              * platform/SegmentedString.h:
              (WebCore::SegmentedSubstring::SegmentedSubstring): Reversed the sense of m_excludeLineNumbers
              and rename it to m_doNotExcludeLineNumbers.
              (WebCore::SegmentedSubstring::excludeLineNumbers): Updated.
              (WebCore::SegmentedSubstring::doNotExcludeLineNumbers): Added.
              (WebCore::SegmentedSubstring::setExcludeLineNumbers): Updated.
              (WebCore::SegmentedString::advance): Use doNotExcludeLineNumbers to reverse the sense and fix
              the regression, but keep the speediness. I accidentally had removed a ! here.
      
              * platform/SegmentedString.cpp:
              (WebCore::SegmentedString::advanceSlowCase): Use doNotExcludeLineNumbers.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4dfc68a2
    • oliver's avatar
      Fix for <rdar://problem/5585334> · b1bdd112
      oliver authored
      Reviewed by Darin.
      
      Fix for <rdar://problem/5585334> numfuzz: integer overflows opening
      malformed SVG file in WebCore::ImageBuffer::create. Add protection
      against a potential overflow.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1bdd112
    • mrowe@apple.com's avatar
      2007-11-11 Mark Rowe <mrowe@apple.com> · 3f065f4a
      mrowe@apple.com authored
              Build fix.  Use the correct filename case.
      
              * kjs/nodes.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f065f4a
    • ggaren@apple.com's avatar
      Reviewed by Sam Weinig. · a862ba22
      ggaren@apple.com authored
              
              Fixed http://bugs.webkit.org/show_bug.cgi?id=15902
              15% of string-validate-input.js is spent compiling the same regular expression
              
              Store a compiled representation of the regular expression in the AST.
              
              Only a .2% SunSpider speedup overall, but a 10.6% speedup on 
              string-validate-input.js.
      
              * kjs/nodes.cpp:
              (KJS::RegExpNode::evaluate):
              * kjs/nodes.h:
              (KJS::RegExpNode::):
              * kjs/nodes2string.cpp:
              (KJS::RegExpNode::streamTo):
              * kjs/regexp.cpp:
              (KJS::RegExp::flags):
              * kjs/regexp.h:
              (KJS::RegExp::pattern):
              * kjs/regexp_object.cpp:
              (KJS::RegExpObjectImp::construct):
              (KJS::RegExpObjectImp::createRegExpImp):
              * kjs/regexp_object.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a862ba22
    • antti@apple.com's avatar
      Reviewed by Darin. · acca0adc
      antti@apple.com authored
              Fix a bunch of cases where the exception code is checked by the function but is not zeroed first.
      
              * bindings/js/kjs_binding.cpp:
              (KJS::setDOMException):
              * dom/Attr.cpp:
              (WebCore::Attr::setPrefix):
              * dom/Document.cpp:
              (WebCore::Document::createElement):
              * dom/Element.cpp:
              (WebCore::Element::setPrefix):
              * dom/Range.cpp:
              (WebCore::Range::setStart):
              (WebCore::Range::setEnd):
              (WebCore::Range::isPointInRange):
              (WebCore::Range::comparePoint):
              (WebCore::Range::compareBoundaryPoints):
              (WebCore::Range::deleteContents):
              (WebCore::Range::processContents):
              (WebCore::Range::extractContents):
              (WebCore::Range::insertNode):
              (WebCore::Range::setStartAfter):
              (WebCore::Range::setEndBefore):
              (WebCore::Range::setEndAfter):
              (WebCore::Range::selectNode):
              (WebCore::Range::surroundContents):
              (WebCore::Range::setStartBefore):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::TextIterator):
              * html/CanvasRenderingContext2D.cpp:
              (WebCore::CanvasRenderingContext2D::createPattern):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::play):
              (WebCore::HTMLMediaElement::pause):
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::add):
              (WebCore::HTMLSelectElement::setOption):
              * xml/XPathEvaluator.cpp:
              (WebCore::XPathEvaluator::evaluate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@27701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      acca0adc