1. 15 Sep, 2009 6 commits
    • mrowe@apple.com's avatar
      WebCore: Document.elementFromPoint() and Document.caretRangeFromPoint()... · bc939268
      mrowe@apple.com authored
      WebCore: Document.elementFromPoint() and Document.caretRangeFromPoint() erroneously returning null at points visible only after scrolling.
      https://bugs.webkit.org/show_bug.cgi?id=29245
      
      Patch by Andrew Richards <randrew@gmail.com> on 2009-09-14
      Reviewed by Sam Weinig.
      
      Use visibleContentRect() instead of boundsRect() when checking hit point bounds on viewport.
      
      * dom/Document.cpp:
      (WebCore::Document::elementFromPoint):
      (WebCore::Document::caretRangeFromPoint):
      
      LayoutTests: Document.elementFromPoint() and Document.caretRangeFromPoint() returning null at points visible only after scrolling.
      https://bugs.webkit.org/show_bug.cgi?id=29245
      
      Patch by Andrew Richards <randrew@gmail.com> on 2009-09-14
      Reviewed by Sam Weinig.
      
      Extend tests to include hits in areas that are not in the initial containing block of the page.
      
      * fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
      * fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
      * fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
      * fast/dom/elementFromPoint-relative-to-viewport.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48398 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc939268
    • jshin@chromium.org's avatar
      2009-09-15 Jungshik Shin <jshin@chromium.org> · d338fbea
      jshin@chromium.org authored
              Reviewed by Eric Seidel
      
              http://bugs.webkit.org/show_bug.cgi?id=26660
      
              Chromium Windows: When rotated, the baseline for a span of complex
              script is completely misaligned with that of the adjacent 
              simple script text. It's fixed by not applying the baseline offset for
              the Skia code path.
      
              Test: transforms/2d/hindi-rotated.html
      
              * platform/graphics/chromium/UniscribeHelper.cpp:
              (WebCore::UniscribeHelper::draw):
      
      2009-09-15  Jungshik Shin  <jshin@chromium.org>
      
              Reviewed by Eric Seidel
      
              http://bugs.webkit.org/show_bug.cgi?id=26660
      
              Chromium Windows: When rotated, the baseline for a span of complex
              script is completely misaligned with that of the adjacent simple
              script text.
      
              * transforms/2d/hindi-rotated.html: Added.
              * platform/mac/transforms/2d/hindi-rotated-expected.checksum: Added.
              * platform/mac/transforms/2d/hindi-rotated-expected.png: Added.
              * platform/mac/transforms/2d/hindi-rotated-expected.txt: Added.
              * platform/win/transforms: Added.
              * platform/win/transforms/2d: Added.
              * platform/win/transforms/2d/hindi-rotated-expected.checksum: Added.
              * platform/win/transforms/2d/hindi-rotated-expected.png: Added.
              * platform/win/transforms/2d/hindi-rotated-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48397 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d338fbea
    • andersca@apple.com's avatar
      Pass the PopupMenu pointer to CreateWindowEx and then get it from the LPCREATESTRUCT in · b2ad560f
      andersca@apple.com authored
      the WM_CREATE handler. This way we don't have to first create an zero size window and then size it.
              
      Reviewed by Adam Roben.
      
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenu::show):
      (WebCore::PopupMenu::PopupMenuWndProc):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48396 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2ad560f
    • atwilson@chromium.org's avatar
      MessageEvent should not be cancelable by default · 70fae526
      atwilson@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=27846
      
      Reviewed by Darin Adler.
      
      WebCore:
      
      * dom/MessageEvent.cpp:
      (WebCore::MessageEvent::MessageEvent):
      Changed constructor to set cancelable=false by default, per the HTML5 spec.
      
      LayoutTests:
      
      * fast/events/message-port-expected.txt:
      * fast/events/message-port.html:
      Added test case to check state of MessageEvent.cancelable attribute.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70fae526
    • eric@webkit.org's avatar
      2009-09-15 Charles Wei <charles.wei@torchmobile.com.cn> · 569d7bc8
      eric@webkit.org authored
              Reviewed by George Staikos.
      
              Add a new test case for SVG Path parsing with a default command and starts with dot '.'
              https://bugs.webkit.org/show_bug.cgi?id=29123
      
              * svg/dom/path-parser-expected.txt:
              * svg/dom/resources/path-parser.js:
      2009-09-15  Charles Wei  <charles.wei@torchmobile.com.cn>
      
              Reviewed by George Staikos.
      
              Fix SVG path parsing error if a command starts with dot '.'
              https://bugs.webkit.org/show_bug.cgi?id=29123
      
              * svg/SVGParserUtilities.cpp:
              (WebCore::SVGPathParser::parseSVG):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      569d7bc8
    • rik@webkit.org's avatar
      Implement conditional breakpoints in the Web Inspector frontend. · d345fed8
      rik@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=28908
      
      Patch by Alexander Pavlov <apavlov@chromium.org> on 2009-09-15
      Reviewed by Timothy Hatcher.
      
      * English.lproj/localizedStrings.js:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * inspector/front-end/Breakpoint.js:
      (WebInspector.Breakpoint.prototype.set condition):
      * inspector/front-end/Popup.js: Added.
      (WebInspector.Popup):
      (WebInspector.Popup.prototype.show):
      (WebInspector.Popup.prototype.hide):
      (WebInspector.Popup.prototype.get visible):
      (WebInspector.Popup.prototype.set element):
      (WebInspector.Popup.prototype.get element):
      (WebInspector.Popup.prototype.positionElement):
      (WebInspector.Popup.prototype.set anchor):
      (WebInspector.Popup.prototype.get anchor):
      (WebInspector.Popup.prototype.set autoHide):
      (WebInspector.Popup.prototype._checkNotVisible):
      (WebInspector.Popup.prototype._keyEventHandler):
      (WebInspector.Popup.prototype._mouseDownEventHandler):
      * inspector/front-end/SourceFrame.js:
      (WebInspector.SourceFrame.prototype.revealLine):
      (WebInspector.SourceFrame.prototype._loaded):
      (WebInspector.SourceFrame.prototype._documentContextMenu):
      (WebInspector.SourceFrame.prototype._documentMouseDown):
      (WebInspector.SourceFrame.prototype._editBreakpointCondition.committed):
      (WebInspector.SourceFrame.prototype._editBreakpointCondition.dismissed):
      (WebInspector.SourceFrame.prototype._editBreakpointCondition):
      (WebInspector.SourceFrame.prototype._showBreakpointConditionPopup):
      (WebInspector.SourceFrame.prototype._createPopupElement):
      (WebInspector.SourceFrame.prototype._addBreakpointToSource):
      (WebInspector.SourceFrame.prototype._removeBreakpointFromSource):
      (WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded.drawBreakpoint):
      (WebInspector.SourceFrame.prototype._drawBreakpointImagesIfNeeded):
      * inspector/front-end/WebKit.qrc:
      * inspector/front-end/inspector.html:
      * inspector/front-end/inspector.js:
      (WebInspector.set currentFocusElement):
      (WebInspector.set currentPanel):
      (WebInspector.loaded):
      (WebInspector.contextMenu):
      (WebInspector.elementDragStart):
      (WebInspector.updateResource):
      (WebInspector.drawLoadingPieChart):
      (WebInspector.linkifyURLAsNode):
      (WebInspector.startEditing.getContent):
      (WebInspector.startEditing.editingCancelled):
      (WebInspector.startEditing.editingCommitted):
      * inspector/front-end/utilities.js:
      (Element.prototype.positionAt):
      (Element.prototype.offsetRelativeToWindow):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48392 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d345fed8
  2. 14 Sep, 2009 17 commits
    • beidson@apple.com's avatar
      Page cache should support pages with unload handlers as an experiment. · 4bb4ad00
      beidson@apple.com authored
      <rdar://problem/7196485> and https://bugs.webkit.org/show_bug.cgi?id=29021
      
      Reviewed by Darin Adler.
      
      WebCore: 
      
      For the experiment, only allow pages with unload handlers into the Page Cache on
      Mac and Windows.
      
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::canCachePageContainingThisFrame):
      (WebCore::FrameLoader::logCanCacheFrameDecision):
      
      LayoutTests: 
      
      Disable fast/loader/frames-with-unload-handlers-in-page-cache.html as it doesn't
      make sense in the context of this experiment.
      
      * platform/mac/Skipped: 
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48388 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bb4ad00
    • simon.fraser@apple.com's avatar
      2009-09-14 Simon Fraser <simon.fraser@apple.com> · 339a522b
      simon.fraser@apple.com authored
              Fix the change in r48376 to do a null-check to fix a crashing test.
      
              * dom/SelectElement.cpp:
              (WebCore::SelectElement::menuListDefaultEventHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      339a522b
    • simon.fraser@apple.com's avatar
      2009-09-14 Simon Fraser <simon.fraser@apple.com> · d15e7113
      simon.fraser@apple.com authored
              Reviewed by Dan Bernstein.
      
              <rdar://problem/7047282> Safari crashes at WebCore::RenderMenuList::adjustInnerStyle() + 436
      
              Avoid a crash when a mouse event handler on a <select> changes the select from a popup
              to a list (by setting the 'size' property) inside the event handler.
      
              Test: fast/forms/select-change-popup-to-listbox-in-event-handler.html
      
              * dom/SelectElement.cpp:
              (WebCore::SelectElement::menuListDefaultEventHandler):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48376 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d15e7113
    • andersca@apple.com's avatar
      More PopupMenu cleanup. · 9c644ee7
      andersca@apple.com authored
              
      Reviewed by Jon Honeycutt.
      
      * platform/PopupMenu.h:
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenu::show):
      Call registerClass.
              
      (WebCore::PopupMenu::registerClass):
      Make this a private static member function so it can refer to PopupMenuWndProc.
              
      (WebCore::PopupMenu::PopupMenuWndProc):
      Try to get the PopupMenu and call its wndProc member function.
              
      (WebCore::PopupMenu::wndProc):
      Make this a member function.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48375 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c644ee7
    • beidson@apple.com's avatar
    • andersca@apple.com's avatar
      Speculative Qt build fix. · 60e72d84
      andersca@apple.com authored
              
      * platform/qt/QWebPopup.cpp:
      (WebCore::QWebPopup::hidePopup):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48372 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60e72d84
    • eric@webkit.org's avatar
      2009-09-14 Dirk Pranke <dpranke@chromium.org> · 1a947e05
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Fix RenderThemeChromiumWin::determineClassicState so that classic_state
              matches the state values (and you get a single classic_state value
              for a given {part,state} value. This change will be tested by a
              chromium patch that will land after this.
      
              This will be tested by code landing downstream on Chromium.org; the
              code does not execute on webkit.org.
      
              * rendering/RenderThemeChromiumWin.cpp:
              (WebCore::RenderThemeChromiumWin::determineClassicState):
              (WebCore::RenderThemeChromiumWin::getThemeData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a947e05
    • andersca@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=29138 · f3f30068
      andersca@apple.com authored
      Simplify popup menu handling.
      
      Reviewed by Adam Roben.
      
      * platform/PopupMenuClient.h:
      Rename hidePopup to popupDidHide.
              
      * platform/chromium/PopupMenuChromium.cpp:
      (WebCore::PopupListBox::handleKeyEvent):        
      (WebCore::PopupListBox::abandon):
      (WebCore::PopupListBox::acceptIndex):
      Call popupDidHide instead of hidePopup.
              
      * platform/gtk/PopupMenuGtk.cpp:
      (WebCore::PopupMenu::menuUnmapped):
      Ditto.
              
      * platform/mac/PopupMenuMac.mm:
      (WebCore::PopupMenu::show):
      Ditto.
              
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenu::hide):
      Call popupDidHide.
              
      (WebCore::PopupWndProc):
      Call PopupMenu::hide.
              
      * platform/wx/PopupMenuWx.cpp:
      (WebCore::PopupMenu::OnMenuItemSelected):
      Call popupDidHide.
              
      * rendering/RenderMenuList.cpp:
      (WebCore::RenderMenuList::hidePopup):
      (WebCore::RenderMenuList::popupDidHide):
      * rendering/RenderMenuList.h:
      Set the "popup is visible" flag in popupDidHide.
              
      * rendering/RenderTextControlSingleLine.cpp:
      (WebCore::RenderTextControlSingleLine::hidePopup):
      (WebCore::RenderTextControlSingleLine::popupDidHide):
      * rendering/RenderTextControlSingleLine.h:
      Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48370 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3f30068
    • andersca@apple.com's avatar
      - Fix <rdar://problem/7182275>. · f71cce3d
      andersca@apple.com authored
      Reviewed by David Hyatt.
      
      Make sure that the newly created scrollbar's style is up to date.
              
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenu::~PopupMenu):
      Call setParent so that the scrollbar's parts are torn down correctly.
              
      (WebCore::PopupMenu::show):
      Call styleChanged.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48369 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f71cce3d
    • jhoneycutt@apple.com's avatar
      <rdar://problem/7197644> WebKit should broadcast an MSAA event when · 4a7e40ab
      jhoneycutt@apple.com authored
      jumping to a named anchor
      
      https://bugs.webkit.org/show_bug.cgi?id=28899
      
      Reviewed by Adam Roben.
      
      * accessibility/AXObjectCache.h:
      (WebCore::AXObjectCache::):
      Added declaration for handleScrolledToAnchor(). Added a new entry to
      the enum of accessibility notifications.
      
      * accessibility/AccessibilityObject.cpp:
      (WebCore::AccessibilityObject::firstAccessibleObjectFromNode):
      Code moved from AccessibilityRenderObject::internalLinkElement() and
      refactored slightly; walks the tree until it finds a Node (with a
      renderer) whose accessibility is not ignored.
      
      * accessibility/AccessibilityObject.h:
      Added a declaration for firstAccessibleObjectFromNode().
      
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::internalLinkElement):
      Code moved to AccessibilityObject::firstAccessibleObjectFromNode().
      
      * accessibility/chromium/AXObjectCacheChromium.cpp:
      (WebCore::AXObjectCache::handleScrolledToAnchor):
      Stubbed.
      
      * accessibility/gtk/AXObjectCacheAtk.cpp:
      (WebCore::AXObjectCache::handleScrolledToAnchor):
      Stubbed.
      
      * accessibility/mac/AXObjectCacheMac.mm:
      (WebCore::AXObjectCache::postPlatformNotification):
      Add a default case that returns early for notifications that Mac
      doesn't handle.
      (WebCore::AXObjectCache::handleScrolledToAnchor):
      Stubbed.
      
      * accessibility/win/AXObjectCacheWin.cpp:
      (WebCore::AXObjectCache::handleScrolledToAnchor):
      Post an AXScrolledToAnchor notification for the first accessible from
      the anchor Node.
      (WebCore::AXObjectCache::postPlatformNotification):
      If the notification is AXFocusedUIElementChanged, fire an
      EVENT_OBJECT_FOCUS. If the notification is AXScrolledToAnchor, fire
      EVENT_SYSTEM_SCROLLINGSTART, matching Firefox.
      (WebCore::AXObjectCache::handleFocusedUIElementChanged):
      Code moved to postPlatformNotification().
      
      * page/FrameView.cpp:
      (WebCore::FrameView::scrollToAnchor):
      Call AXObjectCache::handleScrolledToAnchor().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a7e40ab
    • rik@webkit.org's avatar
      Cookies are not inspectable after reloading a page · 0812708a
      rik@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=29222
      
      Patch by Anthony Ricaud <rik@webkit.org> on 2009-09-14
      Reviewed by Timothy Hatcher.
      
      Create the cookieTreeElement on initialization instead of when the view is shown.
      Reset the selected element of the sidebar on reset.
      
      * inspector/front-end/StoragePanel.js:
      (WebInspector.StoragePanel):
      (WebInspector.StoragePanel.prototype.show):
      (WebInspector.StoragePanel.prototype.reset):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48366 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0812708a
    • beidson@apple.com's avatar
      Windows build fix. · 9d9f85c8
      beidson@apple.com authored
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
      (WebCore::ResourceHandle::receivedCredential):
      (WebCore::WebCoreSynchronousLoader::didReceiveChallenge):
      (WebCore::WebCoreSynchronousLoader::load):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d9f85c8
    • beidson@apple.com's avatar
      Safari 4 cannot be used to update firmware on Linksys routers. · 29c8b21b
      beidson@apple.com authored
      <rdar://problem/7174050> and https://bugs.webkit.org/show_bug.cgi?id=29160
      
      Reviewed by Alexey Proskuryakov.
      
      WebCore: 
      
      In http://trac.webkit.org/changeset/42483, we disabled CFNetwork's session credential storage and 
      implemented our own in WebCore.
      
      One feature we lost is that CFNetwork would automatically send previously authenticated credentials
      with new connections when the paths match, as allowed by RFC 2617 for HTTP Basic and Digest Authentication.  
      
      Even though it's optional for User Agents to do this, (some?) Linksys routers rely on this behavior for
      HTTP Basic Authentication.  So now WebCore's CredentialStorage will track URL paths for Basic credentials.
      
      We're not making this enhancement for Digest at this time, since we don't know of anything that broke
      due to the change in Digest behavior.
      
      Test: http/tests/loading/basic-credentials-sent-automatically.html
            http/tests/loading/basic-auth-resend-wrong-credentials.html
      
      * WebCore.base.exp:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      
      * platform/network/Credential.cpp:
      (WebCore::Credential::isEmpty):
      * platform/network/Credential.h:
      
      Add a slightly more full featured CredentialStore that will track URL paths a credential belongs to:
      * platform/network/CredentialStorage.cpp: Added.
      (WebCore::protectionSpaceToCredentialMap):
      (WebCore::originToDefaultCredentialMap):
      (WebCore::originStringFromURL):
      (WebCore::CredentialStorage::set):
      (WebCore::CredentialStorage::get):
      (WebCore::CredentialStorage::getDefaultAuthenticationCredential):
      * platform/network/CredentialStorage.h: Added.
      
      Allow ProtectionSpace to be a hash key:
      * platform/network/ProtectionSpace.cpp:
      (WebCore::ProtectionSpace::ProtectionSpace):
      * platform/network/ProtectionSpace.h:
      (WebCore::ProtectionSpace::ProtectionSpace):
      (WebCore::ProtectionSpace::isHashTableDeletedValue):
      * platform/network/ProtectionSpaceHash.h: Added.
      (WebCore::ProtectionSpaceHash::hash):
      (WebCore::ProtectionSpaceHash::equal):
      
      Allow ResourceHandles to remember the initial credential they used:
      * platform/network/ResourceHandleInternal.h:
      
      Allow mutable ResourceRequests to update their platform object if HTTP header fields change:
      * platform/network/ResourceRequestBase.cpp:
      (WebCore::ResourceRequestBase::addHTTPHeaderField):
      
      Remove WebCoreCredentialStorage:
      * platform/network/cf/AuthenticationCF.cpp:
      * platform/network/cf/AuthenticationCF.h:
      * platform/network/mac/AuthenticationMac.h:
      * platform/network/mac/AuthenticationMac.mm:
      
      Change ResourceHandleCFNet to try to use stored credentials on new connections, if appropriate:
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::ResourceHandle::start):
      (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed
        Credential if it does not match the initially used Credential.
      (WebCore::ResourceHandle::receivedCredential):
      (WebCore::WebCoreSynchronousLoader::didReceiveChallenge): Only try the ProtectionSpace key'ed
        Credential if it does not match the initially used Credential.
      (WebCore::WebCoreSynchronousLoader::load):
      
      Change ResourceHandleMac to try to use stored credentials on new connections, if appropriate:
      * platform/network/mac/ResourceHandleMac.mm:
      (WebCore::ResourceHandle::start):
      (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Only try the ProtectionSpace key'ed
        Credential if it does not match the initially used Credential.
      (WebCore::ResourceHandle::receivedCredential):
      (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Only try the 
        ProtectionSpace key'ed Credential if it does not match the initially used Credential.
      (+[WebCoreSynchronousLoader loadRequest:allowStoredCredentials:returningResponse:error:]):
      
      Add base64-ability to CString:
      * platform/text/CString.cpp:
      (WebCore::CStringBuffer::base64Encode):
      (WebCore::CString::base64Encode):
      * platform/text/CString.h:
      (WebCore::CStringBuffer::create):
      (WebCore::CStringBuffer::CStringBuffer):
      
      WebKit/mac: 
      
      Adopt the new WebCore::CredentialStorage in WebKit/Mac.
      
      * Misc/WebDownload.mm:
      (-[WebDownloadInternal download:didReceiveAuthenticationChallenge:]):
      * Plugins/WebBaseNetscapePluginView.mm:
      (WebKit::getAuthenticationInfo):
      
      WebKit/win: 
      
      Adopt the new WebCore::CredentialStorage in WebKit/Win.
      
      * WebDownloadCFNet.cpp:
      (WebDownload::didReceiveAuthenticationChallenge):
      
      WebKitTools: 
      
      Add the ability for DRT to handle authentication challenges.
      
      * DumpRenderTree/LayoutTestController.cpp:
      (setAuthenticationPasswordCallback):
      (setAuthenticationUsernameCallback):
      (setHandlesAuthenticationChallengesCallback):
      (LayoutTestController::staticFunctions):
      
      * DumpRenderTree/LayoutTestController.h:
      (LayoutTestController::handlesAuthenticationChallenges):
      (LayoutTestController::setHandlesAuthenticationChallenges):
      (LayoutTestController::authenticationUsername):
      (LayoutTestController::setAuthenticationUsername):
      (LayoutTestController::authenticationPassword):
      (LayoutTestController::setAuthenticationPassword):
      
      * DumpRenderTree/mac/ResourceLoadDelegate.mm:
      (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
      
      * DumpRenderTree/win/ResourceLoadDelegate.cpp:
      (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
      * DumpRenderTree/win/ResourceLoadDelegate.h:
      
      LayoutTests: 
      
      * http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
      * http/tests/loading/basic-auth-resend-wrong-credentials.html: Added.
      * http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
      * http/tests/loading/basic-credentials-sent-automatically.html: Added.
      * http/tests/loading/resources/basic-auth-testing.php: Added.
      * http/tests/loading/resources/othersubresources: Added.
      * http/tests/loading/resources/othersubresources/protected-resource.php: Added.
      * http/tests/loading/resources/protected-resource.php: Added.
      * http/tests/loading/resources/subresources: Added.
      * http/tests/loading/resources/subresources/protected-resource.php: Added.
      * http/tests/loading/resources/test2: Added.
      * http/tests/loading/resources/test2/basic-auth-testing.php: Added.
      * http/tests/loading/resources/test2/protected-resource.php: Added.
      * platform/gtk/Skipped:
      * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29c8b21b
    • mrowe@apple.com's avatar
      Fix <rdar://problem/6954546> Crashes in WebCore::RenderPart::setWidget below... · 9e727ac3
      mrowe@apple.com authored
      Fix <rdar://problem/6954546> Crashes in WebCore::RenderPart::setWidget below FrameLoader::loadPlugin.
      
      Reviewed by Dan Bernstein.
      
      The calls to FrameLoader::requestObject within RenderPartObject::updateWidget can result in a plug-in
      being initialized.  This can run cause arbitrary JavaScript to run and may result in the RenderPartObject
      being detached from the render tree and destroyed, causing a crash like <rdar://problem/6954546>.
      
      No test is possible until <rdar://problem/7090444> is fixed
      
      * rendering/RenderPartObject.cpp:
      (WebCore::RenderPartObject::updateWidget): Ensure that we stay alive for the duration of plug-in initialization.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e727ac3
    • mrowe@apple.com's avatar
      Add RenderWidgetProtector to simplify protecting a RenderWidget from... · 95331ba2
      mrowe@apple.com authored
      Add RenderWidgetProtector to simplify protecting a RenderWidget from destruction for the duration of a function.  Deploy it within RenderWidget.
      
      Reviewed by Dan Bernstein.
      
      * rendering/RenderWidget.cpp:
      (WebCore::RenderWidget::setWidgetGeometry):
      (WebCore::RenderWidget::updateWidgetPosition): Use a RefPtr rather than explicitly
      ref'ing and deref'ing the node.
      * rendering/RenderWidget.h:
      * rendering/RenderWidgetProtector.h:
      (WebCore::RenderWidgetProtector::RenderWidgetProtector):
      (WebCore::RenderWidgetProtector::~RenderWidgetProtector):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95331ba2
    • eric@webkit.org's avatar
      2009-09-14 Cameron McCormack <cam@mcc.id.au> · 66eac7f8
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              CodeGenerator.pm needs some cleaning up
              https://bugs.webkit.org/show_bug.cgi?id=29238
      
              * bindings/scripts/CodeGenerator.pm:
              (FindParentsRecursively): Removed; its functionality is now handled in
              AddMethodsConstantsAndAttributesFromParentClasses.
              (ForAllParents): New function that visits an interface's ancestors and
              invokes a callback for each one.
              (AddMethodsConstantsAndAttributesFromParentClasses): Simplified by using
              ForAllParents.
              (GetMethodsAndAttributesFromParentClasses): Ditto.
              (IDLFileForInterface): Factored out previous calls to ScanDirectory into
              this new function, which returns the filename containing a given IDL
              interface definition.
              (ParseInterface): Simplified by using IDLFileForInterface.
              (ScanDirectory): Removed in lieu of IDLFileForInterface.
              * bindings/scripts/CodeGeneratorV8.pm: Drop call to
              FindParentsRecursively and get the list of parents from the
              AddMethodsConstantsAndAttributesFromParentClasses call instead.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66eac7f8
    • yael.aharon@nokia.com's avatar
      [Qt] Assert hit when dropping a file in QtLauncher · 8b922832
      yael.aharon@nokia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29242
      
      Patch by Yael Aharon <yael.aharon@nokia.com> on 2009-09-14
      Reviewed by Tor Arne Vestbø.
      
      Qt's implementation of DropData::asURL does not return a URL encoded string
      as expected.
      
      * platform/qt/DragDataQt.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b922832
  3. 13 Sep, 2009 4 commits
  4. 12 Sep, 2009 3 commits
    • oliver@apple.com's avatar
      [ES5] Implement Object.keys · d1f19755
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=29170
      
      Reviewed by Maciej Stachowiak.
      
      This patch basically requires two separate steps, the first is to split getPropertyNames
      into two functions -- getOwnPropertyNames and getPropertyNames, basically making them behave
      in the same way as getOwnPropertySlot and getPropertySlot.  In essence getOwnPropertyNames
      produces the list of properties on an object excluding its prototype chain and getPropertyNames
      just iterates the the object and its prototype chain calling getOwnPropertyNames at each level.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d1f19755
    • weinig@apple.com's avatar
      WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29219 · d2427961
      weinig@apple.com authored
      Document.elementFromPoint() should take page scroll into consideration
      
      Reviewed by Anders Carlsson.
      
      Test: fast/dom/elementFromPoint-relative-to-viewport.html
      
      * dom/Document.cpp:
      (WebCore::Document::elementFromPoint):
      (WebCore::Document::caretRangeFromPoint):
      
      LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29219
      Document.elementFromPoint() should take page scroll into consideration
      
      Reviewed by Anders Carlsson.
      
      * fast/dom/elementFromPoint-relative-to-viewport-expected.txt: Added.
      * fast/dom/elementFromPoint-relative-to-viewport.html: Added.
      * fast/events/offsetX-offsetY.html: Change to use clientX/Y instead of pageX/Y.
      * fast/forms/slider-transformed.html: Ditto.
      * fast/forms/slider-zoomed.html: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d2427961
    • weinig@apple.com's avatar
      WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=29217 · 4ff6c71c
      weinig@apple.com authored
      Document.caretRangeFromPoint should take the scroll offset into account before hit testing
      
      Reviewed by Maciej Stachowiak.
      
      In accordance with the CSSOM View Module spec, Document.caretRangeFromPoint should interpret
      the point passed to it as relative to the viewport, not the document.
      
      Test: fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html
      
      * dom/Document.cpp:
      (WebCore::Document::caretRangeFromPoint):
      
      LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=29217
      Document.caretRangeFromPoint should take the scroll offset into account before hit testing
      
      Reviewed by Maciej Stachowiak.
      
      * fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
      * fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@48333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ff6c71c
  5. 11 Sep, 2009 10 commits