1. 24 Jan, 2013 40 commits
    • arv@chromium.org's avatar
      Unreviewed, rolling out r140703. · bc879c42
      arv@chromium.org authored
      http://trac.webkit.org/changeset/140703
      https://bugs.webkit.org/show_bug.cgi?id=107556
      
      r140561 was not the reason for the Android breakage
      
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::~TestShell):
      (TestShell::closeWindow):
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::WebViewHost):
      (WebViewHost::~WebViewHost):
      (WebViewHost::shutdown):
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc879c42
    • jamesr@google.com's avatar
      [chromium] Null check WebLayerTreeView before dereffing in WebViewImpl::invalidateRect · d0e91083
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107855
      
      Reviewed by Adrienne Walker.
      
      During frame shutdown, WebViewImpl::m_layerTreeView may become 0 while commits are deferred but we still
      may get invalidateRect() calls before shutdown completes.
      
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::invalidateRect):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0e91083
    • adamk@chromium.org's avatar
      Layout Test fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html is flaky · 0874c202
      adamk@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106612
      
      Reviewed by Eric Seidel.
      
      * fast/dom/HTMLTemplateElement/ownerDocument-adoptNode.html: Wait for
      the iframe's onload event before running the test.
      * platform/chromium/TestExpectations: Remove flaky expectation.
      * platform/efl/TestExpectations: ditto
      * platform/gtk/TestExpectations: ditto
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0874c202
    • jer.noble@apple.com's avatar
      Unreviewed build fix for Mac/Lion. · 35e31aa7
      jer.noble@apple.com authored
      Protect Lion from the absence of VideoToolbox.h by wrapping in #if
      guards.
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35e31aa7
    • dino@apple.com's avatar
      Allow some plugin snapshot UI content to come from Injected Bundle · d7693eac
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107852
      
      Reviewed by Anders Carlsson.
      
      Source/WebKit2:
      
      Hook up three new methods: plugInStartLabelTitle, plugInStartLabelSubtitle and
      plugInExtraStyleSheet to allow some custom styling and content to come
      from the InjectedBundle.
      
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h: Callbacks added to
      WKBundlePageUIClient structure.
      * WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Stub implementations
      of the three new methods.
      (WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle):
      (WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle):
      (WebKit::InjectedBundlePageUIClient::plugInExtraStyleSheet):
      * WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
      (InjectedBundlePageUIClient):
      * WebProcess/WebCoreSupport/WebChromeClient.cpp: Call into the injected bundle
      for each of these methods.
      (WebKit::WebChromeClient::plugInStartLabelTitle):
      (WebKit::WebChromeClient::plugInStartLabelSubtitle):
      (WebKit::WebChromeClient::plugInExtraStyleSheet):
      * WebProcess/WebCoreSupport/WebChromeClient.h:
      (WebChromeClient): Declare the virtual methods in the Chrome
      Client so that they can accessed from WebCore eventually.
      
      Tools:
      
      Null implementations of plugInStartLabelTitle, plugInStartLabelSubtitle and
      plugInExtraStyleSheet.
      
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::InjectedBundlePage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7693eac
    • andersca@apple.com's avatar
      Add stubbed out StorageNamespaceProxy class · a042db73
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107846
      
      Reviewed by Sam Weinig.
      
      Source/WebCore:
      
      Make StorageNamespace.h and StorageArea.h private headers.
      
      * WebCore.xcodeproj/project.pbxproj:
      
      Source/WebKit2:
      
      Add new class.
      
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/Storage/StorageNamespaceProxy.cpp: Added.
      * WebProcess/Storage/StorageNamespaceProxy.h: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a042db73
    • andersca@apple.com's avatar
      Move WebKeyValueStorageManager to WebProcess/Storage. · 92b5048f
      andersca@apple.com authored
      Rubber-stamped by Sam Weinig.
      
      Try this again, with DerivedSources.make correctly updated this time.
      
      * DerivedSources.make:
      * WebKit2.xcodeproj/project.pbxproj:
      * WebProcess/Storage/WebKeyValueStorageManager.cpp: Renamed from Source/WebKit2/WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp.
      * WebProcess/Storage/WebKeyValueStorageManager.h: Renamed from Source/WebKit2/WebProcess/KeyValueStorage/WebKeyValueStorageManager.h.
      * WebProcess/Storage/WebKeyValueStorageManager.messages.in: Renamed from Source/WebKit2/WebProcess/KeyValueStorage/WebKeyValueStorageManager.messages.in.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92b5048f
    • tony@chromium.org's avatar
      Remove document as a parameter from a few internals methods · d3da52f8
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107757
      
      Reviewed by Hajime Morita.
      
      Remove document as a parameter since there's already one associated with internals.
      
      Source/WebCore:
      
      No new tests, this refactors some testing code and is covered by
      exisiting tests.
      
      * testing/Internals.cpp:
      (WebCore::Internals::isPreloaded):
      (WebCore::Internals::createContentElement):
      (WebCore::Internals::absoluteCaretBounds):
      * testing/Internals.h:
      (Internals):
      * testing/Internals.idl:
      
      LayoutTests:
      
      * editing/input/editable-container-with-word-wrap-normal.html:
      * editing/selection/caret-alignment-for-vertical-text.html:
      * editing/selection/caret-at-end-of-text-line-followed-by-block-in-vertical-mode.html:
      * editing/selection/caret-in-div-containing-br-in-vertical-mode.html:
      * editing/selection/caret-in-empty-inline-1.html:
      * editing/selection/caret-in-empty-inline-2.html:
      * editing/selection/internal-caret-rect.html:
      * fast/dom/resources/shadow-test-driver.js:
      (createContentWithSelect):
      (createContentWithText):
      (appendShadow):
      (appendShadowDeep):
      * fast/dom/shadow/content-element-includer.html:
      * fast/dom/shadow/content-element-renderers.html:
      * fast/dom/shadow/content-selector-query.html:
      * fast/dom/shadow/create-content-element.html:
      * fast/dom/shadow/shadow-contents-fallback-dynamic.html:
      * fast/dom/shadow/shadow-contents-fallback.html:
      * fast/dom/shadow/shadow-contents-select.html:
      * fast/preloader/scan-body-from-head-import.html:
      * http/tests/loading/preload-append-scan.php:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d3da52f8
    • mkwst@chromium.org's avatar
      Web Inspector: 'console.debug' should generate messages at DebugMessageLevel. · 819c0246
      mkwst@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107816
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      'console.debug' is currently aliased to 'console.log'. Since we now
      render debug-level messages differently to log messages, we should use
      the proper message level for 'console.debug'.
      
      * page/Console.cpp:
      (WebCore::Console::debug):
          Replace the alias to 'console.log' with message creation at
          DebugMessageLevel.
      
      LayoutTests:
      
      * inspector/console/console-tests-expected.txt:
      * inspector/extensions/extensions-console-expected.txt:
          Rebaseline this test with the updated message level.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      819c0246
    • nghanavatian@rim.com's avatar
      [BlackBerry] Fix crash in SpellingHandler · 8c5332d2
      nghanavatian@rim.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107842
      
      Reviewed by Rob Buis.
      
      If we have an empty range or one with all spaces, we can simply return 0 instead of
      still creating a range. Putting in a null check after trimming to catch this case
      which was causing the crash in some DRT tests.
      
      Internally reviewed by Mike Fenton.
      
      * WebKitSupport/DOMSupport.cpp:
      (BlackBerry::WebKit::DOMSupport::trimWhitespaceFromRange):
      * WebKitSupport/SpellingHandler.cpp:
      (BlackBerry::WebKit::SpellingHandler::createSpellCheckRequest):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c5332d2
    • commit-queue@webkit.org's avatar
      Implement :past pseudo class for the WebVTT ::cue pseudo element · f972cbb4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=105482
      
      Patch by Dima Gorbik <dgorbik@apple.com> on 2013-01-24
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      It is good to have a designated pseudo class for this, though same could
      be achieved by using a combination of ::cue and ::cue(:future).
      Tests also check that nested timestamps work properly.
      
      Test: media/track/track-css-matching-timestamps.html
      
      * css/CSSSelector.cpp:
      (WebCore::CSSSelector::pseudoId):
      (WebCore::nameToPseudoTypeMap):
      (WebCore::CSSSelector::extractPseudoType):
      * css/CSSSelector.h:
      * css/SelectorChecker.cpp:
      (WebCore::SelectorChecker::checkOne):
      
      LayoutTests:
      
      * media/track/captions-webvtt/styling-timestamps.vtt: Added.
      * media/track/track-css-matching-timestamps-expected.txt: Added.
      * media/track/track-css-matching-timestamps.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f972cbb4
    • jer.noble@apple.com's avatar
      Mac: Avoid using k32BGRAPixelFormat on certain platforms. · 09ea6ed0
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107732
      
      Reviewed by Eric Carlson.
      
      Using a AVPlayerItemVideoOutput to generate ARGB pixel buffers is a potential performance
      hit, as the AVPlayerItemVideoOutput will send YUV buffers through a VTPixeBufferTransferSession
      to convert them to ARGB regardless of whether or not a given buffer will be used. Instead,
      ask the AVPlayerItemVideoOutput for pixel buffers in the decoder's native pixel format and use
      the VTPixelBufferTransferSession to convert to ARGB only those pixel buffers which were actually
      requested.
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput): Ask for the decoder's native
          pixel format.
      (WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer): Lazily create a VTPixelTransferSession
          and convert output pixel buffers to k32BGRAPixelFormat.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09ea6ed0
    • commit-queue@webkit.org's avatar
      Convert RenderFullScreen to use the non-deprecated flexbox · 3a9a1fa8
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107746
      
      Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-01-24
      Reviewed by Ojan Vafai.
      
      Tests: covered by existing tests in fullscreen/.
      
      * rendering/RenderFullScreen.h:
      * rendering/RenderFullScreen.cpp:
      (RenderFullScreen::RenderFullScreen):
      (RenderFullScreen::willBeDestroyed):
      Inherit from RenderFlexibleBox
      
      (createFullScreenStyle):
      Use the new-style CSS properties (justify-content, etc)
      
      * css/fullscreen.css:
      (video:-webkit-full-screen, audio:-webkit-full-screen):
      * css/fullscreenQuickTime.css:
      (video:-webkit-full-screen::-webkit-media-controls-panel):
      (video:-webkit-full-screen::-webkit-media-controls-seek-back-button):
      (video:-webkit-full-screen::-webkit-media-controls-return-to-realtime-button):
      (video:-webkit-full-screen::-webkit-media-controls-seek-forward-button):
      * css/mediaControlsBlackBerryFullscreen.css:
      (video:-webkit-full-screen::-webkit-media-controls-panel):
      (video:-webkit-full-screen::-webkit-media-controls-button-group-container):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-display-container):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-play-button):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-timeline-container):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-current-time-display):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-remaining-display):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-timeline):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-fullscreen-button):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-button-divider):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-button-container, video:-webkit-full-screen::-webkit-media-controls-play-button-container):
      (video:-webkit-full-screen::-webkit-media-controls-fullscreen-button-container):
      (video:-webkit-full-screen::-webkit-media-controls-play-button-container):
      (video:-webkit-full-screen::-webkit-media-controls-placeholder):
      * css/mediaControlsQtFullscreen.css:
      (video::-webkit-media-controls-panel):
      (video::-webkit-media-controls-play-button):
      Update fullscreen-related CSS to use the new flexbox
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a9a1fa8
    • jer.noble@apple.com's avatar
      Mac: Video appears in wrong place during pinch operations · 1dc0d10b
      jer.noble@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107730
      
      Reviewed by Eric Carlson.
      
      Send the correct input and output rects, post translation and scaling,
      to the CIContext for drawing.
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1dc0d10b
    • arv@chromium.org's avatar
      Unreviewed, rolling out r140561. · 864dfd0a
      arv@chromium.org authored
      http://trac.webkit.org/changeset/140561
      https://bugs.webkit.org/show_bug.cgi?id=107556
      
      Suspected to break Android which prevens WebKit roll
      
      * DumpRenderTree/chromium/TestShell.cpp:
      (TestShell::~TestShell):
      (TestShell::closeWindow):
      * DumpRenderTree/chromium/WebViewHost.cpp:
      (WebViewHost::WebViewHost):
      (WebViewHost::~WebViewHost):
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      864dfd0a
    • mvujovic@adobe.com's avatar
      [CSS Filters] CSS opacity property clips filter outsets · 07d7fc6a
      mvujovic@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106549
      
      Reviewed by Dirk Schulze.
      
      Source/WebCore:
      
      Expand the transparencyClipBox for filter outsets and pass the filter output rect instead of
      the input rect to beginTransparencyLayers for clipping. Details below.
      
      Test: css3/filters/css-opacity-with-drop-shadow.html
      
      * rendering/RenderLayer.cpp:
      (WebCore):
      (WebCore::RenderLayer::setFilterBackendNeedsRepaintingInRect):
          Replace filter outset calcuation with a call to expandRectForFilterOutsets.
      (WebCore::expandRectForFilterOutsets):
          New method to factor out repeated filter outset calculation code.
      (WebCore::transparencyClipBox):
          After expanding the clip rect for descendants and reflection, expand it for filter
          outsets, so they don't get clipped when we begin a transparency layer.
      (WebCore::RenderLayer::paintLayerContents):
          Pass paintingInfo.paintDirtyRect instead of localPaintingInfo.paintDirtyRect to
          beginTransparencyLayers for clipping. localPaintingInfo.paintDirtyRect (aka the filter
          input rect) does not contain filter outsets, so they would get clipped. Now, we pass
          paintingInfo.paintDirtyRect (the filter output rect), which includes the filter outsets.
      (WebCore::RenderLayer::calculateLayerBounds):
          Replace filter outset calcuation with a call to expandRectForFilterOutsets.
      * rendering/RenderLayer.h:
      (RenderLayer):
      
      LayoutTests:
      
      Add a reftest to verify that an element's drop shadow filter is not clipped when a CSS
      opacity property is not applied.
      
      * css3/filters/css-opacity-with-drop-shadow-expected.html: Added.
      * css3/filters/css-opacity-with-drop-shadow.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07d7fc6a
    • christophe.dumez@intel.com's avatar
      Unreviewed EFL rebaseline. · f0e3c45f
      christophe.dumez@intel.com authored
      Rebaseline several tests on EFL port after r140693.
      
      * platform/efl-wk1/svg/batik/text/xmlSpace-expected.png:
      * platform/efl/TestExpectations:
      * platform/efl/css2.1/t0505-c16-descendant-01-e-expected.png:
      * platform/efl/css2.1/t0505-c16-descendant-01-e-expected.txt:
      * platform/efl/editing/selection/extend-by-sentence-001-expected.png:
      * platform/efl/editing/selection/extend-by-sentence-001-expected.txt:
      * platform/efl/fast/inline/drawStyledEmptyInlines-expected.png:
      * platform/efl/fast/inline/drawStyledEmptyInlines-expected.txt:
      * platform/efl/fast/inline/drawStyledEmptyInlinesWithWS-expected.png:
      * platform/efl/fast/inline/drawStyledEmptyInlinesWithWS-expected.txt:
      * platform/efl/fast/text/capitalize-empty-generated-string-expected.png:
      * platform/efl/fast/text/capitalize-empty-generated-string-expected.txt:
      * platform/efl/fast/text/whitespace/006-expected.png:
      * platform/efl/fast/text/whitespace/006-expected.txt:
      * platform/efl/fast/text/whitespace/007-expected.png:
      * platform/efl/fast/text/whitespace/007-expected.txt:
      * platform/efl/svg/batik/text/xmlSpace-expected.png:
      * platform/efl/svg/batik/text/xmlSpace-expected.txt:
      * platform/efl/svg/carto.net/combobox-expected.png:
      * platform/efl/svg/carto.net/combobox-expected.txt:
      * platform/efl/tables/mozilla/bugs/bug113235-3-expected.png:
      * platform/efl/tables/mozilla/bugs/bug113235-3-expected.txt:
      * platform/efl/tables/mozilla/bugs/bug1188-expected.png:
      * platform/efl/tables/mozilla/bugs/bug1188-expected.txt:
      * platform/efl/tables/mozilla/bugs/bug1318-expected.png:
      * platform/efl/tables/mozilla/bugs/bug1318-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0e3c45f
    • rniwa@webkit.org's avatar
      Fix a typo after r139838. · 02bbc305
      rniwa@webkit.org authored
      * dom/NodeRareData.h:
      (NodeRareData):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02bbc305
    • lforschler@apple.com's avatar
      Versioning. · e7d4f9d4
      lforschler@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7d4f9d4
    • rniwa@webkit.org's avatar
      Abandoned Memory: SVGFontElement and Corresponding SVGDocument Never Deconstructed · 00bac936
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=66438
      
      Reviewed by Dirk Schulze.
      
      The memory leak was caused by SVGFontFaceElement storing its own parent in a RefPtr.
      
      Fixed the bug by storing a raw pointer instead, and clearing the pointer in removedFrom
      when the node detached from the document. Also added several sanity check assertions.
      
      * svg/SVGFontFaceElement.cpp:
      (WebCore::SVGFontFaceElement::SVGFontFaceElement):
      (WebCore::SVGFontFaceElement::associatedFontElement):
      (WebCore::SVGFontFaceElement::rebuildFontFace):
      (WebCore::SVGFontFaceElement::insertedInto):
      (WebCore::SVGFontFaceElement::removedFrom):
      * svg/SVGFontFaceElement.h:
      (SVGFontFaceElement):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00bac936
    • bfulgham@webkit.org's avatar
      Stipulate build order between WTFGenerated and WTF · 6c344a0a
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107844
      
      Reviewed by Tim Horton.
      
      * WTF.vcxproj/WTF.vcxproj: Use VS2010 project dependency
      declaration so WTF depends on a completed WTFGenerated build.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c344a0a
    • bfulgham@webkit.org's avatar
      Get WTF compiling in VS2010 (32bit) · 4cc70683
      bfulgham@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=106986
      
      Reviewed by Tim Horton.
      
      If you do not have Cygwin in the overall operating system
      PATH, the project will not build.  In VS2005 we had logic
      in the build system to guard against this.  We should
      retain this in the VS2010 work.
      
      Furthermore, VS2010 has a nasty bug where to Visual Studio
      tools path is not defined when performing a 'clean' phase
      on an NMAKE-based build.  This is corrected here as well.
      
      * win/tools/vsprops/common.props: Revise environment setup
      to ensure proper tools are in path during build.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cc70683
    • robert@webkit.org's avatar
      Inline Containing Only Collapsed Whitespace Not Getting a Linebox · 2b307a73
      robert@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=31397
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      Treat inlines containing only collapsed whitespace as empty. This allows them
      to get a linebox.
      
      Test: fast/inline/inline-containing-collapsed-whitespace-treated-as-empty.html
      
      * dom/Position.cpp:
      (WebCore::boundingBoxLogicalHeight):
      (WebCore):
      (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
      * rendering/InlineIterator.h:
      (WebCore::isEmptyInline):
      (WebCore):
      (WebCore::bidiNextShared):
      (WebCore::bidiFirstSkippingEmptyInlines):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::alwaysRequiresLineBox):
      (WebCore::requiresLineBox):
      (WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
      * rendering/RenderText.cpp:
      * rendering/RenderText.h:
      (RenderText):
      
      LayoutTests:
      
      * fast/css/first-letter-capitalized-edit-select-crash-expected.txt:
      * fast/inline/inline-containing-collapsed-whitespace-treated-as-empty-expected.html: Added.
      * fast/inline/inline-containing-collapsed-whitespace-treated-as-empty-vertical-rl-expected.html: Added.
      * fast/inline/inline-containing-collapsed-whitespace-treated-as-empty-vertical-rl.html: Added.
      * fast/inline/inline-containing-collapsed-whitespace-treated-as-empty.html: Added.
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140693 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b307a73
    • christophe.dumez@intel.com's avatar
      [EFL][WK2] Use C API inside ewk_favicon_database · 7d7c2c77
      christophe.dumez@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107680
      
      Reviewed by Kenneth Rohde Christiansen.
      
      Use C API inside ewk_favicon_database instead of
      accessible the C++ classes and violating layering.
      We still rely on some C++ methods but this will be
      addressed later since there is no equivalent in
      the C API and it will require more refactoring.
      
      * UIProcess/API/efl/ewk_context.cpp:
      (EwkContext::ensureFaviconDatabase):
      * UIProcess/API/efl/ewk_favicon_database.cpp:
      (EwkFaviconDatabase::EwkFaviconDatabase):
      (EwkFaviconDatabase::~EwkFaviconDatabase):
      (EwkFaviconDatabase::iconURLForPageURL):
      (EwkFaviconDatabase::iconForPageURL):
      (EwkFaviconDatabase::getIconSurfaceSynchronously):
      (EwkFaviconDatabase::iconDataReadyForPageURL):
      (ewk_favicon_database_async_icon_get):
      * UIProcess/API/efl/ewk_favicon_database_private.h:
      (EwkFaviconDatabase::create):
      (EwkFaviconDatabase):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140692 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d7c2c77
    • commit-queue@webkit.org's avatar
      Web Inspector: expand more chunks in DTE · c0d2b7ab
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107698
      
      Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-24
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      Mock DefaultTextEditor visible area as if it is slightly larger than real one and
      do all chunk expandings and repaints based on this new area.
      
      No new tests: no change in behaviour.
      
      * inspector/front-end/DefaultTextEditor.js:
      (WebInspector.TextEditorChunkedPanel.prototype.findVisibleChunks):
      
      LayoutTests:
      
      Correct text expectation as we change amount of expanded chunks.
      
      * inspector/editor/text-editor-selection-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140691 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c0d2b7ab
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Added platform specific expectation after r140174. · 4b0d8a23
      kadam@inf.u-szeged.hu authored
      https://bugs.webkit.org/show_bug.cgi?id=107434.
      
      * platform/qt/TestExpectations:
      * platform/qt/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Added after r140174.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140689 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b0d8a23
    • kadam@inf.u-szeged.hu's avatar
      [Qt][WK2] Unreviewed gardening. Skip a failing HTML ref test after r140229. · 9509d291
      kadam@inf.u-szeged.hu authored
      https://bugs.webkit.org/show_bug.cgi?id=105390.
      
      * platform/qt-5.0-wk2/TestExpectations:
      * platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt: Added after r140593.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140688 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9509d291
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 8b068d1b
      zandobersek@gmail.com authored
      Adding failure expectations for accessibility tests that regressed with r140658.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b068d1b
    • mikhail.pozdnyakov@intel.com's avatar
      [EFL][WK2] Rename EwkViewImpl class to EwkView · 8f624d84
      mikhail.pozdnyakov@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107719
      
      Reviewed by Andreas Kling.
      
      Rename EwkViewImpl class to EwkView, due to ewk view
      refactoring plan (https://bugs.webkit.org/show_bug.cgi?id=107662#c1).
      
      * PlatformEfl.cmake:
      * UIProcess/API/C/efl/WKView.cpp:
      (WKViewCreate):
      (WKViewCreateWithFixedLayout):
      (WKViewGetPage):
      (WKViewCreateSnapshot):
      * UIProcess/API/efl/EwkView.cpp: Renamed from Source/WebKit2/UIProcess/API/efl/EwkViewImpl.cpp.
      (pageViewMap):
      (EwkView::addToPageViewMap):
      (EwkView::removeFromPageViewMap):
      (EwkView::viewFromPageViewMap):
      (EwkView::EwkView):
      (EwkView::~EwkView):
      (EwkView::smartData):
      (EwkView::fromEvasObject):
      (EwkView::wkPage):
      (EwkView::setCursor):
      (EwkView::setDeviceScaleFactor):
      (EwkView::deviceScaleFactor):
      (EwkView::transformFromScene):
      (EwkView::transformToScene):
      (EwkView::transformToScreen):
      (EwkView::layerTreeRenderer):
      (EwkView::displayTimerFired):
      (EwkView::update):
      (EwkView::enterFullScreen):
      (EwkView::exitFullScreen):
      (EwkView::windowGeometry):
      (EwkView::setWindowGeometry):
      (EwkView::setImageData):
      (EwkView::size):
      (EwkView::isFocused):
      (EwkView::isVisible):
      (EwkView::title):
      (EwkView::inputMethodContext):
      (EwkView::themePath):
      (EwkView::setThemePath):
      (EwkView::customTextEncodingName):
      (EwkView::setCustomTextEncodingName):
      (EwkView::setMouseEventsEnabled):
      (EwkView::setTouchEventsEnabled):
      (EwkView::informIconChange):
      (EwkView::createGLSurface):
      (EwkView::enterAcceleratedCompositingMode):
      (EwkView::exitAcceleratedCompositingMode):
      (EwkView::requestColorPicker):
      (EwkView::dismissColorPicker):
      (EwkView::showContextMenu):
      (EwkView::hideContextMenu):
      (EwkView::requestPopupMenu):
      (EwkView::closePopupMenu):
      (EwkView::requestJSAlertPopup):
      (EwkView::requestJSConfirmPopup):
      (EwkView::requestJSPromptPopup):
      (EwkView::informDatabaseQuotaReached):
      (EwkView::informURLChange):
      (EwkView::windowFeatures):
      (EwkView::createNewPage):
      (EwkView::close):
      (EwkView::onMouseDown):
      (EwkView::onMouseUp):
      (EwkView::onMouseMove):
      (EwkView::feedTouchEvents):
      (EwkView::onTouchDown):
      (EwkView::onTouchUp):
      (EwkView::onTouchMove):
      (EwkView::onFaviconChanged):
      (EwkView::takeSnapshot):
      * UIProcess/API/efl/EwkView.h: Renamed from Source/WebKit2/UIProcess/API/efl/EwkViewImpl.h.
      (WebKit):
      (WebCore):
      (EwkView):
      (EwkView::view):
      (EwkView::page):
      (EwkView::ewkContext):
      (EwkView::settings):
      (EwkView::backForwardList):
      (EwkView::url):
      (EwkView::faviconURL):
      (EwkView::mouseEventsEnabled):
      (EwkView::touchEventsEnabled):
      (EwkView::setNeedsSurfaceResize):
      (EwkView::smartCallback):
      (EwkView::pageClient):
      (EwkView::setPageScaleFactor):
      (EwkView::pageScaleFactor):
      (EwkView::setPagePosition):
      (EwkView::pagePosition):
      (EwkView::isHardwareAccelerated):
      (EwkView::setDrawsBackground):
      (EwkView::evasGLContext):
      (EwkView::evasGLSurface):
      * UIProcess/API/efl/ewk_context_menu.cpp:
      (EwkContextMenu::EwkContextMenu):
      * UIProcess/API/efl/ewk_context_menu_private.h:
      (EwkContextMenu::create):
      (EwkContextMenu):
      * UIProcess/API/efl/ewk_download_job.cpp:
      (EwkDownloadJob::EwkDownloadJob):
      (EwkDownloadJob::view):
      * UIProcess/API/efl/ewk_download_job_private.h:
      (EwkDownloadJob::create):
      (EwkDownloadJob):
      * UIProcess/API/efl/ewk_popup_menu.cpp:
      (EwkPopupMenu::EwkPopupMenu):
      (EwkPopupMenu::close):
      * UIProcess/API/efl/ewk_popup_menu_private.h:
      (EwkPopupMenu::create):
      (EwkPopupMenu):
      * UIProcess/API/efl/ewk_settings.cpp:
      (EwkSettings::preferences):
      * UIProcess/API/efl/ewk_settings_private.h:
      (EwkSettings::create):
      (EwkSettings::EwkSettings):
      (EwkSettings):
      * UIProcess/API/efl/ewk_view.cpp:
      (createEwkView):
      (ewk_view_base_add):
      * UIProcess/API/efl/ewk_view.h:
      * UIProcess/API/efl/ewk_view_private.h:
      * UIProcess/API/efl/ewk_window_features.cpp:
      (EwkWindowFeatures::EwkWindowFeatures):
      (EwkWindowFeatures::setToolbarVisible):
      (EwkWindowFeatures::setStatusBarVisible):
      (EwkWindowFeatures::setMenuBarVisible):
      (EwkWindowFeatures::setResizable):
      * UIProcess/API/efl/ewk_window_features_private.h:
      (EwkWindowFeatures::create):
      (EwkWindowFeatures):
      * UIProcess/cairo/BackingStoreCairo.cpp:
      (WebKit::BackingStore::incorporateUpdate):
      * UIProcess/efl/ContextHistoryClientEfl.cpp:
      (WebKit::ContextHistoryClientEfl::didNavigateWithNavigationData):
      (WebKit::ContextHistoryClientEfl::didPerformClientRedirect):
      (WebKit::ContextHistoryClientEfl::didPerformServerRedirect):
      (WebKit::ContextHistoryClientEfl::didUpdateHistoryTitle):
      * UIProcess/efl/ContextMenuClientEfl.cpp:
      (ContextMenuClientEfl::ContextMenuClientEfl):
      * UIProcess/efl/ContextMenuClientEfl.h:
      (WebKit::ContextMenuClientEfl::create):
      (ContextMenuClientEfl):
      * UIProcess/efl/DownloadManagerEfl.cpp:
      (WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
      (WebKit::DownloadManagerEfl::didFail):
      (WebKit::DownloadManagerEfl::didCancel):
      (WebKit::DownloadManagerEfl::didFinish):
      (WebKit::DownloadManagerEfl::registerDownload):
      * UIProcess/efl/DownloadManagerEfl.h:
      (DownloadManagerEfl):
      * UIProcess/efl/FindClientEfl.cpp:
      (WebKit::FindClientEfl::didFindString):
      (WebKit::FindClientEfl::didFailToFindString):
      (WebKit::FindClientEfl::FindClientEfl):
      * UIProcess/efl/FindClientEfl.h:
      (WebKit::FindClientEfl::create):
      (FindClientEfl):
      * UIProcess/efl/FormClientEfl.cpp:
      (WebKit::FormClientEfl::willSubmitForm):
      (WebKit::FormClientEfl::FormClientEfl):
      * UIProcess/efl/FormClientEfl.h:
      (WebKit::FormClientEfl::create):
      (FormClientEfl):
      * UIProcess/efl/InputMethodContextEfl.cpp:
      (WebKit::InputMethodContextEfl::InputMethodContextEfl):
      (WebKit::InputMethodContextEfl::onIMFInputSequenceComplete):
      (WebKit::InputMethodContextEfl::onIMFPreeditSequenceChanged):
      (WebKit::InputMethodContextEfl::updateTextInputState):
      * UIProcess/efl/InputMethodContextEfl.h:
      (WebKit::InputMethodContextEfl::create):
      (InputMethodContextEfl):
      * UIProcess/efl/PageClientBase.cpp:
      (WebKit::PageClientBase::PageClientBase):
      (WebKit::PageClientBase::view):
      (WebKit::PageClientBase::createDrawingAreaProxy):
      (WebKit::PageClientBase::setViewNeedsDisplay):
      (WebKit::PageClientBase::viewSize):
      (WebKit::PageClientBase::isViewFocused):
      (WebKit::PageClientBase::isViewVisible):
      (WebKit::PageClientBase::processDidCrash):
      (WebKit::PageClientBase::didRelaunchProcess):
      (WebKit::PageClientBase::toolTipChanged):
      (WebKit::PageClientBase::setCursor):
      (WebKit::PageClientBase::createPopupMenuProxy):
      (WebKit::PageClientBase::createContextMenuProxy):
      (WebKit::PageClientBase::enterAcceleratedCompositingMode):
      (WebKit::PageClientBase::exitAcceleratedCompositingMode):
      (WebKit::PageClientBase::updateTextInputState):
      (WebKit::PageClientBase::handleDownloadRequest):
      * UIProcess/efl/PageClientBase.h:
      (PageClientBase):
      * UIProcess/efl/PageClientDefaultImpl.cpp:
      (WebKit::PageClientDefaultImpl::PageClientDefaultImpl):
      (WebKit::PageClientDefaultImpl::updateViewportSize):
      (WebKit::PageClientDefaultImpl::convertToDeviceSpace):
      (WebKit::PageClientDefaultImpl::convertToUserSpace):
      (WebKit::PageClientDefaultImpl::didChangeContentsSize):
      * UIProcess/efl/PageClientDefaultImpl.h:
      (WebKit::PageClientDefaultImpl::create):
      (PageClientDefaultImpl):
      * UIProcess/efl/PageClientLegacyImpl.cpp:
      (WebKit::PageClientLegacyImpl::PageClientLegacyImpl):
      (WebKit::PageClientLegacyImpl::didCommitLoad):
      (WebKit::PageClientLegacyImpl::updateViewportSize):
      (WebKit::PageClientLegacyImpl::didChangeViewportProperties):
      (WebKit::PageClientLegacyImpl::didChangeContentsSize):
      (WebKit::PageClientLegacyImpl::pageDidRequestScroll):
      (WebKit::PageClientLegacyImpl::didRenderFrame):
      (WebKit::PageClientLegacyImpl::pageTransitionViewportReady):
      * UIProcess/efl/PageClientLegacyImpl.h:
      (WebKit::PageClientLegacyImpl::create):
      (PageClientLegacyImpl):
      * UIProcess/efl/PageLoadClientEfl.cpp:
      (WebKit::PageLoadClientEfl::didReceiveTitleForFrame):
      (WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
      (WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
      (WebKit::PageLoadClientEfl::didChangeProgress):
      (WebKit::PageLoadClientEfl::didFinishLoadForFrame):
      (WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
      (WebKit::PageLoadClientEfl::didStartProvisionalLoadForFrame):
      (WebKit::PageLoadClientEfl::didReceiveServerRedirectForProvisionalLoadForFrame):
      (WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):
      (WebKit::PageLoadClientEfl::didCommitLoadForFrame):
      (WebKit::PageLoadClientEfl::didChangeBackForwardList):
      (WebKit::PageLoadClientEfl::didSameDocumentNavigationForFrame):
      (WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):
      (WebKit::PageLoadClientEfl::PageLoadClientEfl):
      * UIProcess/efl/PageLoadClientEfl.h:
      (WebKit::PageLoadClientEfl::create):
      (PageLoadClientEfl):
      (WebKit::PageLoadClientEfl::view):
      * UIProcess/efl/PagePolicyClientEfl.cpp:
      (WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
      (WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):
      (WebKit::PagePolicyClientEfl::PagePolicyClientEfl):
      * UIProcess/efl/PagePolicyClientEfl.h:
      (WebKit::PagePolicyClientEfl::create):
      (PagePolicyClientEfl):
      * UIProcess/efl/PageUIClientEfl.cpp:
      (WebKit::PageUIClientEfl::PageUIClientEfl):
      (WebKit::PageUIClientEfl::close):
      (WebKit::PageUIClientEfl::takeFocus):
      (WebKit::PageUIClientEfl::focus):
      (WebKit::PageUIClientEfl::unfocus):
      (WebKit::PageUIClientEfl::runJavaScriptAlert):
      (WebKit::PageUIClientEfl::runJavaScriptConfirm):
      (WebKit::PageUIClientEfl::runJavaScriptPrompt):
      (WebKit::PageUIClientEfl::toolbarsAreVisible):
      (WebKit::PageUIClientEfl::setToolbarsAreVisible):
      (WebKit::PageUIClientEfl::menuBarIsVisible):
      (WebKit::PageUIClientEfl::setMenuBarIsVisible):
      (WebKit::PageUIClientEfl::statusBarIsVisible):
      (WebKit::PageUIClientEfl::setStatusBarIsVisible):
      (WebKit::PageUIClientEfl::isResizable):
      (WebKit::PageUIClientEfl::setIsResizable):
      (WebKit::PageUIClientEfl::getWindowFrame):
      (WebKit::PageUIClientEfl::setWindowFrame):
      (WebKit::PageUIClientEfl::exceededDatabaseQuota):
      (WebKit::PageUIClientEfl::runOpenPanel):
      (WebKit::PageUIClientEfl::createNewPage):
      (WebKit::PageUIClientEfl::showColorPicker):
      (WebKit::PageUIClientEfl::hideColorPicker):
      * UIProcess/efl/PageUIClientEfl.h:
      (WebKit::PageUIClientEfl::create):
      (PageUIClientEfl):
      * UIProcess/efl/PageViewportControllerClientEfl.cpp:
      (WebKit::PageViewportControllerClientEfl::PageViewportControllerClientEfl):
      (WebKit::PageViewportControllerClientEfl::drawingArea):
      (WebKit::PageViewportControllerClientEfl::updateViewportSize):
      (WebKit::PageViewportControllerClientEfl::didChangeContentsSize):
      (WebKit::PageViewportControllerClientEfl::setViewportPosition):
      (WebKit::PageViewportControllerClientEfl::setPageScaleFactor):
      (WebKit::PageViewportControllerClientEfl::didResumeContent):
      (WebKit::PageViewportControllerClientEfl::didChangeVisibleContents):
      * UIProcess/efl/PageViewportControllerClientEfl.h:
      (WebKit::PageViewportControllerClientEfl::create):
      (PageViewportControllerClientEfl):
      * UIProcess/efl/VibrationClientEfl.cpp:
      (VibrationClientEfl::vibrateCallback):
      (VibrationClientEfl::cancelVibrationCallback):
      (VibrationClientEfl::create):
      (VibrationClientEfl::VibrationClientEfl):
      (VibrationClientEfl::~VibrationClientEfl):
      * UIProcess/efl/VibrationClientEfl.h:
      (VibrationClientEfl):
      * UIProcess/efl/WebContextMenuProxyEfl.cpp:
      (WebKit::WebContextMenuProxyEfl::WebContextMenuProxyEfl):
      (WebKit::WebContextMenuProxyEfl::showContextMenu):
      (WebKit::WebContextMenuProxyEfl::hideContextMenu):
      * UIProcess/efl/WebContextMenuProxyEfl.h:
      (WebKit::WebContextMenuProxyEfl::create):
      (WebContextMenuProxyEfl):
      * UIProcess/efl/WebFullScreenManagerProxyEfl.cpp:
      (WebKit::WebFullScreenManagerProxy::enterFullScreen):
      (WebKit::WebFullScreenManagerProxy::exitFullScreen):
      * UIProcess/efl/WebInspectorProxyEfl.cpp:
      (WebKit::WebInspectorProxy::platformCreateInspectorPage):
      * UIProcess/efl/WebPageProxyEfl.cpp:
      (WebKit::WebPageProxy::viewWidget):
      * UIProcess/efl/WebPopupMenuProxyEfl.cpp:
      (WebKit::WebPopupMenuProxyEfl::WebPopupMenuProxyEfl):
      (WebKit::WebPopupMenuProxyEfl::showPopupMenu):
      (WebKit::WebPopupMenuProxyEfl::hidePopupMenu):
      * UIProcess/efl/WebPopupMenuProxyEfl.h:
      (WebKit::WebPopupMenuProxyEfl::create):
      (WebPopupMenuProxyEfl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140686 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f624d84
    • commit-queue@webkit.org's avatar
      [GStreamer] Implement setPreservesPitch() · f00f182c
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=31155
      
      Enables audio pitch preservation by using the scaletempo GStreamer
      element when required by the MediaPlayer.
      
      Patch by Victor Jaquez <vjaquez@igalia.com> on 2013-01-24
      Reviewed by Philippe Normand.
      
      No new tests, but a layout test shall be implemented at some point
      using WebAudio API.
      
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
      (WebCore::MediaPlayerPrivateGStreamer::setPreservesPitch):
      (WebCore):
      * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
      (MediaPlayerPrivateGStreamer):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f00f182c
    • abecsi@webkit.org's avatar
      Remove nonexistent header from WebKit2/Target.pri · 4e770652
      abecsi@webkit.org authored
      Unreviewed cleanup after r139919.
      
      * Target.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e770652
    • commit-queue@webkit.org's avatar
      Removing deleted files from WebCore/Target.pri after r140399. · 5f84f0f6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107815
      
      Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-01-24
      Reviewed by Csaba Osztrogonác.
      
      * Target.pri:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140683 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f84f0f6
    • commit-queue@webkit.org's avatar
      [BlackBerry] It can't Select texts in main frame when the current focus is in a IFrame · cf66a7ea
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107773
      
      Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-01-24
      Reviewed by Antonio Gomes.
      
      PR285211 Internally reviewed by Genevieve Mak
      
      When touch hold in the unfocused frame, it doesn't switch frame focus. Many
      places in code depends on the webpage->forcusOrMainFrame(), including the
      SelectionHandler, so it can't select in an unfocused frame. This patch switchs
      frame focus when touch starts.
      
      * WebKitSupport/TouchEventHandler.cpp:
      (BlackBerry::WebKit::TouchEventHandler::doFatFingers):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf66a7ea
    • mrobinson@webkit.org's avatar
      Try to fix the Qt Windows build · b137172a
      mrobinson@webkit.org authored
      * xml/parser/XMLDocumentParserQt.cpp:
      (WebCore::decodeNamedEntity): Use a reinterpret_cast to const QChar* like StringQt.cpp.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b137172a
    • aandrey@chromium.org's avatar
      Web Inspector: [Canvas] REGRESSION: stack traces in the replay log are gone · af9d57b5
      aandrey@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107805
      
      Reviewed by Pavel Feldman.
      
      Source/WebCore:
      
      The V8's Error.prepareStackTrace is now called from the Error.captureStackTrace
      function instead of the "stack" getter function.
      
      Test: inspector/profiler/canvas2d/canvas-stack-trace.html
      
      * inspector/InjectedScriptCanvasModuleSource.js:
      (.):
      
      LayoutTests:
      
      A simple test to dump a canvas 2D trace log with function call stack traces.
      
      * inspector/profiler/canvas-profiler-test.js:
      (initialize_CanvasWebGLProfilerTest.):
      (initialize_CanvasWebGLProfilerTest.InspectorTest.dumpTraceLog):
      * inspector/profiler/canvas2d/canvas-stack-trace-expected.txt: Added.
      * inspector/profiler/canvas2d/canvas-stack-trace.html: Added.
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      * platform/qt/TestExpectations:
      * platform/win/TestExpectations:
      * platform/wincairo/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af9d57b5
    • aandrey@chromium.org's avatar
      Web Inspector: [Canvas] UI: add a selector to capture a single canvas frame vs consecutive frames · 67df93b3
      aandrey@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=107688
      
      Reviewed by Pavel Feldman.
      
      Allow capturing several canvas frames in a row.
      
      * English.lproj/localizedStrings.js:
      * inspector/InjectedScriptCanvasModule.cpp:
      (WebCore::InjectedScriptCanvasModule::traceLog):
      * inspector/InjectedScriptCanvasModule.h:
      (InjectedScriptCanvasModule):
      * inspector/InjectedScriptCanvasModuleSource.js:
      (.):
      * inspector/Inspector.json:
      * inspector/InspectorCanvasAgent.cpp:
      (WebCore::InspectorCanvasAgent::getTraceLog):
      * inspector/InspectorCanvasAgent.h:
      (InspectorCanvasAgent):
      * inspector/front-end/CanvasProfileView.js:
      (WebInspector.CanvasProfileView):
      (WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
      (WebInspector.CanvasProfileView.prototype._requestTraceLog):
      (WebInspector.CanvasProfileType):
      (WebInspector.CanvasProfileType.prototype.get statusBarItems):
      (WebInspector.CanvasProfileType.prototype.get buttonTooltip):
      (WebInspector.CanvasProfileType.prototype.buttonClicked):
      (WebInspector.CanvasProfileType.prototype._runSingleFrameCapturing):
      (WebInspector.CanvasProfileType.prototype._startFrameCapturing):
      (WebInspector.CanvasProfileType.prototype._stopFrameCapturing.didStopCapturing):
      (WebInspector.CanvasProfileType.prototype._stopFrameCapturing):
      (WebInspector.CanvasProfileType.prototype._didStartCapturingFrame):
      (WebInspector.CanvasProfileType.prototype.setRecordingProfile):
      (WebInspector.CanvasProfileType.prototype._isSingleFrameMode):
      (WebInspector.CanvasProfileHeader):
      (WebInspector.CanvasProfileHeader.prototype._updateCapturingStatus):
      (WebInspector.CanvasProfileHeader.prototype._requestCapturingStatus):
      * inspector/front-end/ProfileLauncherView.js:
      (WebInspector.ProfileLauncherView):
      * inspector/front-end/ProfilesPanel.js:
      (WebInspector.ProfileType.prototype.get statusBarItems):
      (WebInspector.ProfilesPanel):
      (WebInspector.ProfilesPanel.prototype.get statusBarItems):
      (WebInspector.ProfilesPanel.prototype._onProfileTypeSelected):
      (WebInspector.ProfilesPanel.prototype._reset):
      (WebInspector.ProfilesPanel.prototype._showLauncherView):
      (WebInspector.ProfilesPanel.prototype.showProfile):
      (WebInspector.ProfilesPanel.prototype._updateInterface):
      (WebInspector.ProfilesPanel.prototype._resize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67df93b3
    • akling@apple.com's avatar
      Add CSSSelectorList::isValid(). · b3b891b1
      akling@apple.com authored
      <http://webkit.org/b/107809>
      
      Reviewed by Antti Koivisto.
      
      Add an isValid() method to CSSSelectorList and use that where applicable instead of checking
      if first() is a null pointer.
      
      * css/CSSPageRule.cpp:
      (WebCore::CSSPageRule::setSelectorText):
      * css/CSSSelectorList.cpp:
      * css/CSSSelectorList.h:
      (WebCore::CSSSelectorList::isValid):
      (WebCore::CSSSelectorList::first):
      (CSSSelectorList):
      * css/CSSStyleRule.cpp:
      (WebCore::CSSStyleRule::setSelectorText):
      * html/shadow/HTMLContentElement.cpp:
      (WebCore::HTMLContentElement::validateSelect):
      * inspector/InspectorStyleSheet.cpp:
      (WebCore::checkStyleRuleSelector):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140677 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3b891b1
    • michael.bruning@digia.com's avatar
      [Qt][WK2] Pages / resources cannot be loaded from qrc files. · 44c1e1e8
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=107031
      
      Reviewed by Jocelyn Turcotte.
      
      Enables WebKit2 Qt applications to load files from the bundled
      qrc files. This is achieved by adding a url scheme handler for
      the "qrc" scheme using the application scheme handler and ignoring
      all handlers for the qrc application scheme that the application might
      set.
      
      * UIProcess/API/qt/qquickurlschemedelegate.cpp:
      (QQuickQrcSchemeDelegate::QQuickQrcSchemeDelegate):
      (QQuickQrcSchemeDelegate::readResourceAndSend):
      * UIProcess/API/qt/qquickurlschemedelegate_p.h:
      (QQuickQrcSchemeDelegate):
      * UIProcess/API/qt/qquickwebview.cpp:
      (QQuickWebViewPrivate::initialize):
      (QQuickWebViewExperimental::schemeDelegates_Append):
      (QQuickWebViewExperimental::invokeApplicationSchemeHandler):
      * UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml:
      * UIProcess/API/qt/tests/qmltests/common/qrctest.html: Added.
      * UIProcess/API/qt/tests/qmltests/resources.qrc:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140676 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44c1e1e8
    • michael.bruning@digia.com's avatar
      [Qt] Webkit debug build links against release binaries of ANGLE libEGL, libGLESv2 · a2cc5ff5
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=106217
      
      Patch by Kai Koehne <kai.koehne@digia.com> on 2013-01-24
      Reviewed by Jocelyn Turcotte.
      
      Use libEGLd, libEGLSv2d if qtbase was compiled with ANGLE.
      
      * WebCore.pri: Mirror logic of qtbase\mkspecs\features\win32\opengl.prf
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2cc5ff5
    • commit-queue@webkit.org's avatar
      Adding "has-landed" command to webkit-patch which compares a · 336ec42a
      commit-queue@webkit.org authored
      committed patch to the changes which exist locally (ignoring the
      ChangeLog file).
      
      https://bugs.webkit.org/show_bug.cgi?id=106402
      
      Patch by Tim 'mithro' Ansell <mithro@mithis.com> on 2013-01-24
      Reviewed by Eric Seidel.
      
      * Scripts/webkitpy/common/checkout/diff_parser.py:
      (git_diff_to_svn_diff):
      * Scripts/webkitpy/common/net/bugzilla/bug.py:
      (Bug.commit_revision):
      * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
      (BugTest.test_is_in_comments):
      (BugTest):
      (BugTest.test_commit_revision):
      * Scripts/webkitpy/tool/commands/upload.py:
      (HasLanded):
      * Scripts/webkitpy/tool/steps/__init__.py:
      * Scripts/webkitpy/tool/steps/haslanded.py: Added.
      (HasLanded):
      (HasLanded.convert_to_svn):
      (HasLanded.strip_change_log):
      (run):
      
      * Scripts/webkitpy/common/net/bugzilla/bug.py:
      (Bug.commit_revision):
      * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
      (BugTest.test_is_in_comments):
      (BugTest):
      (BugTest.test_commit_revision):
      * Scripts/webkitpy/tool/commands/upload.py:
      (HasLanded):
      * Scripts/webkitpy/tool/steps/__init__.py:
      * Scripts/webkitpy/tool/steps/haslanded.py: Added.
      (HasLanded):
      (HasLanded.convert_to_svn):
      (HasLanded.strip_change_log):
      (HasLanded.diff_diff):
      (HasLanded.run):
      * Scripts/webkitpy/tool/steps/haslanded_unittest.py: Added.
      (HasLandedTest):
      (HasLandedTest.test_run):
      (test_convert_to_svn_and_strip_change_log):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      336ec42a