1. 08 Jun, 2006 1 commit
  2. 07 Jun, 2006 3 commits
    • justing's avatar
      LayoutTests: · 93798f1e
      justing authored
              Reviewed by levi
      
              * editing/deleting/delete-4038408-fix-expected.txt:
              * editing/input/attributed-substring-from-range-lines-expected.txt:
              * editing/inserting/insert-3654864-fix-expected.txt:
              * editing/inserting/insert-3659587-fix-expected.txt:
              * editing/inserting/insert-3775316-fix-expected.txt:
              * editing/inserting/insert-at-end-01-expected.txt:
              * editing/inserting/insert-at-end-02-expected.txt:
              * editing/inserting/insert-br-001-expected.txt:
              * editing/inserting/insert-br-005-expected.txt:
      
      WebCore:
      
              Reviewed by levi
              
              Fixed some comments and removed an unused variable.
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::removeBlockPlaceholder):
              Don't remove a br if it isn't at the start of a block, since
              it isn't really a "block placeholder".
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializePositionData):
              (WebCore::DeleteSelectionCommand::mergeParagraphs):
              (WebCore::DeleteSelectionCommand::doApply):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
              * editing/htmlediting.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14768 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93798f1e
    • darin's avatar
      LayoutTests: · f3820f23
      darin authored
              Reviewed by Hyatt, tweaked by Mitz.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9122
                REGRESSION: Incorrect vertical position for text fields in a "display: table" block
      
              * fast/table/text-field-baseline-expected.checksum: Added.
              * fast/table/text-field-baseline-expected.png: Added.
              * fast/table/text-field-baseline-expected.txt: Added.
              * fast/table/text-field-baseline.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9122
                REGRESSION: Incorrect vertical position for text fields in a "display: table" block
      
              Test: fast/table/text-field-baseline.html
      
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::baselinePosition): Do not descend into replaced objects, just
              use their baseline.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14760 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3820f23
    • darin's avatar
      LayoutTests: · 627b1374
      darin authored
              Reviewed by Hyatt.
      
              - pixel test for http://bugzilla.opendarwin.org/show_bug.cgi?id=4334
                REGRESSION: Flickering when css-hover should change opacity on floating elements
      
              * fast/block/float/nopaint-after-layer-destruction-expected.checksum: Added.
              * fast/block/float/nopaint-after-layer-destruction-expected.png: Added.
              * fast/block/float/nopaint-after-layer-destruction-expected.txt: Added.
              * fast/block/float/nopaint-after-layer-destruction.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt (concept) and Darin (some coding details).
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4334
                REGRESSION: Flickering when css-hover should change opacity on floating elements
      
              Pixel test: fast/block/float/nopaint-after-layer-destruction.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::setPaintsFloatingObject): Added. Changes the noPaint flag
              in the block's FloatingObject for the given float and calls setChildNeedsLayout.
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::blockThatPaintsFloat): Added this helper function.
              (WebCore::RenderBox::setStyle): Added. Calls to setPaintsFloatingObject when a float
              gains or loses its layer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14759 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      627b1374
  3. 06 Jun, 2006 4 commits
    • darin's avatar
      LayoutTests: · 5b1b7704
      darin authored
              Reviewed by Hyatt.
      
              - repaint test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9121
                REGRESSION: [Incremental Repaint] DHTML movement test failures
      
              * fast/repaint/containing-block-position-change-expected.checksum: Added.
              * fast/repaint/containing-block-position-change-expected.png: Added.
              * fast/repaint/containing-block-position-change-expected.txt: Added.
              * fast/repaint/containing-block-position-change.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9121
                REGRESSION: [Incremental Repaint] DHTML movement test failures
      
              Test (repaint): fast/repaint/containing-block-position-change.html
      
              * manual-tests/containing-block-position-chage.html: Added.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock): Unrelated change: fixed typo from
              the RenderCanvas to RenderView rename.
              (WebCore::RenderBlock::removePositionedObject): Added a return immediately
              after removing the object.
              (WebCore::RenderBlock::removePositionedObjects): Added.
              * rendering/RenderBlock.h:
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::setStyle): Added code to remove absolutely positioned
              descendants from the positioned objects list of their current containing block
              when they are going to have a new one as a result of this block's position
              property changing. 
              * rendering/RenderObject.h:
              (WebCore::RenderObject::removePositionedObjects):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14757 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b1b7704
    • darin's avatar
      * fast/repaint/table-extra-bottom-grow.html: Removed unneeded line of code. · ffa253c8
      darin authored
              * fast/repaint/table-extra-bottom-grow-expected.png: Regenerated.
              * fast/repaint/table-extra-bottom-grow-expected.checksum: Regenerated.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14756 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffa253c8
    • justing's avatar
      LayoutTests: · 11ec52ed
      justing authored
              Reviewed by levi
      
              Added to demonstrate fixes:
              * editing/pasteboard/merge-after-delete-expected.checksum: Added.
              * editing/pasteboard/merge-after-delete-expected.png: Added.
              * editing/pasteboard/merge-after-delete-expected.txt: Added.
              * editing/pasteboard/merge-after-delete.html: Added.
              * editing/inserting/line-break-expected.checksum: Added.
              * editing/inserting/line-break-expected.png: Added.
              * editing/inserting/line-break-expected.txt: Added.
              * editing/inserting/line-break.html: Added.
              * editing/inserting/multiple-lines-selected-expected.checksum: Added.
              * editing/inserting/multiple-lines-selected-expected.png: Added.
              * editing/inserting/multiple-lines-selected-expected.txt: Added.
              * editing/inserting/multiple-lines-selected.html: Added.
              
              Fixed:
              * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
              * editing/deleting/delete-3775172-fix-expected.txt:
              * editing/deleting/delete-3928305-fix-expected.txt:
              * editing/deleting/delete-3959464-fix-expected.checksum:
              * editing/deleting/delete-3959464-fix-expected.png:
              * editing/deleting/delete-3959464-fix-expected.txt:
              * editing/deleting/delete-4038408-fix-expected.checksum:
              * editing/deleting/delete-4038408-fix-expected.png:
              * editing/deleting/delete-4038408-fix-expected.txt:
              * editing/deleting/delete-4038408-fix.html:
              * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
              * editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
              * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
              * editing/deleting/delete-block-contents-001-expected.txt:
              * editing/deleting/delete-block-contents-002-expected.txt:
              * editing/deleting/delete-block-contents-003-expected.txt:
              * editing/deleting/delete-br-011-expected.checksum:
              * editing/deleting/delete-br-011-expected.png:
              * editing/deleting/delete-br-011-expected.txt:
              * editing/deleting/delete-image-004-expected.txt:
              * editing/deleting/delete-line-010-expected.txt:
              * editing/deleting/delete-line-015-expected.txt:
              * editing/deleting/delete-select-all-001-expected.checksum:
              * editing/deleting/delete-select-all-001-expected.png:
              * editing/deleting/delete-select-all-001-expected.txt:
              * editing/deleting/delete-select-all-002-expected.txt:
              * editing/deleting/delete-select-all-003-expected.checksum:
              * editing/deleting/delete-select-all-003-expected.png:
              * editing/deleting/delete-select-all-003-expected.txt:
              * editing/execCommand/insertImage-expected.checksum:
              * editing/execCommand/insertImage-expected.png:
              * editing/input/attributed-substring-from-range-lines-expected.txt:
              * editing/input/text-input-controller-expected.txt:
              * editing/inserting/insert-3654864-fix-expected.txt:
              * editing/inserting/insert-3659587-fix-expected.txt:
              * editing/inserting/insert-3775316-fix-expected.txt:
              * editing/inserting/insert-after-delete-001-expected.txt:
              * editing/inserting/insert-at-end-01-expected.txt:
              * editing/inserting/insert-at-end-02-expected.txt:
              * editing/inserting/insert-br-001-expected.txt:
              * editing/inserting/insert-br-005-expected.txt:
              * editing/pasteboard/4076267-3-expected.txt:
              * editing/pasteboard/4076267-expected.txt:
              * editing/pasteboard/drag-drop-modifies-page-expected.txt:
              * editing/pasteboard/paste-4035648-fix-expected.txt:
              * editing/pasteboard/paste-4039777-fix-expected.checksum:
              * editing/pasteboard/paste-4039777-fix-expected.png:
              * editing/pasteboard/paste-4039777-fix-expected.txt:
              * editing/pasteboard/paste-match-style-001-expected.txt:
              * editing/pasteboard/paste-match-style-002-expected.txt:
              * editing/pasteboard/smart-paste-006-expected.txt:
              * editing/pasteboard/smart-paste-007-expected.txt:
              * editing/selection/drag-to-contenteditable-iframe-expected.txt:
              * editing/style/block-style-005-expected.txt:
              * editing/style/typing-style-002-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.checksum:
              * editing/unsupported-content/list-delete-001-expected.png:
              * editing/unsupported-content/list-delete-001-expected.txt:
              * editing/unsupported-content/list-delete-002-expected.checksum:
              * editing/unsupported-content/list-delete-002-expected.png:
              * editing/unsupported-content/list-delete-002-expected.txt:
              * editing/unsupported-content/table-delete-001-expected.checksum:
              * editing/unsupported-content/table-delete-001-expected.png:
              * editing/unsupported-content/table-delete-001-expected.txt:
              * editing/unsupported-content/table-delete-003-expected.checksum:
              * editing/unsupported-content/table-delete-003-expected.png:
              * editing/unsupported-content/table-delete-003-expected.txt:
              * fast/text/attributed-substring-from-range.html:
      
      WebCore:
      
              Reviewed by levi
      
              * dom/Node.cpp:
              (WebCore::Node::firstDescendant): Added.
              * dom/Node.h:
              * dom/Range.cpp: Added a constructor that takes in Positions.
              (WebCore::Range::Range):
              * dom/Range.h:
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::insertNodeAt): 
              Let this function insert children into empty containers.  
              Calls canHaveChildrenForEditing.
              (WebCore::CompositeEditCommand::appendNode): Assert that the parent canHaveChildrenForEditing.
              (WebCore::CompositeEditCommand::moveParagraph): Tell ReplaceSelectionCommand to select the 
              replacement so that moveParagraph's callers have a valid destination after the move.
              * editing/CompositeEditCommand.h: Moved removeFullySelectedNode to DeleteSelectionCommand,
              made deleteTextFromNode virtual so that DeleteSelectionCommand can update it's endingPosition.
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::DeleteSelectionCommand): 
              Removed m_startNode, used a local variable.
              (WebCore::DeleteSelectionCommand::initializeStartEnd): Fixed special element expansion.
              (WebCore::DeleteSelectionCommand::initializePositionData): Compute the endingPosition up
              front and keep track of it as nodes and text are removed.
              (WebCore::DeleteSelectionCommand::handleSpecialCaseBRDelete): Removed use of m_startNode.
              (WebCore::DeleteSelectionCommand::removeFullySelectedNode): Moved from CompositeEditCommand.
              Update m_endingPosition as we remove nodes.
              (WebCore::DeleteSelectionCommand::deleteTextFromNode): 
              Update m_endingPosition as we delete text.
              (WebCore::DeleteSelectionCommand::handleGeneralDelete): Retain the start block.  Cleaned up.
              (WebCore::DeleteSelectionCommand::mergeParagraphs): Recompute m_endingPosition since moveParagraph
              clobbers the old one.
              (WebCore::DeleteSelectionCommand::doApply): Fixed the logic for placeholder insertion after 
              deletion. Make the placeholder decision before we do special element expansion.
              * editing/DeleteSelectionCommand.h:
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply): Fixed a bug where an extra br was inserted and cleaned 
              up the code.
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply): Deletion of the current selection should do
              a merge (added a testcase).
              * editing/RebalanceWhitespaceCommand.cpp:
              (WebCore::RebalanceWhitespaceCommand::doUnapply): Remove/insert in a way that will trigger a layout.
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply): Ditto.
              Merge even when the incoming fragment has interchange newlines (added a testcase).
              Merge when the selection being pasted into starts at the start of a block because not
              doing so would leave one or more hanging empty blocks.
              (WebCore::ReplaceSelectionCommand::completeHTMLReplacement):
              Rebalance whitespace using rebalanceWhitespaceAt because rebalanceWhitespace requires
              a selection, and a selection can't be created until whitespace has been rebalanced.
              * editing/htmlediting.cpp:
              (WebCore::canHaveChildrenForEditing): Added.
              * editing/htmlediting.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14751 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11ec52ed
    • andersca's avatar
      WebCore: · c382f5ba
      andersca authored
      2006-06-06  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
              clientWidth/clientHeight on document element in strict mode should return visible frame size
              
              * dom/Element.cpp:
              (WebCore::Element::clientWidth):
              (WebCore::Element::clientHeight):
              If we're the document element, and in strict mode, return the visible size of the frame.
              
      LayoutTests:
      
      2006-06-06  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9325
              clientWidth/clientHeight on document element in strict mode should return visible frame size
      
              * fast/dom/client-width-height-expected.txt: Added.
              * fast/dom/client-width-height.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c382f5ba
  4. 05 Jun, 2006 3 commits
    • ddkilzer's avatar
      LayoutTests: · 00974eb7
      ddkilzer authored
              Reviewed by mjs.
      
              testcases for http://bugzilla.opendarwin.org/show_bug.cgi?id=5564
              'font' shorthand parsing should be more tolerant in quirks mode
      
              * fast/css/font_property_compatibility-expected.checksum: Added.
              * fast/css/font_property_compatibility-expected.png: Added.
              * fast/css/font_property_compatibility-expected.txt: Added.
              * fast/css/font_property_compatibility.html: Added.
              * fast/css/font_property_normal-expected.checksum: Added.
              * fast/css/font_property_normal-expected.png: Added.
              * fast/css/font_property_normal-expected.txt: Added.
              * fast/css/font_property_normal.html: Added.
      
      WebCore:
      
              Reviewed by mjs.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=5564
              'font' shorthand parsing should be more tolerant in quirks mode
      
              When not in strict mode accept font property specifications
              lacking a font family part, like WinIE does.
      
              * css/cssparser.cpp:
              (WebCore::CSSParser::parseFont):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14740 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00974eb7
    • ddkilzer's avatar
      LayoutTests: · 0f15b235
      ddkilzer authored
              Reviewed by ggaren.
      
              - Test results for http://bugzilla.opendarwin.org/show_bug.cgi?id=9310
              Add missing DOM prototypes and other DOM cleanup
      
              * fast/dom/global-constructors-expected.txt: Fixed test results.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14738 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f15b235
    • ggaren's avatar
      LayoutTests: · 27b705a1
      ggaren authored
              - Merged test-prototypes.html into global-constructors.html
              - Added prototypes.html, which tests for some missing prototypes in DOM objects
              
              * fast/dom/global-constructors-expected.txt:
              * fast/dom/global-constructors.html:
              * fast/dom/prototypes-expected.txt: Added.
              * fast/dom/prototypes.html: Added.
              * fast/dom/test-prototypes-expected.txt: Removed.
              * fast/dom/test-prototypes.html: Removed.
              * fast/dom/undetectable-document-all-expected.txt: Updated to reflect
              change from "HTMLCollection" to "Collection"
      
      WebCore:
      
              Reviewed by Darin.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9310
              Add missing DOM prototypes and other DOM cleanup
      
              - Added the built-in object prototype to DOM objects that were missing it
              so that primitive operations like == work on them.
              
              - Removed dead EventConstructor class (it's autogenerated now)
              
              - Changed HTML collections to describe themselves as "[object Collection]",
              to match IE.
              
              - Made DOMCSSRule constructor private because JSCSSRule is the class
              to use.
              
              * bindings/js/JSHTMLOptionElementConstructor.cpp:
              (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
              * bindings/js/kjs_css.cpp:
              (KJS::DOMStyleSheet::DOMStyleSheet):
              (KJS::DOMStyleSheetList::DOMStyleSheetList):
              (KJS::DOMCSSRule::DOMCSSRule):
              (KJS::DOMCSSValue::DOMCSSValue):
              (KJS::toJS):
              (KJS::DOMRGBColor::DOMRGBColor):
              (KJS::getDOMRGBColor):
              (KJS::DOMRect::DOMRect):
              * bindings/js/kjs_css.h:
              * bindings/js/kjs_dom.cpp:
              (KJS::DOMNodeList::DOMNodeList):
              (KJS::DOMExceptionConstructor::DOMExceptionConstructor):
              (KJS::DOMExceptionConstructor::getOwnPropertySlot):
              (KJS::):
              (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
              * bindings/js/kjs_dom.h:
              (KJS::DOMNamedNodesCollection::classInfo):
              * bindings/js/kjs_events.h:
              * bindings/js/kjs_html.cpp:
              (KJS::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14735 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27b705a1
  5. 04 Jun, 2006 3 commits
    • darin's avatar
      LayoutTests: · 9d783fab
      darin authored
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9176
                REGRESSION: repro crash in WebCore::StringImpl::hash() const + 28 (StringImpl.h:67)
      
              * fast/loader/link-no-URL.html: Added.
              * fast/loader/link-no-URL-expected.txt: Added.
      
      WebCore:
      
              Reviewed by Maciej.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9176
                REGRESSION: repro crash in WebCore::StringImpl::hash() const + 28 (StringImpl.h:67)
      
              Test: fast/loader/link-no-URL.html
      
              * loader/Cache.h:
              * loader/Cache.cpp:
              (WebCore::Cache::updateCacheStatus): Removed the URL parameter. Instead get the URL
              from the cached object itself. Callers were passing in the wrong URL. When it was a
              null string, it caused the crash mentioned above. But in other cases it may have
              caused some other minor problems as well. Added an assert to catch cases where the
              URL is null (should never happen).
              (WebCore::Cache::requestImage): Changed call site to not pass URL.
              (WebCore::Cache::requestStyleSheet): Ditto.
              (WebCore::Cache::requestScript): Ditto.
              (WebCore::Cache::requestXSLStyleSheet): Ditto.
              (WebCore::Cache::requestXBLDocument): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14732 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d783fab
    • ddkilzer's avatar
      LayoutTests: · fb5e6eec
      ddkilzer authored
              Reviewed by hyatt.
      
              - tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9213
                Absolutely positioned objects with relatively positioned inline 
                containing blocks are rendered incorrectly
      
              * fast/block/positioning/absolute-in-inline-ltr-2.html: Added.
              * fast/block/positioning/absolute-in-inline-ltr-3.html: Added.
              * fast/block/positioning/absolute-in-inline-ltr.html: Added.
              * fast/block/positioning/absolute-in-inline-rtl-2.html: Added.
              * fast/block/positioning/absolute-in-inline-rtl-3.html: Added.
              * fast/block/positioning/absolute-in-inline-rtl.html: Added.
              * fast/block/positioning/absolute-in-inline-short-ltr.html: Added.
              * fast/block/positioning/absolute-in-inline-short-rtl.html: Added.
      
      WebCore:
      
              Reviewed by hyatt.
      
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9213
                Absolutely positioned objects with relatively positioned inline 
                containing blocks are rendered incorrectly
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::containingBlockWidthForPositioned):
              (WebCore::RenderBox::containingBlockHeightForPositioned):
              (WebCore::RenderBox::calcAbsoluteHorizontal):
              (WebCore::RenderBox::calcAbsoluteHorizontalValues):
              (WebCore::RenderBox::calcAbsoluteVertical):
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced):
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced):
              * rendering/RenderBox.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14727 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb5e6eec
    • andersca's avatar
      WebCore: · 0315a98f
      andersca authored
      2006-06-04  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
              document.evaluate and createNSResolver miss on namespaced elements
              
              * xpath/XPathExpression.cpp:
              (WebCore::XPathExpression::createExpression):
              Pass the resolver to the parser.
              
              * xpath/XPathResult.cpp:
              (WebCore::XPathResult::iterateNext):
              Fix off-by-one error.
              
              * xpath/impl/XPathExpressionNode.h:
              (WebCore::XPath::EvaluationContext::EvaluationContext):
              Get rid of the resolver in the evaluation context.
              
              * xpath/impl/XPathGrammar.y:
              Fetch the resolver from the parser. Only return the local name.
              
              * xpath/impl/XPathParser.cpp:        
              (WebCore::XPath::Parser::parseStatement):
              * xpath/impl/XPathParser.h:
              (WebCore::XPath::Parser::resolver):
              Update to hold the resolver.
              
              * xpath/impl/XPathStep.cpp:
              (WebCore::XPath::Step::Step):
              If the parser has stored a namespace URI, set it.
              
              (WebCore::XPath::Step::nodeTestMatches):
              Check namespace URIs.
              
              * xpath/impl/XPathStep.h:
              Add m_namespaceURI.
      
      LayoutTests:
      
      2006-06-04  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9035
              document.evaluate and createNSResolver miss on namespaced elements
      
              * fast/xpath: Added.
              * fast/xpath/xpath-namespaces-expected.txt: Added.
              * fast/xpath/xpath-namespaces.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0315a98f
  6. 03 Jun, 2006 3 commits
    • ddkilzer's avatar
      LayoutTests: · a0cd6749
      ddkilzer authored
              Reviewed by Eric.
      
              Added missing pixel test output:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8848
              TFOOT borders are copied to THEAD and TBODY
      
              * fast/table/border-collapsing/border-collapsing-head-foot-expected.png: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0cd6749
    • ddkilzer's avatar
      LayoutTests: · 6a28aac9
      ddkilzer authored
              Reviewed by mjs.  Tweaked and landed by ddkilzer.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
              With java disabled wrong information is displayed.
      
              * fast/replaced/applet-rendering-java-disabled.html: Added.
              * fast/replaced/applet-rendering-java-disabled-expected.checksum: Added.
              * fast/replaced/applet-rendering-java-disabled-expected.html: Added.
              * fast/replaced/applet-rendering-java-disabled-expected.png: Added.
              * tables/mozilla_expected_failures/bugs/bug8499-expected.checksum: Changed after removing RenderEmptyApplet.
              * tables/mozilla_expected_failures/bugs/bug8499-expected.png: Ditto.
              * tables/mozilla_expected_failures/bugs/bug8499-expected.txt: Ditto.
      
      WebCore:
      
              Reviewed by mjs.  Tweaked and landed by ddkilzer.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7281
              With java disabled wrong information is displayed.
      
              Test: fast/replaced/applet-rendering-java-disabled.html
      
              Match WinIE, render applet content inline when java is
              disabled. 
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Removed RenderEmptyApplet.cpp and RenderEmptyApplet.h.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
              * html/HTMLAppletElement.cpp:
              (WebCore::HTMLAppletElement::createRenderer):
              * rendering/RenderEmptyApplet.cpp: Removed.
              * rendering/RenderEmptyApplet.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a28aac9
    • thatcher's avatar
      LayoutTests: · dd4c7a30
      thatcher authored
              Reviewed by Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9252
                REGRESSION: Very odd roll-over issues (content disappearing)
      
              * fast/dom/HTMLLinkElement/pending-stylesheet-count.html: Added.
              * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.txt: Added.
              * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.png: Added.
              * fast/dom/HTMLLinkElement/pending-stylesheet-count-expected.checksum: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9252
                REGRESSION: Very odd roll-over issues (content disappearing)
      
              Test: fast/dom/HTMLLinkElement/pending-stylesheet-count.html
      
              * html/HTMLLinkElement.cpp:
              (WebCore::HTMLLinkElement::~HTMLLinkElement): If the stylesheet was being
              loaded, call stylesheetLoaded() on the document, to keep the pending stylesheet
              count correct.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd4c7a30
  7. 02 Jun, 2006 6 commits
    • ddkilzer's avatar
      JavaScriptCore: · 31459a5c
      ddkilzer authored
              Reviewed by ggaren.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9234
                Implement $&, $' and $` replacement codes in String.prototype.replace
      
              Test: fast/js/string-replace-3.html
      
              * kjs/string_object.cpp:
              (substituteBackreferences): Added support for $& (matched substring),
              $` (everything preceding matched substring), $' (everything following
              matched substring) and 2-digit back references, and cleaned up a little.
      
      LayoutTests:
      
              Reviewed by ggaren.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9234
                Implement $&, $' and $` replacement codes in String.prototype.replace
      
              * fast/js/resources/string-replace-3.js: Added.
              * fast/js/string-replace-3-expected.txt: Added.
              * fast/js/string-replace-3.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31459a5c
    • thatcher's avatar
      LayoutTests: · 8991c154
      thatcher authored
              Reviewed by Hyatt, checked in by Tim H.
      
              For: http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
              Added test case to test opacity layers, in particular, opacities
              with a value of zero.
      
             * fast/css/ZeroOpacityLayers.html: Added.
             * fast/css/ZeroOpacityLayers-expected.txt: Added.
             * fast/css/ZeroOpacityLayers-expected.png: Added.
             * fast/css/ZeroOpacityLayers-expected.checksum: Added.
             * fast/css/ZeroOpacityLayers2.html: Added.
             * fast/css/ZeroOpacityLayers2-expected.txt: Added.
             * fast/css/ZeroOpacityLayers2-expected.png: Added.
             * fast/css/ZeroOpacityLayers2-expected.checksum: Added.
      
      WebCore:
      
              Reviewed by Hyatt, checked in by Tim H.
      
              fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=9115
              Changed RenderLayer to only render layers that are not
              totally transparent.
      
              * rendering/RenderLayer.cpp
              (RenderLayer::paintLayer):
              Changed function to also check if the layer is totally transparent
              and if it is, don't bother painting it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8991c154
    • thatcher's avatar
      LayoutTests: · 864dbca9
      thatcher authored
              Reviewed by Hyatt, checked in by Tim H.
      
              Adding testcase for bug 8223.
      
              * fast/dom/css-inline-style-important-expected.checksum: Added.
              * fast/dom/css-inline-style-important-expected.png: Added.
              * fast/dom/css-inline-style-important-expected.txt: Added.
              * fast/dom/css-inline-style-important.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt, checked in by Tim H.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8223
              WebKit fails to update style on element via DOM
      
              Handle !important by detecting it and using a different code
              path from normal priority.
      
              * bindings/js/kjs_css.cpp:
              (KJS::DOMCSSStyleDeclaration::put):
              * css/CSSStyleDeclaration.cpp:
              (WebCore::CSSStyleDeclaration::setProperty):
              * css/CSSStyleDeclaration.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      864dbca9
    • darin's avatar
      LayoutTests: · d8c28ba8
      darin authored
              Reviewed by Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=3379
                attr(X) does not work
      
              * fast/css-generated-content/016-expected.checksum: Added.
              * fast/css-generated-content/016-expected.png: Added.
              * fast/css-generated-content/016-expected.txt: Added.
              * fast/css-generated-content/016.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3379
                attr(X) does not work
      
              Test: fast/css-generated-content/016.html
      
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::canShareStyleWithElement): Don't share style
              if the unique bit is set.
              (WebCore::CSSStyleSelector::applyProperty): When applying the "attr" property,
              set the unique bit and add to m_selectorAttrs.
      
              * rendering/render_style.cpp: Did a lot of reformatting, and this one real change.
              (WebCore::RenderStyle::RenderStyle): Initialize m_unique to false.
      
              * rendering/render_style.h:
              (WebCore::RenderStyle::unique): Added. Returns value of m_unique.
              (WebCore::RenderStyle::setUnique): Added. Sets m_unique.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14687 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8c28ba8
    • darin's avatar
      Reviewed by Anders. · c8ed75dd
      darin authored
              Updated test so that is will once again exercise the fix for
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9009
      
              * fast/table/empty-section-crash-expected.txt:
              * fast/table/empty-section-crash.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14685 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8ed75dd
    • ddkilzer's avatar
      LayoutTests: · 249f410d
      ddkilzer authored
              Reviewed by mjs.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
              Finish renaming of RenderCanvas to RenderView
      
              * editing/selection/7152-1-expected.checksum: Layout changed due to text change in HTML file.
              * editing/selection/7152-1-expected.png: Ditto.
              * editing/selection/7152-1-expected.txt: Ditto.
              * editing/selection/7152-1.html: Changed text in HTML content.
              * editing/selection/7152-2-expected.checksum: Layout changed due to text change in HTML file.
              * editing/selection/7152-2-expected.png: Ditto.
              * editing/selection/7152-2-expected.txt: Ditto.
              * editing/selection/7152-2.html: Changed text in HTML content.
              * *-expected.txt: Replaced "RenderCanvas" with "RenderView" in 3023 more files.
      
      WebCore:
      
              Reviewed by mjs.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9183
              Finish renaming of RenderCanvas to RenderView
      
              * rendering/RenderView.h: Changed renderName from "RenderCanvas" to "RenderView".
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14684 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      249f410d
  8. 01 Jun, 2006 11 commits
    • darin's avatar
      LayoutTests: · bd205a70
      darin authored
              Reviewed by Maciej and Adele
              
              Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
              Updated and extended select/option form tests 
              
              * fast/forms/HTMLOptionElement_label01.html:
              * fast/forms/HTMLOptionElement_label01-expected.txt:
              * fast/forms/HTMLOptionElement_label01-expected.png:
              * fast/forms/HTMLOptionElement_label02.html:
              * fast/forms/HTMLOptionElement_label02-expected.txt:
              * fast/forms/HTMLOptionElement_label02-expected.png:
              * fast/forms/HTMLOptionElement_label03.html:
              * fast/forms/HTMLOptionElement_label03-expected.txt:
              * fast/forms/HTMLOptionElement_label03-expected.png
              * fast/forms/HTMLOptionElement_label04.html:
              * fast/forms/HTMLOptionElement_label04-expected.txt:
              * fast/forms/HTMLOptionElement_label04-expected.png
              * fast/forms/HTMLOptionElement_label05.html:
              * fast/forms/HTMLOptionElement_label05-expected.txt:
              * fast/forms/HTMLOptionElement_label05-expected.png:
              Updated to reflect success and added some description
              
              * fast/forms/HTMLOptionElement_label06.html:
              * fast/forms/HTMLOptionElement_label06-expected.txt:
              * fast/forms/HTMLOptionElement_label05-expected.png:
              * fast/forms/HTMLOptionElement_label07.html:
              * fast/forms/HTMLOptionElement_label07-expected.txt:
              * fast/forms/HTMLOptionElement_label07-expected.png:
              Added.
      
      WebCore:
      
              Reviewed by Maciej and Adele
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8398
              REGRESSION: LABEL in OPTION element is clobbering display #TEXT
              Patch provided by Darin.
              
              * rendering/RenderSelect.cpp
              (RenderSelect::updateFromElement): 
              Changed to use the containing text by default, and not the label text
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd205a70
    • darin's avatar
      LayoutTests: · 7869e236
      darin authored
              Reviewed by Hyatt
              
              Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
              Test the window.screen.pixelDepth and window.screen.colorDepth
              
              * fast/dom/window/window-screen-properties.html: Added
              * fast/dom/window/window-screen-properties-expected.txt: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8646
              Correcting the value returned for window.screen.pixelDepth and
              window.screen.colorDepth
              
              * platform/mac/ScreenMac.mm
              (screenDepth): 
              Changed to return the BitsPerPixelFromDepth rather than the WindowDepth
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7869e236
    • ggaren's avatar
      LayoutTests: · 0c46d58a
      ggaren authored
              - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9113
              REGRESSION (14581): XMLHttpRequest never calls onreadystatechange with 
              a readystate == 4
      
              * http/tests/xmlhttprequest/event-listener-gc.html: Added.
              * http/tests/xmlhttprequest/event-listener-gc-expected.txt: Added.
      
      WebCore:
      
              Fix by Mitz. Reviewed, tweaked, tested, landed by me.
      
              - Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=9113
              REGRESSION (14581): XMLHttpRequest never calls onreadystatechange with 
              a readystate == 4
              
              An XMLHttpRequest must be added to the DOMObject cache so that its
              DOM implementation object can protect it, and by extension, its event
              listeners.
              
              This design seems slightly backwards to me -- the bindings should know
              about the DOM, not the other way around -- but I'm restoring it for
              now to fix the regression.
              
              * bindings/js/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequest::JSXMLHttpRequest):
              (KJS::JSXMLHttpRequest::~JSXMLHttpRequest):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14671 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c46d58a
    • andersca's avatar
      WebCore: · 079f44cf
      andersca authored
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
              multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
              
              * bindings/js/kjs_window.cpp:
              (KJS::Location::put):
              Handle the case where the hash starts with a "#". Also, don't do anything if the previous and new hashes
              are equal.
              
              * bridge/BrowserExtension.h:
              * bridge/mac/BrowserExtensionMac.h:
              * bridge/mac/BrowserExtensionMac.mm:        
              (WebCore::BrowserExtensionMac::historyURL):
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              New function historyURL which returns the complete URL for a given item in the history.
              
              * page/Frame.cpp:
              (WebCore::Frame::scheduleLocationChange):        
              (WebCore::Frame::scheduleHistoryNavigation):
              If the URL of the new location only differs in the hash, don't schedule the load. Instead, load it
              directly.
              
              * platform/KURL.cpp:
              * platform/KURL.h:
              Add equalsIgnoringRef which returns whether two URLs are equal, ignoring the ref.
      
      WebKit:
      
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
              multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
      
              * Misc/WebNSURLExtras.m:
              (-[NSString _webkit_URLFragment]):
              Don't include the "#" character in the fragment.
              
              * WebCoreSupport/WebFrameBridge.m:
              (-[WebFrameBridge historyURL:]):
              New function, returns the history URL for a given position in the back/forward list
              
              * WebView/WebFrame.m:
              (-[WebFrame _loadItem:withLoadType:]):
              Always call scrollToAnchorWithURL, even if there is no fragment. This way we keep the WebCore frame's
              URL up-to-date.
      
      WebKitTools:
      
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              * DumpRenderTree/DumpRenderTree.m:
              (+[LayoutTestController isSelectorExcludedFromWebScript:]):
              (-[LayoutTestController clearBackForwardList]):
              Add clearBackForwardList function to layoutTestController
              
      LayoutTests:
      
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=6309
              multiple problems prevent bookmarking/back button technique for AJAX/DHTML applications from working
              
              * fast/dom/location-hash-expected.txt: Added.
              * fast/dom/location-hash.html: Added.
              Added tests.
              
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      079f44cf
    • mjs's avatar
      LayoutTests: · 8e2da038
      mjs authored
              Reviewed by Anders.
              
              - fixed "REGRESSION: Can't order from Pizza Hut (ToT, 05/24/06)"
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9103
      
              * http/tests/misc/redirect-expected.txt: Added.
              * http/tests/misc/redirect.php: Added.
              * http/tests/misc/resources/redirect-result.php: Added.
      
      WebKit:
      
              Reviewed by Anders.
              
              - fixed "REGRESSION: Can't order from Pizza Hut (ToT, 05/24/06)"
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9103
      
              * WebView/WebDataSource.m:
              (-[WebDataSource _willSendRequest:forResource:redirectResponse:]): Set up the
              User-Agent header.
              * WebView/WebDataSourceInternal.h:
              * WebView/WebLoader.m:
              (-[NSURLProtocol willSendRequest:redirectResponse:]): Pass a mutable URL request
              so the above can work.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e2da038
    • justing's avatar
      LayoutTests: · 5c304863
      justing authored
              Reviewed by harrison
      
              * editing/selection/focus-body-expected.checksum: Added.
              * editing/selection/focus-body-expected.png: Added.
              * editing/selection/focus-body-expected.txt: Added.
              * editing/selection/focus-body.html: Added.
              * editing/selection/focus_editable_html-expected.checksum:
              * editing/selection/focus_editable_html-expected.png:
              * editing/selection/focus_editable_html-expected.txt:
      
      WebCore:
      
              Reviewed by harrison
              
              <rdar://problem/4567752> When forwarding a message, pressing TAB key to place caret in body actually selects the entire message instead
      
              * dom/Element.cpp:
              (WebCore::Element::focus):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c304863
    • andersca's avatar
      WebKit: · d6cc887c
      andersca authored
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              * WebView/WebFrameView.m:
              (+[WebFrameView _canShowMIMETypeAsHTML:]):
              Use _webkit_objectForMIMEType here so we'll get an object back for "text/".
      
      WebKitTools:
      
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8996
              slow-utf8-text layout test case failing (no longer deterministic?)
              
              * DumpRenderTree/DumpRenderTree.m:
              (dump):
              Dump as text when the response MIME type is text/plain
      
      LayoutTests:
      
      2006-06-01  Anders Carlsson  <acarlsson@apple.com>
      
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8996
              slow-utf8-text layout test case failing (no longer deterministic?)
      
              * http/tests/incremental/slow-utf8-text-expected.txt:
              Updated
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6cc887c
    • adele's avatar
      LayoutTests: · 65dc279a
      adele authored
              Reviewed by Hyatt.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9124
                Drop shadow obscures "add more stuff" bubble at live.com
      
              * fast/css/find-next-layer-expected.checksum: Added.
              * fast/css/find-next-layer-expected.png: Added.
              * fast/css/find-next-layer-expected.txt: Added.
              * fast/css/find-next-layer.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9124
                Drop shadow obscures "add more stuff" bubble at live.com
      
              Test: fast/css/find-next-layer.html
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::findNextLayer): Fixed a bug where this function could reach
              two levels down in the layer tree and return 0.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65dc279a
    • adele's avatar
      Updated test results for http://bugzilla.opendarwin.org/show_bug.cgi?id=8848 · 04b0fe95
      adele authored
              TFOOT borders are copied to THEAD and TBODY
      
              * tables/mozilla/marvin/backgr_layers-opacity-expected.checksum:
              * tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
              * tables/mozilla/marvin/backgr_position-table-expected.checksum:
              * tables/mozilla/marvin/backgr_position-table-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-cell-expected.checksum:
              * tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-column-expected.checksum:
              * tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-column-group-expected.checksum:
              * tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-expected.checksum:
              * tables/mozilla/marvin/backgr_simple-table-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-row-expected.checksum:
              * tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
              * tables/mozilla/marvin/backgr_simple-table-row-group-expected.checksum:
              * tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.checksum:
              * tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04b0fe95
    • adele's avatar
      LayoutTests: · 25e4a011
      adele authored
              Reviewed by Hyatt.
      
              - tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9100
                Absolutely positioned replaced elements with all non-auto
                values are rendered incorrectly
      
              * fast/replaced/absolute-position-with-auto-height-and-top-and-bottom.html: Added.
              * fast/replaced/absolute-position-with-auto-width-and-left-and-right.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=9100
                Absolutely positioned replaced elements with all non-auto
                values are rendered incorrectly
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calcAbsoluteHorizontalReplaced): Add support for case when all values are specified.
              (WebCore::RenderBox::calcAbsoluteVerticalReplaced): ditto
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25e4a011
    • adele's avatar
      LayoutTests: · cdca1364
      adele authored
              Reviewed by Hyatt.
      
              - test and updated results for
                http://bugzilla.opendarwin.org/show_bug.cgi?id=9012
                Row height not updated when cell heights change
      
              * fast/table/row-height-recalc-expected.checksum: Added.
              * fast/table/row-height-recalc-expected.png: Added.
              * fast/table/row-height-recalc-expected.txt: Added.
              * fast/table/row-height-recalc.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9012
                Row height not updated when cell heights change
      
              Test: fast/table/row-height-recalc.html
      
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::setStyle): Mark the section as needing recalculation
              if the height property changed.
              * rendering/RenderTableRow.cpp:
              (WebCore::RenderTableRow::setStyle): Ditto.
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::recalcCells): Initialize the grid row height
              to the height of the row element (like addChild() does).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cdca1364
  9. 31 May, 2006 3 commits
    • adele's avatar
      LayoutTests: · a9a86b91
      adele authored
              Reviewed by Geoff.
      
              Testcase for http://bugzilla.opendarwin.org/show_bug.cgi?id=8455
      
              * fast/forms/select-reset.html: Added.
      
      WebCore:
      
              Reviewed by Geoff.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8455
              selectedIndex for a select after a Form reset() has wrong value
      
              Make sure the list items are reset properly by selecting
              the first option in case no options have the selected attribute
              set.
      
              * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::reset):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9a86b91
    • adele's avatar
      LayoutTests: · 77712e9d
      adele authored
              Reviewed by Geoff.
      
              Add a test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8024
      
              * fast/dom/document-all-input.html: Added.
      
      WebCore:
      
              Reviewed by Geoff.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8024
              "Go" button (search) doesn't work at fifa.com (document.all.FormName)
      
              Allow input elements with name attributes as possible named
              items for document.all.
      
              * html/HTMLCollection.cpp:
              (WebCore::HTMLCollection::checkForNameMatch):
              (WebCore::HTMLCollection::updateNameCache):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77712e9d
    • bdakin's avatar
      Reviewed by Hyatt. · f0cf2561
      bdakin authored
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6755 CSS3: 
              Borders rounded with border-radius don't draw the roundings
      
              This patch does not draw all of the different border styles 
              perfectly, so I have filed a few followup bugs that I will 
              reference from this Bugzilla.
      
              * platform/GraphicsContext.h:
              * platform/cairo/GraphicsContextCairo.cpp:
              (WebCore::GraphicsContext::drawArc): drawArc() has different 
              parameters now, but mostly this needs to be implemented to match 
              the Mac side later.
              (WebCore::GraphicsContext::addRoundedRectClip): Just a stub. 
              Implement this later.
              (WebCore::GraphicsContext::addInnerRoundedRectClip): Just a stub. 
              Implement this later.
              * platform/cg/GraphicsContextCG.cpp:
              (WebCore::GraphicsContext::drawArc): drawArc() now handles drawing 
              elliptical arcs as well as circular arcs, it also takes a thickness 
              parameter to draw an arc of a given thickness and draws with the 
              appropriate pen style.
              (WebCore::GraphicsContext::addInnerRoundedRectClip): Adds a clip to 
              the inside of an arc instead of to the outside which is already 
              done by addRoundedClipRect()
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::drawBorderArc): Draws the border arcs in 
              the appropriate styles.
              (WebCore::RenderObject::paintBorder): Calls drawBorderArc() when 
              border arcs are needed.
              * rendering/RenderObject.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0cf2561
  10. 30 May, 2006 2 commits
  11. 26 May, 2006 1 commit
    • justing's avatar
      LayoutTests: · d745df2e
      justing authored
              Reviewed by levi
      
              Added, test for the crash by focusing an editable html element and then
              inserting a tab
              * editing/selection/editable-html-element-expected.checksum: Added.
              * editing/selection/editable-html-element-expected.png: Added.
              * editing/selection/editable-html-element-expected.txt: Added.
              * editing/selection/editable-html-element.html: Added.
              Fixed:
              * editing/selection/focus_editable_html-expected.checksum:
              * editing/selection/focus_editable_html-expected.png:
              * editing/selection/focus_editable_html-expected.txt:
      
      WebCore:
      
              Reviewed by levi
              
              <rdar://problem/4564296> Mail crashes on Leopard9A184 when I attempt to compose a new message
      
              * dom/Position.cpp:
              (WebCore::Position::inRenderedContent):
              Removed a candidate at [html, 0].
              * editing/CreateLinkCommand.cpp:
              (WebCore::CreateLinkCommand::doApply): Added early return when there is no selection.
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply): Ditto.
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::input): Ditto.
              * editing/Selection.cpp:
              (WebCore::Selection::validate): If visible positions can't be created from the endpoints, 
              then create a null selection.  Not doing this was making editing code think there was
              a valid, editable selection even though there wasn't.
              * editing/UnlinkCommand.cpp:
              (WebCore::UnlinkCommand::doApply): Early return.
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::initDeepPosition): Special case the html/body element boundary.
              It looks like a non-editable/editable boundary since rootEditableElement stops at the body
              even if the html element is editable.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@14618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d745df2e