1. 23 Jul, 2009 1 commit
    • treat@webkit.org's avatar
      WebCore: · bc00ddcf
      treat@webkit.org authored
      2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>
      
              Reviewed by David Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=27289
              When a mouse click occurs on a scrollbar without a preceding mouse move
              onto it, the release isn't handled correctly (since
              EventHandler::m_lastScrollbarUnderMouse isn't set on mouse down, but
              only on mouse move). (Side comment: That scrollbar-handling code
              in EventHandler is ugly. It should be fixed properly.)
      
              Tests: scrollbars/scrollbar-miss-mousemove.html
                     scrollbars/scrollbar-miss-mousemove-disabled.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseMoveEvent):
              (WebCore::EventHandler::updateLastScrollbarUnderMouse):
              * page/EventHandler.h:
      
      LayoutTests:
      2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>
      
              Reviewed by David Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=27289
              Tests that mouse clicks/releases are handled properly on scrollbars
              even when there is no mouse move onto the scrollbar (two cases: enabled
              and disabled controls).
      
              * scrollbars/scrollbar-miss-mousemove-disabled-expected.txt: Added.
              * scrollbars/scrollbar-miss-mousemove-disabled.html: Added.
              * scrollbars/scrollbar-miss-mousemove-expected.txt: Added.
              * scrollbars/scrollbar-miss-mousemove.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc00ddcf
  2. 10 Jul, 2009 1 commit
    • ddkilzer@apple.com's avatar
      2009-07-10 Shinichiro Hamaji <hamaji@chromium.org> · 9c4dacca
      ddkilzer@apple.com authored
              Reviewed by David Kilzer.
      
              WebKit needs a style linting tool
              https://bugs.webkit.org/show_bug.cgi?id=25884
      
              Fix bunch of style issues by autofix of cpplint.
              This patch is created to demonstrate the autofix of cpplint.py.
      
              No new testcases because it's a style fix
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseMediaQuery):
              (WebCore::CSSParser::validUnit):
              (WebCore::CSSParser::parseValue):
              (WebCore::skipCommaInDashboardRegion):
              (WebCore::CSSParser::parseDashboardRegions):
              (WebCore::ShadowParseContext::commitValue):
              (WebCore::ShadowParseContext::commitLength):
              (WebCore::ShadowParseContext::commitColor):
              (WebCore::BorderImageParseContext::commitNumber):
              (WebCore::BorderImageParseContext::commitWidth):
              (WebCore::BorderImageParseContext::commitRule):
              (WebCore::BorderImageParseContext::commitBorderImage):
              (WebCore::CSSParser::lex):
              (WebCore::CSSParser::text):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * css/MediaList.cpp:
              (WebCore::MediaList::deleteMedium):
              * css/MediaQuery.h:
              * css/MediaQueryEvaluator.cpp:
              (WebCore::parseAspectRatio):
              * css/MediaQueryEvaluator.h:
              * css/MediaQueryExp.h:
              (WebCore::MediaQueryExp::operator==):
              * css/WebKitCSSMatrix.h:
              * dom/Comment.h:
              * dom/Document.cpp:
              (WebCore::Document::setFocusedNode):
              * dom/Document.h:
              (WebCore::Document::setHasDashboardRegions):
              * dom/DocumentFragment.cpp:
              (WebCore::DocumentFragment::nodeName):
              * dom/DocumentFragment.h:
              * dom/DynamicNodeList.h:
              * dom/EditingText.h:
              * dom/Element.cpp:
              (WebCore::Element::dispatchAttrAdditionEvent):
              * dom/NamedAttrMap.cpp:
              (WebCore::NamedNodeMap::item):
              * dom/Node.cpp:
              (WebCore::Node::nodeValue):
              (WebCore::Node::nodeIndex):
              * dom/NodeRareData.h:
              (WebCore::NodeListsNodeData::create):
              * dom/Notation.h:
              * dom/ProcessingInstruction.h:
              * dom/Range.cpp:
              (WebCore::Range::processContents):
              * dom/StyledElement.cpp:
              (WebCore::toHex):
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback):
              (WebCore::PendingCallbacks::PendingStartElementNSCallback::call):
              (WebCore::PendingCallbacks::):
              (WebCore::OffsetBuffer::readOutBytes):
              (WebCore::handleElementNamespaces):
              (WebCore::handleElementAttributes):
              (WebCore::attributesStartElementNsHandler):
              * dom/XMLTokenizerQt.cpp:
              (WebCore::attributesStartElementNsHandler):
              (WebCore::XMLTokenizer::parseStartElement):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyInlineStyle):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::removeNode):
              * editing/Editor.cpp:
              (WebCore::Editor::pasteAsPlainText):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::directionOfEnclosingBlock):
              * editing/SmartReplaceICU.cpp:
              (WebCore::addAllCodePoints):
              * history/HistoryItem.cpp:
              (WebCore::HistoryItem::icon):
              (WebCore::HistoryItem::adoptVisitCounts):
              * html/CanvasStyle.cpp:
              (WebCore::CanvasStyle::applyFillColor):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::setActive):
              (WebCore::HTMLAnchorElement::isLiveLink):
              * html/HTMLAppletElement.h:
              * html/HTMLAudioElement.h:
              * html/HTMLBRElement.h:
              * html/HTMLBaseElement.h:
              * html/HTMLBaseFontElement.h:
              * html/HTMLDListElement.h:
              * html/HTMLDirectoryElement.h:
              * html/HTMLFieldSetElement.cpp:
              (WebCore::HTMLFieldSetElement::HTMLFieldSetElement):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::reset):
              * html/HTMLHRElement.cpp:
              (WebCore::HTMLHRElement::parseMappedAttribute):
              * html/HTMLHeadElement.h:
              * html/HTMLHtmlElement.h:
              * html/HTMLImageElement.h:
              (WebCore::HTMLImageElement::setLoadManually):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::selection):
              * html/HTMLIsIndexElement.h:
              * html/HTMLMarqueeElement.cpp:
              * html/HTMLMediaElement.h:
              (WebCore::HTMLMediaElement::):
              * html/HTMLMenuElement.h:
              * html/HTMLMetaElement.h:
              * html/HTMLModElement.h:
              * html/HTMLOListElement.h:
              * html/HTMLOptionElement.cpp:
              (WebCore::HTMLOptionElement::childrenChanged):
              * html/HTMLParamElement.h:
              * html/HTMLQuoteElement.h:
              * html/HTMLStyleElement.h:
              * html/HTMLTableCaptionElement.h:
              * html/HTMLTableCellElement.h:
              * html/HTMLTableColElement.h:
              * html/HTMLTableSectionElement.cpp:
              (WebCore::HTMLTableSectionElement::deleteRow):
              * html/HTMLTitleElement.h:
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseNonHTMLText):
              (WebCore::HTMLTokenizer::parseEntity):
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::write):
              * html/HTMLUListElement.h:
              * html/HTMLVideoElement.h:
              * html/TimeRanges.h:
              (WebCore::TimeRanges::Range::Range):
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::enableResourceTracking):
              (WebCore::InspectorController::disableResourceTracking):
              * inspector/InspectorFrontend.cpp:
              (WebCore::InspectorFrontend::newInspectorJSONObject):
              * page/Console.cpp:
              (WebCore::Console::addMessage):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::defaultKeyboardEventHandler):
              * page/Frame.cpp:
              (WebCore::Frame::jsDefaultStatusBarText):
              * page/android/DragControllerAndroid.cpp:
              (WebCore::DragController::dragOperation):
              * page/android/EventHandlerAndroid.cpp:
              (WebCore::EventHandler::tabsToAllControls):
              (WebCore::EventHandler::eventActivatedView):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
              * page/gtk/DragControllerGtk.cpp:
              (WebCore::DragController::dragOperation):
              * page/qt/DragControllerQt.cpp:
              * page/win/DragControllerWin.cpp:
              (WebCore::DragController::isCopyKeyDown):
              * page/win/FrameWin.h:
              * rendering/RenderSlider.cpp:
              (WebCore::RenderSlider::mouseEventOffsetToThumb):
              * rendering/style/RenderStyle.h:
              (WebCore::InheritedFlags::setVerticalAlignLength):
              (WebCore::InheritedFlags::setUnicodeBidi):
              (WebCore::InheritedFlags::setCursor):
              * rendering/style/RenderStyleConstants.h:
              (WebCore::):
              * rendering/style/SVGRenderStyleDefs.h:
              * rendering/style/StyleInheritedData.h:
              (WebCore::StyleInheritedData::operator!=):
              * storage/DatabaseTask.h:
              * svg/GradientAttributes.h:
              * svg/LinearGradientAttributes.h:
              * svg/PatternAttributes.h:
              * svg/RadialGradientAttributes.h:
              * svg/SVGAnimatedPathData.h:
              * svg/SVGAnimatedPoints.h:
              * svg/SVGAnimationElement.h:
              * svg/SVGClipPathElement.h:
              * svg/SVGElementInstance.h:
              * svg/SVGFEBlendElement.cpp:
              (WebCore::SVGFEBlendElement::build):
              * svg/SVGFEBlendElement.h:
              * svg/SVGFEColorMatrixElement.cpp:
              (WebCore::SVGFEColorMatrixElement::build):
              * svg/SVGFEComponentTransferElement.cpp:
              (WebCore::SVGFEComponentTransferElement::build):
              * svg/SVGFECompositeElement.cpp:
              (WebCore::SVGFECompositeElement::build):
              * svg/SVGFEDiffuseLightingElement.cpp:
              (WebCore::SVGFEDiffuseLightingElement::build):
              * svg/SVGFEDisplacementMapElement.cpp:
              (WebCore::SVGFEDisplacementMapElement::build):
              * svg/SVGFEDistantLightElement.h:
              * svg/SVGFEFloodElement.cpp:
              (WebCore::SVGFEFloodElement::build):
              * svg/SVGFEFloodElement.h:
              * svg/SVGFEFuncAElement.h:
              * svg/SVGFEFuncBElement.h:
              * svg/SVGFEFuncGElement.h:
              * svg/SVGFEFuncRElement.h:
              * svg/SVGFEGaussianBlurElement.cpp:
              (WebCore::SVGFEGaussianBlurElement::build):
              * svg/SVGFEImageElement.cpp:
              (WebCore::SVGFEImageElement::build):
              * svg/SVGFEMergeElement.cpp:
              (WebCore::SVGFEMergeElement::build):
              * svg/SVGFEOffsetElement.cpp:
              (WebCore::SVGFEOffsetElement::build):
              * svg/SVGFEPointLightElement.h:
              * svg/SVGFESpecularLightingElement.cpp:
              (WebCore::SVGFESpecularLightingElement::build):
              * svg/SVGFESpotLightElement.h:
              * svg/SVGFETileElement.cpp:
              (WebCore::SVGFETileElement::build):
              * svg/SVGLineElement.cpp:
              (WebCore::SVGLineElement::parseMappedAttribute):
              * svg/SVGList.h:
              * svg/SVGListTraits.h:
              (WebCore::):
              * svg/SVGMPathElement.h:
              * svg/SVGMetadataElement.h:
              * svg/SVGParserUtilities.cpp:
              (WebCore::SVGPathParser::parseSVG):
              (WebCore::SVGPathParser::calculateArc):
              * svg/SVGPathElement.h:
              * svg/SVGPathSegClosePath.h:
              * svg/SVGSVGElement.h:
              * svg/SVGSetElement.h:
              * svg/SVGSwitchElement.h:
              * svg/SVGTextPathElement.cpp:
              (WebCore::SVGTextPathElement::parseMappedAttribute):
              * svg/SVGTextPathElement.h:
              * svg/SVGTitleElement.h:
              * svg/SVGTransformable.cpp:
              (WebCore::):
              * svg/SVGViewSpec.cpp:
              (WebCore::):
              * svg/animation/SMILTime.cpp:
              (WebCore::operator+):
              (WebCore::operator-):
              (WebCore::operator*):
              * svg/animation/SVGSMILElement.h:
              * svg/graphics/SVGResource.cpp:
              (WebCore::clientMap):
              * wml/WMLPostfieldElement.cpp:
              (WebCore::WMLPostfieldElement::value):
              * wml/WMLSetvarElement.cpp:
              (WebCore::WMLSetvarElement::value):
              * workers/WorkerRunLoop.cpp:
              * xml/XMLHttpRequest.cpp:
              (WebCore::XMLHttpRequest::dropProtection):
              * xml/XPathPath.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45747 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c4dacca
  3. 06 Jul, 2009 1 commit
    • andersca@apple.com's avatar
      WebCore: · e460e1ac
      andersca@apple.com authored
      2009-07-06  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adele Peterson.
      
              Add the ability for wheel events to latch to a node.
              
              * WebCore.base.exp:
              * page/EventHandler.cpp:
              (WebCore::EventHandler::EventHandler):
              (WebCore::EventHandler::clear):
              (WebCore::EventHandler::handleWheelEvent):
              * page/EventHandler.h:
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::wheelEvent):
              * platform/mac/WebCoreSystemInterface.h:
              * platform/mac/WebCoreSystemInterface.mm:
      
      WebKit/mac:
      
      2009-07-06  Anders Carlsson  <andersca@apple.com>
      
              Reviewed by Adele Peterson.
      
              Initialize wkIsLatchingWheelEvent.
              
              * WebCoreSupport/WebSystemInterface.m:
              (InitWebCoreSystemInterface):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e460e1ac
  4. 02 Jul, 2009 2 commits
    • eric@webkit.org's avatar
      2009-07-02 Erik Arvidsson <arv@chromium.org> · ceaebf3a
      eric@webkit.org authored
              Reviewed by Adam Roben.
      
              [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
              https://bugs.webkit.org/show_bug.cgi?id=26699
      
              * manual-tests/drag-escape.html: Added.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dragSourceEndedAt):
      
      2009-07-02  Erik Arvidsson  <arv@chromium.org>
      
              Reviewed by Adam Roben.
      
              [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
              https://bugs.webkit.org/show_bug.cgi?id=26699
      
              * WebDropSource.cpp:
              (WebDropSource::QueryContinueDrag):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ceaebf3a
    • hyatt@apple.com's avatar
      WebCore: · b327f5d3
      hyatt@apple.com authored
      2009-07-02  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Simon Fraser.
      
              Fix for bug 22119, clicks in the scrollbars of transformed content don't work.  Add new
              conversion methods for going across parent/child widget boundaries that can be implemented
              by the FrameView and ScrollbarClient to be transform-aware.
      
              Test cases added in platform/mac/fast/forms and platform/mac/fast/overflow.
      
              * WebCore.base.exp:
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMouseMoveEvent):
              * page/FrameView.cpp:
              (WebCore::FrameView::convertFromScrollbarToContainingView):
              (WebCore::FrameView::convertFromContainingViewToScrollbar):
              (WebCore::FrameView::convertFromRenderer):
              (WebCore::FrameView::convertToRenderer):
              (WebCore::FrameView::convertToContainingView):
              (WebCore::FrameView::convertFromContainingView):
              * page/FrameView.h:
              * platform/ScrollView.h:
              * platform/Scrollbar.cpp:
              (WebCore::Scrollbar::convertToContainingView):
              (WebCore::Scrollbar::convertFromContainingView):
              * platform/Scrollbar.h:
              * platform/ScrollbarClient.h:
              (WebCore::ScrollbarClient::convertFromScrollbarToContainingView):
              (WebCore::ScrollbarClient::convertFromContainingViewToScrollbar):
              * platform/Widget.cpp:
              (WebCore::Widget::convertFromContainingWindow):
              (WebCore::Widget::convertToContainingWindow):
              (WebCore::Widget::convertFromRootToContainingWindow):
              (WebCore::Widget::convertFromContainingWindowToRoot):
              (WebCore::Widget::convertToContainingView):
              (WebCore::Widget::convertFromContainingView):
              * platform/Widget.h:
              * platform/graphics/IntPoint.h:
              (WebCore::IntPoint::move):
              * platform/mac/WidgetMac.mm:
              (WebCore::Widget::convertFromRootToContainingWindow):
              (WebCore::Widget::convertFromContainingWindowToRoot):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::isPointInOverflowControl):
              * rendering/RenderDataGrid.cpp:
              (WebCore::RenderDataGrid::convertFromScrollbarToContainingView):
              (WebCore::RenderDataGrid::convertFromContainingViewToScrollbar):
              * rendering/RenderDataGrid.h:
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::convertFromScrollbarToContainingView):
              (WebCore::RenderLayer::convertFromContainingViewToScrollbar):
              (WebCore::RenderLayer::scrollbarOffset):
              (WebCore::RenderLayer::hitTestOverflowControls):
              * rendering/RenderLayer.h:
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::isPointInOverflowControl):
              (WebCore::RenderListBox::convertFromScrollbarToContainingView):
              (WebCore::RenderListBox::convertFromContainingViewToScrollbar):
              * rendering/RenderListBox.h:
      
      LayoutTests:
      
      2009-07-02  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Simon Fraser.
      
              Test cases for bug 22119, clicks in scrollbar of transformed element don't work.
      
              * platform/mac/fast/forms/listbox-scrollbar-hit-test-expected.txt: Added.
              * platform/mac/fast/forms/listbox-scrollbar-hit-test.html: Added.
              * platform/mac/fast/overflow/overflow-scrollbar-hit-test-expected.txt: Added.
              * platform/mac/fast/overflow/overflow-scrollbar-hit-test.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b327f5d3
  5. 30 Jun, 2009 1 commit
    • bweinstein@apple.com's avatar
      2009-06-30 Brian Weinstein <bweinstein@apple.com> · 817c602f
      bweinstein@apple.com authored
              Reviewed by Adam Roben.
      
              Renamed scrollbarUnderPoint to scrollbarAtPoint.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::hitTestResultAtPoint):
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseMoveEvent):
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::scrollbarAtPoint):
              * platform/ScrollView.h:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupListBox::handleMouseDownEvent):
              (WebCore::PopupListBox::handleMouseMoveEvent):
      
      2009-06-30  Brian Weinstein  <bweinstein@apple.com>
      
              Reviewed by Adam Roben.
              
              Renamed scrollbarUnderPoint to scrollbarAtPoint to follow conventions.
      
              * Api/qwebpage.cpp:
              (QWebPage::swallowContextMenuEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45384 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      817c602f
  6. 26 Jun, 2009 3 commits
    • bweinstein@apple.com's avatar
      2009-06-26 Brian Weinstein <bweinstein@apple.com> · c06336f8
      bweinstein@apple.com authored
              Reviewed by Simon Fraser.
              
              Changed call of scrollbarUnderMouse to scrollbarUnderPoint to match new API.
      
              * Api/qwebpage.cpp:
              (QWebPage::swallowContextMenuEvent):
      
      2009-06-26  Brian Weinstein  <bweinstein@apple.com>
      
              Reviewed by Simon Fraser.
      
              https://bugs.webkit.org/show_bug.cgi?id=26695
      
              Added hit testing on scrollbars, so if you start a gesture over a scrollbar,
              it isn't counted, and lets the user drag the scrollbar itself instead of a
              panning gesture. Also cleaned up code in gesture.
      
              * WebView.cpp:
              (WebView::gestureNotify):
              (WebView::gesture):
      
      
      2009-06-26  Brian Weinstein  <bweinstein@apple.com>
      
              Reviewed by Simon Fraser.
      
              https://bugs.webkit.org/show_bug.cgi?id=26695
              
              Added the ability to do scrollbar hit testing in EventHandler, changed the
              signature of a PlatformWheelEvent constructor, and changed scrollbarUnderMouse
              to scrollbarUnderPoint, and updated all calls to that function.        
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::hitTestResultAtPoint):
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseMoveEvent):
              * page/EventHandler.h:
              (WebCore::):
              * platform/PlatformWheelEvent.h:
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::scrollbarUnderPoint):
              * platform/ScrollView.h:
              * platform/chromium/PopupMenuChromium.cpp:
              (WebCore::PopupListBox::handleMouseDownEvent):
              (WebCore::PopupListBox::handleMouseMoveEvent):
              * platform/win/WheelEventWin.cpp:
              (WebCore::PlatformWheelEvent::PlatformWheelEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45304 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c06336f8
    • jberlin@apple.com's avatar
      2009-06-26 Jessie Berlin <jberlin@apple.com> · 97739b5c
      jberlin@apple.com authored
              Fix: https://bugs.webkit.org/show_bug.cgi?id=26723
              Where the m_mouseDown event was never being set on windows, so the
              client X and Y coordinates were always being reported as zero in a
              dragstart handler.
              
              Reviewed by Mark Rowe.
      
              Test: editing/selection/drag-start-event-client-x-y.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent):
              Set the m_mouseDown event when the mouse press is handled.
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::mouseDown):
              Removed now redundant setting of m_mouseDown.
              
              Layout test for making sure the client X Y coordinates of the event
              in a dragstart handler are correct.
              
              https://bugs.webkit.org/show_bug.cgi?id=26723
      
              * editing/selection/drag-start-event-client-x-y-expected.txt: Added.
              * editing/selection/drag-start-event-client-x-y.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45278 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97739b5c
    • eric@webkit.org's avatar
      2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com> · cf9680e8
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Bug 20303: [Qt] Key events are not working in frames.
      
              Add a layout test to test the event is sent to the right sub-frame.
      
              * platform/qt/fast/events/event-sender-keydown-frame-expected.txt: Added.
              * platform/qt/fast/events/event-sender-keydown-frame.html: Added.
      
      2009-06-26  Yongjun Zhang  <yongjun.zhang@nokia.com>
      
              Reviewed by Eric Seidel.
      
              Test: platform/qt/fast/events/event-sender-keydown-frame.html
      
              Bug 20303: [Qt] Key events are not working in frames.
      
              Merge scrolling handling code in qt and win port, move it to
              EventHandler.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::scrollRecursively):
              * page/EventHandler.h:
      
      2009-06-26  Yongjun Zhang  <yongjun.zhang@nokia.com>
      
              Reviewed by Eric Seidel.
      
              Bug 20303: [Qt] Key events are not working in frames.
      
              Send scrolling events to current focused frame, bubble the event
              up to parent frame if it is not handled.  Use EventHandler's new
              shared scrolling code.
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::keyPressEvent):
              (QWebPagePrivate::handleScrolling):
              * Api/qwebpage_p.h:
      
      2009-06-26  Yongjun Zhang  <yongjun.zhang@nokia.com>
      
              Reviewed by Eric Seidel.
      
              Bug 20303: [Qt] Key events are not working in frames.
      
              Move the scroll handling code to EventHandler so that other
              ports can share the functionality.
      
              * WebView.cpp:
              (WebView::keyDown):
              (EnumTextMatches::QueryInterface):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@45257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf9680e8
  7. 12 Jun, 2009 1 commit
    • jberlin@apple.com's avatar
      Index: WebCore/ChangeLog · 50b7aa71
      jberlin@apple.com authored
      ===================================================================
      --- WebCore/ChangeLog	(revision 44622)
      +++ WebCore/ChangeLog	(working copy)
      @@ -1,3 +1,23 @@
      +2009-06-12  Jessie Berlin  <jberlin@apple.com>
      +
      +        Reviewed by Mark Rowe.
      +
      +        https://bugs.webkit.org/show_bug.cgi?id=24792
      +        rdar://problem/6933055
      +
      +        Changes the radius in which cursor movement around the 4 arrow icon
      +        while pan-scrolling does not cause scrolling from around 10 pixels to
      +        15 pixels, similar to what is found in IE and Firefox.
      +
      +        * page/EventHandler.cpp:
      +        (WebCore::EventHandler::setPanScrollCursor):
      +        Factor out the no-pan-scroll radius.
      +        * platform/ScrollView.h:
      +        Create a constant for the no-pan-scroll radius.
      +        * rendering/RenderLayer.cpp:
      +        (WebCore::RenderLayer::panScrollFromPoint):
      +        Factor out the no-pan-scroll radius.
      +
       2009-06-12  Xan Lopez  <xlopez@igalia.com>
       
               Reviewed by Gustavo Noronha.
      Index: WebCore/page/EventHandler.cpp
      ===================================================================
      --- WebCore/page/EventHandler.cpp	(revision 44622)
      +++ WebCore/page/EventHandler.cpp	(working copy)
      @@ -661,11 +661,10 @@ void EventHandler::setPanScrollCursor()
       
           // At the original click location we draw a 4 arrowed icon. Over this icon there won't be any scroll
           // So we don't want to change the cursor over this area
      -    const int noScrollRadius = 9;
      -    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - noScrollRadius);
      -    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + noScrollRadius);
      -    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + noScrollRadius);
      -    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - noScrollRadius);
      +    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - ScrollView::noPanScrollRadius);
      +    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + ScrollView::noPanScrollRadius);
      +    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + ScrollView::noPanScrollRadius);
      +    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - ScrollView::noPanScrollRadius);
                
           if (north) {
               if (east)
      Index: WebCore/platform/ScrollView.h
      ===================================================================
      --- WebCore/platform/ScrollView.h	(revision 44622)
      +++ WebCore/platform/ScrollView.h	(working copy)
      @@ -214,7 +214,8 @@ public:
           virtual void hide();
           virtual void setParentVisible(bool);
           
      -    // Pan scrolling methods.
      +    // Pan scrolling.
      +    static const int noPanScrollRadius = 15;
           void addPanScrollIcon(const IntPoint&);
           void removePanScrollIcon();
       
      Index: WebCore/rendering/RenderLayer.cpp
      ===================================================================
      --- WebCore/rendering/RenderLayer.cpp	(revision 44622)
      +++ WebCore/rendering/RenderLayer.cpp	(working copy)
      @@ -948,7 +948,6 @@ void RenderLayer::panScrollFromPoint(con
           const int shortDistanceLimit = 100;  // We delimit a 200 pixels long square enclosing the original point
           const int speedReducer = 2;          // Within this square we divide the scrolling speed by 2
           
      -    const int iconRadius = 10;
           Frame* frame = renderer()->document()->frame();
           if (!frame)
               return;
      @@ -965,9 +964,9 @@ void RenderLayer::panScrollFromPoint(con
           int xDelta = currentMousePosition.x() - sourcePoint.x();
           int yDelta = currentMousePosition.y() - sourcePoint.y();
       
      -    if (abs(xDelta) < iconRadius) // at the center we let the space for the icon
      +    if (abs(xDelta) < ScrollView::noPanScrollRadius) // at the center we let the space for the icon
               xDelta = 0;
      -    if (abs(yDelta) < iconRadius)
      +    if (abs(yDelta) < ScrollView::noPanScrollRadius)
               yDelta = 0;
       
           // Let's attenuate the speed for the short distances
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50b7aa71
  8. 02 Jun, 2009 3 commits
    • darin@apple.com's avatar
      WebCore: · bd433bc4
      darin@apple.com authored
      2009-06-02  Darin Adler  <darin@apple.com>
      
              Reviewed by David Hyatt.
      
              Bug 26112: viewless WebKit -- make events work
              https://bugs.webkit.org/show_bug.cgi?id=26112
      
              The main fix here is to make mouse and wheel event coordinates in the coordinate
              system of the top level NSView rather than the NSWindow when in the viewless mode.
              This is the design Hyatt chose, but the event part of it wasn't done yet.
      
              Also fix FrameView to do normal reference counting instead of a strange model with
              an explicit deref near creation time.
      
              * WebCore.base.exp: Updated.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::eventLoopHandleMouseUp): Moved this function into the file
              to reduce conditionals in the header.
              (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.
      
              * page/EventHandler.h: Reduced includes. Fixed formatting of Objective-C types.
              Made currentNSEvent a static member function. Added sendContextMenuEvent and
              eventMayStartDrag functions that takes NSEvent * so the conversion to PlatformMouseEvent
              can be done here rather than in WebKit. Reduced #if by making eventLoopHandleMouseUp and
              eventLoopHandleMouseDragged unconditional.
      
              * page/Frame.cpp:
              (WebCore::Frame::setView): Made this take a PassRefPtr since it takes ownership.
              (WebCore::Frame::createView): Changed to use RefPtr and FrameView::create and remove
              the explicit deref.
      
              * page/Frame.h: Changed setView to take a PassRefPtr.
      
              * page/FrameTree.cpp: Added newly-needed include.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::FrameView): Got rid of one of the two constructors, and removed
              the initialization of m_refCount and call to show from the reamining one.
              (WebCore::FrameView::create): Added two create functions that do what the two
              constructors did before, except that they return a PassRefPtr to make sure the
              reference counting is handled correctly.
              (WebCore::FrameView::~FrameView): Removed assertion from when FrameView implemented
              its own reference counting.
      
              * page/FrameView.h: Inherit from RefCounted for reference counting. Made the
              constructor private and added create functions. Got rid of the hand-implemented
              reference counting in this class.
      
              * page/mac/EventHandlerMac.mm:
              (WebCore::currentNSEventSlot): Renamed currentEvent to currentNSEventSlot to
              make it more clear how it relates to currentNSEvent.
              (WebCore::EventHandler::currentNSEvent): Updated.
              (WebCore::CurrentEventScope::CurrentEventScope): Added. Use to set/reset the
              current event in a foolproof way.
              (WebCore::CurrentEventScope::~CurrentEventScope): Ditto.
              (WebCore::EventHandler::wheelEvent): Use CurrentEventScope. Pass the platform
              window in when constructing the PlatformWheelEvent.
              (WebCore::EventHandler::keyEvent): Use CurrentEventScope.
              (WebCore::lastEventIsMouseUp): Use currentNSEvent.
              (WebCore::EventHandler::passMouseDownEventToWidget): Ditto.
              (WebCore::EventHandler::eventLoopHandleMouseDragged): Ditto.
              (WebCore::EventHandler::eventLoopHandleMouseUp): Ditto.
              (WebCore::EventHandler::passSubframeEventToSubframe): Use
              currentPlatformMouseEvent to get a mouse event that has the appropriate
              platform window passed to create it.
              (WebCore::EventHandler::passWheelEventToWidget): Ditto.
              (WebCore::EventHandler::mouseDown): Ditto.
              (WebCore::EventHandler::mouseDragged): Ditto.
              (WebCore::EventHandler::mouseUp): Ditto.
              (WebCore::EventHandler::mouseMoved): Ditto.
              (WebCore::EventHandler::currentPlatformMouseEvent): Added. Passes the
              platform window that's now needed to create a PlatformMouseEvent.
              (WebCore::EventHandler::sendContextMenuEvent): Added.
              (WebCore::EventHandler::eventMayStartDrag): Added.
      
              * platform/HostWindow.h: Removed unneeded includes and constructor definition.
      
              * platform/PlatformMouseEvent.h: Sorted things in alphabetical order.
              Changed Mac constructor to take a windowView as well as the event. This is
              needed in viewless mode, since the "window" is actually an NSView, so the
              event has to know which view to compute the coordinates with. Made the
              same change to pointForEvent.
              * platform/PlatformWheelEvent.h: Ditto.
      
              * platform/mac/PlatformMouseEventMac.mm:
              (WebCore::pointForEvent): Convert point from window coordinates to view
              coordinates if a windowView is passed in. This is used in viewless mode.
              (WebCore::PlatformMouseEvent::PlatformMouseEvent): Ditto.
              * platform/mac/WheelEventMac.mm:
              (WebCore::PlatformWheelEvent::PlatformWheelEvent): Ditto.
      
              * platform/mac/WidgetMac.mm:
              (WebCore::Widget::convertFromContainingWindow): Fixed case where there
              is no platform widget and no parent. Before it would yield unpredictable
              results because of dispatching to a nil object and returning a structure.
              Now it returns the point without changing coordinates at all, which is what
              we need for this case in viewless mode.
      
              * rendering/RenderApplet.cpp: Removed unneeded includes.
              (WebCore::RenderApplet::intrinsicSize): Use widget function.
              (WebCore::RenderApplet::createWidgetIfNecessary): Ditto.
      
              * rendering/RenderApplet.h: Make more things private. Get rid of unneeded
              explicit destructor.
      
              * rendering/RenderFrame.cpp: Removed unneeded includes.
              (WebCore::RenderFrame::edgeInfo): Updated to use node function so header
              doesn't have to define element function.
              (WebCore::RenderFrame::viewCleared): Ditto. Also changed to use widget
              function.
      
              * rendering/RenderFrame.h: Removed unneeded includes. Made some things
              private. Got rid of element function.
      
              * rendering/RenderPart.cpp: Removed unneeded includes.
              (WebCore::RenderPart::~RenderPart): Changed to use clearWidget function.
              (WebCore::RenderPart::setWidget): Changed to use widget function.
              (WebCore::RenderPart::deleteWidget): Changed to use passed-in widget.
              This is now only called by the clearWidget function.
      
              * rendering/RenderPart.h: Removed unneeded forward declarations.
              Made more functions private. Updated deleteWidget to take widget argument.
      
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::~RenderPartObject): use frameView function
              instead of getting at m_view directly.
              (WebCore::RenderPartObject::updateWidget): Ditto.
              (WebCore::RenderPartObject::layout): Ditto. Same for widget and m_widget.
              (WebCore::RenderPartObject::viewCleared): Ditto.
      
              * rendering/RenderPartObject.h: Made some functions private.
      
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::RenderWidget): Initialize m_frameView with
              construction syntax instead of assignment.
              (WebCore::RenderWidget::destroy): Updated for name change of m_view
              to m_frameView.
              (WebCore::RenderWidget::~RenderWidget): Use clearWidget to delete
              the widget.
              (WebCore::RenderWidget::setWidget): Use clearWidget.
              (WebCore::RenderWidget::paint): Updated for name change of m_view
              to m_frameView.
              (WebCore::RenderWidget::deleteWidget): Changed to use passed-in widget.
      
              * rendering/RenderWidget.h: Made many functions protected, others
              private and made all data members private.
      
              * svg/animation/SMILTime.h: Removed unhelpful max and min functions. These
              just do what std::max and std::min will already do automatically for this
              type, so they are not helpful.
      
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::SVGImage): Removed unneeded initial values for types
              that initialize to zero without anything explicit.
              (WebCore::SVGImage::~SVGImage): Update since m_frame and m_frameView are
              no longer stored.
              (WebCore::SVGImage::setContainerSize): Ditto.
              (WebCore::SVGImage::usesContainerSize): Ditto.
              (WebCore::SVGImage::size): Ditto.
              (WebCore::SVGImage::hasRelativeWidth): Ditto.
              (WebCore::SVGImage::hasRelativeHeight): Ditto.
              (WebCore::SVGImage::draw): Ditto.
              (WebCore::SVGImage::nativeImageForCurrentFrame): Ditto.
              (WebCore::SVGImage::dataChanged): Ditto.
      
              * svg/graphics/SVGImage.h: Removed unneeded includes and unneeded data
              members m_document, m_frame, m_frameView, and m_minSize.
      
      WebKit/mac:
      
      2009-06-02  Darin Adler  <darin@apple.com>
      
              Reviewed by David Hyatt.
      
              Bug 26112: viewless WebKit -- make events work
              https://bugs.webkit.org/show_bug.cgi?id=26112
      
              One change here is to make the -[WebFrame frameView] function assert if ever called
              in viewless mode, and fix many callers that would trip that assertion.
      
              A major change is to put some methods and data in WebView that are currently in
              WebHTMLView, used only in viewless mode. A next step will be to use the WebView
              methods whenever possible, even when not in the viewless mode.
      
              Also fix FrameView to do normal reference counting instead of a strange model with
              an explicit deref near creation time.
      
              * WebCoreSupport/WebChromeClient.mm:
              (WebChromeClient::scrollRectIntoView): Add code to start in the appropriate place
              when dealing with viewless mode. This gets triggered when visiting the Google home page.
              (WebChromeClient::setToolTip): Changed to call WebView instead of WebHTMLView.
              (WebChromeClient::print): Changed to use a new selector that doesn't require a
              WebFrameView if present. Also don't even try to use the old selector in viewless mode.
      
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::respondToChangedSelection): Changed to call WebView instead of WebHTMLView.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::transitionToCommittedForNewPage): Added more code paths for
              viewless mode to skip things we can't do in that mode, with appropriate FIXME.
              Use Frame::create and RefPtr and eliminate the strange reference counting of FrameView.
      
              * WebView/WebDataSource.mm:
              (-[WebDataSource _receivedData:]): Added a _usesDocumentViews guard around code that's
              specific to document views.
      
              * WebView/WebFrame.mm:
              (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]): Added a _usesDocumentViews
              guard around code that's specific to document views.
              (-[WebFrame _hasSelection]): Added an implementation for viewless mode.
              (-[WebFrame _clearSelection]): Assert we're not in viewless mode; it doesn't really
              make sense to clear the selection in only one frame in viewless mode. Later we can
              decide what to do.
              (-[WebFrame _dragSourceMovedTo:]): Assert we're not in viewless mode; the dragging
              code for viewless mode shouldn't have to involve the WebFrame object at all.
              (-[WebFrame _dragSourceEndedAt:operation:]): Ditto.
              (-[WebFrame frameView]): Assert we're not in viewless mode. This assertion fires
              often, but it's a great pointer to code that needs to be changed.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView hitTest:]): Tweaked a comment.
              (-[WebHTMLView _updateMouseoverWithEvent:]): Fixed a bug where the fake event for
              moving the mouse out of the old view ended up overwriting the event for moving
              the mouse within the new view.
              (-[WebHTMLView mouseDown:]): Got rid of explicit conversion of event to
              PlatformMouseEvent in call to sendContextMenuEvent; that's no longer possible
              without passing another argument, and it's now handled in EventHandler.
      
              * WebView/WebTextCompletionController.h: Copied from WebKit/mac/WebView/WebHTMLView.mm.
              Removed everything except for the WebTextCompletionController class.
              * WebView/WebTextCompletionController.mm: Copied from WebKit/mac/WebView/WebHTMLView.mm.
              Ditto.
      
              * WebView/WebUIDelegatePrivate.h: Added webView:printFrame: method.
      
              * WebView/WebView.mm: Moved includes and fields in from WebHTMLView.
              (-[WebView _usesDocumentViews]): Updated for name change from useDocumentViews
              to usesDocumentViews.
              (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]): Ditto.
              (-[WebView drawSingleRect:]): Ditto.
              (-[WebView isFlipped]): Ditto.
              (-[WebView setFrameSize:]): Ditto. Also changed to use _mainCoreFrame method.
              (-[WebView _viewWillDrawInternal]): Ditto.
              (-[WebView viewWillDraw]): Ditto.
              (-[WebView drawRect:]): Ditto.
              (-[WebView _close]): Added code to nil out the lastMouseoverView global.
              (-[WebView _dashboardRegions]): Use _mainCoreFrame.
              (-[WebView setProhibitsMainFrameScrolling:]): Ditto.
              (-[WebView _setInViewSourceMode:]): Ditto.
              (-[WebView _inViewSourceMode]): Ditto.
              (-[WebView _attachScriptDebuggerToAllFrames]): Ditto.
              (-[WebView _detachScriptDebuggerFromAllFrames]): Ditto.
              (-[WebView textIteratorForRect:]): Ditto.
              (-[WebView _executeCoreCommandByName:value:]): Ditto.
              (-[WebView addWindowObserversForWindow:]): Ditto.
              (-[WebView removeWindowObservers]): Ditto.
              (-[WebView _updateFocusedAndActiveState]): Ditto.
              (-[WebView _updateFocusedAndActiveStateForFrame:]): Turned into a class method.
              Added code to handle the viewless case without calling frameView.
              (-[WebView _windowDidBecomeKey:]): Updated for name change from useDocumentViews
              to usesDocumentViews.
              (-[WebView _windowDidResignKey:]): Ditto.
              (-[WebView _windowWillOrderOnScreen:]): Ditto.
              (-[WebView mainFrame]): Tweaked.
              (-[WebView selectedFrame]): Added a conditional to avoid trying to get at the
              frame view in viewless case.
              (-[WebView _setZoomMultiplier:isTextOnly:]): Use _mainCoreFrame.
              (-[WebView setCustomTextEncodingName:]): Ditto.
              (-[WebView windowScriptObject]): Ditto.
              (-[WebView setHostWindow:]): Ditto. Also put some code that's needed only for
              document views inside _private->usesDocumentViews.
              (-[WebView _hitTest:dragTypes:]): Tweaked.
              (-[WebView acceptsFirstResponder]): Added case for viewless mode along with a
              FIXME, since it's not complete.
              (-[WebView becomeFirstResponder]): Ditto.
              (-[WebView _webcore_effectiveFirstResponder]): Put the body of this inside
              a usesDocumentView check, because we don't need the first responder forwarding
              in viewless mode.
              (-[WebView setNextKeyView:]): Ditto.
              (-[WebView mouseDown:]): Added. Copied from WebHTMLView. FIXME in here suggests
              that we make WebHTMLView share this one soon, which I think is practical.
              (-[WebView mouseUp:]): Ditto.
              (-[WebView setHoverFeedbackSuspended:]): Added a code path for viewless mode.
              (-[WebView shouldClose]): Use _mainCoreFrame.
              (-[WebView aeDescByEvaluatingJavaScriptFromString:]): Ditto.
              (-[WebView setEditable:]): Ditto.
              (-[WebView _frameViewAtWindowPoint:]): Added an assertion that we're not in
              viewless mode since this method makes no sense in that mode.
              (-[WebView _setMouseDownEvent:]): Added. Copied from WebHTMLView. I plan to
              eliminate the one in WebHTMLView soon.
              (-[WebView _cancelUpdateMouseoverTimer]): Ditto.
              (-[WebView _stopAutoscrollTimer]): Ditto.
              (+[WebView _updateMouseoverWithEvent:]): Ditto.
              (-[WebView _updateMouseoverWithFakeEvent]): Ditto.
              (-[WebView _setToolTip:]): Added. Calls through to the WebHTMLView version.
              (-[WebView _selectionChanged]): Ditto.
              (-[WebView _mainCoreFrame]): Added.
              (-[WebView _needsOneShotDrawingSynchronization]): Moved into the WebInternal
              category.
              (-[WebView _setNeedsOneShotDrawingSynchronization:]): Ditto.
              (-[WebView _startedAcceleratedCompositingForFrame:]): Ditto.
              (-[WebView _stoppedAcceleratedCompositingForFrame:]): Ditto.
              (viewUpdateRunLoopObserverCallBack): Ditto.
              (-[WebView _scheduleViewUpdate]): Ditto.
      
              * WebView/WebViewInternal.h: Made most of the file not compile at all when
              included from non-C++ source files, elminating some excess declarations and
              typedefs. Moved more methods into the real internal category. Added new
              methods _setMouseDownEvent, _cancelUpdateMouseoverTimer, _stopAutoscrollTimer,
              _updateMouseoverWithFakeEvent, _selectionChanged, and _setToolTip:.
      
      WebKit/wx:
      
      2009-06-02  Darin Adler  <darin@apple.com>
      
              Reviewed by David Hyatt.
      
              * WebKitSupport/FrameLoaderClientWx.cpp:
              (WebCore::FrameLoaderClientWx::transitionToCommittedForNewPage): Use FrameView::create
              and RefPtr instead of the old "crazy" reference counting.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44379 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd433bc4
    • pkasting@chromium.org's avatar
      Revert r44276. · fafa15d2
      pkasting@chromium.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44371 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fafa15d2
    • eric@webkit.org's avatar
      2009-06-02 Eric Seidel <eric@webkit.org> · 05d6e939
      eric@webkit.org authored
              Reviewed by Maciej Stachowiak.
      
              Remove Range::compareBoundaryPoints(Position, Position) per Darin's suggestion in bug 25056
              https://bugs.webkit.org/show_bug.cgi?id=25500
      
              Darin indicated the Range should deal only with primitive DOM node/offset
              pairs, and that Position (which is a more robust editing construct) should have
              its own comparison functions and that Range.h should not mention Position at all.
      
              Turns out that Position already has a comparePositions() function (which knows
              how to additionally handled positions in shadow trees).  So I've just changed
              all callers of compareBoundaryPoints(Position, Position) to use the existing
              comparePositions() function.  I've also added a comparePositions which takes
              VisiblePositions for convenience.
      
              * dom/Range.cpp:
              * dom/Range.h:
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::updateStartEnd):
              (WebCore::ApplyStyleCommand::applyBlockStyle):
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              (WebCore::ApplyStyleCommand::applyInlineStyle):
              (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::nodeFullySelected):
              (WebCore::ApplyStyleCommand::nodeFullyUnselected):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::deleteInsignificantText):
              (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
              (WebCore::CompositeEditCommand::moveParagraphs):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializeStartEnd):
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              (WebCore::DeleteSelectionCommand::mergeParagraphs):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::nodeWillBeRemoved):
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::toNormalizedRange):
              * editing/htmlediting.cpp:
              (WebCore::comparePositions):
              * editing/htmlediting.h:
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44367 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05d6e939
  9. 29 May, 2009 1 commit
  10. 11 May, 2009 1 commit
  11. 29 Apr, 2009 1 commit
    • eric@webkit.org's avatar
      Reviewed by Darin Adler. · 4e32ebc3
      eric@webkit.org authored
              Make m_offset private and change all callers to use deprecatedEditingOffset().
              https://bugs.webkit.org/show_bug.cgi?id=25472
      
              Per Darin's suggestion, this was just a simple search replace
              of .m_offset with .deprecatedEditingOffset().
      
              There was one change in InsertParagraphSeparatorCommand::doApply to use
              Position::moveToOffset(0) instead of .m_offset = 0;
      
              * dom/Position.cpp:
              (WebCore::Position::rendersInDifferentPosition):
              (WebCore::Position::leadingWhitespacePosition):
              * dom/Position.h:
              (WebCore::Position::deprecatedEditingOffset):
              (WebCore::Position::moveToOffset):
              (WebCore::operator==):
              * dom/PositionIterator.h:
              (WebCore::PositionIterator::PositionIterator):
              * dom/Range.cpp:
              (WebCore::Range::create):
              (WebCore::Range::compareBoundaryPoints):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::nodeFullySelected):
              (WebCore::ApplyStyleCommand::nodeFullyUnselected):
              (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
              (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
              (WebCore::ApplyStyleCommand::joinChildTextNodes):
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::insertNodeAt):
              (WebCore::CompositeEditCommand::positionOutsideTabSpan):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
              (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
              (WebCore::CompositeEditCommand::deleteInsignificantText):
              (WebCore::CompositeEditCommand::moveParagraphs):
              (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::updatePositionForNodeRemoval):
              (WebCore::updatePositionForTextRemoval):
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              (WebCore::DeleteSelectionCommand::fixupWhitespace):
              * editing/Editor.cpp:
              (WebCore::Editor::setComposition):
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::getCompositionSelection):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::performTrivialReplace):
              (WebCore::InsertTextCommand::input):
              (WebCore::InsertTextCommand::insertTab):
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::debugRenderer):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::rangeFromLocationAndLength):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::debugPosition):
              (WebCore::makeRange):
              (WebCore::setStart):
              (WebCore::setEnd):
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::toNormalizedRange):
              (WebCore::makeSearchRange):
              (WebCore::VisibleSelection::debugPosition):
              (WebCore::VisibleSelection::showTreeForThis):
              * editing/htmlediting.cpp:
              (WebCore::comparePositions):
              (WebCore::rangeCompliantEquivalent):
              * editing/visible_units.cpp:
              (WebCore::previousBoundary):
              (WebCore::nextBoundary):
              (WebCore::startPositionForLine):
              (WebCore::startOfLine):
              (WebCore::endPositionForLine):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              (WebCore::logicalStartPositionForLine):
              (WebCore::logicalEndPositionForLine):
              * page/AccessibilityObject.cpp:
              (WebCore::updateAXLineStartForVisiblePosition):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::anchorOffset):
              (WebCore::DOMSelection::focusOffset):
              (WebCore::DOMSelection::baseOffset):
              (WebCore::DOMSelection::extentOffset):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * page/Frame.cpp:
              (WebCore::Frame::selectionLayoutChanged):
              * page/mac/AccessibilityObjectWrapper.mm:
              (textMarkerForVisiblePosition):
              (visiblePositionForTextMarker):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::indexForVisiblePosition):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@43035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e32ebc3
  12. 28 Apr, 2009 1 commit
    • xan@webkit.org's avatar
      2009-04-28 Xan Lopez <xlopez@igalia.com> · 441078c9
      xan@webkit.org authored
              Reviewed by Justin Garcia.
      
              https://bugs.webkit.org/show_bug.cgi?id=16135
              [GTK] Support caret browsing
      
              Based on a patch by Alp Toker.
      
              Implement basic support for caret browsing, active only when the
              corresponding setting is enabled.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMouseReleaseEvent):
              * page/FocusController.cpp:
              (WebCore::FocusController::advanceFocus):
              (WebCore::clearSelectionIfNeeded):
              (WebCore::FocusController::setFocusedNode):
              * page/Frame.cpp:
              (WebCore::Frame::setFocusedNodeIfNeeded):
              (WebCore::Frame::setSelectionFromNone):
              (WebCore::Frame::respondToChangedSelection):
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h:
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintCaret):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      441078c9
  13. 21 Apr, 2009 1 commit
    • timothy@apple.com's avatar
      Change pending unload and beforeunload counts to store the listeners in a... · c9fbbab7
      timothy@apple.com authored
      Change pending unload and beforeunload counts to store the listeners in a single data structure that can be quickly iterated for dispatch.
      
      WebCore:
      
      2009-04-17  Timothy Hatcher  <timothy@apple.com>
      
              Change pending unload and beforeunload counts to store the listeners
              in a single data structure that can be quickly iterated for dispatch.
      
              <rdar://problem/6383352&6383379&6383940>
      
              Reviewed by Darin Adler.
      
              * WebCore.base.exp: Change what symbols are exported.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::stopLoading): Remove count updating code
              and move an if inside a block already checking m_frame->document().
              * page/Chrome.cpp: Remove disableSuddenTermination/enableSuddenTermination.
              * page/Chrome.h: Ditto.
              * page/ChromeClient.h: Ditto.
              * page/DOMWindow.cpp:
              (WebCore::pendingUnloadEventListenerMap): Create a static map.
              (WebCore::pendingBeforeUnloadEventListenerMap): Ditto.
              (WebCore::addPendingEventListener): Add the event listener to the map.
              (WebCore::removePendingEventListener): Remove the event listener from the map.
              (WebCore::removePendingEventListeners): Remove all listeners for the window.
              (WebCore::dispatchWindowEventToListeners): Dispatch the event to the given listeners.
              (WebCore::DOMWindow::dispatchAllPendingBeforeUnloadEvents): Send the beforeunload event.
              (WebCore::DOMWindow::pendingUnloadEventListeners): Return a count of pending listeners.
              (WebCore::DOMWindow::dispatchAllPendingUnloadEvents): Send the unload event.
              (WebCore::DOMWindow::~DOMWindow): Remove the window from both event listener maps.
              (WebCore::DOMWindow::addEventListener): Call addPendingEventListener when needed.
              (WebCore::DOMWindow::removeEventListener): Call removePendingEventListener when needed.
              (WebCore::DOMWindow::removeAllEventListeners): Call removePendingEventListeners.
              (WebCore::DOMWindow::removeInlineEventListenerForType): Call removePendingEventListener when needed.
              * page/DOMWindow.h:
              (WebCore::DOMWindow::frame): Changed to be const.
              * page/EventHandler.cpp:
              (WebCore::EventHandler::EventHandler): Remove count tracking code.
              * page/EventHandler.h: Ditto.
              * page/Page.cpp:
              (WebCore::Page::Page): Ditto.
              * page/Page.h: Ditto.
      
      WebKit/mac:
      
      2009-04-17  Timothy Hatcher  <timothy@apple.com>
      
              Change how sudden termination works with WebView teardown.
      
              <rdar://problem/6383352&6383379&6383940>
      
              Reviewed by Darin Adler.
      
              * WebCoreSupport/WebChromeClient.h: Remove disableSuddenTermination/enableSuddenTermination.
              * WebCoreSupport/WebChromeClient.mm: Ditto.
              * WebView/WebFrame.mm:
              (-[WebFrame _pendingFrameUnloadEventCount]): Ask the DOMWindow.
              * WebView/WebView.mm:
              (+[WebView canCloseAllWebViews]): Call DOMWindow::dispatchAllPendingBeforeUnloadEvents.
              (+[WebView closeAllWebViews]): Call DOMWindow::dispatchAllPendingUnloadEvents and
              call close on all the WebViews.
              (-[WebView _closeWithFastTeardown]): Remove code for unload event dispatch.
              (-[WebView _close]): Correct a comment.
              (+[WebView _applicationWillTerminate]): Call closeAllWebViews.
              * WebView/WebViewPrivate.h: Add canCloseAllWebViews and closeAllWebViews.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42725 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9fbbab7
  14. 17 Apr, 2009 1 commit
    • ggaren@apple.com's avatar
      2009-04-17 Geoffrey Garen <ggaren@apple.com> · 15903b14
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              More fix for https://bugs.webkit.org/show_bug.cgi?id=21260
              Unbounded memory growth when churning elements with anonymous event handler functions
              
              Some refactoring of "inline" event listeners.
              
              Renames:
                  dispatchEventForType => dispatchEvent
                  setWindowInlineEventListenerForTypeAndAttribute => setWindowInlineEventListener
                  removeInlineEventListenerForType => clearInlineEventListener
                  setInlineEventListenerForType => setInlineEventListener
                  inlineEventListenerForType => getInlineEventListener
      
              * bindings/js/JSLazyEventListener.cpp:
              (WebCore::eventParameterName):
              (WebCore::JSLazyEventListener::JSLazyEventListener):
              (WebCore::createInlineEventListener):
              * bindings/js/JSLazyEventListener.h: Added two helper functions for
              creating "inline" event listeners. These replace Document::createEventListener,
              and abstract the creation of JS event listeners for DOM attributes out
              of the DOM. Removed legacy JSProtectedEventListener constructor code for
              adding the event listener's function to a map, since lazy event listeners
              don't have functions at construction time.
      
              * dom/Document.cpp:
              (WebCore::Document::setFocusedNode):
              * dom/Document.h:
              (WebCore::Document::isSVGDocument):
              * dom/Element.cpp:
              (WebCore::Element::setWindowInlineEventListener):
              * dom/Element.h: Updated for renames. Nixed Document::createEventListener,
              mentioned above. Moved setWindowInlineEventListenerForTypeAndAttribute
              to Element, for simplicity.
      
              * dom/InputElement.cpp:
              (WebCore::InputElement::setValueFromRenderer):
              * dom/Node.cpp:
              (WebCore::Node::dispatchFocusEvent):
              (WebCore::Node::dispatchBlurEvent):
              (WebCore::Node::dispatchEvent):
              (WebCore::Node::clearInlineEventListener):
              (WebCore::Node::setInlineEventListener):
              (WebCore::Node::getInlineEventListener):
              (WebCore::Node::onabort):
              (WebCore::Node::setOnabort):
              (WebCore::Node::etc.):
              * dom/Node.h: Updated for renames.
              
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplacementFragment::ReplacementFragment): Updated for renames.
              
              Updated these files for renames, and to use the new createInlineEventListener
              helper function:
      
              * html/HTMLBodyElement.cpp:
              (WebCore::HTMLBodyElement::parseMappedAttribute):
              * html/HTMLButtonElement.cpp:
              (WebCore::HTMLButtonElement::parseMappedAttribute):
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::parseMappedAttribute):
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElement::onChange):
              * html/HTMLFormElement.cpp:
              (WebCore::HTMLFormElement::prepareSubmit):
              (WebCore::HTMLFormElement::reset):
              (WebCore::HTMLFormElement::parseMappedAttribute):
              * html/HTMLFrameElementBase.cpp:
              (WebCore::HTMLFrameElementBase::parseMappedAttribute):
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::parseMappedAttribute):
              * html/HTMLImageElement.cpp:
              (WebCore::HTMLImageElement::parseMappedAttribute):
              * html/HTMLImageLoader.cpp:
              (WebCore::HTMLImageLoader::dispatchLoadEvent):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute):
              (WebCore::HTMLInputElement::onSearch):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::loadInternal):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::parseMappedAttribute):
              * html/HTMLScriptElement.cpp:
              (WebCore::HTMLScriptElement::parseMappedAttribute):
              (WebCore::HTMLScriptElement::dispatchLoadEvent):
              (WebCore::HTMLScriptElement::dispatchErrorEvent):
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::parseMappedAttribute):
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::parseMappedAttribute):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::notifyFinished):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::mouseButtonListener):
              * page/DOMWindow.cpp:
              * page/DOMWindow.h:
              (WebCore::DOMWindow::eventListeners):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::canMouseDownStartSelect):
              (WebCore::EventHandler::canMouseDragExtendSelect):
              (WebCore::EventHandler::sendScrollEvent):
              * page/Page.cpp:
              (WebCore::networkStateChanged):
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::valueChanged):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::selectionChanged):
              * svg/SVGElement.cpp:
              (WebCore::SVGElement::parseMappedAttribute):
              * svg/SVGElementInstance.cpp:
              * svg/SVGImageLoader.cpp:
              (WebCore::SVGImageLoader::dispatchLoadEvent):
              * svg/SVGSVGElement.cpp:
              (WebCore::SVGSVGElement::parseMappedAttribute):
              * svg/SVGScriptElement.cpp:
              (WebCore::SVGScriptElement::dispatchErrorEvent):
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::defaultEventHandler):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15903b14
  15. 13 Apr, 2009 3 commits
  16. 09 Apr, 2009 1 commit
    • hyatt@apple.com's avatar
      2009-04-09 David Hyatt <hyatt@apple.com> · f6d72f34
      hyatt@apple.com authored
              Reviewed by Adam Roben
      
              Rename all of the changed()/setChanged()/setDocumentChanged() methods to mention style recalc
              explicitly instead.
      
              * bindings/js/JSCustomPositionCallback.cpp:
              (WebCore::JSCustomPositionCallback::handleEvent):
              * bindings/js/JSCustomPositionErrorCallback.cpp:
              (WebCore::JSCustomPositionErrorCallback::handleEvent):
              * bindings/js/JSCustomSQLStatementCallback.cpp:
              (WebCore::JSCustomSQLStatementCallback::handleEvent):
              * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
              (WebCore::JSCustomSQLStatementErrorCallback::handleEvent):
              * bindings/js/JSCustomSQLTransactionCallback.cpp:
              (WebCore::JSCustomSQLTransactionCallback::handleEvent):
              * bindings/js/JSCustomSQLTransactionErrorCallback.cpp:
              (WebCore::JSCustomSQLTransactionErrorCallback::handleEvent):
              * bindings/js/JSCustomVoidCallback.cpp:
              (WebCore::JSCustomVoidCallback::handleEvent):
              * bindings/js/JSCustomXPathNSResolver.cpp:
              (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
              * bindings/js/JSEventListener.cpp:
              (WebCore::JSAbstractEventListener::handleEvent):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScriptControllerMac.mm:
              (WebCore::updateStyleIfNeededForBindings):
              (WebCore::ScriptController::initJavaJSBindings):
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::removeProperty):
              (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):
              (WebCore::CSSMutableStyleDeclaration::setProperty):
              (WebCore::CSSMutableStyleDeclaration::setStringProperty):
              (WebCore::CSSMutableStyleDeclaration::setImageProperty):
              (WebCore::CSSMutableStyleDeclaration::parseDeclaration):
              (WebCore::CSSMutableStyleDeclaration::addParsedProperties):
              (WebCore::CSSMutableStyleDeclaration::setCssText):
              (WebCore::CSSMutableStyleDeclaration::merge):
              (WebCore::CSSMutableStyleDeclaration::removePropertiesInSet):
              * css/CSSMutableStyleDeclaration.h:
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::allVisitedStateChanged):
              (WebCore::CSSStyleSelector::SelectorChecker::visitedStateChanged):
              * css/CSSVariablesDeclaration.cpp:
              (WebCore::CSSVariablesDeclaration::removeVariable):
              (WebCore::CSSVariablesDeclaration::setVariable):
              (WebCore::CSSVariablesDeclaration::setNeedsStyleRecalc):
              * css/CSSVariablesDeclaration.h:
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::insertBefore):
              (WebCore::ContainerNode::replaceChild):
              (WebCore::ContainerNode::removeChild):
              (WebCore::ContainerNode::appendChild):
              (WebCore::ContainerNode::detach):
              (WebCore::ContainerNode::setFocus):
              (WebCore::ContainerNode::setActive):
              (WebCore::ContainerNode::setHovered):
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::Document::~Document):
              (WebCore::Document::scheduleStyleRecalc):
              (WebCore::Document::unscheduleStyleRecalc):
              (WebCore::Document::recalcStyle):
              (WebCore::Document::updateStyleIfNeeded):
              (WebCore::Document::updateStyleForAllDocuments):
              (WebCore::Document::updateLayout):
              (WebCore::Document::implicitClose):
              (WebCore::Document::prepareMouseEvent):
              (WebCore::Document::setFocusedNode):
              (WebCore::Document::setCSSTarget):
              * dom/Document.h:
              * dom/Element.cpp:
              (WebCore::Element::recalcStyle):
              (WebCore::checkForSiblingStyleChanges):
              * dom/InputElement.cpp:
              (WebCore::InputElement::parseMaxLengthAttribute):
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::receivedTarget):
              * dom/Node.cpp:
              (WebCore::Node::Node):
              (WebCore::Node::setNeedsStyleRecalc):
              (WebCore::Node::lazyAttach):
              (WebCore::Node::dispatchGenericEvent):
              * dom/Node.h:
              (WebCore::Node::needsStyleRecalc):
              (WebCore::Node::childNeedsStyleRecalc):
              (WebCore::Node::setChildNeedsStyleRecalc):
              * dom/OptionElement.cpp:
              (WebCore::OptionElement::setSelectedState):
              * dom/ScriptElement.cpp:
              (WebCore::ScriptElementData::evaluateScript):
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::attributeChanged):
              (WebCore::StyledElement::classAttributeChanged):
              (WebCore::StyledElement::parseMappedAttribute):
              * dom/Text.cpp:
              (WebCore::Text::recalcStyle):
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::insertErrorMessageBlock):
              * editing/DeleteButtonController.cpp:
              (WebCore::DeleteButtonController::enable):
              * editing/Editor.cpp:
              (WebCore::Editor::setBaseWritingDirection):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::nodeWillBeRemoved):
              (WebCore::SelectionController::layout):
              (WebCore::SelectionController::focusedOrActiveStateChanged):
              * html/HTMLAnchorElement.cpp:
              (WebCore::HTMLAnchorElement::parseMappedAttribute):
              * html/HTMLElement.cpp:
              (WebCore::HTMLElement::setInnerText):
              (WebCore::HTMLElement::isContentEditable):
              (WebCore::HTMLElement::isContentRichlyEditable):
              (WebCore::HTMLElement::contentEditable):
              * html/HTMLEmbedElement.cpp:
              (WebCore::HTMLEmbedElement::updateWidget):
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElement::parseMappedAttribute):
              * html/HTMLFrameSetElement.cpp:
              (WebCore::HTMLFrameSetElement::parseMappedAttribute):
              (WebCore::HTMLFrameSetElement::recalcStyle):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::parseMappedAttribute):
              (WebCore::HTMLInputElement::setChecked):
              (WebCore::HTMLInputElement::setIndeterminate):
              (WebCore::HTMLInputElement::setValue):
              (WebCore::HTMLInputElement::setAutofilled):
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::finishParsingChildren):
              * html/HTMLObjectElement.cpp:
              (WebCore::HTMLObjectElement::updateWidget):
              (WebCore::HTMLObjectElement::finishParsingChildren):
              (WebCore::HTMLObjectElement::childrenChanged):
              * html/HTMLSelectElement.cpp:
              (WebCore::HTMLSelectElement::recalcStyle):
              (WebCore::HTMLSelectElement::restoreState):
              (WebCore::HTMLSelectElement::setRecalcListItems):
              (WebCore::HTMLSelectElement::reset):
              (WebCore::HTMLSelectElement::typeAheadFind):
              * html/HTMLTableElement.cpp:
              (WebCore::setTableCellsChanged):
              (WebCore::HTMLTableElement::parseMappedAttribute):
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::setValue):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::stopLoading):
              (WebCore::FrameLoader::executeScript):
              (WebCore::FrameLoader::gotoAnchor):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::alert):
              (WebCore::DOMWindow::confirm):
              (WebCore::DOMWindow::prompt):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::hoverTimerFired):
              * page/FrameView.cpp:
              (WebCore::FrameView::layout):
              (WebCore::FrameView::needsLayout):
              * page/animation/AnimationBase.cpp:
              (WebCore::AnimationBase::setNeedsStyleRecalc):
              (WebCore::AnimationBase::updateStateMachine):
              * page/animation/AnimationBase.h:
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
              (WebCore::AnimationControllerPrivate::clear):
              (WebCore::AnimationControllerPrivate::updateAnimationTimer):
              (WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
              (WebCore::AnimationControllerPrivate::startupdateStyleIfNeededDispatcher):
              (WebCore::AnimationControllerPrivate::addEventToDispatch):
              (WebCore::AnimationControllerPrivate::addNodeChangeToDispatch):
              (WebCore::AnimationControllerPrivate::animationTimerFired):
              (WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
              (WebCore::AnimationControllerPrivate::pauseTransitionAtTime):
              (WebCore::AnimationControllerPrivate::addToStartTimeResponseWaitList):
              (WebCore::AnimationController::cancelAnimations):
              * page/animation/AnimationControllerPrivate.h:
              * page/animation/ImplicitAnimation.cpp:
              (WebCore::ImplicitAnimation::sendTransitionEvent):
              * page/animation/KeyframeAnimation.cpp:
              (WebCore::KeyframeAnimation::endAnimation):
              (WebCore::KeyframeAnimation::sendAnimationEvent):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::updateDragState):
              * rendering/RenderView.cpp:
              (WebCore::RenderView::selectionBounds):
              * svg/SVGAElement.cpp:
              (WebCore::SVGAElement::svgAttributeChanged):
              * svg/SVGAnimationElement.cpp:
              (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue):
              * svg/SVGCursorElement.cpp:
              (WebCore::SVGCursorElement::svgAttributeChanged):
              * svg/SVGElementInstance.cpp:
              (WebCore::SVGElementInstance::setNeedsUpdate):
              * svg/SVGForeignObjectElement.cpp:
              (WebCore::addCSSPropertyAndNotifyAttributeMap):
              * svg/SVGStopElement.cpp:
              (WebCore::SVGStopElement::parseMappedAttribute):
              * svg/SVGStyledElement.cpp:
              (WebCore::SVGStyledElement::parseMappedAttribute):
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::svgAttributeChanged):
              (WebCore::SVGUseElement::childrenChanged):
              (WebCore::SVGUseElement::recalcStyle):
              * svg/animation/SMILTimeContainer.cpp:
              (WebCore::SMILTimeContainer::updateAnimations):
              * wml/WMLAElement.cpp:
              (WebCore::WMLAElement::parseMappedAttribute):
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::setValue):
              (WebCore::WMLInputElement::parseMappedAttribute):
              * wml/WMLNoopElement.cpp:
              (WebCore::WMLNoopElement::insertedIntoDocument):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42377 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f6d72f34
  17. 02 Apr, 2009 2 commits
    • mrowe@apple.com's avatar
      Fix Windows build after r42190. · 050fe479
      mrowe@apple.com authored
      * page/EventHandler.cpp:
      (WebCore::EventHandler::keyEvent):  Update to use the new name of the constant.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      050fe479
    • darin@apple.com's avatar
      2009-04-02 Darin Adler <darin@apple.com> · 2f1aa605
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              <rdar://problem/6654255> crash due to null FrameView in EventHandler
      
              Lots of code was added to EventHandler that used view() and page() without
              null checking, but both of those can become null due to the frame lifetime.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              (WebCore::EventHandler::eventMayStartDrag):
              (WebCore::EventHandler::handleAutoscroll):
              (WebCore::EventHandler::autoscrollTimerFired):
              (WebCore::EventHandler::setPanScrollCursor):
              (WebCore::EventHandler::allowDHTMLDrag):
              (WebCore::EventHandler::hitTestResultAtPoint):
              (WebCore::EventHandler::stopAutoscrollTimer):
              (WebCore::EventHandler::selectCursor):
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseMoveEvent):
              (WebCore::EventHandler::dispatchDragEvent):
              (WebCore::EventHandler::prepareMouseEvent):
              (WebCore::EventHandler::dispatchMouseEvent):
              (WebCore::EventHandler::handleWheelEvent):
              (WebCore::EventHandler::hoverTimerFired):
              (WebCore::EventHandler::keyEvent):
              (WebCore::EventHandler::dragHysteresisExceeded):
              (WebCore::EventHandler::shouldDragAutoNode):
              (WebCore::EventHandler::handleDrag):
              (WebCore::EventHandler::handleTextInputEvent):
              (WebCore::EventHandler::addPendingFrameUnloadEventCount):
              (WebCore::EventHandler::removePendingFrameUnloadEventCount):
              (WebCore::EventHandler::clearPendingFrameUnloadEventCount):
              (WebCore::EventHandler::addPendingFrameBeforeUnloadEventCount):
              (WebCore::EventHandler::removePendingFrameBeforeUnloadEventCount):
              (WebCore::EventHandler::clearPendingFrameBeforeUnloadEventCount):
              Added null checks for view() and page(). Made minor code cleanups.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@42190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f1aa605
  18. 01 Apr, 2009 1 commit
  19. 26 Mar, 2009 1 commit
  20. 25 Mar, 2009 1 commit
  21. 15 Mar, 2009 1 commit
  22. 10 Mar, 2009 1 commit
    • xan@webkit.org's avatar
      2009-03-10 Xan Lopez <xlopez@igalia.com> · 72434b27
      xan@webkit.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=24491
              Rename posOffset to m_offset, get rid of accessor
      
              As suggested in dom/Position.h, this patch gets rid of the
              'offset()' accessor and renames posOffset to m_offset. I've used
              m_offset instead of offset to follow the style guide lines, since
              Position is still a class and not a structure. If the long term
              plan is still to make it a structure it would be pretty easy to
              just s/m_offset/offset/ globally when that is achieved.
      
              * dom/Position.cpp:
              (WebCore::Position::previous):
              (WebCore::Position::next):
              (WebCore::Position::atStart):
              (WebCore::Position::atEnd):
              (WebCore::Position::renderedOffset):
              (WebCore::Position::isCandidate):
              (WebCore::Position::inRenderedText):
              (WebCore::Position::isRenderedCharacter):
              (WebCore::Position::rendersInDifferentPosition):
              (WebCore::Position::leadingWhitespacePosition):
              (WebCore::Position::debugPosition):
              (WebCore::Position::formatForDebugger):
              * dom/Position.h:
              (WebCore::Position::Position):
              * dom/PositionIterator.h:
              (WebCore::PositionIterator::PositionIterator):
              * dom/Range.cpp:
              * dom/RangeBoundaryPoint.h:
              (WebCore::RangeBoundaryPoint::position):
              (WebCore::RangeBoundaryPoint::set):
              (WebCore::RangeBoundaryPoint::setOffset):
              (WebCore::RangeBoundaryPoint::setToChild):
              (WebCore::RangeBoundaryPoint::setToStart):
              (WebCore::RangeBoundaryPoint::setToEnd):
              (WebCore::RangeBoundaryPoint::childBeforeWillBeRemoved):
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
              (WebCore::ApplyStyleCommand::applyInlineStyleToRange):
              (WebCore::ApplyStyleCommand::removeInlineStyle):
              (WebCore::ApplyStyleCommand::nodeFullySelected):
              (WebCore::ApplyStyleCommand::nodeFullyUnselected):
              (WebCore::ApplyStyleCommand::splitTextAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtStartIfNeeded):
              (WebCore::ApplyStyleCommand::splitTextElementAtEndIfNeeded):
              (WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical):
              (WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical):
              (WebCore::ApplyStyleCommand::joinChildTextNodes):
              * editing/BreakBlockquoteCommand.cpp:
              (WebCore::BreakBlockquoteCommand::doApply):
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::insertNodeAt):
              (WebCore::CompositeEditCommand::positionOutsideTabSpan):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
              (WebCore::CompositeEditCommand::prepareWhitespaceAtPositionForSplit):
              (WebCore::CompositeEditCommand::deleteInsignificantText):
              (WebCore::CompositeEditCommand::removePlaceholderAt):
              (WebCore::CompositeEditCommand::moveParagraphs):
              (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::updatePositionForNodeRemoval):
              (WebCore::updatePositionForTextRemoval):
              (WebCore::DeleteSelectionCommand::handleGeneralDelete):
              (WebCore::DeleteSelectionCommand::fixupWhitespace):
              * editing/Editor.cpp:
              (WebCore::Editor::setComposition):
              (WebCore::Editor::advanceToNextMisspelling):
              (WebCore::Editor::getCompositionSelection):
              * editing/InsertLineBreakCommand.cpp:
              (WebCore::InsertLineBreakCommand::doApply):
              * editing/InsertParagraphSeparatorCommand.cpp:
              (WebCore::InsertParagraphSeparatorCommand::doApply):
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::performTrivialReplace):
              (WebCore::InsertTextCommand::input):
              (WebCore::InsertTextCommand::insertTab):
              * editing/MoveSelectionCommand.cpp:
              (WebCore::MoveSelectionCommand::doApply):
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::debugRenderer):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::rangeFromLocationAndLength):
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::deleteKeyPressed):
              (WebCore::TypingCommand::forwardDeleteKeyPressed):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::characterAfter):
              (WebCore::VisiblePosition::debugPosition):
              (WebCore::makeRange):
              (WebCore::setStart):
              (WebCore::setEnd):
              * editing/VisibleSelection.cpp:
              (WebCore::VisibleSelection::toNormalizedRange):
              (WebCore::makeSearchRange):
              (WebCore::VisibleSelection::debugPosition):
              (WebCore::VisibleSelection::showTreeForThis):
              * editing/htmlediting.cpp:
              (WebCore::comparePositions):
              (WebCore::rangeCompliantEquivalent):
              (WebCore::isFirstPositionAfterTable):
              (WebCore::isLastPositionBeforeTable):
              * editing/visible_units.cpp:
              (WebCore::previousBoundary):
              (WebCore::nextBoundary):
              (WebCore::startPositionForLine):
              (WebCore::startOfLine):
              (WebCore::endPositionForLine):
              (WebCore::nextLinePosition):
              (WebCore::startOfParagraph):
              (WebCore::endOfParagraph):
              * page/AccessibilityObject.cpp:
              (WebCore::updateAXLineStartForVisiblePosition):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::indexForVisiblePosition):
              * page/DOMSelection.cpp:
              (WebCore::DOMSelection::anchorOffset):
              (WebCore::DOMSelection::baseOffset):
              (WebCore::DOMSelection::focusOffset):
              (WebCore::DOMSelection::extentOffset):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEventSingleClick):
              * page/Frame.cpp:
              (WebCore::Frame::selectionLayoutChanged):
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::indexForVisiblePosition):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::writeSelection):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      72434b27
  23. 06 Mar, 2009 2 commits
    • adele@apple.com's avatar
      2009-03-06 Adele Peterson <adele@apple.com> · f50a9ac2
      adele@apple.com authored
              Reviewed by Oliver Hunt.
      
              Fix for <rdar://problem/6607524> REGRESSION (Safari 3-4): I can't tab back to the URL field in an empty window (key loop is broken)
      
              I haven't been able to make a test for this since the problem is not reproducible within an empty iframe.
      
              * page/EventHandler.cpp: (WebCore::eventTargetNodeForDocument): We used to ensure that every html document had a body element.
                That is no longer true, so we should return the document element for a truly empty document.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f50a9ac2
    • pkasting@chromium.org's avatar
      2009-03-06 Peter Kasting <pkasting@google.com> · 8ed8d166
      pkasting@chromium.org authored
              Reviewed by Darin Fisher.
      
              https://bugs.webkit.org/show_bug.cgi?id=24407
              Windows scroll amount was too small, and wheel scroll distance
              conversion code was overly complex.
      
              * page/EventHandler.cpp:
              (WebCore::scrollAndAcceptEvent):
              * platform/PlatformWheelEvent.h:
              (WebCore::):
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::wheelEvent):
              * platform/Scrollbar.h:
              * platform/gtk/WheelEventGtk.cpp:
              (WebCore::PlatformWheelEvent::PlatformWheelEvent):
              * platform/mac/WheelEventMac.mm:
              (WebCore::PlatformWheelEvent::PlatformWheelEvent):
              * platform/qt/WheelEventQt.cpp:
              * platform/win/WheelEventWin.cpp:
              (WebCore::horizontalScrollChars):
              (WebCore::verticalScrollLines):
              (WebCore::PlatformWheelEvent::PlatformWheelEvent):
              * platform/wx/MouseWheelEventWx.cpp:
              (WebCore::PlatformWheelEvent::PlatformWheelEvent):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ed8d166
  24. 04 Mar, 2009 1 commit
    • antti@apple.com's avatar
      JavaScriptCore: · 59db47c4
      antti@apple.com authored
      2009-03-04  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=24359
              Repaint throttling mechanism
              
              Set ENABLE_REPAINT_THROTTLING to 0 by default.
      
              * wtf/Platform.h:
      
      WebCore:
      
      2009-03-04  Antti Koivisto  <antti@apple.com>
      
              Reviewed by Dave Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=24359
              Repaint throttling mechanism
              
              Excessive repainting can slow down page loadind. This implements a timer
              based throttling mechanism. It is behind ENABLE(REPAINT_THROTTLING) and not 
              enabled by default.
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::checkCompleted):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchDragEvent):
              (WebCore::EventHandler::dispatchMouseEvent):
              (WebCore::EventHandler::keyEvent):
              (WebCore::EventHandler::handleTextInputEvent):
              * page/FrameView.cpp:
              (WebCore::FrameView::FrameView):
              (WebCore::FrameView::reset):
              (WebCore::FrameView::repaintContentRectangle):
              (WebCore::FrameView::beginDeferredRepaints):
              (WebCore::FrameView::endDeferredRepaints):
              (WebCore::FrameView::checkStopDelayingDeferredRepaints):
              (WebCore::FrameView::doDeferredRepaints):
              (WebCore::FrameView::updateDeferredRepaintDelay):
              (WebCore::FrameView::resetDeferredRepaintDelay):
              (WebCore::FrameView::adjustedDeferredRepaintDelay):
              (WebCore::FrameView::deferredRepaintTimerFired):
              (WebCore::FrameView::paintContents):
              * page/FrameView.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@41431 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      59db47c4
  25. 12 Feb, 2009 1 commit
  26. 11 Feb, 2009 1 commit
    • hyatt@apple.com's avatar
      2009-02-11 David Hyatt <hyatt@apple.com> · 7e03253f
      hyatt@apple.com authored
              Combine RenderObject::element() and RenderObject::node() into a single function.  
              node() now has the "anonymous bit" checking behavior of element() and will
              return 0 for anonymous content.  This patch switches all callers of element() 
              to node() and patches old callers of node() to deal with situations where they
              did not expect node() to be 0.  A bunch of node() calls were calling stuff on 
              Document that they clearly didn't intend, so overall this is a nice improvement.
          
              Reviewed by Sam Weinig
      
              * dom/ContainerNode.cpp:
              (WebCore::ContainerNode::getUpperLeftCorner):
              * dom/Element.cpp:
              (WebCore::Element::offsetParent):
              * dom/Position.cpp:
              (WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
              * editing/ModifySelectionListLevel.cpp:
              (WebCore::getStartEndListChildren):
              (WebCore::IncreaseSelectionListLevelCommand::doApply):
              (WebCore::DecreaseSelectionListLevelCommand::doApply):
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::advance):
              * editing/VisiblePosition.cpp:
              (WebCore::VisiblePosition::leftVisuallyDistinctCandidate):
              (WebCore::VisiblePosition::rightVisuallyDistinctCandidate):
              * editing/visible_units.cpp:
              (WebCore::startPositionForLine):
              (WebCore::endPositionForLine):
              * page/AXObjectCache.cpp:
              (WebCore::AXObjectCache::get):
              * page/AccessibilityList.cpp:
              (WebCore::AccessibilityList::isUnorderedList):
              (WebCore::AccessibilityList::isOrderedList):
              (WebCore::AccessibilityList::isDefinitionList):
              * page/AccessibilityListBox.cpp:
              (WebCore::AccessibilityListBox::doAccessibilityHitTest):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::isPasswordField):
              (WebCore::AccessibilityRenderObject::isFileUploadButton):
              (WebCore::AccessibilityRenderObject::isInputImage):
              (WebCore::AccessibilityRenderObject::isMultiSelect):
              (WebCore::AccessibilityRenderObject::isControl):
              (WebCore::AccessibilityRenderObject::getAttribute):
              (WebCore::AccessibilityRenderObject::anchorElement):
              (WebCore::AccessibilityRenderObject::actionElement):
              (WebCore::AccessibilityRenderObject::mouseButtonListener):
              (WebCore::AccessibilityRenderObject::helpText):
              (WebCore::AccessibilityRenderObject::textUnderElement):
              (WebCore::AccessibilityRenderObject::hasIntValue):
              (WebCore::AccessibilityRenderObject::intValue):
              (WebCore::AccessibilityRenderObject::labelElementContainer):
              (WebCore::AccessibilityRenderObject::title):
              (WebCore::AccessibilityRenderObject::accessibilityDescription):
              (WebCore::AccessibilityRenderObject::boundingBoxRect):
              (WebCore::AccessibilityRenderObject::checkboxOrRadioRect):
              (WebCore::AccessibilityRenderObject::titleUIElement):
              (WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
              (WebCore::AccessibilityRenderObject::text):
              (WebCore::AccessibilityRenderObject::ariaSelectedTextDOMRange):
              (WebCore::AccessibilityRenderObject::accessKey):
              (WebCore::AccessibilityRenderObject::setSelectedTextRange):
              (WebCore::AccessibilityRenderObject::url):
              (WebCore::AccessibilityRenderObject::isFocused):
              (WebCore::AccessibilityRenderObject::setFocused):
              (WebCore::AccessibilityRenderObject::setValue):
              (WebCore::AccessibilityRenderObject::isEnabled):
              (WebCore::AccessibilityRenderObject::visiblePositionRange):
              (WebCore::AccessibilityRenderObject::index):
              (WebCore::AccessibilityRenderObject::activeDescendant):
              (WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
              (WebCore::AccessibilityRenderObject::observableObject):
              (WebCore::AccessibilityRenderObject::roleValue):
              (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
              (WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
              * page/AccessibilityTable.cpp:
              (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
              (WebCore::AccessibilityTable::title):
              * page/AccessibilityTableCell.cpp:
              (WebCore::AccessibilityTableCell::titleUIElement):
              * page/AccessibilityTableColumn.cpp:
              (WebCore::AccessibilityTableColumn::headerObjectForSection):
              * page/AccessibilityTableRow.cpp:
              (WebCore::AccessibilityTableRow::headerObject):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchMouseEvent):
              (WebCore::EventHandler::canMouseDownStartSelect):
              (WebCore::EventHandler::canMouseDragExtendSelect):
              (WebCore::EventHandler::shouldDragAutoNode):
              * page/Frame.cpp:
              (WebCore::Frame::searchForLabelsAboveCell):
              (WebCore::Frame::setFocusedNodeIfNeeded):
              * page/FrameView.cpp:
              (WebCore::FrameView::updateOverflowStatus):
              * page/animation/AnimationBase.cpp:
              (WebCore::AnimationBase::updateStateMachine):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::updateAnimationTimer):
              (WebCore::AnimationController::cancelAnimations):
              (WebCore::AnimationController::updateAnimations):
              * page/animation/KeyframeAnimation.cpp:
              (WebCore::KeyframeAnimation::KeyframeAnimation):
              (WebCore::KeyframeAnimation::endAnimation):
              * page/mac/AccessibilityObjectWrapper.mm:
              (blockquoteLevel):
              (AXAttributeStringSetHeadingLevel):
              * page/mac/FrameMac.mm:
              (WebCore::Frame::searchForNSLabelsAboveCell):
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::verticallyAlignBoxes):
              (WebCore::InlineFlowBox::paint):
              (WebCore::shouldDrawTextDecoration):
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::paintDocumentMarkers):
              * rendering/RenderBR.cpp:
              (WebCore::RenderBR::positionForCoordinates):
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::layoutBlock):
              (WebCore::RenderBlock::handleRunInChild):
              (WebCore::RenderBlock::paintObject):
              (WebCore::RenderBlock::isSelectionRoot):
              (WebCore::RenderBlock::rightmostPosition):
              (WebCore::RenderBlock::positionForBox):
              (WebCore::RenderBlock::positionForRenderer):
              (WebCore::RenderBlock::positionForCoordinates):
              (WebCore::RenderBlock::hasLineIfEmpty):
              (WebCore::RenderBlock::updateFirstLetter):
              (WebCore::RenderBlock::updateHitTestResult):
              (WebCore::RenderBlock::addFocusRingRects):
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::styleWillChange):
              (WebCore::RenderBox::updateBoxModelInfoFromStyle):
              (WebCore::RenderBox::paintRootBoxDecorations):
              (WebCore::RenderBox::positionForCoordinates):
              * rendering/RenderButton.cpp:
              (WebCore::RenderButton::updateFromElement):
              (WebCore::RenderButton::canHaveChildren):
              * rendering/RenderCounter.cpp:
              (WebCore::planCounter):
              * rendering/RenderFieldset.cpp:
              (WebCore::RenderFieldset::findLegend):
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutVerticalBox):
              * rendering/RenderForeignObject.cpp:
              (WebCore::RenderForeignObject::translationForAttributes):
              (WebCore::RenderForeignObject::calculateLocalTransform):
              * rendering/RenderFrame.h:
              (WebCore::RenderFrame::element):
              * rendering/RenderImage.cpp:
              (WebCore::RenderImage::paintReplaced):
              (WebCore::RenderImage::imageMap):
              (WebCore::RenderImage::nodeAtPoint):
              (WebCore::RenderImage::updateAltText):
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::cloneInline):
              (WebCore::RenderInline::updateHitTestResult):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::isTransparent):
              (WebCore::RenderLayer::scrollToOffset):
              (WebCore::RenderLayer::resize):
              (WebCore::RenderLayer::createScrollbar):
              (WebCore::RenderLayer::updateOverflowStatus):
              (WebCore::RenderLayer::updateScrollInfoAfterLayout):
              (WebCore::RenderLayer::enclosingElement):
              (WebCore::RenderLayer::updateHoverActiveState):
              (WebCore::RenderLayer::updateScrollCornerStyle):
              (WebCore::RenderLayer::updateResizerStyle):
              * rendering/RenderLayer.h:
              (WebCore::RenderLayer::isRootLayer):
              * rendering/RenderListItem.cpp:
              (WebCore::getParentOfFirstLineBox):
              * rendering/RenderMarquee.cpp:
              (WebCore::RenderMarquee::marqueeSpeed):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::RenderObject):
              (WebCore::RenderObject::isBody):
              (WebCore::RenderObject::isHR):
              (WebCore::RenderObject::isHTMLMarquee):
              (WebCore::RenderObject::isEditable):
              (WebCore::RenderObject::addPDFURLRect):
              (WebCore::RenderObject::showTreeForThis):
              (WebCore::RenderObject::draggableNode):
              (WebCore::RenderObject::hasOutlineAnnotation):
              (WebCore::RenderObject::positionForCoordinates):
              (WebCore::RenderObject::updateDragState):
              (WebCore::RenderObject::updateHitTestResult):
              (WebCore::RenderObject::getUncachedPseudoStyle):
              (WebCore::RenderObject::getTextDecorationColors):
              (WebCore::RenderObject::caretMaxOffset):
              (WebCore::RenderObject::offsetParent):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::isRoot):
              (WebCore::RenderObject::isInlineContinuation):
              (WebCore::RenderObject::node):
              (WebCore::RenderObject::setNode):
              * rendering/RenderObjectChildList.cpp:
              (WebCore::RenderObjectChildList::destroyLeftoverChildren):
              * rendering/RenderPart.cpp:
              (WebCore::RenderPart::updateWidgetPosition):
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::updateWidget):
              (WebCore::RenderPartObject::viewCleared):
              * rendering/RenderPath.cpp:
              (WebCore::RenderPath::calculateLocalTransform):
              (WebCore::RenderPath::layout):
              (WebCore::RenderPath::paint):
              (WebCore::RenderPath::drawMarkersIfNeeded):
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::positionForCoordinates):
              (WebCore::RenderReplaced::isSelected):
              * rendering/RenderSVGGradientStop.cpp:
              (WebCore::RenderSVGGradientStop::gradientElement):
              * rendering/RenderSVGImage.cpp:
              (WebCore::RenderSVGImage::calculateLocalTransform):
              * rendering/RenderSVGInlineText.cpp:
              (WebCore::RenderSVGInlineText::positionForCoordinates):
              * rendering/RenderSVGRoot.cpp:
              (WebCore::RenderSVGRoot::layout):
              (WebCore::RenderSVGRoot::applyContentTransforms):
              (WebCore::RenderSVGRoot::paint):
              (WebCore::RenderSVGRoot::calcViewport):
              (WebCore::RenderSVGRoot::absoluteTransform):
              * rendering/RenderSVGText.cpp:
              (WebCore::RenderSVGText::calculateLocalTransform):
              (WebCore::RenderSVGText::layout):
              * rendering/RenderSVGTextPath.cpp:
              (WebCore::RenderSVGTextPath::layoutPath):
              (WebCore::RenderSVGTextPath::startOffset):
              (WebCore::RenderSVGTextPath::exactAlignment):
              (WebCore::RenderSVGTextPath::stretchMethod):
              * rendering/RenderSVGTransformableContainer.cpp:
              (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
              * rendering/RenderSVGViewportContainer.cpp:
              (WebCore::RenderSVGViewportContainer::calcViewport):
              (WebCore::RenderSVGViewportContainer::viewportTransform):
              (WebCore::RenderSVGViewportContainer::nodeAtPoint):
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::addChild):
              * rendering/RenderTableCell.cpp:
              (WebCore::RenderTableCell::updateFromElement):
              (WebCore::RenderTableCell::calcPrefWidths):
              * rendering/RenderTableCol.cpp:
              (WebCore::RenderTableCol::updateFromElement):
              * rendering/RenderTableRow.cpp:
              (WebCore::RenderTableRow::addChild):
              * rendering/RenderTableSection.cpp:
              (WebCore::RenderTableSection::addChild):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::originalText):
              (WebCore::RenderText::positionForCoordinates):
              * rendering/RenderTextControlMultiLine.cpp:
              (WebCore::RenderTextControlMultiLine::nodeAtPoint):
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::nodeAtPoint):
              * rendering/RenderTextFragment.cpp:
              (WebCore::RenderTextFragment::originalText):
              (WebCore::RenderTextFragment::previousCharacter):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::isActive):
              (WebCore::RenderTheme::isChecked):
              (WebCore::RenderTheme::isIndeterminate):
              (WebCore::RenderTheme::isEnabled):
              (WebCore::RenderTheme::isFocused):
              (WebCore::RenderTheme::isPressed):
              (WebCore::RenderTheme::isReadOnlyControl):
              (WebCore::RenderTheme::isHovered):
              * rendering/RenderThemeMac.mm:
              (WebCore::RenderThemeMac::updatePressedState):
              (WebCore::RenderThemeMac::paintMediaFullscreenButton):
              (WebCore::RenderThemeMac::paintMediaMuteButton):
              (WebCore::RenderThemeMac::paintMediaPlayButton):
              (WebCore::RenderThemeMac::paintMediaSeekBackButton):
              (WebCore::RenderThemeMac::paintMediaSeekForwardButton):
              (WebCore::RenderThemeMac::paintMediaSliderTrack):
              (WebCore::RenderThemeMac::paintMediaSliderThumb):
              (WebCore::RenderThemeMac::paintMediaTimelineContainer):
              (WebCore::RenderThemeMac::paintMediaCurrentTime):
              (WebCore::RenderThemeMac::paintMediaTimeRemaining):
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::paintMediaMuteButton):
              (WebCore::RenderThemeSafari::paintMediaPlayButton):
              (WebCore::RenderThemeSafari::paintMediaSliderTrack):
              * rendering/RenderTreeAsText.cpp:
              (WebCore::operator<<):
              (WebCore::writeSelection):
              * rendering/RenderWidget.cpp:
              (WebCore::RenderWidget::setWidgetGeometry):
              (WebCore::RenderWidget::updateWidgetPosition):
              (WebCore::RenderWidget::nodeAtPoint):
              * rendering/RootInlineBox.cpp:
              (WebCore::isEditableLeaf):
              * rendering/SVGRenderSupport.cpp:
              (WebCore::prepareToRenderSVGContent):
              * rendering/SVGRenderTreeAsText.cpp:
              (WebCore::write):
              * rendering/SVGRootInlineBox.cpp:
              (WebCore::SVGRootInlineBox::buildLayoutInformation):
              (WebCore::SVGRootInlineBox::layoutInlineBoxes):
              (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
              (WebCore::SVGRootInlineBox::buildTextChunks):
              * rendering/style/SVGRenderStyle.cpp:
              (WebCore::SVGRenderStyle::cssPrimitiveToLength):
              * svg/SVGFont.cpp:
              (WebCore::SVGTextRunWalker::walk):
              (WebCore::floatWidthOfSubStringUsingSVGFont):
              (WebCore::Font::drawTextUsingSVGFont):
              * svg/SVGTextContentElement.cpp:
              (WebCore::findInlineTextBoxInTextChunks):
              * svg/graphics/SVGPaintServer.cpp:
              (WebCore::SVGPaintServer::fillPaintServer):
              (WebCore::SVGPaintServer::strokePaintServer):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40871 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e03253f
  27. 10 Feb, 2009 3 commits
    • oliver@apple.com's avatar
      <rdar://problem/6156755> onMouseOver events do not fire properly for cross frame drag and drop · 23a723be
      oliver@apple.com authored
      Reviewed by Adele Peterson.
      
      This problem was caused by incorrectly ignoring whether or not the
      default behaviour of the mousedown event was suppressed.  If a
      mousedown handler in a frame prevents default handling then the
      subsequent mousemove events fired for the drag should not be
      captured by that frame, should the mouse move out of its bounds.
      
      Test: fast/events/mouse-drag-from-frame.html
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23a723be
    • hyatt@apple.com's avatar
      2009-02-10 David Hyatt <hyatt@apple.com> · 7cc83d0f
      hyatt@apple.com authored
              Get rid of capsLockStateMayHaveChanged on RenderObject.  It is only implemented by one class (text fields),
              so devirtualize and just query at the single call site.
      
              Reviewed by Eric Seidel
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::capsLockStateMayHaveChanged):
              * rendering/RenderObject.h:
              * rendering/RenderTextControlSingleLine.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40836 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cc83d0f
    • ap@webkit.org's avatar
      Reviewed by Darin Adler. · f9b6eff3
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=23867
              Eliminate obsolete frame->document() checks
      
              * page/FrameView.cpp: (WebCore::FrameView::paintContents): Apparently due to a typo
              (document vs. !document), fillWithRed was always set to false, and other branches were
              never taken. Removing the check for document restores debug-only red color filling.
      
              * loader/FrameLoader.cpp: (WebCore::FrameLoader::begin): Only call dispatchWindowObjectAvailable()
              after a document is created. A client can do anything in its delegate method, so we'd need
              to have frame->document() checks otherwise. DumpRenderTree uses this delegate to add its
              custom property, and it was crashing due to null document in JSDOMWindowBase::getOwnPropertySlot().
      
              * bindings/js/JSDOMWindowBase.cpp:
              (WebCore::JSDOMWindowBase::getOwnPropertySlot):
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::addEventListener):
              (WebCore::JSDOMWindow::removeEventListener):
              * bindings/js/JSNavigatorCustom.cpp:
              (WebCore::needsYouTubeQuirk):
              * bindings/js/ScheduledAction.cpp:
              (WebCore::ScheduledAction::execute):
              * bindings/js/ScriptControllerMac.mm:
              (WebCore::updateRenderingForBindings):
              * dom/Document.cpp:
              (WebCore::Document::initSecurityContext):
              * editing/Editor.cpp:
              (WebCore::Editor::deleteWithDirection):
              (WebCore::Editor::dispatchCPPEvent):
              (WebCore::Editor::applyStyle):
              (WebCore::Editor::applyParagraphStyle):
              * editing/EditorCommand.cpp:
              (WebCore::Editor::Command::execute):
              (WebCore::Editor::Command::isEnabled):
              (WebCore::Editor::Command::state):
              (WebCore::Editor::Command::value):
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::recomputeCaretRect):
              (WebCore::SelectionController::selectFrameElementInParentIfFullySelected):
              (WebCore::SelectionController::selectAll):
              (WebCore::SelectionController::setFocused):
              * inspector/InspectorController.cpp:
              (WebCore::getResourceDocumentNode):
              * inspector/JavaScriptDebugServer.cpp:
              (WebCore::JavaScriptDebugServer::setJavaScriptPaused):
              * loader/DocumentLoader.cpp:
              (WebCore::canonicalizedTitle):
              (WebCore::DocumentLoader::stopLoading):
              (WebCore::DocumentLoader::isLoadingInAPISense):
              (WebCore::DocumentLoader::subresource):
              (WebCore::DocumentLoader::getSubresources):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::urlSelected):
              (WebCore::FrameLoader::stop):
              (WebCore::FrameLoader::iconURL):
              (WebCore::FrameLoader::executeIfJavaScriptURL):
              (WebCore::FrameLoader::clear):
              (WebCore::FrameLoader::endIfNotLoadingMainResource):
              (WebCore::FrameLoader::restoreDocumentState):
              (WebCore::FrameLoader::gotoAnchor):
              (WebCore::FrameLoader::loadDone):
              (WebCore::FrameLoader::checkCompleted):
              (WebCore::FrameLoader::checkCallImplicitClose):
              (WebCore::FrameLoader::scheduleRefresh):
              (WebCore::FrameLoader::outgoingOrigin):
              (WebCore::FrameLoader::canCachePageContainingThisFrame):
              (WebCore::FrameLoader::logCanCacheFrameDecision):
              (WebCore::FrameLoader::updatePolicyBaseURL):
              (WebCore::FrameLoader::setPolicyBaseURL):
              (WebCore::FrameLoader::frameDetached):
              (WebCore::FrameLoader::shouldScrollToAnchor):
              (WebCore::FrameLoader::saveDocumentState):
              * loader/archive/cf/LegacyWebArchive.cpp:
              (WebCore::LegacyWebArchive::create):
              * loader/icon/IconFetcher.cpp:
              (WebCore::IconFetcher::create):
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::startLoading):
              * page/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
              * page/Chrome.cpp:
              (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
              (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::sessionStorage):
              (WebCore::DOMWindow::alert):
              (WebCore::DOMWindow::confirm):
              (WebCore::DOMWindow::prompt):
              (WebCore::DOMWindow::scrollX):
              (WebCore::DOMWindow::scrollY):
              (WebCore::DOMWindow::getMatchedCSSRules):
              (WebCore::DOMWindow::openDatabase):
              (WebCore::DOMWindow::scrollBy):
              (WebCore::DOMWindow::scrollTo):
              * page/EventHandler.cpp:
              (WebCore::EventHandler::allowDHTMLDrag):
              (WebCore::EventHandler::scrollOverflow):
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseDoubleClickEvent):
              (WebCore::EventHandler::handleMouseMoveEvent):
              (WebCore::EventHandler::handleMouseReleaseEvent):
              (WebCore::EventHandler::updateDragAndDrop):
              (WebCore::EventHandler::handleWheelEvent):
              (WebCore::EventHandler::sendContextMenuEvent):
              (WebCore::EventHandler::capsLockStateMayHaveChanged):
              (WebCore::EventHandler::sendResizeEvent):
              (WebCore::EventHandler::sendScrollEvent):
              * page/FocusController.cpp:
              (WebCore::deepFocusableNode):
              (WebCore::FocusController::advanceFocus):
              * page/Frame.cpp:
              (WebCore::Frame::setFocusedNodeIfNeeded):
              (WebCore::Frame::shouldApplyTextZoom):
              (WebCore::Frame::shouldApplyPageZoom):
              (WebCore::Frame::setZoomFactor):
              (WebCore::Frame::setPrinting):
              (WebCore::Frame::reapplyStyles):
              (WebCore::Frame::isContentEditable):
              (WebCore::Frame::computeAndSetTypingStyle):
              (WebCore::Frame::selectionComputedStyle):
              (WebCore::Frame::applyEditingStyleToBodyElement):
              (WebCore::Frame::removeEditingStyleFromBodyElement):
              (WebCore::Frame::contentRenderer):
              (WebCore::Frame::styleForSelectionStart):
              (WebCore::Frame::setSelectionFromNone):
              (WebCore::Frame::findString):
              (WebCore::Frame::markAllMatchesForText):
              (WebCore::Frame::setMarkedTextMatchesAreHighlighted):
              (WebCore::Frame::documentTypeString):
              (WebCore::Frame::shouldClose):
              (WebCore::Frame::respondToChangedSelection):
              * page/FrameView.cpp:
              (WebCore::FrameView::~FrameView):
              (WebCore::FrameView::createScrollbar):
              (WebCore::FrameView::layout):
              (WebCore::FrameView::layoutTimerFired):
              (WebCore::FrameView::scheduleRelayout):
              (WebCore::FrameView::needsLayout):
              (WebCore::FrameView::unscheduleRelayout):
              (WebCore::FrameView::windowClipRect):
              * page/Geolocation.cpp:
              (WebCore::Geolocation::disconnectFrame):
              * page/Page.cpp:
              (WebCore::networkStateChanged):
              (WebCore::Page::~Page):
              (WebCore::Page::unmarkAllTextMatches):
              (WebCore::Page::setMediaVolume):
              * page/animation/AnimationController.cpp:
              (WebCore::AnimationControllerPrivate::updateRenderingDispatcherFired):
              * page/mac/EventHandlerMac.mm:
              (WebCore::EventHandler::currentKeyboardEvent):
              (WebCore::EventHandler::needsKeyboardEventDisambiguationQuirks):
              * page/mac/FrameMac.mm:
              (WebCore::Frame::dashboardRegionsDictionary):
              (WebCore::Frame::setUserStyleSheetLocation):
              (WebCore::Frame::setUserStyleSheet):
              * storage/LocalStorageArea.cpp:
              (WebCore::LocalStorageArea::dispatchStorageEvent):
              * storage/SessionStorageArea.cpp:
              (WebCore::SessionStorageArea::dispatchStorageEvent):
              * svg/graphics/SVGImage.cpp:
              (WebCore::SVGImage::setContainerSize):
              (WebCore::SVGImage::usesContainerSize):
              (WebCore::SVGImage::size):
              (WebCore::SVGImage::hasRelativeWidth):
              (WebCore::SVGImage::hasRelativeHeight):
              Removed frame->document() checks.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@40824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9b6eff3
  28. 09 Feb, 2009 1 commit
  29. 07 Feb, 2009 1 commit