1. 23 Jul, 2009 9 commits
    • treat@webkit.org's avatar
      WebCore: · bc00ddcf
      treat@webkit.org authored
      2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>
      
              Reviewed by David Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=27289
              When a mouse click occurs on a scrollbar without a preceding mouse move
              onto it, the release isn't handled correctly (since
              EventHandler::m_lastScrollbarUnderMouse isn't set on mouse down, but
              only on mouse move). (Side comment: That scrollbar-handling code
              in EventHandler is ugly. It should be fixed properly.)
      
              Tests: scrollbars/scrollbar-miss-mousemove.html
                     scrollbars/scrollbar-miss-mousemove-disabled.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseMoveEvent):
              (WebCore::EventHandler::updateLastScrollbarUnderMouse):
              * page/EventHandler.h:
      
      LayoutTests:
      2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>
      
              Reviewed by David Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=27289
              Tests that mouse clicks/releases are handled properly on scrollbars
              even when there is no mouse move onto the scrollbar (two cases: enabled
              and disabled controls).
      
              * scrollbars/scrollbar-miss-mousemove-disabled-expected.txt: Added.
              * scrollbars/scrollbar-miss-mousemove-disabled.html: Added.
              * scrollbars/scrollbar-miss-mousemove-expected.txt: Added.
              * scrollbars/scrollbar-miss-mousemove.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc00ddcf
    • levin@chromium.org's avatar
      2009-07-23 Mike Fenton <mike.fenton@torchmobile.com> · 86403917
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Update WebCore/page/BarInfo.cpp to conform to WebKit
              Style Guidelines as identified by cpplint.py.
              https://bugs.webkit.org/show_bug.cgi?id=27606
      
              * page/BarInfo.cpp:
              (WebCore::BarInfo::visible):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86403917
    • levin@chromium.org's avatar
      2009-07-23 Mike Fenton <mike.fenton@torchmobile.com> · 4e1469c8
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Update WebCore/page/Console.cpp to conform to WebKit
              Style Guidelines as identified by cpplint.py.
              https://bugs.webkit.org/show_bug.cgi?id=27606
      
              * page/Console.cpp:
              (WebCore::printMessageSourceAndLevelPrefix):
              (WebCore::Console::profile):
              (WebCore::Console::time):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46271 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e1469c8
    • hausmann@webkit.org's avatar
      WebCore: · a20dc7d6
      hausmann@webkit.org authored
      2009-07-23  Simon Hausmann  <simon.hausmann@nokia.com>
      
              Reviewed by Holger Freyther.
      
              Fix crashes with the QObject bindings after garbage collection.
      
              There is one QtInstance per wrapped QObject, and that QtInstance keeps
              references to cached JSObjects for slots. When those objects get
              deleted due to GC, then they becoming dangling pointers.
      
              When a cached member dies, it is now removed from the QtInstance's
              cache.
      
              As we cannot track the lifetime of the children, we have to remove
              them from QtInstance alltogether. They are not cached and were
              only used for mark(), but we _want_ them to be subject to gc.
      
              * bridge/qt/qt_instance.cpp:
              (JSC::Bindings::QtInstance::~QtInstance): Minor coding style cleanup,
              use qDeleteAll().
              (JSC::Bindings::QtInstance::removeCachedMethod): New function, to
              clean m_methods and m_defaultMethod.
              (JSC::Bindings::QtInstance::mark): Avoid marking already marked objects.
              (JSC::Bindings::QtField::valueFromInstance): Don't save children for
              marking.
              * bridge/qt/qt_instance.h: Declare removeCachedMethod.
              * bridge/qt/qt_runtime.cpp:
              (JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod): Call removeCachedMethod
              with this on the instance.
      
      WebKit/qt:
      
      2009-07-23  Simon Hausmann  <simon.hausmann@nokia.com>
      
              Reviewed by Holger Freyther.
      
              Added a testcase to verify that cached methods in the QOBject bindings
              remain alife even after garbage collection.
      
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::protectBindingsRuntimeObjectsFromCollector):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46265 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a20dc7d6
    • xan@webkit.org's avatar
      2009-07-23 Xan Lopez <xlopez@igalia.com> · 0694f1e5
      xan@webkit.org authored
              Reviewed by Mark Rowe.
      
              https://bugs.webkit.org/show_bug.cgi?id=27599
              'const unsigned' in return value
      
              Remove const modifier from unsigned return value, as it does not
              make sense.
      
              * dom/ErrorEvent.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0694f1e5
    • levin@chromium.org's avatar
      2009-07-22 Jens Alfke <snej@chromium.org> · 3d53a4f3
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Bug 22784: Improve keyboard navigation of Select elements.
              Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
              on non-Mac platforms.
              https://bugs.webkit.org/show_bug.cgi?id=22784
              http://code.google.com/p/chromium/issues/detail?id=4576
      
      WebCore:
      
              New test: LayoutTests/fast/forms/select-popup-pagekeys.html
      
              * dom/SelectElement.cpp:
              (WebCore::nextValidIndex):
              New utility fn for traversing items of a select's list.
              (WebCore::SelectElement::menuListDefaultEventHandler):
              Added code to handle Home/End and PageUp/PageDn when ARROW_KEYS_POP_MENU is false.
      
      LayoutTests:
      
              * LayoutTests/fast/forms/select-popup-pagekeys.html: Added.
              * LayoutTests/fast/forms/select-popup-pagekeys-expected.txt: Added
              * LayoutTests/platform/mac/fast/forms/select-popup-pagekeys-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d53a4f3
    • xan@webkit.org's avatar
      2009-07-23 Xan Lopez <xlopez@igalia.com> · 91a4160c
      xan@webkit.org authored
              Reviewed by Mark Rowe.
      
              Fix a couple of compiler warnings.
      
              * platform/graphics/cairo/ImageBufferCairo.cpp:
              (copySurface):
              * platform/graphics/gtk/SimpleFontDataGtk.cpp:
              (WebCore::SimpleFontData::containsCharacters):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91a4160c
    • hausmann@webkit.org's avatar
      WebCore: · 6bfbc21a
      hausmann@webkit.org authored
      2009-07-22  Simon Hausmann  <simon.hausmann@nokia.com>
      
              Rubber-stamped by David Levin.
      
              Enable HTML5 Datagrid defines for the Qt build.
      
              * WebCore.pro:
      
      LayoutTests:
      
      2009-07-22  Simon Hausmann  <simon.hausmann@nokia.com>
      
              Rubber-stamped by David Levin.
      
              Unskip HTML 5 Datagrid tests for the Qt DRT, as they pass.
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bfbc21a
    • abarth@webkit.org's avatar
      2009-07-22 Adam Barth <abarth@webkit.org> · 312e3dd0
      abarth@webkit.org authored
              Reviewed by David Levin.
      
              [V8] Make Node wrappers go fast
              https://bugs.webkit.org/show_bug.cgi?id=27597
      
              Profiles indicate we're spending a lot of time asking whether we're on
              the main thread when looking up DOM wrappers for Nodes, but there isn't
              much point in doing that work because Nodes only exist on the main
              thread.  I've also added an assert to keep us honest in this regard.
      
              * bindings/v8/V8DOMMap.cpp:
              (WebCore::):
              (WebCore::getDOMNodeMap):
              (WebCore::DOMData::getCurrent):
              (WebCore::DOMData::getCurrentMainThread):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      312e3dd0
  2. 22 Jul, 2009 16 commits
    • abarth@webkit.org's avatar
      2009-07-22 Adam Barth <abarth@webkit.org> · 95b02cfa
      abarth@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Remove unneeded virtual destructor from ScriptSourceProvider
              https://bugs.webkit.org/show_bug.cgi?id=27563
      
              * bindings/js/ScriptSourceProvider.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95b02cfa
    • rniwa@webkit.org's avatar
      WebCore: · 076531a0
      rniwa@webkit.org authored
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
              https://bugs.webkit.org/show_bug.cgi?id=27476
      
              executeStrikethrough and executeUnderline were toggling between "line-through" / "underline" and "none".
              This patch adds executeToggleStyleInList that toggles a style in CSSValueList instead of toggling the entire value.
              It modifies CSSComputedStyleDeclaration to return CSSValueList instead of CSSPrimitiveValue for text decorations,
              and adds removeAll member function to CSSValueList.
      
              Tests: editing/execCommand/toggle-text-decorations.html
                     fast/css/getComputedStyle/getComputedStyle-text-decoration.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::renderTextDecorationFlagsToCSSValue): Creates a CSSValueList
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Returns a CSSValueList instead of CSSValue
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue): Text decorations are space separated instead of comma separated
              * css/CSSValueList.cpp:
              (WebCore::CSSValueList::removeAll): Removes all values that match the specified value
              * css/CSSValueList.h:
              * editing/EditorCommand.cpp:
              (WebCore::applyCommandToFrame): Apply style to a frame using specified command
              (WebCore::executeApplyStyle): Uses applyCommandToFrame
              (WebCore::executeToggleStyleInList): Uses applyCommandToFrame
              (WebCore::executeToggleStyle): Toggles a style in CSSValueList
              (WebCore::executeStrikethrough): Uses executeToggleStyleInList
              (WebCore::executeUnderline): Uses executeToggleStyleInList
      
      LayoutTests:
      
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
              https://bugs.webkit.org/show_bug.cgi?id=27476
      
              toggle-text-decorations checks whether we can toggle text decorations with multiple styles properly.
              e.g. execCommand("underline") should modify "text-decoration: underline overline" to "text-decoration: overline"
      
              getComputedStyle-text-decorations checks whether the CSS value of text decoration and its computed style are
              both space-separated CSSValueList instead of CSSPrimitiveValue or comma-separated CSSValueList.
      
              * editing/execCommand/resources/toggle-text-decorations.js: Added.
              (testSingleToggle):
              * editing/execCommand/toggle-text-decorations-expected.txt: Added.
              * editing/execCommand/toggle-text-decorations.html: Added.
              * fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: Added.
              * fast/css/getComputedStyle/getComputedStyle-text-decoration.html: Added.
              * fast/css/getComputedStyle/resources: Added.
              * fast/css/getComputedStyle/resources/TEMPLATE.html: Added.
              * fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js: Added.
              (expect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      076531a0
    • abarth@webkit.org's avatar
      2009-07-22 Daniel Bates <dbates@intudata.com> · 1f56a65a
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27174
              And
              https://bugs.webkit.org/show_bug.cgi?id=26938
      
              Tests prevention of attacks transformed by PHP Magic Quotes/PHP addslashes().
      
              * http/tests/security/xssAuditor/resources/echo-intertag-addslashes.pl: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-backslash.html: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-null-char.html: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html: Added.
      
      2009-07-22  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27174
              And
              https://bugs.webkit.org/show_bug.cgi?id=26938
      
              Code cleanup. Implements support for detecting attacks transformed by
              PHP Magic Quotes/PHP addslashes().
      
              Tests: http/tests/security/xssAuditor/script-tag-addslashes-backslash.html
                     http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html
                     http/tests/security/xssAuditor/script-tag-addslashes-null-char.html
                     http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html
      
              * page/XSSAuditor.cpp:
              (WebCore::isInvalidCharacter):
              (WebCore::XSSAuditor::canEvaluate):
              (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
              (WebCore::XSSAuditor::canLoadObject):
              (WebCore::XSSAuditor::normalize): Decodes HTML entities, removes backslashes,
              and removes control characters that could otherwise cause a discrepancy between
              the source code of a script and the outgoing HTTP parameters.
              (WebCore::XSSAuditor::decodeURL):
              (WebCore::XSSAuditor::decodeHTMLEntities):
              (WebCore::XSSAuditor::findInRequest):
              * page/XSSAuditor.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f56a65a
    • oliver@apple.com's avatar
      Null deref in JSObject::mark due to null xhr wrapper · 53c0f274
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=27565
      
      Reviewed by Adele Peterson.
      
      Make event target binding for appcache and xhr behave in the same way as
      it does for all other events.
      
      No test as I couldn't make a testcase which was remotely reliable.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53c0f274
    • levin@chromium.org's avatar
      2009-07-22 Mads Ager <ager@chromium.org> · b22aac62
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Inform V8 of the amount of WebCore string memory it is keeping alive.
              https://bugs.webkit.org/show_bug.cgi?id=27537
      
              V8 uses external strings that are backed by WebCore strings. Since
              the external strings themselves are small, V8 has no way of
              knowing how much memory it is actually holding on to. With this
              change, we inform V8 of the amount of WebCore string data it is
              holding on to with external strings.
      
              * bindings/v8/V8Binding.cpp:
              (WebCore::WebCoreStringResource::WebCoreStringResource):
              (WebCore::WebCoreStringResource::~WebCoreStringResource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b22aac62
    • hyatt@apple.com's avatar
      WebCore: · ddf151e3
      hyatt@apple.com authored
      2009-07-22  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Beth Dakin.
      
              https://bugs.webkit.org/show_bug.cgi?id=27562
              Add the finalized versions of background-clip and background-origin.  Remove background-clip from
              the background shorthand and have it be auto-set based off background-origin's value.
      
              Three new tests added in fast/backgrounds/size
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseFillShorthand):
              (WebCore::CSSParser::parseFillProperty):
              * css/CSSPropertyLonghand.cpp:
              (WebCore::initShorthandMap):
              * css/CSSPropertyNames.in:
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * css/CSSValueKeywords.in:
      
      LayoutTests:
      
      2009-07-22  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Beth Dakin.
      
              https://bugs.webkit.org/show_bug.cgi?id=27562
              Add some new layout tests that drop the prefix from the background properties and use origin
              in a shorthand.  Update shorthand results and computed style results to account for new properties.
      
              * fast/backgrounds/size/backgroundSize20.html: Added.
              * fast/backgrounds/size/backgroundSize21.html: Added.
              * fast/backgrounds/size/backgroundSize22.html: Added.
              * fast/css/background-position-serialize-expected.txt:
              * fast/css/remove-shorthand-expected.txt:
              * platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Added.
              * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
              * platform/mac/fast/inspector/style-expected.txt:
              * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddf151e3
    • jorlow@chromium.org's avatar
      WebCore: · f2b8ca8a
      jorlow@chromium.org authored
      2009-07-22  Jens Alfke  <snej@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Hook up V8 bindings for DataGrid elements.
              https://bugs.webkit.org/show_bug.cgi?id=27383
              http://code.google.com/p/chromium/issues/detail?id=16730
      
              Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
              to handle exceptions, check appropriate JS prototypes, and
              test column-list's item() method as well as array-indexing.
      
              * WebCore.gypi: Added new source files.
              * bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
              * bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
              * bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates.
              (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
              * bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource)
              (WebCore::V8DataGridDataSource::V8DataGridDataSource):
              (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
              * bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource)
              (WebCore::V8DataGridDataSource::create):
              (WebCore::V8DataGridDataSource::isJSDataGridDataSource):
              (WebCore::V8DataGridDataSource::jsDataSource):
              (WebCore::asV8DataGridDataSource):
              * bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
              * bindings/v8/V8Index.h: Conditionalize datagrid stuff.
              * bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
              * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Added.
              * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors.
              (WebCore::ACCESSOR_GETTER):
              (WebCore::ACCESSOR_SETTER):
      
      LayoutTests:
      
      2009-07-22  Jens Alfke  <snej@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Hook up V8 bindings for DataGrid elements.
              https://bugs.webkit.org/show_bug.cgi?id=27383
              http://code.google.com/p/chromium/issues/detail?id=16730
      
              Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
              to handle exceptions, check appropriate JS prototypes, and
              test column-list's item() method as well as array-indexing.
      
              * fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
              * fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
              * fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2b8ca8a
    • rniwa@webkit.org's avatar
      2009-07-22 Ryosuke Niwa <rniwa@webkit.org> · a1e567dd
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              pushDownTextDecorationStyleAroundNode needs clean up
              https://bugs.webkit.org/show_bug.cgi?id=27556
      
              Cleaned up. pushDownTextDecorationStyleAroundNode traverses tree vertically from highestAncestor to targetNode
              While traversing, it will apply the specified style to all nodes but targetNode.
              i.e. the style is applies to all ancestor nodes and their siblings of targetNode.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Cleaned up and added comments
              * editing/ApplyStyleCommand.h: Updated prototype
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1e567dd
    • pkasting@chromium.org's avatar
      2009-07-22 Peter Kasting <pkasting@google.com> · 91374dbb
      pkasting@chromium.org authored
              Reviewed by David Kilzer.
      
              https://bugs.webkit.org/show_bug.cgi?id=27323
              Handle any type of line endings in WebCore/css/*CSSPropertyNames.in.
      
              * DerivedSources.make:
              * css/makeprop.pl:
              * css/makevalues.pl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91374dbb
    • levin@chromium.org's avatar
      2009-07-22 Paul Godavari <paul@chromium.org> · d7aaa686
      levin@chromium.org authored
              Reviewed by Darin Fisher.
      
              Chromium has a build break after removal of JSRGBColor bindings
              https://bugs.webkit.org/show_bug.cgi?id=27548
      
              Fix a build break in Chromium V8 after the JSRGBColor bindings change:
              https://bugs.webkit.org/show_bug.cgi?id=27242
      
              * bindings/scripts/CodeGeneratorV8.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7aaa686
    • agl@chromium.org's avatar
      2009-07-22 Adam Langley <agl@google.com> · 63d59df9
      agl@chromium.org authored
              Reviewed by Darin Fisher.
      
              Chromium Linux: add static functions to FontPlatformData which allow
              for setting the global font rendering preferences.
      
              https://bugs.webkit.org/show_bug.cgi?id=27513
              http://code.google.com/p/chromium/issues/detail?id=12179
      
              This should not affect any layout tests.
      
              * platform/graphics/chromium/FontPlatformDataLinux.cpp:
              (WebCore::FontPlatformData::setHinting):
              (WebCore::FontPlatformData::setAntiAlias):
              (WebCore::FontPlatformData::setSubpixelGlyphs):
              (WebCore::FontPlatformData::setupPaint):
              * platform/graphics/chromium/FontPlatformDataLinux.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      63d59df9
    • pfeldman@chromium.org's avatar
      2009-07-22 Mikhail Naganov <mnaganov@chromium.org> · 0436fa2a
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Move Inspector panels creation into a function to make possible introducing
              custom panels.
      
              * inspector/front-end/inspector.js:
              (WebInspector._createPanels):
              (WebInspector.loaded):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0436fa2a
    • pfeldman@chromium.org's avatar
      2009-07-22 Pavel Feldman <pfeldman@chromium.org> · b0ffcc95
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              WebInspector: Print console command message upon evaluate
              selection request; Handle errors in evaluation request
              properly.
      
              https://bugs.webkit.org/show_bug.cgi?id=27535
      
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype.evaluateInSelectedCallFrame):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._evalSelectionInCallFrame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0ffcc95
    • xan@webkit.org's avatar
      2009-07-22 Xan Lopez <xlopez@igalia.com> · 08a9c87b
      xan@webkit.org authored
              Attempt to fix the GTK+ build.
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46218 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      08a9c87b
    • hausmann@webkit.org's avatar
      2009-07-21 Simon Hausmann <simon.hausmann@nokia.com> · 7d27cd77
      hausmann@webkit.org authored
              Fix the Qt build.
      
              * WebCore.pro: Add RGBColor.cpp to the build, remove JSRGBColor.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d27cd77
    • abarth@webkit.org's avatar
      2009-07-21 Daniel Bates <dbates@intudata.com> · 2e428bb4
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27494
      
              Fixes an issue that can cause a crash or unexpected behavior when calling
              WebCore::ScriptSourceCode::source on a cached script.
      
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/CachedScriptSourceProvider.h: Modified to inherit from
              WebCore::ScriptSourceCode.
              (WebCore::CachedScriptSourceProvider::source):
              (WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
              * bindings/js/ScriptSourceCode.h:
              (WebCore::ScriptSourceCode::ScriptSourceCode): Separated out source provider and
              rewrote to use WebCore::ScriptSourceProvider.
              (WebCore::ScriptSourceCode::source):
              * bindings/js/ScriptSourceProvider.h: Added.
              (WebCore::ScriptSourceProvider::ScriptSourceProvider):
              (WebCore::ScriptSourceProvider::~ScriptSourceProvider):
              * bindings/js/StringSourceProvider.h: Modified to inherit from
              WebCore::ScriptSourceCode.
              (WebCore::StringSourceProvider::StringSourceProvider):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e428bb4
  3. 21 Jul, 2009 15 commits
    • weinig@apple.com's avatar
      2009-07-21 Sam Weinig <sam@webkit.org> · af5510cf
      weinig@apple.com authored
              Another attempt to fix the Windows build.
      
              * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af5510cf
    • weinig@apple.com's avatar
      2009-07-21 Sam Weinig <sam@webkit.org> · 56b41936
      weinig@apple.com authored
              Attempt to fix the Windows build.
      
              * DerivedSources.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56b41936
    • weinig@apple.com's avatar
      2009-07-21 Sam Weinig <sam@webkit.org> · 265ef8cf
      weinig@apple.com authored
              Attempt to fix the GTK build
      
              * GNUmakefile.am:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      265ef8cf
    • weinig@apple.com's avatar
      2009-07-21 Sam Weinig <sam@webkit.org> · d451a00d
      weinig@apple.com authored
              Reviewed by Dan Bernstein.
      
              Autogenerate Objective-C binding implementation for RGBColor.
      
              No functionality change.
      
              * WebCore.xcodeproj/project.pbxproj: 
              * bindings/objc/DOMRGBColor.mm: Removed.
              * bindings/scripts/CodeGeneratorObjC.pm: Add logic to convert from
              WebCore::Color to NSColor*.
              * css/RGBColor.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d451a00d
    • weinig@apple.com's avatar
      WebCore: · 5b942cb0
      weinig@apple.com authored
      2009-07-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=27242
              JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor
      
              Move the JSC and Objective-C bindings onto using the RGBColor object instead
              of just an unsigned int. The JSC bindings are now completely autogenerated for
              this class. (Also removes the last lut from WebCore).
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSRGBColor.cpp: Removed.
              * bindings/js/JSRGBColor.h: Removed.
              * bindings/objc/DOM.mm:
              (-[DOMRGBColor _color]):
              * bindings/objc/DOMRGBColor.mm:
              (-[DOMRGBColor dealloc]):
              (-[DOMRGBColor finalize]):
              (-[DOMRGBColor red]):
              (-[DOMRGBColor green]):
              (-[DOMRGBColor blue]):
              (-[DOMRGBColor alpha]):
              (-[DOMRGBColor color]):
              * bindings/scripts/CodeGenerator.pm:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorObjC.pm:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseColor):
              * css/CSSPrimitiveValue.cpp:
              (WebCore::CSSPrimitiveValue::getRGBColorValue):
              * css/CSSPrimitiveValue.h:
              (WebCore::CSSPrimitiveValue::getRGBA32Value):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
              * css/RGBColor.cpp:
              (WebCore::RGBColor::alpha):
              * css/RGBColor.h:
              (WebCore::RGBColor::color):
              (WebCore::RGBColor::RGBColor):
              * css/RGBColor.idl:
              * page/DOMWindow.idl:
              * svg/SVGColor.cpp:
              (WebCore::SVGColor::rgbColor):
              * svg/SVGColor.h:
      
      LayoutTests:
      
      2009-07-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Changes for https://bugs.webkit.org/show_bug.cgi?id=27242
              JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor
      
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/dom-constructors-expected.txt:
              * fast/dom/prototype-inheritance-expected.txt:
              * fast/dom/wrapper-classes-expected.txt:
              * fast/js/global-constructors-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b942cb0
    • jianli@chromium.org's avatar
      2009-07-21 Jian Li <jianli@chromium.org> · a3ab52bf
      jianli@chromium.org authored
              Reviewed by David Levin.
      
              Implement AbstractWorker::dispatchScriptErrorEvent by generating an ErrorEvent.
              https://bugs.webkit.org/show_bug.cgi?id=27515
      
              * workers/AbstractWorker.cpp:
              (WebCore::AbstractWorker::dispatchScriptErrorEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3ab52bf
    • eric@webkit.org's avatar
      2009-07-21 Eric Seidel <eric@webkit.org> · 0d9f2e92
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Move m_context out of generator into a superclass
              https://bugs.webkit.org/show_bug.cgi?id=27521
      
              Mostly this is removing code from CodeGeneratorJS
              and instead using a DOMObjectWithSVGContext superclass in JSDOMBinding.h.
      
              DOMObjectWithSVGContext.h is its own file so that WebKit doesn't need to
              know about SVGElement.h (WebKit includes JSDOMBinding.h for some reason).
      
              I also removed context pointer from SVGZoomEvent since it was never used.
      
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/DOMObjectWithSVGContext.h: Added.
              (WebCore::DOMObjectWithSVGContext::context):
              (WebCore::DOMObjectWithSVGContext::DOMObjectWithSVGContext):
              * bindings/js/JSDOMBinding.h:
              * bindings/js/JSEventCustom.cpp:
              (WebCore::toJS):
              * bindings/scripts/CodeGeneratorJS.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d9f2e92
    • rniwa@webkit.org's avatar
      2009-07-21 Ryosuke Niwa <rniwa@webkit.org> · a0f1a0c6
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              REGRESSION (r46142):  editing/execCommand/19087.html & editing/execCommand/19653-1.html fail in Windows build
              https://bugs.webkit.org/show_bug.cgi?id=27480
      
              Because m_anchorType : 2 is treated as a signed integer by cl.exe, anchorType() wasn't returning the correct value.
              We made m_anchorType unsigned so that anchorType() returns the correct value.
      
              * dom/Position.h:
              (WebCore::Position::anchorType): statically cast to AnchorType
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a0f1a0c6
    • jianli@chromium.org's avatar
      2009-07-21 Jian Li <jianli@chromium.org> · 17158547
      jianli@chromium.org authored
              Reviewed by David Levin.
      
              [V8] Add V8 bindings for onerror in WorkerContext.
              https://bugs.webkit.org/show_bug.cgi?id=27518
      
              * bindings/v8/custom/V8CustomBinding.h:
              * bindings/v8/custom/V8WorkerContextCustom.cpp:
              (WebCore::ACCESSOR_GETTER):
              (WebCore::ACCESSOR_SETTER):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17158547
    • jianli@chromium.org's avatar
      2009-07-21 Jian Li <jianli@chromium.org> · 442dc8ef
      jianli@chromium.org authored
              Fix the incorrect patch being landed for bug 27516 that has already been reviewed.
              https://bugs.webkit.org/show_bug.cgi?id=27516
      
              * workers/WorkerContext.h:
              (WebCore::WorkerContext::setOnerror):
              (WebCore::WorkerContext::onerror):
              * workers/WorkerContext.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      442dc8ef
    • jianli@chromium.org's avatar
      2009-07-21 Jian Li <jianli@chromium.org> · 673144da
      jianli@chromium.org authored
              Reviewed by David Levin.
      
              Add onerror to WorkerContext.
              https://bugs.webkit.org/show_bug.cgi?id=27516
      
              * bindings/js/JSWorkerContextCustom.cpp:
              (WebCore::JSWorkerContext::mark):
              * workers/WorkerContext.h:
              (WebCore::WorkerContext::setOnerror):
              (WebCore::WorkerContext::onerror):
              * workers/WorkerContext.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      673144da
    • treat@webkit.org's avatar
      2009-07-21 Yong Li <yong.li@torchmobile.com> · d5e79b15
      treat@webkit.org authored
              Reviewed by George Staikos.
      
              https://bugs.webkit.org/show_bug.cgi?id=27509
              Add font-related files for the WinCE port.
      
              Written by Yong Li <yong.li@torchmobile.com>
      
              * platform/graphics/wince/FontCacheWince.cpp: Added.
              * platform/graphics/wince/FontCustomPlatformData.cpp: Added.
              * platform/graphics/wince/FontCustomPlatformData.h: Added.
              * platform/graphics/wince/FontPlatformData.cpp: Added.
              * platform/graphics/wince/FontPlatformData.h: Added.
              * platform/graphics/wince/FontWince.cpp: Added.
              * platform/graphics/wince/GlyphPageTreeNodeWince.cpp: Added.
              * platform/graphics/wince/SimpleFontDataWince.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5e79b15
    • kevino@webkit.org's avatar
    • kevino@webkit.org's avatar
      WebCorePrefix.h build fixes for non-Mac and wx / CURL builds. · 0b811b27
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b811b27
    • eric@webkit.org's avatar
      2009-07-21 Eric Seidel <eric@webkit.org> · 54d070cc
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              All DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject
              https://bugs.webkit.org/show_bug.cgi?id=27478
      
              This is just moving code.
              I've added two new classes: DOMObjectWithGlobalPointer and DOMConstructorWithDocument.
      
              DOMObjectWithGlobalPointer is a new baseclass for DOMConstructorObject.
              (It's a baseclass because eventually all DOMObjects will have a global pointer, but
              I'll be moving them onto DOMObjectWithGlobalPointer in stages.)
      
              DOMConstructorWithDocument is a new baseclass for the 3 constructor objects
              which require a backpointer to the Document to function.  I made this a subclass of
              DOMConstructorObject to make clear that most constructors can hold no-such assumptions
              about having a back-pointer to the Document (since many constructors can be used from Workers).
      
              * bindings/js/JSAudioConstructor.cpp:
              (WebCore::JSAudioConstructor::JSAudioConstructor):
              * bindings/js/JSAudioConstructor.h:
              * bindings/js/JSDOMBinding.h:
              (WebCore::DOMObjectWithGlobalPointer::globalObject):
              (WebCore::DOMObjectWithGlobalPointer::scriptExecutionContext):
              (WebCore::DOMObjectWithGlobalPointer::DOMObjectWithGlobalPointer):
              (WebCore::DOMObjectWithGlobalPointer::mark):
              (WebCore::DOMConstructorObject::DOMConstructorObject):
              (WebCore::DOMConstructorWithDocument::document):
              (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
              * bindings/js/JSImageConstructor.cpp:
              (WebCore::JSImageConstructor::JSImageConstructor):
              * bindings/js/JSImageConstructor.h:
              * bindings/js/JSMessageChannelConstructor.cpp:
              (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor):
              * bindings/js/JSMessageChannelConstructor.h:
              * bindings/js/JSOptionConstructor.cpp:
              (WebCore::JSOptionConstructor::JSOptionConstructor):
              * bindings/js/JSOptionConstructor.h:
              * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
              (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor):
              * bindings/js/JSWebKitPointConstructor.cpp:
              (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor):
              * bindings/js/JSWorkerConstructor.cpp:
              (WebCore::JSWorkerConstructor::JSWorkerConstructor):
              * bindings/js/JSXMLHttpRequestConstructor.cpp:
              (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor):
              * bindings/js/JSXMLHttpRequestConstructor.h:
              * bindings/js/JSXSLTProcessorConstructor.cpp:
              (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54d070cc