1. 23 Jul, 2009 6 commits
    • treat@webkit.org's avatar
      WebCore: · bc00ddcf
      treat@webkit.org authored
      2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>
      
              Reviewed by David Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=27289
              When a mouse click occurs on a scrollbar without a preceding mouse move
              onto it, the release isn't handled correctly (since
              EventHandler::m_lastScrollbarUnderMouse isn't set on mouse down, but
              only on mouse move). (Side comment: That scrollbar-handling code
              in EventHandler is ugly. It should be fixed properly.)
      
              Tests: scrollbars/scrollbar-miss-mousemove.html
                     scrollbars/scrollbar-miss-mousemove-disabled.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleMousePressEvent):
              (WebCore::EventHandler::handleMouseMoveEvent):
              (WebCore::EventHandler::updateLastScrollbarUnderMouse):
              * page/EventHandler.h:
      
      LayoutTests:
      2009-07-22  Viet-Trung Luu  <viettrungluu@gmail.com>
      
              Reviewed by David Hyatt.
      
              https://bugs.webkit.org/show_bug.cgi?id=27289
              Tests that mouse clicks/releases are handled properly on scrollbars
              even when there is no mouse move onto the scrollbar (two cases: enabled
              and disabled controls).
      
              * scrollbars/scrollbar-miss-mousemove-disabled-expected.txt: Added.
              * scrollbars/scrollbar-miss-mousemove-disabled.html: Added.
              * scrollbars/scrollbar-miss-mousemove-expected.txt: Added.
              * scrollbars/scrollbar-miss-mousemove.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46273 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc00ddcf
    • hausmann@webkit.org's avatar
      2009-07-23 Simon Hausmann <simon.hausmann@nokia.com> · be79664c
      hausmann@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              Rebaseline the Qt results for computed-style.html and
              computed-style-without-rendered.html after r46240, similar to r46252.
      
              * platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be79664c
    • levin@chromium.org's avatar
      2009-07-23 David Levin <levin@chromium.org> · edf7a747
      levin@chromium.org authored
               Rubber-stamped by Oliver Hunt.
      
              Improve keyboard navigation of Select elements.
              Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
              on non-Mac platforms.
              https://bugs.webkit.org/show_bug.cgi?id=22784
      
              One more round of speculative fixes:
               - Really fix the general and win expected results.  (They were missing a return.)
               - Disable the test for gtk (and remove the attempted workaround for that platform).
      
              * fast/forms/select-popup-pagekeys-expected.txt:
              * fast/forms/select-popup-pagekeys.html:
              * platform/gtk/Skipped:
              * platform/win/fast/forms/select-popup-pagekeys-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edf7a747
    • levin@chromium.org's avatar
      2009-07-23 David Levin <levin@chromium.org> · 295161e7
      levin@chromium.org authored
              Rubber-stamped by Oliver Hunt.
      
              3 (speculative) fixes for the new layout test: select-popup-pagekeys
               - Help Windows to pass by adding platform results.
               - Fix the general expected results.
               - Fix select-popup-pagekeys on gtk which doesn't seem to implement eventSender.
      
              * fast/forms/select-popup-pagekeys-expected.txt:
              * fast/forms/select-popup-pagekeys.html:
              * platform/win/fast/forms/select-popup-pagekeys-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      295161e7
    • levin@chromium.org's avatar
      2009-07-22 Jens Alfke <snej@chromium.org> · 3d53a4f3
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Bug 22784: Improve keyboard navigation of Select elements.
              Home/End and PageUp/PageDn buttons do not do anything in drop down lists,
              on non-Mac platforms.
              https://bugs.webkit.org/show_bug.cgi?id=22784
              http://code.google.com/p/chromium/issues/detail?id=4576
      
      WebCore:
      
              New test: LayoutTests/fast/forms/select-popup-pagekeys.html
      
              * dom/SelectElement.cpp:
              (WebCore::nextValidIndex):
              New utility fn for traversing items of a select's list.
              (WebCore::SelectElement::menuListDefaultEventHandler):
              Added code to handle Home/End and PageUp/PageDn when ARROW_KEYS_POP_MENU is false.
      
      LayoutTests:
      
              * LayoutTests/fast/forms/select-popup-pagekeys.html: Added.
              * LayoutTests/fast/forms/select-popup-pagekeys-expected.txt: Added
              * LayoutTests/platform/mac/fast/forms/select-popup-pagekeys-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d53a4f3
    • hausmann@webkit.org's avatar
      WebCore: · 6bfbc21a
      hausmann@webkit.org authored
      2009-07-22  Simon Hausmann  <simon.hausmann@nokia.com>
      
              Rubber-stamped by David Levin.
      
              Enable HTML5 Datagrid defines for the Qt build.
      
              * WebCore.pro:
      
      LayoutTests:
      
      2009-07-22  Simon Hausmann  <simon.hausmann@nokia.com>
      
              Rubber-stamped by David Levin.
      
              Unskip HTML 5 Datagrid tests for the Qt DRT, as they pass.
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6bfbc21a
  2. 22 Jul, 2009 6 commits
    • rniwa@webkit.org's avatar
      2009-07-22 Ryosuke Niwa <rniwa@webkit.org> · 885c66aa
      rniwa@webkit.org authored
              Reviewed by Adam Barth.
      
              REGRESSION (r46240): /fast/css/getComputedStyle/computed-style & computed-style-without-renderer needs rebaseline for Windows
              https://bugs.webkit.org/show_bug.cgi?id=27591
      
              Rebaselines the tests.
      
              * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      885c66aa
    • rniwa@webkit.org's avatar
      WebCore: · 076531a0
      rniwa@webkit.org authored
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
              https://bugs.webkit.org/show_bug.cgi?id=27476
      
              executeStrikethrough and executeUnderline were toggling between "line-through" / "underline" and "none".
              This patch adds executeToggleStyleInList that toggles a style in CSSValueList instead of toggling the entire value.
              It modifies CSSComputedStyleDeclaration to return CSSValueList instead of CSSPrimitiveValue for text decorations,
              and adds removeAll member function to CSSValueList.
      
              Tests: editing/execCommand/toggle-text-decorations.html
                     fast/css/getComputedStyle/getComputedStyle-text-decoration.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::renderTextDecorationFlagsToCSSValue): Creates a CSSValueList
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Returns a CSSValueList instead of CSSValue
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue): Text decorations are space separated instead of comma separated
              * css/CSSValueList.cpp:
              (WebCore::CSSValueList::removeAll): Removes all values that match the specified value
              * css/CSSValueList.h:
              * editing/EditorCommand.cpp:
              (WebCore::applyCommandToFrame): Apply style to a frame using specified command
              (WebCore::executeApplyStyle): Uses applyCommandToFrame
              (WebCore::executeToggleStyleInList): Uses applyCommandToFrame
              (WebCore::executeToggleStyle): Toggles a style in CSSValueList
              (WebCore::executeStrikethrough): Uses executeToggleStyleInList
              (WebCore::executeUnderline): Uses executeToggleStyleInList
      
      LayoutTests:
      
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
              https://bugs.webkit.org/show_bug.cgi?id=27476
      
              toggle-text-decorations checks whether we can toggle text decorations with multiple styles properly.
              e.g. execCommand("underline") should modify "text-decoration: underline overline" to "text-decoration: overline"
      
              getComputedStyle-text-decorations checks whether the CSS value of text decoration and its computed style are
              both space-separated CSSValueList instead of CSSPrimitiveValue or comma-separated CSSValueList.
      
              * editing/execCommand/resources/toggle-text-decorations.js: Added.
              (testSingleToggle):
              * editing/execCommand/toggle-text-decorations-expected.txt: Added.
              * editing/execCommand/toggle-text-decorations.html: Added.
              * fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: Added.
              * fast/css/getComputedStyle/getComputedStyle-text-decoration.html: Added.
              * fast/css/getComputedStyle/resources: Added.
              * fast/css/getComputedStyle/resources/TEMPLATE.html: Added.
              * fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js: Added.
              (expect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      076531a0
    • abarth@webkit.org's avatar
      2009-07-22 Daniel Bates <dbates@intudata.com> · 1f56a65a
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27174
              And
              https://bugs.webkit.org/show_bug.cgi?id=26938
      
              Tests prevention of attacks transformed by PHP Magic Quotes/PHP addslashes().
      
              * http/tests/security/xssAuditor/resources/echo-intertag-addslashes.pl: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-backslash.html: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-null-char.html: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html: Added.
      
      2009-07-22  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27174
              And
              https://bugs.webkit.org/show_bug.cgi?id=26938
      
              Code cleanup. Implements support for detecting attacks transformed by
              PHP Magic Quotes/PHP addslashes().
      
              Tests: http/tests/security/xssAuditor/script-tag-addslashes-backslash.html
                     http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html
                     http/tests/security/xssAuditor/script-tag-addslashes-null-char.html
                     http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html
      
              * page/XSSAuditor.cpp:
              (WebCore::isInvalidCharacter):
              (WebCore::XSSAuditor::canEvaluate):
              (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
              (WebCore::XSSAuditor::canLoadObject):
              (WebCore::XSSAuditor::normalize): Decodes HTML entities, removes backslashes,
              and removes control characters that could otherwise cause a discrepancy between
              the source code of a script and the outgoing HTTP parameters.
              (WebCore::XSSAuditor::decodeURL):
              (WebCore::XSSAuditor::decodeHTMLEntities):
              (WebCore::XSSAuditor::findInRequest):
              * page/XSSAuditor.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f56a65a
    • hyatt@apple.com's avatar
      WebCore: · ddf151e3
      hyatt@apple.com authored
      2009-07-22  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Beth Dakin.
      
              https://bugs.webkit.org/show_bug.cgi?id=27562
              Add the finalized versions of background-clip and background-origin.  Remove background-clip from
              the background shorthand and have it be auto-set based off background-origin's value.
      
              Three new tests added in fast/backgrounds/size
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseFillShorthand):
              (WebCore::CSSParser::parseFillProperty):
              * css/CSSPropertyLonghand.cpp:
              (WebCore::initShorthandMap):
              * css/CSSPropertyNames.in:
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * css/CSSValueKeywords.in:
      
      LayoutTests:
      
      2009-07-22  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Beth Dakin.
      
              https://bugs.webkit.org/show_bug.cgi?id=27562
              Add some new layout tests that drop the prefix from the background properties and use origin
              in a shorthand.  Update shorthand results and computed style results to account for new properties.
      
              * fast/backgrounds/size/backgroundSize20.html: Added.
              * fast/backgrounds/size/backgroundSize21.html: Added.
              * fast/backgrounds/size/backgroundSize22.html: Added.
              * fast/css/background-position-serialize-expected.txt:
              * fast/css/remove-shorthand-expected.txt:
              * platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Added.
              * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
              * platform/mac/fast/inspector/style-expected.txt:
              * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddf151e3
    • jorlow@chromium.org's avatar
      WebCore: · f2b8ca8a
      jorlow@chromium.org authored
      2009-07-22  Jens Alfke  <snej@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Hook up V8 bindings for DataGrid elements.
              https://bugs.webkit.org/show_bug.cgi?id=27383
              http://code.google.com/p/chromium/issues/detail?id=16730
      
              Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
              to handle exceptions, check appropriate JS prototypes, and
              test column-list's item() method as well as array-indexing.
      
              * WebCore.gypi: Added new source files.
              * bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
              * bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
              * bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates.
              (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
              * bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource)
              (WebCore::V8DataGridDataSource::V8DataGridDataSource):
              (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
              * bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource)
              (WebCore::V8DataGridDataSource::create):
              (WebCore::V8DataGridDataSource::isJSDataGridDataSource):
              (WebCore::V8DataGridDataSource::jsDataSource):
              (WebCore::asV8DataGridDataSource):
              * bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
              * bindings/v8/V8Index.h: Conditionalize datagrid stuff.
              * bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
              * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Added.
              * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors.
              (WebCore::ACCESSOR_GETTER):
              (WebCore::ACCESSOR_SETTER):
      
      LayoutTests:
      
      2009-07-22  Jens Alfke  <snej@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Hook up V8 bindings for DataGrid elements.
              https://bugs.webkit.org/show_bug.cgi?id=27383
              http://code.google.com/p/chromium/issues/detail?id=16730
      
              Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
              to handle exceptions, check appropriate JS prototypes, and
              test column-list's item() method as well as array-indexing.
      
              * fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
              * fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
              * fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2b8ca8a
    • eric@webkit.org's avatar
      2009-07-22 Eric Seidel <eric@webkit.org> · 9aa63b51
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              expand prototype-inheritance test to cover constructors
              https://bugs.webkit.org/show_bug.cgi?id=27547
      
              * fast/dom/prototype-inheritance-expected.txt:
              * fast/dom/resources/prototype-inheritance.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aa63b51
  3. 21 Jul, 2009 5 commits
    • weinig@apple.com's avatar
      WebCore: · 5b942cb0
      weinig@apple.com authored
      2009-07-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=27242
              JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor
      
              Move the JSC and Objective-C bindings onto using the RGBColor object instead
              of just an unsigned int. The JSC bindings are now completely autogenerated for
              this class. (Also removes the last lut from WebCore).
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
              * bindings/js/JSRGBColor.cpp: Removed.
              * bindings/js/JSRGBColor.h: Removed.
              * bindings/objc/DOM.mm:
              (-[DOMRGBColor _color]):
              * bindings/objc/DOMRGBColor.mm:
              (-[DOMRGBColor dealloc]):
              (-[DOMRGBColor finalize]):
              (-[DOMRGBColor red]):
              (-[DOMRGBColor green]):
              (-[DOMRGBColor blue]):
              (-[DOMRGBColor alpha]):
              (-[DOMRGBColor color]):
              * bindings/scripts/CodeGenerator.pm:
              * bindings/scripts/CodeGeneratorJS.pm:
              * bindings/scripts/CodeGeneratorObjC.pm:
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseColor):
              * css/CSSPrimitiveValue.cpp:
              (WebCore::CSSPrimitiveValue::getRGBColorValue):
              * css/CSSPrimitiveValue.h:
              (WebCore::CSSPrimitiveValue::getRGBA32Value):
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
              * css/RGBColor.cpp:
              (WebCore::RGBColor::alpha):
              * css/RGBColor.h:
              (WebCore::RGBColor::color):
              (WebCore::RGBColor::RGBColor):
              * css/RGBColor.idl:
              * page/DOMWindow.idl:
              * svg/SVGColor.cpp:
              (WebCore::SVGColor::rgbColor):
              * svg/SVGColor.h:
      
      LayoutTests:
      
      2009-07-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Dan Bernstein.
      
              Changes for https://bugs.webkit.org/show_bug.cgi?id=27242
              JSC bindings should use an auto-bound RGBColor class instead of hand-rolled JSRGBColor
      
              * fast/dom/Window/window-properties-expected.txt:
              * fast/dom/dom-constructors-expected.txt:
              * fast/dom/prototype-inheritance-expected.txt:
              * fast/dom/wrapper-classes-expected.txt:
              * fast/js/global-constructors-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b942cb0
    • barraclough@apple.com's avatar
      JavaScriptCore: · 94484965
      barraclough@apple.com authored
      2009-07-21  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
      
              Reviewed by Gavin Barraclough.
      
              Cache not only the structure of the method, but the
              structure of its prototype as well.
              https://bugs.webkit.org/show_bug.cgi?id=27077
      
              * bytecode/CodeBlock.cpp:
              (JSC::CodeBlock::~CodeBlock):
              * bytecode/CodeBlock.h:
              (JSC::MethodCallLinkInfo::MethodCallLinkInfo):
              * jit/JITPropertyAccess.cpp:
              (JSC::JIT::patchMethodCallProto):
      
      LayoutTests:
      
      2009-07-21  Zoltan Herczeg  <zherczeg@inf.u-szeged.hu>
      
              Reviewed by Gavin Barraclough, RS olliej fix to make the test pass.
      
              Check whether a crash happens after the string
              prototype is overwritten twice. The JIT'ed code
              may crash if one of its already cached method
              called again. Note: This test is not necessary
              crash on all systems, because they use different
              memory allocators!
              https://bugs.webkit.org/show_bug.cgi?id=27077
      
              * fast/js/method-check-expected.txt: Added.
              * fast/js/method-check.html: Added.
              * fast/js/resources/method-check.js: Added.
              (func2):
              (func.String.prototype.a):
              (func.String.prototype.b):
              (func):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      94484965
    • mitz@apple.com's avatar
      Correct relative path in the test after moving it. · 8f74b332
      mitz@apple.com authored
              * platform/mac/fast/loader/non-html-load-event.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f74b332
    • mitz@apple.com's avatar
      Rubber-stamped by Mark Rowe. · 4ada412c
      mitz@apple.com authored
              Move fast/loader/non-html-load-event.html under platform/mac because
              non-HTML views exist only on Mac.
      
              * fast/loader/non-html-load-event-expected.txt: Removed.
              * fast/loader/non-html-load-event.html: Removed.
              * platform/mac/fast/loader/non-html-load-event-expected.txt: Copied from LayoutTests/fast/loader/non-html-load-event-expected.txt.
              * platform/mac/fast/loader/non-html-load-event.html: Copied from LayoutTests/fast/loader/non-html-load-event.html.
              * platform/qt/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ada412c
    • hausmann@webkit.org's avatar
      2009-07-21 Simon Hausmann <simon.hausmann@nokia.com> · c32629f8
      hausmann@webkit.org authored
              Reviewed by Tor Arne Vestbø.
      
              Skip fast/loader/non-html-load-event.html for the Qt DRT as it requires
              support for loading PDF documents.
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46171 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c32629f8
  4. 20 Jul, 2009 7 commits
    • agl@chromium.org's avatar
      2009-07-20 Adam Langley <agl@google.com> · 69270353
      agl@chromium.org authored
              Reviewed by Eric Seidel.
      
              Guard access to installedMediaEngines()[0].
      
              https://bugs.webkit.org/show_bug.cgi?id=27479
              http://code.google.com/p/chromium/issues/detail?id=16541
      
              Else where in the file, installedMediaEngines is always checked for
              being empty because access. This patch adds a case which missed that
              check.
      
              This triggered a crash in Chromium:
                  http://www.yakeze.com/chat/example-chromium-crash/
      
              * platform/graphics/MediaPlayer.cpp:
              (WebCore::MediaPlayer::load):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69270353
    • mitz@apple.com's avatar
      Correct expected results from r46136, which accidentally included the · 61ca2145
      mitz@apple.com authored
              DumpRenderTree header and trailer
      
              * fast/loader/non-html-load-event-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      61ca2145
    • rniwa@webkit.org's avatar
      WebCore: · d96f5b41
      rniwa@webkit.org authored
      2009-07-19  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Refactoring of indentRegion to fix bugs 26816 and 25317
              https://bugs.webkit.org/show_bug.cgi?id=26816
              https://bugs.webkit.org/show_bug.cgi?id=25317
              https://bugs.webkit.org/show_bug.cgi?id=23995 (partially)
      
              This patch implements appendParagraphIntoNode, a simpler specialized version of moveParagraph
              and replaces all calls inside indentRegion. The following is the new behavior of indentRegion.
      
              1. We try to indent as many wrapping nodes as possible.
                 e.g. when indenting "hello" in <div>hello</div>, we try to indent div as well.
              2. We do not delete any wrapping elements
                 With moveParagraph, we used to remove all wrapping nodes, and replaced with a blockquote.
                 This was causing https://bugs.webkit.org/show_bug.cgi?id=23995 for indentation.
                 With appendParagraphIntoNode, we can preserve all wrapping nodes.
              3. We only split the tree until the closest block node instead of until the root editable node.
                 This behavioral change fixes the bug 25317.
              4. When multiple paragraphs are indented, we indent the highest common ancestor within the selection.
                 e.g. when a list is a child node of a div, and the entire div is intended,
                      we enclose the div by a single blockquote.
      
              Note that new behavior is more consistent with that of Internet Explorer and Firefox.
              To demonstrate this, the following tests are added.
      
              Tests: editing/execCommand/indent-div-inside-list.html
                     editing/execCommand/indent-nested-blockquotes.html
                     editing/execCommand/indent-nested-div.html
                     editing/execCommand/indent-second-paragraph-in-blockquote.html
      
              * editing/IndentOutdentCommand.cpp: prepareBlockquoteLevelForInsertion is removed
              (WebCore::IndentOutdentCommand::tryIndentingAsListItem): uses appendParagraphIntoNode now
              (WebCore::IndentOutdentCommand::indentIntoBlockquote): uses appendParagraphIntoNode now
              (WebCore::IndentOutdentCommand::appendParagraphIntoNode): removes a paragraph and appends it to a new node
              (WebCore::IndentOutdentCommand::removeUnnecessaryLineBreakAt): removes a break element at the specified position
              (WebCore::IndentOutdentCommand::indentRegion): exhibits the described behavior
              * editing/IndentOutdentCommand.h: updated prototype
              * editing/execCommand/19653-1-expected.txt: rebaselined (no longer removes wrapping div)
              * editing/execCommand/indent-div-inside-list-expected.txt: Added.
              * editing/execCommand/indent-div-inside-list.html: Added.
              * editing/execCommand/indent-nested-blockquotes-expected.txt: Added.
              * editing/execCommand/indent-nested-blockquotes.html: Added.
              * editing/execCommand/indent-nested-div-expected.txt: Added.
              * editing/execCommand/indent-nested-div.html: Added.
              * editing/execCommand/indent-nested-lists-2-expected.txt: rebaselined (selection corrected)
              * editing/execCommand/indent-nested-lists-3-expected.txt: rebaselined (selection corrected)
              * editing/execCommand/indent-nested-lists-4-expected.txt: rebaselined (selection corrected)
              * editing/execCommand/indent-nested-lists-5-expected.txt: rebaselined (selection corrected)
              * editing/execCommand/indent-second-paragraph-in-blockquote-expected.txt: Added.
              * editing/execCommand/indent-second-paragraph-in-blockquote.html: Added.
              * platform/mac/editing/execCommand/4641880-2-expected.txt: rebaselined
              * platform/mac/editing/execCommand/4916541-expected.txt: rebaselined (no longer removes wrapping span)
              * platform/mac/editing/execCommand/5138441-expected.txt: rebaselined
              * platform/mac/editing/execCommand/5481523-expected.txt: rebaselined
              * platform/mac/editing/execCommand/indent-selection-expected.txt: rebaselined
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46142 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d96f5b41
    • pdherbemont@apple.com's avatar
      WebCore: · a71bfdba
      pdherbemont@apple.com authored
      2009-07-17  Pierre d'Herbemont  <pdherbemont@apple.com>
      
              Reviewed by Eric Seidel.
      
              Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
              https://bugs.webkit.org/show_bug.cgi?id=27380
      
              Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.
      
              * css/mediaControlsQT.css:
      
      LayoutTests:
      
      2009-07-17  Pierre d'Herbemont  <pdherbemont@apple.com>
      
              Reviewed by Eric Seidel.
      
              Media Controls: We are specifying the text height, where it is unneeded and the slider is 2px off.
              https://bugs.webkit.org/show_bug.cgi?id=27380
      
              Adjust the margin of the slider and remove useless height specification to fix alignement of the media controls.
      
              * platform/mac/media/controls-after-reload-expected.txt:
              * platform/mac/media/controls-styling-expected.checksum: Removed.
              * platform/mac/media/controls-styling-expected.png: Removed.
              * platform/mac/media/controls-styling-expected.txt:
              * platform/mac/media/video-zoom-controls-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a71bfdba
    • eric@webkit.org's avatar
      2009-07-20 Eric Seidel <eric@webkit.org> · a1f08621
      eric@webkit.org authored
              Reviewed by Sam Weinig.
      
              Fix failures seen on the bots
              https://bugs.webkit.org/show_bug.cgi?id=27463
      
              Ignore more global variables added by DumpRenderTree.
              Some platforms don't add all of the DRT controllers,
              thus causing this test to fail for those platforms.
      
              Also fix !value to value === null to handle not
              skip the cases where value == 0.
      
              * fast/dom/prototype-inheritance-expected.txt:
              * fast/dom/resources/prototype-inheritance.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46138 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1f08621
    • mitz@apple.com's avatar
      WebCore: · ab752611
      mitz@apple.com authored
              Reviewed by Anders Carlsson.
      
              When loading a custom view into a frame, the old document is still
              around
              <rdar://problem/5145841>
      
              Safari fires onload before PDF is loaded into the browser
              <rdar://problem/6618869>
      
              Test: fast/loader/non-html-load-event.html
      
              * GNUmakefile.am: Added PlaceholderDocument.{cpp,h}
              * WebCore.gypi: Ditto.
              * WebCore.pro: Ditto.
              * WebCore.vcproj/WebCore.vcproj: Ditto.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
              * WebCoreSources.bkl: Ditto.
              * dom/Document.h:
              (WebCore::Document::setStyleSelector): Added this protected accessor for
                  PlaceholderDocument to use.
              * dom/Element.cpp:
              (WebCore::Element::clientWidth): Check whether the document has a
                  renderer.
              (WebCore::Element::clientHeight): Ditto.
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::begin): Create a PlaceholderDocument for frames
                  that do not use an HTML view. Do not nullify the content size in
                  that case.
              (WebCore::FrameLoader::transitionToCommitted): For frames that do not
                  use an HTML view, call receivedFirstData(), which sets up the
                  frame with a new PlaceHolderDocument.
              * loader/PlaceholderDocument.cpp: Added.
              (WebCore::PlaceholderDocument::attach): Sets up the style selector but
                  does not create a RenderView.
              * loader/PlaceholderDocument.h: Added.
              (WebCore::PlaceholderDocument::create):
              (WebCore::PlaceholderDocument::PlaceholderDocument):
      
      LayoutTests:
      
              Reviewed by Anders Carlsson.
      
              Safari fires onload before PDF is loaded into the browser
              <rdar://problem/6618869>
      
              * fast/loader/non-html-load-event-expected.txt: Added.
              * fast/loader/non-html-load-event.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46136 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab752611
    • hausmann@webkit.org's avatar
      2009-07-19 Simon Hausmann <hausmann@webkit.org> · c692cf0e
      hausmann@webkit.org authored
              Rubber-stamped by Xan Lopez.
      
              Skip new fast/dom/prototype-inheritance.html test in the Qt DRT
              due to missing features/properties in the window object.
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46107 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c692cf0e
  5. 19 Jul, 2009 1 commit
  6. 18 Jul, 2009 6 commits
    • mitz@apple.com's avatar
      Added Radar URLs · 21c57377
      mitz@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21c57377
    • mitz@apple.com's avatar
      WebCore: · a9c2ab12
      mitz@apple.com authored
              Reviewed by Anders Carlsson.
      
              Add spread radius support to -webkit-box-shadow
              https://bugs.webkit.org/show_bug.cgi?id=27417
      
              Test: fast/box-shadow/spread.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::valueForShadow): Added a property ID parameter and used it to
                  include the spread length for box-shadow but not for text-shadow.
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
                  Pass the property ID to valueForShadow().
      
              * css/CSSParser.cpp:
              (WebCore::ShadowParseContext::ShadowParseContext): Added property,
                  spread, and allowSpread members. Added a property ID parameter to
                  the constructor. Initialize the property and allowSpread members.
              (WebCore::ShadowParseContext::allowLength): Added allowSpread.
              (WebCore::ShadowParseContext::commitValue): Pass the spread value to
                  the ShadowValue constructor. Reset allowSpread.
              (WebCore::ShadowParseContext::commitLength): Allow spread after blur
                  for the box-shadow property.
              (WebCore::ShadowParseContext::commitColor): Reset allowSpread.
              (WebCore::CSSParser::parseShadow): Pass the property ID to
                  ShadowParseContext().
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty): Get the spread value from
                  the shadow value and pass it to the ShadowData constructor.
      
              * css/ShadowValue.cpp:
              (WebCore::ShadowValue::ShadowValue): Added spread.
              (WebCore::ShadowValue::cssText): Added spread.
      
              * css/ShadowValue.h:
              (WebCore::ShadowValue::create): Added spread.
      
              * page/animation/AnimationBase.cpp:
              (WebCore::blendFunc): Blend the spread value.
              (WebCore::PropertyWrapperShadow::blend): Added 0 spread to the default
                  shadow.
      
              * rendering/InlineFlowBox.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally): Account for spread in
                  the visual overflow calculations.
              (WebCore::InlineFlowBox::placeBoxesVertically): Ditto.
              (WebCore::InlineFlowBox::paint): Ditto.
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::overflowHeight): Ditto.
              (WebCore::RenderBlock::overflowWidth): Ditto.
              (WebCore::RenderBlock::overflowLeft): Ditto.
              (WebCore::RenderBlock::overflowTop): Ditto.
              (WebCore::RenderBlock::overflowRect): Ditto.
              (WebCore::RenderBlock::layoutBlock): Ditto.
      
              * rendering/RenderBoxModelObject.cpp:
              (WebCore::RenderBoxModelObject::paintBoxShadow): Inflate the shadow-
                  casting rect by the shadow spread value. Adjust border radii if
                  necessary.
      
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::layoutBlock): Account for spread in the
                  visual overflow calculations.
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::calculateRects): Ditto.
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Account for spread.
              (WebCore::RenderObject::adjustRectForOutlineAndShadow): Ditto.
      
              * rendering/RenderReplaced.cpp:
              (WebCore::RenderReplaced::adjustOverflowForBoxShadowAndReflect): Ditto.
      
              * rendering/style/RenderStyle.cpp:
              (WebCore::RenderStyle::setTextShadow): Assert that text shadows do not
                  have spread.
      
              * rendering/style/ShadowData.cpp:
              (WebCore::ShadowData::ShadowData): Added spread.
              (WebCore::ShadowData::operator==): Compare spread.
              * rendering/style/ShadowData.h:
              (WebCore::ShadowData::ShadowData): Added spread.
      
      LayoutTests:
      
              Reviewed by Anders Carlsson.
      
              Test box-shadow spread radius
              https://bugs.webkit.org/show_bug.cgi?id=27417
      
              * fast/box-shadow/spread.html: Added.
              * platform/mac/fast/box-shadow/spread-expected.checksum: Added.
              * platform/mac/fast/box-shadow/spread-expected.png: Added.
              * platform/mac/fast/box-shadow/spread-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46097 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9c2ab12
    • jmalonzo@webkit.org's avatar
      2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org> · 06149826
      jmalonzo@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=27145
              [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html fails after r45615
      
              Reviewed by Gustavo Noronha.
      
              * platform/gtk/Skipped:
      
              Normalize file URLs.
      
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (dumpHistoryItem):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46096 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06149826
    • jmalonzo@webkit.org's avatar
      2009-07-18 Jan Michael Alonzo <jmalonzo@webkit.org> · 32ca8bb0
      jmalonzo@webkit.org authored
              [Gtk] Skip tests that require new expected results, eventSender
              and editing callbacks DRT support. Unreviewed.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46090 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32ca8bb0
    • jorlow@chromium.org's avatar
      WebCore: · 18168f82
      jorlow@chromium.org authored
      2009-07-18  Jeremy Orlow  <jorlow@chromium.org>
      
              Rubber stamped by Adam Barth.
      
              Revert https://bugs.webkit.org/show_bug.cgi?id=27383
              https://bugs.webkit.org/show_bug.cgi?id=27407
      
              Revert Jens' patch.  I believe he forgot to include a file.
      
              * WebCore.gypi:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/DOMObjectsInclude.h:
              * bindings/v8/V8DOMWrapper.cpp:
              (WebCore::V8DOMWrapper::getTemplate):
              * bindings/v8/V8DataGridDataSource.cpp: Removed.
              * bindings/v8/V8DataGridDataSource.h: Removed.
              * bindings/v8/V8GCController.h:
              * bindings/v8/V8Index.h:
              * bindings/v8/custom/V8CustomBinding.h:
              * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp:
              (WebCore::ACCESSOR_GETTER):
              (WebCore::ACCESSOR_SETTER):
      
      LayoutTests:
      
      2009-07-18  Jeremy Orlow  <jorlow@chromium.org>
      
              Rubber stamped by Adam Barth.
      
              Revert https://bugs.webkit.org/show_bug.cgi?id=27383
              https://bugs.webkit.org/show_bug.cgi?id=27407
      
              Revert Jens' patch.  I believe he forgot to include a file.
      
              * fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
              * fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
              * fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46087 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18168f82
    • abarth@webkit.org's avatar
      2009-07-17 Daniel Bates <dbates@intudata.com> · 209a4aa2
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27405
      
              Tests that HTML entities that contain an invalid entity, such as an
              unknown named entity, are properly handled.
      
              * http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt: Added.
              * http/tests/security/xssAuditor/link-onclick-ampersand.html: Added.
              * http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt: Added.
              * http/tests/security/xssAuditor/javascript-link-ampersand.html: Added.
      
      2009-07-17  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27405
      
              Fixes an issue when decoding HTML entities with an unknown named entity that
              caused null-characters to be inserted into the decoded result.
      
              Test: http/tests/security/xssAuditor/link-onclick-ampersand.html
                    http/tests/security/xssAuditor/javascript-link-ampersand.html
      
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::decodeHTMLEntities): Added check to conditional so that
              non-zero entity values are not inserted during decoding process.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46086 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      209a4aa2
  7. 17 Jul, 2009 8 commits
    • abarth@webkit.org's avatar
      2009-07-17 Mads Ager <ager@chromium.org> · 4cfb777d
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27403
              Add test case for https://bugs.webkit.org/show_bug.cgi?id=27394:
              properties on a window object should be accessible after the frame
              of the window object has navigated to another site.
      
              * fast/dom/Window/window-access-after-navigation-expected.txt: Added.
              * fast/dom/Window/window-access-after-navigation.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46083 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4cfb777d
    • jorlow@chromium.org's avatar
      WebCore: · 184481bb
      jorlow@chromium.org authored
      2009-07-17  Jens Alfke  <snej@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Hook up V8 bindings for DataGrid elements.
              https://bugs.webkit.org/show_bug.cgi?id=27383
              http://code.google.com/p/chromium/issues/detail?id=16730
      
              Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
              to handle exceptions, check appropriate JS prototypes, and
              test column-list's item() method as well as array-indexing.
      
              * WebCore.gypi: Added new source files.
              * bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
              * bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
              * bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates.
              (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
              * bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource)
              (WebCore::V8DataGridDataSource::V8DataGridDataSource):
              (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
              * bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource)
              (WebCore::V8DataGridDataSource::create):
              (WebCore::V8DataGridDataSource::isJSDataGridDataSource):
              (WebCore::V8DataGridDataSource::jsDataSource):
              (WebCore::asV8DataGridDataSource):
              * bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
              * bindings/v8/V8Index.h: Conditionalize datagrid stuff.
              * bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
              * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors.
              (WebCore::ACCESSOR_GETTER):
              (WebCore::ACCESSOR_SETTER):
      
      LayoutTests:
      
      2009-07-17  Jens Alfke  <snej@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Hook up V8 bindings for DataGrid elements.
              https://bugs.webkit.org/show_bug.cgi?id=27383
              http://code.google.com/p/chromium/issues/detail?id=16730
      
              Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
              to handle exceptions, check appropriate JS prototypes, and
              test column-list's item() method as well as array-indexing.
      
              * fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
              * fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
              * fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46077 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      184481bb
    • ap@webkit.org's avatar
      Reviewed by Dan Bernstein. · b50f0304
      ap@webkit.org authored
              https://bugs.webkit.org/show_bug.cgi?id=27396
              Moving cursor in Thai text sometimes jumps over two characters
      
              Test: editing/text-iterator/thai-cursor-movement.html
      
              * platform/text/TextBreakIteratorICU.cpp: (WebCore::cursorMovementIterator): Added a special
              case for five Thai characters, matching ICU/CLDR changes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46069 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b50f0304
    • eric@webkit.org's avatar
      2009-07-14 Eric Seidel <eric@webkit.org> · 09dc0ee4
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Some constructor objects exposed on Window have the wrong prototype chain
              https://bugs.webkit.org/show_bug.cgi?id=27276
      
              * fast/dom/prototype-inheritance-expected.txt: Added.
              * fast/dom/prototype-inheritance.html: Added.
              * fast/dom/resources/prototype-inheritance.js: Added.
      
      2009-07-14  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Adam Barth.
      
              Some constructor objects exposed on Window have the wrong prototype chain
              https://bugs.webkit.org/show_bug.cgi?id=27276
      
              Several Constructor classes were already being passed a global object
              during construction, but they were ignoring it for prototype lookup.
              I've fixed those to use the passed global object instead.
      
              Most of these Constructor classes should just be auto-generated, but I
              refrained from changing them over to auto-gen in this patch.
      
              Fixed CodeGeneratorJS to pass a global object to getDOMConstructor when
              available, otherwise default to deprecatedGlobalObjectForPrototype(exec)
              to match existing behavior.
      
              Test: fast/dom/prototype-inheritance.html
      
              * bindings/js/JSAudioConstructor.cpp:
              (WebCore::JSAudioConstructor::JSAudioConstructor): use the existing globalObject pointer for prototype lookup
              * bindings/js/JSDOMBinding.h:
              (WebCore::deprecatedGlobalObjectForPrototype): Make it easy to detect where the wrong global object is being used.
              (WebCore::deprecatedGetDOMStructure):
              * bindings/js/JSDOMGlobalObject.h: remove error-prone getDOMConstructor, require passing JSDOMGlobalObject*
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::webKitPoint): pass "this" for the global object.
              (WebCore::JSDOMWindow::webKitCSSMatrix): pass "this" for the global object.
              (WebCore::JSDOMWindow::xsltProcessor): pass "this" for the global object.
              (WebCore::JSDOMWindow::worker): pass "this" for the global object.
              * bindings/js/JSImageConstructor.cpp:
              (WebCore::JSImageConstructor::JSImageConstructor): use the existing globalObject pointer for prototype lookup
              * bindings/js/JSMessageChannelConstructor.cpp:
              (WebCore::JSMessageChannelConstructor::JSMessageChannelConstructor): use the existing globalObject pointer for prototype lookup
              * bindings/js/JSOptionConstructor.cpp:
              (WebCore::JSOptionConstructor::JSOptionConstructor): use the existing globalObject pointer for prototype lookup
              * bindings/js/JSWebKitCSSMatrixConstructor.cpp:
              (WebCore::JSWebKitCSSMatrixConstructor::JSWebKitCSSMatrixConstructor): add new globalObject parameter and use it
              * bindings/js/JSWebKitCSSMatrixConstructor.h:
              * bindings/js/JSWebKitPointConstructor.cpp:
              (WebCore::JSWebKitPointConstructor::JSWebKitPointConstructor): add new globalObject parameter and use it
              * bindings/js/JSWebKitPointConstructor.h:
              * bindings/js/JSWorkerConstructor.cpp:
              (WebCore::JSWorkerConstructor::JSWorkerConstructor): add new globalObject parameter and use it
              * bindings/js/JSWorkerConstructor.h:
              * bindings/js/JSXMLHttpRequestConstructor.cpp:
              (WebCore::JSXMLHttpRequestConstructor::JSXMLHttpRequestConstructor): use the existing globalObject pointer for prototype lookup
               -- XMLHttpRequest constructor was also missing a length.  Added one.
              * bindings/js/JSXSLTProcessorConstructor.cpp:
              (WebCore::JSXSLTProcessorConstructor::JSXSLTProcessorConstructor):
              * bindings/js/JSXSLTProcessorConstructor.h:
              * bindings/scripts/CodeGeneratorJS.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46068 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09dc0ee4
    • pkasting@chromium.org's avatar
      LayoutTests: · b8a7204b
      pkasting@chromium.org authored
      2009-07-17  Michelangelo De Simone  <micdesim@gmail.com>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=25551
              Test suite for the required attribute, the valueMissing flag and new
              :required and :optional CSS pseudoclasses.
              Part of the HTML5 sec. Forms.
              http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required
      
              * fast/css/pseudo-required-optional-001-expected.txt: Added.
              * fast/css/pseudo-required-optional-001.html: Added.
              * fast/css/pseudo-required-optional-002-expected.txt: Added.
              * fast/css/pseudo-required-optional-002.html: Added.
              * fast/css/pseudo-required-optional-003-expected.txt: Added.
              * fast/css/pseudo-required-optional-003.html: Added.
              * fast/css/pseudo-required-optional-004-expected.txt: Added.
              * fast/css/pseudo-required-optional-004.html: Added.
              * fast/css/pseudo-required-optional-005-expected.txt: Added.
              * fast/css/pseudo-required-optional-005.html: Added.
              * fast/css/pseudo-required-optional-006-expected.txt: Added.
              * fast/css/pseudo-required-optional-006.html: Added.
              * fast/forms/ValidityState-valueMissing-001-expected.txt: Added.
              * fast/forms/ValidityState-valueMissing-001.html: Added.
              * fast/forms/ValidityState-valueMissing-002-expected.txt: Added.
              * fast/forms/ValidityState-valueMissing-002.html: Added.
              * fast/forms/ValidityState-valueMissing-003-expected.txt: Added.
              * fast/forms/ValidityState-valueMissing-003.html: Added.
              * fast/forms/ValidityState-valueMissing-004-expected.txt: Added.
              * fast/forms/ValidityState-valueMissing-004.html: Added.
              * fast/forms/ValidityState-valueMissing-005-expected.txt: Added.
              * fast/forms/ValidityState-valueMissing-005.html: Added.
              * fast/forms/ValidityState-valueMissing-006-expected.txt: Added.
              * fast/forms/ValidityState-valueMissing-006.html: Added.
              * fast/forms/ValidityState-valueMissing-007-expected.txt: Added.
              * fast/forms/ValidityState-valueMissing-007.html: Added.
              * fast/forms/ValidityState-valueMissing-008-expected.txt: Added.
              * fast/forms/ValidityState-valueMissing-008.html: Added.
              * fast/forms/ValidityState-valueMissing-009-expected.txt: Added.
              * fast/forms/ValidityState-valueMissing-009.html: Added.
              * fast/forms/required-attribute-001-expected.txt: Added.
              * fast/forms/required-attribute-001.html: Added.
              * fast/forms/required-attribute-002-expected.txt: Added.
              * fast/forms/required-attribute-002.html: Added.
      
      WebCore:
      
      2009-07-17  Michelangelo De Simone  <micdesim@gmail.com>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=25551
              Added support for the "required" attribute, the valueMissing flag
              to the ValidityState object and :required/:optional CSS pseudoclasses.
              Part of HTML5 sec. Forms specs.
              http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#attr-input-required
      
              Tests: fast/css/pseudo-required-optional-001.html
                     fast/css/pseudo-required-optional-002.html
                     fast/css/pseudo-required-optional-003.html
                     fast/css/pseudo-required-optional-004.html
                     fast/css/pseudo-required-optional-005.html
                     fast/css/pseudo-required-optional-006.html
                     fast/forms/ValidityState-valueMissing-001.html
                     fast/forms/ValidityState-valueMissing-002.html
                     fast/forms/ValidityState-valueMissing-003.html
                     fast/forms/ValidityState-valueMissing-004.html
                     fast/forms/ValidityState-valueMissing-005.html
                     fast/forms/ValidityState-valueMissing-006.html
                     fast/forms/ValidityState-valueMissing-007.html
                     fast/forms/ValidityState-valueMissing-008.html
                     fast/forms/ValidityState-valueMissing-009.html
                     fast/forms/required-attribute-001.html
                     fast/forms/required-attribute-002.html
      
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::extractPseudoType): pseudoRequired/pseudoOptional
              * css/CSSSelector.h:
              (WebCore::CSSSelector::): ditto
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto
              * dom/Element.h:
              (WebCore::Element::isOptionalFormControl): check for optional controls
              (WebCore::Element::isRequiredFormControl): check for required controls
              * html/HTMLAttributeNames.in: required attribute
              * html/HTMLButtonElement.h:
              (WebCore::HTMLButtonElement::isOptionalFormControl): ditto
              * html/HTMLFormControlElement.cpp:
              (WebCore::HTMLFormControlElement::required): requiredAttr getter
              (WebCore::HTMLFormControlElement::setRequired): requiredAttr setter
              * html/HTMLFormControlElement.h:
              (WebCore::HTMLFormControlElement::valueMissing): method definition
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::valueMissing): validation code
              (WebCore::HTMLInputElement::isRequiredFormControl): ditto
              * html/HTMLInputElement.h:
              (WebCore::HTMLInputElement::isOptionalFormControl): ditto
              * html/HTMLInputElement.idl: required DOM attribute
              * html/HTMLSelectElement.h:
              (WebCore::HTMLSelectElement::isOptionalFormControl): ditto
              * html/HTMLTextAreaElement.h:
              (WebCore::HTMLTextAreaElement::valueMissing): validation code
              (WebCore::HTMLTextAreaElement::isOptionalFormControl): ditto
              (WebCore::HTMLTextAreaElement::isRequiredFormControl): ditto
              * html/HTMLTextAreaElement.idl: required DOM attribute
              * html/ValidityState.cpp:
              * html/ValidityState.h:
              (WebCore::ValidityState::valueMissing): validation flag
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46062 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8a7204b
    • levin@chromium.org's avatar
      WebCore: · 1f1b9890
      levin@chromium.org authored
      2009-07-17  Drew Wilson  <atwilson@google.com>
      
              Reviewed by David Levin.
      
              Need to refactor Worker to derive from AbstractWorker
              https://bugs.webkit.org/show_bug.cgi?id=26948
      
              Changed Worker to derive from AbstractWorker, which involved moving
              AbstractWorker files from being wrapped by ENABLE_SHARED_WORKERS to
              ENABLE_WORKERS.
      
              Removed obsolete functionality from the JS/V8 bindings that is now
              inherited from AbstractWorker.
      
              * WebCore.pro:
              Moved AbstractWorker files out of SHARED_WORKERS section and into WORKERS.
              * bindings/js/JSAbstractWorkerCustom.cpp:
              Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
              * bindings/js/JSWorkerCustom.cpp:
              Removed obsolete event listener code (now in base class)
              (WebCore::JSWorker::mark):
              No longer need to explicitly mark event listeners (handled by base class).
              * bindings/v8/V8Index.h:
              Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
              * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
              Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
              * bindings/v8/custom/V8CustomBinding.h:
              Moved AbstractWorker lines out of SHARED_WORKERS section and into WORKERS.
              * bindings/v8/custom/V8WorkerCustom.cpp:
              Removed obsolete event listener code that now lives in the base class.
              (WebCore::V8WorkerConstructor): Cleaned up legacy style nits.
              * workers/AbstractWorker.cpp:
              Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
              * workers/AbstractWorker.h:
              Changed to be wrapped by ENABLE(WORKERS), not ENABLE(SHARED_WORKERS).
              * workers/Worker.cpp:
              Removed event listener code (now in base class).
              (WebCore::Worker::Worker): Now derives from AbstractWorker.
              (WebCore::Worker::notifyFinished): Calls dispatchLoadErrorEvent on base class.
              * workers/Worker.h:
              Removed APIs that now live in the base class.
              * workers/Worker.idl:
              Now derives from AbstractWorker.
              Removed APIs that live in the base class, and added a GenerateToJS flag.
      
      LayoutTests:
      
      2009-07-17  Drew Wilson  <atwilson@google.com>
      
              Reviewed by David Levin.
      
              Need to refactor Worker to derive from AbstractWorker
              https://bugs.webkit.org/show_bug.cgi?id=26948
      
              Added checks to make sure that Workers are properly constructed and Worker attributes
              are visible on the resulting object.
      
              * fast/workers/worker-constructor-expected.txt:
              * fast/workers/worker-constructor.html:
              Added explicit check for correct construction/postMessage visibility.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f1b9890
    • hyatt@apple.com's avatar
      WebCore: · 88290755
      hyatt@apple.com authored
      2009-07-17  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=27379
              Absolutely-positioned elements with a scrollbar wrap prematurely.  Make sure to include
              the vertical scrollbar width for overflow:scroll elements.
      
              Added fast/css/positioned-overflow-scroll.html
      
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::calcPrefWidths):
              * rendering/RenderFlexibleBox.cpp:
              (WebCore::RenderFlexibleBox::calcPrefWidths):
      
      LayoutTests:
      
      2009-07-17  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=27379
              Absolutely-positioned elements with a scrollbar wrap prematurely.  Make sure to include
              the vertical scrollbar width for overflow:scroll elements.
      
              * fast/css/positioned-overflow-scroll.html: Added.
              * platform/mac/fast/css/positioned-overflow-scroll-expected.checksum: Added.
              * platform/mac/fast/css/positioned-overflow-scroll-expected.png: Added.
              * platform/mac/fast/css/positioned-overflow-scroll-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88290755
    • hausmann@webkit.org's avatar
      2009-07-17 Kenneth Rohde Christiansen <kenneth.christiansen@openbossa.org> · fc43c8da
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Remove tests from Qt Skipped list that are actually working.
              https://bugs.webkit.org/show_bug.cgi?id=27316
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fc43c8da
  8. 16 Jul, 2009 1 commit