1. 23 Jul, 2009 19 commits
  2. 22 Jul, 2009 21 commits
    • sfalken@apple.com's avatar
      Checkpoint new Windows nightly launcher. · 5439bc8d
      sfalken@apple.com authored
              
              Reviewed by Mark Rowe.
      
              * WebKitLauncherWin: Added.
              * WebKitLauncherWin/Resource.h: Added.
              * WebKitLauncherWin/WebKitLauncherWin.cpp: Added.
              (getStringValue): Retrieve a string registry value.
              (applePathFromRegistry): Get an Apple-related path out of the registry.
              (copyEnvironmentVariable): Copy an environment variable.
              (safariInstallDir): Helper function to get the install directory for Safari.
              (safariBrowserExe): Helper function to get the full path of the Safari executable.
              (_tWinMain): Locate Safari and launch it after setting up an environment variable.
              * WebKitLauncherWin/WebKitLauncherWin.h: Added.
              * WebKitLauncherWin/WebKitLauncherWin.rc: Added.
              * WebKitLauncherWin/WebKitLauncherWin.vcproj: Added.
              * WebKitLauncherWin/webkit.ico: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5439bc8d
    • abarth@webkit.org's avatar
      2009-07-22 Adam Barth <abarth@webkit.org> · 95b02cfa
      abarth@webkit.org authored
              Reviewed by Alexey Proskuryakov.
      
              Remove unneeded virtual destructor from ScriptSourceProvider
              https://bugs.webkit.org/show_bug.cgi?id=27563
      
              * bindings/js/ScriptSourceProvider.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95b02cfa
    • rniwa@webkit.org's avatar
      2009-07-22 Ryosuke Niwa <rniwa@webkit.org> · 885c66aa
      rniwa@webkit.org authored
              Reviewed by Adam Barth.
      
              REGRESSION (r46240): /fast/css/getComputedStyle/computed-style & computed-style-without-renderer needs rebaseline for Windows
              https://bugs.webkit.org/show_bug.cgi?id=27591
      
              Rebaselines the tests.
      
              * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      885c66aa
    • rniwa@webkit.org's avatar
      WebCore: · 076531a0
      rniwa@webkit.org authored
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
              https://bugs.webkit.org/show_bug.cgi?id=27476
      
              executeStrikethrough and executeUnderline were toggling between "line-through" / "underline" and "none".
              This patch adds executeToggleStyleInList that toggles a style in CSSValueList instead of toggling the entire value.
              It modifies CSSComputedStyleDeclaration to return CSSValueList instead of CSSPrimitiveValue for text decorations,
              and adds removeAll member function to CSSValueList.
      
              Tests: editing/execCommand/toggle-text-decorations.html
                     fast/css/getComputedStyle/getComputedStyle-text-decoration.html
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::renderTextDecorationFlagsToCSSValue): Creates a CSSValueList
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Returns a CSSValueList instead of CSSValue
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue): Text decorations are space separated instead of comma separated
              * css/CSSValueList.cpp:
              (WebCore::CSSValueList::removeAll): Removes all values that match the specified value
              * css/CSSValueList.h:
              * editing/EditorCommand.cpp:
              (WebCore::applyCommandToFrame): Apply style to a frame using specified command
              (WebCore::executeApplyStyle): Uses applyCommandToFrame
              (WebCore::executeToggleStyleInList): Uses applyCommandToFrame
              (WebCore::executeToggleStyle): Toggles a style in CSSValueList
              (WebCore::executeStrikethrough): Uses executeToggleStyleInList
              (WebCore::executeUnderline): Uses executeToggleStyleInList
      
      LayoutTests:
      
      2009-07-22  Ryosuke Niwa  <rniwa@webkit.org>
      
              Reviewed by Eric Seidel.
      
              execCommand('underline' / 'strikeThrough') doesn't work properly with multiple styles in text-decoration
              https://bugs.webkit.org/show_bug.cgi?id=27476
      
              toggle-text-decorations checks whether we can toggle text decorations with multiple styles properly.
              e.g. execCommand("underline") should modify "text-decoration: underline overline" to "text-decoration: overline"
      
              getComputedStyle-text-decorations checks whether the CSS value of text decoration and its computed style are
              both space-separated CSSValueList instead of CSSPrimitiveValue or comma-separated CSSValueList.
      
              * editing/execCommand/resources/toggle-text-decorations.js: Added.
              (testSingleToggle):
              * editing/execCommand/toggle-text-decorations-expected.txt: Added.
              * editing/execCommand/toggle-text-decorations.html: Added.
              * fast/css/getComputedStyle/getComputedStyle-text-decoration-expected.txt: Added.
              * fast/css/getComputedStyle/getComputedStyle-text-decoration.html: Added.
              * fast/css/getComputedStyle/resources: Added.
              * fast/css/getComputedStyle/resources/TEMPLATE.html: Added.
              * fast/css/getComputedStyle/resources/getComputedStyle-text-decoration.js: Added.
              (expect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      076531a0
    • abarth@webkit.org's avatar
      2009-07-22 Daniel Bates <dbates@intudata.com> · 1f56a65a
      abarth@webkit.org authored
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27174
              And
              https://bugs.webkit.org/show_bug.cgi?id=26938
      
              Tests prevention of attacks transformed by PHP Magic Quotes/PHP addslashes().
      
              * http/tests/security/xssAuditor/resources/echo-intertag-addslashes.pl: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-backslash.html: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-null-char.html: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt: Added.
              * http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html: Added.
      
      2009-07-22  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=27174
              And
              https://bugs.webkit.org/show_bug.cgi?id=26938
      
              Code cleanup. Implements support for detecting attacks transformed by
              PHP Magic Quotes/PHP addslashes().
      
              Tests: http/tests/security/xssAuditor/script-tag-addslashes-backslash.html
                     http/tests/security/xssAuditor/script-tag-addslashes-double-quote.html
                     http/tests/security/xssAuditor/script-tag-addslashes-null-char.html
                     http/tests/security/xssAuditor/script-tag-addslashes-single-quote.html
      
              * page/XSSAuditor.cpp:
              (WebCore::isInvalidCharacter):
              (WebCore::XSSAuditor::canEvaluate):
              (WebCore::XSSAuditor::canEvaluateJavaScriptURL):
              (WebCore::XSSAuditor::canLoadObject):
              (WebCore::XSSAuditor::normalize): Decodes HTML entities, removes backslashes,
              and removes control characters that could otherwise cause a discrepancy between
              the source code of a script and the outgoing HTTP parameters.
              (WebCore::XSSAuditor::decodeURL):
              (WebCore::XSSAuditor::decodeHTMLEntities):
              (WebCore::XSSAuditor::findInRequest):
              * page/XSSAuditor.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f56a65a
    • levin@chromium.org's avatar
      2009-07-22 David Levin <levin@chromium.org> · afae2f5b
      levin@chromium.org authored
              Reviewed by Adam Treat.
      
              run-webkit-lint should be named check-webkit-style
              https://bugs.webkit.org/show_bug.cgi?id=27568
      
              This name better reflects the fact that it is about checking the style of files.
      
              * Scripts/check-webkit-style: Renamed from WebKitTools/Scripts/run-webkit-lint.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afae2f5b
    • treat@webkit.org's avatar
      2009-07-22 Jakob Petsovits <jakob.petsovits@torchmobile.com> · cda7d0b0
      treat@webkit.org authored
              Reviewed by Adam Treat.
      
              Fix false positives in namespace indentation checks.
              https://bugs.webkit.org/show_bug.cgi?id=27567
      
              The regular expression detecting goto labels (in order
              to skip those) was too permissive, which caused other
              code like "Foo::Bar()" to be treated as a label too,
              thereby not stopping the processing loop as expected.
      
              Now comes with a stricter regexp, and more demanding
              test cases to check for these issues.
      
              * Scripts/modules/cpplint.py:
              * Scripts/modules/cpplint_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cda7d0b0
    • barraclough@apple.com's avatar
      2009-07-22 Gavin Barraclough <barraclough@apple.com> · 1444b28f
      barraclough@apple.com authored
              Reviewed by Sam Weinig.
      
              With ENABLE(ASSEMBLER_WX_EXCLUSIVE), only change permissions once per repatch event.
              ( https://bugs.webkit.org/show_bug.cgi?id=27564 )
      
              Currently we change permissions forwards and backwards for each instruction modified,
              instead we should only change permissions once per complete repatching event.
      
              2.5% progression running with ENABLE(ASSEMBLER_WX_EXCLUSIVE) enabled,
              which recoups 1/3 of the penalty of running with this mode enabled.
      
              * assembler/ARMAssembler.cpp:
              (JSC::ARMAssembler::linkBranch):
                  - Replace usage of MakeWritable with cacheFlush.
              
              * assembler/ARMAssembler.h:
              (JSC::ARMAssembler::patchPointerInternal):
              (JSC::ARMAssembler::repatchLoadPtrToLEA):
                  - Replace usage of MakeWritable with cacheFlush.
      
              * assembler/ARMv7Assembler.h:
              (JSC::ARMv7Assembler::relinkJump):
              (JSC::ARMv7Assembler::relinkCall):
              (JSC::ARMv7Assembler::repatchInt32):
              (JSC::ARMv7Assembler::repatchPointer):
              (JSC::ARMv7Assembler::repatchLoadPtrToLEA):
              (JSC::ARMv7Assembler::setInt32):
                  - Replace usage of MakeWritable with cacheFlush.
      
              * assembler/LinkBuffer.h:
              (JSC::LinkBuffer::performFinalization):
                  - Make explicit call to cacheFlush.
      
              * assembler/MacroAssemblerCodeRef.h:
              (JSC::MacroAssemblerCodeRef::MacroAssemblerCodeRef):
                  - Make size always available.
      
              * assembler/RepatchBuffer.h:
              (JSC::RepatchBuffer::RepatchBuffer):
              (JSC::RepatchBuffer::~RepatchBuffer):
                  - Add calls to MakeWritable & makeExecutable.
      
              * assembler/X86Assembler.h:
              (JSC::X86Assembler::relinkJump):
              (JSC::X86Assembler::relinkCall):
              (JSC::X86Assembler::repatchInt32):
              (JSC::X86Assembler::repatchPointer):
              (JSC::X86Assembler::repatchLoadPtrToLEA):
                  - Remove usage of MakeWritable.
      
              * bytecode/CodeBlock.h:
              (JSC::CodeBlock::getJITCode):
                  - Provide access to CodeBlock's JITCode.
      
              * jit/ExecutableAllocator.h:
              (JSC::ExecutableAllocator::makeExecutable):
              (JSC::ExecutableAllocator::cacheFlush):
                  - Remove MakeWritable, make cacheFlush public.
      
              * jit/JIT.cpp:
              (JSC::ctiPatchNearCallByReturnAddress):
              (JSC::ctiPatchCallByReturnAddress):
              (JSC::JIT::privateCompile):
              (JSC::JIT::unlinkCall):
              (JSC::JIT::linkCall):
                  - Add CodeBlock argument to RepatchBuffer.
      
              * jit/JIT.h:
                  - Pass CodeBlock argument for use by RepatchBuffer.
      
              * jit/JITCode.h:
              (JSC::JITCode::start):
              (JSC::JITCode::size):
                  - Provide access to code start & size.
      
              * jit/JITPropertyAccess.cpp:
              (JSC::JIT::privateCompilePutByIdTransition):
              (JSC::JIT::patchGetByIdSelf):
              (JSC::JIT::patchMethodCallProto):
              (JSC::JIT::patchPutByIdReplace):
              (JSC::JIT::privateCompilePatchGetArrayLength):
              (JSC::JIT::privateCompileGetByIdProto):
              (JSC::JIT::privateCompileGetByIdSelfList):
              (JSC::JIT::privateCompileGetByIdProtoList):
              (JSC::JIT::privateCompileGetByIdChainList):
              (JSC::JIT::privateCompileGetByIdChain):
                  - Add CodeBlock argument to RepatchBuffer.
      
              * jit/JITStubs.cpp:
              (JSC::JITThunks::tryCachePutByID):
              (JSC::JITThunks::tryCacheGetByID):
              (JSC::JITStubs::DEFINE_STUB_FUNCTION):
                  - Pass CodeBlock argument for use by RepatchBuffer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1444b28f
    • oliver@apple.com's avatar
      Null deref in JSObject::mark due to null xhr wrapper · 53c0f274
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=27565
      
      Reviewed by Adele Peterson.
      
      Make event target binding for appcache and xhr behave in the same way as
      it does for all other events.
      
      No test as I couldn't make a testcase which was remotely reliable.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53c0f274
    • levin@chromium.org's avatar
      2009-07-22 Takeshi Yoshino <tyoshino@google.com> · faefc77f
      levin@chromium.org authored
              Reviewed by Darin Adler.
      
              VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in WebKit/win/WebCoreLocalizedStrings.cpp
              https://bugs.webkit.org/show_bug.cgi?id=26375
      
      WebKit/win:
      
              Replace a multiplication sign (U+00D7) encoded in UTF-8 (0xC3 0x97) in WebCoreLocalizedStrings.cpp
              with hex escape sequences.
      
              VC2005 failed to build due to this raw UTF-8 data in source code. Here's the warning message (
              treated as an error and stopped build).
      
              WebCoreLocalizedStrings.cpp : warning C4819: The file contains a character that cannot be
              represented in the current code page (932). Save the file in Unicode format to prevent data loss
      
              A change on WebKitTools/Scripts/extract-localizable-strings is attached to this change not to break
              localized string generation process.
      
              * WebCoreLocalizedStrings.cpp:
              (WebCore::imageTitle):
      
      WebKitTools:
      
              Make it able to use hexadecimal escape sequences in .*UI_STRING(_KEY)? macros. Now,
              the extract-localizable-strings script unescapes hexadecimal escape sequences in string literals
              in the macros before writing out them into the file to update.
      
              By this fix, we can eliminate raw UTF-8 strings in source code while using raw UTF-16 big endian
              strings in the Localizable.strings file.
      
              Bonus: There's no longer extract-webkit-localizable-strings script. Fix usage message to guide
              users to update-webkit-localizable-strings.
      
              * Scripts/extract-localizable-strings:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faefc77f
    • levin@chromium.org's avatar
      2009-07-22 Shinichiro Hamaji <hamaji@google.com> · 65c5cd2a
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Tiny typo fixes for cpplint.py
              https://bugs.webkit.org/show_bug.cgi?id=27530
      
              * Scripts/modules/cpplint.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65c5cd2a
    • levin@chromium.org's avatar
      2009-07-22 Shinichiro Hamaji <hamaji@chromium.org> · 40f71e90
      levin@chromium.org authored
              Reviewed by David Levin.
      
              run-webkit-lint checks code which are not changed
              https://bugs.webkit.org/show_bug.cgi?id=27529
      
              Add check if the line is newly added.
      
              * Scripts/run-webkit-lint:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40f71e90
    • levin@chromium.org's avatar
      2009-07-22 Shinichiro Hamaji <hamaji@chromium.org> · 32483cde
      levin@chromium.org authored
              Reviewed by David Levin.
      
              run-webkit-lint should have --git-commit option
              https://bugs.webkit.org/show_bug.cgi?id=27528
      
              * Scripts/modules/cpplint.py:
              * Scripts/run-webkit-lint:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32483cde
    • levin@chromium.org's avatar
      2009-07-22 Mads Ager <ager@chromium.org> · b22aac62
      levin@chromium.org authored
              Reviewed by David Levin.
      
              Inform V8 of the amount of WebCore string memory it is keeping alive.
              https://bugs.webkit.org/show_bug.cgi?id=27537
      
              V8 uses external strings that are backed by WebCore strings. Since
              the external strings themselves are small, V8 has no way of
              knowing how much memory it is actually holding on to. With this
              change, we inform V8 of the amount of WebCore string data it is
              holding on to with external strings.
      
              * bindings/v8/V8Binding.cpp:
              (WebCore::WebCoreStringResource::WebCoreStringResource):
              (WebCore::WebCoreStringResource::~WebCoreStringResource):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b22aac62
    • hyatt@apple.com's avatar
      WebCore: · ddf151e3
      hyatt@apple.com authored
      2009-07-22  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Beth Dakin.
      
              https://bugs.webkit.org/show_bug.cgi?id=27562
              Add the finalized versions of background-clip and background-origin.  Remove background-clip from
              the background shorthand and have it be auto-set based off background-origin's value.
      
              Three new tests added in fast/backgrounds/size
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::):
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
              * css/CSSMutableStyleDeclaration.cpp:
              (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue):
              (WebCore::CSSParser::parseFillShorthand):
              (WebCore::CSSParser::parseFillProperty):
              * css/CSSPropertyLonghand.cpp:
              (WebCore::initShorthandMap):
              * css/CSSPropertyNames.in:
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              * css/CSSValueKeywords.in:
      
      LayoutTests:
      
      2009-07-22  David Hyatt  <hyatt@apple.com>
      
              Reviewed by Beth Dakin.
      
              https://bugs.webkit.org/show_bug.cgi?id=27562
              Add some new layout tests that drop the prefix from the background properties and use origin
              in a shorthand.  Update shorthand results and computed style results to account for new properties.
      
              * fast/backgrounds/size/backgroundSize20.html: Added.
              * fast/backgrounds/size/backgroundSize21.html: Added.
              * fast/backgrounds/size/backgroundSize22.html: Added.
              * fast/css/background-position-serialize-expected.txt:
              * fast/css/remove-shorthand-expected.txt:
              * platform/mac/fast/backgrounds/size/backgroundSize20-expected.checksum: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize20-expected.png: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize20-expected.txt: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize21-expected.checksum: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize21-expected.png: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize21-expected.txt: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize22-expected.checksum: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize22-expected.png: Added.
              * platform/mac/fast/backgrounds/size/backgroundSize22-expected.txt: Added.
              * platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
              * platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
              * platform/mac/fast/inspector/style-expected.txt:
              * svg/css/getComputedStyle-basic-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddf151e3
    • jorlow@chromium.org's avatar
      WebCore: · f2b8ca8a
      jorlow@chromium.org authored
      2009-07-22  Jens Alfke  <snej@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Hook up V8 bindings for DataGrid elements.
              https://bugs.webkit.org/show_bug.cgi?id=27383
              http://code.google.com/p/chromium/issues/detail?id=16730
      
              Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
              to handle exceptions, check appropriate JS prototypes, and
              test column-list's item() method as well as array-indexing.
      
              * WebCore.gypi: Added new source files.
              * bindings/scripts/CodeGeneratorV8.pm: Made GenerateBatchedAttributeData put #if's around conditional attributes.
              * bindings/v8/DOMObjectsInclude.h: #include DataGrid headers.
              * bindings/v8/V8DOMWrapper.cpp: Add bindings from HTML tags to datagrid templates.
              (WebCore::V8DOMWrapper::getTemplate): Customize datagrid template.
              * bindings/v8/V8DataGridDataSource.cpp: Added. (Based on JSDataGridDataSource)
              (WebCore::V8DataGridDataSource::V8DataGridDataSource):
              (WebCore::V8DataGridDataSource::~V8DataGridDataSource):
              * bindings/v8/V8DataGridDataSource.h: Added. (Based on JSDataGridDataSource)
              (WebCore::V8DataGridDataSource::create):
              (WebCore::V8DataGridDataSource::isJSDataGridDataSource):
              (WebCore::V8DataGridDataSource::jsDataSource):
              (WebCore::asV8DataGridDataSource):
              * bindings/v8/V8GCController.h: Added new handle type "DATASOURCE".
              * bindings/v8/V8Index.h: Conditionalize datagrid stuff.
              * bindings/v8/custom/V8CustomBinding.h: Declare more accessors. Conditionalize.
              * bindings/v8/custom/V8DataGridColumnListCustom.cpp: Added.
              * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Fill in dataSource accessors.
              (WebCore::ACCESSOR_GETTER):
              (WebCore::ACCESSOR_SETTER):
      
      LayoutTests:
      
      2009-07-22  Jens Alfke  <snej@chromium.org>
      
              Reviewed by Darin Fisher.
      
              Hook up V8 bindings for DataGrid elements.
              https://bugs.webkit.org/show_bug.cgi?id=27383
              http://code.google.com/p/chromium/issues/detail?id=16730
      
              Tests: Enhanced LayoutTests/fast/dom/HTMLDataGridElement/*
              to handle exceptions, check appropriate JS prototypes, and
              test column-list's item() method as well as array-indexing.
      
              * fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt:
              * fast/dom/HTMLDataGridElement/DataGridColumns-basic.html:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom-expected.txt:
              * fast/dom/HTMLDataGridElement/DataGridColumns-dom.html:
              * fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f2b8ca8a
    • rniwa@webkit.org's avatar
      2009-07-22 Ryosuke Niwa <rniwa@webkit.org> · a1e567dd
      rniwa@webkit.org authored
              Reviewed by Eric Seidel.
      
              pushDownTextDecorationStyleAroundNode needs clean up
              https://bugs.webkit.org/show_bug.cgi?id=27556
      
              Cleaned up. pushDownTextDecorationStyleAroundNode traverses tree vertically from highestAncestor to targetNode
              While traversing, it will apply the specified style to all nodes but targetNode.
              i.e. the style is applies to all ancestor nodes and their siblings of targetNode.
      
              * editing/ApplyStyleCommand.cpp:
              (WebCore::ApplyStyleCommand::pushDownTextDecorationStyleAroundNode): Cleaned up and added comments
              * editing/ApplyStyleCommand.h: Updated prototype
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1e567dd
    • pkasting@chromium.org's avatar
      2009-07-22 Peter Kasting <pkasting@google.com> · 91374dbb
      pkasting@chromium.org authored
              Reviewed by David Kilzer.
      
              https://bugs.webkit.org/show_bug.cgi?id=27323
              Handle any type of line endings in WebCore/css/*CSSPropertyNames.in.
      
              * DerivedSources.make:
              * css/makeprop.pl:
              * css/makevalues.pl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      91374dbb
    • pkasting@chromium.org's avatar
      2009-07-22 Peter Kasting <pkasting@google.com> · 1d38c502
      pkasting@chromium.org authored
              Reviewed by David Kilzer.
      
              https://bugs.webkit.org/show_bug.cgi?id=27323
              Factor svn-create-patch's "determineSvnRoot()" into a function in
              VCSUtils.pm so commit-log-editor can use it too.
      
              * Scripts/VCSUtils.pm: Add determineSVNRoot().
              * Scripts/commit-log-editor: Use determineSVNRoot() instead of old
                code (which didn't work as well).
              * Scripts/svn-create-patch: Remove determineSvnRoot() (moved).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d38c502
    • treat@webkit.org's avatar
      Revert bugfix for 27557 as this is invalid according to Darin Adler · 2b30c2c6
      treat@webkit.org authored
      who states that include order sorting should be case-sensitive.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b30c2c6
    • eric@webkit.org's avatar
      2009-07-22 Eric Seidel <eric@webkit.org> · 9aa63b51
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              expand prototype-inheritance test to cover constructors
              https://bugs.webkit.org/show_bug.cgi?id=27547
      
              * fast/dom/prototype-inheritance-expected.txt:
              * fast/dom/resources/prototype-inheritance.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9aa63b51