- 14 Aug, 2010 9 commits
-
-
commit-queue@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. Update .gitignore file for more files https://bugs.webkit.org/show_bug.cgi?id=43991 * .gitignore: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65365 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
krit@webkit.org authored
Unreviewed sort of Xcode project file. * WebCore.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65364 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=44005 Reviewed by Anders Carlsson in Sweden. * UIProcess/API/C/WKBase.h: Include ctype.h. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65363 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ariya@webkit.org authored
Reviewed by Simon Hausmann and Kenneth Rohde Christiansen. [Qt] Refactor shadow state handling in GraphicsContextQt https://bugs.webkit.org/show_bug.cgi?id=44006 * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::): Added shadow states as member variables. (WebCore::GraphicsContextPlatformPrivate::hasShadow): Convenient function to check whether there is shadow or not. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::drawRect): Use shadow states instead of calling getShadow. (WebCore::GraphicsContext::drawLine): ditto. (WebCore::GraphicsContext::strokeArc): ditto. (WebCore::GraphicsContext::drawConvexPolygon): ditto. (WebCore::GraphicsContext::fillPath): ditto. (WebCore::GraphicsContext::strokePath): ditto. (WebCore::GraphicsContext::fillRect): Removes the use of helper function drawBorderlessRectShadow as the code already becomes a lot simpler. (WebCore::GraphicsContext::fillRoundedRect): Removes the use of helper function drawFilledShadowPath as the code already becomes a lot simpler. (WebCore::GraphicsContext::setPlatformShadow): Store shadow states and find out the shadow type (complexity) for future use. (WebCore::GraphicsContext::clearPlatformShadow): Reset shadow states. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65362 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ariya@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Outdated pixel test reference for fast/box-shadow/transform-fringing.html https://bugs.webkit.org/show_bug.cgi?id=44007 * platform/qt/fast/box-shadow/transform-fringing-expected.checksum: * platform/qt/fast/box-shadow/transform-fringing-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65361 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Unreviewed. Another fix to support python 2.3. Add support for MathML entities https://bugs.webkit.org/show_bug.cgi?id=43949 * Scripts/webkitpy/thirdparty/simplejson/decoder.py: - It looks like our simplejson is version 1.7.3 which should be python 2.3 compatible. But someone modified our copy slightly from the original source. I've removed the relative import in hopes this fixes the problem. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65360 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Unreviewed. Build fix only. Add support for MathML entities https://bugs.webkit.org/show_bug.cgi?id=43949 * Scripts/create-html-entity-table: - Hack sys.path to avoid executing 2.5 dependent python on systems (like chromium-win and Tiger) which do not have 2.5 python. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65359 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Eric Seidel. Rename some concepts in HTML entity search to be more self-documenting https://bugs.webkit.org/show_bug.cgi?id=44004 Start and end are now first and last, which lets us use some better names for the statics in HTMLEntityTable. * html/HTMLEntityParser.cpp: (WebCore::consumeHTMLEntity): * html/HTMLEntitySearch.cpp: (WebCore::HTMLEntitySearch::HTMLEntitySearch): (WebCore::HTMLEntitySearch::findFirst): (WebCore::HTMLEntitySearch::findLast): (WebCore::HTMLEntitySearch::advance): * html/HTMLEntitySearch.h: (WebCore::HTMLEntitySearch::isEntityPrefix): (WebCore::HTMLEntitySearch::mostRecentMatch): (WebCore::HTMLEntitySearch::fail): * html/HTMLEntityTable.h: 2010-08-13 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. Rename some concepts in HTML entity search to be more self-documenting https://bugs.webkit.org/show_bug.cgi?id=44004 Reflect name change in generator script. * Scripts/create-html-entity-table: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65358 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Eric Seidel. Make it easier to run LayoutTests in Firefox https://bugs.webkit.org/show_bug.cgi?id=44002 Firefox doesn't seem to have innerText. Instead, let's just use the normal DOM operations. * fast/parser/resources/p-in-scope.js: * fast/table/incomplete-table-in-fragment-2.html: * fast/table/incomplete-table-in-fragment-hang.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 13 Aug, 2010 31 commits
-
-
kevino@webkit.org authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65356 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Update test expectations to account for the HTML5 entity parser. There are two main differences: 1) The value of lang and rang have changed. 2) We now parse FOO<BAR as FOO<BAR. * fast/parser/entities-in-html-expected.txt: * fast/parser/entities-in-xhtml-expected.txt: * http/tests/security/xssAuditor/link-onclick-entities-expected.txt: * http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt: - This test expectation is wrong. It's on my list to redesign how the XSS auditor works now that we have better parsing tools. Rather than skip the test on all platforms, I'm updating the expectation. * platform/mac/fast/text/word-space-expected.txt: * platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: * platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65355 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Fix ASSERT in XML entity parsing. You can't advance the entity search if you've already discovered that your string is not an entity. * html/HTMLEntityParser.cpp: (WebCore::decodeNamedEntity): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65354 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Unreviewed. Attempt at fixing Chromium build. Add support for MathML entities https://bugs.webkit.org/show_bug.cgi?id=43949 * WebCore.gyp/WebCore.gyp: - I have no clue if this is right or not. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65353 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Unreviewed. Attempted build fix for Windows. Add support for MathML entities https://bugs.webkit.org/show_bug.cgi?id=43949 * DerivedSources.cpp: - Add HTMLEntityTable.cpp git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65352 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Eric Seidel. Add support for MathML entities https://bugs.webkit.org/show_bug.cgi?id=43949 Test progression for proper entity support. * html5lib/runner-expected-html5.txt: * html5lib/runner-expected.txt: 2010-08-09 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. Add support for MathML entities https://bugs.webkit.org/show_bug.cgi?id=43949 Implementing the HTML5 entity parsing algorithm require refactoring how we search for entity names. Instead of using a perfect hash, we now use a sorted list. As we advance through the input, we walk down a binary search of the table looking for an entity. Using this data structure lets us keep track of whether the current string is a prefix of an existing entity, which we need for the algorithm. In a future patch, I plan to add some indices to the table, which should let us narrow down the range of interesting entries more quickly. The one nasty piece of the algorithm is if we walk too far down the input and we need to back up to a previous match. In this patch, we accomplish this by rewinding the input and consuming a known number of characters to resync the source. * WebCore.xcodeproj/project.pbxproj: * html/HTMLEntityParser.cpp: (WebCore::consumeHTMLEntity): * html/HTMLEntitySearch.cpp: Added. (WebCore::): (WebCore::HTMLEntitySearch::HTMLEntitySearch): (WebCore::HTMLEntitySearch::compare): (WebCore::HTMLEntitySearch::findStart): (WebCore::HTMLEntitySearch::findEnd): (WebCore::HTMLEntitySearch::advance): * html/HTMLEntitySearch.h: Added. (WebCore::HTMLEntitySearch::isEntityPrefix): (WebCore::HTMLEntitySearch::currentValue): (WebCore::HTMLEntitySearch::lastMatch): (WebCore::HTMLEntitySearch::): (WebCore::HTMLEntitySearch::fail): * html/HTMLEntityTable.h: Added. (WebCore::HTMLEntityTableEntry::lastCharacter): 2010-08-12 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. Add support for MathML entities https://bugs.webkit.org/show_bug.cgi?id=43949 A script for generating the C++ state data structure describing all the entities from a JSON description. * Scripts/create-html-entity-table: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65351 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tonyg@chromium.org authored
Reviewed by Eric Seidel. Refactor HTMLScriptRunner to allow deferred scripts to share code https://bugs.webkit.org/show_bug.cgi?id=43736 No new tests because no functional change * html/HTMLScriptRunner.cpp: (WebCore::HTMLScriptRunner::sourceFromPendingScript): Make const to enforce the idea that it doesn't change m_parsingBlockingScript. (WebCore::HTMLScriptRunner::executeParsingBlockingScript): Rename to make it clear this deals with the parsing blocking script and refactor to use executePendingScriptAndDispatchEvent. (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Factored out of executePendingScript, this can be used for executing any external script. (WebCore::HTMLScriptRunner::executeScript): This can be used for executing any inline or external script. ASSERTs moved to the two calling points. (WebCore::HTMLScriptRunner::executeParsingBlockingScripts): Moved method. (WebCore::HTMLScriptRunner::requestParsingBlockingScript): Factored out requestPendingScript. (WebCore::HTMLScriptRunner::requestPendingScript): Factored out from reqeustParsingBlockingScript. (WebCore::HTMLScriptRunner::runScript): * html/HTMLScriptRunner.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65350 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
* WebCore.xcodeproj/project.pbxproj: * platform/win/SharedBufferWin.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Dimitri Glazkov. Form state restore tests fail on GTK build with r65340 https://bugs.webkit.org/show_bug.cgi?id=43998 Move form submits (and rest of test) to run during onload, to make sure that the submit generates a history entry. * fast/forms/state-restore-to-non-autocomplete-form.html: * fast/forms/state-restore-to-non-edited-controls.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65347 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65346 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65345 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
barraclough@apple.com authored
Rubber stamped by Sam Weinig. JavaScriptCore: * JavaScriptCore.exp: * JavaScriptCore.xcodeproj/project.pbxproj: * bytecode/CodeBlock.cpp: (JSC::CodeBlock::dump): * bytecode/SamplingTool.cpp: (JSC::SamplingTool::dump): * interpreter/CallFrame.cpp: (JSC::CallFrame::dumpCaller): * jsc.cpp: (runWithScripts): (runInteractive): * runtime/Identifier.h: (JSC::Identifier::ascii): * runtime/ScopeChain.cpp: (JSC::ScopeChainNode::print): * runtime/UString.cpp: (JSC::UString::ascii): (JSC::UString::latin1): * runtime/UString.h: * wtf/text/StringImpl.cpp: (WTF::StringImpl::asciiOLD): * wtf/text/StringImpl.h: * wtf/text/WTFString.cpp: (WTF::String::ascii): (WTF::String::latin1): * wtf/text/WTFString.h: WebCore: * WebCore.xcodeproj/project.pbxproj: * bridge/c/c_class.cpp: (JSC::Bindings::CClass::methodsNamed): (JSC::Bindings::CClass::fieldNamed): * bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaField::valueFromInstance): (JavaField::setValueToInstance): * bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): * bridge/objc/objc_class.mm: (JSC::Bindings::ObjcClass::methodsNamed): (JSC::Bindings::ObjcClass::fieldNamed): * bridge/objc/objc_instance.mm: (ObjcInstance::setValueOfUndefinedField): (ObjcInstance::getValueOfUndefinedField): * loader/icon/IconRecord.cpp: * platform/sql/SQLiteDatabase.cpp: * platform/sql/SQLiteStatement.cpp: * storage/SQLStatement.cpp: WebKit: * WebKit.xcodeproj/project.pbxproj: WebKit/mac: * Plugins/Hosted/ProxyInstance.mm: (WebKit::ProxyInstance::methodsNamed): (WebKit::ProxyInstance::fieldNamed): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65344 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dpranke@chromium.org authored
Reviewed by Eric Seidel. Rewrite new-run-webkit-test's wait_for_threads_to_finish loop to check for exceptions on all threads, not just the first thread. This change also changes the logging behavior for wedged threads to only dump the stacks of threads that are actually wedged. Refactor the thread classes in the dump_render_tree_thread module to make the contract between TestRunner and TestShellThread clearer. Added a bunch of unit tests. https://bugs.webkit.org/show_bug.cgi?id=38561 * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: * Scripts/webkitpy/layout_tests/run_webkit_tests.py: * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65343 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
* WebKit2.xcodeproj/project.pbxproj: Make WKDictionary.h public. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65342 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Part of <rdar://problem/8255932> https://bugs.webkit.org/show_bug.cgi?id=43995 Reviewed by Brady Eidson. * Platform/CoreIPC/ArgumentCoders.h: (CoreIPC::): Add overload for std::pair. * Shared/ImmutableDictionary.h: (WebKit::ImmutableDictionary::adopt): Fix function signature by removing size parameter. * UIProcess/API/C/WKPage.h: Add dictionary parameter to callback. * UIProcess/WebFormClient.cpp: (WebKit::WebFormClient::willSubmitForm): Create an ImmutableDictionary from the vector of string pairs. * UIProcess/WebFormClient.h: * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::didReceiveMessage): (WebKit::WebPageProxy::willSubmitForm): * UIProcess/WebPageProxy.h: * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm): Plumb through the values vector. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65341 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Dimitri Glazkov. Session history should skip over JS redirects https://bugs.webkit.org/show_bug.cgi?id=42861 Lock the back/forward list for location changes and form submits that happen before the onload event fires that are not the result of user gestures. http/tests/history tests now pass, their expectations were updated accordingly. Other tests needed a setTimeout wrapper around location changes and form submits during onload, otherwise they would not generate history entries as expected anymore. * fast/css/target-fragment-match.html: * fast/dom/location-hash.html: * fast/dom/Geolocation/resources/cached-page-1.html: * fast/dom/Window/timer-resume-on-navigation-back.html: * fast/events/pageshow-pagehide-on-back-cached-with-frames-expected.txt: * fast/events/pageshow-pagehide-on-back-cached-with-frames.html: * fast/forms/button-state-restore.html: * fast/forms/state-restore-to-non-autocomplete-form.html: * fast/forms/state-restore-to-non-edited-controls.html: * fast/frames/resources/cached-page-1.html: * fast/frames/resources/cached-page-2.html: * fast/harness/resources/cached-page-1.html: * fast/harness/resources/cached-page-with-data-urls.html: * fast/history/gesture-before-onload-expected.txt: Added. * fast/history/gesture-before-onload.html: Added. * fast/history/history-length.html: * fast/history/resources/gesture-before-onload-target.html: Added. * fast/history/saves-state-after-fragment-nav.html: * fast/loader/input-element-page-cache-crash.html: * fast/loader/stateobjects/document-destroyed-navigate-back.html: * fast/loader/stateobjects/pushstate-clears-forward-history.html: * fast/loader/subframe-navigate-during-main-frame-load.html: * http/tests/history/back-to-post.php: * http/tests/history/redirect-js-document-location-before-load-expected.txt: * http/tests/history/redirect-js-form-submit-before-load-expected.txt: * http/tests/history/redirect-js-location-assign-before-load-expected.txt: * http/tests/history/redirect-js-location-before-load-expected.txt: * http/tests/history/redirect-js-location-href-before-load-expected.txt: * http/tests/loading/307-after-303-after-post-expected.txt: * http/tests/loading/redirect-methods-expected.txt: * http/tests/navigation/resources/back-send-referrer-helper.php: * http/tests/navigation/resources/document-location.js: (start): * http/tests/navigation/resources/submit-to-fragment.pl: * security/autocomplete-cleared-on-back.html: * storage/hash-change-with-xhr.js: (updateDatabase): (invokeBack): (runTest): (runTestsInner): 2010-08-13 Mihai Parparita <mihaip@chromium.org> Reviewed by Dimitri Glazkov. Session history should skip over JS redirects https://bugs.webkit.org/show_bug.cgi?id=42861 Lock the back/forward list for location changes and form submits that happen before the onload event fires that are not the result of user gestures. Made form submission (at the ScheduledFormSubmission level) more similar to ScheduledURLNavigation by having it call clientRedirected too, fixing a long-standing FIXME. Test: fast/history/gesture-before-onload-location-href.html, fast/history/gesture-before-onload-form-submit.html and updated expectations for http/tests/history tests that used to fail. * loader/FormSubmission.cpp: (WebCore::FormSubmission::requestURL): (WebCore::FormSubmission::populateFrameLoadRequest): * loader/FormSubmission.h: * loader/RedirectScheduler.cpp: (WebCore::ScheduledFormSubmission::ScheduledFormSubmission): (WebCore::ScheduledFormSubmission::fire): (WebCore::ScheduledFormSubmission::didStartTimer): (WebCore::ScheduledFormSubmission::didStopTimer): (WebCore::RedirectScheduler::scheduleRedirect): (WebCore::RedirectScheduler::mustLockBackForwardList): (WebCore::RedirectScheduler::scheduleLocationChange): (WebCore::RedirectScheduler::scheduleFormSubmission): * loader/RedirectScheduler.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=43990 Reviewed by Brady Eidson. Add an immutable dictionary type (WKStringRef -> WKTypeRef). * Shared/APIObject.h: (WebKit::APIObject::): Add new APIType. * Shared/ImmutableDictionary.cpp: Added. (WebKit::ImmutableDictionary::ImmutableDictionary): (WebKit::ImmutableDictionary::~ImmutableDictionary): * Shared/ImmutableDictionary.h: Added. (WebKit::ImmutableDictionary::create): (WebKit::ImmutableDictionary::adopt): (WebKit::ImmutableDictionary::get): (WebKit::ImmutableDictionary::size): (WebKit::ImmutableDictionary::): (WebKit::ImmutableDictionary::type): Add basic implementation * UIProcess/API/C/WKAPICast.h: (WebKit::): Add new mappings. * UIProcess/API/C/WKBase.h: Add new opaque type. * UIProcess/API/C/WKDictionary.cpp: Added. (WKDictionaryGetTypeID): (WKDictionaryGetItemForKey): (WKDictionaryGetSize): (WKDictionaryRetain): (WKDictionaryRelease): * UIProcess/API/C/WKDictionary.h: Added. Add API wrappings. * UIProcess/API/C/WebKit2.h: Add missing public headers. * WebKit2.xcodeproj/project.pbxproj: * win/WebKit2.vcproj: * win/WebKit2Generated.make: Add new files. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65339 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Rubber-stamped by Beth Dakin and Ban Bernstein. * platform/mac-wk2/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
weinig@apple.com authored
Part of <rdar://problem/8255932> https://bugs.webkit.org/show_bug.cgi?id=43947 Reviewed by Jon Honeycutt. * Shared/APIObject.h: Add TypeFormSubmissionListener APIType. * Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Add WillSubmitForm message kind. * UIProcess/API/C/WKAPICast.h: Add new mappings for WKFormSubmissionListenerRef -> WebFormSubmissionListener * UIProcess/API/C/WKBase.h: Add OpaqueWKFormSubmissionListener and rename the other opaque types to match. * UIProcess/API/C/WKFormSubmissionListener.cpp: Added. (WKFormSubmissionListenerGetTypeID): (WKFormSubmissionListenerContinue): (WKFormSubmissionListenerRetain): (WKFormSubmissionListenerRelease): * UIProcess/API/C/WKFormSubmissionListener.h: Added. Add C wrapper for WebFormSubmissionListener. * UIProcess/API/C/WKPage.cpp: (WKPageSetPageFormClient): * UIProcess/API/C/WKPage.h: Add WKPageFormClient with willSubmitForm callback. Additional callbacks will be added as needed. * UIProcess/API/C/WebKit2.h: Add include for WKFormSubmissionListener.h * UIProcess/WebFormClient.cpp: Added. (WebKit::WebFormClient::WebFormClient): (WebKit::WebFormClient::initialize): (WebKit::WebFormClient::willSubmitForm): * UIProcess/WebFormClient.h: Added. Add client for form related delagations. * UIProcess/WebFormSubmissionListenerProxy.cpp: Added. (WebKit::WebFormSubmissionListenerProxy::WebFormSubmissionListenerProxy): (WebKit::WebFormSubmissionListenerProxy::continueSubmission): * UIProcess/WebFormSubmissionListenerProxy.h: Added. (WebKit::WebFormSubmissionListenerProxy::create): (WebKit::WebFormSubmissionListenerProxy::type): * UIProcess/WebFrameListenerProxy.cpp: Copied from UIProcess/WebFramePolicyListenerProxy.cpp. Add new type of listener for form submissions. It inherits from the new base class for listeners, WebFrameListenerProxy. (WebKit::WebFrameListenerProxy::WebFrameListenerProxy): (WebKit::WebFrameListenerProxy::~WebFrameListenerProxy): (WebKit::WebFrameListenerProxy::invalidate): (WebKit::WebFrameListenerProxy::receivedPolicyDecision): * UIProcess/WebFrameListenerProxy.h: Copied from UIProcess/WebFramePolicyListenerProxy.h. Move logic that would have to be shared between WebFramePolicyListenerProxy and WebFormSubmissionListenerProxy into shared base class. * UIProcess/WebFramePolicyListenerProxy.cpp: (WebKit::WebFramePolicyListenerProxy::WebFramePolicyListenerProxy): * UIProcess/WebFramePolicyListenerProxy.h: (WebKit::WebFramePolicyListenerProxy::create): (WebKit::WebFramePolicyListenerProxy::type): Move to inheriting from WebFrameListenerProxy. * UIProcess/WebFrameProxy.cpp: (WebKit::WebFrameProxy::disconnect): (WebKit::WebFrameProxy::receivedPolicyDecision): (WebKit::WebFrameProxy::setUpPolicyListenerProxy): (WebKit::WebFrameProxy::setUpFormSubmissionListenerProxy): * UIProcess/WebFrameProxy.h: Change listener functions to act on WebFrameListenerProxys and add setUpFormSubmissionListenerProxy. * UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::initializeFormClient): (WebKit::WebPageProxy::didReceiveMessage): (WebKit::WebPageProxy::willSubmitForm): * UIProcess/WebPageProxy.h: Plumb through willSubmitForm call as we do with the other listeners. * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp: (WebKit::WebFrameLoaderClient::dispatchWillSubmitForm): Ditto. * WebKit2.xcodeproj/project.pbxproj: Add new files. * win/WebKit2.vcproj: Add new files. * win/WebKit2Generated.make: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65337 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leandro@webkit.org authored
[EFL] Unreviewed build fix. These changes were supposed to be landed on r65319, but due to some svn-apply/commit-queue bug it wasn't fully applied. A bug was filed by Patrick Gansterer (author of the changes in this commit): https://bugs.webkit.org/show_bug.cgi?id=43981 * CMakeLists.txt: Update calls to GENERATE_GPERF and GENERATE_GRAMMAR macros. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65336 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cfleizach@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=43872 Re-adding this patch after it was erroneously rolled out. WebCore: Test: platform/mac/accessibility/native-vs-nonnative-checkboxes.html * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isInputImage): (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): * dom/InputElement.h: * html/HTMLInputElement.h: (WebCore::HTMLInputElement::isCheckbox): LayoutTests: * platform/mac/accessibility/native-vs-nonnative-checkboxes-expected.txt: Added. * platform/mac/accessibility/native-vs-nonnative-checkboxes.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65335 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Unreviewed, rolling out r65331. http://trac.webkit.org/changeset/65331 https://bugs.webkit.org/show_bug.cgi?id=43980 This patch breaks some shadow tests on Qt Linux release (Requested by ariya on #webkit). * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::drawRect): (WebCore::GraphicsContext::drawLine): (WebCore::GraphicsContext::strokeArc): (WebCore::GraphicsContext::drawConvexPolygon): (WebCore::drawFilledShadowPath): (WebCore::GraphicsContext::fillPath): (WebCore::GraphicsContext::strokePath): (WebCore::drawBorderlessRectShadow): (WebCore::GraphicsContext::fillRect): (WebCore::GraphicsContext::fillRoundedRect): (WebCore::GraphicsContext::setPlatformShadow): (WebCore::GraphicsContext::clearPlatformShadow): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65334 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kinuko@chromium.org authored
Reviewed by David Levin. Update run-bindings-tests expectations https://bugs.webkit.org/show_bug.cgi?id=43944 The results have become out of sync after changeset 64552 and 65269. Test: WebKitTools/Scripts/run-bindings-tests * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp: (webkit_dom_test_callback_callback_with_class1param): (webkit_dom_test_callback_callback_with_class2param): (webkit_dom_test_callback_callback_with_non_bool_return_type): * bindings/scripts/test/GObject/WebKitDOMTestCallback.h: * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_void_method_with_args): (webkit_dom_test_obj_int_method_with_args): (webkit_dom_test_obj_obj_method): (webkit_dom_test_obj_obj_method_with_args): (webkit_dom_test_obj_method_that_requires_all_args): (webkit_dom_test_obj_method_that_requires_all_args_and_throws): (webkit_dom_test_obj_serialized_value): (webkit_dom_test_obj_idb_key): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture): (webkit_dom_test_obj_with_dynamic_frame_and_user_gesture_asad): (webkit_dom_test_obj_with_script_state_obj): (webkit_dom_test_obj_with_script_state_obj_exception): (webkit_dom_test_obj_get_read_only_string_attr): (webkit_dom_test_obj_get_read_only_test_obj_attr): (webkit_dom_test_obj_get_string_attr): (webkit_dom_test_obj_set_string_attr): (webkit_dom_test_obj_get_test_obj_attr): (webkit_dom_test_obj_set_test_obj_attr): (webkit_dom_test_obj_get_xml_obj_attr): (webkit_dom_test_obj_set_xml_obj_attr): (webkit_dom_test_obj_get_reflected_string_attr): (webkit_dom_test_obj_set_reflected_string_attr): (webkit_dom_test_obj_get_reflected_url_attr): (webkit_dom_test_obj_set_reflected_url_attr): (webkit_dom_test_obj_get_reflected_non_empty_url_attr): (webkit_dom_test_obj_set_reflected_non_empty_url_attr): (webkit_dom_test_obj_get_reflected_custom_url_attr): (webkit_dom_test_obj_set_reflected_custom_url_attr): (webkit_dom_test_obj_get_reflected_custom_non_empty_url_attr): (webkit_dom_test_obj_set_reflected_custom_non_empty_url_attr): (webkit_dom_test_obj_get_string_attr_with_getter_exception): (webkit_dom_test_obj_set_string_attr_with_getter_exception): (webkit_dom_test_obj_get_string_attr_with_setter_exception): (webkit_dom_test_obj_set_string_attr_with_setter_exception): (webkit_dom_test_obj_get_script_string_attr): (webkit_dom_test_obj_get_hash): (webkit_dom_test_obj_class_init): * bindings/scripts/test/GObject/WebKitDOMTestObj.h: * bindings/scripts/test/JS/JSTestObj.cpp: (WebCore::jsTestObjPrototypeFunctionOverloadedMethod): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65333 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
leandro@webkit.org authored
[EFL] Unreviewed build fix. * cmake/FindGthread.cmake: Fix warnings about obsolete PKGCONFIG macro. * cmake/WebKitGenerators.cmake: FLEX_EXECUTABLE was defined already by the root CMakeLists.txt file, so remove relevant lines that depends on FIND_PACKAGE_HANDLE_STANDARD_ARGS macro, which isn't available anymore. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65332 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ariya@webkit.org authored
Reviewed by Simon Hausmann. [Qt] Canvas and CSS: blur option in shadow not working https://bugs.webkit.org/show_bug.cgi?id=34479 Patch 1: Refactor shadow states handling. * platform/graphics/qt/GraphicsContextQt.cpp: (WebCore::GraphicsContextPlatformPrivate::): Added shadow states as member variables. (WebCore::GraphicsContextPlatformPrivate::hasShadow): Convenient function to check whether there is shadow or not. (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate): (WebCore::GraphicsContext::drawRect): Use shadow states instead of calling getShadow. (WebCore::GraphicsContext::drawLine): ditto. (WebCore::GraphicsContext::strokeArc): ditto. (WebCore::GraphicsContext::drawConvexPolygon): ditto. (WebCore::GraphicsContext::fillPath): ditto. (WebCore::GraphicsContext::strokePath): ditto. (WebCore::GraphicsContext::fillRect): Removes the use of helper function drawBorderlessRectShadow as the code already becomes a lot simpler. (WebCore::GraphicsContext::fillRoundedRect): Removes the use of helper function drawFilledShadowPath as the code already becomes a lot simpler. (WebCore::GraphicsContext::setPlatformShadow): Store shadow states and find out the shadow type (complexity) for future use. (WebCore::GraphicsContext::clearPlatformShadow): Reset shadow states. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65331 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
zmo@google.com authored
Reviewed by Dimitri Glazkov. Regression in linking of programs https://bugs.webkit.org/show_bug.cgi?id=43820 Shaders and programs shouldn't be deleted until their attachments are removed, therefore, we need to track the attach/detach/useProgram. * html/canvas/WebGLObject.cpp: Track the object attachment count and whether it should really be deleted. (WebCore::WebGLObject::WebGLObject): (WebCore::WebGLObject::setObject): (WebCore::WebGLObject::deleteObject): * html/canvas/WebGLObject.h: Track the object attachment count and whether it should really be deleted. (WebCore::WebGLObject::onAttached): (WebCore::WebGLObject::onDetached): (WebCore::WebGLObject::getAttachmentCount): * html/canvas/WebGLProgram.cpp: Track the attached shaders. (WebCore::WebGLProgram::WebGLProgram): (WebCore::WebGLProgram::deleteObjectImpl): (WebCore::WebGLProgram::getAttachedShader): (WebCore::WebGLProgram::attachShader): (WebCore::WebGLProgram::detachShader): * html/canvas/WebGLProgram.h: Track the attached shaders. * html/canvas/WebGLRenderingContext.cpp: (WebCore::WebGLRenderingContext::attachShader): Track the attachment of a shader to a program. (WebCore::WebGLRenderingContext::deleteProgram): Detach shaders. (WebCore::WebGLRenderingContext::detachShader): Track the attachment of a shader to a program. (WebCore::WebGLRenderingContext::validateWebGLObject): Also check if object == 0. (WebCore::WebGLRenderingContext::linkProgram): Using the cached attached shaders instead of query from driver. (WebCore::WebGLRenderingContext::useProgram): Track the attachment of a program to the current rendering pipeline. 2010-08-11 Zhenyao Mo <zmo@google.com> Reviewed by Dimitri Glazkov. Regression in linking of programs https://bugs.webkit.org/show_bug.cgi?id=43820 * fast/canvas/webgl/program-test-expected.txt: Fix the tests so a second shader of the same type attaching to a program will generate error; also, add tests for deleteShader/deleteProgram behavior. * fast/canvas/webgl/program-test.html: Ditto. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
steveblock@google.com authored
Reviewed by Alexey Proskuryakov. Geolocation activity started after frame has been disconnected can cause crash https://bugs.webkit.org/show_bug.cgi?id=39879 New requests started after the Frame has been disconnected are ignored. We do not invoke the error callback as this would allow buggy or malicious pages to hose the CPU. Such a page could hold a reference to a Geolocation object from a since closed Page and register new requests from the error callback to create an infinite loop. Tests: fast/dom/Geolocation/disconnected-frame-already.html * page/Geolocation.cpp: 2010-08-13 Steve Block <steveblock@google.com> Reviewed by Alexey Proskuryakov. Geolocation activity started after frame has been disconnected can cause crash https://bugs.webkit.org/show_bug.cgi?id=39879 Added new tests to GTK skipped list. * fast/dom/Geolocation/disconnected-frame-already.html: Added. * fast/dom/Geolocation/disconnected-frame-already-expected.txt: Added. * fast/dom/Geolocation/script-tests/disconnected-frame-already.js: Added. * fast/dom/Geolocation/resources/disconnected-frame-already-inner1.html: Added. * fast/dom/Geolocation/resources/disconnected-frame-already-inner2.html: Added. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
alex@webkit.org authored
Reviewed by Xan Lopez. We have to add the ACLOCAL_FLAGS in the env to the autogen.sh ACLOCAL_FLAGS variable in order to honor the value already defined, jhbuild uses it to pass parameters. * autogen.sh: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65328 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
commit-queue@webkit.org authored
Reviewed by Jeremy Orlow. Support for multiple speech enabled elements in same page. https://bugs.webkit.org/show_bug.cgi?id=43922 * page/SpeechInput.cpp: Generates request ids as necessary when each speech enabled input element gets created/destroyed and multiplexes the listener callbacks to the appropriate input element based on the request id. (WebCore::SpeechInput::SpeechInput): (WebCore::SpeechInput::~SpeechInput): (WebCore::SpeechInput::registerListener): (WebCore::SpeechInput::unregisterListener): (WebCore::SpeechInput::didCompleteRecording): (WebCore::SpeechInput::didCompleteRecognition): (WebCore::SpeechInput::setRecognitionResult): (WebCore::SpeechInput::startRecognition): (WebCore::SpeechInput::stopRecording): (WebCore::SpeechInput::cancelRecognition): * page/SpeechInput.h: * page/SpeechInputClient.h: Now requires a one time set for the WebCore::SpeechInputListener and takes in a 'requestId' for all calls. * page/SpeechInputListener.h: Now returns the above mentioned requestId in all the listener callbacks for identifying which input element the event goes to. * platform/mock/SpeechInputClientMock.cpp: (WebCore::SpeechInputClientMock::SpeechInputClientMock): (WebCore::SpeechInputClientMock::setListener): (WebCore::SpeechInputClientMock::startRecognition): (WebCore::SpeechInputClientMock::stopRecording): (WebCore::SpeechInputClientMock::cancelRecognition): (WebCore::SpeechInputClientMock::timerFired): * platform/mock/SpeechInputClientMock.h: * rendering/TextControlInnerElements.cpp: (WebCore::InputFieldSpeechButtonElement::InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::~InputFieldSpeechButtonElement): (WebCore::InputFieldSpeechButtonElement::defaultEventHandler): (WebCore::InputFieldSpeechButtonElement::speechInput): (WebCore::InputFieldSpeechButtonElement::didCompleteRecording): (WebCore::InputFieldSpeechButtonElement::didCompleteRecognition): (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): * rendering/TextControlInnerElements.h: 2010-08-13 Satish Sampath <satish@chromium.org> Reviewed by Jeremy Orlow. Support for multiple speech enabled elements in same page. https://bugs.webkit.org/show_bug.cgi?id=43922 * public/WebSpeechInputController.h: Bubbles up the requestId given by webcore to the embedder. (WebKit::WebSpeechInputController::startRecognition): (WebKit::WebSpeechInputController::cancelRecognition): (WebKit::WebSpeechInputController::stopRecording): * public/WebSpeechInputListener.h: Passes down the requestId given by embedder to webcore. (WebKit::WebSpeechInputListener::didCompleteRecording): (WebKit::WebSpeechInputListener::setRecognitionResult): (WebKit::WebSpeechInputListener::didCompleteRecognition): * src/SpeechInputClientImpl.cpp: (WebKit::SpeechInputClientImpl::setListener): (WebKit::SpeechInputClientImpl::startRecognition): (WebKit::SpeechInputClientImpl::stopRecording): (WebKit::SpeechInputClientImpl::cancelRecognition): (WebKit::SpeechInputClientImpl::didCompleteRecording): (WebKit::SpeechInputClientImpl::didCompleteRecognition): (WebKit::SpeechInputClientImpl::setRecognitionResult): * src/SpeechInputClientImpl.h: * src/WebSpeechInputControllerMockImpl.cpp: (WebKit::WebSpeechInputControllerMockImpl::WebSpeechInputControllerMockImpl): (WebKit::WebSpeechInputControllerMockImpl::~WebSpeechInputControllerMockImpl): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecording): (WebKit::WebSpeechInputControllerMockImpl::didCompleteRecognition): (WebKit::WebSpeechInputControllerMockImpl::setRecognitionResult): (WebKit::WebSpeechInputControllerMockImpl::startRecognition): (WebKit::WebSpeechInputControllerMockImpl::cancelRecognition): (WebKit::WebSpeechInputControllerMockImpl::stopRecording): * src/WebSpeechInputControllerMockImpl.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65327 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ariya@webkit.org authored
Rubber-stamped by Simon Hausmann. [Qt] Outdated pixel test reference for basic-shadows.html https://bugs.webkit.org/show_bug.cgi?id=43952 * platform/qt/fast/box-shadow/basic-shadows-expected.checksum: * platform/qt/fast/box-shadow/basic-shadows-expected.png: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@65326 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-