1. 05 Sep, 2012 11 commits
    • kkristof@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · bb31bd6a
      kkristof@inf.u-szeged.hu authored
      https://bugs.webkit.org/show_bug.cgi?id=95827
      
      Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-09-05
      
      * platform/qt/Skipped: skip failing test after r127534.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb31bd6a
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 554c000e
      zandobersek@gmail.com authored
      Rebaselining after r126911, r127163 and r127534.
      
      Adding a platform-specific baseline for accessibility/canvas-description-and-role.html
      that's required after r127084. The baseline is currently the same as Chromium's,
      expecting 'AXCanvas' as the AXRole for the canvas element. The GTK port currently
      reports 'image' as the AXRole - this is probably not intended so the text failure
      expectation is also added for this test.
      
      * platform/gtk/TestExpectations:
      * platform/gtk/accessibility/canvas-description-and-role-expected.txt: Added.
      * platform/gtk/fast/block/float/024-expected.txt:
      * platform/gtk/fast/block/margin-collapse/025-expected.txt:
      * platform/gtk/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
      * platform/gtk/fast/block/margin-collapse/empty-clear-blocks-expected.txt:
      * platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
      * platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
      * platform/gtk/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Added.
      * platform/gtk/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      554c000e
    • yosin@chromium.org's avatar
      [Tests] We should have interactive validation of required value for the "input" element · b7803c6d
      yosin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95817
      
      Reviewed by Kent Tamura.
      
      This patch adds tests for required attribute handling on form
      submission of input types. The test script is parametrized for
      input type and expected type. Each test file simply call one test
      script in common-interactive-validation-required.js.
      
      The test script checks:
        - Don't submit form when required value isn't presented.
        - Submit form when required value is presented.
      
      * fast/forms/date/date-interactive-validation-required-expected.txt: Added.
      * fast/forms/date/date-interactive-validation-required.html: Added.
      * fast/forms/datetime/datetime-interactive-validation-required-expected.txt: Added.
      * fast/forms/datetime/datetime-interactive-validation-required.html: Added.
      * fast/forms/datetimelocal/datetimelocal-interactive-validation-required-expected.txt: Added.
      * fast/forms/datetimelocal/datetimelocal-interactive-validation-required.html: Added.
      * fast/forms/month/month-interactive-validation-required-expected.txt: Added.
      * fast/forms/month/month-interactive-validation-required.html: Added.
      * fast/forms/number/number-interactive-validation-required-expected.txt: Added.
      * fast/forms/number/number-interactive-validation-required.html: Added.
      * fast/forms/resources/common-interactive-validation-required.js: Added.
      * fast/forms/time/time-interactive-validation-required-expected.txt: Added.
      * fast/forms/time/time-interactive-validation-required.html: Added.
      * fast/forms/week/week-interactive-validation-required-expected.txt: Added.
      * fast/forms/week/week-interactive-validation-required.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127564 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7803c6d
    • mikelawther@chromium.org's avatar
      Moved mac results to be the generic results, and the existing result to be the chromium · ee6f3e4f
      mikelawther@chromium.org authored
      platform result. The current result uses subpixel layout, which is not the norm.
      
      Original results were added in r127557. Mac results were added in r127560.
      
      * css3/calc/zoom-with-em-expected.txt:
      * platform/chromium/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.
      * platform/mac/css3/calc/zoom-with-em-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127563 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee6f3e4f
    • yosin@chromium.org's avatar
      Test cases for Up/Down key behavior on field which has maximum/minimum in... · c538f3fb
      yosin@chromium.org authored
      Test cases for Up/Down key behavior on field which has maximum/minimum in multiple fields time input UI
      https://bugs.webkit.org/show_bug.cgi?id=95824
      
      Reviewed by Kent Tamura.
      
      This patch adds test cases for Up/Down key behavior on field which has
      maximum/minimum value in multiple fields time input UI.
      
      This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
      ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.
      
      * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt: Updated expectation for new test cases.
      * fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html: Changed to add test cases for Up key behavior for "23:59:59.999" (11:59:59.999PM in UI) and Down key behavior for "01:00:00.000" (01:00:00.000 AM in UI)
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127562 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c538f3fb
    • rgabor@webkit.org's avatar
      DFG JIT doesn't work properly on ARM hardfp · 909ad1bb
      rgabor@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95684
      
      Reviewed by Filip Pizlo.
      
      Add hardfp support to DFG JIT. The patch is created with the
      help of Zoltan Herczeg.
      
      Source/JavaScriptCore: 
      
      * dfg/DFGCCallHelpers.h:
      (CCallHelpers):
      (JSC::DFG::CCallHelpers::setupArguments):
      * dfg/DFGFPRInfo.h:
      (FPRInfo):
      * dfg/DFGSpeculativeJIT.h:
      (SpeculativeJIT):
      (JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
      (JSC::DFG::SpeculativeJIT::appendCallSetResult):
      
      Source/WTF: 
      
      * wtf/Platform.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127561 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      909ad1bb
    • mitz@apple.com's avatar
      Added Mac-specific expected results for a test added in r127557. The generic results are · 00bd3817
      mitz@apple.com authored
      probably from a build with subpixel layout.
      
      * platform/mac/css3/calc: Added.
      * platform/mac/css3/calc/zoom-with-em-expected.txt: Copied from LayoutTests/css3/calc/zoom-with-em-expected.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00bd3817
    • kbalazs@webkit.org's avatar
      [Qt] QRawWebViewPrivate does not initialize some members · d012b075
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95709
      
      Reviewed by Luiz Agostini.
      
      Don't miss initializing the bool flags.
      
      * UIProcess/API/qt/raw/qrawwebview.cpp:
      (QRawWebViewPrivate::QRawWebViewPrivate):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d012b075
    • keishi@webkit.org's avatar
      Move PagePopupClient implementation for input[type=date] to Chromium WebKit layer · b8f608b0
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95681
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      We are moving calendar picker PagePopupClient to WebKit layer so ports
      can use their platform native chooser UI if they have one.
      DateTimeChooser, DateTimeChooserClient etc. will be reused when we
      implement the week picker and month picker.
      
      No new tests. No behavior change. Covered by existing calendar picker tests.
      
      * WebCore.gypi:
      * html/shadow/CalendarPickerElement.cpp:
      (WebCore::CalendarPickerElement::CalendarPickerElement):
      (WebCore::CalendarPickerElement::~CalendarPickerElement):
      (WebCore::CalendarPickerElement::didChooseValue): Called when user chose a value.
      (WebCore):
      (WebCore::CalendarPickerElement::didEndChooser): Called when chooser has ended.
      (WebCore::CalendarPickerElement::openPopup):
      (WebCore::CalendarPickerElement::closePopup):
      * html/shadow/CalendarPickerElement.h:
      (CalendarPickerElement):
      * loader/EmptyClients.cpp:
      (WebCore):
      (WebCore::EmptyChromeClient::openDateTimeChooser):
      * loader/EmptyClients.h:
      (EmptyChromeClient):
      * page/ChromeClient.h:
      (WebCore):
      (ChromeClient):
      * platform/DateTimeChooser.h:
      (WebCore):
      (DateTimeChooserParameters): Contains information needed to open the DateTimeChooser.
      (DateTimeChooser):
      (WebCore::DateTimeChooser::~DateTimeChooser):
      * platform/DateTimeChooserClient.h:
      (WebCore):
      (DateTimeChooserClient):
      (WebCore::DateTimeChooserClient::~DateTimeChooserClient):
      
      Source/WebKit/chromium:
      
      * WebKit.gyp:
      * src/ChromeClientImpl.cpp:
      (WebKit):
      (WebKit::ChromeClientImpl::openDateTimeChooser):
      * src/ChromeClientImpl.h:
      (WebCore):
      (ChromeClientImpl):
      * src/DateTimeChooserImpl.cpp: Added.
      (WebKit):
      (WebKit::DateTimeChooserImpl::DateTimeChooserImpl):
      (WebKit::DateTimeChooserImpl::~DateTimeChooserImpl):
      (WebKit::DateTimeChooserImpl::endChooser):
      (WebKit::DateTimeChooserImpl::contentSize):
      (WebKit::DateTimeChooserImpl::writeDocument):
      (WebKit::DateTimeChooserImpl::setValueAndClosePopup):
      (WebKit::DateTimeChooserImpl::didClosePopup):
      * src/DateTimeChooserImpl.h:
      (WebCore):
      (WebKit):
      (DateTimeChooserImpl):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8f608b0
    • mikelawther@chromium.org's avatar
      CSS3 calc: expressions with 'em' units do not zoom correctly. · f9e8a8df
      mikelawther@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95705
      
      Reviewed by Ojan Vafai.
      
      Source/WebCore:
      
      Each primitive value in a CSS calc expression now has (zoom) multiplier and scale factor applied
      independently. Previously the multiplier and a single scale factor was applied to the expression
      as a whole, but this failed to account for expressions involving font relative units. This is
      because the multiplier should not be applied to font relative units.
      
      Test: css3/calc/zoom-with-em.html
      
      * css/CSSPrimitiveValue.cpp:
      (WebCore::CSSPrimitiveValue::computeLengthDouble):
      
      LayoutTests:
      
      * css3/calc/zoom-with-em-expected.txt: Added.
      * css3/calc/zoom-with-em.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9e8a8df
    • commit-queue@webkit.org's avatar
      [chromium] Prevent compositor ticking if it can't draw · 588248aa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95399
      
      Patch by Brian Anderson <brianderson@chromium.org> on 2012-09-04
      Reviewed by James Robinson.
      
      Background extensions had an always ticking compositor even though
      they couldn't draw. This patch disables the ticks when canDraw is false
      and adds a notification mechanism for when canDraw changes states so
      we can recover properly.
      
      Tests updated for new interfaces.
      Regression test added to make sure ticking stops when canDraw is false.
      notifyIfCanDrawChanged test added to make sure notifications are sent
      for any changes that might affect canDraw.
      
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
      (WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
      (WebCore::CCLayerTreeHostImpl::notifyIfCanDrawChanged):
      (WebCore):
      (WebCore::CCLayerTreeHostImpl::releaseContentsTextures):
      (WebCore::CCLayerTreeHostImpl::setRootLayer):
      (WebCore::CCLayerTreeHostImpl::initializeRenderer):
      (WebCore::CCLayerTreeHostImpl::setViewportSize):
      * platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
      (CCLayerTreeHostImplClient):
      (WebCore::CCLayerTreeHostImpl::resetContentsTexturesPurged):
      (CCLayerTreeHostImpl):
      * platform/graphics/chromium/cc/CCScheduler.cpp:
      (WebCore::CCScheduler::setCanDraw):
      (WebCore):
      (WebCore::CCScheduler::processScheduledActions):
      * platform/graphics/chromium/cc/CCScheduler.h:
      (CCScheduler):
      * platform/graphics/chromium/cc/CCSchedulerStateMachine.cpp:
      (WebCore::CCSchedulerStateMachine::toString):
      (WebCore):
      (WebCore::CCSchedulerStateMachine::vsyncCallbackNeeded):
      * platform/graphics/chromium/cc/CCSchedulerStateMachine.h:
      (CCSchedulerStateMachine):
      * platform/graphics/chromium/cc/CCSingleThreadProxy.h:
      * platform/graphics/chromium/cc/CCThreadProxy.cpp:
      (WebCore::CCThreadProxy::onCanDrawStateChanged):
      (WebCore):
      (WebCore::CCThreadProxy::beginFrame):
      (WebCore::CCThreadProxy::beginFrameCompleteOnImplThread):
      * platform/graphics/chromium/cc/CCThreadProxy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      588248aa
  2. 04 Sep, 2012 29 commits
    • benjamin@webkit.org's avatar
      Remove WTF_DEPRECATED_STRING_OPERATORS from StylePropertySet.cpp · 77c66802
      benjamin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95800
      
      Patch by Adam Barth <abarth@chromium.org> on 2012-09-04
      Reviewed by Benjamin Poulain.
      
      This patch is a re-spin of part of the patch from
      https://bugs.webkit.org/show_bug.cgi?id=95502, but with the tests
      fixed.  :)
      
      * css/StylePropertySet.cpp:
      (WebCore::StylePropertySet::get4Values):
      (WebCore::StylePropertySet::getLayeredShorthandValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77c66802
    • commit-queue@webkit.org's avatar
      Allow the YarrJIT to use the assembler even when useJIT() is false. · 2793046c
      commit-queue@webkit.org authored
      Introduce the useYarrJIT() option.
      https://bugs.webkit.org/show_bug.cgi?id=95809.
      
      Patch by Mark Lam <mark.lam@apple.com> on 2012-09-04
      Reviewed by Geoffrey Garen.
      
      * runtime/JSGlobalData.cpp:
      (JSC::enableAssembler):
      * runtime/Options.cpp:
      (JSC::Options::initialize):
      * runtime/Options.h:
      (JSC):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2793046c
    • keishi@webkit.org's avatar
      REGRESSION(r126132): MediaSlider and MediaVolumeSlider thumbs don't match mouse when dragged · 349d8e84
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95701
      
      Reviewed by Kent Tamura.
      
      Source/WebCore:
      
      MediaSlider and MediaVolumeSlider thumbs didn't match mouse when dragged because of the negative margin applied to the thumb.
      
      Test: platform/chromium/media/media-volume-slider-hit-test.html
      
      * html/shadow/SliderThumbElement.cpp:
      (WebCore::SliderThumbElement::setPositionFromPoint): Account for margins when calculating the position.
      
      LayoutTests:
      
      * platform/chromium/media/media-volume-slider-hit-test-expected.txt: Added.
      * platform/chromium/media/media-volume-slider-hit-test.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      349d8e84
    • commit-queue@webkit.org's avatar
      [WK2] Use explicit constructor in InjectedBundle. · 98ae2179
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95746
      
      Patch by Kangil Han <kangil.han@samsung.com> on 2012-09-04
      Reviewed by Sam Weinig.
      
      Added explicit keyword in constructor of InjectedBundle in order to avoid implicit type conversion.
      
      * WebProcess/InjectedBundle/InjectedBundle.h:
      (InjectedBundle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98ae2179
    • tkent@chromium.org's avatar
      [Chromium] Update test expectation · 9199e39a
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95395
      
      * platform/chromium-linux/media/track/track-cue-rendering-horizontal-expected.png:
      * platform/chromium-linux/media/track/track-cue-rendering-vertical-expected.png:
      * platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9199e39a
    • tkent@chromium.org's avatar
      [Chromium] Test expectatino update. · d0a8911e
      tkent@chromium.org authored
      * platform/chromium/TestExpectations:
      japanese-ruby-vertical-*.html might be flaky on Windows too.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d0a8911e
    • tony@chromium.org's avatar
      Add a const version of RenderBox::computeLogicalHeight · cf5645c1
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95787
      
      Reviewed by Ojan Vafai.
      
      After this, we can rename the old computeLogicalHeight to computeAndSetLogicalHeight
      to make it clear that it is modifying values.
      
      No new tests, this should just be a refactor.
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::constrainLogicalHeightByMinMax): Make const.
      (WebCore::RenderBox::computeLogicalHeight): Add a const version that takes a LogicalExtentComputedValues struct for out values.
      (WebCore::RenderBox::computeLogicalHeightUsing): Make const.
      (WebCore::RenderBox::computeContentLogicalHeightUsing): Make const.
      (WebCore::RenderBox::computePercentageLogicalHeight): Add a const cast. I tried to
      convert everything below to const, but that's not a simple task. Also, computeReplacedLogicalHeightUsing
      is already using a const_cast.
      * rendering/RenderBox.h:
      (RenderBox): Add const to method signatures.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf5645c1
    • krit@webkit.org's avatar
      -webkit-clip-path does not apply origin for polygon() · 4af9a3ba
      krit@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95656
      
      Reviewed by Tim Horton.
      
      Source/WebCore:
      
      The polygon() shape function did not apply origin of bouding box on created path. The shape was
      not moved to the correct position.
      
      Tests: svg/clip-path/clip-path-shape-polygon-relative-expected.svg
             svg/clip-path/clip-path-shape-polygon-relative.svg
      
      * rendering/style/BasicShapes.cpp:
      (WebCore::BasicShapePolygon::path): Apply origin of bounding box.
      
      LayoutTests:
      
      Check that the origin of the bounding box gets applied to the clip path.
      
      * svg/clip-path/clip-path-shape-polygon-relative-expected.svg: Added.
      * svg/clip-path/clip-path-shape-polygon-relative.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4af9a3ba
    • timothy_horton@apple.com's avatar
      Have NRWT log more output when crash logs are missing · 455b78f8
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95814
      
      Reviewed by Dan Bernstein.
      
      Log the stderr and stdout of the test, in order to provide slightly more
      context when the WebProcess times out while running tests.
      
      * Scripts/webkitpy/layout_tests/port/driver.py:
      (Driver.run_test):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      455b78f8
    • bashi@chromium.org's avatar
      [Chromium] Unreviewed test expectations update after r127534 · e91b504f
      bashi@chromium.org authored
      * platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e91b504f
    • barraclough@apple.com's avatar
      inc/dec behave incorrectly operating on a resolved const · 89f4b827
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95815
      
      Reviewed by Geoff Garen.
      
      Source/JavaScriptCore: 
      
      There are two bugs here.
      
      (1) When the value being incremented is const, and the result is ignored, we assume this cannot be observed, and emit no code.
          However if the value being incremented is not a primitive & has a valueOf conversion, then this should be being called.
      
      (2) In the case of a pre-increment of a const value where the result is not ignored, we'll move +/-1 to the destination, then
          add the resolved const value being incremented to this. This is problematic if the destination is a local, and the const
          value being incremented has a valueOf conversion that throws - the destination will be modified erroneously. Instead, we
          need to use a temporary location.
      
      * bytecompiler/NodesCodegen.cpp:
      (JSC::PostfixResolveNode::emitBytecode):
      (JSC::PrefixResolveNode::emitBytecode):
          - always at least perform a toNumber conversion, use tempDestination when reducing inc/dec to an add +/-1.
      
      LayoutTests: 
      
      Added test cases.
      
      * fast/js/inc-const-valueOf-expected.txt: Added.
      * fast/js/inc-const-valueOf.html: Added.
      * fast/js/script-tests/inc-const-valueOf.js: Added.
      (testPostIncConstVarWithIgnoredResult.const.a.valueOf):
      (testPostIncConstVarWithIgnoredResult):
          test that 'a++' results in a valueOf call, where 'a' is const.
      (testPreIncConstVarWithIgnoredResult.const.a.valueOf):
      (testPreIncConstVarWithIgnoredResult):
          test that '++a' results in a valueOf call, where 'a' is const.
      (testPreIncConstVarWithAssign.const.a.valueOf):
      (testPreIncConstVarWithAssign):
          test that 'b = ++a' does not erroneously update 'b', where 'a' is const.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89f4b827
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update · 7aaa1420
      tkent@chromium.org authored
      Rebaseline vertical-writing tests.
      
      * platform/chromium-linux-x86/fast/writing-mode/border-vertical-lr-expected.txt: Added.
      * platform/chromium-linux-x86/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
      * platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Added.
      * platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
      * platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Added.
      * platform/chromium-linux-x86/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Added.
      * platform/chromium-linux-x86/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
      * platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
      * platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
      * platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.png: Added.
      * platform/chromium-linux/fast/writing-mode/border-vertical-lr-expected.txt: Added.
      * platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.png: Added.
      * platform/chromium-linux/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
      * platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.png: Added.
      * platform/chromium-linux/fast/writing-mode/japanese-rl-selection-expected.txt: Added.
      * platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.png: Added.
      * platform/chromium-linux/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt.
      * platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
      * platform/chromium-mac-snowleopard/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt.
      * platform/chromium-mac/fast/writing-mode/japanese-lr-selection-expected.png: Added.
      * platform/chromium-mac/fast/writing-mode/japanese-rl-selection-expected.png: Added.
      * platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
      * platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
      * platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
      * platform/chromium-mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
      * platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt.
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
      * platform/chromium-win-xp/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Copied from LayoutTests/platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt.
      * platform/chromium-win-xp/fast/dynamic/text-combine-expected.png:
      * platform/chromium-win-xp/fast/dynamic/text-combine-expected.txt: Added.
      * platform/chromium-win-xp/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
      * platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.png:
      * platform/chromium-win-xp/fast/ruby/base-shorter-than-text-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt.
      * platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.png:
      * platform/chromium-win-xp/fast/text/international/text-spliced-font-expected.txt: Added.
      * platform/chromium-win-xp/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
      * platform/chromium-win-xp/fast/writing-mode/border-vertical-lr-expected.txt: Added.
      * platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt:
      * platform/chromium-win-xp/fast/writing-mode/fallback-orientation-expected.png:
      * platform/chromium-win-xp/fast/writing-mode/japanese-lr-selection-expected.txt: Added.
      * platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.png: Removed.
      * platform/chromium-win-xp/fast/writing-mode/japanese-lr-text-expected.txt: Copied from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
      * platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.png: Removed.
      * platform/chromium-win-xp/fast/writing-mode/japanese-rl-text-expected.txt: Renamed from LayoutTests/platform/chromium-linux/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt.
      * platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
      * platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Added.
      * platform/chromium-win-xp/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
      * platform/chromium-win-xp/fast/writing-mode/vertical-align-table-baseline-expected.png:
      * platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.png: Added.
      * platform/chromium-win-xp/fast/writing-mode/vertical-font-fallback-expected.txt: Copied from LayoutTests/platform/chromium-win-xp/fast/writing-mode/broken-ideographic-font-expected.txt.
      * platform/chromium-win-xp/media/track/track-cue-rendering-vertical-expected.png:
      * platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
      * platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
      * platform/chromium-win/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
      * platform/chromium-win/fast/dynamic/text-combine-expected.png:
      * platform/chromium-win/fast/dynamic/text-combine-expected.txt:
      * platform/chromium-win/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
      * platform/chromium-win/fast/ruby/base-shorter-than-text-expected.png:
      * platform/chromium-win/fast/ruby/base-shorter-than-text-expected.txt:
      * platform/chromium-win/fast/text/international/text-spliced-font-expected.png:
      * platform/chromium-win/fast/text/international/text-spliced-font-expected.txt:
      * platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
      * platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
      * platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.png:
      * platform/chromium-win/fast/writing-mode/border-vertical-lr-expected.txt:
      * platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.png:
      * platform/chromium-win/fast/writing-mode/broken-ideographic-font-expected.txt:
      * platform/chromium-win/fast/writing-mode/fallback-orientation-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-lr-selection-expected.txt:
      * platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-lr-text-expected.txt:
      * platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-rl-selection-expected.txt:
      * platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-rl-text-expected.txt:
      * platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Removed.
      * platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
      * platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
      * platform/chromium-win/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
      * platform/chromium-win/fast/writing-mode/vertical-align-table-baseline-expected.png:
      * platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.png: Added.
      * platform/chromium-win/fast/writing-mode/vertical-font-fallback-expected.txt:
      * platform/chromium-win/media/track/track-cue-rendering-vertical-expected.png:
      * platform/chromium-win/media/track/track-cue-rendering-vertical-expected.txt:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7aaa1420
    • roger_fong@apple.com's avatar
    • roger_fong@apple.com's avatar
    • commit-queue@webkit.org's avatar
      Make chromium-linux build without WTF_DEPRECATED_STRING_OPERATORS · fea002d0
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95798
      
      Patch by Adam Barth <abarth@chromium.org> on 2012-09-04
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      This patch makes the chromium-linux port build without
      WTF::String::operator+=.  There are a couple places that require some
      more careful study, and I've whitelisted those uses by defining
      WTF_DEPRECATED_STRING_OPERATORS at the top of the files. (See
      https://bugs.webkit.org/show_bug.cgi?id=95797 for an explanation of
      WTF_DEPRECATED_STRING_OPERATORS.)
      
      * css/StylePropertySet.cpp:
      * inspector/InspectorOverlay.cpp:
      (WebCore::InspectorOverlay::drawNodeHighlight):
      * platform/graphics/filters/CustomFilterValidatedProgram.cpp:
      (WebCore::CustomFilterValidatedProgram::rewriteMixVertexShader):
      
      Source/WebKit/chromium:
      
      * src/WebAccessibilityObject.cpp:
      (WebKit::WebAccessibilityObject::keyboardShortcut):
        - Remove use of WTF::String::operator+=
      * src/WebPageSerializerImpl.cpp:
        - Whitelist use of WTF::String::operator+=. Remove this use will take
          some more careful thought.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fea002d0
    • roger_fong@apple.com's avatar
    • tony@chromium.org's avatar
      Use TrackedRendererListHashSet typedef for percentHeightDescendants() · 05b9d2c6
      tony@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95791
      
      Reviewed by Ojan Vafai.
      
      There were a couple callers that were using ListHashSet<RenderBox*> instead of the typedef.
      
      No new tests, this is just a refactor.
      
      * rendering/RenderTableSection.cpp:
      (WebCore::RenderTableSection::layoutRows):
      * rendering/RenderView.cpp:
      (WebCore::RenderView::setFixedPositionedObjectsNeedLayout):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05b9d2c6
    • roger_fong@apple.com's avatar
    • fpizlo@apple.com's avatar
      DFG GetByVal for JSArrays shouldn't OSR exit every time that the index is out of bound · fa34ff8b
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95717
      
      Reviewed by Oliver Hunt.
              
      Rolling back in after fixing the negative index case.
      
      Make GetByVal for JSArrayOutOfBounds do meaningful things. The profiling was already
      there so we should just use it!
      
      * bytecode/DFGExitProfile.h:
      (JSC::DFG::exitKindToString):
      * dfg/DFGAbstractState.cpp:
      (JSC::DFG::AbstractState::execute):
      * dfg/DFGOperations.cpp:
      * dfg/DFGOperations.h:
      * dfg/DFGSpeculativeJIT.h:
      (JSC::DFG::SpeculativeJIT::callOperation):
      * dfg/DFGSpeculativeJIT32_64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      * dfg/DFGSpeculativeJIT64.cpp:
      (JSC::DFG::SpeculativeJIT::compile):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa34ff8b
    • commit-queue@webkit.org's avatar
      IndexedDB: remove final createIndex backend glue · cc94e653
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95385
      
      Patch by Alec Flett <alecflett@chromium.org> on 2012-09-04
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Remove all code that created index keys in the IndexedDB backend.
      
      No new tests, this is just removal of dead code.
      
      * Modules/indexeddb/IDBKeyPathBackendImpl.cpp: Removed.
      * Modules/indexeddb/IDBKeyPathBackendImpl.h: Removed.
      * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
      (WebCore):
      * WebCore.gyp/WebCore.gyp:
      * WebCore.gypi:
      * storage/chromium/IDBKeyPathBackendImpl.cpp: Removed.
      
      Source/WebKit/chromium:
      
      Remove chromium glue for old key-generation code.
      
      * public/WebIDBKey.h:
      (WebIDBKey):
      * src/WebIDBKey.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc94e653
    • commit-queue@webkit.org's avatar
      Frame element doesn't always unload its child frame. · 4f074eea
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94717
      
      Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2012-09-04
      Reviewed by Hajime Morita.
      
      Source/WebCore:
      
      It's possible for a frame element that has been removed from the document
      to retain an active child frame. This inconsistent state may become a source
      of security vulnerabilities.
      
      The patch adds a global HashSet to store the nodes currently processed by
      ChildFrameDisconnector. Insertion into these nodes' subtrees is not allowed until
      the processing is complete.
      
      Also, the ChildFrameDisconnector call in removeChild(ren) is now immediately
      followed by the actual removal.
      
      Test: fast/frames/out-of-document-iframe-has-child-frame.html
      
      * dom/ContainerNode.cpp:
      (WebCore::willRemoveChildren): Move the ChildFrameDisconnector call out of a loop.
      (WebCore::ContainerNode::removeChild): Rearrange some event firing code.
      (WebCore::ContainerNode::removeChildren): Ditto.
      * dom/ContainerNodeAlgorithms.cpp:
      (WebCore::ChildFrameDisconnector::collectDescendant): Pass a new parameter to collectDescendant(Node*).
      * dom/ContainerNodeAlgorithms.h:
      (WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
      (ChildFrameDisconnector): Maintain a list of nodes that have an active ChildFrameDisconnector.
      (WebCore::ChildFrameDisconnector::~ChildFrameDisconnector):
      (WebCore::ChildFrameDisconnector::rootNodes):
      (WebCore::ChildFrameDisconnector::collectDescendant): Add ShouldIncludeRoot parameter.
      (WebCore::ChildFrameDisconnector::nodeHasDisconnector):
      (WebCore):
      * dom/Node.cpp:
      (WebCore::checkAcceptChild): Reject a parent node if it or one of its parents has an active ChildFrameDisconnector.
      * html/HTMLFrameElementBase.cpp:
      (WebCore::HTMLFrameElementBase::didNotifySubtreeInsertions): Check if an element is still in the document.
      
      LayoutTests:
      
      * fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
      * fast/frames/out-of-document-iframe-has-child-frame.html: Added.
      * fast/innerHTML/innerHTML-iframe-expected.txt:
      * platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt: Added.
      * platform/chromium/fast/innerHTML: Added.
      * platform/chromium/fast/innerHTML/innerHTML-iframe-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4f074eea
    • bashi@chromium.org's avatar
      [Chromium] Unreviewed test expectation update after r127457 · db08652d
      bashi@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db08652d
    • roger_fong@apple.com's avatar
      Unreviewed. Adding test inspector/timeline/timeline-decode-resize.html to Windows skip list. · d79fb265
      roger_fong@apple.com authored
      It fails on both Windows and Mac: https://bugs.webkit.org/show_bug.cgi?id=94374.
      
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d79fb265
    • roger_fong@apple.com's avatar
      Unreviewed. Rebaseline tests after http://trac.webkit.org/changeset/127354. · 8c8a9b09
      roger_fong@apple.com authored
      * platform/win/fast/text/international/text-spliced-font-expected.txt:
      * platform/win/fast/writing-mode/border-vertical-lr-expected.txt:
      * platform/win/fast/writing-mode/japanese-lr-selection-expected.txt:
      * platform/win/fast/writing-mode/japanese-lr-text-expected.txt:
      * platform/win/fast/writing-mode/japanese-rl-selection-expected.txt:
      * platform/win/fast/writing-mode/japanese-rl-text-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c8a9b09
    • bashi@chromium.org's avatar
      [Chromium] Attempt to fix build failure on Win · d4f6dafa
      bashi@chromium.org authored
      Remove chromium/public/WebOfferAnswerRequest.h from Platform.gypi,
      which was added in r127501, but doesn't exist. Unreviewed.
      
      * Platform.gypi:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4f6dafa
    • weinig@apple.com's avatar
      Part 1 of removing PlatformString.h, move remaining functions to new homes · aa390c30
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=95702
      
      Reviewed by Beth Dakin.
      
      Source/WebCore:
      
      Move utf8Buffer() to SharedBuffer.h/cpp
      Move numGraphemeClusters() and numCharactersInGraphemeClusters() to TextBreakIterator.h/cpp
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      Update projects.
      
      * platform/text/TextAllInOne.cpp:
      Add TextBreakIterator.cpp.
      
      * editing/Editor.h:
      Forward declare SharedBuffer, now that PlatformString.h doesn't.
      
      * html/InputType.cpp:
      #include TextBreakIterator.h.
      
      * loader/appcache/ApplicationCacheStorage.h:
      Replace inclusion of PlatformString.h with WTFString.h and forward declare SharedBuffer.
      
      * platform/LocalizedStrings.cpp:
      Replace inclusion of PlatformString.h with TextBreakIterator.h
      
      * platform/SharedBuffer.cpp:
      * platform/SharedBuffer.h:
      Move utf8Buffer() here.
      
      * platform/text/PlatformString.h:
      Remove everything except the #include of WTFString.h.
      
      * platform/text/TextBreakIterator.cpp: Renamed from Source/WebCore/platform/text/String.cpp.
      (WebCore::numGraphemeClusters):
      (WebCore::numCharactersInGraphemeClusters):
      * platform/text/TextBreakIterator.h:
      Move numGraphemeClusters() and numCharactersInGraphemeClusters() here.
      
      Source/WebKit2:
      
      * UIProcess/WebPageProxy.h:
      Forward declare SharedBuffer.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa390c30
    • jchaffraix@webkit.org's avatar
      REGRESSION(r120832): RenderLayer::clampScrollOffset doesn't properly clamp · deb687a6
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95776
      
      Reviewed by Simon Fraser.
      
      .:
      
      * ManualTests/select-menu-list-wrongly-positioned.html: Added.
      
      Source/WebCore:
      
      r120832 consolidated the clamping logic into RenderLayer::clampScrollOffset. The existing code wouldn't properly ensure that
      the offset were positive which got exposed to other code paths, leading to the regression.
      
      Tested by ManualTests/select-menu-list-wrongly-positioned.html as I didn't find a way to create a reliable layout test.
      
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::clampScrollOffset):
      Fixed the clamping logic to ensure that the scroll offset's dimensions are positive.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      deb687a6
    • roger_fong@apple.com's avatar
      Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows... · 7e8ccee7
      roger_fong@apple.com authored
      Unreviewed gardening. editing/style/apply-style-atomic.html fails on Windows since introduced in http://trac.webkit.org/changeset/126865.
      Test added to skip list.
      
      https://bugs.webkit.org/show_bug.cgi?id=95795
      
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e8ccee7
    • jsbell@chromium.org's avatar
      IndexedDB: IDBRequest leaks if IDBCursor closes and no further events fired · ffff0781
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95777
      
      Reviewed by Tony Chang.
      
      IDBRequests are kept alive as long as they may fire events, which includes
      if the associated IDBCursor object can be advanced. When the transaction
      is finished the IDBCursor is notified which in turn tells the IDBRequest
      that the cursor won't be the source of more events. However, if this occurs
      and no further events fire the IDBRequest doesn't clear it's "has pending
      activity flag". Clear the flag on the notification if the request is
      otherwise complete.
      
      No new tests - ActiveDOMObjects and leaks are persnickety.
      
      * Modules/indexeddb/IDBRequest.cpp:
      (WebCore::IDBRequest::finishCursor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffff0781