1. 22 May, 2007 15 commits
    • hyatt's avatar
      Add layout test for better background dumping. · bb21e287
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Fix for bug 13802, background colors can't be reset to default · 0beef8a8
      hyatt authored
              color.  Fix the value cssText method to do the right thing for background
              and background-position values.
              Reviewed by beth
              * css/CSSInitialValue.h:
              * css/CSSMutableStyleDeclaration.cpp:
              * css/CSSMutableStyleDeclaration.h:
              * css/CSSValue.h:
              * css/cssparser.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      LayoutTests: · cc06b695
      darin authored
              Reviewed by Geoff.
              - test for <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
              * fast/dom/iframe-document.html: Updated test to expect no document property.
              * fast/dom/iframe-document-expected.txt: Updated.
              * fast/forms/focus2.html: Changed test to use ownerDocument instead of document.
              Reviewed by Geoff.
              - fix <rdar://problem/5215830> REGRESSION: ebay.com layout is wrong
              The code on ebay was looking for the "document" property on a iframe.
              We changed that to be the ownerDocument rather than the contentDocument,
              which was not what ebay was expecting. The best fix seems to be removing
              the document property altogether.
              Test: fast/dom/iframe-document.html
              * bindings/js/kjs_html.h: Remove ElementDocument.
              * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::getValueProperty): Ditto.
              Reviewed by Geoff.
              * WebInspector/webInspector/treeoutline.js: Use ownerDocument instead of non-standard
              document property.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      Reviewed by Darin. · e1787a6a
      adele authored
              A little cleanup from my last checkin.
              * page/Chrome.h: Formatting change.
              * page/mac/ChromeMac.mm: Fixed copyright.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      LayoutTests: · 82c11d19
      adele authored
              Reviewed by Darin.
              Test for http://bugs.webkit.org/show_bug.cgi?id=13796
              Crash in [NSInputContext currentInputContext] when you click on this map
              * fast/frames/frame-display-none-focus-expected.txt: Added.
              * fast/frames/frame-display-none-focus.html: Added.
              * fast/frames/resources/iframe-focus.html: Added.
              Reviewed by Darin.
              Fix for http://bugs.webkit.org/show_bug.cgi?id=13796
              Crash in [NSInputContext currentInputContext] when you click on this map
              This is another case of <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
              Test: fast/frames/frame-display-none-focus.html
              * WebCore.xcodeproj/project.pbxproj: Added ChromeMac.mm
              * page/Chrome.h:
              * page/mac/ChromeMac.mm: Added.
              (WebCore::Chrome::focusNSView): Moved code from Widget::setFocus so it can be used whenever we need to make a view the first responder.
              * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView): Calls focusNSView.
              * platform/mac/WidgetMac.mm: (WebCore::Widget::setFocus): Calls focusNSView.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · 384cf314
      justing authored
              Reviewed by darin
              <rdar://problem/4875189> List is deleted when replacing contents with Chinese/Japanese characters
              Moved from unsupported-content because we've supported editing lists
              for a while now:
              * editing/deleting/4875189-expected.checksum: Added.
              * editing/deleting/4875189-expected.png: Added.
              * editing/deleting/4875189-expected.txt: Added.
              * editing/deleting/4875189.html: Added.
              * editing/unsupported-content/list-delete-002-expected.checksum: Removed.
              * editing/unsupported-content/list-delete-002-expected.png: Removed.
              * editing/unsupported-content/list-delete-002-expected.txt: Removed.
              * editing/unsupported-content/list-delete-002.html: Removed.
              Reflects new behavior:
              * editing/deleting/delete-select-all-003-expected.checksum:
              * editing/deleting/delete-select-all-003-expected.png:
              * editing/deleting/delete-select-all-003-expected.txt:
              Ditto and also removed a FIXME:
              * editing/deleting/list-item-1-expected.checksum:
              * editing/deleting/list-item-1-expected.png:
              * editing/deleting/list-item-1-expected.txt:
              * editing/deleting/list-item-1.html:
              Reviewed by darin
              List is deleted when replacing contents with Chinese/Japanese characters
              * editing/htmlediting.cpp:
              (WebCore::isSpecialElement): Lists are no longer special.
              They can be removed by removing their content and then 
              then hitting delete inside of the empty list item that's 
              left over. Even when that list item is the first thing 
              in the editable region.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      Reviewed by Darin. · 6793e484
      adele authored
              Adding some asserts to help detect other cases of <rdar://problem/5171145>
              * WebCoreSupport/WebFrameBridge.mm: (-[WebFrameBridge makeFirstResponder:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Tim Hatcher. · da7cd15c
      darin authored
              - fix <rdar://problem/5206089> REGRESSION: hovering over amazon.com "product categories"
                tab makes page content disappear
              The contentWindow property was doing a cross-frame security check, but it shouldn't.
              Window objects are responsible for protecting themselves from cross-frame activity.
              Because contentWindow returned undefined, we then ended up setting visibility on the
              body of the main frame to "hidden".
              No layout test yet. When we make cross-domain tests, we should include this one.
              * html/HTMLFrameElement.idl: Removed CheckFrameSecurity attribute from contentWindow.
              * html/HTMLIFrameElement.idl: Ditto.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • kmccullo's avatar
      Reviewed by. · e3681b65
      kmccullo authored
              - Forgot to checkin for fix for rdar://problem/4981886
              * fast/dom/open-and-close-by-DOM-expected.txt: Added.
              * fast/dom/open-and-close-by-DOM.html: Added.
              * fast/dom/resources/close.html: Added.
              * fast/dom/resources/middle.html: Added.
              * http/tests/security/local-image-from-remote.html:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      LayoutTests: · 00b7e557
      justing authored
              Reviewed by oliver
              REGRESSION(r21467): Active selection remains in text field after clicking on a button
              Demonstrates bug:
              * editing/selection/5213963-expected.checksum: Added.
              * editing/selection/5213963-expected.png: Added.
              * editing/selection/5213963-expected.txt: Added.
              * editing/selection/5213963.html: Added.
              We now clear the selection on mouse down (but not before
              the mousedown event is fired):
              * fast/forms/focus-selection-input-expected.txt:
              * fast/forms/focus-selection-textarea-expected.txt:
              Reviewed by oliver
              REGRESSION(r21467): Active selection remains in text field after clicking on a button
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchMouseEvent): Call
              FocusController::setFocusedNode, because Document::setFocusedNode
              no longer clears the selection.
              Begin passing the new focused frame to 
              FocusController::setFocusedNode, because when the 
              new focus node is null, the selection should only be 
              cleared if the focused frame isn't changing.
              (WebCore::Element::focus): Begin passing the new focused
              (WebCore::Element::blur): Ditto.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::focus): Ditto.
              * html/HTMLTextAreaElement.cpp:
              (WebCore::HTMLTextAreaElement::focus): Ditto.
              * page/Frame.cpp:
              (WebCore::Frame::setFocusedNodeIfNeeded): Ditto.
              * page/FocusController.cpp:
              (WebCore::clearSelectionIfNeeded): Take in the new
              focused frame.  If it's not changing, don't clear the
              (WebCore::FocusController::setFocusedNode): Take
              in the new focused frame.
              * page/FocusController.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • beidson's avatar
      Reviewed by Kevin (Sarge) · cc652ea3
      beidson authored
              <rdar://problem/5219885> - Crash after closing a inline popup ad at http://news.yahoo.com/
              This regressed in http://trac.webkit.org/projects/webkit/changeset/21618
              * WebView/WebFrame.mm:
              (-[WebFrame dataSource]): Null check the frameloader
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • staikos's avatar
      back this out for zack · df04993a
      staikos authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • zack's avatar
      Path implementing more Cliboard from Marius Bugge Monsen. · 329e627d
      zack authored
      Adding implementations of some of the missing methods.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hausmann's avatar
      Fix http headers for POST. · 088e3448
      hausmann authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • justing's avatar
      Updating expected results for r21074. · 18125c04
      justing authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  2. 21 May, 2007 21 commits
    • oliver's avatar
      2007-05-21 Oliver Hunt <oliver@apple.com> · 7fa2f31b
      oliver authored
              Reviewed by Sam.
              Layout test for http://bugs.webkit.org/show_bug.cgi?id=13789
              * svg/custom/getscreenctm-in-mixed-content-expected.checksum: Added.
              * svg/custom/getscreenctm-in-mixed-content-expected.png: Added.
              * svg/custom/getscreenctm-in-mixed-content-expected.txt: Added.
              * svg/custom/getscreenctm-in-mixed-content.xhtml: Added.
              Reviewed by Sam.
              Fix for http://bugs.webkit.org/show_bug.cgi?id=13789 
              -- SVGLocatable::getScreenCTM() faulty
              Needed to update SVGLength to handle the case where the SVGElement is
              not the root document element -- we do this by falling back on the 
              renderer for the context.
              For <svg> elements embedded as mixed content in xhtml we consider the
              absolutePosition of the parent to be the origin for the <svg> element.
              * ksvg2/svg/SVGLength.cpp:
              * ksvg2/svg/SVGSVGElement.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • thatcher's avatar
      Reviewed by Adam. · 428cde24
      thatcher authored
              <rdar://problem/5084400> -[DOMRange lineBoxRects] returns an empty array when the DOM nodes have just been created
              Do a updateLayoutIgnorePendingStylesheets before asking the Node or Range for it's box rects.
              * bindings/objc/DOM.mm:
              (-[DOMNode boundingBox]):
              (-[DOMNode lineBoxRects]):
              (-[DOMRange boundingBox]):
              (-[DOMRange lineBoxRects]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      Reviewed by George Staikos. · 151497a0
      weinig authored
              Fix Qt build.
              * WebCore.pro: add missing IDL files.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21634 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      LayoutTests: · 4d7ce9a5
      weinig authored
              Reviewed by Darin.
              - update tests and results for http://bugs.webkit.org/show_bug.cgi?id=13803
                to account for the new JSHTMLMarquee that is being autogenerated and
                can now produce a constructor.
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/element-constructors-on-window.html:
              * fast/dom/Window/window-properties-expected.txt:
              Reviewed by Darin.
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13803
              Autogenerate the JS bindings for the HTMLMarqueeElement.
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/kjs_css.cpp:
              (KJS::DOMCSSRule::getOwnPropertySlot): Fix possible null pointer issue.
              (KJS::DOMCSSRule::put): Fix possible null pointer issue.
              * bindings/js/kjs_html.cpp:
              (KJS::JSHTMLElement::getOwnPropertySlot): Fix null pointer issue.
              * bindings/js/kjs_html.h:
              * html/HTMLMarqueeElement.cpp:
              * html/HTMLMarqueeElement.h: Add start() and stop() functions.
              * html/HTMLMarqueeElement.idl: Added.
              * page/DOMWindow.idl: Add marquee constructor.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21633 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • adele's avatar
      WebCore: · dd237c40
      adele authored
              Fix by Darin, reviewed by me.
              Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
              * platform/mac/WidgetMac.mm:
              (WebCore::safeRemoveFromSuperview): Added. If the view is the window's first responder, then 
               set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
              (WebCore::Widget::setFocus): Don't attempt to focus the view if it has no window.
              (WebCore::Widget::removeFromSuperview): Call safeRemoveFromSuperview.
              (WebCore::Widget::afterMouseDown): ditto.
              Fix by Darin, reviewed by me.
              Fix for <rdar://problem/5171145> Safari crashed closing tab in NSInputContext updateInputContexts
              * WebView/WebFrameView.mm: (-[WebFrameView _setDocumentView:]): If the old view is the first responder,
              then set the window's first responder to nil so we don't leave the window pointing to a view that's no longer in it.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21632 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      · b3baea79
      weinig authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Make a line gutter backdrop so that tiny view source docs don't look · 52b9b637
      hyatt authored
              Reviewed by aroben
              * css/view-source.css:
              * html/HTMLViewSourceDocument.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21630 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Make sure to distinguish between links to internal resources and · 339df964
      hyatt authored
              real links (anchors) in view source mode.
              Reviewed by aroben
              * css/view-source.css:
              * html/HTMLViewSourceDocument.cpp:
              * html/HTMLViewSourceDocument.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • beidson's avatar
      Making the importance of my last change more clear · 70ce7065
      beidson authored
              * WebView/WebViewPrivate.h: "Leave for Dashboard, people!"
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • beidson's avatar
      Reviewed by Kevin (Sarge) · 274265e3
      beidson authored
              <rdar://problem/5217124> - Re-add mistakenly removed SPI
              * WebView/WebView.mm:
              (-[WebView handleAuthenticationForResource:challenge:fromDataSource:]):
              * WebView/WebViewPrivate.h:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • weinig's avatar
      LayoutTests: · 16885ff7
      weinig authored
              Reviewed by Adam and Darin.
              - update results for http://bugs.webkit.org/show_bug.cgi?id=13791
                to account for new JSHTMLElements that are being autogenerated and
                can now produce constructors.
              * fast/dom/Window/element-constructors-on-window-expected.txt:
              * fast/dom/Window/window-properties-expected.txt:
              Reviewed by Adam and Darin.
              Patch for http://bugs.webkit.org/show_bug.cgi?id=13791
              Autogenerate the JS bindings for the HTMLIFrameElement and HTMLFrameElement.
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSHTMLAnchorElementCustom.cpp:
              * bindings/js/JSHTMLElementWrapperFactory.cpp:
              * bindings/js/kjs_html.cpp:
              * bindings/js/kjs_html.h:
              * bindings/scripts/CodeGeneratorJS.pm:
              * html/HTMLFrameElement.idl:
              * html/HTMLFrameElementBase.cpp:
              * html/HTMLFrameElementBase.h:
              * html/HTMLFrameOwnerElement.h:
              * html/HTMLIFrameElement.idl:
              * page/DOMWindow.idl:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • andersca's avatar
      Reviewed by Ada. · 8cb65d5a
      andersca authored
              <rdar://problem/5200816> REGRESSION: With Shiira 1.2.2 , I can't open embedded link in flash object by clicking (http:/www.adobe.com )
              Null check the request.
              * WebView/WebView.mm:
              (+[WebView _canHandleRequest:]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • lars's avatar
      Updating and adding test cases. · f3564481
      lars authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • lars's avatar
      Reviewed by Simon · b2c8d268
      lars authored
              Remove the userHandle methods from QWebnetworkJob again.
              They don't really give us anything and just clutter the API.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hausmann's avatar
      Export the new qt network API. · 9391c471
      hausmann authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • lars's avatar
      Reviewed by Zack. · 31303062
      lars authored
              Add an API layer for network downloads. Basically QWebnetworkInterface
              is an interface class for downloading resources. QWebnetworkJob describes
              the actual object to download.
              QWebNetworkInterface has a default implementation that replaces the
              old ResourceHandleManager class in the Qt port.
              Remove the ResourceHandleManager class, it is now part of 
              QWebNetworkInterface. Adapt ResourceHandle to the new way 
              of things.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • mjs's avatar
      Reviewed by Geoff. · 05011d70
      mjs authored
              <rdar://problem/5205358> REGRESSION (r21367): All messages appear entirely blank when running Mail off of tip of tree WebKit
              The fix is to return nil from [WebFrame dataSource] when it has not loaded anything but the fake
              empty initial document. However, WebKit still needs the real data source internally, so I also
              added a [WebFrame _dataSource] method that skips this check, and made WebKit use it throughout.
              * Misc/WebNSAttributedStringExtras.mm:
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView dataSource]):
              * Plugins/WebNullPluginView.mm:
              (-[WebNullPluginView viewDidMoveToWindow]):
              * Plugins/WebPluginController.mm:
              (-[WebPluginController URLPolicyCheckReferrer]):
              * WebCoreSupport/WebFrameBridge.mm:
              (-[WebFrameBridge dataSource]):
              (-[WebFrameBridge redirectDataToPlugin:]):
              * WebCoreSupport/WebFrameLoaderClient.mm:
              * WebCoreSupport/WebViewFactory.mm:
              (-[WebViewFactory bridgeForView:]):
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebArchiver.mm:
              (+[WebArchiver archiveFrame:]):
              (+[WebArchiver archiveMainResourceForFrame:]):
              (+[WebArchiver _archiveWithMarkupString:fromFrame:nodes:]):
              (+[WebArchiver archiveSelectionInFrame:]):
              * WebView/WebFrame.mm:
              (-[WebFrame _loadURL:referrer:intoChild:]):
              (-[WebFrame _addChild:]):
              (-[WebFrame _dataSource]):
              (-[WebFrame DOMDocument]):
              (-[WebFrame dataSource]):
              * WebView/WebFrameInternal.h:
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _setPrinting:minimumPageWidth:maximumPageWidth:adjustViewSize:]):
              * WebView/WebRenderNode.mm:
              (-[WebRenderNode initWithWebFrameView:]):
              * WebView/WebView.mm:
              (-[WebView _mainFrameOverrideEncoding]):
              (-[WebView mainFrameURL]):
              (-[WebView mainFrameTitle]):
              (-[WebView mainFrameIcon]):
              (-[WebView validateUserInterfaceItemWithoutDelegate:]):
              (-[WebView replaceSelectionWithArchive:]):
              (-[WebView _isLoading]):
              (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
              (-[WebView _notifyTextSizeMultiplierChanged]):
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Update test results for improved colgroup span handling. · 60ada7c5
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Add new layout test for spanning colgroup rules=groups bug. · 870142ec
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Second half of fix for 13793, make sure rules=groups works properly with · 4699f527
      hyatt authored
              spanning colgroups.
              Also make sure colgroups get an actual span of 1 (instead of incorrectly
              giving them a span of 0).
              Reviewed by mitz
              * html/HTMLTableColElement.cpp:
              * rendering/RenderTable.cpp:
              * rendering/RenderTable.h:
              * rendering/RenderTableCell.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • hyatt's avatar
      Half of a fix for 13793, make sure rules=groups and border behave properly · f5fc941d
      hyatt authored
              Reviewed by mitz
              No tests added, two Mozilla table tests now pass that failed before.
              * html/HTMLTableElement.cpp:
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
  3. 20 May, 2007 4 commits
    • bdash's avatar
      Fix spelling. · a17d2ac0
      bdash authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • beidson's avatar
      Reviewed by Geoose Garen · 2e037c18
      beidson authored
              <rdar://problem/4758919> - Incorrect favicon shown for URL after going back
              When restoring a cached page, we'd try to kick off the icon load for it, which ended up causing 
              shenanigans with the icon url -> page url mapping.  
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::endIfNotLoading): Only try an icon load if we're not restoring from the page cache
              (WebCore::FrameLoader::startIconLoader): Added helpful logging that helped me track this down
              (WebCore::FrameLoader::commitIconURLToIconDatabase): Ditto (and fixed a comment typo)
              * loader/icon/IconLoader.cpp:
              (WebCore::IconLoader::stopLoading): Don't null out the ResourceLoader here, as clearLoadingState() does that
              (WebCore::IconLoader::finishLoading): Added helpful logging that helped me track this down
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • darin's avatar
      Reviewed by Oliver Hunt. · 29df4b01
      darin authored
              - fix <rdar://problem/5193416> REGRESSION: Selection on large pages extremely slow
              * dom/Document.cpp: (WebCore::Document::removeMarkers): Added an early exit for the common
              case where there are no markers. Changed code to iterate over all the nodes in the range
              instead of using TextIterator, which is more efficient.
              * page/Frame.cpp: (WebCore::Frame::respondToChangedSelection): Added checks for editable,
              so we don't bother doing work related to spell checking and grammar checking when changing
              the selection in non-editable text. Also rearranged the code so we only compute the old
              word boundaries and sentence boundaries when actually needed, and don't do the sentence
              range checks unless grammar checking is enabled.
              * platform/TextBreakIteratorICU.cpp:
              (WebCore::setUpIterator): Don't take a locale parameter. Always pass in currentTextBreakLocaleID.
              (WebCore::characterBreakIterator): Removed local parameter.
              (WebCore::wordBreakIterator): Ditto.
              (WebCore::lineBreakIterator): Ditto.
              (WebCore::sentenceBreakIterator): Ditto.
              * platform/mac/TextBreakIteratorInternalICUMac.mm:
              (WebCore::getTextBreakLocale): Broke out the code to actually get the locale.
              (WebCore::currentTextBreakLocaleID): This function now handles only the caching and calls
              getTextBreakLocale to actually figure it out.
              * editing/visible_units.cpp: Added lots of FIXME comments, but no code change.
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    • staikos's avatar
      add -f to cp for some obscure build systems. · 685241da
      staikos authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@21610 268f45cc-cd09-0410-ab3c-d52691b4dbfc