1. 24 Feb, 2006 20 commits
    • ggaren's avatar
      LayoutTests: · bb167e66
      ggaren authored
              Reviewed by Hyatt.
      
              -tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=5146
      
              * fast/replaced/maxheight-percent.html: Added.
              * fast/replaced/maxheight-pxs.html: Added.
              * fast/replaced/maxwidth-percent.html: Added.
              * fast/replaced/maxwidth-pxs.html: Added.
              * fast/replaced/minheight-percent.html: Added.
              * fast/replaced/minheight-pxs.html: Added.
              * fast/replaced/minwidth-percent.html: Added.
              * fast/replaced/minwidth-pxs.html: Added.
              * fast/replaced/resources/1x1-blue.png: Added.
              * fast/replaced/resources/square-blue-100x100.png: Added.
      
      WebCore:
      
              Reviewed by Hyatt, tweaked and landed by ggaren.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5146
                max-height/max-width not resizing images with correct aspect ratio
      
              This patch is a port and adaptation of Allan Sandfeld Jensen's (carewolf)
              patch of http://bugs.kde.org/show_bug.cgi?id=120107 with the needed
              modifications to suit the Webcore tree.  Makes images respect min/max 
              sizes and their intrinsic aspect ratios at the same time according to 
              CSS 2.1 (http://www.w3.org/TR/CSS21/visudet.html#min-max-widths).  
      
              Test: fast/replaced/maxheight-percent.html
              Test: fast/replaced/maxheight-pxs.html
              Test: fast/replaced/maxwidth-percent.html
              Test: fast/replaced/maxwidth-pxs.html
              Test: fast/replaced/minheight-percent.html
              Test: fast/replaced/minheight-pxs.html
              Test: fast/replaced/minwidth-percent.html
              Test: fast/replaced/minwidth-pxs.html
      
              * rendering/render_box.cpp:
              (WebCore::RenderBox::calcReplacedWidth):
              (WebCore::RenderBox::calcReplacedWidthUsing):
              (WebCore::RenderBox::calcReplacedHeight): 
              (WebCore::RenderBox::calcReplacedHeightUsing): Calculate percent heights correctly
              * rendering/render_image.cpp: Respect aspect ratios and calculate max/min
              (WebCore::RenderImage::calcReplacedWidth):
              (WebCore::RenderImage::calcReplacedHeight):
              (WebCore::RenderImage::calcAspectRatioWidth): Added
              (WebCore::RenderImage::calcAspectRatioHeight): Added
              (WebCore::RenderImage::calcMinMaxWidth): Added
              * rendering/render_image.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12981 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb167e66
    • vicki's avatar
      - add missing resources for manual-tests/scrolling-nestedframesets.html · 36c472f2
      vicki authored
              * manual-tests/resources/testframe-link_text.html: Added.
              * manual-tests/resources/testframeset.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12980 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36c472f2
    • vicki's avatar
      - test case for <rdar://problem/4394910> calling Javascript... · a1c0d00c
      vicki authored
              - test case for <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event
      
              * manual-tests/onbeforeunload-close_with_javascript.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12979 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a1c0d00c
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · 0a5c4e11
      eseidel authored
              Reviewed by mjs.
      
              Add Path stubs for Win32 build.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * platform/win/TemporaryLinkStubs.cpp:
              (Path::Path):
              (Path::~Path):
              (Path::operator=):
              (Path::contains):
              (Path::translate):
              (Path::boundingRect):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12978 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0a5c4e11
    • hyatt's avatar
      In preparation for the elimination of QFont and QFontMetrics, rename... · 3e99d1ca
      hyatt authored
              In preparation for the elimination of QFont and QFontMetrics, rename methods on RenderStyle.  htmlFont() becomes simply
              font().  The old font() method turns into qfont().  Also added a helper for obtaining the fontDescription() directly from
              the RenderStyle (without first obtaining the htmlFont()).
      
              Reviewed by darin
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/DOM.mm:
              (-[DOMElement _font]):
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::attributedString):
              (WebCore::MacFrame::fontForSelection):
              (WebCore::MacFrame::fontAttributesForSelectionStart):
              * css/css_computedstyle.cpp:
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              * css/css_valueimpl.cpp:
              (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::styleForElement):
              (WebCore::CSSStyleSelector::pseudoStyleForElement):
              (WebCore::CSSStyleSelector::applyProperty):
              (WebCore::CSSStyleSelector::checkForTextSizeAdjust):
              (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::recalcStyle):
              * editing/visible_text.cpp:
              (khtml::TextIterator::exitNode):
              * ksvg2/svg/SVGLengthImpl.cpp:
              (SVGLengthImpl::updateValue):
              * kwq/KWQAccObject.mm:
              (AXAttributeStringSetStyle):
              * rendering/InlineTextBox.cpp:
              (khtml::InlineTextBox::paint):
              (khtml::InlineTextBox::offsetForPosition):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::shouldUseMonospaceCache):
              (WebCore::RenderText::font):
              (WebCore::RenderText::width):
              (WebCore::RenderText::htmlFont):
              * rendering/bidi.cpp:
              (khtml::RenderBlock::tabWidth):
              (khtml::RenderBlock::checkLinesForTextOverflow):
              * rendering/render_br.cpp:
              (WebCore::RenderBR::lineHeight):
              * rendering/render_flexbox.cpp:
              (khtml::RenderFlexibleBox::layoutVerticalBox):
              * rendering/render_flow.cpp:
              (WebCore::RenderFlow::lineHeight):
              * rendering/render_form.cpp:
              (WebCore::RenderFormElement::setStyle):
              (WebCore::RenderFormElement::addIntrinsicMarginsIfAllowed):
              * rendering/render_image.cpp:
              (WebCore::RenderImage::paint):
              * rendering/render_line.cpp:
              (WebCore::InlineFlowBox::paintDecorations):
              (WebCore::EllipsisBox::paint):
              * rendering/render_list.cpp:
              (RenderListItem::getAbsoluteRepaintRect):
              (RenderListMarker::paint):
              * rendering/render_object.cpp:
              (WebCore::RenderObject::lineHeight):
              * rendering/render_object.h:
              (WebCore::RenderObject::font):
              * rendering/render_replaced.cpp:
              (WebCore::RenderWidget::setStyle):
              * rendering/render_style.h:
              (khtml::RenderStyle::font):
              (khtml::RenderStyle::fontDescription):
              (khtml::RenderStyle::qfont):
              * rendering/render_theme_mac.mm:
              (WebCore::RenderThemeMac::setFontFromControlSize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12977 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e99d1ca
    • mjs's avatar
      Reviewed by Eric. · 5f101cc5
      mjs authored
              - add link stubs for symbols only referenced from the link stubs file
      
              * platform/win/TemporaryLinkStubs.cpp:
              (KWQFileButton::focusPolicy):
              (QLineEdit::checksDescendantsForFocus):
              (KWQFileButton::baselinePosition):
              (QSlider::~QSlider):
              (QListBox::~QListBox):
              (KWQFileButton::frameGeometry):
              (KWQFileButton::~KWQFileButton):
              (QTextEdit::focusPolicy):
              (QSlider::focusPolicy):
              (QListBox::setEnabled):
              (QListBox::checksDescendantsForFocus):
              (QListBox::focusPolicy):
              (QLineEdit::baselinePosition):
              (QSlider::sizeHint):
              (QLineEdit::~QLineEdit):
              (QTextEdit::~QTextEdit):
              (QTextEdit::checksDescendantsForFocus):
              (QLineEdit::focusPolicy):
              (QScrollBar::~QScrollBar):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12976 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f101cc5
    • mjs's avatar
      Rubber stamped by Eric. · adbc41c4
      mjs authored
              - fix up font.h inclues to be Font.h to fix build.
      
              * css/css_computedstyle.cpp:
              * css/css_valueimpl.cpp:
              * platform/Font.cpp:
              * rendering/render_style.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adbc41c4
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · ea3d23dc
      eseidel authored
              Reviewed by mjs.
      
              Fix mac build by changing constants to an enum.
      
              * khtml/dom/dom2_events.h:
              (DOM::KeyboardEvent::):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12974 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea3d23dc
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · 517bbfdd
      eseidel authored
              Reviewed by mjs.
      
              Make DumpRenderTree link against icu.
      
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12973 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      517bbfdd
    • hyatt's avatar
      Move rendering/font to platform/Font. · ec364eee
      hyatt authored
              Reviewed by mjs
      
              * WebCore.xcodeproj/project.pbxproj:
              * css/cssstyleselector.cpp:
              * platform/Font.cpp: Added.
              * platform/Font.h: Added.
              * rendering/font.cpp: Removed.
              * rendering/font.h: Removed.
              * rendering/render_theme_mac.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12972 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec364eee
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · f16ca9fa
      eseidel authored
              Reviewed by mjs.
      
              Remove delcarations causing duplicate symbols on win32.
      
              * khtml/dom/dom2_events.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12971 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f16ca9fa
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · 30922b56
      eseidel authored
              * bridge/win/FrameWin.cpp: fix line endings
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12970 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      30922b56
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · b8be970c
      eseidel authored
              Reviewed by mjs.
      
              Make DumpRenderTree link against libxml, etc.
      
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree/DumpRenderTree.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12969 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8be970c
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · 3bc58845
      eseidel authored
              Reviewed by beth.
      
              Removed WebCore:: prefixes added using namespace WebCore, fixes win32 build.
      
              * platform/win/TemporaryLinkStubs.cpp:
              (QPainter::save):
              (Widget::enableFlushDrawing):
              (QPainter::drawHighlightForText):
              (QTextEdit::textWithHardLineBreaks):
              (QPainter::setPen):
              (QPainter::selectedTextBackgroundColor):
              (QPainter::fontMetrics):
              (Widget::show):
              (QLineEdit::setWritingDirection):
              (KWQFileButton::sizeForCharacterWidth):
              (QTextEdit::sizeWithColumnsAndRows):
              (iBeamCursor):
              (QPainter::misspellingLineThickness):
              (westResizeCursor):
              (Widget::isEnabled):
              (northWestResizeCursor):
              (QPainter::drawEllipse):
              (southWestResizeCursor):
              (Widget::focusPolicy):
              (waitCursor):
              (QPainter::endTransparencyLayer):
              (ScrollView::addChild):
              (Widget::~Widget):
              (QListBox::sizeForNumberOfLines):
              (FrameView::updateBorder):
              (QPainter::drawLineForText):
              (QPainter::QPainter):
              (QComboBox::focusPolicy):
              (QPainter::drawImageAtPoint):
              (QPainter::clearShadow):
              (eastResizeCursor):
              (QFontMetrics::boundingRect):
              (QPainter::beginTransparencyLayer):
              (northEastResizeCursor):
              (Widget::frameGeometry):
              (QPainter::addFocusRingRect):
              (QPainter::restore):
              (Widget::setEnabled):
              (QPainter::font):
              (QPainter::pen):
              (crossCursor):
              (Widget::setIsSelected):
              (handCursor):
              (QLineEdit::text):
              (Widget::unlockDrawingFocus):
              (QPainter::paintingDisabled):
              (northResizeCursor):
              (Widget::lockDrawingFocus):
              (QPainter::drawLine):
              (QPainter::setBrush):
              (QPainter::drawText):
              (QLineEdit::sizeForCharacterWidth):
              (Cursor::~Cursor):
              (QFontMetrics::selectionRectForText):
              (southResizeCursor):
              (moveCursor):
              (FrameView::isFrameView):
              (helpCursor):
              (QTextEdit::setWritingDirection):
              (Widget::setDrawingAlpha):
              (southEastResizeCursor):
              (QPainter::drawScaledAndTiledImage):
              (QPainter::drawImage):
              (QComboBox::setWritingDirection):
              (QComboBox::sizeHint):
              (QPainter::drawRect):
              (QPainter::drawTiledImage):
              (QPainter::clearFocusRing):
              (Widget::Widget):
              (QTextEdit::text):
              (QPainter::drawImageInRect):
              (Widget::disableFlushDrawing):
              (QPainter::initFocusRing):
              (QPainter::drawLineForMisspelling):
              (QComboBox::frameGeometry):
              (QListBox::setWritingDirection):
              (ScrollView::updateContents):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12968 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bc58845
    • darin's avatar
      Reviewed by Hyatt. · 6fb0fdcd
      darin authored
              - moved QScrollView from kwq to platform directory
      
              * kwq/KWQScrollView.h: Removed.
              * kwq/KWQScrollView.mm: Removed.
      
              * platform/ScrollBarMode.h: Added. Just the enum for scroll bar mode.
              * platform/ScrollView.h: Added. The rest of the former QScrollView.
              * platform/mac/ScrollViewMac.mm: Added.
      
              * WebCore.xcodeproj/project.pbxproj: Updated.
              * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.
              * platform/win/TemporaryLinkStubs.cpp: Updated.
      
              * bridge/mac/MacFrame.mm: (WebCore::MacFrame::createFrame):
              * khtml/html/html_baseimpl.cpp:
              (WebCore::HTMLFrameElementImpl::init):
              (WebCore::HTMLFrameElementImpl::parseMappedAttribute):
              * page/Frame.cpp: (WebCore::Frame::scrollbarsVisible):
              Changed scrolling constants to use new names.
      
              * khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::bodySetter):
              Use FrameView instead of QScrollView for a local variable.
      
              * khtml/html/html_baseimpl.h: Use ScrollBarMode instead of
              QScrollView::ScrollBarMode.
      
              * kwq/KWQListBox.h: Use WebCore::ScrollView instead of
              QScrollView and WebCore::ScrollBarMode instead of QScrollView::ScrollBarMode.
              * kwq/KWQTextEdit.h: Ditto.
              * kwq/KWQTextEdit.mm:
              (QTextEdit::setScrollBarModes): Ditto.
              (QTextEdit::focusPolicy): Ditto.
      
              * page/FrameView.h:
              * page/FrameView.cpp:
              (WebCore::FrameViewPrivate::FrameViewPrivate): Use ScrollBarMode
              instead of QScrollView::ScrollBarMode.
              (WebCore::FrameView::FrameView): Remove mention of QScrollView.
              (WebCore::FrameView::resetScrollBars): Rename QScrollView to ScrollView.
              (WebCore::FrameView::applyOverflowToViewport): Use newly-named constants.
              (WebCore::FrameView::layout): Ditto.
              (WebCore::FrameView::setScrollBarsMode): Rename QScrollView to ScrollView.
              (WebCore::FrameView::setVScrollBarMode): Ditto.
              (WebCore::FrameView::setHScrollBarMode): Ditto.
              (WebCore::FrameView::restoreScrollBar): Ditto.
      
              * platform/mac/MouseEventMac.mm: (WebCore::positionForEvent): Fixed comment.
              * platform/mac/WheelEventMac.mm: (WebCore::positionForEvent): Ditto.
              * platform/mac/WidgetMac.mm: (WebCore::Widget::getOuterView): Ditto.
      
              * rendering/render_form.cpp: (WebCore::RenderTextArea::setStyle):
              Use ScrollBarMode instead of QScrollView::ScrollBarMode, and new constants.
              * rendering/render_frames.cpp:
              (WebCore::RenderFrameSet::userResize): Changed to use an IntRect to pass to
              updateContents so we can remove the overload.
              (WebCore::RenderPart::updateWidgetPosition): Remove unnecessary of QScrollView.
      
              * rendering/render_layer.cpp:
              (WebCore::RenderLayer::scrollRectToVisible): Use FrameView instead of QScrollView.
              (WebCore::RenderLayer::setHasHorizontalScrollbar): Ditto.
              (WebCore::RenderLayer::setHasVerticalScrollbar): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fb0fdcd
    • andersca's avatar
      2006-02-24 Mitz Pettel <opendarwin.org@mitzpettel.com> · 83afa1b4
      andersca authored
              Reviewed and landed by Anders.
              
              Prevent rendering to the offscreen window. -[NSWindow displayIfNeeded] was
              getting called from the run loop, making the view render each test and thus slowing
              down the tests.
      
              * DumpRenderTree/DumpRenderTree.m:
              (main): Set the offscreen window to not autodisplay.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83afa1b4
    • eseidel's avatar
      2006-02-24 Eric Seidel <eseidel@apple.com> · f148eebe
      eseidel authored
              Reviewed by anders.
      
              Fix the win32 build.
      
              * page/Frame.cpp:
              (WebCore::Frame::adjustPageHeight):
              (WebCore::Frame::forceLayoutWithPageWidthRange):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f148eebe
    • ap's avatar
      Reviewed by Darin. · 2fdcd478
      ap authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7435
                Add Ian Hickson's XMLHttpRequest tests
      
              * http/conf/httpd.conf: Enable send-as-is handler, required by the tests.
              * http/tests/xmlhttprequest/web-apps: Added (recursively).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fdcd478
    • hyatt's avatar
      Rename FontDef to FontDescription and move it into the platform directory. · 1bb126c4
      hyatt authored
              Reviewed by darin
      
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::attributedString):
              * css/css_computedstyle.cpp:
              (WebCore::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
              * css/css_valueimpl.cpp:
              (WebCore::CSSPrimitiveValueImpl::computeLengthFloat):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::applyProperty):
              (WebCore::CSSStyleSelector::checkForTextSizeAdjust):
              (WebCore::CSSStyleSelector::checkForGenericFamilyChange):
              (WebCore::CSSStyleSelector::setFontSize):
              * css/cssstyleselector.h:
              * dom/DocumentImpl.cpp:
              (WebCore::DocumentImpl::recalcStyle):
              * editing/visible_text.cpp:
              (khtml::TextIterator::exitNode):
              * platform/FontDescription.h: Added.
              (WebCore::FontDescription::):
              (WebCore::FontDescription::FontDescription):
              (WebCore::FontDescription::operator!=):
              (WebCore::FontDescription::family):
              (WebCore::FontDescription::firstFamily):
              (WebCore::FontDescription::specifiedSize):
              (WebCore::FontDescription::computedSize):
              (WebCore::FontDescription::italic):
              (WebCore::FontDescription::computedPixelSize):
              (WebCore::FontDescription::smallCaps):
              (WebCore::FontDescription::isAbsoluteSize):
              (WebCore::FontDescription::weight):
              (WebCore::FontDescription::genericFamily):
              (WebCore::FontDescription::usePrinterFont):
              (WebCore::FontDescription::setFamily):
              (WebCore::FontDescription::setComputedSize):
              (WebCore::FontDescription::setSpecifiedSize):
              (WebCore::FontDescription::setItalic):
              (WebCore::FontDescription::setSmallCaps):
              (WebCore::FontDescription::setIsAbsoluteSize):
              (WebCore::FontDescription::setWeight):
              (WebCore::FontDescription::setGenericFamily):
              (WebCore::FontDescription::setUsePrinterFont):
              (WebCore::FontDescription::operator==):
              * rendering/RenderText.cpp:
              (WebCore::RenderText::widthFromCache):
              (WebCore::RenderText::trimmedMinMaxWidth):
              * rendering/bidi.cpp:
              (khtml::RenderBlock::computeHorizontalPositionsForLine):
              * rendering/font.cpp:
              (khtml::Font::selectionRectForText):
              (khtml::Font::drawHighlightForText):
              (khtml::Font::drawText):
              (khtml::Font::update):
              * rendering/font.h:
              (WebCore::Font::Font):
              (WebCore::Font::operator==):
              (WebCore::Font::fontDescription):
              (WebCore::Font::isSmallCaps):
              (WebCore::Font::wordSpacing):
              (WebCore::Font::floatWidth):
              (WebCore::Font::checkSelectionPoint):
              (WebCore::Font::width):
              * rendering/render_line.cpp:
              (WebCore::InlineFlowBox::placeBoxesHorizontally):
              * rendering/render_list.cpp:
              (RenderListItem::getAbsoluteRepaintRect):
              * rendering/render_style.h:
              (khtml::RenderStyle::wordSpacing):
              (khtml::RenderStyle::letterSpacing):
              (khtml::RenderStyle::setFontDescription):
              (khtml::RenderStyle::setWordSpacing):
              (khtml::RenderStyle::setLetterSpacing):
              * rendering/render_theme_mac.mm:
              (WebCore::RenderThemeMac::setFontFromControlSize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1bb126c4
    • mjs's avatar
      - fix build by making some pointless changes to files that Xcode doesn't · 04973112
      mjs authored
              rebuild otherwise
      
              * bindings/js/JSDOMCore.cpp:
              * bindings/js/JSDOMEvents.cpp:
              * dom/Element.idl:
              * dom/WheelEvent.idl:
              
              - add -Y 3 flag to linking; this makes the linker say what files reference 
              unresolved symbols
              
              * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04973112
  2. 23 Feb, 2006 20 commits
    • darin's avatar
      - try to fix buildbot failure · adae7a93
      darin authored
              * bindings/c/c_utility.cpp: Touch this file, which seems to not have been
              recompiled after additional inlining was introduced (Xcode bug?).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adae7a93
    • darin's avatar
      - try to fix Windows build · 83f99d9b
      darin authored
              * platform/win/TemporaryLinkStubs.cpp: Removed childX/Y stubs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83f99d9b
    • darin's avatar
      - fix Windows build · 11cc9b0d
      darin authored
              * platform/win/TemporaryLinkStubs.cpp: Removed QPalette-related stubs
      
              - remove unused forwarding headers
      
              * ForwardingHeaders/kurl.h: Removed.
              * ForwardingHeaders/qlist.h: Removed.
              * ForwardingHeaders/qregion.h: Removed.
              * ForwardingHeaders/qsortedlist.h: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11cc9b0d
    • darin's avatar
      Reviewed by Maciej. · 5ed43097
      darin authored
              - removed QPalette, QRegion, QPrinter
              - added Path to replace QRegion
              - removed unused QScrollView functions
      
              * ForwardingHeaders/qpalette.h: Removed.
              * kwq/KWQPalette.h: Removed.
              * kwq/KWQPalette.mm: Removed.
              * kwq/KWQPrinter.h: Removed.
              * kwq/KWQRegion.cpp: Removed.
              * kwq/KWQRegion.h: Removed.
      
              * platform/Path.h: Added. Replaces QRegion.
              * platform/cg: Added.
              * platform/cg/PathCG.cpp: Added.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: Updated for file changes.
              * WebCore.xcodeproj/project.pbxproj: Ditto.
      
              * bridge/mac/MacFrame.mm: Removed use of KWQPrinter.h.
              (WebCore::MacFrame::khtmlMouseMoveEvent): Removed use of viewport().
              * bridge/mac/WebCoreFrameBridge.mm: Removed use of KWQPrinter.h.
              * khtml/html/html_imageimpl.cpp:
              (WebCore::HTMLAreaElementImpl::getRect): Replaced QRegion with Path.
              (WebCore::HTMLAreaElementImpl::getRegion): Ditto.
              * khtml/html/html_imageimpl.h: Ditto.
              * kwq/KWQPainter.mm: Removed use of QRegion.
              * page/Frame.cpp: (WebCore::Frame::~Frame): Removed use of viewport().
              * page/FrameView.cpp:
              (WebCore::FrameView::FrameView): Ditto.
              (WebCore::FrameView::viewportMouseMoveEvent): Ditto.
              * rendering/render_frames.cpp: (WebCore::RenderFrameSet::userResize): Ditto.
              * rendering/render_layer.cpp: (WebCore::RenderLayer::scrollRectToVisible): Ditto.
      
              * kwq/KWQScrollView.h: Removed viewport(), hasVerticalScrollBar(),
              hasHorizontalScrollBar(), childX(), childY().
              * kwq/KWQScrollView.mm: Ditto.
      
              * rendering/render_box.cpp: (WebCore::RenderBox::paintBackgroundExtended):
              Removed use of QPalette that always yields white.
              * rendering/render_canvas.cpp: (WebCore::RenderCanvas::paintBoxDecorations):
              Ditto.
      
              * platform/Widget.h:
              * platform/mac/WidgetMac.mm: Removed palette() and setPalette().
      
              * kwq/KWQLineEdit.h: Replaced setPalette with setColors.
              * kwq/KWQLineEdit.mm: (QLineEdit::setColors): Replaced setPalette.
              * kwq/KWQTextEdit.h: Ditto.
              * kwq/KWQTextEdit.mm: (QTextEdit::setColors): Ditto.
      
              * rendering/render_form.cpp:
              (WebCore::RenderFormElement::updateFromElement): Removed call to setPalette.
              (WebCore::RenderLineEdit::updateFromElement): Added call to setColors.
              (WebCore::RenderTextArea::updateFromElement): Ditto.
      
              * rendering/render_replaced.cpp: (WebCore::RenderWidget::paint):
              Removed use of childX and childY functions.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ed43097
    • mjs's avatar
      Reviewed by Darin. · 54023cf9
      mjs authored
              - add KURL to windows build and fix its compile issues
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7439
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * platform/KURL.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12957 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54023cf9
    • mjs's avatar
      - fix build (header name changed) · 48ec2dc7
      mjs authored
              * platform/mac/KURLMac.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48ec2dc7
    • mjs's avatar
      Reviewed by Eric. · 3bd09266
      mjs authored
              - add temporary stubs that call abort() for functions only called from render and editing code 
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7429
      
              This gets rid of a couple hundred link errors.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * kwq/KWQFontMetrics.h:
              * kwq/KWQSignal.h:
              (KWQSignal::KWQSignal):
              * platform/win/TemporaryLinkStubs.cpp: Added.
              (notImplemented):
              (QLineEdit::selectAll):
              (WebCore::QPainter::save):
              (WebCore::Widget::enableFlushDrawing):
              (WebCore::QPainter::drawHighlightForText):
              (QFont::setPrinterFont):
              (QTextEdit::textWithHardLineBreaks):
              (QLineEdit::cursorPosition):
              (WebCore::QPainter::setPen):
              (WebCore::QPainter::selectedTextBackgroundColor):
              (WebCore::QPainter::fontMetrics):
              (WebCore::Widget::show):
              (QFont::setItalic):
              (QSlider::setValue):
              (QLineEdit::addSearchResult):
              (KWQFileButton::click):
              (QLineEdit::setWritingDirection):
              (KWQFileButton::sizeForCharacterWidth):
              (QTextEdit::sizeWithColumnsAndRows):
              (WebCore::iBeamCursor):
              (QComboBox::clear):
              (WebCore::QPainter::misspellingLineThickness):
              (QLineEdit::maxLength):
              (WebCore::westResizeCursor):
              (WebCore::Widget::isEnabled):
              (WebCore::northWestResizeCursor):
              (QTextEdit::selectionEnd):
              (QFont::determinePitch):
              (QTextEdit::setScrollBarModes):
              (WebCore::QPainter::drawEllipse):
              (WebCore::southWestResizeCursor):
              (QTextEdit::setReadOnly):
              (QListBox::appendItem):
              (WebCore::Widget::focusPolicy):
              (QTextEdit::selectAll):
              (WebCore::waitCursor):
              (WebCore::QPainter::endTransparencyLayer):
              (QScrollView::addChild):
              (QTextEdit::setDisabled):
              (QScrollBar::scroll):
              (WebCore::Widget::~Widget):
              (QListBox::sizeForNumberOfLines):
              (QScrollView::resizeContents):
              (QLineEdit::selectionStart):
              (QLineEdit::QLineEdit):
              (WebCore::FrameView::updateBorder):
              (QLineEdit::hasSelectedText):
              (QListBox::doneAppendingItems):
              (QScrollView::inWindow):
              (QScrollBar::setValue):
              (QTextEdit::hasSelectedText):
              (QTextEdit::selectionStart):
              (QFont::setWeight):
              (QScrollView::scrollXOffset):
              (QListBox::isSelected):
              (QLineEdit::setReadOnly):
              (WebCore::QPainter::drawLineForText):
              (QObject::disconnect):
              (WebCore::QPainter::QPainter):
              (QComboBox::~QComboBox):
              (QComboBox::focusPolicy):
              (WebCore::QPainter::drawImageAtPoint):
              (WebCore::QPainter::clearShadow):
              (QTextEdit::setLineHeight):
              (QMouseEvent::QMouseEvent):
              (WebCore::eastResizeCursor):
              (QScrollBar::setKnobProportion):
              (QFontMetrics::boundingRect):
              (QTextEdit::setSelectionStart):
              (WebCore::QPainter::beginTransparencyLayer):
              (WebCore::northEastResizeCursor):
              (WebCore::Widget::frameGeometry):
              (QListBox::setSelected):
              (WebCore::QPainter::addFocusRingRect):
              (QTextEdit::setCursorPosition):
              (WebCore::QPainter::restore):
              (QFontMetrics::width):
              (WebCore::Widget::setEnabled):
              (QTextEdit::setSelectionEnd):
              (QComboBox::populate):
              (QScrollView::setStaticBackground):
              (WebCore::QPainter::font):
              (QTextEdit::setAlignment):
              (QLineEdit::setCursorPosition):
              (WebCore::Widget::palette):
              (WebCore::QPainter::pen):
              (QFontMetrics::descent):
              (QListBox::QListBox):
              (QFontMetrics::ascent):
              (QLineEdit::selectedText):
              (WebCore::crossCursor):
              (WebCore::Widget::setIsSelected):
              (WebCore::handCursor):
              (QLineEdit::text):
              (WebCore::Widget::unlockDrawingFocus):
              (QLineEdit::setLiveSearch):
              (WebCore::QPainter::paintingDisabled):
              (WebCore::northResizeCursor):
              (QComboBox::QComboBox):
              (QSlider::setMaxValue):
              (WebCore::Widget::lockDrawingFocus):
              (WebCore::QPainter::drawLine):
              (WebCore::QPainter::setBrush):
              (QTextEdit::setSelectionRange):
              (WebCore::QPainter::drawText):
              (QScrollView::scrollPointRecursively):
              (QLineEdit::sizeForCharacterWidth):
              (WebCore::Cursor::~Cursor):
              (QFontMetrics::selectionRectForText):
              (WebCore::southResizeCursor):
              (QScrollView::suppressScrollBars):
              (QFontMetrics::checkSelectionPoint):
              (QTextEdit::getCursorPosition):
              (WebCore::moveCursor):
              (WebCore::FrameView::isFrameView):
              (QScrollBar::setSteps):
              (QLineEdit::setMaxLength):
              (QComboBox::baselinePosition):
              (QComboBox::appendItem):
              (WebCore::helpCursor):
              (QTextEdit::setWritingDirection):
              (WebCore::Widget::setDrawingAlpha):
              (QSlider::QSlider):
              (WebCore::southEastResizeCursor):
              (QScrollView::setVScrollBarMode):
              (WebCore::QPainter::drawScaledAndTiledImage):
              (QScrollView::scrollYOffset):
              (WebCore::QPainter::drawImage):
              (QComboBox::setCurrentItem):
              (QFontMetrics::height):
              (QComboBox::setWritingDirection):
              (QScrollView::setScrollBarsMode):
              (QComboBox::sizeHint):
              (WebCore::QPainter::drawRect):
              (QFont::setPixelSize):
              (QLineEdit::setSelection):
              (QLineEdit::setMaxResults):
              (QListBox::clear):
              (QLineEdit::edited):
              (WebCore::QPainter::drawTiledImage):
              (WebCore::QPainter::clearFocusRing):
              (WebCore::Widget::Widget):
              (QTextEdit::text):
              (WebCore::QPainter::drawImageInRect):
              (WebCore::Widget::disableFlushDrawing):
              (WebCore::QPainter::initFocusRing):
              (QSlider::setMinValue):
              (QTextEdit::setWordWrap):
              (WebCore::QPainter::drawLineForMisspelling):
              (QSlider::value):
              (QListBox::setSelectionMode):
              (QFontMetrics::lineSpacing):
              (QLineEdit::setEdited):
              (QComboBox::frameGeometry):
              (QListBox::setWritingDirection):
              (QLineEdit::setAlignment):
              (QScrollView::updateContents):
              (QFontMetrics::floatWidth):
              (QScrollView::setHScrollBarMode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3bd09266
    • mjs's avatar
      Reviewed by Eric. · c6361a65
      mjs authored
              
              - Move KURL from kwq to platform, make portable
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7437
      
              * WebCore.xcodeproj/project.pbxproj:
              * css/css_ruleimpl.cpp:
              * css/cssparser.cpp:
              * css/cssstyleselector.cpp:
              * dom/DocumentImpl.h:
              * khtml/html/html_baseimpl.cpp:
              * khtml/html/html_documentimpl.cpp:
              * khtml/html/html_headimpl.cpp:
              * khtml/xbl/xbl_binding.cpp:
              * ksvg2/svg/SVGDocumentImpl.cpp:
              * kwq/KWQTextCodec.cpp:
              (QTextCodec::codecForName):
              (QTextCodec::utf8Codec):
              (QTextCodec::codecForNameEightBitOnly):
              (QTextCodec::codecForLocale):
              (QTextCodec::name):
              (QTextCodec::makeDecoder):
              * kwq/KWQTextCodec.h:
              * loader/CachedObject.cpp:
              * loader/DocLoader.cpp:
              * page/Frame.h:
              * platform/KURL.cpp: Added.
              (KURL::decode_string):
              (encodeRelativeString):
              * platform/KURL.h: Added.
              * platform/mac/KURLMac.mm: Added.
              (KURL::getNSURL):
              * xml/xmlhttprequest.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6361a65
    • darin's avatar
      Reviewed by John Sullivan. · 947a31b6
      darin authored
              - moved QMouseEvent, QKeyEvent, QWheelEvent, and "Foundation extras"
                from kwq to platform directory
              - moved history function from kwq to bridge directory
              - eliminated QEvent, MousePressEvent, MouseDoubleClickEvent, MouseMoveEvent,
                MoveReleaseEvent, and DrawContents classes
              - merged NodeImpl::MouseEvent and the MouseEvent from khtml_events.h into
                a single class in the page directory
              - broke khtmllayout.h out into a file for the Length structure in the css
                directory and a file for the GapRects structure in the rendering directory
              - redid the Length structure to work more portably by not relying on bitfield
                layout and improve the names to no longer explicitly mention "width"
              - reduced use of QGuardedPtr and other uses of the QObject "destroyed" signal
      
              * ForwardingHeaders/kparts: Removed.
              * ForwardingHeaders/qevent.h: Removed.
              * khtml/khtml_event...
      947a31b6
    • thatcher's avatar
      New build to fix the i386 arch. (The _cuEnc64 symbol was missing.) · 05690148
      thatcher authored
              * libWebKitSystemInterface.a:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05690148
    • eseidel's avatar
      2006-02-23 Eric Seidel <eseidel@apple.com> · 864b4dde
      eseidel authored
              Reviewed by darin.
      
              Fix linking of static constructed globals on win32.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * config.h:
              * dom/EventNames.cpp:
              (WebCore::EventNames::init):
              * dom/EventNames.h:
              * dom/dom_qname.cpp:
              (WebCore::QualifiedName::init):
              * dom/dom_qname.h:
              * khtml/html/htmlnames.cpp:
              (WebCore::HTMLNames::init):
              * khtml/html/htmlnames.h:
              * platform/AtomicString.cpp:
              (WebCore::AtomicString::init):
              * platform/StaticConstructors.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      864b4dde
    • vicki's avatar
      Reviewed by Tim Omernick. · aebb78f0
      vicki authored
       
              - fix <rdar://problem/4394910> calling Javascript window.close() does not trigger onbeforeunload event
      
              Check shouldClose() before actually scheduling a close.
      
              shouldClose() checks for the onbeforeunload handler, displays the onbeforeunload dialog, and returns a 
              result based on whether the user clicks "OK" or "Cancel".  In cases where the window is closed with cmd-w 
              or by clicking the red globe, shouldClose() is checked in the windowShouldClose delegate method.  Since 
              windowShouldClose isn't invoked when a window is closed with Javascript, it makes sense to add a check 
              for shouldClose() in scheduleClose(), returning early when appropriate before the chain of events that 
              closes a window even gets started.  
      
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::scheduleClose): add a check for shouldClose()
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aebb78f0
    • ggaren's avatar
      Reviewed by Darin, Maciej. · d62a712a
      ggaren authored
              - Inline some functions suggested by Shark. 2.9% speedup on super
              accurate JS iBench.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7411
              <rdar://problem/4448116>
      
              * kjs/nodes.h:
              (KJS::ArgumentsNode::evaluateList):
              * kjs/object.cpp:
              * kjs/object.h:
              (KJS::ScopeChain::release):
              (KJS::JSObject::toPrimitive):
              * kjs/scope_chain.cpp:
              * kjs/ustring.cpp:
              * kjs/ustring.h:
              (KJS::UString::toArrayIndex):
              * kjs/value.cpp:
              * kjs/value.h:
              (KJS::JSValue::toObject):
              * kxmlcore/FastMalloc.cpp:
              (KXMLCore::TCMalloc_ThreadCache_FreeList::Push):
              (KXMLCore::TCMalloc_ThreadCache_FreeList::Pop):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d62a712a
    • vicki's avatar
      Reviewed by Hyatt. · 8bb20cbc
      vicki authored
       
              - fix <rdar://problem/4456004> onbeforeunload should cancel, and 
              <rdar://problem/4453579> REGRESSION (TOT): onbeforeunload is broken (7421)
      
              * bridge/mac/MacFrame.mm:
              (WebCore::MacFrame::shouldClose): Onbeforeunload is a non-bubbling window
              event, so we should be using handleWindowEvent rather than dispatching a 
              generic event on the body. It seems this only worked before because of incorrect
              code in other parts of the tree. 
              * dom/dom2_eventsimpl.cpp:
              (WebCore::BeforeUnloadEventImpl::BeforeUnloadEventImpl): for this constructor,
              pass true for the cancel parameter
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8bb20cbc
    • ap's avatar
      Reviewed by Darin. · 01538bb8
      ap authored
              - Turn http tests back on by default.
              - Wait for Apache to actually start serving requests.
              - Get user id from a built-in variable rather than an external command; 
              don't pass the group. 
      
              * Scripts/run-webkit-tests: 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01538bb8
    • ap's avatar
      Suggested by Mitz Pettel, reviewed by Darin. · 2cf64115
      ap authored
              * Scripts/run-webkit-tests: Pass User and Group directives, so that Apache
              can run CGIs even if the permissions are 700 or 600.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2cf64115
    • darin's avatar
      Collaborating with Alexey. · de24439f
      darin authored
              - turn off http tests by default until we figure out how to get them
                to run even when permissions on CGI files are 700 instead of 755
      
              * Scripts/run-webkit-tests: Set $testHTTP to 0 instead of 1 for now.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de24439f
    • eseidel's avatar
      2006-02-23 Eric Seidel <eseidel@apple.com> · ea6e03b8
      eseidel authored
              Add *.user to ignore list.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea6e03b8
    • eseidel's avatar
      2006-02-23 Eric Seidel <eseidel@apple.com> · 05be17e9
      eseidel authored
              Remove binary file which shouldn't have been commited (and add to ignore list).
      
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.ncb: Removed.
              * DumpRenderTree/DumpRenderTree.vcproj/DumpRenderTree.suo: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05be17e9
    • darin's avatar
      Reviewed by Eric. · 3c46729b
      darin authored
              * Scripts/run-webkit-tests: Put Apache log files in the right directory.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@12942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c46729b