1. 01 Aug, 2013 9 commits
  2. 31 Jul, 2013 31 commits
    • commit-queue@webkit.org's avatar
      Reduce JSC API static value setter/getter overhead. · 2396eba5
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119277
      
      Patch by Yi Shen <max.hong.shen@gmail.com> on 2013-07-31
      Reviewed by Geoffrey Garen.
      
      Add property name to the static value entry, so that OpaqueJSString::create() doesn't
      need to get called every time when set or get the static value.
      
      * API/JSCallbackObjectFunctions.h:
      (JSC::::put):
      (JSC::::putByIndex):
      (JSC::::getStaticValue):
      * API/JSClassRef.cpp:
      (OpaqueJSClassContextData::OpaqueJSClassContextData):
      * API/JSClassRef.h:
      (StaticValueEntry::StaticValueEntry):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2396eba5
    • kseo@webkit.org's avatar
      Use emptyString instead of String("") · ffc4158f
      kseo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119335
      
      Reviewed by Darin Adler.
      
      Use emptyString() instead of String("") because it is better style and
      faster. This is a followup to r116908, removing all occurrences of
      String("") from WebKit.
      
      Source/JavaScriptCore:
      
      * runtime/RegExpConstructor.cpp:
      (JSC::constructRegExp):
      * runtime/RegExpPrototype.cpp:
      (JSC::regExpProtoFuncCompile):
      * runtime/StringPrototype.cpp:
      (JSC::stringProtoFuncMatch):
      (JSC::stringProtoFuncSearch):
      
      Source/WebCore:
      
      No behavior change, no new tests needed.
      
      * platform/graphics/blackberry/LayerAnimation.h:
      (WebCore::LayerAnimation::name):
      * platform/mac/PlatformEventFactoryMac.mm:
      (WebCore::textFromEvent):
      (WebCore::unmodifiedTextFromEvent):
      (WebCore::keyIdentifierForKeyEvent):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::userAgent):
      
      Source/WebKit/qt:
      
      * WebCoreSupport/ChromeClientQt.cpp:
      (WebCore::ChromeClientQt::runJavaScriptPrompt):
      
      Source/WebKit2:
      
      * Shared/mac/WebEventFactory.mm:
      (WebKit::textFromEvent):
      (WebKit::unmodifiedTextFromEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ffc4158f
    • bjonesbe@adobe.com's avatar
      Update location of w3c shapes tests to reflect new import location · 36dfd36b
      bjonesbe@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118156
      
      Reviewed by Dirk Pranke.
      
      Partial imports should not be imported to the same place as the full
      import, so this adds an option to allow importing to a different
      location than the default. In doing that, I found that imports from
      contributor directories didn't seem to be working correctly, so I
      updated the import to be smarter about both contributor directories
      and the test status directories. It should now be more likely that the
      script guesses the root directory properly.
      
      * Scripts/webkitpy/w3c/test_importer.py: Remove comment about the
          script not working with the full set of contributors, as that is
          no longer true, and I didn't see a good way to keep that behavior.
          Also update documentation to properly explain what happens when a
          contributor dir is imported.
      (main): Attempt to find the proper repo dir by looking at the
          directory above the "test status" in the given path, this is still
          not exactly right, but is less error prone than just trimming.
      (parse_args): Add -d option to set the import directory.
      (TestImporter.__init__): Stop appending the subdirs to the
          destination_directory because it was making things more complex
          and isn't really needed.
      (TestImporter.update_test_status): Remove hardcoded strings and use
          the TEST_STATUS constants instead.
      * Scripts/webkitpy/w3c/test_importer_unittest.py:
      (TestImporterTest.test_import_dir_with_no_tests_and_no_hg): Add
          support for new option.
      (TestImporterTest.test_import_dir_with_no_tests): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36dfd36b
    • bfulgham@apple.com's avatar
      [Windows] Winlauncher shouldn't look for Safari Install Directory · 6ba71310
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119351
      
      Reviewed by Darin Adler.
      
      * win/DLLLauncher/DLLLauncherMain.cpp: Don't check registry for
      the Safari install location. Instead, use the proper support
      library path for the build architecture.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ba71310
    • rwlbuis@webkit.org's avatar
      Convert SVG test from r153433 to a reftest · 43bf0f97
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119346
      
      Reviewed by Philip Rogers.
      
      Reftest taken from https://chromium.googlesource.com/chromium/blink/+/ac10e305a870c8fd500b42e90075aee3aa48da8d.
      
      * platform/qt/svg/animations/attributeNameAndAttributeTypeMissmatch-expected.txt: Removed.
      * svg/animations/attributeNameAndAttributeTypeMismatch-expected.html: Added.
      * svg/animations/attributeNameAndAttributeTypeMismatch.html: Added.
      * svg/animations/attributeNameAndAttributeTypeMissmatch.svg: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43bf0f97
    • benjamin@webkit.org's avatar
      Upload images for a potential blog post · 040498a7
      benjamin@webkit.org authored
      * blog-files/size-matters: Added.
      * blog-files/size-matters/JavaScript-growth.png: Added.
      * blog-files/size-matters/WebCore-growth-baseline.png: Added.
      * blog-files/size-matters/WebCore-growth.png: Added.
      * blog-files/size-matters/WebKit-growth.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      040498a7
    • commit-queue@webkit.org's avatar
      <input type=color> Mac UI behaviour · 23815488
      commit-queue@webkit.org authored
      <rdar://problem/10269922> and https://bugs.webkit.org/show_bug.cgi?id=61276
      
      Source/JavaScriptCore:
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
      Reviewed by Brady Eidson.
      
      * Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
      
      Source/WebCore:
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
      Reviewed by Brady Eidson.
      
      This patch turns on INPUT_TYPE_COLOR and implements it using the native
      Mac color panel.
      
      No new tests added.
      
      Currently, there are no automated ways to test the types of changes made in this patch. (i.e. checking
      which color is being displayed in the color panel, checking which color element is currently
      associated to the color panel, checking the state of color elements after directing away and
      being directed back to its page, etc.)
      
      * Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
      * WebCore.exp.in:
      * WebCore.xcodeproj/project.pbxproj:
      
      * html/ColorInputType.cpp:
      (WebCore::ColorInputType::handleDOMActivateEvent): Reattaches the color picker if
        a color picker has already been shown for an element
      (WebCore::ColorInputType::shouldResetOnDocumentActivation): Always returns true, needed to
        detach the color picker when caching a page.
      * html/ColorInputType.h:
      
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::documentDidResumeFromPageCache): For <input type='color'>,
        don't reset the element.
      (WebCore::HTMLInputElement::documentWillSuspendForPageCache): For <input type='color'>, call detach().
      * html/HTMLInputElement.h:
      
      * platform/ColorChooser.h:
      (WebCore::ColorChooser::reattachColorChooser): Added definition.
      
      Source/WebKit/mac:
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
      Reviewed by Brady Eidson.
      
      * Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
      * WebCoreSupport/WebChromeClient.h:
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::createColorPicker): Added stub implementation.
      
      Source/WebKit2:
      
      Implemented <input type='color'> on Mac using the native color picker.
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
      Reviewed by Brady Eidson.
      
      Code for WebColorPickerMac is derived from Chromium's color_chooser_mac.mm:
      https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/cocoa/color_chooser_mac.mm
      
      * Configurations/FeatureDefines.xcconfig: Enabled INPUT_TYPE_COLOR.
      
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::createColorPicker): Replaced stub implementation
        and return a WebColorPickerMac object.
      
      * UIProcess/WebColorPicker.cpp:
      (WebKit::WebColorPicker::invalidate): Updated to call endChooser().
      (WebKit::WebColorPicker::showColorPicker): Added stub implementation.
      * UIProcess/WebColorPicker.h:
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::close): Removed invalidation of removed color picker objects.
      (WebKit::WebPageProxy::showColorPicker): Updated so that it works for
        multiple <input type='color'> elements on a page.
      (WebKit::WebPageProxy::didEndColorPicker): Removed cleanup of removed color picker objects.
      (WebKit::WebPageProxy::resetStateAfterProcessExited): Removed cleanup of removed color picker objects.
      
      * UIProcess/mac/WebColorPickerMac.h: Added.
      * UIProcess/mac/WebColorPickerMac.mm: Added.
      (WebKit::WebColorPickerMac::create):
      (WebKit::WebColorPickerMac::~WebColorPickerMac):
      (WebKit::WebColorPickerMac::WebColorPickerMac):
      (WebKit::WebColorPickerMac::endPicker):
      (WebKit::WebColorPickerMac::setSelectedColor):
      (WebKit::WebColorPickerMac::didChooseColor):
      (WebKit::WebColorPickerMac::showColorPicker):
      WebColorPickerMac contains a reference to a WKColorPanelMac object
        and is responsible for maintaining the color picker UI.
      
      (-[WKColorPanelMac setAndShowPicker:withColor:]):
      (-[WKColorPanelMac invalidate]):
      (-[WKColorPanelMac windowWillClose:]):
      (-[WKColorPanelMac didChooseColor:]):
      (-[WKColorPanelMac setColor:]):
      WKColorPanelMac is a wrapper for a NSColorPanel object and
        is responsible for the color picker UI.
      
      * WebKit2.xcodeproj/project.pbxproj:
      
      * WebProcess/WebCoreSupport/WebChromeClient.cpp:
      (WebKit::WebChromeClient::createColorChooser): Updated to always create a
        WebColorChooser object.
      
      * WebProcess/WebCoreSupport/WebColorChooser.cpp:
      (WebKit::WebColorChooser::reattachColorChooser): Sets the page's
        active color chooser to the current object and pings the UIProcess
        to show the color picker.
      (WebKit::WebColorChooser::setSelectedColor): Only sets the color in the
        color picker if the WebColorChooser object is the active color element.
      * WebProcess/WebCoreSupport/WebColorChooser.h:
      
      Source/WTF:
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
      Reviewed by Brady Eidson.
      
      * wtf/FeatureDefines.h: Enabled INPUT_TYPE_COLOR on Mac port.
      
      LayoutTests:
      
      Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-31
      Reviewed by Brady Eidson.
      
      Updated tests to reflect <input type='color'> being implemented with a native color picker.
      
      * fast/forms/color/input-color-onchange-event-expected.txt:
      
      * platform/mac/TestExpectations: Enabled fast/form/color tests on Mac.
      
      * platform/mac/accessibility/color-well-expected.txt:
      * platform/mac/accessibility/role-subrole-roledescription-expected.txt:
      * platform/mac/accessibility/role-subrole-roledescription.html:
      
      * platform/mac/fast/forms/color/input-appearance-color-expected.txt: Updated test expectations
      on Mac to reflect the fact that the list attribute for <input type='color'> is not yet supported.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23815488
    • mhahnenberg@apple.com's avatar
      DFG doesn't account for inlining of functions with switch statements that... · 56325c96
      mhahnenberg@apple.com authored
      DFG doesn't account for inlining of functions with switch statements that haven't been executed by the baseline JIT
      https://bugs.webkit.org/show_bug.cgi?id=119349
      
      Reviewed by Geoffrey Garen.
      
      Source/JavaScriptCore: 
      
      Prior to this patch, the baseline JIT was responsible for resizing the ctiOffsets Vector for 
      SimpleJumpTables to be equal to the size of the branchOffsets Vector. The DFG implicitly relied
      on code it compiled with any switch statements to have been run in the baseline JIT first. 
      However, if the DFG chooses to inline a function that has never been compiled by the baseline 
      JIT then this resizing never happens and we crash at link time in the DFG.
      
      We can fix this by also doing the resize in the DFG to catch this case.
      
      * dfg/DFGJITCompiler.cpp:
      (JSC::DFG::JITCompiler::link):
      
      LayoutTests: 
      
      * fast/js/dfg-inline-switch-imm-expected.txt: Added.
      * fast/js/dfg-inline-switch-imm.html: Added.
      * fast/js/script-tests/dfg-inline-switch-imm.js: Added.
      (foo):
      (bar):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      56325c96
    • barraclough@apple.com's avatar
      Speculative Windows build fix. · 609eecac
      barraclough@apple.com authored
      Reviewed by NOBODY
      
      * runtime/JSString.cpp:
      (JSC::JSRopeString::getIndexSlowCase):
      * runtime/JSString.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      609eecac
    • timothy_horton@apple.com's avatar
      RenderEmbeddedObject::isReplacementObscured is wrong if an obscuring element... · 9bd010b4
      timothy_horton@apple.com authored
      RenderEmbeddedObject::isReplacementObscured is wrong if an obscuring element has pointer-events: none set
      https://bugs.webkit.org/show_bug.cgi?id=119348
      
      Reviewed by Dean Jackson.
      
      Change the expected outcome of the test to want a visually-obscured
      but clickable embed (because the obscuring element has pointer-events: none)
      to be considered obscured.
      
      Also, adjust the test so that it runs all of the subtests even if
      some of them fail.
      
      * plugins/unavailable-plugin-indicator-obscurity-expected.txt:
      * plugins/unavailable-plugin-indicator-obscurity.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9bd010b4
    • bjonesbe@adobe.com's avatar
      Update scripts to reference contributors.json instead of committers.py in messaging · 694390b7
      bjonesbe@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119342
      
      Reviewed by Ryosuke Niwa.
      
      Change the scripts to point people to contributors.json instead of
      committers.py since the latter no longer contains the list of
      contributors.
      
      * Scripts/webkitpy/common/config/committervalidator.py:
      (CommitterValidator._contributors_json_path):
      (CommitterValidator._flag_permission_rejection_message):
      * Scripts/webkitpy/common/config/committervalidator_unittest.py:
      (CommitterValidatorTest.test_flag_permission_rejection_message):
      * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
      (Bugzilla._commit_queue_flag):
      * Scripts/webkitpy/common/watchlist/watchlistparser.py:
      (WatchListParser._validate):
      * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
      (WatchListParserTest.test_cc_rule_with_invalid_email):
      * Scripts/webkitpy/tool/bot/feeders_unittest.py:
      * Scripts/webkitpy/tool/commands/queues_unittest.py:
      * Scripts/webkitpy/tool/steps/validatereviewer.py:
      (ValidateReviewer.run):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      694390b7
    • roger_fong@apple.com's avatar
      Unreviewed. Re-enable WinEWS tests following r153527. · 1ee0c35d
      roger_fong@apple.com authored
      * Scripts/webkitpy/common/config/ews.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ee0c35d
    • roger_fong@apple.com's avatar
      Unreviewed gardening. AppleWin port. · 139c88d5
      roger_fong@apple.com authored
      * platform/win/editing/selection/move-left-right-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      139c88d5
    • barraclough@apple.com's avatar
      Some cleanup in JSValue::get · ab7b6096
      barraclough@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119343
      
      Reviewed by Geoff Garen.
      
      Source/JavaScriptCore: 
      
      JSValue::get is implemented to:
          1) Check if the value is a cell – if not, synthesize a prototype to search,
          2) call getOwnPropertySlot on the cell,
          3) if this returns false, cast to JSObject to get the prototype, and walk the prototype chain.
      By all rights this should crash when passed a string and accessing a property that does not exist, because
      the string is a cell, getOwnPropertySlot should return false, and the cast to JSObject should be unsafe.
      To work around this, JSString::getOwnPropertySlot actually implements 'get' functionality - searching the
      prototype chain, and faking out a return value of undefined if no property is found.
      
      This is a huge hazard, since fixing JSString::getOwnPropertySlot or calling getOwnPropertySlot on cells
      from elsewhere would introduce bugs. Fortunately it is only ever called in this one place.
      
      The fix here is to move getOwnPropertySlot onto JSObjecte and end this madness - cells don't have property
      slots anyway.
      
      Interesting changes are in JSCJSValueInlines.h, JSString.cpp - the rest is pretty much all JSCell -> JSObject.
      
      Source/WebCore: 
      
      * WebCore.exp.in:
      * bindings/js/JSDOMWindowCustom.cpp:
      (WebCore::JSDOMWindow::getOwnPropertySlot):
      (WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
      * bindings/scripts/CodeGeneratorJS.pm:
      (GenerateHeader):
      (GenerateImplementation):
      (GenerateConstructorDeclaration):
      (GenerateConstructorHelperMethods):
      * bridge/objc/objc_runtime.h:
      * bridge/objc/objc_runtime.mm:
      (JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
      * bridge/runtime_array.cpp:
      (JSC::RuntimeArray::getOwnPropertySlot):
      (JSC::RuntimeArray::getOwnPropertySlotByIndex):
      * bridge/runtime_array.h:
      * bridge/runtime_method.cpp:
      (JSC::RuntimeMethod::getOwnPropertySlot):
      * bridge/runtime_method.h:
      * bridge/runtime_object.cpp:
      (JSC::Bindings::RuntimeObject::getOwnPropertySlot):
      * bridge/runtime_object.h:
          - getOwnPropertySlot, JSCell -> JSObject
      
      Source/WebKit2: 
      
      * WebProcess/Plugins/Netscape/JSNPObject.cpp:
      (WebKit::JSNPObject::getOwnPropertySlot):
      * WebProcess/Plugins/Netscape/JSNPObject.h:
          - getOwnPropertySlot, JSCell -> JSObject
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab7b6096
    • ap@apple.com's avatar
      REGRESSION (r153406): DOM intervals are not properly restarted when resumed · 7a43ae44
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=119345
      
              Reviewed by Sam Weinig.
      
              * page/SuspendableTimer.cpp: (WebCore::SuspendableTimer::suspend): Call base class
              version of repeatInterval(), not our version that will just return the current value
              of m_savedRepeatInterval in this situation.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a43ae44
    • rniwa@webkit.org's avatar
      Avoid calling nextRenderer() in some cases · a6fb3b8f
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119313
      
      Reviewed by Andreas Kling.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/3207cfda52082f4fd6a04c7819c18a980de58beb.
      
      * dom/Text.cpp:
      (WebCore::Text::textRendererIsNeeded):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6fb3b8f
    • rniwa@webkit.org's avatar
      Convert most callers of setInlineStyleProperty passing strings to enums or doubles instead · 43a08580
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119304
      
      Reviewed by Andreas Kling.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/8157dd9381716759f183fabbfed29c52962be746
      
      * editing/DeleteButtonController.cpp:
      (WebCore::DeleteButtonController::createDeletionUI):
      (WebCore::DeleteButtonController::show):
      * html/HTMLTextFormControlElement.cpp:
      (WebCore::HTMLTextFormControlElement::updatePlaceholderVisibility):
      * html/ImageDocument.cpp:
      (WebCore::ImageDocument::resizeImageToFit):
      (WebCore::ImageDocument::restoreImageSize):
      (WebCore::ImageDocument::windowSizeChanged):
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlTextTrackContainerElement::updateDisplay):
      (WebCore::MediaControlTextTrackContainerElement::updateTimerFired):
      * html/track/TextTrackCue.cpp:
      (WebCore::TextTrackCue::setFontSize):
      * html/track/TextTrackCueGeneric.cpp:
      (WebCore::TextTrackCueGenericBoxElement::applyCSSProperties):
      (WebCore::TextTrackCueGeneric::setFontSize):
      * rendering/RenderLayer.cpp:
      (WebCore::RenderLayer::resize):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43a08580
    • bjonesbe@adobe.com's avatar
      [CSS Shapes] Stop using internals in shape-outside tests · 3c14189b
      bjonesbe@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119229
      
      Reviewed by Alexandru Chiculita.
      
      We no longer need to use window.internals for shape-outside, since it
      is enabled by default on ports where it is compiled in. To make the
      w3c spec test cleaner, that reference has been removed from all of the
      tests.
      
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-circle-000.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-000.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001-expected.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-001.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002-expected.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-002.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-003.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-horizontal-rectangle-004.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-000.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-001.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-inset-rectangle-002.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-001.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-002.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-003.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-rounded-rectangle-004.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-square-000.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-000.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001-expected.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-001.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002-expected.html:
      * csswg/submitted/shapes/shape-outside/shape-outside-floats-vertical-rectangle-002.html:
      * csswg/submitted/shapes/shape-outside/w3c-import.log:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c14189b
    • msaboff@apple.com's avatar
      [Win] JavaScript crash. · 800ff4c7
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119339
      
      Reviewed by Mark Hahnenberg.
      
      * jit/JITStubsX86.h: Implement ctiVMThrowTrampoline and
      ctiVMThrowTrampolineSlowpath the same way as the gcc x86 version does.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      800ff4c7
    • rniwa@webkit.org's avatar
      Test assignment to indexed window properties · 4d49a137
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119307
      
      Reviewed by Geoffrey Garen.
      
      Merge https://chromium.googlesource.com/chromium/blink/+/bdeca10fa79477f669cab1e5b081a480e743fd3f
      
      * http/tests/security/xss-DENIED-window-index-assign-expected.txt: Added.
      * http/tests/security/xss-DENIED-window-index-assign.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d49a137
    • rniwa@webkit.org's avatar
      Add a test to ensure SelectElement removes an option when null is assigned by indexed setter · 8f0415da
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119311
      
      Reviewed by Alexey Proskuryakov.
      
      Merge a test in https://chromium.googlesource.com/chromium/blink/+/da5c8d908b87f75c5ba3d1457c2353642e999963
      even though the regression never existed in WebKit.
      
      * fast/forms/select/select-assign-null-expected.txt: Added.
      * fast/forms/select/select-assign-null.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f0415da
    • bjonesbe@adobe.com's avatar
      Unreviewed: Adding myself to the committers' list. · c135ffb8
      bjonesbe@adobe.com authored
      * Scripts/webkitpy/common/config/contributors.json:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c135ffb8
    • commit-queue@webkit.org's avatar
      [Coordinated Graphics] Use m_ prefix only for member variable · 1f44e2af
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119250
      
      Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-31
      Reviewed by Noam Rosenthal.
      
      WebKit coding style suggests to use m_ prefix only for data members.
      This patch also removes unnecessary copy by passing const-reference
      parameter values.
      
      * platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h:
      (WebCore::CoordinatedCustomFilterProgram::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f44e2af
    • allan.jensen@digia.com's avatar
      [Qt] Images are down-scaled badly · 4fc804d0
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119263
      
      Reviewed by Jocelyn Turcotte.
      
      QPainter only does bilinear filtering, which means it will downscaling beyond
      0.5x will start skipping pixel and start to degrade the end result. Scaling in
      QImage and QPixmap however uses a better but much more expensive sampling that
      counts all pixels.
      
      To get the high quality downscaling we must therefore prescale the images before
      painting them. To avoid a performance impact on repeated paints the prescaled
      image are saved in the QPixmapCache.
      
      * platform/graphics/qt/ImageQt.cpp:
      (WebCore::BitmapImage::draw):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fc804d0
    • simon.pena@samsung.com's avatar
      [GTK] Unreviewed gardening. Remove flaky tests from TestExpectations. · 586ba68b
      simon.pena@samsung.com authored
      * platform/gtk/TestExpectations: Remove tests no longer flaky after
      webkit.org/b/100688 was fixed in r140166.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      586ba68b
    • allan.jensen@digia.com's avatar
      [Qt] Build WebKit with C++11 · 5dad9483
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119337
      
      Reviewed by Csaba Osztrogonác.
      
      Source/WebKit2:
      
      We no longer need to enable C++11 specifically for WebKit2.
      
      * WebKit2.pri:
      
      Tools:
      
      Enable building with C++11.
      
      * qmake/mkspecs/features/default_pre.prf:
      * qmake/mkspecs/features/unix/default_post.prf:
      * qmake/mkspecs/features/unix/default_pre.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dad9483
    • allan.jensen@digia.com's avatar
      [Qt] ASSERTS trigger in release builds · d85e8de8
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119336
      
      Reviewed by Jocelyn Turcotte.
      
      Ensure the qmake also defaults to release if no configuration is known.
      
      * qmake/mkspecs/features/default_post.prf:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d85e8de8
    • zandobersek@gmail.com's avatar
      [texmap][GStreamer][GTK] composited video shows tearing · c27a5e93
      zandobersek@gmail.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118253
      
      Reviewed by Martin Robinson.
      
      * gtk/jhbuild.modules: Bump the Jhbuild versions of the Gdk-Pixbuf and GTK+ packages to 2.27.3 and 3.8.2, respectively.
      The first is required by the second, and the GTK+ bump introduces proper display framerate synchronization that removes
      screen tearing when enabling accelerated compositing and performing graphically heavy operations like viewing HD videos.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c27a5e93
    • michael.bruning@digia.com's avatar
      [Qt][WK1] navigator.plugins shows too few entries. · 67aa1463
      michael.bruning@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119332
      
      Reviewed by Jocelyn Turcotte.
      
      Based on input by Choon Sik Cho.
      
      PlatformStrategiesQt::getPluginInfo was using the
      WTF::Vector::resize method wrongly.
      
      This patch removes the call to Vector::resize as
      Vector::append will take care of increasing capacity
      if needed.
      
      * WebCoreSupport/PlatformStrategiesQt.cpp:
      (PlatformStrategiesQt::getPluginInfo):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67aa1463
    • commit-queue@webkit.org's avatar
      [Qt] Add interface API for origin whitelisting · 2d4bf795
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=117823
      
      Patch by Deepjyoti Saha <deesaha@cisco.com> on 2013-07-31
      Reviewed by Jocelyn Turcotte.
      
      Adding interface APIs in QWebSecurityOrigin to add and remove whiteList entires.
      
      Re-used most of the test cases written by Carol Szabo  <carol.szabo@nokia.com>
      for https://bugs.webkit.org/show_bug.cgi?id=31875 and added the same.
      
      * Api/qwebsecurityorigin.cpp:
      (QWebSecurityOrigin::addAccessWhitelistEntry):
      (QWebSecurityOrigin::removeAccessWhitelistEntry):
      * Api/qwebsecurityorigin.h:
      * tests/qwebsecurityorigin: Added.
      * tests/qwebsecurityorigin/qwebsecurityorigin.pro: Added.
      * tests/qwebsecurityorigin/resources: Added.
      * tests/qwebsecurityorigin/resources/test.html: Added.
      * tests/qwebsecurityorigin/tst_qwebsecurityorigin.cpp: Added.
      (tst_QWebSecurityOrigin::tst_QWebSecurityOrigin):
      (tst_QWebSecurityOrigin::~tst_QWebSecurityOrigin):
      (tst_QWebSecurityOrigin::init):
      (tst_QWebSecurityOrigin::cleanup):
      (tst_QWebSecurityOrigin::whiteList_data):
      (tst_QWebSecurityOrigin::whiteList):
      * tests/qwebsecurityorigin/tst_qwebsecurityorigin.qrc: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d4bf795
    • g.czajkowski@samsung.com's avatar
      Remove guessesVector param from isUngrammatical · fe2d0c01
      g.czajkowski@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119241
      
      Reviewed by Ryosuke Niwa.
      
      TextCheckingHelper::isUngrammatical(Vector<String>& guessesVector) doesn't return
      guesses for ungrammatical phrases through its parameter.
      Editor::isSelectionUngrammatical() uses it to check whether the selection
      is ungrammatical.
      
      r71009 showed that isUngrammatical(Vector<String>& guessesVector) had not supported
      grammar guesses.
      
      The grammar guesses can be retrieved by guessesForMisspelledOrUngrammaticalRange
      when UNIFIED_TEXT_CHECKING is on.
      
      No new tests, this is dead code due to no WebKit port implements grammar using
      legacy text checker.
      
      * WebCore.exp.in: Removed __ZN7WebCore6Editor32guessesForUngrammaticalSelectionEv.
      * editing/Editor.cpp:
      (WebCore::Editor::isSelectionUngrammatical):
      (WebCore::Editor::guessesForMisspelledOrUngrammatical):
      * editing/Editor.h: Removed guessesForUngrammaticalSelection. Dead code.
      * editing/TextCheckingHelper.cpp:
      (WebCore::TextCheckingHelper::isUngrammatical):
      * editing/TextCheckingHelper.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe2d0c01