1. 05 Aug, 2009 19 commits
    • pkasting@chromium.org's avatar
      2009-08-05 Peter Kasting <pkasting@google.com> · b8283dc0
      pkasting@chromium.org authored
              Reviewed by Sam Weinig.
      
              https://bugs.webkit.org/show_bug.cgi?id=27851
              Fix a pair of compiler warnings on the GTK Linux buildbot.
      
              * platform/image-decoders/bmp/BMPImageDecoder.cpp:
              (WebCore::BMPImageDecoder::processFileHeader): Don't use multi-character constants, they're not portable.
              * platform/image-decoders/ico/ICOImageDecoder.cpp:
              (WebCore::ICOImageDecoder::setSize): Simpler code that also doesn't compare signed with unsigned.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46814 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8283dc0
    • beidson@apple.com's avatar
      2009-08-05 Brady Eidson <beidson@apple.com> · af781ea8
      beidson@apple.com authored
              Rubberstamped by Mark Rowe.
      
              As a followup to http://trac.webkit.org/changeset/46811, Windows-specific results *did* have some differences, so restoring those results.
      
              * platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt.
              * platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt.
              * platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt.
              * platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Copied from platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af781ea8
    • beidson@apple.com's avatar
      2009-08-05 Brady Eidson <beidson@apple.com> · 4a9a8f6f
      beidson@apple.com authored
              Rubberstamped by Mark Rowe.
      
              Actually, for all 6 of these tests Tiger now matches the cross-platform results, so removing all the Tiger results.
      
              * platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt: Removed.
              * platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Removed.
              * platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
              * platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
              * platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
              * platform/mac-tiger/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a9a8f6f
    • beidson@apple.com's avatar
      2009-08-05 Brady Eidson <beidson@apple.com> · 196694fc
      beidson@apple.com authored
              Rubberstamped by Mark Rowe.
      
              As a followup to http://trac.webkit.org/changeset/46809, Windows-specific results now match the cross-platform results, 
              so I'm removing them.
      
              * platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt: Removed.
              * platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt: Removed.
              * platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Removed.
              * platform/win/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      196694fc
    • beidson@apple.com's avatar
      2009-08-05 Brady Eidson <beidson@apple.com> · 1100e9ad
      beidson@apple.com authored
              Rubberstamped by Mark Rowe.
      
              As a followup to http://trac.webkit.org/changeset/46809, update Tiger platform specific results for these tests.
      
              * platform/mac-tiger/http/tests/loading/redirect-methods-expected.txt:
              * platform/mac-tiger/http/tests/misc/favicon-loads-with-images-disabled-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1100e9ad
    • darin@chromium.org's avatar
      2009-08-05 Darin Fisher <darin@chromium.org> · 27a4603c
      darin@chromium.org authored
              Reviewed by Darin Adler.
      
              Add layoutTestController.dumpWillCacheResponse
              https://bugs.webkit.org/show_bug.cgi?id=28010
      
              willCacheResponse is only interesting for embedders of mainline WebKit on Mac.
              Splitting off a new dumpWillCacheResponse allows a number of existings tests
              to run across platforms.
      
              The test that was specifically verifying willCacheResponse now calls
              dumpWillCacheResponse.
      
              * DumpRenderTree/LayoutTestController.cpp: Add dumpWillCacheResponse
              (LayoutTestController::LayoutTestController):
              (dumpWillCacheResponseCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              (LayoutTestController::dumpWillCacheResponse):
              (LayoutTestController::setDumpWillCacheResponse):
              * DumpRenderTree/mac/ResourceLoadDelegate.mm: Inspect dumpWillCacheResponse
              instead of dumpResourceLoadCallbacks.
              (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46809 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27a4603c
    • mrowe@apple.com's avatar
      Fix two tests to not load a resource that takes five seconds to load. · 0396c338
      mrowe@apple.com authored
      Reviewed by Brady Eidson.
      
      We achieve this by making the delay in slow-resource.pl configurable in a query parameter.
      This drops the run time of each of the tests from over five seconds to less than a third
      of a second.
      
      * http/tests/misc/DOMContentLoaded-event.html:
      * http/tests/navigation/multiple-back-forward-entries.html:
      * http/tests/navigation/resources/slow-resource.pl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0396c338
    • pkasting@chromium.org's avatar
      2009-08-05 Peter Kasting <pkasting@google.com> · 4d746f67
      pkasting@chromium.org authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=26460
              Return multiple icon entries from the ICO decoder as separate frames,
              sorted by decreasing quality (much like the CG ICO decoder does).
      
              As a result of this change, we can eliminate the Skia-specific setData()
              hack that the Chromium port used to select the desired icon size -- now
              callers can just enumerate the frames and ask for the data from the one
              they like.
              
              Under the hood, the ICO decoder now keeps vectors for a number of things
              (including directory entries and image decoders) where it used to have
              single members.  However, callers (that I have seen) will only request
              one frame from the icon, so practically there aren't going to be lots of
              instantiated image decoders.
      
              * platform/graphics/ImageSource.h: Move |m_decoder| back to private now that Skia no longer needs to access it.
              * platform/graphics/cairo/ImageSourceCairo.cpp:
              (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
              * platform/graphics/skia/ImageSourceSkia.cpp:
              (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
              (WebCore::ImageSource::setData): Remove function to ask for a particular icon size.
              * platform/graphics/skia/ImageSourceSkia.h: Removed.
              * platform/graphics/wx/ImageSourceWx.cpp:
              (WebCore::createDecoder): Remove size argument from ICO decoder instantiation.
              * platform/image-decoders/ico/ICOImageDecoder.cpp:
              (WebCore::ICOImageDecoder::ICOImageDecoder):
              (WebCore::ICOImageDecoder::~ICOImageDecoder): Delete all instantiated per-frame decoders.
              (WebCore::ICOImageDecoder::setData): Send data to all instantiated per-frame decoders.
              (WebCore::ICOImageDecoder::isSizeAvailable): Use size from icon directory instead of PNG decoder (if applicable) so we can report it without decoding the PNG frames.
              (WebCore::ICOImageDecoder::size): Report frame-specific size if BMP decoder is calling.  Otherwise, use size from icon directory instead of PNG decoder (if applicable).
              (WebCore::ICOImageDecoder::frameSizeAtIndex): Implement.
              (WebCore::ICOImageDecoder::setSize): Sanity check value if BMP decoder is calling.
              (WebCore::ICOImageDecoder::frameCount): Implement.
              (WebCore::ICOImageDecoder::frameBufferAtIndex): Sanity check size for PNG frames.
              (WebCore::ICOImageDecoder::compareEntries): Add utility function for sorting entries.
              (WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex): Factor out utility function for passing correct data blob to a PNG decoder.
              (WebCore::ICOImageDecoder::decodeWithCheckForDataEnded): Split decode() into two pieces.
              (WebCore::ICOImageDecoder::decodeDirectory): The first part of the old decode().
              (WebCore::ICOImageDecoder::decodeAtIndex): The second part of the old decode(), split off so we avoid decoding an entry until it's requested.
              (WebCore::ICOImageDecoder::processDirectory): Add resizing of internal data structures based on directory contents.
              (WebCore::ICOImageDecoder::processDirectoryEntries): Sort entries by quality.
              (WebCore::ICOImageDecoder::imageTypeAtIndex): Return type to caller instead of setting a member.
              * platform/image-decoders/ico/ICOImageDecoder.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46807 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d746f67
    • abarth@webkit.org's avatar
      2009-08-05 Szabo Carol <carol.szabo@nokia.com> · 8a73293f
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=27942
              Form Reset does not work per w3c standard when single selection
              SELECT element has more than one option marked as selected.
      
              * fast/forms/select-reset-multiple-selections-4-single-selection-expected.txt: Added.
              * fast/forms/select-reset-multiple-selections-4-single-selection.html: Added.
      
      2009-08-05  Szabo Carol  <carol.szabo@nokia.com>
      
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=27942
      
              Test: fast/forms/select-reset-multiple-selections-4-single-selection.html
      
              * dom/SelectElement.cpp:
              (WebCore::SelectElement::reset):
                 Added HTML 4.01 compliant handling of broken webpages that
                 specify more than one selected option for single selection SELECT
                 element, in a manner that emulates Firefox and is similar to IE 7
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a73293f
    • jorlow@chromium.org's avatar
      2009-08-05 Jeremy Orlow <jorlow@chromium.org> · 40ace582
      jorlow@chromium.org authored
              Reviewed by Adam Barth.
      
              Add my name to committers.py
              https://bugs.webkit.org/show_bug.cgi?id=28013
      
              Add my name to committers.py.
      
              * Scripts/modules/committers.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46805 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      40ace582
    • hausmann@webkit.org's avatar
      2009-08-05 Andras Becsi <becsi.andras@stud.u-szeged.hu> · f9233035
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              WebCore.pro bugfix
      
              Fix the gperf lines to properly include the string.h header at compilation with gperf version 3.0.3 and newer.
      
              * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46804 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9233035
    • hausmann@webkit.org's avatar
      2009-08-05 Csaba Osztrogonac <oszi@inf.u-szeged.hu> · 23c12b74
      hausmann@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Fix build error caused by http://trac.webkit.org/changeset/46763
      
              * Api/qwebpluginfactory.h: Export macro added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46803 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23c12b74
    • kenneth@webkit.org's avatar
      2009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org> · dc09fac2
      kenneth@webkit.org authored
              Reviewed by Simon Hausmann.
      
              A minor refactoring of the Qt DRT to be a bit more similar to
              the other DRTs, as well as more understandable.
      
              Splitting up resetJSObjects into a LayoutTestController->reset()
              plus a new closeRemainingWindows() method.
      
              Added a resetToConsistentStateBeforeTesting() method to keep
              the code in one place, making it easier to verify that we are
              doing things properly.
      
              * DumpRenderTree/qt/DumpRenderTree.cpp:
              (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
              (WebCore::DumpRenderTree::open):
              (WebCore::DumpRenderTree::closeRemainingWindows):
              * DumpRenderTree/qt/DumpRenderTree.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc09fac2
    • kenneth@webkit.org's avatar
      2009-08-05 Kenneth Rohde Christiansen <kenneth@webkit.org> · 4dcdbe89
      kenneth@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Make the Qt DRT WorkQueue work similarily to the cross platform
              one. This means that all items return true if they started
              loading.
      
              This change paves the way for unforking the WorkQueue, if we [Qt]
              would like that.
      
              * DumpRenderTree/qt/WorkQueue.cpp:
              (WorkQueue::processWork):
              * DumpRenderTree/qt/WorkQueue.h:
              * DumpRenderTree/qt/WorkQueueItem.h:
              * DumpRenderTree/qt/jsobjects.cpp:
              (LoadItem::invoke):
              (ReloadItem::invoke):
              (ScriptItem::invoke):
              (BackForwardItem::invoke):
              (LayoutTestController::processWork):
              (LayoutTestController::maybeDump):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46801 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4dcdbe89
    • kenneth@webkit.org's avatar
      2009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org> · 1cdca787
      kenneth@webkit.org authored
              Reviewed by Simon Hausmann.
      
              If load of a test fails, don't dump as it will be dumped
              in the preceding test, resulting in a invalid incorrect layout.
      
              * DumpRenderTree/qt/jsobjects.cpp:
              (LayoutTestController::maybeDump):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1cdca787
    • kenneth@webkit.org's avatar
      2009-08-04 Kenneth Rohde Christiansen <kenneth@webkit.org> · 0f27983c
      kenneth@webkit.org authored
              Reviewed by Simon Hausmann.
      
              Make the Qt DumpRenderTree more similar to the mac one.
      
              Changes include:
              1) Reset zoom factor before each test
              2) Only dump the backforward list when we got other dump result
              3) When we dump the render tree, and got zero result print out:
                 [mainFrame renderTreeAsExternalRepresentation]
                 and not:
                 [frame renderTreeAsExternalRepresentation]
      
              * DumpRenderTree/qt/DumpRenderTree.cpp:
              (WebCore::DumpRenderTree::open):
              (WebCore::methodNameStringForFailedTest):
              (WebCore::DumpRenderTree::dump):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46799 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f27983c
    • cfleizach@apple.com's avatar
      WebCore: · 399016cc
      cfleizach@apple.com authored
      2009-08-05  Chris Fleizach  <cfleizach@apple.com>
      
              Fix Tiger build breakage.
      
              * accessibility/mac/AccessibilityObjectWrapper.mm:
      
      WebKitTools:
      
      2009-08-05  chris fleizach  <cfleizach@apple.com>
      
              Fix Tiger build breakage.
      
              * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46798 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      399016cc
    • jmalonzo@webkit.org's avatar
      2009-08-05 Jan Michael Alonzo <jmalonzo@webkit.org> · 7c65380d
      jmalonzo@webkit.org authored
              Reviewed by Xan Lopez.
      
              [Gtk] macros in webkit.m4 should be defined once only
              https://bugs.webkit.org/show_bug.cgi?id=27929
      
              The macros in webkit.m4 are not meant to be called multiple times
              so we'll make them AC_DEFUN_ONCE. Also make AC_HEADER_STDC and AC_PROG_CXX
              AC_REQUIRE to remove the automake warnings when doing autogen.sh.
      
              Lastly, make sure CXXFLAGS and CFLAGS are defined before
              AC_PROG_CXX gets expanded so it doesn't add "-g -O2" on Release builds.
      
              * autotools/webkit.m4:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7c65380d
    • xan@webkit.org's avatar
      2009-08-05 Xan Lopez <xlopez@igalia.com> · a936363e
      xan@webkit.org authored
              Revert r46714, it was making us build debug images by default.
      
              * autotools/webkit.m4:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a936363e
  2. 04 Aug, 2009 21 commits
    • hausmann@webkit.org's avatar
      2009-08-04 Simon Hausmann <hausmann@webkit.org> · addf1b1d
      hausmann@webkit.org authored
              Prospective build fix for Qt build bot: Fix dependency of HTMLNames.cpp
              to both source files, HTMLTagNames.in and HTMLAttributeNames.in
      
              * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      addf1b1d
    • abarth@webkit.org's avatar
      2009-08-04 Adam Barth <abarth@webkit.org> · 6cf8eee1
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              [V8] Teach ScheduledAction::execute about isolated worlds
              https://bugs.webkit.org/show_bug.cgi?id=27703
      
              Rename queueScriptInIsolatedWorld to evaluateScriptInIsolatedWorld
              because I've changed this API to be synchronous instead of asynchronous
              to work around some strange behavior in the work_queue_.  Turns out we
              don't need the complexity of an asynchronous API to test this feature.
      
              * http/tests/security/isolatedWorld/all-window-properties.html:
              * http/tests/security/isolatedWorld/all-window-prototypes.html:
              * http/tests/security/isolatedWorld/body-properties.html:
              * http/tests/security/isolatedWorld/body-prototype.html:
              * http/tests/security/isolatedWorld/click-event.html:
              * http/tests/security/isolatedWorld/document-open.html:
              * http/tests/security/isolatedWorld/document-properties.html:
              * http/tests/security/isolatedWorld/document-prototype.html:
              * http/tests/security/isolatedWorld/global-variables.html:
              * http/tests/security/isolatedWorld/image-properties.html:
              * http/tests/security/isolatedWorld/image-prototype.html:
              * http/tests/security/isolatedWorld/location-properties.html:
              * http/tests/security/isolatedWorld/location-prototype.html:
              * http/tests/security/isolatedWorld/number-prototype.html:
              * http/tests/security/isolatedWorld/object-prototype.html:
              * http/tests/security/isolatedWorld/string-prototype.html:
              * http/tests/security/isolatedWorld/window-properties.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46794 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6cf8eee1
    • bweinstein@apple.com's avatar
      2009-08-04 Brian Weinstein <bweinstein@apple.com> · 6c0024ad
      bweinstein@apple.com authored
              Reviewed by Adele Peterson.
      
              Keypress should exit from pan scrolling mode.
              https://bugs.webkit.org/show_bug.cgi?id=28005
      
              Change the logic from only exiting pan scrolling on escape to exiting on any key press,
              making it easier for users to back out of an accidental pan scroll.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::keyEvent):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c0024ad
    • eric@webkit.org's avatar
      2009-08-04 Eric Seidel <eric@webkit.org> · 6fd7b362
      eric@webkit.org authored
              Reviewed by Simon Fraser.
      
              REGRESSION (r45064): Drop caret remains in text control after the mouse exits
              https://bugs.webkit.org/show_bug.cgi?id=26787
      
              Fix some bogus comments noticed during testing.
      
              * fast/forms/drag-into-textarea.html:
              * fast/forms/drag-out-of-textarea.html:
      
      2009-08-04  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Simon Fraser.
      
              REGRESSION (r45064): Drop caret remains in text control after the mouse exits
              https://bugs.webkit.org/show_bug.cgi?id=26787
      
              Add back missing dragController()->clear() call.
      
              * manual-tests/drag-caret.html: Added.
              * page/DragController.cpp:
              (WebCore::DragController::tryDocumentDrag):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46792 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fd7b362
    • alice.liu@apple.com's avatar
      2009-08-04 Alice Liu <alice.liu@apple.com> · 92bdfec6
      alice.liu@apple.com authored
              "Shift + Enter" should behave like "Enter" in editable fields.
              Affects backward search in find-in-page in Safari for Windows
      
              Reviewed by Jon Honeycutt.
      
              * WebView.cpp:
              Register shift+enter as InsertNewline command, similar to other 
              modifier+Enter combinations.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46791 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      92bdfec6
    • eric@webkit.org's avatar
      2009-08-04 Chris Fleizach <cfleizach@apple.com> · 0e2037c9
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
              https://bugs.webkit.org/show_bug.cgi?id=27994
      
              * platform/mac/accessibility/aria-valuetext-expected.txt: Added.
              * platform/mac/accessibility/aria-valuetext.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e2037c9
    • cfleizach@apple.com's avatar
      2009-08-04 Chris Fleizach <cfleizach@apple.com> · ff691cae
      cfleizach@apple.com authored
              Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
              https://bugs.webkit.org/show_bug.cgi?id=27994
      
              Forgot to commit attribute names.
      
              * html/HTMLAttributeNames.in:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46789 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff691cae
    • cfleizach@apple.com's avatar
      WebCore: · 9b3fa5bb
      cfleizach@apple.com authored
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
              https://bugs.webkit.org/show_bug.cgi?id=27994
      
              Test: platform/mac/accessibility/aria-valuetext.html
      
              * accessibility/AccessibilityObject.h:
              (WebCore::AccessibilityObject::valueDescription):
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::valueDescription):
              * accessibility/AccessibilityRenderObject.h:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
              * html/HTMLAttributeNames.in:
      
      WebKitTools:
      
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
              https://bugs.webkit.org/show_bug.cgi?id=27994
      
              Expose valueDescription for accessibility. 
      
              * DumpRenderTree/AccessibilityUIElement.cpp:
              (getValueDescriptionCallback):
              (AccessibilityUIElement::getJSClass):
              * DumpRenderTree/AccessibilityUIElement.h:
              * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
              (AccessibilityUIElement::valueDescription):
              * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
              (AccessibilityUIElement::valueDescription):
      
      LayoutTests:
      
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27994 - WAI-ARIA: aria-valuetext needs to be implemented
              https://bugs.webkit.org/show_bug.cgi?id=27994
      
              * platform/mac/accessibility/aria-valuetext-expected.txt: Added.
              * platform/mac/accessibility/aria-valuetext.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46788 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b3fa5bb
    • eric@webkit.org's avatar
      2009-08-04 Eric Seidel <eric@webkit.org> · a01618d0
      eric@webkit.org authored
              Reviewed by Mark Rowe.
      
              REGRESSION: run-webkit-tests crashes if you have non-system perl in PATH
              https://bugs.webkit.org/show_bug.cgi?id=28006
      
              Hard-code perl to /usr/bin/perl and swig to /usr/bin/swig
      
              * DumpRenderTree/mac/PerlSupport/Makefile:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46787 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a01618d0
    • darin@chromium.org's avatar
      2009-08-04 Michael Nordman <michaeln@google.com> · df43753e
      darin@chromium.org authored
              Reviewed by Alexey Proskuryakov.
      
              https://bugs.webkit.org/show_bug.cgi?id=27821
      
              No new features, no new tests. Existing layout tests pass.
      
              * WebCore.base.exp:
      
              Export AppliationCacheGroup::storeCopyOfCache
      
              * WebCore.xcodeproj/project.pbxproj:
      
              Restore DOMApplicationCache.h and ApplicationCacheHost.h to 'project' headers
              instead of 'private' headers since they're no longer in the DocumentLoader.h
              include graph.
      
              * html/HTMLHtmlElement.cpp:
              (WebCore::HTMLHtmlElement::insertedIntoDocument):
      
              Reinstate the test for manifest.isNull instead of .isEmtpty().
              Added a FIXME to revisit once the spec gets clarified.
              
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::DocumentLoader):
              (WebCore::DocumentLoader::mainReceivedError):
              (WebCore::DocumentLoader::detachFromFrame):
              * loader/DocumentLoader.h:
              (WebCore::DocumentLoader::applicationCacheHost):
      
              ApplicationCacheHost is held in an OwnPtr<> by DocumentLoader. This was done
              for compile time friendliness, it results in a smaller include graph for files
              dependent on DocumentLoader.h.
      
              * loader/FrameLoader.cpp:
              * loader/MainResourceLoader.cpp:
              * loader/ResourceLoader.cpp:
      
              Cleanup ussage of ENABLE(xxx) around includes, generally remove those guards.
              This was done for readability at the include site. The included files contain appropriate guards,
              so they're not needed at the include site.
      
              * loader/appcache/ApplicationCacheGroup.cpp:
              (WebCore::ApplicationCacheGroup::selectCache):
              (WebCore::ApplicationCacheGroup::finishedLoadingMainResource):
              (WebCore::ApplicationCacheGroup::failedLoadingMainResource):
              (WebCore::ApplicationCacheGroup::update):
              (WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
              (WebCore::ApplicationCacheGroup::manifestNotFound):
              (WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
              (WebCore::ApplicationCacheGroup::startLoadingEntry):
              (WebCore::CallCacheListenerTask::create):
              (WebCore::CallCacheListenerTask::performTask):
              (WebCore::CallCacheListenerTask::CallCacheListenerTask):
              (WebCore::ApplicationCacheGroup::postListenerTask):
              * loader/appcache/ApplicationCacheGroup.h:
      
              Use ApplicationCachHost defined constants, no longer depends on DOMApplicationCache.
      
              * loader/appcache/ApplicationCacheHost.cpp:
              (WebCore::ApplicationCacheHost::ApplicationCacheHost):
              (WebCore::ApplicationCacheHost::setDOMApplicationCache):
              (WebCore::ApplicationCacheHost::notifyEventListener):
              (WebCore::ApplicationCacheHost::status):
              * loader/appcache/ApplicationCacheHost.h:
              (WebCore::ApplicationCacheHost::):
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::ApplicationCacheStorage::storeCopyOfCache):
              * loader/appcache/ApplicationCacheStorage.h:
      
              Merge recently added transferApplicationCache and pre-existing storeCopyOfCache methods.
      
              * loader/appcache/DOMApplicationCache.cpp:
              (WebCore::DOMApplicationCache::status):
              (WebCore::DOMApplicationCache::addEventListener):
              (WebCore::DOMApplicationCache::removeEventListener):
              (WebCore::DOMApplicationCache::callListener):
              (WebCore::DOMApplicationCache::toEventType):
              (WebCore::DOMApplicationCache::toEventID):
              * loader/appcache/DOMApplicationCache.h:
              (WebCore::DOMApplicationCache::setAttributeEventListener):
              (WebCore::DOMApplicationCache::getAttributeEventListener):
              (WebCore::DOMApplicationCache::clearAttributeEventListener):
              (WebCore::DOMApplicationCache::callEventListener):
              (WebCore::DOMApplicationCache::setOnchecking):
              (WebCore::DOMApplicationCache::onchecking):
              (WebCore::DOMApplicationCache::setOnerror):
              (WebCore::DOMApplicationCache::onerror):
              (WebCore::DOMApplicationCache::setOnnoupdate):
              (WebCore::DOMApplicationCache::onnoupdate):
              (WebCore::DOMApplicationCache::setOndownloading):
              (WebCore::DOMApplicationCache::ondownloading):
              (WebCore::DOMApplicationCache::setOnprogress):
              (WebCore::DOMApplicationCache::onprogress):
              (WebCore::DOMApplicationCache::setOnupdateready):
              (WebCore::DOMApplicationCache::onupdateready):
              (WebCore::DOMApplicationCache::setOncached):
              (WebCore::DOMApplicationCache::oncached):
              (WebCore::DOMApplicationCache::setOnobsolete):
              (WebCore::DOMApplicationCache::onobsolete):
      
              Use ApplicationCachHost defined constants for Status and EventIDs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46786 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df43753e
    • abarth@webkit.org's avatar
      2009-08-04 Adam Barth <abarth@webkit.org> · b3c48504
      abarth@webkit.org authored
              Reviewed by Darin Adler.
      
              Add pkasting to bugzilla-tool as a committer
              https://bugs.webkit.org/show_bug.cgi?id=28002
      
              * Scripts/modules/committers.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46785 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3c48504
    • japhet@chromium.org's avatar
      2009-08-04 Nate Chapin <japhet@chromium.org> · 07e35744
      japhet@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Revert r46421 and r46769, which appear to have totally hosed the v8 bindings.
      
              https://bugs.webkit.org/show_bug.cgi?id=27719
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      07e35744
    • cfleizach@apple.com's avatar
      WebCore: · 2365e885
      cfleizach@apple.com authored
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27993 - AXSliders are missing required attributes and actions
              https://bugs.webkit.org/show_bug.cgi?id=27993
      
              Expose appropriate actions and attributes for sliders.
      
              Test: platform/mac/accessibility/slider-supports-actions.html
      
              * accessibility/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::orientation):
              * accessibility/AccessibilityObject.h:
              (WebCore::):
              * accessibility/AccessibilitySlider.cpp:
              (WebCore::AccessibilitySlider::orientation):
              * accessibility/AccessibilitySlider.h:
              * accessibility/mac/AccessibilityObjectWrapper.mm:
              (-[AccessibilityObjectWrapper accessibilityActionNames]):
              (-[AccessibilityObjectWrapper accessibilityAttributeNames]):
              (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
      
      WebKitTools:
      
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27993 - AXSliders are missing required attributes and actions
              https://bugs.webkit.org/show_bug.cgi?id=27993
      
              Add ability to check if any arbitrary action is supported.
      
              * DumpRenderTree/AccessibilityUIElement.cpp:
              (isActionSupportedCallback):
              (AccessibilityUIElement::getJSClass):
              * DumpRenderTree/AccessibilityUIElement.h:
              * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
              (AccessibilityUIElement::isActionSupported):
              * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
              (AccessibilityUIElement::isActionSupported):
      
      LayoutTests:
      
      2009-08-04  Chris Fleizach  <cfleizach@apple.com>
      
              Reviewed by Darin Adler.
      
              Bug 27993 - AXSliders are missing required attributes and actions
              https://bugs.webkit.org/show_bug.cgi?id=27993
      
              Update tests to use more generic isActionSupported.
      
              * accessibility/aria-link-supports-press.html:
              * accessibility/button-press-action.html:
              * accessibility/onclick-handlers.html:
              * platform/mac/accessibility/slider-supports-actions-expected.txt: Added.
              * platform/mac/accessibility/slider-supports-actions.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46783 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2365e885
    • jianli@chromium.org's avatar
      2009-08-04 Jian Li <jianli@chromium.org> · 38b946b2
      jianli@chromium.org authored
              Reviewed by David Levin.
      
              [V8] Fix an assert in WebCoreStringResource that causes worker script
              evaluation failed.
              https://bugs.webkit.org/show_bug.cgi?id=27996
      
              The fix is to check for the same thread, instead of the main thread.
              This is because Chromium's workers use v8 in a single thread that is
              not the main thread.
      
              * bindings/v8/V8Binding.cpp:
              (WebCore::WebCoreStringResource::WebCoreStringResource):
              (WebCore::WebCoreStringResource::~WebCoreStringResource):
              (WebCore::WebCoreStringResource::atomicString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38b946b2
    • abarth@webkit.org's avatar
      2009-08-04 Adam Barth <abarth@webkit.org> · 2282d863
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              bugzilla-tool unit tests need a test harness
              https://bugs.webkit.org/show_bug.cgi?id=27977
      
              * Scripts/run-webkit-unittests: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46781 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2282d863
    • kevino@webkit.org's avatar
      wx build fix after InspectorClient API change. · dc5b52be
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46780 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc5b52be
    • eric@webkit.org's avatar
      2009-08-04 Eric Seidel <eric@webkit.org> · e94d8b69
      eric@webkit.org authored
              Reviewed by Simon Fraser.
      
              LayoutTests are too slow
              https://bugs.webkit.org/show_bug.cgi?id=27995
      
              Shave 5 seconds off of run-webkit-tests.
      
              * fast/events/click-count.html: use eventSender.leapForward instead of setTimeout
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46779 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e94d8b69
    • barraclough@apple.com's avatar
      2009-08-04 Gavin Barraclough <barraclough@apple.com> · 2efbcabc
      barraclough@apple.com authored
              Rubber Stamped by Oiver Hunt.
      
              Revert r46643 since this breaks the Yarr::Interpreter running the v8 tests.
              https://bugs.webkit.org/show_bug.cgi?id=27874
      
              * yarr/RegexInterpreter.cpp:
              (JSC::Yarr::Interpreter::allocDisjunctionContext):
              (JSC::Yarr::Interpreter::freeDisjunctionContext):
              (JSC::Yarr::Interpreter::allocParenthesesDisjunctionContext):
              (JSC::Yarr::Interpreter::freeParenthesesDisjunctionContext):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46778 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2efbcabc
    • oliver@apple.com's avatar
      PPC64 Build fix · a6782873
      oliver@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46777 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a6782873
    • simon.fraser@apple.com's avatar
      2009-08-04 Simon Fraser <simon.fraser@apple.com> · f714b56d
      simon.fraser@apple.com authored
              Reviewed by Dave Hyatt.
      
              Add support for transitions/animations of text-indent.
      
              Test: transitions/text-indent-transition.html
      
              * page/animation/AnimationBase.cpp:
              (WebCore::ensurePropertyMap):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46776 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f714b56d
    • mrowe@apple.com's avatar
      Ensure that DumpRenderTreeSupport is regenerated when switching between OS versions · 034cc68e
      mrowe@apple.com authored
      by listing the DumpRenderTree binary as a dependency.  Xcode has the smarts to rebuild
      DumpRenderTree itself when switching OS versions so this dependency removes the need
      for any smarts in the Makefile.
      
      Rubber-stamped by Gavin "Gavvy" Barraclough.
      
      * DumpRenderTree/mac/PerlSupport/Makefile:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46775 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      034cc68e