1. 29 Oct, 2012 40 commits
    • tasak@google.com's avatar
      Updated ChangeLog. · b74ba8f5
      tasak@google.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132866 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b74ba8f5
    • tasak@google.com's avatar
      Added myself as a committer. · b064f34a
      tasak@google.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b064f34a
    • scheib@chromium.org's avatar
      Unreviewed, rolling out r132845. · 360b1359
      scheib@chromium.org authored
      http://trac.webkit.org/changeset/132845
      https://bugs.webkit.org/show_bug.cgi?id=99975
      
      Broke chromium builds, linker errors from
      IDBBindingUtilitiesTest
      
      Source/WebCore:
      
      * Modules/indexeddb/IDBRequest.cpp:
      (WebCore::IDBRequest::IDBRequest):
      (WebCore::IDBRequest::onSuccess):
      (WebCore::IDBRequest::dispatchEvent):
      * Modules/indexeddb/IDBRequest.h:
      (IDBRequest):
      * bindings/v8/IDBBindingUtilities.cpp:
      (WebCore::createIDBKeyFromScriptValueAndKeyPath):
      (WebCore):
      (WebCore::deserializeIDBValue):
      (WebCore::injectIDBKeyIntoScriptValue):
      (WebCore::idbKeyToScriptValue):
      * bindings/v8/V8PerIsolateData.cpp:
      (WebCore::V8PerIsolateData::ensureAuxiliaryContext):
      (WebCore):
      * bindings/v8/V8PerIsolateData.h:
      (V8PerIsolateData):
      
      Source/WebKit/chromium:
      
      * tests/IDBBindingUtilitiesTest.cpp:
      (WebCore::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      360b1359
    • andersca@apple.com's avatar
      Fix Windows build. · 5e352844
      andersca@apple.com authored
      * platform/network/cf/ResourceRequestCFNet.cpp:
      (WebCore::setHeaderFields):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e352844
    • jamesr@google.com's avatar
      [chromium] Defer commits between page unload and first invalidation in threaded compositing mode · a58e3808
      jamesr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100702
      
      Reviewed by Adrienne Walker.
      
      In threaded compositing mode, it's not terribly useful to commit after unloading a page and before receiving
      the first invalidation for the new page since the document is likely not loaded enough to paint usefully.
      This defers commits from the time compositing is deactivated (which in force compositing mode only happens
      at FrameView destruction) until we get the first invalidation from WebCore.
      
      * src/ChromeClientImpl.cpp:
      (WebKit::ChromeClientImpl::invalidateContentsAndRootView):
      * src/WebViewImpl.cpp:
      (WebKit::WebViewImpl::invalidateRect):
      (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
      (WebKit):
      * src/WebViewImpl.h:
      (WebViewImpl):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132862 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a58e3808
    • commit-queue@webkit.org's avatar
      Coordinated Graphics: Delete cached ShareableSurfaces when purging backingStores. · f00186e6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100705
      
      Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-29
      Reviewed by Noam Rosenthal.
      
      LayerTreeCoordinatorProxy can be used after calling
      LayerTreeCoordinatorProxy::purgeBackingStores(). So we should clear cached
      ShareableSurfaces.
      
      * UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
      (WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132861 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f00186e6
    • mrowe@apple.com's avatar
      Simplify Xcode configuration settings that used to vary between OS versions. · fb7aaa43
      mrowe@apple.com authored
      Reviewed by Dan Bernstein.
      
      Source/JavaScriptCore:
      
      * Configurations/Base.xcconfig:
      * Configurations/DebugRelease.xcconfig:
      * Configurations/JavaScriptCore.xcconfig:
      
      Source/ThirdParty:
      
      * gtest/xcode/Config/General.xcconfig:
      
      Source/ThirdParty/ANGLE:
      
      * Configurations/Base.xcconfig:
      * Configurations/DebugRelease.xcconfig:
      
      Source/WebCore:
      
      * Configurations/Base.xcconfig:
      * Configurations/DebugRelease.xcconfig:
      * Configurations/WebCore.xcconfig:
      
      Source/WebKit/mac:
      
      * Configurations/Base.xcconfig:
      * Configurations/DebugRelease.xcconfig:
      * Configurations/WebKit.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/Base.xcconfig:
      * Configurations/WebKit2.xcconfig:
      
      Source/WTF:
      
      * Configurations/Base.xcconfig:
      * Configurations/DebugRelease.xcconfig:
      
      Tools:
      
      * DumpRenderTree/mac/Configurations/Base.xcconfig:
      * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
      * MiniBrowser/Configurations/Base.xcconfig:
      * MiniBrowser/Configurations/DebugRelease.xcconfig:
      * TestWebKitAPI/Configurations/Base.xcconfig:
      * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
      * WebKitTestRunner/Configurations/Base.xcconfig:
      * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132860 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb7aaa43
    • mrowe@apple.com's avatar
      Remove references to unsupported OS and Xcode versions. · 5b132015
      mrowe@apple.com authored
      Reviewed by Anders Carlsson.
      
      Source/JavaScriptCore:
      
      * Configurations/Base.xcconfig:
      * Configurations/CompilerVersion.xcconfig: Removed.
      * Configurations/DebugRelease.xcconfig:
      * Configurations/Version.xcconfig:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      
      Source/ThirdParty:
      
      * gtest/xcode/Config/CompilerVersion.xcconfig: Removed.
      * gtest/xcode/Config/General.xcconfig:
      
      Source/ThirdParty/ANGLE:
      
      * Configurations/Base.xcconfig:
      * Configurations/CompilerVersion.xcconfig: Removed.
      * Configurations/DebugRelease.xcconfig:
      
      Source/WebCore:
      
      * Configurations/Base.xcconfig:
      * Configurations/CompilerVersion.xcconfig: Removed.
      * Configurations/DebugRelease.xcconfig:
      * Configurations/Version.xcconfig:
      * Configurations/WebCore.xcconfig:
      * DerivedSources.make:
      * WebCore.xcodeproj/project.pbxproj:
      
      Source/WebKit:
      
      * WebKit.xcodeproj/project.pbxproj:
      
      Source/WebKit/mac:
      
      * Configurations/Base.xcconfig:
      * Configurations/CompilerVersion.xcconfig: Removed.
      * Configurations/DebugRelease.xcconfig:
      * Configurations/Version.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/Base.xcconfig:
      * Configurations/CompilerVersion.xcconfig: Removed.
      * Configurations/DebugRelease.xcconfig:
      * Configurations/Version.xcconfig:
      * DerivedSources.make:
      * WebKit2.xcodeproj/project.pbxproj:
      
      Source/WTF:
      
      * Configurations/Base.xcconfig:
      * Configurations/CompilerVersion.xcconfig: Removed.
      * Configurations/DebugRelease.xcconfig:
      * WTF.xcodeproj/project.pbxproj:
      
      Tools:
      
      * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
      * DumpRenderTree/mac/Configurations/Base.xcconfig:
      * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Removed.
      * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
      * MiniBrowser/Configurations/Base.xcconfig:
      * MiniBrowser/Configurations/CompilerVersion.xcconfig: Removed.
      * MiniBrowser/Configurations/DebugRelease.xcconfig:
      * TestWebKitAPI/Configurations/Base.xcconfig:
      * TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Removed.
      * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * WebKitTestRunner/Configurations/Base.xcconfig:
      * WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Removed.
      * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
      * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132859 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b132015
    • andersca@apple.com's avatar
      AtomicString(CFStringRef) shouldn't unconditionally create a StringImpl · 7baee1c0
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100701
      
      Reviewed by Dan Bernstein.
      
      Source/WebCore:
      
      * WebCore.exp.in:
      Export AtomicString::add(CFStringRef).
      
      * Target.pri:
      * WebCore.gypi:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      Add AtomicStringCF.cpp
      
      * platform/text/cf/AtomicStringCF.cpp: Added.
      (WTF::AtomicString::add):
      When trying to add the atomic string to the table, first try to get a Latin-1 pointer
      from the string. Second, try to get a Unicode pointer from the string.
      If that also fails, copy the string to a temporary unicode buffer and add it from there.
      
      * platform/text/cf/HyphenationCF.cpp:
      (WebCore::::createValueForKey):
      Update for AtomicString::createCFString being removed.
      
      Source/WTF:
      
      * wtf/text/AtomicString.h:
      (WTF::AtomicString::AtomicString):
      Change the constructors that take a CFStringRef and an NSString * to call AtomicString::add(CFStringRef)
      and remove AtomicString::createCFString.
      
      (WTF::AtomicString::add):
      Add new member function declaration. The definition is in a new file in WebCore, AtomicStringCF.cpp.
      Also, fix the overload of add that takes a const char* to call the right other overload instead of itself.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132858 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7baee1c0
    • ap@apple.com's avatar
      [WK2] Add a NetworkingContext for NetworkProcess · 6b05831f
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=100708
      
              Reviewed by Anders Carlsson.
      
              Each request will have a context, because these are so lightweight on Mac, and
              other platforms will need ResourceHandle refactored anyway to use NetworkProcess.
      
              * NetworkProcess/mac/RemoteNetworkingContext.h: Added.
              * NetworkProcess/mac/RemoteNetworkingContext.mm: Added.
              These go mac/ subdirectory, because NetworkingContext interface is different on
              each platform, as ResourceHandle needs dictate.
      
              * WebKit2.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b05831f
    • schenney@chromium.org's avatar
      feImage should not be allowed to self reference · 42738924
      schenney@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=94652
      
      Reviewed by Eric Seidel.
      
      Source/WebCore: 
      
      Add cycle detection for SVG filter application, and also fix a problem
      with graphics context restore when filters are applied. This also
      converts the flags in FilterData to a state tracking system, as the
      number of flags was getting messy and only one flag is valid at any given time.
      
      Test: svg/filters/feImage-self-and-other-referencing.html
      
      * rendering/svg/RenderSVGResourceFilter.cpp: Convert to new FilterData
      state management and enable cycle detection.
      (WebCore):
      (WebCore::RenderSVGResourceFilter::removeClientFromCache): Change isBuilt and markedForRemoval flags to state enums.
      (WebCore::RenderSVGResourceFilter::applyResource): Change flags to state enums and detect cycles.
      (WebCore::RenderSVGResourceFilter::postApplyResource): Change flags to state and add handling
      for the various states.
      (WebCore::RenderSVGResourceFilter::primitiveAttributeChanged): Change isBuilt flag to state enums.
      * rendering/svg/RenderSVGResourceFilter.h:
      (WebCore::FilterData::FilterData):
      (FilterData): Convert to a state tracking system.
      * rendering/svg/RenderSVGRoot.cpp:
      (WebCore::RenderSVGRoot::paintReplaced): Add a block around the
      SVGRenderingContext so that it applies the filter and reverts the
      context before the calling method restores the context.
      
      LayoutTests: 
      
      Additional test case for situations when the filter is applied to multiple objects that it also references.
      
      * svg/filters/feImage-self-and-other-referencing-expected.html: Added.
      * svg/filters/feImage-self-and-other-referencing.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42738924
    • senorblanco@chromium.org's avatar
      Unreviewed. Rolled DEPS. · 90dd8df5
      senorblanco@chromium.org authored
      * DEPS:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132855 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90dd8df5
    • abarth@webkit.org's avatar
      Unreviewed. Correct my previous patch to disable external SVG · efa18b72
      abarth@webkit.org authored
      references only on PLATFORM(CHROMIUM).
      
      * wtf/Platform.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132854 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      efa18b72
    • msaboff@apple.com's avatar
      Non-special escape character sequences cause JSC::Lexer::parseString to create 16 bit strings · 48f4353d
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100576
      
      Reviewed by Darin Adler.
      
      Source/JavaScriptCore: 
      
      Changed singleEscape() processing to be based on a lookup of a static table.  The table
      covers ASCII characters SPACE through DEL.  If a character can be a single character escape,
      then the table provides the non-zero result of that escape.  Updated the result of
      singleEscape to be an LChar to make the table as small as possible.
      Added a new test fast/js/normal-character-escapes-in-string-literals.html to validated
      the behavior.
      
      * parser/Lexer.cpp:
      (JSC::singleEscape):
      (JSC::Lexer::parseString):
      (JSC::Lexer::parseStringSlowCase):
      
      LayoutTests: 
      
      Added a new test to validated the behavior of the corresponding changes to string processing
      in the Lexer.
      
      * fast/js/normal-character-escapes-in-string-literals-expected.txt: Added.
      * fast/js/normal-character-escapes-in-string-literals.html: Added.
      * fast/js/script-tests/normal-character-escapes-in-string-literals.js: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132853 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      48f4353d
    • mitz@apple.com's avatar
      <rdar://problem/12592716> REGRESSION (r132545): With full-page accelerated drawing, a · 82bfc00c
      mitz@apple.com authored
      reproducible hang occurs at <http://www.cbsnews.com/stories/2010/01/24/ftn/main6136386.shtml>.
      
      Reviewed by Anders Carlsson.
      
      Work around <rdar://problem/12584492> by limiting the scope of the fix for <http://webkit.org/b/100413>.
      
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::clipOut): Reverted to using CGContextGetClipBoundingBox() rather
      than CGRectInfinite when the context is accelerated and has a transform that is not just
      a translation or a scale.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82bfc00c
    • rwlbuis@webkit.org's avatar
      [BlackBerry] Simplify AuthenticationChallengeManager::instance · e2c4789d
      rwlbuis@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100614
      
      Reviewed by Yong Li.
      Internally reviewed by Lyon Chen.
      
      Source/WebCore:
      
      Use a standard Singleton pattern here, this makes sure we create lazily.
      
      * platform/blackberry/AuthenticationChallengeManager.cpp:
      (WebCore):
      * platform/blackberry/AuthenticationChallengeManager.h:
      (AuthenticationChallengeManager):
      
      Source/WebKit/blackberry:
      
      No need to call AuthenticationChallengeManager::init anymore.
      
      * Api/BlackBerryGlobal.cpp:
      (BlackBerry::WebKit::globalInitialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2c4789d
    • roger_fong@apple.com's avatar
      Unreviewed. Feature introduced in r132708 is chromium only. Skipping related tests. · 14a1d790
      roger_fong@apple.com authored
      * platform/win/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132850 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14a1d790
    • abarth@webkit.org's avatar
      Block SVG external references pending a security review · 01a17e2f
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100635
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      We need to do a security review of loading external SVG references
      before we're sure that it is safe.
      
      * css/StyleResolver.cpp:
      (WebCore::StyleResolver::createFilterOperations):
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::canRequest):
      
      Source/WTF:
      
      We need to do a security review of loading external SVG references
      before we're sure that it is safe.
      
      * wtf/Platform.h:
      
      LayoutTests:
      
      Skip tests that depend on external SVG references.
      
      * platform/chromium/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132849 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01a17e2f
    • jsbell@chromium.org's avatar
      IndexedDB: Crash on checking version of corrupt backing store · 90438d49
      jsbell@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100692
      
      Reviewed by Tony Chang.
      
      If the backing store fails to open (due to corruption, non-writeable disk, etc)
      the subsequent schema version check dereferences a null pointer. Fix to only
      do the schema check if the database opened.
      
      Chromium tests will be included with crrev.com/11196029
      
      * Modules/indexeddb/IDBLevelDBBackingStore.cpp:
      (WebCore::IDBLevelDBBackingStore::open):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132848 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      90438d49
    • pdr@google.com's avatar
      Let SVGElements have pending resources. · a4354cd8
      pdr@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=99694
      
      Reviewed by Eric Seidel.
      
      Our SVG pending resource tracking is used for handling dynamic id changes. For example,
      if an SVG element references an id that is not yet in the document (or has been removed),
      the SVG element will be 'pending' an id. When styled elements are inserted into
      the document, buildPendingResourcesIfNeeded() is called to force any pending elements
      to resolve their dependencies. Only SVGStyledElement targets can be referenced using
      this infrastructure, and that is not changed with this patch.
      
      Previously, only SVGStyledElements could have pending resources. Some examples of where
      this is violated are SVGAnimateElement and SVGMPathElement which are not a styled elements
      but which can have pending references (they can reference styled elements and
      paths, respectively). This patch changes the pending resource handling to allow
      any SVGElement to have pending resources.
      
      This patch is only a refactoring of code in preparation for WK99694 and does not
      affect existing functionality or tests.
      
      * svg/SVGDocumentExtensions.cpp:
      (WebCore::SVGDocumentExtensions::addPendingResource):
      (WebCore::SVGDocumentExtensions::isElementPendingResources):
      (WebCore::SVGDocumentExtensions::isElementPendingResource):
      (WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
      (WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemoval):
      * svg/SVGDocumentExtensions.h:
      (WebCore):
      (SVGDocumentExtensions):
      * svg/SVGElement.cpp:
      (WebCore::SVGElement::~SVGElement):
      (WebCore::SVGElement::removedFrom):
      (WebCore::SVGElement::hasPendingResources):
      (WebCore):
      (WebCore::SVGElement::setHasPendingResources):
      (WebCore::SVGElement::clearHasPendingResourcesIfPossible):
      * svg/SVGElement.h:
      (SVGElement):
      (WebCore::SVGElement::buildPendingResource):
      * svg/SVGStyledElement.cpp:
      (WebCore):
      (WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
      (WebCore::SVGStyledElement::removedFrom):
      * svg/SVGStyledElement.h:
      (SVGStyledElement):
      (WebCore::SVGStyledElement::selfHasRelativeLengths):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132847 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4354cd8
    • crogers@google.com's avatar
      Unreviewed rebaseline of webaudio/audiobuffersource-loop-points · 23f47b17
      crogers@google.com authored
      * platform/chromium-win-xp/webaudio/audiobuffersource-loop-points-expected.wav: Added.
      * platform/chromium-win/webaudio/audiobuffersource-loop-points-expected.wav: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132846 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23f47b17
    • commit-queue@webkit.org's avatar
      Remove ensureAuxiliaryContext · d365a3df
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99975
      
      Patch by Dan Carney <dcarney@google.com> on 2012-10-29
      Reviewed by Adam Barth.
      
      Source/WebCore:
      
      Removed auxilliaryContext as use if it is problematic in IDB.
      
      No new tests. No change in functionality.
      
      * Modules/indexeddb/IDBCursor.cpp:
      (WebCore::IDBCursor::update):
      (WebCore::IDBCursor::setValueReady):
      * Modules/indexeddb/IDBCursor.h:
      (IDBCursor):
      * Modules/indexeddb/IDBObjectStore.cpp:
      (WebCore::generateIndexKeysForValue):
      (WebCore::IDBObjectStore::put):
      (WebCore):
      * Modules/indexeddb/IDBRequest.cpp:
      (WebCore::IDBRequest::onSuccess):
      (WebCore::IDBRequest::dispatchEvent):
      * bindings/v8/IDBBindingUtilities.cpp:
      (WebCore::createIDBKeyFromScriptValueAndKeyPath):
      (WebCore::deserializeIDBValue):
      (WebCore::injectIDBKeyIntoScriptValue):
      * bindings/v8/IDBBindingUtilities.h:
      (WebCore):
      * bindings/v8/V8Binding.cpp:
      (WebCore::toV8Context):
      (WebCore):
      * bindings/v8/V8Binding.h:
      (WebCore):
      * bindings/v8/V8PerIsolateData.cpp:
      (WebCore):
      * bindings/v8/V8PerIsolateData.h:
      
      Source/WebKit/chromium:
      
      Updated tests to use correct v8 context.
      
      * tests/IDBBindingUtilitiesTest.cpp:
      (WebKit::checkKeyFromValueAndKeyPathInternal):
      (WebKit::checkKeyPathNullValue):
      (WebKit::injectKey):
      (WebKit::checkInjection):
      (WebKit::checkInjectionFails):
      (WebKit::checkKeyPathStringValue):
      (WebKit::checkKeyPathNumberValue):
      (WebKit::scriptExecutionContext):
      (WebKit):
      (WebKit::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132845 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d365a3df
    • hclam@chromium.org's avatar
      [skia] Handle mask box image. · e09f5ef7
      hclam@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100570
      
      Reviewed by James Robinson.
      
      Source/WebCore:
      
      When drawing an image with source rectangle it should intersect with image rectangle.
      This should be the case for drawing single image and tiling an image.
      
      Test: fast/images/mask-box-image-crash.html
      
      * platform/graphics/skia/ImageSkia.cpp:
      (WebCore::Image::drawPattern):
      (WebCore::BitmapImage::draw):
      (WebCore::BitmapImageSingleFrameSkia::draw):
      
      LayoutTests:
      
      Added a test for -webkit-mask-box-image. Test should complete without crashes.
      Output image should be blank.
      
      * fast/images/mask-box-image-crash-expected.png: Added.
      * fast/images/mask-box-image-crash-expected.txt: Added.
      * fast/images/mask-box-image-crash.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132844 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e09f5ef7
    • dbarton@mathscribe.com's avatar
      Unreviewed gardening. LayoutTests/mathml/msubsup-fuzz.html passes locally but not on · d6763783
      dbarton@mathscribe.com authored
      cr-linux-ews. I need to see a stack trace to debug it. See webkit.org/b/100463.
      
      * mathml/msubsup-fuzz-expected.txt: Added.
      * mathml/msubsup-fuzz.html: Added.
      * platform/chromium/TestExpectations:
      * platform/efl/TestExpectations:
      * platform/gtk/TestExpectations:
      * platform/mac/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132843 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d6763783
    • eric.carlson@apple.com's avatar
      Support captions when PLUGIN_PROXY_FOR_VIDEO · 2d0fe4d3
      eric.carlson@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100690
      
      Reviewed by Simon Fraser.
      
      When built with PLUGIN_PROXY_FOR_VIDEO, WebCore uses a plug-in for the media element's
      platform media engine. Update this code path so the shadow DOM elements used to display
      text tracks are created and configured correctly.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::configureMediaControls): Create media controls if necessary.
      
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::layout): Set the position and size of the shadow DOM when the
          position of the embedded element changes.
      * rendering/RenderEmbeddedObject.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132842 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2d0fe4d3
    • msaboff@apple.com's avatar
      buildHTTPHeaders() should use a StringBuilder.appendLiteral() for separator · 5052ad78
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100689
      
      Reviewed by Darin Adler.
      
      Changed from using a String temporary for the separator to using StringBuilder.appendLiteral(": ").
      
      * WebProcess/Plugins/PluginView.cpp:
      (WebKit::buildHTTPHeaders):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5052ad78
    • dpranke@chromium.org's avatar
      webkitpy: change non-verbose log format for webkit-patch · 0dd62360
      dpranke@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100561
      
      Reviewed by Ojan Vafai.
      
      Logging the module name and the log level is annoying and nearly useless.
      For starters, this change removes that unless you are doing verbose/
      debug logging. In the future we should split out the concepts of
      verbose and debug logging (like we did in test-webkitpy and
      run-webkit-tests) so that you could get this in debug logging.
      
      * Scripts/webkitpy/common/system/logutils.py:
      (_default_handlers):
      (configure_logging):
      * Scripts/webkitpy/common/system/logutils_unittest.py:
      (ConfigureLoggingTest.test_info_message):
      (ConfigureLoggingTest):
      (ConfigureLoggingTest.test_debug_message):
      (ConfigureLoggingTest.test_two_messages):
      (ConfigureLoggingVerboseTest):
      (ConfigureLoggingVerboseTest._logging_level):
      (ConfigureLoggingVerboseTest.test_info_message):
      (ConfigureLoggingVerboseTest.test_debug_message):
      (ConfigureLoggingCustomLevelTest.test_logged_message):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132840 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dd62360
    • junov@google.com's avatar
      [Chromium] flickering observed when copying 2D canvas to webGL texture · 2dfcde15
      junov@google.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100691
      
      Reviewed by Stephen White.
      
      Source/WebCore:
      
      Added a flush to the webgl context after texture upload from an image
      buffer to ensure proper graphics context synchronization with respect
      to subsequent changes to the source image.
      
      Tests: fast/canvas/webgl/canvas-2d-webgl-texture.html
      
      * platform/graphics/skia/ImageBufferSkia.cpp:
      (WebCore::ImageBuffer::copyToPlatformTexture):
      
      LayoutTests:
      
      Modified test by adding a canvas draw imediately after webgl texture
      upload in order to exercise graphics context synchronization between
      the webGL and 2D canvas graphics contexts.
      
      * fast/canvas/webgl/canvas-2d-webgl-texture.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132839 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dfcde15
    • commit-queue@webkit.org's avatar
      [CSSOM] Extraneous whitespace in CSSImportRule.cssText · 759404aa
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100657
      
      Patch by Glenn Adams <glenn@skynav.com> on 2012-10-29
      Reviewed by Simon Fraser.
      
      Source/WebCore:
      
      Remove extraneous whitespace when serializing CSSImportRule.cssText when
      media list is empty.
      
      Test: cssom/cssimportrule-media.html
      
      * css/CSSImportRule.cpp:
      (WebCore::CSSImportRule::cssText):
      Don't append extra whitespace if mediaText is empty.
      
      LayoutTests:
      
      Test (from CSS WG) that checks serializion of CSSImportRule.cssText.
      
      * http/tests/css/shared-stylesheet-mutation-expected.txt:
      * http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt:
      Fix expected output to match removal of extraneous space.
      
      * cssom/cssimportrule-media-expected.txt: Added.
      * cssom/cssimportrule-media.html: Added.
      * cssom/resources/import.css: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      759404aa
    • commit-queue@webkit.org's avatar
      [CMAKE] Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMakeLists.txt · 371825cd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100681
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-29
      Reviewed by Anders Carlsson.
      
      Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMake since
      it is needed by plugins/npruntime/npruntime-calls-with-null-npp.html
      layout test.
      
      * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132831 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      371825cd
    • msaboff@apple.com's avatar
      String::split(UChar, Vector<String>&) shouldn't create a temporary String · b5a613c4
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100578
      
      Reviewed by Anders Carlsson.
      
      Changed split(UChar, Vector<String>&) to call split(UChar, bool, Vector<String>&) instead of creating a
      string and calling the split(String,...) version and moved it to WTFString.h.  Also moved
      split(const String& separator, Vector<String>& result) to WTFString.h.
      
      * wtf/text/WTFString.cpp:
      (WTF::String::split):
      * wtf/text/WTFString.h:
      (WTF::String::split):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132828 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5a613c4
    • zandobersek@gmail.com's avatar
      Unreviewed GTK gardening. · 23cc78e6
      zandobersek@gmail.com authored
      Adding flaky crash expectations for tests that crash after r132699
      if the accessibility object cache is populated.
      
      * platform/gtk/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132827 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      23cc78e6
    • commit-queue@webkit.org's avatar
      [EFL] Skip fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html test case · 9f431fc4
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100687
      
      Unreviewed EFL gardening.
      
      Skip fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html test case
      since it is intrinsically flaky and cannot be fixed.
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-29
      
      * platform/efl/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f431fc4
    • msaboff@apple.com's avatar
      WKStringCopyCFString() should directly use 8 bit Strings data instead of up converting · f8a2f0d0
      msaboff@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100579
      
      Reviewed by Oliver Hunt.
      
      Changed to use CFStringCreateWithBytes() for 8 bit strings using characters8() for an 8 bit argument string.
      Changed the current call to characters16().
      
      * Shared/API/c/cf/WKStringCF.cpp:
      (WKStringCopyCFString):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132825 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8a2f0d0
    • commit-queue@webkit.org's avatar
      webview not redrawn as needed when accelerated compositing is enabled. · 1d885e0d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99109
      
      Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-29
      Reviewed by Martin Robinson.
      
      GL shared display is not in the gtk loop and therefore, its events are
      not captured by gtk. So, we use gdk default instead.
      
      No new tests, covered by existing tests.
      
      * platform/gtk/RedirectedXCompositeWindow.cpp:
      (WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
      (WebCore::RedirectedXCompositeWindow::~RedirectedXCompositeWindow):
      (WebCore::RedirectedXCompositeWindow::resize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d885e0d
    • commit-queue@webkit.org's avatar
      Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac. · b7e62150
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100683
      
      Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-10-29
      Reviewed by Pavel Feldman.
      
      When in compact mode, style the Web Inspector toolbar using the same colors & gradients
      as the Chromium toolbar (Chromium port only).
      
      * src/js/devTools.css:
      (body.compact.platform-mac #toolbar):
      (body.compact.platform-mac.inactive #toolbar):
      (body.platform-mac.inactive #toolbar .toolbar-label):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7e62150
    • allan.jensen@digia.com's avatar
      [Qt] Flaky security tests · e1157d08
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100388
      
      Reviewed by Jocelyn Turcotte.
      
      Tools:
      
      Disable text dumping and load a blank URL to ensure the documentLoader is cleared
      before we start dumping text for the new page. Otherwise messages from the old page
      may end up in the text output of the new test.
      
      This matches what WebKitTestRunner does, and reuses the Qt code for waiting for flag.
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::DumpRenderTree::DumpRenderTree):
      (WebCore::runUntil):
      (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
      (WebCore::DumpRenderTree::finishedResetting):
      (WebCore::DumpRenderTree::dump):
      * DumpRenderTree/qt/DumpRenderTreeQt.h:
      (DumpRenderTree):
      * DumpRenderTree/qt/TestRunnerQt.cpp:
      (TestRunner::resetDumping):
      (TestRunner::reset):
      * DumpRenderTree/qt/TestRunnerQt.h:
      (TestRunner):
      
      LayoutTests:
      
      Unskip no longer flaky tests.
      
      * platform/qt/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132819 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e1157d08
    • zoltan@webkit.org's avatar
      Turn PageLoad tests into simple performancetests, commit #7 (last) · 18f61b34
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99899
      
      Reviewed by Ryosuke Niwa.
      
      We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
      performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
      to their new location and adds html/js wrappers for them.
      
      This is the #7 (last) commit of the whole patch.
      
      * PageLoad: Removed.
      * PageLoad/svg: Removed.
      * PageLoad/svg/LICENSES: Removed.
      * PageLoad/svg/files: Removed.
      * PageLoad/svg/files/33041-Samurai.svg: Removed.
      * PageLoad/svg/files/42450-under the see.svg: Removed.
      * PageLoad/svg/files/world-iso.svg: Removed.
      * PageLoad/svg/svg.pltsuite: Removed.
      * SVG/Samurai.html: Added.
      * SVG/UnderTheSee.html: Added.
      * SVG/WorldIso.html: Added.
      * SVG/resources/LICENSES: Copied from PerformanceTests/PageLoad/svg/LICENSES.
      * SVG/resources/Samurai.svg: Copied from PerformanceTests/PageLoad/svg/files/33041-Samurai.svg.
      * SVG/resources/UnderTheSee.svg: Copied from PerformanceTests/PageLoad/svg/files/42450-under%20the%20see.svg.
      * SVG/resources/WorldIso.svg: Copied from PerformanceTests/PageLoad/svg/files/world-iso.svg.
      * SVG/resources/svg.pltsuite: Copied from PerformanceTests/PageLoad/svg/svg.pltsuite.
      * Skipped: Rename the files on the skipped list also.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132815 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18f61b34
    • pfeldman@chromium.org's avatar
      Web Inspector: bind redo to Ctrl+Y on non-mac platforms · 4ba2844e
      pfeldman@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100685
      
      Reviewed by Vsevolod Vlasov.
      
      * inspector/front-end/DefaultTextEditor.js:
      (WebInspector.DefaultTextEditor.prototype._registerShortcuts):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132813 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ba2844e
    • enrica@apple.com's avatar
      Add ENABLE_USERSELECT_ALL feature flag. · ae9b0990
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100559
      
      Reviewed by Eric Seidel.
      
      Source/JavaScriptCore: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit/mac: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2: 
      
      * Configurations/FeatureDefines.xcconfig:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae9b0990