1. 22 Jun, 2009 11 commits
  2. 21 Jun, 2009 21 commits
    • oliver@apple.com's avatar
      Bug 26594: JSC needs to support Date.toISOString · 09f8e91e
      oliver@apple.com authored
      <https://bugs.webkit.org/show_bug.cgi?id=26594>
      
      Reviewed by Sam Weinig
      
      Add support for Date.toISOString.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      09f8e91e
    • weinig@apple.com's avatar
      WebCore: · 5f4ed313
      weinig@apple.com authored
      2009-06-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Oliver Hunt.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=26596
              Only expose event handler attributes to elements and documents.
      
              Test: fast/dom/event-attribute-availability.html
      
              * dom/Document.idl:
              * dom/Element.idl:
              * dom/Node.cpp:
              * dom/Node.h:
              * dom/Node.idl:
      
      LayoutTests:
      
      2009-06-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Oliver Hunt.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=26596
              Only expose event handler attributes to elements and documents.
      
              * fast/dom/event-attribute-availability-expected.txt: Added.
              * fast/dom/event-attribute-availability.html: Added.
              * fast/dom/resources/event-attribute-availability.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5f4ed313
    • abarth@webkit.org's avatar
      WebCore: · c12acbed
      abarth@webkit.org authored
      2009-06-21  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Adam Barth.
      
              https://bugs.webkit.org/show_bug.cgi?id=26580
              
              Fix to enable XSSAuditor on child windows.
              
              Test: http/tests/security/xssAuditor/link-opens-new-window.html
              
              * page/XSSAuditor.cpp:
              (WebCore::XSSAuditor::XSSAuditor):
              (WebCore::XSSAuditor::isEnabled):
              (WebCore::XSSAuditor::canEvaluate):
              (WebCore::XSSAuditor::canCreateInlineEventListener):
              (WebCore::XSSAuditor::canLoadExternalScriptFromSrc):
              (WebCore::XSSAuditor::canLoadObject):
              * page/XSSAuditor.h: Removed method setXSSAuditorEnabled, and field m_isEnabled. Moved implementation of isEnabled to XSSAuditor.cpp and changed implementation to query Settings.
      
      LayoutTests:
      
      2009-06-21  Daniel Bates  <dbates@intudata.com>
      
              Reviewed by Adam Barth.
              
              Test for https://bugs.webkit.org/show_bug.cgi?id=26580
              
              Tests that XSSAuditor (if enabled) prevents script execution in child window.
      
              * http/tests/security/xssAuditor/link-opens-new-window-expected.txt: Added.
              * http/tests/security/xssAuditor/link-opens-new-window.html: Added.
              * http/tests/security/xssAuditor/resources/echo-intertag-and-notify.php: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c12acbed
    • mitz@apple.com's avatar
      Rubber-stamped by Mark Rowe. · 7da68d22
      mitz@apple.com authored
              - make repaint tests more reliable when run in Safari
      
              * fast/repaint/resources/repaint.js:
              (runRepaintTest): Increased the timeout from 0 to 100, to ensure that
              painting occurs once before repaintTest() is called.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7da68d22
    • mrowe@apple.com's avatar
      Set a sensible user agent string for the HTTP requests that Sparkle makes... · ee32658e
      mrowe@apple.com authored
      Set a sensible user agent string for the HTTP requests that Sparkle makes (checking for and downloading updates).
      
      Reviewed by Sam Weinig.
      
      * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
      (userAgentStringForSparkle):
      (initializeSparkle):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee32658e
    • oliver@apple.com's avatar
      Fix build by removing dead code. · c72459b2
      oliver@apple.com authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44924 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c72459b2
    • oliver@apple.com's avatar
      Bug 26587: Support JSON.parse · cfe3e969
      oliver@apple.com authored
      <https://bugs.webkit.org/show_bug.cgi?id=26587>
      
      Reviewed by Darin Adler and Cameron Zwarich.
      
      Extend the LiteralParser to support the full strict JSON
      grammar, fix a few places where the grammar was incorrectly
      lenient.   Doesn't yet support the JSON.parse reviver function
      but that does not block the JSON.parse functionality itself.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44923 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfe3e969
    • levin@chromium.org's avatar
      2009-06-21 David Levin <levin@chromium.org> · 80f8179a
      levin@chromium.org authored
              Reviewed by NOBODY (speculative build fix for windows).
      
              Simply removed some whitespace form this file to make windows build wtf and
              hopefully copy the new MessageQueque.h so that WebCore picks it up.
      
              * wtf/Assertions.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44922 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      80f8179a
    • levin@chromium.org's avatar
      2009-06-21 David Levin <levin@chromium.org> · 566f4b8a
      levin@chromium.org authored
              Reviewed by NOBODY.
      
              Speculative windows build fix (idea by Mark Rowe).
      
              * WebCore.vcproj/WebCore.vcproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44921 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      566f4b8a
    • mrowe@apple.com's avatar
      Add a hook to the WebKit launcher application to allow a link on the nightly build start page to · 04542937
      mrowe@apple.com authored
      trigger an update via the built-in software update mechanism.
      
      Reviewed by Sam Weinig.
      
      * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
      * WebKitLauncher/WebKitLauncherURLProtocol.h: Added.
      * WebKitLauncher/WebKitLauncherURLProtocol.m: Added.
      (+[WebKitLauncherURLProtocol load]):
      (+[WebKitLauncherURLProtocol canInitWithRequest:]): Only allow use of the x-webkit-launcher scheme from .webkit.org subdomains.
      (+[WebKitLauncherURLProtocol canonicalRequestForRequest:]):
      (-[WebKitLauncherURLProtocol startLoading]):
      (-[WebKitLauncherURLProtocol stopLoading]):
      (-[WebKitLauncherURLProtocol handleIsWebKitLauncherAvailableJS]): Return a brief JavaScript snippet that can be used to programatically
      determine whether the x-webkit-launcher is available and working.
      (-[WebKitLauncherURLProtocol handleCheckForUpdates]): Trigger a software update on the main thread.
      (-[WebKitLauncherURLProtocol resourceNotFound]): Fail with a generic "File does not exist" error.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44920 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04542937
    • levin@chromium.org's avatar
      2009-06-21 David Levin <levin@chromium.org> · ccc3e5a8
      levin@chromium.org authored
              Reviewed by NOBODY (Speculative gtk build fix).
      
              * GNUmakefile.am:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44919 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccc3e5a8
    • levin@chromium.org's avatar
      2009-06-21 David Levin <levin@chromium.org> · 0255857a
      levin@chromium.org authored
              Reviewed by NOBODY.
      
              Speculative tiger build fix and a windows build fix.
              More fixes may still be in order.
      
              * WebCore.vcproj/WebCoreCommon.vsprops:
              * dom/default/PlatformMessagePortChannel.h:
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44918 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0255857a
    • levin@chromium.org's avatar
      2009-06-21 David Levin <levin@chromium.org> · 7ee2077b
      levin@chromium.org authored
              Reviewed by NOBODY (Speculative tiger build fix).
      
              * dom/default/PlatformMessagePortChannel.h:
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::~MessagePortQueue):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44917 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ee2077b
    • levin@chromium.org's avatar
      WebCore: · a12e4afc
      levin@chromium.org authored
      2009-06-21  Drew Wilson  <atwilson@google.com>
      
              Reviewed by David Levin.
      
              <https://bugs.webkit.org/show_bug.cgi?id=26448>
      
              Added optimized GC for MessagePorts when the entangled port is run by the same thread.
              Fixed bug in isProxyFor() that was not properly throwing an exception when trying to clone the entangled port.
      
              * bindings/js/JSDOMBinding.cpp:
              (WebCore::markActiveObjectsForContext):
              Now marks remotely entangled ports as in-use, in addition to those with pending activity.
              * bindings/js/JSMessagePortCustom.cpp:
              (WebCore::JSMessagePort::mark):
              Now checks if the entangled port is local (run by same thread) and if so mark()s it.
              * dom/MessagePort.cpp:
              (WebCore::MessagePort::postMessage):
              (WebCore::MessagePort::disentangle):
              Removes cloned ports from the ScriptExecutionContext - this allows cloned ports to be GC'd as otherwise they look like remotely entangled ports.
              (WebCore::MessagePort::start):
              (WebCore::MessagePort::locallyEntangledPort):
              Added API for fetching the entangled port if it is run by the same thread
              * dom/MessagePort.h:
              * dom/MessagePortProxyWrapper.h:
              * dom/default/MessagePortProxy.cpp:
              (WebCore::MessagePortProxyWrapper::locallyEntangledPort):
              Added API for fetching the entangled port if it is run by the same thread
              (WebCore::MessagePortProxy::hasPendingActivity):
              Changed definition of hasPendingActivity() to be stricter - only returns true if there are pending messages.
              (WebCore::MessagePortProxy::locallyEntangledPort):
              * dom/default/MessagePortProxy.h:
      
      LayoutTests:
      
      2009-06-21  Drew Wilson  <atwilson@google.com>
      
              Reviewed by David Levin.
      
              <https://bugs.webkit.org/show_bug.cgi?id=26448>
      
              New tests for MessagePort GC cases that weren't previously covered.
      
              * fast/events/message-channel-gc-4-expected.txt: Added.
              Test for case where both MessagePorts are in-transit (cloned) when a GC occurs.
              * fast/events/message-channel-gc-4.html-disabled: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44916 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a12e4afc
    • levin@chromium.org's avatar
      JavaScriptCore: · 3affb89e
      levin@chromium.org authored
      2009-06-21  Drew Wilson  <atwilson@google.com>
      
              Reviewed by David Levin.
      
              <https://bugs.webkit.org/show_bug.cgi?id=25043>
              Added support for multi-threaded MessagePorts.
      
              * wtf/MessageQueue.h:
              (WTF::::appendAndCheckEmpty):
                  Added API to test whether the queue was empty before adding an element.
      
      WebCore:
      
      2009-06-21  Drew Wilson  <atwilson@google.com>
      
              Reviewed by David Levin.
      
              <https://bugs.webkit.org/show_bug.cgi?id=25043>
              Removed obsolete MessagePort.startConversation(), active and onclose APIs.
      
              Refactored MessagePortProxy into MessagePortChannel and a platform-dependent PlatformMessagePortChannel
              implementation. Modified APIs to simplify cross-process implementations by moving the messaging code
              entirely into the platform-dependent proxy.
      
              Created a thread-safe default PlatformMessagePortChannel implementation.
      
              Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how
              cross-thread MessagePorts work.
      
              * GNUMakefile.am:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
                  Added MessagePortChannel/PlatformMessagePortChannel files.
              * bindings/js/JSMessagePortCustom.cpp:
              (WebCore::JSMessagePort::mark):
                  Changed ports to not mark their entangled pair as reachable, per the spec.
              * bindings/v8/custom/V8MessagePortCustom.cpp:
              * dom/MessageChannel.cpp:
              (WebCore::MessageChannel::MessageChannel):
                  Updated to use PlatformMessagePortChannel::createChannel() to entangle the ports.
              * dom/MessagePort.cpp:
              (WebCore::MessagePort::MessagePort):
              (WebCore::MessagePort::~MessagePort):
              (WebCore::MessagePort::postMessage):
              (WebCore::MessagePort::disentangle):
              (WebCore::MessagePort::messageAvailable):
              (WebCore::MessagePort::start):
              (WebCore::MessagePort::close):
              (WebCore::MessagePort::entangle):
              (WebCore::MessagePort::contextDestroyed):
              (WebCore::MessagePort::dispatchMessages):
              (WebCore::MessagePort::setOnmessage):
              (WebCore::MessagePort::hasPendingActivity):
                  Changed these APIs to delegate to new PlatformMessagePortChannel APIs.
              * dom/MessagePort.h:
                  Renamed isQueueOpen() to started().
              * dom/MessagePort.idl:
                  Removed startConversation and onclose.
              * dom/MessagePortProxy.h: Removed.
              * dom/MessagePortChannel.cpp: Added.
              (WebCore::MessagePortChannel::EventData::create):
              (WebCore::MessagePortChannel::EventData::EventData):
              (WebCore::MessagePortChannel::~MessagePortChannel):
              * dom/MessagePortChannel.h: Added.
              (WebCore::MessagePortChannel::EventData::message):
              (WebCore::MessagePortChannel::EventData::channel):
                  Changed EventData to hold a reference to a MessagePortChannel object instead of a MessagePort to enable cross-thread messaging.
              (WebCore::MessagePortChannel::MessagePortChannel):
              (WebCore::MessagePortChannel::create):
              * dom/ScriptExecutionContext.cpp:
              (WebCore:ScriptExecutionContext::dispatchMessagePortEvents):
                  Renamed isQueueOpen() to started().
              * dom/default/PlatformMessagePortChannel.cpp: Added.
              (WebCore::MessagePortChannel::entangleIfOpen):
              (WebCore::MessagePortChannel::disentangle):
              (WebCore::MessagePortChannel::postMessageToRemote):
              (WebCore::MessagePortChannel::tryGetMessageFromRemote):
              (WebCore::MessagePortChannel::close):
              (WebCore::MessagePortChannel::isConnectedTo):
              (WebCore::MessagePortChannel::hasPendingActivity):
              (WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
              (WebCore::PlatformMessagePortChannel::~PlatformMessagePortChannel):
              (WebCore::PlatformMessagePortChannel::createChannel):
              (WebCore::PlatformMessagePortChannel::entangleIfOpen):
              (WebCore::PlatformMessagePortChannel::disentangle):
              (WebCore::PlatformMessagePortChannel::setRemotePort):
              (WebCore::PlatformMessagePortChannel::remotePort):
              (WebCore::PlatformMessagePortChannel::entangledChannel):
              (WebCore::PlatformMessagePortChannel::setEntangledChannel):
              (WebCore::PlatformMessagePortChannel::postMessageToRemote):
              (WebCore::PlatformMessagePortChannel::tryGetMessageFromRemote):
              (WebCore::PlatformMessagePortChannel::isConnectedTo):
              (WebCore::PlatformMessagePortChannel::close):
              (WebCore::PlatformMessagePortChannel::closeInternal):
              (WebCore::PlatformMessagePortChannel::hasPendingActivity):
              * dom/default/PlatformMessagePortChannel.h: Added.
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::create):
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::tryGetMessage):
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::appendAndCheckEmpty):
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::isEmpty):
              (WebCore::PlatformMessagePortChannel::MessagePortQueue::MessagePortQueue):
              * page/DOMWindow.cpp:
              (WebCore::PostMessageTimer::PostMessageTimer):
                  Changed DOMWindow messaging to create the MessageEvent in the target ScriptExecutionContext to match how cross-thread MessagePorts work.
              (WebCore::PostMessageTimer::event):
              (WebCore::DOMWindow::postMessage):
              (WebCore::DOMWindow::postMessageTimerFired):
      
      LayoutTests:
      
      2009-06-21  Drew Wilson  <atwilson@google.com>
      
              Reviewed by David Levin.
      
              <https://bugs.webkit.org/show_bug.cgi?id=25043>
              Updated MessageChannel/MessagePorts tests to reflect latest spec (close event has been removed).
              Added more tests of port cloning.
      
              * fast/events/message-channel-gc-2-expected.txt:
              * fast/events/message-channel-gc-2.html-disabled:
              * fast/events/message-channel-gc-3-expected.txt:
              * fast/events/message-channel-gc-3.html-disabled:
              * fast/events/message-channel-gc-expected.txt:
              * fast/events/message-channel-gc.html-disabled:
              * fast/events/message-port-clone-expected.txt: Added.
              * fast/events/message-port-clone.html-disabled: Added.
              * fast/events/message-port-expected.txt:
              * fast/events/message-port-no-wrapper-expected.txt: Added.
              * fast/events/message-port-onclose-expected.txt: Removed.
              * fast/events/message-port-onclose.html-disabled: Removed.
              * fast/events/message-port.html-disabled:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3affb89e
    • mitz@apple.com's avatar
      WebCore: · 0e2df434
      mitz@apple.com authored
              Reviewed by Sam Weinig.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=15383
                <rdar://problem/5682745> resize: vertical does not restrict to vertical
                resize
      
              Test: fast/css/resize-single-axis.html
      
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::resize): Ignore movement along the non-resizing
              axis.
      
      LayoutTests:
      
              Reviewed by Sam Weinig.
      
              - test for https://bugs.webkit.org/show_bug.cgi?id=15383
                <rdar://problem/5682745> resize: vertical does not restrict to vertical
                resize
      
              * fast/css/resize-single-axis-expected.txt: Added.
              * fast/css/resize-single-axis.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44914 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e2df434
    • weinig@apple.com's avatar
      WebCore: · f23f5741
      weinig@apple.com authored
      2009-06-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Eric Seidel
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=26578
              event.currentTarget for listener registered on window should point to the window object like in Firefox
      
              Test: fast/events/event-trace.html
      
              * dom/Node.cpp:
              (WebCore::Node::dispatchGenericEvent): Make the DOMWindow the currentTarget when events are dispatched
              to it. We previously used the document because DOMWindow was not yet an EventTarget.
      
      LayoutTests:
      
      2009-06-21  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=26578
              event.currentTarget for listener registered on window should point to the window object like in Firefox
      
              * fast/events/event-trace-expected.txt: Added.
              * fast/events/event-trace.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44913 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f23f5741
    • mitz@apple.com's avatar
      WebCore: · c8cb8b8a
      mitz@apple.com authored
              Reviewed by Sam Weinig.
      
              - fix https://bugs.webkit.org/show_bug.cgi?id=9694
                resize value not compared
      
              Test: fast/css/resize-value-compared.html
      
              * rendering/style/StyleRareInheritedData.cpp:
              (WebCore::StyleRareInheritedData::operator==): Compare the resize
              member.
      
      LayoutTests:
      
              Reviewed by Sam Weinig.
      
              - test for https://bugs.webkit.org/show_bug.cgi?id=9694
                resize value not compared
      
              * fast/css/resize-value-compared-expected.txt: Added.
              * fast/css/resize-value-compared.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44912 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8cb8b8a
    • darin@apple.com's avatar
      2009-06-21 Darin Adler <darin@apple.com> · edf21428
      darin@apple.com authored
              * platform/gtk/Skipped: Skip one more test.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44911 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      edf21428
    • darin@apple.com's avatar
      2009-06-20 Darin Adler <darin@apple.com> · 6beb5891
      darin@apple.com authored
              * platform/gtk/Skipped: Skip some new tests.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44910 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6beb5891
    • darin@apple.com's avatar
      2009-06-20 Darin Adler <darin@apple.com> · 6dbcead3
      darin@apple.com authored
              Reviewed by Sam Weinig.
      
              <rdar://problem/6964221> Need more processing of pluginspage.
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44909 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dbcead3
  3. 20 Jun, 2009 8 commits
    • alice.liu@apple.com's avatar
      WebCore: · 3c49db48
      alice.liu@apple.com authored
      2009-06-19  Alice Liu  <alice.liu@apple.com>
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=26568 
              Repro crash animating GIF if previously used in a closed window's back/forward list
              Also filed as <rdar://problem/6978362>
      
              Reviewed by Maciej Stachowiak.
      
              Can't test this bug with an automated layout test since it requires b/f caching 
              * manual-tests/animated-gif-bfcache-crash.html: Added.
              * manual-tests/resources/containsAnimatedGif.html: Added.
      
              Adding checks for hostWindow() since there is no guarantee that the Page is alive
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              (WebCore::ScrollView::contentsToScreen):
              (WebCore::ScrollView::screenToContents):
              (WebCore::ScrollView::wheelEvent):
      
      LayoutTests:
      
      2009-06-19  Alice Liu  <alice.liu@apple.com>
      
              Fix https://bugs.webkit.org/show_bug.cgi?id=26568 
              Repro crash animating GIF if previously used in a closed window's back/forward list
              Also filed as <rdar://problem/6978362>
      
              Reviewed by Maciej Stachowiak.
      
              Adding resource used in WebCore/manual-tests/animated-gif-bfcache-crash.html
              * http/tests/misc/resources/animated-gif-with-offsets.gif: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44908 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3c49db48
    • mrowe@apple.com's avatar
      Roll out the Windows portion of r44905 as it broke the build. · 7d676a48
      mrowe@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44907 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7d676a48
    • weinig@apple.com's avatar
      WebCore: · 46aee689
      weinig@apple.com authored
      2009-06-20  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Adam Barth.
      
              Fix for https://bugs.webkit.org/show_bug.cgi?id=26554
              Shadowing of top and parent
      
              * page/DOMWindow.idl:
      
      LayoutTests:
      
      2009-06-20  Sam Weinig  <sam@webkit.org>
      
              Reviewed by Adam Barth.
      
              Test for https://bugs.webkit.org/show_bug.cgi?id=26554
      
              Test writing to parent and top.
      
              * http/tests/security/cross-frame-access-put-expected.txt:
              * http/tests/security/cross-frame-access-put.html:
              * http/tests/security/resources/cross-frame-iframe-for-put-test.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44906 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      46aee689
    • darin@apple.com's avatar
      WebKit/mac: · 12ff6f52
      darin@apple.com authored
      2009-06-20  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              <rdar://problem/6964221> Need more processing of pluginspage.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
      
      WebKit/win:
      
      2009-06-20  Darin Adler  <darin@apple.com>
      
              Reviewed by Sam Weinig.
      
              <rdar://problem/6964221> Need more processing of pluginspage.
      
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::createPlugin): Check protocolInHTTPFamily.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44905 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      12ff6f52
    • jmalonzo@webkit.org's avatar
      Reviewed by Gustavo Noronha and Xan Lopez. · 8344d832
      jmalonzo@webkit.org authored
              [Gtk] Implement DRT XSS auditor support
              https://bugs.webkit.org/show_bug.cgi?id=26571
      
              * webkit/webkitwebsettings.cpp:
              (webkit_web_settings_class_init):
              (webkit_web_settings_set_property):
              (webkit_web_settings_get_property):
              (webkit_web_settings_copy):
              * webkit/webkitwebview.cpp:
              (webkit_web_view_update_settings):
              (webkit_web_view_settings_notify):
              * DumpRenderTree/gtk/DumpRenderTree.cpp:
              (resetWebViewToConsistentStateBeforeTesting):
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::setXSSAuditorEnabled):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44904 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8344d832
    • jmalonzo@webkit.org's avatar
      2009-06-20 Jan Michael Alonzo <jmalonzo@webkit.org> · e262c982
      jmalonzo@webkit.org authored
              Reviewed by Gustavo Noronha and Xan Lopez.
      
              webkit_web_back_forward_list_add_item() should add a ref for the history item
              https://bugs.webkit.org/show_bug.cgi?id=26517
      
              Add a ref to the WebHistoryItem when it's added to the back
              forward list through webkit_web_back_forward_list_add_item.
              This keeps the history item alive and prevents pywebkitgtk from
              crashing
      
              * tests/testwebbackforwardlist.c:
              (test_webkit_web_history_item_lifetime):
              (test_webkit_web_back_forward_list_order):
              (test_webkit_web_back_forward_list_add_item):
              * webkit/webkitwebbackforwardlist.cpp:
              (webkit_web_back_forward_list_add_item):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44903 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e262c982
    • mrowe@apple.com's avatar
      Fix <https://bugs.webkit.org/show_bug.cgi?id=15106>. · bc157d8b
      mrowe@apple.com authored
      Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none
      
      Reviewed by Dan Bernstein.
      
      We allow selections to begin within an element that has -webkit-user-select: none set,
      unless the element is draggable as dragging should take priority over starting a selection.
      
      Test: editing/selection/user-drag-element-and-user-select-none.html
      
      * dom/Node.cpp:
      (WebCore::Node::canStartSelection):
      
      Test for <https://bugs.webkit.org/show_bug.cgi?id=15106>.
      Bug 15106: REGRESSION: Can't drag text as element when user-select is set to none
      
      * editing/selection/user-drag-element-and-user-select-none-expected.txt: Added.
      * editing/selection/user-drag-element-and-user-select-none.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44902 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc157d8b
    • darin@apple.com's avatar
      WebCore: · e2948901
      darin@apple.com authored
      2009-06-20  Darin Adler  <darin@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
              https://bugs.webkit.org/show_bug.cgi?id=26528
              rdar://problem/6985329
      
              * editing/TextIterator.cpp:
              (WebCore::TextIterator::handleReplacedElement): When entering a text control,
              start at the top of the shadow tree (by calling shadowTreeRootNode). Also
              remove assumption that innerTextElement will never be 0 since RenderTextControl
              doesn't really guarantee this.
      
      LayoutTests:
      
      2009-06-20  Darin Adler  <darin@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Bug 26528: REGRESSION (r44674): Assertion in TextIterator::pushFullyClippedState while counting matches for "a" on apple.com
              https://bugs.webkit.org/show_bug.cgi?id=26528
              rdar://problem/6985329
      
              * editing/selection/find-in-text-control-expected.txt: Updated to expect
              finding text in <input type="text"> and <input type="search">, but not
              in <input type="password">.
      
              * editing/selection/find-in-text-control.html: Added tests for <input>
              elements as well as <textarea> elements. Also tweaked result output
              format to accomodate multiple text nodes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44901 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2948901