1. 27 Jul, 2007 11 commits
  2. 26 Jul, 2007 29 commits
    • ddkilzer's avatar
      Added radar. · 5ca21077
      ddkilzer authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24669 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ca21077
    • ap's avatar
      Reviewed by Oliver. · 4bfa3d5a
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=14733
              Add a logging channel for text input
      
              * Misc/WebKitLogging.h:
              * Misc/WebKitLogging.m:
              (WebKitInitializeLoggingChannelsIfNecessary):
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView validAttributesForMarkedText]):
              (-[WebHTMLView textStorage]):
              (-[WebHTMLView characterIndexForPoint:]):
              (-[WebHTMLView firstRectForCharacterRange:]):
              (-[WebHTMLView selectedRange]):
              (-[WebHTMLView markedRange]):
              (-[WebHTMLView attributedSubstringFromRange:]):
              (-[WebHTMLView hasMarkedText]):
              (-[WebHTMLView unmarkText]):
              (-[WebHTMLView setMarkedText:selectedRange:]):
              (-[WebHTMLView doCommandBySelector:]):
              (-[WebHTMLView insertText:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24668 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bfa3d5a
    • darin's avatar
      * http/tests/security/cross-frame-access-put-expected.txt: · 76ff732a
      darin authored
              Checked in corrected results that match the checked-in test.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24667 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      76ff732a
    • darin's avatar
      - fix Tiger build · 1ea4341c
      darin authored
              * Misc/WebTypesInternal.h: For use inside the library, use NSInteger and
              NSUInteger, just like on Leopard. WebNSInteger and WebNSUInteger are still
              present, but they are used in public and private headers only.
      
              * Carbon/CarbonWindowAdapter.m:
              * Carbon/CarbonWindowFrame.m:
              * DefaultDelegates/WebScriptDebugServer.m:
              * History/WebBackForwardList.mm:
              * Misc/WebDownload.m:
              * Misc/WebSearchableTextView.m:
              * Plugins/WebBaseNetscapePluginView.mm:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              * WebView/WebHTMLView.mm:
              * WebView/WebPDFView.mm:
              * WebView/WebView.mm:
              * WebView/WebViewInternal.h:
              Update all implementation files and internal headers to use NSInteger and
              NSUInteger rather than WebNSInteger and WebNSUInteger.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ea4341c
    • sullivan's avatar
      Reviewed by Kevin Decker · f8d1b24d
      sullivan authored
              
              - fixed <rdar://problem/5362989> Searching a pdf in some modes shows hilights for all instances 
                of the word, even those not on the current page
                
              It turns out that there were three different issues here, all contributing to incorrect display
              of multiple matches for PDF pages in certain display modes. (1) in non-continuous display modes,
              we weren't updating the match rects when the displayed page is changed with page up/down (e.g.);
              (2) the mechanism to update the match rects on scrolling was busted except for the first scroll
              away from 0,0; (3) the PDFKit API returns selection bounds for non-displayed pages in non-continuous
              modes just as if they were the displayed pages. This patch fixes all three issues.
      
              * WebView/WebPDFView.h:
              made ivar name even longer
              
              * WebView/WebPDFView.mm:
              (-[WebPDFView setPDFDocument:]):
              updated for ivar name change
              (-[WebPDFView viewDidMoveToWindow]):
              observe page-change notifications as well as the others; this is necessary because in the
              non-continuous modes the view can be completely updated without any scrolling involved (problem 1)
              (-[WebPDFView viewWillMoveToWindow:]):
              stop observing page-change notifications
              (-[WebPDFView rectsForTextMatches]):
              skip any pages that aren't visible; this avoids treating matches on non-displayed non-continous
              modes as if they were on the displayed page (problem 3)
              (-[WebPDFView _PDFDocumentViewMightHaveScrolled:]):
              after checking whether scroll position has changed since we last checked it, remember the new
              one (d'oh!) (problem 2)
      
              (-[WebPDFView _scaleOrDisplayModeOrPageChanged:]):
              renamed to include page changes
              
              (-[WebPDFView _visiblePDFPages]):
              new method, returns the set of pages that are at least partly visible
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24665 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8d1b24d
    • tristan's avatar
      Reviewed by Anders Carlsson. · 857ba4fd
      tristan authored
              
              <rdar://problem/5350019> REGRESSION: Pages on milliyet.com are added to Back list when visited, causing Back button to just reload
      
              * http/tests/navigation/lockedhistory-iframe-expected.txt: Added.
              * http/tests/navigation/lockedhistory-iframe.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      857ba4fd
    • tristan's avatar
      Reviewed by Anders Carlsson. · ef173ccb
      tristan authored
              <rdar://problem/5350019> REGRESSION: Pages on milliyet.com are added to Back list when visited, causing Back button to just reload
      
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
              If the policy action is FrameLoadTypeRedirectLockHistory, don't add the frame load url to the history.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef173ccb
    • hyatt's avatar
      · 6d63d442
      hyatt authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6d63d442
    • andersca's avatar
      Reviewed by Geoff. · dfbbc17b
      andersca authored
              Add a FIXME about caching pages with plug-ins that have outstanding NPObjects.
              
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::canCachePage):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24661 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dfbbc17b
    • kmccullo's avatar
      Reviewed by Sam. · 8ea01da3
      kmccullo authored
              - Updated results as they are affecte by my previous checkin.
      
              * http/tests/security/cross-frame-access-put-expected.txt:
              * http/tests/security/resources/cross-frame-iframe-for-put-test.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24660 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ea01da3
    • hyatt's avatar
      FIx for <rdar://problem/5289721> CrashTracer: [REGRESSION] 2658... · b85bc581
      hyatt authored
              FIx for <rdar://problem/5289721> CrashTracer: [REGRESSION] 2658 crashes in Safari at com.apple.WebCore: WebCore::RenderInline::height const + 16
      
              Adding a null check for now and an assert.  We don't know how/why this
              bug happens, but hopefully the assert will help people to reproduce.
      
              Reviewed by kevin
      
              * rendering/RenderInline.cpp:
              (WebCore::RenderInline::height):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b85bc581
    • andersca's avatar
      Reviewed by Oliver. · 83197933
      andersca authored
              <rdar://problem/5362783>
              In Mail, a crash occurs at WTF::fastMalloc() when attempting to create a new HTML message from http://nytimes.com/
              
              If the cache is disabled and there is already a resource with the given URL, return it instead of creating a new one.
              
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::requestResource):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24658 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83197933
    • adele's avatar
      Reviewed by Geoff. · e6047756
      adele authored
              Build fix.
      
              * platform/network/cf/ResourceRequest.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24657 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6047756
    • kmccullo's avatar
      Reviewed by. · 97121859
      kmccullo authored
              - Fixed bot breakage.
      
              * fast/dom/Window/window-resize.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24656 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      97121859
    • andersca's avatar
      Reviewed by John Sullivan. · b260e3ca
      andersca authored
              <rdar://problem/5349389> 
              Some frame load delegate methods not called when loading a page from the BF cache
              
              These calls were moved to FrameLoader::begin, which is never called for pages loaded
              from the BF cache. This happened in revision 24490.
               
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::transitionToCommitted):
              Call delegate methods if the load is from the BF cache.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24655 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b260e3ca
    • kmccullo's avatar
      LayoutTests: · 231507bc
      kmccullo authored
              Reviewed by Darin, Geoff and Sam.
      
              - <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
      
              - Tests to ensure we resize/move the window out of bounds correctly.
      
              * fast/dom/Window/window-resize-expected.txt: Added.
              * fast/dom/Window/window-resize.html: Added.
              * mac/leopard/Skipped:
      
      WebCore:
      
              Reviewed by Darin, Geoff and Sam.
      
              - <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
              - We now better match the behavior of other browsers.
      
              * bindings/js/kjs_window.cpp:
              (KJS::constrainToVisible):
              (KJS::WindowFunc::callAsFunction):
      
      WebKitTools:
      
              Reviewed by Darin, Geoff, Sam.
      
              - <rdar://problem/5150461> Resizing the window larger than the screen causes no resize.
      
              - Added delegate methods to intercept and fake the frame location so methods like resizeTo and moveTo can change the window location without actually making the window appear on-screen.
      
              * DumpRenderTree/UIDelegate.h:
              * DumpRenderTree/UIDelegate.m:
              (-[UIDelegate webView:setFrame:]):
              (-[UIDelegate webViewFrame:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      231507bc
    • kmccullo's avatar
      Reviewed by Brady. · d33666bc
      kmccullo authored
              - Added leopard-specific results for <rdar://problem/5228256> REGRESSION(Leopard): layout test failures: security/block-test
      
              * mac/leopard/security: Added.
              * mac/leopard/security/block-test-expected.txt: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d33666bc
    • tristan's avatar
      Reviewed by Adele Peterson. · 0dfff97f
      tristan authored
              
              <rdar://problem/5359921> WebCore should maintain a dirty flag for confirmation on unsaved changes
      
              * bindings/objc/DOMHTML.mm:
              (-[DOMHTMLInputElement _isUserEdited]):
              (-[DOMHTMLTextAreaElement _isUserEdited]):
              Renamed _isEdited to _isUserEdited since the functionality is now different
              
              * bindings/objc/DOMPrivate.h:
              Renamed _isEdited to _isUserEdited.
              
              * rendering/RenderTextControl.cpp:
              (WebCore::RenderTextControl::RenderTextControl):
              Defaulted m_userEdited to false
              
              (WebCore::RenderTextControl::updateFromElement):
              Set m_userEdited to false, since the change wasn't triggered first by an edit
              
              (WebCore::RenderTextControl::subtreeHasChanged):
              Set m_userEdited to true, since it has been touched by the user
              
              * rendering/RenderTextControl.h:
              (WebCore::RenderTextControl::isUserEdited):
              (WebCore::RenderTextControl::setUserEdited):
              Added two new methods to set/return the userEdited boolean value.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dfff97f
    • ggaren's avatar
      Reviewed by Beth Dakin. · faf1a371
      ggaren authored
              Fixed NULL-dereference crash seen on buildbot.
              
              No bug filed because this is a part of <rdar://problem/5241167>.
      
              * history/PageCache.h:
              (WebCore::PageCache::get): NULL-check HistoryItems passed to get()
              and remove(), to match the old semantics of HashMap. For clarity,
              ASSERT that add() is not called with NULL arguments.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      faf1a371
    • kmccullo's avatar
      Reviewed by Adam. · 3a4a34e7
      kmccullo authored
              - Lars wanted this check for Qt but it breaks platform specific layout tests.
      
              * Scripts/run-webkit-tests:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3a4a34e7
    • andersca's avatar
      Reviewed by Oliver Hunt. · 84806efe
      andersca authored
              <rdar://problem/5361106> Crash in user style sheet when loading webpage
      
              Null check m_frame.
              
              * dom/Document.cpp:
              (WebCore::Document::stylesheetLoaded):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      84806efe
    • ggaren's avatar
      Used `svn merge -r24646:24645' to revert project changes I accidentally · 9148139a
      ggaren authored
              checked in.
      
              * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24647 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9148139a
    • ggaren's avatar
      Reviewed by Darin Adler. · 4ae498b9
      ggaren authored
              Fixed <rdar://problem/5241167> REGRESSION: PLT 1% slower due to r21793 
              (global page cache cap)
              
              I just measured a .1%-.2% regression in PLT average, but a .4% win in 
              PLT fastest run, so I think this regression is licked.
      
              Surprisingly, the combination of wtf data structures I originally used 
              for PageCache turned out to be too slow, so I reworked PageCache to use
              a hand-crafted linked list for LRU tracking (instead of ListHashSet), 
              to store its CachedPages in the HistoryItems to which they corresponded 
              (instead of using a HashMap), and to ref/deref HistoryItems manually
              (instead of using RefPtr, which would ref once for every reference in 
              the linked list).
      
              * history/HistoryItem.h: Added data members for PageCache data. Made
              PageCache a friend so it could access them. Ideally (from an 
              encapsulation perspective), we would store this data an independent 
              structure, but that's just too slow.
      
              * history/PageCache.cpp: Added a hand-crafted linked list for LRU 
              tracking.
              (WebCore::PageCache::PageCache):
              (WebCore::PageCache::add): Adopt the HistoryItem's ref when it's added.
              (WebCore::PageCache::remove): deref() the Historyitem when it's 
              removed.
              (WebCore::PageCache::prune):
              (WebCore::PageCache::addToLRUList):
              (WebCore::PageCache::removeFromLRUList):
      
              * history/PageCache.h:
              (WebCore::PageCache::get): Inlined just in case.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ae498b9
    • andersca's avatar
      Reviewed by John Sullivan. · eb09b5e4
      andersca authored
              Stop the test from dumping load callbacks as they differ on Tiger and Leopard. 
              This is done by removing the call to dumpResourceLoadCallbacks and moving the test away
              from the "loading" directory.
              
              * http/tests/loading/cached-scripts-expected.txt: Removed.
              * http/tests/loading/cached-scripts.html: Removed.
              * http/tests/loading/resources/cached-scripts-subframe.html: Removed.
              * http/tests/misc/cached-scripts-expected.txt: Copied from http/tests/loading/cached-scripts-expected.txt.
              * http/tests/misc/cached-scripts.html: Copied from http/tests/loading/cached-scripts.html.
              * http/tests/misc/resources/cached-scripts-subframe.html: Copied from http/tests/loading/resources/cached-scripts-subframe.html.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb09b5e4
    • treat's avatar
      Launch the context menu in the right place. · 4fcbc118
      treat authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4fcbc118
    • treat's avatar
      Patch from Qing Zhao that adds a signal for history notification. · 194bc8ec
      treat authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      194bc8ec
    • hausmann's avatar
      Use QMAKE_LIBDIR instead of QMAKE_LFLAGS to specify the library search path... · e4840e62
      hausmann authored
      Use QMAKE_LIBDIR instead of QMAKE_LFLAGS to specify the library search path for QtWebKit, as the former is portable and correctly transformed to /LIBPATH: with msvc for example.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4840e62
    • hausmann's avatar
      Ensure QtLauncher and DumpRenderTree are linked against the uninstalled... · 17680239
      hausmann authored
      Ensure QtLauncher and DumpRenderTree are linked against the uninstalled QtWebKit library by making sure $$OUTPUT_DIR/lib appears before $QTDIR/lib in the library search path and rpath.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17680239
    • mjs's avatar
      - grammar fix pointed out by Mitz. · 1193f15e
      mjs authored
              * projects/goals.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@24639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1193f15e