Commits · b6a0aceaece3f4a857d4f0d49e0632a7a19214e2 · App_Technologies / webkit

28 Mar, 2007 10 commits

Not reviewed - fix typo in gdk build. · b6a0acea

kjk authored Mar 29, 2007

        * platform/gdk/ScrollViewGdk.cpp:
        (WebCore::ScrollView::contentsToWindow):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b6a0acea

LayoutTests: · 14590a57

mjs authored Mar 29, 2007

        Reviewed by Darin.
        
        - <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)

        * fast/overflow/scrollRevealButton-expected.checksum:
        * fast/overflow/scrollRevealButton-expected.png:
        * fast/overflow/scrollRevealButton-expected.txt:

WebCore:

        Reviewed by Darin.
        
        - fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
                
        Handle scrolling external scrollviews around the webview during
        autoscroll or when scrolling into view.
        
        This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollRectIntoViewRecursively):
        * page/FrameView.h:
        * platform/ScrollView.h:
        * platform/gdk/ScrollViewGdk.cpp:
        (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
        (WebCore::ScrollView::scrollRectIntoViewRecursively):
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::visibleContentRect):
        (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
        (WebCore::ScrollView::scrollRectIntoViewRecursively):
        (WebCore::ScrollView::updateContents):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
        (WebCore::ScrollView::scrollRectIntoViewRecursively):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::ScrollView::scrollRectIntoViewRecursively):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14590a57

Reviewed by Brady. · 1d3bb180

adele authored Mar 28, 2007

        Update to last fix.

        * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK.
        * WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
        Added check to only use the VitalSource workaround if the app is not linked on or after
        the defined WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK version number.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1d3bb180

Reviewed and landed by Darin · 993602c1

darin authored Mar 28, 2007

        Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.
        http://bugs.webkit.org/show_bug.cgi?id=13138

        * platform/StringImpl.cpp:
        (WebCore::StringImpl::isLower):
        (WebCore::StringImpl::lower):
        (WebCore::StringImpl::equalIgnoringCase):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

993602c1

Reviewed by Hyatt. · 60c2cceb

antti authored Mar 28, 2007

        Fix <rdar://problem/5092653>
        REGRESSION: Image decoding making scrolling slow
        
        If decoder gave back a null frame (which I think happens regularly if you don't have full frame 
        data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
        led to massive growth in calculated image size and eventually made cache prune constantly. 
        
        No test, I don't know how to make one for this.

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::cacheFrame):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

60c2cceb

WebCore: · cc025d83

adele authored Mar 28, 2007

        Reviewed by Kevin M.

        WebCore part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

        * page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
        Convert return value to a string.  This matches the behavior in Safari 2.0.

WebKit:

        Reviewed by Kevin M.

        WebKit part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

        Added an app specific workaround for VitalSource Bookshelf that strips "return" from the beginning of their script strings.  We used to allow this
        but now we throw a JavaScript exception for return statements that aren't in functions.

        Filed this evangelism bug so we can notify VitalSource of the problem:
        <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString

        * WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

cc025d83

Reviewed by Darin. · 16c9b5f7

ap authored Mar 28, 2007

        http://bugs.webkit.org/show_bug.cgi?id=13190
        XPath incorrectly handles namespaces on attributes

WebCore:
        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but 
        measurable performance improvement for bug 13021.
        (WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.

        * xml/XPathStep.h:
        (WebCore::XPath::Step::NodeTest::NodeTest):
        (WebCore::XPath::Step::NodeTest::namespaceURI):
        (WebCore::XPath::Step::nodeTest):
        (WebCore::XPath::Step::setNodeTest):
        Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).

        * xml/XPathGrammar.y:
        * xml/XPathPath.cpp:
        (WebCore::XPath::LocationPath::optimizeStepPair):
        Accounted for the above change.

LayoutTests:
        * fast/xpath/attr-namespace-expected.txt: Added.
        * fast/xpath/attr-namespace.html: Added.

        * fast/xpath/xpath-namespaces-expected.txt:
        * fast/xpath/xpath-namespaces.html:
        Cleaned up; added a couple more cases (which passed anyway, but weren't tested for).



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16c9b5f7

Update libWebKitSystemInterface, previous version was out of date. · 6ef858f4

antti authored Mar 28, 2007

        * libWebKitSystemInterface.a:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6ef858f4

2007-03-28 Oliver Hunt <oliver@apple.com> · 1c0320b6

oliver authored Mar 28, 2007

        rs=Hyatt.

        Rollout local changes :-/

        * loader/Cache.cpp:
        (WebCore::Cache::pruneAllResources):
        (WebCore::Cache::remove):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1c0320b6

2007-03-28 Oliver Hunt <oliver@apple.com> · 97c1d600

oliver authored Mar 28, 2007

        Reviewed by Hyatt.

        Roll out r20511 due to incredible badness

        * loader/Cache.cpp:
        (WebCore::Cache::pruneAllResources):
        (WebCore::Cache::remove):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

97c1d600

27 Mar, 2007 20 commits

* svg/hixie/text/003-expected.txt: Updated results for this one test that now has · 2a254a04

darin authored Mar 28, 2007

different results due to the painting Adele added to DumpRenderTree. Long term,
we just have to fix SVG so that painting doesn't cause changes to the render tree!

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2a254a04

2007-03-27 Oliver Hunt <oliver@apple.com> · 798912f8

oliver authored Mar 28, 2007

        Reviewed by Adam.

        Don't enforce text-selection drag delay when we are
        going to drag an image anyway.

        Fixes rdar://problem/4668935

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleDrag):
Layout tests:
        Test to ensure there is no delay forced when dragging a selected image

        * editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum: Added.
        * editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
        * editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
        * editing/pasteboard/drag-selected-image-to-contenteditable.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

798912f8

JavaScriptCore: · d74e433f

andersca authored Mar 27, 2007

        Reviewed by Geoff.

        * bindings/NP_jsobject.cpp:
        (_NPN_InvokeDefault):
        Call JSObject:call for native JavaScript objects.

LayoutTests:

        Reviewed by Geoff.

        Add NPN_InvokeDefault test.
        
        * plugins/netscape-invoke-default-expected.txt: Added.
        * plugins/netscape-invoke-default.html: Added.

WebKitTools:

        Reviewed by Geoff.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
        (pluginInvoke):
        Add new function which takes a function and calls it using NPN_InvokeDefault.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

d74e433f

Build fix · 7eaa01a4

justing authored Mar 27, 2007

        
        * editing/markup.cpp:
        (WebCore::startMarkup):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7eaa01a4

LayoutTests: · 7d3dbfed

justing authored Mar 27, 2007

Reviewed by darin

<rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family

Demonstrates the bug fixed:
* editing/style/5091898-expected.checksum: Added.
* editing/style/5091898-expected.png: Added.
* editing/style/5091898-expected.txt: Added.
* editing/style/5091898.html: Added.
Demonstrates a related bug fixed (deleting
the line break before a paragraph could remove
its underlining):
* editing/deleting/5091898-expected.checksum: Added.
* editing/deleting/5091898-expected.png: Added.
* editing/deleting/5091898-expected.txt: Added.
* editing/deleting/5091898.html: Added.
Demonstrates that a link now (correctly) exists,
instead of just underlined text:
* editing/pasteboard/4840662-expected.txt:

WebCore:

Reviewed by darin

<rdar://problem/5091898> REGRESSION: GMail Editor: A line of underlined text copied with Select All pastes with wrong font family

createMarkup skipped elements if they were blocks
when called from moveParagraphs (because that function
must receive only inline content). This patch adds
code to inline these blocks instead of skipping them
so that we don't lose any of the style that they
contribute to the copied markup.

* editing/markup.cpp:
(WebCore::startMarkup): Add an inlineBlocks option.
Make sure to overwrite display:block coming from
a style sheet or the inline style declaration.
(WebCore::createMarkup): Don't refuse to include a
specialCommonAncestor that's a block if we were asked
to include only inline content, since we can now inline
block elements in startMarkup.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7d3dbfed

Oops- my comment was missing a word. · 97ab9364

adele authored Mar 27, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

97ab9364

Adding comment. · ad634f59

adele authored Mar 27, 2007

        * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ad634f59

Fix svg tests by calling displayIfNeeded. · 37405f5e

adele authored Mar 27, 2007

        * DumpRenderTree/DumpRenderTree.m:
        (-[WaitUntilDoneDelegate webView:didFinishLoadForFrame:]):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

37405f5e

Reviewed by Tim · 93cf3a55

sullivan authored Mar 27, 2007

        
        - fixed <rdar://problem/5092556> Default UA spoofing is always off until explicitly toggled

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        initialize the cached value of _private->useSiteSpecificSpoofing here; formerly it would not
        be initialized correctly in the common case of WebViews that use [WebPreferences standardPreferences]



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

93cf3a55

Reviewed by Hyatt. · 7c2f10dc

adele authored Mar 27, 2007

        Fix for <rdar://problem/5026141> REGRESSION: Aperture Viewer Flashes when switching from Index Page to Detail page in Web Gallery

        This disables the paint that occurs after WebCore finishes loading the document.  We should reenable this when we
        move the dispatchDidFinishLoad delegate callback to happen around the same time as the JS onload call.  See <rdar://problem/5092361>.

        * dom/Document.cpp: (WebCore::Document::implicitClose):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7c2f10dc

LayoutTests: · dcdb2794

justing authored Mar 27, 2007

        Reviewed by darin
        
        <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
        <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
        <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
        <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

        * editing/pasteboard/5065605-expected.checksum: Added.
        * editing/pasteboard/5065605-expected.png: Added.
        * editing/pasteboard/5065605-expected.txt: Added.
        * editing/pasteboard/5065605.html: Added.
        * editing/style/4916887-expected.checksum: Added.
        * editing/style/4916887-expected.png: Added.
        * editing/style/4916887-expected.txt: Added.
        * editing/style/4916887.html: Added.
        * editing/style/5065910-expected.checksum: Added.
        * editing/style/5065910-expected.png: Added.
        * editing/style/5065910-expected.txt: Added.
        * editing/style/5065910.html: Added.
        * editing/style/5084241-expected.checksum: Added.
        * editing/style/5084241-expected.png: Added.
        * editing/style/5084241-expected.txt: Added.
        * editing/style/5084241.html: Added.

WebCore:

        Reviewed by darin
        
        <rdar://problem/5065910> REGRESSION: In Mail and GMail, Can't apply color to pasted line of text
        <rdar://problem/5084241> After deleting a paragraph of colored text, can't change text color
        <rdar://problem/5065605> REGRESSION: Text copied with Select All + Copy loses color on Paste
        <rdar://problem/4916887> GMAIL: Can't apply color to text once it becomes indented

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
        If a node's text fill color is invalid, then its children use 
        their font-color as their text fill color (they don't inherit 
        it).  Likewise for stroke color.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

dcdb2794

* platform/ScrollBar.h: · c3c0159f

andersca authored Mar 27, 2007

        Use wtf/MathExtras.h instead of math.h



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c3c0159f

2007-03-27 Mark Rowe <mrowe@apple.com> · 68cd801b

bdash authored Mar 27, 2007

        Reviewed by Dave Harrison.

        * Configurations/WebKit.xcconfig: Include UMBRELLA_FRAMEWORKS_DIR in framework search path.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

68cd801b

Fix the build · ad1986b4

zack authored Mar 27, 2007


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ad1986b4

2007-03-27 Oliver Hunt <oliver@apple.com> · 93990f86

oliver authored Mar 27, 2007

        Reviewed by Maciej.

        The WebArchiver needs all the subresources of a document to be accessible
        through the DocLoader, so we can't remove a CachedResource simultaneously
        from the global Cache and all DocLoaders, just because it needs to be 
        reloaded in one.

        Fixes rdar://problem/5044366

        * loader/Cache.cpp:
        (WebCore::Cache::remove):
           Don't evict the resource from all DocLoaders
        * manual-tests/test-iframes-loading-the-same-resource.html: Added.
           Alas it wasn't possible to make a nice layout test, even this manual test
           is not entirely deterministic



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

93990f86

2007-03-27 Mark Rowe <mrowe@apple.com> · 0b93c7ef

bdash authored Mar 27, 2007

        Build fix.

        * platform/GlyphBuffer.h:
        (WebCore::GlyphBuffer::clear):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0b93c7ef

Fix the rendering crashes due to triggered · e44b3300

zack authored Mar 27, 2007

asserts and improve a bit the layout scheduling in the
Qt port


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e44b3300

Add support for glyph offsets to the GlyphBuffer. · 701900a4

hyatt authored Mar 27, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

701900a4

Keep buildbot happy. · 4e73c473

antti authored Mar 27, 2007

        * platform/mac/PlatformScrollBarMac.mm:
        (WebCore::PlatformScrollbar::scrollbarHit):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4e73c473

WebCore: · 8a4614cf

antti authored Mar 27, 2007

        Reviewed by Darin.
        
        On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
        http://bugs.webkit.org/show_bug.cgi?id=13134
        <rdar://problem/5076249?

        * WebCore.exp:
            Export _wkGetWheelEventDeltas
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleWheelEvent):
            Remove (0, 0) scroll event hack, it is not needed anymore.
            Do per-pixel scrolling for fine grained events.
        * platform/PlatformWheelEvent.h:
        (WebCore::PlatformWheelEvent::isContinuous):
            Add new m_isContinuous boolean to indicate fine grained wheel events.
        * platform/ScrollBar.cpp:
        (WebCore::Scrollbar::Scrollbar):
        (WebCore::Scrollbar::setValue):
        (WebCore::Scrollbar::setSteps):
        (WebCore::Scrollbar::scroll):
        * platform/ScrollBar.h:
        (WebCore::Scrollbar::value):
            Use float to represent current position to support finer grained scrolling.
            Add ScrollByPixel, remove ScrollByWheel (which was same as ScrollByLine anyway)
        * platform/ScrollTypes.h:
        (WebCore::):
        * platform/gdk/WheelEventGdk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
            Initalize m_isContinuous
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
            Add wkGetWheelEventDeltas for getting fine grained wheel events
        * platform/mac/WheelEventMac.mm:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
            Get the wheel deltas using new wkGetWheelEventDeltas interface
        * platform/qt/WheelEventQt.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
            Initalize m_isContinuous
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::calcHeight):
            Pass item height to scrollbar

WebKit:

        Reviewed by Darin.
        
        On Mac, support fine grained wheel events generated by trackpad and Mighty Mouse.
        http://bugs.webkit.org/show_bug.cgi?id=13134
        <rdar://problem/5076249?

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Expose GetWheelEventDeltas()

WebKitLibraries:

        Reviewed by Darin.
        
        Added wkGetWheelEventDeltas

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8a4614cf

26 Mar, 2007 10 commits

Added Radar references. · 0d143db6

ddkilzer authored Mar 27, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0d143db6

fixed up order of ChangeLog entries · 649c8c08

ggaren authored Mar 27, 2007

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

649c8c08

LayoutTests: · 97535e0d

ggaren authored Mar 27, 2007

        Reviewed by Darin Adler.
        
        Layout tests for <rdar://problem/5088234> REGRESSION: Crash occurs at 
        WebCore::Node::createRendererIfNeeded() when changing map views with MS 
        Virtual Earth (http://www.ziprealty.com/)

        * fast/dom/mutation-event-remove-inserted-node-expected.txt: Added.
        * fast/dom/mutation-event-remove-inserted-node.html: Added.
        * fast/dom/script-element-remove-self-expected.txt: Added.
        * fast/dom/script-element-remove-self.html: Added.

WebCore:

        Reviewed by Darin, landed by Anders.

        Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142

        * manual-tests/liveconnect-applet-get-boolean.html: Added.
        * manual-tests/resources/CheckerApplet.class: Added.
        * manual-tests/resources/CheckerApplet.java: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

97535e0d

JavaScriptCore: · 8a518610

andersca authored Mar 27, 2007

        Reviewed by Darin, landed by Anders.

        Fix for: http://bugs.webkit.org/show_bug.cgi?id=13142

        The previous fix http://bugs.webkit.org/show_bug.cgi?id=12636 
        introduced new JNIType to enum in jni_utility.h This is a 
        problem on the Mac as it seems that the JNIType enum is also
        used in the JVM, it is used to specify the return type in
        jni_objc.mm
        Corrected the fix by moving type to the end, and changing
        jni_objc.mm to convert the new type to an old compatible
        type.

        * bindings/jni/jni_objc.mm:
        (KJS::Bindings::dispatchJNICall):
        * bindings/jni/jni_utility.h:

WebCore:

        Reviewed by Darin, landed by Anders.

        Manual test case for http://bugs.webkit.org/show_bug.cgi?id=13142

        * manual-tests/liveconnect-applet-get-boolean.html: Added.
        * manual-tests/resources/CheckerApplet.class: Added.
        * manual-tests/resources/CheckerApplet.java: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8a518610

Reviewed/landed by Adam. · 7f11a584

aroben authored Mar 27, 2007

        Bug 13198: Move build settings from project file to xcconfig file for apollo
        port JSCore
        http://bugs.webkit.org/show_bug.cgi?id=13198

        - Moving build settings from xcode project file to xcconfig files.

        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Debug.xcconfig:
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.Release.xcconfig:
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcconfig:
        * JavaScriptCore.apolloproj/mac/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7f11a584

Rubberstamped by Anders and Maciej aand Geoff (oh my!) · 25b1cbdd

beidson authored Mar 26, 2007

        
        Since CFTypeRef is really void*, a RetainPtr couldn't be used. 
        RefType was "void", which doesn't actually exist as a type.
        Since RefType only existed for operator*(), and since that operator
        doesn't make any sense for RetainPtr, I removed them!

        * kjs/nodes.cpp: Touch this to force a rebuild and (hopefully) help the
          compiler with dependencies
        * wtf/RetainPtr.h: Nuke RefType and operator*()


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

25b1cbdd

LayoutTests: · 56377c9d

darin authored Mar 26, 2007

        Reviewed and landed by Darin.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13194
          REGRESSION: Selection rects are wrong for images in search results from images.google.com

        * fast/replaced/selection-rect-in-table-cell-expected.checksum: Added.
        * fast/replaced/selection-rect-in-table-cell-expected.png: Added.
        * fast/replaced/selection-rect-in-table-cell-expected.txt: Added.
        * fast/replaced/selection-rect-in-table-cell.html: Added.

WebCore:

        Reviewed and landed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13194
          <rdar://problem/5087738>
          REGRESSION: Selection rects are wrong for images in search results from images.google.com

        Test: fast/replaced/selection-rect-in-table-cell.html

        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::selectionRect):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

56377c9d

Reviewed by Dave Harrison · 858f93a1

sullivan authored Mar 26, 2007

        
        - fixed <rdar://problem/4769772> Problem with Find on certain PDF page

        * WebView/WebPDFView.mm:
        (-[WebPDFView _scaledAttributedString:]):
        We were hitting an exception trying to set the font attribute to nil, which was happening because
        the result of -[PDFSelection attributedString] had no attributes. That PDFSelection bug is now
        filed separately, but this works around the exception.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

858f93a1

Touched a file to (hopefully) help the compiler with RetainPtr dependencies. · 9378b0e4

ggaren authored Mar 26, 2007

        * kjs/nodes.cpp:
        (Node::deref):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9378b0e4

Removed now-stale #includes of <assert.h>. · a094a575

ggaren authored Mar 26, 2007

        
        * WebCorePrefix.h:
        * config.h:
        * css/CSSGrammar.y:
        * platform/Arena.cpp:
        * platform/KURL.cpp:
        * platform/SegmentedString.h:
        * rendering/DataRef.h:
        * rendering/RenderArena.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a094a575