1. 30 Mar, 2007 11 commits
    • andersca's avatar
      Reviewed by Geoff. · b5e193f8
      andersca authored
              * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c:
              (testAllocate):
              (testEnumerate):
              Add casts.
              
              * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h:
              Don't use #import, use #include.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5e193f8
    • andersca's avatar
      Reviewed by Alexey. · 9421e408
      andersca authored
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              (pluginInvoke):
              Free the identifier string.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20618 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9421e408
    • justing's avatar
      LayoutTests: · 31d74f38
      justing authored
              Reviewed by john
              
              <rdar://problem/5076323> Only one To Do can be created by a selection in a message
      
              * editing/selection/5076323-1-expected.checksum: Added.
              * editing/selection/5076323-1-expected.txt: Added.
              * editing/selection/5076323-1.html: Added.
              * editing/selection/5076323-2-expected.checksum: Added.
              * editing/selection/5076323-2-expected.txt: Added.
              * editing/selection/5076323-2.html: Added.
              * editing/selection/5076323-3-expected.checksum: Added.
              * editing/selection/5076323-3-expected.txt: Added.
              * editing/selection/5076323-3.html: Added.
      
      WebCore:
      
              Reviewed by john
      
              <rdar://problem/5076323> Only one To Do can be created by a selection in a message
      
              When Mail's ToDoify operation called moveToEndOfDocument: 
              with a selection that started just before a ToDo, we'd 
              move them to the end of the document, not to the end
              of the editable root, because we incorrectly checked
              for the editability of positions before ToDos.  Then Mail
              would refuse to create a ToDo because the selection was 
              outside of the region where they allowed editing.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingRightForward):
              Check the position for editability, not the position's node,
              since there are editable positions of the form [node, offset]
              where node is contenteditable=false.
              Re-use pos.  Nothing that happens after it's created can invalidate
              it or the position and affinity used to create it.
              (WebCore::SelectionController::modifyMovingRightForward): Ditto.
              (WebCore::SelectionController::modifyExtendingLeftBackward): Ditto.
              (WebCore::SelectionController::modifyMovingLeftBackward): Ditto.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintCaret): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20617 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31d74f38
    • beidson's avatar
      Reviewed by Brian Dash · 28c25e3e
      beidson authored
              Fixes an intermittent failure in the port blocking layout test where
              some sort of indeterminacy would change the error code the networking
              layer reported.
      
              * security/block-test-expected.txt:
              * security/block-test.html:  Use 255.255.255.255 instead of a bogus domain name
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20616 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      28c25e3e
    • adele's avatar
      WebCore: · 93bb2c79
      adele authored
              Reviewed by Darin.
      
              Added DeleteWordBackward and DeleteWordForward to execCommand.
      
              * editing/Editor.cpp:
              (WebCore::execDeleteWordBackward):
              (WebCore::execDeleteWordForward):
              (WebCore::CommandEntry::):
      
      WebKit:
      
              Reviewed by Darin.
      
              Call execCommand for deleteWordForward and deleteWordBackward instead of calling
              deleteWithDirection directly.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView deleteWordForward:]):
              (-[WebHTMLView deleteWordBackward:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      93bb2c79
    • andersca's avatar
      Build fix. · 9c881ca6
      andersca authored
              
              * bindings/NP_jsobject.cpp:
              (_NPN_Enumerate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20614 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c881ca6
    • andersca's avatar
      JavaScriptCore: · 77d5e0d0
      andersca authored
              Reviewed by Geoff.
      
              Implement _NPN_Enumerate support.
              
              * JavaScriptCore.exp:
              * bindings/NP_jsobject.cpp:
              (_NPN_Enumerate):
              * bindings/c/c_instance.cpp:
              (KJS::Bindings::CInstance::getPropertyNames):
              * bindings/c/c_instance.h:
              * bindings/npapi.h:
              * bindings/npruntime.h:
              * bindings/npruntime_impl.h:
              * bindings/runtime.h:
              (KJS::Bindings::Instance::getPropertyNames):
              * bindings/runtime_object.cpp:
              (RuntimeObjectImp::getPropertyNames):
              * bindings/runtime_object.h:
              (KJS::RuntimeObjectImp::getInternalInstance):
      
      LayoutTests:
      
              Reviewed by Geoff.
      
              Add enumeration test.
              
              * plugins/netscape-enumerate-expected.txt: Added.
              * plugins/netscape-enumerate.html: Added.
      
      WebKit:
      
              Reviewed by Geoff.
      
              * Plugins/WebNetscapePluginPackage.m:
              (-[WebNetscapePluginPackage load]):
              Initialize pushpopupsenabledstate, poppopupsenabledstate and enumerate.
              
              * Plugins/npapi.m:
              (NPN_PushPopupsEnabledState):
              (NPN_PopPopupsEnabledState):
              Add stubs for these functions.
              
              * Plugins/npfunctions.h:
              Add new methods to NPNetscapeFuncs.
      
      WebKitTools:
      
              Reviewed by Geoff.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
              Add TestObject.c and TestObject.h
              
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              (pluginGetProperty):
              Implement the testObject property.
              
              (pluginInvoke):
              Implement testEnumerate which takes an object and an array and enumerates
              the properties of the object and adds them to the array.
              
              (pluginAllocate):
              Allocate the test object.
              
              (pluginDeallocate):
              Free the test object.
              
              * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.c: Added.
              * DumpRenderTree/TestNetscapePlugIn.subproj/TestObject.h: Added.
              Add a test object with two enumerable properties.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20613 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77d5e0d0
    • hausmann's avatar
      Fix Qt release builds · 1f0bfa23
      hausmann authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20612 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f0bfa23
    • antti's avatar
      Reviewed by bdash. · 70a5f8f9
      antti authored
              Spotted an int that should be float in previous patch.
      
              * platform/Font.cpp:
              (WebCore::WidthIterator::advance):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20611 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      70a5f8f9
    • antti's avatar
      Reviewed by Hyatt. · abdc5919
      antti authored
              Render tree memory savings, part 1
              
              - Eliminate caching of monospace char width from RenderText. This optimization is not needed
                anymore since Font already caches space width (RenderText -4 bytes)
              - Eliminate caching of tab width from RenderBlock. Similary this optimization has become
                obsolete (RenderBlock -4 bytes)
      
              * platform/Font.cpp:
              (WebCore::WidthIterator::advance):
              (WebCore::Font::spaceWidth):
              * platform/Font.h:
              (WebCore::Font::tabWidth):
              * platform/TextStyle.h:
              (WebCore::TextStyle::TextStyle):
              (WebCore::TextStyle::allowTabs):
              * rendering/InlineTextBox.cpp:
              (WebCore::InlineTextBox::selectionRect):
              (WebCore::InlineTextBox::paint):
              (WebCore::InlineTextBox::paintSelection):
              (WebCore::InlineTextBox::paintMarkedTextBackground):
              (WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
              (WebCore::InlineTextBox::paintTextMatchMarker):
              (WebCore::InlineTextBox::offsetForPosition):
              (WebCore::InlineTextBox::positionForOffset):
              * rendering/RenderBlock.cpp:
              (WebCore:::RenderFlow):
              (WebCore::RenderBlock::setStyle):
              * rendering/RenderBlock.h:
              * rendering/RenderObject.cpp:
              * rendering/RenderObject.h:
              * rendering/RenderText.cpp:
              (WebCore::RenderText::RenderText):
              (WebCore::RenderText::setStyle):
              (WebCore::RenderText::widthFromCache):
              (WebCore::RenderText::trimmedMinMaxWidth):
              (WebCore::RenderText::calcMinMaxWidthInternal):
              (WebCore::RenderText::setTextInternal):
              (WebCore::RenderText::width):
              * rendering/RenderText.h:
              (WebCore::RenderText::allowTabs):
              * rendering/bidi.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20610 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abdc5919
    • hyatt's avatar
      Fix (take 2) for bug 4334, flickering when floating elements gain/lose transparency. · 57cac343
      hyatt authored
              Reviewed by mitz
      
              * rendering/RenderBlock.cpp:
              * rendering/RenderBlock.h:
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::setStyle):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20609 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      57cac343
  2. 29 Mar, 2007 20 commits
    • ggaren's avatar
      Layout test for <rdar://problem/5061807>. (This one's for you, Boyscout!) · aa7f2a8b
      ggaren authored
              * fast/frames/remove-frame-with-scrollbars-crash-expected.txt: Added.
              * fast/frames/remove-frame-with-scrollbars-crash.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20608 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa7f2a8b
    • weinig's avatar
      LayoutTests: · 4759b9cd
      weinig authored
              Reviewed by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=13166
                REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table
      
              * fast/tokenizer/write-partial-entity-expected.txt: Added.
              * fast/tokenizer/write-partial-entity.html: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13166
                REGRESSION (2005-10-16 - 2005-10-19): Ampersands showing up in the last column of the Gmail contacts table
      
              Test: fast/tokenizer/write-partial-entity.html
      
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::parseTag): Reordered to avoid resetting the buffer position
              after script execution which can write to the buffer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20607 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4759b9cd
    • justing's avatar
      LayoutTests: · 7ddfeab4
      justing authored
              Reviewed by john
              
              <rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position
      
              Tests for the bug:
              * editing/deleting/5099303-expected.checksum: Added.
              * editing/deleting/5099303-expected.png: Added.
              * editing/deleting/5099303-expected.txt: Added.
              * editing/deleting/5099303.html: Added.
              Tests that extending an editable selection skips non-editable
              content:
              * editing/selection/5099303-expected.checksum: Added.
              * editing/selection/5099303-expected.png: Added.
              * editing/selection/5099303-expected.txt: Added.
              * editing/selection/5099303.html: Added.
      
      WebCore:
      
              Reviewed by john
      
              <rdar://problem/5099303> Deleting after a ToDo puts the caret in the wrong position
              
              We were failing to create the correct selection 
              for DeleteSelectionCommand because the selection extension 
              operations don't skip over non-editable content for editable 
              selections.
      
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingRightForward):
              When extending an editable selection, don't extend into
              non-editable content.
              (WebCore::SelectionController::modifyExtendingLeftBackward):
              Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ddfeab4
    • ggaren's avatar
      LayoutTests: · 2663f9a7
      ggaren authored
              Reviewed by Beth Dakin.
              
              Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in 
              -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
              navigating away from page with DivX movie plug-in (13203)
      
              * plugins/destroy-stream-twice-expected.txt: Added.
              * plugins/destroy-stream-twice.html: Added.
      
      WebKit:
      
              Reviewed by Beth Dakin, reviewed by Maciej Stachowiak.
              
              Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in 
              -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
              navigating away from page with DivX movie plug-in (13203)
              
              Changed LOG_ERROR to LOG so the layout test doesn't produce console spew
              every time you run it.
      
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView destroyStream:reason:]):
      
      WebKitTools:
      
              Reviewed by Beth Dakin.
              
              Layout test for <rdar://problem/5091330> REGRESSION: Repro crash in 
              -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
              navigating away from page with DivX movie plug-in (13203)
              
              Added hasStream property and destroyStream function, used by layout test.
      
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
              (pluginGetProperty):
              (pluginInvoke):
              (pluginAllocate):
              * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h:
              * DumpRenderTree/TestNetscapePlugIn.subproj/main.c:
              (NPP_NewStream):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2663f9a7
    • bdakin's avatar
      Rubber-stamped by Adam. · 4b1e6748
      bdakin authored
              Keep OpenSource building.
      
              * WebKitSystemInterface.h:
              * libWebKitSystemInterface.a:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b1e6748
    • pyeh's avatar
      <rdar://problem/4918397> Exception raise inspecting note contents in the background · aa8721f0
      pyeh authored
              * bridge/mac/WebCoreAXObject.mm:
              (-[WebCoreAXObject subrole]):
              (-[WebCoreAXObject title]):
      	Check that attachment supports the attribute before requesting it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aa8721f0
    • justing's avatar
      I forgot add this expected result in my previous checkin. · 3b45d4ce
      justing authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3b45d4ce
    • bdakin's avatar
      Reviewed by Brady. · 88c795d7
      bdakin authored
              Fix for <rdar://problem/4674537> REGRESSION: Adobe Acrobat 8 - Text 
              blinks when mouse is moved, and is invisible otherwise
      
              -and-
      
              <rdar://problem/4992521> Please adjust WebKit's Acrobat-workaround 
              methodology
      
              The fix for the first bug is to compare against the bundle 
              identifiers for Adobe Reader and the non-Pro Adobe Acrobat in 
              addition to Adobe Acrobat Pro. The fix for the second bug is to 
              check the version number of Acrobat/Reader through 
              WebKitSystemInterface instead of checking which version of WebKit 
              it has been linked against.
      
              * English.lproj/StringsNotToBeLocalized.txt: Two new bundle 
              identifiers.
              * Misc/WebKitVersionChecks.h: Remove Acrobat quirk constant.
              * WebView/WebView.mm:
              (-[WebView _updateWebCoreSettingsFromPreferences:]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88c795d7
    • justing's avatar
      LayoutTests: · b7701503
      justing authored
              Reviewed by john
      
              <rdar://problem/5032066> <Delete> should work between To Dos
      
              Demonstrates the fix:
              * editing/deleting/5032066-expected.checksum: Added.
              * editing/deleting/5032066-expected.png: Added.
              * editing/deleting/5032066-expected.txt: Added.
              * editing/deleting/5032066.html: Added.
              
              Fixed:
              * editing/deleting/delete-block-table-expected.checksum:
              * editing/deleting/delete-block-table-expected.png:
              * editing/deleting/delete-block-table-expected.txt:
              
              shouldInsertNode:... now being called during moves:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
              * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-001-expected.txt:
              * editing/deleting/delete-block-merge-contents-002-expected.txt:
              * editing/deleting/delete-block-merge-contents-003-expected.txt:
              * editing/deleting/delete-block-merge-contents-004-expected.txt:
              * editing/deleting/delete-block-merge-contents-005-expected.txt:
              * editing/deleting/delete-block-merge-contents-006-expected.txt:
              * editing/deleting/delete-block-merge-contents-007-expected.txt:
              * editing/deleting/delete-block-merge-contents-008-expected.txt:
              * editing/deleting/delete-block-merge-contents-009-expected.txt:
              * editing/deleting/delete-block-merge-contents-010-expected.txt:
              * editing/deleting/delete-block-merge-contents-012-expected.txt:
              * editing/deleting/delete-block-merge-contents-013-expected.txt:
              * editing/deleting/delete-block-merge-contents-014-expected.txt:
              * editing/deleting/delete-block-merge-contents-015-expected.txt:
              * editing/deleting/delete-block-merge-contents-016-expected.txt:
              * editing/deleting/delete-block-merge-contents-017-expected.txt:
              * editing/deleting/delete-block-merge-contents-018-expected.txt:
              * editing/deleting/delete-block-merge-contents-019-expected.txt:
              * editing/deleting/delete-block-merge-contents-020-expected.txt:
              * editing/deleting/delete-block-merge-contents-021-expected.txt:
              * editing/deleting/delete-block-merge-contents-022-expected.txt:
              * editing/deleting/delete-br-010-expected.txt:
              * editing/deleting/delete-line-002-expected.txt:
              * editing/deleting/delete-line-004-expected.txt:
              * editing/deleting/delete-line-006-expected.txt:
              * editing/deleting/delete-line-007-expected.txt:
              * editing/deleting/delete-line-008-expected.txt:
              * editing/deleting/delete-line-011-expected.txt:
              * editing/deleting/delete-line-012-expected.txt:
              * editing/deleting/delete-listitem-001-expected.txt:
              * editing/deleting/delete-to-end-of-paragraph-expected.txt:
              * editing/deleting/merge-different-styles-expected.txt:
              * editing/deleting/merge-no-br-expected.txt:
              * editing/deleting/pruning-after-merge-1-expected.txt:
              * editing/deleting/pruning-after-merge-2-expected.txt:
              * editing/execCommand/create-list-from-range-selection-expected.txt:
              * editing/execCommand/create-list-with-hr-expected.txt:
              * editing/execCommand/format-block-expected.txt:
              * editing/execCommand/format-block-from-range-selection-expected.txt:
              * editing/execCommand/format-block-with-braces-expected.txt:
              * editing/execCommand/format-block-with-trailing-br-expected.txt:
              * editing/execCommand/indent-list-item-expected.txt:
              * editing/execCommand/indent-selection-expected.txt:
              * editing/execCommand/insert-list-and-stitch-expected.txt:
              * editing/execCommand/insert-list-with-id-expected.txt:
              * editing/execCommand/nsresponder-indent-expected.txt:
              * editing/execCommand/outdent-selection-expected.txt:
              * editing/execCommand/queryCommandState-01-expected.txt:
              * editing/execCommand/remove-list-1-expected.txt:
              * editing/execCommand/remove-list-from-range-selection-expected.txt:
              * editing/execCommand/remove-list-item-1-expected.txt:
              * editing/execCommand/remove-list-items-expected.txt:
              * editing/execCommand/switch-list-type-expected.txt:
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/inserting/insert-div-026-expected.txt:
              * editing/inserting/multiple-lines-selected-expected.txt:
              * editing/inserting/return-key-with-selection-001-expected.txt:
              * editing/inserting/return-key-with-selection-002-expected.txt:
              * editing/pasteboard/4076267-2-expected.txt:
              * editing/pasteboard/4700297-expected.txt:
              * editing/pasteboard/8145-3-expected.txt:
              * editing/pasteboard/display-block-on-spans-expected.txt:
              * editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
              * editing/pasteboard/interchange-newline-1-expected.txt:
              * editing/pasteboard/interchange-newline-2-expected.txt:
              * editing/pasteboard/merge-after-delete-1-expected.txt:
              * editing/pasteboard/merge-after-delete-2-expected.txt:
              * editing/pasteboard/merge-after-delete-expected.txt:
              * editing/pasteboard/merge-end-1-expected.txt:
              * editing/pasteboard/merge-end-2-expected.txt:
              * editing/pasteboard/merge-end-3-expected.txt:
              * editing/pasteboard/merge-end-4-expected.txt:
              * editing/pasteboard/merge-end-5-expected.txt:
              * editing/pasteboard/merge-end-blockquote-expected.txt:
              * editing/pasteboard/merge-end-borders-expected.txt:
              * editing/pasteboard/merge-end-list-expected.txt:
              * editing/pasteboard/merge-end-table-expected.txt:
              * editing/pasteboard/paste-line-endings-007-expected.txt:
              * editing/pasteboard/paste-line-endings-008-expected.txt:
              * editing/pasteboard/paste-line-endings-009-expected.txt:
              * editing/pasteboard/paste-match-style-001-expected.txt:
              * editing/pasteboard/paste-text-002-expected.txt:
              * editing/pasteboard/paste-text-003-expected.txt:
              * editing/pasteboard/paste-text-004-expected.txt:
              * editing/pasteboard/paste-text-005-expected.txt:
              * editing/pasteboard/paste-text-006-expected.txt:
              * editing/pasteboard/paste-text-008-expected.txt:
              * editing/pasteboard/paste-text-009-expected.txt:
              * editing/pasteboard/paste-text-010-expected.txt:
              * editing/pasteboard/smart-paste-001-expected.txt:
              * editing/pasteboard/smart-paste-002-expected.txt:
              * editing/pasteboard/smart-paste-003-expected.txt:
              * editing/pasteboard/smart-paste-004-expected.txt:
              * editing/pasteboard/smart-paste-005-expected.txt:
              * editing/pasteboard/smart-paste-006-expected.txt:
              * editing/pasteboard/smart-paste-007-expected.txt:
              * editing/pasteboard/smart-paste-008-expected.txt:
              * editing/style/create-block-for-style-001-expected.txt:
              * editing/style/create-block-for-style-002-expected.txt:
              * editing/style/create-block-for-style-003-expected.txt:
              * editing/style/create-block-for-style-004-expected.txt:
              * editing/style/create-block-for-style-007-expected.txt:
              * editing/style/create-block-for-style-009-expected.txt:
              * editing/style/create-block-for-style-010-expected.txt:
              * editing/style/create-block-for-style-011-expected.txt:
              * editing/style/create-block-for-style-012-expected.txt:
              * editing/style/create-block-for-style-013-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
              * editing/style/style-boundary-005-expected.txt:
              * editing/unsupported-content/list-delete-001-expected.txt:
      
      WebCore:
      
              Reviewed by john
      
              <rdar://problem/5032066> Delete should work between ToDos
              
              Stop selecting the table when the user attempts to delete
              the line break just after it, instead, extend the selection
              into the last table cell.
              Let deletion merge content into table cells (as long as 
              its not from another table cell).  
              Start calling shouldInsertNode:replacingDOMRange:givenAction: 
              when moving content with moveParagraphs, so that Mail can 
              modify content before it is moved into a ToDo during a delete.
      
              * editing/CompositeEditCommand.cpp:
              (WebCore::CompositeEditCommand::moveParagraphs): Ask the
              delegate before performing the move.  This will let Mail
              prevent styles from entering a ToDo.
              Added a FIXME about adding a new WebViewInsertAction
              * editing/DeleteSelectionCommand.cpp:
              (WebCore::DeleteSelectionCommand::initializePositionData):
              Allow merging into table cells from content not in a table.
              * editing/SelectionController.cpp:
              (WebCore::SelectionController::modifyExtendingRightForward):
              Don't select the table when extending by character/word from
              just before it.  This code was here to make it easier to select
              tables in order to delete them, but the deletion UI makes it 
              largely unnecessary.
              (WebCore::SelectionController::modifyExtendingLeftBackward):
              Ditto.
              * editing/TypingCommand.cpp:
              (WebCore::isFirstPositionAfterTable): Added.
              (WebCore::isLastPositionBeforeTable): Ditto.
              (WebCore::TypingCommand::deleteKeyPressed): When pressing
              the delete key with a caret at the beginning of a paragraph
              just after a table, move the paragraph into the last table
              cell.
              Do not do this if it would mean moving a block table.
              Removed some old irrelevant comments.
              * editing/htmlediting.cpp: Removed unused functions.
              * editing/htmlediting.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7701503
    • thatcher's avatar
      Build fix for Leopard. · 3619ea1d
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3619ea1d
    • staikos's avatar
      Add a comment since our current fix is not really acceptable. · dd4e40c2
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd4e40c2
    • staikos's avatar
      Remove redundant line. · 64c14577
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64c14577
    • staikos's avatar
      correct the changelog entry for the patch author. · 4eeb87ad
      staikos authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4eeb87ad
    • staikos's avatar
      Take into account the entire run length to get a proper selection. · 4afb0159
      staikos authored
              Doesn't seem to affect the Mac build but is a problem for Qt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4afb0159
    • ggaren's avatar
      Rubber stamped by Beth Dakin. · c8c5fb4e
      ggaren authored
              
              WebBaseNetscapePluginStream.m => WebBaseNetscapePluginStream.mm, since
              it's ObjC++ now.
      
              * Plugins/WebBaseNetscapePluginStream.m: Removed.
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8c5fb4e
    • darin's avatar
      Layout test for <rdar://problem/4545060>, technorati and arstechnica fail · a5177246
      darin authored
              because of getComputedStyle not reporting display:none.
              http://bugs.webkit.org/show_bug.cgi?id=13103
      
              * fast/css/computed-style-display-none.html: Added.
              * fast/css/computed-style-display-none-expected.txt: Added.
      
              * fast/css/computed-style-negative-top.html: Updated to work with Gecko.
              * fast/css/computed-style-negative-top-expected.txt: Newline change needed
              because of change above.
      
              * fast/css/computed-style.html: Updated to work with Gecko.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5177246
    • ggaren's avatar
      Reluctantly tolerated by Darin Adler. · ff861b0b
      ggaren authored
              
              Fixed <rdar://problem/5091330> REGRESSION: Repro crash in 
              -[WebBaseNetscapePluginView(WebNPPCallbacks) destroyStream:reason:] 
              navigating away from page with DivX movie plug-in (13203)
              
              The problem was that the DivX plug-in would ask us to destroy an NPStream
              that had already been destroyed, causing us to wander off into freed
              memory. (I believe the reason this was a regression was that we never used 
              to destroy plug-in streams, period.)
              
              The solution here is to track the NPStreams belonging to a plug-in, and 
              guard against plug-ins making calls with NPStreams that don't belong to 
              them. (It turns out that NPN_DestroyStream is the only stream-based 
              plug-in call we support.)
      
              (CarbonPathFromPOSIXPath): Fixed up a cast to be C++ compatible.
              * Plugins/WebBaseNetscapePluginView.mm:
              (-[WebBaseNetscapePluginView destroyStream:reason:]): The actual fix.
              Use helper method to guard against a plug-in using an NPStream that doesn't
              belong to it.
              * WebKit.xcodeproj/project.pbxproj: Made WebBaseNetscapePluginView ObjC++
              so I could use HashMap.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20571 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff861b0b
    • hyatt's avatar
      Fix for <rdar://problem/4545060>, technorati and arstechnica fail... · 3666feb9
      hyatt authored
              Fix for <rdar://problem/4545060>, technorati and arstechnica fail because of getComputedStyle not
              reporting display:none properly when it is set.  This is bugzilla bug 13103.
      
              Reviewed by mitz
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20570 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3666feb9
    • dsmith's avatar
      JavaScriptCore: · ebd6d4e5
      dsmith authored
              Reviewed by Darin.
      
              http://bugs.webkit.org/show_bug.cgi?id=12963
              Fix some inconsistencies in the Mozilla JS Array extras implementations
              with respect to the Mozilla implementation:
      
                - holes in arrays should be skipped, not treated as undefined,
                  by all such methods
                - an element with value undefined is not a hole
                - Array.prototype.forEach should return undefined
      
              * kjs/array_object.cpp:
              (ArrayInstance::getOwnPropertySlot):
              (ArrayProtoFunc::callAsFunction):
      
      LayoutTests:
      
              Reviewed by Darin.
      
               http://bugs.webkit.org/show_bug.cgi?id=12963
               Fix some inconsistencies in the Mozilla JS Array extras implementations
               with respect to the Mozilla implementation:
      
                 - holes in arrays should be skipped, not treated as undefined,
                   by all such methods
                 - an element with value undefined is not a hole
                 - Array.prototype.forEach should return undefined
      
              * fast/js/array-every-expected.txt:
              * fast/js/array-filter-expected.txt: Added.
              * fast/js/array-filter.html: Added.
              * fast/js/array-foreach-expected.txt:
              * fast/js/array-foreach.html:
              * fast/js/array-indexof-expected.txt:
              * fast/js/array-indexof.html:
              * fast/js/array-lastIndexOf-expected.txt:
              * fast/js/array-map-expected.txt: Added.
              * fast/js/array-map.html: Added.
              * fast/js/array-some-expected.txt:
              * fast/js/array-some.html:
              * fast/js/resources/array-every.js:
              * fast/js/resources/array-lastIndexOf.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ebd6d4e5
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 06d89a01
      oliver authored
              Reviewed by Hyatt.
      
              Rename DocLoader::setPasteInProgress, etc to more generic 
              setAllowStaleResources, etc
      
              * editing/Editor.cpp:
              (WebCore::Editor::paste):
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::DocLoader):
              (WebCore::DocLoader::checkForReload):
              * loader/DocLoader.h:
              (WebCore::DocLoader::setAllowStaleResources):
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20568 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06d89a01
  3. 28 Mar, 2007 9 commits
    • oliver's avatar
      2007-03-28 Oliver Hunt <oliver@apple.com> · 1c8a4876
      oliver authored
              Reviewed by Anders and Steve.
      
              Add a flag to DocLoader to prevent it from reloading 
              when performing a paste or drop operation.
              
              Remove m_cachePolicy from CachedResource as it is never used
              
              Fixes rdar://problem/5044366 : REGRESSION: Repro ASSERT failures 
              dragging image into GMail message in _web_writeImage and 
              documentFragmentFromDragData
      
              * editing/Editor.cpp:
              (WebCore::Editor::paste):
                prevent the docloader from reloading resources on paste
              * html/HTMLImageLoader.cpp:
              (WebCore::HTMLImageLoader::updateFromElement):
              * loader/Cache.cpp:
              (WebCore::createResource):
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
              * loader/CachedCSSStyleSheet.h:
              * loader/CachedImage.cpp:
              (WebCore::CachedImage::CachedImage):
              * loader/CachedImage.h:
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::CachedResource):
              * loader/CachedResource.h:
              * loader/CachedScript.cpp:
              (WebCore::CachedScript::CachedScript):
              * loader/CachedScript.h:
              * loader/CachedXBLDocument.cpp:
              (WebCore::CachedXBLDocument::CachedXBLDocument):
              * loader/CachedXBLDocument.h:
              * loader/CachedXSLStyleSheet.cpp:
              (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
              * loader/CachedXSLStyleSheet.h:
              * loader/DocLoader.cpp:
              (WebCore::DocLoader::DocLoader):
                 Tidy up constructor initialise new field
              (WebCore::DocLoader::checkForReload):
                 Prevent reload when pasting
              * loader/DocLoader.h:
              (WebCore::DocLoader::setPasteInProgress):
                new field and setter
              * page/DragController.cpp:
              (WebCore::DragController::concludeDrag):
                prevent the docloader from reloading resources on drop
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20567 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1c8a4876
    • kjk's avatar
      Not reviewed - fix typo in gdk build. · b6a0acea
      kjk authored
              * platform/gdk/ScrollViewGdk.cpp:
              (WebCore::ScrollView::contentsToWindow):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20566 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6a0acea
    • mjs's avatar
      LayoutTests: · 14590a57
      mjs authored
              Reviewed by Darin.
              
              - <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
      
              * fast/overflow/scrollRevealButton-expected.checksum:
              * fast/overflow/scrollRevealButton-expected.png:
              * fast/overflow/scrollRevealButton-expected.txt:
      
      WebCore:
      
              Reviewed by Darin.
              
              - fixed <rdar://problem/4820817> Autoscroll is broken in Mail.app (message jumps around when trying to select text)
                      
              Handle scrolling external scrollviews around the webview during
              autoscroll or when scrolling into view.
              
              This should also restore performance on BenchJS test 6 lost due to Tim's partial fix.
      
              * page/FrameView.cpp:
              (WebCore::FrameView::scrollRectIntoViewRecursively):
              * page/FrameView.h:
              * platform/ScrollView.h:
              * platform/gdk/ScrollViewGdk.cpp:
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              * platform/mac/ScrollViewMac.mm:
              (WebCore::ScrollView::visibleContentRect):
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              (WebCore::ScrollView::updateContents):
              * platform/qt/ScrollViewQt.cpp:
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              * platform/win/ScrollViewWin.cpp:
              (WebCore::ScrollView::visibleContentRectConsideringExternalScrollers):
              * platform/win/TemporaryLinkStubs.cpp:
              (WebCore::ScrollView::scrollRectIntoViewRecursively):
              * rendering/RenderLayer.cpp:
              (WebCore::RenderLayer::scrollRectToVisible):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20565 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      14590a57
    • adele's avatar
      Reviewed by Brady. · 1d3bb180
      adele authored
              Update to last fix.
      
              * Misc/WebKitVersionChecks.h: Added WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK.
              * WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
              Added check to only use the VitalSource workaround if the app is not linked on or after
              the defined WEBKIT_FIRST_VERSION_WITHOUT_VITALSOURCE_QUIRK version number.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1d3bb180
    • darin's avatar
      Reviewed and landed by Darin · 993602c1
      darin authored
              Get rid of some misuses of |islower| and |tolower| for non-ASCII characters.
              http://bugs.webkit.org/show_bug.cgi?id=13138
      
              * platform/StringImpl.cpp:
              (WebCore::StringImpl::isLower):
              (WebCore::StringImpl::lower):
              (WebCore::StringImpl::equalIgnoringCase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20559 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      993602c1
    • antti's avatar
      Reviewed by Hyatt. · 60c2cceb
      antti authored
              Fix <rdar://problem/5092653>
              REGRESSION: Image decoding making scrolling slow
              
              If decoder gave back a null frame (which I think happens regularly if you don't have full frame 
              data yet for image that does not decode incrementally) m_decodedSize was incremented anyway. This
              led to massive growth in calculated image size and eventually made cache prune constantly. 
              
              No test, I don't know how to make one for this.
      
              * platform/graphics/BitmapImage.cpp:
              (WebCore::BitmapImage::cacheFrame):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      60c2cceb
    • adele's avatar
      WebCore: · cc025d83
      adele authored
              Reviewed by Kevin M.
      
              WebCore part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
      
              * page/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
              Convert return value to a string.  This matches the behavior in Safari 2.0.
      
      WebKit:
      
              Reviewed by Kevin M.
      
              WebKit part of fix for <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
      
              Added an app specific workaround for VitalSource Bookshelf that strips "return" from the beginning of their script strings.  We used to allow this
              but now we throw a JavaScript exception for return statements that aren't in functions.
      
              Filed this evangelism bug so we can notify VitalSource of the problem:
              <rdar://problem/5095515> VitalSource Bookshelf should not pass return statements into stringByEvaluatingJavaScriptFromString
      
              * WebView/WebView.mm: (-[WebView stringByEvaluatingJavaScriptFromString:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cc025d83
    • ap's avatar
      Reviewed by Darin. · 16c9b5f7
      ap authored
              http://bugs.webkit.org/show_bug.cgi?id=13190
              XPath incorrectly handles namespaces on attributes
      
      WebCore:
              * xml/XPathStep.cpp:
              (WebCore::XPath::Step::nodesInAxis): Added a special case for faster attribute lookup; gives a slight but 
              measurable performance improvement for bug 13021.
              (WebCore::XPath::Step::nodeMatches): Fixed NameTest for attribute nodes.
      
              * xml/XPathStep.h:
              (WebCore::XPath::Step::NodeTest::NodeTest):
              (WebCore::XPath::Step::NodeTest::namespaceURI):
              (WebCore::XPath::Step::nodeTest):
              (WebCore::XPath::Step::setNodeTest):
              Move m_namespaceURI to NodeTest, where it belongs. Removed unused m_nodeTestData (oops!).
      
              * xml/XPathGrammar.y:
              * xml/XPathPath.cpp:
              (WebCore::XPath::LocationPath::optimizeStepPair):
              Accounted for the above change.
      
      LayoutTests:
              * fast/xpath/attr-namespace-expected.txt: Added.
              * fast/xpath/attr-namespace.html: Added.
      
              * fast/xpath/xpath-namespaces-expected.txt:
              * fast/xpath/xpath-namespaces.html:
              Cleaned up; added a couple more cases (which passed anyway, but weren't tested for).
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16c9b5f7
    • antti's avatar
      Update libWebKitSystemInterface, previous version was out of date. · 6ef858f4
      antti authored
              * libWebKitSystemInterface.a:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6ef858f4