1. 25 Feb, 2010 39 commits
    • enrica@apple.com's avatar
      Extra layout on keypress after a space (problem with rebalanceWhitespaceAt in InsertTextCommand). · b5adb4e2
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30946
      <rdar://problem/7639184>
      
      Reviewed by Adele Peterson.
      
      WebCore: 
      
      Do text insertion and whitespace rebalancing around the insertion in one step so that there's only one layout.
      This patch was originally made by Justin Garcia.
              
      Test: editing/inserting/rebalance-whitespace-1.html
      
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::rebalanceWhitespaceAt): No behavior changes here,
      just pushed the code that determined the extent of whitespace surrounding a position
      to its own helper function.
      * editing/InsertTextCommand.cpp:
      (WebCore::InsertTextCommand::insertTextIntoNodeAndRebalanceWhitespace): Added.  Find 
      whitespace surrounding the insertion position, add the text to insert, rebalance that entire
      string, then insert it into the document.
      (WebCore::InsertTextCommand::input):
      * editing/InsertTextCommand.h:
      * editing/htmlediting.cpp:
      (WebCore::isWhitespace): Moved from CompositeEditCommand.cpp.
      (WebCore::extentOfWhitespaceForRebalancingAt): Moved code from rebalanceWhitespaceAt into this helper
      function.  Obtains the offset of the start and end of whitespace around a particular position.
      * editing/htmlediting.h:
      
      LayoutTests: 
      
      There are now regular spaces where nbsps were used unnecessarily before.  Also,
      multi-character insertions now have their whitespace rebalanced, and this is
      reflected in a few tests.
      
      * editing/execCommand/5142012-3-expected.txt:
      * editing/inserting/rebalance-whitespace-1-expected.txt: Added.
      * editing/inserting/rebalance-whitespace-1.html: Added.
      * editing/pasteboard/5521237-expected.txt:
      * platform/mac/editing/execCommand/5482023-expected.checksum:
      * platform/mac/editing/execCommand/5482023-expected.png: Removed.
      * platform/mac/editing/execCommand/5482023-expected.txt:
      * platform/mac/editing/execCommand/remove-formatting-2-expected.checksum:
      * platform/mac/editing/execCommand/remove-formatting-2-expected.png: Removed.
      * platform/mac/editing/execCommand/remove-formatting-expected.checksum:
      * platform/mac/editing/execCommand/remove-formatting-expected.png: Removed.
      * platform/mac/editing/execCommand/remove-formatting-expected.txt:
      * platform/mac/editing/inserting/editable-html-element-expected.checksum:
      * platform/mac/editing/inserting/editable-html-element-expected.png: Removed.
      * platform/mac/editing/inserting/editable-html-element-expected.txt:
      * platform/mac/editing/pasteboard/4989774-expected.checksum:
      * platform/mac/editing/pasteboard/4989774-expected.png: Removed.
      * platform/mac/editing/pasteboard/4989774-expected.txt:
      * platform/mac/editing/selection/4983858-expected.checksum:
      * platform/mac/editing/selection/4983858-expected.png: Removed.
      * platform/mac/editing/selection/4983858-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5adb4e2
    • ap@apple.com's avatar
      Reviewed by Anders Carlsson. · 8c4e21b9
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=35406
              <rdar://problem/6945502> Make generic array methods work with JavaArray
      
              Test: java/array-sort.html
      
              Made RuntimeArray inherit from JSArray, keeping the promise given in ClassInfo.
      
              * bridge/runtime_array.cpp:
              (JSC::RuntimeArray::RuntimeArray):
              (JSC::RuntimeArray::~RuntimeArray):
              * bridge/runtime_array.h:
              (JSC::RuntimeArray::classInfo):
              (JSC::RuntimeArray::getConcreteArray):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c4e21b9
    • mitz@apple.com's avatar
      Fixed a regression introduced in r44243, which made the assertion in checkListItems() · 0ac226a2
      mitz@apple.com authored
      ineffective.
      
      Reviewed by Alexey Proskuryakov.
      
      * dom/SelectElement.cpp:
      (WebCore::SelectElementData::checkListItems): Copy the items vector before recomputing it,
      then assert that the newly-computed vector is equal to the copy.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55261 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ac226a2
    • krit@webkit.org's avatar
      2010-02-25 Dirk Schulze <krit@webkit.org> · 35058be7
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters
              https://bugs.webkit.org/show_bug.cgi?id=35354
      
              This makes the base class RenderSVGInline of RenderSVGTSpan and RenderSVGInlineText
              dependent on SVGBaseRenderer.
              The SVG spec want as to use the object bounding box of the text root as the bounding box
              for text-childs. So we search for the text root and use it's bounding box, stroke rect and
              repaint rect for further calculations.
      
              Test: svg/filters/filter-on-tspan.svg
      
              * rendering/RenderSVGInline.cpp:
              (WebCore::RenderSVGInline::objectBoundingBox): Find the text root and give back it's bounding box.
              (WebCore::RenderSVGInline::strokeBoundingBox): same for stroke rect
              (WebCore::RenderSVGInline::repaintRectInLocalCoordinates): same for repaint rect
              * rendering/RenderSVGInline.h:
              (WebCore::RenderSVGInline::toSVGRenderBase): RenderSVGInline is part of SVGRenderBase now.
              * rendering/RenderSVGTSpan.h:
              (WebCore::RenderSVGTSpan::renderName): Removed bounding box code. Was just a hack for filters and maskers.
              * rendering/SVGRenderSupport.cpp:
              (WebCore::findTextRootObject): Search for the text root.
              * rendering/SVGRenderSupport.h:
              * svg/graphics/SVGPaintServerGradient.cpp: moved findTextRootObject to SVGRenderSupport
      2010-02-25  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Nikolas Zimmermann.
      
              SVG's tspan is no member of SVGRenderBase, this can cause crashes on filters
              https://bugs.webkit.org/show_bug.cgi?id=35354
      
              Check if filters work for tspan according to the SVG Spec. The test shouldn't
              throw an assert now and a green rect should be visible.
      
              * platform/mac/svg/filters/filter-on-tspan-expected.checksum: Added.
              * platform/mac/svg/filters/filter-on-tspan-expected.png: Added.
              * platform/mac/svg/filters/filter-on-tspan-expected.txt: Added.
              * svg/filters/filter-on-tspan.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55260 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35058be7
    • krit@webkit.org's avatar
      2010-02-25 Dirk Schulze <krit@webkit.org> · 4246fd03
      krit@webkit.org authored
              Reviewed by Nikolas Zimmermann.
      
              Use-element doesn't transform clipPath
              https://bugs.webkit.org/show_bug.cgi?id=35375
      
              If the use element is a child of clipPath, any settings on x, y or transform does not
              transform the clipPath it references.
              The use-element just misses this transformation in toClipPath.
      
              Test: svg/custom/use-on-clip-path-with-transformation.svg
      
              * platform/graphics/cairo/PathCairo.cpp: Gtk port translated the path to the wrong direction.
              (WebCore::Path::translate):
              * svg/SVGUseElement.cpp:
              (WebCore::SVGUseElement::toClipPath):
      2010-02-25  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Nikolas Zimmermann.
      
              Use-element doesn't transform clipPath
              https://bugs.webkit.org/show_bug.cgi?id=35375
      
              Check if the clipPath gets transformed on setting a transform or translation for use.
      
              * platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.checksum: Added.
              * platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.png: Added.
              * platform/mac/svg/custom/use-on-clip-path-with-transformation-expected.txt: Added.
              * svg/custom/use-on-clip-path-with-transformation.svg: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4246fd03
    • oliver@apple.com's avatar
      2010-02-25 Oliver Hunt <oliver@apple.com> · bc0c2187
      oliver@apple.com authored
              Reviewed by Geoff Garen.
      
              JSC crashes like crazy in the JSPropertyNameIterator destructor
      
              Add back null check of m_cachedStructure.  Curse last minute changes.
      
              * runtime/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55258 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc0c2187
    • jianli@chromium.org's avatar
      File.type support. · e02de703
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=35361
      
      Reviewed by Dmitry Titov.
      
      WebCore:
      
      Test: LayoutTests/editing/pasteboard/file-input-files-access.html
      
      * html/File.cpp:
      (WebCore::File::File):
      * html/File.h:
      (WebCore::File::type):
      * html/File.idl:
      
      LayoutTests:
      
      Update the layout test to test File.type.
      
      * editing/pasteboard/file-input-files-access-expected.txt:
      * editing/pasteboard/script-tests/file-input-files-access.js:
      (fileListShouldBe):
      (runTest):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55257 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e02de703
    • oliver@apple.com's avatar
      2010-02-25 Oliver Hunt <oliver@apple.com> · 43b309bf
      oliver@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              Race condition in JSPropertyNameIterator and Structure destruction
              https://bugs.webkit.org/show_bug.cgi?id=35398
      
              JSPropertyNameIterator and Structure have a cyclic dependency that they
              manage by clearing the appropriate reference in each other during their
              destruction.  However if the Structure is destroyed while the
              JSPropertyNameIterator is dead but not yet finalized the Structures
              WeakGCPtr will return null, and so prevent Structure from clearing
              the m_cachedStructure pointer of the iterator.  When the iterator is
              then finalised the m_cachedStructure is invalid, and the attempt to
              clear the structures back reference fails.
      
              To fix this we simply make JSPropertyNameIterator keep the Structure
              alive, using the weak pointer to break the ref cycle.
      
              * runtime/JSPropertyNameIterator.cpp:
              (JSC::JSPropertyNameIterator::~JSPropertyNameIterator):
                The iterator now keeps m_cachedStructure alive itself, so no longer needs
                to check for it being cleared
              * runtime/JSPropertyNameIterator.h:
              (JSC::JSPropertyNameIterator::setCachedStructure):
                Add an assertion to ensure correct usage
              (JSC::JSPropertyNameIterator::cachedStructure):
                Add .get()
              * runtime/Structure.cpp:
              (JSC::Structure::~Structure):
                Add an assertion that our iterator isn't already dead, and remove
                the now unnecessary attempt to clear the ref in the iterator
              * runtime/WeakGCPtr.h:
              (JSC::WeakGCPtr::hasDeadObject):
                An assert-only function to allow us to assert correct behaviour
                in the Structure destructor
      2010-02-25  Oliver Hunt  <oliver@apple.com>
      
              Reviewed by Maciej Stachowiak.
      
              Race condition in JSPropertyNameIterator and Structure destruction
              https://bugs.webkit.org/show_bug.cgi?id=35398
      
              Add test to ensure that this race condition doesn't occur.
      
              * fast/js/script-tests/for-in-cached.js:
              (cacheClearing):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55256 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43b309bf
    • eric@webkit.org's avatar
      2010-02-25 Alexander Pavlov <apavlov@chromium.org> · 0ff00400
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Javascript console should not attempt to scroll to end of console if console is not visible
      
              https://bugs.webkit.org/show_bug.cgi?id=22992
      
              * inspector/front-end/ConsoleView.js:
              (WebInspector.ConsoleView.prototype._scheduleScrollIntoView.scrollIntoView):
              (WebInspector.ConsoleView.prototype._scheduleScrollIntoView):
              (WebInspector.ConsoleView.prototype.addMessage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55255 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ff00400
    • eric@webkit.org's avatar
      2010-02-25 James Hawkins <jhawkins@chromium.org> · 66611a0d
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              [Chromium] Implement WebLabelElement.
      
              https://bugs.webkit.org/show_bug.cgi?id=35317
      
              * WebKit.gyp:
              * public/WebLabelElement.h: Added.
              * src/WebLabelElement.cpp: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55254 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66611a0d
    • ap@apple.com's avatar
      Qt and Gtk build fixes. · 21a37c87
      ap@apple.com authored
              * GNUmakefile.am:
              * WebCore.pro:
              Added CRuntimeObject.{c,cpp}.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55253 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21a37c87
    • ap@apple.com's avatar
      Windows build fix. · 7585642d
      ap@apple.com authored
              * WebCore.vcproj/WebCore.vcproj: Added CRuntimeObject.{c,cpp}.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55252 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7585642d
    • ap@apple.com's avatar
      Tiger build fix. · ef18f0ce
      ap@apple.com authored
              * java/Makefile: I can't get $(or ...) work on Tiger, so changed to use a single condition.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55251 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef18f0ce
    • ap@apple.com's avatar
      Reviewed by Geoffrey Garen. · 6c2214a9
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=35394
              <rdar://problem/7685262> Make passing objects between Java and plug-ins work
      
              * WebCore.PluginHostProcess.exp: WebKit now subclasses RuntimeObject, so it needed more exports.
      
              * bridge/runtime_object.cpp:
              (JSC::Bindings::callRuntimeObject):
              (JSC::Bindings::callRuntimeConstructor):
              Assert that a runtime object is passed as function.
      
              * bridge/runtime_object.h: Moved RuntimeObject into Bindings namespace, matching other
              related classes.
      
              * bridge/jni/jni_jsobject.mm:
              (JavaJSObject::toString): Pass rootObject to convertValueToJValue(). It's not needed when
              constructing a string, but this function now takes it for the sake of Object.
              (JavaJSObject::convertValueToJObject): Check that object class is JavaRuntimeObject, not
              just RuntimeObject.
      
              * bridge/jni/jsc/JNIBridgeJSC.cpp:
              (JavaField::setValueToInstance): Pass rootObject to convertValueToJValue().
              (JavaArray::setValueAt): Ditto.
      
              * bridge/jni/jsc/JNIUtilityPrivate.h: convertValueToJValue() now takes a RootObject argument,
              because one is needed to gcProtect an object ghtat is wrapped into JSObject.
      
              * bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Convert
              JavaScript objects to Java JSObject ones. This was already happening in other code paths,
              which we should change to use common code.
      
              * bridge/jni/jsc/JavaInstanceJSC.cpp:
              (JavaInstance::newRuntimeObject): Create an appropriate RuntimeObject subclass,
              which is JavaRuntimeObject for Java.
              (JavaInstance::invokeMethod): Unwrap returned JavaObjects that contain JS objects.
      
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/objc/WebScriptObject.mm:
              (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
              * bridge/c/CRuntimeObject.cpp: Added.
              (JSC::Bindings::CRuntimeObject::CRuntimeObject):
              (JSC::Bindings::CRuntimeObject::~CRuntimeObject):
              (JSC::Bindings::CRuntimeObject::getInternalCInstance):
              * bridge/c/CRuntimeObject.h: Added.
              (JSC::Bindings::CRuntimeObject::classInfo):
              * bridge/c/c_instance.cpp:
              (JSC::Bindings::CInstance::newRuntimeObject):
              * bridge/c/c_instance.h:
              * bridge/c/c_utility.cpp:
              (JSC::Bindings::convertValueToNPVariant):
              * bridge/jni/jsc/JavaInstanceJSC.h:
              * bridge/jni/jsc/JavaRuntimeObject.cpp: Added.
              (JSC::Bindings::):
              (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
              (JSC::Bindings::JavaRuntimeObject::~JavaRuntimeObject):
              (JSC::Bindings::JavaRuntimeObject::getInternalJavaInstance):
              * bridge/jni/jsc/JavaRuntimeObject.h: Added.
              (JSC::Bindings::JavaRuntimeObject::classInfo):
              * bridge/jsc/BridgeJSC.h:
              * bridge/objc/ObjCRuntimeObject.h: Added.
              (JSC::Bindings::ObjCRuntimeObject::classInfo):
              * bridge/objc/ObjCRuntimeObject.mm: Added.
              (JSC::Bindings::):
              (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
              (JSC::Bindings::ObjCRuntimeObject::~ObjCRuntimeObject):
              (JSC::Bindings::ObjCRuntimeObject::getInternalObjCInstance):
              * bridge/objc/objc_instance.h:
              * bridge/objc/objc_instance.mm:
              (ObjcInstance::newRuntimeObject):
              * bridge/objc/objc_runtime.mm:
              (JSC::Bindings::callObjCFallbackObject):
              * bridge/runtime_root.h:
              Added RuntimeObject subclasses for each instance type, and use them for type casting.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55250 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c2214a9
    • kov@webkit.org's avatar
      2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 03f3ea00
      kov@webkit.org authored
              Rubber-stamped by Xan Lopez.
      
              Adopt the same string as the one that is expected by
              fast/parser/fragment-parser.html for the description used by the
              <isindex> element.
      
              * platform/gtk/LocalizedStringsGtk.cpp:
              (WebCore::searchableIndexIntroduction):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55249 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      03f3ea00
    • pfeldman@chromium.org's avatar
      2010-02-25 Pavel Feldman <pfeldman@chromium.org> · 81cf3486
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: evaluate-on-hover does not work on HTML files.
      
              https://bugs.webkit.org/show_bug.cgi?id=35378
      
              * inspector/front-end/SourceCSSTokenizer.re2js:
              * inspector/front-end/SourceHTMLTokenizer.js:
              (WebInspector.SourceHTMLTokenizer):
              (WebInspector.SourceHTMLTokenizer.prototype.set line):
              (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttribute):
              (WebInspector.SourceHTMLTokenizer.prototype._isExpectingAttributeValue):
              (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttribute):
              (WebInspector.SourceHTMLTokenizer.prototype._setExpectingAttributeValue):
              (WebInspector.SourceHTMLTokenizer.prototype._attrValueTokenType):
              (WebInspector.SourceHTMLTokenizer.prototype.nextToken):
              * inspector/front-end/SourceHTMLTokenizer.re2js:
              * inspector/front-end/SourceJavaScriptTokenizer.js:
              (WebInspector.SourceJavaScriptTokenizer):
              * inspector/front-end/SourceJavaScriptTokenizer.re2js:
              * inspector/front-end/SourceTokenizer.js:
              (WebInspector.SourceTokenizer.prototype.set condition):
              (WebInspector.SourceTokenizer.prototype.get condition):
              (WebInspector.SourceTokenizer.prototype.get subTokenizer):
              (WebInspector.SourceTokenizer.prototype.getLexCondition):
              (WebInspector.SourceTokenizer.prototype.setLexCondition):
              * inspector/front-end/TextEditorHighlighter.js:
              (WebInspector.TextEditorHighlighter):
              (WebInspector.TextEditorHighlighter.prototype.set mimeType):
              (WebInspector.TextEditorHighlighter.prototype.highlight):
              (WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
              (WebInspector.TextEditorHighlighter.prototype._highlightLines):
              (WebInspector.TextEditorHighlighter.prototype._highlightLine):
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextViewer.prototype._paintLine):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55248 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81cf3486
    • jorlow@chromium.org's avatar
      Make the context that was passed to the ThreadFunction accessible. · 7f493695
      jorlow@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=35379
      
      Patch by Jochen Eisinger <jochen@chromium.org> on 2010-02-25
      Reviewed by Jeremy Orlow.
      
      When a database is opened, right now you
      don't have any context from where it is opened. The problem is that
      the actual calls that open a database go through the sqlite3 vfs
      layer, so there's no easy way to pass this function down to to
      platform/sql/chromium/SQLFileSystemChromium*.cpp
      
      This patch will allow you to get from anywhere within webkit a pointer
      to the Thread object that actually created the thread you're currently
      on (in case of the database, this can be either a thread forked of
      from the main thread or from a worker thread), and query the object
      for context information.
      
      * wtf/Threading.h:
      * wtf/ThreadingNone.cpp:
      (WTF::threadContext):
      * wtf/ThreadingPthreads.cpp:
      (WTF::):
      (WTF::identifierByPthreadHandle):
      (WTF::establishIdentifierForPthreadHandle):
      (WTF::pthreadHandleForIdentifier):
      (WTF::contextForIdentifier):
      (WTF::createThreadInternal):
      (WTF::currentThread):
      (WTF::threadContext):
      * wtf/ThreadingWin.cpp:
      (WTF::):
      (WTF::threadMap):
      (WTF::storeThreadHandleByIdentifier):
      (WTF::threadHandleForIdentifier):
      (WTF::contextForIdentifier):
      (WTF::createThreadInternal):
      (WTF::threadContext):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55247 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f493695
    • jorlow@chromium.org's avatar
      Reverting to re-submit with better change log. · 162895c0
      jorlow@chromium.org authored
      * wtf/Threading.h:
      * wtf/ThreadingNone.cpp:
      (WTF::isMainThread):
      * wtf/ThreadingPthreads.cpp:
      (WTF::identifierByPthreadHandle):
      (WTF::establishIdentifierForPthreadHandle):
      (WTF::pthreadHandleForIdentifier):
      (WTF::createThreadInternal):
      (WTF::currentThread):
      * wtf/ThreadingWin.cpp:
      (WTF::threadMap):
      (WTF::storeThreadHandleByIdentifier):
      (WTF::threadHandleForIdentifier):
      (WTF::createThreadInternal):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55246 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      162895c0
    • kov@webkit.org's avatar
      2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · e958733a
      kov@webkit.org authored
              Reviewed by Xan Lopez.
      
              [Gtk] crashed when destroying
              https://bugs.webkit.org/show_bug.cgi?id=31271
      
              NULL-check the page before relaying the focus out event, since
              this might happen when destroying the widget without destroying
              its parent, and we currently crash.
      
              * tests/testwebview.c:
              (delayed_destroy):
              (test_webkit_web_view_destroy):
              (main):
              * webkit/webkitwebview.cpp:
              (webkit_web_view_focus_in_event):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55245 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e958733a
    • xan@webkit.org's avatar
      2010-02-25 Xan Lopez <xlopez@igalia.com> · 99cb16ef
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Simple style cleanups.
      
              * plugins/gtk/PluginViewGtk.cpp:
              (WebCore::plugRemovedCallback):
              (WebCore::plugAddedCallback):
              (WebCore::PluginView::platformStart):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55244 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      99cb16ef
    • abarth@webkit.org's avatar
      2010-02-25 Adam Barth <abarth@webkit.org> · cd4817a6
      abarth@webkit.org authored
              Reviewed by David Levin.
      
              EWS leaks memory slowly
              https://bugs.webkit.org/show_bug.cgi?id=35395
      
              The EWS bots leak memory very slowly.  If you run them for about a
              month, each one will take up around 1 GB of virutal memory.  If you run
              several of them on one machine, you'll eventually exhaust all available
              memory and grind the bots to a halt.
      
              This patch introduces a --exit-after-iteration option to the queues so
              that we run them for a finite amount of time.  Once they exit and
              restart, they'll reclaim the leaked memory.  I'm not sure how many
              iterations I'll end up running them for.  I'll need to sort that out
              operationally, but my initial guess is around 1000.
      
              * Scripts/webkitpy/commands/queues.py:
              * Scripts/webkitpy/commands/queues_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55243 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd4817a6
    • eric@webkit.org's avatar
      2010-02-25 Andreas Kling <andreas.kling@nokia.com> · 2fef2fe0
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Optimize decoding of Latin-1 text by exploiting the fact that most of it will
              be ASCII-only data.
      
              https://bugs.webkit.org/show_bug.cgi?id=35233
      
              * platform/text/TextCodecLatin1.cpp:
              (WebCore::TextCodecLatin1::decode):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55242 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fef2fe0
    • pfeldman@chromium.org's avatar
      2010-02-25 Pavel Feldman <pfeldman@chromium.org> · 091c8281
      pfeldman@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Web Inspector: make script lines count calculation lazy.
      
              https://bugs.webkit.org/show_bug.cgi?id=35392
      
              * inspector/front-end/Script.js:
              (WebInspector.Script):
              (WebInspector.Script.prototype.get linesCount):
              * inspector/front-end/ScriptsPanel.js:
              * inspector/front-end/SourceView.js:
              (WebInspector.SourceView.prototype._addBreakpoint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55241 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      091c8281
    • levin@chromium.org's avatar
      Change hardcoded gcc paths to be Solaris friendly · 8a929be4
      levin@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=35213
      
      Patch by James Choi <jchoi42@pha.jhu.edu> on 2010-02-25
      Reviewed by David Levin.
      
      * bindings/scripts/CodeGeneratorObjC.pm:
      * bindings/scripts/IDLParser.pm:
      * css/make-css-file-arrays.pl:
      * dom/make_names.pl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55240 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8a929be4
    • darin@chromium.org's avatar
      2010-02-24 Darin Fisher <darin@chromium.org> · e0789c19
      darin@chromium.org authored
              Reviewed by David Levin.
      
              Add a missing WebString.h include.
              https://bugs.webkit.org/show_bug.cgi?id=35360
      
              This is required since some of the methods have implementations that
              return a WebString.
      
              * public/WebCookieJar.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55239 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0789c19
    • xan@webkit.org's avatar
      2010-02-25 Xan Lopez <xlopez@igalia.com> · 74eb6efc
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Workaround Java plugins not drawing themselves properly on first
              expose by doing a late size-allocate after 'plug-added' has been
              emitted on the embedding GtkSocket. It's unclear to me if this is
              a bug in our side or theirs, but this should be pretty safe and
              fixes the annoyance while we investigate it further.
      
              * plugins/gtk/PluginViewGtk.cpp:
              (WebCore::plugAddedCallback):
              (WebCore::PluginView::platformStart):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55238 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74eb6efc
    • jocelyn.turcotte@nokia.com's avatar
      Add missing include guards · 5de927ac
      jocelyn.turcotte@nokia.com authored
      Reviewed by Tor Arne Vestbø.
      
      * loader/CrossOriginPreflightResultCache.h:
      * loader/MainResourceLoader.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55237 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5de927ac
    • jocelyn.turcotte@nokia.com's avatar
      [Qt] Restrict the optimization flags for Symbian to release builds. · 8cb446cb
      jocelyn.turcotte@nokia.com authored
      Reviewed by Tor Arne Vestbø.
      
      * WebCore.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55236 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cb446cb
    • eric@webkit.org's avatar
      2010-02-25 Jarkko Sakkinen <jarkko.sakkinen@tieto.com> · 17dee22d
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Qt WebGL support
      
              Adds GraphicsContext3D QtWebKit implementation.
              https://bugs.webkit.org/show_bug.cgi?id=35153
      
              * WebCore.pri:
              * WebCore.pro:
              * platform/graphics/GraphicsContext3D.h:
              * platform/graphics/qt/GraphicsContext3DQt.cpp: Added.
              (WebCore::GraphicsContext3DInternal::isValid):
              (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
              (WebCore::GraphicsContext3DInternal::~GraphicsContext3DInternal):
              (WebCore::GraphicsContext3DInternal::getProcAddress):
              (WebCore::GraphicsContext3D::create):
              (WebCore::GraphicsContext3D::GraphicsContext3D):
              (WebCore::GraphicsContext3D::~GraphicsContext3D):
              (WebCore::GraphicsContext3D::platformGraphicsContext3D):
              (WebCore::GraphicsContext3D::platformTexture):
              (WebCore::GraphicsContext3D::makeContextCurrent):
              (WebCore::GraphicsContext3D::beginPaint):
              (WebCore::GraphicsContext3D::endPaint):
              (WebCore::GraphicsContext3D::reshape):
              (WebCore::GraphicsContext3D::activeTexture):
              (WebCore::GraphicsContext3D::attachShader):
              (WebCore::GraphicsContext3D::bindAttribLocation):
              (WebCore::GraphicsContext3D::bindBuffer):
              (WebCore::GraphicsContext3D::bindFramebuffer):
              (WebCore::GraphicsContext3D::bindRenderbuffer):
              (WebCore::GraphicsContext3D::bindTexture):
              (WebCore::GraphicsContext3D::blendColor):
              (WebCore::GraphicsContext3D::blendEquation):
              (WebCore::GraphicsContext3D::blendEquationSeparate):
              (WebCore::GraphicsContext3D::blendFunc):
              (WebCore::GraphicsContext3D::blendFuncSeparate):
              (WebCore::GraphicsContext3D::bufferData):
              (WebCore::GraphicsContext3D::bufferSubData):
              (WebCore::GraphicsContext3D::checkFramebufferStatus):
              (WebCore::GraphicsContext3D::clearColor):
              (WebCore::GraphicsContext3D::clear):
              (WebCore::GraphicsContext3D::clearDepth):
              (WebCore::GraphicsContext3D::clearStencil):
              (WebCore::GraphicsContext3D::colorMask):
              (WebCore::GraphicsContext3D::compileShader):
              (WebCore::GraphicsContext3D::copyTexImage2D):
              (WebCore::GraphicsContext3D::copyTexSubImage2D):
              (WebCore::GraphicsContext3D::cullFace):
              (WebCore::GraphicsContext3D::depthFunc):
              (WebCore::GraphicsContext3D::depthMask):
              (WebCore::GraphicsContext3D::depthRange):
              (WebCore::GraphicsContext3D::detachShader):
              (WebCore::GraphicsContext3D::disable):
              (WebCore::GraphicsContext3D::disableVertexAttribArray):
              (WebCore::GraphicsContext3D::drawArrays):
              (WebCore::GraphicsContext3D::drawElements):
              (WebCore::GraphicsContext3D::enable):
              (WebCore::GraphicsContext3D::enableVertexAttribArray):
              (WebCore::GraphicsContext3D::finish):
              (WebCore::GraphicsContext3D::flush):
              (WebCore::GraphicsContext3D::framebufferRenderbuffer):
              (WebCore::GraphicsContext3D::framebufferTexture2D):
              (WebCore::GraphicsContext3D::frontFace):
              (WebCore::GraphicsContext3D::generateMipmap):
              (WebCore::GraphicsContext3D::getActiveAttrib):
              (WebCore::GraphicsContext3D::getActiveUniform):
              (WebCore::GraphicsContext3D::getAttribLocation):
              (WebCore::GraphicsContext3D::getContextAttributes):
              (WebCore::GraphicsContext3D::getError):
              (WebCore::GraphicsContext3D::getString):
              (WebCore::GraphicsContext3D::hint):
              (WebCore::GraphicsContext3D::isBuffer):
              (WebCore::GraphicsContext3D::isEnabled):
              (WebCore::GraphicsContext3D::isFramebuffer):
              (WebCore::GraphicsContext3D::isProgram):
              (WebCore::GraphicsContext3D::isRenderbuffer):
              (WebCore::GraphicsContext3D::isShader):
              (WebCore::GraphicsContext3D::isTexture):
              (WebCore::GraphicsContext3D::lineWidth):
              (WebCore::GraphicsContext3D::linkProgram):
              (WebCore::GraphicsContext3D::pixelStorei):
              (WebCore::GraphicsContext3D::polygonOffset):
              (WebCore::GraphicsContext3D::readPixels):
              (WebCore::GraphicsContext3D::releaseShaderCompiler):
              (WebCore::GraphicsContext3D::renderbufferStorage):
              (WebCore::GraphicsContext3D::sampleCoverage):
              (WebCore::GraphicsContext3D::scissor):
              (WebCore::GraphicsContext3D::shaderSource):
              (WebCore::GraphicsContext3D::stencilFunc):
              (WebCore::GraphicsContext3D::stencilFuncSeparate):
              (WebCore::GraphicsContext3D::stencilMask):
              (WebCore::GraphicsContext3D::stencilMaskSeparate):
              (WebCore::GraphicsContext3D::stencilOp):
              (WebCore::GraphicsContext3D::stencilOpSeparate):
              (WebCore::GraphicsContext3D::texParameterf):
              (WebCore::GraphicsContext3D::texParameteri):
              (WebCore::GraphicsContext3D::uniform1f):
              (WebCore::GraphicsContext3D::uniform1fv):
              (WebCore::GraphicsContext3D::uniform2f):
              (WebCore::GraphicsContext3D::uniform2fv):
              (WebCore::GraphicsContext3D::uniform3f):
              (WebCore::GraphicsContext3D::uniform3fv):
              (WebCore::GraphicsContext3D::uniform4f):
              (WebCore::GraphicsContext3D::uniform4fv):
              (WebCore::GraphicsContext3D::uniform1i):
              (WebCore::GraphicsContext3D::uniform1iv):
              (WebCore::GraphicsContext3D::uniform2i):
              (WebCore::GraphicsContext3D::uniform2iv):
              (WebCore::GraphicsContext3D::uniform3i):
              (WebCore::GraphicsContext3D::uniform3iv):
              (WebCore::GraphicsContext3D::uniform4i):
              (WebCore::GraphicsContext3D::uniform4iv):
              (WebCore::GraphicsContext3D::uniformMatrix2fv):
              (WebCore::GraphicsContext3D::uniformMatrix3fv):
              (WebCore::GraphicsContext3D::uniformMatrix4fv):
              (WebCore::GraphicsContext3D::useProgram):
              (WebCore::GraphicsContext3D::validateProgram):
              (WebCore::GraphicsContext3D::vertexAttrib1f):
              (WebCore::GraphicsContext3D::vertexAttrib1fv):
              (WebCore::GraphicsContext3D::vertexAttrib2f):
              (WebCore::GraphicsContext3D::vertexAttrib2fv):
              (WebCore::GraphicsContext3D::vertexAttrib3f):
              (WebCore::GraphicsContext3D::vertexAttrib3fv):
              (WebCore::GraphicsContext3D::vertexAttrib4f):
              (WebCore::GraphicsContext3D::vertexAttrib4fv):
              (WebCore::GraphicsContext3D::vertexAttribPointer):
              (WebCore::GraphicsContext3D::viewport):
              (WebCore::GraphicsContext3D::getBooleanv):
              (WebCore::GraphicsContext3D::getBufferParameteriv):
              (WebCore::GraphicsContext3D::getFloatv):
              (WebCore::GraphicsContext3D::getFramebufferAttachmentParameteriv):
              (WebCore::GraphicsContext3D::getIntegerv):
              (WebCore::GraphicsContext3D::getProgramiv):
              (WebCore::GraphicsContext3D::getProgramInfoLog):
              (WebCore::GraphicsContext3D::getRenderbufferParameteriv):
              (WebCore::GraphicsContext3D::getShaderiv):
              (WebCore::GraphicsContext3D::getShaderInfoLog):
              (WebCore::GraphicsContext3D::getShaderSource):
              (WebCore::GraphicsContext3D::getTexParameterfv):
              (WebCore::GraphicsContext3D::getTexParameteriv):
              (WebCore::GraphicsContext3D::getUniformfv):
              (WebCore::GraphicsContext3D::getUniformiv):
              (WebCore::GraphicsContext3D::getUniformLocation):
              (WebCore::GraphicsContext3D::getVertexAttribfv):
              (WebCore::GraphicsContext3D::getVertexAttribiv):
              (WebCore::GraphicsContext3D::getVertexAttribOffset):
              (WebCore::GraphicsContext3D::texImage2D):
              (WebCore::GraphicsContext3D::texSubImage2D):
              (WebCore::GraphicsContext3D::createBuffer):
              (WebCore::GraphicsContext3D::createFramebuffer):
              (WebCore::GraphicsContext3D::createProgram):
              (WebCore::GraphicsContext3D::createRenderbuffer):
              (WebCore::GraphicsContext3D::createShader):
              (WebCore::GraphicsContext3D::createTexture):
              (WebCore::GraphicsContext3D::deleteBuffer):
              (WebCore::GraphicsContext3D::deleteFramebuffer):
              (WebCore::GraphicsContext3D::deleteProgram):
              (WebCore::GraphicsContext3D::deleteRenderbuffer):
              (WebCore::GraphicsContext3D::deleteShader):
              (WebCore::GraphicsContext3D::deleteTexture):
              (WebCore::GraphicsContext3D::sizeInBytes):
              (WebCore::GraphicsContext3D::synthesizeGLError):
              (WebCore::GraphicsContext3D::getImageData):
      2010-02-25  Jarkko Sakkinen  <jarkko.sakkinen@tieto.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Qt WebGL support
      
              Adds enabling and disabling of WebGL support to QWebSettings.
              https://bugs.webkit.org/show_bug.cgi?id=35153
      
              * Api/qwebsettings.cpp:
              (QWebSettingsPrivate::apply):
              (QWebSettings::QWebSettings):
              * Api/qwebsettings.h:
      2010-02-25  Jarkko Sakkinen  <jarkko.sakkinen@tieto.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Qt WebGL support
      
              Adds toggling of WebGL support to QtLauncher.
              https://bugs.webkit.org/show_bug.cgi?id=35153
      
              * QtLauncher/main.cpp:
              (LauncherWindow::toggleWebGL):
              (LauncherWindow::setupUI):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55235 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      17dee22d
    • eric@webkit.org's avatar
      2010-02-25 Jochen Eisinger <jochen@chromium.org> · 95c6e9da
      eric@webkit.org authored
              Reviewed by Jeremy Orlow.
      
              Make the context that was passed to the ThreadFunction accessible.
              https://bugs.webkit.org/show_bug.cgi?id=35379
      
              * wtf/Threading.h:
              * wtf/ThreadingNone.cpp:
              (WTF::threadContext):
              * wtf/ThreadingPthreads.cpp:
              (WTF::):
              (WTF::identifierByPthreadHandle):
              (WTF::establishIdentifierForPthreadHandle):
              (WTF::pthreadHandleForIdentifier):
              (WTF::contextForIdentifier):
              (WTF::createThreadInternal):
              (WTF::currentThread):
              (WTF::threadContext):
              * wtf/ThreadingWin.cpp:
              (WTF::):
              (WTF::threadMap):
              (WTF::storeThreadHandleByIdentifier):
              (WTF::threadHandleForIdentifier):
              (WTF::contextForIdentifier):
              (WTF::createThreadInternal):
              (WTF::threadContext):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55234 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95c6e9da
    • pfeldman@chromium.org's avatar
      2010-02-25 Pavel Feldman <pfeldman@chromium.org> · 58bf4747
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Swap images for activate and deactivate breakpoints.
      
              https://bugs.webkit.org/show_bug.cgi?id=35383
      
              * WebCore.gypi:
              * inspector/front-end/Images/breakpointsActivateButtonGlyph.png: Renamed from WebCore/inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png.
              * inspector/front-end/Images/breakpointsDeactivateButtonGlyph.png: Renamed from WebCore/inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png.
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55233 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58bf4747
    • kov@webkit.org's avatar
      2010-02-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 16ccb995
      kov@webkit.org authored
              Reviewed by Xan Lopez.
      
              Go back on symlink resolution if we are loading the flash plugin,
              and the path contains /netscape/, following what Chromium does.
      
              Thanks to Evan Martin for the help on this!
      
              * plugins/gtk/PluginPackageGtk.cpp:
              (WebCore::PluginPackage::load):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55232 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16ccb995
    • pfeldman@chromium.org's avatar
      2010-02-23 Pavel Feldman <pfeldman@chromium.org> · beffff7c
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Scripts panel shows blank source when stopping on a breakpoint on refresh.
      
              https://bugs.webkit.org/show_bug.cgi?id=35232
      
              * inspector/front-end/Panel.js:
              (WebInspector.Panel.prototype.canShowSourceLine):
              (WebInspector.Panel.prototype.showSourceLine):
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.canShowSourceLine):
              (WebInspector.ResourcesPanel.prototype.showSourceLine):
              * inspector/front-end/Script.js:
              (WebInspector.Script):
              * inspector/front-end/ScriptView.js:
              (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype.show):
              (WebInspector.ScriptsPanel.prototype.get searchableViews):
              (WebInspector.ScriptsPanel.prototype.addScript):
              (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
              (WebInspector.ScriptsPanel.prototype.addBreakpoint):
              (WebInspector.ScriptsPanel.prototype.removeBreakpoint):
              (WebInspector.ScriptsPanel.prototype.reset):
              (WebInspector.ScriptsPanel.prototype.canShowSourceLine):
              (WebInspector.ScriptsPanel.prototype.showSourceLine):
              (WebInspector.ScriptsPanel.prototype._scriptOrResourceForURLAndLine):
              (WebInspector.ScriptsPanel.prototype.showView):
              (WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
              (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
              (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu.optionCompare):
              (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
              * inspector/front-end/SourceView.js:
              (WebInspector.SourceView.prototype._addBreakpoint):
              * inspector/front-end/inspector.js:
              (WebInspector.documentClick.followLink):
              (WebInspector.documentClick):
              (WebInspector._choosePanelToShowSourceLine):
              (WebInspector.canShowSourceLine):
              (WebInspector.showSourceLine):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55231 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      beffff7c
    • eric@webkit.org's avatar
      2010-02-25 Ben Murdoch <benm@google.com> · d72a19c1
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              The target element of a Touch should be the target where that touch originated, not where it is now.
              https://bugs.webkit.org/show_bug.cgi?id=34585
      
              * fast/events/touch/basic-single-touch-events-expected.txt: Update expected target element.
              * fast/events/touch/script-tests/basic-single-touch-events.js: ditto.
              * fast/events/touch/script-tests/touch-target.js: Added.
              * fast/events/touch/touch-target-expected.txt: Added.
              * fast/events/touch/touch-target.html: Added.
      2010-02-25  Ben Murdoch  <benm@google.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              The target element of a Touch should be the target where that touch originated, not where it is now.
              https://bugs.webkit.org/show_bug.cgi?id=34585
      
              Currently the target of a touch is set to the resulting node of the hit test where the touch currently
              is. This does not match the behavior of iPhone or Android. This patch uses a hashmap on the EventHandler
              to keep track of the target element when a touch is first started. This target is then used as the target
              for subsequent touches with the same id. This matches observed behavior on iPhone and Android.
      
              Tests:
              fast/events/touch/touch-target.html: Added.
              fast/events/touch/basic-single-touch-events.html: Updated.
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::handleTouchEvent): Store the originating target element of a touch in a hashmap
                  so that we can reuse that target for future events caused by that touch. This matches observed behavior
                  on iPhone and Android.
              * page/EventHandler.h: Add hashmap as a member.
              * platform/PlatformTouchPoint.h:
              (WebCore::PlatformTouchPoint::id): Store the touch point id as unsigned.
              * platform/qt/PlatformTouchPointQt.cpp:
              (WebCore::PlatformTouchPoint::PlatformTouchPoint): Cast platform touch id from signed to unsigned. Qt API
                  docs state that it will always be >= 0.
      2010-02-25  Ben Murdoch  <benm@google.com>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              The target element of a Touch should be the target where that touch originated, not where it is now.
              https://bugs.webkit.org/show_bug.cgi?id=34585
      
              * DumpRenderTree/qt/EventSenderQt.cpp:
              (EventSender::addTouchPoint): Fix a bug where touch points were not being given unique ids.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d72a19c1
    • xan@webkit.org's avatar
      2010-02-25 Xan Lopez <xlopez@igalia.com> · feaa2a70
      xan@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              Unskip a bunch of (AFAICT) non-flakey HTTP tests that we currently
              pass.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55229 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      feaa2a70
    • tonikitoo@webkit.org's avatar
      Add a convenient center() method to IntRect · 6fe487e0
      tonikitoo@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=35346
      
      Reviewed by Simon Fraser.
      Patch by Antonio Gomes <tonikitoo@webkit.org>
      
      As it is a convenience method, and implemention is
      based on FloatRect's one, patch does not provide a
      layout test.
      
      * platform/graphics/IntRect.h:
      (WebCore::IntRect::center):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6fe487e0
    • eric@webkit.org's avatar
      2010-02-25 Andrey Kosyakov <caseq@chromium.org> · 700c5b0d
      eric@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Fake workers implementation that simulates workers using iframe and timer,
              needed to support workers debugging. Also, a facility to inject scripts into
              inspected page upon load.
              https://bugs.webkit.org/show_bug.cgi?id=35148
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/InspectorBackend.cpp:
              (WebCore::InspectorBackend::addScriptToEvaluateOnLoad):
              (WebCore::InspectorBackend::removeAllScriptsToEvaluateOnLoad):
              * inspector/InspectorBackend.h:
              * inspector/InspectorBackend.idl:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::didCommitLoad):
              (WebCore::InspectorController::addScriptToEvaluateOnLoad):
              (WebCore::InspectorController::removeAllScriptsToEvaluateOnLoad):
              * inspector/InspectorController.h:
              * inspector/front-end/InjectedFakeWorker.js: Added.
              (InjectedFakeWorker.Worker):
              (InjectedFakeWorker.FakeWorker):
              (InjectedFakeWorker.FakeWorker.prototype.postMessage):
              (InjectedFakeWorker.FakeWorker.prototype.terminate):
              (InjectedFakeWorker.FakeWorker.prototype._onmessageWrapper):
              (InjectedFakeWorker.FakeWorker.prototype._dispatchMessage):
              (InjectedFakeWorker.FakeWorker.prototype._handleException):
              (InjectedFakeWorker.FakeWorker.prototype._buildWorker):
              (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext.handler):
              (InjectedFakeWorker.FakeWorker.prototype._setupWorkerContext):
              (InjectedFakeWorker.FakeWorker.prototype._importScripts):
              (InjectedFakeWorker.FakeWorker.prototype._loadScript):
              (InjectedFakeWorker.URL):
              (InjectedFakeWorker.URL.prototype.urlRegEx.split):
              (InjectedFakeWorker.URL.prototype.mockLocation):
              (InjectedFakeWorker.URL.prototype.completeWith):
              (InjectedFakeWorker.URL.prototype.sameOrigin):
              (InjectedFakeWorker.DOMCoreException.formatError):
              (InjectedFakeWorker.DOMCoreException):
              (InjectedFakeWorker.noop):
              * inspector/front-end/InspectorBackendStub.js:
              (.WebInspector.InspectorBackendStub.prototype.setInjectedScriptSource):
              (.WebInspector.InspectorBackendStub.prototype.addScriptToEvaluateOnLoad):
              (.WebInspector.InspectorBackendStub.prototype.removeAllScriptsToEvaluateOnLoad):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55227 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      700c5b0d
    • eric@webkit.org's avatar
      2010-02-24 Sam Kerner <skerner@chromium.org> · f3a0e5dc
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Expose WebFrame::setCanHaveScrollbars().  This allows a view
              which is being resized to not need scroll bars to ensure that
              they are not drawn.
      
              Existing function setAllowsScrolling() was renamed
              setCanHaveScrollbars(), to be consistant with change 37159:
              http://trac.webkit.org/changeset/37159
      
              https://bugs.webkit.org/show_bug.cgi?id=35257
      
              * WebKit/chromium/public/WebFrame.h:
              * WebKit/chromium/src/ChromeClientImpl.cpp:
              * WebKit/chromium/src/WebFrameImpl.cpp:
              * WebKit/chromium/src/WebFrameImpl.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55226 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3a0e5dc
    • eric@webkit.org's avatar
      2010-02-24 Nicholas Young <nicholas.young@nokia.com> · 525cdb2d
      eric@webkit.org authored
              Reviewed by Eric Carlson.
      
              Add mediaPlayerOwningDocument() to MediaPlayerClient.
              https://bugs.webkit.org/show_bug.cgi?id=35374
      
              No new tests. These are interface changes only.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::mediaPlayerOwningDocument): Implementation for media element.
              * html/HTMLMediaElement.h:
              * platform/graphics/MediaPlayer.h:
              (WebCore::MediaPlayerClient::mediaPlayerOwningDocument): New virtual method.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      525cdb2d
  2. 24 Feb, 2010 1 commit