1. 06 May, 2010 3 commits
  2. 05 May, 2010 2 commits
    • jianli@chromium.org's avatar
      XMLHttpRequestUpload events do not fire when sending a raw file or FormData object. · b4605b49
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=37771
      
      Reviewed by David Levin.
      
      WebCore:
      
      Test: http/tests/local/formdata/upload-events.html
      
      * xml/XMLHttpRequest.cpp:
      (WebCore::XMLHttpRequest::createRequest):
      
      LayoutTests:
      
      Add a layout test to test upload events firing.
      
      * http/tests/local/formdata/resources/send-form-data-common.js:
      (dumpResponse):
      (sendFormData):
      (testSendingFormData):
      * http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js:
      * http/tests/local/formdata/script-tests/send-form-data.js:
      * http/tests/local/formdata/script-tests/upload-events.js: Added.
      * http/tests/local/formdata/upload-events-expected.txt: Added.
      * http/tests/local/formdata/upload-events.html: Added.
      * platform/gtk/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in gtk platform.
      * platform/qt/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in qt platform.
      * platform/win/Skipped: Skip the new test because eventSender.beginDragWithFiles is not supported in win platform.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58841 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4605b49
    • xan@webkit.org's avatar
      2010-05-05 Xan Lopez <xlopez@igalia.com> · 823fba27
      xan@webkit.org authored
              Skip flakey workers test.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      823fba27
  3. 04 May, 2010 2 commits
  4. 30 Apr, 2010 1 commit
  5. 29 Apr, 2010 3 commits
  6. 28 Apr, 2010 3 commits
    • tonikitoo@webkit.org's avatar
      2010-04-25 Antonio Gomes <tonikitoo@webkit.org> · 444dff87
      tonikitoo@webkit.org authored
              Reviewed by Darin Adler.
      
              Clicking a scrollbar blurs the currently focused element
              https://bugs.webkit.org/show_bug.cgi?id=16809
      
              WebKit ports that do not use native (platform) widgets for rendering the scrollbars
              are currently mismatching a common behaviour of other browser vendors (including
              Firefox and Opera): clicking on a frame scrollbar *should not* steal focus from content.
              WebKit browsers based ports that do use WebCore for handling scrollbars, like QtWebKit for
              instance, can observe the opposite behaviour.
      
              Patch fixes this behaviour by checking if current MouseDown event targets a frame scrollbar.
              If that is the case, it bails out and do not change focus behavior at all.
      
              It is important to note that the given way this is implemented by this patch, non-frame
              scrollbars (e.g. a vertical scrollbar of an overflowed textareas or divs) will keep working
              in the same way as it works currently.
      
              Tests: scrollbars/scrollbar-click-does-not-blur-content.html
                     scrollbars/scrollbar-iframe-click-does-not-blur-content.html
      
              * page/EventHandler.cpp:
              (WebCore::EventHandler::dispatchMouseEve
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      444dff87
    • mrobinson@webkit.org's avatar
      2010-04-28 Martin Robinson <mrobinson@webkit.org> · 7b36a573
      mrobinson@webkit.org authored
              Reviewed by Gustavo Noronha.
      
              [GTK] Enable DOM clipboard and drag-and-drop access
              https://bugs.webkit.org/show_bug.cgi?id=30623
      
              Make ClipboardGtk a "live" DataTransfer object, able to modify
              the clipboard when setData(...) is called.
      
              * platform/gtk/Skipped: Uncomment tests that are now passing.
      2010-04-28  Martin Robinson  <mrobinson@webkit.org>
      
              Reviewed by Gustavo Noronha.
      
              [GTK] Enable DOM clipboard and drag-and-drop access
              https://bugs.webkit.org/show_bug.cgi?id=30623
      
              Make ClipboardGtk a "live" DataTransfer object, able to modify
              the clipboard when setData(...) is called.
      
              * platform/gtk/ClipboardGtk.cpp:
              (WebCore::Editor::newGeneralClipboard): Pass the GtkClipboard into the factory method.
              (WebCore::ClipboardGtk::ClipboardGtk): Create two separate constructors, one for DnD data and one for clipboard data.
              (WebCore::dataObjectTypeFromHTMLClipboardType): Added.
              (WebCore::ClipboardGtk::clearData): Clear the member DataObject, optionally write the clipboard.
              (WebCore::ClipboardGtk::clearAllData): Ditto.
              (WebCore::joinURIList): Added.
              (WebCore::ClipboardGtk::getData): Get the data from the clipboard, if possible.
              (WebCore::ClipboardGtk::setData): Write data to the DataObject and maybe the clipboard.
              (WebCore::ClipboardGtk::types): Read the clipboard/DataObject to find applicable types.
              (WebCore::ClipboardGtk::files): Read the clipboard/DataObject to find the files.
              (WebCore::ClipboardGtk::writeURL): Write to the DataObject and maybe the clipboard.
              (WebCore::ClipboardGtk::writeRange): Ditto.
              (WebCore::ClipboardGtk::writePlainText): Ditto.
              (WebCore::ClipboardGtk::hasData): Query the clipboard/DataObject.
              * platform/gtk/ClipboardGtk.h:
              (WebCore::ClipboardGtk::create): Added one factory for pasteboard-backed DataObjects and one for DnD-backed objects.
              * platform/gtk/DataObjectGtk.cpp:
              (WebCore::replaceNonBreakingSpaceWithSpace): Added this helper function to clean &nbsp; from plain text.
              (WebCore::DataObjectGtk::markup): Actually return the range if it's set.
              (WebCore::DataObjectGtk::setText): Clean &nbsp; from plain text.
              (WebCore::DataObjectGtk::clearText): Added.
              (WebCore::DataObjectGtk::clearMarkup): Added.
              * platform/gtk/DataObjectGtk.h:
              (WebCore::DataObjectGtk::clearURIList): Added.
              (WebCore::DataObjectGtk::clearImage): Added.
              * platform/gtk/PasteboardHelper.cpp:
              (WebCore::PasteboardHelper::initializeTargetList): Added target ID's for URI list and Netscape URL targets.
              (WebCore::urisToKURLVector): Added.
              (WebCore::PasteboardHelper::getClipboardContents): Added.
              (WebCore::PasteboardHelper::fillSelectionData): Added logic for URI lists and Netscape URLs.
              (WebCore::PasteboardHelper::targetListForDataObject): Ditto.
              * platform/gtk/PasteboardHelper.h: Added default argument to writeClipboardContents and new method.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7b36a573
    • alex@webkit.org's avatar
      2010-04-28 Alejandro G. Castro <alex@igalia.com> · cad91b66
      alex@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] Failing test http/tests/misc/isindex-with-no-form.html
              https://bugs.webkit.org/show_bug.cgi?id=30815
      
              The test currently works, removing from Skipped.
      
              * platform/gtk/Skipped:
      
      * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58417 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cad91b66
  7. 25 Apr, 2010 1 commit
    • eric@webkit.org's avatar
      2010-04-25 yael aharon <yael.aharon@nokia.com> · 82fc1e43
      eric@webkit.org authored
              Reviewed by Adele Peterson.
      
              Allow styling of HTMLProgressElement.
              https://bugs.webkit.org/show_bug.cgi?id=37901
      
              Added a test for changing the -webkit-appearance statically and dynamically.
      
              * fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html: Added.
              * platform/chromium/test_expectations.txt:
              * platform/gtk/Skipped:
              * platform/mac/fast/dom/HTMLProgressElement: Added.
              * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Added.
              * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
              * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt: Added.
              * platform/qt/Skipped:
              * platform/win/Skipped:
      2010-04-25  yael aharon  <yael.aharon@nokia.com>
      
              Reviewed by Adele Peterson.
      
              Allow styling of HTMLProgressElement.
              https://bugs.webkit.org/show_bug.cgi?id=37901
      
              Added a new pseudo element to represent the value portion of the progress element.
              Web developers can style this pseudo element separate from the rest of the progress element.
      
              Test: fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html
      
              * css/CSSPrimitiveValueMappings.h:
              (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
              * css/CSSSelector.cpp:
              (WebCore::CSSSelector::pseudoId):
              (WebCore::nameToPseudoTypeMap):
              (WebCore::CSSSelector::extractPseudoType):
              * css/CSSSelector.h:
              * css/CSSValueKeywords.in:
              * platform/ThemeTypes.h:
              * rendering/RenderProgress.cpp:
              (WebCore::ProgressValueElement::isShadowNode):
              (WebCore::ProgressValueElement::shadowParentNode):
              (WebCore::ProgressValueElement::ProgressValueElement):
              (WebCore::RenderProgress::RenderProgress):
              (WebCore::RenderProgress::~RenderProgress):
              (WebCore::RenderProgress::layout):
              (WebCore::RenderProgress::styleDidChange):
              (WebCore::RenderProgress::updateFromElement):
              (WebCore::RenderProgress::updateValuePartState):
              (WebCore::RenderProgress::createStyleForValuePart):
              (WebCore::RenderProgress::updateAnimationState):
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::isControlStyled):
              * rendering/RenderProgress.h:
              * rendering/style/RenderStyleConstants.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58228 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82fc1e43
  8. 22 Apr, 2010 2 commits
    • mjs@apple.com's avatar
      2010-04-22 Maciej Stachowiak <mjs@apple.com> · a37664ef
      mjs@apple.com authored
              Reviewed by Dan Bernstein.
      
              Links around blocks (e.g. divs) results in too many VoiceOver call outs
              https://bugs.webkit.org/show_bug.cgi?id=37079
      
              The basic change is to modify the AccessibilityRenderObject tree
              traversal methods to account for inline continuations in the
              render tree and make the accessibility tree look as if
              continuations didn't exist - the same as if CSS blocks could just
              sit in CSS inlines. This is slightly tricky code but creates a
              much saner accessibility tree.
              
              Tests: accessibility/image-link-inline-cont.html
                     accessibility/image-link.html
                     accessibility/inline-continuations.html
      
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::isInlineWithContinuation): Helper function for traversal functions to use in accounting for continuations.
              (WebCore::firstChildInContinuation): ditto
              (WebCore::firstChildConsideringContinuation): ditto
              (WebCore::lastChildConsideringContinuation): ditto
              (WebCore::startOfContinuations): ditto
              (WebCore::endOfContinuations): ditto
              (WebCore::childBeforeConsideringContinuations): ditto
              (WebCore::firstChildIsInlineContinuation): ditto
              (WebCore::lastChildHasContinuation): ditto
              (WebCore::AccessibilityRenderObject::firstChild): Account for inline continuations.
              (WebCore::AccessibilityRenderObject::lastChild): ditto
              (WebCore::AccessibilityRenderObject::previousSibling): Account for inline continuations
              and their anonymous block parents.
              (WebCore::AccessibilityRenderObject::nextSibling): ditto
              (WebCore::AccessibilityRenderObject::parentObjectIfExists): Account for inline continuations.
              (WebCore::AccessibilityRenderObject::parentObject): Account for inline continuations.
              * rendering/RenderInline.h: Make RenderInline::inlineContinuation public.
      2010-04-22  Maciej Stachowiak  <mjs@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Links around blocks (e.g. divs) results in too many VoiceOver call outs
              https://bugs.webkit.org/show_bug.cgi?id=37079
              
              The new test cases verify the accessibility tree created by an image inside a link, and verify
              that adding a div with role=presentation now has no effect on the accessibility tree (as expected).
      
              * accessibility/image-link-inline-cont-expected.txt: Added.
              * accessibility/image-link-inline-cont.html: Added.
              * accessibility/image-link.html: Added.
              * platform/gtk/Skipped:
              * platform/mac/accessibility/image-link-expected.txt: Added.
              * platform/win/Skipped:
              
              Test to check that accessibility tree doesn't get duplicate content in the presence
              of inline continuations (this was a bug in an earlier version of this patch).
      
              * accessibility/inline-continuations-expected.txt: Added.
              * accessibility/inline-continuations.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a37664ef
    • dglazkov@chromium.org's avatar
      2010-04-22 Dave Moore <davemoore@chromium.org> · 89ffc2a0
      dglazkov@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              Add test for icon change notifications.
      
              https://bugs.webkit.org/show_bug.cgi?id=33812
      
              * fast/dom/icon-url-property-expected.txt: Added.
              * fast/dom/icon-url-property.html: Added.
              * Skipped on all platforms but Win
      2010-04-22  Dave Moore  <davemoore@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Added notification when the favicons for a page are changed
              from a script.
              The Document object will notify the frame loader, which will
              notify the client. Implementations of FrameLoaderClient will
              have to add one method; dispatchDidChangeIcons().
      
              https://bugs.webkit.org/show_bug.cgi?id=33812
      
              Test: fast/dom/icon-url-property.html
      
              * dom/Document.cpp:
              (WebCore::Document::setIconURL):
              * loader/DocumentLoader.cpp:
              (WebCore::DocumentLoader::setIconURL):
              * loader/DocumentLoader.h:
              (WebCore::DocumentLoader::iconURL):
              * loader/EmptyClients.h:
              (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::setIconURL):
              (WebCore::FrameLoader::didChangeIcons):
              * loader/FrameLoader.h:
              * loader/FrameLoaderClient.h:
      2010-04-22  Dave Moore  <davemoore@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Added notification when the favicons for a page are changed
              from a script.
              The Document object will notify the frame loader, which will
              notify the client. Implementations of FrameLoaderClient will
              have to add one method; dispatchDidChangeIcons().
      
              https://bugs.webkit.org/show_bug.cgi?id=33812
      
              * public/WebFrameClient.h:
              (WebKit::WebFrameClient::didChangeIcons):
              * src/FrameLoaderClientImpl.cpp:
              (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
              * src/FrameLoaderClientImpl.h:
      2010-04-22  Dave Moore  <davemoore@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Added notification when the favicons for a page are changed
              from a script.
              The Document object will notify the frame loader, which will
              notify the client. Implementations of FrameLoaderClient will
              have to add one method; dispatchDidChangeIcons().
      
              * WebCoreSupport/FrameLoaderClientGtk.cpp:
              (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
              * WebCoreSupport/FrameLoaderClientGtk.h:
      2010-04-22  Dave Moore  <davemoore@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Added notification when the favicons for a page are changed
              from a script.
              The Document object will notify the frame loader, which will
              notify the client. Implementations of FrameLoaderClient will
              have to add one method; dispatchDidChangeIcons().
      
              https://bugs.webkit.org/show_bug.cgi?id=33812
      
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchDidChangeIcons):
      2010-04-22  Dave Moore  <davemoore@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Added notification when the favicons for a page are changed
              from a script.
              The Document object will notify the frame loader, which will
              notify the client. Implementations of FrameLoaderClient will
              have to add one method; dispatchDidChangeIcons().
      
              https://bugs.webkit.org/show_bug.cgi?id=33812
      
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
              (WebCore::FrameLoaderClientQt::didChangeTitle):
              * WebCoreSupport/FrameLoaderClientQt.h:
      2010-04-22  Dave Moore  <davemoore@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Added notification when the favicons for a page are changed
              from a script.
              The Document object will notify the frame loader, which will
              notify the client. Implementations of FrameLoaderClient will
              have to add one method; dispatchDidChangeIcons().
      
              https://bugs.webkit.org/show_bug.cgi?id=33812
      
              * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
              * WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebFrameLoaderClient::dispatchDidChangeIcons):
              * WebCoreSupport/WebFrameLoaderClient.h:
              * WebFrame.cpp:
              (WebFrame::didChangeIcons):
              * WebFrame.h:
      2010-04-22  Dave Moore  <davemoore@chromium.org>
      
              Reviewed by Dimitri Glazkov.
      
              Add test support for icon changes.
      
              https://bugs.webkit.org/show_bug.cgi?id=33812
      
              * DumpRenderTree/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (dumpIconChangesCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              (LayoutTestController::dumpIconChanges):
              (LayoutTestController::setDumpIconChanges):
              * DumpRenderTree/win/FrameLoadDelegate.cpp:
              (FrameLoadDelegate::didChangeIcons):
              * DumpRenderTree/win/FrameLoadDelegate.h:
              * WinLauncher/WinLauncher.h:
              (WinLauncherWebHost::didChangeIcons):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      89ffc2a0
  9. 21 Apr, 2010 2 commits
    • johnnyg@google.com's avatar
      2010-04-15 John Gregg <johnnyg@google.com> · c984cf3b
      johnnyg@google.com authored
              Reviewed by David Levin.
      
              Enable the notifications layout tests, but skip them on the ports that don't
              implement notifications.
              https://bugs.webkit.org/show_bug.cgi?id=37667
      
              * fast/notifications/notifications-check-permission.html: Added.
              * fast/notifications/notifications-check-permission.html-disabled: Removed.
              * fast/notifications/notifications-display-close-events.html: Added.
              * fast/notifications/notifications-display-close-events.html-disabled: Removed.
              * fast/notifications/notifications-double-show.html: Added.
              * fast/notifications/notifications-double-show.html-disabled: Removed.
              * fast/notifications/notifications-no-icon.html: Added.
              * fast/notifications/notifications-no-icon.html-disabled: Removed.
              * fast/notifications/notifications-request-permission.html: Added.
              * fast/notifications/notifications-request-permission.html-disabled: Removed.
              * fast/notifications/notifications-with-permission.html: Added.
              * fast/notifications/notifications-with-permission.html-disabled: Removed.
              * fast/notifications/notifications-without-permission.html: Added.
              * fast/notifications/notifications-without-permission.html-disabled: Removed.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt/Skipped:
              * platform/win/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c984cf3b
    • alex@webkit.org's avatar
      2010-04-21 Alejandro G. Castro <alex@igalia.com> · a3baa0c2
      alex@webkit.org authored
              Rubber-stamped by Xan Lopez.
      
              Skipping fast/frames/frame-crash-with-page-cache.html
              https://bugs.webkit.org/show_bug.cgi?id=37914
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a3baa0c2
  10. 20 Apr, 2010 1 commit
  11. 19 Apr, 2010 2 commits
    • mrowe@apple.com's avatar
      Roll out r57823. · b0cd47b8
      mrowe@apple.com authored
      It adds methods to IWebFrameLoadDelegatePrivate2, a delegate interface that is implemented
      by shipping clients of WebKit on Windows.  Adding methods to a delegate interface in this
      manner breaks ABI compatibility and leads to crashes or other unexpected behavior when the
      methods are used.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57856 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0cd47b8
    • dglazkov@chromium.org's avatar
      WebCore: Added notification when the favicons for a page are changed · e5916262
      dglazkov@chromium.org authored
      from a script.
      The Document object will notify the frame loader, which will
      notify the client. Implementations of FrameLoaderClient will
      have to add one method; dispatchDidChangeIcons().
      
      Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
      Reviewed by Dimitri Glazkov.
      
      https://bugs.webkit.org/show_bug.cgi?id=33812
      
      Test: fast/dom/icon-url-property.html
      
      * dom/Document.cpp:
      (WebCore::Document::setIconURL):
      * loader/DocumentLoader.cpp:
      (WebCore::DocumentLoader::setIconURL):
      * loader/DocumentLoader.h:
      (WebCore::DocumentLoader::iconURL):
      * loader/EmptyClients.h:
      (WebCore::EmptyFrameLoaderClient::dispatchDidChangeIcons):
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::setIconURL):
      (WebCore::FrameLoader::didChangeIcons):
      * loader/FrameLoader.h:
      * loader/FrameLoaderClient.h:
      
      WebKit/chromium: Added notification when the favicons for a page are changed
      from a script.
      The Document object will notify the frame loader, which will
      notify the client. Implementations of FrameLoaderClient will
      have to add one method; dispatchDidChangeIcons().
      
      Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
      Reviewed by Dimitri Glazkov.
      
      https://bugs.webkit.org/show_bug.cgi?id=33812
      
      * public/WebFrameClient.h:
      (WebKit::WebFrameClient::didChangeIcons):
      * src/FrameLoaderClientImpl.cpp:
      (WebKit::FrameLoaderClientImpl::dispatchDidChangeIcons):
      * src/FrameLoaderClientImpl.h:
      
      WebKit/gtk: Added notification when the favicons for a page are changed
      from a script.
      The Document object will notify the frame loader, which will
      notify the client. Implementations of FrameLoaderClient will
      have to add one method; dispatchDidChangeIcons().
      
      Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
      Reviewed by Dimitri Glazkov.
      
      https://bugs.webkit.org/show_bug.cgi?id=33812
      
      * WebCoreSupport/FrameLoaderClientGtk.cpp:
      (WebKit::FrameLoaderClient::dispatchDidChangeIcons):
      * WebCoreSupport/FrameLoaderClientGtk.h:
      
      WebKit/mac: Added notification when the favicons for a page are changed
      from a script.
      The Document object will notify the frame loader, which will
      notify the client. Implementations of FrameLoaderClient will
      have to add one method; dispatchDidChangeIcons().
      
      Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
      Reviewed by Dimitri Glazkov.
      
      https://bugs.webkit.org/show_bug.cgi?id=33812
      
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebCoreSupport/WebFrameLoaderClient.mm:
      (WebFrameLoaderClient::dispatchDidChangeIcons):
      
      WebKit/qt: Added notification when the favicons for a page are changed
      from a script.
      The Document object will notify the frame loader, which will
      notify the client. Implementations of FrameLoaderClient will
      have to add one method; dispatchDidChangeIcons().
      
      Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
      Reviewed by Dimitri Glazkov.
      
      https://bugs.webkit.org/show_bug.cgi?id=33812
      
      * WebCoreSupport/FrameLoaderClientQt.cpp:
      (WebCore::FrameLoaderClientQt::dispatchDidChangeIcons):
      (WebCore::FrameLoaderClientQt::didChangeTitle):
      * WebCoreSupport/FrameLoaderClientQt.h:
      
      WebKit/win: Added notification when the favicons for a page are changed
      from a script.
      The Document object will notify the frame loader, which will
      notify the client. Implementations of FrameLoaderClient will
      have to add one method; dispatchDidChangeIcons().
      
      Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
      Reviewed by Dimitri Glazkov.
      
      https://bugs.webkit.org/show_bug.cgi?id=33812
      
      * Interfaces/IWebFrameLoadDelegatePrivate2.idl:
      * WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebFrameLoaderClient::dispatchDidChangeIcons):
      * WebCoreSupport/WebFrameLoaderClient.h:
      * WebFrame.cpp:
      (WebFrame::didChangeIcons):
      * WebFrame.h:
      
      WebKitTools: Add test support for icon changes.
      
      Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
      Reviewed by Dimitri Glazkov.
      
      https://bugs.webkit.org/show_bug.cgi?id=33812
      
      * DumpRenderTree/LayoutTestController.cpp:
      (LayoutTestController::LayoutTestController):
      (dumpIconChangesCallback):
      (LayoutTestController::staticFunctions):
      * DumpRenderTree/LayoutTestController.h:
      (LayoutTestController::dumpIconChanges):
      (LayoutTestController::setDumpIconChanges):
      * DumpRenderTree/win/FrameLoadDelegate.cpp:
      (FrameLoadDelegate::didChangeIcons):
      * DumpRenderTree/win/FrameLoadDelegate.h:
      * WinLauncher/WinLauncher.h:
      (WinLauncherWebHost::didChangeIcons):
      
      LayoutTests: Add test for icon change notifications.
      
      Patch by Dave Moore <davemoore@chromium.org> on 2010-04-19
      Reviewed by Dimitri Glazkov.
      
      https://bugs.webkit.org/show_bug.cgi?id=33812
      
      * fast/dom/icon-url-property-expected.txt: Added.
      * fast/dom/icon-url-property.html: Added.
      * Skipped on all platforms but Win
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57823 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5916262
  12. 17 Apr, 2010 2 commits
  13. 15 Apr, 2010 2 commits
    • jianli@chromium.org's avatar
      Unreviewed. · 333ccf7c
      jianli@chromium.org authored
      Updated Skipped list to use the right directory due to directory
      shuffling at r57695.
      
      * platform/gtk/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      333ccf7c
    • jianli@chromium.org's avatar
      Support using FormData to send a sliced file via XHR. · d8be2d18
      jianli@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=36678
      
      Reviewed by Dmitry Titov.
      
      WebCore:
      
      Tests: http/tests/local/formdata/send-form-data-with-sliced-file.html
      
      * html/Blob.h:
      (WebCore::Blob::isFile):
      * html/DOMFormData.cpp:
      (WebCore::DOMFormData::append):
      * html/File.h:
      (WebCore::File::isFile):
      * html/FormDataList.h:
      (WebCore::FormDataList::appendBlob):
      (WebCore::FormDataList::Item::Item):
      (WebCore::FormDataList::Item::blob):
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::appendFormData):
      * platform/network/FormData.cpp:
      (WebCore::FormData::appendDOMFormData):
      * platform/network/mac/FormDataStreamMac.mm:
      (WebCore::closeCurrentStream):
      
      LayoutTests:
      
      Move common functionality to test sending FormData into a helper file
      so that it can be shared by FormData layout tests.
      Also move the form data testing files to a new subdirectory formdata/.
      
      * http/tests/local/formdata/resources/send-form-data-common.js: Added.
      * http/tests/local/formdata/script-tests/TEMPLATE.html: Added.
      * http/tests/local/formdata/script-tests/send-form-data-with-sliced-file.js: Added.
      * http/tests/local/formdata/script-tests/send-form-data.js: Added.
      * http/tests/local/formdata/send-form-data-expected.txt: Renamed from LayoutTests/http/tests/local/send-form-data-expected.txt.
      * http/tests/local/formdata/send-form-data-with-sliced-file-expected.txt: Added.
      * http/tests/local/formdata/send-form-data-with-sliced-file.html: Added.
      * http/tests/local/formdata/send-form-data.html: Added.
      * http/tests/local/resources/send-form-data.js: Removed.
      * http/tests/local/send-form-data.html: Removed.
      * platform/gtk/Skipped:
      * platform/qt/Skipped:
      * platform/win/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@57695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d8be2d18
  14. 14 Apr, 2010 13 commits
  15. 13 Apr, 2010 1 commit