- 06 May, 2010 33 commits
-
-
ojan@chromium.org authored
Reviewed by Adam Barth. editing/selection/shift-click.html fails on GTK and QT https://bugs.webkit.org/show_bug.cgi?id=38656 r58892 added this test. It's the first test for shift+click behavior, so it exposed bugs in GTK/QT. Skipping to green the bots. * platform/gtk/Skipped: * platform/qt/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58896 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
sfalken@apple.com authored
Reviewed by Adam Roben. WebFrame::paintDocumentRectToContext paints content at the wrong location https://bugs.webkit.org/show_bug.cgi?id=38651 * WebFrame.cpp: (WebFrame::paintDocumentRectToContext): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58895 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
darin@apple.com authored
Reviewed by Beth Dakin. Page::setCanStartMedia does not properly handle the case where a media listener is removed https://bugs.webkit.org/show_bug.cgi?id=38602 We can't find any real case where this causes a crash at this time, but we want to harden the code anyway. Thus there are no new regression tests. * page/Page.cpp: (WebCore::Page::removeMediaCanStartListener): Removed incorrect assertion. (WebCore::Page::setCanStartMedia): Change algorithm so we notify listeners one at a time and don't notify any listener that has already been removed from the set. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58894 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
evan@chromium.org authored
Unreviewed. Updating test expectations. [chromium] new baselines for r58886 https://bugs.webkit.org/show_bug.cgi?id=38652 * platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.txt: * platform/chromium-linux/fast/text/international/danda-space-expected.checksum: * platform/chromium-linux/fast/text/international/danda-space-expected.png: * platform/chromium-linux/fast/text/international/danda-space-expected.txt: * platform/chromium-linux/fast/text/international/thai-baht-space-expected.checksum: * platform/chromium-linux/fast/text/international/thai-baht-space-expected.png: * platform/chromium-linux/fast/text/international/thai-baht-space-expected.txt: * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58893 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
ojan@chromium.org authored
Reviewed by Darin Adler. shift+click on an existing selection doesn't work right https://bugs.webkit.org/show_bug.cgi?id=36542 NSTextView behavior is to move the end of the selection closest to the shift-click. Win/Linux behavior is to always move the focus end of the selection. * editing/selection/script-tests/shift-click.js: Added. (shiftClick): (assertSelectionString): * editing/selection/shift-click-expected.txt: Added. * editing/selection/shift-click.html: Added. * platform/win/editing/selection/shift-click-expected.txt: Added. 2010-05-05 Ojan Vafai <ojan@chromium.org> Reviewed by Darin Adler. shift+click on an existing selection doesn't work right https://bugs.webkit.org/show_bug.cgi?id=36542 NSTextView behavior is to move the end of the selection closest to the shift-click. Win/Linux behavior is to always move the focus end of the selection. Test: editing/selection/shift-click.html * page/EventHandler.cpp: (WebCore::textDistance): (WebCore::EventHandler::handleMousePressEventSingleClick): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58892 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: implement panels history traversal on Cmd+Left/Right. https://bugs.webkit.org/show_bug.cgi?id=38649 * inspector/front-end/inspector.js: (WebInspector.set currentPanel): (WebInspector.loaded): (WebInspector.documentKeyDown): (WebInspector.PanelHistory): (WebInspector.PanelHistory.prototype.canGoBack): (WebInspector.PanelHistory.prototype.goBack): (WebInspector.PanelHistory.prototype.canGoForward): (WebInspector.PanelHistory.prototype.goForward): (WebInspector.PanelHistory.prototype.setPanel): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58891 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Chromium Dev Tools: Large toolbar icons flash when dev tools is opened in docked mode. https://bugs.webkit.org/show_bug.cgi?id=38631 * src/js/DevTools.js: (devtools.domContentLoaded): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58890 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Dimitri Glazkov. Make ImageDiff depend on WebKit. When compiled from within Chromium, WTF is not a standalone dynamic library but depends on WebKit. https://bugs.webkit.org/show_bug.cgi?id=38632 * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58889 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tonikitoo@webkit.org authored
Rubber-stamped by Kenneth Christiansen. Spatial Navigation: use data url in layout tests https://bugs.webkit.org/show_bug.cgi?id=38584 In order to make Spatial Navigation layout tests more readable, patch changes the use or src=resources/iframeXXX.html by inlined sources via data uri schema. It is a polishment. * fast/events/spatial-navigation/resources/iframe.html: Removed. * fast/events/spatial-navigation/resources/iframe2.html: Removed. * fast/events/spatial-navigation/resources/iframe3.html: Removed. * fast/events/spatial-navigation/resources/iframe4.html: Removed. * fast/events/spatial-navigation/snav-iframe-no-focusable-content.html: * fast/events/spatial-navigation/snav-iframe-no-scrollable-content.html: * fast/events/spatial-navigation/snav-iframe-with-offscreen-focusable-element.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58888 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tonikitoo@webkit.org authored
[Gtk] Skipped fast/events/spatial-navigation/snav-iframe-flattening-simple.html DRT does not support frame flattening testing. https://bugs.webkit.org/show_bug.cgi?id=38650 * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58887 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
evan@chromium.org authored
Reviewed by Eric Seidel. [chromium] use glyphDataForCharacter so we hit the glyphdata cache https://bugs.webkit.org/show_bug.cgi?id=38500 Calling fontDataForCharacters() while rendering text is expensive. Examining the relevant Mac code in WebKit revealed that calling the similarly-named glyphDataForCharacters() results in caching the font data on a per-glyph basis. Since we now choose a font based on the first character in a run, we need to be careful that all the glyphs within the run use the same font. This is also similar to the WebKit Mac code. We need to remove all of the script run bits eventually and this is a step in that direction. Tests: fast/text/international/danda-space.html spacing changes slightly (now matches Firefox better) and fast/text/international/thai-baht-space.html now picks the correct (serif) font for the digits. * platform/graphics/chromium/FontLinux.cpp: (WebCore::TextRunWalker::nextScriptRun): (WebCore::TextRunWalker::setupFontForScriptRun): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58886 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mrobinson@webkit.org authored
Reviewed by Gustavo Noronha Silva. [GTK] Enable DOM clipboard and drag-and-drop access https://bugs.webkit.org/show_bug.cgi?id=30623 Convert dragging portion of drag-and-drop to use DataObjectGtk. * wtf/gobject/GRefPtr.h: Add forward declarations for GObject functions. 2010-05-06 Martin Robinson <mrobinson@webkit.org> Reviewed by Gustavo Noronha Silva. [GTK] Enable DOM clipboard and drag-and-drop access https://bugs.webkit.org/show_bug.cgi?id=30623 Convert dragging portion of drag-and-drop to use DataObjectGtk. No new tests, because functionality has not changed. * page/gtk/EventHandlerGtk.cpp: (WebCore::EventHandler::createDraggingClipboard): Pass the DataObjectGtk as a parameter here. * platform/gtk/ClipboardGtk.h: (WebCore::ClipboardGtk::create): Take the DataObject as a parameter instead of creating it here. (WebCore::Clip... -
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: Do not show content tab for resources not supporting content preview. https://bugs.webkit.org/show_bug.cgi?id=38635 * English.lproj/localizedStrings.js: * inspector/front-end/FontView.js: (WebInspector.FontView.prototype.hasContentTab): * inspector/front-end/ImageView.js: (WebInspector.ImageView.prototype.hasContentTab): * inspector/front-end/ResourceView.js: (WebInspector.ResourceView): (WebInspector.ResourceView.prototype._selectTab): (WebInspector.ResourceView.prototype.hasContentTab): * inspector/front-end/SourceView.js: (WebInspector.SourceView.prototype.hasContentTab): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58884 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tonikitoo@webkit.org authored
Reviewed by Kenneth Christiansen. Spatial Navigation: Add LayoutTest with frame flattening feature on. https://bugs.webkit.org/show_bug.cgi?id=38585 * fast/events/spatial-navigation/snav-iframe-flattening-simple-expected.txt: Added. * fast/events/spatial-navigation/snav-iframe-flattening-simple.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58883 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
tonikitoo@webkit.org authored
Reviewed by Kenneth Christiansen. Spatial Navigation: adapt the logic of {deep}findFocusableNodeInDirection to do traversal starting from Node* not Document* https://bugs.webkit.org/show_bug.cgi?id=37803 Instead of receiving a Document pointer as incoming parameter, patch modifies findFocusableNodeInDirection and deepFindFocusableNodeInDirection methods to receive a Node pointer as start for content traversal. This way we can make good use of deepFindFocusableNodeInDirection to traverse other scrollable container like scrollable div's, and not only frames or iframes. Patch also makes use of 'while' instead of 'for' to loop control, that gives move flexibility to the incremental step: e.g. if a scrollable div was processed, the incremental step in the loop does not have to do node->traverseNextNode() but node->traverseNextSibling(). No behavior change. It is ... -
ossy@webkit.org authored
Preprocessor doesn't understand "true", changed to "1" * platform/graphics/MediaPlayer.cpp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58881 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mnaganov@chromium.org authored
Reviewed by Pavel Feldman. Temporarily disable 'console.profiles' until we can distinguish functions from different frames https://bugs.webkit.org/show_bug.cgi?id=38638 * bindings/v8/custom/V8ConsoleCustom.cpp: (WebCore::V8Console::profilesAccessorGetter): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58880 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
vitalyr@chromium.org authored
[chromium] Unreviewed. Updating expectations. * platform/chromium-linux/fast/url/segments-expected.txt: Added. * platform/chromium-linux/fast/url/segments-from-data-url-expected.txt: Added. * platform/chromium-mac/fast/url/segments-expected.txt: Added. * platform/chromium-mac/fast/url/segments-from-data-url-expected.txt: Added. * platform/chromium-win/fast/url/segments-expected.txt: Added. * platform/chromium-win/fast/url/segments-from-data-url-expected.txt: Added. * platform/chromium/test_expectations.txt: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58879 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Eric Seidel. MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE https://bugs.webkit.org/show_bug.cgi?id=38544 * wtf/Platform.h: 2010-05-06 Steve Block <steveblock@google.com> Reviewed by Eric Seidel. MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE https://bugs.webkit.org/show_bug.cgi?id=38544 No new tests, build fix only. * DerivedSources.make: * bindings/js/ScriptController.cpp: (WebCore::ScriptController::ScriptController): * bindings/js/ScriptController.h: * bindings/js/ScriptControllerMac.mm: (WebCore::ScriptController::createScriptInstanceForWidget): * bridge/jni/JNIBridge.cpp: * bridge/jni/JNIBridge.h: * bridge/jni/JNIUtility.cpp: * bridge/jni/JNIUtility.h: * bridge/jni/jni_jsobject.h: * bridge/jni/jni_jsobject.mm: * bridge/jni/jni_objc.mm: * bridge/jni/jsc/JNIBridgeJSC.cpp: * bridge/jni/jsc/JNIBridgeJSC.h: * bridge/jni/jsc/JNIUtilityPrivate.cpp: * bridge/jni/jsc/JNIUtilityPrivate.h: * bridge/jni/jsc/JavaClassJSC.cpp: * bridge/jni/jsc/JavaClassJSC.h: * bridge/jni/jsc/JavaInstanceJSC.cpp: * bridge/jni/jsc/JavaInstanceJSC.h: * loader/FrameLoaderClient.h: 2010-05-06 Steve Block <steveblock@google.com> Reviewed by Eric Seidel. MAC_JAVA_BRIDGE should be renamed JAVA_BRIDGE https://bugs.webkit.org/show_bug.cgi?id=38544 * WebCoreSupport/WebFrameLoaderClient.h: * WebCoreSupport/WebFrameLoaderClient.mm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58878 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Simon Hausmann. [Qt] Patch to fix compilation warnings for QGraphicsWebView https://bugs.webkit.org/show_bug.cgi?id=37428 Patch by Alexis Menard <alexis.menard@nokia.com> * Api/qgraphicswebview.cpp: (QGraphicsWebView::itemChange): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58877 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Kenneth Rohde Christiansen. [Qt] Replace public inspector url with private property for QtLauncher https://bugs.webkit.org/show_bug.cgi?id=35340 Replace the public API with a private dynamic property until this feature is ready. * Api/qwebsettings.cpp: * Api/qwebsettings.h: * WebCoreSupport/InspectorClientQt.cpp: (WebCore::InspectorClientQt::openInspectorFrontend): * symbian/bwins/QtWebKitu.def: * symbian/eabi/QtWebKitu.def: 2010-05-06 Simon Hausmann <simon.hausmann@nokia.com> Reviewed by Kenneth Rohde Christiansen. [Qt] Replace public inspector url with private property for QtLauncher https://bugs.webkit.org/show_bug.cgi?id=35340 Replace the public API with a private dynamic property until this feature is ready. * QtLauncher/main.cpp: (LauncherWindow::init): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58876 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
alex@webkit.org authored
Reviewed by Xan Lopez. Fixed the gobject introspection compilation with the new DOM bindings, we needed to add DOM objects. * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58875 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Maciej Stachowiak. [WTFURL] Add a class to represent the segments of a URL https://bugs.webkit.org/show_bug.cgi?id=38566 When paired with a string, this class represents a parsed URL. * wtf/url/src/URLSegments.cpp: Added. (WTF::URLSegments::length): (WTF::URLSegments::charactersBefore): * wtf/url/src/URLSegments.h: Added. (WTF::URLSegments::): (WTF::URLSegments::URLSegments): * wtf/url/wtfurl.gyp: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58874 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Eric Seidel. drop support for sessionStorage in sandbox iframes https://bugs.webkit.org/show_bug.cgi?id=38151 Update test expectation. This test was originally created to show that we complied with the letter of the spec, but our behavior is insecure. In the future, we might revert this change and implement a separate storage area for each unique origin. * fast/frames/resources/sandboxed-iframe-storage-disallowed.html: * fast/frames/sandboxed-iframe-storage-expected.txt: 2010-05-06 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. drop support for sessionStorage in sandbox iframes https://bugs.webkit.org/show_bug.cgi?id=38151 This patch causes us to throw a security exception when a sandboxed iframe attempts to access sessionStorage, matching our behavior for localStorage. The letter of the spec asks us to create a separate storage area for each unique origin. We might want to do that in a future patch, but throwing a security error seems like a safe move now. * page/DOMWindow.cpp: (WebCore::DOMWindow::sessionStorage): (WebCore::DOMWindow::localStorage): * page/DOMWindow.h: * page/DOMWindow.idl: * page/SecurityOrigin.h: (WebCore::SecurityOrigin::canAccessSessionStorage): * storage/StorageEventDispatcher.cpp: (WebCore::StorageEventDispatcher::dispatch): 2010-05-06 Adam Barth <abarth@webkit.org> Reviewed by Eric Seidel. drop support for sessionStorage in sandbox iframes https://bugs.webkit.org/show_bug.cgi?id=38151 Update client of sessionStorage to handle exceptions. * src/StorageAreaProxy.cpp: (WebCore::StorageAreaProxy::storageEvent): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58873 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
aestes@apple.com authored
originated from a user gesture. Reviewed by Maciej Stachowiak. https://bugs.webkit.org/show_bug.cgi?id=37335 <rdar://problem/7884980> Test: fast/events/popup-allowed-from-gesture-initiated-form-submit.html * bindings/js/ScriptController.cpp: (WebCore::ScriptController::processingUserGesture): If no DOM event is being processed, consult UserGestureIndicator to determine return value. * bindings/js/ScriptController.h: Moved the logic of processingUserGestureEvent() into processingUserGesture(). LayoutTests: Add a test to ensure popups are allowed when the user submits a form with target="_blank". Reviewed by Maciej Stachowiak. https://bugs.webkit.org/show_bug.cgi?id=37335 <rdar://problem/7884980> * fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Added. * fast/events/popup-allowed-from-gesture-initiated-form-submit.html: Added. * fast/events/resources/popup-allowed-from-gesture-initiated-form-submit-target.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58872 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Rubber-stamped by Eric Seidel. [GTK] Refactor GenerateProperties in CodeGenerationGObject.pm https://bugs.webkit.org/show_bug.cgi?id=38577 Thinko caught while refactoring, $custom variable was not initialized. * bindings/scripts/CodeGeneratorGObject.pm: * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: (webkit_dom_test_obj_set_property): (webkit_dom_test_obj_get_property): (webkit_dom_test_obj_class_init): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58871 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
xan@webkit.org authored
Rubber-stamped by Eric Seidel. [GTK] Refactor GenerateProperties in CodeGenerationGObject.pm https://bugs.webkit.org/show_bug.cgi?id=38577 Refactor GenerateProperty out of GenerateProperties. This is in preparation for EventListeren attributes, which won't generate normal GObject properties. * bindings/scripts/CodeGeneratorGObject.pm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58870 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Joseph Pecoraro. Web Inspector: follow up to linkify event listeners. https://bugs.webkit.org/show_bug.cgi?id=38257 * bindings/js/ScriptEventListener.cpp: (WebCore::eventListenerHandlerLocation): * bindings/v8/ScriptEventListener.cpp: (WebCore::eventListenerHandlerLocation): * inspector/front-end/ElementsPanel.js: (WebInspector.ElementsPanel.prototype.linkifyNodeReference): * inspector/front-end/EventListenersSidebarPane.js: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58869 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Pavel Feldman. Web Inspector: build-webkit --inspector-frontend Should Exclude *.re2js https://bugs.webkit.org/show_bug.cgi?id=38449 * Scripts/webkitdirs.pm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58868 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by George Staikos https://bugs.webkit.org/show_bug.cgi?id=37848 Add test cases for -wap-input-format and -wap-input-required of WCSS * fast/wcss/wap-input-format-expected.txt: Added. * fast/wcss/wap-input-format.xhtml: Added. * fast/wcss/wap-input-required-expected.txt: Added. * fast/wcss/wap-input-required.xhtml: Added. 2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn> Reviewed by George Staikos https://bugs.webkit.org/show_bug.cgi?id=37848 This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit Tests: fast/wcss/wap-input-format.xhtml fast/wcss/wap-input-required.xhtml * css/CSSParser.cpp: (WebCore::CSSParser::parseValue): (WebCore::CSSParser::parseWCSSInputProperty): * css/CSSParser.h: * css/CSSStyleSelector.cpp: (WebCore::CSSStyleSelector::applyProperty): * css/WCSSPropertyNames.in: * dom/InputElement.cpp: (WebCore::InputElement::sanitizeValue): (WebCore::InputElement::handleBeforeTextInsertedEvent): (WebCore::InputElementData::InputElementData): (WebCore::formatCodes): (WebCore::cursorPositionToMaskIndex): (WebCore::InputElement::isConformToInputMask): (WebCore::InputElement::validateInputMask): * dom/InputElement.h: (WebCore::InputElementData::inputFormatMask): (WebCore::InputElementData::setInputFormatMask): (WebCore::InputElementData::maxInputCharsAllowed): (WebCore::InputElementData::setMaxInputCharsAllowed): * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::setWapInputFormat): * html/HTMLInputElement.h: (WebCore::HTMLInputElement::data): * wml/WMLInputElement.h: (WebCore::WMLInputElement::data): 2010-05-05 Charles Wei <charles.wei@torchmobile.com.cn> Reviewed by George Staikos This patch adds WCSS -wap-input-format and -wap-input-required support to WebKit Make the test cases in fast/wcss optionional only when WCSS is enabled. https://bugs.webkit.org/show_bug.cgi?id=37848 * Scripts/old-run-webkit-tests: * Scripts/webkitperl/features.pm: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58867 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
hamaji@chromium.org authored
Reviewed by Eric Seidel. [GTK] Markup of copied non ASCII characters is broken https://bugs.webkit.org/show_bug.cgi?id=37918 This test was fixed by http://trac.webkit.org/changeset/58468 * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58866 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
mitz@apple.com authored
Reviewed by Mark Rowe. * WebView/WebFrameView.mm: (-[WebFrameView webFrame]): Null-check _private. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58865 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
morrita@google.com authored
Reviewed by Darin Adler. https://bugs.webkit.org/show_bug.cgi?id=38150 Refactoring: webkitEditableContentChangedEvent should be handled by the owner of appropriate the renderer. Moved a part of code chunk in HTMLFormControlElementWithState::defaultEventHandler() which accesses the renderer from foreign node, to TextControlInnerTextElement::defaultEventHandler() which owns the renderer. No new tests. No behavioral change. * html/HTMLFormControlElement.cpp: (WebCore::HTMLFormControlElementWithState::defaultEventHandler): * html/HTMLFormControlElement.h: * html/HTMLInputElement.h: * html/HTMLTextAreaElement.h: * rendering/TextControlInnerElements.cpp: (WebCore::TextControlInnerTextElement::defaultEventHandler): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58864 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
- 05 May, 2010 7 commits
-
-
ossy@webkit.org authored
https://bugs.webkit.org/show_bug.cgi?id=38457 Rubber-stamped by Alexey Proskuryakov. * platform/qt/Skipped: Only skip tests that fail. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58863 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
tkent@chromium.org authored
Reviewed by Eric Seidel. [DRT/Chromium] Remove InitWebCoreSystemInterface() call https://bugs.webkit.org/show_bug.cgi?id=38624 Chromium r45167 <http://src.chromium.org/viewvc/chrome?view=rev&revision=45167> added InitWebCoreSystemInterface() to webkit/support/platform_support_mac.mm. So we don't need to call it from DumpRenderTree.cpp anymore. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: * DumpRenderTree/chromium/DumpRenderTree.cpp: (main): Remove InitWebCoreSystemInterface(). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58862 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Alexey Proskuryakov. Remove platform specific test result Don't print the formatted string of the z-index in the test case since there's a risk that the output on different c stdlib implementations/platforms/locale could be different https://bugs.webkit.org/show_bug.cgi?id=38617. * fast/dom/clone-node-z-index-expected.txt: * fast/dom/clone-node-z-index.html: * platform/win/fast/dom/clone-node-z-index-expected.txt: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58861 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Alexey Proskuryakov. Add a test of URL segmentation from a data URL base https://bugs.webkit.org/show_bug.cgi?id=38606 As requested by Alexey. These tests find some interesting behavior in both KURL and GURL. We'll need to go through them in more detail later to understand what the right behavior is. * fast/url/script-tests/segments-from-data-url.js: Added. * fast/url/segments-from-data-url-expected.txt: Added. * fast/url/segments-from-data-url.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58860 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Alexey Proskuryakov. Add a test of URL segmentation https://bugs.webkit.org/show_bug.cgi?id=38600 These tests are based on URLParser.Standard from http://code.google.com/p/google-url/source/browse/trunk/src/url_parse_unittest.cc * fast/url/resources/utilities.js: (canonicalize): - I changed this to use deterministic IDs because (theoretically) the old way was flaky in case the IDs collided. (segments): - Here we're using HTMLAnchorElement's attributes to infer the internal segmentation. Unforunately, there don't seem to be accessors for usernames and passwords of URLs. * fast/url/script-tests/segments.js: Added. - I'm not 100% sure all the test cases here represent the intent of the original test author. The tricky bit is we don't have a good way to test absolute URL parsing from the web platform, which means a bunch of these become tests of how we handle relative URLs. However, I'm not one to turn down more test cases. * fast/url/script-tests/trivial-segments.js: Added. - This is more of a test of the testing harness to make sure its working properly when running on other browsers. * fast/url/segments-expected.txt: Added. * fast/url/trivial-segments-expected.txt: Added. - As usual, these have their "PASS" expectations set to the Chromium behavior but have their -expected.txt set to the normal WebKit behavior, letting us track differences between the two. * fast/url/segments.html: Added. * fast/url/trivial-segments.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58859 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Adam Barth. Adding comment with link to RefPtr documentation. https://bugs.webkit.org/show_bug.cgi?id=38601 * wtf/RefPtr.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58858 268f45cc-cd09-0410-ab3c-d52691b4dbfc -
eric@webkit.org authored
Reviewed by Timothy Hatcher. Web Inspector: Line Numbers should be Aligned with the Source Code Line https://bugs.webkit.org/show_bug.cgi?id=38593 If there is a message bubble, such as an error message, in a source view the line number should be in line with the source code line, not centered between the source and bubble. * inspector/front-end/textViewer.css: (.webkit-line-number): added vertical-align: top git-svn-id: http://svn.webkit.org/repository/webkit/trunk@58857 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
