1. 07 Apr, 2008 5 commits
    • alp@webkit.org's avatar
      2008-04-07 Luca Bruno <lethalman88@gmail.com> · b46c9feb
      alp@webkit.org authored
              Reviewed by Alp Toker.
      
              http://bugs.webkit.org/show_bug.cgi?id=18297
              Bug #18297 - Acid2/Acid3 -tests don't load load with soup.
      
              Fixes in the libsoup backend: data url parsing, acid tests, redirects,
              response headers handling and re-entrancy issues on job cancellation.
              Thanks to Dan Winship for libsoup hints.
      
              * platform/network/ResourceHandleInternal.h:
              (WebCore::ResourceHandleInternal::ResourceHandleInternal): add m_cancelled and remove unuseful m_session
              * platform/network/soup/ResourceHandleSoup.cpp:
              (WebCore::restartedCallback): added to route redirects to webkit
              (WebCore::dataCallback): add response headers, some checks and fix re-entrancy
              (WebCore::parseDataUrl): be an idle callback for the main loop
              (WebCore::ResourceHandle::start):
              (WebCore::ResourceHandle::cancel): fixed re-entrancy
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31682 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b46c9feb
    • ap@webkit.org's avatar
      Build fix, rubber-stamped and landed by ap. · c266b3f7
      ap@webkit.org authored
              * configure.ac: Add autoconf flag for HTML5 client-side session and persistent storage support.
      
      WebCore: 
              * GNUmakefile.am: Fix dom_storage conditional and typo: ENABLE_DOM_STORAG.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c266b3f7
    • beidson@apple.com's avatar
      2008-04-07 Brady Eidson <beidson@apple.com> · 5ad07575
      beidson@apple.com authored
              Whoops, idls don't go in the vcproj!
      
              * WebCore.vcproj/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31680 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ad07575
    • beidson@apple.com's avatar
      2008-04-06 Brady Eidson <beidson@apple.com> · 860faa5f
      beidson@apple.com authored
              Attempt to tickle Windows build into accepting this idl
      
              * storage/StorageEvent.idl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31679 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      860faa5f
    • beidson@apple.com's avatar
      2008-04-06 Brady Eidson <beidson@apple.com> · cce3c766
      beidson@apple.com authored
              Reviewed by Sam
      
              HTML5 Session and Local Storage
      
              Land a bunch of empty files and interfaces to keep things building while 
              I finish off the rest of the implementation of SessionStorage
      
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * WebCoreSources.bkl:
      
              * storage/OriginStorage.cpp: Added.
              * storage/OriginStorage.h: Added.
      
              * storage/SessionStorage.cpp: Added.
              * storage/SessionStorage.h: Added.
      
              * storage/Storage.cpp: Added.
              (WebCore::Storage::length):
              (WebCore::Storage::key):
              (WebCore::Storage::getItem):
              (WebCore::Storage::setItem):
              (WebCore::Storage::removeItem):
              * storage/Storage.h: Added.
              * storage/Storage.idl: Added.
      
              * storage/StorageEvent.cpp: Added.
              * storage/StorageEvent.h: Added.
              (WebCore::StorageEvent::key):
              (WebCore::StorageEvent::oldValue):
              (WebCore::StorageEvent::newValue):
              (WebCore::StorageEvent::uri):
              (WebCore::StorageEvent::source):
              (WebCore::StorageEvent::initStorageEvent):
              * storage/StorageEvent.idl: Added.
      
              * storage/StorageMap.cpp: Added.
              * storage/StorageMap.h: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31678 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cce3c766
  2. 05 Apr, 2008 5 commits
    • kevino@webkit.org's avatar
      Reviewed by Mark Rowe. · cf769d47
      kevino@webkit.org authored
      Add CSS to the MIMETypeRegistry, which ensures CSS files get the right MIMEType when loaded from disk.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31666 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf769d47
    • rwlbuis@webkit.org's avatar
      Reviewed by Eric. · a60dd79b
      rwlbuis@webkit.org authored
              http://bugs.webkit.org/show_bug.cgi?id=17129
              Incorrect style resolution in CSS styled SVG, with multiple style sheets
              Fix the style resolution on the svg by ensuring xml-stylesheet pseudo
              attributes title and alternate are transferred to the stylesheet
              created from the ProcessingInstruction.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31664 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a60dd79b
    • mitz@apple.com's avatar
      WebCore: · 440ac8c4
      mitz@apple.com authored
              Reviewed by Darin Adler.
      
              - fix <rdar://problem/5843719> Excessive repainting of cells in tables with non-auto height
      
              Test: fast/repaint/table-two-pass-layout-overpaint.html
      
              * rendering/RenderTable.cpp:
              (WebCore::RenderTable::layout): Changed the first pass over the sections
              to only call calcRowHeight() and recalcOuterBorder() but not
              layoutRows(), because the section's final height is unknown yet.
              Removed caching of m_height before the call to calcHeight(), because
              for non-positioned tables, calcHeight() only calculates the vertical
              margins and does not change m_height.
              Added a second pass over the sections, after the table height is known,
              to call layoutRows() on each section, with additional height if needed.
              Did minimal cleanup including caching the value of collapseBorders() in
              a local variable and changing a while loop into a for loop.
              * rendering/RenderTableSection.cpp:...
      440ac8c4
    • hausmann@webkit.org's avatar
      Simon Hausmann <shausman@trolltech.com> · 6e2533da
      hausmann@webkit.org authored
      Fixes: Disable "unimplemented" warnings when building WebKit inside Qt.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31662 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6e2533da
    • hausmann@webkit.org's avatar
      Simon Hausmann <hausmann@webkit.org> · b1233477
      hausmann@webkit.org authored
      Rubber-stamped by Holger
      
      Revert "* Load images incrementally. This will show warnings on the console"
      This rolls out -r29739.
      
      This unfortunately caused some crashes and drawing errors. Backing out for now.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31659 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1233477
  3. 04 Apr, 2008 18 commits
    • kevino@webkit.org's avatar
      Add GradientWx.cpp to the wx build process. · e8557d79
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31654 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8557d79
    • mitz@apple.com's avatar
      Reviewed by Sam Weinig. · 6a397794
      mitz@apple.com authored
              - speed up CSSFontSelector::getFontData()
      
              * css/CSSFontSelector.cpp:
              (WebCore::fontDataForGenericFamily): Factored out of getFontData().
              (WebCore::CSSFontSelector::getFontData): Changed to call
              fontDataForGenericFamily() directly if the map is empty.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31653 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a397794
    • jhoneycutt@apple.com's avatar
      2008-04-04 Jon Honeycutt <jhoneycutt@apple.com> · 3da811d0
      jhoneycutt@apple.com authored
              Reviewed by Oliver.
      
              Replace AccessibilityObject::isRenderImage() with a virtual
              RenderObject::isRenderImage().
      
              * page/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::accessibilityIsIgnored):
              (WebCore::AccessibilityObject::addChildren):
              * page/AccessibilityObject.h:
              (WebCore::AccessibilityObject::isDetached):
              * rendering/RenderImage.h:
              (WebCore::RenderImage::isRenderImage):
              * rendering/RenderObject.h:
              (WebCore::RenderObject::isRenderImage):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31652 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3da811d0
    • mitz@apple.com's avatar
      - try to fix the wx build · b575e3bc
      mitz@apple.com authored
              * platform/graphics/wx/FontPlatformDataWx.cpp:
              (WebCore::fontWeightToWxFontWeight):
              (WebCore::FontPlatformData::FontPlatformData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31650 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b575e3bc
    • jhoneycutt@apple.com's avatar
      2008-04-04 Jon Honeycutt <jhoneycutt@apple.com> · 760da6dc
      jhoneycutt@apple.com authored
              Reviewed by Beth.
      
              Some more clean-up of AccessibilityObject:
              - Rearranged/grouped methods.
              - Marked many methods const.
              - Changed many methods to take args by const ref instead of by val.
              - Made headingLevel() static.
              - Renamed detached() to isDetached(), loaded() to isLoaded(),
                documentLinks to getDocumentLinks().
              - Made clearChildren(), removeAXObjectID(), isDetached() private.
              - Added notImplemented() calls for unimplemented methods.
              - Replaced stringForReplacedNode method with static function.
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31649 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      760da6dc
    • timothy@apple.com's avatar
      Restore the user entered text when clearing the auto-completion. · 5882d3f3
      timothy@apple.com authored
      This is important when the user typed text that is a different
      case than the completion. This has no affect on the Console, since
      it matches completions case-sensitively. This is used in the up-coming
      Database Query view for words like "SELECT" and "INSERT".
      
      Reviewed by Adam Roben.
      
      * page/inspector/TextPrompt.js:
      (WebInspector.TextPrompt.prototype.clearAutoComplete): Restore the user typed
      text in the original DOM range that complete() saved away.
      (WebInspector.TextPrompt.prototype.complete): Store away the fullWordRange
      and it's text content so clearAutoComplete can restore it.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31648 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5882d3f3
    • timothy@apple.com's avatar
      Don't trim whitespace when looking for the current match, this prevents... · 5c745141
      timothy@apple.com authored
      Don't trim whitespace when looking for the current match, this prevents tabbing through matches in the up-coming Database Query view.
      
      Reviewed by Adam Roben.
      
      * page/inspector/TextPrompt.js: Removed a trimTrailingWhitespace() call.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31646 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5c745141
    • timothy@apple.com's avatar
      Factor out the Console text completion and command history into · 8b21c6eb
      timothy@apple.com authored
      a new TextPrompt object. This TextPrompt object will be used later
      other parts of the Inspector that need text completion and history.
      Not functionality changed, just moved code around.
      
      Reviewed by Adam Roben.
      
      * WebCore.vcproj/WebCore.vcproj: Add TextPrompt.js.
      * page/inspector/Console.js: Call the new prompt object and
        delete all the code that moved.
      * page/inspector/TextPrompt.js: Added. Moved code from Console.js.
      * page/inspector/WebKit.qrc: Add TextPrompt.js.
      * page/inspector/inspector.html: Add TextPrompt.js.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31645 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b21c6eb
    • timothy@apple.com's avatar
      Makes setting shouldRefreshChildren on a TreeElement perform the refresh · 894ffe7f
      timothy@apple.com authored
      immediately if the element is already expanded.
      
      Reviewed by Adam Roben.
      
      * page/inspector/treeoutline.js:
      (TreeElement.prototype.get shouldRefreshChildren): Return this._shouldRefreshChildren.
      (TreeElement.prototype.set shouldRefreshChildren): If changing to true, and
      already expanded,
      call expand again to trigger the refresh. Sets this._shouldRefreshChildren.
      (TreeElement.prototype._attach): Check for this._shouldRefreshChildren.
      (TreeElement.prototype.expand): Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31644 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      894ffe7f
    • jhoneycutt@apple.com's avatar
      2008-04-04 Jon Honeycutt <jhoneycutt@apple.com> · 47e63d77
      jhoneycutt@apple.com authored
              Reviewed by Beth.
      
              Some clean up of AccessibilityObject:
              - Use existing isImage() in more places.
              - Use existing isTextControl() in more places.
              - Added isRenderImage(). Check this before casting to RenderImage,
                since other, non-RenderImage derived RenderObjects (e.g.
                RenderListMarker) can return true for isImage().
              - Fix two copy/paste errors with improper semicolons.
      
              * page/AccessibilityObject.cpp:
              (WebCore::AccessibilityObject::isImageButton): Use isImage().
              (WebCore::AccessibilityObject::isRenderImage): Added.
              (WebCore::AccessibilityObject::isAnchor): Use isImage().
              (WebCore::AccessibilityObject::isAttachment): Same.
              (WebCore::AccessibilityObject::accessibilityDescription): Same.
              (WebCore::AccessibilityObject::accessibilityIsIgnored): Use
              isRenderImage() instead of isImage().
              (WebCore::AccessibilityObject::url): Use isImage().
              (WebCore::AccessibilityObject::textControl): Remove improper semicolon, 
              and use isTextControl().
              (WebCore::AccessibilityObject::textMarkerForIndex): Same.
              (WebCore::AccessibilityObject::indexForTextMarker): Use isTextControl().
              (WebCore::AccessibilityObject::doAXRangeForLine): Same.
              (WebCore::AccessibilityObject::doAXRangeForIndex): Same
              (WebCore::AccessibilityObject::doAXStringForRange): Same.
              (WebCore::AccessibilityObject::roleValue):  Use isImage().
              (WebCore::AccessibilityObject::addChildren): Use isRenderImage().
              * page/AccessibilityObject.h:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31643 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47e63d77
    • timothy@apple.com's avatar
      Fixes a null exception when hovering in some areas of the DOM tree. · cee3d6d1
      timothy@apple.com authored
      Reviewed by Adam Roben.
      
      * page/inspector/treeoutline.js:
      (TreeOutline.prototype.treeElementFromPoint): Check listNode for null/undefined
      before accessing any properties. Return null if listNode is null.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31642 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cee3d6d1
    • timothy@apple.com's avatar
      Changing WebInspector.currentFocusElement to/from an input element · 58fad059
      timothy@apple.com authored
      does not change the actual focus of that input element. You see this
      in the search field.
      
      Reviewed by Adam Roben.
      
      * page/inspector/inspector.js:
      (WebInspector.set currentFocusElement): Call blur and focus if the
      node implements them.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31641 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58fad059
    • hyatt@apple.com's avatar
      2008-04-04 David Hyatt <hyatt@apple.com> · 820875f7
      hyatt@apple.com authored
              Improve the background size heuristic for SVGs used as background images with no intrinsic size specified.
              Treat them as having a background-size of 100%.  This means their maximal size will be the box established
              by background-origin.
      
              Reviewed by Beth
      
              * rendering/RenderBox.cpp:
              (WebCore::RenderBox::calculateBackgroundSize):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31640 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      820875f7
    • timothy@apple.com's avatar
      Correctly show DOCTYPE in the breadcrumbs and match the CSS rules · 8f6a18bd
      timothy@apple.com authored
      from view-source.css for the DOCTYPE in the DOM tree.
      
      Reviewed by Adam Roben.
      
      * css/view-source.css: Add and correct comments about keeping
      in-sync with inspector.css.
      * page/inspector/ElementsPanel.js:
      (WebInspector.DocumentPanel.prototype.updateBreadcrumb):
      Add a case for Node.DOCUMENT_TYPE_NODE.
      * page/inspector/inspector.css: Add a rule for .webkit-html-doctype.
      * page/inspector/utilities.js:
      (nodeTitleInfo): Use the webkit-html-doctype class for nodes
      with Node.DOCUMENT_TYPE_NODE.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31639 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f6a18bd
    • mitz@apple.com's avatar
      - try to fix the Tiger build · bb10a991
      mitz@apple.com authored
              * icu/unicode/uscript.h: Copied from WebKit/mac/icu/unicode/uscript.h.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31638 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb10a991
    • aroben@apple.com's avatar
      Make WebKit use WebCore's copy of the ICU headers · 6df273d6
      aroben@apple.com authored
      WebCore:
      
              Copy icu/ to PrivateHeaders for WebKit's benefit
      
              Rubberstamped by Tim Hatcher.
      
              * WebCore.xcodeproj/project.pbxproj: Renamed the Copy Forwarding
              Headers build phase to Copy Forwarding and ICU Headers, and added the
              icu/ directory to it.
      
      WebKit/mac:
      
              Use WebCore's ICU headers instead of our own copy
      
              Rubberstamped by Tim Hatcher.
      
              * Configurations/WebKit.xcconfig: Pick up ICU headers from WebCore's
              PrivateHeaders.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31637 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6df273d6
    • aroben@apple.com's avatar
      Fix <rdar://problem/5804776> Would like to use WebCore's ForwardingHeaders in... · 400d9ed1
      aroben@apple.com authored
      Fix <rdar://problem/5804776> Would like to use WebCore's ForwardingHeaders in WebKit without manually creating copies
      
      WebCore:
      
              Fix <rdar://problem/5804776> Would like to use WebCore's
              ForwardingHeaders in WebKit without manually creating copies
      
              Patch by Tim Hatcher, typed by me.
      
              * WebCore.xcodeproj/project.pbxproj: Added a new build phase, Copy
              Forwarding Headers, that copies the ForwardingHeaders directory to
              WebCore's PrivateHeaders directory.
      
      WebKit/mac:
      
              Fix <rdar://problem/5804776> Would like to use WebCore's
              ForwardingHeaders in WebKit without manually creating copies
      
              Patch by Tim Hatcher, typed by me.
      
              * Configurations/WebKit.xcconfig: Use the copy of ForwardingHeaders in
              WebCore's PrivateHeaders instead of our own copy.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31636 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      400d9ed1
    • adachan@apple.com's avatar
      WebCore: · b5db420f
      adachan@apple.com authored
              Changed the signature of imageTitleForFilename so we can pass in the width
              and height as integers.
      
              Reviewed by Dan.
      
              * page/mac/WebCoreViewFactory.h:
              * platform/mac/LocalizedStringsMac.mm:
              (WebCore::imageTitle):
      
      WebKit:
              Updated the format string for window title for a standalone image to take integers.
      
              Reviewed by Dan.
      
              * English.lproj/Localizable.strings:
      
      WebKit/mac:
              Now we pass width and height directly as integers to format
              the window title for a standalone image.
      
              Reviewed by Dan.
      
              * WebCoreSupport/WebViewFactory.mm:
              (-[WebViewFactory imageTitleForFilename:width:height:]):
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b5db420f
  4. 03 Apr, 2008 12 commits
    • mitz@apple.com's avatar
      - Windows build fix · 4778ff09
      mitz@apple.com authored
              * platform/graphics/win/FontCacheWin.cpp:
              (WebCore::matchImprovingEnumProc):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31629 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4778ff09
    • kevino@webkit.org's avatar
      Fix PlatformGradient so that it's a pointer on all platforms. · e29255bc
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31628 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e29255bc
    • mitz@apple.com's avatar
      - 64-bit build fix · 4e5512a7
      mitz@apple.com authored
              * platform/mac/WebFontCache.mm:
              (+[WebFontCache internalFontWithFamily:traits:weight:size:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31627 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4e5512a7
    • kevino@webkit.org's avatar
      wx build fix. Add stubs for gradient class platform functions. · 2a6c9295
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31626 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a6c9295
    • kevino@webkit.org's avatar
      Reviewed by Dan Bernstein. · 53ec44be
      kevino@webkit.org authored
      Refactor Gradient.h to have the same API on platforms without a gradient class.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31625 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      53ec44be
    • mitz@apple.com's avatar
      - Qt build fix · 05c9af29
      mitz@apple.com authored
              * platform/graphics/qt/FontQt.cpp:
              (WebCore::Font::Font):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31624 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05c9af29
    • mitz@apple.com's avatar
      - Tiger build fix · be2a41f4
      mitz@apple.com authored
              * platform/mac/WebFontCache.mm:
              * rendering/RenderThemeMac.mm:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31623 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be2a41f4
    • mitz@apple.com's avatar
      - Gtk build fix · fb859bc1
      mitz@apple.com authored
              * platform/graphics/gtk/FontPlatformData.h:
              (WebCore::FontPlatformData::size):
              * platform/graphics/gtk/FontPlatformDataGtk.cpp:
              (WebCore::FontPlatformData::FontPlatformData):
              * platform/graphics/gtk/FontPlatformDataPango.cpp:
              (WebCore::FontPlatformData::FontPlatformData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31622 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fb859bc1
    • mitz@apple.com's avatar
      - project file updates in preparation for build fixes · 7454b3e7
      mitz@apple.com authored
              * GNUmakefile.am:
              * WebCore.pro:
              * WebCoreSources.bkl:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31621 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7454b3e7
    • mitz@apple.com's avatar
      WebCore: · cd4813bc
      mitz@apple.com authored
      2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
      
              Updated by Dan Bernstein. Reviewed by Dave Hyatt.
      
              - WebCore part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
                font-weight does not properly support graded weights
      
              Tests to come: <http://bugs.webkit.org/show_bug.cgi?id=18306>
      
              Build fixes for platforms other than Mac and Windows to come.
      
              * WebCore.vcproj/WebCore.vcproj: Added FontDescription.cpp.
      
              * WebCore.xcodeproj/project.pbxproj: Ditto.
      
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to
              return additional weight value keywords 100, 200, 300, 500, 600, 800
              and 900.
      
              * css/CSSFontSelector.cpp:
              (WebCore::hashForFont): Changed the bold parameter into a weight
              parameter and added the weight to the string to be hashed.
              (WebCore::CSSFontSelector::addFontFaceRule): Changed to apply all CSS
              weight values to the font description.
              (WebCore::CSSFontSelector::getFontData): Updated the fallback logic to
              go through all weights equal or lighter from the desired weight. For
              SVG, to also consider heavier weights.
      
              * css/CSSParser.cpp:
              (WebCore::CSSParser::parseValue): Cleaned up parsing of the font-weight
              property.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::applyProperty): Changed to apply all CSS
              weight values to the font description.
      
              * platform/graphics/Font.h:
              (WebCore::Font::weight): Updated for the change to
              FontDescription::weight().
      
              * platform/graphics/FontCache.cpp:
              (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey): Replaced
              the bold component of the key with a weight component.
              (WebCore::FontPlatformDataCacheKey::operator==): Updated for the above.
              (WebCore::computeHash): Ditto.
              (WebCore::FontPlatformDataCacheKeyTraits::deletedValue): Removed
              unnecessary parameters.
              (WebCore::FontPlatformDataCacheKeyTraits::emptyValue): Ditto.
              (WebCore::FontCache::getCachedFontPlatformData): Updated for the change
              in FontPlatformDataCacheKey.
      
              * platform/graphics/FontDescription.cpp: Added.
              (WebCore::FontDescription::lighterWeight): Added. Returns a lighter CSS
              font-weight value if there is one, or the lightest value.
              (WebCore::FontDescription::bolderWeight): Added. Returns a heavier CSS
              font-weight value if there is one, or the heaviest value.
      
              * platform/graphics/FontDescription.h:
              (WebCore::FontWeight): Added this enumeration.
              (WebCore::FontDescription::FontDescription):
              (WebCore::FontDescription::bold): Removed.
              (WebCore::FontDescription::weight): Changed to return a FontWeight.
              (WebCore::FontDescription::setBold): Removed.
              (WebCore::FontDescription::setWeight): Changed to take a FontWeight.
      
              * platform/graphics/mac/FontCacheMac.mm:
              (WebCore::toAppKitFontWeight): Added. Maps a FontWeight to the AppKit
              font weight scale of 0-15.
              (WebCore::isAppKitFontWeightBold): Added.
              (WebCore::FontCache::getFontDataForCharacters): Changed to use a weight
              instead of the bold trait for custom fonts, and to decide whether to
              synthesize bold based on the weights rather than the bold trait.
              (WebCore::FontCache::fontExists): Updated for the change in
              WebFontCache .
              (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to
              decide whether to synthesize bold based on the weights rather than on
              the bold trait.
      
              * platform/graphics/win/FontCacheWin.cpp:
              (WebCore::toGDIFontWeight): Added. Maps a FontWeight to a GDI font
              weight constant.
              (WebCore::isGDIFontWeightBold): Added.
              (WebCore::adjustedGDIFontWeight): Added.
              (WebCore::MatchImprovingProcData::MatchImprovingProcData): Added this
              data structure for use by the following callback.
              (WebCore::matchImprovingEnumProc): Added. The logic of this method is a
              simplification of the betterChoice() predicate in WebFontCache.mm, which
              considers only the italic trait and the weight.
              (WebCore::createGDIFont): Added. Similarly to
              +[WebFontCache fontWithFamily:traits:weight:size:], this function
              finds the closest match in the family for the desired italic bit and
              weight.
              (WebCore::FontCache::fontExists): Changed to call createGDIFont().
              (WebCore::FontCache::createFontPlatformData): Ditto. Also changed to
              compute the synthetic bold and synthetic italic flags based on weights
              and italic bits and pass them to the FontPlatformData constructor.
      
              * platform/graphics/win/FontPlatformDataWin.cpp:
              (WebCore::FontPlatformData::FontPlatformData): Changed the bold and
              oblique parameters to mean whether these should be synthesized and
              removed the font enumeration code that used to decide that.
      
              * platform/graphics/win/SimpleFontDataWin.cpp:
              (WebCore::SimpleFontData::smallCapsFontData): Changed to pass the
              synthetic bold and oblique flags from the full-size FontPlatformData to
              the FontPlatformData constructor for the small caps font.
      
              * platform/mac/WebCoreTextRenderer.h:
              * platform/mac/WebCoreTextRenderer.mm:
              (WebCoreFindFont): Added a weight parameter, which is passed to
              +[WebFontCache fontWithFamily:traits:weight:size:].
      
              * platform/mac/WebFontCache.h:
              * platform/mac/WebFontCache.mm:
              (acceptableChoice):
              (betterChoice): Changed to ignore the bold trait. Changed the logic for
              deciding based on weights to prefer the font whose weight is closer to
              the desired one, or, if both candidates' weights are the same distance
              from the desired weight, the one that is more "off-center". 
              (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Changed to
              check for weight when matching by full name. Changed to pass
              the actual desired weight instead of the constant 5 to
              acceptableChoice() and betterChoice(). Changed to use weights to decide
              whether to synthesize bold.
              (+[WebFontCache fontWithFamily:traits:weight:size:]): Added a weight
              parameter, which is passed to the internal method.
      
              * platform/win/PopupMenuWin.cpp:
              (WebCore::PopupMenu::paint): Updated for the change to FontDescription.
      
              * rendering/RenderListBox.cpp:
              (WebCore::RenderListBox::updateFromElement): Ditto.
              (WebCore::RenderListBox::paintItemForeground): Ditto.
      
              * rendering/RenderThemeMac.mm:
              (WebCore::toFontWeight): Added. Maps the AppKit font weight range of
              0-15 to the FontWeight range.
              (WebCore::RenderThemeMac::systemFont): Updated for the change to
              FontDescription.
      
              * rendering/RenderThemeSafari.cpp:
              (WebCore::RenderThemeSafari::systemFont): Ditto.
      
      WebKit/mac:
      
      2008-04-03  Nicholas Shanks  <webkit@nickshanks.com>
      
              Updated by Dan Bernstein. Reviewed by Dave Hyatt.
      
              - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
                font-weight does not properly support graded weights
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView _styleFromFontAttributes:]):
              (-[WebHTMLView _originalFontB]):
              (-[WebHTMLView _addToStyle:fontA:fontB:]):
      
      WebKit/win:
      
      2008-04-03  Dan Bernstein  <mitz@apple.com>
      
              Reviewed by Dave Hyatt.
      
              - WebKit part of fixing http://bugs.webkit.org/show_bug.cgi?id=6484
                font-weight does not properly support graded weights
      
              * DOMCoreClasses.cpp:
              (DOMElement::font): Updated for the change to FontDescription.
              * WebCoreSupport/WebDragClient.cpp:
              (dragLabelFont): Ditto.
              * WebKitGraphics.cpp:
              (makeFont): Ditto.
              * WebKitGraphics.h: Added a FIXME.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31620 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cd4813bc
    • mitz@apple.com's avatar
      - another Gtk build fix attempt · 69ed85ac
      mitz@apple.com authored
              * platform/graphics/cairo/GradientCairo.cpp:
              (WebCore::Gradient::platformDestroy):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31619 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69ed85ac
    • mitz@apple.com's avatar
      - attempted Gtk build fix · 5e016980
      mitz@apple.com authored
              * GNUmakefile.am:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31615 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e016980