1. 26 Oct, 2012 33 commits
    • kkristof@inf.u-szeged.hu's avatar
      [Qt] Enable JSC's disassembler on x86, x86_64 Linux · b46bab1b
      kkristof@inf.u-szeged.hu authored
      https://bugs.webkit.org/show_bug.cgi?id=100386
      
      Patch by Gabor Ballabas <gaborb@inf.u-szeged.hu> on 2012-10-26
      Reviewed by Simon Hausmann.
      
      It works fine on Linux x86, x86_64 just needs to be enabled in the
      QtWebKit build system.
      
      Source/JavaScriptCore:
      
      * DerivedSources.pri:
      * JavaScriptCore.pri:
      * Target.pri:
      
      Source/WTF:
      
      * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b46bab1b
    • yurys@chromium.org's avatar
      Memory instrumentation: do not report memory occupied by v8::String · 830dbd7b
      yurys@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100487
      
      Reviewed by Alexander Pavlov.
      
      Pointers to v8::String are skipped when reporting memory usage of V8 bindings'
      string cache.
      
      * bindings/v8/V8Binding.cpp:
      (WTF):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132605 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      830dbd7b
    • kbalazs@webkit.org's avatar
      [Qt] Pixel tests need rebaseline · 3edacae2
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99323
      
      Unreviewed pixel gardening.
      
      Added a bunch of pixel expectations for Qt-WebKit2 - part 1.
      
      * platform/qt-5.0-wk2/css3/filters/filter-empty-element-crash-expected.png: Added.
      * platform/qt-5.0-wk2/css3/filters/multiple-filters-invalidation-expected.png: Added.
      * platform/qt-5.0-wk2/css3/flexbox/repaint-expected.png: Added.
      * platform/qt-5.0-wk2/css3/flexbox/repaint-rtl-column-expected.png: Added.
      * platform/qt-5.0-wk2/fast/borders/border-shadow-large-radius-expected.png: Added.
      * platform/qt-5.0-wk2/fast/borders/outline-alpha-block-expected.png: Added.
      * platform/qt-5.0-wk2/fast/borders/outline-alpha-inline-expected.png: Added.
      * platform/qt-5.0-wk2/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
      * platform/qt-5.0-wk2/fast/box-shadow/no-blur-multiple-offsets-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/canvas-composite-fill-repaint-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/canvas-composite-transformclip-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/canvas-empty-image-pattern-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/canvas-resize-reset-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/canvas-transforms-during-path-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/gradient-add-second-start-end-stop-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/image-pattern-rotate-expected.png: Added.
      * platform/qt-5.0-wk2/fast/canvas/toDataURL-alpha-expected.png: Added.
      * platform/qt-5.0-wk2/fast/css/border-radius-non-negative-expected.png: Added.
      * platform/qt-5.0-wk2/fast/css/linear-gradient-currentcolor-expected.png: Added.
      * platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-expected.png: Added.
      * platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png: Added.
      * platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png: Added.
      * platform/qt-5.0-wk2/fast/forms/datalist/input-appearance-range-with-transform-expected.png: Added.
      * platform/qt-5.0-wk2/fast/forms/file/file-input-pressed-state-expected.png/file-input-pressed-state-expected.png: Added.
      * platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png/css3-color-stop-units-expected.png: Added.
      * platform/qt-5.0-wk2/fast/gradients/css3-color-stops-expected.png/css3-color-stops-expected.png: Added.
      * platform/qt-5.0-wk2/fast/gradients/css3-linear-angle-gradients-expected.png/css3-linear-angle-gradients-expected.png: Added.
      * platform/qt-5.0-wk2/fast/gradients/css3-linear-right-angle-gradients-expected.png/css3-linear-right-angle-gradients-expected.png: Added.
      * platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients-expected.png/css3-radial-gradients-expected.png: Added.
      * platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients2-expected.png/css3-radial-gradients2-expected.png: Added.
      * platform/qt-5.0-wk2/fast/gradients/css3-radial-gradients3-expected.png/css3-radial-gradients3-expected.png: Added.
      * platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients-expected.png/css3-repeating-linear-gradients-expected.png: Added.
      * platform/qt-5.0-wk2/fast/gradients/css3-repeating-linear-gradients2-expected.png/css3-repeating-linear-gradients2-expected.png: Added.
      * platform/qt-5.0-wk2/fast/gradients/css3-repeating-radial-gradients-expected.png/css3-repeating-radial-gradients-expected.png: Added.
      * platform/qt-5.0-wk2/fast/gradients/gradient-after-transparent-border-expected.png/gradient-after-transparent-border-expected.png: Added.
      * platform/qt-5.0-wk2/fast/images/jpeg-with-color-profile-expected.png: Added.
      * platform/qt-5.0-wk2/fast/images/paint-subrect-expected.png: Added.
      * platform/qt-5.0-wk2/fast/images/paint-subrect-grid-expected.png: Added.
      * platform/qt-5.0-wk2/fast/images/png-suite/test-expected.png/test-expected.png: Added.
      * platform/qt-5.0-wk2/fast/images/png-with-color-profile-expected.png: Added.
      * platform/qt-5.0-wk2/fast/images/rgb-jpeg-with-adobe-marker-only-expected.png: Added.
      * platform/qt-5.0-wk2/fast/images/rgb-png-with-cmyk-color-profile-expected.png: Added.
      * platform/qt-5.0-wk2/fast/images/ycbcr-with-cmyk-color-profile-expected.png: Added.
      * platform/qt-5.0-wk2/fast/layers/scroll-with-transform-composited-layer-expected.png/scroll-with-transform-composited-layer-expected.png: Added.
      * platform/qt-5.0-wk2/fast/layers/scroll-with-transform-layer-expected.png/scroll-with-transform-layer-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/absolute-position-changed-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/fixed-and-absolute-position-scrolled-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-inner-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/nested-iframe-scroll-outer-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/overflow-show-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/scroll-absolute-layer-with-reflection-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-no-visible-content-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/scroll-fixed-reflected-layer-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/scroll-in-clipped-layer-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/scroll-in-transformed-layer-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/scroll-inside-table-cell-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/scroll-with-transformed-parent-layer-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/table-overflow-auto-in-overflow-auto-scrolled-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png: Added.
      * platform/qt-5.0-wk2/fast/repaint/table-overflow-scroll-in-overflow-scroll-scrolled-expected.png: Added.
      * platform/qt-5.0-wk2/fast/replaced/outline-replaced-elements-expected.png: Added.
      * platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png: Added.
      * platform/qt-5.0-wk2/fast/table/border-collapsing/collapsed-border-with-col-colgroup-span-expected.png: Added.
      * platform/qt-5.0-wk2/fast/table/table-row-focus-ring-paint-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132604 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3edacae2
    • ossy@webkit.org's avatar
      [Qt][WK2] Unreviewed gardening, skip a new failing test. · f95df62b
      ossy@webkit.org authored
      * platform/qt-5.0-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132603 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f95df62b
    • mihnea@adobe.com's avatar
      [CSSRegions] Add support for auto-height regions with region-breaks · 1210a77f
      mihnea@adobe.com authored
      https://bugs.webkit.org/show_bug.cgi?id=99952
      
      Reviewed by David Hyatt.
      
      Source/WebCore:
      
      This patch takes region breaks into account when computing the height for auto logical height regions.
      When a region break is encountered before/after an element from within a flow thread and we are in the layout
      phase in which we lay out the flow threads in regions unconstrained, we use the region break to
      compute the region override logical content height if the region break fits inside an auto logical height region.
      A region break inside an auto logical height region determines the region override logical content height, taking
      min/max height into account.
      
      Tests: fast/regions/autoheight-allregions-nobreaks.html
             fast/regions/autoheight-allregions.html
             fast/regions/autoheight-breakafteralways-maxheight.html
             fast/regions/autoheight-breakbeforealways.html
             fast/regions/autoheight-firstregion-breakalways.html
             fast/regions/autoheight-lastregion-overflowauto-breaksignored.html
             fast/regions/autoheight-lastregion-overflowauto.html
             fast/regions/autoheight-middleregion.html
             fast/regions/autoheight-secondregion-breakoutside.html
             fast/regions/autoheight-secondregion.html
             fast/regions/autoheight-singleregion-breakafteralways-maxheight.html
             fast/regions/autoheight-singleregion-breakafteralways.html
             fast/regions/autoheight-singleregion-breakaftermargin.html
             fast/regions/autoheight-singleregion-breakbeforealways-minheight.html
             fast/regions/autoheight-singleregion-breakbeforealways.html
             fast/regions/autoheight-singleregion-multiplebreaks.html
             fast/regions/autoheight-singleregion-overflowauto-breaksignored.html
             fast/regions/autoheight-singleregion-overflowauto.html
      
      * rendering/RenderBlock.cpp: When encounter a region break before/after an element inside a flow thread,
      try to use it to determine the override logical content height for auto logical height regions.
      (WebCore::RenderBlock::applyBeforeBreak):
      (WebCore::RenderBlock::applyAfterBreak):
      * rendering/RenderFlowThread.cpp:
      (WebCore::RenderFlowThread::layout):
      (WebCore::RenderFlowThread::computeOverflowStateForRegions):
      Simulate a region break at the end of the flow thread content.
      (WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
      (WebCore::RenderFlowThread::clearOverrideLogicalContentHeightInRegions):
      Helper method used to clear the overrideLogicalContentHeight for auto logical height regions.
      (WebCore::RenderFlowThread::addForcedRegionBreak):
      Extend the method to process region breaks. The method returns true if at least one auto logical height region
      has its override logical content height computed.
      * rendering/RenderFlowThread.h:
      * rendering/RenderRegion.cpp: Make these methods work with auto logical height regions.
      (WebCore::RenderRegion::pageLogicalHeight):
      (WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
      
      LayoutTests:
      
      Add tests for auto logical height regions with content having region breaks.
      
      * fast/regions/autoheight-allregions-expected.html: Added.
      * fast/regions/autoheight-allregions-nobreaks-expected.html: Added.
      * fast/regions/autoheight-allregions-nobreaks.html: Added.
      * fast/regions/autoheight-allregions.html: Added.
      * fast/regions/autoheight-breakafteralways-maxheight-expected.html: Added.
      * fast/regions/autoheight-breakafteralways-maxheight.html: Added.
      * fast/regions/autoheight-breakbeforealways-expected.html: Added.
      * fast/regions/autoheight-breakbeforealways.html: Added.
      * fast/regions/autoheight-firstregion-breakalways-expected.html: Added.
      * fast/regions/autoheight-firstregion-breakalways.html: Added.
      * fast/regions/autoheight-lastregion-overflowauto-breaksignored-expected.html: Added.
      * fast/regions/autoheight-lastregion-overflowauto-breaksignored.html: Added.
      * fast/regions/autoheight-lastregion-overflowauto-expected.html: Added.
      * fast/regions/autoheight-lastregion-overflowauto.html: Added.
      * fast/regions/autoheight-middleregion-expected.html: Added.
      * fast/regions/autoheight-middleregion.html: Added.
      * fast/regions/autoheight-secondregion-breakoutside-expected.html: Added.
      * fast/regions/autoheight-secondregion-breakoutside.html: Added.
      * fast/regions/autoheight-secondregion-expected.html: Added.
      * fast/regions/autoheight-secondregion.html: Added.
      * fast/regions/autoheight-singleregion-breakafteralways-expected.html: Added.
      * fast/regions/autoheight-singleregion-breakafteralways-maxheight-expected.html: Added.
      * fast/regions/autoheight-singleregion-breakafteralways-maxheight.html: Added.
      * fast/regions/autoheight-singleregion-breakafteralways.html: Added.
      * fast/regions/autoheight-singleregion-breakaftermargin-expected.html: Added.
      * fast/regions/autoheight-singleregion-breakaftermargin.html: Added.
      * fast/regions/autoheight-singleregion-breakbeforealways-expected.html: Added.
      * fast/regions/autoheight-singleregion-breakbeforealways-minheight-expected.html: Added.
      * fast/regions/autoheight-singleregion-breakbeforealways-minheight.html: Added.
      * fast/regions/autoheight-singleregion-breakbeforealways.html: Added.
      * fast/regions/autoheight-singleregion-multiplebreaks-expected.html: Added.
      * fast/regions/autoheight-singleregion-multiplebreaks.html: Added.
      * fast/regions/autoheight-singleregion-overflowauto-breaksignored-expected.html: Added.
      * fast/regions/autoheight-singleregion-overflowauto-breaksignored.html: Added.
      * fast/regions/autoheight-singleregion-overflowauto-expected.html: Added.
      * fast/regions/autoheight-singleregion-overflowauto.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132602 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1210a77f
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Enable WebGL · 818cb17d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=97652
      
      Patch by Regina Chung <heejin.r.chung@samsung.com> on 2012-10-26
      Reviewed by Gyuyoung Kim.
      
      .:
      
      Use Graphics Surface to enable WebGL for WebKit2 EFL.
      
      * Source/cmake/OptionsEfl.cmake:
      
      Source/WebCore:
      
      Implemented GraphicsSurface for EFL to enable WebGL for WebKit2.
      Depends on GLX since Evas doesn't provide the necessary functionality.
      
      No new tests. Covered by existing tests.
      
      * PlatformEfl.cmake:
      * platform/graphics/GraphicsContext3D.h:
      * platform/graphics/efl/GraphicsContext3DEfl.cpp:
      (WebCore::GraphicsContext3D::createGraphicsSurfaces):
      * platform/graphics/efl/GraphicsContext3DPrivate.cpp:
      (WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
      (WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
      (WebCore):
      (WebCore::GraphicsContext3DPrivate::createGraphicsSurfaces):
      (WebCore::GraphicsContext3DPrivate::copyToGraphicsSurface):
      (WebCore::GraphicsContext3DPrivate::graphicsSurfaceToken):
      * platform/graphics/efl/GraphicsContext3DPrivate.h:
      (GraphicsContext3DPrivate):
      * platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
      (WebCore::GraphicsContext3D::reshape):
      * platform/graphics/surfaces/efl: Added.
      * platform/graphics/surfaces/efl/GraphicsSurfaceEfl.cpp: Added.
      (WebCore):
      (WebCore::OffScreenRootWindow::get):
      (WebCore::OffScreenRootWindow::~OffScreenRootWindow):
      (WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
      (WebCore::GraphicsSurfacePrivate::createSurface):
      (WebCore::GraphicsSurfacePrivate::makeCurrent):
      (WebCore::GraphicsSurfacePrivate::doneCurrent):
      (WebCore::GraphicsSurfacePrivate::swapBuffers):
      (WebCore::GraphicsSurface::platformBeginPaint):
      (WebCore::GraphicsSurface::createReadOnlyImage):
      * platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
      * platform/graphics/surfaces/qt/GraphicsSurfaceGLX.h: Added.
      (WebCore):
      (OffScreenRootWindow):
      (WebCore::OffScreenRootWindow::OffScreenRootWindow):
      (GraphicsSurfacePrivate):
      (WebCore::GraphicsSurfacePrivate::~GraphicsSurfacePrivate):
      (WebCore::GraphicsSurfacePrivate::createPixmap):
      (WebCore::GraphicsSurfacePrivate::copyFromTexture):
      (WebCore::GraphicsSurfacePrivate::display):
      (WebCore::GraphicsSurfacePrivate::glxPixmap):
      (WebCore::GraphicsSurfacePrivate::size):
      (WebCore::GraphicsSurfacePrivate::glContext):
      (WebCore::resolveGLMethods):
      * platform/graphics/surfaces/qt/GraphicsSurfaceQt.cpp:
      (WebCore):
      (WebCore::OffScreenRootWindow::OffScreenRootWindow::get):
      (WebCore::OffScreenRootWindow::~OffScreenRootWindow):
      (WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
      (WebCore::GraphicsSurfacePrivate::createSurface):
      (WebCore::GraphicsSurfacePrivate::makeCurrent):
      (WebCore::GraphicsSurfacePrivate::doneCurrent):
      (WebCore::GraphicsSurfacePrivate::swapBuffers):
      
      Source/WebKit2:
      
      Set WebGLEnabled to true when WebGL is enabled.
      
      * UIProcess/API/efl/ewk_view.cpp:
      (_ewk_view_initialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      818cb17d
    • commit-queue@webkit.org's avatar
      Add feature flags for CSS Device Adaptation · b885adcb
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=95960
      
      Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-10-26
      Reviewed by Kenneth Rohde Christiansen.
      
      .:
      
      * Source/cmake/WebKitFeatures.cmake:
      * Source/cmakeconfig.h.cmake:
      * configure.ac:
      
      Source/JavaScriptCore:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebCore:
      
      * Configurations/FeatureDefines.xcconfig:
      * GNUmakefile.am:
      * GNUmakefile.features.am:
      
      Source/WebKit/chromium:
      
      * features.gypi:
      
      Source/WebKit/mac:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Source/WebKit2:
      
      * Configurations/FeatureDefines.xcconfig:
      
      Tools:
      
      * Scripts/webkitperl/FeatureList.pm:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132600 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b885adcb
    • commit-queue@webkit.org's avatar
      fast/forms/file/input-file-write-files.html should cover correct setting value · 51df952a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100085
      
      Patch by Li Yin <li.yin@intel.com> on 2012-10-26
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      From Spec: http://dev.w3.org/html5/spec/single-page.html#dom-input-value-filename
      On setting, if the new value is the empty string, it must empty the list of selected
      files; otherwise, it must throw an InvalidStateError exception.
      
      Test: fast/forms/file/input-file-value.html
      
      * html/HTMLInputElement.cpp:
      (WebCore::HTMLInputElement::setValue):
      (WebCore):
      * html/HTMLInputElement.h:
      (HTMLInputElement):
      * html/HTMLInputElement.idl:
      
      LayoutTests:
      
      The test input-file-value.html is split from input-file-write-test.html.
      And add correct setting value for files attribute, verify the files attribute
      is writable or not.
      
      * fast/forms/file/input-file-value-expected.txt: Added.
      * fast/forms/file/input-file-value.html: Added.
      * fast/forms/file/input-file-write-files-expected.txt:
      * fast/forms/file/input-file-write-files.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132599 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51df952a
    • commit-queue@webkit.org's avatar
      [EFL] Gardening after bug 99824 · f57d5555
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100469
      
      Unreviewed, EFL gardening.
      
      Unskip following 3 test cases after bug 99824 is resolved.
       - fast/lists/w3-css3-list-styles-alphabetic.html
       - fast/lists/w3-css3-list-styles-fallback-style.html
       - fast/lists/w3-list-styles.html
      
      Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-26
      
      * platform/efl-wk1/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132598 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f57d5555
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r132552. · ccd5bb02
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/132552
      https://bugs.webkit.org/show_bug.cgi?id=100486
      
      Makes typeahead tests crash in debug. (Requested by pfeldman
      on #webkit).
      
      Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-10-26
      
      * DumpRenderTree/DumpRenderTree.gypi:
      * DumpRenderTree/chromium/DRTTestRunner.h:
      * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
      (WebTestDelegate):
      * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
      * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
      (WebTestRunner):
      (WebTestRunner::EventSender::doDragDrop):
      (WebTestRunner::EventSender::updateClickCountForButton):
      (WebTestRunner::EventSender::mouseDown):
      (WebTestRunner::EventSender::mouseUp):
      (WebTestRunner::EventSender::mouseMoveTo):
      (WebTestRunner::EventSender::keyDown):
      (WebTestRunner::EventSender::replaySavedEvents):
      (WebTestRunner::EventSender::contextClick):
      (WebTestRunner::EventSender::beginDragWithFiles):
      (WebTestRunner::EventSender::sendCurrentTouchEvent):
      (WebTestRunner::EventSender::handleMouseWheel):
      (WebTestRunner::EventSender::gestureEvent):
      (WebTestRunner::EventSender::gestureFlingCancel):
      (WebTestRunner::EventSender::gestureFlingStart):
      * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
      * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
      * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
      (TestDelegate):
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
      * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
      (WebKit):
      (webkit_support):
      * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
      (WebTestInterfaces::Internal):
      * DumpRenderTree/chromium/WebViewHost.cpp:
      * DumpRenderTree/chromium/WebViewHost.h:
      (WebViewHost):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132597 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ccd5bb02
    • keishi@webkit.org's avatar
      Refactor calendar picker to remove _x/_y from DaysTable · 665b605e
      keishi@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100460
      
      Reviewed by Kent Tamura.
      
      _x/_y properties keep the coordinates for the selection but when we add
      week and month picking capabilities, the selection can't be expressed as
      a set of coordinates. This change will remove it.
      
      No new tests. Covered by calendar-picker-*.html tests.
      
      * Resources/pagepopups/calendarPicker.js:
      (DaysTable): Removed _x/_y properties.
      (DaysTable.prototype._hasSelection): Changed to refer to the DOM to see if we have a selection.
      (DaysTable.prototype.navigateToMonthAndKeepSelectionPosition): Lookup the selection position.
      (DaysTable.prototype.selectDate): Deselect first so we don't have two selections.
      (DaysTable.prototype._selectRangeContainingNode): Selects date/week/month containing the given day node.
      (DaysTable.prototype._selectRangeAtPosition): Selects date/week/month at the given position.
      (DaysTable.prototype._firstNodeInSelectedRange): Returns first selected day node.
      (DaysTable.prototype._deselect): Deselects all selections.
      (DaysTable.prototype._handleMouseOver): Use _selectRangeContainingNode so we don't have many places handling the selection.
      (DaysTable.prototype._handleMouseOut): Use _deselect.
      (DaysTable.prototype._handleKey): Lookup the selection position.
      (DaysTable.prototype.updateSelection): Use _selectRangeAtPosition.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132596 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      665b605e
    • commit-queue@webkit.org's avatar
      [EFL] Unskip svg/foreignObject/viewport-foreignobject-crash.html · a7d52a9e
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100467
      
      Unreviewed, EFL gardening.
      
      Removing a test failure expectations, the test was fixed in r132548.
      
      Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-26
      
      * platform/efl-wk2/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132595 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7d52a9e
    • commit-queue@webkit.org's avatar
      [EFL][WK2] Move input method code out of EwkViewImpl · c261bad7
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100468
      
      Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-26
      Reviewed by Kenneth Rohde Christiansen.
      
      Move input method code out of EwkViewImpl and into
      a new InputMethodContextEfl class to avoid cluttering
      the view code.
      
      * PlatformEfl.cmake:
      * UIProcess/API/efl/EwkViewImpl.cpp:
      (EwkViewImpl::EwkViewImpl):
      (EwkViewImpl::inputMethodContext):
      * UIProcess/API/efl/EwkViewImpl.h:
      (WebKit):
      (EwkViewImpl):
      * UIProcess/API/efl/ewk_view.cpp:
      (_ewk_view_smart_mouse_up):
      (_ewk_view_smart_key_down):
      * UIProcess/efl/InputMethodContextEfl.cpp: Added.
      (WebKit):
      (WebKit::InputMethodContextEfl::InputMethodContextEfl):
      (WebKit::InputMethodContextEfl::~InputMethodContextEfl):
      (WebKit::InputMethodContextEfl::onIMFInputSequenceComplete):
      (WebKit::InputMethodContextEfl::onIMFPreeditSequenceChanged):
      (WebKit::InputMethodContextEfl::createIMFContext):
      (WebKit::InputMethodContextEfl::handleMouseUpEvent):
      (WebKit::InputMethodContextEfl::handleKeyDownEvent):
      (WebKit::InputMethodContextEfl::updateTextInputState):
      * UIProcess/efl/InputMethodContextEfl.h: Added.
      (WebKit):
      (InputMethodContextEfl):
      (WebKit::InputMethodContextEfl::create):
      * UIProcess/efl/PageClientImpl.cpp:
      (WebKit::PageClientImpl::updateTextInputState):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132594 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c261bad7
    • tkent@chromium.org's avatar
      [Chromium]... · 3fe4b751
      tkent@chromium.org authored
      [Chromium] platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html fails every 3 days
      https://bugs.webkit.org/show_bug.cgi?id=100480
      
      Reviewed by Pavel Feldman.
      
      Because the date field in the test has step=3, the availability of
      [Today] button depends on the current date. We make the test stable by
      specifying max attribute.
      
      * platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
      * platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3fe4b751
    • commit-queue@webkit.org's avatar
      FileReader abort case causes Chromium renderer crash · 0f317e58
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99142
      
      Patch by Ningxin Hu <ningxin.hu@intel.com> on 2012-10-26
      Reviewed by Kentaro Hara.
      
      Before dispatching load event, FileReader should check if it is
      in aborting.
      
      Test: manually launch fast/files/file-reader-abort.html in Chromium
      browser and compare the result with
      fast/files/file-reader-abort-expected.txt.
      
      * fileapi/FileReader.cpp:
      (WebCore::FileReader::didFinishLoading):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132592 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f317e58
    • jchaffraix@webkit.org's avatar
      Generate less repaint calls during subtree detaching · dc47c36c
      jchaffraix@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99741
      
      Reviewed by Eric Seidel.
      
      Source/WebCore:
      
      Following bug 98336, detach is now a subtree top-down operation. Because we
      track visual overflow from our children during layout for most cases, we can
      generate a repaint only on the subtree root.
      
      On http://dglazkov.github.com/performance-tests/redraw.html, this ups the FPS to
      26 fps from 22 fps on my MBP (+ 15%). On PerformanceTests/layout/subtree-detach.html,
      it decreases the time by 35%. This is due to being the best case and we now generate
      only one repaint per detach phase.
      
      Covered by existing pixels tests (including but not limited to repaint ones).
      
      * rendering/RenderObject.cpp:
      (WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):
      Changed the function not to be recursive anymore to generate one painting for
      our root only. Added a FIXME about using our RenderLayer for repainting to avoid
      the cost of computing our absolute repaint rectangle.
      
      * rendering/RenderObjectChildList.cpp:
      (WebCore::RenderObjectChildList::removeChildNode):
      Removed the logic for repainting in the general case. However we still force a repaint
      if we have a RenderLayer as we don't track their overflow in some cases (e.g. positioned
      objects). This check is conservative and could be narrowed down (e.g overflow RenderLayers
      are properly accounted for in our clipppedOverflowRectForRepaint).
      
      LayoutTests:
      
      * platform/chromium-linux/fast/repaint/selection-after-remove-expected.png:
      Rebaselined this test after the change. It is progressing as we still properly repaint
      the selection, but repaint less (ie don't repaint the top border which didn't change).
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dc47c36c
    • commit-queue@webkit.org's avatar
      [WIN] Make LLInt offsets extractor work on Windows · 0bbdcdcd
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100369
      
      Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-10-26
      Reviewed by Kenneth Rohde Christiansen.
      
      Open the input file explicitly in binary mode to prevent ruby/Windows from thinking that
      it's a text mode file that needs even new line conversions. The binary mode parameter is
      ignored on other platforms.
      
      * offlineasm/offsets.rb:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132590 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0bbdcdcd
    • bashi@chromium.org's avatar
      local(Helvetica) in src descriptor prevent fallback · d7b49958
      bashi@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100446
      
      Reviewed by Dan Bernstein.
      
      FontCache::getCachedFontData() has a mechanism that aliases a few pairs
      of font family names, so that if the family name specified in the font-family
      property is not available on the system, but the its alias is available,
      it will be used instead. This is appropriate for the font-family property,
      but not for font family names specified in the local() function of the src
      descriptor in a @font-face rule.
      
      This patch disables the mechanism while checking src descriptor of @font-face.
      
      No new tests. It's difficult to test the change because 'Helvetica' can
      be mapped any other font. For example, chromium DRT uses FontConfig to
      map Helvetica to Times New Roman. Other ports may map Helvetica to other
      fonts. We can't define the expected result.
      
      * css/CSSFontFaceSource.cpp:
      (WebCore::CSSFontFaceSource::getFontData):
      Call fontCache()->getCachedFontData() with checkingAlternateName = true.
      This disables aliasing font family names in FontCache.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132589 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7b49958
    • commit-queue@webkit.org's avatar
      Web Inspector: Doctype Audits panel code · eb4dbe83
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100371
      
      Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-26
      Reviewed by Alexander Pavlov.
      
      This is a preparation step for ongoing refactoring.
      It is much easier to read doctyped code.
      
      * inspector/front-end/AuditRules.js:
      (WebInspector.AuditRules.MinimizeDnsLookupsRule.prototype.doRun):
      Replaced "undefined" with "null"
      * inspector/front-end/AuditsPanel.js:
      (WebInspector.AuditCategory.prototype.callbackWrapper):
      Removed callback parameter indirection.
      (WebInspector.AuditRuleResult.prototype.addFormatted):
      Converted private instance function to scoped function.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132588 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb4dbe83
    • tkent@chromium.org's avatar
      [Chromium] Test expectation update. · c4a0552c
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100471
      
      * platform/chromium/TestExpectations:
      We should do rebaseline for time-suggestion-picker-*.html too.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132587 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c4a0552c
    • tkent@chromium.org's avatar
      Disable ENABLE_INPUT_TYPE_WEEK on Chromium/Android · e8ab7bcf
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100457
      
      Reviewed by Kentaro Hara.
      
      Source/WebKit/chromium:
      
      It was enabled accidentally. Week input is not implemented in
      Android.
      
      * features.gypi: Remove ENABLE_INPUT_TYPE_WEEK=1 in the common block,
      add ENABLE_INPUT_TYPE_WEEK=0 in Android block, and add
      ENABLE_INPUT_TYPE_WEEK=1 in non-Android block.
      
      LayoutTests:
      
      * platform/chromium/TestExpectations:
      Tests in fast/forms/week/ may fail on Android.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e8ab7bcf
    • pfeldman@chromium.org's avatar
      Not reviewed: chromiuim expectations updated. · 5e352dc3
      pfeldman@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132585 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e352dc3
    • kbalazs@webkit.org's avatar
      [Qt] Pixel tests need rebaseline · ac104529
      kbalazs@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99323
      
      Unreviewed pixel rebaseline.
      
      Adding new expectations, mark failures.
      
      * platform/qt-5.0-wk2/TestExpectations:
      * platform/qt-5.0-wk2/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/bgCompositeCopy-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize01-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize02-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize04-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize05-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize06-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize07-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize12-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize13-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize14-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize17-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize18-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize19-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize20-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize21-expected.png: Added.
      * platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize22-expected.png: Added.
      * platform/qt-5.0-wk2/svg/css/arrow-with-shadow-expected.png: Added.
      * platform/qt/TestExpectations:
      * platform/qt/animations/state-at-end-event-expected.png: Added.
      * platform/qt/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.png: Added.
      * platform/qt/compositing/overflow/nested-scrolling-expected.png: Added.
      * platform/qt/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor-expected.png: Added.
      * platform/qt/compositing/overflow/remove-overflow-crash2-expected.png: Added.
      * platform/qt/css2.1/t1004-c43-rpl-ibx-00-d-ag-expected.png: Added.
      * platform/qt/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
      * platform/qt/css2.1/t100801-c544-valgn-01-d-ag-expected.png: Added.
      * platform/qt/css2.1/t100801-c548-ln-ht-02-b-ag-expected.png: Added.
      * platform/qt/css2.1/t1202-counters-04-b-expected.png: Added.
      * platform/qt/css2.1/t140201-c534-bgreps-00-c-ag-expected.png: Added.
      * platform/qt/css2.1/t140201-c534-bgreps-01-c-ag-expected.png: Added.
      * platform/qt/css2.1/t140201-c534-bgreps-02-c-ag-expected.png: Added.
      * platform/qt/css2.1/t140201-c534-bgreps-03-c-ag-expected.png: Added.
      * platform/qt/css2.1/t140201-c534-bgreps-04-c-ag-expected.png: Added.
      * platform/qt/css2.1/t140201-c534-bgreps-05-c-ag-expected.png: Added.
      * platform/qt/css2.1/t1601-c547-indent-00-b-a-expected.png: Added.
      * platform/qt/css2.1/t1602-c43-center-00-d-ag-expected.png: Added.
      * platform/qt/css2.1/t1604-c542-letter-sp-00-b-a-expected.png: Added.
      * platform/qt/css2.1/t1604-c542-letter-sp-01-b-a-expected.png: Added.
      * platform/qt/css2.1/t1605-c545-txttrans-00-b-ag-expected.png: Added.
      * platform/qt/css3/flexbox/flexbox-baseline-expected.png: Added.
      * platform/qt/css3/flexbox/flexbox-baseline-margins-expected.png: Added.
      * platform/qt/css3/flexbox/repaint-during-resize-no-flex-expected.png: Added.
      * platform/qt/fast/backgrounds/bgCompositeCopy-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize01-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize02-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize03-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize04-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize05-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize06-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize07-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize08-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize09-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize10-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize11-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize12-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize13-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize14-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize17-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize18-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize19-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize20-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize21-expected.png: Added.
      * platform/qt/fast/backgrounds/size/backgroundSize22-expected.png: Added.
      * platform/qt/fast/block/float/009-expected.png: Added.
      * platform/qt/fast/block/float/034-expected.png: Added.
      * platform/qt/fast/block/float/4145535Crash-expected.png: Added.
      * platform/qt/fast/block/float/negative-margin-clear-expected.png: Added.
      * platform/qt/fast/block/float/nowrap-clear-min-width-expected.png: Added.
      * platform/qt/fast/borders/border-image-scaled-gradient-expected.png: Added.
      * platform/qt/fast/borders/border-radius-circle-expected.png: Added.
      * platform/qt/fast/borders/border-radius-groove-01-expected.png: Added.
      * platform/qt/fast/borders/border-radius-groove-02-expected.png: Added.
      * platform/qt/fast/borders/border-radius-groove-03-expected.png: Added.
      * platform/qt/fast/borders/border-radius-valid-border-clipping-expected.png: Added.
      * platform/qt/fast/borders/border-radius-wide-border-01-expected.png: Added.
      * platform/qt/fast/borders/border-radius-wide-border-02-expected.png: Added.
      * platform/qt/fast/borders/border-radius-wide-border-03-expected.png: Added.
      * platform/qt/fast/borders/border-radius-wide-border-04-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDashed04-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDashed05-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDashed06-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDotted04-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDotted05-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDotted06-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDouble04-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDouble05-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDouble06-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDouble07-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDouble08-expected.png: Added.
      * platform/qt/fast/borders/borderRadiusDouble09-expected.png: Added.
      * platform/qt/fast/borders/outline-offset-min-assert-expected.png: Added.
      * platform/qt/fast/css/006-expected.png: Added.
      * platform/qt/fast/css/background-clip-values-expected.png: Added.
      * platform/qt/fast/css/bogus-color-span-expected.png: Added.
      * platform/qt/fast/css/box-shadow-and-border-radius-expected.png:
      * platform/qt/fast/css/content-dynamic-expected.png: Added.
      * platform/qt/fast/css/contentDiv-expected.png: Added.
      * platform/qt/fast/css/contentDivWithChildren-expected.png: Added.
      * platform/qt/fast/css/contentImage-expected.png: Added.
      * platform/qt/fast/css/pseudo-first-line-border-width-expected.png: Added.
      * platform/qt/fast/css/replaced-element-implicit-size-expected.png: Added.
      * platform/qt/fast/dom/attr_dead_doc-expected.png: Added.
      * platform/qt/fast/dom/css-cached-import-rule-expected.png: Added.
      * platform/qt/fast/dom/css-insert-import-rule-expected.png: Added.
      * platform/qt/fast/dynamic/001-expected.png: Added.
      * platform/qt/fast/dynamic/005-expected.png: Added.
      * platform/qt/fast/dynamic/anonymous-block-layer-lost-expected.png: Added.
      * platform/qt/fast/dynamic/staticY-expected.png: Added.
      * platform/qt/fast/forms/002-expected.png: Added.
      * platform/qt/fast/forms/003-expected.png: Added.
      * platform/qt/fast/forms/004-expected.png: Added.
      * platform/qt/fast/forms/005-expected.png: Added.
      * platform/qt/fast/forms/006-expected.png: Added.
      * platform/qt/fast/forms/007-expected.png: Added.
      * platform/qt/fast/forms/HTMLOptionElement_label01-expected.png: Added.
      * platform/qt/fast/forms/HTMLOptionElement_label02-expected.png: Added.
      * platform/qt/fast/forms/HTMLOptionElement_label03-expected.png: Added.
      * platform/qt/fast/forms/HTMLOptionElement_label04-expected.png: Added.
      * platform/qt/fast/forms/button-submit-expected.png: Added.
      * platform/qt/fast/forms/caret-rtl-expected.png: Added.
      * platform/qt/fast/forms/control-clip-expected.png: Added.
      * platform/qt/fast/forms/fieldset-with-float-expected.png: Added.
      * platform/qt/fast/forms/form-added-to-table-expected.png: Added.
      * platform/qt/fast/forms/form-in-malformed-markup-expected.png: Added.
      * platform/qt/fast/forms/formmove-expected.png: Added.
      * platform/qt/fast/forms/formmove2-expected.png: Added.
      * platform/qt/fast/forms/image-border-expected.png: Added.
      * platform/qt/fast/forms/indeterminate-expected.png: Added.
      * platform/qt/fast/forms/input-align-image-expected.png: Added.
      * platform/qt/fast/forms/input-first-letter-expected.png: Added.
      * platform/qt/fast/forms/input-no-renderer-expected.png: Added.
      * platform/qt/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Added.
      * platform/qt/fast/forms/menulist-deselect-update-expected.png: Added.
      * platform/qt/fast/forms/menulist-no-overflow-expected.png: Added.
      * platform/qt/fast/forms/option-index-expected.png: Added.
      * platform/qt/fast/forms/option-script-expected.png: Added.
      * platform/qt/fast/forms/option-text-clip-expected.png: Added.
      * platform/qt/fast/forms/preserveFormDuringResidualStyle-expected.png: Added.
      * platform/qt/fast/forms/range/thumbslider-no-parent-slider-expected.png: Added.
      * platform/qt/fast/forms/select-align-expected.png: Added.
      * platform/qt/fast/forms/select-change-listbox-to-popup-expected.png: Added.
      * platform/qt/fast/forms/select-dirty-parent-pref-widths-expected.png: Added.
      * platform/qt/fast/forms/select-disabled-appearance-expected.png: Added.
      * platform/qt/fast/forms/select-display-none-style-resolve-expected.png: Added.
      * platform/qt/fast/forms/select-empty-option-height-expected.png: Added.
      * platform/qt/fast/forms/select-selected-expected.png: Added.
      * platform/qt/fast/forms/select-size-expected.png: Added.
      * platform/qt/fast/forms/select-style-expected.png: Added.
      * platform/qt/fast/forms/stuff-on-my-optgroup-expected.png: Added.
      * platform/qt/fast/forms/textfield-overflow-by-value-update-expected.png: Added.
      * platform/qt/fast/frames/002-expected.png: Added.
      * platform/qt/fast/frames/calculate-round-expected.png: Added.
      * platform/qt/fast/frames/content-opacity-1-expected.png: Added.
      * platform/qt/fast/frames/content-opacity-2-expected.png: Added.
      * platform/qt/fast/frames/empty-cols-attribute-expected.png: Added.
      * platform/qt/fast/frames/empty-frame-src-expected.png: Added.
      * platform/qt/fast/frames/frame-length-fractional-expected.png: Added.
      * platform/qt/fast/frames/frame-set-whitespace-attributes-expected.png: Added.
      * platform/qt/fast/frames/iframe-text-contents-expected.png: Added.
      * platform/qt/fast/frames/no-frame-borders-expected.png: Added.
      * platform/qt/fast/gradients/border-image-gradient-expected.png: Added.
      * platform/qt/fast/gradients/border-image-gradient-sides-and-corners-expected.png: Added.
      * platform/qt/fast/images/embed-image-expected.png: Added.
      * platform/qt/fast/images/favicon-as-image-expected.png: Added.
      * platform/qt/fast/images/image-css3-content-data-expected.png: Added.
      * platform/qt/fast/images/object-image-expected.png: Added.
      * platform/qt/fast/images/pdf-as-image-expected.png: Added.
      * platform/qt/fast/inline-block/004-expected.png: Added.
      * platform/qt/fast/inline-block/005-expected.png: Added.
      * platform/qt/fast/invalid/015-expected.png: Added.
      * platform/qt/fast/invalid/table-residual-style-crash-expected.png: Added.
      * platform/qt/fast/js/exception-linenums-in-html-3-expected.png: Added.
      * platform/qt/fast/js/missing-style-end-tag-js-expected.png: Added.
      * platform/qt/fast/js/missing-title-end-tag-js-expected.png: Added.
      * platform/qt/fast/layers/opacity-stacking-expected.png: Added.
      * platform/qt/fast/layers/positioned-inside-root-with-margins-expected.png: Added.
      * platform/qt/fast/layers/zindex-ridonkulous-expected.png: Added.
      * platform/qt/fast/media/implicit-media-all-expected.png: Added.
      * platform/qt/fast/media/media-query-invalid-value-expected.png: Added.
      * platform/qt/fast/media/monochrome-expected.png: Added.
      * platform/qt/fast/media/mq-min-pixel-ratio-expected.png: Added.
      * platform/qt/fast/overflow/position-relative-expected.png: Added.
      * platform/qt/fast/overflow/unreachable-content-test-expected.png: Added.
      * platform/qt/fast/parser/comment-in-script-expected.png: Added.
      * platform/qt/fast/parser/style-script-head-test-expected.png: Added.
      * platform/qt/fast/reflections/table-cell-expected.png: Added.
      * platform/qt/fast/repaint/background-generated-expected.png: Added.
      * platform/qt/fast/repaint/background-misaligned-expected.png: Added.
      * platform/qt/fast/repaint/canvas-putImageData-expected.png: Added.
      * platform/qt/fast/repaint/erase-overflow-expected.png: Added.
      * platform/qt/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
      * platform/qt/fast/repaint/float-new-in-block-expected.png: Added.
      * platform/qt/fast/repaint/inline-block-resize-expected.png: Added.
      * platform/qt/fast/repaint/intermediate-layout-position-clip-expected.png: Added.
      * platform/qt/fast/repaint/intermediate-layout-position-expected.png: Added.
      * platform/qt/fast/repaint/layer-full-repaint-expected.png: Added.
      * platform/qt/fast/repaint/table-col-background-expected.png: Added.
      * platform/qt/fast/repaint/table-outer-border-expected.png: Added.
      * platform/qt/fast/repaint/table-row-expected.png: Added.
      * platform/qt/fast/repaint/table-section-overflow-expected.png: Added.
      * platform/qt/fast/replaced/008-expected.png: Added.
      * platform/qt/fast/replaced/image-tag-expected.png: Added.
      * platform/qt/fast/replaced/selection-rect-expected.png: Added.
      * platform/qt/fast/table/008-expected.png: Added.
      * platform/qt/fast/table/024-expected.png: Added.
      * platform/qt/fast/table/031-expected.png: Added.
      * platform/qt/fast/table/caption-relayout-expected.png: Added.
      * platform/qt/fast/table/colspanMinWidth-vertical-expected.png: Added.
      * platform/qt/fast/table/div-as-col-span-expected.png: Added.
      * platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.png: Added.
      * platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.png: Added.
      * platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.png: Added.
      * platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.png: Added.
      * platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.png: Added.
      * platform/qt/fast/table/fixed-table-with-small-percent-width-expected.png: Added.
      * platform/qt/fast/table/giantRowspan-expected.png: Added.
      * platform/qt/fast/table/growCellForImageQuirk-expected.png: Added.
      * platform/qt/fast/table/percent-widths-stretch-expected.png: Added.
      * platform/qt/fast/table/vertical-align-baseline-readjust-expected.png: Added.
      * platform/qt/fast/text/align-center-rtl-spill-expected.png: Added.
      * platform/qt/fast/text/basic/013-expected.png: Added.
      * platform/qt/fast/text/basic/015-expected.png: Added.
      * platform/qt/fast/text/line-breaks-expected.png: Added.
      * platform/qt/fast/text/soft-hyphen-3-expected.png: Added.
      * platform/qt/fast/text/stripNullFromText-expected.png: Added.
      * platform/qt/fast/text/whitespace/017-expected.png: Added.
      * platform/qt/fast/tokenizer/missing-style-end-tag-1-expected.png: Added.
      * platform/qt/fast/tokenizer/missing-style-end-tag-2-expected.png: Added.
      * platform/qt/fast/tokenizer/script-after-frameset-expected.png: Added.
      * platform/qt/fast/xsl/xslt-mismatched-tags-in-xslt-expected.png: Added.
      * platform/qt/http/tests/security/contentSecurityPolicy/xsl-blocked-expected.png: Added.
      * platform/qt/svg/as-background-image/svg-as-background-1-expected.png: Added.
      * platform/qt/svg/as-background-image/svg-as-background-2-expected.png: Added.
      * platform/qt/svg/as-background-image/svg-as-background-3-expected.png: Added.
      * platform/qt/svg/as-background-image/svg-as-background-6-expected.png: Added.
      * platform/qt/svg/as-background-image/svg-as-background-expected.png: Added.
      * platform/qt/svg/as-background-image/svg-as-tiled-background-expected.png: Added.
      * platform/qt/svg/as-background-image/svg-width-100p-as-background-expected.png: Added.
      * platform/qt/svg/as-image/svg-as-image-expected.png: Added.
      * platform/qt/svg/as-image/svg-as-relative-image-expected.png: Added.
      * platform/qt/svg/css/arrow-with-shadow-expected.png: Added.
      * platform/qt/svg/css/circle-in-mask-with-shadow-expected.png: Added.
      * platform/qt/svg/css/path-with-shadow-expected.png: Added.
      * platform/qt/svg/css/shadow-and-opacity-expected.png: Added.
      * platform/qt/svg/css/shadow-with-large-radius-expected.png: Added.
      * platform/qt/svg/css/shadow-with-negative-offset-expected.png: Added.
      * platform/qt/svg/custom/animation-currentColor-expected.png: Added.
      * platform/qt/svg/custom/clip-path-id-changes-expected.png: Added.
      * platform/qt/svg/custom/createImageElement-expected.png: Added.
      * platform/qt/svg/custom/gradient-userSpaceOnUse-with-percentage-expected.png: Added.
      * platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.png: Added.
      * platform/qt/svg/custom/js-update-image-and-display-expected.png: Added.
      * platform/qt/svg/custom/js-update-image-and-display2-expected.png: Added.
      * platform/qt/svg/custom/js-update-image-and-display3-expected.png: Added.
      * platform/qt/svg/custom/marker-opacity-expected.png: Added.
      * platform/qt/svg/custom/marker-referencePoint-expected.png: Added.
      * platform/qt/svg/custom/marker-strokeWidth-changes-expected.png: Added.
      * platform/qt/svg/custom/mask-on-multiple-objects-expected.png: Added.
      * platform/qt/svg/custom/mask-with-default-value-expected.png: Added.
      * platform/qt/svg/custom/outer-svg-unknown-feature-expected.png: Added.
      * platform/qt/svg/custom/pan-direction-expected.png: Added.
      * platform/qt/svg/custom/pattern-excessive-malloc-expected.png: Added.
      * platform/qt/svg/custom/repaint-shadow-expected.png: Added.
      * platform/qt/svg/custom/transformedMaskFails-expected.png: Added.
      * platform/qt/svg/custom/use-inherit-style-expected.png: Added.
      * platform/qt/svg/custom/xhtml-no-svg-renderer-expected.png: Added.
      * platform/qt/svg/filters/feGaussianBlur-expected.png: Added.
      * platform/qt/svg/filters/feLighting-crash-expected.png: Added.
      * platform/qt/svg/filters/feMerge-expected.png: Added.
      * platform/qt/svg/filters/feMerge-wrong-input-expected.png: Added.
      * platform/qt/svg/filters/feOffset-expected.png: Added.
      * platform/qt/svg/filters/feTile-expected.png: Added.
      * platform/qt/svg/filters/filter-clip-expected.png: Added.
      * platform/qt/svg/filters/filter-rounding-issues-expected.png: Added.
      * platform/qt/svg/filters/shadow-on-filter-expected.png: Added.
      * platform/qt/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
      * platform/qt/svg/filters/subRegion-in-userSpace-expected.png: Added.
      * platform/qt/svg/hixie/error/006-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug120107-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug1271-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug12908-2-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug12910-2-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug131020-2-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug13169-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug137388-3-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug1818-3-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug1818-6-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug196870-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug222336-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug222467-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug269566-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug277062-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug28933-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug2954-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug50695-2-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug56201-expected.png: Added.
      * platform/qt/tables/mozilla/bugs/bug8032-2-expected.png: Added.
      * platform/qt/tables/mozilla/core/col_widths_fix_autoFixPer-expected.png: Added.
      * platform/qt/transitions/opacity-transition-zindex-expected.png: Added.
      * platform/qt/transitions/transition-end-event-rendering-expected.png: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132584 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ac104529
    • commit-queue@webkit.org's avatar
      [Qt]REGRESSION(r131428): cookies.db created on wrong place · 9e9a200f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=99445
      
      Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-10-26
      Reviewed by Simon Hausmann.
      
      Added a slash to the path of cookies.db in CookieJarQt.cpp.
      
      * platform/qt/CookieJarQt.cpp:
      (WebCore::SharedCookieJarQt::SharedCookieJarQt):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132583 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e9a200f
    • commit-queue@webkit.org's avatar
      [BlackBerry] Support pixel tests for BlackBerry DRT · e10c3543
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100210
      
      Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-10-26
      Reviewed by Rob Buis.
      
      Source/WebKit:
      
      Adds a step to build ImageDiff from Qt for DRT. Most of the works are
      accomplished by Christopher Wells.
      
      * PlatformBlackBerry.cmake:
      
      Tools:
      
      The implementation is based on the patch from Christopher Wells.
      
      * DumpRenderTree/blackberry/DumpRenderTree.cpp:
      (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
      (BlackBerry::WebKit::DumpRenderTree::runTest):
      (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
      (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
      (BlackBerry::WebKit::DumpRenderTree::runTests):
      (BlackBerry::WebKit::DumpRenderTree::dump):
      * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
      (DumpRenderTree):
      
      * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
      (BGRAtoRGBA):
      (encodeBitmapToPNG):
      * DumpRenderTree/blackberry/PNGImageEncoder.h:
      The changes to PNGImageEncoder files are from master_40, patched by Tyler
      Abbott and Rob Buis.
      
      * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
      (createBitmapContextFromWebView):
      (computeMD5HashStringForBitmapContext):
      (printPNG):
      (dumpBitmap):
      * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
      (BitmapContext::createByAdoptingData):
      (BitmapContext::~BitmapContext):
      (BitmapContext):
      (BitmapContext::BitmapContext):
      
      * DumpRenderTree/blackberry/build: Added.
      * DumpRenderTree/blackberry/src.pro: Added.
      Adds 2 files for building ImageDiff, by Christopher Wells.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132582 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e10c3543
    • abarth@webkit.org's avatar
      Unreviewed. This ASSERT is no longer correct (and fires on many tests.) · f41c1661
      abarth@webkit.org authored
      * bindings/v8/V8DOMWrapper.h:
      (WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f41c1661
    • pfeldman@chromium.org's avatar
      Not reviewed: chromiuim expectations updated. · 632f5c8f
      pfeldman@chromium.org authored
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      632f5c8f
    • tkent@chromium.org's avatar
      [Chromium-Win] Support shortTimeFormat · ca169be7
      tkent@chromium.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100471
      
      Reviewed by Kentaro Hara.
      
      Source/WebCore:
      
      No new tests. Covered by fast/forms/time-multiple-fields/ and
      WebKit/chromium/tests/LocaleWinTest.
      
      * platform/text/LocaleWin.cpp:
      (WebCore::LocaleWin::shortTimeFormat):
      Gets a format by LOCALE_SSHORTTIME. If it fails, remove "<delimiter>ss"
      from the format by LOCALE_STIMEFORMAT.
      * platform/text/LocaleWin.h:
      (LocaleWin): Declare m_timeFormatWithoutSeconds.
      
      Source/WebKit/chromium:
      
      * tests/LocaleWinTest.cpp:
      (TEST_F): Update test expectations for the behavior change.
      
      LayoutTests:
      
      * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-basic-expected.png:
      * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-disabled-readonly-expected.png:
      * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-classes-expected.png:
      * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-pseudo-elements-expected.png:
      * platform/chromium-win/fast/forms/time-multiple-fields/time-multiple-fields-appearance-style-expected.png:
      * platform/chromium/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132579 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca169be7
    • commit-queue@webkit.org's avatar
      Implement {get,set}FloatValueForKey · 77397022
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100452
      
      Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-10-26
      Reviewed by Anders Carlsson.
      
      Implement missing functions in WebPreferencesStore.
      
      * Shared/WebPreferencesStore.cpp:
      (WebKit::WebPreferencesStore::setFloatValueForKey):
      (WebKit):
      (WebKit::WebPreferencesStore::getFloatValueForKey):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      77397022
    • kadam@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. · e07dc365
      kadam@inf.u-szeged.hu authored
      Skip a new failing test introduced in r132554 that fails on 32 bit platforms.
      Remove another one that does not exists already.
      
      Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-10-26
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132577 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e07dc365
    • abarth@webkit.org's avatar
      Unreviewed. Update run-bindings-tests results after recent active DOM · a7a88e33
      abarth@webkit.org authored
      object changes.
      
      * bindings/scripts/test/V8/V8TestInterface.cpp:
      (WebCore::V8TestInterface::constructorCallback):
      (WebCore::V8TestInterface::wrapSlow):
      * bindings/scripts/test/V8/V8TestInterface.h:
      (WebCore::V8TestInterface::wrap):
      * bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
      (WebCore::V8TestNamedConstructorConstructorCallback):
      (WebCore::V8TestNamedConstructor::wrapSlow):
      * bindings/scripts/test/V8/V8TestNamedConstructor.h:
      (WebCore::V8TestNamedConstructor::wrap):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132576 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7a88e33
    • abarth@webkit.org's avatar
      [V8] REGRESSION(132540) Assertion failure on V8DOMWrapper::setJSWrapperForDOMNode() · d7db5480
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100462
      
      Patch by MORITA Hajime <morrita@google.com> on 2012-10-26
      Reviewed by Adam Barth.
      
      Removed the no longer correct assertion statement.
      
      No new tests. Covered by breaking tests.
      
      * bindings/v8/V8DOMWrapper.cpp:
      (WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132575 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7db5480
    • abarth@webkit.org's avatar
      [V8] WorkerContextExecutionProxy should use ScopedPersistent · 65ddcfa0
      abarth@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=100443
      
      Reviewed by Eric Seidel.
      
      This class was manually re-implementing the ScopedPersistent pattern.
      
      * bindings/v8/WorkerContextExecutionProxy.cpp:
      (WebCore::WorkerContextExecutionProxy::dispose):
      (WebCore::WorkerContextExecutionProxy::initializeIfNeeded):
      (WebCore::WorkerContextExecutionProxy::evaluate):
      * bindings/v8/WorkerContextExecutionProxy.h:
      (WebCore::WorkerContextExecutionProxy::context):
      (WorkerContextExecutionProxy):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@132574 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      65ddcfa0
  2. 25 Oct, 2012 7 commits