1. 26 Oct, 2009 3 commits
  2. 25 Oct, 2009 10 commits
  3. 24 Oct, 2009 14 commits
    • timothy@apple.com's avatar
      WebInspector: Fixed issue with IME inside console · b149bc94
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30660
      
      Patch by Keishi Hattori <casey.hattori@gmail.com> on 2009-10-24
      Reviewed by Timothy Hatcher.
      
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView.prototype._promptKeyDown):
      * inspector/front-end/DatabaseQueryView.js:
      (WebInspector.DatabaseQueryView.prototype._promptKeyDown):
      * inspector/front-end/inspector.js:
      (WebInspector.loaded):
      (WebInspector.searchKeyDown): Moved performSearch here from WebInspector.searchKeyUp.
      (WebInspector.startEditing.element.handleKeyEvent):
      (WebInspector.startEditing):
      * inspector/front-end/utilities.js:
      (isEnterKey): Added. Check if in IME.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b149bc94
    • bweinstein@apple.com's avatar
      Fixes <https://bugs.webkit.org/show_bug.cgi?id=30752>. · c9bfaf07
      bweinstein@apple.com authored
      Web Inspector: Multiple Selection on Scope Bars by default Conflicts with other behavior on OSX.
              
      Reviewed by Timothy Hatcher.
      
      Have the scope bars select one scope by default, but if the multiple selection key
      is pressed, allow for multiple selection.
      
      * inspector/front-end/ConsoleView.js:
      (WebInspector.ConsoleView):
      (WebInspector.ConsoleView.prototype._updateFilter):
      (WebInspector.ConsoleView.prototype.filter):
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel):
      (WebInspector.ResourcesPanel.prototype.filter):
      (WebInspector.ResourcesPanel.prototype._updateFilter):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9bfaf07
    • weinig@apple.com's avatar
      WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=30751 · 6f70676f
      weinig@apple.com authored
      HTMLOptionsCollection should not inherit from HTMLCollection
      
      Reviewed by Dan Bernstein.
      
      * GNUmakefile.am:
      * WebCore.gypi:
      * WebCore.pro:
      * WebCore.vcproj/WebCore.vcproj:
      * WebCore.xcodeproj/project.pbxproj:
      Added JSHTMLCollectionFunctions.h
      
      * bindings/js/JSHTMLAllCollectionCustom.cpp:
      (WebCore::callHTMLAllCollection):
      (WebCore::JSHTMLAllCollection::nameGetter):
      (WebCore::JSHTMLAllCollection::item):
      (WebCore::JSHTMLAllCollection::namedItem):
      * bindings/js/JSHTMLCollectionCustom.cpp:
      (WebCore::callHTMLCollection):
      (WebCore::JSHTMLCollection::nameGetter):
      (WebCore::JSHTMLCollection::item):
      (WebCore::JSHTMLCollection::namedItem):
      * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
      (WebCore::callHTMLCollection):
      (WebCore::JSHTMLOptionsCollection::getCallData):
      (WebCore::JSHTMLOptionsCollection::canGetItemsForName):
      (WebCore::JSHTMLOptionsCollection::nameGetter):
      (WebCore::JSHTMLOptionsCollection::indexSetter):
      (WebCore::JSHTMLOptionsCollection::item):
      (WebCore::JSHTMLOptionsCollection::namedItem):
      Refactor to use generic implementation of HTMLCollection bindings functions
      from JSHTMLCollectionFunctions.h
      
      * bindings/js/JSHTMLCollectionFunctions.h: Added.
      (WebCore::getCollectionNamedItems):
      (WebCore::getCollectionItems):
      (WebCore::callHTMLCollectionGeneric):
      Added generic functions that JSHTMLCollection, JSHTMLAllCollection and
      JSHTMLOptionsCollection can all use.
      
      * bindings/js/JSHTMLDocumentCustom.cpp: Add include of JSHTMLAllCollection.h
      for toJS on document.all.
      
      * bindings/objc/DOMHTML.mm:
      * bindings/objc/DOMUtility.mm:
      (JSC::createDOMWrapper):
      Remove special cases for HTMLOptionsCollection.
      
      * bindings/scripts/CodeGeneratorJS.pm:
      * html/HTMLAllCollection.idl:
      * html/HTMLCollection.idl:
      * html/HTMLOptionsCollection.idl:
      
      LayoutTests: Update tests for https://bugs.webkit.org/show_bug.cgi?id=30751
      HTMLOptionsCollection should not inherit from HTMLCollection
      
      Reviewed by Dan Bernstein.
      
      * fast/dom/wrapper-classes-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6f70676f
    • timothy@apple.com's avatar
      Make the scope bars in the Web Inspector match other scope bars in Mac OS X. · e5458b88
      timothy@apple.com authored
      Also cleans up the CSS to use classes instead of ID selectors.
      
      https://bugs.webkit.org/show_bug.cgi?id=28186
      
      Reviewed by Dan Bernstein.
      
      * inspector/front-end/ResourcesPanel.js: Add the scope-bar class.
      * inspector/front-end/inspector.css: Lots of changes to make it look right.
      * inspector/front-end/inspector.html: Add the scope-bar class.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e5458b88
    • timothy@apple.com's avatar
      Fix selecting Resources in the Web Inspector's Resources panel. · 0fd7ad7d
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30743
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.prototype.isCategoryVisible): Added.
      (WebInspector.ResourceSidebarTreeElement.prototype.get selectable): Call
      isCategoryVisible on the ResourcesPanel.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fd7ad7d
    • timothy@apple.com's avatar
      Fix the Scope Bar in the Web Inspector's Resource panel, so that selecting · 36cbe8c7
      timothy@apple.com authored
      All will deselect the other filters.
      
      https://bugs.webkit.org/show_bug.cgi?id=30744
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.createFilterElement): Better syntax.
      (WebInspector.ResourcesPanel):
      (WebInspector.ResourcesPanel.prototype.filter): Use a normal for loop,
      and the child variable instead of target in the loop. Other clean up.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36cbe8c7
    • timothy@apple.com's avatar
      Make resizing the Web Inspector's Elements panel sidebar work again. · fe8ddd65
      timothy@apple.com authored
      Also makes Resources panel use the sidebar code in Panel.
      
      https://bugs.webkit.org/show_bug.cgi?id=30742
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/Panel.js:
      (WebInspector.Panel): Don't create the sidebar with an argument.
      (WebInspector.Panel.prototype.show): Call updateSidebarWidth.
      (WebInspector.Panel.prototype.handleKeyEvent): Call handleSidebarKeyEvent.
      (WebInspector.Panel.prototype.handleSidebarKeyEvent): Added.
      (WebInspector.Panel.prototype.createSidebar): Renamed from _createSidebar.
      (WebInspector.Panel.prototype._sidebarDragging): Call updateSidebarWidth.
      (WebInspector.Panel.prototype.updateSidebarWidth): Renamed from _updateSidebarWidth.
      (WebInspector.Panel.prototype.setSidebarWidth): Added. Called by updateSidebarWidth.
      (WebInspector.Panel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
      * inspector/front-end/ProfilesPanel.js:
      (WebInspector.ProfilesPanel): Call createSidebar.
      (WebInspector.ProfilesPanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel.prototype.show): Remove call to _updateSidebarWidth.
      (WebInspector.ResourcesPanel.prototype.showResource): Call updateSidebarWidth
      (WebInspector.ResourcesPanel.prototype.closeVisibleResource): Ditto.
      (WebInspector.ResourcesPanel.prototype.setSidebarWidth): Added.
      (WebInspector.ResourcesPanel.prototype.updateMainViewWidth): Added.
      * inspector/front-end/StoragePanel.js:
      (WebInspector.StoragePanel): Call createSidebar.
      (WebInspector.StoragePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
      * inspector/front-end/TimelinePanel.js:
      (WebInspector.TimelinePanel): Call createSidebar.
      (WebInspector.TimelinePanel.prototype.updateMainViewWidth): Renamed from setMainViewWidth.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe8ddd65
    • timothy@apple.com's avatar
      Call updateSelection() in a few places so hovering in the Web Inspector's · 16a4516c
      timothy@apple.com authored
      Elements panel always has the correct row selection height.
      
      https://bugs.webkit.org/show_bug.cgi?id=30735
      
      Reviewed by Pavel Feldman.
      
      * inspector/front-end/ElementsTreeOutline.js:
      (WebInspector.ElementsTreeElement.prototype.toggleNewAttributeButton): Call updateSelection().
      (WebInspector.ElementsTreeElement.prototype._insertInLastAttributePosition): Ditto.
      * inspector/front-end/inspector.css: Prevent text wrapping in the middle of the add attribute text.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16a4516c
    • eric@webkit.org's avatar
      2009-10-24 Timothy Hatcher <timothy@apple.com> · dd961820
      eric@webkit.org authored
              Remove the re-root tree feature from the Web Inspector's
              Elements panel. This feature wasn't super useful and gets
              in the way of double-click to edit.
      
              https://bugs.webkit.org/show_bug.cgi?id=30736
      
              Reviewed by Pavel Feldman.
      
              * inspector/front-end/ElementsTreeOutline.js:
              (WebInspector.ElementsTreeElement.prototype.ondblclick):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dd961820
    • eric@webkit.org's avatar
      2009-10-24 Anton Muhin <antonm@chromium.org> · a50961a5
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Implements ReturnsNew hint for V8 bindings generation code.
              https://bugs.webkit.org/show_bug.cgi?id=30745
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/V8DOMWrapper.h:
              (WebCore::V8DOMWrapper::convertNewNodeToV8Object):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a50961a5
    • mitz@apple.com's avatar
      Missing images at 350.org due to wrong URLs · 776ffb9b
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=30748
      
      Reviewed by Sam Weinig.
      
      WebCore: 
      
      Test: fast/dom/HTMLImageElement/parse-src.html
      
      * dom/Element.cpp:
      (WebCore::Element::getURLAttribute): Pass the attribute value through deprecateParseURL().
      This matches what the Objective-C bindings do, as well as what HTMLImageLoader::sourceURI()
      and SVGImageLoader::sourceURI() do.
      
      LayoutTests: 
      
      * fast/dom/HTMLImageElement/parse-src-expected.txt: Added.
      * fast/dom/HTMLImageElement/parse-src.html: Added.
      * fast/dom/HTMLImageElement/script-tests: Added.
      * fast/dom/HTMLImageElement/script-tests/TEMPLATE.html: Copied from LayoutTests/fast/dom/Document/script-tests/TEMPLATE.html.
      * fast/dom/HTMLImageElement/script-tests/parse-src.js: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      776ffb9b
    • laszlo.1.gombos@nokia.com's avatar
      2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 11b19b0c
      laszlo.1.gombos@nokia.com authored
              Unreviewed.
      
              [Qt] Build fix for QtWebKit after r50013.
      
              * WebCore.pro:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11b19b0c
    • dglazkov@chromium.org's avatar
      2009-10-24 Dimitri Glazkov <dglazkov@chromium.org> · 5b32f28d
      dglazkov@chromium.org authored
              Unreviewed, build fix.
      
              [V8] Fix up to accommodate for HTMLAllCollection changes in
              http://trac.webkit.org/changeset/49998.
      
              * WebCore.gypi:
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/custom/V8CustomBinding.h:
              * bindings/v8/custom/V8HTMLDocumentCustom.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5b32f28d
    • eric@webkit.org's avatar
      2009-10-24 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 5708acfe
      eric@webkit.org authored
              Reviewed by Holger Freyther.
      
              [Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
              https://bugs.webkit.org/show_bug.cgi?id=30476
      
              Set the stack size to 80 Kb and heap size to the 128kB - 32MB range
              to all executables linking against WebKit library.
      
              * WebKit.pri:
      2009-10-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Holger Freyther.
      
              [Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
              https://bugs.webkit.org/show_bug.cgi?id=30476
      
              Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
              to jsc.exe.
      
              * jsc.pro:
      2009-10-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
      
              Reviewed by Holger Freyther.
      
              [Qt] [Symbian] Set the capability and memory required to run QtWebKit for Symbian
              https://bugs.webkit.org/show_bug.cgi?id=30476
      
              Assign ReadUserData WriteUserData NetworkServices Symbian capabilities
              to all QtWebkit executables.
      
              * QGVLauncher/QGVLauncher.pro:
              * QtLauncher/QtLauncher.pro:
              * tests/benchmarks/loading/tst_loading.pro:
              * tests/benchmarks/painting/tst_painting.pro:
              * tests/qgraphicswebview/qgraphicswebview.pro:
              * tests/qwebelement/qwebelement.pro:
              * tests/qwebframe/qwebframe.pro:
              * tests/qwebhistory/qwebhistory.pro:
              * tests/qwebhistoryinterface/qwebhistoryinterface.pro:
              * tests/qwebpage/qwebpage.pro:
              * tests/qwebplugindatabase/qwebplugindatabase.pro:
              * tests/qwebview/qwebview.pro:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5708acfe
  4. 23 Oct, 2009 13 commits
    • mitz@apple.com's avatar
      <rdar://problem/7294131> Assertion failure in AuthenticationMac at · 643c3a5d
      mitz@apple.com authored
      mac(const Credential&) after authenticating to MobileMe Gallery movie
      
      Reviewed by Alexey Proskuryakov.
      
      * platform/network/Credential.cpp:
      (WebCore::Credential::Credential): Initialize m_persistence.
      (WebCore::Credential::isEmpty): Made this method const.
      * platform/network/Credential.h:
      * platform/network/mac/AuthenticationMac.mm:
      (WebCore::mac): Return nil if the Credential is empty.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      643c3a5d
    • mrowe@apple.com's avatar
      Fix engineering builds in the mysterious future. · 00c63b14
      mrowe@apple.com authored
      * Configurations/DebugRelease.xcconfig:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00c63b14
    • bweinstein@apple.com's avatar
      Fixes <https://bugs.webkit.org/show_bug.cgi?id=30617>. · c6f66428
      bweinstein@apple.com authored
      Web Inspector: Resources Scope Bar Should Allow Combinations.
              
      Reviewed by Timothy Hatcher.
      
      Refactor the filtering in ResourcePanel to make it match ConsoleView,
      and add a divider between All, and the other choices of Resource types.
      
      * inspector/front-end/ResourcesPanel.js:
      (WebInspector.ResourcesPanel):
      (WebInspector.ResourcesPanel.prototype.filter):
      (WebInspector.ResourcesPanel.prototype._updateFilter):
      * inspector/front-end/inspector.css:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c6f66428
    • mrowe@apple.com's avatar
      Build fix. Include config.h before including other files. · 0ecb288f
      mrowe@apple.com authored
      * AccessibleImage.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ecb288f
    • eric@webkit.org's avatar
      2009-10-23 Chris Evans <cevans@chromium.org> · b984c386
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Added test for bug 27239 (ignore Refresh for view source mode).
              https://bugs.webkit.org/show_bug.cgi?id=27239
      
              * http/tests/security/view-source-no-refresh.html: Added
              * http/tests/security/view-source-no-refresh-expected.txt: Added
              * http/tests/security/resources/view-source-no-refresh.php: Added
      2009-10-23  Chris Evans  <cevans@chromium.org>
      
              Reviewed by Adam Barth.
      
              Ignore the Refresh header if we're in view source mode.
      
              https://bugs.webkit.org/show_bug.cgi?id=27239
      
              Test: http/tests/security/view-source-no-refresh.html
      
              * loader/FrameLoader.cpp: ignore Refresh in view-source mode.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b984c386
    • ap@apple.com's avatar
      Reviewed by Sam Weinig. · 986cf94b
      ap@apple.com authored
              https://bugs.webkit.org/show_bug.cgi?id=30734
              Remove XMLTokenizer::m_currentNodeIsReferenced
      
              No change in behavior, no tests.
      
              * dom/XMLTokenizer.cpp:
              (WebCore::XMLTokenizer::setCurrentNode):
              * dom/XMLTokenizer.h:
              Don't store a boolean for the current node being the document - we can always check for that.
      
              * dom/XMLTokenizerLibxml2.cpp:
              (WebCore::XMLTokenizer::XMLTokenizer):
              * dom/XMLTokenizerQt.cpp:
              (WebCore::XMLTokenizer::XMLTokenizer):
              A fragment passed to XMLTokenizer is never null - in fact, the first thing we do is dereference
              it unconditionally, and then begin checking it for null, as if it could help.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      986cf94b
    • bdakin@apple.com's avatar
      No review since this is a build fix. · 7cc75a42
      bdakin@apple.com authored
      Build fix for the Mac. (Build is only broken when SVG filters are 
      enabled.)
      
      Labelled these function static.
      * platform/graphics/filters/FEComponentTransfer.cpp:
      (WebCore::identity):
      (WebCore::table):
      (WebCore::discrete):
      (WebCore::linear):
      (WebCore::gamma):
      * platform/graphics/filters/FEGaussianBlur.cpp:
      (WebCore::boxBlur):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cc75a42
    • pfeldman@chromium.org's avatar
      2009-10-23 Pavel Feldman <pfeldman@chromium.org> · cca2832a
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Implement a Timeline panel.
      
              https://bugs.webkit.org/show_bug.cgi?id=30725
      
              * WebCore.gypi:
              * WebCore.vcproj/WebCore.vcproj:
              * inspector/front-end/Images/timelineIcon.png: Added.
              * inspector/front-end/TimelineAgent.js:
              (WebInspector.addItemToTimeline):
              (WebInspector.timelineProfilerWasStarted):
              (WebInspector.timelineProfilerWasStopped):
              * inspector/front-end/TimelinePanel.js: Added.
              (WebInspector.TimelinePanel):
              (WebInspector.TimelinePanel.prototype.toolbarItemClass.get toolbarItemLabel):
              (WebInspector.TimelinePanel.prototype.get statusBarItems):
              (WebInspector.TimelinePanel.prototype.handleKeyEvent):
              (WebInspector.TimelinePanel.prototype.timelineWasStarted):
              (WebInspector.TimelinePanel.prototype.timelineWasStopped):
              (WebInspector.TimelinePanel.prototype.addItemToTimeline):
              (WebInspector.TimelinePanel.prototype._innerAddItemToTimeline):
              (WebInspector.TimelinePanel.prototype._toggleTimelineButton):
              (WebInspector.TimelinePanel.prototype.setMainViewWidth):
              (WebInspector.TimelinePanel.prototype.getItemTypeName):
              (WebInspector.TimelineRecordTreeElement):
              (WebInspector.TimelineRecordTreeElement.prototype.onattach):
              * inspector/front-end/WebKit.qrc:
              * inspector/front-end/inspector.css:
              * inspector/front-end/inspector.html:
              * inspector/front-end/inspector.js:
              (WebInspector._createPanels):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cca2832a
    • joepeck@webkit.org's avatar
      2009-10-23 Joseph Pecoraro <joepeck@webkit.org> · 7dabc822
      joepeck@webkit.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Clash Between Search's onkeyup and incremental search events
              https://bugs.webkit.org/show_bug.cgi?id=30731
      
              * inspector/front-end/inspector.js:
              (WebInspector.performSearch): prevent incremental search event from clobbering a forced search
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7dabc822
    • pfeldman@chromium.org's avatar
      2009-10-23 Kelly Norton <knorton@google.com> · 8cc4af0e
      pfeldman@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Removes the need for C++ Timeline types in InspectorTimelineAgent in favor
              of ScriptObjects.
              https://bugs.webkit.org/show_bug.cgi?id=30707
      
              * GNUmakefile.am:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/DOMDispatchTimelineItem.cpp: Removed.
              * inspector/DOMDispatchTimelineItem.h: Removed.
              * inspector/InspectorTimelineAgent.cpp:
              (WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
              (WebCore::InspectorTimelineAgent::willDispatchDOMEvent):
              (WebCore::InspectorTimelineAgent::didDispatchDOMEvent):
              (WebCore::InspectorTimelineAgent::willLayout):
              (WebCore::InspectorTimelineAgent::didLayout):
              (WebCore::InspectorTimelineAgent::willRecalculateStyle):
              (WebCore::InspectorTimelineAgent::didRecalculateStyle):
              (WebCore::InspectorTimelineAgent::willPaint):
              (WebCore::InspectorTimelineAgent::didPaint):
              (WebCore::InspectorTimelineAgent::willWriteHTML):
              (WebCore::InspectorTimelineAgent::didWriteHTML):
              (WebCore::InspectorTimelineAgent::reset):
              (WebCore::InspectorTimelineAgent::didCompleteCurrentRecord):
              (WebCore::InspectorTimelineAgent::pushCurrentTimelineItem):
              * inspector/InspectorTimelineAgent.h:
              (WebCore::InspectorTimelineAgent::TimelineItemEntry::TimelineItemEntry):
              * inspector/TimelineItem.cpp: Removed.
              * inspector/TimelineItem.h: Removed.
              * inspector/TimelineItemFactory.cpp: Added.
              (WebCore::TimelineItemFactory::createGenericTimelineItem):
              (WebCore::TimelineItemFactory::createDOMDispatchTimelineItem):
              * inspector/TimelineItemFactory.h: Added.
              (WebCore::):
              (WebCore::TimelineItemFactory::TimelineItemFactory):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8cc4af0e
    • barraclough@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=30729 · 8616dbc0
      barraclough@apple.com authored
      Provide private API to request the global context for a specific world.
      Used to initialize parameters on the global object.
      
      Patch by Gavin Barraclough <barraclough@apple.com> on 2009-10-23
      Reviewed by Geoff Garen.
      
      WebCore: 
      
      * bindings/js/ScriptController.cpp:
      (WebCore::ScriptController::globalObject):
      * bindings/js/ScriptController.h:
      
      WebKit/mac: 
      
      * WebView/WebFramePrivate.h:
      * WebView/WebFrame.mm:
      (-[WebFrame contextForWorldID:]):
      
      WebKit/win: 
      
      * WebFrame.cpp:
      (WebFrame::contextForWorldID):
      * WebFrame.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8616dbc0
    • bweinstein@apple.com's avatar
      Pan-scrolling pointer shows up in other tabs or windows, can't "fix" it. · d27991a0
      bweinstein@apple.com authored
      <http://webkit.org/b/30732> and <rdar://7332018>.
              
      Reviewed by John Sullivan.
      
      Turns off pan-scrolling on a WebView when it is about to lose focus.
      
      * WebView.cpp:
      (WebViewWndProc):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d27991a0
    • eric@webkit.org's avatar
      2009-10-23 Steve Block <steveblock@google.com> · a2885d89
      eric@webkit.org authored
              Reviewed by Eric Seidel.
      
              Fixes style problems in Android-specific files.
              https://bugs.webkit.org/show_bug.cgi?id=30717
      
              Style changes only, no new tests possible.
      
              * page/android/EventHandlerAndroid.cpp: Modified.
              (WebCore::EventHandler::passMouseDownEventToWidget): Fixes whitespace in method signature.
              (WebCore::EventHandler::passSubframeEventToSubframe): Fixes whitespace in method signature.
              (WebCore::EventHandler::passWheelEventToWidget): Fixes whitespace in method signature.
              (WebCore::EventHandler::passMouseMoveEventToSubframe): Fixes whitespace in method signature.
              * platform/android/ClipboardAndroid.h: Modified. Fixes header include order and indenting.
              * platform/android/CursorAndroid.cpp: Modified.
              (WebCore::grabCursor): Fixes function braces.
              (WebCore::grabbingCursor): Fixes function braces.
              * platform/android/FileChooserAndroid.cpp: Modified.
              (WebCore::FileChooser::basenameForWidth): Fixes braces on while statement, and updates String::copy to String::threadsafeCopy.
              * platform/android/FileSystemAndroid.cpp: Modified. Fixes header include order.
              (WebCore::unloadModule): Fixes zero test.
              (WebCore::writeToFile): Fixes if statement structure.
              * platform/android/KeyEventAndroid.cpp: Modified.
              (WebCore::windowsKeyCodeForKeyEvent): Fixes switch statement indenting.
              (WebCore::keyIdentifierForAndroidKeyCode): Fixes switch statement indenting.
              * platform/android/ScreenAndroid.cpp: Modified. Fixes header include order and switch statement indenting.
              * platform/android/TemporaryLinkStubs.cpp: Modified. Fixes header include order.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@50006 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2885d89