1. 24 Jan, 2011 4 commits
    • alex@webkit.org's avatar
      2011-01-24 Alejandro G. Castro <alex@igalia.com> · b4516f6c
      alex@webkit.org authored
              Unreviewed, skipped tests failing the 64bits bot and passing in the
              32bits bots. Bug following the issue:
              https://bugs.webkit.org/show_bug.cgi?id=52996
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4516f6c
    • yuzo@google.com's avatar
      2011-01-23 Yuzo Fujishima <yuzo@google.com> · 79c15983
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
      
              Update Chromim test expectations (LINUX/SVG) in response to r76442.
      
              * platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
              * platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79c15983
    • yuzo@google.com's avatar
      2011-01-23 Yuzo Fujishima <yuzo@google.com> · d468af44
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
      
              Update Chromim test expectations (WIN/SVG) in response to r76442.
      
              * platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
              * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
              * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
              * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
              * platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
              * platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
              * platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
              * platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
              * platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
              * platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
              * platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
              * platform/chromium-win/svg/text/text-text-04-t-expected.png:
              * platform/chromium-win/svg/text/text-text-04-t-expected.txt:
              * platform/chromium-win/svg/text/text-vkern-expected.checksum:
              * platform/chromium-win/svg/text/text-vkern-expected.png:
              * platform/chromium-win/svg/text/text-vkern-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d468af44
    • caseq@chromium.org's avatar
      2011-01-23 Andrey Kosyakov <caseq@chromium.org> · eab0e536
      caseq@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: summary bar is not resized properly with the rest of net
              https://bugs.webkit.org/show_bug.cgi?id=52881
      
              * inspector/front-end/NetworkPanel.js:
              (WebInspector.NetworkPanel.prototype.updateSidebarWidth):
              (WebInspector.NetworkPanel.prototype._positionSummaryBar):
              (WebInspector.NetworkPanel.prototype._toggleGridMode):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eab0e536
  2. 23 Jan, 2011 23 commits
    • morrita@google.com's avatar
      2011-01-19 MORITA Hajime <morrita@google.com> · 6a3e425f
      morrita@google.com authored
              Reviewed by Ryosuke Niwa.
      
              Space and tab characters "sent" by an input method give totally different results than typing them directly.
              https://bugs.webkit.org/show_bug.cgi?id=5241
      
              Added a test that exercises continous whitespace characters and tabs inserted by IME.
      
              * editing/inserting/insert-composition-whitespace-expected.txt: Added.
              * editing/inserting/insert-composition-whitespace.html: Added.
      2011-01-19  MORITA Hajime  <morrita@google.com>
      
              Reviewed by Ryosuke Niwa.
      
              Space and tab characters "sent" by an input method give totally different results than typing them directly
              https://bugs.webkit.org/show_bug.cgi?id=5241
      
              * Introduced TextEvent::InputTypeComposition and TypingCommand::TextCompositionType to
                distinguish text input which is originated by composition.
              * Generalized rebalanceWhitespaceAt() to rebalanceWhitespaceOnTextSubstring() to rebalancing
                range of string on text node, instead of surrounding part of that.
      
              Test: editing/inserting/insert-composition-whitespace.html
      
              * dom/TextEvent.h:
              (WebCore::TextEvent::isComposition):
              * dom/TextEventInputType.h: Added TextEventInputComposition as a member of TextEvent::InputType
              * editing/CompositeEditCommand.cpp:
              (WebCore::containsOnlyWhitespace):
              (WebCore::CompositeEditCommand::shouldRebalanceLeadingWhitespaceFor):
              (WebCore::CompositeEditCommand::canRebalance):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceAt):
              (WebCore::CompositeEditCommand::rebalanceWhitespaceOnTextSubstring): Added: A generalized version of rebalanceWhitespaceAt(), which takes a range inside Text string.
              * editing/CompositeEditCommand.h:
              * editing/Editor.cpp:
              (WebCore::Editor::insertTextForConfirmedComposition): Added.
              (WebCore::Editor::insertTextWithoutSendingTextEvent):
              (WebCore::Editor::confirmComposition): Now uses insertTextForConfirmedComposition().
              (WebCore::Editor::setComposition):
              * editing/Editor.h:
              * editing/InsertTextCommand.cpp:
              (WebCore::InsertTextCommand::input):
              * editing/InsertTextCommand.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::TypingCommand):
              (WebCore::TypingCommand::insertText):
              (WebCore::TypingCommand::insertTextRunWithoutNewlines):
              * editing/TypingCommand.h: Added TypingCommand::m_compositionType and TypingCommand::TextCompositionType
              (WebCore::TypingCommand::setCompositionType): Added.
              (WebCore::TypingCommand::create):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6a3e425f
    • yuzo@google.com's avatar
      2011-01-23 Yuzo Fujishima <yuzo@google.com> · adaa23e1
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
              Update Chromim test expectations (WIN) in response to r76442.
      
              * platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
              * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
              * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
              * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
              * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
              * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
              * platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
              * platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
              * platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
              * platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
              * platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
              * platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
              * platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
              * platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
              * platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
              * platform/chromium-win/svg/text/text-hkern-expected.txt: Added.
              * platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      adaa23e1
    • yuzo@google.com's avatar
      2011-01-23 Yuzo Fujishima <yuzo@google.com> · c645f1da
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
              Mark fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html as TEXT for LINUX.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c645f1da
    • mrowe@apple.com's avatar
      Follow-up to r76477. · 5e136a24
      mrowe@apple.com authored
      Fix the scripts that detect problematic code such as static initializers
      and destructors, weak vtables, inappropriate files in the framework wrappers,
      and public headers including private headers. These had all been broken
      since the projects were moved in to the Source directory as the paths to the
      scripts were not updated at that time.
      
      Source/JavaScriptCore:
      
      * JavaScriptCore.xcodeproj/project.pbxproj:
      
      Source/JavaScriptGlue:
      
      * JavaScriptGlue.xcodeproj/project.pbxproj:
      
      Source/WebCore:
      
      Stop copying an IDL file in to the framework wrapper. Doing that doesn't even make sense.
      
      * WebCore.xcodeproj/project.pbxproj:
      
      Source/WebKit:
      
      * WebKit.xcodeproj/project.pbxproj:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e136a24
    • mrowe@apple.com's avatar
      Build fix after r76459. · bc7f1116
      mrowe@apple.com authored
      Static member variables or globals of types that have constructors or destructors are bad as
      they generate static initializers and destructors. This is code that is run either at link time
      when the library is loaded in to memory or at application termination time. Both of these are
      terrible for performance and are thus outlawed in WebKit code.
      
      The typical solution is to replace the static member or global with a function that allocates
      the necessary variable on the heap. The variable is leaked to prevent it from being destroyed
      at application termination time. The DEFINE_STATIC_LOCAL macro wraps this in to a concise little
      package, but sadly fails to work in this case due to the type containing multiple template
      parameters.
      
      * inspector/InspectorInstrumentation.cpp:
      (WebCore::InspectorInstrumentation::inspectorAgents):
      * inspector/InspectorInstrumentation.h:
      (WebCore::InspectorInstrumentation::bindInspectorAgent):
      (WebCore::InspectorInstrumentation::unbindInspectorAgent):
      (WebCore::InspectorInstrumentation::inspectorAgentForPage):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc7f1116
    • yuzo@google.com's avatar
      2011-01-23 Yuzo Fujishima <yuzo@google.com> · 82393543
      yuzo@google.com authored
              Unreviewed Chromium test expectation change.
              Update Chromim test expectations in response to r76442.
      
              * platform/chromium-linux/fast/css/acid2-expected.txt: Added.
              * platform/chromium-linux/fast/css/acid2-pixel-expected.checksum:
              * platform/chromium-linux/fast/css/acid2-pixel-expected.png:
              * platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Added.
              * platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
              * platform/chromium-linux/fast/forms/button-sizes-expected.png:
              * platform/chromium-linux/fast/forms/button-sizes-expected.txt:
              * platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
              * platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
              * platform/chromium-linux/fast/forms/input-button-sizes-expected.txt:
              * platform/chromium-linux/http/tests/misc/acid2-expected.txt: Added.
              * platform/chromium-linux/http/tests/misc/acid2-pixel-expected.checksum:
              * platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
              * platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Added.
              * platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Removed.
              * platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
              * platform/chromium-linux/svg/hixie/perf/003-expected.txt: Removed.
              * platform/chromium-linux/svg/hixie/perf/004-expected.txt: Removed.
              * platform/chromium-linux/svg/hixie/perf/005-expected.txt: Removed.
              * platform/chromium-linux/svg/hixie/perf/006-expected.txt: Removed.
              * platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
              * platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
              * platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
              * platform/chromium-linux/svg/text/text-text-01-b-expected.png:
              * platform/chromium-linux/svg/text/text-text-01-b-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      82393543
    • vangelis@chromium.org's avatar
      2011-01-21 Vangelis Kokkevis <vangelis@chromium.org> · 67b4e5b9
      vangelis@chromium.org authored
              Reviewed by Kenneth Russell.
      
              [chromium] Add support for -webkit-mask properties to the
              accelerated compositing path.
              https://bugs.webkit.org/show_bug.cgi?id=49780
               
              Tests: Existing tests in LayoutTests/compositing/masks
      
              * platform/graphics/chromium/ContentLayerChromium.cpp:
              (WebCore::ContentLayerChromium::draw):
              (WebCore::ContentLayerChromium::unreserveContentsTexture):
              (WebCore::ContentLayerChromium::bindContentsTexture):
              * platform/graphics/chromium/ContentLayerChromium.h:
              * platform/graphics/chromium/GraphicsLayerChromium.cpp:
              (WebCore::GraphicsLayerChromium::setMaskLayer):
              * platform/graphics/chromium/GraphicsLayerChromium.h:
              * platform/graphics/chromium/LayerChromium.cpp:
              (WebCore::LayerChromium::LayerChromium):
              * platform/graphics/chromium/LayerChromium.h:
              (WebCore::LayerChromium::setMaskLayer):
              (WebCore::LayerChromium::maskLayer):
              (WebCore::LayerChromium::unreserveContentsTexture):
              (WebCore::LayerChromium::bindContentsTexture):
              * platform/graphics/chromium/LayerRendererChromium.cpp:
              (WebCore::LayerRendererChromium::updateLayersRecursive):
              * platform/graphics/chromium/LayerTexture.cpp:
              (WebCore::LayerTexture::bindTexture):
              * platform/graphics/chromium/RenderSurfaceChromium.cpp:
              (WebCore::RenderSurfaceChromium::SharedValues::SharedValues):
              (WebCore::RenderSurfaceChromium::SharedValues::~SharedValues):
              (WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
              (WebCore::RenderSurfaceChromium::draw):
              * platform/graphics/chromium/RenderSurfaceChromium.h:
              (WebCore::RenderSurfaceChromium::SharedValues::maskShaderProgram):
              (WebCore::RenderSurfaceChromium::SharedValues::maskShaderSamplerLocation):
              (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMaskSamplerLocation):
              (WebCore::RenderSurfaceChromium::SharedValues::maskShaderMatrixLocation):
              (WebCore::RenderSurfaceChromium::SharedValues::maskShaderAlphaLocation):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      67b4e5b9
    • paroga@webkit.org's avatar
      2011-01-23 Patrick Gansterer <paroga@webkit.org> · 52569f77
      paroga@webkit.org authored
              Reviewed by Darin Adler.
      
              Use WTF::StringHasher in WebCore
              https://bugs.webkit.org/show_bug.cgi?id=52934
      
              Add an additional function to calculate the hash
              of data with a runtimedependent size.
      
              * wtf/StringHasher.h:
              (WTF::StringHasher::createBlobHash):
      2011-01-23  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by Darin Adler.
      
              Use WTF::StringHasher in WebCore
              https://bugs.webkit.org/show_bug.cgi?id=52934
      
              * loader/appcache/ApplicationCacheStorage.cpp:
              (WebCore::urlHostHash):
              * platform/LinkHash.cpp:
              (WebCore::visitedLinkHashInline):
              * platform/cf/BinaryPropertyList.cpp:
              (WebCore::IntegerArrayHash::hash):
              * platform/graphics/wx/FontPlatformDataWx.cpp:
              (WebCore::FontPlatformData::computeHash):
              * platform/network/ProtectionSpaceHash.h:
              (WebCore::ProtectionSpaceHash::hash):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      52569f77
    • kdecker@apple.com's avatar
      2011-01-23 Damian Kaleta <dkaleta@apple.com> · bc7cfb69
      kdecker@apple.com authored
              Reviewed by Kevin Decker.
      
              <rdar://problem/8905171>
              https://bugs.webkit.org/show_bug.cgi?id=52985 
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::scaleWebView): Eliminated early return inside WebPageProxy::scaleWebView, making it 
              consistent with WebKit1.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bc7cfb69
    • paroga@webkit.org's avatar
      2011-01-23 Patrick Gansterer <paroga@webkit.org> · 75d8ffb2
      paroga@webkit.org authored
              Reviewed by David Kilzer.
      
              Add an overload to base64Encode with String output
              https://bugs.webkit.org/show_bug.cgi?id=50122
      
              This change removes duplicated code.
      
              * inspector/InspectorResourceAgent.cpp:
              (WebCore::InspectorResourceAgent::resourceContentBase64):
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::btoa):
              * platform/graphics/skia/FontCustomPlatformData.cpp:
              (WebCore::createUniqueFontName):
              * platform/graphics/win/FontCustomPlatformData.cpp:
              (WebCore::createUniqueFontName):
              * platform/graphics/wince/FontCustomPlatformData.cpp:
              (WebCore::createUniqueFontName):
              * platform/network/cf/ResourceHandleCFNet.cpp:
              (WebCore::encodeBasicAuthorization):
              * platform/network/mac/ResourceHandleMac.mm:
              (WebCore::encodeBasicAuthorization):
              * platform/text/Base64.cpp:
              (WebCore::base64Encode):
              * platform/text/Base64.h:
              (WebCore::base64Encode):
              * platform/wince/KeygenWinCE.cpp:
              (WebCore::WebCore::signedPublicKeyAndChallengeString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      75d8ffb2
    • paroga@webkit.org's avatar
      2011-01-23 Patrick Gansterer <paroga@webkit.org> · 58e54645
      paroga@webkit.org authored
              Reviewed by David Kilzer.
      
              Fix comment in String::ascii()
              https://bugs.webkit.org/show_bug.cgi?id=52980
      
              * wtf/text/WTFString.cpp:
              (WTF::String::ascii):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58e54645
    • ap@apple.com's avatar
      2011-01-23 Alexey Proskuryakov <ap@apple.com> · d08b07e4
      ap@apple.com authored
              Reviewed by Dan Bernstein.
      
              https://bugs.webkit.org/show_bug.cgi?id=52968
              Use a separate NSView for printing
      
              Also addresses <rdar://problem/8900148> Improper check for
              -[NSGraphicsContext currentContextDrawingToScreen]
      
              * UIProcess/API/mac/WKPrintingView.h: Added.
              * UIProcess/API/mac/WKPrintingView.mm: Added.
              (-[WKPrintingView initWithFrameProxy:]):
              (-[WKPrintingView isFlipped]):
              (-[WKPrintingView _adjustPrintingMarginsForHeaderAndFooter]):
              (-[WKPrintingView knowsPageRange:]):
              (-[WKPrintingView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
              (-[WKPrintingView drawPageBorderWithSize:]):
              (-[WKPrintingView _provideTotalScaleFactorForPrintOperation:]):
              (-[WKPrintingView rectForPage:]):
              * UIProcess/API/mac/WKView.mm:
              (-[WKView drawRect:]):
              (-[WKView canChangeFrameLayout:]):
              (-[WKView printOperationWithPrintInfo:forFrame:]):
              * WebKit2.xcodeproj/project.pbxproj:
              Moved printing code to a separate view, simplifying as appropriate. The view is currently not
              referenced by anything in WebKit2 directly, being owned by NSPrintOperation.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d08b07e4
    • paroga@webkit.org's avatar
      2011-01-23 Patrick Gansterer <paroga@webkit.org> · f7f715a2
      paroga@webkit.org authored
              Reviewed by David Kilzer.
      
              Add String::containsOnlyLatin1()
              https://bugs.webkit.org/show_bug.cgi?id=52979
      
              * wtf/text/WTFString.h:
              (WTF::String::containsOnlyLatin1):
              (WTF::charactersAreAllLatin1):
      2011-01-23  Patrick Gansterer  <paroga@webkit.org>
      
              Reviewed by David Kilzer.
      
              Add String::containsOnlyLatin1()
              https://bugs.webkit.org/show_bug.cgi?id=52979
      
              Use String::containsOnlyLatin1() instead of isSafeToConvertCharList().
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::btoa):
              (WebCore::DOMWindow::atob):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7f715a2
    • ap@apple.com's avatar
      2011-01-23 Alexey Proskuryakov <ap@apple.com> · 71538558
      ap@apple.com authored
              Reviewed by Eric Seidel.
      
              https://bugs.webkit.org/show_bug.cgi?id=15649
              Empty STYLE elements are not reflected into the document.styleSheets object
      
              Adding a test for a bug that no longer occurs.
      
              * fast/dom/document-stylesheets-empty-style-expected.txt: Added.
              * fast/dom/document-stylesheets-empty-style.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71538558
    • paroga@webkit.org's avatar
      2011-01-23 Patrick Gansterer <paroga@webkit.org> · 9f1ac134
      paroga@webkit.org authored
              Reviewed by Andreas Kling.
      
              [CMake] Add missing CodeGenerator dependencies
              https://bugs.webkit.org/show_bug.cgi?id=52976
      
              * CMakeLists.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f1ac134
    • yael.aharon@nokia.com's avatar
      2011-01-23 Yael Aharon <yael.aharon@nokia.com> · 1dba3a94
      yael.aharon@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt][Symbian] Fix --minimal build
              https://bugs.webkit.org/show_bug.cgi?id=52839
      
              Some of the plugins' functionality is reimplemented in
              Symbian specific files.
              Some of this functionality should be compiled in even if
              the guard NETSCAPE_PLUGIN_API is turned off.
              This patch moves that functionality out of the
              NETSCAPE_PLUGIN_API guard.
      
              Build fix so no new tests.
      
              * WebCore.pro:
              * plugins/symbian/PluginPackageSymbian.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1dba3a94
    • paroga@webkit.org's avatar
      2011-01-23 Patrick Gansterer <paroga@webkit.org> · 1fd60541
      paroga@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Remove obsolete JSVALUE32 code
              https://bugs.webkit.org/show_bug.cgi?id=52948
      
              r70111 removed support for JSVALUE32.
              ARM, MIPS and X86 support JSVALUE32_64 only.
      
              * jit/JITStubs.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1fd60541
    • mitz@apple.com's avatar
      <rdar://problem/6097826> Mail's cursor does not become a resize cursor when... · 5e32c9c5
      mitz@apple.com authored
      <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
      
      Reviewed by John Sullivan.
      
      * WebCoreSupport/WebChromeClient.mm:
      (WebChromeClient::setCursor): If the current cursor comes from a cursor rect, do not override it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e32c9c5
    • andreas.kling@nokia.com's avatar
      2011-01-23 Andreas Kling <kling@webkit.org> · 54a0191b
      andreas.kling@nokia.com authored
              Reviewed by Tor Arne Vestbø.
      
              [Qt] Use rad2deg() from WTF instead of rolling our own.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::rotate):
              * platform/graphics/qt/PathQt.cpp:
              (WebCore::Path::addArc):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76463 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      54a0191b
    • andreas.kling@nokia.com's avatar
      2011-01-23 Kenneth Rohde Christiansen <kenneth@webkit.org> · 9c45d175
      andreas.kling@nokia.com authored
              Reviewed by Andreas Kling.
      
              Viewport meta: Always adjust device dimensions to the device pixel ratio.
      
              * dom/ViewportArguments.cpp:
              (WebCore::computeViewportAttributes):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c45d175
    • andreas.kling@nokia.com's avatar
      2011-01-23 Andreas Kling <kling@webkit.org> · 2191bafc
      andreas.kling@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Don't scale absolute geometry specified by viewport meta tag.
      
              * dom/ViewportArguments.cpp:
              (WebCore::computeViewportAttributes):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2191bafc
    • loislo@chromium.org's avatar
      2011-01-23 Ilya Tikhonovsky <loislo@chromium.org> · e7676e73
      loislo@chromium.org authored
              Unreviewed build fix.
      
              Web Inspector: looks like efl doesn't regenerate InspectorBackendDispatcher.
      
              Touch Inspector.idl.
      
              * inspector/Inspector.idl:
      
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7676e73
    • pfeldman@chromium.org's avatar
      2011-01-22 Ilya Tikhonovsky <loislo@chromium.org> · f73e2772
      pfeldman@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: next step in splitting InspectorController.
      
              Splitting InspectorController is a bit tricky process.
      
              As a first step I'll do the next things:
              1) rename existing InspectorController to InspectorAgent;
              2) s/nspectorController/nspectorAgent/g everywhere in WebCore/inspector but InspectorInstrumentation;
              3) create a fake InspectorController derived from the InspectorAgent for the rest of WebCore and WebKit;
      
              The second step is a migration of a small set of functions described in bug 52510 from InspectorAgent to InspectorController.
      
              As far as the second step will have significant changes in the functions' implementation I'll do it as a separate patch.
      
              https://bugs.webkit.org/show_bug.cgi?id=52955
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.exp.in:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/JSInjectedScriptHostCustom.cpp:
              (WebCore::JSInjectedScriptHost::nodeForId):
              (WebCore::JSInjectedScriptHost::selectDOMStorage):
              * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
              (WebCore::V8InjectedScriptHost::nodeForIdCallback):
              * inspector/CodeGeneratorInspector.pm:
              * inspector/InjectedScriptHost.cpp:
              (WebCore::InjectedScriptHost::InjectedScriptHost):
              (WebCore::InjectedScriptHost::clearConsoleMessages):
              (WebCore::InjectedScriptHost::databaseForId):
              (WebCore::InjectedScriptHost::selectDatabase):
              (WebCore::InjectedScriptHost::selectDOMStorage):
              (WebCore::InjectedScriptHost::injectedScriptForMainFrame):
              (WebCore::InjectedScriptHost::inspectorDOMAgent):
              (WebCore::InjectedScriptHost::frontend):
              (WebCore::InjectedScriptHost::didCreateWorker):
              (WebCore::InjectedScriptHost::didDestroyWorker):
              * inspector/InjectedScriptHost.h:
              (WebCore::InjectedScriptHost::create):
              (WebCore::InjectedScriptHost::inspectorAgent):
              (WebCore::InjectedScriptHost::disconnectController):
              * inspector/InspectorAgent.cpp: Copied from Source/WebCore/inspector/InspectorController.cpp.
              (WebCore::InspectorAgent::InspectorAgent):
              (WebCore::InspectorAgent::~InspectorAgent):
              (WebCore::InspectorAgent::inspectedPageDestroyed):
              (WebCore::InspectorAgent::enabled):
              (WebCore::InspectorAgent::inspectorStartsAttached):
              (WebCore::InspectorAgent::setInspectorStartsAttached):
              (WebCore::InspectorAgent::setInspectorAttachedHeight):
              (WebCore::InspectorAgent::inspectorAttachedHeight):
              (WebCore::InspectorAgent::searchingForNodeInPage):
              (WebCore::InspectorAgent::restoreInspectorStateFromCookie):
              (WebCore::InspectorAgent::inspect):
              (WebCore::InspectorAgent::focusNode):
              (WebCore::InspectorAgent::highlight):
              (WebCore::InspectorAgent::highlightDOMNode):
              (WebCore::InspectorAgent::highlightFrame):
              (WebCore::InspectorAgent::hideHighlight):
              (WebCore::InspectorAgent::mouseDidMoveOverElement):
              (WebCore::InspectorAgent::handleMousePress):
              (WebCore::InspectorAgent::setInspectorFrontendClient):
              (WebCore::InspectorAgent::didClearWindowObjectInWorld):
              (WebCore::InspectorAgent::setSearchingForNode):
              (WebCore::InspectorAgent::connectFrontend):
              (WebCore::InspectorAgent::show):
              (WebCore::InspectorAgent::showPanel):
              (WebCore::InspectorAgent::close):
              (WebCore::InspectorAgent::disconnectFrontend):
              (WebCore::InspectorAgent::resourceAgent):
              (WebCore::InspectorAgent::releaseFrontendLifetimeAgents):
              (WebCore::InspectorAgent::populateScriptObjects):
              (WebCore::InspectorAgent::pushDataCollectedOffline):
              (WebCore::InspectorAgent::restoreDebugger):
              (WebCore::InspectorAgent::restoreProfiler):
              (WebCore::InspectorAgent::unbindAllResources):
              (WebCore::InspectorAgent::didCommitLoad):
              (WebCore::InspectorAgent::mainResourceFiredDOMContentEvent):
              (WebCore::InspectorAgent::mainResourceFiredLoadEvent):
              (WebCore::InspectorAgent::isMainResourceLoader):
              (WebCore::InspectorAgent::willSendRequest):
              (WebCore::InspectorAgent::ensureSettingsLoaded):
              (WebCore::InspectorAgent::startTimelineProfiler):
              (WebCore::InspectorAgent::stopTimelineProfiler):
              (WebCore::PostWorkerNotificationToFrontendTask::create):
              (WebCore::PostWorkerNotificationToFrontendTask::PostWorkerNotificationToFrontendTask):
              (WebCore::PostWorkerNotificationToFrontendTask::performTask):
              (WebCore::InspectorAgent::postWorkerNotificationToFrontend):
              (WebCore::InspectorAgent::didCreateWorker):
              (WebCore::InspectorAgent::didDestroyWorker):
              (WebCore::InspectorAgent::didOpenDatabase):
              (WebCore::InspectorAgent::getCookies):
              (WebCore::InspectorAgent::buildArrayForCookies):
              (WebCore::InspectorAgent::buildObjectForCookie):
              (WebCore::InspectorAgent::deleteCookie):
              (WebCore::InspectorAgent::didUseDOMStorage):
              (WebCore::InspectorAgent::didCreateWebSocket):
              (WebCore::InspectorAgent::willSendWebSocketHandshakeRequest):
              (WebCore::InspectorAgent::didReceiveWebSocketHandshakeResponse):
              (WebCore::InspectorAgent::didCloseWebSocket):
              (WebCore::InspectorAgent::isRecordingUserInitiatedProfile):
              (WebCore::InspectorAgent::startUserInitiatedProfiling):
              (WebCore::InspectorAgent::stopUserInitiatedProfiling):
              (WebCore::InspectorAgent::profilerEnabled):
              (WebCore::InspectorAgent::enableProfiler):
              (WebCore::InspectorAgent::disableProfiler):
              (WebCore::InspectorAgent::showAndEnableDebugger):
              (WebCore::InspectorAgent::enableDebugger):
              (WebCore::InspectorAgent::disableDebugger):
              (WebCore::InspectorAgent::resume):
              (WebCore::InspectorAgent::setAllBrowserBreakpoints):
              (WebCore::InspectorAgent::evaluateForTestInFrontend):
              (WebCore::InspectorAgent::didEvaluateForTestInFrontend):
              (WebCore::quadToPath):
              (WebCore::drawOutlinedQuad):
              (WebCore::drawOutlinedQuadWithClip):
              (WebCore::drawHighlightForBox):
              (WebCore::drawHighlightForLineBoxesOrSVGRenderer):
              (WebCore::convertFromFrameToMainFrame):
              (WebCore::frameToMainFrameOffset):
              (WebCore::InspectorAgent::drawNodeHighlight):
              (WebCore::InspectorAgent::drawElementTitle):
              (WebCore::InspectorAgent::openInInspectedWindow):
              (WebCore::InspectorAgent::addScriptToEvaluateOnLoad):
              (WebCore::InspectorAgent::removeAllScriptsToEvaluateOnLoad):
              (WebCore::InspectorAgent::setInspectorExtensionAPI):
              (WebCore::InspectorAgent::inspectedURL):
              (WebCore::InspectorAgent::reloadPage):
              (WebCore::InspectorAgent::setExtraHeaders):
              * inspector/InspectorAgent.h: Copied from Source/WebCore/inspector/InspectorController.h.
              (WebCore::InspectorAgent::inspectorBackendDispatcher):
              (WebCore::InspectorAgent::inspectorClient):
              (WebCore::InspectorAgent::injectedScriptHost):
              (WebCore::InspectorAgent::inspectedPage):
              (WebCore::InspectorAgent::hideDOMNodeHighlight):
              (WebCore::InspectorAgent::hideFrameHighlight):
              (WebCore::InspectorAgent::frontend):
              (WebCore::InspectorAgent::inspectorController):
              (WebCore::InspectorAgent::inspectorAgent):
              (WebCore::InspectorAgent::consoleAgent):
              (WebCore::InspectorAgent::cssAgent):
              (WebCore::InspectorAgent::domAgent):
              (WebCore::InspectorAgent::injectedScriptAgent):
              (WebCore::InspectorAgent::runtimeAgent):
              (WebCore::InspectorAgent::timelineAgent):
              (WebCore::InspectorAgent::databaseAgent):
              (WebCore::InspectorAgent::domStorageAgent):
              (WebCore::InspectorAgent::fileSystemAgent):
              (WebCore::InspectorAgent::browserDebuggerAgent):
              (WebCore::InspectorAgent::debuggerAgent):
              (WebCore::InspectorAgent::profilerAgent):
              (WebCore::InspectorAgent::applicationCacheAgent):
              (WebCore::InspectorAgent::hasInspectorFrontendClient):
              (WebCore::InspectorAgent::hasFrontend):
              (WebCore::InspectorAgent::startProfiling):
              (WebCore::InspectorAgent::stopProfiling):
              (WebCore::InspectorAgent::debuggerEnabled):
              (WebCore::InspectorAgent::state):
              (WebCore::InspectorAgent::settings):
              * inspector/InspectorApplicationCacheAgent.cpp:
              (WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):
              (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
              * inspector/InspectorApplicationCacheAgent.h:
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              (WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
              (WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
              (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
              (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
              (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
              (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
              (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
              (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
              * inspector/InspectorBrowserDebuggerAgent.h:
              (WebCore::InspectorBrowserDebuggerAgent::create):
              * inspector/InspectorConsoleAgent.cpp:
              (WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
              (WebCore::InspectorConsoleAgent::clearConsoleMessages):
              (WebCore::InspectorConsoleAgent::addMessageToConsole):
              (WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
              (WebCore::InspectorConsoleAgent::didReceiveResponse):
              (WebCore::InspectorConsoleAgent::didFailLoading):
              (WebCore::InspectorConsoleAgent::setMonitoringXHREnabled):
              (WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
              (WebCore::InspectorConsoleAgent::addConsoleMessage):
              * inspector/InspectorConsoleAgent.h:
              * inspector/InspectorController.cpp:
              (WebCore::InspectorController::InspectorController):
              * inspector/InspectorController.h:
              * inspector/InspectorDatabaseAgent.cpp:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::create):
              (WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
              (WebCore::InspectorDebuggerAgent::~InspectorDebuggerAgent):
              (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
              (WebCore::InspectorDebuggerAgent::getCompletionsOnCallFrame):
              (WebCore::InspectorDebuggerAgent::currentCallFrames):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/InspectorFileSystemAgent.cpp:
              (WebCore::InspectorFileSystemAgentCallbacks::didOpenFileSystem):
              (WebCore::InspectorFileSystemAgent::InspectorFileSystemAgent):
              (WebCore::InspectorFileSystemAgent::stop):
              (WebCore::InspectorFileSystemAgent::getFileSystemPathAsync):
              (WebCore::InspectorFileSystemAgent::didGetFileSystemPath):
              (WebCore::InspectorFileSystemAgent::didGetFileSystemError):
              * inspector/InspectorFileSystemAgent.h:
              (WebCore::InspectorFileSystemAgent::create):
              * inspector/InspectorFrontendHost.cpp:
              (WebCore::InspectorFrontendHost::setExtensionAPI):
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::create):
              (WebCore::InspectorProfilerAgent::InspectorProfilerAgent):
              (WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
              (WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
              (WebCore::InspectorProfilerAgent::startUserInitiatedProfiling):
              (WebCore::InspectorProfilerAgent::stopUserInitiatedProfiling):
              * inspector/InspectorProfilerAgent.h:
      2011-01-22  Ilya Tikhonovsky  <loislo@chromium.org>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: next step in splitting InspectorController.
      
              #include "InspectorController.h" was added.
      
              https://bugs.webkit.org/show_bug.cgi?id=52955
      
              * WebCoreSupport/InspectorServerQt.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f73e2772
  3. 22 Jan, 2011 13 commits
    • mjs@apple.com's avatar
      2011-01-22 Maciej Stachowiak <mjs@apple.com> · 8b55d51e
      mjs@apple.com authored
              Reviewed by Oliver Hunt.
      
              Skip a test that seems to cause the subsequent test to sporadically fail, and unskip the several tests after it
              https://bugs.webkit.org/show_bug.cgi?id=52970
      
              * platform/mac-wk2/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8b55d51e
    • ggaren@apple.com's avatar
      2011-01-22 Geoffrey Garen <ggaren@apple.com> · 7fc55f20
      ggaren@apple.com authored
              Reviewed by Dan Bernstein.
      
              ASSERT running run-webkit-tests --threaded.
              https://bugs.webkit.org/show_bug.cgi?id=52971
              
              SunSpider and v8 report no change.
      
              * runtime/ConservativeSet.cpp:
              (JSC::ConservativeSet::grow):
              (JSC::ConservativeSet::add):
              * runtime/ConservativeSet.h: Tweaked the inline capacity to 128, and
              the growth policy to 2X, to make SunSpider and v8 happy.
              (JSC::ConservativeSet::ConservativeSet):
              (JSC::ConservativeSet::~ConservativeSet):
              (JSC::ConservativeSet::mark): Use OSAllocator directly, instead of malloc.
              Malloc is forbidden during a multi-threaded mark phase because it can
              cause deadlock.
      2011-01-22  Geoffrey Garen  <ggaren@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Beefed up --threaded mode to catch even more kinds of errors.
              https://bugs.webkit.org/show_bug.cgi?id=52971
      
              * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
              context group to force JSC to mark multiple threads. (This used to be
              the default, but it changed in SnowLeopard.)
              (runJavaScriptThread): Do more locking and unlocking, and more allocation,
              to give threading mistakes more chances to show themselves.
              (startJavaScriptThreads):
              (stopJavaScriptThreads):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7fc55f20
    • dbates@webkit.org's avatar
      2011-01-22 Chris Rogers <crogers@google.com> · e48103dd
      dbates@webkit.org authored
              Rubber-stamped by Anders Carlsson.
      
              Fix FFTFrameStub to compile properly
              https://bugs.webkit.org/show_bug.cgi?id=52969
      
              No new tests since this is a build fix.
      
              * platform/audio/FFTFrameStub.cpp:
              (WebCore::FFTFrame::FFTFrame):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e48103dd
    • jam@chromium.org's avatar
      2011-01-22 John Abd-El-Malek <jam@chromium.org> · e0a200f5
      jam@chromium.org authored
              Reviewed by Adam Barth.
      
              [chromium]: Fix WebScrollbarImpl not getting scroll events after recent scrollbar refactoring
              https://bugs.webkit.org/show_bug.cgi?id=52967
      
              * src/WebScrollbarImpl.cpp:
              (WebKit::WebScrollbarImpl::horizontalScrollbar):
              (WebKit::WebScrollbarImpl::verticalScrollbar):
              * src/WebScrollbarImpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0a200f5
    • ggaren@apple.com's avatar
      2011-01-22 Geoffrey Garen <ggaren@apple.com> · c9bfff41
      ggaren@apple.com authored
              Reviewed by Geoffrey Garen.
      
              Rubber-stamped by Maciej Stachowiak.
      
              A few of Maciej's review suggestions for my last patch.
              https://bugs.webkit.org/show_bug.cgi?id=52946        
      
              SunSpider reports no change.
      
              * Android.mk:
              * CMakeLists.txt:
              * GNUmakefile.am:
              * JavaScriptCore.gypi:
              * JavaScriptCore.pro:
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * JavaScriptCore.xcodeproj/project.pbxproj: Updated build systems.
      
              * runtime/ConservativeSet.cpp: Added.
              (JSC::isPointerAligned):
              (JSC::ConservativeSet::add):
              * runtime/ConservativeSet.h: Added.
              (JSC::ConservativeSet::ConservativeSet):
              (JSC::ConservativeSet::mark): Split ConservativeSet out into its own
              file, and moved the conservative check into ConservativeSet::add, making
              ConservativeSet's responsibility clearer.
      
              * runtime/Heap.cpp:
              (JSC::Heap::markRoots):
              * runtime/MachineStackMarker.cpp:
              (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
              (JSC::MachineStackMarker::markOtherThreadConservatively):
              * runtime/MachineStackMarker.h:
              * runtime/MarkStack.h: Updated for changes above.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c9bfff41
    • andersca@apple.com's avatar
      2011-01-22 Anders Carlsson <andersca@apple.com> · 4beeebf5
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Transparent windows with compositing WebKit2 content show garbage
              https://bugs.webkit.org/show_bug.cgi?id=52966
              <rdar://problem/8765051>
      
              * UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
              (WebKit::LayerBackedDrawingAreaProxy::paint):
              If the WKView should draw transparent background, do so.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76453 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4beeebf5
    • andersca@apple.com's avatar
      2011-01-22 Anders Carlsson <andersca@apple.com> · f3248c7d
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Add an asynchronous WKPageForceRepaint
              https://bugs.webkit.org/show_bug.cgi?id=52964
              <rdar://problem/8898527>
      
              * UIProcess/API/C/WKPage.cpp:
              (WKPageForceRepaint):
              Call WebPageProxy::forceRepaint.
      
              * UIProcess/API/C/WKPage.h:
              Add WKPageForceRepaint.
      
              * UIProcess/GenericCallback.h:
              Add a "generic" VoidCallback class.
      
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::forceRepaint):
              Insert the callback in the m_voidCallbacks map and send a forceRepaint message.
      
              (WebKit::WebPageProxy::voidCallback):
              Call the right void callback.
      
              (WebKit::WebPageProxy::processDidCrash):
              Invalidate m_voidCallbacks.
      
              * UIProcess/WebPageProxy.messages.in:
              Add a VoidCallback message.
      
              * WebProcess/WebPage/ChunkedUpdateDrawingArea.cpp:
              (WebKit::ChunkedUpdateDrawingArea::forceRepaint):
              Force a repaint.
      
              * WebProcess/WebPage/ChunkedUpdateDrawingArea.h:
              Add forceRepaint.
      
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::forceRepaint):
              Call forceRepaint on the drawing area.
      
              * WebProcess/WebPage/WebPage.messages.in:
              Add a ForceRepaint message.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76452 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3248c7d
    • robert@webkit.org's avatar
      2011-01-22 Robert Hogan <robert@webkit.org> · 852ab546
      robert@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Support layoutTestController.addURLToRedirect()
              https://bugs.webkit.org/show_bug.cgi?id=52956
      
              * platform/qt/Skipped:
      2011-01-22  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] Support layoutTestController.addURLToRedirect()
              https://bugs.webkit.org/show_bug.cgi?id=52956
      
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::addURLToRedirect):
              * WebCoreSupport/DumpRenderTreeSupportQt.h:
              * WebCoreSupport/FrameLoaderClientQt.cpp:
              (WebCore::FrameLoaderClientQt::dispatchWillSendRequest):
              * WebCoreSupport/FrameLoaderClientQt.h:
      2011-01-22  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Andreas Kling.
      
              [Qt] Support layoutTestController.addURLToRedirect()
              https://bugs.webkit.org/show_bug.cgi?id=52956
      
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::addURLToRedirect):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76451 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      852ab546
    • zimmermann@webkit.org's avatar
      2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com> · 8ced7144
      zimmermann@webkit.org authored
              Not reviewed.
      
              REGRESSION: Vertical line metrics incorrect
              https://bugs.webkit.org/show_bug.cgi?id=52960
      
              Revert accidently landed mac baseline changes.
      
              * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
              * platform/mac/svg/batik/text/xmlSpace-expected.txt:
              * platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
              * platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
              * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
              * platform/mac/svg/text/text-hkern-expected.txt:
              * platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
              * platform/mac/svg/text/text-text-04-t-expected.txt:
              * platform/mac/svg/text/text-vkern-expected.txt:
              * platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
              * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76450 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ced7144
    • zimmermann@webkit.org's avatar
      2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com> · 9c4aceb1
      zimmermann@webkit.org authored
              Not reviewed.
      
              REGRESSION: Vertical line metrics incorrect
              https://bugs.webkit.org/show_bug.cgi?id=52960
      
              Rebaselined several text dumps from the bots, after the FontMetrics change.
              All show 1px diffs, but are progressions, since the lineSpacing calculation has been improved.
              Mac still has the old results - as it depends on a rounding trick at the moment.
      
              * platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
              * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
              * platform/gtk/svg/text/text-hkern-expected.txt:
              * platform/gtk/svg/text/text-hkern-on-vertical-text-expected.txt:
              * platform/gtk/svg/text/text-vkern-expected.txt:
              * platform/gtk/svg/text/text-vkern-on-horizontal-text-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
              * platform/mac/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
              * platform/mac/svg/batik/text/xmlSpace-expected.txt:
              * platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
              * platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
              * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
              * platform/mac/svg/text/text-hkern-expected.txt:
              * platform/mac/svg/text/text-hkern-on-vertical-text-expected.txt:
              * platform/mac/svg/text/text-text-04-t-expected.txt:
              * platform/mac/svg/text/text-vkern-expected.txt:
              * platform/mac/svg/text/text-vkern-on-horizontal-text-expected.txt:
              * platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
              * platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
              * platform/qt/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
              * platform/qt/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
              * platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
              * platform/qt/svg/text/text-hkern-expected.txt:
              * platform/qt/svg/text/text-hkern-on-vertical-text-expected.txt:
              * platform/qt/svg/text/text-vkern-expected.txt:
              * platform/qt/svg/text/text-vkern-on-horizontal-text-expected.txt:
              * platform/qt/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76449 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c4aceb1
    • andreip@google.com's avatar
      2011-01-22 Andrei Popescu <andreip@google.com> · d16c1587
      andreip@google.com authored
              Reviewed by Jeremy Orlow.
      
              IndexedDB corrupts data on disk
              https://bugs.webkit.org/show_bug.cgi?id=52890
      
              * storage/indexeddb/data-corruption-expected.txt: Added.
              * storage/indexeddb/data-corruption.html: Added.
      2011-01-22  Andrei Popescu  <andreip@google.com>
      
              Reviewed by Jeremy Orlow.
      
              IndexedDB corrupts data on disk
              https://bugs.webkit.org/show_bug.cgi?id=52890
      
              We need to store the SerializedScriptValues on disk in a BLOB column rather than TEXT.
              Test: storage/indexeddb/data-corruption.html
      
              * platform/sql/SQLiteStatement.cpp:
              (WebCore::SQLiteStatement::bindBlob):
              (WebCore::SQLiteStatement::getColumnBlobAsString):
              (WebCore::SQLiteStatement::getColumnBlobAsVector):
              * platform/sql/SQLiteStatement.h:
              * storage/IDBCursorBackendImpl.cpp:
              (WebCore::IDBCursorBackendImpl::loadCurrentRow):
              * storage/IDBFactoryBackendImpl.cpp:
              (WebCore::runCommands):
              (WebCore::createTables):
              (WebCore::createMetaDataTable):
              (WebCore::migrateDatabase):
              * storage/IDBObjectStoreBackendImpl.cpp:
              (WebCore::IDBObjectStoreBackendImpl::getInternal):
              (WebCore::putObjectStoreData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76448 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d16c1587
    • zimmermann@webkit.org's avatar
      2011-01-22 Nikolas Zimmermann <nzimmermann@rim.com> · 7436a2ca
      zimmermann@webkit.org authored
              Not reviewed. Fix WinCE build.
      
              * platform/graphics/wince/GraphicsContextWinCE.cpp:
              (WebCore::GraphicsContext::drawText):
              * rendering/RenderThemeWinCE.cpp:
              (WebCore::RenderThemeWinCE::adjustMenuListButtonStyle):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76447 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7436a2ca
    • robert@webkit.org's avatar
      2011-01-22 Robert Hogan <robert@webkit.org> · d31455da
      robert@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
              https://bugs.webkit.org/show_bug.cgi?id=49802
      
              * platform/qt/Skipped:
              * platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt: Added.
              * platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt: Added.
              * platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt: Added.
      2011-01-22  Robert Hogan  <robert@webkit.org>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
              https://bugs.webkit.org/show_bug.cgi?id=49802
      
              * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
              (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
              (WebCore::DumpRenderTree::open):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76446 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d31455da