1. 29 Jun, 2005 23 commits
    • harrison's avatar
      Reviewed by Dave Hyatt (rendering) and Maciej (editing). · b43c5185
      harrison authored
              Test cases added:  Coming soon.  Will include with next round of changes for this bug.
      
              This is the first checkin for...
      
              <rdar://problem/3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)
      
              Basic strategy is to put tabs into spans with white-space:pre style, and
              render them with tabs stops every 8th space, where the space width and
              the left margin are those of the enclosing block.
      
              What's left is to switch to implement white-space:pre-wrap so
              that we can coalesce consecutive tabs while maintaining proper
              line breaking.  That will keep the markup smaller.
      
              * khtml/editing/apply_style_command.cpp:
              (khtml::createStyleSpanElement):
              (khtml::ApplyStyleCommand::removeCSSStyle):
              (khtml::ApplyStyleCommand::addInlineStyleIfNeeded):
              * khtml/editing/delete_selection_command.cpp:
              (khtml::DeleteSelectionCommand::saveTypingStyleState):
              * khtml/editing/edit_command.cpp:
              (khtml::EditCommand::styleAtPosition):
              * khtml/editing/html_interchange.h:
              * khtml/editing/htmlediting.cpp:
              (khtml::isSpecialElement):
              (khtml::isTabSpanNode):
              (khtml::isTabSpanTextNode):
              (khtml::positionBeforeTabSpan):
              (khtml::createTabSpanElement):
              * khtml/editing/htmlediting.h:
              * khtml/editing/insert_text_command.cpp:
              (khtml::InsertTextCommand::prepareForTextInsertion):
              (khtml::InsertTextCommand::input):
              (khtml::InsertTextCommand::insertTab):
              * khtml/editing/insert_text_command.h:
              * khtml/editing/markup.cpp:
              (khtml::createParagraphContentsFromString):
              (khtml::createFragmentFromText):
              * khtml/editing/replace_selection_command.cpp:
              (khtml::ReplacementFragment::removeStyleNodes):
              * khtml/html/htmltokenizer.cpp:
              (khtml::HTMLTokenizer::begin):
              (khtml::HTMLTokenizer::processListing):
              (khtml::HTMLTokenizer::parseEntity):
              (khtml::HTMLTokenizer::parseTag):
              (khtml::HTMLTokenizer::addPending):
              (khtml::HTMLTokenizer::write):
              * khtml/html/htmltokenizer.h:
              (khtml::HTMLTokenizer::):
              * khtml/rendering/bidi.cpp:
              (khtml::addRun):
              (khtml::RenderBlock::tabWidth):
              (khtml::RenderBlock::computeHorizontalPositionsForLine):
              (khtml::RenderBlock::skipWhitespace):
              (khtml::RenderBlock::findNextLineBreak):
              (khtml::RenderBlock::checkLinesForTextOverflow):
              * khtml/rendering/break_lines.cpp:
              (khtml::isBreakable):
              * khtml/rendering/font.cpp:
              (Font::drawHighlightForText):
              (Font::drawText):
              (Font::floatWidth):
              (Font::floatCharacterWidths):
              (Font::checkSelectionPoint):
              (Font::width):
              * khtml/rendering/font.h:
              * khtml/rendering/render_block.cpp:
              (khtml::stripTrailingSpace):
              (khtml::RenderBlock::calcInlineMinMaxWidth):
              * khtml/rendering/render_block.h:
              * khtml/rendering/render_br.h:
              (khtml::RenderBR::width):
              * khtml/rendering/render_flexbox.cpp:
              (khtml::RenderFlexibleBox::layoutVerticalBox):
              * khtml/rendering/render_image.cpp:
              (RenderImage::setPixmap):
              (RenderImage::paint):
              * khtml/rendering/render_line.cpp:
              (khtml::EllipsisBox::paint):
              * khtml/rendering/render_line.h:
              (khtml::InlineBox::width):
              (khtml::InlineBox::xPos):
              (khtml::InlineBox::yPos):
              (khtml::InlineBox::height):
              (khtml::InlineBox::baseline):
              * khtml/rendering/render_list.cpp:
              (RenderListMarker::paint):
              (RenderListMarker::calcMinMaxWidth):
              * khtml/rendering/render_object.cpp:
              (RenderObject::tabWidth):
              (RenderObject::recalcMinMaxWidths):
              * khtml/rendering/render_object.h:
              * khtml/rendering/render_replaced.cpp:
              * khtml/rendering/render_text.cpp:
              (InlineTextBox::selectionRect):
              (InlineTextBox::paint):
              (InlineTextBox::paintSelection):
              (InlineTextBox::paintMarkedTextBackground):
              (InlineTextBox::textPos):
              (InlineTextBox::offsetForPosition):
              (InlineTextBox::positionForOffset):
              (RenderText::cacheWidths):
              (RenderText::widthFromCache):
              (RenderText::trimmedMinMaxWidth):
              (RenderText::calcMinMaxWidth):
              (RenderText::containsOnlyWhitespace):
              (RenderText::width):
              * khtml/rendering/render_text.h:
              * kwq/KWQFontMetrics.h:
              * kwq/KWQFontMetrics.mm:
              (QFontMetrics::width):
              (QFontMetrics::charWidth):
              (QFontMetrics::floatWidth):
              (QFontMetrics::floatCharacterWidths):
              (QFontMetrics::checkSelectionPoint):
              (QFontMetrics::boundingRect):
              (QFontMetrics::size):
              * kwq/KWQPainter.h:
              * kwq/KWQPainter.mm:
              (QPainter::drawText):
              (QPainter::drawHighlightForText):
              * kwq/WebCoreTextRenderer.h:
              * kwq/WebCoreTextRendererFactory.mm:
              (WebCoreInitializeEmptyTextStyle):
              * layout-tests/editing/deleting/delete-tab-001-expected.txt:
              * layout-tests/editing/deleting/delete-tab-001.html:
              * layout-tests/editing/deleting/delete-tab-002-expected.txt:
              * layout-tests/editing/deleting/delete-tab-002.html:
              * layout-tests/editing/deleting/delete-tab-003-expected.txt:
              * layout-tests/editing/deleting/delete-tab-003.html:
              * layout-tests/editing/deleting/delete-tab-004-expected.txt:
              * layout-tests/editing/deleting/delete-tab-004.html:
              * layout-tests/editing/inserting/insert-tab-001-expected.txt:
              * layout-tests/editing/inserting/insert-tab-002-expected.txt:
              * layout-tests/editing/inserting/insert-tab-003-expected.txt:
              * layout-tests/editing/inserting/insert-tab-004-expected.txt:
              * layout-tests/fast/dom/quadraticCurveTo-expected.txt:
              * layout-tests/fast/js/string-replace-2-expected.txt:
              * layout-tests/fast/table/039-expected.txt:
              * layout-tests/fast/table/border-collapsing/004-expected.txt:
              * layout-tests/fast/tokenizer/script_extra_close-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b43c5185
    • ggaren's avatar
      JavaScriptCore: · b0aae7df
      ggaren authored
      	Patch by Francisco Tolmasky <tolmasky@gmail.com>
      
      	- fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3667
      	Core JavaScript 1.5 Reference:Objects:Array:forEach
      
      	See WebCore Changelog for layout tests added.
      
              Reviewed by darin.
      
              * kjs/array_object.cpp:
              (ArrayProtoFuncImp::call):
              * kjs/array_object.h:
              (KJS::ArrayProtoFuncImp::):
      
      WebCore:
      
      	Contributed by Francisco Tolmasky <tolmasky@gmail.com>
      
      	-test cases for fix to http://bugzilla.opendarwin.org/show_bug.cgi?id=3667
      	Core JavaScript 1.5 Reference:Objects:Array:forEach
      
      	See JavaScriptCore Changelog for details on the patch.
      
              Reviewed by darin.
      
              Test cases added:
              * layout-tests/fast/js/array-every-expected.txt: Added.
              * layout-tests/fast/js/array-every.html: Added.
              * layout-tests/fast/js/array-foreach-expected.txt: Added.
              * layout-tests/fast/js/array-foreach.html: Added.
              * layout-tests/fast/js/array-some-expected.txt: Added.
              * layout-tests/fast/js/array-some.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b0aae7df
    • bdibello's avatar
      Reviewed by Geoff Garen · d4c3b88e
      bdibello authored
              Test cases added: added expected results for previous check in
      
              * layout-tests/fast/dom/HTMLDocument/url/getset-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4c3b88e
    • ggaren's avatar
      DOM compatibility tests for HTMLDocument::writeln · db397201
      ggaren authored
              Reviewed by justing.
      
              Test cases added:
      
              * layout-tests/fast/dom/HTMLDocument/writeln/call-expected.txt: Added.
              * layout-tests/fast/dom/HTMLDocument/writeln/call.html: Added.
              * layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls-expected.txt: Added.
              * layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db397201
    • ggaren's avatar
      Reviewed by Geoff Garen. · 69f483c3
      ggaren authored
              Test cases added: added DOM test for document.URL
      
              * layout-tests/fast/dom/HTMLDocument/url/getset.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69f483c3
    • bdibello's avatar
      Reviewed by Geoff Garen. · 664577fa
      bdibello authored
              Test cases added: added DOM test for document.URL
      
              * layout-tests/fast/dom/HTMLDocument/url/getset.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      664577fa
    • ggaren's avatar
      DOM compatibility test for HTMLDocument::write · 8502e637
      ggaren authored
              Reviewed by justing.
      
              Test cases added:
              * layout-tests/fast/dom/HTMLDocument/write/call-expected.txt: Added.
              * layout-tests/fast/dom/HTMLDocument/write/call.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8502e637
    • ggaren's avatar
      DOM compatibility tests for HTMLDocument::title · f42b5231
      ggaren authored
              Reviewed by justing.
      
              Test cases added:
              * layout-tests/fast/dom/HTMLDocument/title/get-expected.txt: Added.
              * layout-tests/fast/dom/HTMLDocument/title/get.html: Added.
              * layout-tests/fast/dom/HTMLDocument/title/set-expected.txt: Added.
              * layout-tests/fast/dom/HTMLDocument/title/set.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f42b5231
    • ggaren's avatar
      DOM compatibility tests for HTMLDocument::title · 4290e8a7
      ggaren authored
              Reviewed by justing.
      
              Test cases added:
              * layout-tests/fast/dom/HTMLDocument/title/get.html: Added.
              * layout-tests/fast/dom/HTMLDocument/title/set.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4290e8a7
    • sullivan's avatar
      Reviewed by Kevin. · 8ddee2ab
      sullivan authored
              - deleted some never-used stub code
      
              * WebView.subproj/WebView.m:
              * WebView.subproj/WebViewInternal.h:
              * WebView.subproj/WebViewPrivate.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ddee2ab
    • justing's avatar
      *** empty log message *** · db30969c
      justing authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      db30969c
    • justing's avatar
      *** empty log message *** · f958feb7
      justing authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f958feb7
    • justing's avatar
      *** empty log message *** · 9e820456
      justing authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9e820456
    • mjs's avatar
      Reviewed by Darin. · 3de19481
      mjs authored
              Added iterator support to new hashtable class, the HashSet API is
      	now essentially complete.
      
      	Added support for consistency check mode.
      
              * khtml/misc/hashset.h:
              (khtml::HashSet::capacity): Added
              (khtml::HashSet::begin): Added (both const and non-const)
              (khtml::HashSet::end): Added (both const and non-const)
              (khtml::HashSet::insert): Made both versions return an iterator
              (khtml::HashSet::find): Added (both const and on-const, returning appropriate iterator)
              (khtml::HashSet::contains): Added
              (khtml::HashSet::remove): Added version that takes an iterator argument
              (khtml::HashSet::clear): Added
              * khtml/misc/hashtable.h:
              (khtml::HashTableIterator): New class with all the obvious iterator stuff.
              (khtml::HashTableConstIterator::HashTableConstIterator): New class with all the obvious
      	const iterator stuff.
              (khtml::HashTable::begin): Added (both const and non-consts)
              (khtml::HashTable::end): Added (both const and non-consts)
              (khtml::HashTable::capacity): Added
              (khtml::HashTable::insert): Implement non-template method in terms
      	of template method.
              (khtml::HashTable::contains): Added (implemented in terms of find)
              (khtml::HashTable::remove): Implemented key remove in terms of find and
      	iterator remove.
              (khtml::HashTable::hash): Made static
              (khtml::HashTable::equal): Made static
              (khtml::HashTable::identityConvert): Added - no-op convert method so template insert
      	method can be implemented in terms of non-template
              (khtml::HashTable::insert): Changed to return iterator
              (khtml::HashTable::reinsert): Recoded to be more like the other functions
              (khtml::HashTable::find): Added
              (khtml::HashTable::remove): Added iterator version
              (khtml::HashTable::clear): Added
              * khtml/xml/dom_atomicstring.cpp:
              (DOM::AtomicString::add): Updated to deal with the fact that insert returns an iterator
              (khtml::HashTable::shouldExpand): New helper.
              (khtml::HashTable::shouldShrink): ditto
              (khtml::HashTable::makeIterator): ditto
              (khtml::HashTable::makeConstIterator): ditto
              (khtml::HashTable::checkConsistency): consistency check method
              (khtml::HashTable::checkConsistencyExceptSize): consistency check method
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3de19481
    • ggaren's avatar
      JavaScriptCore: · 33a3a951
      ggaren authored
      	Patch contributed by Oliver Hunt <ojh16@student.canterbury.ac.nz>
      
      	-fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3743
      	Incorrect error message given for certain calls
      
      	See WebCore Changelog for layout test added.
      
              Reviewed by mjs.
      
              * kjs/object.cpp:
              (KJS::ObjectImp::defaultValue):
      
      WebCore:
      
      	-added test case for fix to http://bugzilla.opendarwin.org/show_bug.cgi?id=3743
      	Incorrect error message given for certain calls
      
      	See JavaScriptCore Changelog for details about the patch.
      
              Reviewed by me.
      
              Test cases added:
              * layout-tests/fast/js/toString-stack-overflow-expected.txt: Added.
              * layout-tests/fast/js/toString-stack-overflow.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      33a3a951
    • ggaren's avatar
      Rolling out date patch from 6-28-05 because it breaks · f24910cb
      ggaren authored
      	fast/js/date-parse-test
      
              Reviewed by NOBODY.
      
              * kjs/date_object.cpp:
              (formatLocaleDate):
              (DateProtoFuncImp::call):
              (DateObjectImp::construct):
              (KJS::parseDate):
              (ymdhms_to_seconds):
              (isSpaceOrTab):
              (KJS::KRFCDate_parseDate):
              * kjs/date_object.h:
              * tests/mozilla/expected.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f24910cb
    • justing's avatar
      - Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3714> · cba4c3c5
      justing authored
              HTMLLabelElement's form property isn't implemented
      
              Patch by Anders Carlsson <andersca@mac.com>
      
              Reviewed by Darin
      
              Test cases added:
              * layout-tests/fast/dom/HTMLLabelElement/properties/form-expected.txt: Added.
              * layout-tests/fast/dom/HTMLLabelElement/properties/form.html: Added.
      
              * khtml/html/html_formimpl.cpp:
              (DOM::HTMLLabelElementImpl::form):
              Traverse upwards looking for a form element.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cba4c3c5
    • justing's avatar
      Bug #: · 1f3e0718
      justing authored
      Submitted by:
      Reviewed by:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f3e0718
    • ggaren's avatar
      Patch by Joost de Valk <webkit@joostdevalk.nl> · b8f2aff6
      ggaren authored
      	- http://bugzilla.opendarwin.org/show_bug.cgi?id=3732
      	Testcase for accesskeys that will run with run-webkit-tests.
      
              Reviewed by Darin.
      
              Test cases added:
              * layout-tests/fast/forms/access-key-expected.txt: Added.
              * layout-tests/fast/forms/access-key.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b8f2aff6
    • justing's avatar
      Patch by Anders Carlsson <andersca@mac.com> · 9433aa2e
      justing authored
              - Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3715>
              An HTMLObjectElement's form property was always null.
      
              Reviewed by Darin
      
              Test cases added:
              * layout-tests/fast/dom/htmlobject-form-expected.txt: Added.
              * layout-tests/fast/dom/htmlobject-form.html: Added.
      
              * khtml/html/html_objectimpl.cpp:
              (DOM::HTMLObjectElementImpl::form):
              Implement this function by traversing the parent nodes looking
              for a form element.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9433aa2e
    • ggaren's avatar
      Patch by Antoine Quint <ml@graougraou.com> · 51b18553
      ggaren authored
      	-fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3648
      	quadraticCurveTo() method in <canvas> APIs JS bindings does not exist
      
              Reviewed by Darin.
      
              Test cases added:
              * layout-tests/fast/dom/quadraticCurveTo-expected.txt: Added.
              * layout-tests/fast/dom/quadraticCurveTo.xml: Added.
      
              * khtml/ecma/kjs_html.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      51b18553
    • ggaren's avatar
      Patch by Hanspeter Schaub <Hanspeterschaub@mac.com> · 0d630388
      ggaren authored
      	-fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3317
      	REGRESSION: CSS2: outline is applied to both <li> element
      	and its enclosing text with context dependent selector
      
              Reviewed by Hyatt.
      
              Test cases added:
              * layout-tests/fast/css/list-outline-expected.txt: Added.
              * layout-tests/fast/css/list-outline.html: Added.
      
              * khtml/rendering/render_line.cpp:
              (khtml::InlineFlowBox::paint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0d630388
    • ggaren's avatar
      Reviewed by Darin. · c8dafe43
      ggaren authored
      	-fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3750
      	build fails with KJS_VERBOSE set
      
              * kjs/nodes.cpp: changed debug print statement to use UString
              (VarDeclNode::evaluate):
              * kjs/reference.cpp: ditto
              (KJS::Reference::putValue):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@9518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8dafe43
  2. 28 Jun, 2005 6 commits
  3. 27 Jun, 2005 6 commits
  4. 26 Jun, 2005 1 commit
  5. 25 Jun, 2005 1 commit
  6. 24 Jun, 2005 3 commits