1. 12 Aug, 2013 35 commits
    • oliver@apple.com's avatar
      Remove CodeBlock's notion of adding identifiers entirely · b4345037
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119708
      
      Reviewed by Geoffrey Garen.
      
      Remove addAdditionalIdentifier entirely, including the bogus assertion.
      Move the addition of identifiers to DFGPlan::reallyAdd
      
      * bytecode/CodeBlock.h:
      * dfg/DFGDesiredIdentifiers.cpp:
      (JSC::DFG::DesiredIdentifiers::reallyAdd):
      * dfg/DFGDesiredIdentifiers.h:
      * dfg/DFGPlan.cpp:
      (JSC::DFG::Plan::reallyAdd):
      (JSC::DFG::Plan::finalize):
      * dfg/DFGPlan.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153967 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4345037
    • ryuan.choi@samsung.com's avatar
      [EFL] Unreviewed gardening. · e6928ed3
      ryuan.choi@samsung.com authored
      * platform/efl/TestExpectations: Added pasteboard after r152185.
      * platform/efl/editing/deleting/delete-br-002-expected.txt: Updated after r152478.
      * platform/efl/editing/execCommand/outdent-blockquote-test1-expected.txt:
      Removed platform specific expectations after r152494.
      * platform/efl/editing/execCommand/outdent-blockquote-test2-expected.txt: Ditto.
      * platform/efl/editing/execCommand/outdent-blockquote-test3-expected.txt: Ditto.
      * platform/efl/editing/execCommand/outdent-blockquote-test4-expected.txt: Ditto.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153966 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6928ed3
    • oliver@apple.com's avatar
      Build fix · be885151
      oliver@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153965 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be885151
    • ap@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=119693 · fd6d6354
      ap@apple.com authored
      [Mac] security/contentSecurityPolicy/connect-src-websocket-blocked.html is flaky
      because of connect-src-websocket-allowed.html
      
      Reviewed by Darin Adler.
      
      Starting a load of about:blank and immediately stopping it cancels outstanding
      resource loads, but the page has to transition to committed state to have timers
      or WebSockets stopped too.
      
      * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Use a synchronous load to
      ensure that transition to committed state happens before we start the next test.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153964 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fd6d6354
    • oliver@apple.com's avatar
      Move additionalIdentifiers into DFGCommonData as only the optimising JITs use them · 7a432c90
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119705
      
      Reviewed by Geoffrey Garen.
      
      Relatively trivial refactoring
      
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::numberOfAdditionalIdentifiers):
      (JSC::CodeBlock::addAdditionalIdentifier):
      (JSC::CodeBlock::identifier):
      (JSC::CodeBlock::numberOfIdentifiers):
      * dfg/DFGCommonData.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153963 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a432c90
    • oliver@apple.com's avatar
      Stop making unnecessary copy of CodeBlock Identifier Vector · 9b652768
      oliver@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119702
      
      Reviewed by Michael Saboff.
      
      Make CodeBlock simply use a separate Vector for additional Identifiers
      and use the UnlinkedCodeBlock for the initial set of identifiers.
      
      * bytecode/CodeBlock.cpp:
      (JSC::CodeBlock::printGetByIdOp):
      (JSC::dumpStructure):
      (JSC::dumpChain):
      (JSC::CodeBlock::printGetByIdCacheStatus):
      (JSC::CodeBlock::printPutByIdOp):
      (JSC::CodeBlock::dumpBytecode):
      (JSC::CodeBlock::CodeBlock):
      (JSC::CodeBlock::shrinkToFit):
      * bytecode/CodeBlock.h:
      (JSC::CodeBlock::numberOfIdentifiers):
      (JSC::CodeBlock::numberOfAdditionalIdentifiers):
      (JSC::CodeBlock::addAdditionalIdentifier):
      (JSC::CodeBlock::identifier):
      * dfg/DFGDesiredIdentifiers.cpp:
      (JSC::DFG::DesiredIdentifiers::reallyAdd):
      * jit/JIT.h:
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emitSlow_op_get_arguments_length):
      * jit/JITPropertyAccess.cpp:
      (JSC::JIT::emit_op_get_by_id):
      (JSC::JIT::compileGetByIdHotPath):
      (JSC::JIT::emitSlow_op_get_by_id):
      (JSC::JIT::compileGetByIdSlowCase):
      (JSC::JIT::emitSlow_op_put_by_id):
      * jit/JITPropertyAccess32_64.cpp:
      (JSC::JIT::emit_op_get_by_id):
      (JSC::JIT::compileGetByIdHotPath):
      (JSC::JIT::compileGetByIdSlowCase):
      * jit/JITStubs.cpp:
      (JSC::DEFINE_STUB_FUNCTION):
      * llint/LLIntSlowPaths.cpp:
      (JSC::LLInt::LLINT_SLOW_PATH_DECL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153962 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b652768
    • a.renevier@samsung.com's avatar
      [cairo] memory corruption with putImageData and accelerated canvas. · bb47298f
      a.renevier@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=118621
      
      Reviewed by Martin Robinson.
      
      When we have an accelerated imageBuffer, and we putByteArray with a
      non zero destPoint, we create temporary surface of sourceSize. Then,
      we write to image data with an offset. This results in an out of bound
      write.
      
      In order to avoid that, we use a 0 offset when writing data.
      
      In addition, we also create image with the minimal needed size in
      getImageData, and also use a 0 offset. This decrease data transfer
      between cpu and gpu
      
      Instead of the map/unmap mechanism, perform an explicit surface copy
      when needed. This change also removes an unneeded glReadPixels at the
      start of putByteArray
      
      Add two parameters to copyRectFromOneSurfaceToAnother: destination
      offset, and cairo drawing operator.
      
      No new tests. Accelerated canvas is not enabled for testing yet.
      
      * platform/graphics/cairo/CairoUtilities.cpp:
      (WebCore::copyRectFromOneSurfaceToAnother):
      * platform/graphics/cairo/CairoUtilities.h:
      * platform/graphics/cairo/ImageBufferCairo.cpp:
      (WebCore::copySurfaceToImageAndAdjustRect):
      (WebCore::getImageData):
      (WebCore::ImageBuffer::putByteArray):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153961 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb47298f
    • rniwa@webkit.org's avatar
      Layout Test fast/overflow/scrollbar-click-retains-focus.html is failing on Apple Mac WK1 and GTK. · 291ffc28
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=104104
      
      Add back test expectation for Mac since it's still failing on ML WK1 bots.
      
      * platform/mac/TestExpectations:
      * platform/mac-wk2/TestExpectations:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153960 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      291ffc28
    • rniwa@webkit.org's avatar
      Use const AtomicStringImpl* in DocumentOrderedMap · c8bc2077
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119700
      
      Reviewed by Benjamin Poulain.
      
      Use const AtomicStringImpl* in DocumentOrderedMap. It caught at least one bug that HTMLNameCollection'
      subclasses' nodeMatches were taking const AtomicString& instead of AtomicStringImpl*. This was forcing
      DocumentOrderedMap::getElementByWindowNamedItem and DocumentOrderedMap::getElementByDocumentNamedItem
      to create temporary AtomicStrings.
      
      * dom/DocumentOrderedMap.cpp:
      (WebCore::keyMatchesId):
      (WebCore::keyMatchesName):
      (WebCore::keyMatchesMapName):
      (WebCore::keyMatchesLowercasedMapName):
      (WebCore::keyMatchesLabelForAttribute):
      (WebCore::keyMatchesWindowNamedItem):
      (WebCore::keyMatchesDocumentNamedItem):
      (WebCore::DocumentOrderedMap::add):
      (WebCore::DocumentOrderedMap::remove):
      (WebCore::DocumentOrderedMap::get):
      (WebCore::DocumentOrderedMap::getElementById):
      (WebCore::DocumentOrderedMap::getElementByName):
      (WebCore::DocumentOrderedMap::getElementByMapName):
      (WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
      (WebCore::DocumentOrderedMap::getElementByLabelForAttribute):
      (WebCore::DocumentOrderedMap::getElementByWindowNamedItem):
      (WebCore::DocumentOrderedMap::getElementByDocumentNamedItem):
      (WebCore::DocumentOrderedMap::getAllElementsById):
      * dom/DocumentOrderedMap.h:
      (WebCore::DocumentOrderedMap::containsSingle):
      (WebCore::DocumentOrderedMap::contains):
      (WebCore::DocumentOrderedMap::containsMultiple):
      * html/HTMLNameCollection.cpp:
      (WebCore::WindowNameCollection::nodeMatches):
      (WebCore::DocumentNameCollection::nodeMatches):
      * html/HTMLNameCollection.h:
      (WebCore::WindowNameCollection::nodeMatches):
      (WebCore::DocumentNameCollection::nodeMatches):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c8bc2077
    • bdakin@apple.com's avatar
      The LayoutMilestones didLayout callback should only fire for the main frame · 7ce7e1b1
      bdakin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119457
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      This patch makes it so that FrameLoader::didLayout(LayoutMilestones) is only ever 
      called for the main frame. Technically this will change existing API for 
      didFirstVisuallyNonEmptyLayoutInFrame and didFirstLayoutInFrame. Clients used to 
      be able to register for those callbacks for any frame they wanted, however, now 
      they will only ever get the callback when it applies to the main frame. We think 
      that this is acceptable since we don’t know of any clients that ever used those 
      APIs for a non-main frame. This change also makes nothing but sense for the 
      didLayout(LayoutMilestones) callback, since that is a Page-level concept, so it 
      should only fire for the main frame.
      
      Only call didLayout for the main frame.
      * dom/Document.cpp:
      (WebCore::Document::setVisualUpdatesAllowed):
      
      Assert that this is the main frame.
      * loader/FrameLoader.cpp:
      (WebCore::FrameLoader::didLayout):
      
      Only call didLayout for the main frame.
      * page/FrameView.cpp:
      (WebCore::FrameView::performPostLayoutTasks):
      
      Tools: 
      
      Now that the didLayout callback only fires for the main frame, we want to make 
      sure it will fire even when all of the content is in a subframe.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp: Added.
      (TestWebKitAPI::didLayout):
      (TestWebKitAPI::TEST):
      * TestWebKitAPI/Tests/WebKit2/all-content-in-one-iframe.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153958 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ce7e1b1
    • bdakin@apple.com's avatar
      Remove didNewFirstVisuallyNonEmptyLayout from WebKit2 · df41e0de
      bdakin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119658
      
      Reviewed by Darin Adler.
      
      Source/WebKit2: 
      
      Removing this function entirely will change some functionality in the Nightlies, 
      but we think that is an acceptable difference for the Nightlies. If is does cause 
      a problem though, we can roll out this patch and deprecate the function instead.
      
      * UIProcess/API/C/WKPage.h:
      * UIProcess/WebLoaderClient.cpp:
      * UIProcess/WebLoaderClient.h:
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::initializeLoaderClient):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * WebProcess/InjectedBundle/API/c/WKBundlePage.h:
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
      * WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
      * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
      (WebKit::WebFrameLoaderClient::dispatchDidLayout):
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::initializeInjectedBundleLoaderClient):
      
      Tools: 
      
      * MiniBrowser/mac/WK2BrowserWindowController.m:
      (-[WK2BrowserWindowController awakeFromNib]):
      * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
      (WTR::InjectedBundlePage::InjectedBundlePage):
      * WebKitTestRunner/TestController.cpp:
      (WTR::TestController::createWebViewWithOptions):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153956 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      df41e0de
    • ch.dumez@sisa.samsung.com's avatar
      Define DOM_KEY_LOCATION_* constants on KeyboardEvent · 25c754fa
      ch.dumez@sisa.samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119341
      
      Reviewed by Ryosuke Niwa.
      
      Source/WebCore:
      
      Add support for the DOM_KEY_LOCATION_* constants on KeyboardEvent as per
      the specification:
      http://www.w3.org/TR/DOM-Level-3-Events/#events-KeyboardEvent
      
      Those constants are already supported by IE10, Firefox 22 and since
      recently Blink.
      
      Note that the following constants are not supported / exposed yet:
      DOM_KEY_LOCATION_MOBILE and DOM_KEY_LOCATION_JOYSTICK.
      
      Test: fast/events/keyboardevent-location-constants.html
      
      * dom/KeyboardEvent.cpp:
      (WebCore::keyLocationCode):
      (WebCore::KeyboardEvent::KeyboardEvent):
      * dom/KeyboardEvent.h:
      * dom/KeyboardEvent.idl:
      
      LayoutTests:
      
      Make use of the new DOM_KEY_LOCATION_* constants in the KeyboardEvent
      test cases instead of hardcoding their values.
      
      * fast/events/constructors/keyboard-event-constructor-expected.txt:
      * fast/events/constructors/keyboard-event-constructor.html:
      * fast/events/js-keyboard-event-creation-expected.txt:
      * fast/events/js-keyboard-event-creation.html:
      * fast/events/keyboardevent-location-constants-expected.txt: Added.
      * fast/events/keyboardevent-location-constants.html: Added.
      * fast/events/keydown-leftright-keys-expected.txt:
      * fast/events/keydown-leftright-keys.html:
      * fast/events/keydown-numpad-keys-expected.txt:
      * fast/events/script-tests/keydown-numpad-keys.js:
      (testKeyEventWithLocation):
      * platform/efl/fast/events/js-keyboard-event-creation-expected.txt:
      * platform/gtk/fast/events/js-keyboard-event-creation-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153955 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25c754fa
    • seokju@webkit.org's avatar
      Remove glu's libtest rule from checker.py · ef485a79
      seokju@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119674
      
      Reviewed by Darin Adler.
      
      * Scripts/webkitpy/style/checker.py: It is no longer used after r148032.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153954 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ef485a79
    • ap@apple.com's avatar
      Multiple CSP tests complain about undefined strings in echo-object-data.pl and echo-script-src.pl · 87a92545
      ap@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119692
      
      Reviewed by Darin Adler.
      
      * http/tests/security/contentSecurityPolicy/resources/echo-object-data.pl:
      * http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl:
      Check whether optional CGI parameters are provided.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      87a92545
    • timothy_horton@apple.com's avatar
      dataLog dumpers for WebCore's basic geometry types · b9dc6063
      timothy_horton@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119636
      
      Reviewed by Filip Pizlo.
      
      * platform/graphics/FloatPoint.cpp:
      (WebCore::FloatPoint::dump):
      * platform/graphics/FloatPoint.h:
      * platform/graphics/FloatRect.cpp:
      (WebCore::FloatRect::dump):
      * platform/graphics/FloatRect.h:
      * platform/graphics/FloatSize.cpp:
      (WebCore::FloatSize::dump):
      * platform/graphics/FloatSize.h:
      * platform/graphics/IntPoint.h:
      (WebCore::IntPoint::dump):
      * platform/graphics/IntRect.cpp:
      (WebCore::IntRect::dump):
      * platform/graphics/IntRect.h:
      * platform/graphics/IntSize.h:
      (WebCore::IntSize::dump):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153952 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9dc6063
    • commit-queue@webkit.org's avatar
      Broken build with build-webkit --no-webgl · 0cfa14e1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119272
      
      Patch by Ragner Magalhaes <ranger.n@samsung.com> on 2013-08-12
      Reviewed by Alexandru Chiculita.
      
      CSS_SHADERS requires WEBGL enabled.
      Add error message to dependency failure.
      
      * wtf/FeatureDefines.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cfa14e1
    • joepeck@webkit.org's avatar
      [iOS] isMainThread implementation with USE(WEB_THREAD) · aab0d877
      joepeck@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119644
      
      Reviewed by Benjamin Poulain.
      
      On iOS isMainThread() means that the current thread is either the
      MainThread or WebThread and the current thread has the WebThreadLock.
      
      * wtf/ios/WebCoreThread.cpp: Added.
      * wtf/ios/WebCoreThread.h: Added.
      * wtf/mac/MainThreadMac.mm:
      (WTF::isMainThread):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153950 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aab0d877
    • commit-queue@webkit.org's avatar
      [Qt] [WebKit2] Remove duplicate RAM Size calculation and reuse WTF::ramSize() · 38fb1d32
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119663
      
      Patch by Arunprasad Rajkumar <arurajku@cisco.com> on 2013-08-12
      Reviewed by Sam Weinig.
      
      * WebProcess/qt/WebProcessQt.cpp:
      (WebKit::WebProcess::platformSetCacheModel):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153949 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38fb1d32
    • dino@apple.com's avatar
      Shadows don't support viewport units · 21d890ba
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119649
      
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      We don't yet support viewport units in shadows, so
      fail parsing if we see one. The bug to fix this
      completely is: https://webkit.org/b/119650
      
      Test: fast/css/shadow-viewport-units.html
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::parseShadow): Fail if we get one of
      vh, vw, vmin, vmax.
      
      LayoutTests:
      
      Test that exercises a viewport unit in text-shadow to make sure we don't parse it.
      
      * fast/css/shadow-viewport-units-expected.txt: Added.
      * fast/css/shadow-viewport-units.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153948 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      21d890ba
    • commit-queue@webkit.org's avatar
      [GTK] Don't load GAIL when using GTK 3.2 or greater · 245c5c50
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=72735
      
      Patch by Anton Obzhirov <a.obzhirov@samsung.com> on 2013-08-12
      Reviewed by Carlos Garcia Campos.
      
      Source/WebKit/gtk:
      
      * tests/testatk.c:
      (initializeTestingFramework):
      (main):
      
      Source/WebKit2:
      
      * UIProcess/API/gtk/tests/AccessibilityTestServer.cpp:
      (main):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153947 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      245c5c50
    • commit-queue@webkit.org's avatar
      [Curl] Cookie is not set when url string is unicode. · 7eda727a
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119545
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-08-12
      Reviewed by Brent Fulgham.
      
      When the method setCookiesFromDOM is called with an unicode url parameter, the cookie is not correctly set.
      We need to convert the cookie string to 8 bit, before passing it to the Curl api function.
      
      * platform/network/curl/CookieJarCurl.cpp:
      (WebCore::setCookiesFromDOM): Convert cookie string to 8 bit, if needed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153946 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7eda727a
    • eric.carlson@apple.com's avatar
      Revert r153912 because it broke some track tests. · ab4e1e61
      eric.carlson@apple.com authored
      Rubber-stamped by Antti Koivisto.
      
      * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
      (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
      (WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153945 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab4e1e61
    • commit-queue@webkit.org's avatar
      [Curl] Crash when starting second download. · 611e3f9b
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119620
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-08-12
      Reviewed by Brent Fulgham.
      
      When a second download is started, a crash sometimes occurs in Curl.
      This happens because the Curl easy handle is deleted and removed from the Curl multi handle twice.
      This is solved by adding an array to keep track of active downloads to avoid double deletion.
      
      * platform/network/curl/CurlDownload.cpp:
      (WebCore::CurlDownloadManager::CurlDownloadManager): Removed active download count member.
      (WebCore::CurlDownloadManager::getActiveDownloadCount): Use active download array to return active download count.
      (WebCore::CurlDownloadManager::updateHandleList): Remove Curl handles before adding, in case Curl reuses handles.
      (WebCore::CurlDownloadManager::addToCurl): Add Curl handle to active download array.
      (WebCore::CurlDownloadManager::removeFromCurl): Check if Curl handle is in active download array to avoid double deletion.
      (WebCore::CurlDownloadManager::downloadThread): Removed active download count member.
      * platform/network/curl/CurlDownload.h: Added array of active downloads member, and removed download count member.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153944 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      611e3f9b
    • commit-queue@webkit.org's avatar
      [Win] TestWebKitAPI fails to link. · afe8c58f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119619
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-08-12
      Reviewed by Brent Fulgham.
      
      * WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Export needed symbol.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153943 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afe8c58f
    • antti@apple.com's avatar
      Add ElementTraversal::next/previousSibling · 7419d278
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119681
      
      Reviewed by Andreas Kling.
      
      Add nextSibling/previousSibling/lastWithin to ElementTraversal namespace.
              
      - Use them to replace internal use of Element::next/previousElementSibling DOM API for traversal.
      - Replace some Node::nextSibling() usage with ElementTraversal::nextSibling() for tighter code.
      - Replace ElementTraversal::nextSkippingChildren where it is used to traverse over immediate children only.
      
      * css/SelectorChecker.cpp:
      (WebCore::isFirstChildElement):
      (WebCore::isLastChildElement):
      (WebCore::isFirstOfType):
      (WebCore::isLastOfType):
      (WebCore::countElementsBefore):
      (WebCore::countElementsOfTypeBefore):
      (WebCore::countElementsAfter):
      (WebCore::countElementsOfTypeAfter):
      * dom/Element.cpp:
      (WebCore::Element::lastElementChild):
      (WebCore::Element::previousElementSibling):
      (WebCore::Element::nextElementSibling):
      * dom/Element.h:
      * dom/ElementTraversal.h:
      (WebCore::ElementTraversal::lastElementWithinTemplate):
      (WebCore::ElementTraversal::lastWithin):
      (WebCore::ElementTraversal::traverseNextSiblingElementTemplate):
      (WebCore::ElementTraversal::nextSibling):
      (WebCore::ElementTraversal::traversePreviousSiblingElementTemplate):
      (WebCore::ElementTraversal::previousSibling):
      * editing/ApplyStyleCommand.cpp:
      (WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan):
      (WebCore::ApplyStyleCommand::cleanupUnstyledAppleStyleSpans):
      * editing/CompositeEditCommand.cpp:
      (WebCore::CompositeEditCommand::breakOutOfEmptyListItem):
      * editing/IndentOutdentCommand.cpp:
      (WebCore::IndentOutdentCommand::tryIndentingAsListItem):
      * editing/InsertListCommand.cpp:
      (WebCore::InsertListCommand::mergeWithNeighboringLists):
      * editing/markup.cpp:
      (WebCore::createContextualFragment):
      * html/HTMLCollection.cpp:
      (WebCore::firstMatchingChildElement):
      (WebCore::nextMatchingSiblingElement):
      (WebCore::HTMLCollection::traverseNextElement):
      (WebCore::HTMLCollection::traverseForwardToOffset):
      * html/HTMLFieldSetElement.cpp:
      (WebCore::HTMLFieldSetElement::childrenChanged):
      (WebCore::HTMLFieldSetElement::legend):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::finishParsingChildren):
      * html/HTMLObjectElement.cpp:
      (WebCore::HTMLObjectElement::containsJavaApplet):
      * rendering/FilterEffectRenderer.cpp:
      (WebCore::FilterEffectRenderer::buildReferenceFilter):
      * style/StyleResolveTree.cpp:
      (WebCore::Style::resolveTree):
      * svg/SVGStyledElement.cpp:
      (WebCore::SVGStyledElement::title):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153942 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7419d278
    • allan.jensen@digia.com's avatar
      [Qt] Add Support for canvas blend modes · 993adc62
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=100072
      
      Reviewed by Jocelyn Turcotte.
      
      Source/WebCore:
      
      Implement basic support for the blend-modes supported by QPainter.
      
      Covered by existing tests.
      
      * platform/graphics/qt/GraphicsContextQt.cpp:
      (WebCore::toQtCompositionMode):
      (WebCore::GraphicsContext::setPlatformCompositeOperation):
      * platform/graphics/qt/ImageBufferQt.cpp:
      (WebCore::ImageBuffer::draw):
      * platform/graphics/qt/ImageQt.cpp:
      (WebCore::BitmapImage::draw):
      * platform/graphics/qt/StillImageQt.cpp:
      (WebCore::StillImage::draw):
      
      LayoutTests:
      
      Unskip tests that now passes.
      
      * platform/qt/TestExpectations:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153941 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      993adc62
    • zarvai@inf.u-szeged.hu's avatar
      Buildfix for !ENABLE(SVG). Fix warning by adding guard after r153901: · cf265d43
      zarvai@inf.u-szeged.hu authored
      void WebCore::addString(WebCore::FeatureSet&, const char*)'
      defined but not used [-Werror=unused-function]
      
      Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-08-12
      Reviewed by Csaba Osztrogonác.
      
      * dom/DOMImplementation.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153940 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf265d43
    • antti@apple.com's avatar
      Move ElementTraversal to ElementTraversal.h · 9b3887b9
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119678
      
      Rubber-stamped by Andreas Kling.
      
      Move ElementTraversal namespace from NodeTraversal.h to a correctly named file.
      
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.xcodeproj/project.pbxproj:
      * accessibility/AccessibilityRenderObject.cpp:
      * css/StyleInvalidationAnalysis.cpp:
      * dom/Document.cpp:
      * dom/DocumentOrderedMap.cpp:
      * dom/Element.cpp:
      * dom/ElementTraversal.h: Added.
      (WebCore::ElementTraversal::firstElementWithinTemplate):
      (WebCore::ElementTraversal::firstWithin):
      (WebCore::ElementTraversal::traverseNextElementTemplate):
      (WebCore::ElementTraversal::next):
      (WebCore::ElementTraversal::traverseNextElementSkippingChildrenTemplate):
      (WebCore::ElementTraversal::nextSkippingChildren):
      (WebCore::ElementTraversal::previousIncludingPseudo):
      (WebCore::ElementTraversal::nextIncludingPseudo):
      (WebCore::ElementTraversal::nextIncludingPseudoSkippingChildren):
      (WebCore::ElementTraversal::pseudoAwarePreviousSibling):
      * dom/Node.cpp:
      * dom/NodeTraversal.h:
      * dom/SelectorQuery.cpp:
      * dom/TreeScope.cpp:
      * dom/VisitedLinkState.cpp:
      * editing/FrameSelection.cpp:
      * editing/markup.cpp:
      * html/HTMLCollection.cpp:
      * html/HTMLFieldSetElement.cpp:
      * html/HTMLFormElement.cpp:
      * html/HTMLLabelElement.cpp:
      * html/HTMLLegendElement.cpp:
      * html/HTMLMapElement.cpp:
      * html/HTMLObjectElement.cpp:
      * html/HTMLSelectElement.cpp:
      * html/shadow/ContentDistributor.cpp:
      * page/FocusController.cpp:
      * rendering/RenderCounter.cpp:
      * rendering/RenderListItem.cpp:
      * svg/SVGSVGElement.cpp:
      * svg/SVGStyledElement.cpp:
      * svg/SVGUseElement.cpp:
      * svg/animation/SMILTimeContainer.cpp:
      * svg/graphics/SVGImage.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153939 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b3887b9
    • antti@apple.com's avatar
      Move some Document recalcStyle code to StyleResolveTree · 037e4c0a
      antti@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119676
      
      Reviewed by Andreas Kling.
      
      Move the code that resolves the document and child styles to Style::resolveTree(Document*).
      
      * dom/Document.cpp:
      (WebCore::Document::recalcStyle):
      * style/StyleResolveTree.cpp:
      (WebCore::Style::resolveTree):
      * style/StyleResolveTree.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153938 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      037e4c0a
    • allan.jensen@digia.com's avatar
      Resource leak related to gstreamer and videos · 9f800d94
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=109350
      
      Reviewed by Eric Carlson.
      
      Since active DOM object are only stopped once and can not be restarted, we can
      unreference the media player there, instead of waiting for garbage collection.
      
      If the r152778 is rolled back, this also breaks a circular reference between
      GStreamer and WebKit which prevented garbage collecting from triggering.
      
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::stop):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f800d94
    • rgabor@webkit.org's avatar
      [Qt] Unreviewed buildfix for webaudio. · d29d8009
      rgabor@webkit.org authored
      * Target.pri: Add missing files
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d29d8009
    • akling@apple.com's avatar
      More Windows build juice. · 9cb4e767
      akling@apple.com authored
      * WebView.cpp:
      (WebView::notifyPreferencesChanged):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153935 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9cb4e767
    • akling@apple.com's avatar
      Some build juice for the Windows bots after r153926 + r153927. · a8b7bd1f
      akling@apple.com authored
      * html/shadow/MediaControlElements.cpp:
      * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
      (WebCore::MediaPlayerPrivateQuickTimeVisualContext::supportsFullscreen):
      (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153934 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8b7bd1f
    • zarvai@inf.u-szeged.hu's avatar
      [Qt] Unreviewed gardening. Rebaselining after r153903. · 20b51603
      zarvai@inf.u-szeged.hu authored
      * platform/qt-5.0-wk1/fast/loader/main-document-url-for-non-http-loads-expected.txt: Added.
      * platform/qt-5.0-wk1/http/tests/cache/iframe-304-crash-expected.txt: Added.
      * platform/qt-5.0-wk1/http/tests/loading/307-after-303-after-post-expected.txt: Added.
      * platform/qt-5.0-wk1/http/tests/loading/redirect-methods-expected.txt: Added.
      * platform/qt-5.0-wk1/http/tests/misc/favicon-loads-with-images-disabled-expected.txt: Added.
      * platform/qt-5.0-wk1/http/tests/security/XFrameOptions/x-frame-options-allowall-expected.txt: Added.
      * platform/qt-5.0-wk1/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt: Added.
      * platform/qt-5.0-wk1/http/tests/security/XFrameOptions/x-frame-options-invalid-expected.txt: Added.
      * platform/qt-5.0-wk1/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt: Added.
      * platform/qt-5.0-wk1/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-allow-expected.txt: Added.
      * platform/qt-5.0-wk2/compositing/geometry/preserve-3d-switching-expected.txt:
      * platform/qt-5.0-wk2/http/tests/misc/will-send-request-returns-null-on-redirect-expected.txt:
      * platform/qt-5.0-wk2/http/tests/misc/window-dot-stop-expected.txt:
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt:
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
      * platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
      * platform/qt-5.0-wk2/loader/go-back-cached-main-resource-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153933 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20b51603
    • g.czajkowski@samsung.com's avatar
      Update spellcheck-attribute.html description. · 1f47034f
      g.czajkowski@samsung.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119486
      
      Reviewed by Ryosuke Niwa.
      
      r70512 r72782 added new fields to spellcheck-attribute.html to verify
      spellcheck attribute.
      Update the test to be more descriptive by dumping additional information
      whether the misspelled word should be marked or not.
      
      * editing/spelling/spellcheck-attribute-expected.txt:
      * editing/spelling/spellcheck-attribute.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153932 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1f47034f
  2. 11 Aug, 2013 5 commits
    • weinig@apple.com's avatar
      Move RenderMathMLSpace.h/cpp to the right group in the Xcode project. · 9b4fd1f8
      weinig@apple.com authored
      Reviewed by Dean Jackson.
      
      * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b4fd1f8
    • dino@apple.com's avatar
      Update localizedStrings - I think I checked in an unmerged version · b6b472c0
      dino@apple.com authored
      in the previous commit.
      
      * Localizations/en.lproj/localizedStrings.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153929 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6b472c0
    • dino@apple.com's avatar
      Bootstrap canvas profiler · 31858a66
      dino@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=119652
      <rdar://problem/14703665>
      
      Reviewed by Joseph Pecoraro.
      
      Add enough to get an empty Canvas profile recording
      and displayed.
      
      * Localizations/en.lproj/localizedStrings.js: Add canvas strings.
      * UserInterface/CanvasProfileObject.js: Added. Mostly copied from CSS Selector Profiles.
      * UserInterface/CanvasProfileType.js: Added. Ditto.
      * UserInterface/CanvasDataGridNode.js: Added. Ditto.
      * UserInterface/CanvasProfileView.js: Added. Ditto.
      * UserInterface/ContentView.js:
      (WebInspector.ContentView): Add support for the new View type.
      (WebInspector.ContentView.isViewable):
      * UserInterface/InstrumentSidebarPanel.js:
      (WebInspector.InstrumentSidebarPanel): Add support for canvas profiles.
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedOver):
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedDown):
      (WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphClicked):
      (WebInspector.InstrumentSidebarPanel.prototype._profileTypeWasSelected):
      (WebInspector.InstrumentSidebarPanel.prototype._profilesCleared):
      * UserInterface/Main.html: Load the new files.
      * UserInterface/ProfileManager.js: New methods and support for canvas profiles.
      (WebInspector.ProfileManager):
      (WebInspector.ProfileManager.prototype.initialize):
      (WebInspector.ProfileManager.prototype.isProfilingCanvas):
      (WebInspector.ProfileManager.prototype.startProfilingCanvas):
      (WebInspector.ProfileManager.prototype.stopProfilingCanvas):
      (WebInspector.ProfileManager.prototype._checkForInterruptions):
      (WebInspector.ProfileManager.prototype._attemptToResumeProfiling):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153928 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31858a66
    • akling@apple.com's avatar
      Make Page::settings() return a reference. · ff5990f3
      akling@apple.com authored
      <http://webkit.org/b/119662>
      
      Reviewed by Anders Carlsson.
      
      ...and remove some pointless null checks that were exposed by doing this.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff5990f3
    • akling@apple.com's avatar
      Make some things that return never-null pointers return references instead. · ad1137cb
      akling@apple.com authored
      <http://webkit.org/b/119660>
      
      Reviewed by Antti Koivisto.
      
      Source/WebCore:
      
      These functions never return null anyway, so remove any ambiguity by letting
      them return references instead of pointers.
      
      - Node::ensureRareData()
      - Element::ensureUniqueElementData()
      - Element::ensureShadow()
      - Element::ensureUserAgentShadowRoot()
      - StyledElement::ensureMutableInlineStyle()
      - NodeRareData::ensureNodeLists()
      - NodeRareData::ensureMutationObserverData()
      - EventTarget::ensureEventTargetData()
      - Document::ensureStyleResolver()
      - Document::selectorQueryCache()
      - Document::mediaQueryMatcher()
      - FlowThreadController::ensureRenderFlowThreadWithName()
      - HTMLTrackElement::ensureTrack()
      - SVGElement::ensureSVGRareData()
      - AnimationControllerPrivate::ensureCompositeAnimation()
      
      Source/WebKit/qt:
      
      * Api/qwebelement.cpp:
      (QWebElement::styleProperty):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad1137cb