GitLab

https://bugs.webkit.org/show_bug.cgi?id=66323

Patch by Rafael Antognolli <antognolli@profusion.mobi> on 2011-09-09
Reviewed by Martin Robinson.

This file will be used by the EFL port too, and since it's not GTK
specific anymore, rename it to something better.

No new functionality so no new tests.

* GNUmakefile.list.am:
* platform/graphics/pango/FontPango.cpp: Renamed from Source/WebCore/platform/graphics/gtk/FontGtk.cpp.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/gtk/css2.1/t090204-display-change-01-b-ao-expected.txt:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Build fix: Guard against double-#define for something already #defined
        by the build system.

        * wtf/Platform.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dan Bernstein.

        Never #define ENABLE_SINGLE_THREADED, !ENABLE_JSC_MULTIPLE_THREADS, or
        !ENABLE_WTF_MULTIPLE_THREADS
        https://bugs.webkit.org/show_bug.cgi?id=67860

        First step toward making the baseline platform assumption that threads
        exist: Never #define ENABLE_SINGLE_THREADED, !ENABLE_JSC_MULTIPLE_THREADS,
        or !ENABLE_WTF_MULTIPLE_THREADS.

        * wtf/Platform.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67820

Reviewed by Darin Adler.

Silences valgrind warning reported in http://crbug.com/76490.

No new tests since this would only very occasionally be flaky,
and in the codepath in the valgrind report, the ec is ignored anyway.

* dom/Element.cpp:
(WebCore::Element::removeAttribute): Initialize ec to 0.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67855

Reviewed by Dirk Pranke.

The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.

Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67853

Reviewed by Darin Adler.

* Scripts/webkitpy/common/config/committers.py:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67814

Reviewed by Andreas Kling.

.:

* Source/WebKit.pri: Move rules from common.pri to WebKit.pri.
* Source/common.pri: Removed.

Source/JavaScriptCore:

* JavaScriptCore.pri:

Source/WebCore:

No new tests, no change in functionality.

* CodeGenerators.pri:
* WebCore.pri:

Tools:

* Tools.pro:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium-linux/fast/lists/list-marker-before-content-table-expected.png: Added.
* platform/chromium-linux/fast/runin/runin-generated-before-content-expected.png: Added.
* platform/chromium-win-xp/fast/lists: Removed.
* platform/chromium-win/fast/lists/list-marker-before-content-table-expected.png: Added.
* platform/chromium-win/fast/runin/runin-generated-before-content-expected.png: Added.
* platform/gtk/fast/lists/list-marker-before-content-table-expected.txt: Added.
* platform/gtk/fast/runin/runin-generated-before-content-expected.txt: Added.
* platform/mac/fast/lists/list-marker-before-content-table-expected.txt: Added.
* platform/mac/fast/runin/runin-generated-before-content-expected.txt: Added.
* platform/qt/fast/lists/list-marker-before-content-table-expected.txt: Added.
* platform/qt/fast/runin/runin-generated-before-content-expected.txt: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=61805

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-09
Reviewed by Chris Fleizach.

Fix nextSibling and previousSibling to handle adjacent continuations
properly, otherwise nodes end up appearing in the accessibility
tree twice (or a debug assertion could be raised).

Test: accessibility/adjacent-continuations-cause-assertion-failure.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::previousSibling):
(WebCore::AccessibilityRenderObject::nextSibling):

LayoutTests: Add a test to catch a case where adjacent continuations were
causing nodes to get added to the accessibility tree twice, leading
to an assertion failure or a crash. The test expectations are
currently Mac-specific, so added the test to the Skipped file for
gtk and win.
https://bugs.webkit.org/show_bug.cgi?id=61805

Patch by Dominic Mazzoni <dmazzoni@google.com> on 2011-09-09
Reviewed by Chris Fleizach.

* accessibility/adjacent-continuations-cause-assertion-failure.html: Added.
* platform/mac/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67835

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-09
Reviewed by Tony Chang.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67590

Patch by Hao Zheng <zhenghao@chromium.org> on 2011-09-09
Reviewed by Tony Chang.

Source/WebKit/chromium:

Exclude Android specific files of DRT from other platforms.

* WebKit.gyp:

Tools:

Add 2 mechanism to make DRT interaction more robust on Android:
- Send 'QUIT' to DRT to make it stop.
- Wait until receiving '#READY' from DRT, so that DRT won't miss any
input commands before it starts.
And LayoutTestController.cpp needs to include <cctype> for 'tolower'
and <clocale> for 'LC_ALL' to compile on Android.

Also change to use sigaction instead of signal for TestShellGtk.cpp,
as signal() man page recommends using sigaction().

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* DumpRenderTree/chromium/LayoutTestController.cpp:
* DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
(AlarmHandler):
(TestShell::waitTestFinished):
(platformInit):
(openStartupDialog):
(checkLayoutTestSystemDependencies):
* DumpRenderTree/chromium/TestShellGtk.cpp:
(AlarmHandler):
(TestShell::waitTestFinished):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67825

Source/WebCore:

Patch by Kentaro Hara <haraken@google.com> on 2011-09-08
Reviewed by Sam Weinig.

There is no spec for the WebKitAnimationEvent constructor
since it is WebKit-specific. However, based on the current
IDL of initWebKitAnimationEvent(), the constructor IDL
should be as follows.

[Constructor(DOMString type, optional WebKitAnimationEventInit eventInitDict)]
interface WebKitAnimationEvent : Event {
    ...;
}

dictionary WebKitAnimationEventInit : EventInit {
    DOMString animationName;
    double elapsedTime;
}

Test: fast/events/constructors/webkit-animation-event-constructor.html

* bindings/generic/EventConstructors.h: Added a definition for the WebKitAnimationEvent constructor.
* bindings/js/JSEventConstructors.cpp: Added #includes for WebKitAnimationEvent.
* dom/WebKitAnimationEvent.cpp:
(WebCore::WebKitAnimationEventInit::WebKitAnimationEventInit):
(WebCore::WebKitAnimationEvent::WebKitAnimationEvent):
* dom/WebKitAnimationEvent.h: Added a definition for WebKitAnimationEventInit.
(WebCore::WebKitAnimationEvent::create):
* dom/WebKitAnimationEvent.idl: Makes WebKitAnimationEvent constructible.

LayoutTests:

Checks the behavior of the WebKitAnimationEvent constructor.

Patch by Kentaro Hara <haraken@google.com> on 2011-09-08
Reviewed by Sam Weinig.

* fast/dom/constructed-objects-prototypes-expected.txt:
* fast/events/constructors/webkit-animation-event-constructor-expected.txt: Added.
* fast/events/constructors/webkit-animation-event-constructor.html: Added.
* platform/chromium/test_expectations.txt: Skipped webkit-animation-event-constructor.html, since V8 does not yet have the WebKitAnimationEvent constructor.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/qt/fast/lists/list-marker-before-content-table-expected.png: Added.
* platform/qt/fast/lists/list-marker-before-content-table-expected.txt: Added.
* platform/qt/fast/runin/runin-generated-before-content-expected.png: Added.
* platform/qt/fast/runin/runin-generated-before-content-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67584

Patch by Hao Zheng <zhenghao@chromium.org> on 2011-09-09
Reviewed by Steve Block.

Make src/PlatformSupport.cpp and src/WebFrameImpl.cpp compile on
Chromium port for Android.

* WebKit.gyp:
* public/android: Added.
* public/android/WebSandboxSupport.h: Added.
* public/android/WebThemeEngine.h: Added.
(WebKit::WebThemeEngine::getSize):
(WebKit::WebThemeEngine::paint):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::getFontFamilyForCharacters):
(WebCore::PlatformSupport::getRenderStyleForStrike):
* src/WebFrameImpl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67735

Source/WebCore: 

1) Remove the isAnonymous checks for run-in detection since the
run-in can belong to a node.
2) When the parent has block children, then the list marker will
be enclosed in an anonymous block. In that case, for going to the
next list marker, we need to traverse one level up. We don't need
this check when searching for generated run-in (loop 2), since we
know parent will have inline children, so the list marker wont be
enclosed in an anonymous block.

Reviewed by Dave Hyatt.

Tests: fast/lists/list-marker-before-content-table.html
       fast/runin/runin-generated-before-content.html

* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::beforePseudoElementRenderer):

LayoutTests: 

Reviewed by Dave Hyatt.

* fast/lists/list-marker-before-content-table-expected.png: Added.
* fast/lists/list-marker-before-content-table-expected.txt: Added.
* fast/lists/list-marker-before-content-table.html: Added.
* fast/runin/runin-generated-before-content-expected.png: Added.
* fast/runin/runin-generated-before-content-expected.txt: Added.
* fast/runin/runin-generated-before-content.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Chromium leopard css3 baselines, and new mac gpu baselines.

        * platform/chromium-cg-mac-leopard/css3: Added.
        * platform/chromium-cg-mac-leopard/css3/bdi-element-expected.png: Added.
        * platform/chromium-cg-mac-leopard/css3/bdi-element-expected.txt: Added.
        * platform/chromium-cg-mac-leopard/css3/unicode-bidi-isolate-aharon-expected.png: Added.
        * platform/chromium-cg-mac-leopard/css3/unicode-bidi-isolate-basic-expected.png: Added.
        * platform/chromium-gpu-cg-mac/platform/chromium/compositing/zoom-animator-scale-test-expected.png: Added.
        * platform/chromium-gpu-win/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Removed.
        * platform/chromium-gpu/platform/chromium/compositing/zoom-animator-scale-test-expected.txt: Added.
        * platform/chromium/test_expectations.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67838

SourceFrame should not deal with JavaScript debugging since it is a base class for all source frame implementations.

Reviewed by Pavel Feldman.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/JavaScriptSourceFrame.js: Added.
(WebInspector.JavaScriptSourceFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel): moved from ScriptsPanel.js
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggingSupported):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.canEditScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSource):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setScriptSourceIsBeingEdited):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.debuggerPaused):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.evaluateInSelectedCallFrame):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.releaseEvaluationResult):
(WebInspector.SourceFrameDelegateForScriptsPanel.prototype.suggestedFileName):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Added reference images.

* platform/chromium-gpu-mac: Added.
(remaining files omitted for brevity)


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/94851
https://bugs.webkit.org/show_bug.cgi?id=67847

It broke a webkitpy test (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-09

* Scripts/webkitpy/layout_tests/controllers/manager.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=62464

Enclosing an element means wrapping something around an element,
not inserting something into an element. Therefore we need to check
if the parent of the element allows insertion rather than checking
the element itself.

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-09-09
Reviewed by Andreas Kling.

* Api/qwebelement.cpp:
(QWebElement::prependOutside):
(QWebElement::appendOutside):
(QWebElement::encloseWith):
* tests/qwebelement/tst_qwebelement.cpp:
(tst_QWebElement::appendAndPrepend):
(tst_QWebElement::encloseWith):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67835

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-09
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/layout_tests/controllers/manager.py:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-09

* platform/qt/css3/bdi-element-expected.png: Added.
* platform/qt/css3/bdi-element-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugzilla.gnome.org/show_bug.cgi?id=610152

Patch by Tiffany Antopolski  <tiffany@antopolski.com> on 2011-09-09
Reviewed by Gustavo Noronha.

* en_CA.po: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67842

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2011-09-09

* platform/qt/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Patch by Martin Kosiba <mkosiba@chromium.org> on 2011-09-09
Reviewed by Darin Fisher.

* public/WebNode.h:
* src/WebNode.cpp:
(WebKit::WebNode::isLink):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/94845
https://bugs.webkit.org/show_bug.cgi?id=67839

This patch kicked Qt-SL bots, but we don't need this
modification. (Requested by ossy_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-09

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
* platform/mac/WebVideoFullscreenController.mm:
* platform/mac/WebVideoFullscreenHUDWindowController.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67799

It seems these files didn't rebuilt because of a
dependency bug. Touch them to trigger a rebuild.

* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
* platform/mac/WebVideoFullscreenController.mm:
* platform/mac/WebVideoFullscreenHUDWindowController.mm:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: [Chromium] Valgrind signals use of uninitialized field in InspectorStyleSheetForInlineStyle
https://bugs.webkit.org/show_bug.cgi?id=67837

* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/94536
https://bugs.webkit.org/show_bug.cgi?id=67836

breaks absoluteLocation() of RelatedMouseEvent (Requested by
jknotten on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-09

Source/WebCore:

* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):

LayoutTests:

* fast/events/page-scaled-mouse-click-expected.txt: Removed.
* fast/events/page-scaled-mouse-click.html: Removed.
* fast/events/script-tests/page-scaled-mouse-click.js: Removed.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=65962

Source/WebCore:

Add the "Edit" button to SourceFrame, so that resources/scripts can be edited both in the
Resources and the Scripts panels. The button is grayed out if the resource/script is not editable.

Reviewed by Yury Semikhatsky.

* inspector/front-end/Images/statusbarButtonGlyphs.png:
* inspector/front-end/ResourceView.js:
(WebInspector.EditableResourceSourceFrame.prototype.canEditSource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.get statusBarItems):
(WebInspector.ScriptsPanel.prototype.set visibleView):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.get statusBarItems):
(WebInspector.SourceFrame.prototype._initializeTextViewer):
(WebInspector.SourceFrame.prototype._editButtonClicked):
(WebInspector.SourceFrame.prototype.canEditSource):
(WebInspector.SourceFrame.prototype.startEditing):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype._setReadOnly):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.doubleClick):
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype.set readOnly):
(WebInspector.TextEditorMainPanel.prototype._updateSelectionOnStartEditing):
* inspector/front-end/inspector.css:
(button.edit-source-status-bar-item .glyph):
(button.edit-source-status-bar-item.toggled-on .glyph):

LayoutTests:

Reviewed by Yury Semikhatsky.

* inspector/debugger/scripts-panel.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67767

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-09
Reviewed by Darin Adler.

Source/WebCore:

In CompositeEditCommand::closeParagraphUnderNewElement(), lastNode could be a non Element node.
The current code assumes lastNode is an Element node. This patch checks it.

Test: editing/execCommand/ident-crashes-topnode-is-text.html

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::cloneParagraphUnderNewElement): Added an element node check.

LayoutTests:

Added a crash test case.

* editing/execCommand/ident-crashes-topnode-is-text-expected.txt: Added.
* editing/execCommand/ident-crashes-topnode-is-text.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67765

Patch by Shinya Kawanaka <shinyak@google.com> on 2011-09-09
Reviewed by Ryosuke Niwa.

WebCore::enclosingBlock may return null, but ApplyStyleCommand::applyBlockStyle did not check it. This patch make it to be checked.

Source/WebCore:

Test: editing/style/remove-format-without-enclosing-block.html

* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyBlockStyle): Added null check.

LayoutTests:

* editing/style/remove-format-without-enclosing-block-expected.txt: Added.
* editing/style/remove-format-without-enclosing-block.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed. Update test expectations for hyphenate-limit-lines.html.

        * platform/chromium/test_expectations.txt:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67815

Reviewed by Adam Barth.

Test: fast/css/font-face-opentype.html under valgrind

* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
* platform/graphics/skia/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed, remove wrong chromium expectations for hyphenate-limit-lines.html and mark the test as failing IMAGE+TEXT.

        I rebaselined the expectations yesterday but actualy Chromium doesn't support hyphenation yet.
        See CR47083. 

        * platform/chromium-cg-mac/fast/text/hyphenate-limit-lines-expected.png: Removed.
        * platform/chromium-linux/fast/text/hyphenate-limit-lines-expected.png: Removed.
        * platform/chromium-mac/fast/text/hyphenate-limit-lines-expected.png: Removed.
        * platform/chromium-win/fast/text/hyphenate-limit-lines-expected.png: Removed.
        * platform/chromium-win/fast/text/hyphenate-limit-lines-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:




git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67742

Reviewed by Darin Adler.

Moved more code in HTMLInputElement::setValue to TextFieldInputType::setValue, and merged
InputType::valueChanged into InputType::setValue. Also introduced
InputType::dispatchChangeEventInResponseToSetValue to be overridden by TextFieldInputType.

* html/BaseButtonInputType.cpp:
(WebCore::BaseButtonInputType::setValue):
* html/BaseButtonInputType.h:
* html/BaseCheckableInputType.cpp:
(WebCore::BaseCheckableInputType::setValue):
* html/BaseCheckableInputType.h:
* html/ColorInputType.cpp:
* html/ColorInputType.h:
* html/FileInputType.cpp:
(WebCore::FileInputType::setValue):
* html/FileInputType.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue):
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::cacheSelectionInResponseToSetValue):
* html/HiddenInputType.cpp:
(WebCore::HiddenInputType::setValue):
* html/HiddenInputType.h:
* html/InputType.cpp:
(WebCore::InputType::setValue):
(WebCore::InputType::dispatchChangeEventInResponseToSetValue):
* html/InputType.h:
* html/RangeInputType.cpp:
(WebCore::RangeInputType::setValue):
* html/RangeInputType.h:
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::setValue):
(WebCore::TextFieldInputType::dispatchChangeEventInResponseToSetValue):
* html/TextFieldInputType.h:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=67829

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-08
Reviewed by Sam Weinig.

Fixing a couple tests that were broken due to the wrong values being 
set in the parent class pointers in the ClassInfo structs for 
TerminatedExecutionError and InterruptedExecutionError.

* runtime/ExceptionHelpers.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* platform/chromium/test_expectations.txt: chromium/compositing/zoom-animator-scale-test missing on leopard gpu

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@94834 268f45cc-cd09-0410-ab3c-d52691b4dbfc