1. 20 Nov, 2010 18 commits
    • rniwa@webkit.org's avatar
      2010-11-20 Ryosuke Niwa <rniwa@webkit.org> · b3e9317c
      rniwa@webkit.org authored
              Unreviewed rebaselines for r72482.
      
              Since Home/End behavior is different on Mac and GTK, move the expected result added by r72482
              to platform/mac and platform/gtk, and add new expected result for other platforms.
      
              See also: http://trac.webkit.org/changeset/54980 and https://webkit.org/b/35066.
      
              * editing/selection/extend-selection-home-end-expected.txt:
              * platform/chromium-win/editing/selection/extend-selection-expected.txt: Removed.
              * platform/chromium/test_expectations.txt: Removed extend-selection.html.
              * platform/gtk/Skipped: Ditto.
              * platform/gtk/editing/selection/extend-selection-expected.txt: Removed.
              * platform/gtk/editing/selection/extend-selection-home-end-expected.txt: Added.
              * platform/mac/editing/selection/extend-selection-home-end-expected.txt: Added.
              * platform/qt/Skipped: Removed extend-selection.html.
              * platform/win/editing/selection/extend-selection-expected.txt: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b3e9317c
    • commit-queue@webkit.org's avatar
      2010-11-20 Kwang Yul Seo <skyul@company100.net> · 3e647da2
      commit-queue@webkit.org authored
              Reviewed by David Kilzer.
      
              [BREWMP] Use std_wstrlen instead of WSTRLEN
              https://bugs.webkit.org/show_bug.cgi?id=49516
      
              WSTRLEN is prohibited in Mod1. Use std_wstrlen from AEEstd.h instead.
      
              * platform/text/brew/StringBrew.cpp:
              (WTF::String::String):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3e647da2
    • commit-queue@webkit.org's avatar
      2010-11-20 Kwang Yul Seo <skyul@company100.net> · b6005aca
      commit-queue@webkit.org authored
              Reviewed by David Kilzer.
      
              [BREWMP] Replace DBGPRINTF and DBGPRINTF_FATAL with dbg_Message
              https://bugs.webkit.org/show_bug.cgi?id=49520
      
              DBGPRINTF and DBGPRINTF_FATAL macros are prohibited in Mod1. Use dbg_Message instead.
      
              * wtf/Assertions.cpp:
              * wtf/Assertions.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6005aca
    • paroga@webkit.org's avatar
      2010-11-20 Patrick Gansterer <paroga@webkit.org> · b2cc12c3
      paroga@webkit.org authored
              Reviewed by David Kilzer.
      
              [WINCE] Implement textBreakLast and textBreakPrevious
              https://bugs.webkit.org/show_bug.cgi?id=49552
      
              This allows us to use TextBoundaries.cpp and remove TextBoundariesWinCE.cpp.
              Also unify the different TextBreakIterator::first() implementations.
      
              * platform/text/wince/TextBoundariesWinCE.cpp: Removed.
              * platform/text/wince/TextBreakIteratorWinCE.cpp:
              (WebCore::TextBreakIterator::first):
              (WebCore::TextBreakIterator::last):
              (WebCore::textBreakLast):
              (WebCore::textBreakPrevious):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2cc12c3
    • rniwa@webkit.org's avatar
      2010-11-19 Ryosuke Niwa <rniwa@webkit.org> · 7bf402a9
      rniwa@webkit.org authored
              Reviewed by Antonio Gomes.
      
              /editing/selection/extend-selection.html should be split into smaller tests
              https://bugs.webkit.org/show_bug.cgi?id=49849
      
              Divided the test into 4 pieces.
      
              * editing/selection/extend-selection-character-expected.txt: Added.
              * editing/selection/extend-selection-character.html: Added.
              * editing/selection/extend-selection-enclosing-block-expected.txt: Added.
              * editing/selection/extend-selection-enclosing-block.html: Added.
              * editing/selection/extend-selection-expected.txt: Removed.
              * editing/selection/extend-selection-home-end-expected.txt: Added.
              * editing/selection/extend-selection-home-end.html: Added.
              * editing/selection/extend-selection-word-expected.txt: Added.
              * editing/selection/extend-selection-word.html: Added.
              * editing/selection/extend-selection.html: Removed.
              * editing/selection/resources/extend-selection.css: Added.
              (div.test):
              (div.test:before):
              (div.test span):
              (div.test img):
              (div.test img + img):
              (div.test div):
              * editing/selection/resources/extend-selection.js: Added.
              (log):
              (positionsExtendingInDirectionForEnclosingBlock):
              (positionsExtendingInDirection):
              (fold):
              (logPositions):
              (checkReverseOrder):
              (checkSameOrder):
              (extendingSelection):
              (testExtendingSelection):
              (createTestNodes.window.onload):
              (createTestNodes):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7bf402a9
    • loki@webkit.org's avatar
      2010-11-20 Gabor Loki <loki@webkit.org> · 0f28f9b8
      loki@webkit.org authored
              Reviewed by Gavin Barraclough.
      
              Support JIT_OPTIMIZE_MOD on Thumb-2
              https://bugs.webkit.org/show_bug.cgi?id=49432
      
              Rewrite the soft modulo operation into macroassembler form, and move it
              to JSValue32_64 section.
              Add support for soft modulo on Thumb-2 JIT also.
      
              * assembler/ARMv7Assembler.h:
              (JSC::ARMv7Assembler::clz):
              * assembler/MacroAssemblerARM.h:
              (JSC::MacroAssemblerARM::countLeadingZeros32):
              (JSC::MacroAssemblerARM::relativeTableJump):
              * assembler/MacroAssemblerARMv7.h:
              (JSC::MacroAssemblerARMv7::countLeadingZeros32):
              (JSC::MacroAssemblerARMv7::relativeTableJump):
              * jit/JITArithmetic.cpp:
              (JSC::JIT::emit_op_mod):
              * jit/JITOpcodes.cpp:
              (JSC::JIT::privateCompileCTIMachineTrampolines):
              * jit/JITOpcodes32_64.cpp:
              (JSC::JIT::softModulo):
              * jit/JITStubs.cpp:
              (JSC::JITThunks::JITThunks):
              * wtf/Platform.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f28f9b8
    • jparent@chromium.org's avatar
      Unreviewed. Adding failing expectation for Win + Linux for new · 41f2812d
      jparent@chromium.org authored
      fast/canvas/canvas-fillPath-shadow test.
      
      * platform/chromium/test_expectations.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      41f2812d
    • andreas.kling@nokia.com's avatar
      2010-11-20 Andreas Kling <kling@webkit.org> · 6b93201a
      andreas.kling@nokia.com authored
              Reviewed by David Kilzer.
      
              Path: Remove unused method swap()
              https://bugs.webkit.org/show_bug.cgi?id=49853
      
              * platform/graphics/Path.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6b93201a
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/49867> MediaPlayerPrivateQTKit::setPreservesPitch(bool) leaks an NSDictionary · 64ac6332
      ddkilzer@apple.com authored
      Reviewed by Dan Bernstein.
      
      * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
      (WebCore::MediaPlayerPrivateQTKit::setPreservesPitch): Use
      RetainPtr<NSDictionary> for movieAttributes.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64ac6332
    • ddkilzer@apple.com's avatar
      <http://webkit.org/b/49848> Make it possible to display the last character of... · e82106be
      ddkilzer@apple.com authored
      <http://webkit.org/b/49848> Make it possible to display the last character of a secure text field unobscured
      
      Reviewed by Darin Adler.
      
      * JavaScriptCore.exp:
      * wtf/text/StringImpl.cpp:
      (WTF::StringImpl::secure): Added argument that controls whether
      the last character is obscured or not.  Implemented behavior.
      * wtf/text/StringImpl.h:
      (WTF::StringImpl::LastCharacterBehavior): Added enum.
      (WTF::StringImpl::secure): Updated method signature.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e82106be
    • paroga@webkit.org's avatar
      2010-11-20 Patrick Gansterer <paroga@webkit.org> · 480452bb
      paroga@webkit.org authored
              Reviewed by Andreas Kling.
      
              Use String::fromUTF8 instead of UTF8Encoding().decode
              in the libxml XMLDocumentParser
              https://bugs.webkit.org/show_bug.cgi?id=45488
      
              * dom/XMLDocumentParser.cpp:
              (WebCore::toString):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      480452bb
    • commit-queue@webkit.org's avatar
      2010-11-20 Sheriff Bot <webkit.review.bot@gmail.com> · d828eedd
      commit-queue@webkit.org authored
              Unreviewed, rolling out r72471.
              http://trac.webkit.org/changeset/72471
              https://bugs.webkit.org/show_bug.cgi?id=49865
      
              broke two IME tests on Qt (Requested by kling on #webkit).
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::inputMethodEvent):
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::inputMethods):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d828eedd
    • reni@webkit.org's avatar
      FilterPrimitives should have a pointer to its Filter object. · a11689df
      reni@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49863
      
      Reviewed by Dirk Schulze.
      
      FilterPrimitives should have a renderer, and they need a member pointer to their Filter objects for Layout() calls.
      This patch adds this member to FilterEffect.
      
      No new test is needed because these modifications are covered by all of SVG Filter tests.
      
      * platform/graphics/filters/FEBlend.cpp:
      (WebCore::FEBlend::FEBlend):
      (WebCore::FEBlend::create):
      (WebCore::FEBlend::apply):
      * platform/graphics/filters/FEBlend.h:
      * platform/graphics/filters/FEColorMatrix.cpp:
      (WebCore::FEColorMatrix::FEColorMatrix):
      (WebCore::FEColorMatrix::create):
      (WebCore::FEColorMatrix::apply):
      * platform/graphics/filters/FEColorMatrix.h:
      * platform/graphics/filters/FEComponentTransfer.cpp:
      (WebCore::FEComponentTransfer::FEComponentTransfer):
      (WebCore::FEComponentTransfer::create):
      (WebCore::FEComponentTransfer::apply):
      * platform/graphics/filters/FEComponentTransfer.h:
      * platform/graphics/filters/FEComposite.cpp:
      (WebCore::FEComposite::FEComposite):
      (WebCore::FEComposite::create):
      (WebCore::FEComposite::determineAbsolutePaintRect):
      (WebCore::FEComposite::apply):
      * platform/graphics/filters/FEComposite.h:
      * platform/graphics/filters/FEConvolveMatrix.cpp:
      (WebCore::FEConvolveMatrix::FEConvolveMatrix):
      (WebCore::FEConvolveMatrix::create):
      (WebCore::FEConvolveMatrix::apply):
      * platform/graphics/filters/FEConvolveMatrix.h:
      (WebCore::FEConvolveMatrix::determineAbsolutePaintRect):
      * platform/graphics/filters/FEDiffuseLighting.cpp:
      (WebCore::FEDiffuseLighting::FEDiffuseLighting):
      (WebCore::FEDiffuseLighting::create):
      * platform/graphics/filters/FEDiffuseLighting.h:
      * platform/graphics/filters/FEDisplacementMap.cpp:
      (WebCore::FEDisplacementMap::FEDisplacementMap):
      (WebCore::FEDisplacementMap::create):
      (WebCore::FEDisplacementMap::apply):
      * platform/graphics/filters/FEDisplacementMap.h:
      (WebCore::FEDisplacementMap::determineAbsolutePaintRect):
      * platform/graphics/filters/FEFlood.cpp:
      (WebCore::FEFlood::FEFlood):
      (WebCore::FEFlood::create):
      (WebCore::FEFlood::apply):
      * platform/graphics/filters/FEFlood.h:
      (WebCore::FEFlood::determineAbsolutePaintRect):
      * platform/graphics/filters/FEGaussianBlur.cpp:
      (WebCore::FEGaussianBlur::FEGaussianBlur):
      (WebCore::FEGaussianBlur::create):
      (WebCore::FEGaussianBlur::determineAbsolutePaintRect):
      (WebCore::FEGaussianBlur::apply):
      * platform/graphics/filters/FEGaussianBlur.h:
      * platform/graphics/filters/FELighting.cpp:
      (WebCore::FELighting::FELighting):
      (WebCore::FELighting::apply):
      * platform/graphics/filters/FELighting.h:
      (WebCore::FELighting::determineAbsolutePaintRect):
      * platform/graphics/filters/FEMerge.cpp:
      (WebCore::FEMerge::FEMerge):
      (WebCore::FEMerge::create):
      (WebCore::FEMerge::apply):
      * platform/graphics/filters/FEMerge.h:
      * platform/graphics/filters/FEMorphology.cpp:
      (WebCore::FEMorphology::FEMorphology):
      (WebCore::FEMorphology::create):
      (WebCore::FEMorphology::determineAbsolutePaintRect):
      (WebCore::FEMorphology::apply):
      * platform/graphics/filters/FEMorphology.h:
      * platform/graphics/filters/FEOffset.cpp:
      (WebCore::FEOffset::FEOffset):
      (WebCore::FEOffset::create):
      (WebCore::FEOffset::determineAbsolutePaintRect):
      (WebCore::FEOffset::apply):
      * platform/graphics/filters/FEOffset.h:
      * platform/graphics/filters/FESpecularLighting.cpp:
      (WebCore::FESpecularLighting::FESpecularLighting):
      (WebCore::FESpecularLighting::create):
      * platform/graphics/filters/FESpecularLighting.h:
      * platform/graphics/filters/FETile.cpp:
      (WebCore::FETile::FETile):
      (WebCore::FETile::create):
      (WebCore::FETile::apply):
      * platform/graphics/filters/FETile.h:
      (WebCore::FETile::determineAbsolutePaintRect):
      * platform/graphics/filters/FETurbulence.cpp:
      (WebCore::FETurbulence::FETurbulence):
      (WebCore::FETurbulence::create):
      (WebCore::FETurbulence::apply):
      * platform/graphics/filters/FETurbulence.h:
      (WebCore::FETurbulence::determineAbsolutePaintRect):
      * platform/graphics/filters/FilterEffect.cpp:
      (WebCore::FilterEffect::FilterEffect):
      (WebCore::FilterEffect::determineAbsolutePaintRect):
      (WebCore::FilterEffect::effectContext):
      * platform/graphics/filters/FilterEffect.h:
      (WebCore::FilterEffect::filter):
      * platform/graphics/filters/SourceAlpha.cpp:
      (WebCore::SourceAlpha::create):
      (WebCore::SourceAlpha::determineAbsolutePaintRect):
      (WebCore::SourceAlpha::apply):
      * platform/graphics/filters/SourceAlpha.h:
      (WebCore::SourceAlpha::SourceAlpha):
      * platform/graphics/filters/SourceGraphic.cpp:
      (WebCore::SourceGraphic::create):
      (WebCore::SourceGraphic::determineAbsolutePaintRect):
      (WebCore::SourceGraphic::apply):
      * platform/graphics/filters/SourceGraphic.h:
      (WebCore::SourceGraphic::SourceGraphic):
      * rendering/RenderSVGResourceFilter.cpp:
      (WebCore::RenderSVGResourceFilter::buildPrimitives):
      (WebCore::RenderSVGResourceFilter::applyResource):
      (WebCore::RenderSVGResourceFilter::postApplyResource):
      * rendering/RenderSVGResourceFilter.h:
      * rendering/SVGRenderTreeAsText.cpp:
      (WebCore::writeSVGResourceContainer):
      * svg/SVGFEBlendElement.cpp:
      (WebCore::SVGFEBlendElement::build):
      * svg/SVGFEBlendElement.h:
      * svg/SVGFEColorMatrixElement.cpp:
      (WebCore::SVGFEColorMatrixElement::build):
      * svg/SVGFEColorMatrixElement.h:
      * svg/SVGFEComponentTransferElement.cpp:
      (WebCore::SVGFEComponentTransferElement::build):
      * svg/SVGFEComponentTransferElement.h:
      * svg/SVGFECompositeElement.cpp:
      (WebCore::SVGFECompositeElement::build):
      * svg/SVGFECompositeElement.h:
      * svg/SVGFEConvolveMatrixElement.cpp:
      (WebCore::SVGFEConvolveMatrixElement::build):
      * svg/SVGFEConvolveMatrixElement.h:
      * svg/SVGFEDiffuseLightingElement.cpp:
      (WebCore::SVGFEDiffuseLightingElement::build):
      * svg/SVGFEDiffuseLightingElement.h:
      * svg/SVGFEDisplacementMapElement.cpp:
      (WebCore::SVGFEDisplacementMapElement::build):
      * svg/SVGFEDisplacementMapElement.h:
      * svg/SVGFEFloodElement.cpp:
      (WebCore::SVGFEFloodElement::build):
      * svg/SVGFEFloodElement.h:
      * svg/SVGFEGaussianBlurElement.cpp:
      (WebCore::SVGFEGaussianBlurElement::build):
      * svg/SVGFEGaussianBlurElement.h:
      * svg/SVGFEImageElement.cpp:
      (WebCore::SVGFEImageElement::build):
      * svg/SVGFEImageElement.h:
      * svg/SVGFEMergeElement.cpp:
      (WebCore::SVGFEMergeElement::build):
      * svg/SVGFEMergeElement.h:
      * svg/SVGFEMorphologyElement.cpp:
      (WebCore::SVGFEMorphologyElement::build):
      * svg/SVGFEMorphologyElement.h:
      * svg/SVGFEOffsetElement.cpp:
      (WebCore::SVGFEOffsetElement::build):
      * svg/SVGFEOffsetElement.h:
      * svg/SVGFESpecularLightingElement.cpp:
      (WebCore::SVGFESpecularLightingElement::build):
      * svg/SVGFESpecularLightingElement.h:
      * svg/SVGFETileElement.cpp:
      (WebCore::SVGFETileElement::build):
      * svg/SVGFETileElement.h:
      * svg/SVGFETurbulenceElement.cpp:
      (WebCore::SVGFETurbulenceElement::build):
      * svg/SVGFETurbulenceElement.h:
      * svg/SVGFilterPrimitiveStandardAttributes.h:
      * svg/graphics/filters/SVGFEImage.cpp:
      (WebCore::FEImage::FEImage):
      (WebCore::FEImage::create):
      (WebCore::FEImage::determineAbsolutePaintRect):
      (WebCore::FEImage::apply):
      * svg/graphics/filters/SVGFEImage.h:
      * svg/graphics/filters/SVGFilterBuilder.cpp:
      (WebCore::SVGFilterBuilder::SVGFilterBuilder):
      * svg/graphics/filters/SVGFilterBuilder.h:
      (WebCore::SVGFilterBuilder::create):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72474 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a11689df
    • commit-queue@webkit.org's avatar
      2010-11-20 Helder Correia <helder@sencha.com> · 388b0c6f
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] GraphicsContext::strokeArc() is not necessary any more
              https://bugs.webkit.org/show_bug.cgi?id=49859
      
              Remove strokeArc() from the Qt port.
      
              No test is needed.
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      388b0c6f
    • commit-queue@webkit.org's avatar
      2010-11-20 Helder Correia <helder@sencha.com> · 36dcd3d9
      commit-queue@webkit.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Path fill lacks blur shadow support
              https://bugs.webkit.org/show_bug.cgi?id=49491
      
              Add new test for checking path fill blur shadow.
      
              * fast/canvas/canvas-fillPath-shadow-expected.txt: Added.
              * fast/canvas/canvas-fillPath-shadow.html: Added.
              * fast/canvas/script-tests/canvas-fillPath-shadow.js: Added.
      2010-11-20  Helder Correia  <helder@sencha.com>
      
              Reviewed by Andreas Kling.
      
              [Qt] Path fill lacks blur shadow support
              https://bugs.webkit.org/show_bug.cgi?id=49491
      
              Add blur shadow support to fillPath().
      
              Test: fast/canvas/canvas-fillPath-shadow.html
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::fillPath):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      36dcd3d9
    • andreas.kling@nokia.com's avatar
      2010-11-19 Kristian Amlie <kristian.amlie@nokia.com> · e325fc66
      andreas.kling@nokia.com authored
              Reviewed by Andreas Kling.
      
              Fixed handling of QInputMethodEvents with nonzero replacementLength.
      
              These types of events replace text that is already in the widget, but
              WebKit did not check for replacementLength at all.
      
              Also made sure that the preeditString is always respected, even if
              there is committed text. This is how QLineEdit does it.
      
              https://bugs.webkit.org/show_bug.cgi?id=49787
      
              * Api/qwebpage.cpp:
              (QWebPagePrivate::inputMethodEvent):
              * tests/qwebpage/tst_qwebpage.cpp:
              (tst_QWebPage::inputMethods):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e325fc66
    • commit-queue@webkit.org's avatar
      2010-11-19 W. James MacLean <wjmaclean@chromium.org> · 16dfa447
      commit-queue@webkit.org authored
              Reviewed by James Robinson.
      
              Scaled Resized images are blurred when sent to Skia
              https://bugs.webkit.org/show_bug.cgi?id=42370
      
              * platform/chromium-linux/svg/custom/image-rescale-expected.checksum: Added.
              * platform/chromium-linux/svg/custom/image-rescale-expected.png: Added.
              * platform/chromium-linux/svg/custom/image-rescale-expected.txt: Added.
              * platform/chromium-linux/svg/custom/image-rescale-scroll-expected.checksum: Added.
              * platform/chromium-linux/svg/custom/image-rescale-scroll-expected.png: Added.
              * platform/chromium-linux/svg/custom/image-rescale-scroll-expected.txt: Added.
              * platform/chromium/test_expectations.txt:
              * platform/mac/svg/custom/image-rescale-expected.checksum: Added.
              * platform/mac/svg/custom/image-rescale-expected.png: Added.
              * platform/mac/svg/custom/image-rescale-expected.txt: Added.
              * platform/mac/svg/custom/image-rescale-scroll-expected.checksum: Added.
              * platform/mac/svg/custom/image-rescale-scroll-expected.png: Added.
              * platform/mac/svg/custom/image-rescale-scroll-expected.txt: Added.
              * platform/mac/test_expectations.txt:
              * svg/custom/image-rescale-scroll.html: Added.
              * svg/custom/image-rescale.svg: Added.
              * svg/custom/resources/image-rescale.jpg: Added.
      2010-11-19  W. James MacLean  <wjmaclean@chromium.org>
      
              Reviewed by James Robinson.
      
              Scaled Resized images are blurred when sent to Skia
              https://bugs.webkit.org/show_bug.cgi?id=42370
      
              This patch modifies ImageSkia.cpp to fix the calculation of resampled
              bitmap sizes so as to include the transform matrix of the canvas.
              Includes a new test to catch a regression that occured the first time
              this patch was applied.
      
              Tests: svg/custom/image-rescale-scroll.html
                     svg/custom/image-rescale.svg
      
              * platform/graphics/skia/ImageSkia.cpp:
              (WebCore::computeResamplingMode):
              (WebCore::drawResampledBitmap):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16dfa447
    • commit-queue@webkit.org's avatar
      2010-11-19 Jia Pu <jpu@apple.com> · a563e17c
      commit-queue@webkit.org authored
              Reviewed by Dan Bernstein.
      
              Regression: contraction is considered misspelling.
              https://bugs.webkit.org/show_bug.cgi?id=49423
              <rdar://problem/8654206>
      
              * platform/mac-leopard/Skipped:
              * platform/mac-snowleopard/Skipped:
              * platform/mac-tiger/Skipped:
              * platform/mac-wk2/Skipped:
              * platform/mac/editing/spelling/autocorrection-contraction-expected.checksum: Added.
              * platform/mac/editing/spelling/autocorrection-contraction-expected.png: Added.
              * platform/mac/editing/spelling/autocorrection-contraction-expected.txt: Added.
              * platform/mac/editing/spelling/autocorrection-contraction.html: Added.
      2010-11-19  Jia Pu  <jpu@apple.com>
      
              Reviewed by Dan Bernstein.
      
              Regression: contraction is considered misspelling.
              https://bugs.webkit.org/show_bug.cgi?id=49423
              <rdar://problem/8654206>
      
              Test: platform/mac/editing/spelling/autocorrection-contraction.html
                    manual-tests/autocorrection/autocorrection-contraction.html
      
              * editing/Editor.cpp:
              (WebCore::isAmbiguousBoundaryCharacter): Moved function to the top of the file so that it can
                be used by all other functions in the file.
              (WebCore::Editor::markMisspellingsAfterTypingToWord): Renamed markMisspellingsAfterTypingToPosition()
                to improve readability, and to pass in additional argument. Before we apply pending
                autocorrection, we check to see if currently typed character makes current word a partial
                contraction, for instance "wouldn'". If that's the case, we would not apply the pending
                correction.
              (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges): Make sure currently typed word
                is not a partial contraction, such as "wouldn'", before mark it as misspelled. Also update
                the location of ambiguous boundary if other replacements have changed the length of the
                paragraph.
              * editing/Editor.h:
              * editing/TypingCommand.cpp:
              (WebCore::TypingCommand::markMisspellingsAfterTyping): Adopt renamed function.
              * manual-tests/autocorrection/autocorrection-contraction.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a563e17c
  2. 19 Nov, 2010 22 commits