1. 10 Mar, 2011 29 commits
    • pfeldman@chromium.org's avatar
      2011-03-10 Greg Simon <gregsimon@chromium.org> · b35e6870
      pfeldman@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Need new graphic icon for garbage collect button.
              https://bugs.webkit.org/show_bug.cgi?id=55794
      
              No new tests: gc tests are flaky due to non-determinisic
              behavior of collection APIs (more notes in bug)
      
              * English.lproj/localizedStrings.js:
              * WebCore.gypi:
              * bindings/js/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::collectGarbage):
              * bindings/js/ScriptProfiler.h:
              * bindings/v8/ScriptProfiler.cpp:
              (WebCore::ScriptProfiler::collectGarbage):
              * bindings/v8/ScriptProfiler.h:
              * inspector/Inspector.idl:
              * inspector/InspectorProfilerAgent.cpp:
              (WebCore::InspectorProfilerAgent::collectGarbage):
              * inspector/InspectorProfilerAgent.h:
              * inspector/front-end/Images/garbageCollectButtonGlyph.png: Added.
              * inspector/front-end/TimelinePanel.js:
              (WebInspector.TimelinePanel.prototype.get statusBarItems):
              (WebInspector.TimelinePanel.prototype._createStatusbarButtons):
              (WebInspector.TimelinePanel.prototype._garbageCollectButtonClicked):
              * inspector/front-end/inspector.css:
              (.garbage-collect-status-bar-item .glyph):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80723 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b35e6870
    • andreip@google.com's avatar
      2011-03-10 Andrei Popescu <andreip@google.com> · 0dfff4c1
      andreip@google.com authored
              Unreviewed, build fix.
      
              [Chromium] fast/text/justify-ideograph-vertical.html fails on OSX 10.5
              https://bugs.webkit.org/show_bug.cgi?id=56106
      
              Update Chromium test expectations.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80722 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dfff4c1
    • caseq@chromium.org's avatar
      2011-03-10 Andrey Kosyakov <caseq@chromium.org> · d59a5975
      caseq@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: better names for HAR export commands
              https://bugs.webkit.org/show_bug.cgi?id=56097
      
              Rename Export to HAR to Copy entry/network log as HAR
              Expose Copy as HAR unconditionally, remove related settings entry.
      
              * English.lproj/localizedStrings.js:
              * inspector/front-end/NetworkPanel.js:
              (WebInspector.NetworkPanel.prototype._contextMenu):
              * inspector/front-end/Settings.js:
      
      2011-03-10  Andrey Kosyakov  <caseq@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: better names for HAR export commands
              https://bugs.webkit.org/show_bug.cgi?id=56097
      
              * src/js/DevTools.js: removed override for resourceExportEnabled
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80721 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d59a5975
    • laszlo.1.gombos@nokia.com's avatar
      2011-03-10 Qi Zhang <qi.2.zhang@nokia.com> · ca63cd91
      laszlo.1.gombos@nokia.com authored
              Reviewed by Laszlo Gombos.
      
              [Qt] Mobile Devices should include Model and Firmware Version in Webkit Generated User Agent String
              https://bugs.webkit.org/show_bug.cgi?id=48636
      
              Fix a typo in features.pri that turns on this feature on mobile
              devices by default.
      
              * features.pri:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca63cd91
    • apavlov@chromium.org's avatar
      2011-03-10 Alexander Pavlov <apavlov@chromium.org> · c721dd2e
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Invalid expected parameter list in CSSAgent.setSelectorText() callback (CSSStyleModel.js)
              https://bugs.webkit.org/show_bug.cgi?id=56092
      
              * inspector/front-end/CSSStyleModel.js:
              (WebInspector.CSSStyleModel.prototype.setRuleSelector):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c721dd2e
    • pfeldman@chromium.org's avatar
      2011-03-10 Pavel Feldman <pfeldman@chromium.org> · a5641fab
      pfeldman@chromium.org authored
              Not reviewed: rolling out r80478 and its follow ups for breaking
              inspector and engadget.com.
              https://bugs.webkit.org/show_bug.cgi?id=49401
      
              * dom/Document.cpp:
              (WebCore::Document::Document):
              (WebCore::performTask):
              (WebCore::Document::postTask):
              * dom/Document.h:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::setDefersLoading):
              * manual-tests/database-callback-deferred.html: Removed.
              * page/PageGroupLoadDeferrer.cpp:
              (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
              (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):
      
      2011-03-10  Pavel Feldman  <pfeldman@chromium.org>
      
              Not reviewed: rolling out r80478 and its follow ups for breaking
              inspector and engadget.com.
              https://bugs.webkit.org/show_bug.cgi?id=49401
      
              * platform/gtk/Skipped:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80718 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a5641fab
    • philn@webkit.org's avatar
      2011-03-10 Philippe Normand <pnormand@igalia.com> · f079005f
      philn@webkit.org authored
              Unreviewed, skip 1 more svg test failing by one pixel in 32-bits
              Debug, see bug 39022.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80717 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f079005f
    • kov@webkit.org's avatar
      2011-03-10 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 3f1a57fd
      kov@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              Tiled backing store's delegated scroll request uses incorrect convention
              https://bugs.webkit.org/show_bug.cgi?id=56011
      
              Use a point instead of delta, when relaying the scroll request from
              ScrollView::setScrollPosition.
      
              * loader/EmptyClients.h:
              (WebCore::EmptyChromeClient::delegatedScrollRequested):
              * page/Chrome.cpp:
              (WebCore::Chrome::delegatedScrollRequested):
              * page/Chrome.h:
              * page/ChromeClient.h:
              * platform/HostWindow.h:
              * platform/ScrollView.cpp:
              (WebCore::ScrollView::setScrollPosition):
      2011-03-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Tiled backing store's delegated scroll request uses incorrect convention
              https://bugs.webkit.org/show_bug.cgi?id=56011
      
              Adapt internal API to match the change from delta to point on the
              WebCore side, and convert the point to a delta for the public API.
      
              * WebCoreSupport/ChromeClientQt.cpp:
              (WebCore::ChromeClientQt::delegatedScrollRequested):
              * WebCoreSupport/ChromeClientQt.h:
      2011-03-10  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
      
              Reviewed by Kenneth Rohde Christiansen.
      
              Tiled backing store's delegated scroll request uses incorrect convention
              https://bugs.webkit.org/show_bug.cgi?id=56011
      
              Adapt all of the internal API to match the delta to point
              conversion at the WebCore side.
      
              * UIProcess/API/qt/qwkpage.cpp:
              (QWKPagePrivate::pageDidRequestScroll):
              * UIProcess/API/qt/qwkpage_p.h:
              * UIProcess/PageClient.h:
              * UIProcess/WebPageProxy.cpp:
              (WebKit::WebPageProxy::pageDidRequestScroll):
              * UIProcess/WebPageProxy.h:
              * UIProcess/WebPageProxy.messages.in:
              * WebProcess/WebCoreSupport/WebChromeClient.cpp:
              (WebKit::WebChromeClient::delegatedScrollRequested):
              * WebProcess/WebCoreSupport/WebChromeClient.h:
              * WebProcess/WebPage/WebPage.cpp:
              (WebKit::WebPage::pageDidRequestScroll):
              * WebProcess/WebPage/WebPage.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80716 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f1a57fd
    • philn@webkit.org's avatar
      2011-03-10 Philippe Normand <pnormand@igalia.com> · 6148bfe2
      philn@webkit.org authored
              Reviewed by Xan Lopez.
      
              [GTK] unittests/testapplicationcache crashes
              https://bugs.webkit.org/show_bug.cgi?id=56083
      
              Removed the webkit_application_cache_get_database_directory_path
              API as the underlying ApplicationCacheStorage doesn't allow
              setting the cache path multiple times.
      
              * tests/testapplicationcache.c:
              (main):
              * webkit/webkitapplicationcache.cpp:
              (webkit_application_cache_get_database_directory_path):
              * webkit/webkitapplicationcache.h:
              * webkit/webkitglobals.cpp:
              (webkitInit):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80715 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6148bfe2
    • kbalazs@webkit.org's avatar
      2011-03-10 Balazs Kelemen <kbalazs@webkit.org> · eb7aefb1
      kbalazs@webkit.org authored
              Reviewed by Andreas Kling.
      
              [WK2] Make non-transparent windowless plugins paint on X11
              https://bugs.webkit.org/show_bug.cgi?id=55660
      
              Implement painting for non-transparent windowless X11 plugins.
              The essence of the logic has been adapted from WebCore.
              The implementation is stubbed for GTK and working only on Qt
              but it should be really easy to finish it for GTK.
      
              * WebKit2.pro:
              * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
              (WebKit::NPN_GetValue): Handle X11 specific values that are necessary.
              * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
              (WebKit::NetscapePlugin::NetscapePlugin): Initialize the X11 specific
              members that has been added.
              (WebKit::NetscapePlugin::callSetWindow): Always set the x and y coordinates
              of the NP_Window to 0 on X11 since we are using a backings store as the
              painting area for the plugin.
              * WebProcess/Plugins/Netscape/NetscapePlugin.h:
              * WebProcess/Plugins/Netscape/gtk/NetscapePluginGtk.cpp: Removed in favour
              of a common implementation for X11.
              * WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp: Ditto.
              * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Added.
              (WebKit::getPluginDisplay):
      
              Platform specific static getters.
              (WebKit::x11Display):
              (WebKit::displayDepth):
              (WebKit::rootWindowID):
              (WebKit::x11Screen):
      
              (WebKit::NetscapePlugin::platformPostInitialize): Set up the visual
              settings and the colormap for the plugin.
              (WebKit::NetscapePlugin::platformDestroy):
              (WebKit::NetscapePlugin::platformInvalidate): Remained stub.
              (WebKit::NetscapePlugin::platformGeometryDidChange): Create a new
              pixmap that fits the geometry.
              (WebKit::NetscapePlugin::platformPaint): Propagate a paint event
              to the plugin, sync with it if necessary and draw the pixmap to
              the screen.
              (WebKit::toNP): Remained stub.
              (WebKit::NetscapePlugin::platformHandleMouseEvent): Remained stub.
              (WebKit::NetscapePlugin::platformHandleWheelEvent): Remained stub.
              (WebKit::NetscapePlugin::platformSetFocus): Remained stub.
              (WebKit::NetscapePlugin::platformHandleMouseEnterEvent): Remained stub.
              (WebKit::NetscapePlugin::platformHandleMouseLeaveEvent): Remained stub.
              (WebKit::NetscapePlugin::platformHandleKeyboardEvent): Remained stub.
              * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
              (WebKit::WebFrameLoaderClient::createPlugin): Hack. Inject wmode=opaque
              key-value pair to the plugin parameters to force Flash to act in
              non-transparent windowless mode. Qt also doing this in WebCore.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80714 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eb7aefb1
    • pfeldman@chromium.org's avatar
      2011-03-10 Pavel Feldman <pfeldman@chromium.org> · 83de0c7c
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: brush up DOM agent API.
              https://bugs.webkit.org/show_bug.cgi?id=56093
      
              * http/tests/inspector/elements-test.js:
              (initialize_ElementTest.InspectorTest.nodeWithId.processChildren):
              (initialize_ElementTest.InspectorTest.nodeWithId.documentRequested):
              (initialize_ElementTest.InspectorTest.nodeWithId):
              (initialize_ElementTest.InspectorTest.dumpDOMAgentTree.dump):
              (initialize_ElementTest.InspectorTest.dumpDOMAgentTree):
              (initialize_ElementTest):
              * inspector/elements/elements-panel-rewrite-href.html:
              * inspector/elements/elements-panel-search.html:
              * inspector/elements/elements-panel-selection-on-refresh.html:
              * inspector/elements/mutate-unknown-node.html:
      2011-03-10  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: brush up DOM agent API.
              https://bugs.webkit.org/show_bug.cgi?id=56093
      
              * inspector/Inspector.idl:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::childNodes):
              (WebCore::InspectorDOMAgent::setNodeName):
              (WebCore::InspectorDOMAgent::outerHTML):
              (WebCore::InspectorDOMAgent::setNodeValue):
              * inspector/InspectorDOMAgent.h:
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMNode):
              (WebInspector.DOMNode.prototype.hasAttributes):
              (WebInspector.DOMNode.prototype.nodeType):
              (WebInspector.DOMNode.prototype.nodeName):
              (WebInspector.DOMNode.prototype.setNodeName):
              (WebInspector.DOMNode.prototype.localName):
              (WebInspector.DOMNode.prototype.nodeValue):
              (WebInspector.DOMNode.prototype.setNodeValue):
              (WebInspector.DOMNode.prototype.setAttribute):
              (WebInspector.DOMNode.prototype.attributes):
              (WebInspector.DOMNode.prototype.removeAttribute):
              (WebInspector.DOMNode.prototype.childNodes.mycallback):
              (WebInspector.DOMNode.prototype.childNodes):
              (WebInspector.DOMNode.prototype.outerHTML):
              (WebInspector.DOMNode.prototype.setOuterHTML):
              (WebInspector.DOMNode.prototype.removeNode):
              (WebInspector.DOMNode.prototype.copyNode):
              (WebInspector.DOMNode.prototype.path):
              (WebInspector.DOMNode.prototype._setAttributesPayload):
              (WebInspector.DOMNode.prototype._addAttribute):
              (WebInspector.DOMAgent.prototype._characterDataModified):
              * inspector/front-end/ElementsPanel.js:
              (WebInspector.ElementsPanel.prototype.updateBreadcrumb):
              (WebInspector.ElementsPanel.prototype.decorateNodeLabel):
              (WebInspector.ElementsPanel.prototype.handleCopyEvent):
              * inspector/front-end/ElementsTreeOutline.js:
              (WebInspector.ElementsTreeOutline.prototype.findTreeElement):
              (WebInspector.ElementsTreeElement):
              (WebInspector.ElementsTreeElement.prototype.updateChildren):
              (WebInspector.ElementsTreeElement.prototype._updateChildren):
              (WebInspector.ElementsTreeElement.prototype._startEditingTarget):
              (WebInspector.ElementsTreeElement.prototype._startEditing):
              (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):
              (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted.moveToNextAttributeIfNeeded):
              (WebInspector.ElementsTreeElement.prototype._tagNameEditingCommitted):
              (WebInspector.ElementsTreeElement.prototype._textNodeEditingCommitted):
              (WebInspector.ElementsTreeElement.prototype._attributeHTML):
              ():
              * inspector/front-end/EventListenersSidebarPane.js:
              ():
              * inspector/front-end/MetricsSidebarPane.js:
              * inspector/front-end/StylesSidebarPane.js:
              * inspector/front-end/utilities.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80713 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      83de0c7c
    • philn@webkit.org's avatar
      2011-03-10 Philippe Normand <pnormand@igalia.com> · 7f16ffa2
      philn@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] run-gtk-tests doesn't fail if a test crashes
              https://bugs.webkit.org/show_bug.cgi?id=56089
      
              * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
              even if a test crashes. So run the tests individually and if a
              test fails remember its exit code so run-gtk-test fails too, if
              required.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80712 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7f16ffa2
    • philn@webkit.org's avatar
      2011-03-10 Philippe Normand <pnormand@igalia.com> · e4fd02e1
      philn@webkit.org authored
              Unreviewed, skip 2 more flacky tests on GTK 32-bits Release.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80711 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4fd02e1
    • apavlov@chromium.org's avatar
      2011-03-09 Alexander Pavlov <apavlov@chromium.org> · c67b6c3f
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [STYLES] Editing a property value adds a word for any property value that uses a paren
              https://bugs.webkit.org/show_bug.cgi?id=56002
      
              * inspector/front-end/StylesSidebarPane.js: Introduce an additional check.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c67b6c3f
    • podivilov@chromium.org's avatar
      2011-03-09 Pavel Podivilov <podivilov@chromium.org> · 45e5ba45
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: use DebuggerPresentation instead of DebuggerModel in source frame delegate.
              https://bugs.webkit.org/show_bug.cgi?id=56034
      
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel.prototype.continueToLine):
              (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype._sourceLocationToActualLocation):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel.prototype._createSourceFrame):
              (WebInspector.SourceFrameDelegateForScriptsPanel):
              (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.setBreakpoint):
              (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.updateBreakpoint):
              (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.removeBreakpoint):
              (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.findBreakpoint):
              (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.continueToLine):
              * inspector/front-end/SourceFrame.js:
              (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition.didEditBreakpointCondition):
              (WebInspector.SourceFrame.prototype._contextMenu.else.editBreakpointCondition):
              (WebInspector.SourceFrame.prototype._contextMenu.else.setBreakpointEnabled):
              (WebInspector.SourceFrame.prototype._contextMenu):
              (WebInspector.SourceFrame.prototype._mouseDown):
              (WebInspector.SourceFrameDelegate.prototype.removeBreakpoint):
              (WebInspector.SourceFrameDelegate.prototype.updateBreakpoint):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80709 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      45e5ba45
    • apavlov@chromium.org's avatar
      2011-03-09 Alexander Pavlov <apavlov@chromium.org> · 7cfcbd7c
      apavlov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: elements dom tree - word wrap toggle
              https://bugs.webkit.org/show_bug.cgi?id=44311
      
              A "Word Wrap" option is now shown in a context menu for the entire DOM tree content area
              and persisted into application settings.
      
              * English.lproj/localizedStrings.js:
              * inspector/front-end/ElementsPanel.js:
              (WebInspector.ElementsPanel.prototype._contextMenuEventFired):
              (WebInspector.ElementsPanel.prototype._contextMenuEventFired.toggleWordWrap):
              * inspector/front-end/ElementsTreeOutline.js:
              (WebInspector.ElementsTreeOutline):
              (WebInspector.ElementsTreeOutline.prototype._treeElementFromEvent):
              (WebInspector.ElementsTreeOutline.prototype.populateContextMenu):
              (WebInspector.ElementsTreeElement.prototype.onreveal):
              * inspector/front-end/Settings.js:
              (WebInspector.Settings):
              * inspector/front-end/inspector.css:
              (#elements-content.nowrap):
              (#elements-content > ol):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80708 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7cfcbd7c
    • philn@webkit.org's avatar
      2011-03-10 Philippe Normand <pnormand@igalia.com> · 158428ca
      philn@webkit.org authored
              Unreviewed, skip 1 more svg test failing by one pixel in 32-bits
              Debug, see bug 39022.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80707 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      158428ca
    • philn@webkit.org's avatar
      2011-03-10 Philippe Normand <pnormand@igalia.com> · a2bc72a8
      philn@webkit.org authored
              Unreviewed, skip 2 more svg tests failing by one pixel in 32-bits
              Release, see bug 39022.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80706 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a2bc72a8
    • podivilov@chromium.org's avatar
      2011-03-09 Pavel Podivilov <podivilov@chromium.org> · 05fdb31e
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: re-implement breakpoints sidebar pane based on debugger presentation model.
              https://bugs.webkit.org/show_bug.cgi?id=55823
      
              * inspector/front-end/BreakpointsSidebarPane.js:
              (WebInspector.JavaScriptBreakpointsSidebarPane):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint.didLoadSnippet):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.addBreakpoint):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.removeBreakpoint):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.highlightBreakpoint):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.clearBreakpointHighlight):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._createBreakpointItemId):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointClicked):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointCheckboxClicked):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenu):
              (WebInspector.JavaScriptBreakpointsSidebarPane.prototype.reset):
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel):
              (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
              (WebInspector.DebuggerPresentationModel.prototype._revealHiddenBreakpoints):
              (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
              (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
              (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
              (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
              (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
              (WebInspector.DebuggerPresentationModel.prototype.reset):
              * inspector/front-end/ScriptsPanel.js:
              (WebInspector.ScriptsPanel):
              (WebInspector.ScriptsPanel.prototype._breakpointAdded):
              (WebInspector.ScriptsPanel.prototype._breakpointRemoved):
              (WebInspector.ScriptsPanel.prototype._debuggerPaused):
              (WebInspector.ScriptsPanel.prototype.reset):
              (WebInspector.ScriptsPanel.prototype._clearInterface):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80705 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05fdb31e
    • podivilov@chromium.org's avatar
      2011-03-10 Andrey Adaikin <aandrey@google.com> · 9c79d469
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: Highlighter refactoring
              https://bugs.webkit.org/show_bug.cgi?id=56015
      
              * inspector/editor/highlighter-basics-expected.txt:
              * inspector/editor/highlighter-basics.html:
              * inspector/editor/highlighter-long-line.html:
              * inspector/editor/highlighter-paste-in-comment-expected.txt:
              * inspector/editor/highlighter-paste-in-comment.html:
      2011-03-10  Andrey Adaikin  <aandrey@google.com>
      
              Reviewed by Pavel Feldman.
      
              Web Inspector: Highlighter refactoring
              https://bugs.webkit.org/show_bug.cgi?id=56015
      
              * inspector/front-end/TextEditorHighlighter.js:
              (WebInspector.TextEditorHighlighter):
              (WebInspector.TextEditorHighlighter.prototype.set mimeType):
              (WebInspector.TextEditorHighlighter.prototype.highlight):
              (WebInspector.TextEditorHighlighter.prototype.updateHighlight):
              (WebInspector.TextEditorHighlighter.prototype._highlightInChunks):
              (WebInspector.TextEditorHighlighter.prototype._highlightLines):
              (WebInspector.TextEditorHighlighter.prototype._selectHighlightState):
              (WebInspector.TextEditorHighlighter.prototype._clearHighlightState):
              * inspector/front-end/TextViewer.js:
              (WebInspector.TextEditorMainPanel.prototype._buildChunks):
              (WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80704 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c79d469
    • jknotten@chromium.org's avatar
      2011-03-10 John Knottenbelt <jknotten@chromium.org> · 35f104ce
      jknotten@chromium.org authored
              Reviewed by Andreas Kling.
      
              [Qt] Skip fast/dom/Geolocation/page-reload-cancel-permission-requests.html pending implementation of LayoutTestController::numberOfPendingGeolocationPermissionRequests
              https://bugs.webkit.org/show_bug.cgi?id=56087
      
              * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80703 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      35f104ce
    • podivilov@chromium.org's avatar
      2011-03-05 Pavel Podivilov <podivilov@chromium.org> · 44b263d5
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: move breakpoint column adjustment to debugger model.
              https://bugs.webkit.org/show_bug.cgi?id=55821
      
              Test: inspector/debugger/debug-inlined-scripts.html
      
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel.prototype.setBreakpoint.didSetBreakpoint):
              (WebInspector.DebuggerModel.prototype.setBreakpoint):
              * inspector/front-end/SourceFrameContent.js:
              (WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToActualLocation):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80702 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44b263d5
    • jknotten@chromium.org's avatar
      2011-02-16 John Knottenbelt <jknotten@chromium.org> · e0c8fe13
      jknotten@chromium.org authored
              Reviewed by Dmitry Titov.
      
              Detach Geolocation from Frame when Page destroyed.
              https://bugs.webkit.org/show_bug.cgi?id=52877
      
              Ensure that all geolocation permission requests are cancelled
              when the page is detached from its frame.
      
              * fast/dom/Geolocation/page-reload-cancel-permission-requests-expected.txt: Added.
              * fast/dom/Geolocation/page-reload-cancel-permission-requests.html: Added.
              * fast/dom/Geolocation/resources/page-reload-cancel-permission-requests-inner.html: Added.
              * fast/dom/Geolocation/script-tests/page-reload-cancel-permission-requests.js: Added.
              * platform/gtk/Skipped:
              * platform/mac/Skipped:
              * platform/qt-wk2/Skipped:
      2011-01-21  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Dmitry Titov.
      
              Detach Geolocation from Frame when Page destroyed.
              https://bugs.webkit.org/show_bug.cgi?id=52877
      
              On Page destruction, any outstanding Geolocation permission
              requests should be cancelled, because the Geolocation can only
              access the client indirectly via m_frame->page().
      
              Page destruction is signalled by a call to the
              Frame::pageDestroyed() method. This explictly calls
              DOMWindow::resetGeolocation which ultimately calls Geolocation::reset.
      
              Geolocation::reset() detaches from the GeolocationController,
              cancels requests, watches and single shots, and sets the
              permission state back to Unknown.
      
              Frame::pageDestroyed() is also called by FrameLoader even though
              the page is not destroyed. We should still cancel permission
              requests, because the GeolocationClient will become inaccessible
              to the Geolocation object after this call.
      
              Frame::transferChildFrameToNewDocument also indirectly calls
              Geolocation::reset when the frame is reparented between
              pages. Ideally we would like the Geolocation's activities to
              continue after reparenting, see bug
              https://bugs.webkit.org/show_bug.cgi?id=55577
      
              Since GeolocationController is owned by Page, and all Geolocation
              objects will now unsubscribe from the GeolocationController on
              pageDetached(), we no longer need to call stopUpdating() from the
              GeolocationController's destructor. Instead we can simply assert
              that there should be no no observers. See related bug
              https://bugs.webkit.org/show_bug.cgi?id=52216 .
      
              Introduced new method 'numberOfPendingPermissionRequests' on
              GeolocationClientMock to count the number of outstanding pending
              permission requests. This provides a reusable implementation for
              client-based implementations of the LayoutTestController's
              numberOfPendingGeolocationPermissionRequests method.
      
              Test: fast/dom/Geolocation/page-reload-cancel-permission-requests.html
      
              * page/DOMWindow.cpp:
              (WebCore::DOMWindow::resetGeolocation):
              * page/DOMWindow.h:
              * page/Frame.cpp:
              (WebCore::Frame::pageDestroyed):
              (WebCore::Frame::transferChildFrameToNewDocument):
              * page/Geolocation.cpp:
              (WebCore::Geolocation::~Geolocation):
              (WebCore::Geolocation::page):
              (WebCore::Geolocation::reset):
              (WebCore::Geolocation::disconnectFrame):
              (WebCore::Geolocation::lastPosition):
              (WebCore::Geolocation::requestPermission):
              (WebCore::Geolocation::startUpdating):
              (WebCore::Geolocation::stopUpdating):
              * page/Geolocation.h:
              * page/GeolocationController.cpp:
              (WebCore::GeolocationController::~GeolocationController):
              * page/Navigator.cpp:
              (WebCore::Navigator::resetGeolocation):
              * page/Navigator.h:
              * platform/mock/GeolocationClientMock.cpp:
              (WebCore::GeolocationClientMock::numberOfPendingPermissionRequests):
              * platform/mock/GeolocationClientMock.h:
      2011-01-26  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Dmitry Titov.
      
              Detach Geolocation from Frame when Page destroyed.
              https://bugs.webkit.org/show_bug.cgi?id=52877
      
              Add accessors to the WebGeolocationClientMock to allow the number of
              pending geolocation permission requests to be queried.
      
              * public/WebGeolocationClientMock.h:
              * src/WebGeolocationClientMock.cpp:
              (WebKit::WebGeolocationClientMock::numberOfPendingPermissionRequests):
      2011-01-26  John Knottenbelt  <jknotten@chromium.org>
      
              Reviewed by Dmitry Titov.
      
              Detach Geolocation from Frame when Page destroyed.
              https://bugs.webkit.org/show_bug.cgi?id=52877
      
              Extend the layout test controller to expose the number of pending
              geolocation requests, so that we can test that the requests have
              been cancelled on page close.
      
              * DumpRenderTree/LayoutTestController.cpp:
              (numberOfPendingGeolocationPermissionRequestsCallback):
              (LayoutTestController::staticFunctions):
              * DumpRenderTree/LayoutTestController.h:
              * DumpRenderTree/chromium/LayoutTestController.cpp:
              (LayoutTestController::LayoutTestController):
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
              * DumpRenderTree/chromium/LayoutTestController.h:
              * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
              * DumpRenderTree/mac/LayoutTestControllerMac.mm:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
              * DumpRenderTree/mac/UIDelegate.h:
              * DumpRenderTree/mac/UIDelegate.mm:
              (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
              * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
              * DumpRenderTree/qt/LayoutTestControllerQt.h:
              * DumpRenderTree/win/LayoutTestControllerWin.cpp:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
              * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
              (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80701 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e0c8fe13
    • ossy@webkit.org's avatar
      Unreviewed. · 504051eb
      ossy@webkit.org authored
      Add Qt specific expected files for tests introduced in r80622 and r80682.
      
      * platform/qt/fast/dom/scroll-reveal-left-overflow-expected.checksum: Added.
      * platform/qt/fast/dom/scroll-reveal-left-overflow-expected.png: Added.
      * platform/qt/fast/dom/scroll-reveal-left-overflow-expected.txt: Added.
      * platform/qt/fast/dom/scroll-reveal-top-overflow-expected.checksum: Added.
      * platform/qt/fast/dom/scroll-reveal-top-overflow-expected.png: Added.
      * platform/qt/fast/dom/scroll-reveal-top-overflow-expected.txt: Added.
      * platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.checksum: Added.
      * platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.png: Added.
      * platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.txt: Added.
      * platform/qt/fast/dynamic/float-at-line-break-expected.checksum: Added.
      * platform/qt/fast/dynamic/float-at-line-break-expected.png: Added.
      * platform/qt/fast/dynamic/float-at-line-break-expected.txt: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80700 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      504051eb
    • philn@webkit.org's avatar
      2011-03-10 Philippe Normand <pnormand@igalia.com> · 29ef93f7
      philn@webkit.org authored
              Unreviewed, skip fast/js/large-expressions.html on GTK.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80699 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29ef93f7
    • philn@webkit.org's avatar
      2011-03-10 Philippe Normand <pnormand@igalia.com> · c03de84a
      philn@webkit.org authored
              Unreviewed, skip jquery/effects.html on GTK.
      
              * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80698 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c03de84a
    • abarth@webkit.org's avatar
      2011-03-10 Adam Barth <abarth@webkit.org> · 8f510c6d
      abarth@webkit.org authored
              Partial revert of http://trac.webkit.org/changeset/80670.  This test
              has been failing sporatically since it was changed in that revision.
      
              * platform/mac/accessibility/aria-expanded-notifications.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80697 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8f510c6d
    • ojan@chromium.org's avatar
      2011-03-10 Ojan Vafai <ojan@chromium.org> · 4a97b027
      ojan@chromium.org authored
              Reviewed by Darin Adler.
      
              Able to move nodes across documents
              https://bugs.webkit.org/show_bug.cgi?id=19524
      
              Makes cross-document appendChild, insertBefore, Range.insertNode and Range.surroundContents work.
              This matches Gecko and the new Dom Core spec. There are a number of Range methods where we don't
              match Gecko or the spec that will need to be updated in a following patch.
      
              * dom/html/level1/core/hc_elementwrongdocumenterr-expected.txt:
              * dom/html/level1/core/hc_namednodemapwrongdocumenterr-expected.txt:
              * dom/xhtml/level1/core/hc_elementwrongdocumenterr-expected.txt:
              * dom/xhtml/level1/core/hc_namednodemapwrongdocumenterr-expected.txt:
              * fast/dom/move-nodes-across-documents-expected.txt: Added.
              * fast/dom/move-nodes-across-documents.html: Added.
      2011-03-10  Ojan Vafai  <ojan@chromium.org>
      
              Reviewed by Darin Adler.
      
              Able to move nodes across documents
              https://bugs.webkit.org/show_bug.cgi?id=19524
      
              Makes cross-document appendChild, insertBefore, Range.insertNode and Range.surroundContents work.
              This matches Gecko and the new Dom Core spec. There are a number of Range methods where we don't
              match Gecko or the spec that will need to be updated in a following patch.
      
              Test: fast/dom/move-nodes-across-documents.html
      
              * dom/Element.cpp:
              (WebCore::Element::removeAttributeNode):
              * dom/NamedNodeMap.cpp:
              (WebCore::NamedNodeMap::setNamedItem):
              * dom/Node.cpp:
              (WebCore::Node::setDocumentRecursively):
              (WebCore::checkAcceptChild):
              (WebCore::Node::checkReplaceChild):
              * dom/Range.cpp:
              (WebCore::Range::insertNode):
              (WebCore::Range::surroundContents):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80696 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4a97b027
    • antti@apple.com's avatar
      Not reviewed. · c40827d4
      antti@apple.com authored
      Reverting crash catching code, the bug being hunted was fixed by
      http://trac.webkit.org/changeset/80686
      
      * loader/cache/CachedResourceLoader.cpp:
      (WebCore::CachedResourceLoader::CachedResourceLoader):
      (WebCore::CachedResourceLoader::~CachedResourceLoader):
      (WebCore::CachedResourceLoader::requestImage):
      (WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
      (WebCore::CachedResourceLoader::requestResource):
      (WebCore::CachedResourceLoader::setAutoLoadImages):
      (WebCore::CachedResourceLoader::load):
      (WebCore::CachedResourceLoader::loadDone):
      (WebCore::CachedResourceLoader::preload):
      (WebCore::CachedResourceLoader::requestPreload):
      * loader/cache/CachedResourceLoader.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@80695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c40827d4
  2. 09 Mar, 2011 11 commits