GitLab

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=26367

        Remove the global variables in bidi.cpp.  Make a new struct, MidpointState, that holds all of the
        midpoint information.  Add the remaining global variables as arguments passed down through functions
        as needed.

        * platform/text/BidiResolver.h:
        (WebCore::MidpointState::MidpointState):
        (WebCore::MidpointState::reset):
        (WebCore::BidiResolver::midpointState):
        * rendering/RenderBlock.h:
        * rendering/bidi.cpp:
        (WebCore::BidiRun::operator delete):
        (WebCore::chopMidpointsAt):
        (WebCore::checkMidpoints):
        (WebCore::addMidpoint):
        (WebCore::appendRunsForObject):
        (WebCore::RenderBlock::bidiReorderLine):
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::determineStartPosition):
        (WebCore::skipNonBreakingSpace):
        (WebCore::shouldCollapseWhiteSpace):
        (WebCore::requiresLineBox):
        (WebCore::RenderBlock::generatesLineBoxesForInlineChild):
        (WebCore::RenderBlock::skipTrailingWhitespace):
        (WebCore::RenderBlock::skipLeadingWhitespace):
        (WebCore::shouldSkipWhitespaceAfterStartObject):
        (WebCore::RenderBlock::findNextLineBreak):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

I want the original change to be backed out as the whole
Skia merging is going in the wrong direction. The discussion
will happen in the bugtracker.

https://bugs.webkit.org/show_bug.cgi?id=25709.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Gustavo Noronha.

        [Gtk] Enable more http/tests/navigation tests

        * platform/gtk/Skipped:

        [Gtk] use strlen instead of g_utf8_strlen so we can enable more tests.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (dumpHistoryItem):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Gtk build fix: include cstdio so we can use sscanf

        Gtk/Win Cairo build fix: use isASCIISpace instead of isspace
        Suggested by Brent Fulgham

        * platform/image-decoders/xbm/XBMImageDecoder.cpp:
        (WebCore::XBMImageDecoder::decodeDatum):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Yet another Skia bustage fix.

        * platform/image-decoders/skia/ImageDecoder.h:
        (WebCore::RGBA32Buffer::setSize): Avoid symbol name clash.  The better fix is to take an IntSize(); I'll do that later.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Reviewed by Geoff Garen.

Convert LiteralParser from using a simple recursive descent parser
to a hand rolled PDA.  Relatively simple conversion, but required
modifications to MarkedArgumentBuffer to make it more suitable as
a generic marked vector.   I'll refactor and rename MarkedArgumentBuffer
in future as there are many other cases where it will be useful to
have such a class.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix remaining Cairo build bustage from
        https://bugs.webkit.org/show_bug.cgi?id=25709 changes.  Use
        Vector<char> in place of std::string.

        * platform/image-decoders/xbm/XBMImageDecoder.cpp:
        (WebCore::XBMImageDecoder::setData):
        (WebCore::XBMImageDecoder::decodeHeader):
        (WebCore::XBMImageDecoder::decodeDatum):
        * platform/image-decoders/xbm/XBMImageDecoder.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by NOBODY (build fix for windows).

        Adjust the exports for JSC on Windows like what was done for OSX in
        the previous commit.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore_debug.def:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-06-12  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        UString shouldn't create sharedBuffer for SmallStrings.
        https://bugs.webkit.org/show_bug.cgi?id=26360

        The methods changed are not used by JSC, so there is no JS perf impact.  However,
        there is a potential DOM perf impact, so I re-ran several of the tests that
        I ran previously and ensured that the perf stay the same which caused me to
        adjust the minLengthToShare.

        * JavaScriptCore.exp:
        * runtime/UString.cpp:
        (JSC::UString::Rep::sharedBuffer):
            Determines if the buffer being shared is big enough before doing so.
            Previously, BaseString::sharedBuffer was called but it would only know
            the length of the base string (BaseString::len) which may not be the same
            as the string being shared (Rep::len).
        (JSC::UString::BaseString::sharedBuffer):
            This is now only be used by Rep::sharedBuffer. which does the length check.
        * runtime/UString.h:

WebCore:

2009-06-12  David Levin  <levin@chromium.org>

        Reviewed by Darin Adler.

        UString shouldn't create sharedBuffer for SmallStrings.
        https://bugs.webkit.org/show_bug.cgi?id=26347

        Change the call to use the method UString::Rep::sharedBuffer due
        to changes in UString.

        No noticable change in behavior, so no test.

        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::create):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Dan Bernstein

        https://bugs.webkit.org/show_bug.cgi?id=26095

        Fix crash when a renderer for an anonymous node is composited
        by null-checking renderer()->node().

        Test: compositing/generated-content.html

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::createGraphicsLayer):
        (WebCore::RenderLayerBacking::rendererHasBackground):
        (WebCore::RenderLayerBacking::rendererBackgroundColor):
        (WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
        (WebCore::RenderLayerBacking::paintIntoLayer):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix Chromium and some of Cairo build bustage, fallout from
        https://bugs.webkit.org/show_bug.cgi?id=25709 changes.

        * WebCore.vcproj/WebCore.vcproj: Add missing XBM decoder files.
        * platform/image-decoders/skia/ImageDecoder.h:
        (WebCore::RGBA32Buffer::copyRowNTimes): Fix typo that broke Skia GIF decoding.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Oliver Hunt

        Add a page indexing the various demo applications we have posted.

        * demos/index.html: Added.
        * nav.inc: Add a link to the demos page on the side bar
        * css/main.css:  Add a style for date stamps based on the blog.

        * demos/calendar/index.html: Added to redirect to Calendar.html.  I'm not moving Calendar.html to
          index.html as the Calendar.html url has already been published and we should keep it working.

        Move the drosera test code to /misc, as it is no longer a meaningful demo:
        * demos/drosera: Removed.
        * demos/drosera/demo.js: Removed.
        * demos/drosera/drosera.png: Removed.
        * demos/drosera/index.html: Removed.
        * misc/drosera: Copied from demos/drosera.

        Move the sticky notes example into /demos:
        * demos/sticky-notes: Added.
        * demos/sticky-notes/StickyNotes.manifest: Copied from misc/DatabaseExample.manifest.
        * demos/sticky-notes/deleteButton.png: Copied from misc/deleteButton.png.
        * demos/sticky-notes/deleteButtonPressed.png: Copied from misc/deleteButtonPressed.png.
        * demos/sticky-notes/index.html: Copied from misc/DatabaseExample.html.
        * misc/DatabaseExample.html: Changed to redirect to demos/sticky-notes/index.html.  I'm not removing
          it altogether as the misc/DatabaseExample.html url has already been published and we should keep it working.
        * misc/DatabaseExample.manifest: Removed.
        * misc/deleteButton.png: Removed.
        * misc/deleteButtonPressed.png: Removed.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Fix build when ACCELERATED_COMPOSITING is defined.

        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::attachRootGraphicsLayer):
        (WebCore::EmptyChromeClient::setNeedsOneShotDrawingSynchronization):
        (WebCore::EmptyChromeClient::scheduleViewUpdate):
        Add stubs for the compositing-related ChromeClient methods.

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateRootLayerPosition):
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer):
        docWidth()/docHeight() became private. Use overflowWidth()/overflowHeight() instead, which
        matches what is used to size the WebHTMLView.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26356
        http://crbug.com/14006
        Create custom bindings for v8.  The rest of these files are still
        forked (so the review is happening on the chromium review site).
        These bindings have been tested on a hacked up Chromium instance
        (also running --single-process) and Android.

        * bindings/v8/custom/V8StorageCustom.cpp: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26359
        [v8] Add XMLHttpRequest to WorkerContextExecutionProxy.

        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::ToV8Object): Add type == V8ClassIndex::XMLHTTPREQUEST to the convertable types.
        (WebCore::WorkerContextExecutionProxy::EventTargetToV8Object): same.
        * bindings/v8/WorkerContextExecutionProxy.h: fix typo in the comment.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25709 part eight
        Replace placeholder Cairo BMP, ICO, XBM decoders with real ones.  Remove
        all the decoders from skia/ since they are now just mirrors of the Cairo
        ones.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:
        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.  Enable XBM decoding on Windows.
        * platform/graphics/skia/ImageSourceSkia.cpp:
        * platform/graphics/wx/ImageSourceWx.cpp:
        (WebCore::createDecoder): Pass IntSize() to ICOImageDecoder() so it will always decode the largest icon.
        * platform/image-decoders/bmp/BMPImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.cpp.
        * platform/image-decoders/bmp/BMPImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/BMPImageDecoder.h.
        * platform/image-decoders/bmp/BMPImageReader.cpp: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.cpp.
        * platform/image-decoders/bmp/BMPImageReader.h: Copied from WebCore/platform/image-decoders/skia/BMPImageReader.h.
        * platform/image-decoders/ico/ICOImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.cpp.
        * platform/image-decoders/ico/ICOImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/ICOImageDecoder.h.
        * platform/image-decoders/skia/BMPImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/BMPImageDecoder.h: Removed.
        * platform/image-decoders/skia/BMPImageReader.cpp: Removed.
        * platform/image-decoders/skia/BMPImageReader.h: Removed.
        * platform/image-decoders/skia/GIFImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/GIFImageDecoder.h: Removed.
        * platform/image-decoders/skia/GIFImageReader.cpp: Removed.
        * platform/image-decoders/skia/GIFImageReader.h: Removed.
        * platform/image-decoders/skia/ICOImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/ICOImageDecoder.h: Removed.
        * platform/image-decoders/skia/JPEGImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/JPEGImageDecoder.h: Removed.
        * platform/image-decoders/skia/PNGImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/PNGImageDecoder.h: Removed.
        * platform/image-decoders/skia/XBMImageDecoder.cpp: Removed.
        * platform/image-decoders/skia/XBMImageDecoder.h: Removed.
        * platform/image-decoders/xbm/XBMImageDecoder.cpp: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.cpp.
        * platform/image-decoders/xbm/XBMImageDecoder.h: Replaced with WebCore/platform/image-decoders/skia/XBMImageDecoder.h.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26191
        Remove xmath include in MathExtras.h, because it is not needed and also
        breaks VS2008 builds with TR1 turned on.

        * wtf/MathExtras.h: Removed xmath include.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25599
        [GTK] Enable more tests

        Implement dumping of status callback.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewStatusBarTextChanged):
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=25709 part seven
        Update Skia's ImageDecoder.h with a few changes designed to reduce the
        delta between specific implementations of ImageDecoder.h.  Update
        Cairo's ImageDecoder.h to sync up with the API changes in the Skia
        version in the last two chage sets.  Update Cairo's PNG/JPEG/GIF
        decoders to use the APIs as well.  All the Cairo image decoder changes
        are direct copies of the Skia versions except ImageDecoder.h, which is
        modified in the necessary ways for the differences between Cairo and
        Skia.

        * platform/graphics/cairo/ImageSourceCairo.cpp:
        (WebCore::ImageSource::createFrameAtIndex): Use new RGBA32Buffer::asNewNativeImage() API.
        * platform/image-decoders/ImageDecoder.h: Sync up with Skia version.
        (WebCore::RGBA32Buffer::):
        (WebCore::RGBA32Buffer::RGBA32Buffer):
        (WebCore::RGBA32Buffer::clear):
        (WebCore::RGBA32Buffer::zeroFill):
        (WebCore::RGBA32Buffer::copyBitmapData):
        (WebCore::RGBA32Buffer::copyRowNTimes):
        (WebCore::RGBA32Buffer::setSize):
        (WebCore::RGBA32Buffer::asNewNativeImage):
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::disposalMethod):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::RGBA32Buffer::setDisposalMethod):
        (WebCore::RGBA32Buffer::setRGBA):
        (WebCore::RGBA32Buffer::operator=):
        (WebCore::RGBA32Buffer::width):
        (WebCore::RGBA32Buffer::height):
        (WebCore::RGBA32Buffer::getAddr):
        * platform/image-decoders/gif/GIFImageDecoder.cpp: Sync up with Skia version.
        (WebCore::GIFImageDecoder::initFrameBuffer):
        (WebCore::GIFImageDecoder::haveDecodedRow):
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Sync up with Skia version.
        (WebCore::JPEGImageDecoder::outputScanlines):
        * platform/image-decoders/png/PNGImageDecoder.cpp: Sync up with Skia version.
        (WebCore::PNGImageDecoder::rowAvailable):
        * platform/image-decoders/skia/ImageDecoder.h: Add various typedefs or helper functions to minimize differences with Cairo version.  Reorder functions slightly to match reordering of Cairo's m_hasAlpha variable, which I moved to increase readability.
        (WebCore::RGBA32Buffer::):
        (WebCore::RGBA32Buffer::copyRowNTimes):
        (WebCore::RGBA32Buffer::setSize):
        (WebCore::RGBA32Buffer::asNewNativeImage):
        (WebCore::RGBA32Buffer::hasAlpha):
        (WebCore::RGBA32Buffer::disposalMethod):
        (WebCore::RGBA32Buffer::setHasAlpha):
        (WebCore::RGBA32Buffer::setStatus):
        (WebCore::RGBA32Buffer::setDisposalMethod):
        (WebCore::RGBA32Buffer::setRGBA):
        (WebCore::RGBA32Buffer::operator=):
        (WebCore::RGBA32Buffer::width):
        (WebCore::RGBA32Buffer::height):
        (WebCore::RGBA32Buffer::getAddr):
        * platform/image-decoders/skia/JPEGImageDecoder.cpp: Add #include needed by JPEG headers on some platforms, plus comment.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Unreviewed build correction.

        Revert accidental configuration checkin.  Was not meant to
        be part of the last changeset.

        * config.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26353
        Corrects handling of Cairo fonts that were getting out of
        sync due to default copy construction.  Also refactors
        some incorrect platform font destruction code that belongs
        in the font object's destructor.

        * platform/graphics/win/FontPlatformData.h:
        * platform/graphics/win/FontPlatformDataCGWin.cpp:
        (WebCore::FontPlatformData::~FontPlatformData):
        * platform/graphics/win/FontPlatformDataCairoWin.cpp:
        (WebCore::FontPlatformData::platformDataInit):
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::setFont):
        (WebCore::FontPlatformData::~FontPlatformData):
        * platform/graphics/win/FontPlatformDataWin.cpp:
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/win/SimpleFontDataWin.cpp:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebCore:

2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog-2007-10-14: Update my email address.
        * ChangeLog-2008-08-10: Update my email address.

WebKit/mac:

2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog-2007-10-14: Change pseudonym "Don Gibson" to me (was used while Google Chrome was not public); update my email address.

WebKit/win:

2009-06-12  Peter Kasting  <pkasting@google.com>

        Reviewed by Eric Seidel.

        * ChangeLog: Update my email address.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by David Levin.

        Upstream V8Helpers.

        https://bugs.webkit.org/show_bug.cgi?id=26332

        * bindings/v8/V8Helpers.cpp: Added.
        (wrapNPObject): Moved from v8_helpers.cpp.
        (toV8Context): Moved from v8_helpers.cpp.
        (toV8Proxy): Moved from v8_helpers.cpp.
        * bindings/v8/V8Helpers.h: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

===================================================================
--- WebCore/ChangeLog	(revision 44622)
+++ WebCore/ChangeLog	(working copy)
@@ -1,3 +1,23 @@
+2009-06-12  Jessie Berlin  <jberlin@apple.com>
+
+        Reviewed by Mark Rowe.
+
+        https://bugs.webkit.org/show_bug.cgi?id=24792
+        rdar://problem/6933055
+
+        Changes the radius in which cursor movement around the 4 arrow icon
+        while pan-scrolling does not cause scrolling from around 10 pixels to
+        15 pixels, similar to what is found in IE and Firefox.
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::setPanScrollCursor):
+        Factor out the no-pan-scroll radius.
+        * platform/ScrollView.h:
+        Create a constant for the no-pan-scroll radius.
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::panScrollFromPoint):
+        Factor out the no-pan-scroll radius.
+
 2009-06-12  Xan Lopez  <xlopez@igalia.com>
 
         Reviewed by Gustavo Noronha.
Index: WebCore/page/EventHandler.cpp
===================================================================
--- WebCore/page/EventHandler.cpp	(revision 44622)
+++ WebCore/page/EventHandler.cpp	(working copy)
@@ -661,11 +661,10 @@ void EventHandler::setPanScrollCursor()
 
     // At the original click location we draw a 4 arrowed icon. Over this icon there won't be any scroll
     // So we don't want to change the cursor over this area
-    const int noScrollRadius = 9;
-    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - noScrollRadius);
-    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + noScrollRadius);
-    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + noScrollRadius);
-    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - noScrollRadius);
+    bool east = m_panScrollStartPos.x() < (m_currentMousePosition.x() - ScrollView::noPanScrollRadius);
+    bool west = m_panScrollStartPos.x() > (m_currentMousePosition.x() + ScrollView::noPanScrollRadius);
+    bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() + ScrollView::noPanScrollRadius);
+    bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() - ScrollView::noPanScrollRadius);
          
     if (north) {
         if (east)
Index: WebCore/platform/ScrollView.h
===================================================================
--- WebCore/platform/ScrollView.h	(revision 44622)
+++ WebCore/platform/ScrollView.h	(working copy)
@@ -214,7 +214,8 @@ public:
     virtual void hide();
     virtual void setParentVisible(bool);
     
-    // Pan scrolling methods.
+    // Pan scrolling.
+    static const int noPanScrollRadius = 15;
     void addPanScrollIcon(const IntPoint&);
     void removePanScrollIcon();
 
Index: WebCore/rendering/RenderLayer.cpp
===================================================================
--- WebCore/rendering/RenderLayer.cpp	(revision 44622)
+++ WebCore/rendering/RenderLayer.cpp	(working copy)
@@ -948,7 +948,6 @@ void RenderLayer::panScrollFromPoint(con
     const int shortDistanceLimit = 100;  // We delimit a 200 pixels long square enclosing the original point
     const int speedReducer = 2;          // Within this square we divide the scrolling speed by 2
     
-    const int iconRadius = 10;
     Frame* frame = renderer()->document()->frame();
     if (!frame)
         return;
@@ -965,9 +964,9 @@ void RenderLayer::panScrollFromPoint(con
     int xDelta = currentMousePosition.x() - sourcePoint.x();
     int yDelta = currentMousePosition.y() - sourcePoint.y();
 
-    if (abs(xDelta) < iconRadius) // at the center we let the space for the icon
+    if (abs(xDelta) < ScrollView::noPanScrollRadius) // at the center we let the space for the icon
         xDelta = 0;
-    if (abs(yDelta) < iconRadius)
+    if (abs(yDelta) < ScrollView::noPanScrollRadius)
         yDelta = 0;
 
     // Let's attenuate the speed for the short distances


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Jan Michael Alonzo.

        [Qt] Fix build break
        https://bugs.webkit.org/show_bug.cgi?id=26340

        * JavaScriptCore.pri: Add JSONObject.cpp to LUT files.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Gustavo Noronha.

        https://bugs.webkit.org/show_bug.cgi?id=25609
        [GTK] Implement support for get_selection and get_n_selections

        Only use the VisibleSelection object if it actually belongs to the
        object we are using.

        This is pretty hacky-ish, but I can't seem to find a direct API to
        get the VisibleSelection for a given object, only the global one.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (selectionBelongsToObject):
        (webkit_accessible_text_get_n_selections):
        (webkit_accessible_text_get_selection):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=2628i
        Converted LayoutTests\editing\deleting\4875189.html from a pixel test t
 dumpAsText test
        since it only checks whether the result contains exactly two paragraphs
or not.

        * editing/deleting/4875189-expected.txt: Added.
        * editing/deleting/4875189.html:
        * platform/mac/editing/deleting/4875189-expected.checksum: Removed.
        * platform/mac/editing/deleting/4875189-expected.png: Removed.
        * platform/mac/editing/deleting/4875189-expected.txt: Removed.
        * platform/qt/editing/deleting/4875189-expected.txt: Removed.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Xan Lopez.

        Add a test to perform an actual download.

        * tests/testdownload.c:
        (navigation_policy_decision_requested_cb):
        (notify_status_cb):
        (download_requested_cb):
        (test_webkit_download_perform):
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Xan Lopez.

        Fix crash when downloading, caused by assuming SoupMessage would
        be there. This change factors the logic required to create a
        ResourceRequest from a WebKitNetworkRequest into a core()
        function, like we have for some other classes.

        * webkit/webkitdownload.cpp:
        (webkit_download_start):
        * webkit/webkitprivate.cpp:
        (WebKit::core):
        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_load_request):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Rubber stamped by Dave Levin.

        Add missing pixel results

        * platform/mac/editing/style/apply-through-end-of-document-expected.checksum: Added.
        * platform/mac/editing/style/apply-through-end-of-document-expected.png: Added.
        * platform/mac/fast/canvas/canvas-empty-image-pattern-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
        * platform/mac/fast/canvas/canvas-empty-image-pattern-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.
        * platform/mac/fast/css/compare-content-style-expected.checksum: Added.
        * platform/mac/fast/css/compare-content-style-expected.png: Added.
        * platform/mac/fast/dynamic/anchor-lock-expected.checksum: Added.
        * platform/mac/fast/dynamic/anchor-lock-expected.png: Added.
        * platform/mac/fast/transforms/bounding-rect-zoom-expected.checksum: Added.
        * platform/mac/fast/transforms/bounding-rect-zoom-expected.png: Added.
        * platform/mac/webarchive/test-link-rel-icon-expected.checksum: Copied from LayoutTests/platform/mac-tiger/svg/custom/mask-excessive-malloc-expected.checksum.
        * platform/mac/webarchive/test-link-rel-icon-expected.png: Copied from LayoutTests/platform/mac/dom/xhtml/level3/core/canonicalform08-expected.png.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Steve Falkenburg.

        https://bugs.webkit.org/show_bug.cgi?id=26306

        Revert 42565 as it leads to DumpRenderTree crashing on startup because
        Windows can't find CFURLCacheCopySharedURLCache in CoreNetwork.dll.

        * DumpRenderTree/win/DumpRenderTree.cpp:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=25512
        Handle texts after unfinished special tags (i.e., script, style, textarea,
        title, xmp, and iframe) as the text node under the tags in view-source mode.
        Before this change, all texts in unfinished special tags cannot be seen even in view-source mode.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Holger Freyther.

        Fix compilation warnings
        <https://bugs.webkit.org/show_bug.cgi?id=26015>

        * wtf/ThreadingNone.cpp:
        (WTF::ThreadCondition::wait): Fix compilation warning.
        (WTF::ThreadCondition::timedWait): Ditto.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Holger Freyther.

        [Qt] Fix release build detection
        https://bugs.webkit.org/show_bug.cgi?id=26267

        * WebKit.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=26291

        [Qt] build break in ImageDecoderQt.cpp.

        * platform/graphics/qt/ImageDecoderQt.cpp:
        (WebCore::ImageDecoderQt::reset):
        (WebCore::ImageDecoderQt::setData):
        (WebCore::ImageDecoderQt::isSizeAvailable):
        * platform/image-decoders/ImageDecoder.h:
        (WebCore::ImageDecoder::setSize):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

        Reviewed by Eric Seidel.

        Fixes https://bugs.webkit.org/show_bug.cgi?id=26309.
        Update a few items in the testing language to:
        (1) Reflect results are now generated with Leopard (not Tiger)
        (2) Explain how to generate pixel-level layout tests.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@44604 268f45cc-cd09-0410-ab3c-d52691b4dbfc