1. 15 Mar, 2007 16 commits
    • thatcher's avatar
      Finally a real build fix. · b2fdc30b
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20225 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2fdc30b
    • thatcher's avatar
      Yet another build fix. Sigh. · c062a608
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20224 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c062a608
    • thatcher's avatar
      Another build fix attempt. · 1582e732
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1582e732
    • thatcher's avatar
      Attempt to fix the build. · 5fc4a4ed
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fc4a4ed
    • thatcher's avatar
      Build fix. · 9b31b4fe
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20221 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b31b4fe
    • bdakin's avatar
      Reviewed by Hyatt. · d7b88aec
      bdakin authored
              Fix for <rdar://problem/5065396> REGRESSION: leaks in 
              RenderBlock::layoutInlineChildren seen on buildbot
      
              This leak appeared after http://trac.webkit.org/projects/webkit/
              changeset/20188. This change shifted line boxes around in 
              removeChild(). But since removeChild() calls 
              setNeedsLayoutAndMinMaxRecalc(), all of the line boxes will be 
              removed once we actually lay out anyway. So this patch fixes the 
              leak by deleting the line boxes instead of shifting them around. 
      
              * editing/IndentOutdentCommand.cpp:
              (WebCore::IndentOutdentCommand::outdentParagraph): Call into 
              updateLayout(). This fixes an assertion I got in editing/
              execCommand/4976800.html This is very similar to the line box fix I 
              made recently (http://trac.webkit.org/projects/webkit/changeset/
              20177). We need to update layout before relying on VisiblePositions 
              after removing a node.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::deleteLinesForBlock): New helper function 
              since this functionality is needed in three places now.
              (WebCore::RenderBlock::makeChildrenNonInline): Call into new 
              deleteLinesForBlock().
              (WebCore::RenderBlock::removeChild): Same.
              * rendering/RenderBlock.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20220 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d7b88aec
    • thatcher's avatar
      JavaScriptCore: · 04880a02
      thatcher authored
              Reviewed by John.
      
              * Factored out most of our common build settings into .xcconfig files. Anything that was common in
                each build configuration was factored out into the shared .xcconfig file.
              * Adds a Version.xcconfig file to define the current framework version, to be used in other places.
              * Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
              * Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
      
              * Configurations/Base.xcconfig: Added.
              * Configurations/DebugRelease.xcconfig: Added.
              * Configurations/JavaScriptCore.xcconfig: Added.
              * Configurations/Version.xcconfig: Added.
              * Info.plist:
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      JavaScriptGlue:
      
              Reviewed by John.
      
              * Factored out most of our common build settings into .xcconfig files. Anything that was common in
                each build configuration was factored out into the shared .xcconfig file.
              * Adds a Version.xcconfig file to define the current framework version, to be used in other places.
              * Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
              * Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
      
              * Configurations/Base.xcconfig: Added.
              * Configurations/DebugRelease.xcconfig: Added.
              * Configurations/JavaScriptGlue.xcconfig: Added.
              * Configurations/Version.xcconfig: Added.
              * Info.plist:
              * JavaScriptGlue.xcodeproj/project.pbxproj:
      
      WebCore:
      
              Reviewed by John.
      
              * Factored out most of our common build settings into .xcconfig files. Anything that was common in
                each build configuration was factored out into the shared .xcconfig file.
              * Adds a Version.xcconfig file to define the current framework version, to be used in other places.
              * Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
              * Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
      
              * Configurations/Base.xcconfig: Added.
              * Configurations/DebugRelease.xcconfig: Added.
              * Configurations/Version.xcconfig: Added.
              * Configurations/WebCore.xcconfig: Added.
              * Info.plist:
              * WebCore.xcodeproj/project.pbxproj:
      
      WebKit:
      
              Reviewed by John.
      
              * Fixes: <rdar://problem/4927747> WebKit's Current Library Version number should match the Info.plist Version
              * Factored out most of our common build settings into .xcconfig files. Anything that was common in
                each build configuration was factored out into the shared .xcconfig file.
              * Adds a Version.xcconfig file to define the current framework version, to be used in other places.
              * Use the new $(BUNDLE_VERSION) (defined in Version.xcconfig) in the preprocessed Info.plist.
              * Use the versions defined in Version.xcconfig to set $(DYLIB_CURRENT_VERSION).
              * Make WebKit use the same warning flags as the other projects. This required two casts to be added to fix new warnings.
      
              * Configurations/Base.xcconfig: Added.
              * Configurations/DebugRelease.xcconfig: Added.
              * Configurations/Version.xcconfig: Added.
              * Configurations/WebKit.xcconfig: Added.
              * Info.plist:
              * Misc/WebKitVersionChecks.h:
              * Plugins/WebBaseNetscapePluginStream.m:
              (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
              * WebKit.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20219 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04880a02
    • kdecker's avatar
      Reviewed by Anders. · 763b6b50
      kdecker authored
              Fixed: <rdar://problem/5001428> stationery background images do not display
             
              Change 19244 fixed the method -[WebResource _shouldIgnoreWhenUnarchiving], but also broke Mail stationery.
              
              The problem was that with archivedResourceForURL now fixed, the engine will try to decode the images.  These images wouldn't decode because
              Mail re-encodes and directly manipulates the image data in such a way that prevented WebKit from decoding the image.  Because Mail was giving
              us bad data, the images wouldn't render.  This was never an issue before because archivedResourceForURL (broken) always returned nil, thus the
              engine would never attempt to decode the resource, therefore the responsibility was delegated to Mail's protocol handler, which would do the 
              right thing and load the image.
              
              Since Mail is relying on the fact it can store arbitrary data in WebArchives, I've introduced SPI that acts as a hint for us to ignore certain 
              subresources while unarchiving. This SPI is -[WebResource _shouldIgnoreWhenUnarchiving].
              
              * WebView/WebResource.mm: Addd private ivar shouldIgnoreWhenUnarchiving.
              (-[WebResource _ignoreWhenUnarchiving]): Added.
              (-[WebResource _shouldIgnoreWhenUnarchiving]): Added.
              * WebView/WebResourcePrivate.h: Added two methods to private header.
              * WebView/WebUnarchivingState.m:
              (-[WebUnarchivingState archivedResourceForURL:]): Check if we should ignore the resource.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20217 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      763b6b50
    • kjk's avatar
      Not reviewed - gdk build fixes. · a61bd05e
      kjk authored
              * platform/gdk/EditorClientGdk.cpp:
              (WebCore::EditorClientGdk::handleKeypress):
              * platform/graphics/cairo/ImageSourceCairo.cpp:
              (WebCore::ImageSource::setData):
              * platform/graphics/gdk/ImageGdk.cpp:
              (WebCore::Image::loadPlatformResource):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a61bd05e
    • justing's avatar
      LayoutTests: · 5e10a81c
      justing authored
              Reviewed by john
      
              Removed an unnecessary block (one that was fully
              selected but whose markup wasn't needed to preserve
              appearance):
              * editing/pasteboard/paste-text-011-expected.txt:
              Removed unnecessary style spans:
              * editing/pasteboard/merge-end-blockquote-expected.txt:
              Removed unnecessary empty anonymous blocks:
              * editing/execCommand/create-list-with-hr-expected.txt:
              * editing/pasteboard/display-block-on-spans-expected.txt:
              * editing/pasteboard/paste-text-006-expected.txt:
              * editing/pasteboard/paste-table-001-expected.txt:
              * editing/pasteboard/paste-text-013-expected.txt:
              * editing/pasteboard/paste-text-002-expected.txt:
              * editing/pasteboard/paste-list-001-expected.txt:
              * editing/pasteboard/paste-text-005-expected.txt:
              * editing/pasteboard/paste-text-003-expected.txt:
              * editing/pasteboard/paste-text-014-expected.txt:
              * editing/pasteboard/paste-pre-001-expected.txt:
              Now (correctly) includes fully selected root:
              * editing/pasteboard/paste-text-015-expected.checksum:
              * editing/pasteboard/paste-text-015-expected.png:
              * editing/pasteboard/paste-text-015-expected.txt:
              * editing/inserting/insert-3907422-fix-expected.txt:
              * editing/pasteboard/paste-text-004-expected.txt:
              Demonstrates a bug that already existed (we don't inline 
              the font styles from the Preference Pane on copy):
              * editing/pasteboard/5027857-expected.checksum:
              * editing/pasteboard/5027857-expected.png:
              * editing/pasteboard/5027857-expected.txt:
              * editing/pasteboard/paste-pre-002-expected.checksum:
              * editing/pasteboard/paste-pre-002-expected.png:
              * editing/pasteboard/paste-pre-002-expected.txt:
      
      WebCore:
      
              Reviewed by john
              
              ~2x speed up of 5k rich text paste:
              http://shakespeare.mit.edu/hamlet/full.html        
      
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::doApply): Remove the top 
              level style span if its unnecessary before inserting
              into the document, its faster than doing it after.
              * editing/ReplaceSelectionCommand.h: Exposed 
              ReplacementFragment::removeNodePreservingChildren so that
              the style span can be removed using non-undoable removes,
              like the rest of the removes done on the ReplacementFragment.
              * editing/markup.cpp:
              (WebCore::createMarkup): Make the style span the top level
              element, otherwise it's useless.  This also facilitates the
              optimization mentioned above.
              When including markup for a fully selected root, include markup
              for all the nodes beneath that fully selected root, to preserve 
              the structure and appearance of the copied markup.  Did this
              by merging with the code for adding markup for descendants of
              special commonAncestorBlocks.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e10a81c
    • bdakin's avatar
      Rubber-stamped by Adele. · 2f06e491
      bdakin authored
              Rolling out http://trac.webkit.org/projects/webkit/changeset/20148 
              (which is a fix for http://bugs.webkit.org/show_bug.cgi?id=12595 
              and rdar://4722863) because it causes a horrible memory-trasher.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20214 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2f06e491
    • bdash's avatar
      2007-03-16 Shrikant Gangoda <shrikant.gangoda@celunite.com> · 16e4c706
      bdash authored
              Gdk build fix.
      
              * kjs/DateMath.cpp:  gettimeofday comes from <sys/time.h> on Linux.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20213 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16e4c706
    • bdash's avatar
      2007-03-15 Mark Rowe <mrowe@apple.com> · 9fb26f81
      bdash authored
              Reviewed by Antti.
      
              Fix for <rdar://problem/5065060> ASSERTION FAILURE: newUsername && newPassword
              when submitting an authentication form without password.
      
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchWillSubmitForm): Don't omit form fields with empty values from the dictionary
              passed to the delegate.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20212 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9fb26f81
    • ggaren's avatar
      Added an assert to help catch a bug. Hopefully someone will hit it! · 44fd9c68
      ggaren authored
              
              * bindings/js/kjs_proxy.cpp:
              (WebCore::KJSProxy::~KJSProxy):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20211 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      44fd9c68
    • andersca's avatar
      Reviewed by Dave Hyatt. · 6945702d
      andersca authored
              Don't add the data twice, it's also done by didReceiveData.
              
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::deliverArchivedResources):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20210 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6945702d
    • oliver's avatar
      2007-03-14 Oliver Hunt <oliver@apple.com> · 01dd65f4
      oliver authored
              Reviewed by Adele.
      
              Fix for rdar://problem/5061737.
              
              This was a regression from the original Objective-C -> C++ conversion
              for the drag logic.  We don't need to call Range::startNode as we just
              need the document that contains the range.   
      
              * page/DragController.cpp:
              (WebCore::documentFragmentFromDragData):
      LayoutTests:
              Layout tests for rdar://problem/5061737
      
              * editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt: Added.
              * editing/pasteboard/drag-image-to-contenteditable-in-iframe.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20209 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01dd65f4
  2. 14 Mar, 2007 24 commits
    • andersca's avatar
      Fix segmentation fault when running layout tests. · 7e2db9e7
      andersca authored
              Remove bogus check that that I added on purpose to see how good Geoff is at spotting mistakes when reviewing code.
              (Turns out he's not that good!)
              
              * WebView/WebDocumentLoaderMac.mm:
              (WebDocumentLoaderMac::increaseLoadCount):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20208 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e2db9e7
    • kmccullo's avatar
      Reviewed by . · e78f0bcc
      kmccullo authored
              Silly wrapping change for testing a post-commit hook change.
      
              * contact.html:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20207 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e78f0bcc
    • andersca's avatar
      Reviewed by Geoff. · 3f18aeee
      andersca authored
              http://bugs.webkit.org/show_bug.cgi?id=13076
              REGRESSION: Multiple loading tabs cause assertion in WebDocumentLoaderMac::decreaseLoadCount(unsigned long)
      
              Store the identifier set in the document loader since identifiers are per-webview and not global.
              
              * WebView/WebDocumentLoaderMac.h:
              * WebView/WebDocumentLoaderMac.mm:
              (WebDocumentLoaderMac::WebDocumentLoaderMac):
              (WebDocumentLoaderMac::attachToFrame):
              (WebDocumentLoaderMac::increaseLoadCount):
              (WebDocumentLoaderMac::decreaseLoadCount):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f18aeee
    • kmccullo's avatar
      Reviewed by . · eddb0571
      kmccullo authored
              - Fixed one more build breakage
      
              * kjs/date_object.cpp:
              (KJS::formatLocaleDate):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eddb0571
    • kmccullo's avatar
      Reviewed by . · e4255dd9
      kmccullo authored
              - Fixed a build breakage.
      
              * kjs/DateMath.cpp:
              * kjs/date_object.cpp:
              (KJS::formatLocaleDate):
              (KJS::DateObjectImp::construct):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e4255dd9
    • kmccullo's avatar
      JavaScriptCore: · 014b4536
      kmccullo authored
              Reviewed by Geoff.
      
              - rdar://problem/5045720
              - DST changes in US affect JavaScript date calculations (12975)
              This fix was to ensure we properly test for the new changes to DST in the US.
              Also this fixes when we apply DST, now we correctly map most past years to current
              DST rules.  We still have a small issue with years before 1900 or after 2100.
              rdar://problem/5055038
      
              * kjs/DateMath.cpp: Fix DST to match spec better.
              (KJS::getCurrentUTCTime):
              (KJS::mimimumYearForDST):
              (KJS::maximumYearForDST):
              (KJS::equivalentYearForDST):
              (KJS::getDSTOffset):
              * kjs/DateMath.h: Consolodated common funtionality.
              * kjs/date_object.cpp: Consolodated common functionality.
              (KJS::formatLocaleDate):
              (KJS::DateObjectImp::construct):
              * tests/mozilla/ecma/jsref.js: Added functions for finding the correct days when DST starts and ends.
              * tests/mozilla/ecma/shell.js: Added back in the old DST functions for ease of merging with mozilla if needed.
              * tests/mozilla/ecma_2/jsref.js: Added functions for finding the correct days when DST starts and ends.
              * tests/mozilla/ecma_3/Date/shell.js: Added functions for finding the correct days when DST starts and ends.
              * tests/mozilla/expected.html: Updated to show all date tests passing.
      
      LayoutTests:
      
              Reviewed by Geoff.
      
              - rdar://problem/5045720
              - DST changes in US affect JavaScript date calculations (12975)
              Changed layout tests to properly check for the new changes to DST in the
              US. Also these now test that equivalent years return the same results for DST.
      
              * fast/js/date-DST-time-cusps-expected.txt:
              * fast/js/date-big-setdate-expected.txt:
              * fast/js/resources/date-DST-time-cusps.js:
              * fast/js/resources/date-big-setdate.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      014b4536
    • weinig's avatar
      LayoutTests: · 5a5b938d
      weinig authored
              Reviewed by Hyatt.
      
              - test for://bugs.webkit.org/show_bug.cgi?id=13071
                REGRESSION: Plain text files no longer wrap lines longer than the width of the browser window
      
              * fast/loader/resources/text-document-wrapping.txt: Added.
              * fast/loader/text-document-wrapping-expected.checksum: Added.
              * fast/loader/text-document-wrapping-expected.png: Added.
              * fast/loader/text-document-wrapping-expected.txt: Added.
              * fast/loader/text-document-wrapping.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - http://bugs.webkit.org/show_bug.cgi?id=13071
                REGRESSION: Plain text files no longer wrap lines longer than the width of the browser window
      
              Test: fast/loader/text-document-wrapping.html
      
              * loader/TextDocument.cpp:
              (WebCore::TextTokenizer::write): Specified word-wrap:break-word for the <pre> element.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20202 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5a5b938d
    • harrison's avatar
      Reviewed by Maciej. · ab34f98a
      harrison authored
              <rdar://problem/5009625> REGRESSION: Aperture 1.5: Can't select entire line of text after correcting a misspelled word
      
              * WebCoreSupport/WebEditorClient.mm:
              (WebEditorClient::respondToChangedSelection):
              * WebCoreSupport/WebFrameBridge.mm:
              Provide compatibility by not sending WebViewDidChangeSelectionNotification if
              the app is Aperture and is linked against WebKit 2.0.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab34f98a
    • weinig's avatar
      LayoutTests: · 98726dac
      weinig authored
              Reviewed by Hyatt.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=13072
                REGRESSION (r15617): white-space: pre-wrap breaks off the last character of a wide word
      
              * fast/text/whitespace/pre-wrap-last-char-expected.checksum: Added.
              * fast/text/whitespace/pre-wrap-last-char-expected.png: Added.
              * fast/text/whitespace/pre-wrap-last-char-expected.txt: Added.
              * fast/text/whitespace/pre-wrap-last-char.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=13072
                REGRESSION (r15617): white-space: pre-wrap breaks off the last character of a wide word
      
              Test: fast/text/whitespace/pre-wrap-last-char.html
      
              * rendering/bidi.cpp:
              (WebCore::RenderBlock::findNextLineBreak): Undid the change from r15617.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      98726dac
    • hyatt's avatar
      Add asserts to help catch double refs and double derefs of CachedResources. · f56c4413
      hyatt authored
              Reviewed by mjs
      
              * loader/CachedResource.cpp:
              (WebCore::CachedResource::ref):
              (WebCore::CachedResource::deref):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f56c4413
    • aliceli1's avatar
      Rubber-stamped by Hyatt. · 3163197d
      aliceli1 authored
              Adding null check to prevent the crash that happens on 2nd run of iBench HTML load test
      
              * loader/icon/IconDataCache.cpp:
              (WebCore::IconDataCache::writeToDatabase):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3163197d
    • adele's avatar
      Reviewed by Adam. · 15b52e0a
      adele authored
              Fix for <rdar://problem/5062898> REGRESSION: autocomplete window in text fields doesn't come up
      
              When we moved the initialization of a bunch of variables in the HTMLFormElement constructor, m_autocomplete accidently got initialized to false.
      
              * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::HTMLFormElement):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      15b52e0a
    • sfalken's avatar
      2007-03-14 Steve Falkenburg <sfalken@apple.com> · ddc61b50
      sfalken authored
              Reviewed by Adam.
      
              Added missing null check in case this is called on a subframe
              that hasn't started loading.
      
              * page/Frame.cpp:
              (WebCore::Frame::setMarkedTextMatchesAreHighlighted): Check for a null document.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ddc61b50
    • andersca's avatar
      Reviewed by Geoff. · af0f8bdf
      andersca authored
              <rdar://problem/5058714>
              http://bugs.webkit.org/show_bug.cgi?id=13050
              
              World leaks seen on Leopard after opening then closing tab (13050)
      
              Add a hash set to prevent the load count to be increased twice for the same resource.
              
              * WebCoreSupport/WebFrameLoaderClient.mm:
              (WebFrameLoaderClient::dispatchWillSendRequest):
              (WebFrameLoaderClient::dispatchDidFinishLoading):
              (WebFrameLoaderClient::dispatchDidFailLoading):
              * WebView/WebDocumentLoaderMac.h:
              * WebView/WebDocumentLoaderMac.mm:
              (loadingResources):
              (WebDocumentLoaderMac::increaseLoadCount):
              (WebDocumentLoaderMac::decreaseLoadCount):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      af0f8bdf
    • antti's avatar
      Reviewed by Geoff. · 0e45dad8
      antti authored
              Fix http://bugs.webkit.org/show_bug.cgi?id=13060
              REGRESSION: Repro ASSERT failure in Cache::adjustSize running layout tests
              <rdar://5060208>
              
              Script evaluation may have dereffed the CachedScript object already, causing double deref and
              eventually m_liveResourcesSize underflow.
      
              * html/HTMLScriptElement.cpp:
              (WebCore::HTMLScriptElement::notifyFinished):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e45dad8
    • adele's avatar
      WebCore: · a21aa1a7
      adele authored
              Reviewed by Darin.
      
              Added InsertTab, InsertBacktab, InsertLineBreak, and InsertNewline to the editing command table.
              Added Event parameter to execCommand, and to all of the enabled and exec functions.  Right now,
              the event is only used by the newly added commands.  But in the future, many (and possibly all) of
              these editing commands will need to consider the event so they are applied to the correct selection.
      
              * WebCore.exp:
              * editing/Editor.cpp:
              (WebCore::execCopy):
              (WebCore::execCut):
              (WebCore::execDelete):
              (WebCore::execBackwardDelete):
              (WebCore::execForwardDelete):
              (WebCore::execMoveBackward):
              (WebCore::execMoveBackwardAndModifySelection):
              (WebCore::execMoveUpByPageAndModifyCaret):
              (WebCore::execMoveDown):
              (WebCore::execMoveDownAndModifySelection):
              (WebCore::execMoveForward):
              (WebCore::execMoveForwardAndModifySelection):
              (WebCore::execMoveDownByPageAndModifyCaret):
              (WebCore::execMoveLeft):
              (WebCore::execMoveLeftAndModifySelection):
              (WebCore::execMoveRight):
              (WebCore::execMoveRightAndModifySelection):
              (WebCore::execMoveToBeginningOfDocument):
              (WebCore::execMoveToBeginningOfDocumentAndModifySelection):
              (WebCore::execMoveToBeginningOfSentence):
              (WebCore::execMoveToBeginningOfSentenceAndModifySelection):
              (WebCore::execMoveToBeginningOfLine):
              (WebCore::execMoveToBeginningOfLineAndModifySelection):
              (WebCore::execMoveToBeginningOfParagraph):
              (WebCore::execMoveToBeginningOfParagraphAndModifySelection):
              (WebCore::execMoveToEndOfDocument):
              (WebCore::execMoveToEndOfDocumentAndModifySelection):
              (WebCore::execMoveToEndOfSentence):
              (WebCore::execMoveToEndOfSentenceAndModifySelection):
              (WebCore::execMoveToEndOfLine):
              (WebCore::execMoveToEndOfLineAndModifySelection):
              (WebCore::execMoveToEndOfParagraph):
              (WebCore::execMoveToEndOfParagraphAndModifySelection):
              (WebCore::execMoveParagraphBackwardAndModifySelection):
              (WebCore::execMoveParagraphForwardAndModifySelection):
              (WebCore::execMoveUp):
              (WebCore::execMoveUpAndModifySelection):
              (WebCore::execMoveWordBackward):
              (WebCore::execMoveWordBackwardAndModifySelection):
              (WebCore::execMoveWordForward):
              (WebCore::execMoveWordForwardAndModifySelection):
              (WebCore::execMoveWordLeft):
              (WebCore::execMoveWordLeftAndModifySelection):
              (WebCore::execMoveWordRight):
              (WebCore::execMoveWordRightAndModifySelection):
              (WebCore::execPaste):
              (WebCore::execSelectAll):
              (WebCore::execToggleBold):
              (WebCore::execToggleItalic):
              (WebCore::execRedo):
              (WebCore::execUndo):
              (WebCore::execInsertTab):
              (WebCore::execInsertBacktab):
              (WebCore::execInsertNewline):
              (WebCore::execInsertLineBreak):
              (WebCore::enabled):
              (WebCore::canPaste):
              (WebCore::hasEditableSelection):
              (WebCore::hasEditableRangeSelection):
              (WebCore::hasRangeSelection):
              (WebCore::hasRichlyEditableSelection):
              (WebCore::canRedo):
              (WebCore::canUndo):
              (WebCore::CommandEntry::):
              (WebCore::Editor::toggleBold):
      
              (WebCore::Editor::execCommand): Added optional event parameter.
              (WebCore::Editor::insertText): Added.  Calls handleTextInputEvent.
              (WebCore::Editor::insertTextWithoutSendingTextEvent): Renamed from insertText.
               Performs the actual insertion without dispatching any event.
              * editing/Editor.h:
              * page/EventHandler.cpp: (WebCore::EventHandler::defaultTextInputEventHandler):
                Call insertTextWithoutSendingTextEvent.
      
      WebKit:
      
              Reviewed by Darin.
      
              Removed _insertTextWithEvent, _insertNewlineWithEvent, and _insertTextWithEvent.
              Instead, use execCommand and insertText methods on the Editor.
      
              * WebView/WebHTMLView.mm:
              (-[WebHTMLView insertTab:]):
              (-[WebHTMLView insertBacktab:]):
              (-[WebHTMLView insertNewline:]):
              (-[WebHTMLView insertLineBreak:]):
              (-[WebHTMLView insertParagraphSeparator:]):
              (-[WebHTMLView insertNewlineIgnoringFieldEditor:]):
              (-[WebHTMLView insertTabIgnoringFieldEditor:]):
              (-[WebHTMLView yank:]):
              (-[WebHTMLView yankAndSelect:]):
              (-[WebHTMLView doCommandBySelector:]):
              (-[WebHTMLView insertText:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a21aa1a7
    • justing's avatar
      I forgot to update this expected result in my previous checkin. · 42cfb678
      justing authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      42cfb678
    • justing's avatar
      LayoutTests: · 867f199a
      justing authored
              Reviewed by darin
      
              Removed unnecessary style spans:
              * editing/deleting/delete-3857753-fix-expected.txt:
              * editing/execCommand/4916541-expected.txt:
              * editing/execCommand/create-list-from-range-selection-expected.txt:
              * editing/execCommand/format-block-expected.txt:
              * editing/execCommand/format-block-from-range-selection-expected.txt:
              * editing/execCommand/format-block-with-braces-expected.txt:
              * editing/execCommand/indent-selection-expected.txt:
              * editing/execCommand/remove-list-from-range-selection-expected.txt:
              * editing/execCommand/remove-list-items-expected.txt:
              * editing/execCommand/switch-list-type-expected.txt:
              * editing/pasteboard/4861080-expected.txt:
              * editing/pasteboard/display-block-on-spans-expected.txt:
              * editing/pasteboard/drag-drop-modifies-page-expected.txt:
              * editing/pasteboard/paste-table-002-expected.txt:
              * editing/pasteboard/paste-text-001-expected.txt:
              * editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
              * editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
              * editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
              * editing/style/smoosh-styles-001-expected.txt:
              * editing/style/smoosh-styles-002-expected.txt:
      
      WebCore:
      
              Reviewed by darin
              
              ~3x speedup pasting 5k lines of rich text:
              http://shakespeare.mit.edu/hamlet/full.html
              ~2x speedup pasting 10k lines of plain text
              
              * css/CSSComputedStyleDeclaration.cpp:
              (WebCore::computedStyle): Added for convenience.
              * css/CSSComputedStyleDeclaration.h:
              * editing/ReplaceSelectionCommand.cpp:
              (WebCore::ReplaceSelectionCommand::removeRedundantStyles):
              The code that pushed down the top level style span had
              a bug in it that made it do unnecessary work.  Instead of
              fixing the bug I removed the code because it was used to 
              help see more redundancies in second level style spans, but 
              createMarkup now *only* creates a top level style span.
              Only remove redundant styles from style spans and only remove
              unstyled elements if they are style spans.  FF doesn't
              remove redundant styles from elements, or remove redundant 
              font tags on copy/paste.  We could offer this functionality 
              through a separate "cleanup" command.
              * editing/markup.cpp:
              (WebCore::createMarkup): Only add markup for ancestors of 
              lastClosed if we're including markup for acommonAncestorBlock 
              (we do this for commonAncestorBlocks like tables and lists),
              otherwise it's unnecessary/redundant.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      867f199a
    • andersca's avatar
      Reviewed by Ada. · 9f3a1769
      andersca authored
              Make sure to call ResourceLoader::didReceiveData to ensure that there's a shared buffer with the resource
              data, since SubresourceLoaderClients now make use of that buffer.
              
              * loader/SubresourceLoader.cpp:
              (WebCore::SubresourceLoader::didReceiveData):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f3a1769
    • andersca's avatar
      Get the size from the shared buffer. · 00ee54b1
      andersca authored
              
              * platform/graphics/cg/ImageSourceCG.cpp:
              (WebCore::ImageSource::setData):
              * platform/graphics/cg/PDFDocumentImage.cpp:
              (WebCore::PDFDocumentImage::dataChanged):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00ee54b1
    • weinig's avatar
      LayoutTests: · 760f10f9
      weinig authored
              Reviewed by Hyatt, thumbs up by Darin.
      
              - test for http://bugs.webkit.org/show_bug.cgi?id=12782
                Reproducible crash in BidiContext::deref
      
              * fast/dynamic/anonymous-block-orphaned-lines-expected.checksum: Added.
              * fast/dynamic/anonymous-block-orphaned-lines-expected.png: Added.
              * fast/dynamic/anonymous-block-orphaned-lines-expected.txt: Added.
              * fast/dynamic/anonymous-block-orphaned-lines.html: Added.
      
      WebCore:
      
              Reviewed by Hyatt, thumbs up by Darin.
      
              - fix http://bugs.webkit.org/show_bug.cgi?id=12782
                Reproducible crash in BidiContext::deref
      
              Test: fast/dynamic/anonymous-block-orphaned-lines.html
      
              * rendering/InlineBox.cpp:
              (WebCore::InlineBox::root): Added an assertion that we return a root inline box.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::removeChild): Added code to adopt the line boxes of
              anonymous blocks being destroyed instead of leaving them orphaned, which
              is what caused this crash. The boxes will be deleted on the next layout, but
              this ensures consistency in the mean time.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      760f10f9
    • lars's avatar
      Reviewed by Antti. · 5fe38f17
      lars authored
              Fix the Qt build.
              Add a getter to SharedBuffer that returns a reference to the internal
              Vector to avoid an extra copy of the data.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5fe38f17
    • antti's avatar
      LayoutTests: · e3543b8f
      antti authored
              Reviewed by Mitz.
              
              Test case for <rdar://problem/5058774>
              REGRESSION: In Mail, caret appears oversized when typing in a To Do note
      
              * editing/style/highlight-expected.checksum: Added.
              * editing/style/highlight-expected.png: Added.
              * editing/style/highlight-expected.txt: Added.
              * editing/style/highlight.html: Added.
      
      WebCore:
      
              Reviewed by Mitz.
              
              Fix <rdar://problem/5058774>
              REGRESSION: In Mail, caret appears oversized when typing in a To Do note
              
              Horizontal and vertical were switched. Was regression from
              http://trac.webkit.org/projects/webkit/changeset/20103
      
              * rendering/RootInlineBox.cpp:
              (WebCore::RootInlineBox::addHighlightOverflow):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20186 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e3543b8f
    • hyatt's avatar
      Tweak the data() functions of stylesheets and scripts to be internally consistent. · 1ea6f464
      hyatt authored
              * loader/CachedCSSStyleSheet.cpp:
              (WebCore::CachedCSSStyleSheet::data):
              * loader/CachedScript.cpp:
              (WebCore::CachedScript::data):
              * loader/CachedXSLStyleSheet.cpp:
              (WebCore::CachedXSLStyleSheet::data):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@20185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1ea6f464