1. 24 Jan, 2011 40 commits
    • jberlin@webkit.org's avatar
      WebKit2: LayoutTests: The UNIMPLEMENTED warnings in TextCheckerWin should be disabled · b2f777a9
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=53029
      
      Reviewed by Adam Roben.
      
      * UIProcess/win/TextCheckerWin.cpp:
      Disable the warnings for this file.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b2f777a9
    • andreip@google.com's avatar
      2011-01-24 Andrei Popescu <andreip@google.com> · 616a18bf
      andreip@google.com authored
              Unreviewed, build fix.
      
              LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
              https://bugs.webkit.org/show_bug.cgi?id=53032
      
              Fix the expected output, which still had an error.
      
              * storage/indexeddb/objectstore-autoincrement-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      616a18bf
    • antonm@chromium.org's avatar
      2011-01-24 Anton Muhin <antonm@chromium.org> · ea255cbc
      antonm@chromium.org authored
              Reviewed by Nate Chapin.
      
              [v8] Refactoring: extract IntrusiveDOMWrapperMap into a seprate class and files.
              https://bugs.webkit.org/show_bug.cgi?id=52911
      
              Plain refactoring, covered by the existing tests.
      
              * WebCore.gypi: IntrusiveDOMWrapperMap.h added.
              * bindings/v8/DOMDataStore.cpp: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
              * bindings/v8/DOMDataStore.h: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
              * bindings/v8/IntrusiveDOMWrapperMap.h: Added.
              (WebCore::ChunkedTable::ChunkedTable):
              (WebCore::ChunkedTable::add):
              (WebCore::ChunkedTable::remove):
              (WebCore::ChunkedTable::clear):
              (WebCore::ChunkedTable::visit):
              (WebCore::ChunkedTable::Chunk::Chunk):
              (WebCore::ChunkedTable::clearEntries):
              (WebCore::ChunkedTable::visitEntries):
              (WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
              (WebCore::IntrusiveDOMWrapperMap::get):
              (WebCore::IntrusiveDOMWrapperMap::set):
              (WebCore::IntrusiveDOMWrapperMap::contains):
              (WebCore::IntrusiveDOMWrapperMap::visit):
              (WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
              (WebCore::IntrusiveDOMWrapperMap::clear):
              (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::move):
              (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
              (WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
              * bindings/v8/StaticDOMDataStore.h: include added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ea255cbc
    • commit-queue@webkit.org's avatar
      2011-01-24 Kenji Imasaki <imasaki@chromium.org> · 046a3f91
      commit-queue@webkit.org authored
              Reviewed by Jian Li.
      
              [chromium] Remove non-flaky tests from test expectation file
              https://bugs.webkit.org/show_bug.cgi?id=53022
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      046a3f91
    • andreip@google.com's avatar
      2011-01-24 Andrei Popescu <andreip@google.com> · 55871dc8
      andreip@google.com authored
              Reviewed by Jeremy Orlow.
      
              LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
              https://bugs.webkit.org/show_bug.cgi?id=53032
      
              This fixes the layout test by modifying the arguments to IDBDatabase::transaction.
      
              * storage/indexeddb/objectstore-autoincrement-expected.txt:
              * storage/indexeddb/objectstore-autoincrement.html:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      55871dc8
    • commit-queue@webkit.org's avatar
      2011-01-24 Shane Stephens <shanestephens@google.com> · 4413d10c
      commit-queue@webkit.org authored
              Reviewed by Chris Marrin.
      
              TransformationMatrix multiply operations apply operands in wrong order.
              https://bugs.webkit.org/show_bug.cgi?id=52780
      
              Rename TranformationMatrix::multLeft into multiply (the method does a multRight,
              not a multLeft).
      
              Remove TransformationMatrix::multiply, which was actually doing a multLeft.
      
              Fix TransformationMatrix::operator* and operator*= such that the operand is
              applied to the right-hand side of the matrix that the method is called on.
              i.e., previously "a * b" used to compute "b * a", and "a *= b" used to store
              "b * a" in "a".  This has now been fixed so "a * b" computes "a * b" and
              "a *= b" stores "a * b" in "a".
      
              Convert all call sites for these methods to provide operands in the correct order.
      
              No new tests as patch adds no new functionality.
      
              * css/WebKitCSSMatrix.cpp:
              (WebCore::WebKitCSSMatrix::multiply):
              * platform/graphics/transforms/Matrix3DTransformOperation.h:
              (WebCore::Matrix3DTransformOperation::apply):
              * platform/graphics/transforms/MatrixTransformOperation.h:
              (WebCore::MatrixTransformOperation::apply):
              * platform/graphics/transforms/TransformationMatrix.cpp:
              (WebCore::TransformationMatrix::scaleNonUniform):
              (WebCore::TransformationMatrix::scale3d):
              (WebCore::TransformationMatrix::rotate3d):
              (WebCore::TransformationMatrix::skew):
              (WebCore::TransformationMatrix::applyPerspective):
              (WebCore::TransformationMatrix::multiply):
              (WebCore::TransformationMatrix::recompose):
              * platform/graphics/transforms/TransformationMatrix.h:
              (WebCore::TransformationMatrix::operator*=):
              (WebCore::TransformationMatrix::operator*):
              * rendering/RenderLayer.cpp:
              (WebCore::transparencyClipBox):
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::getTransformFromContainer):
              * rendering/TransformState.cpp:
              (WebCore::TransformState::applyTransform):
              (WebCore::HitTestingTransformState::applyTransform):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4413d10c
    • andersca@apple.com's avatar
      2011-01-24 Anders Carlsson <andersca@apple.com> · ebef3a29
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Wait for half a second if we're asked to paint when receiving a DidSetSize message
              https://bugs.webkit.org/show_bug.cgi?id=53028
      
              * UIProcess/DrawingAreaProxyImpl.cpp:
              (WebKit::DrawingAreaProxyImpl::paint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ebef3a29
    • andersca@apple.com's avatar
      2011-01-24 Anders Carlsson <andersca@apple.com> · a31b9aaa
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Implement forceRedisplay in the new drawing area
              https://bugs.webkit.org/show_bug.cgi?id=53026
      
              * WebProcess/WebPage/DrawingAreaImpl.cpp:
              (WebKit::DrawingAreaImpl::forceRepaint):
              * WebProcess/WebPage/DrawingAreaImpl.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a31b9aaa
    • andersca@apple.com's avatar
      2011-01-24 Anders Carlsson <andersca@apple.com> · 6c85ea42
      andersca@apple.com authored
              Reviewed by Sam Weinig.
      
              Fill unpainted rects with the background color.
              https://bugs.webkit.org/show_bug.cgi?id=53025
      
              * UIProcess/API/mac/WKView.mm:
              (drawPageBackground):
              Add new helper function.
      
              (-[WKView drawRect:]):
              Iterate over the unpainted rects and fill them with the background color.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6c85ea42
    • andreip@google.com's avatar
      2011-01-24 Andrei Popescu <andreip@google.com> · f86bef17
      andreip@google.com authored
              Reviewed by Nate Chapin.
      
              IndexedDatabase methods should not take arguments of type OptionsObject
              https://bugs.webkit.org/show_bug.cgi?id=53012
      
              * storage/indexeddb/create-object-store-options-expected.txt:
              * storage/indexeddb/create-object-store-options.html:
              * storage/indexeddb/cursor-delete-expected.txt:
              * storage/indexeddb/cursor-delete.html:
              * storage/indexeddb/cursor-index-delete-expected.txt:
              * storage/indexeddb/cursor-index-delete.html:
              * storage/indexeddb/data-corruption-expected.txt:
              * storage/indexeddb/data-corruption.html:
              * storage/indexeddb/database-quota-expected.txt:
              * storage/indexeddb/database-quota.html:
              * storage/indexeddb/index-cursor.html:
              * storage/indexeddb/objectstore-basics-expected.txt:
              * storage/indexeddb/objectstore-basics.html:
              * storage/indexeddb/objectstore-cursor.html:
              * storage/indexeddb/open-cursor-expected.txt:
              * storage/indexeddb/open-cursor.html:
              * storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
              * storage/indexeddb/transaction-and-objectstore-calls.html:
              * storage/indexeddb/tutorial.html:
      2011-01-24  Andrei Popescu  <andreip@google.com>
      
              Reviewed by Nate Chapin.
      
              IndexedDatabase methods should not take arguments of type OptionsObject
              https://bugs.webkit.org/show_bug.cgi?id=53012
      
              This patch reverts all IDB methods, except IDBDatabase::createObjectStore and
              IDBObjectStore::createIndex, to using a plain list of arguments instead of
              grouping the various parameters inside a single OptionsObject argument.
              This decision was made on public-webapps@w3.org mailing list.
      
              We also add support (v8 only for now) for passing DOMStringList objects as arguments to native
              methods. The code for obtaining a DOMStringList object from a JS array of strings existed already
              in OptionsObject.cpp, I just copied it to V8Bindings.cpp and taught the v8 code generator how to
              use it.
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/V8Binding.cpp:
              (WebCore::v8ValueToWebCoreDOMStringList):
              * bindings/v8/V8Binding.h:
              * storage/IDBDatabase.cpp:
              (WebCore::IDBDatabase::transaction):
              * storage/IDBDatabase.h:
              (WebCore::IDBDatabase::transaction):
              * storage/IDBDatabase.idl:
              * storage/IDBIndex.cpp:
              (WebCore::IDBIndex::openCursor):
              (WebCore::IDBIndex::openKeyCursor):
              * storage/IDBIndex.h:
              (WebCore::IDBIndex::openCursor):
              (WebCore::IDBIndex::openKeyCursor):
              * storage/IDBIndex.idl:
              * storage/IDBObjectStore.cpp:
              (WebCore::IDBObjectStore::openCursor):
              * storage/IDBObjectStore.h:
              (WebCore::IDBObjectStore::openCursor):
              * storage/IDBObjectStore.idl:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f86bef17
    • commit-queue@webkit.org's avatar
      2011-01-24 Andreas Kling <kling@webkit.org> · a91fd125
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              check-webkit-style: Update exemptions following Source/ move.
              https://bugs.webkit.org/show_bug.cgi?id=53017
      
              * Scripts/webkitpy/style/checker.py:
              * Scripts/webkitpy/style/checker_unittest.py:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a91fd125
    • mitz@apple.com's avatar
      WebKit2 version of <rdar://problem/6097826> Mail's cursor does not become a... · a78d2f2f
      mitz@apple.com authored
      WebKit2 version of <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
      
      Reviewed by John Sullivan.
      
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::setCursor): If the current cursor comes from a cursor rect, do not override it.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a78d2f2f
    • chang.shu@nokia.com's avatar
      2011-01-24 Chang Shu <chang.shu@nokia.com> · b38a60bc
      chang.shu@nokia.com authored
              Reviewed by Darin Adler.
      
              Move contentEditable related test cases to the right place as they are DOM
              related instead of editing related.
              https://bugs.webkit.org/show_bug.cgi?id=53010
      
              * editing/editability: Removed.
              * editing/editability/attr-empty-string-expected.txt: Removed.
              * editing/editability/attr-empty-string.html: Removed.
              * editing/editability/attr-false-string-expected.txt: Removed.
              * editing/editability/attr-false-string.html: Removed.
              * editing/editability/attr-invalid-string-expected.txt: Removed.
              * editing/editability/attr-invalid-string.html: Removed.
              * editing/editability/attr-missing-ancestor-false-expected.txt: Removed.
              * editing/editability/attr-missing-ancestor-false.html: Removed.
              * editing/editability/attr-missing-ancestor-true-expected.txt: Removed.
              * editing/editability/attr-missing-ancestor-true.html: Removed.
              * editing/editability/attr-missing-parent-ancestor-missing-expected.txt: Removed.
              * editing/editability/attr-missing-parent-ancestor-missing.html: Removed.
              * editing/editability/attr-missing-parent-false-expected.txt: Removed.
              * editing/editability/attr-missing-parent-false.html: Removed.
              * editing/editability/attr-missing-parent-true-expected.txt: Removed.
              * editing/editability/attr-missing-parent-true.html: Removed.
              * editing/editability/attr-true-string-expected.txt: Removed.
              * editing/editability/attr-true-string.html: Removed.
              * editing/editability/set-false-expected.txt: Removed.
              * editing/editability/set-false.html: Removed.
              * editing/editability/set-inherit-parent-false-expected.txt: Removed.
              * editing/editability/set-inherit-parent-false.html: Removed.
              * editing/editability/set-inherit-parent-true-expected.txt: Removed.
              * editing/editability/set-inherit-parent-true.html: Removed.
              * editing/editability/set-invalid-value-expected.txt: Removed.
              * editing/editability/set-invalid-value.html: Removed.
              * editing/editability/set-true-expected.txt: Removed.
              * editing/editability/set-true.html: Removed.
              * editing/editability/set-value-caseinsensitive-expected.txt: Removed.
              * editing/editability/set-value-caseinsensitive.html: Removed.
              * fast/dom/HTMLElement/attr-empty-string-expected.txt: Copied from LayoutTests/editing/editability/attr-empty-string-expected.txt.
              * fast/dom/HTMLElement/attr-empty-string.html: Copied from LayoutTests/editing/editability/attr-empty-string.html.
              * fast/dom/HTMLElement/attr-false-string-expected.txt: Copied from LayoutTests/editing/editability/attr-false-string-expected.txt.
              * fast/dom/HTMLElement/attr-false-string.html: Copied from LayoutTests/editing/editability/attr-false-string.html.
              * fast/dom/HTMLElement/attr-invalid-string-expected.txt: Copied from LayoutTests/editing/editability/attr-invalid-string-expected.txt.
              * fast/dom/HTMLElement/attr-invalid-string.html: Copied from LayoutTests/editing/editability/attr-invalid-string.html.
              * fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false-expected.txt.
              * fast/dom/HTMLElement/attr-missing-ancestor-false.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false.html.
              * fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true-expected.txt.
              * fast/dom/HTMLElement/attr-missing-ancestor-true.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true.html.
              * fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing-expected.txt.
              * fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing.html.
              * fast/dom/HTMLElement/attr-missing-parent-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-false-expected.txt.
              * fast/dom/HTMLElement/attr-missing-parent-false.html: Copied from LayoutTests/editing/editability/attr-missing-parent-false.html.
              * fast/dom/HTMLElement/attr-missing-parent-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-true-expected.txt.
              * fast/dom/HTMLElement/attr-missing-parent-true.html: Copied from LayoutTests/editing/editability/attr-missing-parent-true.html.
              * fast/dom/HTMLElement/attr-true-string-expected.txt: Copied from LayoutTests/editing/editability/attr-true-string-expected.txt.
              * fast/dom/HTMLElement/attr-true-string.html: Copied from LayoutTests/editing/editability/attr-true-string.html.
              * fast/dom/HTMLElement/set-false-expected.txt: Copied from LayoutTests/editing/editability/set-false-expected.txt.
              * fast/dom/HTMLElement/set-false.html: Copied from LayoutTests/editing/editability/set-false.html.
              * fast/dom/HTMLElement/set-inherit-parent-false-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-false-expected.txt.
              * fast/dom/HTMLElement/set-inherit-parent-false.html: Copied from LayoutTests/editing/editability/set-inherit-parent-false.html.
              * fast/dom/HTMLElement/set-inherit-parent-true-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-true-expected.txt.
              * fast/dom/HTMLElement/set-inherit-parent-true.html: Copied from LayoutTests/editing/editability/set-inherit-parent-true.html.
              * fast/dom/HTMLElement/set-invalid-value-expected.txt: Copied from LayoutTests/editing/editability/set-invalid-value-expected.txt.
              * fast/dom/HTMLElement/set-invalid-value.html: Copied from LayoutTests/editing/editability/set-invalid-value.html.
              * fast/dom/HTMLElement/set-true-expected.txt: Copied from LayoutTests/editing/editability/set-true-expected.txt.
              * fast/dom/HTMLElement/set-true.html: Copied from LayoutTests/editing/editability/set-true.html.
              * fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt: Copied from LayoutTests/editing/editability/set-value-caseinsensitive-expected.txt.
              * fast/dom/HTMLElement/set-value-caseinsensitive.html: Copied from LayoutTests/editing/editability/set-value-caseinsensitive.html.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76528 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b38a60bc
    • tony@chromium.org's avatar
      2011-01-24 Tony Chang <tony@chromium.org> · e2fa398f
      tony@chromium.org authored
              Reviewed by James Robinson.
      
              [chromium] turn off gyp circular dependency checking and roll chromium deps
              https://bugs.webkit.org/show_bug.cgi?id=52935
      
              * DEPS:
              * gyp_webkit: Turn off gyp circular dependency checking on Linux
                  and Win since we don't do these checks in gyp_chromium.  It's
                  just making it harder for us to roll DEPS and have something
                  explode.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e2fa398f
    • satish@chromium.org's avatar
      2011-01-24 Satish Sampath <satish@chromium.org> · 580f65f5
      satish@chromium.org authored
              Reviewed by Csaba Osztrogonác.
      
              Remove obsolete public/API method in chromium port
              https://bugs.webkit.org/show_bug.cgi?id=53015
      
              * public/WebSpeechInputController.h:
              (WebKit::WebSpeechInputController::startRecognition): Removed obsolete method
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      580f65f5
    • abecsi@webkit.org's avatar
      2011-01-24 Andras Becsi <abecsi@webkit.org> · 7783c2d6
      abecsi@webkit.org authored
              Rubber-stamped by Csaba Osztrogonác.
      
              [Qt] Move project files into Source
              https://bugs.webkit.org/show_bug.cgi?id=52891
      
              * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7783c2d6
    • weinig@apple.com's avatar
      Add editing/inserting/insert-composition-whitespace.html to the windows · 34fc0cac
      weinig@apple.com authored
      skipped list.
      
      * platform/win/Skipped:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      34fc0cac
    • ossy@webkit.org's avatar
      Unreviewed. · 20e41c1b
      ossy@webkit.org authored
      Add Qt specific expected results for passing editing/selections tests.
      Compared to Mac png files and Mac expected files. (part 3)
      
      * platform/qt/editing/selection/ [...]:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20e41c1b
    • ossy@webkit.org's avatar
      Unreviewed. · 9d91ddd4
      ossy@webkit.org authored
      Add Qt specific expected results for passing editing/selections tests.
      Compared to Mac png files and Mac expected files. (part 2)
      
      * platform/qt/editing/selection/ [...]:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9d91ddd4
    • ossy@webkit.org's avatar
      Unreviewed. · da81509d
      ossy@webkit.org authored
      Add Qt specific expected results for passing editing/selections tests.
      Compared to Mac png files and Mac expected files. (part 1)
      
      * platform/qt/editing/selection/ [...]:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      da81509d
    • kbalazs@webkit.org's avatar
      Typo fix. · ff06a04e
      kbalazs@webkit.org authored
      Rubber-stamped by Csaba Osztrogonác.
      
      * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
      (WebKit::ProcessLauncher::launchProcess): Move the bracket to the right place.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ff06a04e
    • pfeldman@chromium.org's avatar
      2011-01-24 Pavel Feldman <pfeldman@chromium.org> · a7ada265
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: extract dispatch API from network manager.
              https://bugs.webkit.org/show_bug.cgi?id=53009
      
              * WebCore.xcodeproj/project.pbxproj:
              * inspector/front-end/NetworkManager.js:
              (WebInspector.NetworkManager):
              (WebInspector.NetworkManager.prototype.reset):
              (WebInspector.NetworkManager.prototype.requestContent):
              (WebInspector.NetworkManager.prototype._processCachedResources):
              (WebInspector.NetworkDispatcher):
              (WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest):
              (WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
              (WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
              (WebInspector.NetworkDispatcher.prototype.identifierForInitialRequest):
              (WebInspector.NetworkDispatcher.prototype.willSendRequest):
              (WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
              (WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache):
              (WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
              (WebInspector.NetworkDispatcher.prototype.didCreateWebSocket):
              (WebInspector.NetworkDispatcher.prototype._appendRedirect):
              (WebInspector.NetworkDispatcher.prototype._startResource):
              (WebInspector.NetworkDispatcher.prototype._updateResource):
              (WebInspector.NetworkDispatcher.prototype._finishResource):
              (WebInspector.NetworkDispatcher.prototype._addFramesRecursively):
              (WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners):
              (WebInspector.NetworkDispatcher.prototype._createResource):
              * inspector/front-end/Resource.js:
              (WebInspector.Resource.prototype._innerRequestContent):
              * inspector/front-end/ResourceTreeModel.js:
              (WebInspector.ResourceTreeModel):
              (WebInspector.ResourceTreeModel.prototype.reset):
              (WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7ada265
    • yurys@chromium.org's avatar
      2011-01-24 Yury Semikhatsky <yurys@chromium.org> · 2e3a4c1a
      yurys@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
              https://bugs.webkit.org/show_bug.cgi?id=53007
      
              It's impossible to create "provisional" inspector for pages which are
              not yet created so there is no need to listen for page creation in ScriptDebugServer.
      
              * bindings/js/ScriptDebugServer.cpp:
              * bindings/js/ScriptDebugServer.h:
              * page/Page.cpp:
              (WebCore::Page::Page):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e3a4c1a
    • podivilov@chromium.org's avatar
      2011-01-24 Pavel Podivilov <podivilov@chromium.org> · bbc1f4fc
      podivilov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
              https://bugs.webkit.org/show_bug.cgi?id=53002
      
              * inspector/front-end/ApplicationCacheItemsView.js:
              (WebInspector.ApplicationCacheItemsView.prototype._update):
              * inspector/front-end/DOMAgent.js:
              (WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76517 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bbc1f4fc
    • reni@webkit.org's avatar
      [Qt] QWebFramePrivate::renderRelativeCoords() calls QPainter::save/restore more than necessary · 5e28fa7f
      reni@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=49915
      
      Reviewed by Andreas Kling.
      
      In the first loop of renderRelativeCoords() the call of QPainter::save/restore is useless, because
      the context is saved/stored within the loop.
      In the second loop the calls are also avoidable by using inverse translation on context.
      
      * Api/qwebframe.cpp:
      (QWebFramePrivate::renderRelativeCoords):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76516 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5e28fa7f
    • andreas.kling@nokia.com's avatar
      2011-01-24 Andreas Kling <kling@webkit.org> · bf9ce4eb
      andreas.kling@nokia.com authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Fix warnings about unregistering an invalid timer
              https://bugs.webkit.org/show_bug.cgi?id=53006
      
              The ShadowBuffer's purge timer ID was initialized with 0 which lead
              to us calling QObject::killTimer(0), causing some qWarnings.
      
              * platform/graphics/qt/ContextShadowQt.cpp:
              (WebCore::ShadowBuffer::ShadowBuffer):
              (WebCore::ShadowBuffer::schedulePurge):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76515 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bf9ce4eb
    • mnaganov@chromium.org's avatar
      2011-01-21 Mikhail Naganov <mnaganov@chromium.org> · f77412cd
      mnaganov@chromium.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: [Chromium] Fix heap snapshot table sorting.
      
              Fix table sorting to avoid qsort instability artefacts.
      
              https://bugs.webkit.org/show_bug.cgi?id=52914
      
              * inspector/front-end/HeapSnapshotView.js:
              (WebInspector.HeapSnapshotView.prototype._sortData):
              (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator):
              (WebInspector.HeapSnapshotDataGridList.propertyComparator):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76514 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f77412cd
    • ossy@webkit.org's avatar
      Unreviewed. · 1deabf24
      ossy@webkit.org authored
      RTL: selection.modify("move", "forward", "line") when cursor is at start of a line does not move down a line
      https://bugs.webkit.org/show_bug.cgi?id=51517
      
      * platform/qt-linux/editing: Removed.
      * platform/qt-linux/editing/selection: Removed.
      * platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Removed.
      * platform/qt/Skipped: Add editing/selection/extend-to-line-boundary.html until fix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76513 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1deabf24
    • podivilov@chromium.org's avatar
      2011-01-24 Pavel Podivilov <podivilov@chromium.org> · ae06a9f9
      podivilov@chromium.org authored
              Unreviewed, build fix  for r76509.
      
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::setBreakpoint):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76512 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ae06a9f9
    • mnaganov@chromium.org's avatar
      2011-01-24 Mikhail Naganov <mnaganov@chromium.org> · 0f69b7b9
      mnaganov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: Find duplicate strings in localizedStrings.js, update it.
      
              https://bugs.webkit.org/show_bug.cgi?id=53005
      
              * English.lproj/localizedStrings.js:
              * Scripts/check-inspector-strings:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0f69b7b9
    • podivilov@chromium.org's avatar
      2011-01-24 Pavel Podivilov <podivilov@chromium.org> · 88024c47
      podivilov@chromium.org authored
              Unreviewed, build fix  for r76509.
      
              * bindings/js/ScriptDebugServer.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76510 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88024c47
    • podivilov@chromium.org's avatar
      2011-01-24 Pavel Podivilov <podivilov@chromium.org> · 5d1abbf5
      podivilov@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: set breakpoints by line:column.
              https://bugs.webkit.org/show_bug.cgi?id=52615
      
              * CMakeLists.txt:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.pro:
              * WebCore.vcproj/WebCore.vcproj:
              * WebCore.xcodeproj/project.pbxproj:
              * bindings/js/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::setBreakpoint):
              (WebCore::ScriptDebugServer::removeBreakpoint):
              (WebCore::ScriptDebugServer::hasBreakpoint):
              (WebCore::ScriptDebugServer::clearBreakpoints):
              * bindings/js/ScriptDebugServer.h:
              * bindings/v8/DebuggerScript.js:
              ():
              * bindings/v8/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::setBreakpoint):
              * bindings/v8/ScriptDebugServer.h:
              * inspector/Inspector.idl:
              * inspector/InspectorBrowserDebuggerAgent.cpp:
              (WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::InspectorDebuggerAgent::setStickyBreakpoint):
              (WebCore::InspectorDebuggerAgent::setBreakpoint):
              (WebCore::InspectorDebuggerAgent::restoreBreakpoint):
              (WebCore::InspectorDebuggerAgent::didParseSource):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/ScriptBreakpoint.cpp: Removed.
              * inspector/ScriptBreakpoint.h:
              (WebCore::ScriptBreakpoint::ScriptBreakpoint):
              * inspector/front-end/Breakpoint.js:
              (WebInspector.Breakpoint):
              (WebInspector.Breakpoint.prototype.get url):
              * inspector/front-end/BreakpointManager.js:
              (WebInspector.JavaScriptBreakpoint.prototype._serializeToJSON):
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel.prototype.continueToLine):
              (WebInspector.DebuggerModel.prototype.setBreakpoint):
              (WebInspector.DebuggerModel.prototype._breakpointSetOnBackend):
              (WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76509 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5d1abbf5
    • ossy@webkit.org's avatar
      * runtime: Removed. It was accidentally created by r76457. · 3795340a
      ossy@webkit.org authored
      Rubber-stamped by Csaba Osztrogonác.
      Patch by Peter Gal <galpater@inf.u-szeged.hu> on 2011-01-24
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76508 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3795340a
    • commit-queue@webkit.org's avatar
      2011-01-24 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com> · 8e2795bd
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Remove CleanupHandler by passing file descriptors.
      
              Deleting files in signal handler of UI process is not a good idea,
              because the memory where filenames are stored might not be valid
              after a crash.
      
              To avoid the need of using signal handlers for cleanup,
              change following:
                1) Avoid passing filenames between processes, pass fds
                2) When mmap'ing files, delete them immediately after
                   opening and mmap'ing them.
                3) Pass sockets with fds during fork+exec instead of
                   passing them via the filesystem.
                4) Use mmap'ed files for implementation of SharedMemory.
                   QSharedMemory does not support cleanup correctly.
      
              Consquences:
                - Move MappedMemory to SharedMemory, make UpdateChunk use this.
                - Implement CoreIPC::Attachment using mmaped files.
                - Send messages using datagram socket. This solution works
                  similiarly to Mach ports on Mac.
                - Send big messages out-of-line and thus avoid increasing
                  the receive buffer.
                - Remove MemoryMappedPool and rely on libc/kernel caching
                  of mmapped areas.
                - Unmap memory areas after use.
                - When UI process crashes, kill the web process using SIGKILL.
                  This is possible again because cleanup handler is not needed.
      
              [WK2][Qt] Multiple problems with MemoryMappedPool
              https://bugs.webkit.org/show_bug.cgi?id=51984
      
              * Platform/CoreIPC/Attachment.cpp:
              (CoreIPC::Attachment::Attachment):
              * Platform/CoreIPC/Attachment.h:
              (CoreIPC::Attachment::size):
              (CoreIPC::Attachment::releaseFileDescriptor):
              (CoreIPC::Attachment::fileDescriptor):
              * Platform/CoreIPC/Connection.h:
              * Platform/CoreIPC/qt/ConnectionQt.cpp:
              (CoreIPC::MessageInfo::MessageInfo):
              (CoreIPC::MessageInfo::setMessageBodyOOL):
              (CoreIPC::MessageInfo::isMessageBodyOOL):
              (CoreIPC::MessageInfo::bodySize):
              (CoreIPC::MessageInfo::messageID):
              (CoreIPC::MessageInfo::attachmentCount):
              (CoreIPC::Connection::platformInitialize):
              (CoreIPC::Connection::platformInvalidate):
              (CoreIPC::SocketNotifierDisableGuard::SocketNotifierDisableGuard):
              (CoreIPC::SocketNotifierDisableGuard::~SocketNotifierDisableGuard):
              (CoreIPC::Connection::readyReadHandler):
              (CoreIPC::Connection::open):
              (CoreIPC::Connection::platformCanSendOutgoingMessages):
              (CoreIPC::Connection::sendOutgoingMessage):
              * Platform/SharedMemory.h:
              * Platform/WorkQueue.h:
              * Platform/qt/MappedMemoryPool.cpp: Removed.
              * Platform/qt/MappedMemoryPool.h: Removed.
              * Platform/qt/SharedMemoryQt.cpp:
              (WebKit::SharedMemory::Handle::Handle):
              (WebKit::SharedMemory::Handle::~Handle):
              (WebKit::SharedMemory::Handle::isNull):
              (WebKit::SharedMemory::Handle::encode):
              (WebKit::SharedMemory::Handle::decode):
              (WebKit::SharedMemory::Handle::releaseToAttachment):
              (WebKit::SharedMemory::Handle::adoptFromAttachment):
              (WebKit::SharedMemory::create):
              (WebKit::accessModeMMap):
              (WebKit::SharedMemory::~SharedMemory):
              (WebKit::accessModeFile):
              (WebKit::SharedMemory::createHandle):
              * Platform/qt/WorkQueueQt.cpp:
              (WorkQueue::registerSocketEventHandler):
              * Shared/qt/UpdateChunk.cpp:
              (WebKit::UpdateChunk::UpdateChunk):
              (WebKit::UpdateChunk::~UpdateChunk):
              (WebKit::UpdateChunk::encode):
              (WebKit::UpdateChunk::decode):
              (WebKit::UpdateChunk::createImage):
              * Shared/qt/UpdateChunk.h:
              * UIProcess/Launcher/ProcessLauncher.h:
              * UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
              (WebKit::QtWebProcess::QtWebProcess):
              (WebKit::QtWebProcess::setupChildProcess):
              (WebKit::ProcessLauncher::launchProcess):
              (WebKit::ProcessLauncher::platformInvalidate):
              * UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
              (WebKit::webThreadBody):
              (WebKit::ThreadLauncher::createWebThread):
              * WebKit2.pro:
              * WebProcess/qt/WebProcessMainQt.cpp:
              (WebKit::WebProcessMainQt):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76507 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e2795bd
    • yurys@chromium.org's avatar
      2011-01-24 Yury Semikhatsky <yurys@chromium.org> · 4779e651
      yurys@chromium.org authored
              Unreviewed. Update Chromium test expectations.
      
              * platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
              * platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
              * platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76506 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4779e651
    • commit-queue@webkit.org's avatar
      2011-01-24 Peter Beverloo <peter@chromium.org> · 0c0db027
      commit-queue@webkit.org authored
              Reviewed by Pavel Feldman.
      
              Web Inspector: recognize application/x-font-woff as a valid mime-type.
              https://bugs.webkit.org/show_bug.cgi?id=52977
      
              No new tests.
      
              * inspector/front-end/inspector.js:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76505 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c0db027
    • podivilov@chromium.org's avatar
      2011-01-24 Pavel Podivilov <podivilov@chromium.org> · 6933e129
      podivilov@chromium.org authored
              Unreviewed, fix for r76497.
      
              * inspector/front-end/ResourcesPanel.js:
              (WebInspector.ResourcesPanel.prototype.show):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76504 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6933e129
    • zoltan@webkit.org's avatar
      [Qt] Regroup MiniBrowser's menubar and add open file action · 9b0df0bd
      zoltan@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=53000
      
      Reviewed by Andreas Kling.
      
      Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
      
      * MiniBrowser/qt/BrowserWindow.cpp:
      (BrowserWindow::BrowserWindow):
      (BrowserWindow::openFile):
      (BrowserWindow::~BrowserWindow):
      * MiniBrowser/qt/BrowserWindow.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76503 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9b0df0bd
    • pvarga@webkit.org's avatar
      2011-01-24 Peter Varga <pvarga@inf.u-szeged.hu> · 66266275
      pvarga@webkit.org authored
              Reviewed by Oliver Hunt.
      
              Optimize regex patterns which contain empty alternatives
              https://bugs.webkit.org/show_bug.cgi?id=51395
      
              Eliminate the empty alternatives from the regex pattern and convert it to do
              the matching in an easier way.
      
              * fast/regex/script-tests/slow.js:
              * fast/regex/slow-expected.txt:
      2011-01-24  Peter Varga  <pvarga@webkit.org>
      
              Reviewed by Oliver Hunt.
      
              Optimize regex patterns which contain empty alternatives
              https://bugs.webkit.org/show_bug.cgi?id=51395
      
              Eliminate the empty alternatives from the regex pattern and convert it to do
              the matching in an easier way.
      
              * yarr/YarrPattern.cpp:
              (JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76502 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66266275
    • andreas.kling@nokia.com's avatar
      2011-01-24 Andreas Kling <kling@webkit.org> · 20a991ba
      andreas.kling@nokia.com authored
              Reviewed by Tor Arne Vestbø.
      
              [Qt] Use rad2deg() from WTF instead of rolling our own.
              https://bugs.webkit.org/show_bug.cgi?id=52993
      
              * platform/graphics/qt/GraphicsContextQt.cpp:
              (WebCore::GraphicsContext::rotate):
              * platform/graphics/qt/PathQt.cpp:
              (WebCore::Path::addArc):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76501 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      20a991ba