1. 16 Dec, 2009 20 commits
    • eric@webkit.org's avatar
      2009-12-16 Benjamin Otte <otte@gnome.org> · b229e23c
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              Get rid of the phase argument to Image::drawPattern.
              https://bugs.webkit.org/show_bug.cgi?id=31187
      
              The argument can be expressed equally well as part of the
              patternTransform. All backends but the Qt one did exactly that
              manually anyway.
      
              * platform/graphics/BitmapImage.h:
              * platform/graphics/GeneratedImage.cpp:
              (WebCore::GeneratedImage::drawPattern):
              * platform/graphics/GeneratedImage.h:
              * platform/graphics/Image.cpp:
              (WebCore::Image::drawTiled):
              * platform/graphics/Image.h:
              * platform/graphics/cairo/ImageCairo.cpp:
              (WebCore::Image::drawPattern):
              * platform/graphics/cg/ImageCG.cpp:
              (WebCore::Image::drawPattern):
              * platform/graphics/haiku/ImageHaiku.cpp:
              (WebCore::Image::drawPattern):
              * platform/graphics/qt/ImageQt.cpp:
              (WebCore::Image::drawPattern):
              * platform/graphics/skia/ImageSkia.cpp:
              (WebCore::Image::drawPattern):
              * platform/graphics/wince/GraphicsContextWince.cpp:
              (WebCore::GraphicsContext::drawBitmapPattern):
              * platform/graphics/wince/ImageBufferWince.cpp:
              (WebCore::):
              (WebCore::BufferedImage::drawPattern):
              * platform/graphics/wx/ImageWx.cpp:
              (WebCore::BitmapImage::drawPattern):
              (WebCore::Image::drawPattern):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52206 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b229e23c
    • eric@webkit.org's avatar
      2009-12-16 Kenneth Russell <kbr@google.com> · 2b3a3716
      eric@webkit.org authored
              Reviewed by Darin Fisher.
      
              Performance problems with index validation code for drawElements
              https://bugs.webkit.org/show_bug.cgi?id=32466
      
              Added a cache of the maximum index for each element type to
              WebGLBuffer, querying it before iterating through the indices in
              the client-side copy of the buffer's data. Hoisted checks of the
              size of the element array itself into validateElementArraySize to
              avoid duplicating code.
      
              The performance improvement has been measured with manual tests.
              Existing layout tests cover the index validation functionality
              and continue to pass as before.
      
              * html/canvas/WebGLBuffer.cpp:
              (WebCore::WebGLBuffer::WebGLBuffer):
              (WebCore::WebGLBuffer::associateBufferData):
              (WebCore::WebGLBuffer::associateBufferSubData):
              (WebCore::WebGLBuffer::getCachedMaxIndex):
              (WebCore::WebGLBuffer::setCachedMaxIndex):
              (WebCore::WebGLBuffer::clearCachedMaxIndices):
              * html/canvas/WebGLBuffer.h:
              * html/canvas/WebGLRenderingContext.cpp:
              (WebCore::WebGLRenderingContext::validateElementArraySize):
              (WebCore::WebGLRenderingContext::validateIndexArrayConservative):
              (WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
              (WebCore::WebGLRenderingContext::validateRenderingState):
              (WebCore::WebGLRenderingContext::drawElements):
              * html/canvas/WebGLRenderingContext.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52205 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b3a3716
    • eric@webkit.org's avatar
      2009-12-16 Zelidrag Hornung <zelidrag@chromium.org> · b6e6211e
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              https://bugs.webkit.org/show_bug.cgi?id=32261
              Added ability to separate the autocomplete suggestion previewing from
              the actual accepting of the suggested value in HTMLInputElement.
              This element (it's single line text incarnation) can now
              be put in suggestion mode where renderer might display the suggested
              value without making it automatically exposed to JavaScript.
      
              No new tests. This new methods are not exposed yet. It's use will be
              platform specific. PopupMenu and Chromium specific changes will be
              separated based on Darin Adler's comments.
      
              * dom/InputElement.h:
              (WebCore::InputElementData::suggestedValue):
              (WebCore::InputElementData::setSuggestedValue):
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::suggestedValue):
              (WebCore::HTMLInputElement::setSuggestedValue):
              (WebCore::HTMLInputElement::setValue):
              (WebCore::HTMLInputElement::setValueFromRenderer):
              * html/HTMLInputElement.h:
              * rendering/RenderTextControlSingleLine.cpp:
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              * wml/WMLInputElement.cpp:
              (WebCore::WMLInputElement::suggestedValue):
              * wml/WMLInputElement.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52204 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6e6211e
    • pfeldman@chromium.org's avatar
      2009-12-16 Pavel Feldman <pfeldman@chromium.org> · 2bee5621
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: Make Elements tree, properties section and resources
              view monospace.
      
              https://bugs.webkit.org/show_bug.cgi?id=32609
      
              * inspector/front-end/ElementsPanel.js:
              * inspector/front-end/PropertiesSection.js:
              (WebInspector.PropertiesSection):
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView):
              * inspector/front-end/inspector.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52203 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2bee5621
    • eric@webkit.org's avatar
      2009-12-16 Dirk Schulze <krit@webkit.org> · 3bd3a71e
      eric@webkit.org authored
              Reviewed by Darin Adler.
      
              sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
              https://bugs.webkit.org/show_bug.cgi?id=32575
      
              Check if the GraphicsContex get adjusted, if the source rect is clipped
              to the filter rect.
      
              * platform/mac/svg/filters/filter-source-position-expected.checksum: Added.
              * platform/mac/svg/filters/filter-source-position-expected.png: Added.
              * platform/mac/svg/filters/filter-source-position-expected.txt: Added.
              * svg/filters/filter-source-position.svg: Added.
      2009-12-16  Dirk Schulze  <krit@webkit.org>
      
              Reviewed by Darin Adler.
      
              sourceGraphic wrong if positive x,y is >0 and objectBB is selected on Filter
              https://bugs.webkit.org/show_bug.cgi?id=32575
      
              On SVG Filters, the rest of the source graphic gets clipped to the filter
              rest. This helps us to minimize the size of intermediate ImageBuffers. If
              the...
      3bd3a71e
    • enrica@apple.com's avatar
      CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore:... · 0155056d
      enrica@apple.com authored
      CrashTracer: [USER] 1 crash in Safari at com.apple.WebCore: WebCore::endsOfNodeAreVisuallyDistinctPositions + 115
      <rdar://problem/7467108>
      https://bugs.webkit.org/show_bug.cgi?id=32590
      
      Reviewed by Adele Peterson.
      
      WebCore: 
      
      If the element is a button there is no need to look at the children to calculate the caret position.
              
      Test: editing/selection/button-right-click.html
      
      * dom/Position.cpp:
      (WebCore::Position::getInlineBoxAndOffset): Avoid calling recursively this method,
      when starting from a button element.
      
      LayoutTests: 
      
      * editing/selection/button-right-click-expected.txt: Added.
      * editing/selection/button-right-click.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52201 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0155056d
    • kov@webkit.org's avatar
      Rubber-stamped by Xan Lopez. · 049c598e
      kov@webkit.org authored
      Add tab_key_cycles_through_elements to copies of
      WebKitWebSettings.
      
      * webkit/webkitwebsettings.cpp:
      (webkit_web_settings_copy):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52200 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      049c598e
    • eric@webkit.org's avatar
      2009-12-16 Luiz Agostini <luiz.agostini@openbossa.org> · 0e54da2f
      eric@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] Implement combobox delegate for Qt
              https://bugs.webkit.org/show_bug.cgi?id=32550
      
              Refactoring of class QWebPopup.
      
              Class QWebPopup has been split in QtAbstractWebPopup and QtFallbackWebPopup.
              Both new classes are now in corresponding files and files QWebPopup.* have been removed.
      
              Custom combo popup classes will inherit from QtAbstractWebPopup. It is not the public API as it is
              in WebCore and will not be visible by users of QtWebKit. It will be used in implementation of
              public QtWebKit combobox popup delegation API.
      
              Class QtFallbackWebPopup inherits from QtAbstractWebPopup and implements the currently used combobox popup.
              It needs to be improved to provide standard features that are missing like style or indentation.
      
              No behavior changes.
      
              * WebCore.pro:
              * platform/PopupMenu.h:
              * platform/qt/PopupMenuQt.cpp:
              (WebCore::PopupMenu::PopupMenu):
              * platform/qt/QWebPopup.cpp: Removed.
              * platform/qt/QWebPopup.h: Removed.
              * platform/qt/QtAbstractWebPopup.cpp: Added.
              (WebCore::QtAbstractWebPopup::QtAbstractWebPopup):
              (WebCore::QtAbstractWebPopup::~QtAbstractWebPopup):
              (WebCore::QtAbstractWebPopup::client):
              * platform/qt/QtAbstractWebPopup.h: Added.
              * platform/qt/QtFallbackWebPopup.cpp: Added.
              (WebCore::QtFallbackWebPopup::QtFallbackWebPopup):
              (WebCore::QtFallbackWebPopup::show):
              (WebCore::QtFallbackWebPopup::populate):
              (WebCore::QtFallbackWebPopup::showPopup):
              (WebCore::QtFallbackWebPopup::hidePopup):
              (WebCore::QtFallbackWebPopup::activeChanged):
              * platform/qt/QtFallbackWebPopup.h: Added.
              (WebCore::QtFallbackWebPopup::hide):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52199 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0e54da2f
    • eric@webkit.org's avatar
      2009-12-16 Martin Robinson <martin.james.robinson@gmail.com> · 643bffce
      eric@webkit.org authored
              Reviewed by Gustavo Noronha Silva.
      
              [GTK] webkit_web_navigation_action_get_button() documentation
              https://bugs.webkit.org/show_bug.cgi?id=25555
      
              Small documentation improvement for webkit_web_navigation_action_get_button.
      
              * webkit/webkitwebnavigationaction.cpp:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52198 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      643bffce
    • ossy@webkit.org's avatar
      Rubber-stamped by Kenneth Rohde Christiansen. · 4756ae4c
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=31332
      
      [Qt] After http://trac.webkit.org/changeset/52192
      there are a failing and a timeouter test.
      
      * platform/qt/Skipped: http/tests/misc/drag-over-iframe-invalid-source-crash.html added until fix.
      * platform/qt/fast/text/international/khmer-selection-expected.txt: update outdated expected.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4756ae4c
    • ossy@webkit.org's avatar
      Rubber-stamped by Simon Hausmann. · 690ffe82
      ossy@webkit.org authored
      [Qt] http://trac.webkit.org/changeset/52194 fixed a side-effect
      of DumpRenderTree. The previously wrong expected file updated.
      
      * platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt: updated.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52196 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      690ffe82
    • kov@webkit.org's avatar
      Skipping a new test, and a test that fails only on the release bot, · 11601289
      kov@webkit.org authored
      apparently because of rouding errors.
      
      * platform/gtk/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11601289
    • hausmann@webkit.org's avatar
      WebKitTools: Fix crash with tests that use custom font faces. · 4d0fdcf7
      hausmann@webkit.org authored
      Reviewed by Holger Freyther.
      
      https://bugs.webkit.org/show_bug.cgi?id=32600
      
      In the DRT we call QApplication::removeAllApplicationFonts(), to make sure
      that custom font faces between tests don't influence each other. Calling this
      function in Qt however also invalidates all existing handles with QFontDatabase.
      
      In order to make sure that WebCore also drops these handles we call QWebSettings::clearMemoryCaches(),
      which implies a call to WebCore::FontCache::fontCache()->invalidate().
      
      * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
      (WebCore::DumpRenderTree::open):
      
      LayoutTests: [Qt] Unskip fast/css/font-face-multiple-families.html.
      
      Reviewed by Holger Freyther.
      
      * platform/qt/Skipped:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4d0fdcf7
    • pfeldman@chromium.org's avatar
      2009-12-15 Pavel Feldman <pfeldman@chromium.org> · 66168b2b
      pfeldman@chromium.org authored
              Reviewed by Timothy Hatcher.
      
              Web Inspector: beautify HTTP info section.
      
              https://bugs.webkit.org/show_bug.cgi?id=32583
      
              * English.lproj/localizedStrings.js:
              * inspector/front-end/ResourceView.js:
              (WebInspector.ResourceView):
              (WebInspector.ResourceView.prototype._refreshURL):
              (WebInspector.ResourceView.prototype._refreshHTTPInformation):
              * inspector/front-end/inspector.css:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52193 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      66168b2b
    • eric@webkit.org's avatar
      2009-12-16 Andreas Kling <andreas.kling@nokia.com> · 38104128
      eric@webkit.org authored
              Reviewed by Simon Hausmann.
      
              [Qt] Maintain button state between mouse events.
      
              This allows eventSender to generate drag events.
      
              https://bugs.webkit.org/show_bug.cgi?id=32601
      
              * DumpRenderTree/qt/EventSenderQt.cpp:
              (EventSender::mouseDown):
              (EventSender::mouseUp):
              (EventSender::mouseMoveTo):
              * DumpRenderTree/qt/EventSenderQt.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52192 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      38104128
    • kov@webkit.org's avatar
      Revert r52085, because it causes crashes on media tests in the release · 4b8ad552
      kov@webkit.org authored
      bot.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52191 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4b8ad552
    • ossy@webkit.org's avatar
      [Qt] fast/css/font-face-unused-source-loaded.html crashes · 1a0fb047
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=32600
      
      Reviewed by Simon Hausmann.
      
      The crash caused by fast/css/font-face-multiple-families.html, added to skiplist until fix.
      
      * platform/qt/Skipped: fast/css/font-face-multiple-families.html added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1a0fb047
    • tkent@chromium.org's avatar
      2009-12-15 Chris Jerdonek <chris.jerdonek@gmail.com> · cfd094c8
      tkent@chromium.org authored
              Reviewed by David Levin.
      
              Code clean-up in check-webkit-style as described below.
              The only functional changes are minor improvements to the
              script's help output.
      
              https://bugs.webkit.org/show_bug.cgi?id=32487
      
              * Scripts/check-webkit-style:
                - Added the module docstring from cpp_style.py.
                - Improved wording of the --help output and added some of the
                  default values as substitution strings.
                - Called cpp_style.exit_with_usage instead of sys.stderr.write
                  in main function.
                - Made changes caused by changes to cpp_style.py.
      
              * Scripts/modules/cpp_style.py:
                - Removed module docstring, as well as redundant _USAGE string
                  and main() function obsoleted by check-webkit-style.
                - Moved specification of default script values from within a
                  function definition to global variables.
                - Moved the default webkit filter rules to be near the other
                  global variables.
                - Renamed "FILTER" global variables to "FILTER_RULES" to
                  establish unambiguous terminology.
                - Renamed _ERROR_CATEGORIES to _STYLE_CATEGORIES.
                - Changed _STYLE_CATEGORIES from a string to a list.
                - Added default webkit filter rules to --filter= output.
                - Renamed "print_" methods to "exit_with_" since they exist
                  and added a temporary display_help parameter.
                - Added a temporary display_help parameter to parse_arguments.
      
              * Scripts/modules/cpp_style_unittest.py:
                - Made changes caused by changes to cpp_style.py.
                - Lower-cased ErrorCollector's ERROR_CATEGORIES instance
                  variables since they are not global.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfd094c8
    • abarth@webkit.org's avatar
      Unreviewed fix for the style-queue. · bb6b1006
      abarth@webkit.org authored
      Typo: _updates_status -> _update_status
      
      We need to improve our testing infrastructure for the queues.
      
      * Scripts/modules/commands/queues.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52188 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bb6b1006
    • abarth@webkit.org's avatar
      Unreviewed fix for the style-queue. I suspect this is a recent · 2105f608
      abarth@webkit.org authored
      regression from Eric's change below.
      
      * Scripts/modules/commands/queues.py:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@52187 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2105f608
  2. 15 Dec, 2009 20 commits