1. 27 Jun, 2006 8 commits
    • thatcher's avatar
      Reviewed by Darin. · b203939a
      thatcher authored
              <rdar://problem/4406785> Add an export file to TOT JavaScriptCore like the Safari-2-0-branch
      
              * JavaScriptCore.exp: Added.
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15058 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b203939a
    • mjs's avatar
      Reviewed by Adele · 95e2cf40
      mjs authored
              - fixed <rdar://problem/4550473> Reproducible hang on www.digg.com
              
              * dom/NodeList.cpp:
              (WebCore::NodeList::recursiveItem): Make NodeList caching also
              work for backwards iteration - if the requested index is before
              the last cached, but closer to it than to the start of the list,
              then search backwards from there.
              (WebCore::NodeList::itemForwardsFromCurrent): Split this out as a
              helper method.
              (WebCore::NodeList::itemBackwardsFromCurrent): New helper, similar
              to the above.
              * dom/NodeList.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95e2cf40
    • beidson's avatar
      Reviewed by Levi · 037bdb04
      beidson authored
              Some SQLDatabase cleanup (style stuff) and enhancements
      
              * icon/SQLDatabase.cpp:
              (SQLDatabase::open):
              (SQLDatabase::executeCommand):
              (SQLDatabase::returnsAtLeastOneResult):  Accessor to see if this query returns results
              (SQLDatabase::lastInsertRowID):  Accessor for the rowid of the last insert
              * icon/SQLDatabase.h:
              (WebCore::SQLStatement::prepareAndStep):
              * icon/SQLStatement.cpp:
              (WebCore::SQLStatement::bindInt64):
              -All of the following used to require the user to manually prepare and step a statement
              before asking for the result.  Now it will prepare and step itself so you can use a temporary
              object to get a quick result
              (WebCore::SQLStatement::getColumnName):
              (WebCore::SQLStatement::getColumnName16):
              (WebCore::SQLStatement::getColumnText):
              (WebCore::SQLStatement::getColumnText16):
              (WebCore::SQLStatement::getColumnDouble):
              (WebCore::SQLStatement::getColumnInt):
              (WebCore::SQLStatement::getColumnInt64):
              (WebCore::SQLStatement::getColumnBlobAsVector):
              (WebCore::SQLStatement::getColumnBlob):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15056 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      037bdb04
    • adachan's avatar
      2006-06-27 Ada Chan <adachan@apple.com> · 0cd61ac7
      adachan authored
              Reviewed by sfalken.
      
              Fixed build.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0cd61ac7
    • bdakin's avatar
      Reviewed by Hyatt. · 0b5dc49f
      bdakin authored
              Fix for <rdar://problem/4602635> Media queries must be extended to 
              address CSS pixel scaling factor
      
              * css/MediaFeatureNames.h: Add -webkit-device-pixel-ratio, -webkit-
              min-device-pixel-ratio, and -webkit-max-device-pixel-ratio to the 
              list of feature names.
              * css/MediaQueryEvaluator.cpp:
              (WebCore::cmpvalue): Added a version of cmpvalue that compares 
              floats.
              (WebCore::device_pixel_ratioMediaFeatureEval):
              (WebCore::min_device_pixel_ratioMediaFeatureEval):
              (WebCore::max_device_pixel_ratioMediaFeatureEval):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0b5dc49f
    • darin's avatar
      Reviewed by Geoff. · 8d7f073b
      darin authored
              - finish with http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
                REGRESSION: some callers are still using clientX/Y to get pageX/Y
      
              * rendering/RenderFrameSet.cpp: (WebCore::RenderFrameSet::userResize):
              Change to use pageX/Y, but this really doesn't matter since framesets
              can't be scrolled -- it's the frames that are scrolled. So this change
              has no user-visible effect, but it's still better this way.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8d7f073b
    • darin's avatar
      LayoutTests: · ee673905
      darin authored
              Tests for fix for 2/3 of http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
              REGRESSION: some callers are still using clientX/Y to get pageX/Y
      
              * fast/events/anchor-image-scrolled-x-y-expected.txt: Added.
              * fast/events/anchor-image-scrolled-x-y.html: Added.
              * fast/events/input-image-scrolled-x-y-expected.txt: Added.
              * fast/events/input-image-scrolled-x-y.html: Added.
      
      WebCore:
      
              Reviewed by Geoff.
      
              - fix 2/3 of http://bugzilla.opendarwin.org/show_bug.cgi?id=9606
                REGRESSION: some callers are still using clientX/Y to get pageX/Y
      
              Test: fast/events/anchor-image-scrolled-x-y.html
              Test: fast/events/input-image-scrolled-x-y.html
      
              * html/HTMLAnchorElement.cpp: (WebCore::HTMLAnchorElement::defaultEventHandler): Use pageX/Y.
              * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15052 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee673905
    • beidson's avatar
      Reviewed by Maciej · ab9e9e13
      beidson authored
              Added functionality to WebCore::Image to get multiple representations/sizes into TIFF data
      
              * platform/mac/ImageMac.mm:
              (WebCore::Image::getTIFFRepresentation):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ab9e9e13
  2. 26 Jun, 2006 5 commits
    • hyatt's avatar
      Fix for 9538, support syntax highlighted HTML source. Lots of loose · 3ad24079
      hyatt authored
              ends still (script/style/comments/doctype/entities/accurate whitespace).
      
              Reviewed by darin
      
              * DerivedSources.make:
              * WebCore.xcodeproj/project.pbxproj:
              * bridge/mac/WebCoreFrameBridge.h:
              * bridge/mac/WebCoreFrameBridge.mm:
              (-[WebCoreFrameBridge setInViewSourceMode:]):
              (-[WebCoreFrameBridge inViewSourceMode]):
              * css/cssstyleselector.cpp:
              (WebCore::CSSStyleSelector::loadDefaultStyle):
              (WebCore::CSSStyleSelector::matchUARules):
              * css/cssstyleselector.h:
              * css/view-source.css: Added.
              * dom/Document.cpp:
              (WebCore::Document::implicitClose):
              * dom/xml_tokenizer.h:
              (WebCore::Tokenizer::Tokenizer):
              (WebCore::Tokenizer::~Tokenizer):
              (WebCore::Tokenizer::inViewSourceMode):
              (WebCore::Tokenizer::setInViewSourceMode):
              * html/HTMLAttributeNames.in:
              * html/HTMLFrameElement.cpp:
              (WebCore::HTMLFrameElement::init):
              (WebCore::HTMLFrameElement::parseMappedAttribute):
              (WebCore::HTMLFrameElement::attach):
              * html/HTMLFrameElement.h:
              (WebCore::HTMLFrameElement::viewSourceMode):
              * html/HTMLTokenizer.cpp:
              (WebCore::HTMLTokenizer::HTMLTokenizer):
              (WebCore::HTMLTokenizer::scriptHandler):
              (WebCore::HTMLTokenizer::scriptExecution):
              (WebCore::HTMLTokenizer::parseTag):
              (WebCore::HTMLTokenizer::continueProcessing):
              (WebCore::HTMLTokenizer::write):
              (WebCore::HTMLTokenizer::timerFired):
              (WebCore::HTMLTokenizer::end):
              (WebCore::HTMLTokenizer::processToken):
              (WebCore::HTMLTokenizer::notifyFinished):
              * html/HTMLTokenizer.h:
              * html/HTMLViewSourceDocument.cpp: Added.
              (WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
              (WebCore::HTMLViewSourceDocument::createTokenizer):
              (WebCore::HTMLViewSourceDocument::addViewSourceToken):
              (WebCore::HTMLViewSourceDocument::addViewSourceAttribute):
              (WebCore::HTMLViewSourceDocument::addSpanWithClassName):
              * html/HTMLViewSourceDocument.h: Added.
              * page/Frame.cpp:
              (WebCore::Frame::begin):
              (WebCore::Frame::inViewSourceMode):
              (WebCore::Frame::setInViewSourceMode):
              * page/Frame.h:
              * page/FramePrivate.h:
              (WebCore::FramePrivate::FramePrivate):
              * rendering/RenderPartObject.cpp:
              (WebCore::RenderPartObject::updateWidget):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15050 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3ad24079
    • hyatt's avatar
      Fix for 9538, support syntax highlighting for HTML source. · d45e71de
      hyatt authored
              Reviewed by darin
      
              * WebKit.xcodeproj/project.pbxproj:
              * WebView/WebView.m:
              (-[WebView _setInViewSourceMode:]):
              (-[WebView _inViewSourceMode]):
              * WebView/WebViewPrivate.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15049 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d45e71de
    • andersca's avatar
      2006-06-26 Anders Carlsson <acarlsson@apple.com> · 5dc61eae
      andersca authored
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9031
              REGRESSION: Crash when closing tabs on newegg.com
              
              * page/Frame.cpp:
              (WebCore::Frame::pageDestroyed):        
              * page/Frame.h:
              Add new method which is invoked when the frame's page has been destroyed.
              Currently this function disassociates the JS Window object with the frame, 
              stopping any running JS timers.
              
              * page/Page.cpp:
              (WebCore::Page::~Page):
              Call pageDestroyed on all frames.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5dc61eae
    • darin's avatar
      Reviewed and reworked by Darin. · 8ce13dc1
      darin authored
              Code cleanup, calculate clientX/clientY in one central place.
      
              * dom/EventTargetNode.h:
              * dom/EventTargetNode.cpp: (WebCore::EventTargetNode::dispatchMouseEvent):
              Renamed parameters to pageX/Y since they aren't clientX/Y values.
              Removed code to compute clientX/Y (was a bit confused in naming before),
              because that's now done inside MouseEvent.
      
              * dom/MouseEvent.h:
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::MouseEvent): Removed clientX/Y parameters.
              (WebCore::MouseEvent::initMouseEvent): Added comments about problems I noticed.
              (WebCore::MouseEvent::which): Fixed comment that confusingly mentioned KHTML,
              when it was talking about the DOM standard.
      
              * dom/MouseRelatedEvent.h:
              * dom/MouseRelatedEvent.cpp:
              (WebCore::contentsX): Added helper function.
              (WebCore::contentsY): Ditto.
              (WebCore::MouseRelatedEvent::MouseRelatedEvent): Removed clientX/Y parameter,
              and added code to compute clientX/Y based on pageX/Y.
              (WebCore::MouseRelatedEvent::receivedTarget): Fixed comments.
      
              * dom/WheelEvent.h:
              * dom/WheelEvent.cpp: (WebCore::WheelEvent::WheelEvent): Removed clientX/Y
              parameter.
      
              * page/FrameView.cpp: (WebCore::FrameView::dispatchDragEvent): Removed the code
              to compute coordinates, and renamed the confusingly named clientPos (which was
              a page-relative position) to contentsPos.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8ce13dc1
    • darin's avatar
      LayoutTests: · 5ff2bf2c
      darin authored
              Reviewed by Darin.
      
              * LayoutTests/fast/events/objc-event-api-expected.txt: Updated to
              reflect flipped coordinates dumped by the layout tests.
      
      WebKitTools:
      
              Reviewed by Darin.
      
              Bug 9579: LayoutTests/fast/events/objc-event-api.html failing due to screenY output
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9579
      
              Report screenY values as (height of zero screen - screenY)
      
              * DumpRenderTree/EventSendingController.m: (-[EventSendingController handleEvent:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ff2bf2c
  3. 25 Jun, 2006 18 commits
    • thatcher's avatar
      Reviewed by Geoff. · c571e06f
      thatcher authored
              Bug 9591: [Drosera] breakpoints should be dragable and deletable by dragging off the gutter
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9591
              
              Makes breakpoints dragable. If dragged off the gutter they are deleted.
      
              * Drosera/debugger.js:
              * Drosera/viewer.css:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c571e06f
    • darin's avatar
      LayoutTests: · 8c74d768
      darin authored
              Reviewed by Darin.
      
              Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=9185
      
              * fast/forms/input-appearance-height-expected.png: Added.
              * fast/forms/input-appearance-height-expected.txt: Added.
              * fast/forms/input-appearance-height.html: Added.
              Tests the height attribute on all input types
      
              * fast/forms/input-type-change-expected.checksum: Added.
              * fast/forms/input-type-change-expected.png: Added.
              * fast/forms/input-type-change-expected.txt: Added.
              * fast/forms/input-type-change.html: Added.
              Tests changing an input type=TEXT to type=IMAGE with
              a height and width specified on the element.
      
              * fast/forms/input-type-change2-expected.checksum: Added.
              * fast/forms/input-type-change2-expected.png: Added.
              * fast/forms/input-type-change2-expected.txt: Added.
              * fast/forms/input-type-change2.html: Added.
              Tests changing an input type=IMAGE to type=TEXT with
              a height and width specified on the element.
      
      WebCore:
      
              Reviewed and tweaked by Darin.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9185
              REGRESSION: UserID field appears with an incorrect height 
              on americanexpresslogin page
              - Height and Width attribute only applies to IMAGE and HIDDEN
              types.
      
              * dom/NamedMappedAttrMap.h:
              (WebCore::NamedMappedAttrMap::getAttributeItem):
              Added to static_cast method.
      
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::setInputType):
              Update the style decl if input type has changed.
              (WebCore::HTMLInputElement::mapToEntry):
              Only Cache height and width if it is an IMAGE or HIDDEN
              (WebCore::HTMLInputElement::parseMappedAttribute):
              Check type before adding height and width style.
              (WebCore::HTMLInputElement::attach):
              Remove code for discarding width.
      
              * html/HTMLInputElement.h:
              (WebCore::HTMLInputElement::respectHeightAndWidthAttrs):
              New method added to report if this input type uses height & width.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8c74d768
    • ggaren's avatar
      Reviewed by Adele. · dcc6aead
      ggaren authored
              
              - Added JSConstructorMake to match JSFunctionMake, along with test code.
              
              [ I checked in the ChangeLog before without the actual files. ]
      
              * API/JSObjectRef.cpp:
              (JSConstructorMake):
              * API/JSObjectRef.h:
              * API/testapi.c:
              (myConstructor_callAsConstructor):
              (main):
              * API/testapi.js:
              * ChangeLog:
              * JavaScriptCore.xcodeproj/project.pbxproj: Moved testapi.c to the testapi
              target -- this was an oversight in my earlier check-in.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      dcc6aead
    • thatcher's avatar
      Reviewed by Darin. · 7ee5fcbb
      thatcher authored
              
              Bug 9568: assertion failure in Safari after quitting Drosera
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9568
      
              Call switchToServerNamed:nil and not removeLister to make sure
              the server object is set to nil to prevent further removeListener calls.
      
              * Drosera/DebuggerDocument.m:
              (-[DebuggerDocument applicationTerminating:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7ee5fcbb
    • ddkilzer's avatar
      LayoutTests: · f7154a32
      ddkilzer authored
              Reviewed by Darin.
      
              * fast/forms/textarea-hard-linewrap-empty.html: Submit form without setTimeout().
              * fast/forms/textarea-hard-linewrap.html: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f7154a32
    • ddkilzer's avatar
      WebCore: · 643dfd0b
      ddkilzer authored
              Reviewed by Darin.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9537
                REGRESSION: Reproducible crash in WebCore::RenderTextField::textWithHardLineBreaks()
      
              Test: fast/forms/textarea-hard-linewrap-empty.html
      
              * rendering/RenderTextField.cpp:
              (WebCore::RenderTextField::textWithHardLineBreaks): Added null check for
              m_div->firstChild()->renderer().
      
      LayoutTests:
      
              Reviewed by Darin.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=9537
                REGRESSION: Reproducible crash in WebCore::RenderTextField::textWithHardLineBreaks()
      
              * fast/forms/textarea-hard-linewrap-empty-expected.txt: Added.
              * fast/forms/textarea-hard-linewrap-empty.html: Added.
              * fast/forms/textarea-hard-linewrap.html: Reduced timeout from 200ms to 0ms and
              renamed function from foo() to submitForm().
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      643dfd0b
    • ddkilzer's avatar
      WebKitTools: · 25b4b502
      ddkilzer authored
              Reviewed by Darin.
      
              * Scripts/svn-apply: Speed up isDirectoryEmptyForRemoval() by returning as soon as we find
              that the directory is not empty instead of reading in every single file and directory first,
              then checking the count.  Avoid warning in removeDirectoriesIfNeeded() if $svnOutput is not
              defined.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      25b4b502
    • ddkilzer's avatar
      WebCore: · a4d27ab3
      ddkilzer authored
              Reviewed by Darin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=9388
                REGRESSION: outlines don't get erased when removed in some cases
      
              Test: fast/repaint/outline-shrinking.html
      
              * rendering/RenderObject.cpp:
              (WebCore::RenderObject::setStyle): Always repaint with the old style if the outline is
              becoming narrower, even if we are going to relayout.
      
      LayoutTests:
      
              Reviewed by Darin.
      
              - repaint test for http://bugzilla.opendarwin.org/show_bug.cgi?id=9388
                REGRESSION: outlines don't get erased when removed in some cases
      
              * fast/repaint/outline-shrinking-expected.checksum: Added.
              * fast/repaint/outline-shrinking-expected.png: Added.
              * fast/repaint/outline-shrinking-expected.txt: Added.
              * fast/repaint/outline-shrinking.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a4d27ab3
    • thatcher's avatar
      Build fix for for GCC 5406 · f1b59e62
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f1b59e62
    • thatcher's avatar
      Rolls out a build fix I made on Friday, this was correctly fixed by adding a... · ad846835
      thatcher authored
      Rolls out a build fix I made on Friday, this was correctly fixed by adding a long version of operator[] to Vector.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ad846835
    • ddkilzer's avatar
      WebCore: · 32149159
      ddkilzer authored
              Reviewed by Darin.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8707:
              event.clientX and event.clientY should be relative to the viewport, not the canvas
      
              Make sure clientX and clientY take into account the scroll offsets
              of the view.
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchMouseEvent):
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::MouseEvent):
              * dom/MouseEvent.h:
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::MouseRelatedEvent):
              (WebCore::MouseRelatedEvent::initCoordinates):
              * dom/MouseRelatedEvent.h:
              * dom/WheelEvent.cpp:
              (WebCore::WheelEvent::WheelEvent):
              * page/FrameView.cpp:
              (WebCore::FrameView::dispatchDragEvent):
      
      LayoutTests:
      
              Reviewed by Darin.
      
              Test cases for
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=8707>
              event.clientX and event.clientY should be relative to the viewport, not the canvas
      
              * fast/dom/window-xy-properties-expected.txt: Added.
              * fast/dom/window-xy-properties.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      32149159
    • thatcher's avatar
      Leak fix · 5cdc5e0e
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5cdc5e0e
    • darin's avatar
      * Scripts/svn-apply: Tweak comments. · 43efeffc
      darin authored
              * Scripts/svn-create-patch: Ditto.
              * Scripts/svn-unapply: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      43efeffc
    • ddkilzer's avatar
      WebKitTools: · abfe3872
      ddkilzer authored
              Formatting fix per Bug 9571 Comment #2.  Reviewed by NOBODY.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9571#c2
      
              * Scripts/svn-apply: Formatting fix.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      abfe3872
    • ddkilzer's avatar
      WebKitTools: · 576fd480
      ddkilzer authored
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9571
              Teach svn-apply and svn-unapply to handle directory adds and removes better
      
              * Scripts/svn-apply: Handle directory adds more intelligently.  Handle directory removes.
              * Scripts/svn-unapply: Handle undoing both directory adds and removes.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      576fd480
    • thatcher's avatar
      http://bugzilla.opendarwin.org/show_bug.cgi?id=9560 · 47609000
      thatcher authored
              
              This fix converted the resize corner image to a B/W tiff.
              The pixel tests showed 0.0% changes but still said it had differences.
              Updating the tests that use CSS3 resize or textarea.
      
              * fast/forms/floating-textfield-relayout-expected.checksum:
              * fast/forms/form-element-geometry-expected.checksum:
              * fast/forms/form-element-geometry-expected.png:
              * fast/forms/negativeLineHeight-expected.checksum:
              * fast/forms/negativeLineHeight-expected.png:
              * fast/forms/textAreaLineHeight-expected.checksum:
              * fast/forms/textAreaLineHeight-expected.png:
              * fast/forms/textarea-setinnerhtml-expected.checksum:
              * fast/forms/textarea-setinnerhtml-expected.png:
              * fast/overflow/overflow-x-y-expected.checksum:
              * fast/overflow/overflow-x-y-expected.png:
              * fast/table/003-expected.checksum:
              * fast/table/003-expected.png:
              * tables/mozilla/bugs/bug194024-expected.checksum:
              * tables/mozilla/bugs/bug194024-expected.png:
              * tables/mozilla/bugs/bug30559-expected.checksum:
              * tables/mozilla/bugs/bug30559-expected.png:
              * tables/mozilla/bugs/bug30692-expected.checksum:
              * tables/mozilla/bugs/bug30692-expected.png:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47609000
    • thatcher's avatar
      JavaScriptCore: · 6458fe59
      thatcher authored
              Reviewed by Darin.
      
              Bug 9574: Drosera should show inline scripts within the original HTML
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9574
      
              Pass the starting line number and error message to the debugger.
      
              * kjs/debugger.cpp:
              (Debugger::sourceParsed):
              * kjs/debugger.h:
              * kjs/function.cpp:
              (KJS::GlobalFuncImp::callAsFunction):
              * kjs/function_object.cpp:
              (FunctionObjectImp::construct):
              * kjs/interpreter.cpp:
              (KJS::Interpreter::evaluate):
      
      WebCore:
      
              Reviewed by Darin.
      
              Bug 9574: Drosera should show inline scripts within the original HTML
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9574
      
              * Pass the starting line number and error message to the debugger.
              * Call parsedSource even if there was a script parse error so the
                debugger can show the parse error.
              * Pass NSURL objects to the ObjC delegate for the script URLs.
      
              * bridge/mac/WebCoreScriptDebugger.h:
              * bridge/mac/WebCoreScriptDebugger.mm:
              (toNSURL):
              (WebCoreScriptDebuggerImp::sourceParsed):
      
      WebKit:
      
              Reviewed by Darin.
      
              Bug 9574: Drosera should show inline scripts within the original HTML
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9574
      
              * Adds a new version of the didParseSource delegate callback with base line number.
              * Adds a new delegate callback for when a script fails to parse.
              * These new callbacks use NSURLs for the url parameter.
              * Adds a new script listener callback to notify when the main resource loads.
              * Adds a WebScriptErrorDomian and other keys for use with NSError.
      
              * DefaultDelegates/WebDefaultScriptDebugDelegate.m:
              (-[WebDefaultScriptDebugDelegate webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
              (-[WebDefaultScriptDebugDelegate webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
              * DefaultDelegates/WebScriptDebugServer.h:
              * DefaultDelegates/WebScriptDebugServer.m:
              (-[WebScriptDebugServer webView:didLoadMainResourceForDataSource:]):
              (-[WebScriptDebugServer webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
              (-[WebScriptDebugServer webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
              * DefaultDelegates/WebScriptDebugServerPrivate.h:
              * WebKit.exp:
              * WebView/WebDataSource.m:
              (-[WebDataSource _setPrimaryLoadComplete:]):
              * WebView/WebScriptDebugDelegate.h:
              * WebView/WebScriptDebugDelegate.m:
              (-[WebScriptCallFrame parsedSource:fromURL:sourceId:startLine:errorLine:errorMessage:]):
      
      WebKitTools:
      
              Reviewed by Darin.
      
              Bug 9574: Drosera should show inline scripts within the original HTML
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9574
      
              Refactor the JavaScript code to have a distinction between files
              and scripts. Show the script in the context of the HTML file if
              it's URL is the same as the frame's main resource. At the time of
              the disParseScript callback the main resource might not be completely
              loaded, but Drosera needs to show whatever we have at the time. Once
              the main resource is finished, update the file source and reload the file.
      
              * Drosera/DebuggerDocument.m:
              (-[DebuggerDocument pause]):
              (-[DebuggerDocument webView:didLoadMainResourceForDataSource:]):
              (-[DebuggerDocument webView:didParseSource:baseLineNumber:fromURL:sourceId:forWebFrame:]):
              (-[DebuggerDocument webView:failedToParseSource:baseLineNumber:fromURL:withError:forWebFrame:]):
              * Drosera/debugger.css:
              * Drosera/debugger.js:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6458fe59
    • ddkilzer's avatar
      WebKitTools: · b7b3b914
      ddkilzer authored
              Reviewed by Darin.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9570
              Teach prepare-ChangeLog to operate on a list of files or directories
      
              * Scripts/prepare-ChangeLog: Accept a list of files and/or directories when running.
              * Scripts/svn-create-patch: Code refactoring.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b7b3b914
  4. 24 Jun, 2006 9 commits
    • ddkilzer's avatar
      WebCore: · e730f672
      ddkilzer authored
              Build fix.  Reviewed by NOBODY.
      
              - Backed out patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=8707
                event.clientX and event.clientY should be relative to the viewport, not the canvas
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchMouseEvent):
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::MouseEvent):
              * dom/MouseEvent.h:
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::MouseRelatedEvent):
              (WebCore::MouseRelatedEvent::initCoordinates):
              * dom/MouseRelatedEvent.h:
              * dom/WheelEvent.cpp:
              (WebCore::WheelEvent::WheelEvent):
      
      LayoutTests:
      
              Build fix.  Reviewed by NOBODY.
      
              - Backed out patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=8707
                event.clientX and event.clientY should be relative to the viewport, not the canvas
      
              * fast/dom/window-xy-properties-expected.txt: Removed.
              * fast/dom/window-xy-properties.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e730f672
    • ddkilzer's avatar
      WebCore: · 9c37765c
      ddkilzer authored
              Reviewed by Darin.  Patch by Rob Buis.
      
              Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8707:
              event.clientX and event.clientY should be relative to the viewport, not the canvas
      
              Make sure clientX and clientY take into account the scroll offsets
              of the view.
      
              Test: fast/dom/window-xy-properties.html
      
              * dom/EventTargetNode.cpp:
              (WebCore::EventTargetNode::dispatchMouseEvent):
              * dom/MouseEvent.cpp:
              (WebCore::MouseEvent::MouseEvent):
              * dom/MouseEvent.h:
              * dom/MouseRelatedEvent.cpp:
              (WebCore::MouseRelatedEvent::MouseRelatedEvent):
              (WebCore::MouseRelatedEvent::initCoordinates):
              * dom/MouseRelatedEvent.h:
              * dom/WheelEvent.cpp:
              (WebCore::WheelEvent::WheelEvent):
      
      LayoutTests:
      
              Reviewed by Darin.  Patch by Rob Buis.
      
              Test cases for
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=8707>
              event.clientX and event.clientY should be relative to the viewport, not the canvas
      
              * fast/dom/window-xy-properties-expected.txt: Added.
              * fast/dom/window-xy-properties.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c37765c
    • ddkilzer's avatar
      LayoutTests: · 27667fc8
      ddkilzer authored
              Reviewed by Darin.  Patch by James G. Speth.
      
              - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8843
                add a way to build Objective-C test cases in HTML
      
              * plugins/jsobjc-dom-wrappers-expected.txt: Added.
              * plugins/jsobjc-dom-wrappers.html: Added.
              * plugins/jsobjc-simple-expected.txt: Added.
              * plugins/jsobjc-simple.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      27667fc8
    • ddkilzer's avatar
      LayoutTests: · 9f287ffc
      ddkilzer authored
              Reviewed by Darin. Patch by Rob Buis.
      
              Test cases for
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=9352>
              Webkit doesn't respect stroke-width in SVG for smaller <circle>s
      
              * svg/custom/gradient-stroke-width-expected.checksum: Added.
              * svg/custom/gradient-stroke-width-expected.png: Added.
              * svg/custom/gradient-stroke-width-expected.txt: Added.
              * svg/custom/gradient-stroke-width.svg: Added.
      
      WebCore:
      
              Reviewed by Darin. Patch by Rob Buis.
      
              http://bugzilla.opendarwin.org/show_bug.cgi?id=9352
              Webkit doesn't respect stroke-width in SVG for smaller <circle>s
      
              Make sure the stroke path is set before applying gradient transforms.
      
              * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
              (WebCore::KRenderingPaintServerGradientQuartz::setup):
              (WebCore::KRenderingPaintServerGradientQuartz::renderPath):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f287ffc
    • ddkilzer's avatar
      WebKitTools: · c97ef652
      ddkilzer authored
              Reviewed by Darin.  Patch by James G. Speth.
      
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=8843
                add a way to build Objective-C test cases in HTML
      
              Tests running in DumpRenderTree can choose to relax some restrictions of the JavaScript/Objective-C bridge
              allowing more extensive testing of the Obj-C API.  (and by more extensive, I mean this lets scripts do 
              pretty much whatever they want, including acting as delegates, generating events, instantiating obj-c
              objects, etc... )
      
              * DumpRenderTree/ObjCPlugin.h:
              * DumpRenderTree/ObjCPlugin.m: this ability is only exposed to scripts running in DumpRenderTree
              (+[ObjCPlugin isSelectorExcludedFromWebScript:]):
              (+[ObjCPlugin webScriptNameForSelector:]):
              (-[ObjCPlugin removeBridgeRestrictions:]): scripts call this to open up obj-c for extensive testing
              (+[NSObject setAllowsScriptsFullAccess:]): makes NSObject allow all selectors to be invoked from script
              (+[NSObject allowsScriptsFullAccess]):
              (+[NSObject isSelectorExcludedFromWebScript:]): when full access is enabled, no selector is excluded
              (+[NSObject webScriptNameForSelector:]): always return nil for the default selector mutation
              (-[JSObjC classNameOfObject:isSelectorExcludedFromWebScript:]):
              (+[JSObjC webScriptNameForSelector:]):
              (-[JSObjC invokeDefaultMethodWithArguments:]): shortcut for accessing classes
              (-[JSObjC lookUpClass:]): allow scripts to retrieve obj-c classes by name
              (-[JSObjC log:]): access to NSLog function
              (-[JSObjC retainObject:]): useful obj-c functions that are otherwise hard to reach from javascript
              (-[JSObjC classOfObject:]):
              (-[JSObjC classNameOfObject:]):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c97ef652
    • ap's avatar
      Rubber-stamped by Eric. · fe38bd3e
      ap authored
              Add a -h (do not follow symlinks) option to ln in derived sources build script (without it,
              a symlink was created inside the source directory on second build).
      
      JavaScriptCore:
              * JavaScriptCore.xcodeproj/project.pbxproj:
      
      WebCore:
              * WebCore.xcodeproj/project.pbxproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fe38bd3e
    • ddkilzer's avatar
      WebCore: · a7bfea3b
      ddkilzer authored
              Reviewed by Darin.  Patch by James G. Speth.  Copyrights tweaked by ddkilzer.
              
              Bug 8331: DOMNodeLists returned to Objective-C are not properly wrapped
              http://bugzilla.opendarwin.org/show_bug.cgi?id=8331
              
              DOMNodes were the only objects handled by createObjcInstanceForValue.
              now it handles all of these: DOMNode, DOMNodeList, DOMNamedNodeMap, DOMStyleSheetList,
              DOMStyleSheet, DOMMediaList, DOMCSSRuleList, DOMCSSRule, DOMCSSStyleDeclaration, and DOMCSSValue
              
              * WebCore.xcodeproj/project.pbxproj: added file DOMCSSInternal.h to project
              * bindings/js/kjs_css.cpp:
              (KJS::): changed ClassInfo for DOMCSSStyleSheet to have DOMStyleSheet as its parent class
              * bindings/objc/DOM.mm:
              (-[DOMDocumentType :]):  moved DOMNamedNodeMap (WebCoreInternal) interface to DOMInternal.h
              * bindings/objc/DOMCSS.mm: moved WebCoreInternal interfaces to DOMCSSInternal.h
              * bindings/objc/DOMCSSInternal.h: Added file, contains WebCoreInternal interface for CSS classes
              * bindings/objc/DOMInternal.h: added DOMNamedNodeMap (WebCoreInternal) interface
              * bindings/objc/DOMUtility.mm:
              (KJS::ScriptInterpreter::createObjcInstanceForValue): support for more classes
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a7bfea3b
    • ddkilzer's avatar
      JavaScriptCore: · 577f0491
      ddkilzer authored
              Reviewed by Timothy.
      
              * Info.plist: Fixed copyright to include 2003-2006.
      
      JavaScriptGlue:
      
              Reviewed by Timothy.
      
              * Info.plist: Fixed copyright to include 2003-2006.
      
      WebCore:
      
              Reviewed by Timothy.
      
              * Info.plist: Fixed copyright to include 2003-2006.
              * manual-tests/NPN_Invoke/Info.plist: Added copyright statement.
      
      WebKit:
      
              Reviewed by Timothy.
      
              * Info.plist: Fixed copyright to include 2003-2006.
      
      WebKitTools:
      
              Reviewed by Timothy.
      
              * DrawTest/Info.plist: Added copyright statement.
              * Drosera/Info.plist: Ditto.
              * DumpRenderTree/TestNetscapePlugIn.subproj/Info.plist: Ditto.
              * WebKitLauncher/Info.plist: Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      577f0491
    • ddkilzer's avatar
      WebKitTools: · 79a81ae5
      ddkilzer authored
              Build fix. Reviewed by NOBODY.
      
              - Backed out http://bugzilla.opendarwin.org/show_bug.cgi?id=7802
                devenv.com not available in VC++ Express installations
      
              * Scripts/webkitdirs.pm: Backed out previous change.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@15016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      79a81ae5