1. 11 Sep, 2013 40 commits
    • commit-queue@webkit.org's avatar
      MapData and WeakMapData don't need to be objects · b1511430
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121167
      
      Patch by Sam Weinig <sam@webkit.org> on 2013-09-11
      Reviewed by Geoffrey Garen.
      
      * runtime/JSGlobalObject.cpp:
      (JSC::JSGlobalObject::reset):
      (JSC::JSGlobalObject::visitChildren):
      * runtime/JSGlobalObject.h:
      (JSC::JSGlobalObject::mapStructure):
      Remove MapData and WeakMapData structures (they moved to VM with other non-object Structures).
      
      * runtime/JSMap.cpp:
      (JSC::JSMap::finishCreation):
      * runtime/JSMap.h:
      (JSC::JSMap::create):
      * runtime/JSSet.cpp:
      (JSC::JSSet::finishCreation):
      * runtime/JSSet.h:
      (JSC::JSSet::create):
      * runtime/JSWeakMap.cpp:
      (JSC::JSWeakMap::finishCreation):
      * runtime/JSWeakMap.h:
      (JSC::JSWeakMap::create):
      Update to not pass a global object to the MapData or WeakMapData Structure.
      
      * runtime/MapData.cpp:
      (JSC::MapData::MapData):
      * runtime/MapData.h:
      (JSC::MapData::create):
      (JSC::MapData::createStructure):
      * runtime/WeakMapData.cpp:
      (JSC::WeakMapData::WeakMapData):
      (JSC::WeakMapData::set): Change to take a VM rather than a CallFrame, as that it all it needs.
      * runtime/WeakMapData.h:
      (JSC::WeakMapData::create):
      (JSC::WeakMapData::createStructure):
      Instead of inheriting from JSDestructibleObject, inherit from JSCell and mark self as needing destruction
      and having an immortal structure.
      
      * runtime/VM.cpp:
      (JSC::VM::VM):
      * runtime/VM.h:
      Add MapData and WeakMapData Structures.
      
      * runtime/WeakMapPrototype.cpp:
      (JSC::protoFuncWeakMapSet):
      Pass a VM rather than an ExecState.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155558 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1511430
    • bfulgham@apple.com's avatar
      [Windows] Revise GDI Create Functions to use GDIObject Smart Pointer. · f44603e1
      bfulgham@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121100
      
      Reviewed by Anders Carlsson.
      
      * platform/graphics/FontPlatformData.h: Use GDIObject instead of bare pointer.
      * platform/graphics/win/FontCacheWin.cpp:
      (WebCore::createGDIFont): No longer need to leak the pointer; use move semantic
      to pass ownership to FontPlatformData.
      (WebCore::FontCache::createFontPlatformData):
      * platform/graphics/win/FontCustomPlatformData.cpp:
      (WebCore::FontCustomPlatformData::fontPlatformData): Use move operation.
      * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
      (WebCore::FontCustomPlatformData::fontPlatformData): Ditto.
      * platform/graphics/win/FontPlatformDataCGWin.cpp:
      (WebCore::FontPlatformData::FontPlatformData): Ditto.
      * platform/graphics/win/FontPlatformDataCairoWin.cpp:
      (WebCore::FontPlatformData::FontPlatformData): Ditto.
      * platform/graphics/win/FontPlatformDataWin.cpp:
      (WebCore::FontPlatformData::FontPlatformData): Ditto.
      * platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp:
      (WebCore::GlyphPage::fill): Use HWndDC smart pointer instead of bare HDC.
      * platform/graphics/win/SimpleFontDataWin.cpp:
      (WebCore::SimpleFontData::platformCreateScaledFontData): Use move operation.
      * platform/win/DragImageCGWin.cpp:
      (WebCore::allocImage): Change to use GDIObject.
      (WebCore::scaleDragImage): Use smart pointers to avoid manual deallocs.
      (WebCore::createDragImageFromImage): Ditto.
      * platform/win/DragImageCairoWin.cpp:
      (WebCore::allocImage): Change to use GDIObject.
      (WebCore::scaleDragImage): Use smart pointers to avoid manual deallocs.
      (WebCore::createDragImageFromImage): Ditto.
      * platform/win/DragImageWin.cpp:
      (WebCore::createDragImageForLink): Update for GDIObject.
      * platform/win/PopupMenuWin.cpp:
      (WebCore::PopupMenuWin::PopupMenuWin): Switch to GDIObject.
      (WebCore::PopupMenuWin::~PopupMenuWin): Remove uneeded deallocs.
      (WebCore::PopupMenuWin::paint): Update for GDIObject.
      * platform/win/PopupMenuWin.h: Use smart pointers instead of bare GDI objects.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155557 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f44603e1
    • paroga@webkit.org's avatar
      Fix animations with !USE(ACCELERATED_COMPOSITING) after r147792. · d856e104
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121159
      
      Reviewed by Simon Fraser.
      
      CSSPropertyAnimation::blendProperties() is available always
      and needs to be called to make the animations work.
      
      * page/animation/ImplicitAnimation.cpp:
      (WebCore::ImplicitAnimation::animate):
      * page/animation/KeyframeAnimation.cpp:
      (WebCore::KeyframeAnimation::animate):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155556 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d856e104
    • hyatt@apple.com's avatar
      Move all collapsing margin code out of RenderBlock and into RenderBlockFlow. · 1807b5bc
      hyatt@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121049
      
      Reviewed by Dean Jackson.
      
      This patch begins the migration of the rare data struct of RenderBlock into
      RenderBlockFlow. During this process we will temporarily have rare data structs
      in both places, but ultimately all of the members are going to move down into
      RenderBlockFlow, and if any don't, they will get forced into a hash.
              
      For this patch, the margin information is being shifted out of RenderBlock and into
      RenderBlockFlow. Any functions that refer to MarginValues or to MarginInfo also got
      moved down into RenderBlockFlow. Most of block child layout is now in RenderBlockFlow
      after this patch.
              
      Note that in many cases the code didn't simply move. There is some type tightening
      that happened as well, i.e., places that look for RenderBlock can now look for
      RenderBlockFlow instead and let RenderBlock execute the base RenderBox functions.
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::RenderBlock):
      (WebCore::RenderBlock::setPaginationStrut):
      (WebCore::RenderBlock::setPageLogicalOffset):
      (WebCore::RenderBlock::setBreakAtLineToAvoidWidow):
      * rendering/RenderBlock.h:
      (WebCore::RenderBlock::setLineGridBox):
      (WebCore::RenderBlock::setShapeInsideInfo):
      (WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
      * rendering/RenderBlockFlow.cpp:
      (WebCore::RenderBlockFlow::MarginInfo::MarginInfo):
      (WebCore::RenderBlockFlow::RenderBlockFlow):
      (WebCore::RenderBlockFlow::layoutBlockChild):
      (WebCore::RenderBlockFlow::adjustPositionedBlock):
      (WebCore::RenderBlockFlow::adjustFloatingBlock):
      (WebCore::RenderBlockFlow::marginValuesForChild):
      (WebCore::RenderBlockFlow::collapseMargins):
      (WebCore::RenderBlockFlow::clearFloatsIfNeeded):
      (WebCore::RenderBlockFlow::marginBeforeEstimateForChild):
      (WebCore::RenderBlockFlow::estimateLogicalTopPosition):
      (WebCore::RenderBlockFlow::setCollapsedBottomMargin):
      (WebCore::RenderBlockFlow::handleAfterSideOfBlock):
      (WebCore::RenderBlockFlow::setMaxMarginBeforeValues):
      (WebCore::RenderBlockFlow::setMaxMarginAfterValues):
      (WebCore::RenderBlockFlow::setMustDiscardMarginBefore):
      (WebCore::RenderBlockFlow::setMustDiscardMarginAfter):
      (WebCore::RenderBlockFlow::mustDiscardMarginBefore):
      (WebCore::RenderBlockFlow::mustDiscardMarginAfter):
      (WebCore::RenderBlockFlow::mustDiscardMarginBeforeForChild):
      (WebCore::RenderBlockFlow::mustDiscardMarginAfterForChild):
      (WebCore::RenderBlockFlow::mustSeparateMarginBeforeForChild):
      (WebCore::RenderBlockFlow::mustSeparateMarginAfterForChild):
      (WebCore::inNormalFlow):
      (WebCore::RenderBlockFlow::applyBeforeBreak):
      (WebCore::RenderBlockFlow::applyAfterBreak):
      (WebCore::RenderBlockFlow::adjustBlockChildForPagination):
      * rendering/RenderBlockFlow.h:
      (WebCore::RenderBlockFlow::MarginValues::MarginValues):
      (WebCore::RenderBlockFlow::MarginValues::positiveMarginBefore):
      (WebCore::RenderBlockFlow::MarginValues::negativeMarginBefore):
      (WebCore::RenderBlockFlow::MarginValues::positiveMarginAfter):
      (WebCore::RenderBlockFlow::MarginValues::negativeMarginAfter):
      (WebCore::RenderBlockFlow::MarginValues::setPositiveMarginBefore):
      (WebCore::RenderBlockFlow::MarginValues::setNegativeMarginBefore):
      (WebCore::RenderBlockFlow::MarginValues::setPositiveMarginAfter):
      (WebCore::RenderBlockFlow::MarginValues::setNegativeMarginAfter):
      (WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
      (WebCore::RenderBlockFlow::RenderBlockFlowRareData::positiveMarginBeforeDefault):
      (WebCore::RenderBlockFlow::RenderBlockFlowRareData::negativeMarginBeforeDefault):
      (WebCore::RenderBlockFlow::RenderBlockFlowRareData::positiveMarginAfterDefault):
      (WebCore::RenderBlockFlow::RenderBlockFlowRareData::negativeMarginAfterDefault):
      (WebCore::RenderBlockFlow::MarginInfo::setAtBeforeSideOfBlock):
      (WebCore::RenderBlockFlow::MarginInfo::setAtAfterSideOfBlock):
      (WebCore::RenderBlockFlow::MarginInfo::clearMargin):
      (WebCore::RenderBlockFlow::MarginInfo::setHasMarginBeforeQuirk):
      (WebCore::RenderBlockFlow::MarginInfo::setHasMarginAfterQuirk):
      (WebCore::RenderBlockFlow::MarginInfo::setDeterminedMarginBeforeQuirk):
      (WebCore::RenderBlockFlow::MarginInfo::setPositiveMargin):
      (WebCore::RenderBlockFlow::MarginInfo::setNegativeMargin):
      (WebCore::RenderBlockFlow::MarginInfo::setPositiveMarginIfLarger):
      (WebCore::RenderBlockFlow::MarginInfo::setNegativeMarginIfLarger):
      (WebCore::RenderBlockFlow::MarginInfo::setMargin):
      (WebCore::RenderBlockFlow::MarginInfo::setCanCollapseMarginAfterWithChildren):
      (WebCore::RenderBlockFlow::MarginInfo::setDiscardMargin):
      (WebCore::RenderBlockFlow::MarginInfo::atBeforeSideOfBlock):
      (WebCore::RenderBlockFlow::MarginInfo::canCollapseWithMarginBefore):
      (WebCore::RenderBlockFlow::MarginInfo::canCollapseWithMarginAfter):
      (WebCore::RenderBlockFlow::MarginInfo::canCollapseMarginBeforeWithChildren):
      (WebCore::RenderBlockFlow::MarginInfo::canCollapseMarginAfterWithChildren):
      (WebCore::RenderBlockFlow::MarginInfo::quirkContainer):
      (WebCore::RenderBlockFlow::MarginInfo::determinedMarginBeforeQuirk):
      (WebCore::RenderBlockFlow::MarginInfo::hasMarginBeforeQuirk):
      (WebCore::RenderBlockFlow::MarginInfo::hasMarginAfterQuirk):
      (WebCore::RenderBlockFlow::MarginInfo::positiveMargin):
      (WebCore::RenderBlockFlow::MarginInfo::negativeMargin):
      (WebCore::RenderBlockFlow::MarginInfo::discardMargin):
      (WebCore::RenderBlockFlow::MarginInfo::margin):
      (WebCore::RenderBlockFlow::maxPositiveMarginBefore):
      (WebCore::RenderBlockFlow::maxNegativeMarginBefore):
      (WebCore::RenderBlockFlow::maxPositiveMarginAfter):
      (WebCore::RenderBlockFlow::maxNegativeMarginAfter):
      (WebCore::RenderBlockFlow::initMaxMarginValues):
      * rendering/RenderDeprecatedFlexibleBox.cpp:
      (WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
      * rendering/RenderTable.cpp:
      (WebCore::RenderTable::layout):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1807b5bc
    • commit-queue@webkit.org's avatar
      Fix nested unicode-bidi: isolate · 1968a430
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120504
      
      Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-09-11
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      When we have a nested isolate renderer if the outer isolate has a text
      and this text is not the first child, the isolated chain is not
      rendered correctly. This happens because constructBidiRunsForSegment
      uses always the first inner isolated renderer as isolated inline
      container. This patch fixes the behavior described changing
      containingIsolate to find the right isolated container.
      
      Merged from Blink: https://chromium.googlesource.com/chromium/blink/+/840a57050eade39dd04dde0c6603e129b783151c
      
      Tests: fast/text/international/unicode-bidi-isolate-nested-first-child-text.html
             fast/text/international/unicode-bidi-isolate-nested-simple.html
      
      * rendering/InlineIterator.h:
      (WebCore::containingIsolate):
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::constructBidiRunsForSegment):
      
      LayoutTests:
      
      * fast/text/international/unicode-bidi-isolate-nested-first-child-text-expected.html: Added.
      * fast/text/international/unicode-bidi-isolate-nested-first-child-text.html: Added.
      * fast/text/international/unicode-bidi-isolate-nested-simple-expected.html: Added.
      * fast/text/international/unicode-bidi-isolate-nested-simple.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155554 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1968a430
    • ap@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=121169 · 50b732ce
      ap@apple.com authored
      media/track/track-cue-rendering-vertical.html is flaky on Mac
      
      Reviewed by Eric Carlson.
      
      Source/WebCore:
      
      * html/shadow/MediaControlElements.cpp:
      (WebCore::MediaControlTextTrackContainerElement::updateSizes): Added a FIXME.
      
      LayoutTests:
      
      * media/media-reparent.html: Changed to use setTimeout directly.
      
      * media/video-test.js:
      (endTest): Added a zero delay timer to let text track layout do its work.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      50b732ce
    • andersca@apple.com's avatar
      Source/WebCore: Stop using deleteAllValues in SVG code · 979942dd
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121172
      
      Reviewed by Antti Koivisto.
      
      Use OwnPtr for values instead.
      
      * rendering/svg/RenderSVGResourceClipper.cpp:
      (WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper):
      (WebCore::RenderSVGResourceClipper::removeAllClientsFromCache):
      (WebCore::RenderSVGResourceClipper::removeClientFromCache):
      (WebCore::RenderSVGResourceClipper::applyClippingToContext):
      * rendering/svg/RenderSVGResourceClipper.h:
      * rendering/svg/RenderSVGResourceFilter.cpp:
      (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
      (WebCore::RenderSVGResourceFilter::removeAllClientsFromCache):
      (WebCore::RenderSVGResourceFilter::removeClientFromCache):
      (WebCore::RenderSVGResourceFilter::applyResource):
      (WebCore::RenderSVGResourceFilter::postApplyResource):
      (WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
      * rendering/svg/RenderSVGResourceFilter.h:
      * rendering/svg/RenderSVGResourceMasker.cpp:
      (WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker):
      (WebCore::RenderSVGResourceMasker::removeAllClientsFromCache):
      (WebCore::RenderSVGResourceMasker::removeClientFromCache):
      (WebCore::RenderSVGResourceMasker::applyResource):
      * rendering/svg/RenderSVGResourceMasker.h:
      
      Source/WTF: Vector::append doesn't work if element type has overloaded operator&
      https://bugs.webkit.org/show_bug.cgi?id=121175
      
      Reviewed by Brent Fulgham.
      
      Use std::addressof to get the address of the given object.
      
      * wtf/Vector.h:
      (WTF::::appendSlowCase):
      (WTF::::uncheckedAppend):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155552 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      979942dd
    • andersca@apple.com's avatar
      Vector::append doesn't work if element type has overloaded operator& · 6af248e3
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121175
      
      Reviewed by Brent Fulgham.
      
      Source/WTF:
      
      Use std::addressof to get the address of the given object.
      
      * wtf/Vector.h:
      (WTF::::appendSlowCase):
      (WTF::::uncheckedAppend):
      
      Tools:
      
      Add a test case.
      
      * TestWebKitAPI/Tests/WTF/Vector.cpp:
      (TestWebKitAPI::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155551 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6af248e3
    • rniwa@webkit.org's avatar
      Make the table static const. · 19589b55
      rniwa@webkit.org authored
      * css/makeprop.pl:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19589b55
    • timothy@apple.com's avatar
      Remove TimelineTraceEventProcessor since no current ports use it · 01b4acba
      timothy@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121171
      
      Reviewed by Joseph Pecoraro.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * Target.pri:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * inspector/InspectorAllInOne.cpp:
      * inspector/InspectorClient.h:
      * inspector/InspectorInstrumentation.cpp:
      * inspector/InspectorInstrumentation.h:
      * inspector/InspectorTimelineAgent.cpp:
      (WebCore::InspectorTimelineAgent::start):
      (WebCore::InspectorTimelineAgent::stop):
      * inspector/InspectorTimelineAgent.h:
      * inspector/TimelineTraceEventProcessor.cpp: Removed.
      * inspector/TimelineTraceEventProcessor.h: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155549 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      01b4acba
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r155519. · 0ce6a86a
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/155519
      https://bugs.webkit.org/show_bug.cgi?id=121174
      
      Included regression test fails, and an existing test started
      to crash (Requested by ap on #webkit).
      
      Source/WebCore:
      
      * dom/Document.cpp:
      (WebCore::Document::hoveredElementDidDetach):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler):
      (WebCore::EventHandler::clear):
      (WebCore::EventHandler::handleMouseMoveEvent):
      (WebCore::EventHandler::scheduleHoverStateUpdate):
      (WebCore::EventHandler::hoverTimerFired):
      * page/EventHandler.h:
      
      LayoutTests:
      
      * fast/events/mouseenterleave-detached-element-expected.txt: Removed.
      * fast/events/mouseenterleave-detached-element.html: Removed.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155548 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0ce6a86a
    • andersca@apple.com's avatar
      Stop using deleteAllValues in SVG code · 909ece73
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121172
      
      Reviewed by Antti Koivisto.
      
      Use OwnPtr for values instead.
      
      * rendering/svg/RenderSVGResourceClipper.cpp:
      (WebCore::RenderSVGResourceClipper::~RenderSVGResourceClipper):
      (WebCore::RenderSVGResourceClipper::removeAllClientsFromCache):
      (WebCore::RenderSVGResourceClipper::removeClientFromCache):
      (WebCore::RenderSVGResourceClipper::applyClippingToContext):
      * rendering/svg/RenderSVGResourceClipper.h:
      * rendering/svg/RenderSVGResourceFilter.cpp:
      (WebCore::RenderSVGResourceFilter::~RenderSVGResourceFilter):
      (WebCore::RenderSVGResourceFilter::removeAllClientsFromCache):
      (WebCore::RenderSVGResourceFilter::removeClientFromCache):
      (WebCore::RenderSVGResourceFilter::applyResource):
      (WebCore::RenderSVGResourceFilter::postApplyResource):
      (WebCore::RenderSVGResourceFilter::primitiveAttributeChanged):
      * rendering/svg/RenderSVGResourceFilter.h:
      * rendering/svg/RenderSVGResourceMasker.cpp:
      (WebCore::RenderSVGResourceMasker::~RenderSVGResourceMasker):
      (WebCore::RenderSVGResourceMasker::removeAllClientsFromCache):
      (WebCore::RenderSVGResourceMasker::removeClientFromCache):
      (WebCore::RenderSVGResourceMasker::applyResource):
      * rendering/svg/RenderSVGResourceMasker.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155547 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      909ece73
    • simon.fraser@apple.com's avatar
      REGRESSION (143483): overflow:hidden doesn't quash big repaints from text-indent: -9999px · e7508bc8
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121137
      
      Source/WebCore:
      
      Reviewed by Ryosuke Niwa.
      
      The change in r143483 made it so that negative text-indent gets added
      to visual oveflow even when we have overflow:hidden, which is really bad
      because it causes large repaints (and large layers) for a common-on-the-web
      pattern.
      
      Revert the change, and add a new test to make sure it doesn't regress.
      
      I can't reproduce the bug it was trying to fix with the change reverted.
      
      Tests: compositing/geometry/negative-text-indent-with-overflow-hidden-layer.html
             fast/repaint/negative-text-indent-with-overflow-hidden.html
      
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::computeOverflow):
      
      LayoutTests:
      
      Reviewed by Ryosuke Niwa.
      
      Text-based repaint test, and test for compositing layer geometry.
      
      * compositing/geometry/negative-text-indent-with-overflow-hidden-layer-expected.txt: Added.
      * compositing/geometry/negative-text-indent-with-overflow-hidden-layer.html: Added.
      * fast/repaint/negative-text-indent-with-overflow-hidden-expected.txt: Added.
      * fast/repaint/negative-text-indent-with-overflow-hidden.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155546 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e7508bc8
    • simon.fraser@apple.com's avatar
      Optionally show visual and layout overflow rects in layer tree dumps · 082bd052
      simon.fraser@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121135
      
      Reviewed by Beth Dakin.
      
      When calling showLayerTree() from the debugger, show overflow rects
      (visaul and layout) for renderers.
      
      Does not affect test output.
      
      * rendering/RenderLayer.cpp:
      (showLayerTree): Pass the new flag to show overflow rects.
      * rendering/RenderTreeAsText.cpp:
      (WebCore::RenderTreeAsText::writeRenderObject): Print the rects.
      (WebCore::write): Don't force layout on subframes if the "dont' layout"
      flag is set.
      * rendering/RenderTreeAsText.h: New flag.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155545 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      082bd052
    • bfulgham@apple.com's avatar
      [Windows] Unreviewed build correction after r155507. · b9e67d7c
      bfulgham@apple.com authored
      * WebCoreSupport/WebChromeClient.cpp: Add missing header include
      to define isHTMLVideoElement.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155544 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b9e67d7c
    • cfleizach@apple.com's avatar
      AX: WebKit exposes AXTitleUIElement incorrectly on checkboxes and radio buttons · f157e081
      cfleizach@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121039
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      Stop hiding <label> elements for radio buttons and checkboxes (and using the text inside them for the AXTitle).
      Instead, expose the <label> element as the titleUIElement if appropriate for the input.
      
      This implies:
         1) The web will no longer match MacOS behavior exactly (the text and the checkbox control are combined on MacOS into one element)
         2) But, the user will now be able to explore the <label> element which may include links or other important controls.
      I think sacrificing 1) here is a good tradeoff. The user will likely never know the difference in terms of output.
      
      Test: platform/mac/accessibility/label-elements-exposed-as-title-ui-elements.html
      
      * accessibility/AccessibilityNodeObject.cpp:
      (WebCore::AccessibilityNodeObject::titleElementText):
      (WebCore::AccessibilityNodeObject::title):
      * accessibility/AccessibilityRenderObject.cpp:
      (WebCore::AccessibilityRenderObject::hasTextAlternative):
      (WebCore::AccessibilityRenderObject::exposesTitleUIElement):
      
      LayoutTests: 
      
      * accessibility/label-for-control-hittest-expected.txt: Removed.
      * accessibility/label-for-control-hittest.html: Removed.
            We no longer need this test since we are not combining label + control into one element anymore.
      * accessibility/radio-button-group-members.html:
            Rewrite this test to be more modern (don't just dump attributes). 
            Instead test for what we want to know (whether radio button group members can identify their siblings)
      * accessibility/radio-button-title-label-expected.txt:
      * accessibility/radio-button-title-label.html:
            Rewrite this test so that it understands that controls won't hide their <label> elements.
      * platform/mac/accessibility/label-element-with-hidden-control-expected.txt:
      * platform/mac/accessibility/label-element-with-hidden-control.html:
            Update test to reflect that title UI elements are exposed for some controls.
      * platform/mac/accessibility/label-elements-exposed-as-title-ui-elements-expected.txt: Added.
      * platform/mac/accessibility/label-elements-exposed-as-title-ui-elements.html: Added.
            New test to explicitly confirm that <label> is exposed as a title UI element.
      * platform/mac/accessibility/radio-button-group-members-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155543 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f157e081
    • andersca@apple.com's avatar
      VectorBuffer::swap doesn't need to use std::swap_ranges · 69f00660
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121164
      
      Reviewed by Darin Adler.
      
      There's a std::swap overload for swapping arrays, just use it instead.
      
      * wtf/Vector.h:
      (WTF::VectorBuffer::swap):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      69f00660
    • andersca@apple.com's avatar
      Implement Vector::append for move-only types · 96e736c6
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120805
      
      Source/WTF:
      
      Reviewed by Andreas Kling.
      
      * wtf/Vector.h:
      (WTF::::expandCapacity):
      Remove const from the pointer passed to expandCapacity, it can be non-const if we're moving.
      
      (WTF::::append):
      Change append to take U&& and use std::forward when constructing the element and when passing
      the element along to appendSlowCase if that's necessary.
      
      (WTF::::appendSlowCase):
      Use std::forward.
      
      (WTF::::uncheckedAppend):
      Rename val to value.
      
      Tools:
      
      Reviewed by Sam Weinig.
      
      Add a test for Vector<MoveOnly>::append.
      
      * TestWebKitAPI/Tests/WTF/Vector.cpp:
      (TestWebKitAPI::TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155541 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      96e736c6
    • akling@apple.com's avatar
      Remove unnecessary Document::frame() null checks in rendererIsNeeded(). · b117102e
      akling@apple.com authored
      <https://webkit.org/b/121166>
      
      Reviewed by Anders Carlsson.
      
      rendererIsNeeded() is only called during style resolve, which only happens
      while there's a Frame present.
      
      * html/HTMLEmbedElement.cpp:
      (WebCore::HTMLEmbedElement::rendererIsNeeded):
      * html/HTMLMediaElement.cpp:
      (WebCore::HTMLMediaElement::rendererIsNeeded):
      * html/HTMLObjectElement.cpp:
      * html/HTMLObjectElement.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b117102e
    • ossy@webkit.org's avatar
      ARM buildfix after r155491 · 8e5a0193
      ossy@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121152
      
      Reviewed by Anders Carlsson.
      
      FELightingNEON.cpp and FELightingNEON.h is inside COMPILER(GCC) guard, so it's safe to use GCC attribute.
      
      * platform/graphics/cpu/arm/filters/FELightingNEON.cpp: Use __aligned__ GCC attribute directly.
      * platform/graphics/cpu/arm/filters/FELightingNEON.h: Use __aligned__ GCC attribute instead of ugly template magic.
      (WebCore::FELighting::platformApplyNeon):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155539 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8e5a0193
    • ossy@webkit.org's avatar
      Unreviewed. Fix the indentation after r105848. Typo fix after r155523. · 2fe6c6d0
      ossy@webkit.org authored
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (RunAndUploadPerfTests):
      (RunAndUploadPerfTests.start):
      (RunAndUploadPerfTests.getText2):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2fe6c6d0
    • commit-queue@webkit.org's avatar
      [WinCairo] Compile errors. · 71a74ee3
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121153
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-11
      Reviewed by Brent Fulgham.
      
      * page/win/FrameCairoWin.cpp:
      (WebCore::imageFromRect): Return empty GDIObject.
      * platform/graphics/win/FontCustomPlatformDataCairo.cpp:
      (WebCore::FontCustomPlatformData::fontPlatformData): Get actual handle from GDIObject.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155537 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      71a74ee3
    • darin@apple.com's avatar
      Rework CSS parser, eliminating "floating" concept and using %destructor · 4ab3de15
      darin@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121161
      
      Reviewed by Antti Koivisto.
      
      This is some basic improvement, but there is still room for a lot more
      consistent approach and formatting in this file. There is a mix of code that
      works by side effects in the CSSParser class and code that works with the
      values that bison generates in the union that is more or less random. And
      the data structures seem too costly, with too much heap allocation. And the
      CSSParser class has grown massive, with a mix of both function for use by
      code that wants to trigger parsing, and helper functions called by code in
      the grammar file. All of that can benefit from more refinement in the future.
      
      * css/CSSGrammar.y.in: Made some incremental improvements to the structure
      of the grammar file, including:
      - Breaking up the %union so types are declared next to their use
      - Eliminating one shift/reduce conflict caused by two "maybe_space" in a row
      - Breaking the conditional sections out into their own sections instead of
        scattering them in with the other code.
      - Eliminating unused return values in productions such as charset,
        ignored_charset, namespace, margin_box, invalid_rule, save_block,
        invalid_at, and declarations_and_margins.
      - Adding %destructor to productions that return values that need to be deleted
        or deref'd. This removes the need for CSSParser to separately track these
        as "floating" to clean up in case of errors.
      - Removing unneeded productions such as media_feature, region_selector,
        attr_name, and medium.
      - Removing explicit code blocks that just say "$$ = $1" or empty blocks when
        there is no return type, since those are default.
      - Formatting many productions on single lines since I find them easier to read.
        Later I think we could make many more CSSParser functions and make even
        more of the production single lines in the grammar file.
      - Using adoptPtr, adoptRef, delete, deref, leakPtr, and leakRef to put
        heap allocated values into and out of the union without storage leaks.
      
      * css/CSSParser.cpp:
      (WebCore::CSSParser::~CSSParser): Remove the now-unneeded deleteAllValues for
      the various colections of floating things.
      (WebCore::CSSParser::createFilterRule): Don't put the rule into m_parsedRules,
      just return a PassRefPtr instead.
      (WebCore::CSSParser::createImportRule): Ditto.
      (WebCore::CSSParser::createMediaRule): Ditto.
      (WebCore::CSSParser::createEmptyMediaRule): Ditto.
      (WebCore::CSSParser::createSupportsRule): Ditto.
      (WebCore::CSSParser::createKeyframesRule): Ditto.
      (WebCore::CSSParser::createStyleRule): Ditto.
      (WebCore::CSSParser::createFontFaceRule): Ditto.
      (WebCore::CSSParser::createHostRule): Ditto.
      (WebCore::CSSParser::rewriteSpecifiersWithNamespaceIfNeeded): Got rid of the
      unused return value from this function and changed it to to take a reference
      instead of a pointer.
      (WebCore::CSSParser::rewriteSpecifiersWithElementName): Ditto.
      (WebCore::CSSParser::rewriteSpecifiers): Changed this to take and return OwnPtr.
      (WebCore::CSSParser::createPageRule): Don't put rule into m_parsedRules, return
      PassRefPtr instead.
      (WebCore::CSSParser::createSelectorVector): Added. Used to implement the
      optimization where we recycle a single selector vector. Not sure we still need
      this, or maybe we need more optimizations like it, but for now keep it.
      (WebCore::CSSParser::recycleSelectorVector): Ditto.
      (WebCore::CSSParser::createRegionRule): Don't put rule into m_parsedRules, return
      PassRefPtr instead.
      (WebCore::CSSParser::createMarginAtRule): Got rid of unused return value.
      When this function is implemented for real, we might add a return value.
      (WebCore::CSSParser::createKeyframe): Don't put keyframe into m_parsedKeyframes,
      return PassRefPtr instead.
      (WebCore::CSSParser::createViewportRule): Don't put rule into m_parsedRules, return
      PassRefPtr instead.
      
      * css/CSSParser.h: Removed many now-needed functions to manage floating items.
      Changed rule creation functions to return PassRefPtr. Other changes as mentioned above.
      
      * css/CSSParserValues.cpp:
      (WebCore::destroy): Added.
      (WebCore::CSSParserValueList::~CSSParserValueList): Updated to call destroy.
      * css/CSSParserValues.h: Ditto.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155536 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4ab3de15
    • andersca@apple.com's avatar
      The style checker shouldn't complain about returning or passing OwnPtr · 2b3d1eb9
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121163
      
      Reviewed by Antti Koivisto.
      
      * Scripts/webkitpy/style/checkers/cpp.py:
      (check_function_definition_and_pass_ptr):
      * Scripts/webkitpy/style/checkers/cpp_unittest.py:
      (PassPtrTest.test_pass_ref_ptr_return_value):
      (PassPtrTest.test_own_ptr_parameter_value):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155535 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b3d1eb9
    • mario@webkit.org's avatar
      [GTK] Remove Gail dependency from build system for GTK3 · 888b8c1d
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119673
      
      Reviewed by Gustavo Noronha Silva.
      
      .:
      
      * Source/autotools/FindDependencies.m4: Don't look for GAIL at all.
      * Source/autotools/Versions.m4: Removed any reference to GAIL.
      * Source/cmake/FindGAIL3.cmake: Removed.
      * Source/cmake/OptionsGTK.cmake: Don't look for the GAIL package.
      
      Source/WebCore:
      
      * GNUmakefile.am: Removed GAIL_CFLAGS.
      * PlatformGTK.cmake: Removed GAIL3_INCLUDE_DIRS and GAIL3_LIBRARIES.
      
      Source/WebKit/gtk:
      
      * GNUmakefile.am: Removed GAIL_CFLAGS and GAIL_LIBS.
      
      Source/WebKit2:
      
      * GNUmakefile.am: Removed GAIL_LIBS.
      
      Tools:
      
      * EWSTools/ubuntu-ews-packages: Removed libgail-dev package.
      * Scripts/webkitpy/port/gtk.py:
      (GtkPort.setup_environ_for_server): Do not load the 'gail' module anymore.
      * TestWebKitAPI/GNUmakefile.am: Removed GAIL_LIBS.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      888b8c1d
    • berto@igalia.com's avatar
      [WK2] [GTK] LayerTreeHostGtk: don't set m_isValid to false if glContext() returns null · 3f64f459
      berto@igalia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120892
      
      Reviewed by Martin Robinson.
      
      If the GL context cannot be created then m_isValid is set to false
      during the initialization of LayerTreeHostGtk.
      
      This is not really necessary since the rest of the code already
      deals with that situation, so it doesn't have any effect other
      than breaking the assertion in invalidate().
      
      * WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
      (WebKit::LayerTreeHostGtk::initialize):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155533 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3f64f459
    • commit-queue@webkit.org's avatar
      Unreviewed, rolling out r154899. · 3d95f65c
      commit-queue@webkit.org authored
      http://trac.webkit.org/changeset/154899
      https://bugs.webkit.org/show_bug.cgi?id=121162
      
      It didn't fix the problem and broke other unit tests
      (Requested by KaL on #webkit).
      
      * UIProcess/API/gtk/tests/WebViewTest.cpp:
      (WebViewTest::resizeView):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155532 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d95f65c
    • commit-queue@webkit.org's avatar
      [EFL] Changed expected results after r155253 · 840349ae
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121157
      
      Unreviewed EFL gardening.
      
      Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-09-11
      
      * platform/efl/editing/deleting/delete-br-004-expected.png:
      * platform/efl/editing/deleting/delete-br-004-expected.txt:
      * platform/efl/editing/deleting/delete-br-005-expected.png:
      * platform/efl/editing/deleting/delete-br-005-expected.txt:
      * platform/efl/editing/deleting/delete-br-006-expected.png:
      * platform/efl/editing/deleting/delete-br-006-expected.txt:
      * platform/efl/editing/selection/caret-ltr-right-expected.png:
      * platform/efl/editing/selection/caret-ltr-right-expected.txt:
      * platform/efl/editing/selection/caret-rtl-2-left-expected.png:
      * platform/efl/editing/selection/caret-rtl-2-left-expected.txt:
      * platform/efl/editing/selection/caret-rtl-right-expected.png:
      * platform/efl/editing/selection/caret-rtl-right-expected.txt:
      * platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png:
      * platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
      * platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png:
      * platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      840349ae
    • akling@apple.com's avatar
      Remove Widget::widgetPositionsUpdated(). · ec7cc010
      akling@apple.com authored
      <https://webkit.org/b/121160>
      
      Reviewed by Anders Carlsson.
      
      Remove this no-op virtual that was only used by chromium.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155530 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec7cc010
    • akling@apple.com's avatar
      Page::backForward() should return a reference. · 31cf0095
      akling@apple.com authored
      <https://webkit.org/b/121151>
      
      Reviewed by Anders Carlsson.
      
      There is always a BackForwardController, so make backForward() return a reference.
      Also made it store a Page& internally since it's tied to the lifetime of Page.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155529 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      31cf0095
    • mikhail.pozdnyakov@intel.com's avatar
      WTF::OwnPtr should behave similarly with the rest of WTF smart pointers · 11f610c1
      mikhail.pozdnyakov@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120773
      
      Reviewed by Anders Carlsson.
      
      Before the change OwnPtr could take either the pointer type or the pointed-to type, which was bad
      for the following reasons:
      - It distinguished OwnPtr behaviour from other WTF smart pointer classes behaviour (so it was confusing for the Client).
      - It was potential error-prone as it actually modified the type given by the Client in opaque way.
      
      Source/WebCore:
      
      * page/animation/CSSPropertyAnimation.cpp:
      (WebCore::PropertyWrapperShadow::blendSimpleOrMatchedShadowLists):
      (WebCore::PropertyWrapperShadow::blendMismatchedShadowLists):
      
      Source/WebKit2:
      
      * UIProcess/API/efl/ewk_database_manager.cpp:
      (getDatabaseOriginsCallback):
      * UIProcess/API/efl/ewk_storage_manager.cpp:
      (getStorageOriginsCallback):
      
      Source/WTF:
      
      * wtf/OwnPtr.h:
      * wtf/PassOwnPtr.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155527 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      11f610c1
    • mikhail.pozdnyakov@intel.com's avatar
      OwnPtr: Use copy/move-and-swap for assignment operators · eaee0f64
      mikhail.pozdnyakov@intel.com authored
      https://bugs.webkit.org/show_bug.cgi?id=121154
      
      Reviewed by Anders Carlsson.
      
      Rationals:
      - decrease of repeated code
      - consistency with RefPtr
      
      * wtf/OwnPtr.h:
      (WTF::=):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      eaee0f64
    • commit-queue@webkit.org's avatar
      [Win] Compile error when VIDEO is not enabled. · 19de023d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121156
      
      Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-11
      Reviewed by Andreas Kling.
      
      * WebView.cpp:
      (WebView::enterFullscreenForNode): Protect isHTMLVideoElement() function with ENABLE(VIDEO) guard.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      19de023d
    • akling@apple.com's avatar
      FrameView: Tighten widget handling code. · c35b66f7
      akling@apple.com authored
      <https://webkit.org/b/121155>
      
      Reviewed by Antti Koivisto.
      
      Harden typing in this code to work with RenderEmbeddedObject& instead of RenderObject*.
      Functions and members renamed to reflect that they only deal with embedded objects.
      
      * html/HTMLPlugInImageElement.h:
      (WebCore::toHTMLPlugInImageElement):
      
          Add a toHTMLPlugInImageElement that takes an Element&.
      
      * html/HTMLTagNames.in:
      
          Generate type helpers for applet and embed elements.
      
      * page/FrameView.h:
      * page/FrameView.cpp:
      (WebCore::FrameView::addEmbeddedObjectToUpdate):
      (WebCore::FrameView::removeEmbeddedObjectToUpdate):
      (WebCore::FrameView::updateEmbeddedObjects):
      (WebCore::FrameView::updateEmbeddedObject):
      
          Re-ordered this function in early return style. Change locals into references.
      
      * rendering/RenderEmbeddedObject.cpp:
      (WebCore::RenderEmbeddedObject::~RenderEmbeddedObject):
      (WebCore::RenderEmbeddedObject::layout):
      * rendering/RenderSnapshottedPlugIn.cpp:
      (WebCore::RenderSnapshottedPlugIn::layout):
      
          Updated for new FrameView function signatures.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c35b66f7
    • commit-queue@webkit.org's avatar
      Performance tester bots should report the number of failing tests · 95912f4f
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=120462
      
      Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-09-11
      Reviewed by Csaba Osztrogonác.
      
      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (RunAndUploadPerfTests.start.getText):
      (RunAndUploadPerfTests.start):
      (RunAndUploadPerfTests):
      (RunAndUploadPerfTests.start.getText2):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95912f4f
    • changseok.oh@collabora.com's avatar
      Unreviewed build fix. · aed42078
      changseok.oh@collabora.com authored
      * GNUmakefile.list.am: Duplicated NetscapePluginModuleNone.cpp & NetscapePluginNone.cpp.
      They cause build breaks of multiple definitions when targeting wayland build.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      aed42078
    • paroga@webkit.org's avatar
      [CMake] Split out generic Windows files into its own file · 0fff901b
      paroga@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=119514
      
      Reviewed by Gyuyoung Kim.
      
      This allows us to add smaller CMakeLists.txt files when
      adding additional Windows ports.
      
      .:
      
      * Source/cmake/OptionsWinCE.cmake:
      * Source/cmake/WebKitMacros.cmake:
      
      Source/WebCore:
      
      * PlatformWin.cmake: Copied from Source/WebCore/PlatformWinCE.cmake.
      * PlatformWinCE.cmake:
      
      Source/WTF:
      
      * wtf/PlatformWin.cmake: Renamed from Source/WTF/wtf/PlatformWinCE.cmake.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0fff901b
    • mario@webkit.org's avatar
      [GTK] Get rid of Pango/Gail dependencies in accessibility for ATK · a840a43b
      mario@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=114867
      
      Reviewed by Martin Robinson.
      
      Removed all trace of Gail and Pango specific code from the AtkText
      implementation, now everything has been reimplemented.
      
      * accessibility/atk/WebKitAccessibleInterfaceText.cpp:
      (webkitAccessibleTextGetTextForOffset): Removed fallback code
      relying in Gail/Pango, now all the related code has been
      removed. Also, replaced the collection of if statements with a
      switch, for better readability of the code.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155520 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a840a43b
    • allan.jensen@digia.com's avatar
      Mouseenter/-leave not triggered when element under cursor is moved/removed · f297334e
      allan.jensen@digia.com authored
      https://bugs.webkit.org/show_bug.cgi?id=120786
      
      Reviewed by Antonio Gomes.
      
      Source/WebCore:
      
      When a hovered element is detached it will now emit a fake mousemove event
      similar to what happens when a hovered element has CSS display set to none.
      
      Test: fast/events/mouseenterleave-detached-element.html
      
      * dom/Document.cpp:
      (WebCore::Document::hoveredElementDidDetach):
      * page/EventHandler.cpp:
      (WebCore::EventHandler::EventHandler):
      (WebCore::EventHandler::clear):
      (WebCore::EventHandler::handleMouseMoveEvent):
      * page/EventHandler.h:
      
      LayoutTests:
      
      Test of mouseenter/mouseleave events when a hovered element is removed.
      
      * fast/events/mouseenterleave-detached-element-expected.txt: Added.
      * fast/events/mouseenterleave-detached-element.html: Added.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155519 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f297334e
    • commit-queue@webkit.org's avatar
      [ATK] Adds mapping MenuItemRadioRole to ATK · 413f75b1
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=121149
      
      Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-11
      Reviewed by Mario Sanchez Prada.
      
      Source/WebCore:
      
      Adds mapping MenuItemRadioRole to ATK.
      
      * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
      (atkRole):
      
      Tools:
      
      Adds mapping MenuItemRadioRole to ATK.
      
      * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
      (roleToString):
      * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
      (WTR::roleToString):
      
      LayoutTests:
      
      Corrected expectations so that they can properly test MenuItemRadioRole.
      
      * platform/efl/accessibility/aria-menubar-menuitems-expected.txt:
      * platform/gtk/accessibility/aria-menubar-menuitems-expected.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155518 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      413f75b1