1. 27 Feb, 2006 40 commits
    • mjs's avatar
      Reviewed by Darin. · b114cebb
      mjs authored
              - write a portable ICU version of TextEncoding::fromUnicode for use on win32
      
              * platform/StreamingTextDecoder.h:
              * platform/TextEncoding.cpp:
              (WebCore::TextEncoding::fromUnicode): added
              (WebCore::getConverter): helper
              (WebCore::cacheConverter): ditto
              (WebCore::effectiveEncoding): ditto
              * platform/mac/TextEncodingMac.cpp: Add comment
              * platform/win/TemporaryLinkStubs.cpp:
              (WebCore::TextEncoding::fromUnicode): remove
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b114cebb
    • darin's avatar
      LayoutTests: · d4028cf1
      darin authored
              Reviewed by Darin.
      
              - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7433
                REGRESSION (r12789): Second RTL text run on a line cannot be selected
      
              * fast/text/in-rendered-text-rtl-expected.checksum: Added.
              * fast/text/in-rendered-text-rtl-expected.png: Added.
              * fast/text/in-rendered-text-rtl-expected.txt: Added.
              * fast/text/in-rendered-text-rtl.html: Added.
      
      WebCore:
      
              Test: fast/text/in-rendered-text-rtl.html
      
              Reviewed by Darin.
      
              - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7433
                REGRESSION (r12789): Second RTL text run on a line cannot be selected
      
              * dom/dom_position.cpp:
              (WebCore::Position::inRenderedText): If the RenderText contains
              reversed text, the text boxes are not necessarily ordered by start
              position, so iterate through all of them.
              (WebCore::Position::isRenderedCharacter): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13045 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d4028cf1
    • darin's avatar
      LayoutTests: · f5bb3016
      darin authored
              Reviewed by Darin.
      
              - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=7321
              REGRESSION: style tag in body causes two head elements to appear in the DOM
      
              The head-check.html document uses an iframe as a laboratory for loading each
              head-check-N.html file and checking its DOM, with inspiration from Ian Hixie's
              Live DOM Viewer: http://software.hixie.ch/utilities/js/live-dom-viewer/
      
              Each of the four head-check-N.html files tests a different code path for
              creating a document's head element in WebCore/khtml/html/htmlparser.cpp.
      
              * editing/inserting/editing-empty-divs-expected.txt: Corrected <html> child
              index for <body> since the document previously had two <head> nodes.
              * fast/dom/HTMLHeadElement: Added.
              * fast/dom/HTMLHeadElement/head-check-expected.txt: Added.
              * fast/dom/HTMLHeadElement/head-check.html: Added.
              * fast/dom/HTMLHeadElement/resources: Added.
              * fast/dom/HTMLHeadElement/resources/head-check-1.html: Added.
              * fast/dom/HTMLHeadElement/resources/head-check-2.html: Added.
              * fast/dom/HTMLHeadElement/resources/head-check-3.html: Added.
              * fast/dom/HTMLHeadElement/resources/head-check-4.html: Added.
              * fast/dom/HTMLHeadElement/resources/head-check.js: Added.
      
      WebCore:
      
              Reviewed by Darin.
      
              - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7321
              REGRESSION: style tag in body causes two head elements to appear in the DOM
      
              * khtml/html/htmlparser.cpp: Handle the head node like form and map nodes.
              (WebCore::HTMLParser::parseToken):
              (WebCore::HTMLParser::headCreateErrorCheck):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f5bb3016
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · 81bb3dc6
      eseidel authored
              Reviewed by darin.
      
              Add stub to make DRT link.
              Make WebCore copy libxml.dll into build directory when building.
      
              * WebCore.vcproj/WebCore/build-generated-files.sh:
              * platform/win/TemporaryLinkStubs.cpp:
              (WebCore::TextEncoding::fromUnicode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13043 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      81bb3dc6
    • darin's avatar
      Reviewed by Eric. · 0956a81b
      darin authored
              - fix regression in layout tests
      
              * dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength):
              Fix some code that was not properly truncating. I broke it in my
              string change this morning. 
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13042 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0956a81b
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · b6a2ed70
      eseidel authored
              Rubber-stamped by darin.
      
              Remove fpconst.cpp, unused on win32 and the cause of linker warnings.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b6a2ed70
    • mjs's avatar
      Rubber stamped by Eric. · 453ea90e
      mjs authored
              - add stubs for FrameWin overrides of pure virtual Frame methods
      
              * platform/win/TemporaryLinkStubs.cpp:
              (WebCore::FrameWin::respondToChangedContents):
              (WebCore::FrameWin::unfocusWindow):
              (WebCore::FrameWin::locationbarVisible):
              (WebCore::FrameWin::respondToChangedSelection):
              (WebCore::FrameWin::clearUndoRedoOperations):
              (WebCore::FrameWin::issueRedoCommand):
              (WebCore::FrameWin::canRedo):
              (WebCore::FrameWin::restoreDocumentState):
              (WebCore::FrameWin::canUndo):
              (WebCore::FrameWin::overrideMediaType):
              (WebCore::FrameWin::saveDocumentState):
              (WebCore::FrameWin::print):
              (WebCore::FrameWin::issueCutCommand):
              (WebCore::FrameWin::issueCopyCommand):
              (WebCore::FrameWin::partClearedInBegin):
              (WebCore::FrameWin::issueUndoCommand):
              (WebCore::FrameWin::clearRecordedFormValues):
              (WebCore::FrameWin::issuePasteCommand):
              (WebCore::FrameWin::markedTextRange):
              (WebCore::FrameWin::shouldChangeSelection):
              (WebCore::FrameWin::scheduleClose):
              (WebCore::FrameWin::menubarVisible):
              (WebCore::FrameWin::personalbarVisible):
              (WebCore::FrameWin::createEmptyDocument):
              (WebCore::FrameWin::lastEventIsMouseUp):
              (WebCore::FrameWin::statusbarVisible):
              (WebCore::FrameWin::toolbarVisible):
              (WebCore::FrameWin::issueTransposeCommand):
              (WebCore::FrameWin::userAgent):
              (WebCore::FrameWin::canPaste):
              (WebCore::FrameWin::incomingReferrer):
              (WebCore::FrameWin::canGoBackOrForward):
              (WebCore::FrameWin::issuePasteAndMatchStyleCommand):
              (WebCore::FrameWin::handledOnloadEvents):
              (WebCore::FrameWin::generateFrameName):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13040 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      453ea90e
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · 3d043b8d
      eseidel authored
              Reviewed by mjs.
      
              Add constructor and destructor. 
      
              * bridge/win/FrameWin.cpp:
              (WebCore::FrameWin::FrameWin):
              (WebCore::FrameWin::~FrameWin):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d043b8d
    • mjs's avatar
      Rubber stamped by Eric (sorta). · a8c585c2
      mjs authored
              - add return values where needed
      
              * platform/win/TemporaryLinkStubs.cpp:
              (KWQServeRequest):
              (KWQServeSynchronousRequest):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a8c585c2
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · fa95296c
      eseidel authored
              Reviewed by mjs.
      
              Fix Assertions.cpp to compile on win32.
      
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
              * kxmlcore/Assertions.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      fa95296c
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · 4bb56f32
      eseidel authored
              Reviewed by mjs.
      
              Add a couple more stubs to make Win32 link.
      
              * platform/win/TemporaryLinkStubs.cpp:
              (KWQServeSynchronousRequest):
              (WebCore::FrameView::topLevelWidget):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4bb56f32
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · 9f33d28e
      eseidel authored
              Reviewed by mjs.
      
              Move mac-specific logging logic up into WebCore (from JavaScriptCore).
              Remove KWQ prefixes from default log channels.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7503
      
              * bridge/mac/WebCorePageBridge.mm:
              (initializeLogChannel):
              (initializeLoggingChannelsIfNecessary):
              (-[WebCorePageBridge init]):
              * page/Frame.h:
              * platform/Logging.cpp:
              * platform/Logging.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9f33d28e
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · 9259f147
      eseidel authored
              Reviewed by mjs.
      
              Made Assertions.cpp platform independent.
              Moved mac-specific logging logic up into WebCore.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7503
      
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * kxmlcore/Assertions.cpp: Added.
              * kxmlcore/Assertions.h:
              * kxmlcore/Assertions.mm: Removed.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9259f147
    • darin's avatar
      Reviewed by Maciej. · 02f49673
      darin authored
              - fix <rdar://problem/4104575> hang due to slow saveDocumentState method
      
              * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge saveDocumentState]):
              Change code that iterates a QStringList with indices to use iterator instead.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02f49673
    • mjs's avatar
      Reviewed by Eric. · 2a36f0ca
      mjs authored
              - portable version of QString::utf8
      
              * platform/QString.cpp:
              (QString::utf8): moved here, rewritten to use TextCodec
              * platform/mac/QStringMac.mm:
              (QString::utf8): removed from here
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2a36f0ca
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · 2b1ca654
      eseidel authored
              Rubber-stamped by mjs.
      
              Fix FrameWin.h to use consistant line endings.
              Fix TemporaryLinkStubs to better match style guidelines.
      
              * bridge/win/FrameWin.h:
              (WebCore::Win):
              * platform/win/TemporaryLinkStubs.cpp:
              (QLineEdit::selectAll):
              (QPainter::save):
              (Widget::enableFlushDrawing):
              (QPainter::drawHighlightForText):
              (QFont::setPrinterFont):
              (QTextEdit::textWithHardLineBreaks):
              (Widget::mapFromGlobal):
              (QPainter::addClip):
              (QLineEdit::cursorPosition):
              (QPainter::setPen):
              (QPainter::selectedTextBackgroundColor):
              (QPainter::fontMetrics):
              (Widget::show):
              (QFont::setItalic):
              (QSlider::setValue):
              (QLineEdit::addSearchResult):
              (KWQFileButton::click):
              (QLineEdit::setWritingDirection):
              (QPainter::drawFocusRing):
              (KWQFileButton::sizeForCharacterWidth):
              (QTextEdit::sizeWithColumnsAndRows):
              (QComboBox::clear):
              (QPainter::misspellingLineThickness):
              (QComboBox::setFrameGeometry):
              (QLineEdit::maxLength):
              (Widget::isEnabled):
              (KWQServeRequest):
              (QTextEdit::setText):
              (Widget::paint):
              (QPainter::addRoundedRectClip):
              (FrameView::viewportToGlobal):
              (QTextEdit::selectionEnd):
              (QFont::determinePitch):
              (QTextEdit::setScrollBarModes):
              (QPainter::drawEllipse):
              (QTextEdit::setReadOnly):
              (QListBox::appendItem):
              (QLineEdit::setPlaceholderString):
              (Cursor::Cursor):
              (Widget::focusPolicy):
              (ScrollView::removeChild):
              (QTextEdit::selectAll):
              (QPainter::fillRect):
              (QPainter::endTransparencyLayer):
              (QFont::QFont):
              (ScrollView::addChild):
              (QTextEdit::setDisabled):
              (QScrollBar::scroll):
              (Widget::~Widget):
              (QPainter::xForm):
              (QListBox::sizeForNumberOfLines):
              (ScrollView::resizeContents):
              (QLineEdit::selectionStart):
              (QLineEdit::QLineEdit):
              (FrameView::updateBorder):
              (QLineEdit::hasSelectedText):
              (QScrollBar::QScrollBar):
              (QListBox::doneAppendingItems):
              (QTextEdit::QTextEdit):
              (ScrollView::inWindow):
              (QScrollBar::setValue):
              (QFont::setFirstFamily):
              (QTextEdit::hasSelectedText):
              (QTextEdit::selectionStart):
              (QFont::setWeight):
              (ScrollView::scrollXOffset):
              (QListBox::isSelected):
              (QLineEdit::setReadOnly):
              (QPainter::drawLineForText):
              (QPainter::QPainter):
              (QComboBox::~QComboBox):
              (QComboBox::focusPolicy):
              (QPainter::drawImageAtPoint):
              (QPainter::clearShadow):
              (QTextEdit::setLineHeight):
              (QScrollBar::setKnobProportion):
              (KWQFileButton::KWQFileButton):
              (QFontMetrics::boundingRect):
              (QTextEdit::setSelectionStart):
              (QPainter::beginTransparencyLayer):
              (QFontMetrics::setFont):
              (QComboBox::setFont):
              (Widget::frameGeometry):
              (QListBox::setSelected):
              (QPainter::addFocusRingRect):
              (QTextEdit::setCursorPosition):
              (QPainter::restore):
              (QFontMetrics::width):
              (Widget::setEnabled):
              (QTextEdit::setSelectionEnd):
              (QComboBox::populate):
              (ScrollView::setStaticBackground):
              (QPainter::font):
              (QTextEdit::setAlignment):
              (QLineEdit::setCursorPosition):
              (QPainter::drawText):
              (QPainter::pen):
              (KJavaAppletWidget::KJavaAppletWidget):
              (QFontMetrics::descent):
              (QListBox::QListBox):
              (QFontMetrics::ascent):
              (QLineEdit::selectedText):
              (Widget::setIsSelected):
              (QLineEdit::text):
              (Widget::unlockDrawingFocus):
              (QLineEdit::setLiveSearch):
              (QPainter::paintingDisabled):
              (QComboBox::QComboBox):
              (QPainter::drawConvexPolygon):
              (Widget::setFont):
              (QSlider::setMaxValue):
              (Widget::lockDrawingFocus):
              (QPainter::drawLine):
              (QPainter::setBrush):
              (QTextEdit::setSelectionRange):
              (ScrollView::scrollPointRecursively):
              (QLineEdit::sizeForCharacterWidth):
              (Cursor::~Cursor):
              (QFontMetrics::selectionRectForText):
              (ScrollView::suppressScrollBars):
              (QFontMetrics::checkSelectionPoint):
              (QTextEdit::getCursorPosition):
              (FrameView::isFrameView):
              (QScrollBar::setSteps):
              (QLineEdit::setMaxLength):
              (Widget::setCursor):
              (QLineEdit::setAutoSaveName):
              (QComboBox::baselinePosition):
              (QComboBox::appendItem):
              (QPainter::setShadow):
              (QTextEdit::setWritingDirection):
              (Widget::setDrawingAlpha):
              (QSlider::QSlider):
              (ScrollView::setVScrollBarMode):
              (QPainter::drawScaledAndTiledImage):
              (ScrollView::scrollYOffset):
              (QPainter::drawImage):
              (QComboBox::setCurrentItem):
              (QFontMetrics::height):
              (QComboBox::setWritingDirection):
              (ScrollView::setScrollBarsMode):
              (QComboBox::sizeHint):
              (QPainter::drawRect):
              (QFont::setPixelSize):
              (Widget::setFrameGeometry):
              (QLineEdit::setSelection):
              (QLineEdit::setMaxResults):
              (QListBox::clear):
              (QLineEdit::edited):
              (QPainter::drawTiledImage):
              (QPainter::clearFocusRing):
              (QFont::operator==):
              (Widget::Widget):
              (QTextEdit::text):
              (QPainter::drawImageInRect):
              (QPainter::setFont):
              (Widget::disableFlushDrawing):
              (QPainter::initFocusRing):
              (QSlider::setMinValue):
              (QTextEdit::setWordWrap):
              (QPainter::drawLineForMisspelling):
              (QLineEdit::setText):
              (QSlider::value):
              (QListBox::setSelectionMode):
              (KWQFileButton::setFilename):
              (QFontMetrics::QFontMetrics):
              (QFontMetrics::lineSpacing):
              (QLineEdit::setEdited):
              (QComboBox::frameGeometry):
              (QListBox::setWritingDirection):
              (QLineEdit::setAlignment):
              (ScrollView::updateContents):
              (QFontMetrics::floatWidth):
              (ScrollView::setHScrollBarMode):
              (KWQFileButton::focusPolicy):
              (QListBox::setFont):
              (QLineEdit::checksDescendantsForFocus):
              (KWQFileButton::baselinePosition):
              (QSlider::~QSlider):
              (KWQFileButton::setFrameGeometry):
              (QListBox::~QListBox):
              (KWQFileButton::frameGeometry):
              (QTextEdit::setFont):
              (QLineEdit::setFont):
              (KWQFileButton::~KWQFileButton):
              (QTextEdit::focusPolicy):
              (QSlider::focusPolicy):
              (QSlider::setFont):
              (QListBox::setEnabled):
              (QListBox::checksDescendantsForFocus):
              (QListBox::focusPolicy):
              (QLineEdit::baselinePosition):
              (QSlider::sizeHint):
              (QLineEdit::~QLineEdit):
              (QTextEdit::~QTextEdit):
              (QTextEdit::checksDescendantsForFocus):
              (QLineEdit::focusPolicy):
              (QScrollBar::~QScrollBar):
              (Path::operator=):
              (QLineEdit::setColors):
              (QTextEdit::setColors):
              (searchableIndexIntroduction):
              (KWQKCookieJar::setCookie):
              (KWQKCookieJar::cookie):
              (WebCore::screenRect):
              (WebCore::Widget::clearFocus):
              (WebCore::historyContains):
              (KWQFindNextSentenceFromIndex):
              (KWQFindSentenceBoundary):
              (KWQFindNextWordFromIndex):
              (KWQFindWordBoundary):
              (submitButtonDefaultLabel):
              (inputElementAltText):
              (resetButtonDefaultLabel):
              (KWQKCookieJar::cookieEnabled):
              (WebCore::Widget::setFocus):
              (WebCore::QPainter::fillRect):
              (WebCore::QPainter::~QPainter):
              (WebCore::ScrollView::viewportToContents):
              (WebCore::TransferJob::kill):
              (WebCore::TransferJob::addMetaData):
              (WebCore::TransferJob::queryMetaData):
              (WebCore::TransferJob::error):
              (WebCore::TransferJob::errorText):
              (WebCore::TransferJob::isErrorPage):
              (WebCore::TransferJob::TransferJob):
              (WebCore::Widget::hide):
              (KLocale::language):
              (PlugInInfoStore::createPluginInfoForPluginAtIndex):
              (WebCore::screenDepth):
              (QFont::italic):
              (QFontMetrics::operator=):
              (QFontMetrics::xHeight):
              (WebCore::usableScreenRect):
              (QFont::operator=):
              (Widget::setActiveWindow):
              (KWQCheckIfReloading):
              (WebCore::ScrollView::contentsX):
              (WebCore::ScrollView::contentsY):
              (WebCore::ScrollView::contentsHeight):
              (WebCore::ScrollView::contentsWidth):
              (WebCore::ScrollView::visibleHeight):
              (WebCore::ScrollView::visibleWidth):
              (WebCore::ScrollView::hScrollBarMode):
              (WebCore::ScrollView::vScrollBarMode):
              (KWQCheckCacheObjectStatus):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2b1ca654
    • tomernic's avatar
      Reviewed by Adele. · 88e8ec13
      tomernic authored
              <rdar://problem/4222043> Safari should reduce null events sent to invisible plugins
      
              * Plugins/WebBaseNetscapePluginView.h:
              * Plugins/WebBaseNetscapePluginView.m:
              (-[WebBaseNetscapePluginView restartNullEvents]):
              Check to see if the plugin view is completely obscured (scrolled out of view, for example).  If it is
              obscured and it wasn't before, or the other way around, then restart the null event timer so it can
              fire at the appropriate rate.
              (-[WebBaseNetscapePluginView viewHasMoved:]):
              If a plugin is obscured, send it null events as if it were in an inactive window.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      88e8ec13
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · 3de08130
      eseidel authored
              Reviewed by timo.
      
              Fix xcode project after previous KWQLogging move.
      
              * WebCore.xcodeproj/project.pbxproj:
              * platform/Logging.h:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3de08130
    • justing's avatar
      LayoutTests: · 26aeccc0
      justing authored
              Reviewed by darin
              
              Test for:
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
              elementAtPoint returns the list when the point is over a list marker
      
              * fast/events/onclick-list-marker-expected.txt: Added.
              * fast/events/onclick-list-marker.html: Added.
      
      WebCore:
      
              Reviewed by darin
              
              <http://bugzilla.opendarwin.org/show_bug.cgi?id=6844>
              elementAtPoint returns the list when the point is over a list marker
              
              Consider the case of outside list markers in nodeAtPoint.  Had to pull 
              the code out of RenderListMarker::paint that computed the position/size 
              of the list marker.
      
              Added:
              * fast/events/onclick-list-marker.html
      
              * rendering/render_list.cpp:
              (RenderListItem::nodeAtPoint):
              (RenderListItem::getAbsoluteRepaintRect):
              (RenderListMarker::paint):
              (RenderListMarker::nodeAtPoint):
              (RenderListMarker::getRelativeMarkerRect):
              * rendering/render_list.h:
              * rendering/render_object.h:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      26aeccc0
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · 18f16d8b
      eseidel authored
              Reviewed by timo.
      
              Move KWQLogging to platform and rename as Logging.*, fix headers.
              This will break the mac build, which I will fix on my next commit.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * dom/DocumentImpl.cpp:
              * dom/dom_position.cpp:
              * editing/DeleteSelectionCommand.cpp:
              * editing/InsertLineBreakCommand.cpp:
              * editing/InsertParagraphSeparatorCommand.cpp:
              * editing/InsertTextCommand.cpp:
              * editing/VisiblePosition.cpp:
              * editing/markup.cpp:
              * khtml/ecma/kjs_window.cpp:
              * kwq/KWQLogging.h: Removed.
              * kwq/KWQLogging.m: Removed.
              * kwq/KWQRegExp.cpp:
              * kwq/KWQTextStream.cpp:
              * platform/Logging.cpp: Added.
              * platform/Logging.h: Added.
              * platform/QString.cpp:
              * platform/win/TemporaryLinkStubs.cpp:
              (WebCore::ScrollView::vScrollBarMode):
              (WebCore::theme):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      18f16d8b
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · 4927d4b9
      eseidel authored
              Reviewed by hyatt.
      
              Fix a bunch more link errors in the win32 build, mostly by adding stubs.
      
              * WebCore.vcproj/WebCore/WebCore.vcproj: add JSXMLHttpRequest and PlugInInfoStore
              * WebCore.vcproj/WebCore/build-generated-files.sh: update for JSXMLHttpRequest
              * khtml/ecma/JSXMLHttpRequest.cpp:
              (KJS::JSXMLHttpRequest::getValueProperty): fix switch to compile
              * platform/PlugInInfoStore.h:
              * platform/mac/PlugInInfoStoreMac.mm:
              * platform/win/TemporaryLinkStubs.cpp: add a bunch of stubs.
              (WebCore::TransferJob::errorText):
              (WebCore::TransferJob::isErrorPage):
              (WebCore::Widget::hide):
              (PlugInInfoStore::createPluginInfoForPluginAtIndex):
              (PlugInInfoStore::pluginCount):
              (WebCore::refreshPlugins):
              (QFont::QFont):
              (QFont::~QFont):
              (QFont::italic):
              (QFont::weight):
              (QFontMetrics::QFontMetrics):
              (QFontMetrics::~QFontMetrics):
              (QFontMetrics::xHeight):
              (Widget::setActiveWindow):
              (WebCore::ScrollView::contentsX):
              (WebCore::ScrollView::contentsY):
              (WebCore::ScrollView::contentsHeight):
              (WebCore::ScrollView::contentsWidth):
              (WebCore::ScrollView::visibleHeight):
              (WebCore::ScrollView::visibleWidth):
              (WebCore::ScrollView::hScrollBarMode):
              (WebCore::ScrollView::vScrollBarMode):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      4927d4b9
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · de63e678
      eseidel authored
              Reviewed by timo.
      
              Add missing include to fix build.
      
              * platform/win/TemporaryLinkStubs.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de63e678
    • eseidel's avatar
      2006-02-25 Eric Seidel <eseidel@apple.com> · a992df03
      eseidel authored
              Reviewed by ggaren.
              
              Test new PlugInInfoStore class (used to be KConfig).
              
              * plugins/plugin-javascript-access-expected.txt: Added.
              * plugins/plugin-javascript-access.html: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13022 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a992df03
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · d70f5671
      eseidel authored
              Reviewed by ggaren.
      
              Test new KConfig -> PlugInInfoStore change.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7498
      
              * DumpRenderTree/DumpRenderTree.m:
              (main): load test netscape plugin
              * Scripts/run-webkit-tests: style update
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13021 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d70f5671
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · b502dd04
      eseidel authored
              Reviewed by ggaren.
      
              Move KConfig to platform/PlugInInfoStore and add test.
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7498
      
              Test: plugins/plugin-javascript-access.html
      
              * ForwardingHeaders/kconfig.h: Removed.
              * WebCore.xcodeproj/project.pbxproj:
              * khtml/ecma/kjs_navigator.cpp:
              (KJS::PluginBase::PluginBase):
              * khtml/ecma/kjs_window.cpp:
              * kwq/KWQKConfigBase.h: Removed.
              * kwq/KWQKConfigBase.mm: Removed.
              * platform/PlugInInfoStore.h: Added.
              * platform/mac/PlugInInfoStoreMac.mm: Added.
              (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
              (WebCore::PlugInInfoStore::pluginCount):
              (WebCore::refreshPlugins):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13020 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b502dd04
    • darin's avatar
      Reviewed by Eric. · d5f933d8
      darin authored
              * platform/win/TemporaryLinkStubs.cpp: Added more stubs.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13019 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      d5f933d8
    • thatcher's avatar
      Build fix for i386. Workaround for 4213314 · 5eede2f3
      thatcher authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13018 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5eede2f3
    • darin's avatar
      - fixed Mac Debug build, there was an unused parameter · 04c3a118
      darin authored
              * kxmlcore/FastMalloc.cpp: (KXMLCore::fastMallocRegisterThread):
              Remove parameter name.
      
              * kjs/debugger.h: Fixed comment.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13017 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      04c3a118
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · e6be61ae
      eseidel authored
              Reviewed by darin.
      
              * kxmlcore/Vector.h:
              (KXMLCore::deleteAllValues): fix unused variable warning
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13016 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6be61ae
    • mjs's avatar
      Reviewed by Darin. · 05585423
      mjs authored
              
              - Turn off -Wno-unused-param for JavaScriptCore and get rid of unused params
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7384
      
              * JavaScriptCore.xcodeproj/project.pbxproj:
              * bindings/NP_jsobject.cpp:
              (jsAllocate):
              (_NPN_InvokeDefault):
              (_NPN_Evaluate):
              (_NPN_GetProperty):
              (_NPN_SetProperty):
              (_NPN_RemoveProperty):
              (_NPN_HasProperty):
              (_NPN_HasMethod):
              * bindings/c/c_class.h:
              (KJS::Bindings::CClass::constructorAt):
              * bindings/c/c_utility.cpp:
              (KJS::Bindings::convertNPVariantToValue):
              * bindings/jni/jni_class.cpp:
              (JavaClass::methodsNamed):
              (JavaClass::fieldNamed):
              * bindings/jni/jni_instance.cpp:
              (JavaInstance::invokeDefaultMethod):
              * bindings/jni/jni_jsobject.cpp:
              * bindings/jni/jni_objc.mm:
              (-[NSObject KJS::Bindings::]):
              * bindings/objc/WebScriptObject.mm:
              (+[WebUndefined allocWithZone:]):
              (-[WebUndefined initWithCoder:]):
              (-[WebUndefined encodeWithCoder:]):
              (-[WebUndefined copyWithZone:]):
              * bindings/objc/objc_class.h:
              (KJS::Bindings::ObjcClass::constructorAt):
              * bindings/objc/objc_class.mm:
              (KJS::Bindings::ObjcClass::methodsNamed):
              (KJS::Bindings::ObjcClass::fallbackObject):
              * bindings/objc/objc_instance.mm:
              (ObjcInstance::getValueOfUndefinedField):
              * bindings/objc/objc_runtime.mm:
              (ObjcFallbackObjectImp::getOwnPropertySlot):
              (ObjcFallbackObjectImp::put):
              (ObjcFallbackObjectImp::canPut):
              (ObjcFallbackObjectImp::deleteProperty):
              (ObjcFallbackObjectImp::toBoolean):
              * bindings/runtime.cpp:
              (KJS::Bindings::Instance::createLanguageInstanceForValue):
              * bindings/runtime.h:
              (KJS::Bindings::Instance::getValueOfUndefinedField):
              (KJS::Bindings::Instance::setValueOfUndefinedField):
              * bindings/runtime_array.cpp:
              (RuntimeArray::lengthGetter):
              (RuntimeArray::indexGetter):
              (RuntimeArray::put):
              (RuntimeArray::deleteProperty):
              * bindings/runtime_method.cpp:
              (RuntimeMethod::lengthGetter):
              (RuntimeMethod::execute):
              * bindings/runtime_object.cpp:
              (RuntimeObjectImp::fallbackObjectGetter):
              (RuntimeObjectImp::fieldGetter):
              (RuntimeObjectImp::methodGetter):
              (RuntimeObjectImp::put):
              (RuntimeObjectImp::canPut):
              (RuntimeObjectImp::deleteProperty):
              (RuntimeObjectImp::defaultValue):
              (RuntimeObjectImp::callAsFunction):
              * bindings/runtime_root.cpp:
              (performJavaScriptAccess):
              * kjs/array_object.cpp:
              (ArrayInstance::lengthGetter):
              (ArrayInstance::getOwnPropertySlot):
              (ArrayPrototype::ArrayPrototype):
              (ArrayPrototype::getOwnPropertySlot):
              * kjs/bool_object.cpp:
              (BooleanObjectImp::BooleanObjectImp):
              * kjs/date_object.cpp:
              (KJS::DateObjectFuncImp::DateObjectFuncImp):
              (KJS::DateObjectFuncImp::callAsFunction):
              * kjs/error_object.cpp:
              (ErrorObjectImp::ErrorObjectImp):
              (NativeErrorPrototype::NativeErrorPrototype):
              (NativeErrorImp::NativeErrorImp):
              * kjs/function.cpp:
              (KJS::FunctionImp::argumentsGetter):
              (KJS::FunctionImp::lengthGetter):
              (KJS::Arguments::mappedIndexGetter):
              (KJS::ActivationImp::argumentsGetter):
              (KJS::ActivationImp::put):
              * kjs/function_object.cpp:
              (FunctionObjectImp::FunctionObjectImp):
              * kjs/internal.cpp:
              (KJS::GetterSetterImp::toPrimitive):
              (KJS::GetterSetterImp::toBoolean):
              * kjs/interpreter.cpp:
              (KJS::Interpreter::evaluate):
              * kjs/interpreter.h:
              (KJS::Interpreter::isGlobalObject):
              (KJS::Interpreter::interpreterForGlobalObject):
              (KJS::Interpreter::isSafeScript):
              * kjs/lexer.cpp:
              (Lexer::makeIdentifier):
              (Lexer::makeUString):
              * kjs/lookup.h:
              (KJS::staticFunctionGetter):
              (KJS::staticValueGetter):
              * kjs/nodes.cpp:
              (StatementNode::processFuncDecl):
              (PropertyNode::evaluate):
              (PropertyNameNode::evaluate):
              * kjs/number_object.cpp:
              (NumberObjectImp::NumberObjectImp):
              (NumberObjectImp::getOwnPropertySlot):
              * kjs/object.cpp:
              (KJS::JSObject::defineGetter):
              (KJS::JSObject::defineSetter):
              (KJS::JSObject::hasInstance):
              (KJS::JSObject::propertyIsEnumerable):
              * kjs/object_object.cpp:
              (ObjectObjectImp::ObjectObjectImp):
              * kjs/property_slot.cpp:
              (KJS::PropertySlot::undefinedGetter):
              (KJS::PropertySlot::functionGetter):
              * kjs/reference.cpp:
              (KJS::Reference::getPropertyName):
              * kjs/reference_list.cpp:
              (ReferenceListIterator::operator++):
              * kjs/regexp_object.cpp:
              (RegExpObjectImp::RegExpObjectImp):
              (RegExpObjectImp::getValueProperty):
              (RegExpObjectImp::putValueProperty):
              * kjs/string_object.cpp:
              (StringInstance::lengthGetter):
              (StringInstance::indexGetter):
              (StringPrototype::StringPrototype):
              * kxmlcore/Assertions.mm:
              * kxmlcore/FastMalloc.cpp:
              (KXMLCore::TCMalloc_PageHeap::CheckList):
              * kxmlcore/HashTable.h:
              (KXMLCore::HashTableConstIterator::checkValidity):
              (KXMLCore::IdentityHashTranslator::translate):
              * pcre/pcre_get.c:
              (pcre_get_stringnumber):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      05585423
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · 7991caa2
      eseidel authored
              Reviewed by darin.
      
              Reworked KConfig and plugin architecture to be much more sane.
              This is part one.  Once this lands, I'll move it under platform with a better name.
      
              Darin had several great suggested further improvements as part of:
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7451
              I'll make some of those when I move this to platform.
      
              No layout test possible (no way to control which plugins DRT sees).
      
              * khtml/ecma/kjs_navigator.cpp:
              (KJS::PluginBase::PluginBase):
              (KJS::PluginBase::~PluginBase):
              (KJS::PluginBase::refresh):
              (KJS::Plugins::getValueProperty):
              (KJS::Plugins::nameGetter):
              (KJS::Plugins::getOwnPropertySlot):
              (KJS::MimeTypes::getValueProperty):
              (KJS::MimeTypes::nameGetter):
              (KJS::MimeTypes::getOwnPropertySlot):
              (KJS::Plugin::getValueProperty):
              (KJS::Plugin::nameGetter):
              (KJS::Plugin::getOwnPropertySlot):
              * khtml/ecma/kjs_navigator.h:
              * khtml/ecma/kjs_window.cpp:
              * kwq/KWQKConfigBase.h:
              (WebCore::PluginInfoStore::PluginInfoStore):
              * kwq/KWQKConfigBase.mm:
              (WebCore::PluginInfoStore::createPluginInfoForPluginAtIndex):
              (WebCore::PluginInfoStore::pluginCount):
              (WebCore::refreshPlugins):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13014 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7991caa2
    • eseidel's avatar
      2006-02-27 Eric Seidel <eseidel@apple.com> · 070491d1
      eseidel authored
              Reviewed by darin.
      
              Build fix: cast to unsigned from size_t.
      
              * platform/StreamingTextDecoder.cpp:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13013 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      070491d1
    • mjs's avatar
      Reviewed by Darin. · 8aa39fce
      mjs authored
              - add Selection.cpp to win32 build
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7490
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13012 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      8aa39fce
    • mjs's avatar
      - use proper header for std::min. · 0266ac14
      mjs authored
              * platform/StreamingTextDecoder.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13011 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0266ac14
    • mjs's avatar
      Reviewed by Darin. · 0908026c
      mjs authored
              - add new TextEncoding stuff to win32 build
              http://bugzilla.opendarwin.org/show_bug.cgi?id=7491
      
              * WebCore.vcproj/WebCore/WebCore.vcproj:
              * WebCore.vcproj/WebCore/build-generated-files.sh:
              * platform/StreamingTextDecoder.cpp:
              (WebCore::StreamingTextDecoder::convertUTF16):
              * platform/TextEncoding.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13010 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0908026c
    • darin's avatar
      - try to fix Windows build · cfdf6823
      darin authored
              * WebCore.vcproj/WebCore/WebCore.vcproj: Removed rendering/font.* and added platform/Font.*.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13009 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cfdf6823
    • darin's avatar
      * css/csshelper.cpp: (WebCore::parseURL): Actually, the second version was fine. Rolling · de7df06f
      darin authored
              back to that; apologies for the churn.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13008 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      de7df06f
    • darin's avatar
      * css/csshelper.cpp: (WebCore::parseURL): Third time's the charm. · 520b1f17
      darin authored
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13007 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      520b1f17
    • darin's avatar
    • darin's avatar
      Reviewed by Maciej. · 9907729d
      darin authored
              - http://bugzilla.opendarwin.org/show_bug.cgi?id=7486
                a first step in improving String/StringImpl API -- use "s" and "l" less
      
              * css/csshelper.cpp: (WebCore::parseURL): Use a local buffer rather than
              manipulating the characters directly inside a StringImpl buffer.
      
              * css/cssstyleselector.cpp: (WebCore::parseUASheet): Copy the data to parse
              it rather than going out of our way to hack StringImpl to not copy the data.
              It would be better not to copy, but this is one-time work.
      
              * dom/DOMImplementationImpl.cpp: (WebCore::DOMImplementationImpl::createDocument):
              * dom/dom2_viewsimpl.cpp: (DOM::AbstractViewImpl::getMatchedCSSRules):
              * dom/dom_elementimpl.cpp: (WebCore::StyledElementImpl::addCSSLength):
              * dom/dom_xmlimpl.cpp: (WebCore::EntityImpl::toString):
              * editing/CompositeEditCommand.cpp: (WebCore::CompositeEditCommand::deleteInsignificantText):
              * khtml/html/htmlparser.cpp: (WebCore::HTMLParser::handleError):
              * platform/AtomicString.cpp:
              (WebCore::CStringTranslator::equal):
              (WebCore::QCharBufferTranslator::equal):
              (WebCore::AtomicString::add):
              * platform/StringImpl.h:
              (WebCore::StringImpl::unicode): Added.
              (KXMLCore::CaseInsensitiveHash::hash): 
              (KXMLCore::CaseInsensitiveHash::equal):
              * rendering/InlineTextBox.cpp: (khtml::InlineTextBox::selectionStartEnd):
              * rendering/RenderBlock.cpp: (WebCore::RenderBlock::updateFirstLetter):
              * rendering/RenderText.cpp:
              (WebCore::getCharacterBreakIterator):
              (WebCore::RenderText::RenderText):
              (WebCore::RenderText::atLineWrap):
              (WebCore::RenderText::allAscii):
              (WebCore::RenderText::widthFromCache):
              (WebCore::RenderText::trimmedMinMaxWidth):
              (WebCore::RenderText::containsOnlyWhitespace):
              (WebCore::RenderText::setSelectionState):
              (WebCore::RenderText::setTextWithOffset):
              (WebCore::RenderText::setText):
              (WebCore::RenderText::width):
              (WebCore::RenderText::selectionRect):
              (WebCore::RenderText::caretMaxOffset):
              * rendering/RenderTextFragment.cpp:
              (khtml::RenderTextFragment::RenderTextFragment):
              (khtml::RenderTextFragment::originalString):
              Use length() instead of l, unicode() instead of s, and (*x)[] instead of x->s[].
      
              * editing/visible_units.cpp:
              (WebCore::startOfParagraph): Use const.
              (WebCore::endOfParagraph): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@13005 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9907729d