https://bugs.webkit.org/show_bug.cgi?id=95747

PR199729

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-09-04
Reviewed by Rob Buis.
Internally Reviewed by Joe Mason.

If the browser has never saved a secure protocol cookie in its mapping before,
and it tries to set and retreive a secure cookie over a non-secure
protocol, it will not show up because the link between the secure and
non-secure mapping isn't created until a cookie (sent through secure) is set.

The fix is to also check for the linkage in getRawCookies. Note that we cannot
map the secure CookieMap to the non-secure one because getRawCookies is a const
function.

Manually tested using our Browser Test suite.

* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getRawCookies):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95751

Reviewed by Martin Robinson.

In gstreamer commit f712a9596c2bc1863edf9b816d9854eefca9ba45
gst_message_new_duration was renamed to
gst_message_new_duration_changed.

However the only place where we used this is in the HTTP source
element and only if appsrc < 0.10.27 is used at runtime. In the
case of GStreamer 1.0 this condition will be always false so we
can disable this code at build time.

* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::didReceiveResponse):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=93443

Patch by Andrei Poenaru <poenaru@adobe.com> on 2012-09-04
Reviewed by Pavel Feldman.

Source/WebCore:

Added "regionLayoutUpdate" event to the protocol.

Removed "getFlowByName" from protocol.

The front-end keeps in sync the requested Named Flow Collections.

Modified existing test: inspector/styles/protocol-css-regions-commands.html

* dom/NamedFlowCollection.cpp:
(WebCore::NamedFlowCollection::ensureFlowWithName):
(WebCore::NamedFlowCollection::discardNamedFlow):
* inspector/Inspector.json:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::didCreateNamedFlow):
(WebCore::InspectorCSSAgent::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorCSSAgent::didUpdateRegionLayout):
(WebCore::InspectorCSSAgent::getNamedFlowCollection):
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl):
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl):
(WebCore::InspectorInstrumentation::didUpdateRegionLayoutImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateNamedFlow):
(WebCore::InspectorInstrumentation::willRemoveNamedFlow):
(WebCore):
(WebCore::InspectorInstrumentation::didUpdateRegionLayout):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync.callback):
(WebInspector.CSSStyleModel.prototype.getNamedFlowCollectionAsync):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync.callback):
(WebInspector.CSSStyleModel.prototype.getFlowByNameAsync):
(WebInspector.CSSStyleModel.prototype._namedFlowCreated):
(WebInspector.CSSStyleModel.prototype._namedFlowRemoved):
(WebInspector.CSSStyleModel.prototype._regionLayoutUpdated):
(WebInspector.CSSStyleModel.prototype._resetNamedFlowCollections):
(WebInspector.CSSDispatcher.prototype.namedFlowCreated):
(WebInspector.CSSDispatcher.prototype.namedFlowRemoved):
(WebInspector.CSSDispatcher.prototype.regionLayoutUpdated):
(WebInspector.NamedFlow):
(WebInspector.NamedFlowCollection):
(WebInspector.NamedFlowCollection.prototype.appendNamedFlow):
(WebInspector.NamedFlowCollection.prototype.removeNamedFlow):
(WebInspector.NamedFlowCollection.prototype.flowByName):
* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::dispatchRegionLayoutUpdateEvent):

LayoutTests:

Validate "regionLayoutUpdate" event.

* inspector/styles/protocol-css-regions-commands-expected.txt:
* inspector/styles/protocol-css-regions-commands.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95730

Patch by Jonathan Liu <net147@gmail.com> on 2012-09-04
Reviewed by Csaba Osztrogonác.

IDL dependency generation is still not working after
https://bugs.webkit.org/show_bug.cgi?id=88304. This is because spaces
added after the filename in an echo command end up being added to the
file which isn't handled correctly by preprocess-idls.pl. The problem
is fixed by removing the space after the filename.

* DerivedSources.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95618

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-09-04
Reviewed by Martin Robinson.

Source/WebCore:

Make sure we only emit the the signal for menu lists and list
boxes rendered from actual HTML select elements.

* accessibility/gtk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange): We support accessibility
ListBoxes and MenuLists only here, assuming they represent HTML
select elements, which might be not always true (e.g. ARIA). Thus,
check if that condition is true, early returning in other case.

LayoutTests:

New layout test to ensure we don't crash with ATK notifications
anymore when changing the selection in an ARIA listbox.

* platform/gtk/accessibility/aria-listbox-crash-expected.txt: Added.
* platform/gtk/accessibility/aria-listbox-crash.html: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95713

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-09-04
Reviewed by Noam Rosenthal.

Fix an assertion failure by returning a valid context always for GraphicsContext3D::platformContext.
This is important because TextureMapperGL uses the platform context to perform hashing.

No new tests. This is covered by existing accelerated compositing tests.

* platform/graphics/cairo/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::platformContext): Return the current GLContext
when getting the platform context for private GraphicsContext3DPrivates that render
to the currently active context.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=86961

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Add ecore_x initialisation check before calling ecore_x_bell
to avoid crashes when X server is not running.

* platform/efl/SoundEfl.cpp:
(WebCore::systemBeep):

LayoutTests:

Unskipped two layout tests that were crashing.

* platform/efl/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95680

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-09-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

In WK2, WebProcess doesn't have access to ewk_view evas object.
Methods that get screen rect or screen depth either return incorrect value or crash.
This patch removes dependency to ewk_view evas object and relies on ecore_x_* functions
to get screen rectangle or color depth of the screen.

* platform/efl/EflScreenUtilities.cpp: removed unused getPixelDepth method definition
* platform/efl/EflScreenUtilities.h: removed unsused getPixelDepth method declaration
(WebCore):
* platform/efl/PlatformScreenEfl.cpp:
(WebCore):
(WebCore::screenHorizontalDPI):
(WebCore::screenVerticalDPI):
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):
(WebCore::screenIsMonochrome):
(WebCore::screenRect):

LayoutTests:

Unskipped passing CSS3 Media Query tests.

* platform/efl-wk2/TestExpectations:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

* Source/cmake/OptionsEfl.cmake: Turn on CONTEXT_MENUS flag for EFL port

Source/WebCore: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

* PlatformEfl.cmake: Removed -DWTF_USE_CROSS_PLATFORM_CONTEXT_MENUS=1

Source/WebKit: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

* PlatformEfl.cmake: Added ContextMenuClientEfl.cpp file to sources list.

Source/WebKit/efl: [EFL] Context menu restore.
https://bugs.webkit.org/show_bug.cgi?id=74179

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-09-04
Reviewed by Gyuyoung Kim.

Adds context menu support for EFL port using non-CROSS_PLATFORM_CONTEXT_MENUS
approach, the same as used in WebKit2.

* WebCoreSupport/ContextMenuClientEfl.cpp: Added.
(WebCore):
(WebCore::ContextMenuClientEfl::contextMenuDestroyed):
(WebCore::ContextMenuClientEfl::getCustomMenuFromDefaultItems):
(WebCore::ContextMenuClientEfl::contextMenuItemSelected):
(WebCore::ContextMenuClientEfl::downloadURL):
(WebCore::ContextMenuClientEfl::lookUpInDictionary):
(WebCore::ContextMenuClientEfl::speak):
(WebCore::ContextMenuClientEfl::isSpeaking):
(WebCore::ContextMenuClientEfl::stopSpeaking):
(WebCore::ContextMenuClientEfl::searchWithGoogle):
* WebCoreSupport/ContextMenuClientEfl.h: Added.
(WebCore):
(ContextMenuClientEfl):
* ewk/ewk_contextmenu.cpp: Removed ewk_context_menu_customize implementation.
(ewk_context_menu_destroy): Added freeing context menu.
(ewk_context_menu_new): Added filling ewk_contextmenu list.
(ewk_context_menu_item_append):
* ewk/ewk_contextmenu_private.h: Removed ewk_context_menu_customize and changed ewk_context_menu_new definition.
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(_ewk_view_priv_del):
(ewk_view_context_menu_forward_event):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95687

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.

gl.bindTexture accepts either TEXTURE_2D or TEXTURE_CUBE_MAP targets, but we tried to replay with TEXTURE_CUBE_MAP_POSITIVE_X and others for 3D textures.

* inspector/InjectedScriptWebGLModuleSource.js:
(.):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95204

.:

Reviewed by Antonio Gomes.

Update exported symbols.

* Source/autotools/symbols.filter:

Source/WebCore:

Reviewed by Antonio Gomes.

Refactors how EventHandler::hitTestResultAtPoint handles child-frame content,
it is now handled by the hit test itself controlled by the AllowChildFrameContent
flag in HitTestRequest.

Tests: fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html
       touchadjustment/iframe-boundary.html

* WebCore.exp.in:
* WebCore.order:
* dom/Document.cpp:
(WebCore::Document::nodesFromRect):
* dom/Document.h:
(Document):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* rendering/HitTestRequest.h:
(WebCore::HitTestRequest::allowChildFrameContent):
(WebCore::HitTestRequest::childFrameHitTest):
(WebCore::HitTestRequest::testChildFrameScrollBars):
* rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::nodeAtPoint):
(WebCore):
* rendering/RenderFrameBase.h:
(RenderFrameBase):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTest):
* testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit2:

Reviewed by Antonio Gomes.

Update symbols for the Windows build-system.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Reviewed by Antonio Gomes.
Touch-Adjustment test by Kevin Ellis

Two new tests for hit-testing child frame content. One for testing it as an option to
nodesFromRect, and one testing its improvement on touch adjustment on iframe boundaries.

* fast/dom/nodesFromRect/nodesFromRect-child-frame-content-expected.txt: Added.
* fast/dom/nodesFromRect/nodesFromRect-child-frame-content.html: Added.
* fast/dom/nodesFromRect/resources/child-frame.html: Added.
* fast/dom/nodesFromRect/resources/nodesFromRect.js:
(check):
(checkShadowContent):
(checkRect):
(nodesFromRectAsString):
* touchadjustment/iframe-boundary-expected.txt: Added.
* touchadjustment/iframe-boundary.html: Added.
* touchadjustment/resources/inner-content-page.html: Added.
* touchadjustment/resources/inner-navigation-frame.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95724

Unreviewed EFL build fix.

Make sure <sys/socket.h> is included before
<linux/netlink.h> to fix build errors on some
systems (e.g. Ubuntu 11.10).

No new tests, no behavior change.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-09-04

* platform/network/efl/NetworkStateNotifierEfl.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95352

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.

Tests: inspector/debugger/network-uisourcecode-provider.html
       inspector/debugger/resource-script-mapping.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerDispatcher.prototype.scriptFailedToParse):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
* inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):
* inspector/front-end/RawSourceCode.js:
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/Workspace.js: Drive-by: fixed duplicating uiSourceCodes in workspace.
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.

* http/tests/inspector/network/network-request-revision-content.html:
* http/tests/inspector/workspace-test.js: Added.
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/dynamic-script-tag-expected.txt:
* inspector/debugger/dynamic-script-tag.html:
* inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
* inspector/debugger/network-uisourcecode-provider.html: Added.
* inspector/debugger/raw-source-code-expected.txt: Removed.
* inspector/debugger/raw-source-code.html: Removed.
* inspector/debugger/resource-script-mapping-expected.txt: Added.
* inspector/debugger/resource-script-mapping.html: Added.
* inspector/debugger/scripts-panel.html:
* inspector/debugger/source-frame-count.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Web Inspector: [WebGL] Save gl.getError() status before taking a WebGL state snapshot and restore it afterwards
https://bugs.webkit.org/show_bug.cgi?id=95443

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-04
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Save gl.getError() status before taking the GL snapshot and restore it afterwards.

* inspector/InjectedScriptWebGLModuleSource.js:
(.):

LayoutTests:

Adds a test to check that we properly save the WebGL getError() status while doing the instrumentation.

* inspector/profiler/webgl/webgl-profiler-get-error-expected.txt: Added.
* inspector/profiler/webgl/webgl-profiler-get-error.html: Added.
* inspector/profiler/webgl/webgl-profiler-test.js: Added.
(initialize_WebGLProfilerTest.InspectorTest.enableWebGLAgent):
(initialize_WebGLProfilerTest):
(createWebGLContext):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95696

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Entities for text directionality-related characters added (LRE, RLE, LRO, RLO, PDF).

* inspector/front-end/ElementsTreeOutline.js:

LayoutTests:

* inspector/elements/elements-panel-structure-expected.txt:
* inspector/elements/elements-panel-structure.html:


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95686

Reviewed by Vsevolod Vlasov.

* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::restore): set m_headersRequested flags
to true and clear all profiles on the front-end since there are no
collected profiles yet immediately after render process sitching.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95716

Also m_memoryInstrumentation became a reference to external object because it has other life time than domNodeVisitor.

Reviewed by Yury Semikhatsky.

* inspector/InspectorMemoryAgent.cpp:
(WebCore):
(WebCore::collectDomTreeInfo):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=94702

Reviewed by Kenneth Rohde Christiansen.

Based on patch by Noam Rosenthal.

The conversion uses a simple JSClassRef based binding and only a few
uses of private JSC API for the HTML element DOM bindings remain.

This is essentially used for wrapping QPixmap and QImage types in
JavaScript and the other way around, for retrieving the image data
out of a HTML image element when converting from JS/DOM to Qt.

* bridge/qt/qt_pixmapruntime.cpp:
(JSC::Bindings::copyPixels):
(JSC::Bindings::toPixmap):
(JSC::Bindings::toImage):
(JSC::Bindings::imageSizeForVariant):
(JSC::Bindings::getPixmapWidth):
(JSC::Bindings::getPixmapHeight):
(JSC::Bindings::assignToHTMLImageElement):
(JSC::Bindings::pixmapToImageData):
(JSC::Bindings::pixmapToDataUrl):
(JSC::Bindings::pixmapToString):
(JSC::Bindings::QtPixmapRuntime::toJS):
(JSC::Bindings::QtPixmapRuntime::toQt):
(JSC::Bindings::QtPixmapRuntime::canHandle):
(JSC::Bindings::QtPixmapRuntime::getClassRef):
* bridge/qt/qt_pixmapruntime.h:
(QtPixmapRuntime):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

<http://webkit.org/b/94990>

Reviewed by Antti Koivisto.

Keep a cache of ElementAttributeData objects for a given set of attributes and reuse
them in elements with identical attribute maps. ElementAttributeData is made ref-counted
to facilitate this. A copy-on-write mechanism is already in place, since mutating call
sites have to go via Element::mutableAttributeData().

The cache is held by Document and cleared in Document::finishedParsing() since the vast
majority of immutable ElementAttributeData will be constructed during parsing.

On the HTML5 spec at <http://whatwg.org/c/>, we get a cache hit rate of nearly 80%,
translating into a 3.5MB reduction in memory use.

* dom/Document.cpp:
(WebCore::Document::finishedParsing):
(ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::ImmutableAttributeDataCacheKey):
(WebCore::ImmutableAttributeDataCacheKey::operator!=):
(WebCore::ImmutableAttributeDataCacheKey::hash):
(ImmutableAttributeDataCacheEntry):
(WebCore::Document::cachedImmutableAttributeData):
* dom/Document.h:
* dom/Element.cpp:
(WebCore::Element::parserSetAttributes):
* dom/Element.h:
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::createImmutable):
(WebCore::ElementAttributeData::ElementAttributeData):
* dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::create):
(ElementAttributeData):
(WebCore::ElementAttributeData::makeMutable):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95334

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-09-03
Reviewed by Pavel Feldman.

In "_openInspectorWindow", before "&dedicatedWorkerId=" should have a '?' to make the whole URL valid.

No new tests case for this bug.

* inspector/front-end/WorkerManager.js:
(WebInspector.WorkerManager.prototype._openInspectorWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95636

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-09-03
Reviewed by Gyuyoung Kim.

Source/WebCore:

Check if the m_timer is active in stopUpdating()
to know the BatteryProvider is updating or not.
By checking the timer, stopUpdating() will be called
only BatteryProviderEfl is updating.

* platform/efl/BatteryProviderEfl.cpp:
(WebCore::BatteryProviderEfl::stopUpdating):

Source/WebKit/efl:

Invoke stopUpdating() in the destructor of BatteryClinetEfl()
to call e_ukit_shutdown() and e_dbus_shutdown() if and when
stopUpdating() has not been called explicitly.

* WebCoreSupport/BatteryClientEfl.cpp:
(BatteryClientEfl::~BatteryClientEfl):
* WebCoreSupport/BatteryClientEfl.h:
(BatteryClientEfl):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

http://trac.webkit.org/changeset/127427
https://bugs.webkit.org/show_bug.cgi?id=95695

Breaks some inspector/debugger tests on JSC (Requested by
vsevik on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-09-03

Source/WebCore:

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js:
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
* inspector/front-end/NetworkUISourceCodeProvider.js: Removed.
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.prototype._createUISourceCode):
(WebInspector.RawSourceCode.prototype.uiLocationToRawLocation):
(WebInspector.RawSourceCode.prototype.uiSourceCode):
(WebInspector.RawSourceCode.prototype._finishedLoading):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._shouldBindScriptToContentProvider):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
(WebInspector.ResourceScriptMapping.prototype._bindScriptToRawSourceCode):
(WebInspector.ResourceScriptMapping.prototype._reset):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):
* inspector/front-end/StylesUISourceCodeProvider.js: Added.
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype._populate):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype._reset):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

* http/tests/inspector/network/network-request-revision-content.html:
* http/tests/inspector/workspace-test.js: Removed.
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/dynamic-script-tag-expected.txt:
* inspector/debugger/dynamic-script-tag.html:
* inspector/debugger/network-uisourcecode-provider-expected.txt: Removed.
* inspector/debugger/network-uisourcecode-provider.html: Removed.
* inspector/debugger/raw-source-code-expected.txt: Added.
* inspector/debugger/raw-source-code.html: Added.
* inspector/debugger/resource-script-mapping-expected.txt: Removed.
* inspector/debugger/resource-script-mapping.html: Removed.
* inspector/debugger/scripts-panel.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95352

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced NetworkUISourceCodeProvider that is listening for ResourceTreeModel and creates UISourceCodes for them.
RawSourceCode does not create uiSourceCodes based on resource anymore (this is done by NetworkUISourceCodeProvider instead).
Moved script <-> uiSourceCode binding logic from RawSourceCode to ResourceScriptMapping.
Removed rawSourceCode as it was not needed anymore.

Tests: inspector/debugger/network-uisourcecode-provider.html
       inspector/debugger/resource-script-mapping.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js:
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
* inspector/front-end/NetworkUISourceCodeProvider.js: Renamed from Source/WebCore/inspector/front-end/StylesUISourceCodeProvider.js.
(WebInspector.NetworkUISourceCodeProvider):
(WebInspector.NetworkUISourceCodeProvider.prototype._populate):
(WebInspector.NetworkUISourceCodeProvider.prototype._styleResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded.resourceFinished):
(WebInspector.NetworkUISourceCodeProvider.prototype._scriptResourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._addJavaScriptSource):
(WebInspector.NetworkUISourceCodeProvider.prototype._addUISourceCode):
(WebInspector.NetworkUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.NetworkUISourceCodeProvider.prototype._reset):
* inspector/front-end/RawSourceCode.js:
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ResourceScriptMapping.prototype._scriptsForSourceURL):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode.get var):
(WebInspector.ResourceScriptMapping.prototype._addOrReplaceTemporaryUISourceCode):
(WebInspector.ResourceScriptMapping.prototype.get _uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._reset):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.SnippetJavaScriptSource):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uiLocationToRawLocation):
(WebInspector.UISourceCode.prototype.setSourceMapping):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

Removed raw-source-code.html test as RawSourceCode was removed by this patch.
Added resource-script-mapping.html to test script <-> uiSourceCode binding behavior.
Added network-uisourcecode-provider.html to test uiSourceCode creation behavior.
Updated dynamic-script-tag.html to better match expected behavior.

* http/tests/inspector/network/network-request-revision-content.html:
* http/tests/inspector/workspace-test.js: Added.
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent.uiSourceCodeReplaced):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeReplacedEvent):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent.uiSourceCodeAdded):
(initialize_WorkspaceTest.InspectorTest.waitForWorkspaceUISourceCodeAddedEvent):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):
(initialize_WorkspaceTest.InspectorTest._defaultUISourceCodeProviderEventHandler):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode.didRequestContent):
(initialize_WorkspaceTest.InspectorTest.dumpUISourceCode):
(initialize_WorkspaceTest):
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/dynamic-script-tag-expected.txt:
* inspector/debugger/dynamic-script-tag.html:
* inspector/debugger/network-uisourcecode-provider-expected.txt: Added.
* inspector/debugger/network-uisourcecode-provider.html: Added.
* inspector/debugger/raw-source-code-expected.txt: Removed.
* inspector/debugger/raw-source-code.html: Removed.
* inspector/debugger/resource-script-mapping-expected.txt: Added.
* inspector/debugger/resource-script-mapping.html: Added.
* inspector/debugger/scripts-panel.html:
* inspector/debugger/source-frame-count.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95682

Patch by Andrey Adaikin <aandrey@chromium.org> on 2012-09-03
Reviewed by Pavel Feldman.

Make the injected auxiliary property __resourceObject non-enumerable to hide it from for..in iterations.
Ideally this property should be completely hidden from the user's code.
Drive-by: Fix couple of small FIXME's.

* inspector/InjectedScriptWebGLModuleSource.js:
(.):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95565

Reviewed by Adam Barth.

Source/Platform:

* Platform.gypi:
* chromium/public/WebRTCICECandidateDescriptor.h: Copied from Source/Platform/chromium/public/WebRTCPeerConnectionHandlerClient.h.
(WebCore):
(WebKit):
(WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::~WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::operator=):
(WebKit::WebRTCICECandidateDescriptor::isNull):
* chromium/public/WebRTCPeerConnectionHandler.h:
(WebKit):
(WebRTCPeerConnectionHandler):
* chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebKit):
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

Adds all Ice-related functionality to RTCPeerConnection, including
events, callbacks and methods.

Test: fast/mediastream/RTCPeerConnection-ice.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/RTCIceCandidateEvent.cpp: Added.
(WebCore):
(WebCore::RTCIceCandidateEvent::create):
(WebCore::RTCIceCandidateEvent::RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::~RTCIceCandidateEvent):
(WebCore::RTCIceCandidateEvent::candidate):
(WebCore::RTCIceCandidateEvent::interfaceName):
* Modules/mediastream/RTCIceCandidateEvent.h: Added.
(WebCore):
(RTCIceCandidateEvent):
* Modules/mediastream/RTCIceCandidateEvent.idl: Added.
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::updateIce):
(WebCore):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::iceState):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didGenerateIceCandidate):
(WebCore::RTCPeerConnection::didChangeIceState):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeIceState):
* Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* WebCore.gypi:
* dom/EventNames.h:
(WebCore):
* dom/EventNames.in:
* platform/chromium/support/WebRTCICECandidateDescriptor.cpp: Copied from Source/WebCore/platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp.
(WebKit):
(WebKit::WebRTCICECandidateDescriptor::WebRTCICECandidateDescriptor):
(WebKit::WebRTCICECandidateDescriptor::assign):
(WebKit::WebRTCICECandidateDescriptor::reset):
(WebKit::WebRTCICECandidateDescriptor::initialize):
(WebKit::WebRTCICECandidateDescriptor::operator PassRefPtr<WebCore::RTCIceCandidateDescriptor>):
(WebKit::WebRTCICECandidateDescriptor::candidate):
(WebKit::WebRTCICECandidateDescriptor::sdpMid):
(WebKit::WebRTCICECandidateDescriptor::sdpMLineIndex):
* platform/mediastream/RTCIceCandidateDescriptor.h:
(WebCore::RTCIceCandidateDescriptor::candidate):
(WebCore::RTCIceCandidateDescriptor::sdpMid):
(WebCore::RTCIceCandidateDescriptor::sdpMLineIndex):
* platform/mediastream/RTCPeerConnectionHandler.h:
(WebCore):
(RTCPeerConnectionHandler):
* platform/mediastream/RTCPeerConnectionHandlerClient.h:
(WebCore):
(RTCPeerConnectionHandlerClient):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::updateIce):
(WebCore):
(WebCore::RTCPeerConnectionHandlerChromium::addIceCandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didGenerateICECandidate):
(WebCore::RTCPeerConnectionHandlerChromium::didChangeICEState):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(WebKit):
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:

Tools:

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
(MockWebRTCPeerConnectionHandler::updateICE):
(MockWebRTCPeerConnectionHandler::addICECandidate):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
(MockWebRTCPeerConnectionHandler):

LayoutTests:

* fast/mediastream/RTCPeerConnection-ice-expected.txt: Added.
* fast/mediastream/RTCPeerConnection-ice.html: Added.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

* rendering/HitTestResult.cpp:
(WebCore::HitTestLocation::HitTestLocation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95685

Reviewed by Antonio Gomes.

Moves the flag and updates the interface for HitTestResult::addNodeToRectBasedTestResult so that
it can read the flag from HitTestRequest instead of from HitTestResult.

No change in functionality. No new tests.

* dom/Document.cpp:
(WebCore::Document::nodesFromRect):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
* rendering/HitTestRequest.h:
* rendering/HitTestResult.cpp:
(WebCore::HitTestLocation::HitTestLocation):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
* rendering/HitTestResult.h:
(HitTestLocation):
(HitTestResult):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::nodeAtPoint):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::nodeAtPoint):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=93888

Reviewed by Pavel Feldman.

Source/WebCore:

Certain invisible characters will be rendered as HTML entity references in the DOM tree to make them visible to the user.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):

LayoutTests:

* inspector/elements/elements-panel-structure-expected.txt:
* inspector/elements/elements-panel-structure.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95677

Reviewed by Yury Semikhatsky.

- renamed the file and the usages
- renamed isolatedContextCreated to executionContextCreated for consistency.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/Inspector.json:
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::notifyContextCreated):
* inspector/compile-front-end.py:
* inspector/front-end/RuntimeModel.js: Renamed from Source/WebCore/inspector/front-end/JavaScriptContextManager.js.
(WebInspector.RuntimeModel):
(WebInspector.RuntimeModel.prototype._frameAdded):
(WebInspector.RuntimeModel.prototype._frameDetached):
(WebInspector.RuntimeModel.prototype._executionContextCreated):
(WebInspector.RuntimeDispatcher):
(WebInspector.RuntimeDispatcher.prototype.executionContextCreated):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95540

Reviewed by Pavel Feldman.

Linkify recource details using WebInspector.linkifyResourceAsNode(), so these bypass linkifier. Also
fix closure compiler warning.

* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview):
(WebInspector.TimelinePresentationModel.Record.prototype._linkifyLocation):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Not reviewed.

* inspector/front-end/FilteredItemSelectionDialog.js:
* inspector/front-end/HeapSnapshotView.js:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95676

Reviewed by Alexander Pavlov.

Otherwise, ruler numbers are not visible when selecting body.

* inspector/InspectorOverlayPage.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95567

Reviewed by Yury Semikhatsky.

Source/WebCore:

We now assign execution context id upon changes in the UI.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype.get statusBarItems):
(WebInspector.ConsoleView.prototype._contextAdded):
(WebInspector.ConsoleView.prototype._addContextList):
(WebInspector.ConsoleView.prototype._contextListRemoved):
(WebInspector.ConsoleView.prototype._updateExecutionContextSelector):
(WebInspector.ConsoleView.prototype._appendExecutionContextOption):
(WebInspector.ConsoleView.prototype._executionContextChanged):
(WebInspector.ConsoleView.prototype._contextListUpdated):
(WebInspector.ConsoleView.prototype._addedExecutionContext):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow.evalCallback):
(WebInspector.ConsoleView.prototype.evalInInspectedWindow):
(WebInspector.ConsoleView.prototype._enterKeyPressed):
* inspector/front-end/JavaScriptContextManager.js:
(WebInspector.JavaScriptContextManager):
(WebInspector.JavaScriptContextManager.prototype.contextLists):
(WebInspector.JavaScriptContextManager.prototype.contextByFrameAndSecurityOrigin):
(WebInspector.JavaScriptContextManager.prototype._frameAdded):
(WebInspector.JavaScriptContextManager.prototype._frameNavigated):
(WebInspector.JavaScriptContextManager.prototype._frameDetached):
(WebInspector.JavaScriptContextManager.prototype.isolatedContextCreated):
(WebInspector.FrameExecutionContextList):
(WebInspector.FrameExecutionContextList.prototype._frameNavigated):
(WebInspector.FrameExecutionContextList.prototype._addExecutionContext):
(WebInspector.FrameExecutionContextList.prototype.executionContexts):
(WebInspector.FrameExecutionContextList.prototype.contextBySecurityOrigin):

LayoutTests:

* http/tests/inspector/console-cd-completions.html:
* http/tests/inspector/console-cd.html:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95436

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

The 'checkSpellingOfString' method assumes that the given string is concatenation of words.
To properly handle spellchecking of each word we need to iterate over the all available
dictionaries ('dictIter').

To allow spellchecking for multiple words, 'dictIter' should be initialized at the beginning
of vector while spellchecking of the word. This ensures performing of spelling for word based on
at least one dictionary.

* platform/text/enchant/TextCheckerEnchant.cpp:
(TextCheckerEnchant::checkSpellingOfString): Moved initialization of 'dictIter' to an inner loop.

LayoutTests:

'checkSpellingOfString' from the TextCheckerEnchant class can not mark multiplie words that are misspelled.
It's possible to mark misspeled string only by defining its location and length.

* platform/gtk/TestExpectations: Added spelling-backspace-between-lines.html to TestExpectations.


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Forms] Empty visible value of AM/PM field of multiple fields time input UI should display variable number of "-" based on maximum number of labels
https://bugs.webkit.org/show_bug.cgi?id=95660

Reviewed by Kent Tamura.

This patch changes visible empty value of AM/PM field in multiple
fields time input UI to "-", "--", "---", and so on based on maximum
length of AM/PM labels. In current implementation, it is always "--"
regardless locale, although on Arabic, AM/PM are represented in one
character.

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.

* html/shadow/DateTimeSymbolicFieldElement.cpp:
(makeVisibleEmptyValue): Build visible empty value from maximum length
of labels.
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Changed to
use m_visibleEmptyValue.
* html/shadow/DateTimeSymbolicFieldElement.h:
(WebCore::DateTimeSymbolicFieldElement): Added new member variable
m_visibleEmptyValue to hold visible empty value.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95542

Reviewed by Kent Tamura.

This patch changes width of AM/PM field of multiple field time input
UI fixed as maximum width of labels or "--".

This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME and
ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS.

No new tests. Once multiple field time input UI uses "lang" HTML
attribute to take time format, we can write a test for this patch.

* css/html.css:
(input::-webkit-datetime-edit-ampm-field): Added "display" property to "inline-block" for setting width.
Added "text-align" property to "center".
* html/shadow/DateTimeSymbolicFieldElement.cpp:
(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement): Changed to call setHasCustomCallback().
(WebCore::DateTimeSymbolicFieldElement::customStyleForRenderer): Added for setting field with from maximum width of labels.
* html/shadow/DateTimeSymbolicFieldElement.h:
(WebCore::DateTimeSymbolicFieldElement::visibleEmptyValue): Added for using visible empty value in customStyleForRenderer() and visibleValue().
(WebCore::DateTimeSymbolicFieldElement::visibleValue): Changed to call visibleEmptyValue() instead of using literal "--".
(DateTimeSymbolicFieldElement): Added a declaration of customStyleForRenderer().

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95301

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-09-02
Reviewed by Darin Adler.

The static string convertedSpaceString() had a couple of annoying side effects:
-The string was 16bits due to noBreakSpace, which forced any input to be converted to 16bits.
-The string was kept in the heap for no particular reason.

This patch redefines convertedSpaceString as a constant literal so that we can use it efficiently.

The patch also make the binary a tiny bit smaller (700 bytes).

* editing/HTMLInterchange.cpp:
(WebCore::convertHTMLTextToInterchangeFormat):


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95653

Patch by Mike West <mkwst@chromium.org> on 2012-09-02
Reviewed by Dirk Schulze.

Adding CSSPropertyWebkitClipPath to the massive switch statement in StyleResolver.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95480

Reviewed by Simon Fraser

Any dynamically triggered resource loading currently sends us back to deferred paint mode, making animation choppy. 
This is not the intention of this code.

This patch adds an additional condition that prevents page from re-entering deferred repaint mode after the initial
load has completed. It also cleans up the code slightly.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted):
        
    Add additional call to checkStopDelayingDeferredRepaints() after a frame load completes as the
    new condition in shouldUseLoadTimeDeferredRepaintDelay() looks for this change too.

* page/FrameView.cpp:
(WebCore):
        
    Reduced the normal delay from 25ms to 16ms to not interfere with full framerate animation.

(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::checkFlushDeferredRepaintsAfterLoadComplete):
        
    Ensure the repaint delay is reset after load completes even if we don't currently need a repaint.

(WebCore::FrameView::flushDeferredRepaints):
        
    We had to identical functions, flushDeferredRepaints() and stopDelayingDeferredRepaints(). Remove
    the latter.

(WebCore::FrameView::shouldUseLoadTimeDeferredRepaintDelay):
        
    Factor the test for using load time repaint timings to a functions. The test for
    initial page load having completed is new.

(WebCore::FrameView::updateDeferredRepaintDelay):
(WebCore::FrameView::updateLayoutAndStyleIfNeededRecursive):
(WebCore::FrameView::setRepaintThrottlingDeferredRepaintDelay):
* page/FrameView.h:
(FrameView):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

https://bugs.webkit.org/show_bug.cgi?id=95652

Reviewed by Adam Barth.
        
This undoes the 50% performance regression in pdfjs caused by
http://trac.webkit.org/changeset/126165

No new tests because behavior is unchanged.

* bindings/js/JSDOMBinding.cpp:
(WebCore::shouldAllowAccessToFrame):
(WebCore::shouldAllowAccessToDOMWindow):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@127387 268f45cc-cd09-0410-ab3c-d52691b4dbfc