Commits · b012c5eac8fe5794d2c5097d1a889be02fce78d7 · App_Technologies / webkit

01 Dec, 2009 40 commits

WAI-ARIA: implement support for ARIA drag and drop · b012c5ea

cfleizach@apple.com authored Dec 02, 2009

https://bugs.webkit.org/show_bug.cgi?id=32007

Reviewed by Darin Adler.

WebCore: 

Test: platform/mac/accessibility/aria-drag-drop.html

* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::supportsARIADropping):
(WebCore::AccessibilityObject::supportsARIADragging):
(WebCore::AccessibilityObject::isARIAGrabbed):
(WebCore::AccessibilityObject::setARIAGrabbed):
(WebCore::AccessibilityObject::determineARIADropEffects):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::supportsARIADropping):
(WebCore::AccessibilityRenderObject::supportsARIADragging):
(WebCore::AccessibilityRenderObject::isARIAGrabbed):
(WebCore::AccessibilityRenderObject::setARIAGrabbed):
(WebCore::AccessibilityRenderObject::determineARIADropEffects):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[AccessibilityObjectWrapper accessibilityIsAttributeSettable:]):
(-[AccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
* html/HTMLAttributeNames.in:

WebKitTools: 

* DumpRenderTree/AccessibilityUIElement.cpp:
(getARIADropEffectsCallback):
(getARIAIsGrabbedCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::ariaIsGrabbed):
(AccessibilityUIElement::ariaDropEffects):

LayoutTests: 

* platform/mac/accessibility/aria-drag-drop-expected.txt: Added.
* platform/mac/accessibility/aria-drag-drop.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b012c5ea

Typo fix. · 344da20d

abarth@webkit.org authored Dec 02, 2009

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

344da20d

2009-12-01 Adam Barth <abarth@webkit.org> · 345d17f8

abarth@webkit.org authored Dec 02, 2009

        https://bugs.webkit.org/show_bug.cgi?id=21288

        Unreviewed port of @sandbox to V8.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::isEnabled):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::createWindow):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

345d17f8

https://bugs.webkit.org/show_bug.cgi?id=21288 · 8c5918e6

abarth@webkit.org authored Dec 02, 2009

Reviewed by Darin Adler.

Add sneaky test that has tabs.

* fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
* fast/frames/sandboxed-iframe-attribute-parsing.html: Added.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8c5918e6

Change unsigned to int to fix the Windows build. · 18d381ea
bweinstein@apple.com authored Dec 02, 2009
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51578 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
18d381ea

2009-12-01 Patrik Persson <patrik.j.persson@ericsson.com> · b8a10552

abarth@webkit.org authored Dec 02, 2009

        Reviewed by Darin Adler.

        Implement HTML5 sandbox attribute for iframes.
        http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
        https://bugs.webkit.org/show_bug.cgi?id=21288

        * fast/frames/resources/non-sandboxed-iframe-navigation.html: Added.
        * fast/frames/resources/sandboxed-iframe-attribute-parsing-allowed.html: Added.
        * fast/frames/resources/sandboxed-iframe-attribute-parsing-disallowed.html: Added.
        * fast/frames/resources/sandboxed-iframe-form-allowed.html: Added.
        * fast/frames/resources/sandboxed-iframe-form-disallowed.html: Added.
        * fast/frames/resources/sandboxed-iframe-navigated.html: Added.
        * fast/frames/resources/sandboxed-iframe-navigation-child.html: Added.
        * fast/frames/resources/sandboxed-iframe-navigation-navigated.html: Added.
        * fast/frames/resources/sandboxed-iframe-navigation-parent.html: Added.
        * fast/frames/resources/sandboxed-iframe-navigation-source.html: Added.
        * fast/frames/resources/sandboxed-iframe-navigation-targetlink.html: Added.
        * fast/frames/resources/sandboxed-iframe-navigation-windowopen.html: Added.
        * fast/frames/resources/sandboxed-iframe-plugins-frame-applet.html: Added.
        * fast/frames/resources/sandboxed-iframe-plugins-frame-embed.html: Added.
        * fast/frames/resources/sandboxed-iframe-plugins-frame-object.html: Added.
        * fast/frames/resources/sandboxed-iframe-script-dynamic.html: Added.
        * fast/frames/resources/sandboxed-iframe-storage-allowed.html: Added.
        * fast/frames/resources/sandboxed-iframe-storage-disallowed.html: Added.
        * fast/frames/sandboxed-iframe-attribute-parsing-expected.txt: Added.
        * fast/frames/sandboxed-iframe-attribute-parsing.html: Added.
        * fast/frames/sandboxed-iframe-forms-expected.txt: Added.
        * fast/frames/sandboxed-iframe-forms.html: Added.
        * fast/frames/sandboxed-iframe-navigation-allowed-expected.txt: Added.
        * fast/frames/sandboxed-iframe-navigation-allowed.html: Added.
        * fast/frames/sandboxed-iframe-navigation-parent-expected.txt: Added.
        * fast/frames/sandboxed-iframe-navigation-parent.html: Added.
        * fast/frames/sandboxed-iframe-navigation-targetlink-expected.txt: Added.
        * fast/frames/sandboxed-iframe-navigation-targetlink.html: Added.
        * fast/frames/sandboxed-iframe-navigation-windowopen-expected.txt: Added.
        * fast/frames/sandboxed-iframe-navigation-windowopen.html: Added.
        * fast/frames/sandboxed-iframe-plugins-expected.txt: Added.
        * fast/frames/sandboxed-iframe-plugins.html: Added.
        * fast/frames/sandboxed-iframe-scripting-expected.txt: Added.
        * fast/frames/sandboxed-iframe-scripting.html: Added.
        * fast/frames/sandboxed-iframe-storage-expected.txt: Added.
        * fast/frames/sandboxed-iframe-storage.html: Added.
        * http/tests/security/resources/sandboxed-iframe-document-cookie-read-denied.html: Added.
        * http/tests/security/resources/sandboxed-iframe-modify-self.html: Added.
        * http/tests/security/resources/xss-DENIED-sandboxed-iframe-attacker.html: Added.
        * http/tests/security/sandboxed-iframe-document-cookie-expected.txt: Added.
        * http/tests/security/sandboxed-iframe-document-cookie.html: Added.
        * http/tests/security/sandboxed-iframe-modify-self-expected.txt: Added.
        * http/tests/security/sandboxed-iframe-modify-self.html: Added.
        * http/tests/security/xss-DENIED-sandboxed-iframe-expected.txt: Added.
        * http/tests/security/xss-DENIED-sandboxed-iframe.html: Added.
        * http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html: Added.
        * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard-expected.txt: Added.
        * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html: Added.
        * http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html: Added.
        * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow-iframe.html: Added.
        * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-allow.cgi: Added.
        * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-iframe.html: Added.
        * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard-iframe.html: Added.
        * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied-without-wildcard.cgi: Added.
        * http/tests/xmlhttprequest/resources/access-control-sandboxed-iframe-denied.cgi: Added.
2009-12-01  Patrik Persson  <patrik.j.persson@ericsson.com>

        Reviewed by Darin Adler.

        Implement HTML5 sandbox attribute for iframes.
        http://www.w3.org/TR/html5/text-level-semantics.html#attr-iframe-sandbox
        https://bugs.webkit.org/show_bug.cgi?id=21288

        Tests: fast/frames/sandboxed-iframe-attribute-parsing.html
               fast/frames/sandboxed-iframe-forms.html
               fast/frames/sandboxed-iframe-navigation-allowed.html
               fast/frames/sandboxed-iframe-navigation-parent.html
               fast/frames/sandboxed-iframe-navigation-targetlink.html
               fast/frames/sandboxed-iframe-navigation-windowopen.html
               fast/frames/sandboxed-iframe-plugins.html
               fast/frames/sandboxed-iframe-scripting.html
               fast/frames/sandboxed-iframe-storage.html
               http/tests/security/sandboxed-iframe-document-cookie.html
               http/tests/security/sandboxed-iframe-modify-self.html
               http/tests/security/xss-DENIED-sandboxed-iframe.html
               http/tests/xmlhttprequest/access-control-sandboxed-iframe-allow.html
               http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied-without-wildcard.html
               http/tests/xmlhttprequest/access-control-sandboxed-iframe-denied.html

        * bindings/js/JSDOMWindowCustom.cpp: sandboxing navigation
        (WebCore::createWindow):
        * bindings/js/ScriptController.cpp: sandboxing scripts
        (WebCore::ScriptController::isEnabled):
        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv):
        (WebCore::Document::cookie): raise exception when accessed from sandbox
        (WebCore::Document::setCookie): raise exception when accessed from sandbox
        (WebCore::Document::initSecurityContext): updae sandbox status
        (WebCore::Document::updateSandboxFlags):
        * dom/Document.h:
        * dom/Document.idl:
        * html/HTMLAppletElement.cpp: sandboxing applets
        (WebCore::HTMLAppletElement::createRenderer):
        (WebCore::HTMLAppletElement::renderWidgetForJSBindings):
        (WebCore::HTMLAppletElement::canEmbedJava):
        * html/HTMLAppletElement.h:
        * html/HTMLAttributeNames.in:
        * html/HTMLFrameOwnerElement.cpp: management of sandbox flags as stated in attribute
        (WebCore::HTMLFrameOwnerElement::HTMLFrameOwnerElement):
        (WebCore::HTMLFrameOwnerElement::setSandboxFlags):
        * html/HTMLFrameOwnerElement.h:
        (WebCore::HTMLFrameOwnerElement::sandboxFlags):
        * html/HTMLIFrameElement.cpp: sandbox attribute parsing
        (WebCore::parseSandboxAttribute):
        (WebCore::HTMLIFrameElement::parseMappedAttribute):
        * html/HTMLIFrameElement.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getCookies):
        * loader/CrossOriginAccessControl.cpp:
        (WebCore::passesAccessControlCheck):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::init):
        (WebCore::FrameLoader::submitForm): sandboxing forms
        (WebCore::FrameLoader::requestObject): sandboxing plugins
        (WebCore::FrameLoader::shouldAllowNavigation): sandboxing navigation
        (WebCore::FrameLoader::updateSandboxFlags): propagation of sandbox flags
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::ownerElementSandboxFlagsChanged):
        (WebCore::FrameLoader::isSandboxed):
        (WebCore::FrameLoader::sandboxFlags):
        * loader/FrameLoaderTypes.h:
        (WebCore::):
        * page/DOMWindow.cpp: disable storage and databases in sandboxed frames
        (WebCore::DOMWindow::sessionStorage):
        (WebCore::DOMWindow::localStorage):
        (WebCore::DOMWindow::openDatabase):
        * page/SecurityOrigin.cpp: added sandboxing status
        (WebCore::SecurityOrigin::SecurityOrigin):
        (WebCore::SecurityOrigin::canAccess):
        (WebCore::SecurityOrigin::canRequest):
        (WebCore::SecurityOrigin::toString):
        * page/SecurityOrigin.h:
        (WebCore::SecurityOrigin::setSandboxFlags):
        (WebCore::SecurityOrigin::isSandboxed):
        (WebCore::SecurityOrigin::canAccessDatabase):
        (WebCore::SecurityOrigin::canAccessStorage):
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::didReceiveData):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b8a10552

ARIA: support a way to create a static text object · bd43f07d

cfleizach@apple.com authored Dec 02, 2009

https://bugs.webkit.org/show_bug.cgi?id=32030

Reviewed by David Kilzer.

WebCore: 

Test: accessibility/aria-text-role.html

* accessibility/AccessibilityObject.cpp:
(WebCore::createARIARoleMap):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::isDescendantOfBarrenParent):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::text):
* accessibility/AccessibilityRenderObject.h:

LayoutTests: 

* accessibility/aria-text-role-expected.txt: Added.
* accessibility/aria-text-role.html: Added.
* platform/gtk/Skipped:
* platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bd43f07d

Not reviewed. GTK DRT try 2. · 0067edb7

zimmermann@webkit.org authored Dec 02, 2009


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0067edb7

Not reviewed. Try to fix gtk DRT build. · 03e0a333

zimmermann@webkit.org authored Dec 02, 2009


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

03e0a333

Touch WebKit.idl to rebuild Interfaces and fix the Windows build. · 16df50a8
bweinstein@apple.com authored Dec 02, 2009
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51573 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
16df50a8

Inspector crashes when collecting on every allocation · ff7890e1

oliver@apple.com authored Dec 02, 2009

https://bugs.webkit.org/show_bug.cgi?id=32044

Reviewed by Maciej Stachowiak.

The crash is caused by the prototype wrapper object getting collected
when allocating the object that is going to use it as a prototype.
Because the only reference to the prototype wrapper is through the
new object's Structure it does not get marked automatically.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ff7890e1

Build fix by using DOMNode::node() to go from a DOMNode to a node, and · 7abd0d56

bweinstein@apple.com authored Dec 02, 2009

added svg/animation in the WebCore.vcproj list of headers to be copied
over on build.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7abd0d56

check-webkit-style does not understand (Prefix)Foo(Custom|Gtk|CG|Mac).cpp including Foo.h · 1e35af71

levin@chromium.org authored Dec 02, 2009

https://bugs.webkit.org/show_bug.cgi?id=32033

Reviewed by Eric Seidel.

* Scripts/modules/cpp_style.py: Changed check for a possible primary header to use find
                                instead of startswith.
* Scripts/modules/cpp_style_unittest.py: Added a unit test for the new behavior.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1e35af71

Not reviewed. Qt build almost fixed, DumpRenderTree should compile now as well. · adf4e19f
zimmermann@webkit.org authored Dec 02, 2009
```
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51569 268f45cc-cd09-0410-ab3c-d52691b4dbfc
```
adf4e19f

Not reviewed. Try to fix qt/win builds. · 8e195f83

zimmermann@webkit.org authored Dec 02, 2009


git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8e195f83

2009-12-01 Nikolas Zimmermann <nzimmermann@rim.com> · 840d1766

zimmermann@webkit.org authored Dec 02, 2009

        Reviewed by Simon Fraser.

        Add SVG animation test framework with 'snapshot' functionality
        https://bugs.webkit.org/show_bug.cgi?id=31897

        Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
        forwarding the call to SVGDocumentExtensions, if SVG is enabled.

        Implemented just like the existing pauseAnimation* methods for CSS animations.

        * Api/qwebframe.cpp:
        (qt_drt_pauseSVGAnimation):
2009-12-01  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Simon Fraser.

        Add SVG animation test framework with 'snapshot' functionality
        https://bugs.webkit.org/show_bug.cgi?id=31897

        Add API used by the new 'sampleSVGAnimationForElementAtTime' DRT method,
        forwarding the call to SVGDocumentExtensions, if SVG is enabled.

        Implemented just like the existing pauseAnimation* methods for CSS animations.

        * webkit/webkitprivate.h:
    ...

840d1766

JavaScriptCore: Added variants of find/contains/add that allow a foreign key type to be used. · bc3c1476

snej@chromium.org authored Dec 02, 2009

This will allow AtomicString-keyed maps to be queried by C string without
having to create a temporary AtomicString (see HTTPHeaderMap.)
The code for this is adapted from the equivalent in HashSet.h.

WebCore: Add convenience methods to Element and QualifiedName that take
char* instead of AtomicString, in preparation for removing the
implicit conversion between the two types (30187).
https://bugs.webkit.org/show_bug.cgi?id=31749

Reviewed by Darin Adler.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

bc3c1476

More Windows build fix. · 9c19a120

ap@apple.com authored Dec 01, 2009

        * platform/network/cf/CredentialStorageCFNet.cpp:
        (WebCore::CredentialStorage::getFromPersistentStorage):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9c19a120

Windows build fix. · b565dd45

ap@apple.com authored Dec 01, 2009

        * platform/network/cf/CredentialStorageCFNet.cpp: Include RetainPtr.h.



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

b565dd45

Skip more tests that fail with specific versions of CFNetwork on Windows · 64b696b1

aroben@apple.com authored Dec 01, 2009

Rubber-stamped in advance by Brady Eidson.

* platform/win/Skipped:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

64b696b1

Simplify [WebView userAgentForURL:]. No need to call into helper function. · 02c9476f

weinig@apple.com authored Dec 01, 2009

Reviewed by Mark Rowe.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::userAgent):
* WebView/WebView.mm:
(-[WebView userAgentForURL:]):
* WebView/WebViewInternal.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

02c9476f

Reviewed by Darin Adler. · aeb999ad

ap@apple.com authored Dec 01, 2009

https://bugs.webkit.org/show_bug.cgi?id=32036
Implement CredentialStorage::getFromPersistentStorage for CFNetwork

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

aeb999ad

[Chromium] Simplify zoom-related APIs and add a zoom level getter, · 7fbcd16a

pkasting@chromium.org authored Dec 01, 2009

part one: Add new APIs.  (Old APIs will be removed in a second pass.)
https://bugs.webkit.org/show_bug.cgi?id=31893

Reviewed by Darin Fisher.

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::zoomLevel):
(WebKit::WebViewImpl::setZoomLevel):
* src/WebViewImpl.h:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7fbcd16a

2009-12-01 Daniel Bates <dbates@webkit.org> · f06a4d76

eric@webkit.org authored Dec 01, 2009

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=32001

        Updated layout test to reflect change to localized string and
        rebased the result.

        * inspector/elements-img-tooltip-expected.txt:
        * inspector/elements-img-tooltip.html:
2009-12-01  Daniel Bates  <dbates@webkit.org>

        Reviewed by Pavel Feldman.

        https://bugs.webkit.org/show_bug.cgi?id=32001

        Added missing localized strings (that I left out of the patch for bug #21554):
        %d × %d pixels
        %d × %d pixels (Natural: %d × %d pixels)

        Also, changed formatting of these stings to conform with existing ones (added
        a space on both sides of the multiply sign).

        * English.lproj/localizedStrings.js: Added stings.
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype.createTooltipForImageNode):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

f06a4d76

2009-12-01 Daniel Bates <dbates@webkit.org> · a82ec714

eric@webkit.org authored Dec 01, 2009

        Reviewed by Kenneth Rohde Christiansen.

        https://bugs.webkit.org/show_bug.cgi?id=31898

        Makes QtLauncher default to the http scheme for URLs.

        * QtLauncher/main.cpp:
        (MainWindow::MainWindow):
        (MainWindow::changeLocation):
        (main):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a82ec714

Skip a test that fails with some versions of CFNetwork on Windows · a15fb1ea

aroben@apple.com authored Dec 01, 2009

Rubber-stamped by Brady Eidson.

* platform/win/Skipped: Skip http/tests/plugins/post-url-file.html.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a15fb1ea

Fix for bug 32032, empty namespaces should be allowed in @namespace directives in CSS. · 6e4e9856

hyatt@apple.com authored Dec 01, 2009

Reviewed by Simon Fraser.

Added fast/css/namespaces/namespaces-empty.xml

* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addNamespace):
(WebCore::CSSStyleSheet::determineNamespace):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6e4e9856

Revert 51551 because it broke GTK+. · 197accca

kov@webkit.org authored Dec 01, 2009

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

197accca

Remove user content before running each test on Windows · 73ca6e7e

aroben@apple.com authored Dec 01, 2009

Fixes <http://webkit.org/b/31479> Make websocket tests work on Windows

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting): Remove all user content
before each test, which matches Mac.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

73ca6e7e

2009-12-01 Joseph Pecoraro <joepeck@webkit.org> · 02237f75

joepeck@webkit.org authored Dec 01, 2009

        Reviewed by Timothy Hatcher.

        Web Inspector: Escape key in the Search Field should be more User Friendly
        https://bugs.webkit.org/show_bug.cgi?id=32005

        * inspector/front-end/inspector.js:
        (WebInspector.loaded): add mousedown listener on the search field
        (WebInspector.searchFieldManualFocus): user clicked to focus on the search field
        (WebInspector.searchKeyDown): handle escape

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

02237f75

Enabling WebSocket tests on Windows again - let's see what errors get logged. · 9d4a04bb

ap@apple.com authored Dec 01, 2009

        * platform/win/Skipped:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9d4a04bb

2009-12-01 Laszlo Gombos <laszlo.1.gombos@nokia.com> · 823bfaf1

eric@webkit.org authored Dec 01, 2009

        Reviewed by Eric Seidel.

        PLATFORM(CAIRO) should be defined by WIN_CAIRO define
        https://bugs.webkit.org/show_bug.cgi?id=22250

        * wtf/Platform.h: Remove WTF_PLATFORM_CAIRO as it is
        already define in config.h

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

823bfaf1

2009-12-01 Yuzo Fujishima <yuzo@google.com> · 97479bbf

ap@apple.com authored Dec 01, 2009

        Reviewed by Alexey Proskuryakov.

        Make pywebsocket log errors to a file
        https://bugs.webkit.org/show_bug.cgi?id=31604

        * Scripts/run-webkit-tests: Log output to a pywebsocket_log.txt file in results directory
        (by passing the path to the server via a recently added -l option).



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

97479bbf

@namespace directives need to use "maybe_space" in the "maybe_ns_prefix"... · 5ccf9a12

hyatt@apple.com authored Dec 01, 2009

@namespace directives need to use "maybe_space" in the "maybe_ns_prefix" portion of the grammar to match
the spec.  Not doing so prevent comments from being used immmediately after the namespace prefix.

Reviewed by David Kilzer.

Added fast/css/namespaces-comments.xml

* css/CSSGrammar.y:



git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5ccf9a12

2009-12-01 Xiyuan Xia <xiyuan@chromium.org> · e6dd2557

eric@webkit.org authored Dec 01, 2009

        Reviewed by Darin Fisher.

        Only fire start/stop events when main frame is not loading.

        https://bugs.webkit.org/show_bug.cgi?id=31838

        * src/FrameLoaderClientImpl.cpp:
        (WebKit::FrameLoaderClientImpl::dispatchDidChangeLocationWithinPage):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

e6dd2557

Add a timing-out test to the Skipped file on Windows · c4d65298

aroben@apple.com authored Dec 01, 2009

Rubber-stamped by Ada Chan.

* platform/win/Skipped: Added
fast/dom/Window/window-postmessage-clone.html, which was timing out
due to eventSender.beginDragFiles being unimplemented.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

c4d65298

Fix tests that use the TestNetscapePlugin in Debug_Internal builds · a6a81b06

aroben@apple.com authored Dec 01, 2009

Reviewed by Ada Chan.

Fixes <http://webkit.org/b/32027> REGRESSION (r49705): Tests that use
TestNetscapePlugin fail in Debug_Internal builds

* DumpRenderTree/win/DumpRenderTree.cpp: Use the "_Debug" plugin
directory in Debug and Debug_All builds, but not in Debug_Internal
builds.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

a6a81b06

Re-enable DRT's watchdog timer on Windows · 06cd711f

aroben@apple.com authored Dec 01, 2009

It was accidentally disabled in r50907.

* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setWaitToDump): Remove a "false &&" that snuck
into an if condition.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

06cd711f

2009-12-01 Yael Aharon <yael.aharon@nokia.com> · 0c9118b2

eric@webkit.org authored Dec 01, 2009

        Reviewed by Timothy Hatcher.

        Reloading WebInspector from context menu is closing it instead of reloading.
        https://bugs.webkit.org/show_bug.cgi?id=32004

        When reloading WebInspector, don't delete its m_page.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::close):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

0c9118b2

Add expected Windows failure results for tests that use textInputController · 84857548

aroben@apple.com authored Dec 01, 2009

<http://webkit.org/b/32021> covers fixing these tests.

Rubber-stamped by Sam Weinig.

* platform/win/Skipped: Removed tests that use textInputController.

* platform/win/editing/selection/5825350-1-expected.txt: Added.
* platform/win/editing/selection/5825350-2-expected.txt: Added.
* platform/win/editing/selection/mixed-editability-10-expected.txt: Added.
* platform/win/fast/events/ime-composition-events-001-expected.txt: Added.
* platform/win/fast/forms/input-maxlength-ime-completed-expected.txt: Added.
* platform/win/fast/forms/input-maxlength-ime-preedit-expected.txt: Added.
* platform/win/fast/text/international/thai-cursor-position-expected.txt: Added.

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@51543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

84857548