- 03 Mar, 2010 40 commits
-
-
sfalken@apple.com authored
* JavaScriptCore.vcproj/jsc/jsc.vcproj: * JavaScriptCore.vcproj/jsc/jscCommon.vsprops: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55495 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken@apple.com authored
* JavaScriptCore.vcproj/jsc/jsc.vcproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
The patch broke fast/frames/sandboxed-iframe-storage.html Last one (I hope). * WebCore.xcodeproj/project.pbxproj: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55491 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dumi@chromium.org authored
cleaning up some style issues. Reviewed by Dimitri Glazkov. * storage/database-lock-after-reload.html: * storage/resources/database-lock-after-reload-2.html: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55490 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
Exclude leaks in Java that build bot complains about. * Scripts/run-webkit-tests: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55489 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
The patch broke fast/frames/sandboxed-iframe-storage.html Unfortunately, (the webkit-patch rollout and) I missed these in r55485. WebCore: * bindings/js/JSDatabaseCallback.cpp: Removed. * bindings/js/JSDatabaseCallback.h: Removed. * bindings/v8/custom/V8DatabaseCallback.cpp: Removed. * bindings/v8/custom/V8DatabaseCallback.h: Removed. * storage/DatabaseCallback.h: Removed. LayoutTests: * storage/open-database-creation-callback-expected.txt: Removed. * storage/open-database-creation-callback-isolated-world-expected.txt: Removed. * storage/open-database-creation-callback-isolated-world.html: Removed. * storage/open-database-creation-callback.html: Removed. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55488 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dumi@chromium.org authored
SQLTransaction::checkAndHandleClosedDatabase() should only be run when that method is invoked on the DB thread. Reviewed by Dimitri Glazkov. We cannot test this fix with a test, because the crash happens only when all of the following conditions are met: 1. A database is closing. 2. A transaction on that database is in progress. 3. The transaction is in a state where a statement/transaction success/error callback needs to be invoked (so there's a task for this transaction pending on the main thread). 4. The DB thread finished processing all its tasks and called SQLTransactionCoordinator::shutdown() before the main thread go to that task. The closest thing we have to a test is running LayoutTests/storage/database-lock-after-reload.html 1000 times in a row. Without the patch, the probability of a crash happening in one of the runs is very high. With the patch, the test should reliably run 1000 times in a row without a single crash. https://bugs.webkit.org/show_bug.cgi?id=35624 * storage/SQLTransaction.cpp: (WebCore::SQLTransaction::checkAndHandleClosedDatabase): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55487 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@chromium.org authored
Reviewed by Mark Rowe. Page should not care about Chromium plug-in implementation details https://bugs.webkit.org/show_bug.cgi?id=35623 * WebCore.gypi: Compile PluginViewNone.cpp * page/Page.cpp: (WebCore::Page::privateBrowsingStateChanged): Remove conditional compilation for PLATFORM(CHROMIUM). git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55486 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
No review, rolling out r55474. http://trac.webkit.org/changeset/55480 The patch broke fast/frames/sandboxed-iframe-storage.html * Android.jscbindings.mk: * Android.v8bindings.mk: * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * bindings/js/JSDOMWindowCustom.cpp: * bindings/v8/custom/V8DOMWindowCustom.cpp: * dom/Document.cpp: (WebCore::Document::postTask): * page/DOMWindow.cpp: (WebCore::DOMWindow::openDatabase): * page/DOMWindow.h: * page/DOMWindow.idl: * storage/Database.cpp: (WebCore::Database::openDatabase): (WebCore::Database::Database): (WebCore::Database::performOpenAndVerify): * storage/Database.h: * workers/WorkerContext.cpp: (WebCore::WorkerContext::openDatabase): * workers/WorkerContext.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55485 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
levin@chromium.org authored
No review, rolling out r55480. http://trac.webkit.org/changeset/55480 The patch broke fast/frames/sandboxed-iframe-storage.html * storage/Database.cpp: * storage/Database.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55484 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mrowe@apple.com authored
Reviewed by Geoff Garen. JavaScriptCore: * wtf/TCSystemAlloc.cpp: (TryMmap): Use the VM tag. * wtf/VMTags.h: Make use of VM_MEMORY_TCMALLOC and VM_MEMORY_WEBCORE_PURGEABLE_BUFFERS. WebCore: * platform/mac/PurgeableBufferMac.cpp: (WebCore::PurgeableBuffer::create): Use the VM tag. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55483 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
Try better to fix Java tests on Tiger bot. * platform/mac-tiger/Skipped: * platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Removed. This test gets different resultson each run when it fails, so it needs to be disabled on Tiger. * platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added a newline I didn't get when copying actual results from buildbot. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55482 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cmarrin@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=35610 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55481 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dumi@chromium.org authored
Database.cpp. Reviewed by nobody, build fix. * storage/Database.cpp: * storage/Database.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55480 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ossy@webkit.org authored
missing layoutTestController.evaluateScriptInIsolatedWorld() * platform/qt/Skipped: storage/open-database-creation-callback-isolated-world.html skipped. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55479 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
darin@apple.com authored
* WebCore.xcodeproj/project.pbxproj: Marked a couple of headers "private" so they can be used in the WebKit project. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55478 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=35700 Some of the newly added Java tests fail randomly on buildbot * fast/js/resources/js-test-post-async.js: Added a version that calls notifyDone(). I first wanted to add a notifyDone() call to js-test-post.js, but it turns out that multiple tests dump results after "TEST COMPLETE", and we need to get bots back to green fast. * java/lc3: (Many files). Don't load two scripts dynamically, WebKit has issues with order of execution in this case. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55477 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
sfalken@apple.com authored
Fix bogus xcopy that was polluting source tree at build time. * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55476 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=35044 Crash in XML tokenizer reloading zoom-coords-viewattr-01-b.svg I'm often getting a crash even when opening the test for the first time in Safari, but it doesn't seem to crash in DumpRenderTree. Still, I can't think of a stronger way to test for this condition, so no new regression test. * dom/XMLTokenizer.cpp: (WebCore::XMLTokenizer::end): Be prepared that parsing remaining input will pause parsing. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
dumi@chromium.org authored
passed to openDatabase(). Reviewed by Adam Barth. Test: storage/open-database-creation-callback.html https://bugs.webkit.org/show_bug.cgi?id=34726 * Android.jscbindings.mk * Android.v8bindings.mk * GNUmakefile.am: * WebCore.gypi: * WebCore.pro: * WebCore.vcproj/WebCore.vcproj: * WebCore.xcodeproj/project.pbxproj: * bindings/js/JSDOMWindowCustom.cpp: (WebCore::JSDOMWindow::openDatabase): * bindings/js/JSDatabaseCallback.cpp: Added. (WebCore::JSDatabaseCallback::JSDatabaseCallback): (WebCore::JSDatabaseCallback::~JSDatabaseCallback): (WebCore::JSDatabaseCallback::handleEvent): * bindings/js/JSDatabaseCallback.h: Added. (WebCore::JSDatabaseCallback::create): * bindings/v8/custom/V8DOMWindowCustom.cpp: (WebCore::V8DOMWindow::openDatabaseCallback): * bindings/v8/custom/V8DatabaseCallback.cpp: Added. (WebCore::V8DatabaseCallback::V8DatabaseCallback): (WebCore::V8DatabaseCallback::~V8DatabaseCallback): (WebCore::V8DatabaseCallback::handl...
-
cmarrin@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55473 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
bweinstein@apple.com authored
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55472 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
Two newly added Java tests fail on Tiger build bot. Just land actual results as expected. I don't even know which behavior is more correct. * platform/mac-tiger/java: Added. * platform/mac-tiger/java/lc3: Added. * platform/mac-tiger/java/lc3/JavaArray: Added. * platform/mac-tiger/java/lc3/JavaArray/ToString-001-expected.txt: Added. * platform/mac-tiger/java/lc3/JavaObject: Added. * platform/mac-tiger/java/lc3/JavaObject/JavaObjectToString-001-expected.txt: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55471 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=35692 <rdar://problem/7703622> Crash when calling abort() on an XHR while in a windowless WebView * Panels/WebAuthenticationPanel.m: (-[WebAuthenticationPanel runAsModalDialogWithChallenge:]): Retain the challenge, just like it's done for sheet. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55470 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
ap@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=35617 Import Mozilla LiveConnect 3 test suite * java/lc3/sources: Added (many files). Sources for Mozilla test applet. * java/jstests.jar: Added in compiled form, since it's unlikely that we'll ever need to modify the above sources. * java/lc3.java: Added. (lc3): This is a small wrapper around jstests.jar. The latter only adds some classes, but WebKit needs an actual applet to call into Java. (lc3.createQAObject): Instantiate a class defined in jstests.jar by name. (lc3.stringToByteArray): A helper to make a byte array out of string. Tests originally relied on window.java package interface to do this, but it's not available in WebKit. We need more functions like this to work around other uses of window.java, but this is one I wrote for now. * java/Makefile: Link test applets to Mozilla's jstests.jar. This is not needed for tests other than ones imported here, but it's also harmless, and I don't know how to write good makefiles. * java/lc3: Added (many files). Tests were heavily reworked to run to completion, but PASS/FAIL results should not be generally relied upon. All html wrappers are identical. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55469 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric.carlson@apple.com authored
Unreviewed, build fix. Update expected results for fast/js/custom-constructors-expected.txt git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55468 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
cmarrin@apple.com authored
https://bugs.webkit.org/show_bug.cgi?id=35610 git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55467 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
apavlov@chromium.org authored
Reviewed by Pavel Feldman. Web Inspector: resources panel only shows uncompressed resource size. https://bugs.webkit.org/show_bug.cgi?id=35403 * English.lproj/localizedStrings.js: * inspector/InspectorResource.cpp: (WebCore::InspectorResource::updateScriptObject): * inspector/front-end/AbstractTimelinePanel.js: (WebInspector.AbstractTimelinePanel.prototype.refresh): * inspector/front-end/AuditRules.js: (WebInspector.AuditRules.GzipRule.prototype.doRun): (WebInspector.AuditRules.GzipRule.prototype._shouldCompress): * inspector/front-end/ImageView.js: (WebInspector.ImageView): * inspector/front-end/Resource.js: (WebInspector.Resource.prototype.get resourceSize): (WebInspector.Resource.prototype.set resourceSize): (WebInspector.Resource.prototype.get transferSize): (WebInspector.Resource.CompareBySize): (WebInspector.Resource.CompareByTransferSize): * inspector/front-end/ResourcesPanel.js: (WebInspector.ResourcesPanel.prototype.populateSidebar): (WebInspector.ResourceTimeCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphLabels): (WebInspector.ResourceTransferSizeCalculator.prototype.computeBarGraphPercentages): (WebInspector.ResourceTransferSizeCalculator.prototype._value): (WebInspector.ResourceTransferSizeCalculator.prototype._networkBytes): (WebInspector.ResourceSidebarTreeElement.CompareByDescendingTransferSize): (WebInspector.ResourceGraph.prototype.refreshLabelPositions): (WebInspector.ResourceGraph.prototype.refresh): * inspector/front-end/inspector.css: * inspector/front-end/inspector.js: (WebInspector.updateResource): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55466 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
mitz@apple.com authored
* dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55465 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
pfeldman@chromium.org authored
Reviewed by Timothy Hatcher. Web Inspector: Get rid of synchronous debuggerEnabled, profilerEnabled calls. https://bugs.webkit.org/show_bug.cgi?id=32331 * inspector/InspectorBackend.cpp: * inspector/InspectorBackend.h: * inspector/InspectorBackend.idl: * inspector/front-end/BreakpointsSidebarPane.js: (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype.removeBreakpoint): (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged): * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel): (WebInspector.ProfilesPanel.prototype.profilerWasEnabled): (WebInspector.ProfilesPanel.prototype.profilerWasDisabled): (WebInspector.ProfilesPanel.prototype._updateInterface): (WebInspector.ProfilesPanel.prototype._enableProfiling): (WebInspector.ProfilesPanel.prototype._toggleProfiling): * inspector/front-end/ScriptsPanel.js: (WebInspector.ScriptsPanel): (WebInspector.ScriptsPanel.prototype.debuggerWasEnabled): (WebInspector.ScriptsPanel.prototype.debuggerWasDisabled): (WebInspector.ScriptsPanel.prototype.reset): (WebInspector.ScriptsPanel.prototype.canShowSourceLine): (WebInspector.ScriptsPanel.prototype._updateDebuggerButtons): (WebInspector.ScriptsPanel.prototype._enableDebugging): (WebInspector.ScriptsPanel.prototype._toggleDebugging): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55464 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric.carlson@apple.com authored
Reviewed by Adele Peterson. Replace 'autobuffer' attribute with 'preload' to align with spec revision 4811. https://bugs.webkit.org/show_bug.cgi?id=35385 rdar://problem/7689602 Tests: media/audio-constructor-preload.html media/video-dom-preload.html * html/HTMLAttributeNames.in: Remove autobuffer, add preload * html/HTMLAudioElement.cpp: (WebCore::HTMLAudioElement::createForJSConstructor): set preload to 'auto' instead of autobuffer to true. * html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_preload. (WebCore::HTMLMediaElement::parseMappedAttribute): Deal with 'preload' attribute. (WebCore::HTMLMediaElement::loadResource): Call setPreload() on the newly created MediaPlayer, before calling load() so it can pass the setting through to the media engine. (WebCore::HTMLMediaEl...
-
rdar://problem/7682756mitz@apple.com authored
Reviewed by Sam Weinig. WebCore: Test: fast/dom/remove-children-notification-order.html * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeChildren): Changed to call childrenChanged() before calling removedFromDocument() on each removed child, which matches the order removeChild() does things, and avoids the assertion. This required temporarily storing the removed children in a vector. Also added comments about other discrepancies between this function and removeChild(). LayoutTests: * fast/dom/remove-children-notification-order-expected.txt: Added. * fast/dom/remove-children-notification-order.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55462 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
abarth@webkit.org authored
Reviewed by Darin Adler. Document cookieURL and firstPartyForCookies https://bugs.webkit.org/show_bug.cgi?id=35613 Some folks asked what the cookieURL and the firstPartyForCookies were on IRC. This patch documents these properties in the code so folks don't have to ask on IRC anymore. * dom/Document.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55461 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Simon Hausmann. Refactor QtLauncher so it respects command line arguments and inherits settings when you clone or create a new window. Implemented with help of Kenneth Rohde Christiansen. [Qt] QtLauncher must be refactored to fix command line arguments usage https://bugs.webkit.org/show_bug.cgi?id=35536 * QtLauncher/main.cpp: (LauncherWindow::LauncherWindow): (LauncherWindow::init): (LauncherWindow::isGraphicsBased): (applySetting): (LauncherWindow::applyPrefs): (LauncherWindow::initializeView): (LauncherWindow::newWindow): (LauncherWindow::cloneWindow): (LauncherWindow::createChrome): (main): * QtLauncher/webview.cpp: (WebViewGraphicsBased::WebViewGraphicsBased): (WebViewGraphicsBased::setFrameRateMeasurementEnabled): * QtLauncher/webview.h: (WebViewGraphicsBased::itemCacheMode): (WebViewGraphicsBased::frameRateMeasurementEnabled): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55460 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Gustavo Noronha Silva. [Gtk]: assertion triggered when geolocation getCurrentPosition without an option argument. https://bugs.webkit.org/show_bug.cgi?id=35666 * platform/gtk/GeolocationServiceGtk.cpp: (WebCore::GeolocationServiceGtk::startUpdating): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
kov@webkit.org authored
[GTK] build slaves need working geoclue service https://bugs.webkit.org/show_bug.cgi?id=35674 Skip tests we're not really able to run for the time being. * platform/gtk/Skipped: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55458 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
eric@webkit.org authored
Reviewed by Xan Lopez. Miscellaneous little fixes for the windows build of webkit-gtk https://bugs.webkit.org/show_bug.cgi?id=35640 * GNUmakefile.am: On Windows with GCC, presence of __declspec(dllexport) on some symbols disables the autoexport/autoimport feature for all others. Using regex here assures that all symbols that need to be exported in the dll are actually exported. 2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch> Reviewed by Xan Lopez. Miscellaneous little fixes for the windows build of webkit-gtk https://bugs.webkit.org/show_bug.cgi?id=35640 * GNUmakefile.am: dist two new files concerning mathml support. 2010-03-03 Fridrich Strba <fridrich.strba@bluewin.ch> Reviewed by Xan Lopez. Miscellaneous little fixes for the windows build of webkit-gtk https://bugs.webkit.org/show_bug.cgi?id=35640 * webkit/webkitdownload.cpp: Windows headers define ERROR which breaks the build. Undef ERROR if it is defined. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55457 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
xan@webkit.org authored
Unreviewed distcheck fix. Add new file to the build. * GNUmakefile.am: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55456 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
antti@apple.com authored
Reviewed by Oliver Hunt. https://bugs.webkit.org/show_bug.cgi?id=35586 * WebCore.pro: * WebCore.xcodeproj/project.pbxproj: * platform/graphics/IntPointHash.h: Added. (WTF::IntPointHash::hash): (WTF::IntPointHash::equal): (WTF::): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55455 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-
philn@webkit.org authored
Unreviewed, build fix after r55452. * webkit/webkitwebview.cpp: (DNDContentsRequest::webkit_web_view_settings_notify): added missing braces. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55454 268f45cc-cd09-0410-ab3c-d52691b4dbfc
-