1. 05 Dec, 2013 26 commits
  2. 04 Dec, 2013 14 commits
    • samuel_white@apple.com's avatar
      Layout Test platform/mac/accessibility/search-predicate-element-count.html is flaky · 722b96b3
      samuel_white@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125195
      
      Reviewed by Chris Fleizach.
      
      Our test checks for AccessibilityObject::isOnscreen which makes sure an element is currently scrolled to a visible
      location onscreen. This test was flaky because sometimes elements we thought would be visible weren't. To resolve
      this I've moved the elements that are tested for visibility to the very top of the document so they have a tiny
      vertical offset and will ALWAYS be visible.
      
      * platform/mac/TestExpectations:
      * platform/mac/accessibility/search-predicate-element-count-expected.txt:
      * platform/mac/accessibility/search-predicate-element-count.html:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160160 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      722b96b3
    • commit-queue@webkit.org's avatar
      % unit heights don't work if parent block height is set in vh · 9478219d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=118516
      
      Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-12-04
      Reviewed by Simon Fraser.
      
      From Blink r156449 by <srinivasa.ragavan.venkateswaran@intel.com>
      
      Source/WebCore:
      
      An element having height as percentage needs to have the
      containingblock's height or availableheight to calculate its
      own height. The containing block having a height set in vh
      unit was not being considered for calculating the child's
      height.
      
      Tests: fast/css/viewport-percentage-compute-box-height.html
             fast/css/viewport-percentage-compute-box-width.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computePercentageLogicalHeight):
      Correct child's height(in pecentage) was not being calculated
      incase of parent having height set in vh unit. Added condition
      to calculate the containing block height in terms of viewport size.
      
      LayoutTests:
      
      * fast/css/viewport-percentage-compute-box-height-expected.html: Added.
      * fast/css/viewport-percentage-compute-box-height.html: Added.
      * fast/css/viewport-percentage-compute-box-width-expected.html: Added.
      * fast/css/viewport-percentage-compute-box-width.html: Added.
      Added new tests for verifying that percentage unit height/width works
      if parent block height/width is set in vh/vw units.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160159 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9478219d
    • roger_fong@apple.com's avatar
      [Windows] Unreviewed build fix. Copy headers from rendering/line to build directory. · f0679740
      roger_fong@apple.com authored
      * WebCore.vcxproj/copyForwardingHeaders.cmd:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f0679740
    • rniwa@webkit.org's avatar
      bgColor, setBgColor, alinkColor, setAlinkColor, and etc... on HTMLBodyElement are useless · 58bf1c9a
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125208
      
      Rubber-stamped by Anders Carlsson.
      
      Address Darin's comment to use fastGetAttribute instead of getAttribute.
      
      * html/HTMLDocument.cpp:
      (WebCore::HTMLDocument::bgColor):
      (WebCore::HTMLDocument::fgColor):
      (WebCore::HTMLDocument::alinkColor):
      (WebCore::HTMLDocument::linkColor):
      (WebCore::HTMLDocument::vlinkColor):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160157 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      58bf1c9a
    • rniwa@webkit.org's avatar
      Enable HTMLTemplateElement by default · 9c8509d0
      rniwa@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=123851
      
      Reviewed by Antti Koivisto.
      
      .: 
      
      * Source/autotools/SetupWebKitFeatures.m4:
      * Source/cmake/WebKitFeatures.cmake:
      
      Source/WTF: 
      
      * wtf/FeatureDefines.h:
      
      Tools: 
      
      * Scripts/webkitperl/FeatureList.pm:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160156 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c8509d0
    • matthew_hanson@apple.com's avatar
      Versioning. · 0dc16c34
      matthew_hanson@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160155 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0dc16c34
    • matthew_hanson@apple.com's avatar
      Versioning. · b53d1252
      matthew_hanson@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160154 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b53d1252
    • commit-queue@webkit.org's avatar
      Consolidate various frame snapshot capabilities. · 2dd8bf0d
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124325
      
      Patch by Brian J. Burg <burg@cs.washington.edu> on 2013-12-04
      Reviewed by Darin Adler.
      
      Source/WebCore:
      
      Various snapshot creation methods had duplicated code and were split
      between Frame, DragImage, and platform-specific implementationss.
      This patch puts WebCore snapshot methods into FrameSnapshotting
      and removes platform implementations where possible.
      
      DragImage methods reuse snapshot methods where possible. Inspector
      will be able to take snapshots without using drag images.
      
      No new tests, this is a refactoring.
      
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * WebCore.exp.in:
      * WebCore.vcxproj/WebCore.vcxproj:
      * WebCore.vcxproj/WebCore.vcxproj.filters:
      * WebCore.xcodeproj/project.pbxproj:
      * bindings/objc/DOM.mm:
      (-[DOMNode renderedImage]):
      (-[DOMRange renderedImageForcingBlackText:]):
      * dom/Clipboard.cpp:
      (WebCore::Clipboard::createDragImage):
      * dom/ClipboardMac.mm:
      (WebCore::Clipboard::createDragImage):
      * page/DragController.cpp:
      (WebCore::DragController::startDrag):
      * page/Frame.cpp:
      * page/Frame.h:
      * page/FrameSnapshotting.cpp: Added.
      (WebCore::ScopedFramePaintingState::ScopedFramePaintingState):
      (WebCore::ScopedFramePaintingState::~ScopedFramePaintingState):
      (WebCore::snapshotFrameRect): Move most buffer logic to here.
      (WebCore::snapshotSelection): Moved from Frame.
      (WebCore::snapshotNode): Moved from Frame.
      * page/FrameSnapshotting.h: Added.
      * page/mac/FrameMac.mm: Removed.
      * page/mac/FrameSnapshottingMac.h: Removed.
      * page/mac/FrameSnapshottingMac.mm: Removed.
      * page/win/FrameWin.cpp: remove duplicate implementation.
      * page/win/FrameWin.h: Fix an incorrect parameter name.
      * platform/DragImage.cpp:
      (WebCore::ScopedNodeDragState::ScopedNodeDragState):
      (WebCore::ScopedNodeDragState::~ScopedNodeDragState):
      (WebCore::createDragImageFromSnapshot): Boilerplate buffer conversion.
      (WebCore::createDragImageForNode):
      (WebCore::createDragImageForSelection):
      (WebCore::ScopedFrameSelectionState::ScopedFrameSelectionState):
      (WebCore::ScopedFrameSelectionState::~ScopedFrameSelectionState):
      (WebCore::createDragImageForRange): Moved from Frame.
      (WebCore::createDragImageForImage): Moved from FrameSnapshottingMac.
      (WebCore::createDragImageForLink): use nullptr.
      
      Source/WebKit/ios:
      
      * WebCoreSupport/WebFrameIOS.mm: use new header file.
      
      Source/WebKit/mac:
      
      Use new platform-independent methods instead of Mac methods.
      
      * WebView/WebHTMLView.mm:
      (-[WebHTMLView _selectionDraggingImage]):
      (-[WebHTMLView selectionImageForcingBlackText:]):
      
      Source/WebKit/win:
      
      * DOMCoreClasses.cpp:
      (DOMElement::renderedImage): use createDragImageForNode.
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160152 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2dd8bf0d
    • commit-queue@webkit.org's avatar
      [EFL] Bumping GStreamer version to 1.2.1 · 9df78de6
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=125155
      
      Patch by Jozsef Berta <jberta@inf.u-szeged.hu> on 2013-12-04
      Reviewed by Gyuyoung Kim.
      
      * efl/jhbuild.modules: Set the GStreamer version to 1.2.1
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160151 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9df78de6
    • fpizlo@apple.com's avatar
      Fold constant typed arrays · ee327c85
      fpizlo@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125205
      
      Source/JavaScriptCore: 
      
      Reviewed by Oliver Hunt and Mark Hahnenberg.
              
      If by some other mechanism we have a typed array access on a compile-time constant
      typed array pointer, then fold:
              
      - Array bounds checks. Specifically, fold the load of length.
              
      - Loading the vector.
              
      This needs to install a watchpoint on the array itself because of the possibility of
      neutering. Neutering is ridiculous. We do this without bloating the size of
      ArrayBuffer or JSArrayBufferView in the common case (i.e. the case where you
      allocated an array that didn't end up becoming a compile-time constant). To install
      the watchpoint, we slowDownAndWasteMemory and then create an incoming reference to
      the ArrayBuffer, where that incoming reference is from a watchpoint object. The
      ArrayBuffer already knows about such incoming references and can fire the
      watchpoints that way.
              
      * CMakeLists.txt:
      * GNUmakefile.list.am:
      * JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
      * JavaScriptCore.xcodeproj/project.pbxproj:
      * dfg/DFGDesiredWatchpoints.cpp:
      (JSC::DFG::ArrayBufferViewWatchpointAdaptor::add):
      (JSC::DFG::DesiredWatchpoints::addLazily):
      * dfg/DFGDesiredWatchpoints.h:
      (JSC::DFG::GenericSetAdaptor::add):
      (JSC::DFG::GenericSetAdaptor::hasBeenInvalidated):
      (JSC::DFG::ArrayBufferViewWatchpointAdaptor::hasBeenInvalidated):
      (JSC::DFG::GenericDesiredWatchpoints::reallyAdd):
      (JSC::DFG::GenericDesiredWatchpoints::areStillValid):
      (JSC::DFG::GenericDesiredWatchpoints::isStillValid):
      (JSC::DFG::GenericDesiredWatchpoints::shouldAssumeMixedState):
      (JSC::DFG::DesiredWatchpoints::isStillValid):
      (JSC::DFG::DesiredWatchpoints::shouldAssumeMixedState):
      (JSC::DFG::DesiredWatchpoints::isValidOrMixed):
      * dfg/DFGGraph.cpp:
      (JSC::DFG::Graph::tryGetFoldableView):
      * dfg/DFGGraph.h:
      * dfg/DFGSpeculativeJIT.cpp:
      (JSC::DFG::SpeculativeJIT::jumpForTypedArrayOutOfBounds):
      (JSC::DFG::SpeculativeJIT::emitTypedArrayBoundsCheck):
      (JSC::DFG::SpeculativeJIT::compileGetByValOnIntTypedArray):
      (JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
      (JSC::DFG::SpeculativeJIT::compileGetByValOnFloatTypedArray):
      (JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):
      (JSC::DFG::SpeculativeJIT::compileConstantIndexedPropertyStorage):
      (JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
      * dfg/DFGSpeculativeJIT.h:
      * dfg/DFGWatchpointCollectionPhase.cpp:
      (JSC::DFG::WatchpointCollectionPhase::handle):
      (JSC::DFG::WatchpointCollectionPhase::addLazily):
      * ftl/FTLLowerDFGToLLVM.cpp:
      (JSC::FTL::LowerDFGToLLVM::compileGetIndexedPropertyStorage):
      (JSC::FTL::LowerDFGToLLVM::compileGetByVal):
      (JSC::FTL::LowerDFGToLLVM::compilePutByVal):
      (JSC::FTL::LowerDFGToLLVM::typedArrayLength):
      * runtime/ArrayBuffer.cpp:
      (JSC::ArrayBuffer::transfer):
      * runtime/ArrayBufferNeuteringWatchpoint.cpp: Added.
      (JSC::ArrayBufferNeuteringWatchpoint::ArrayBufferNeuteringWatchpoint):
      (JSC::ArrayBufferNeuteringWatchpoint::~ArrayBufferNeuteringWatchpoint):
      (JSC::ArrayBufferNeuteringWatchpoint::finishCreation):
      (JSC::ArrayBufferNeuteringWatchpoint::destroy):
      (JSC::ArrayBufferNeuteringWatchpoint::create):
      (JSC::ArrayBufferNeuteringWatchpoint::createStructure):
      * runtime/ArrayBufferNeuteringWatchpoint.h: Added.
      (JSC::ArrayBufferNeuteringWatchpoint::set):
      * runtime/VM.cpp:
      (JSC::VM::VM):
      * runtime/VM.h:
      
      LayoutTests: 
      
      Reviewed by Oliver Hunt and Mark Hahnenberg.
      
      * js/regress/fixed-typed-array-storage-expected.txt: Added.
      * js/regress/fixed-typed-array-storage-var-index-expected.txt: Added.
      * js/regress/fixed-typed-array-storage-var-index.html: Added.
      * js/regress/fixed-typed-array-storage.html: Added.
      * js/regress/script-tests/fixed-typed-array-storage-var-index.js: Added.
      (foo):
      * js/regress/script-tests/fixed-typed-array-storage.js: Added.
      (foo):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160150 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ee327c85
    • commit-queue@webkit.org's avatar
      Update jhbuild revision. · 16c7d7a2
      commit-queue@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=124966
      
      Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2013-12-04
      Reviewed by Gyuyoung Kim.
      
      Used version of Jhbuild failed to create directories and caused
      update-webkitefl-libs to fail. Latest Jhbuild version has it fixed.
      
      * jhbuild/jhbuild-wrapper:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      16c7d7a2
    • weinig@apple.com's avatar
      [Cocoa] Make WKConnection work with WKObject wrapping · 7206d0db
      weinig@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125266
      
      Reviewed by Dan Bernstein.
      
      * UIProcess/API/Cocoa/WKConnection.mm:
      (-[WKConnection dealloc]):
      (didReceiveMessage):
      (didClose):
      (setUpClient):
      (-[WKConnection delegate]):
      (-[WKConnection setDelegate:]):
      (-[WKConnection sendMessageWithName:body:]):
      (-[WKConnection remoteObjectRegistry]):
      (-[WKConnection API::]):
      * UIProcess/API/Cocoa/WKConnectionInternal.h:
      (WebKit::wrapper):
      * UIProcess/API/Cocoa/WKProcessGroup.mm:
      (didCreateConnection):
      * WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
      (-[WKWebProcessPlugInController _initWithPrincipalClassInstance:bundleRef:]):
      (-[WKWebProcessPlugInController connection]):
      (-[WKWebProcessPlugInController _bundleRef]):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160148 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7206d0db
    • benjamin@webkit.org's avatar
      Remove spaces on a blank line to have ResourceHandleCFNet.cpp identical to iOS · 3d7ac80f
      benjamin@webkit.org authored
      Unreviewed.
      
      Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-12-04
      
      * platform/network/cf/ResourceHandleCFNet.cpp:
      (WebCore::ResourceHandle::platformLoadResourceSynchronously):
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160147 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      3d7ac80f
    • andersca@apple.com's avatar
      Add a WeakObjCPtr class · 06f7733b
      andersca@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=125267
      
      Reviewed by Geoffrey Garen.
      
      Source/WebKit2:
      
      WeakObjCPtr is a zeroing weak reference class template that will be used for delegates.
      
      * Shared/mac/WeakObjCPtr.h: Added.
      (WebKit::WeakObjCPtr::WeakObjCPtr):
      (WebKit::WeakObjCPtr::~WeakObjCPtr):
      (WebKit::WeakObjCPtr::operator=):
      (WebKit::WeakObjCPtr::get):
      * WebKit2.xcodeproj/project.pbxproj:
      
      Tools:
      
      Add API tests for WeakObjCPtr.
      
      * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
      * TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm: Added.
      (TEST):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@160146 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      06f7733b