1. 06 Mar, 2008 1 commit
  2. 05 Mar, 2008 10 commits
    • kevino@webkit.org's avatar
      Fix the wx build after the bindings move. · 62f191f2
      kevino@webkit.org authored
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30824 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      62f191f2
    • alp@webkit.org's avatar
      2008-03-05 Alp Toker <alp@atoker.com> · 29183505
      alp@webkit.org authored
              GTK+ build fix for breakage introduced in r30800.
      
              Track moved bridge sources from JavaScriptCore to WebCore.
      
              * GNUmakefile.am:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30821 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      29183505
    • mrowe@apple.com's avatar
      2008-03-05 Brent Fulgham <bfulgham@gmail.com> · 02a10025
      mrowe@apple.com authored
              Reviewed by Adam Roben.
      
              Modify source files to use the USE(SAFARI_THEME) macro, rather than
              USE_SAFARI_THEME.  (http://bugs.webkit.org/show_bug.cgi?id=17683)
      
              * WebCore/platform/win/PlatformScrollBarSafari.cpp
              * WebCore/rendering/RenderThemeSafari.cpp
              * WebCore/rendering/RenderThemeSafari.h
              * config.h: Move definition of WTF_USE_SAFARI_THEME here
      
      2008-03-05  Brent Fulgham  <bfulgham@gmail.com>
      
              Reviewed by Adam Roben.
      
              Remove definition of WTF_USE_SAFARI_THEME from wtf/Platform.h
              because the PLATFORM(CG) flag is not set until config.h has
              already included this file.
      
              * wtf/Platform.h:  Remove useless definition of WTF_USE_SAFARI_THEME
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30812 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      02a10025
    • beidson@apple.com's avatar
      JavaScriptCore: · a059d6f9
      beidson@apple.com authored
              Reviewed by Alexey and Mark Rowe
      
              Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html
      
              DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
              removing particular items for Databases that were shutting down.
      
              This filtering operation is not atomic, and therefore causes a race condition with the
              MessageQueue waking up and reading from the message queue.  
      
              The end result was an attempt to dereference a null DatabaseTask.  Timing-wise, this never
              seemed to happen in a debug build, otherwise an assertion would've caught it.  Replacing that
              assertion with a crash in a release build is what revealed this bug.
      
              * wtf/MessageQueue.h:
              (WTF::::waitForMessage): Tweak the waiting logic to check the queue's empty state then go back
                to sleep if the queue was empty - checking m_killed each time it wakes up.
      
      WebCore:
      
              Reviewed by Alexey and Mark Rowe
      
              Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html
      
              DatabaseThread::unscheduleDatabaseTasks() manually filters through a MessageQueue,
              removing particular items for Databases that were shutting down.
      
              This filtering operation is not atomic, and therefore causes a race condition with the
              database thread waking up and reading from the message queue.  
      
              The end result was an attempt to dereference a null DatabaseTask.  Timing-wise, this never
              seemed to happen in a debug build, otherwise an assertion would've caught it.  Replacing that
              assertion with a crash in a release build is what revealed this bug.
      
              The fix for the above symptom was entirely in WTF::MessageQueue in JSCore.  With this fix in 
              place, another crash popped up in the layout tests that was related to dereferencing a 
              deallocated object - simply because SQLTransaction had a raw pointer to it's Database object 
              when it needed to be a ref pointer.
      
              * storage/SQLTransaction.cpp:
              (WebCore::SQLTransaction::runCurrentStatement):
              * storage/SQLTransaction.h: Change m_database to be a RefPtr
              (WebCore::SQLTransaction::database):
      
      LayoutTests:
      
              Reviewed by Alexey + Mark Rowe
      
              Fix for <rdar://problem/5778247> - Reproducible crash on storage/execute-sql-args.html
      
              This test takes its best shot at handling two databases on a single database thread at once,
              then having one of those databases go away completely (garbage collection and everything)
      
              * storage/multiple-databases-garbage-collection-expected.txt: Added.
              * storage/multiple-databases-garbage-collection.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30811 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a059d6f9
    • ddkilzer@apple.com's avatar
      Remove unused header includes from interpreter.cpp. · b1a25b51
      ddkilzer@apple.com authored
              Reviewed by Darin.
      
              * kjs/interpreter.cpp: Remove unused header includes.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30810 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b1a25b51
    • ddkilzer@apple.com's avatar
      Fixed commit date. · 867a6a5e
      ddkilzer@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30808 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      867a6a5e
    • andersca@apple.com's avatar
      Reviewed by Sam. · f3b9897e
      andersca@apple.com authored
              
              Remove bindings/.
      
              * bindings: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30800 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f3b9897e
    • andersca@apple.com's avatar
      Don't build bindings/ anymore. · bcfbd395
      andersca@apple.com authored
              
              * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30797 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bcfbd395
    • andersca@apple.com's avatar
      JavaScriptCore: · 74d51542
      andersca@apple.com authored
              Reviewed by Geoff.
      
              Don't build JavaScriptCore/bindings.
              
              * JavaScriptCore.exp:
              Export a couple of new functions. 
              
              * JavaScriptCore.xcodeproj/project.pbxproj:
              Remove bindings/
              
              * kjs/config.h:
              No need to define HAVE_JNI anymore.
              
              * kjs/interpreter.cpp:
              Remove unnecessary include.
      
      WebCore:
      
              Reviewed by Geoff.
      
              * WebCore.base.exp:
              Add the NPN and KJS methods.
              
              * WebCore.xcodeproj/project.pbxproj:
              Bring in bridge/
      
              * config.h:
              Add HAVE_JNI define.
              
              * bindings/js/kjs_html.cpp:
              * bindings/objc/DOMInternal.mm:
              * bindings/objc/DOMUtility.mm:
              * bindings/objc/WebScriptObject.mm:
              * html/HTMLAppletElement.cpp:
              * html/HTMLEmbedElement.cpp:
              * html/HTMLObjectElement.cpp:
              * html/HTMLPlugInElement.cpp:
              * page/Frame.cpp:
              * page/mac/FrameMac.mm:
              * page/mac/WebCoreFrameBridge.mm:
              * page/mac/WebCoreScriptDebugger.mm:
              * plugins/win/PluginViewWin.cpp:
              Include file changes.
      
      WebKit/mac:
      
              Reviewed by Geoff.
      
              Include file changes.
              
              * Plugins/WebBaseNetscapePluginView.mm:
              * Plugins/WebNetscapePluginPackage.m:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30796 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      74d51542
    • ddkilzer@apple.com's avatar
      Allow override of default script file name using command-line argument. · a172de83
      ddkilzer@apple.com authored
              Reviewed by Adele.
      
              * API/minidom.c:
              (main): Allow first command-line argument to override the default script
              file name of "minidom.js".
              * API/testapi.c:
              (main): Allow first command-line argument to override the default script
              file name of "testapi.js".
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30795 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a172de83
  3. 04 Mar, 2008 1 commit
  4. 03 Mar, 2008 1 commit
  5. 02 Mar, 2008 2 commits
  6. 29 Feb, 2008 2 commits
  7. 28 Feb, 2008 1 commit
  8. 27 Feb, 2008 1 commit
  9. 26 Feb, 2008 1 commit
    • weinig@apple.com's avatar
      JavaScriptCore: · f8479433
      weinig@apple.com authored
              Reviewed by Dan Bernstein.
      
              - Add a variant of remove that takes a position and a length.
      
              * wtf/Vector.h:
              (WTF::Vector::remove):
      
      WebCore:
      
              Reviewed by Dan Bernstein.
      
              Make the cleanPath function in CSSStyleSelector more efficient by using
              a Vector<UChar>.
      
              * css/CSSStyleSelector.cpp:
              (WebCore::cleanPath): Make this function work on a Vector<UChar> instead
              of a String.  Also remove unnecessary reverseFind call that could be acomplished
              with two compares.
              (WebCore::checkPseudoState): Remove reserveCapacity calls now that we are using
              a stack buffer.
              * platform/text/PlatformString.h:
              (WebCore::find): Make this find generic enough that it can be used for
              String::find.
              (WebCore::reverseFind): Implement reverseFind so that it can be used
              for with a UChar* and length.
              * platform/text/StringImpl.cpp:
              (WebCore::StringImpl::find): Use implementation in PlatformString.cpp
              (WebCore::StringImpl::reverseFind): Ditto,
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30593 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f8479433
  10. 25 Feb, 2008 4 commits
  11. 24 Feb, 2008 4 commits
    • weinig@apple.com's avatar
      Reviewed by Mark Rowe. · 95ec0004
      weinig@apple.com authored
              http://bugs.webkit.org/show_bug.cgi?id=17528
              Give testkjs a bath
      
              * JavaScriptCore.exp:
              * JavaScriptCore.xcodeproj/project.pbxproj: Make the testkjs.cpp use 4 space indentation.
              * kjs/testkjs.cpp:
              (StopWatch::getElapsedMS):
              (GlobalObject::className):
              (GlobalObject::GlobalObject):
              Rename GlobalImp to GlobalObject and setup the global functions
              in the GlobalObject's constructor. Also, use static functions for
              the implementation so we can use the standard PrototypeFunction
              class and remove TestFunctionImp.
              (functionPrint): Move print() functionality here.
              (functionDebug): Move debug() functionality here.
              (functionGC): Move gc() functionality here.
              (functionVersion): Move version() functionality here.
              (functionRun): Move run() functionality here.
              (functionLoad): Move load() functionality here.
              (functionQuit): Move quit() functionality here.
              (prettyPrintScript): Fix indentation.
              (runWithScripts): Since all the functionality of createGlobalObject is
              now in the GlobalObject constructor, just call new here.
              (parseArguments): Fix indentation.
              (kjsmain): Ditto
              (fillBufferWithContentsOfFile): Ditto.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30555 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      95ec0004
    • weinig@apple.com's avatar
      Reviewed by Oliver Hunt and Mark Rowe. · 86f155c3
      weinig@apple.com authored
              http://bugs.webkit.org/show_bug.cgi?id=17505
              Add support for getting command line arguments in testkjs
      
              - This slightly changes the behavior of parsing arguments by requiring
                a '-f' before all files. 
      
              * kjs/testkjs.cpp:
              (createGlobalObject): Add a global property called 'arguments' which
              contains an array with the parsed arguments as strings.
              (runWithScripts): Pass in the arguments vector so that it can be passed
              to the global object.
              (parseArguments): Change parsing rules to require a '-f' before any script
              file. After all '-f' and '-p' arguments have been parsed, the remaining
              are added to the arguments vector and exposed to the script. If there is a
              chance of ambiguity (the user wants to pass the string '-f' to the script),
              the string '--' can be used separate the options from the pass through 
              arguments.
              (kjsmain):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30553 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      86f155c3
    • mitz@apple.com's avatar
      Reviewed by Darin Adler. · 00aa164f
      mitz@apple.com authored
              - fix http://bugs.webkit.org/show_bug.cgi?id=17511
                REGRESSION: Reproducible crash in SegmentedSubstring::SegmentedSubstring(SegmentedSubstring const&)
      
              * wtf/Deque.h:
              (WTF::::expandCapacityIfNeeded): Fixed the case where m_start and m_end
              are both zero but the buffer capacity is non-zero.
              (WTF::::prepend): Added validity checks.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30550 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      00aa164f
    • pewtermoose@webkit.org's avatar
      2008-02-23 Jan Michael Alonzo <jmalonzo@unpluggable.com> · 7a953d97
      pewtermoose@webkit.org authored
      .:
      
              Rubber stamped by Darin.
      
              Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
              whitespaces introduced in the previous commit.
      
              * GNUmakefile.am: 
      
      JavaScriptCore:
      
              Rubber stamped by Darin.
      
              Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
              whitespaces introduced in the previous commit.
      
              * GNUmakefile.am: 
      
      WebKitTools:
      
              Rubber stamped by Darin.
      
              Add separator '\' after libJavaScriptCore_la_LIBADD and cleanup
              whitespaces introduced in the previous commit.
      
              * GNUmakefile.am:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30542 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7a953d97
  12. 23 Feb, 2008 10 commits
    • darin@apple.com's avatar
      .: · 47e2c23b
      darin@apple.com authored
              Rubber-stamped by Darin.
      
              * GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
              * configure.ac: Break dependent modules into GLOBALDEPS and WEBKITDEPS.
      
      JavaScriptCore:
      
              * GNUmakefile.am: Add GLOBALDEPS for testkjs and minidom.
      
      WebKitTools:
      
              Rubber-stamped by Darin.
      
              * GNUmakefile.am: Add both GLOBALDEPS and WEBKITDEPS instead of DEPENDENCIES.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30540 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      47e2c23b
    • darin@apple.com's avatar
      Reviewed by Anders. · f329a7dc
      darin@apple.com authored
              - http://bugs.webkit.org/show_bug.cgi?id=17496
                make Deque use a circular array; add iterators
      
              * wtf/Deque.h: Wrote an all-new version of this class that uses a circular
              buffer. Growth policy is identical to vector. Added iterators.
      
              * wtf/Vector.h: Made two small refinements while using this to implement
              Deque: Made VectorBufferBase derive from Noncopyable, which would have
              saved me some debugging time if it had been there. Renamed Impl and
              m_impl to Buffer and m_buffer.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30538 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f329a7dc
    • darin@apple.com's avatar
      JavaScriptCore: · e25e04e3
      darin@apple.com authored
              Reviewed by Anders.
      
              - http://bugs.webkit.org/show_bug.cgi?id=17067
                eliminate attributes parameter from JSObject::put for speed/clarity
      
              * API/JSCallbackObject.h: Removed attribute arguments.
              * API/JSCallbackObjectFunctions.h:
              (KJS::JSCallbackObject<Base>::put): Ditto.
              * API/JSObjectRef.cpp:
              (JSObjectSetProperty): Use initializeVariable or putDirect when necessary
              to set attribute values.
              * JavaScriptCore.exp: Updated.
              * bindings/objc/objc_runtime.h: Removed attribute arguments.
              * bindings/objc/objc_runtime.mm:
              (ObjcFallbackObjectImp::put): Ditto.
              * bindings/runtime_array.cpp:
              (RuntimeArray::put): Ditto.
              * bindings/runtime_array.h: Ditto.
              * bindings/runtime_object.cpp:
              (RuntimeObjectImp::put): Ditto.
              * bindings/runtime_object.h: Ditto. Also removed canPut which was only
              called from one place in WebCore that can use hasProperty instead.
      
              * kjs/Activation.h: Removed attribute argument from put and added the new
              initializeVariable function that's used to put variables in variable objects.
              Also made isActivationObject a const member.
      
              * kjs/JSGlobalObject.cpp:
              (KJS::JSGlobalObject::put): Removed attribute argument.
              (KJS::JSGlobalObject::initializeVariable): Added. Used to give variables
              their initial values, which can include the read-only property.
              (KJS::JSGlobalObject::reset): Removed obsolete comments about flags.
              Removed Internal flag, which is no longer needed.
              * kjs/JSGlobalObject.h: More of the same.
      
              * kjs/JSVariableObject.h: Added pure virtual initializeVariable function.
              (KJS::JSVariableObject::symbolTablePut): Removed checkReadOnly flag; we always
              check read-only.
              (KJS::JSVariableObject::symbolTableInitializeVariable): Added.
      
              * kjs/array_instance.cpp:
              (KJS::ArrayInstance::put): Removed attribute argument.
              * kjs/array_instance.h: Ditto.
      
              * kjs/function.cpp:
              (KJS::FunctionImp::put): Ditto.
              (KJS::Arguments::put): Ditto.
              (KJS::ActivationImp::put): Ditto.
              (KJS::ActivationImp::initializeVariable): Added.
              * kjs/function.h: Removed attribute arguments.
      
              * kjs/function_object.cpp:
              (KJS::FunctionObjectImp::construct): Removed Internal flag.
      
              * kjs/lookup.h:
              (KJS::lookupPut): Removed attributes argument. Also changed to use putDirect
              instead of calling JSObject::put.
              (KJS::cacheGlobalObject): Ditto.
      
              * kjs/nodes.cpp:
              (KJS::ConstDeclNode::handleSlowCase): Call initializeVariable to initialize
              the constant.
              (KJS::ConstDeclNode::evaluateSingle): Ditto.
              (KJS::TryNode::execute): Use putDirect to set up the new object.
              (KJS::FunctionBodyNode::processDeclarations): Removed Internal.
              (KJS::ProgramNode::processDeclarations): Ditto.
              (KJS::EvalNode::processDeclarations): Call initializeVariable to initialize
              the variables and functions.
              (KJS::FuncDeclNode::makeFunction): Removed Internal.
              (KJS::FuncExprNode::evaluate): Ditto.
      
              * kjs/object.cpp: Removed canPut, which was only being used in one code path,
              not the normal high speed one.
              (KJS::JSObject::put): Removed attribute argument. Moved the logic from
              canPut here, in the one code ath that was still using it.
              * kjs/object.h: Removed Internal attribute, ad canPut function. Removed the
              attributes argument to the put function. Made isActivationObject const.
      
              * kjs/regexp_object.cpp:
              (KJS::RegExpImp::put): Removed attributes argument.
              (KJS::RegExpImp::putValueProperty): Ditto.
              (KJS::RegExpObjectImp::put): Ditto.
              (KJS::RegExpObjectImp::putValueProperty): Ditto.
              * kjs/regexp_object.h: Ditto.
      
              * kjs/string_object.cpp:
              (KJS::StringInstance::put): Removed attributes argument.
              * kjs/string_object.h: Ditto.
      
      WebCore:
      
              Reviewed by Anders.
      
              - http://bugs.webkit.org/show_bug.cgi?id=17067
                eliminate attributes parameter from JSObject::put for speed/clarity
      
              * bindings/js/JSCSSStyleDeclarationCustom.cpp:
              (WebCore::JSCSSStyleDeclaration::customPut): Remove attributes argument.
      
              * bindings/js/JSCanvasPixelArrayCustom.cpp:
              (WebCore::JSCanvasPixelArray::indexGetter): Use early exit idiom.
              (WebCore::JSCanvasPixelArray::indexSetter): Moved length check into the
              CanvasPixelArray object, for consistency with the getter. Removed attributes
              argument.
      
              * bindings/js/JSDOMWindowCustom.cpp:
              (WebCore::JSDOMWindow::customPut): Removed special case for variable
              initialization, which is not needed since that does use put any more.
              Removed attributes argument.
      
              * bindings/js/JSEventTargetBase.h:
              (WebCore::JSEventTargetBase::putValueProperty): Removed attributes argument.
              (WebCore::JSEventTargetBase::put): Ditto.
              (WebCore::JSEventTargetPrototype::self): Removed Internal flag.
              * bindings/js/JSEventTargetNode.cpp:
              (WebCore::JSEventTargetNode::put): Removed attributes argument.
              (WebCore::JSEventTargetNode::putValueProperty): Ditto.
              * bindings/js/JSEventTargetNode.h: Ditto.
              * bindings/js/JSHTMLAppletElementCustom.cpp:
              (WebCore::JSHTMLAppletElement::customPut): Ditto.
              * bindings/js/JSHTMLEmbedElementCustom.cpp:
              (WebCore::JSHTMLEmbedElement::customPut): Ditto.
              * bindings/js/JSHTMLInputElementBase.cpp:
              (WebCore::JSHTMLInputElementBase::put): Ditto.
              (WebCore::JSHTMLInputElementBase::putValueProperty): Ditto.
              * bindings/js/JSHTMLInputElementBase.h: Ditto.
              * bindings/js/JSHTMLObjectElementCustom.cpp:
              (WebCore::JSHTMLObjectElement::customPut): Ditto.
              * bindings/js/JSHTMLOptionsCollectionCustom.cpp:
              (WebCore::JSHTMLOptionsCollection::indexSetter): Ditto.
              * bindings/js/JSHTMLSelectElementCustom.cpp:
              (WebCore::JSHTMLSelectElement::indexSetter): Ditto.
              * bindings/js/JSHistoryCustom.cpp:
              (WebCore::JSHistory::customPut): Ditto.
              * bindings/js/JSLocation.cpp:
              (WebCore::JSLocation::put): Ditto.
              * bindings/js/JSLocation.h: Ditto.
              * bindings/js/JSXMLHttpRequest.cpp:
              (WebCore::JSXMLHttpRequest::put): Ditto.
              (WebCore::JSXMLHttpRequest::putValueProperty): Ditto.
              * bindings/js/JSXMLHttpRequest.h: Ditto.
      
              * bindings/js/kjs_dom.cpp:
              (WebCore::getRuntimeObject): Changed return type to JSObject*.
              * bindings/js/kjs_dom.h: Ditto.
      
              * bindings/js/kjs_events.cpp:
              (WebCore::JSClipboard::put): Removed attributes argument.
              (WebCore::JSClipboard::putValueProperty): Ditto.
              * bindings/js/kjs_events.h: Ditto.
      
              * bindings/js/kjs_html.cpp:
              (WebCore::runtimeObjectGetter): Updated for change to getRuntimeObject to
              return a JSObject. Used early exit idiom.
              (WebCore::runtimeObjectPropertyGetter): Ditto.
              (WebCore::runtimeObjectCustomGetOwnPropertySlot): Ditto.
              (WebCore::runtimeObjectCustomPut): Use hasProperty to check for properties
              that we should put with the property syntax instead of canPut.
              (WebCore::runtimeObjectImplementsCall): Ditto.
              (WebCore::runtimeObjectCallAsFunction): Ditto.
              * bindings/js/kjs_html.h: Removed attributes argument to runtimeObjectCustomPut.
      
              * bindings/js/kjs_window.cpp:
              (KJS::Window::put): Removed attributes argument.
              * bindings/js/kjs_window.h: Ditto.
      
              * bindings/scripts/CodeGeneratorJS.pm: Removed attributes argument from put,
              putValueProperty, customPut, and indexSetter.
      
              * html/CanvasPixelArray.h:
              (WebCore::CanvasPixelArray::set): Added index checking here, as in the get
              function. Before, the checking was done in the JavaScript bindings for set.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30534 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e25e04e3
    • pewtermoose@webkit.org's avatar
      2008-02-23 Jan Michael Alonzo <jmalonzo@unpluggable.com> · 0577f4fc
      pewtermoose@webkit.org authored
              Not reviewed, Gtk build fix.
      
              * kjs/testkjs.pro:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30531 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0577f4fc
    • ap@webkit.org's avatar
      01686d37
    • ap@webkit.org's avatar
      Build fix. · a9f84116
      ap@webkit.org authored
      JavaScriptCore:
              Touch some files, hoping that Windows build bot will create JSC headers.
      
              * kjs/AllInOneFile.cpp:
              * kjs/array_instance.cpp:
              * wtf/HashTable.cpp:
      
      WebKit/gtk:
              * webkit/webkitprivate.cpp:
              (webkit_init): Renamed initializeThreading to initializeThreadingAndMainThread.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30526 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a9f84116
    • ap@webkit.org's avatar
      Qt/Wx build fix - this file was still in a wrong namespace, too. · 2154b495
      ap@webkit.org authored
              * wtf/ThreadingNone.cpp:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30525 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2154b495
    • ap@webkit.org's avatar
      More build fixing - fix mismatched braces. · f004c502
      ap@webkit.org authored
              * JavaScriptCore.pri:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30524 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f004c502
    • ap@webkit.org's avatar
      Wx and Gtk build fixes. · 64d199ae
      ap@webkit.org authored
              * JavaScriptCore.pri: Don't try to compile ThreadingPthreads.
              * wtf/ThreadingGtk.cpp: Use a correct namespace.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30523 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      64d199ae
    • ap@webkit.org's avatar
      2008-02-23 Alexey Proskuryakov <ap@webkit.org> · ec0fdafc
      ap@webkit.org authored
              Reviewed by Darin.
      
              Move basic threading support from WebCore to WTF.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30522 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ec0fdafc
  13. 22 Feb, 2008 2 commits
    • ggaren@apple.com's avatar
      JavaScriptCore: · 5ffdb7b1
      ggaren@apple.com authored
              Reviewed by Sam Weinig.
              
              Partial fix for <rdar://problem/5744037> Gmail out of memory (17455)
              
              I'm removing KJS_MEM_LIMIT for the following reasons:
              
              - We have a few reports of KJS_MEM_LIMIT breaking important web
              applications, like GMail and Google Reader. (For example, if you
              simply open 12 GMail tabs, tab #12 will hit the limit.)
      
              - Firefox has no discernable JS object count limit, so any limit, even
              a large one, is a potential compatibility problem.
              
              - KJS_MEM_LIMIT does not protect against malicious memory allocation,
              since there are many ways to maliciously allocate memory without
              increasing the JS object count.
              
              - KJS_MEM_LIMIT is already mostly broken, since it only aborts the
              script that breaches the limit, not any subsequent scripts.
              
              - We've never gotten bug reports about websites that would have
              benefited from an unbroken KJS_MEM_LIMIT. The initial check-in of
              KJS_MEM_LIMIT (KJS revision 80061) doesn't mention a website that
              needed it.
              
              - Any website that brings you anywhere close to crashing due to the
              number of live JS objects will almost certainly put up the "slow
              script" dialog at least 20 times beforehand.
      
              * kjs/collector.cpp:
              (KJS::Collector::collect):
              * kjs/collector.h:
              * kjs/nodes.cpp:
              (KJS::TryNode::execute):
      
      LayoutTests:
      
              Reviewed by Sam Weinig.
              
              Removing the test for KJS_MEM_LIMIT, since I removed KJS_MEM_LIMIT.
      
              * fast/js/out-of-memory-expected.txt: Removed.
              * fast/js/out-of-memory.html: Removed.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30492 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5ffdb7b1
    • oliver@apple.com's avatar
      <rdar://problem/5759327> REGRESSION: while(NaN) acts like while(true) · 9c3b3ab0
      oliver@apple.com authored
      Reviewed by Alexey P.
      
      Fix yet another case where we incorrectly relied on implicit double
      to bool coercion.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@30475 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      9c3b3ab0