1. 08 May, 2011 16 commits
    • rniwa@webkit.org's avatar
      2011-05-08 Ryosuke Niwa <rniwa@webkit.org> · afbef274
      rniwa@webkit.org authored
              Reviewed by Darin Adler.
      
              Extract a DragCaretController from FrameSelection
              https://bugs.webkit.org/show_bug.cgi?id=60273
      
              Extracted CaretBase and DragCaretController from FrameSelection. CaretBase is a base class for
              DragCaretController and FrameSelection and provides functions to paint caret.
      
              Since DragCaretController doesn't need to store selection, it only holds one VisiblePosition.
      
              * WebCore.exp.in:
              * editing/FrameSelection.cpp:
              (WebCore::CaretBase::CaretBase): Added.
              (WebCore::DragCaretController::DragCaretController): Added; Set m_caretVisible true.
              (WebCore::DragCaretController::isContentRichlyEditable): Added.
              (WebCore::FrameSelection::FrameSelection): Several member variables are move to CaretBase.
              (WebCore::DragCaretController::setCaretPosition): Extracted from FrameSelection::setSelection.
              (WebCore::FrameSelection::setSelection): Removed an early exit for DragCaretController.
              (WebCore::clearRenderViewSelection): Extracted from FrameSelection::respondToNodeModification.
              (WebCore::DragCaretController::nodeWillBeRemoved): Extracted from FrameSelection::nodeWillBeRemoved
              and respondToNodeModification. Note that the position DragCaretController holds is equivalent to
              FrameSelection's base or start so when removingNodeRemovesPosition returns true for m_position,
              we used to execute the first if clause and cleared render tree selection and DOM tree selection.
              This is exactly what new DragCaretController::nodeWillBeRemoved does.
              (WebCore::FrameSelection::nodeWillBeRemoved): Simplified early exist conditions.
              (WebCore::FrameSelection::respondToNodeModification): Calls clearRenderViewSelection.
              (WebCore::CaretBase::updateCaretRect): Takes document, caretPosition, selection type, and boolean isOrphaned.
              Note that we can't obtain the document from caretPosition because VisiblePosition can be null even if
              FrameSelection's start was not null.
              (WebCore::caretRendersInsideNode): Moved; Made static local.
              (WebCore::CaretBase::caretRenderer): Extracted from FrameSelection::caretRenderer.
              (WebCore::FrameSelection::caretRenderer): Calls CaretBase::caretRenderer.
              (WebCore::DragCaretController::caretRenderer): Ditto.
              (WebCore::FrameSelection::localCaretRect): Calls updateCaretRect with extra arguments.
              (WebCore::CaretBase::absoluteBoundsForLocalRect): Moved from FrameSelection; Takes Node*.
              (WebCore::CaretBase::caretRepaintRect): Ditto.
              (WebCore::FrameSelection::recomputeCaretRect): Calls absoluteBoundsForLocalRect, caretRepaintRect,
              and shouldRepaintCaret with extra arguments.
              (WebCore::CaretBase::shouldRepaintCaret): Takes a boolean isContentEditable.
              (WebCore::FrameSelection::invalidateCaretRect): Calls CaretBase::invalidateCaretRect.
              (WebCore::CaretBase::invalidateCaretRect): Extracted from FrameSelection::invalidateCaretRect.
              (WebCore::FrameSelection::paintCaret): Calls CaretBase::paintCaret.
              (WebCore::CaretBase::paintCaret): Extracted from FrameSelection::paintCaret.
              (WebCore::FrameSelection::updateAppearance): Removed an assertion that this function is never called for
              DragCaretController.
              (WebCore::DragCaretController::paintDragCaret): Moved from FrameSelection::paintDragCaret.
              * editing/FrameSelection.h:
              (WebCore::CaretBase::localCaretRectForPainting): Added.
              (WebCore::DragCaretController::isContentEditable): Added.
              (WebCore::DragCaretController::hasCaret): Added.
              (WebCore::DragCaretController::caretPosition): Added.
              (WebCore::DragCaretController::clear): Added.
              * page/DragController.cpp:
              (WebCore::DragController::tryDocumentDrag): Uses DragCaretController.
              (WebCore::DragController::dispatchTextInputEventFor): Ditto.
              (WebCore::DragController::concludeEditDrag): Ditto.
              (WebCore::DragController::placeDragCaret): Ditto.
              * page/Page.cpp:
              (WebCore::Page::Page): Instantiates DragCaretController instead of FrameSelection.
              * page/Page.h:
              (WebCore::Page::dragCaretController): Returns DragCaretController* instead of FrameSelection*.
              * rendering/RenderBlock.cpp:
              (WebCore::RenderBlock::paintCaret): Uses FrameSelection and DragCaretController.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86039 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      afbef274
    • commit-queue@webkit.org's avatar
      2011-05-08 Sheriff Bot <webkit.review.bot@gmail.com> · 2e498e75
      commit-queue@webkit.org authored
              Unreviewed, rolling out r86037.
              http://trac.webkit.org/changeset/86037
              https://bugs.webkit.org/show_bug.cgi?id=60453
      
              broke Windows tests (Requested by jessieberlin on #webkit).
      
              * win/lib/WebKitSystemInterface.lib:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86038 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      2e498e75
    • jberlin@webkit.org's avatar
      Update the WKSI libraries. · b4a84aa9
      jberlin@webkit.org authored
      Rubber-stamped by Alice Liu.
      
      * win/lib/WebKitSystemInterface.lib:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86037 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      b4a84aa9
    • jberlin@webkit.org's avatar
      Make JSRetainPtr work with JSGlobalContextRefs. · 397c0131
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=60452
      
      Reviewed by Dan Bernstein.
      
      Add specialized functions for JSRetain and JSRelease when dealing with JSGlobalContextRefs.
      
      * API/JSRetainPtr.h:
      (JSRetain):
      (JSRelease):
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86036 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      397c0131
    • inferno@chromium.org's avatar
      2011-05-08 Abhishek Arya <inferno@chromium.org> · be1a2f5d
      inferno@chromium.org authored
              Unreviewed.
      
              More rebaselines for r86028.
      
              * platform/chromium-linux/fast/text/basic/002-expected.png:
              * platform/chromium-win/fast/text/basic/002-expected.png:
              * platform/chromium-win/fast/text/basic/002-expected.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86035 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      be1a2f5d
    • imasaki@chromium.org's avatar
      2011-05-08 Kenji Imasaki <imasaki@chromium.org> · a35cbe39
      imasaki@chromium.org authored
              Reviewed by Eric Seidel.
      
              [Chromium] add rebaseline for video-volume-slider for GPU.
              https://bugs.webkit.org/show_bug.cgi?id=60427
      
              These tests are failing due to text.
              http://code.google.com/p/chromium/issues/detail?id=81482
      
              * platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
              * platform/chromium-gpu-mac/media/video-volume-slider-expected.png:
              * platform/chromium-gpu-win/media/video-volume-slider-expected.png:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      a35cbe39
    • inferno@chromium.org's avatar
      2011-05-08 Abhishek Arya <inferno@chromium.org> · cf847613
      inferno@chromium.org authored
              Unreviewed.
      
              More chromium rebaseline for r86028.
      
              * platform/chromium-linux/css1/box_properties/float_on_text_elements-expected.png:
              * platform/chromium-linux/fast/text/justified-selection-expected.png:
              * platform/chromium-linux/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
              * platform/chromium-linux/fast/text/justify-nbsp-expected.png: Removed.
              * platform/chromium-linux/fast/text/trailing-white-space-2-expected.png:
              * platform/chromium-linux/fast/text/trailing-white-space-expected.png:
              * platform/chromium-mac-leopard/fast/text/justify-nbsp-expected.png: Removed.
              * platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
              * platform/chromium-mac/fast/text/justify-ideograph-leading-expansion-expected.txt:
              * platform/chromium-win-xp/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
              * platform/chromium-win/css1/box_properties/float_on_text_elements-expected.png:
              * platform/chromium-win/css1/box_properties/float_on_text_elements-expected.txt:
              * platform/chromium-win/fast/text/justified-selection-expected.png:
              * platform/chromium-win/fast/text/justified-selection-expected.txt:
              * platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.png: Added.
              * platform/chromium-win/fast/text/justify-ideograph-leading-expansion-expected.txt: Added.
              * platform/chromium-win/fast/text/justify-nbsp-expected.png: Added.
              * platform/chromium-win/fast/text/trailing-white-space-2-expected.png:
              * platform/chromium-win/fast/text/trailing-white-space-2-expected.txt:
              * platform/chromium-win/fast/text/trailing-white-space-expected.png:
              * platform/chromium-win/fast/text/trailing-white-space-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86033 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      cf847613
    • inferno@chromium.org's avatar
      2011-05-08 Abhishek Arya <inferno@chromium.org> · 5937a9e8
      inferno@chromium.org authored
              Unreviewed.
      
              Chromium Rebaselines for r86028.
      
              * platform/chromium-linux/css1/box_properties/clear_float-expected.png:
              * platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
              * platform/chromium-linux/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
              * platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
              * platform/chromium-linux/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
              * platform/chromium-linux/css2.1/t1602-c546-txt-align-00-b-expected.png:
              * platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
              * platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
              * platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-1-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-10-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-2-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-3-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-4-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-5-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-6-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-7-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-8-expected.png:
              * platform/chromium-linux/fast/repaint/line-flow-with-floats-9-expected.png:
              * platform/chromium-linux/fast/text/justified-selection-at-edge-expected.png:
              * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
              * platform/chromium-linux/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
              * platform/chromium-linux/tables/mozilla/marvin/x_td_align_justify-expected.png:
              * platform/chromium-linux/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
              * platform/chromium-linux/tables/mozilla/marvin/x_th_align_justify-expected.png:
              * platform/chromium-linux/tables/mozilla/marvin/x_thead_align_justify-expected.png:
              * platform/chromium-linux/tables/mozilla/marvin/x_tr_align_justify-expected.png:
              * platform/chromium-mac-leopard/css1/box_properties/clear_float-expected.png: Added.
              * platform/chromium-mac-leopard/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
              * platform/chromium-mac-leopard/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
              * platform/chromium-mac-leopard/css2.1/t1602-c546-txt-align-00-b-expected.png:
              * platform/chromium-mac-leopard/fast/multicol/float-avoidance-expected.png:
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-1-expected.png:
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-10-expected.png:
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-2-expected.png:
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-3-expected.png:
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-4-expected.png:
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-5-expected.png:
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-6-expected.png:
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-7-expected.png:
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-8-expected.png:
              * platform/chromium-mac-leopard/fast/repaint/line-flow-with-floats-9-expected.png:
              * platform/chromium-mac-leopard/fast/text/justified-selection-at-edge-expected.png:
              * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
              * platform/chromium-mac-leopard/tables/mozilla/marvin/x_td_align_justify-expected.png:
              * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
              * platform/chromium-mac-leopard/tables/mozilla/marvin/x_th_align_justify-expected.png:
              * platform/chromium-mac-leopard/tables/mozilla/marvin/x_thead_align_justify-expected.png: Added.
              * platform/chromium-mac-leopard/tables/mozilla/marvin/x_tr_align_justify-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-1-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-10-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-2-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-3-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-4-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-5-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-6-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-7-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-8-expected.png:
              * platform/chromium-mac/fast/repaint/line-flow-with-floats-9-expected.png:
              * platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
              * platform/chromium-win/css1/box_properties/clear_float-expected.png:
              * platform/chromium-win/css1/box_properties/clear_float-expected.txt:
              * platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
              * platform/chromium-win/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
              * platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
              * platform/chromium-win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
              * platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.png:
              * platform/chromium-win/css2.1/t1602-c546-txt-align-00-b-expected.txt:
              * platform/chromium-win/fast/multicol/float-avoidance-expected.png:
              * platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
              * platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
              * platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
              * platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
              * platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-1-expected.txt:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-10-expected.txt:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-2-expected.txt:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-3-expected.txt:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-4-expected.txt:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-5-expected.txt:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-6-expected.txt:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-7-expected.txt:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-8-expected.txt:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.png:
              * platform/chromium-win/fast/repaint/line-flow-with-floats-9-expected.txt:
              * platform/chromium-win/fast/text/justified-selection-at-edge-expected.png:
              * platform/chromium-win/fast/text/justified-selection-at-edge-expected.txt:
              * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
              * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
              * platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
              * platform/chromium-win/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
              * platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.png:
              * platform/chromium-win/tables/mozilla/marvin/x_td_align_justify-expected.txt:
              * platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
              * platform/chromium-win/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
              * platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.png:
              * platform/chromium-win/tables/mozilla/marvin/x_th_align_justify-expected.txt:
              * platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.png:
              * platform/chromium-win/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
              * platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.png:
              * platform/chromium-win/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86032 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      5937a9e8
    • commit-queue@webkit.org's avatar
      2011-05-08 Kamil Blank <k.blank@samsung.com> · c1c8d2b8
      commit-queue@webkit.org authored
              Reviewed by Antonio Gomes.
      
              Added new commands to be called by ewk_view_editor_command.
              Due to this change ewk_view_select_* functions have been removed.
              https://bugs.webkit.org/show_bug.cgi?id=60435
      
              * ewk/ewk_view.cpp:
              (ewk_view_execute_editor_command):
              * ewk/ewk_view.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86031 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c1c8d2b8
    • mitz@apple.com's avatar
      Updated a platform-specific expected result again after r86028. · f264dad2
      mitz@apple.com authored
      * platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f264dad2
    • mitz@apple.com's avatar
      Updated some platform-specific expected results after r86028. · c901e17c
      mitz@apple.com authored
      * platform/gtk/css1/box_properties/clear_float-expected.txt:
      * platform/gtk/css1/box_properties/float_on_text_elements-expected.txt:
      * platform/gtk/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
      * platform/gtk/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
      * platform/gtk/css2.1/t1602-c546-txt-align-00-b-expected.txt:
      * platform/gtk/fast/multicol/float-avoidance-expected.txt:
      * platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
      * platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
      * platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
      * platform/gtk/fast/text/justified-selection-at-edge-expected.txt:
      * platform/gtk/fast/text/trailing-white-space-2-expected.txt:
      * platform/gtk/svg/custom/svg-fonts-in-html-expected.txt:
      * platform/gtk/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
      * platform/gtk/tables/mozilla/marvin/x_td_align_justify-expected.txt:
      * platform/gtk/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
      * platform/gtk/tables/mozilla/marvin/x_th_align_justify-expected.txt:
      * platform/gtk/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
      * platform/gtk/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
      * platform/mac-leopard/fast/text/justify-ideograph-leading-expansion-expected.txt:
      * platform/qt/css1/box_properties/clear_float-expected.txt:
      * platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
      * platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
      * platform/qt/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
      * platform/qt/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
      * platform/qt/css2.1/t1602-c546-txt-align-00-b-expected.txt:
      * platform/qt/fast/multicol/float-avoidance-expected.txt:
      * platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
      * platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:
      * platform/qt/fast/text/justified-selection-at-edge-expected.txt:
      * platform/qt/fast/text/justify-nbsp-expected.txt:
      * platform/qt/svg/custom/svg-fonts-in-html-expected.txt:
      * platform/qt/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
      * platform/qt/tables/mozilla/marvin/x_td_align_justify-expected.txt:
      * platform/qt/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
      * platform/qt/tables/mozilla/marvin/x_th_align_justify-expected.txt:
      * platform/qt/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
      * platform/qt/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
      * platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86029 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c901e17c
    • mitz@apple.com's avatar
      <rdar://problem/9401853> REGRESSION (r78846): Insufficient expansion for... · c7a1a518
      mitz@apple.com authored
      <rdar://problem/9401853> REGRESSION (r78846): Insufficient expansion for justification when there are multiple inline boxes
      https://bugs.webkit.org/show_bug.cgi?id=60432
      
      Reviewed by Darin Adler.
      
      Source/WebCore: 
      
      * rendering/InlineTextBox.h:
      (WebCore::InlineTextBox::setExpansion): Changed back to take a int, since the m_expansion member
      variable is a (truncated) int anyway.
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::computeExpansionForJustifiedText): Changed the expansion local variable into an int
      so that the right amount is added to the total width. Also changed to use an early return.
      
      LayoutTests: 
      
      * fast/text/justify-nbsp-expected.png:
      * fast/text/justify-nbsp-expected.txt:
      * platform/mac-snowleopard/fast/text/justify-ideograph-leading-expansion-expected.txt:
      * platform/mac/css1/box_properties/clear_float-expected.png:
      * platform/mac/css1/box_properties/clear_float-expected.txt:
      * platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
      * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
      * platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
      * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
      * platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
      * platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.png:
      * platform/mac/css2.1/t1602-c546-txt-align-00-b-expected.txt:
      * platform/mac/fast/multicol/float-avoidance-expected.png:
      * platform/mac/fast/multicol/float-avoidance-expected.txt:
      * platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
      * platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
      * platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
      * platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-1-expected.png:
      * platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-10-expected.png:
      * platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-2-expected.png:
      * platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-3-expected.png:
      * platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-4-expected.png:
      * platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-5-expected.png:
      * platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-6-expected.png:
      * platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-7-expected.png:
      * platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-8-expected.png:
      * platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
      * platform/mac/fast/repaint/line-flow-with-floats-9-expected.png:
      * platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
      * platform/mac/fast/text/hyphenate-character-expected.png:
      * platform/mac/fast/text/hyphenate-character-expected.txt:
      * platform/mac/fast/text/hyphens-expected.png:
      * platform/mac/fast/text/hyphens-expected.txt:
      * platform/mac/fast/text/justified-selection-at-edge-expected.png:
      * platform/mac/fast/text/justified-selection-at-edge-expected.txt:
      * platform/mac/fast/text/justify-ideograph-leading-expansion-expected.png:
      * platform/mac/svg/custom/svg-fonts-in-html-expected.png:
      * platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
      * platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
      * platform/mac/tables/mozilla/marvin/x_tbody_align_justify-expected.txt:
      * platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.png:
      * platform/mac/tables/mozilla/marvin/x_td_align_justify-expected.txt:
      * platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
      * platform/mac/tables/mozilla/marvin/x_tfoot_align_justify-expected.txt:
      * platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.png:
      * platform/mac/tables/mozilla/marvin/x_th_align_justify-expected.txt:
      * platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.png:
      * platform/mac/tables/mozilla/marvin/x_thead_align_justify-expected.txt:
      * platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.png:
      * platform/mac/tables/mozilla/marvin/x_tr_align_justify-expected.txt:
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86028 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      c7a1a518
    • pfeldman@chromium.org's avatar
      2011-05-08 Pavel Feldman <pfeldman@chromium.org> · 7e92153c
      pfeldman@chromium.org authored
              Not reviewed: ignore 0 responses in the inspector network instrumentation.
      
              * inspector/front-end/NetworkManager.js:
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86027 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      7e92153c
    • commit-queue@webkit.org's avatar
      2011-05-08 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com> · 0c256967
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] GraphicsContext3D::getImageData() does not retrieve image data correctly
              https://bugs.webkit.org/show_bug.cgi?id=58556
      
              Tests: fast/canvas/webgl/gl-teximage.html
      
              * platform/graphics/qt/GraphicsContext3DQt.cpp:
              (WebCore::GraphicsContext3D::getImageData):
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86026 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      0c256967
    • mitz@apple.com's avatar
      Reverted unintended changes in r86024 · ca90675a
      mitz@apple.com authored
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86025 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      ca90675a
    • mitz@apple.com's avatar
      <rdar://problem/9403055> REGRESSION (r85499): Inline images in iChat overflow their chat bubbles · f9e61b3f
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=60443
      
      Reviewed by Maciej Stachowiak.
      
      Source/WebCore: 
      
      Test: fast/replaced/table-percent-height-positioned.html
      
      * rendering/RenderBox.cpp:
      (WebCore::RenderBox::computeReplacedLogicalHeightUsing): Do not apply the logic to prevent precent-height
      replaced elements from being squeezed by table cells when the replaced element is positioned (and thus
      doesn’t affect the table cell’s height).
      
      LayoutTests: 
      
      * fast/replaced/table-percent-height-positioned-expected.png: Added.
      * fast/replaced/table-percent-height-positioned-expected.txt: Added.
      * fast/replaced/table-percent-height-positioned.html: Added.
      
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86024 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      f9e61b3f
  2. 07 May, 2011 19 commits
  3. 06 May, 2011 5 commits
    • inferno@chromium.org's avatar
      2011-05-06 Abhishek Arya <inferno@chromium.org> · 6dce8237
      inferno@chromium.org authored
              Unreviewed.
      
              Forgot it since my last svg rebaseline r85981.
      
              * platform/chromium-win-xp/svg/batik/text/textFeatures-expected.png: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86000 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      6dce8237
    • inferno@chromium.org's avatar
      2011-05-06 Abhishek Arya <inferno@chromium.org> · 1790a8c0
      inferno@chromium.org authored
              Unreviewed.
      
              Chromium rebaselines for r85990
      
              * platform/chromium-linux/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
              * platform/chromium-mac-leopard/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
              * platform/chromium-mac/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
              * platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.png: Added.
              * platform/chromium-win/scrollbars/scrollbars-on-positioned-content-expected.txt: Added.
      
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85999 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      1790a8c0
    • tkent@chromium.org's avatar
      2011-05-06 Kent Tamura <tkent@chromium.org> · e6001382
      tkent@chromium.org authored
              Reviewed by Ryosuke Niwa.
      
              Eliminate WebCore/dom/InputElement.{cpp,h}
              https://bugs.webkit.org/show_bug.cgi?id=60262
      
              - Fold in all of the code of InputElement.{cpp,h} into HTMLInputElement
                and TextFieldInputType.
              - Change the return type of Node::toInputElement():
                InputElement* -> HTMLInputElement*
      
              No new tests. This change should not change the existing behaviour.
      
              * CMakeLists.txt: Remove InpuntElement.cpp and/or InputElement.h.
              * GNUmakefile.list.am: ditto.
              * WebCore.exp.in: Add symbols of functions exposed to WebKit.
              * WebCore.gypi: Remove InpuntElement.cpp and/or InputElement.h.
              * WebCore.pro: ditto.
              * WebCore.vcproj/WebCore.vcproj: ditto.
              * WebCore.xcodeproj/project.pbxproj: ditto.
              * accessibility/AXObjectCache.cpp:
              (WebCore::AXObjectCache::textMarkerDataForVisiblePosition):
                Follow the return type change of Node::toInputElement().
              * accessibility/AccessibilityRenderObject.cpp:
              (WebCore::AccessibilityRenderObject::isPasswordField): ditto.
              (WebCore::AccessibilityRenderObject::isIndeterminate): ditto.
              (WebCore::AccessibilityRenderObject::isNativeCheckboxOrRadio): ditto.
              (WebCore::AccessibilityRenderObject::isChecked): ditto.
              * css/CSSStyleSelector.cpp:
              (WebCore::CSSStyleSelector::canShareStyleWithElement): ditto.
              (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): ditto.
              * dom/CheckedRadioButtons.cpp:
              (WebCore::CheckedRadioButtons::removeButton): ditto.
              * dom/DOMAllInOne.cpp: Remove InputElement.h.
              * dom/InputElement.cpp: Removed.
              * dom/InputElement.h: Removed.
              * dom/Node.cpp:
              (WebCore::Node::toInputElement):
                Change the return type from InputElement* to HTMLInputElement*.
              * dom/Node.h: ditto.
              * html/HTMLInputElement.cpp:
              (WebCore::HTMLInputElement::HTMLInputElement):
              (WebCore::HTMLInputElement::formControlName):
              (WebCore::HTMLInputElement::tooLong):
              (WebCore::HTMLInputElement::updateFocusAppearance):
              (WebCore::HTMLInputElement::aboutToUnload):
              (WebCore::HTMLInputElement::handleFocusEvent):
              (WebCore::HTMLInputElement::handleBlurEvent):
              (WebCore::HTMLInputElement::updateType):
              (WebCore::HTMLInputElement::parseMappedAttribute):
              (WebCore::HTMLInputElement::size):
              (WebCore::HTMLInputElement::copyNonAttributeProperties):
              (WebCore::HTMLInputElement::value):
              (WebCore::HTMLInputElement::suggestedValue):
              (WebCore::HTMLInputElement::setSuggestedValue):
              (WebCore::HTMLInputElement::setValue):
              (WebCore::HTMLInputElement::setValueFromRenderer):
              (WebCore::HTMLInputElement::setFileListFromRenderer):
              (WebCore::HTMLInputElement::setDefaultName):
              (WebCore::HTMLInputElement::maxLength):
              (WebCore::HTMLInputElement::cacheSelection):
              (WebCore::formatCodes): Moved from InputElement.
              (WebCore::cursorPositionToMaskIndex): ditto.
              (WebCore::HTMLInputElement::isConformToInputMask): ditto.
              (WebCore::HTMLInputElement::validateInputMask): ditto.
              (WebCore::HTMLInputElement::setWapInputFormat): ditto.
              (WebCore::HTMLInputElement::notifyFormStateChanged): ditto.
              (WebCore::HTMLInputElement::parseMaxLengthAttribute): ditto.
              (WebCore::HTMLInputElement::updateValueIfNeeded):ditto.
              * html/HTMLInputElement.h:
                - Add data members which were defined in InputElementData.
                - Make some functions public because the public interface InputElement is removed.
                - Make some functions non-virtual because they don't override
                  corresponding virtual functions of InputElement anymore.
              (WebCore::HTMLInputElement::toInputElement):
                Follow the return type change of Node::toInputElement().
              (WebCore::HTMLInputElement::isIndeterminate):
              (WebCore::HTMLInputElement::isAutofilled):
              (WebCore::HTMLInputElement::supportsMaxLength):
              (WebCore::HTMLInputElement::cachedSelectionStart):
              (WebCore::HTMLInputElement::cachedSelectionEnd):
              * html/HTMLTextAreaElement.cpp: Remove unused InputElement.h.
              * html/InputType.cpp:
              (WebCore::InputType::handleBeforeTextInsertedEvent): Remove the code.
              * html/InputType.h: Update for the above.
              * html/TextFieldInputType.cpp:
              (WebCore::replaceEOLAndLimitLength): Moved from InputElement.cpp.
              (WebCore::TextFieldInputType::sanitizeValue): Implement with replaceEOLAndLimitLength().
              (WebCore::TextFieldInputType::handleBeforeTextInsertedEvent):
                Move the code from InputElement::handleBeforeTextInsertedEvent().
              * html/TextFieldInputType.h: Update declarations.
              * rendering/RenderTextControlSingleLine.cpp:
                - Remove ASSERT(node()->isHTMLElement()) because it is checked in the constructor.
                - Follow the return type change of inputElement().
              (WebCore::RenderTextControlSingleLine::RenderTextControlSingleLine):
                Make sure node() is an HTMLInputElement instance.
              (WebCore::RenderTextControlSingleLine::addSearchResult):
              (WebCore::RenderTextControlSingleLine::stopSearchEventTimer):
              (WebCore::RenderTextControlSingleLine::showPopup):
              (WebCore::RenderTextControlSingleLine::hidePopup):
              (WebCore::RenderTextControlSingleLine::subtreeHasChanged):
              (WebCore::RenderTextControlSingleLine::updateFromElement):
              (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
              (WebCore::RenderTextControlSingleLine::createResultsButtonStyle):
              (WebCore::RenderTextControlSingleLine::createCancelButtonStyle):
              (WebCore::RenderTextControlSingleLine::createInnerSpinButtonStyle):
              (WebCore::RenderTextControlSingleLine::createOuterSpinButtonStyle):
              (WebCore::RenderTextControlSingleLine::createSpeechButtonStyle):
              (WebCore::RenderTextControlSingleLine::visibilityForCancelButton):
              (WebCore::RenderTextControlSingleLine::startSearchEventTimer):
              (WebCore::RenderTextControlSingleLine::searchEventTimerFired):
              (WebCore::RenderTextControlSingleLine::valueChanged):
              (WebCore::RenderTextControlSingleLine::setTextFromItem):
              (WebCore::RenderTextControlSingleLine::inputElement):
              * rendering/RenderTextControlSingleLine.h:
                Change the return type of inputElement(): InputElement* -> HTMLInputElement*.
              * rendering/RenderTheme.cpp:
              (WebCore::RenderTheme::isChecked):
                Follow the return type change of Node::toInputElement().
              (WebCore::RenderTheme::isIndeterminate): ditto.
              (WebCore::RenderTheme::shouldHaveSpinButton):
                Change the parameter type: InputElement* -> HTMLInputElement*.
              * rendering/RenderTheme.h: ditto.
      2011-05-06  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Eliminate WebCore/dom/InputElement.{cpp,h}
              https://bugs.webkit.org/show_bug.cgi?id=60262
      
              * src/WebInputElement.cpp:
              (WebKit::WebInputElement::defaultMaxLength):
                Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength.
              (WebKit::toWebInputElement):
                Follow the return type change of Node::toInputElement().
      2011-05-06  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Eliminate WebCore/dom/InputElement.{cpp,h}
              https://bugs.webkit.org/show_bug.cgi?id=60262
      
              * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
              (DumpRenderTreeSupportGtk::setAutofilled):
                Follow the return type change of Node::toInputElement().
              (DumpRenderTreeSupportGtk::setValueForUser): ditto.
      2011-05-06  Kent Tamura  <tkent@chromium.org>
      
              Reviewed by Ryosuke Niwa.
      
              Eliminate WebCore/dom/InputElement.{cpp,h}
              https://bugs.webkit.org/show_bug.cgi?id=60262
      
              * Api/qwebpage.cpp:
              (QWebPage::inputMethodQuery):
                Replace InputElement::s_maximumLength with HTMLInputElement::maximumLength.
              * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
              (DumpRenderTreeSupportQt::setAutofilled):
                Follow the return type change of Node::toInputElement().
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85998 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      e6001382
    • abarth@webkit.org's avatar
      2011-05-06 Adam Barth <abarth@webkit.org> · bd0c7751
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Implement "Report-Only" mode for CSP
              https://bugs.webkit.org/show_bug.cgi?id=60402
      
              * http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/report-only.html: Added.
      2011-05-06  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Implement "Report-Only" mode for CSP
              https://bugs.webkit.org/show_bug.cgi?id=60402
      
              This mode lets web sites try out CSP by getting violation reports (and
              console spam) without actually changing the behavior of their web sites.
      
              Test: http/tests/security/contentSecurityPolicy/report-only.html
      
              * dom/Document.cpp:
              (WebCore::Document::processHttpEquiv):
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::didBeginDocument):
              * page/ContentSecurityPolicy.cpp:
              (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
              (WebCore::ContentSecurityPolicy::didReceiveHeader):
              (WebCore::ContentSecurityPolicy::reportViolation):
              (WebCore::ContentSecurityPolicy::checkInlineAndReportViolation):
              (WebCore::ContentSecurityPolicy::checkEvalAndReportViolation):
              (WebCore::ContentSecurityPolicy::checkSourceAndReportViolation):
              (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
              * page/ContentSecurityPolicy.h:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85993 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      bd0c7751
    • imasaki@chromium.org's avatar
      2011-05-06 Kenji Imasaki <imasaki@chromium.org> · 588a3d48
      imasaki@chromium.org authored
              Reviewed by David Levin.
      
              [Chromium] Add rebaseline to chromium for video-layer.
              https://bugs.webkit.org/show_bug.cgi?id=60423
      
              These expected files are produced by the rebaseline tool.
              http://code.google.com/p/chromium/issues/detail?id=81833
      
              * platform/chromium-linux/fast/layers/video-layer-expected.png:
              * platform/chromium-mac-leopard/fast/layers/video-layer-expected.png:
              * platform/chromium-mac/fast/layers/video-layer-expected.png:
              * platform/chromium-mac/fast/layers/video-layer-expected.txt:
              * platform/chromium-win/fast/layers/video-layer-expected.png:
              * platform/chromium-win/fast/layers/video-layer-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: http://svn.webkit.org/repository/webkit/trunk@85992 268f45cc-cd09-0410-ab3c-d52691b4dbfc
      588a3d48